[Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Sep 10 14:29:19 CEST 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Well.. all the exceptions thrown by Koha::Email->create are around invalid
email addresses so I'm not entirely comfortable with 'Unknown error'.. that
kinda feels like "Give up now" to me whereas the actual fix is fairly simple.

Problem is.. we don't, yet, pass the 'fields' param in the BadParameter
exceptions that are thrown and I'm not sure we've got a field in the messages
table to hold that data anyway to pass it to the template.

So.. all in all.. I dunno.  Personally, we have the patch in production now on
all our servers without your follow-up.. and find it helpful.

I also don't really think this needs to require either of the depends. Yes,
they help to reduce the times it'll get thrown, but this patch eliminates a
vital issue whereby sending ANY massages in the queue can be thwarted by one
bad email address server wide.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list