[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Sep 10 18:10:32 CEST 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124781
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124781&action=edit
Bug 27032: Move auto renewal code out of CanBookBeRenewed

This moves the checks related to whether auto renewal can be done on
the checkout to its own function _CanBookBeAutoRenewed(). This makes
it more clear which parts of the code are related to auto renewal
checking and which are not.

To test:
  1) Make sure prove t/db_dependent/Circulation.t still passes

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Rebased-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list