[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |joonas.kylmala at iki.fi

--- Comment #19 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
This breaks the existing links in the format:

localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=&branch_group_limit=multibranchlimit-1&weight_search=1

i.e. where branch_group_limit is used. Let's not break the links suddenly as
they might be someone's bookmarks or shared online. So please fix the code in
opac/opac-search.pl to not produce multibranch query params from
branch_group_limit param and leave a note that branch_group_limit is deprecated
and should not be used.

The code I'm talking about is in the following if block:

> my $branch_group_limit = $cgi->param("branch_group_limit");
> if ( $branch_group_limit ) {

-- 
You are receiving this mail because:
You are watching all bug changes.