[Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sat Sep 11 13:05:06 CEST 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124637|0                           |1
        is obsolete|                            |
 Attachment #124638|0                           |1
        is obsolete|                            |

--- Comment #9 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124793
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124793&action=edit
Bug 28927: Fix id opacmainuserblock used twice in OPAC

Since preference OpacMainUserBlock is an HTML customization, there is an HTML
tags with id="opacmainuserblock" and one with id="OpacMainUserBlock".

I think template block "koha_news_block" should add a class (lowercase) instead
of an id.
It fixes the bug and also it may be used several times in same page in the
future.

Test plan :
1) Create an HTML customization for OpacMainUserBlock with some text
2) Go to OPAC main page
3) Check HTML code of the page
4) Check you see class="opacmainuserblock" and not id="OpacMainUserBlock"

https://bugs.koha-community.org/show_bug.cgi?id=28927

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Rebased-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list