[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #21 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Sorry for not doing very good job the first time reviewing, I found now
additional issue:

The buildQuery function in C4/Search.pm is modified by "Bug 28847: Move
SearchLimitLibrary code to QueryBuilder Modules", it however leaves dead code
in the else section "if ($this_limit =~ /^branch:(.+)/) {". That should be
completely removed, and also we can see from that that the new regex condition
added doesn't match as carefully the limit parameter.

-- 
You are receiving this mail because:
You are watching all bug changes.