[Koha-bugs] [Bug 28895] Don't fill in items.location with NewItemsDefaultLocation if blank

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28895

--- Comment #5 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Actually, testing this on master this morning it's very much not working as
intended.

I have NewItemsDefaultLocation set to PROC.
On additem.pl, when I create a load the new item page, location is
automatically set to PROC. If I create my item without changing it, the item
has both location and shelving_location set to PROC.
There is no reason to set the default to PROC here, but I guess it doesn't hurt
anything.

On additem.pl, if I change the shelving location to any value other than PROC
before I create my item, both the location and permanent location are set to
whatever new value I've selected.
Whatever I've selected should go into permanent_location, but location should
be PROC.

If I delete PROC without selecting something else on creating my item, then
location and permanent_location end up as PROC anyway.
This bug asserts that in this case I should get location=PROC and
permanent_location=NULL. I support that change.

This could debatably be a new bug, but there are a lot of old bugs around this
syspref already.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.