[Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC patron entry

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi
             Status|Signed Off                  |Failed QA

--- Comment #6 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
(In reply to Hayley Pelham from comment #5)
> Created attachment 124852 [details] [review]
> Bug 28934: Correct markup of GDPR consent in OPAC patron entry
> 
> This patch makes changes to the markup around the GDPR consent checkbox
> in the OPAC self-registration / update page to make it more consistent
> with other form fields on the page.
> 
> The patch also adds some missing attributes which are required to enable
> JavaScript validation of the checkbox.
> 
> To test, apply the patch and rebuild the OPAC CSS
> (https://wiki.koha-community.org/wiki/
> Working_with_SCSS_in_the_OPAC_and_staff_client).
> 
> - Go to Administration -> System preferences and Enable the system
>   preference PatronSelfRegistration.
> - Set the system preference GDPR_Policy to "Enforce".
> - Go to the OPAC and click the "Register here" link.
> - Under the "GDPR consent" heading near the bottom of the page,
>   confirm that the "I agree" checkbox lines up with other form fields on
>   the page, and that the "Required" label lines up below it.
> - Submit the form without checking the GDPR consent checkbox.
> - The form should not be submitted, and a "This field is
>   required" message should appear next to the checkbox label.
> 
> Signed-off-by: Hayley Pelham <hayleypelham at catalyst.net.nz>

The alignment is still slightly off with this patch, noticable if you put the
cursor to the input box above and then use down arrow to scroll to the
checkbox. Also, I would prefer we would use consistent way to show the fields,
i.e. always label and then the input form, this would make the alignment
perfect as well. The gender field has also the same problem. I could send a
patch to fix both of them.

-- 
You are receiving this mail because:
You are watching all bug changes.