[Koha-bugs] [Bug 28832] Batch modification always clears permanent_location if it is mapped in frameworks

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123982|0                           |1
        is obsolete|                            |

--- Comment #6 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 125076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125076&action=edit
Bug 28832: Don't batch modify fields that we don't update

In bug 27837 we made sure to always pass through the permanent_location if it
was passed in unlike
other fields which are not passed if they have no value.
During batch mod, however, fields that aren't editied have no value, so forcing
permanent_location
to pass through forces blanking it.

This patch alters the script to only pass thgouhr for edit the fields that have
been updated or
cleared.

To test:
 1 - In frameworks add a new subfield to 952, "C" - make it editable in items
tab and visible in intranet/editor
 2 - In mappings map that subfield to items.permanent_location
 3 - Set an item to have differing shelving location and permanent_location
 4 - This saves correctly for an individual item
 5 - Edit the item using Tools->batch item modification, updating the note
field
 6 - Note the permanet_location is removed
 7 - Check the DB, the field is set to NULL
 8 - Apply patch
 9 - Repeat
10 - Permanent location is not cleared
11 - Verify that clearing fields works as before, including permanent_location

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Deb Stephenson <dstephen at dubuque.lib.ia.us>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.