[Koha-bugs] [Bug 28338] Validate item holdability and pickup location separately

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28338

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #19 from David Cook <dcook at prosentient.com.au> ---
Just a little comment on this one. 

On "koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt", the function
"check(table)" should really be "check(form)" because it's the form element
#hold-request-form passed in rather than the table element.

It would make more sense to do "check(form)" and then do something like "let
table = form.find('#requestspecific');"

And then when searching through the table, you could do input[name="checkitem"]
rather than input[type="radio"], so that it's more specific. (I say this as
someone who works on bug 15565 though, so that's just me being demanding :p)

Hopefully I'll make the above changes via bug 15565 some day down the line, but
figured I'd note them here anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.