[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #64 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
If I apply patches from this bug (27945) and the ones from bug 27944 I am
getting the following failures:

t/db_dependent/ArticleRequests.t .. 22/55 
    #   Failed test 'Limit is 1, so patron cannot request more articles'
    #   at t/db_dependent/ArticleRequests.t line 292. 
    #          got: '1'  
    #     expected: '0'                                                         

    #   Failed test 'There is still an AR, so patron cannot request more
articles'
    #   at t/db_dependent/ArticleRequests.t line 309. 
    #          got: '1'
    #     expected: '0'

    #   Failed test 'There is still one article request'
    #   at t/db_dependent/ArticleRequests.t line 310. 
    #          got: '2'
    #     expected: '1'

    #   Failed test 'A new AR was created, so patron cannot request more
articles'
    #   at t/db_dependent/ArticleRequests.t line 329. 
    #          got: '1'
    #     expected: '0'

    #   Failed test 'There are 2 article requests'
    #   at t/db_dependent/ArticleRequests.t line 330. 
    #          got: '3'
    #     expected: '2'

    #   Failed test 'There is an old AR but not completed or cancelled, so
patron cannot request more articles'
    #   at t/db_dependent/ArticleRequests.t line 347. 
    #          got: '1'
    #     expected: '0'

    #   Failed test 'There are 3 current article requests'
    #   at t/db_dependent/ArticleRequests.t line 348. 
    #          got: '4'
    #     expected: '3'
    # Looks like you planned 13 tests but ran 12.
    # Looks like you failed 7 tests of 12 run.
t/db_dependent/ArticleRequests.t .. 55/55 
#   Failed test 'article request limit'
#   at t/db_dependent/ArticleRequests.t line 350.

There are 3 PQA bugs related to article requests (bug 27944, bug 27945 and bug
27947). Please make sure they don't conflict with each others and that the
tests pass.

-- 
You are receiving this mail because:
You are watching all bug changes.