[Koha-bugs] [Bug 29043] Items are prcoessed but not displayed on request.pl before a patron is selected

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi

--- Comment #3 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
I think this makes the code harder to understand by adding one more indentation
layer to the giant loop. Could I propose that in this outer loop "foreach my
$biblionumber (@biblionumbers) {" all the non-patron requiring code comes first
and calls next unless we have a $patron? This way we we are not adding in all
the different places calls to if ($patron) but only in one place. This would
help also to make the multi-holds work for clubs – bug 29117.

If anyhow other people think it is okay to go with the patch here then "my
$items_any_available;" and the comment above it should be inside the loop as
well, and probably the outer loop should also actually be in this if condition.

-- 
You are receiving this mail because:
You are watching all bug changes.