[Koha-bugs] [Bug 29106] Can we get rid of Koha::Item->effective_itemtype

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29106

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Marcel de Rooy from comment #1)
> sub effective_itemtype {
>     my ( $self ) = @_;
> 
>     my $pref = C4::Context->preference('item-level_itypes');
>     if ( $pref && $self->itype() ) {
>         return $self->itype();
>     } else {
>         warn "item-level_itypes set but no itemtype set for item
> (".$self->itemnumber.")"
>           if $pref;
>         return $self->biblioitemnumber()->itemtype();
>     }
> }
> 
> This sub c/should be moved out of the DBIx schema file to Koha::Item ?
> There is no need to warn each time imo.

I think it should be moved to the object. That method was added to the DBIC
class before Koha::Object(s) existed!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.