[Koha-bugs] [Bug 29106] Can we get rid of Koha::Item->effective_itemtype

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29106

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Tomás Cohen Arazi from comment #3)
> When I said we send a warning to the logs, I meant we are telling the users
> their data is wrong. It implies that the user needs to fix that.
> Implicitly, we are telling people they need to set a value there.
> 
> Can't we force that somehow? And set the 'effective item type' on a DBRev
> instead? It feels like it was a trasitional step, for a transition that
> never took place.

It would be better to have a Koha data linter tool for sure. Maybe we should
move this check to the about page, considering we have other checks of this
nature there.

The reason the warning is there is because itemtype is required for Koha to
operate correctly. It can be set at either the item or the bib level. That's
why that warning ended up where it is. However, unless somebody is routinely
combing through the logs that warning will go unnoticed. It seems more sensible
to remove the warning there and add a check to the about page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.