[Koha-bugs] [Bug 23678] Cancel holds in bulk

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com
             Status|Passed QA                   |In Discussion

--- Comment #24 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
1. I don't understand why we pass patron_name when we have the patron_id (same
for biblio_title).
If you modify the patron's name, the name won't match.

If you cannot do it now, you may need Koha::BackgroundJob->additional_report
from "Bug 28445: Add the capability to provide more info to the background job
detail view"

2.
+            push @messages, {
+                type => 'error',
+                code => 'hold_not_cancelled',
+                patron_id => defined $patron?$patron->borrowernumber:'',
+                patron_name => defined
$patron?($patron->firstname?$patron->firstname.', ':'').$patron->surname:'',
+                biblio_id => defined $biblio?$biblio->biblionumber:'',
+                biblio_title => defined $biblio?$biblio->title:'',
+                hold_id => $hold_id,
+                error => defined $hold?($@ ? $@ : 0):'No hold with id
'.$hold_id.' found',
+            };

Erk, spaces, indentation? I can fix that.

-- 
You are receiving this mail because:
You are watching all bug changes.