[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #64 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
1. Not blocker, but:
-    my ( $self, $notes ) = @_;
+    my ( $self, $cancellation_reason, $notes ) = @_;

You should have used a hashref, especially because we have Koha::Hold->cancel
that is getting a reason as well:

my $cancel_hold = $hold->cancel(
    {
        [ charge_cancel_fee => 1||0, ]
        [ cancellation_reason => $cancellation_reason, ]
    }
);

-- 
You are receiving this mail because:
You are watching all bug changes.