[Koha-bugs] [Bug 27944] Add new stages to the article request process

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #84 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
1. Missing POD in Koha::ArticleRequest

2. Koha::ArticleRequest->request is not covered by tests

3. Changes to Koha::ArticleRequest->cancel are not covered by tests

4. Koha::ArticleRequests->requested is not covered by tests

4. Not a big deal (not blocker of course) but
  $reason = $av->lib_opac ? $av->lib_opac : $av->lib if $av;
Is more readable (IMO) like:
  $reason = $av->lib_opac || $av->lib if $av;

-- 
You are receiving this mail because:
You are watching all bug changes.