From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 00:02:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Mar 2022 22:02:52 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_30425=5D_New=3A_April_fools!?= Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30425 Bug ID: 30425 Summary: April fools! Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: victor at tuxayo.net QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Many possibilities, for example: ponies! 🎠 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 00:06:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Mar 2022 22:06:32 +0000 Subject: [Koha-bugs] [Bug 30425] April fools! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30425 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Summary|April fools! |April fools! Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 00:07:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Mar 2022 22:07:26 +0000 Subject: [Koha-bugs] [Bug 30425] April fools! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30425 --- Comment #1 from Victor Grousset/tuxayo --- Created attachment 132812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132812&action=edit Bug 30425: April fools Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 00:07:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Mar 2022 22:07:47 +0000 Subject: [Koha-bugs] [Bug 30425] April fools! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30425 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 00:12:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Mar 2022 22:12:28 +0000 Subject: [Koha-bugs] [Bug 30425] April fools! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30425 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #2 from Victor Grousset/tuxayo --- We need to ship and deploy it quick. Trivial patch, dependency is libre (MIT License), straight pass QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 01:02:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Mar 2022 23:02:12 +0000 Subject: [Koha-bugs] [Bug 30426] New: suggestion service missing Auth and Output imports Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30426 Bug ID: 30426 Summary: suggestion service missing Auth and Output imports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org While most scripts have been updated to import specific functions from C4::Auth and C4::Output, /opac/svc/suggestion missed those, which means calls to it generate 500 errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 01:03:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Mar 2022 23:03:59 +0000 Subject: [Koha-bugs] [Bug 30426] suggestion service missing Auth and Output imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30426 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 01:04:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Mar 2022 23:04:04 +0000 Subject: [Koha-bugs] [Bug 30426] suggestion service missing Auth and Output imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30426 --- Comment #1 from David Cook --- Created attachment 132813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132813&action=edit Bug 30426: Add missing C4::Auth and C4::Output imports This patch adds missing function imports for C4::Auth and C4::Output in the opac/svc/suggestion script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 01:04:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Mar 2022 23:04:17 +0000 Subject: [Koha-bugs] [Bug 30426] suggestion service missing Auth and Output imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30426 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 01:05:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Mar 2022 23:05:53 +0000 Subject: [Koha-bugs] [Bug 30426] suggestion service missing Auth and Output imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30426 --- Comment #2 from David Cook --- Test plan: 1. Go to http://localhost:8081/cgi-bin/koha/admin/didyoumean.pl 2. Turn on some plugins 3. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 4. Note in your browser's Network tab that the call to http://localhost:8080/cgi-bin/koha/svc/suggestion?render=stub&q=test generates a 200 response instead of a 500 error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 01:06:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Mar 2022 23:06:58 +0000 Subject: [Koha-bugs] [Bug 30426] suggestion service missing Auth and Output imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30426 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 [Bug 17600] Standardize the EXPORT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 01:06:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Mar 2022 23:06:58 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30426 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30426 [Bug 30426] suggestion service missing Auth and Output imports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 01:41:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Mar 2022 23:41:14 +0000 Subject: [Koha-bugs] [Bug 7750] Release notes for stable releases should be in Master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7750 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #4 from David Cook --- (In reply to Katrin Fischer from comment #3) > I am not sure how this could be solved, but it probably needs to be part of > the release workflow, pulling the release notes created until a certain > moment in. It looks like release notes are included in misc/release_notes now, so this one is probably invalid. However, it looks like only Koha 3.x release notes are added into Debian packages... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 01:42:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Mar 2022 23:42:33 +0000 Subject: [Koha-bugs] [Bug 30427] New: Debian packages only include release notes for Koha 3.x Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30427 Bug ID: 30427 Summary: Debian packages only include release notes for Koha 3.x Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org If you look in /usr/share/doc/koha-common, you'll only see release notes for Koha 3.x It looks like it's because of the following line in the debian/ packaging instructions: debian/koha-common.docs:misc/release_notes/release_notes_3*.txt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 04:46:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 02:46:11 +0000 Subject: [Koha-bugs] [Bug 27783] Add handling for 'Queues' in the background job queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 --- Comment #11 from David Cook --- (In reply to Tomás Cohen Arazi from comment #10) > The 'turtle' queue name was put to make it obvious what I meant. > But it is cool too <.< I laughed. I like it haha. (In reply to Tomás Cohen Arazi from comment #9) > I was reading the code and thinking how plugin-generated tasks could fit > here. And with the current approach, I was leaning into adding > 'plugin-real-time' and 'plugin-long-running' queues on top of this. But the > need to have 4 running workers sounds like too much... You wouldn't need to have 4 running workers though, since a worker can subscribe to multiple queues. Regardless of the implementation, I am keen to get plugin-generated tasks into Koha. > What about having: > > * 'real-time' > * 'turtle' Personally, I would prefer more granularity and configurability, but this does sound like a pragmatic compromise. Another benefit of having "real-time" and "turtle" would be that adding more background tasks should have a lower barrier to entry, since you'd just need to provide a class for the worker to use and an interface for enqueuing tasks. (I've been concerned that people haven't been taking advantage of the background tasks because they weren't sure how to work with it.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 04:47:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 02:47:56 +0000 Subject: [Koha-bugs] [Bug 27783] Add handling for 'Queues' in the background job queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 --- Comment #12 from David Cook --- (In reply to David Cook from comment #11) > Another benefit of having "real-time" and "turtle" would be that adding more > background tasks should have a lower barrier to entry, since you'd just need > to provide a class for the worker to use and an interface for enqueuing > tasks. (I've been concerned that people haven't been taking advantage of the > background tasks because they weren't sure how to work with it.) Admittedly, I've wanted to use the background tasks for local customizations, but the current amount of customization required of core Koha::BackgroundJob code has made me avoid it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 04:54:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 02:54:42 +0000 Subject: [Koha-bugs] [Bug 30410] Add a way for plugins to register background tasks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 07:47:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 05:47:48 +0000 Subject: [Koha-bugs] [Bug 12285] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 --- Comment #29 from Emmi Takkinen --- (In reply to Kyle M Hall from comment #28) > t/db_dependent/Members/FineSlip.t is failing Tested and tests pass fine. Could you take a look where it exactly fails for you? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 08:45:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 06:45:43 +0000 Subject: [Koha-bugs] [Bug 2222] Field auth_subfield_structure.frameworkcode should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2222 --- Comment #3 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #2) > Could there be a use case for multiple frameworks for an auth_type or would > that not work anyway? That does not work. An authtype is a framework. I am not aware of a realistic use case for this scenario. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:04:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 07:04:30 +0000 Subject: [Koha-bugs] [Bug 30428] New: Simplify authorities/merge_ajax.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30428 Bug ID: 30428 Summary: Simplify authorities/merge_ajax.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Looking at this script within the context of bug 2222. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:10:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 07:10:48 +0000 Subject: [Koha-bugs] [Bug 30428] Simplify authorities/merge_ajax.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30428 --- Comment #1 from Marcel de Rooy --- Funny older commit: From: Marcel de Rooy Date: Wed, 22 Jul 2015 14:19:09 +0200 Subject: [PATCH] Bug 14588: Simplify merge_ajax.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:10:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 07:10:58 +0000 Subject: [Koha-bugs] [Bug 30428] Simplify authorities/merge_ajax.pl again In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30428 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Simplify |Simplify |authorities/merge_ajax.pl |authorities/merge_ajax.pl | |again -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:17:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 07:17:49 +0000 Subject: [Koha-bugs] [Bug 30360] Add helper methods to Koha::BackgroundJobs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au, | |julian.maurice at biblibre.com | |, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:19:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 07:19:53 +0000 Subject: [Koha-bugs] [Bug 30410] Add a way for plugins to register background tasks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 132814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132814&action=edit Bug 30410: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:19:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 07:19:57 +0000 Subject: [Koha-bugs] [Bug 30410] Add a way for plugins to register background tasks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 132815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132815&action=edit Bug 30410: Add a way for plugins to expose tasks they implement This patch implements a mechanism for plugins to tell Koha they implement background jobs, by returning a mapping ``` task => class ``` * _task_ is a string that will be used when queueing new tasks, to let the workers know which class to instantiate to launch the job (a.k.a. process). * _class_ is a string for a class name. For this to work, plugins need to include the 'namespace' attribute in their metadata. If they don't, they will be skipped when listing the valid _background jobs_. After this, high-level methods for letting plugins (easily) enqueue their tasks will be provided. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Plugins/BackgroundJob.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:24:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 07:24:52 +0000 Subject: [Koha-bugs] [Bug 27783] Add handling for 'Queues' in the background job queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 --- Comment #13 from Tomás Cohen Arazi --- (In reply to David Cook from comment #11) > > You wouldn't need to have 4 running workers though, since a worker can > subscribe to multiple queues. Well, that's the point. You need to set special workers using the .pl script instead of koha-worker, etc... so it complicates things. This is what I valued the most when looking at this patchset. > Another benefit of having "real-time" and "turtle" would be that adding more > background tasks should have a lower barrier to entry, since you'd just need > to provide a class for the worker to use and an interface for enqueuing > tasks. (I've been concerned that people haven't been taking advantage of the > background tasks because they weren't sure how to work with it.) Look at the follow-up bugs and bug 30360 for ideas. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:26:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 07:26:50 +0000 Subject: [Koha-bugs] [Bug 20424] New UNIMARC ZEBRA indexes according to last IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119034|0 |1 is obsolete| | --- Comment #16 from Alex Arnaud --- Created attachment 132816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132816&action=edit Bug 20424: Add new zebra indexes for the last IFLA updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:27:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 07:27:20 +0000 Subject: [Koha-bugs] [Bug 20424] New UNIMARC ZEBRA indexes according to last IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119080|0 |1 is obsolete| | --- Comment #17 from Alex Arnaud --- Created attachment 132817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132817&action=edit Bug 20424: (Followup) Add new zebra indexes for the last IFLA updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:27:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 07:27:55 +0000 Subject: [Koha-bugs] [Bug 20424] New UNIMARC ZEBRA indexes according to last IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119081|0 |1 is obsolete| | Attachment #132663|0 |1 is obsolete| | --- Comment #18 from Alex Arnaud --- Created attachment 132818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132818&action=edit Bug 20424: provides biblio-zebra-indexdefs.xsl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:35:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 07:35:50 +0000 Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:36:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 07:36:50 +0000 Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on fresh install, but can be null with upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com |ity.org | CC| |julian.maurice at biblibre.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:37:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 07:37:01 +0000 Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on fresh install, but can be null with upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253 --- Comment #3 from Julian Maurice --- Created attachment 132819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132819&action=edit Bug 27253: Fix definition of updated_on in borrowers and deletedborrowers Test plan: 1. First you have to be in a state where updated_on is NULL-able. You can do that by either: a) do a fresh install of Koha 16.05 and update to master, or b) execute the following SQL queries: ALTER TABLE borrowers MODIFY updated_on timestamp NULL DEFAULT current_timestamp() ON UPDATE current_timestamp() COMMENT 'time of last change could be useful for synchronization with external systems (among others)' ALTER TABLE deletedborrowers MODIFY updated_on timestamp NULL DEFAULT current_timestamp() ON UPDATE current_timestamp() COMMENT 'time of last change could be useful for synchronization with external systems (among others)' 2. Create two borrowers (let's name them X and Y) 3. Delete borrower Y 4. Set the column updated_on to NULL for both borrowers by executing the following SQL query: UPDATE borrowers SET updated_on = NULL WHERE borrowernumber = UPDATE deletedborrowers SET updated_on = NULL WHERE borrowernumber = 5. Apply patch and run updatedatabase 6. Verify that borrowers.updated_on and deletedborrowers.updated_on are not NULL-able. Verify that updated_on for X and Y have taken the value of dateenrolled. 7. Repeat step 2 to 6 but this time renew the patron and/or log in with its account in order to set the columns borrowers.date_renewed and borrowers.lastseen before executing updatedatabase borrowers.updated_on should take the greatest value among dateenrolled, date_renewed, and lastseen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:37:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 07:37:26 +0000 Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on fresh install, but can be null with upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:39:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 07:39:17 +0000 Subject: [Koha-bugs] [Bug 26003] Could the holds queue be live rather than built via cron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26003 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #11 from Martin Renvoize --- *** This bug has been marked as a duplicate of bug 29346 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:39:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 07:39:17 +0000 Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #16 from Martin Renvoize --- *** Bug 26003 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:39:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 07:39:31 +0000 Subject: [Koha-bugs] [Bug 30378] Convert about page tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30378 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:39:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 07:39:38 +0000 Subject: [Koha-bugs] [Bug 30378] Convert about page tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30378 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132323|0 |1 is obsolete| | --- Comment #2 from Séverine Queune --- Created attachment 132820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132820&action=edit Bug 30378: Convert about page tabs to Bootstrap This patch updates the about page to use Bootstrap tabs instead of jQueryUI. The patch also makes a minor HTML correction for validity. To test, apply the patch and go to the about page in the staff interface. Test that the tabs look correct and work correctly. Signed-off-by: Séverine Queune -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:41:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 07:41:01 +0000 Subject: [Koha-bugs] [Bug 30378] Convert about page tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30378 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr --- Comment #3 from Séverine Queune --- Nice, thanks Owen ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:49:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 07:49:06 +0000 Subject: [Koha-bugs] [Bug 30389] Switch to Bootstrap tabs on the page for adding orders from MARC file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:49:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 07:49:11 +0000 Subject: [Koha-bugs] [Bug 30389] Switch to Bootstrap tabs on the page for adding orders from MARC file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132359|0 |1 is obsolete| | --- Comment #2 from Séverine Queune --- Created attachment 132821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132821&action=edit Bug 30389: Switch to Bootstrap tabs on the page for adding orders from MARC file This patch updates addorderiso2709.tt so that it uses Bootstrap tabs intead of jQuery. The patch contains indentation changes, so diff accordingly. To test apply the patch and go to Acquisitions -> Vendor -> Basket -> Add to basket -> From a staged file. - Click "Add orders" next to the staged file you want to use. - On the "Add orders" page, test that the tabs work correctly. Signed-off-by: Séverine Queune -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:50:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 07:50:10 +0000 Subject: [Koha-bugs] [Bug 30389] Switch to Bootstrap tabs on the page for adding orders from MARC file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr --- Comment #3 from Séverine Queune --- Really nice Owen ! The alignment of the first tab is really better with the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:57:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 07:57:37 +0000 Subject: [Koha-bugs] [Bug 30423] Convert authority merge page tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30423 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:57:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 07:57:43 +0000 Subject: [Koha-bugs] [Bug 30423] Convert authority merge page tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30423 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132803|0 |1 is obsolete| | --- Comment #2 from Séverine Queune --- Created attachment 132822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132822&action=edit Bug 30423: Convert authority merge page tabs to Bootstrap This patch updates the authority merge page to use Bootstrap tabs instead of jQueryUI. To test, apply the patch go to Authorities in the staff interface. - Perform an authority search which will return more than one authority record. - On the results page, click Actions -> Merge for two authority records. - Click "Next" after selecting a merge reference. - On the next page you should see two tabs under "Source records." Confirm that they work correctly. - Confirm that tag and subfield selection still works correctly. Signed-off-by: Séverine Queune -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:59:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2022 07:59:54 +0000 Subject: [Koha-bugs] [Bug 24161] Add ability to track the claim dates of later orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #73 from Katrin Fischer --- I am not sure if the database for this one works correctly. It looks like the timestamp was always set to the 'update date' instead of the last known claim date as it should have been. :(
$DBversion = '19.12.00.085';
if( CheckVersion( $DBversion ) ) {
    unless ( TableExists( 'aqorders_claims' ) ) {
        $dbh->do(q|
            CREATE TABLE aqorders_claims (
                id int(11) AUTO_INCREMENT,
                ordernumber INT(11) NOT NULL,
                claimed_on TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP,
                PRIMARY KEY (id),
                CONSTRAINT aqorders_claims_ibfk_1 FOREIGN KEY (ordernumber)
REFERENCES aqorders (ordernumber) ON DELETE CASCADE ON UPDATE CASCADE
            ) ENGINE = InnoDB DEFAULT CHARSET = utf8mb4 COLLATE =
utf8mb4_unicode_ci
        |);

        my $orders = $dbh->selectall_arrayref(q|
            SELECT ordernumber, claims_count, claimed_date
            FROM aqorders
            WHERE claims_count > 0
        |, { Slice => {} });
        my $insert_claim_sth = $dbh->prepare(q|
            INSERT INTO aqorders_claims (ordernumber, claimed_on)
            VALUES (?,?)
        |);

        for my $order ( @$orders ) {
            for my $claim (1..$order->{claims_count}) {
                $insert_claim_sth->execute($order->{ordernumber},
$order->{claimed_on});
            }
        }

        $dbh->do(q|ALTER TABLE aqorders DROP COLUMN claims_count, DROP COLUMN
claimed_date|);
    }

    NewVersion( $DBversion, 24161, "Add new join table aqorders_claims to keep
track of claims");
}

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 10:00:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 08:00:32 +0000
Subject: [Koha-bugs] [Bug 30423] Convert authority merge page tabs to
 Bootstrap
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30423

Séverine Queune  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

--- Comment #3 from Séverine Queune  ---
Everything works as expected, and no more gap on the left of the first tab.
Thank you Owen !

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 10:04:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 08:04:48 +0000
Subject: [Koha-bugs] [Bug 30419] Convert authority detail page tabs to
 Bootstrap
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30419

Séverine Queune  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 10:04:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 08:04:52 +0000
Subject: [Koha-bugs] [Bug 30419] Convert authority detail page tabs to
 Bootstrap
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30419

Séverine Queune  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132793|0                           |1
        is obsolete|                            |

--- Comment #2 from Séverine Queune  ---
Created attachment 132823
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132823&action=edit
Bug 30419: Convert authority detail page tabs to Bootstrap

This patch updates the authority detail page to use Bootstrap tabs
instead of jQueryUI.

The patch also removes some broken JavaScript. It will be re-implemented
in Bug 30422.

To test, apply the patch search for an authority record in the
authorities module.

View the detail page for the authority and test that the tabs look
correct and work correctly.

Signed-off-by: Séverine Queune 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 10:09:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 08:09:55 +0000
Subject: [Koha-bugs] [Bug 30345] Koha::BackgroundJob->enqueue should set
 borrowernumber=undef if no userenv
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345

Arthur Suzuki  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 10:09:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 08:09:59 +0000
Subject: [Koha-bugs] [Bug 30345] Koha::BackgroundJob->enqueue should set
 borrowernumber=undef if no userenv
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345

Arthur Suzuki  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132243|0                           |1
        is obsolete|                            |
 Attachment #132244|0                           |1
        is obsolete|                            |

--- Comment #5 from Arthur Suzuki  ---
Created attachment 132824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132824&action=edit
Bug 30345: Regression tests

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Arthur Suzuki 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 10:10:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 08:10:15 +0000
Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
 using Koha::BackgroundJob
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344

Arthur Suzuki  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |30345


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345
[Bug 30345] Koha::BackgroundJob->enqueue should set borrowernumber=undef if no
userenv
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 10:10:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 08:10:15 +0000
Subject: [Koha-bugs] [Bug 30345] Koha::BackgroundJob->enqueue should set
 borrowernumber=undef if no userenv
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345

Arthur Suzuki  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |27344


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
[Bug 27344] Implement Elastic's update_index_background using
Koha::BackgroundJob
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 10:10:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 08:10:46 +0000
Subject: [Koha-bugs] [Bug 30345] Koha::BackgroundJob->enqueue should set
 borrowernumber=undef if no userenv
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345

--- Comment #6 from Arthur Suzuki  ---
Created attachment 132825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132825&action=edit
Bug 30345: Make Koha::BackgroundJob->enqueue set borrowernumber=undef if no
userenv

This patch makes ->enqueue set undef if no userenv is provided. The CLI
scripts will usually use Koha::Script and have this set to undef as
well, but on the tests, there's usually no userenv set unless we need to
test it. And as we are adding triggers everywhere, that will schedule
background jobs, it means we would end up mocking userenv or the
->enqueue method everywhere and it will get messy.

This patch just make it set undef.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/BackgroundJob.t
=> FAIL: Wow, it explodes badly. Same as any test that happens to
trigger a background job enqueuing.
3. Apply this patch
4. Repeat 2
=> SUCCESS: Great, tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Arthur Suzuki 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 10:11:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 08:11:46 +0000
Subject: [Koha-bugs] [Bug 30417] Switch to Bootstrap tabs on the basic
 library transfer limit page
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30417

Séverine Queune  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 10:11:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 08:11:51 +0000
Subject: [Koha-bugs] [Bug 30417] Switch to Bootstrap tabs on the basic
 library transfer limit page
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30417

Séverine Queune  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132758|0                           |1
        is obsolete|                            |

--- Comment #2 from Séverine Queune  ---
Created attachment 132826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132826&action=edit
Bug 30417: Switch to Bootstrap tabs on the basic library transfer limit page

This patch updates the basic library transfer limits  page to use
Bootstrap tabs instead of jQueryUI.

To test, apply the patch and go to Administraion -> Library transfer
limits.

Test that the tabs look correct and work correctly. The functionality of
the page should be unchanged.

Signed-off-by: Séverine Queune 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 10:13:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 08:13:22 +0000
Subject: [Koha-bugs] [Bug 30417] Switch to Bootstrap tabs on the basic
 library transfer limit page
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30417

Séverine Queune  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

--- Comment #3 from Séverine Queune  ---
Works perfectly, well done Owen !

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 10:26:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 08:26:24 +0000
Subject: [Koha-bugs] [Bug 20424] New UNIMARC ZEBRA indexes according to last
 IFLA updates
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424

Koha Team University Lyon 3  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #19 from Koha Team University Lyon 3  ---
Hi,
We tested it on a kohadevbox.
We tried all the indexes.
It works.
Thanks :-)
Sonia

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 10:31:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 08:31:14 +0000
Subject: [Koha-bugs] [Bug 20424] New UNIMARC ZEBRA indexes according to last
 IFLA updates
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424

Koha Team University Lyon 3  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93732|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 10:31:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 08:31:32 +0000
Subject: [Koha-bugs] [Bug 20424] New UNIMARC ZEBRA indexes according to last
 IFLA updates
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424

Koha Team University Lyon 3  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93733|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 10:31:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 08:31:52 +0000
Subject: [Koha-bugs] [Bug 20424] New UNIMARC ZEBRA indexes according to last
 IFLA updates
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424

Koha Team University Lyon 3  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93736|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 10:32:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 08:32:34 +0000
Subject: [Koha-bugs] [Bug 20424] New UNIMARC ZEBRA indexes according to last
 IFLA updates
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424

sandboxes at biblibre.com  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132816|0                           |1
        is obsolete|                            |

--- Comment #20 from sandboxes at biblibre.com  ---
Created attachment 132827
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132827&action=edit
Bug 20424: Add new zebra indexes for the last IFLA updates

Signed-off-by: Sonia 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 10:32:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 08:32:39 +0000
Subject: [Koha-bugs] [Bug 20424] New UNIMARC ZEBRA indexes according to last
 IFLA updates
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424

sandboxes at biblibre.com  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132817|0                           |1
        is obsolete|                            |

--- Comment #21 from sandboxes at biblibre.com  ---
Created attachment 132828
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132828&action=edit
Bug 20424: (Followup) Add new zebra indexes for the last IFLA updates

Signed-off-by: Sonia 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 10:32:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 08:32:43 +0000
Subject: [Koha-bugs] [Bug 20424] New UNIMARC ZEBRA indexes according to last
 IFLA updates
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424

sandboxes at biblibre.com  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132818|0                           |1
        is obsolete|                            |

--- Comment #22 from sandboxes at biblibre.com  ---
Created attachment 132829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132829&action=edit
Bug 20424: provides biblio-zebra-indexdefs.xsl

Signed-off-by: Sonia 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 10:50:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 08:50:37 +0000
Subject: [Koha-bugs] [Bug 30406] Our DT tables not filtering on the correct
 column if hidden by default
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30406

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com
                   |ity.org                     |
             Status|NEW                         |ASSIGNED
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 10:50:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 08:50:57 +0000
Subject: [Koha-bugs] [Bug 30406] Our DT tables not filtering on the correct
 column if hidden by default
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30406

--- Comment #1 from Julian Maurice  ---
Created attachment 132830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132830&action=edit
Bug 30406: Add column filters before hiding columns

The code that adds column filters works only on visible columns, so we
should hide columns after filters are created

Test plan:
1. Apply patch
2. Go to Tables settings. Hide city_state for the cities table.
3. Create some cities and go to the cities page
4. Verify that filtering works as expected.
5. Make the city_state column appear. Verify that filtering on this
   column works too

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 11:02:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 09:02:20 +0000
Subject: [Koha-bugs] [Bug 30406] Our DT tables not filtering on the correct
 column if hidden by default
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30406

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 11:26:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 09:26:05 +0000
Subject: [Koha-bugs] [Bug 27619] Remove fr-FR installer data
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #2 from Marcel de Rooy  ---
This did not move recently.
On bug 2222 I want to remove auth_subfield_structure.frameworkcode.
That gives a lot of changes in especially the fr-FR SQL files.
Would you support doing that first ?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 11:30:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 09:30:24 +0000
Subject: [Koha-bugs] [Bug 30429] New: Empty searchbox when there is one
 result
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30429

            Bug ID: 30429
           Summary: Empty searchbox when there is one result
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: severine.queune at bulac.fr
        QA Contact: testopia at bugs.koha-community.org

When you perform a search that brings a unique result, the searched terms are
kept in the search box which can be useful in some cases but when you scan
barcode all day, it's quite annoying to delete the previous search before
searching the new one.
As the string '&found1=1' is added at the end of url, would it be possible to
empty the searchbox in that specific case ?
It saw it was introduced by Bug 23475 that asks precisely for the opposite
behaviour and that I sign it, but now we have this in production, I realise
it's not ergonomic at all for my colleagues.
Maybe a (new...) syspref to let each library choose the favourite behaviour ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 11:32:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 09:32:07 +0000
Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
 using Koha::BackgroundJob
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=27783                   |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 11:32:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 09:32:07 +0000
Subject: [Koha-bugs] [Bug 27783] Add handling for 'Queues' in the background
 job queue
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=27344                   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 11:37:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 09:37:11 +0000
Subject: [Koha-bugs] [Bug 30430] New: UNIMARC XSLT : displaying field B_214
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430

            Bug ID: 30430
           Summary: UNIMARC XSLT : displaying field B_214
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: MARC Bibliographic data support
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fpichenot at ville-roubaix.fr
        QA Contact: testopia at bugs.koha-community.org

We need to update XSLT files to display new UNIMARC B_214 field.
See
https://cdn.ifla.org/wp-content/uploads/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u_b_214_update2019_online_final.pdf

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 11:37:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 09:37:47 +0000
Subject: [Koha-bugs] [Bug 30430] UNIMARC XSLT : displaying field B_214
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430

François Pichenot  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thibault.keromnes at univ-pari
                   |                            |s8.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 11:48:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 09:48:08 +0000
Subject: [Koha-bugs] [Bug 30431] New: Register personal details on OPAC
 create empty modification requets
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30431

            Bug ID: 30431
           Summary: Register personal details on OPAC create empty
                    modification requets
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: severine.queune at bulac.fr
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Created attachment 132831
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132831&action=edit
Empty modification request

As there is no 'Cancel' option on 'your personal details' on OPAC, most patrons
going on this page click on 'Submit changes'.
Problem is when OPACPatronDetails is enabled, a validation is required even
thought no modifications are made in the account.
It can be quite time consuming to validate these non-modifications.
Could we imagine a way to avoid this task ?
For example an 'auto-validation' when no datas are present in the
borrower_modifications table ?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 11:52:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 09:52:59 +0000
Subject: [Koha-bugs] [Bug 30421] Error 500 while trying to put a hold on a
 record
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30421

Arthur Suzuki  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

--- Comment #1 from Arthur Suzuki  ---
That was due to data on a record not being in the proper format.
After removing the publication date (210d and 211a) the issue didn't appear
anymore.
Not a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 11:59:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 09:59:25 +0000
Subject: [Koha-bugs] [Bug 2222] Field auth_subfield_structure.frameworkcode
 should be removed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2222

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Large patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 11:59:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 09:59:29 +0000
Subject: [Koha-bugs] [Bug 2222] Field auth_subfield_structure.frameworkcode
 should be removed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2222

--- Comment #4 from Marcel de Rooy  ---
Created attachment 132832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132832&action=edit
Bug 2222: Adjust kohastructure

Test plan:
See next patch.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 11:59:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 09:59:33 +0000
Subject: [Koha-bugs] [Bug 2222] Field auth_subfield_structure.frameworkcode
 should be removed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2222

--- Comment #5 from Marcel de Rooy  ---
Created attachment 132833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132833&action=edit
Bug 2222: Adjust SQL en marc21/unimarc yml and sql file

Test plan:
Run a new install for en/marc21 testing the yml file.
I tested the unimarc sql file as follows:
    (sql) delete from auth_subfield_structure; delete from auth_tag_structure;
delete from auth_types;
    (bash) mysql -h YOUR_HOST -p YOUR_CLONE < FILE_NAME

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 11:59:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 09:59:38 +0000
Subject: [Koha-bugs] [Bug 2222] Field auth_subfield_structure.frameworkcode
 should be removed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2222

--- Comment #6 from Marcel de Rooy  ---
Created attachment 132834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132834&action=edit
Bug 2222: Adjust SQL fr-FR Obligatoire file authorities_normal_marc21.sql

Test plan:
I tested this sql script as follows:
    (sql) delete from auth_subfield_structure; delete from auth_tag_structure;
delete from auth_types;
    (bash) mysql -h YOUR_HOST -p YOUR_CLONE < FILE_NAME

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 11:59:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 09:59:42 +0000
Subject: [Koha-bugs] [Bug 2222] Field auth_subfield_structure.frameworkcode
 should be removed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2222

--- Comment #7 from Marcel de Rooy  ---
Created attachment 132835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132835&action=edit
Bug 2222: Adjust SQL fr-FR unimarc complet Obligatoire default

I tested this sql script as follows:
    (sql) delete from auth_subfield_structure; delete from auth_tag_structure;
delete from auth_types;
    (bash) mysql -h YOUR_HOST -p YOUR_CLONE < FILE_NAME

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 11:59:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 09:59:46 +0000
Subject: [Koha-bugs] [Bug 2222] Field auth_subfield_structure.frameworkcode
 should be removed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2222

--- Comment #8 from Marcel de Rooy  ---
Created attachment 132836
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132836&action=edit
Bug 2222: Adjust SQL fr-FR unimarc complete Obligatoire norme

This is a large file where frameworkcode is not the last field in each row.
So harder to replace since the contents of the last field varies.
Awaiting migration to yaml, I chose here to add and drop the column ;)

Test plan:
I tested this sql script as follows:
    (sql) delete from auth_subfield_structure; delete from auth_tag_structure;
delete from auth_types;
    (bash) mysql -h YOUR_HOST -p YOUR_CLONE < FILE_NAME

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 11:59:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 09:59:50 +0000
Subject: [Koha-bugs] [Bug 2222] Field auth_subfield_structure.frameworkcode
 should be removed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2222

--- Comment #9 from Marcel de Rooy  ---
Created attachment 132837
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132837&action=edit
Bug 2222: Adjust SQL fr-FR unimarc lecture Obligatoire norme

I tested the sql file as follows:
    (sql) delete from auth_subfield_structure; delete from auth_tag_structure;
delete from auth_types;
    (bash) mysql -h YOUR_HOST -p YOUR_CLONE < FILE_NAME

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 11:59:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 09:59:54 +0000
Subject: [Koha-bugs] [Bug 2222] Field auth_subfield_structure.frameworkcode
 should be removed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2222

--- Comment #10 from Marcel de Rooy  ---
Created attachment 132838
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132838&action=edit
Bug 2222: Database revision

Test plan:
Run updatedatabase.pl on existing data.
Check database columns.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 11:59:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 09:59:58 +0000
Subject: [Koha-bugs] [Bug 2222] Field auth_subfield_structure.frameworkcode
 should be removed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2222

--- Comment #11 from Marcel de Rooy  ---
Created attachment 132839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132839&action=edit
Bug 2222: Modify C4::AuthoritiesMarc::GetTagsLabels and callers

We adjust two callers here to rename the parameter from framework
to authtypecode in order to prevent confusion.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:00:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:00:20 +0000
Subject: [Koha-bugs] [Bug 2222] Field auth_subfield_structure.frameworkcode
 should be removed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2222

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:00:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:00:40 +0000
Subject: [Koha-bugs] [Bug 2222] Field auth_subfield_structure.frameworkcode
 should be removed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2222

--- Comment #12 from Marcel de Rooy  ---
Still needs some attention; work in progress

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:03:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:03:01 +0000
Subject: [Koha-bugs] [Bug 2222] Field auth_subfield_structure.frameworkcode
 should be removed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2222

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132838|0                           |1
        is obsolete|                            |

--- Comment #13 from Marcel de Rooy  ---
Created attachment 132840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132840&action=edit
Bug 2222: Database revision

Test plan:
Run updatedatabase.pl on existing data.
Check database columns.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:03:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:03:06 +0000
Subject: [Koha-bugs] [Bug 2222] Field auth_subfield_structure.frameworkcode
 should be removed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2222

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132839|0                           |1
        is obsolete|                            |

--- Comment #14 from Marcel de Rooy  ---
Created attachment 132841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132841&action=edit
Bug 2222: Modify C4::AuthoritiesMarc::GetTagsLabels and callers

We adjust two callers here to rename the parameter from framework
to authtypecode in order to prevent confusion.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:04:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:04:09 +0000
Subject: [Koha-bugs] [Bug 2222] Field auth_subfield_structure.frameworkcode
 should be removed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2222

--- Comment #15 from Marcel de Rooy  ---
TODO Lost my merge_ajax changes somewhere ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:28:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:28:27 +0000
Subject: [Koha-bugs] [Bug 29999] Replace the use of jQueryUI tabs on
 authorized values administration page
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29999

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:28:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:28:28 +0000
Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
Bug 29226 depends on bug 29999, which changed state.

Bug 29999 Summary: Replace the use of jQueryUI tabs on authorized values administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29999

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:28:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:28:28 +0000
Subject: [Koha-bugs] [Bug 29998] Replace the use of jQueryUI tabs on item
 types administration page
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998
Bug 29998 depends on bug 29999, which changed state.

Bug 29999 Summary: Replace the use of jQueryUI tabs on authorized values administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29999

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:29:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:29:17 +0000
Subject: [Koha-bugs] [Bug 29998] Replace the use of jQueryUI tabs on item
 types administration page
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |kyle at bywatersolutions.com
             Status|Pushed to master            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:29:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:29:17 +0000
Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
Bug 29226 depends on bug 29998, which changed state.

Bug 29998 Summary: Replace the use of jQueryUI tabs on item types administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:29:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:29:35 +0000
Subject: [Koha-bugs] [Bug 30316] Replace the use of jQueryUI tabs on MARC
 detail page
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30316

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:29:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:29:36 +0000
Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
Bug 29226 depends on bug 30316, which changed state.

Bug 30316 Summary: Replace the use of jQueryUI tabs on MARC detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30316

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:29:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:29:50 +0000
Subject: [Koha-bugs] [Bug 30317] Replace the use of jQueryUI tabs on search
 history page
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30317

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |kyle at bywatersolutions.com
             Status|Pushed to master            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:29:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:29:50 +0000
Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
Bug 29226 depends on bug 30317, which changed state.

Bug 30317 Summary: Replace the use of jQueryUI tabs on search history page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30317

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:30:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:30:09 +0000
Subject: [Koha-bugs] [Bug 30227] Replace the use of jQueryUI tabs on
 bibliographic detail page
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30227

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:30:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:30:09 +0000
Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
Bug 29226 depends on bug 30227, which changed state.

Bug 30227 Summary: Replace the use of jQueryUI tabs on bibliographic detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30227

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:31:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:31:05 +0000
Subject: [Koha-bugs] [Bug 24221] Convert OPACMySummaryNote system preference
 to news block
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:31:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:31:06 +0000
Subject: [Koha-bugs] [Bug 26050] [OMNIBUS] Convert system preferences to
 news block
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26050
Bug 26050 depends on bug 24221, which changed state.

Bug 24221 Summary: Convert OPACMySummaryNote system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:33:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:33:48 +0000
Subject: [Koha-bugs] [Bug 28416] Email::Sender::Transport::SMTP is using
 10Mo of RAM
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28416

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
                 CC|                            |kyle at bywatersolutions.com
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:33:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:33:49 +0000
Subject: [Koha-bugs] [Bug 28410] Reduce memory footprint
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
Bug 28410 depends on bug 28416, which changed state.

Bug 28416 Summary: Email::Sender::Transport::SMTP is using 10Mo of RAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28416

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:36:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:36:22 +0000
Subject: [Koha-bugs] [Bug 29103] reserves.desk_id for desk of waiting hold
 only updates when printing new hold slip
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.05.00                    |22.05.00,21.11.05
        released in|                            |
                 CC|                            |kyle at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #8 from Kyle M Hall  ---
Pushed to 21.11.x for 21.11.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:37:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:37:00 +0000
Subject: [Koha-bugs] [Bug 30251] With IndependentBranches
 non-superlibrarians do not get autocomplete list in circulation module
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30251

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.05.00                    |22.05.00,21.11.05
        released in|                            |
                 CC|                            |kyle at bywatersolutions.com

--- Comment #7 from Kyle M Hall  ---
Pushed to 21.11.x for 21.11.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:38:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:38:26 +0000
Subject: [Koha-bugs] [Bug 30244] Hide lost items not respected in OPAC
 results XSLT
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30244

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.05.00                    |22.05.00,21.11.05
        released in|                            |
                 CC|                            |kyle at bywatersolutions.com

--- Comment #6 from Kyle M Hall  ---
Pushed to 21.11.x for 21.11.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:39:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:39:20 +0000
Subject: [Koha-bugs] [Bug 30276] Web-based installer failing on db upgrade
 for 30060
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30276

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |kyle at bywatersolutions.com
             Status|Pushed to master            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:40:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:40:15 +0000
Subject: [Koha-bugs] [Bug 30194] Update required JSON::Validator version
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:40:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:40:16 +0000
Subject: [Koha-bugs] [Bug 25796] Allow REST API to use external OAuth2
 authorization server
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25796
Bug 25796 depends on bug 30194, which changed state.

Bug 30194 Summary: Update required JSON::Validator version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:40:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:40:16 +0000
Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
Bug 29810 depends on bug 30194, which changed state.

Bug 30194 Summary: Update required JSON::Validator version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:40:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:40:16 +0000
Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make
 them use the REST API routes
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055
Bug 30055 depends on bug 30194, which changed state.

Bug 30194 Summary: Update required JSON::Validator version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 12:40:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 10:40:17 +0000
Subject: [Koha-bugs] [Bug 30408] API and OpenAPI versions should be string
 in spec
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30408
Bug 30408 depends on bug 30194, which changed state.

Bug 30194 Summary: Update required JSON::Validator version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 13:05:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 11:05:25 +0000
Subject: [Koha-bugs] [Bug 27783] Add handling for 'Queues' in the background
 job queue
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |27344
         Depends on|27344                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
[Bug 27344] Implement Elastic's update_index_background using
Koha::BackgroundJob
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 13:05:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 11:05:25 +0000
Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
 using Koha::BackgroundJob
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|27783                       |
         Depends on|                            |27783


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
[Bug 27783] Add handling for 'Queues' in the background job queue
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 13:06:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 11:06:03 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add handling for 'Queues'   |Introduce background job
                   |in the background job queue |queues

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 13:06:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 11:06:56 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com
         Depends on|                            |30345


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345
[Bug 30345] Koha::BackgroundJob->enqueue should set borrowernumber=undef if no
userenv
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 13:06:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 11:06:56 +0000
Subject: [Koha-bugs] [Bug 30345] Koha::BackgroundJob->enqueue should set
 borrowernumber=undef if no userenv
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |27783


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
[Bug 27783] Introduce background job queues
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 13:09:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 11:09:38 +0000
Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
 using Koha::BackgroundJob
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 13:09:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 11:09:41 +0000
Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
 using Koha::BackgroundJob
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132794|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 13:09:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 11:09:44 +0000
Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
 using Koha::BackgroundJob
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132795|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 13:09:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 11:09:50 +0000
Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
 using Koha::BackgroundJob
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132796|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 13:09:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 11:09:53 +0000
Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
 using Koha::BackgroundJob
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132797|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 13:09:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 11:09:56 +0000
Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
 using Koha::BackgroundJob
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132798|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 13:33:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 11:33:11 +0000
Subject: [Koha-bugs] [Bug 30430] UNIMARC XSLT : displaying field B_214
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430

Arthur Suzuki  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 13:33:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 11:33:16 +0000
Subject: [Koha-bugs] [Bug 30430] UNIMARC XSLT : displaying field B_214
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430

--- Comment #1 from Arthur Suzuki  ---
Created attachment 132842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132842&action=edit
Bug 30430: UNIMARC XSLT add field B214 display

test plan :
- Apply patch
- Find a record with a B214
- Check on both Opac-Details and Opac-Result that the field is displayed.
- Do the same checks on catalogue/search results and catalogue/details
in Staff interface.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:00:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:00:46 +0000
Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
 using Koha::BackgroundJob
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344

--- Comment #43 from Tomás Cohen Arazi  ---
Created attachment 132843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132843&action=edit
Bug 27344: Implement Elastic's update_index_background using
Koha::BackgroundJob

This patch adds a background job submodule, UpdateElasticIndex, to deal
with async ES index update (not the deletion).

Using NYTProf (on a checkin):
Without
618ms, executing 35676 statements and 26355 subroutine calls in 266 source
files and 83 string evals.

With
521ms, executing 13282 statements and 7979 subroutine calls in 195 source files
and 26 string evals.

However there are some problems with this patch:
1. We don't want *all* the index update to be in the background_jobs
tabtle (we could add a filter on the list view)
2. We don't track the "progress" of the job as we are sending all the
records to Elastic. It is okish in my opinion but it must be noted.

Signed-off-by: Arthur Suzuki 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:00:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:00:54 +0000
Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
 using Koha::BackgroundJob
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344

--- Comment #44 from Tomás Cohen Arazi  ---
Created attachment 132844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132844&action=edit
Bug 27344: Add missing include file

Signed-off-by: Arthur Suzuki 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:00:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:00:59 +0000
Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
 using Koha::BackgroundJob
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344

--- Comment #45 from Tomás Cohen Arazi  ---
Created attachment 132845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132845&action=edit
Bug 27344: Adapt to bug 30181 changes

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:02:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:02:14 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:02:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:02:18 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132649|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:02:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:02:20 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132650|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:02:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:02:23 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132651|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:03:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:03:19 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

--- Comment #14 from Tomás Cohen Arazi  ---
Created attachment 132846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132846&action=edit
Bug 27783: Add --job-type to background_jobs_worker.pl

This will let sysop adjust the number of workers and how they want to
manage them.
For instance one could want to have one worker for ES indexation and
another worker for other jobs, to prevent ES index to be stuck behind
bigger batch process.

Signed-off-by: Arthur Suzuki 
Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:03:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:03:25 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

--- Comment #15 from Tomás Cohen Arazi  ---
Created attachment 132847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132847&action=edit
Bug 27783: Replace --job-type by --queue

This patch adds a new column background_jobs.queue, which default to
'default'
By default, new jobs are enqueued into this default queue, and the
background job worker will subscribe to the default queue unless told
otherwise by the --job-queue option

The new job UpdateElasticIndex is automatically enqueued in another
queue named 'index'
So you can have 'default' worker with
    misc/background_jobs_worker.pl
and a dedicated indexing worker with
    misc/background_jobs_worker.pl --queue index

This is to address bug 27344 comment #15

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:03:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:03:32 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

--- Comment #16 from Tomás Cohen Arazi  ---
Created attachment 132848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132848&action=edit
Bug 27783: Add missing atomicupdate file

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:03:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:03:37 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

--- Comment #17 from Tomás Cohen Arazi  ---
Created attachment 132849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132849&action=edit
Bug 27783: (follow-up) Add DB change to installer

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:03:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:03:42 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

--- Comment #18 from Tomás Cohen Arazi  ---
Created attachment 132850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132850&action=edit
Bug 27783: Rename queues and adjust currently defined jobs

This patch renames the queues so the default is the **real-time** one, and
the other (*turtle*) is kept for **slow** tasks.

All current *batch* tasks are explicitly assigned to the **turtle**
queue as well.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:05:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:05:43 +0000
Subject: [Koha-bugs] [Bug 30345] Koha::BackgroundJob->enqueue should set
 borrowernumber=undef if no userenv
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:06:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:06:27 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

--- Comment #19 from Tomás Cohen Arazi  ---
Ok, after several talks at the hackfest, everyone agreed we should (or not
opposed to) reverse the dependency to keep things clearer. I took on the task
of rebasing, reorganizing things, etc keeping the attribution of the original
patches.

To put it clear, this *should* only be lacking what it already lacked of:
integration with koha-worker so both worker processes are launched by default
to .deb install users.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:09:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:09:14 +0000
Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|30345                       |27783


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
[Bug 27783] Introduce background job queues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345
[Bug 30345] Koha::BackgroundJob->enqueue should set borrowernumber=undef if no
userenv
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:09:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:09:14 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29346


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
[Bug 29346] Add real-time holds queue update option
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:09:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:09:14 +0000
Subject: [Koha-bugs] [Bug 30345] Koha::BackgroundJob->enqueue should set
 borrowernumber=undef if no userenv
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|29346                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
[Bug 29346] Add real-time holds queue update option
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:09:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:09:50 +0000
Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
 using Koha::BackgroundJob
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|30345                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345
[Bug 30345] Koha::BackgroundJob->enqueue should set borrowernumber=undef if no
userenv
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:09:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:09:50 +0000
Subject: [Koha-bugs] [Bug 30345] Koha::BackgroundJob->enqueue should set
 borrowernumber=undef if no userenv
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|27344                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
[Bug 27344] Implement Elastic's update_index_background using
Koha::BackgroundJob
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:10:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:10:36 +0000
Subject: [Koha-bugs] [Bug 17841] Can't use indexname "acqdate,
 st-date-normalized" in keyword search
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17841

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #2 from Katrin Fischer  ---
Frido, that took a while, but it works, I think also with ge at the end in
20.11.

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:11:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:11:45 +0000
Subject: [Koha-bugs] [Bug 30345] Koha::BackgroundJob->enqueue should set
 borrowernumber=undef if no userenv
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:11:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:11:48 +0000
Subject: [Koha-bugs] [Bug 30345] Koha::BackgroundJob->enqueue should set
 borrowernumber=undef if no userenv
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132824|0                           |1
        is obsolete|                            |
 Attachment #132825|0                           |1
        is obsolete|                            |

--- Comment #7 from Kyle M Hall  ---
Created attachment 132851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132851&action=edit
Bug 30345: Regression tests

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Arthur Suzuki 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:12:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:12:01 +0000
Subject: [Koha-bugs] [Bug 30360] Add helper methods to Koha::BackgroundJobs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |27344


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
[Bug 27344] Implement Elastic's update_index_background using
Koha::BackgroundJob
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:12:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:12:01 +0000
Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
 using Koha::BackgroundJob
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |30360


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360
[Bug 30360] Add helper methods to Koha::BackgroundJobs
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:24:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:24:33 +0000
Subject: [Koha-bugs] [Bug 30345] Koha::BackgroundJob->enqueue should set
 borrowernumber=undef if no userenv
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132851|0                           |1
        is obsolete|                            |

--- Comment #8 from Kyle M Hall  ---
Created attachment 132852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132852&action=edit
Bug 30345: Regression tests

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Arthur Suzuki 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:24:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:24:44 +0000
Subject: [Koha-bugs] [Bug 30345] Koha::BackgroundJob->enqueue should set
 borrowernumber=undef if no userenv
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345

--- Comment #9 from Kyle M Hall  ---
Created attachment 132853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132853&action=edit
Bug 30345: Make Koha::BackgroundJob->enqueue set borrowernumber=undef if no
userenv

This patch makes ->enqueue set undef if no userenv is provided. The CLI
scripts will usually use Koha::Script and have this set to undef as
well, but on the tests, there's usually no userenv set unless we need to
test it. And as we are adding triggers everywhere, that will schedule
background jobs, it means we would end up mocking userenv or the
->enqueue method everywhere and it will get messy.

This patch just make it set undef.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/BackgroundJob.t
=> FAIL: Wow, it explodes badly. Same as any test that happens to
trigger a background job enqueuing.
3. Apply this patch
4. Repeat 2
=> SUCCESS: Great, tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Arthur Suzuki 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:26:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:26:47 +0000
Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use
 Font Awesome icons
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:26:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:26:51 +0000
Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use
 Font Awesome icons
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132376|0                           |1
        is obsolete|                            |
 Attachment #132377|0                           |1
        is obsolete|                            |

--- Comment #22 from Kyle M Hall  ---
Created attachment 132854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132854&action=edit
Bug 29066: Remove text in OPAC search form and use Font Awesome icons

In modern front-end websites, first think you see in header region is an large
input text with a search icon.
No need to say it is a search form.
We still tell it in 'title' attribut for accessibility.

This patch removes 'Search' text.
If 'my library first' feature is enabled, shows a text in title of a
question mark icon.
In submit button, replaces 'Go' with a seach icon and add title
'Search'.

Test plan :
1)
1.1) Set system preferences :
  OpacAddMastheadLibraryPulldown to 'Add'
  SearchMyLibraryFirst to 'Don't limit'
1.2) Go to OPAC main page
1.3) You don't see 'Search' anymore
1.4) You see in submit button an icon
1.5) Move mouse over submit button to see tooltip text 'Search'
2)
2.1) Set system preferences :
  OpacAddMastheadLibraryPulldown to 'Don't add'
  SearchMyLibraryFirst to 'Limit'
2.2) Go to OPAC main page
2.3) Log in
2.4) You don't see text 'Search (in ) only'
2.5) You see a question mark icon
2.6) Move mouse over submit button to see tooltip text 'Search (in ) only'

Signed-off-by: Samu Heiskanen 

Signed-off-by: Lucas Gass 

Signed-off-by: Katrin Fischer 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:27:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:27:05 +0000
Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use
 Font Awesome icons
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066

--- Comment #23 from Kyle M Hall  ---
Created attachment 132855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132855&action=edit
Bug 29066: (follow-up) add aria-label and aria-hidden on icons

Signed-off-by: Lucas Gass 

Signed-off-by: Katrin Fischer 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:29:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:29:54 +0000
Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373

--- Comment #8 from Thibault Keromnès  ---
Tested with Arthur's git on a sandbox. 
First tests (comments #1, #2 and #3) worked well (we have Default, ACQ, FA and
Authorities frameworks)

Test on comment #4 failed, we couldn't install a new language. 
"misc/translation/translate create xx-YY" didn't create
"misc/translation/po/xx-YY-installer-UNIMARC.po"

On the default framework itself it looks really good, we just think it'd be
better not to collapse the following fields : 
001 
010$d
020 
021  
106 
3XX 
4XX 
5XX 
8XX 
9XX
We imported all authorities types, it's great, thanks a lot.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:30:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:30:55 +0000
Subject: [Koha-bugs] [Bug 30378] Convert about page tabs to Bootstrap
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30378

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:30:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:30:59 +0000
Subject: [Koha-bugs] [Bug 30378] Convert about page tabs to Bootstrap
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30378

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132820|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall  ---
Created attachment 132856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132856&action=edit
Bug 30378: Convert about page tabs to Bootstrap

This patch updates the about page to use Bootstrap tabs instead of
jQueryUI.

The patch also makes a minor HTML correction for validity.

To test, apply the patch and go to the about page in the staff
interface.

Test that the tabs look correct and work correctly.

Signed-off-by: Séverine Queune 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:33:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:33:35 +0000
Subject: [Koha-bugs] [Bug 30350] Do not hardcode job types
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30350

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:35:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:35:36 +0000
Subject: [Koha-bugs] [Bug 30350] Do not hardcode job types
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30350

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:35:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:35:39 +0000
Subject: [Koha-bugs] [Bug 30350] Do not hardcode job types
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30350

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132298|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall  ---
Created attachment 132857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132857&action=edit
Bug 30350: Avoid hardcoding job types in background_jobs_worker.pl

Currently, background_jobs_worker.pl has a hardcoded list of jobs it can
process. Koha::BackgroundJob already has a method that can be used to
extract such list. Using it would avoid having to maintain two lists,
and it would also make it easier to inject plugin tasks as well.

To test:
1. Apply the patch
2. Restart the koha-worker
3. Run one of the batch operations that make use of the background jobs
   (I used batch item delete)
=> SUCCESS: Things work, no change
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

JD amended patch
-my @job_types = keys %{Koha::BackgroundJob::type_to_class_mapping};
+my @job_types = keys %{Koha::BackgroundJob::type_to_class_mapping()};
To remove the following error:
Ambiguous use of %{Koha::BackgroundJob::type_to_class_mapping} resolved to
%Koha::BackgroundJob::type_to_class_mapping
Signed-off-by: Jonathan Druart 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:36:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:36:41 +0000
Subject: [Koha-bugs] [Bug 30417] Switch to Bootstrap tabs on the basic
 library transfer limit page
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30417

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:39:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:39:26 +0000
Subject: [Koha-bugs] [Bug 30417] Switch to Bootstrap tabs on the basic
 library transfer limit page
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30417

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:39:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:39:30 +0000
Subject: [Koha-bugs] [Bug 30417] Switch to Bootstrap tabs on the basic
 library transfer limit page
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30417

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132826|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall  ---
Created attachment 132858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132858&action=edit
Bug 30417: Switch to Bootstrap tabs on the basic library transfer limit page

This patch updates the basic library transfer limits  page to use
Bootstrap tabs instead of jQueryUI.

To test, apply the patch and go to Administraion -> Library transfer
limits.

Test that the tabs look correct and work correctly. The functionality of
the page should be unchanged.

Signed-off-by: Séverine Queune 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:41:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:41:33 +0000
Subject: [Koha-bugs] [Bug 30398] Reindent invoices template
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:41:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:41:37 +0000
Subject: [Koha-bugs] [Bug 30398] Reindent invoices template
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132788|0                           |1
        is obsolete|                            |
 Attachment #132789|0                           |1
        is obsolete|                            |

--- Comment #8 from Kyle M Hall  ---
Created attachment 132859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132859&action=edit
Bug 30398: Reindent invoices template

This patch updates the invoices template so that the indentation is
consistent.

To test, apply the patch and go to Acquisitions.

- Locate a vendor which has multiple invoices associated with it.
- View the vendor details, and click the "Invoices" link in the sidebar.
- The display of invoices should look correct. The DataTable should work
  correctly.
- Test the search filters in the sidebar to confirm that they work too.

Signed-off-by: Séverine Queune 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:41:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:41:48 +0000
Subject: [Koha-bugs] [Bug 30398] Reindent invoices template
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398

--- Comment #9 from Kyle M Hall  ---
Created attachment 132860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132860&action=edit
Bug 30398: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: Séverine Queune 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:48:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:48:12 +0000
Subject: [Koha-bugs] [Bug 30432] New: get_items_that_can_fill needs to
 specify table for biblionumbers
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432

            Bug ID: 30432
           Summary: get_items_that_can_fill needs to specify table for
                    biblionumbers
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

When not using item_level-itypes i.e. it is set to 'bibliographic record', we
join to biblioitems to get the itemtype

This causes ambiguity in the 'filter_by_for_hold' call in
'get_items_that_can_fill' as we only specify 'biblionumber' in our
bibs_or_items variable

The error is:
DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
execute failed: Column 'biblionumber' in where clause is ambiguous at
/kohadevbox/koha/Koha/Objects.pm line 394

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:49:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:49:11 +0000
Subject: [Koha-bugs] [Bug 22347] Translatability of ILSDI results for
 getavaibility
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22347

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:49:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:49:15 +0000
Subject: [Koha-bugs] [Bug 22347] Translatability of ILSDI results for
 getavaibility
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22347

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132550|0                           |1
        is obsolete|                            |

--- Comment #9 from Kyle M Hall  ---
Created attachment 132861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132861&action=edit
Bug 22347: Translatability of ILSDI GetAvailability

Some discovery tools can't translate ISL-DI results, it would be useful
if we can get ISL-DI output already translate.

This patch add an optional parameter language to GetAvailability, and
make GetAvailability results translatable.
If no parameter is given the output language is the language of the
cookies is present or the first language in the opac language list.

Test plan:
1. Enable the ILS-DI system preference
2. Locate a record
3. Test these URLs:
  
[OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=[BIBLIONUMBER]&id_type=biblio
   and
  
[OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=[ITEMNUMBER]&id_type=item
   (Where the [OPACBASEURL] is the OPAC URL of your test instance,
   [BIBLIONUMBER] and [ITEMNUMBER] are a record number and item number of
   your choice.)
4. Apply the patch
5. Test these URLs:
  
[OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=[BIBLIONUMBER]&id_type=biblio&language=[LANGUAGE]
   and
  
[OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=[ITEMNUMBER]&id_type=item&language=[LANGUAGE]
   (Where the [OPACBASEURL] is the OPAC URL of your test instance,
   [BIBLIONUMBER] and [ITEMNUMBER] are a record number and item number of
   your choice, [LANGUAGE] is a language code ex: 'en' or 'fr-FR')
6. The results should now be in the requested langugage

Sponsored-by: University Lyon 3

Signed-off-by: Sonia 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:51:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:51:01 +0000
Subject: [Koha-bugs] [Bug 30432] get_items_that_can_fill needs to specify
 table for biblionumbers
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:51:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:51:05 +0000
Subject: [Koha-bugs] [Bug 30432] get_items_that_can_fill needs to specify
 table for biblionumbers
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432

--- Comment #1 from Nick Clemens  ---
Created attachment 132862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132862&action=edit
Bug 30432: Unit test

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:51:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:51:09 +0000
Subject: [Koha-bugs] [Bug 30432] get_items_that_can_fill needs to specify
 table for biblionumbers
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432

--- Comment #2 from Nick Clemens  ---
Created attachment 132863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132863&action=edit
Bug 30432: Specify 'me' for biblionumber when limiting items

To test:
1 - Apply only unit tests
2 - prove t/db_dependent/Koha/Holds.t
3 - It fails
4 - Apply this patch
5 - prove t/db_dependent/Koha/Holds.t
6 - It passes!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:51:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:51:26 +0000
Subject: [Koha-bugs] [Bug 30432] get_items_that_can_fill needs to specify
 table for biblionumbers
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 14:53:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 12:53:01 +0000
Subject: [Koha-bugs] [Bug 30430] UNIMARC XSLT : displaying field B_214
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430

François Pichenot  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132842|0                           |1
        is obsolete|                            |

--- Comment #2 from François Pichenot  ---
Created attachment 132864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132864&action=edit
Bug 30430: UNIMARC XSLT add field B214 display

test plan :
- Apply patch
- Find a record with a B214
- Check on both Opac-Details and Opac-Result that the field is displayed.
- Do the same checks on catalogue/search results and catalogue/details
in Staff interface.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 15:00:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 13:00:01 +0000
Subject: [Koha-bugs] [Bug 30424] Reindent advanced search template in the
 staff interface
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30424

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 15:00:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 13:00:06 +0000
Subject: [Koha-bugs] [Bug 30424] Reindent advanced search template in the
 staff interface
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30424

--- Comment #1 from Owen Leonard  ---
Created attachment 132865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132865&action=edit
Bug 30424: Reindent advanced search template in the staff interface

This patch reindents the advanced search template. Some lines have been
split to make the markup more readable.

To test, apply the patch and test the advanced search page in the staff
interface. Everything should work as normal. Be sure to test both the
"More options" and "Fewer options" views.

When viewing the diff for this change, ignore whitespace. The only
visible changes should be split lines.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 15:00:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 13:00:10 +0000
Subject: [Koha-bugs] [Bug 30424] Reindent advanced search template in the
 staff interface
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30424

--- Comment #2 from Owen Leonard  ---
Created attachment 132866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132866&action=edit
Bug 30424: (follow-up) Markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 15:02:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 13:02:22 +0000
Subject: [Koha-bugs] [Bug 30433] New: Convert advanced search tabs to
 Bootstrap
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30433

            Bug ID: 30433
           Summary: Convert advanced search tabs to Bootstrap
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
        Depends on: 30424
            Blocks: 29226

Continuing the process of phasing out jQueryUI, this patch will replace
jQueryUI tabs in the advanced catalog search template with Bootstrap.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
[Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30424
[Bug 30424] Reindent advanced search template in the staff interface
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 15:02:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 13:02:22 +0000
Subject: [Koha-bugs] [Bug 30424] Reindent advanced search template in the
 staff interface
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30424

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |30433


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30433
[Bug 30433] Convert advanced search tabs to Bootstrap
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 15:02:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 13:02:22 +0000
Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |30433


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30433
[Bug 30433] Convert advanced search tabs to Bootstrap
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 15:03:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 13:03:41 +0000
Subject: [Koha-bugs] [Bug 30433] Convert advanced search tabs to Bootstrap
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30433

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 15:14:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 13:14:04 +0000
Subject: [Koha-bugs] [Bug 30433] Convert advanced search tabs to Bootstrap
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30433

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 15:14:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 13:14:08 +0000
Subject: [Koha-bugs] [Bug 30433] Convert advanced search tabs to Bootstrap
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30433

--- Comment #1 from Owen Leonard  ---
Created attachment 132867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132867&action=edit
Bug 30433: Convert advanced search tabs to Bootstrap

This patch updates the advanced search page in the staff interface to
use Bootstrap tabs instead of jQueryUI.

To test, apply the patch and test the advanced search interface. The
tabs should look correct and work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 15:19:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 13:19:37 +0000
Subject: [Koha-bugs] [Bug 30434] New: Convert catalog merge page tabs to
 Bootstrap
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30434

            Bug ID: 30434
           Summary: Convert catalog merge page tabs to Bootstrap
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 29226

Continuing the process of phasing out jQueryUI, this patch will replace
jQueryUI tabs in the catalog merge template with Bootstrap.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
[Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 15:19:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 13:19:37 +0000
Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |30434


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30434
[Bug 30434] Convert catalog merge page tabs to Bootstrap
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 15:30:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 13:30:54 +0000
Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in
 export_records.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #65 from David Gustafsson  ---
(In reply to Marcel de Rooy from comment #57)
> +    my $marc_flavour = C4::Context->preference('marcflavour');
> +    my $biblio_metadata = $resultset->find({
> +        'biblionumber' => $biblionumber,
> +        'format' => 'marcxml',
> +        'marcflavour' => $marc_flavour
> +    });
> +    my $marc_xml = $biblio_metadata->metadata;
> +    $marc_xml = StripNonXmlChars($marc_xml);
> +
> +    my $record = eval {
> +        MARC::Record::new_from_xml($marc_xml, 'UTF-8', $marc_flavour)
> +    };
> +    if (!$record) {
> 
> You test $record, but you should have tested $biblio_metadata too ?
> Otherwise you already crash on ->metadata..

Hi, thanks for the feedback. There is no definite right or wrong, but
personally try to avoid defensive programming where things are very unlikely to
fail. Ids should be valid since have been previously fetched from database, in
case of the XML-decoding it's highly unlikely to go wrong, but I can imagine
cases where it could.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 15:36:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 13:36:38 +0000
Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in
 export_records.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #66 from David Gustafsson  ---
(In reply to Marcel de Rooy from comment #57)
> +    my $marc_flavour = C4::Context->preference('marcflavour');
> +    my $biblio_metadata = $resultset->find({
> +        'biblionumber' => $biblionumber,
> +        'format' => 'marcxml',
> +        'marcflavour' => $marc_flavour
> +    });
> +    my $marc_xml = $biblio_metadata->metadata;
> +    $marc_xml = StripNonXmlChars($marc_xml);
> +
> +    my $record = eval {
> +        MARC::Record::new_from_xml($marc_xml, 'UTF-8', $marc_flavour)
> +    };
> +    if (!$record) {
> 
> You test $record, but you should have tested $biblio_metadata too ?
> Otherwise you already crash on ->metadata..

Hi, thanks for the feedback. There is no definite right or wrong, but
personally try to avoid defensive programming where things are very unlikely to
fail. Ids should be valid since have been previously fetched from database, in
case of the XML-decoding it's highly unlikely to go wrong, but I can imagine
cases where it could.(In reply to Marcel de Rooy from comment #58)
> +    return unless (@{$record_ids} || @{$deleted_record_ids} && $format ne
> 'csv');
> 
> Parentheses here would be more helpful inside. The outer ones are not needed.
> But in order to read easier, you could do A || ( B && C )

Yes,they could be removed. Personally I think it's more confusing, or at least
a bit unsightly, to use parenthesis for anything else than changing operator
precedence. At least with "||" and "&&" where there really should be no
confusion.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 15:38:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 13:38:14 +0000
Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in
 export_records.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #67 from David Gustafsson  ---
(In reply to Marcel de Rooy from comment #59)
> sub export
> 
>         binmode $fh, ':encoding(UTF-8)' unless $format eq 'csv';
>     } else {
>         binmode STDOUT, ':encoding(UTF-8)' unless $format eq 'csv';
> 
> What happens if we choose csv? Are we not doing UTF-8 ?
> Later we do:
> 
> print marc2csv( $record_ids, $csv_profile_id, $itemnumbers );

I had a look at this and don't think this block is part of the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 15:50:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 13:50:21 +0000
Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in
 export_records.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #68 from David Gustafsson  ---
(In reply to Marcel de Rooy from comment #59)
> sub export
> 
>         binmode $fh, ':encoding(UTF-8)' unless $format eq 'csv';
>     } else {
>         binmode STDOUT, ':encoding(UTF-8)' unless $format eq 'csv';
> 
> What happens if we choose csv? Are we not doing UTF-8 ?
> Later we do:
> 
> print marc2csv( $record_ids, $csv_profile_id, $itemnumbers );

marc2csv uses GetMarcBiblio to load biblios that does not support loading
deleted biblios which resides in another table. marc2csv would have to be
carefully reviewed and refactored to ensure it can handle deleted biblios, this
would increase the scope of this patch and I just did not think it was worth
the effort. A separate issues could perhaps be created in case there is an
interest implementing support for this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 15:52:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 13:52:36 +0000
Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in
 export_records.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #69 from David Gustafsson  ---
Sorry, the last comment was meant to be a response to:

> And functionally: why not deleted records in csv ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 16:06:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 14:06:36 +0000
Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in
 export_records.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #70 from David Gustafsson  ---
(In reply to Marcel de Rooy from comment #61)
> +                my ($record_type) = @_;
> 
> +            my $validator = $encoding_validator->('Record');
> 
> +                $validator = $encoding_validator->('Deleted record');
> 
> Deleted flag ?

I don't think I understand. The string is correct, but looking at the code I
wonder why creating a closure instead of just providing the argument further
down, I should probably change this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 16:23:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 14:23:13 +0000
Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in
 export_records.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #71 from David Gustafsson  ---
(In reply to Marcel de Rooy from comment #62)
> -            my $record = _get_record_for_export( { %$params, record_id =>
> $record_id } );
> 
> +            for my $record (@records, @deleted_records) {
> +                print MARC::File::XML::record($record);
> 
> Noting that get_record_for_export does a lot more and we seem to loose that
> now?

Yes, right now I can't think of any reason why deleted records should not be a
new record type in _get_record_for_export and processed in the same way as the
others (authorities and biblios). I will look into this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 16:26:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 14:26:18 +0000
Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in
 export_records.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #72 from David Gustafsson  ---
(_get_record_for_export is still called to fetch the other records though, so
no functionality has been removed there, but reading what it does don't se how
most of the same operations should not work also on deleted biblios)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 16:41:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 14:41:32 +0000
Subject: [Koha-bugs] [Bug 30350] Do not hardcode job types
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30350

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |ASSIGNED

--- Comment #6 from Tomás Cohen Arazi  ---
I would like to take this out of the RM queue for now, as work on bug 27783
might make this require some changes.

If someone (including me) finds this is still relevant, let's make it PQA
again.

Thanks Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 16:43:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 14:43:15 +0000
Subject: [Koha-bugs] [Bug 30434] Convert catalog merge page tabs to Bootstrap
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30434

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 16:43:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 14:43:19 +0000
Subject: [Koha-bugs] [Bug 30434] Convert catalog merge page tabs to Bootstrap
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30434

--- Comment #1 from Owen Leonard  ---
Created attachment 132868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132868&action=edit
Bug 30434: Convert catalog merge page tabs to Bootstrap

This patch updates the catalog merge template so that it uses Bootstrap
tabs instead of jQueryUI. Some JavaScript is modified to accommodate the
new DOM structure.

The patch also makes a minor HTML correction, adding a missing "".

To test, apply the patch and search the catalog in the staff client.

- In the search results, check the checkbox for two records.
- Choose Edit -> Merge records.
- Click next to accept the merge reference selection.
- On the next page you should see two tabs under "Source records."
  Confirm that they work correctly.
- All checkboxes in the first tab should be checked by default.
- Confirm that tag and subfield selection still works correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 16:54:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 14:54:29 +0000
Subject: [Koha-bugs] [Bug 20424] New UNIMARC ZEBRA indexes according to last
 IFLA updates
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424

Victor Grousset/tuxayo  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
         QA Contact|                            |victor at tuxayo.net
                 CC|                            |victor at tuxayo.net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 17:17:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 15:17:47 +0000
Subject: [Koha-bugs] [Bug 30435] New: Remove unused MACLES cataloging plugin
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30435

            Bug ID: 30435
           Summary: Remove unused MACLES cataloging plugin
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

I wrote this to the Koha mailing list in December 2017:

There is a plugin for the MARC edit form called macles.pl, "Gestion
des index MACLES" I'm assuming it's specific to UNIMARC.

Does anyone know if this is still in use? It's been broken since I
think version 16.05, so I'm curious whether it can be removed.

----

We keep updating the associated files to keep up with standards, but I think it
might be wasted work.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 17:22:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 15:22:12 +0000
Subject: [Koha-bugs] [Bug 30435] Remove unused MACLES cataloging plugin
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30435

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 17:22:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 15:22:33 +0000
Subject: [Koha-bugs] [Bug 30435] Remove unused MACLES cataloging plugin
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30435

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 17:22:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 15:22:37 +0000
Subject: [Koha-bugs] [Bug 30435] Remove unused MACLES cataloging plugin
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30435

--- Comment #1 from Owen Leonard  ---
Created attachment 132869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132869&action=edit
Bug 30435: Remove unused MACLES cataloging plugin

This patch removes the files associated with the MACLES cataloging
plugin. The feature is unmaintained.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 17:24:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 15:24:40 +0000
Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |30436


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436
[Bug 30436] Convert article requests tabs to Bootstrap
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 17:24:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 15:24:40 +0000
Subject: [Koha-bugs] [Bug 30436] New: Convert article requests tabs to
 Bootstrap
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436

            Bug ID: 30436
           Summary: Convert article requests tabs to Bootstrap
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
            Blocks: 29226

Continuing the process of phasing out jQueryUI, this patch will replace
jQueryUI tabs in the article requests template with Bootstrap.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
[Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 18:10:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 16:10:03 +0000
Subject: [Koha-bugs] [Bug 30437] New: Add an SVG loader to Koha
 pendingreserves.pl
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30437

            Bug ID: 30437
           Summary: Add an SVG loader to Koha pendingreserves.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Some pages in Koha can take a long time to load in Koha. One that often can
take some time is pendingreserves.pl 

If a library has a lot of holds this page can take a pretty long time to load
and sometimes users don't realize that. It is easy to think the page is broken
or not loading properly, causing users to continually click on the
pendingreserves.pl link. 

Clicking over and over again can be problematic as i causes pendingreserves.pl
to begin loading again and again. 

A SVG loader that gives a visual indication that the page is loading/working
could help prevent users from clicking the link multiple times while the page
is still loading.

pendingreserves.pl is one example, so it might be nice to have an SVG loader
that can be applied to any link within Koha that takes a long time to load.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 18:10:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 16:10:17 +0000
Subject: [Koha-bugs] [Bug 30436] Convert article requests tabs to Bootstrap
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 18:10:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 16:10:21 +0000
Subject: [Koha-bugs] [Bug 30436] Convert article requests tabs to Bootstrap
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436

--- Comment #1 from Owen Leonard  ---
Created attachment 132870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132870&action=edit
Bug 30436: Convert article requests tabs to Bootstrap

This patch converts the jQuery tabs on the article requests page to
Bootstrap.

To test you should have the "ArticleRequests" system preference
enabled. If necessary, create some article requests and mark some
"Pending," some "Processing," and leave some new.

- Apply the patch and go to Circulation -> Article requests.
- The page should show three tabs: New, Pending, and Processing.
- The tabs should look correct and work correctly.
- The DataTables under each tab should work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 18:20:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 16:20:17 +0000
Subject: [Koha-bugs] [Bug 30437] Add an SVG loader to Koha pendingreserves.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30437

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 18:20:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 16:20:21 +0000
Subject: [Koha-bugs] [Bug 30437] Add an SVG loader to Koha pendingreserves.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30437

--- Comment #1 from Lucas Gass  ---
Created attachment 132871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132871&action=edit
Bug 30437: Add SVG loader to pendingreserves.pl

To test:
1. Try to have a bunch of holds in your test system so pendingreserves.pl takes
several seconds to load
2. Apply patch
3. Regenerate the staff CSS:
https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface
4. Go to Home > Circulation
5. Click on "Holds to Pull"
6. As the page is loading you should notice some 'Loading page...' text with a
spinning SVG loader.
7. Nothing else should change with the functionality of the "Holds to Pull"
report

This uses a very nice free to use SVG loader from Sam Herbert.
https://samherbert.net/svg-loaders/
Credit and link are included in the SVG file

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 18:21:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 16:21:47 +0000
Subject: [Koha-bugs] [Bug 30437] Add an SVG loader to Koha pendingreserves.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30437

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 21:33:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 19:33:59 +0000
Subject: [Koha-bugs] [Bug 30430] UNIMARC XSLT : displaying field B_214
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430

Arthur Suzuki  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132864|0                           |1
        is obsolete|                            |

--- Comment #3 from Arthur Suzuki  ---
Created attachment 132872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132872&action=edit
Bug 30430: UNIMARC XSLT add field B214 display

test plan :
- Apply patch
- Find a record with a B214
- Check on both Opac-Details and Opac-Result that the field is displayed.
- Do the same checks on catalogue/search results and catalogue/details
in Staff interface.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 22:03:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 20:03:40 +0000
Subject: [Koha-bugs] [Bug 30438] New: Add select all/clear buttons to
 invoices.tt open and closed tables
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30438

            Bug ID: 30438
           Summary: Add select all/clear buttons to invoices.tt open and
                    closed tables
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Some librarians would find it handy to have "Select all" and "Clear all"
buttons on the on invoices.tt which selected, or cleared, each of the
checkboxes for open or closed invoices.

This would include sepearate select all/clear all buttons for the open and
closed invoice tables

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 22:11:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 20:11:08 +0000
Subject: [Koha-bugs] [Bug 30438] Add select all/clear buttons to invoices.tt
 open and closed tables
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30438

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 22:11:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 20:11:11 +0000
Subject: [Koha-bugs] [Bug 30438] Add select all/clear buttons to invoices.tt
 open and closed tables
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30438

--- Comment #1 from Lucas Gass  ---
Created attachment 132873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132873&action=edit
Bug 30438: Add select all/clear all buttons to invoices.tt

To test:
1. Apply patch
2. Have a bunch of invoices, some open and some closed.
3. Go to Home > Acquisitions > Invoices and do a search that will return you
many of those invoices, some open and some closed.
4. Notice the 'Select all' and 'Clear all' buttons.
5. Try clicking 'Select all' on the Open invoices tab. All Open invoices should
become checked.
6. Try clicking 'Clear all' on the Open invoices tab. All open invoices should
become unchecked.
7. Try 5 - 6 again but on the Closed invoices tab.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 22:19:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 20:19:38 +0000
Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373

--- Comment #9 from Bernardo Gonzalez Kriegel  ---
(In reply to Thibault Keromnès from comment #8)
> Tested with Arthur's git on a sandbox. 
> First tests (comments #1, #2 and #3) worked well (we have Default, ACQ, FA
> and Authorities frameworks)
> 
> Test on comment #4 failed, we couldn't install a new language. 
> "misc/translation/translate create xx-YY" didn't create
> "misc/translation/po/xx-YY-installer-UNIMARC.po"

It's strange, new po file creation depends on the last patch, and that is
present in the biblibre repo.
I just tried and I have not found problems.
I'll attach a sample xx-YY-installer-UNIMARC.po with french translations.

> On the default framework itself it looks really good, we just think it'd be
> better not to collapse the following fields : 
> 001 
> 010$d
> 020 
> 021  
> 106 
> 3XX 
> 4XX 
> 5XX 
> 8XX 
> 9XX
> We imported all authorities types, it's great, thanks a lot.

About visibility of fields/subfields, I'll gladly follow any advice, as in the
case of mandatory values.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 22:24:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 20:24:32 +0000
Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373

--- Comment #10 from Bernardo Gonzalez Kriegel  ---
Created attachment 132874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132874&action=edit
Sample UNIMARC install po file with fr-FR translations

After creation of new language xx-YY but before installing it, replace
xx-YY-installer-UNIMARC.po with this file, populated with strings from fr-FR
sql files.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 22:38:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 20:38:06 +0000
Subject: [Koha-bugs] [Bug 30438] Add select all/clear buttons to invoices.tt
 open and closed tables
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30438

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 22:38:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 20:38:21 +0000
Subject: [Koha-bugs] [Bug 30438] Add select all/clear buttons to invoices.tt
 open and closed tables
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30438

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 23:20:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 21:20:01 +0000
Subject: [Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items
 does not work
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375

--- Comment #24 from Katrin Fischer  ---
I wonder if  'not "notforloan"' should not only be for on order items that have
not yet arrived at the library. As it is now we exclude all reference items as
'not available' which is not true usually. A lot of special libraries have
large collections that are not for loan but can still be consulted.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 23:22:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 21:22:46 +0000
Subject: [Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items
 does not work
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |In Discussion

--- Comment #25 from Katrin Fischer  ---
Same for damaged - that something is damaged doesn't equal unavailable in a lot
of libraries. It might just be so that when the item is checked out the patron
is not blamed for pre-existing damage.

Maybe we do need to have some configuration options here?

If I could pick, I'd pick lost, withdrawn and on loan as unavailable.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 23:27:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 21:27:53 +0000
Subject: [Koha-bugs] [Bug 29129] The printclearscreen icon on circulation.tt
 should be configuarable to print either ISSUESLIP or ISSUEQSLIP
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129

--- Comment #1 from Andrew Fuerste-Henry  ---
+!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 23:30:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 21:30:16 +0000
Subject: [Koha-bugs] [Bug 27619] Remove fr-FR installer data
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619

--- Comment #3 from Katrin Fischer  ---
(In reply to Marcel de Rooy from comment #2)
> This did not move recently.
> On bug 2222 I want to remove auth_subfield_structure.frameworkcode.
> That gives a lot of changes in especially the fr-FR SQL files.
> Would you support doing that first ?

Hi Marcel, easy to miss, but there is actually some very recent movement here:

This was waiting for the new UNIMARC frameworks (dependency bug 30373). The
patches were provided just in time before the hackfest and tests have begun.
Once this is solved, it should be relatively easy to resolve this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Apr  1 23:36:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2022 21:36:36 +0000
Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use
 Font Awesome icons
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066

--- Comment #24 from Katrin Fischer  ---
Owen had showed a screenshot on IRC using the 'filter' icon, that I liked
better than the question mark, but not sure if he was going to provide a
follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Apr  2 12:37:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Apr 2022 10:37:07 +0000
Subject: [Koha-bugs] [Bug 30172] Background jobs failing due to race
 condition
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Apr  2 12:47:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Apr 2022 10:47:26 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132848|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Apr  2 12:47:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Apr 2022 10:47:29 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132849|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Apr  2 12:47:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Apr 2022 10:47:31 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132850|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Apr  2 12:47:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Apr 2022 10:47:33 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132846|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Apr  2 12:47:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Apr 2022 10:47:35 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132847|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Apr  2 12:49:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Apr 2022 10:49:22 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

--- Comment #20 from Tomás Cohen Arazi  ---
Created attachment 132875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132875&action=edit
Bug 27783: Add --job-type to background_jobs_worker.pl

This will let sysop adjust the number of workers and how they want to
manage them.
For instance one could want to have one worker for ES indexation and
another worker for other jobs, to prevent ES index to be stuck behind
bigger batch process.

Signed-off-by: Arthur Suzuki 
Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Apr  2 12:49:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Apr 2022 10:49:27 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

--- Comment #21 from Tomás Cohen Arazi  ---
Created attachment 132876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132876&action=edit
Bug 27783: Replace --job-type by --queue

This patch adds a new column background_jobs.queue, which default to
'default'
By default, new jobs are enqueued into this default queue, and the
background job worker will subscribe to the default queue unless told
otherwise by the --job-queue option

The new job UpdateElasticIndex is automatically enqueued in another
queue named 'index'
So you can have 'default' worker with
    misc/background_jobs_worker.pl
and a dedicated indexing worker with
    misc/background_jobs_worker.pl --queue index

This is to address bug 27344 comment #15

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Apr  2 12:49:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Apr 2022 10:49:31 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

--- Comment #22 from Tomás Cohen Arazi  ---
Created attachment 132877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132877&action=edit
Bug 27783: Add missing atomicupdate file

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Apr  2 12:49:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Apr 2022 10:49:36 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

--- Comment #23 from Tomás Cohen Arazi  ---
Created attachment 132878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132878&action=edit
Bug 27783: (follow-up) Add DB change to installer

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Apr  2 12:49:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Apr 2022 10:49:41 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

--- Comment #24 from Tomás Cohen Arazi  ---
Created attachment 132879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132879&action=edit
Bug 27783: Rename queues and adjust currently defined jobs

This patch renames the queues so the default is the **real-time** one, and
the other (*long_tasks*) is kept for **long running** tasks.

All current *batch* tasks are explicitly assigned to the **long_tasks**
queue as well.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Apr  2 12:51:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Apr 2022 10:51:35 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #25 from Tomás Cohen Arazi  ---
Somehow, my working branch was missing 30172, so I rebased this patches on top
of it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Apr  2 12:58:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Apr 2022 10:58:43 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

--- Comment #26 from Tomás Cohen Arazi  ---
Created attachment 132880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132880&action=edit
Bug 27783: (QA follow-up) Make dbrev idempotent

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Apr  2 13:00:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Apr 2022 11:00:03 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Apr  2 13:32:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Apr 2022 11:32:31 +0000
Subject: [Koha-bugs] [Bug 30391] Bad JS in IntranetUserJS can break the
 staff client
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30391

Adam Styles  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrfawn at gmail.com

--- Comment #1 from Adam Styles  ---
Hi Magnus,

The intranet JS logic is injected into all Staff intranet pages on page load.
This means that any JS added to the Intranet JS text area can possibly disrupt
existing Koha JS and related core functionality.

>From my experience, using Intranet JS to inject some hot fixed for Koha
Intranet staff UI can be useful if used sparingly. I generally run regression
tests for my JS added source via a local vanilla test version of Koha, to test
for any potential functionality friction, before apply to live/PROD.

A possible long term fix for this potentially disruptive experience, could be
to add micro regression tests to run on save of Intranet JS data input field.
This would offer the very core testing for the possible logic blocks to things
like JQUERY, which is used to power many of the koha UI front end behaviors.

IMHO.

Thoughts?

Adam.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Apr  2 15:56:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Apr 2022 13:56:36 +0000
Subject: [Koha-bugs] [Bug 30439] New: Apache server status module is exposed
 publicly on Koha bytemark hosted websites
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30439

            Bug ID: 30439
           Summary: Apache server status module is exposed publicly on
                    Koha bytemark hosted websites
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: james at jmwhite.co.uk
        QA Contact: testopia at bugs.koha-community.org

Hi,

My name is James White, I'm a Web Developer at Nottingham College. A member of
the public through responsible disclosure has alerted us to the fact that our
Koha library site at: https://library.nottinghamcollege.ac.uk currently has the
Apache Server Status module publicly exposed and is accessible through any IP
address: https://library.nottinghamcollege.ac.uk/server-status

This reveals various server information as well as network requests, which
could potentially expose sensitive information such as tokens, CSRF etc.

My investigation has identified this service is hosted by Bytemark, which I
assume is some form of cloud hosting agreement with yourselves, but I could be
wrong as I'm not able to verify our exact relationship with Koha internally at
this time.

However, I'm hoping by reporting it here that is can get to the right place. I
also found another Koha site also hosted on Bytemark which is also exposing the
Apache server status information: https://koha.lboro.ac.uk/server-status, so it
suggests it's likely happening for other Koha hosted sites through this
platform.

Ideally, the server status module needs to be restricted to localhost or
trusted subnets, not the public WAN.

Thanks,

James

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Apr  2 15:58:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Apr 2022 13:58:52 +0000
Subject: [Koha-bugs] [Bug 30439] Apache server status module is exposed
 publicly on Koha bytemark hosted websites
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30439

James White  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P3
           Severity|enhancement                 |major

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Apr  2 23:01:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Apr 2022 21:01:18 +0000
Subject: [Koha-bugs] [Bug 30440] New: Password reset input field are huge
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30440

            Bug ID: 30440
           Summary: Password reset input field are huge
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

In the OPAC the input fields to reset the password in the patron account are
now very wide independent of the password length configured. 
Asking for longer passwords is a good idea, but this might overdo it a little
:)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Apr  2 23:03:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Apr 2022 21:03:04 +0000
Subject: [Koha-bugs] [Bug 30409] barcodedecode() should always trim barcode
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409

Peter Vashchuk  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132781|0                           |1
        is obsolete|                            |

--- Comment #3 from Peter Vashchuk  ---
Created attachment 132881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132881&action=edit
Bug 30409: barcodedecode() should always trim barcode

Barcode is trimmed of leading/trailing whitespaces in many instances
before the barcodedecode sub was called. This patch instead makes that
barcodedecode sub is going to trim it itself and removes unnecessary,
and repetitive code that was used before barcodedecode was called.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Apr  2 23:11:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Apr 2022 21:11:37 +0000
Subject: [Koha-bugs] [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and
 staff interface
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011

--- Comment #9 from Katrin Fischer  ---
Only a note: I don't get an auto-complete on
cgi-bin/koha/reserve/request.pl?biblionumber=255 with and without the patch
set.

Everything else worked as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Apr  2 23:13:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Apr 2022 21:13:45 +0000
Subject: [Koha-bugs] [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and
 staff interface
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Apr  2 23:13:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Apr 2022 21:13:56 +0000
Subject: [Koha-bugs] [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and
 staff interface
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #131044|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer  ---
Created attachment 132882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132882&action=edit
Bug 30011: Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface

This patch updates jQueryUI in the OPAC and staff interface. Old assets
are removed and new assets added.

jQueryUI has been re-compiled in each interface to include only the
required features. In the OPAC: tabs and tooltip. In the staff
interface: accordion, autocomplete, sortable, and tabs.

The next patch will make the required updates to templates.

Signed-off-by: Lucas Gass 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Apr  2 23:14:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Apr 2022 21:14:02 +0000
Subject: [Koha-bugs] [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and
 staff interface
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #131045|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer  ---
Created attachment 132883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132883&action=edit
Bug 30011: Update links to jQueryUI assets, remove datepicker references, etc.

This patch updates templates to include the new version of jQueryUI. It
removes some references to the now unused datepicker widget as well as
the jQuery timepicker addon.

Some minor JavaScript and style updates to fix issues resulting from the
upgrade.

To test, apply the patch and update the CSS in the staff interface AND
in the OPAC
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

IN THE OPAC:

 - The OPAC only uses the tabs jQueryUI widget.
 - View pages where tabs are used: Bibliographic details, user summary,
   advanced search.

IN THE STAFF INTERFACE:

 - The staff interface uses four jQueryUI widgets: accordion,
   autocomplete, sortable, and tabs
 - Test the accordion widget on two pages: Administration -> Table
   settings and Patrons -> Patrons requesting modifications.
 - Test autocomplete (requires PatronAutoComplete to be enabled) on
   various pages. For example:
   - From the "Check out" tab in the header search box.
   - From the "Search patrons" tab in the header search box, e.g. from
     the main Patrons page.
   - Place hold -> Search patrons.
   - Tools -> Patron lists -> Add patrons to list -> Patron search.
 - Test sortable:
   - Administration -> System preferences -> Language.
     - With more than one language installed you should be able to
       drag to re-order the enabled languages. Confirm that your change
       is saved successfully.
   - Administration -> MARC bibliographic framework -> MARC structure ->
     Edit subfields on a tag with multiple subfields. You should be able
     to drag to re-order the tabs at the top of the subfield constraints
     edit page. Confirm that your changes are saved successfully.
   - Cataloging -> New record. Test that you can re-order subfields
     under a tag with multiple subfields and that your changes are
     saved.
 - Tabs: View various pages with tabs: Check out, bibliographic details,
   basic MARC editor. They're everywhere.

Also confirm that the removal of the leftover datepicker doesn't affect
pages which use the calendar include: Test various pages which use
Flatpickr, e.g. check out, renew, reports, etc.

Signed-off-by: Lucas Gass 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Apr  2 23:32:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Apr 2022 21:32:48 +0000
Subject: [Koha-bugs] [Bug 30409] barcodedecode() should always trim barcode
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409

Peter Vashchuk  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Apr  2 23:32:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Apr 2022 21:32:52 +0000
Subject: [Koha-bugs] [Bug 30409] barcodedecode() should always trim barcode
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409

Peter Vashchuk  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132881|0                           |1
        is obsolete|                            |

--- Comment #4 from Peter Vashchuk  ---
Created attachment 132884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132884&action=edit
Bug 30409: barcodedecode() should always trim barcode

Barcode is trimmed of leading/trailing whitespaces in many instances
before the barcodedecode sub was called. This patch instead makes that
barcodedecode sub is going to trim it itself and removes unnecessary,
and repetitive code that was used before barcodedecode was called.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Apr  2 23:40:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Apr 2022 21:40:22 +0000
Subject: [Koha-bugs] [Bug 30409] barcodedecode() should always trim barcode
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409

Peter Vashchuk  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132884|0                           |1
        is obsolete|                            |

--- Comment #5 from Peter Vashchuk  ---
Created attachment 132885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132885&action=edit
Bug 30409: barcodedecode() should always trim barcode

Barcode is trimmed of leading/trailing whitespaces in many instances
before the barcodedecode sub was called. This patch instead makes that
barcodedecode sub is going to trim it itself and removes unnecessary,
and repetitive code that was used before barcodedecode was called.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Apr  3 00:03:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Apr 2022 22:03:46 +0000
Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface - 

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 00:03:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 22:03:53 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131069|0 |1 is obsolete| | --- Comment #113 from Katrin Fischer --- Created attachment 132886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132886&action=edit Bug 27631: Changed

around logo to
To test: 1) Look at Staff Client and the logo 2) Apply patch 3) Check Koha logo moves to the middle of the page when zooming in 4) Ensure page source shows logo inside
and not

Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 00:03:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 22:03:59 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131070|0 |1 is obsolete| | --- Comment #114 from Katrin Fischer --- Created attachment 132887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132887&action=edit Bug 27631: circ folder Changed each of the pages in the circ folder to have one

tag showing that describes the page, rather than the

describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the circ folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is

Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 00:04:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 22:04:05 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131071|0 |1 is obsolete| | --- Comment #115 from Katrin Fischer --- Created attachment 132888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132888&action=edit Bug 27631: labels and members folders Changed each of the pages in the labels and members folders to have one

tag showing that describes the page, rather than the

describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the labels and members folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is

Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 00:04:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 22:04:11 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131072|0 |1 is obsolete| | --- Comment #116 from Katrin Fischer --- Created attachment 132889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132889&action=edit Bug 27631: authorities, clubs, common, course_reserves folders Changed each of the pages in the authorities, clubs, common, course_reserves folders to have one

tag showing that describes the page, rather than the

describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the authorities, clubs, common, course_reserves folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is

Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 00:04:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 22:04:17 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131073|0 |1 is obsolete| | --- Comment #117 from Katrin Fischer --- Created attachment 132890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132890&action=edit Bug 27631: installer and onboarding folders Changed each of the pages in the installer and onboarding folders to have one

tag showing that describes the page, rather than the

describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Ensure that the page source shows logo inside
and not inside

4) Go to each of the pages in the installer and onboarding folders and check that they have an obvious and descriptive heading 5) Ensure that the heading in the page is

Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 00:04:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 22:04:24 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131074|0 |1 is obsolete| | --- Comment #118 from Katrin Fischer --- Created attachment 132891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132891&action=edit Bug 27631: offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders Changed each of the pages in the offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders to have one

tag showing that describes the page, rather than the

describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is

Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 00:04:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 22:04:30 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131075|0 |1 is obsolete| | --- Comment #119 from Katrin Fischer --- Created attachment 132892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132892&action=edit Bug 27631: catalogue and tags folders Changed each of the pages in the catalogue and tags folders to have one

tag showing that describes the page, rather than the

describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the catalogue and tags folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is

Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 00:04:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 22:04:36 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131076|0 |1 is obsolete| | --- Comment #120 from Katrin Fischer --- Created attachment 132893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132893&action=edit Bug 27631: tools and virtualshelves folders Changed each of the pages in the tools and virtualshelves folders to have one

tag showing that describes the page, rather than the

describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the tools and virtualshelves folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is

Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 00:04:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 22:04:42 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131077|0 |1 is obsolete| | --- Comment #121 from Katrin Fischer --- Created attachment 132894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132894&action=edit Bug 27631: reports and serials folders Changed each of the pages in the reports and serials folders to have one

tag showing that describes the page, rather than the

describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the reports and serials folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is

Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 00:04:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 22:04:48 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131078|0 |1 is obsolete| | --- Comment #122 from Katrin Fischer --- Created attachment 132895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132895&action=edit Bug 27631: cataloguing folder Changed each of the pages in the cataloguing folder to have one

tag showing that describes the page, rather than the

describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the cataloguing folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is

Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 00:04:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 22:04:55 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131079|0 |1 is obsolete| | --- Comment #123 from Katrin Fischer --- Created attachment 132896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132896&action=edit Bug 27631: acqui folder Changed each of the pages in the acqui folder to have one

tag showing that describes the page, rather than the

describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the acqui folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is

Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 00:05:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 22:05:01 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131080|0 |1 is obsolete| | --- Comment #124 from Katrin Fischer --- Created attachment 132897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132897&action=edit Bug 27631: Hidden

on intranet-main.tt This patch visually hides a

on intranet-main.tt so that the heading is available to be read out by screenreaders in the summary of headings on the page. Test plan: 1) Ensure the

"Koha home" heading on the staff client main/home page is hidden visually, but in the source code you can see it Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 00:05:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 22:05:08 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131081|0 |1 is obsolete| | --- Comment #125 from Katrin Fischer --- Created attachment 132898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132898&action=edit Bug 27631: admin folder Changed each of the pages in the admin folder to have one

tag showing that describes the page, rather than the

describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the admin folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is

Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 00:05:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 22:05:15 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131082|0 |1 is obsolete| | --- Comment #126 from Katrin Fischer --- Created attachment 132899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132899&action=edit Bug 27631: (follow-up) course_reserves/course-details.tt Changed file to have one

tag showing that describes the page, rather than the

around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to course_reserves/course-details and check that it has an obvious and descriptive heading 4) Ensure that the heading is

Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 00:05:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 22:05:20 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131083|0 |1 is obsolete| | --- Comment #127 from Katrin Fischer --- Created attachment 132900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132900&action=edit Bug 27631: (follow-up) tools/marc_modification_templates.tt Changed file to have one

tag showing that describes the page, rather than the

around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to tools/marc_modification_templates and check that it has an obvious and descriptive heading 4) Ensure that the heading is

Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 00:05:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 22:05:26 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131084|0 |1 is obsolete| | --- Comment #128 from Katrin Fischer --- Created attachment 132901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132901&action=edit Bug 27631: (follow-up) reports/guided_reports_start.tt Changed file to have one

tag showing that describes the page, rather than the

around the logo. The hierarchy of other heading tags may be wrong, but this wil be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to reports/guided_reports_start and check that it has an obvious and descriptive heading 4) Ensure that the heading is

Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 00:05:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 22:05:29 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 --- Comment #22 from Katrin Fischer --- (In reply to Mason James from comment #0) > a bug to use for testing debian/control updates Is this supposed to go through QA? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 00:05:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 22:05:32 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131085|0 |1 is obsolete| | --- Comment #129 from Katrin Fischer --- Created attachment 132902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132902&action=edit Bug 27631: (follow-up) circ/branchtransfers.tt Changed file to have one

tag showing that describes the page, rather than the

around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to circ/branchtransfers and check that it has an obvious and descriptive heading 4) Ensure that the heading is

Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 00:05:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 22:05:38 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131086|0 |1 is obsolete| | --- Comment #130 from Katrin Fischer --- Created attachment 132903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132903&action=edit Bug 27631: (follow-up) Some minor corrections This patch makes some corrections to issues found during testing: Some duplicate headings, a markup error in labeledMARCdetail.tt, a change of the transfers heading from "Branch transfers" to "Item transfers." This patch also undoes the changes to the position of the toolbar on several pages. I think those changes don't belong in this bug. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 00:05:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 22:05:44 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131087|0 |1 is obsolete| | --- Comment #131 from Katrin Fischer --- Created attachment 132904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132904&action=edit Bug 27631: (follow-up) Modify logo CSS to give better alignment This patch modifies the CSS of the Koha logo and its container so that it more closely matches the previous version and so that alignment is handled better at various browser widths. To test, apply the patch and build the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Check various pages in the staff interface to confirm that the position of the Koha logo is correct. Adjust your browser width to confirm that the alignment adapts at narrow widths. Test also on pages where the header search form can be expanded, e.g. Patrons -> [+] to expand search options. Or Acquisitions -> Orders search -> [+]. Confirm that logo alignment is correct on these pages too. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 00:05:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 22:05:50 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131192|0 |1 is obsolete| | --- Comment #132 from Katrin Fischer --- Created attachment 132905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132905&action=edit Bug 27631: (follow-up) Various corrections This patch addresses issues found during QA: - Double headings (patron details page) - Inconsistent heading position (check out, patron accounting) - Missing headings when there is no data (Library EANs, Item search fields, MARC modification templates). - Typo: Z19.50 => Z39.50 - Reword "Classification sources" heading: "Classification configuration" Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 00:06:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 22:06:49 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #133 from Katrin Fischer --- Thank you for the follow-up, Owen! Sorry it took me so long to get back to this one, I think it's about time we get this one in! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 00:18:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 22:18:07 +0000 Subject: [Koha-bugs] [Bug 29282] Allow items.issue and items.renewals to be shown in the bib details holdings table on the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer --- Hi Andrew, this works really nicely and I like that they are hidden by default. But could you make the same changes to the otherholdings table so we keep them in sync? It's tied to the SeparateHoldings system preference that divides the items between your own and the other branches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 00:18:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 22:18:43 +0000 Subject: [Koha-bugs] [Bug 29282] Allow items.issue and items.renewals in the holdings table on the detail page in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow items.issue and |Allow items.issue and |items.renewals to be shown |items.renewals in the |in the bib details holdings |holdings table on the |table on the staff |detail page in the staff |interface |interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 00:18:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 22:18:53 +0000 Subject: [Koha-bugs] [Bug 29282] Show items.issue and items.renewals in the holdings table on the detail page in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow items.issue and |Show items.issue and |items.renewals in the |items.renewals in the |holdings table on the |holdings table on the |detail page in the staff |detail page in the staff |interface |interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 00:23:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 22:23:38 +0000 Subject: [Koha-bugs] [Bug 30223] Move book cover image upload JS to a separate file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30223 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 00:23:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 22:23:42 +0000 Subject: [Koha-bugs] [Bug 30223] Move book cover image upload JS to a separate file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30223 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131387|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 132906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132906&action=edit Bug 30223: Move book cover image upload JS to a separate file This patch moves most of the JavaScript from upload-images.tt into a separate file, upload-images.js. Functionality should be unchanged. To test, apply the patch and go to Tools -> Upload local cover image. Test all the things: - Drag-and-drop upload - Click-to-browse upload; - Deleting existing images - Uploading a zip file Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 00:31:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 22:31:59 +0000 Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search function for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Katrin Fischer --- I believe 8) is not right: 8. Try changing to a different branch and doing another search. It should correcrly limit to that branch BUT it should also default back to 'All libraries' for the next search. * In the OPAC the branch selection is maintained and I believe this is the correct behaviour. * We keep all the other search related options: search terms, search option (IntranetCatalogSearchPulldown). So It doesn't make sense that the branch selection would be the only search parameter to be reset. It creates a mismatch of what you see and what has been searched for. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 01:11:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 23:11:28 +0000 Subject: [Koha-bugs] [Bug 23352] Define serial's collection code in the subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #40 from Katrin Fischer --- Hi Alex, could you take a look at the failure in QA test tools please? 1) QA tools FAIL installer/data/mysql/atomicupdate/bug_23352-add_ccode_column_to_subscriptions_table.pl FAIL valid Useless use of anonymous hash ({}) in void context ... and nothing else. Tests pass and testing looked good. Hope above is an easy fix! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 01:16:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 23:16:49 +0000 Subject: [Koha-bugs] [Bug 30441] New: Make subtitle searchable in serials search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30441 Bug ID: 30441 Summary: Make subtitle searchable in serials search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org It would be nice if together with the title, the subtitle was also searchable as it's often helpful to distinguish a lot of similar serial titles. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 01:16:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 23:16:49 +0000 Subject: [Koha-bugs] [Bug 30204] Add subtitle to serial subscription search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30441 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 01:20:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 23:20:27 +0000 Subject: [Koha-bugs] [Bug 30204] Add subtitle to serial subscription search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131560|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 132907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132907&action=edit Bug 30204: Add subtitle to serial search results To test: 1. Make some new serial subscriptions and connect them to biblios that contain subtitles. 2. Do a serial search that will return your newly created subscription. 3. Notice the subtitle doesn't appear. 4. Apply patch and restart_all 5. Again try step 2. 6. Notice the subtitle appears alongside the title now. 7. Make sure it still sorts that column correctly. Signed-off-by: shiyao Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 01:25:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 23:25:26 +0000 Subject: [Koha-bugs] [Bug 30204] Add subtitle to serial subscription search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- This works great! But as the patches include a change to SearchSubscriptions in Serials.pm, we should probably have a small addition to the unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 01:28:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 23:28:43 +0000 Subject: [Koha-bugs] [Bug 23352] Define serial's collection in the subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Define serial's collection |Define serial's collection |code in the subscription |in the subscription -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 01:36:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2022 23:36:03 +0000 Subject: [Koha-bugs] [Bug 28840] Better texts in batch record modification/deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #9 from Katrin Fischer --- I believe it should probably be IDs instead of ids? The internet suggests so, but maybe we could still have a native speaker weigh in? Example:
  • Enter a list of record ids
  • -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 11:32:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 09:32:29 +0000 Subject: [Koha-bugs] [Bug 30401] Convert budgets administration page tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30401 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 11:32:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 09:32:33 +0000 Subject: [Koha-bugs] [Bug 30401] Convert budgets administration page tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30401 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132809|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 132908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132908&action=edit Bug 30401: Convert budgets administration page tabs to Bootstrap This patch updates the budgets administration page to use Bootstrap tabs instead of jQueryUI. This patch contains indentation changes, so ignore whitespace when you use your preferred diff tool. To test, apply the patch and go to Administration -> Budgets. Check that the "Active budgets" and "Inactive budgets" work correctly. Append "?tab=2" to the page URL to confirm that the second tab is preselected. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 12:00:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 10:00:20 +0000 Subject: [Koha-bugs] [Bug 30442] New: Adjust ACCTDETAILS sample email to new behaviour Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30442 Bug ID: 30442 Summary: Adjust ACCTDETAILS sample email to new behaviour Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org We have made the ACCTDETAILS mail into a welcome email, but it still reads: Your new Koha account details. We should change things around a bit to make the new purpose clear. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 12:00:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 10:00:20 +0000 Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30442 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 12:02:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 10:02:39 +0000 Subject: [Koha-bugs] [Bug 29005] Add option to send ACCTDETAILS notice for new patrons added via patron imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 12:02:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 10:02:44 +0000 Subject: [Koha-bugs] [Bug 29005] Add option to send ACCTDETAILS notice for new patrons added via patron imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132783|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer --- Created attachment 132909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132909&action=edit Bug 29005: Add support for the command line script This patch adds welcome email for new users support to the command line patron import tool. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 12:02:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 10:02:49 +0000 Subject: [Koha-bugs] [Bug 29005] Add option to send ACCTDETAILS notice for new patrons added via patron imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132784|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer --- Created attachment 132910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132910&action=edit Bug 29005: Unit tests Add a unit test for the additional functionality of sending welcome emails from Koha::Patrons::Import. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 12:10:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 10:10:58 +0000 Subject: [Koha-bugs] [Bug 30442] Adjust ACCTDETAILS sample email to new behaviour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30442 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 30237 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 12:10:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 10:10:58 +0000 Subject: [Koha-bugs] [Bug 30237] Rename/rephrase AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 --- Comment #10 from Katrin Fischer --- *** Bug 30442 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 12:23:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 10:23:34 +0000 Subject: [Koha-bugs] [Bug 30237] Rename/rephrase AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA Keywords| |Manual, | |release-notes-needed --- Comment #11 from Katrin Fischer --- Hi all, almost there! 1) This includes a database update to insert a new letter. I am not sure about this approach. I think it would be better if we changed the letter code on the existing ACCTDETAILS instead, because it will cause less surprising behaviour. The existing notice will kept to be sent for libraries using the feature instead of it suddently changing text and turning English. (blocker) 2) We could add a note to the system preference about the letter code, so people will be able to see the change a little better. (suggestion) 3) QA test tools: FAIL installer/data/mysql/atomicupdate/bug_30237.pl FAIL file permissions File must have the exec flag 4) New letter Thank you for doing this, I already had filed a separate bug before stumbling onto this here! Some small stuff and hopefully good suggestions: a) Tiny typo: Thank you + - "Thankyou for joining [% Koha.Preference('LibraryName') %]" b) Linking 'here' Never link "here", it's a known accessibility issue with screen readers, but also because we are all used to scan for links now and it doesn't give an useful clue on where it leads. "The library's catalog can be found here." Better to say something like: You can search for all our materials in our catalog." And patron's won't know that this is Koha or who the administrator is, better to ask them to get in touch with the library staff :) If you have any problems or questions regarding your account, please contact your Koha Administrator. Better: If you have any problems or questions regarding your account, please contact your library. 5) French installer As we don't know yet if the French installer will be gone in time for release, we should update the installer with the new notice: installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 12:27:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 10:27:53 +0000 Subject: [Koha-bugs] [Bug 30400] Convert invoices page tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30400 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 12:27:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 10:27:57 +0000 Subject: [Koha-bugs] [Bug 30400] Convert invoices page tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30400 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132811|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 132911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132911&action=edit Bug 30400: Convert invoices page tabs to Bootstrap This patch updates the invoices page to use Bootstrap tabs instead of jQueryUI. To test, apply the patch and go to Acquisitions. - Locate a vendor which has multiple invoices associated with it. - View the vendor details, and click the "Invoices" link in the sidebar. - Check that the "Open invoices" and "Closed invoices" tabs work correctly. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 12:30:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 10:30:09 +0000 Subject: [Koha-bugs] [Bug 30423] Convert authority merge page tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30423 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 12:30:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 10:30:13 +0000 Subject: [Koha-bugs] [Bug 30423] Convert authority merge page tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30423 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132822|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 132912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132912&action=edit Bug 30423: Convert authority merge page tabs to Bootstrap This patch updates the authority merge page to use Bootstrap tabs instead of jQueryUI. To test, apply the patch go to Authorities in the staff interface. - Perform an authority search which will return more than one authority record. - On the results page, click Actions -> Merge for two authority records. - Click "Next" after selecting a merge reference. - On the next page you should see two tabs under "Source records." Confirm that they work correctly. - Confirm that tag and subfield selection still works correctly. Signed-off-by: Séverine Queune Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 12:34:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 10:34:47 +0000 Subject: [Koha-bugs] [Bug 30419] Convert authority detail page tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30419 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 12:34:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 10:34:51 +0000 Subject: [Koha-bugs] [Bug 30419] Convert authority detail page tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30419 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132823|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 132913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132913&action=edit Bug 30419: Convert authority detail page tabs to Bootstrap This patch updates the authority detail page to use Bootstrap tabs instead of jQueryUI. The patch also removes some broken JavaScript. It will be re-implemented in Bug 30422. To test, apply the patch search for an authority record in the authorities module. View the detail page for the authority and test that the tabs look correct and work correctly. Signed-off-by: Séverine Queune Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 12:39:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 10:39:18 +0000 Subject: [Koha-bugs] [Bug 30389] Switch to Bootstrap tabs on the page for adding orders from MARC file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 --- Comment #4 from Katrin Fischer --- I am afraid this is not quite ready for QA yet with the 2 dependent bugs not yet signed off. Moving to BLOCKED, back to QA queue soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 12:39:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 10:39:24 +0000 Subject: [Koha-bugs] [Bug 30389] Switch to Bootstrap tabs on the page for adding orders from MARC file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 12:42:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 10:42:15 +0000 Subject: [Koha-bugs] [Bug 30396] Convert basket groups page tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30396 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 12:42:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 10:42:19 +0000 Subject: [Koha-bugs] [Bug 30396] Convert basket groups page tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30396 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132474|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 132914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132914&action=edit Bug 30396: Convert basket groups page tabs to Bootstrap This patch replaces the use of jQueryUI tabs on the basket groups page, in the view where open and closed basket groups are displayed in separate tabs. This patch includes indentation changes, so please ignore whitespace when using your preferred diff tool. To test you should have at least two basket groups set up in Acquisitions, one open and one closed. Go to Acquisitions -> Vendor -> Basket groups and confirm that the "Open" and "Closed" tabs look correct and work correctly. Under the "Closed" tab, try clicking the "Reopen" button. The page will refresh but you should still see the "Closed" tab active. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 12:47:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 10:47:34 +0000 Subject: [Koha-bugs] [Bug 30205] Add biblio.subtitle to the subscription-detail.pl page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 12:47:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 10:47:38 +0000 Subject: [Koha-bugs] [Bug 30205] Add biblio.subtitle to the subscription-detail.pl page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131762|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 132915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132915&action=edit Bug 30205: Add subtitle to subscription detail page To test: 1. Make some new serial subscriptions and connect them to biblios that contain subtitles. 2. Do a serial search that will return your newly created subscription. 3. Click on one of those subscription to be taken to the subscription detail page. 4. Look at the main heading (h1) and the "Biblio:" line. Notice there is no subtitle in either place 5. Apply patch, restart_all, and reload the subscription detail page. 6. You should now see the subtitle on both the main heading (h1) and on the 'Biblio:' line. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 12:48:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 10:48:52 +0000 Subject: [Koha-bugs] [Bug 30205] Add biblio.subtitle to the subscription-detail.pl page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205 --- Comment #7 from Katrin Fischer --- (In reply to Lucas Gass from comment #3) > (In reply to Owen Leonard from comment #2) > > Did you look at including biblio-title.inc? Maybe it's overkill here? > > I did not, but now I will! Hi Andrew, I am ok with the patch as is, but maybe you can add a note why not biblio-title.inc? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 12:52:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 10:52:27 +0000 Subject: [Koha-bugs] [Bug 30237] Rename/rephrase AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 --- Comment #12 from Katrin Fischer --- 6) While testing bug 9097 I noticed that the branch name is not resolved in the subject line: Welcome to We might want to remove the name there for now and fix the subject replacement for TT on a separate bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 12:56:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 10:56:27 +0000 Subject: [Koha-bugs] [Bug 9097] Add option to trigger 'Welcome mail' manually In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 12:56:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 10:56:32 +0000 Subject: [Koha-bugs] [Bug 9097] Add option to trigger 'Welcome mail' manually In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131518|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer --- Created attachment 132916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132916&action=edit Bug 9097: Add option to manually send welcome email This patch adds a new 'Send welcome email' option to the 'More' dropdown menu in the patrons toolbar. Clicking the button will queue the welcome email again for the patron and redirect the user to the Notices tab to view it's contents. Signed-off-by: Kelly McElligott Signed-off-by: Jessie Zairo Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 12:57:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 10:57:26 +0000 Subject: [Koha-bugs] [Bug 9097] Add option to trigger 'Welcome mail' manually In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED --- Comment #22 from Katrin Fischer --- Added Kelly's, Jessie's and my sign-off line here and this can be considered PQA, but have to move to BLOCKED for now until we have ironed out some glitches in the dependent bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 13:08:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 11:08:05 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #1 from Katrin Fischer --- Hi Nick, I have read it several times, but I am not sure I understand yet what the new permissions would look like. Maybe you could write them up? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 13:15:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 11:15:43 +0000 Subject: [Koha-bugs] [Bug 30425] April fools! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30425 --- Comment #3 from Katrin Fischer --- Please remember to revert/remove :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 13:22:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 11:22:30 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #341 from Katrin Fischer --- Created attachment 132917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132917&action=edit Bug 20256: (QA follow-up) Fix typo in permission descriptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 13:29:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 11:29:58 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #342 from Katrin Fischer --- Started to test functionality a bit more and I feel like there is a bigger issue with how this will change how item editing is set up. We now have: * Edit items (not including items restricted by library group) (edit_items) * Edit any item including items that would otherwise be restricted (edit_any_item) Test case 1: * edit_items * Independentbranches is off * No library groups are set up Items from other libraries cannot be edited. This means that now both permissions are required in order to have the current behaviour when Independentbranches is turned off. As the permissions for existing staff users are not updated with this patch set, it will cause a behaviour change and require a lot of config changes (depending on staff numbers) to fix. So what can we do? 1) Update staff permissions for existing staff users. This will still mean that 2 checkboxes will have to be set to allow for full item editing. 2) Change the checks to see if there are actually any library groups for 'item edit' set up and only apply the limit if there are. What do you think? I lean a bit more towards 2 as this will make the default config a little easier (= no restrictions set up, no restrictions applied) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 13:33:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 11:33:36 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #343 from Katrin Fischer --- Ok, I misread the database update, there actually is an update! + $dbh->do(q{ + INSERT INTO user_permissions ( borrowernumber, module_bit, code ) + SELECT borrowernumber, '9', 'edit_any_item' + FROM user_permissions + WHERE module_bit = '9' + AND code = 'edit_items' + }); Still wondering if we could get around the 2 permissions for simple item edit somehow... but maybe not. Because: if we implemented my suggestion 2) libraries wanting to limit on home branch for editing would have to set up a group for each branch, which is also not nice. I'll test more! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 14:42:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 12:42:05 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #344 from Katrin Fischer --- =Testing restrictions= Test case 1: * edit_items = yes * edit_any_items = no * Independentbranches = NO * No library groups defined Only items from home branch can be edited. Test case 2: * edit_items = yes * edit_any_items = yes * Independentbranches = NO * No library groups defined All items can be edited. Test case 3: * edit_items = yes * edit_any_items = no * Independentbranches = YES * No library groups defined Only items from home branch can be edited. Same as with Indybranches off. Test case 4: * edit_items = yes * edit_any_items = yes * Independentbranches = YES * No library groups defined All items can be edited. Same as with Indybranches off. Test case 5: * edit_items = yes * edit_any_items = no * Independentbranches = YES or NO * Library group includes staff users home branch (MPL) and other library branch (CPL) Only items from home branch (CPL) and group library (MPL) can be edited. Test case 6: * edit_items = yes * edit_any_items = yes * Independentbranches = YES or NO * No library groups defined All items can be edited. Summary: ==> The new edit_any_items overwrites the Indybranches pref. In consequence it appears it no longer has any effect. Correct? Should we update the IndependantBranches description to reflect that? Currently reads: Prevent staff (but not superlibrarians) from modifying objects (holds, items, patrons, etc.) belonging to other libraries: [Yes|No] ==> We update all staff users to have edit_any_items, but we should possibly only update if IndependentBranches is set to off, to keep current behaviour! (blocker) =Edit buttons= Tested with configuration from Test case 5. 1) OK - detail page - holdings table 2) OK - detail page - items tab 3) NOT OK - item edit page The Edit link in the Actions menu always shows, but redirects to detail page, if no permission. It shoudl only show if editing is possible. (blocker) 4) OK - item search It could be improved later, so that if there is only "edit record" we show this option directly (no blocker). 5) NOT OK - Course reserves a) Use a barcode to add a reserve to a course from another branch, don't change home branch The edit link is removed, but something with the table structure is broken because of it and causes breakage of the datatable: Uncaught TypeError: Cannot set property '_DT_CellIndex' of undefined. (blocker) b) Use a barcode to add a reserve to a course from another branch, update home branch to an editable one The links are shown and the table keeps working. This one is tricky, I think for sure we need to fix the table to not be broken (minimum requirement). But this could be easily a thing where a patron 'traps' themselves with a reserve they can only 'remove' using the 'remove all' feature. Conclusion: An idea: As there sure is a use case for getting items from other branches for your course reserve, maybe we can do this: - Always show button to remove the item from the reserve (that's not editing right?) Also might fix the table issue. - Maybe: Allow editing of the item for this use case after the item has been added to the course reserve. If we allow on adding it... it would be consequential and it's only temporary changes. 6) OK - detail page - batch editing 7) NOT OK - tools - items batch edit - Added barcodes of one editable and a non-editable item. Exlosion (blocker) Can't locate object method "params" via package "Koha::UI::Table::Builder::Items" at /kohadevbox/koha/Koha/UI/Table/Builder/Items.pm line 75 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 15:04:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 13:04:06 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23681 --- Comment #39 from Katrin Fischer --- Hi Emmi, thanks for the rebase, starting to dig a little deeper into this now: 1) DelDebarmentsAfterPayment According to coding guidelines the methods in Koha namespace should always be snake case. 2) Terminology debarment --> restriction In general, and that possibly applies to above as well, we should use the term "restrictions". See: bug 5268 for an explanation. borrower --> patron I know you can't change all spots as the table is called borrowers_debarments, but I think it would be good to change where possible. Example: Lift these debarments after Borrower has paid their charges > Lift these restrictions after a patron has paid their charges See also: https://wiki.koha-community.org/wiki/Terminology 3) Functionality I recently reviewed bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 15:04:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 13:04:06 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16223 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 15:20:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 13:20:05 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #40 from Katrin Fischer --- Hi Emmi, thanks for the rebase, starting to dig a little deeper into this now: 1) DelDebarmentsAfterPayment According to coding guidelines the methods in Koha namespace should always be snake case. 2) Terminology debarment --> restriction In general, and that possibly applies to above as well, we should use the term "restrictions". See: bug 5268 for an explanation. borrower --> patron I know you can't change all spots as the table is called borrowers_debarments, but I think it would be good to change whereever possible. Example: Lift these debarments after Borrower has paid their charges > Lift these restrictions after a patron has paid their charges See also: https://wiki.koha-community.org/wiki/Terminology 3) Number of tests The number of tests needs to be updated to 37 for tests to pass :) 4) Functionality A thing I stumbled on is that this works on the restriction comment and not the type of restriction. I believe this is done, because we can't have different types of restrictions currently and this makes it more flexible. But I am not sure if it will not also create issues. Currently the comment can only be set, if the type of restriction is MANUAL, for DISCHARGE it will be empty, possibly for OVERDUES and SUSPENSION as well. We cannot edit restrictions to add a certain comment or fix a typo. I recently reviewed bug 23681 and I think this goes in a more maintainable direction. It will allow to define restriction types in a new table with some being Koha-internal and others being added in addition. And what you do with the YAML pref could then be moved to be columns in the new table, which would make it easy to query, easy to handle for staff, etc. and remove any issues with variations of spelling/whitespace by having a list to pick from. I know this is the older dev, but maybe have a look at bug 23681? It's currently waiting for some more work, but I think it would be still achievable for the next version, especially with a little help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 01:54:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2022 23:54:10 +0000 Subject: [Koha-bugs] [Bug 30410] Add a way for plugins to register background tasks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410 --- Comment #3 from David Cook --- (In reply to Tomás Cohen Arazi from comment #2) > For this to work, plugins need to include the 'namespace' attribute in > their metadata. If they don't, they will be skipped when listing the > valid _background jobs_. What's an example 'namespace' attribute? Is that used to prevent collisions with task names? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 03:34:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 01:34:24 +0000 Subject: [Koha-bugs] [Bug 30443] New: Strip line breaks and carriage returns from input fields when cataloguing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30443 Bug ID: 30443 Summary: Strip line breaks and carriage returns from input fields when cataloguing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Line breaks and carriage returns are known to break legacy library system record imports and, text area fields in MARC records are not designed to carry formatting, therefore it is implied that the data would be saved as a plain text string with no added formatting. For users who follow these cataloguing standards, there should be a setting to ask Koha to strip these. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 03:34:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 01:34:37 +0000 Subject: [Koha-bugs] [Bug 30443] Strip line breaks and carriage returns from input fields when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30443 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30358 Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 03:34:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 01:34:37 +0000 Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30443 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 03:45:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 01:45:07 +0000 Subject: [Koha-bugs] [Bug 30443] Strip line breaks and carriage returns from input fields when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30443 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Aleisha Amohia --- Deciding to work this fix into Bug 30358. *** This bug has been marked as a duplicate of bug 30358 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 03:45:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 01:45:07 +0000 Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 --- Comment #3 from Aleisha Amohia --- *** Bug 30443 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 03:46:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 01:46:00 +0000 Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 --- Comment #4 from Aleisha Amohia --- Line breaks and carriage returns are known to break legacy library system record imports and, text area fields in MARC records are not designed to carry formatting, therefore it is implied that the data would be saved as a plain text string with no added formatting. For users who follow these cataloguing standards, there should be a setting to ask Koha to strip these. Planning to amend StripWhitespaceChars to also strip inner line breaks and carriage returns. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 04:03:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 02:03:17 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #23 from Hayley Pelham --- Created attachment 132918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132918&action=edit Bug 12029: (follow-up) Adhering to coding guidelines This is a follow-up patch which (based on comment #19) does the following: 1) Removes newline from top of Koha/Patron/Messages.pm 2) Changes method Koha::Patron::Messages->unread to ->filter_by_unread 3) Removes method Koha::Patron::Messages->unread_count 4) (Will address tests in separate patch) 5) Removes changes to Koha/Schema/Result/Message.pm 6) Changes atomicupdate from qq{} to q{} 7) (Left for RM) 8) Removes extra copyright statement in opac/dismiss_message.pl 9) Removes extra comments from opac/dismiss_message.pl 10) (Left for now) 11) (Left for now) Sponsored-by: Horowhenua Library Trust -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 04:06:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 02:06:24 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Hayley Pelham changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleypelham at catalyst.net.n | |z --- Comment #24 from Hayley Pelham --- (In reply to Martin Renvoize from comment #22) > Comment on attachment 130516 [details] [review] > Bug 12029: Patrons should be able to delete their patron messages > > Review of attachment 130516 [details] [review]: > ----------------------------------------------------------------- > > ::: installer/data/mysql/kohastructure.sql > @@ +3739,4 @@ > > `message` mediumtext COLLATE utf8mb4_unicode_ci NOT NULL COMMENT 'the text of the message', > > `message_date` timestamp NOT NULL DEFAULT current_timestamp() COMMENT 'the date and time the message was written', > > `manager_id` int(11) DEFAULT NULL COMMENT 'creator of message', > > + `patron_read_date` timestamp NULL DEFAULT NULL COMMENT 'date and time the patron dismissed the message', > > Final additional note from my own review: > > Shouldn't this be a DATETIME rather than a TIMESTAMP field? As the similar field message_date is also a timestamp I see no need to change this aspect of the patch at this stage. Please let me know if you have other reasoning! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 04:19:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 02:19:02 +0000 Subject: [Koha-bugs] [Bug 28911] Bcrypt settings are required for pseudonymization but are not set on upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28911 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- Just got stung by this one. There are quite a few settings like this I think (e.g. plugin_repos, koha_xslt_security, smtp_server). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 04:36:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 02:36:24 +0000 Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 --- Comment #5 from Aleisha Amohia --- Created attachment 132919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132919&action=edit Bug 30358: (follow-up) Also strip inner newlines This patch amends the StripWhitespaceChars system preference to also strip inner newlines (line breaks and carriage returns) when enabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 05:47:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 03:47:56 +0000 Subject: [Koha-bugs] [Bug 30444] New: Enable Shibboleth option for SelfCheck modules for Koha Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444 Bug ID: 30444 Summary: Enable Shibboleth option for SelfCheck modules for Koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Add 'Shibboleth' to the SelfCheckoutByLogin system preference, so users can sign into the self-checkout page via Shibboleth. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 05:48:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 03:48:28 +0000 Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck modules for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alexbuckley at catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23989 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 05:48:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 03:48:28 +0000 Subject: [Koha-bugs] [Bug 23989] Enable SSO options for SelfCheck modules for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23989 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30444 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 06:25:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 04:25:56 +0000 Subject: [Koha-bugs] [Bug 23352] Define serial's collection in the subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 --- Comment #41 from Alex Buckley --- Created attachment 132920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132920&action=edit Bug 23352: (follow-up) Fix QA test failure Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 06:33:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 04:33:58 +0000 Subject: [Koha-bugs] [Bug 23352] Define serial's collection in the subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #42 from Alex Buckley --- (In reply to Katrin Fischer from comment #40) > Hi Alex, > > could you take a look at the failure in QA test tools please? > > 1) QA tools > FAIL > installer/data/mysql/atomicupdate/bug_23352- > add_ccode_column_to_subscriptions_table.pl > FAIL valid > Useless use of anonymous hash ({}) in void context > > ... and nothing else. Tests pass and testing looked good. Hope above is an > easy fix! Hi Katrin, Thanks for doing QA on this patchset! I've attached a follow-up patch that, I hope, has fixed that QA test tool failure. Could you please take a look? Many thanks, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 07:28:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 05:28:42 +0000 Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck modules for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:06:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:06:26 +0000 Subject: [Koha-bugs] [Bug 30410] Add a way for plugins to register background tasks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410 --- Comment #4 from Tomás Cohen Arazi --- (In reply to David Cook from comment #3) > (In reply to Tomás Cohen Arazi from comment #2) > > For this to work, plugins need to include the 'namespace' attribute in > > their metadata. If they don't, they will be skipped when listing the > > valid _background jobs_. > > What's an example 'namespace' attribute? Is that used to prevent collisions > with task names? There's a clear example in the patches. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:14:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:14:12 +0000 Subject: [Koha-bugs] [Bug 30391] Bad JS in IntranetUserJS can break the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30391 Marie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom at musikverket.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:18:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:18:59 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:19:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:19:00 +0000 Subject: [Koha-bugs] [Bug 26740] REST API: Add endpoint for task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26740 Bug 26740 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:19:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:19:00 +0000 Subject: [Koha-bugs] [Bug 27258] Rename BackgroundJobs => Tasks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27258 Bug 27258 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:19:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:19:01 +0000 Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 Bug 27421 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:19:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:19:01 +0000 Subject: [Koha-bugs] [Bug 27434] Task Scheduler should use classes as job types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27434 Bug 27434 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:19:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:19:01 +0000 Subject: [Koha-bugs] [Bug 27756] background_jobs_worker.pl is memory inefficient In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27756 Bug 27756 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:19:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:19:02 +0000 Subject: [Koha-bugs] [Bug 29020] Missing Background jobs link in admin-home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29020 Bug 29020 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:19:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:19:02 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 Bug 29387 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:19:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:19:03 +0000 Subject: [Koha-bugs] [Bug 30172] Background jobs failing due to race condition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172 Bug 30172 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:19:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:19:03 +0000 Subject: [Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 Bug 25674 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:19:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:19:04 +0000 Subject: [Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Bug 26080 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:19:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:19:04 +0000 Subject: [Koha-bugs] [Bug 26363] Provide a systemd unit file for background_jobs_worker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 Bug 26363 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:19:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:19:04 +0000 Subject: [Koha-bugs] [Bug 26702] Remove explicit libnet-stomp-perl from debian/control.in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26702 Bug 26702 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:19:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:19:05 +0000 Subject: [Koha-bugs] [Bug 26741] Make rabbitmq-server suggested rather than required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 Bug 26741 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:19:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:19:05 +0000 Subject: [Koha-bugs] [Bug 26742] Add configuration for message broker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26742 Bug 26742 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:19:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:19:06 +0000 Subject: [Koha-bugs] [Bug 27027] Typo: has successfully been modified.. %s In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27027 Bug 27027 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:19:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:19:06 +0000 Subject: [Koha-bugs] [Bug 27109] Better labels for background job details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27109 Bug 27109 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:19:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:19:07 +0000 Subject: [Koha-bugs] [Bug 27127] Wrong display of messages if there was only 1 record modified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27127 Bug 27127 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:19:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:19:07 +0000 Subject: [Koha-bugs] [Bug 27661] Clarify error for message broker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 Bug 27661 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:19:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:19:08 +0000 Subject: [Koha-bugs] [Bug 27782] If a BackgroundJob should fail, it should NOT bring down the worker! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27782 Bug 27782 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:19:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:19:08 +0000 Subject: [Koha-bugs] [Bug 27839] koha-worker missing tab-completion in bash In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27839 Bug 27839 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:19:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:19:09 +0000 Subject: [Koha-bugs] [Bug 28413] background job worker is running with all the modules in RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28413 Bug 28413 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:19:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:19:09 +0000 Subject: [Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 Bug 28445 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:19:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:19:10 +0000 Subject: [Koha-bugs] [Bug 29178] Only users with manage_background_jobs can cancel a job In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29178 Bug 29178 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:19:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:19:10 +0000 Subject: [Koha-bugs] [Bug 29386] background jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 Bug 29386 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:19:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:19:11 +0000 Subject: [Koha-bugs] [Bug 29388] No need to decode data from misc/background_jobs_worker.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29388 Bug 29388 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:36:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 06:36:22 +0000 Subject: [Koha-bugs] [Bug 30410] Add a way for plugins to register background tasks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410 --- Comment #5 from David Cook --- (In reply to Tomás Cohen Arazi from comment #4) > There's a clear example in the patches. > Thanks My bad. I had already read the main patch but not the unit tests patch. I should've thought to look there, although I didn't think the example was that clear. I had to re-read it a few times. I suppose the plugin's "name" isn't usable since it's human-friendly and not machine friendly. A default method inherited from Koha::Plugins::Base that does something like this might be useful: sub namespace { my $namespace = lc(__PACKAGE__); $namespace =~ s/::/_/g return $namespace } I suppose free text and auto-generated both have their pros and cons... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 09:21:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 07:21:15 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Marie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom at musikverket.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 09:22:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 07:22:56 +0000 Subject: [Koha-bugs] [Bug 30380] No suggestions ASKED letter transported by email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30380 Marie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom at musikverket.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 09:47:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 07:47:39 +0000 Subject: [Koha-bugs] [Bug 29311] Do not allow editing of bibliographic information when entering suggestion from existing bibs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 09:48:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 07:48:52 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 09:48:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 07:48:56 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #165 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 09:48:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 07:48:59 +0000 Subject: [Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 09:49:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 07:49:03 +0000 Subject: [Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #70 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 09:49:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 07:49:07 +0000 Subject: [Koha-bugs] [Bug 30093] Rewrite the patron search when placing a hold with the REST API route In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 09:49:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 07:49:10 +0000 Subject: [Koha-bugs] [Bug 30093] Rewrite the patron search when placing a hold with the REST API route In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 --- Comment #41 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 09:49:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 07:49:13 +0000 Subject: [Koha-bugs] [Bug 30094] Rewrite the patron search when requesting an article with the REST API route In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30094 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 09:49:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 07:49:16 +0000 Subject: [Koha-bugs] [Bug 30094] Rewrite the patron search when requesting an article with the REST API route In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30094 --- Comment #8 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 09:49:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 07:49:20 +0000 Subject: [Koha-bugs] [Bug 30393] datatables wrapper should handle searching for %, _ and \ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30393 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 09:49:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 07:49:23 +0000 Subject: [Koha-bugs] [Bug 30393] datatables wrapper should handle searching for %, _ and \ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30393 --- Comment #8 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 09:49:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 07:49:26 +0000 Subject: [Koha-bugs] [Bug 30404] Enlarge all patron searches pop-up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30404 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 09:49:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 07:49:29 +0000 Subject: [Koha-bugs] [Bug 30404] Enlarge all patron searches pop-up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30404 --- Comment #8 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 09:50:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 07:50:04 +0000 Subject: [Koha-bugs] [Bug 30425] April fools! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30425 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Passed QA |RESOLVED CC| |fridolin.somers at biblibre.co | |m --- Comment #4 from Fridolin Somers --- Reverted from master. See you next year XD -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 10:39:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 08:39:37 +0000 Subject: [Koha-bugs] [Bug 30406] Our DT tables not filtering on the correct column if hidden by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30406 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 10:39:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 08:39:41 +0000 Subject: [Koha-bugs] [Bug 30406] Our DT tables not filtering on the correct column if hidden by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30406 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132830|0 |1 is obsolete| | --- Comment #2 from Séverine Queune --- Created attachment 132921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132921&action=edit Bug 30406: Add column filters before hiding columns The code that adds column filters works only on visible columns, so we should hide columns after filters are created Test plan: 1. Apply patch 2. Go to Tables settings. Hide city_state for the cities table. 3. Create some cities and go to the cities page 4. Verify that filtering works as expected. 5. Make the city_state column appear. Verify that filtering on this column works too Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 10:42:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 08:42:16 +0000 Subject: [Koha-bugs] [Bug 30406] Our DT tables not filtering on the correct column if hidden by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30406 --- Comment #3 from Séverine Queune --- I never thought it would be so easily fixed ! Well done Julian :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 11:52:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 09:52:50 +0000 Subject: [Koha-bugs] [Bug 30406] Our DT tables not filtering on the correct column if hidden by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30406 --- Comment #4 from Julian Maurice --- (In reply to Séverine Queune from comment #3) > I never thought it would be so easily fixed ! > Well done Julian :) Me neither :) Thanks for testing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 11:54:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 09:54:40 +0000 Subject: [Koha-bugs] [Bug 30194] Update required JSON::Validator version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala at helsinki.fi --- Comment #96 from Ere Maijala --- I think the relnotes should be expanded a bit since this affects backwards-compatibility. At least the fact that the validation is now stricter and doesn't allow the invalid refs it used to should be mentioned, as these can have a direct effect on REST API plugins. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 12:10:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 10:10:36 +0000 Subject: [Koha-bugs] [Bug 30438] Add select all/clear buttons to invoices.tt open and closed tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30438 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 12:10:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 10:10:39 +0000 Subject: [Koha-bugs] [Bug 30438] Add select all/clear buttons to invoices.tt open and closed tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30438 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132873|0 |1 is obsolete| | --- Comment #2 from Séverine Queune --- Created attachment 132922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132922&action=edit Bug 30438: Add select all/clear all buttons to invoices.tt To test: 1. Apply patch 2. Have a bunch of invoices, some open and some closed. 3. Go to Home > Acquisitions > Invoices and do a search that will return you many of those invoices, some open and some closed. 4. Notice the 'Select all' and 'Clear all' buttons. 5. Try clicking 'Select all' on the Open invoices tab. All Open invoices should become checked. 6. Try clicking 'Clear all' on the Open invoices tab. All open invoices should become unchecked. 7. Try 5 - 6 again but on the Closed invoices tab. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 12:11:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 10:11:32 +0000 Subject: [Koha-bugs] [Bug 30438] Add select all/clear buttons to invoices.tt open and closed tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30438 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr --- Comment #3 from Séverine Queune --- Nice useful one, thank you Lucas ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 12:16:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 10:16:41 +0000 Subject: [Koha-bugs] [Bug 27123] Add messages to batch patrons modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131042|0 |1 is obsolete| | --- Comment #4 from Jérémy Breuillard --- Created attachment 132923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132923&action=edit Bug 27123: Add messages to batch patrons modification With this patch you can write or delete circulation messages on the batch patrons modification form Test plan: 1)Go to Home > Tools > Batch patron modification 2)Write one or more card numbers to access the modification form 3)Notice the input you can interact with 4)Apply patch and repeat 1) & 2) 5)Notice the new input 'Message:' which appeared down the form 6)Write a message and choose a type (opac or intranet) 7)Save & notice the new 'Message' column filled up with what you wrote before 8)To delete: back on the modification form - check the checkbox beside the input - save again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 12:16:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 10:16:45 +0000 Subject: [Koha-bugs] [Bug 27123] Add messages to batch patrons modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123 --- Comment #5 from Jérémy Breuillard --- Created attachment 132924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132924&action=edit Bug 27123: Add filter + translate comment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 12:16:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 10:16:50 +0000 Subject: [Koha-bugs] [Bug 27123] Add messages to batch patrons modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123 --- Comment #6 from Jérémy Breuillard --- Created attachment 132925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132925&action=edit Bug 27123: whitespaces deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 12:16:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 10:16:54 +0000 Subject: [Koha-bugs] [Bug 27123] Add messages to batch patrons modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123 --- Comment #7 from Jérémy Breuillard --- Created attachment 132926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132926&action=edit Bug 27123: Delete useless code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 12:16:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 10:16:58 +0000 Subject: [Koha-bugs] [Bug 27123] Add messages to batch patrons modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123 --- Comment #8 from Jérémy Breuillard --- Created attachment 132927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132927&action=edit Bug 27123: Remove Dumpers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 12:17:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 10:17:41 +0000 Subject: [Koha-bugs] [Bug 27123] Add messages to batch patrons modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 12:18:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 10:18:11 +0000 Subject: [Koha-bugs] [Bug 27123] Add messages to batch patrons modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 12:32:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 10:32:26 +0000 Subject: [Koha-bugs] [Bug 30436] Convert article requests tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr Status|Needs Signoff |Failed QA --- Comment #2 from Séverine Queune --- Hi Owen ! After I applied the patch, the 'Select all' and 'Clear all' options don't work any more in the 'Pending' and 'Processing' tab. Everything else is ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 12:47:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 10:47:45 +0000 Subject: [Koha-bugs] [Bug 30436] Convert article requests tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 12:47:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 10:47:49 +0000 Subject: [Koha-bugs] [Bug 30436] Convert article requests tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132870|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 132928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132928&action=edit Bug 30436: Convert article requests tabs to Bootstrap This patch converts the jQuery tabs on the article requests page to Bootstrap. To test you should have the "ArticleRequests" system preference enabled. If necessary, create some article requests and mark some "Pending," some "Processing," and leave some new. - Apply the patch and go to Circulation -> Article requests. - The page should show three tabs: New, Pending, and Processing. - The tabs should look correct and work correctly. - The DataTables under each tab should work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 12:55:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 10:55:53 +0000 Subject: [Koha-bugs] [Bug 29450] Allow flatPickr to instantiate in any order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29450 --- Comment #4 from Owen Leonard --- Can you remember where you observed this bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:04:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:04:59 +0000 Subject: [Koha-bugs] [Bug 2222] Field auth_subfield_structure.frameworkcode should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2222 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132832|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:05:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:05:01 +0000 Subject: [Koha-bugs] [Bug 2222] Field auth_subfield_structure.frameworkcode should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2222 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132833|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:05:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:05:04 +0000 Subject: [Koha-bugs] [Bug 2222] Field auth_subfield_structure.frameworkcode should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2222 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132834|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:05:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:05:07 +0000 Subject: [Koha-bugs] [Bug 2222] Field auth_subfield_structure.frameworkcode should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2222 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132835|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:05:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:05:11 +0000 Subject: [Koha-bugs] [Bug 2222] Field auth_subfield_structure.frameworkcode should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2222 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132836|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:05:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:05:14 +0000 Subject: [Koha-bugs] [Bug 2222] Field auth_subfield_structure.frameworkcode should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2222 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132837|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:05:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:05:16 +0000 Subject: [Koha-bugs] [Bug 2222] Field auth_subfield_structure.frameworkcode should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2222 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132840|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:05:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:05:18 +0000 Subject: [Koha-bugs] [Bug 2222] Field auth_subfield_structure.frameworkcode should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2222 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132841|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:10:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:10:44 +0000 Subject: [Koha-bugs] [Bug 30445] New: Move translatable strings out of cataloging_additem.inc and into JavaScript Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30445 Bug ID: 30445 Summary: Move translatable strings out of cataloging_additem.inc and into JavaScript Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr, testopia at bugs.koha-community.org Strings defined for translation in cataloging_additem.inc can now be wrapped in the new translation function and put in cataloging_additem.js. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:11:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:11:01 +0000 Subject: [Koha-bugs] [Bug 2222] Field auth_subfield_structure.frameworkcode should not be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2222 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Field |Field |auth_subfield_structure.fra |auth_subfield_structure.fra |meworkcode should be |meworkcode should not be |removed |removed Resolution|--- |WORKSFORME Status|ASSIGNED |RESOLVED --- Comment #16 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #1) > This is still actual. > We do not need frameworkcode in this table, we have authtypecode. > Let's remove this field now ! This was a dumb exercise. There are a few see also fields that need it. Title changed accordingly :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:11:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:11:06 +0000 Subject: [Koha-bugs] [Bug 30445] Move translatable strings out of cataloging_additem.inc and into JavaScript In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30445 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21156 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:11:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:11:06 +0000 Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30445 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30445 [Bug 30445] Move translatable strings out of cataloging_additem.inc and into JavaScript -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:11:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:11:26 +0000 Subject: [Koha-bugs] [Bug 2222] Field auth_subfield_structure.frameworkcode should not be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2222 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Large patch |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:12:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:12:14 +0000 Subject: [Koha-bugs] [Bug 2222] Field auth_subfield_structure.frameworkcode should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2222 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|m.de.rooy at rijksmuseum.nl |koha-bugs at lists.koha-commun | |ity.org Summary|Field |Field |auth_subfield_structure.fra |auth_subfield_structure.fra |meworkcode should not be |meworkcode should be |removed |removed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:13:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:13:54 +0000 Subject: [Koha-bugs] [Bug 2222] Field auth_subfield_structure.frameworkcode should NOT be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2222 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Field |Field |auth_subfield_structure.fra |auth_subfield_structure.fra |meworkcode should be |meworkcode should NOT be |removed |removed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:30:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:30:38 +0000 Subject: [Koha-bugs] [Bug 30386] Prevent search errors if deleted record still remains in search indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30386 --- Comment #2 from Owen Leonard --- I could not reproduce this error. I also tried this test plan: 1) Enable item-level_itypes 2) Create 3 records in Koha that share a word 3) Ran koha-rebuild-zebra 4) Search for that word, note your 3+ results 5) Ran koha-indexer --stop kohadev 6) delete from biblio where biblionumber = XXX; 7) Searched again, deleted record still returned along with the others. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:36:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:36:51 +0000 Subject: [Koha-bugs] [Bug 30426] suggestion service missing Auth and Output imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30426 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:36:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:36:55 +0000 Subject: [Koha-bugs] [Bug 30426] suggestion service missing Auth and Output imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30426 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132813|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 132929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132929&action=edit Bug 30426: Add missing C4::Auth and C4::Output imports This patch adds missing function imports for C4::Auth and C4::Output in the opac/svc/suggestion script. Test plan: 1. Go to http://localhost:8081/cgi-bin/koha/admin/didyoumean.pl 2. Turn on some plugins 3. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 4. Note in your browser's Network tab that the call to http://localhost:8080/cgi-bin/koha/svc/suggestion?render=stub&q=test generates a 200 response instead of a 500 error Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:40:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:40:20 +0000 Subject: [Koha-bugs] [Bug 30409] barcodedecode() should always trim barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard --- Could you please add a test plan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:43:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:43:10 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:45:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:45:17 +0000 Subject: [Koha-bugs] [Bug 27619] Remove fr-FR installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 --- Comment #4 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #2) > This did not move recently. > On bug 2222 I want to remove auth_subfield_structure.frameworkcode. > That gives a lot of changes in especially the fr-FR SQL files. > Would you support doing that first ? I cant remove that field. Scratch this remark. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:46:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:46:26 +0000 Subject: [Koha-bugs] [Bug 30446] New: Add a test for GetTagsLabels Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30446 Bug ID: 30446 Summary: Add a test for GetTagsLabels Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Just a remainder from an experiment on bug 2222. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:46:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:46:34 +0000 Subject: [Koha-bugs] [Bug 30446] Add a test for GetTagsLabels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30446 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:48:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:48:47 +0000 Subject: [Koha-bugs] [Bug 30432] get_items_that_can_fill needs to specify table for biblionumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:48:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:48:51 +0000 Subject: [Koha-bugs] [Bug 30432] get_items_that_can_fill needs to specify table for biblionumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132862|0 |1 is obsolete| | Attachment #132863|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 132930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132930&action=edit Bug 30432: Unit test Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:48:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:48:55 +0000 Subject: [Koha-bugs] [Bug 30432] get_items_that_can_fill needs to specify table for biblionumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432 --- Comment #4 from Owen Leonard --- Created attachment 132931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132931&action=edit Bug 30432: Specify 'me' for biblionumber when limiting items To test: 1 - Apply only unit tests 2 - prove t/db_dependent/Koha/Holds.t 3 - It fails 4 - Apply this patch 5 - prove t/db_dependent/Koha/Holds.t 6 - It passes! Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:54:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:54:07 +0000 Subject: [Koha-bugs] [Bug 30446] Add a test for GetTagsLabels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30446 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:54:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:54:10 +0000 Subject: [Koha-bugs] [Bug 30446] Add a test for GetTagsLabels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30446 --- Comment #1 from Marcel de Rooy --- Created attachment 132932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132932&action=edit Bug 30446: Add a test for GetTagsLabels Moved from obsoleted bug 2222 on its own. Test plan: Run t/db_dependent/Authority/GetTagsLabels.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:54:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:54:39 +0000 Subject: [Koha-bugs] [Bug 30446] Add a test for GetTagsLabels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30446 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #2 from Marcel de Rooy --- Adding self SO: only simple unit test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:58:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:58:36 +0000 Subject: [Koha-bugs] [Bug 20397] Implement Content Security Policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20397 Jake Deery changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jake.deery at ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:58:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 11:58:56 +0000 Subject: [Koha-bugs] [Bug 10787] Linked Data/RDF Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10787 Jake Deery changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jake.deery at ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 14:02:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 12:02:29 +0000 Subject: [Koha-bugs] [Bug 30436] Convert article requests tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 14:02:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 12:02:33 +0000 Subject: [Koha-bugs] [Bug 30436] Convert article requests tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132928|0 |1 is obsolete| | --- Comment #4 from Séverine Queune --- Created attachment 132933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132933&action=edit Bug 30436: Convert article requests tabs to Bootstrap This patch converts the jQuery tabs on the article requests page to Bootstrap. To test you should have the "ArticleRequests" system preference enabled. If necessary, create some article requests and mark some "Pending," some "Processing," and leave some new. - Apply the patch and go to Circulation -> Article requests. - The page should show three tabs: New, Pending, and Processing. - The tabs should look correct and work correctly. - The DataTables under each tab should work correctly. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 14:03:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 12:03:56 +0000 Subject: [Koha-bugs] [Bug 30436] Convert article requests tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 --- Comment #5 from Séverine Queune --- Thank you Owen for the quick rebase, everything works fine now ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 14:09:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 12:09:48 +0000 Subject: [Koha-bugs] [Bug 30447] New: pendingreserves.pl is checking too many transfers Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30447 Bug ID: 30447 Summary: pendingreserves.pl is checking too many transfers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 26057 added a 'cancellationdate' column to branchtransfers The code in pendingreserves.pl checks against transfers like: 'itembib.itemnumber' => { -not_in => \'SELECT itemnumber FROM branchtransfers WHERE datearrived IS NULL' } This needs to be updated to: 'itembib.itemnumber' => { -not_in => \'SELECT itemnumber FROM branchtransfers WHERE datearrived IS NULL AND datecancelled IS NULL' } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 14:13:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 12:13:10 +0000 Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on fresh install, but can be null with upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 14:13:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 12:13:14 +0000 Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on fresh install, but can be null with upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132819|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 132934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132934&action=edit Bug 27253: Fix definition of updated_on in borrowers and deletedborrowers Test plan: 1. First you have to be in a state where updated_on is NULL-able. You can do that by either: a) do a fresh install of Koha 16.05 and update to master, or b) execute the following SQL queries: ALTER TABLE borrowers MODIFY updated_on timestamp NULL DEFAULT current_timestamp() ON UPDATE current_timestamp() COMMENT 'time of last change could be useful for synchronization with external systems (among others)' ALTER TABLE deletedborrowers MODIFY updated_on timestamp NULL DEFAULT current_timestamp() ON UPDATE current_timestamp() COMMENT 'time of last change could be useful for synchronization with external systems (among others)' 2. Create two borrowers (let's name them X and Y) 3. Delete borrower Y 4. Set the column updated_on to NULL for both borrowers by executing the following SQL query: UPDATE borrowers SET updated_on = NULL WHERE borrowernumber = UPDATE deletedborrowers SET updated_on = NULL WHERE borrowernumber = 5. Apply patch and run updatedatabase 6. Verify that borrowers.updated_on and deletedborrowers.updated_on are not NULL-able. Verify that updated_on for X and Y have taken the value of dateenrolled. 7. Repeat step 2 to 6 but this time renew the patron and/or log in with its account in order to set the columns borrowers.date_renewed and borrowers.lastseen before executing updatedatabase borrowers.updated_on should take the greatest value among dateenrolled, date_renewed, and lastseen Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 14:22:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 12:22:31 +0000 Subject: [Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 14:25:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 12:25:13 +0000 Subject: [Koha-bugs] [Bug 30447] pendingreserves.pl is checking too many transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30447 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 14:25:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 12:25:16 +0000 Subject: [Koha-bugs] [Bug 30447] pendingreserves.pl is checking too many transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30447 --- Comment #1 from Nick Clemens --- Created attachment 132935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132935&action=edit Bug 30447: Check if transfers arrived or cancelled TO test: 1 - Find a bib with a single item 2 - Browse to Circulation->Transfer 3 - Transfer the item to another branch 4 - Check the item in at current branch and cancel the transfer on the dialog 5 - Place a hold on the biblio for a patron at current branch 6 - Browse to Circulation->Holds to pull 7 - Item does not show 8 - Apply patch, restart all 9 - Browse to Circulation->Holds to pull 10 - Item shows -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 14:31:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 12:31:38 +0000 Subject: [Koha-bugs] [Bug 30448] New: CircConfirmItemParts works differently depending on staff permissions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30448 Bug ID: 30448 Summary: CircConfirmItemParts works differently depending on staff permissions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If a library has turned on the system preference CircConfirmItemParts, the option to confirm the message in the 952$3 is turned on. However, if a staff member doesn't have the permission, Force checkout if a limitation exists, the staff member at checkout will not get the option of checkout or not checkout, they will just see a "continue" option. At check-in, the staff member without the force's permission will see the appropriate options. Test: !. Turn on system preference, circconfirmitemparts 2. Have a staff member without permission, "Force checkout if a limitation exists " check out a book with text in 952$y. 3. Observe staff will only see the yellow box, with the option to continue. 4. Have a staff member with this permission, Force checkout if a limitation exists " check out a book with text in the 952$y, see they get a yellow box with the option to "yes checkout" or "no checkout" We should have this consistent regardless of permission. The confirmcircparts option is important to libraries to identify to their staff that there are steps to be done prior to checkout. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:01:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 13:01:04 +0000 Subject: [Koha-bugs] [Bug 30449] New: Missing FK constraint on borrower_attribute_types Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449 Bug ID: 30449 Summary: Missing FK constraint on borrower_attribute_types Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Not in kohastructure, but present for a long time already in updatedatabase: $DBversion = "3.07.00.034"; $dbh->do("ALTER TABLE borrower_attribute_types ADD CONSTRAINT category_code_fk FOREIGN KEY (category_code) REFERENCES categories(categorycode)"); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:07:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 13:07:58 +0000 Subject: [Koha-bugs] [Bug 30448] CircConfirmItemParts works differently depending on staff permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30448 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Kelly McElligott --- *** This bug has been marked as a duplicate of bug 29504 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:07:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 13:07:58 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com --- Comment #20 from Kelly McElligott --- *** Bug 30448 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:12:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 13:12:49 +0000 Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 --- Comment #73 from David Gustafsson --- Created attachment 132936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132936&action=edit Bug 20551: Fetch deleted biblios through _get_record_export -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:25:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 13:25:39 +0000 Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 --- Comment #74 from David Gustafsson --- Created attachment 132937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132937&action=edit Bug 20551: Refactor unmotivated partially applied validator function -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:30:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 13:30:31 +0000 Subject: [Koha-bugs] [Bug 30402] Authority import hanging when replacing matched record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30402 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:30:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 13:30:34 +0000 Subject: [Koha-bugs] [Bug 30402] Authority import hanging when replacing matched record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30402 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132494|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 132938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132938&action=edit Bug 30402: Import authorities subroutines to ImportBatch script The following authorities subroutines are used by the ImportBatch script but are not accessible, because they aren't imported. This caused MARC importing errors. - GetAuthorityXML - ModAuthority - DelAuthority These affected the BatchCommitRecords and BatchRevertRecords routines, and it wasn't caught because there are no tests written for them. To test: 1. Find an existing authority record, or import one to use. 2. Save this authority record (export/download). 3. Go to Admin -> Record matching rules. Create a new record matching rule for authorities that matches on 001, Local-Number index. 4. Go to Tools -> Stage MARC for import. Upload the authority file you just downloaded. 5. Change record type to authority. 6. Under 'Look for existing items in catalog?', set the record matching rule to the rule you just made which matches on 001. If matching record found, replace the existing one. If no match is found, ignore. 7. Stage the record. Once complete, a match should've been found. 8. Go to Staged MARC management. 9. Import the batch into the catalog. Notice it hangs and never completes. 10. Apply the patch and restart services. 11. Repeat steps 4-9. This time importing should be successful. Sponsored-by: Educational Services Australia SCIS Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:32:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 13:32:35 +0000 Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #75 from David Gustafsson --- Thanks again for the feedback, I think at least the most important issues should now be fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:39:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 13:39:06 +0000 Subject: [Koha-bugs] [Bug 30424] Reindent advanced search template in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30424 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:39:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 13:39:10 +0000 Subject: [Koha-bugs] [Bug 30424] Reindent advanced search template in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30424 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132865|0 |1 is obsolete| | --- Comment #3 from Séverine Queune --- Created attachment 132939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132939&action=edit Bug 30424: Reindent advanced search template in the staff interface This patch reindents the advanced search template. Some lines have been split to make the markup more readable. To test, apply the patch and test the advanced search page in the staff interface. Everything should work as normal. Be sure to test both the "More options" and "Fewer options" views. When viewing the diff for this change, ignore whitespace. The only visible changes should be split lines. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:39:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 13:39:14 +0000 Subject: [Koha-bugs] [Bug 30424] Reindent advanced search template in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30424 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132866|0 |1 is obsolete| | --- Comment #4 from Séverine Queune --- Created attachment 132940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132940&action=edit Bug 30424: (follow-up) Markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:39:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 13:39:18 +0000 Subject: [Koha-bugs] [Bug 29783] Account lockout message appears incorrectly for blank userid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29783 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:45:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 13:45:39 +0000 Subject: [Koha-bugs] [Bug 30424] Reindent advanced search template in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30424 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr --- Comment #5 from Séverine Queune --- Nice re-indentation Owen ! Everything seemed ok for me using the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:48:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 13:48:24 +0000 Subject: [Koha-bugs] [Bug 30447] pendingreserves.pl is checking too many transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30447 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:48:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 13:48:28 +0000 Subject: [Koha-bugs] [Bug 30447] pendingreserves.pl is checking too many transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30447 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132935|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 132941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132941&action=edit Bug 30447: Check if transfers arrived or cancelled TO test: 1 - Find a bib with a single item 2 - Browse to Circulation->Transfer 3 - Transfer the item to another branch 4 - Check the item in at current branch and cancel the transfer on the dialog 5 - Place a hold on the biblio for a patron at current branch 6 - Browse to Circulation->Holds to pull 7 - Item does not show 8 - Apply patch, restart all 9 - Browse to Circulation->Holds to pull 10 - Item shows Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 16:02:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 14:02:45 +0000 Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard --- This seems to work but the test does pass: t/db_dependent/Biblio/ModBiblioMarc.t .. 1/2 # Failed test 'Title still has whitespace characters because StripWhitespaceChars is disabled' # at t/db_dependent/Biblio/ModBiblioMarc.t line 67. # got: 'My title' # expected: ' My title # ' # Looks like you failed 1 test of 3. # Failed test 'StripWhitespaceChars tests' # at t/db_dependent/Biblio/ModBiblioMarc.t line 75. # Looks like you failed 1 test of 2. t/db_dependent/Biblio/ModBiblioMarc.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/2 subtests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 16:10:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 14:10:08 +0000 Subject: [Koha-bugs] [Bug 22659] Add 'save and continue' functionality to news and HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22659 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr Status|Needs Signoff |Failed QA --- Comment #13 from Séverine Queune --- If I follow Katrin's test plan : 1) Add a new HTML customization 2) Leave title empty 3) Save and continue --> no more redirection problems Katrin found, but the 'Content' field is reset This problem (or expected behaviour ?) exists for 'News' menu but only for the language specific tabs. For 'Default' tab, we have a warning pop-up asking to specify a title. I think it should be the same for 'HTML customization' menu. I also noticed that for HTML menu, it's possible to save a content only for a specific language without any content in 'Default' : is that expected ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 16:21:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 14:21:07 +0000 Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #17 from Owen Leonard --- I'm getting an error from the test: t/db_dependent/HoldsQueue.t .. 1/58 No property queue for Koha::BackgroundJob::BatchUpdateBiblioHoldsQueue# Looks like your test exited with 11 just after 2. t/db_dependent/HoldsQueue.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 56/58 subtests Test Summary Report ------------------- t/db_dependent/HoldsQueue.t (Wstat: 2816 Tests: 2 Failed: 0) Non-zero exit status: 11 Parse errors: Bad plan. You planned 58 tests but ran 2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 16:41:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 14:41:20 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 --- Comment #37 from David Gustafsson --- Created attachment 132942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132942&action=edit Bug 29440: Fix QA-tool issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 16:41:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 14:41:40 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 16:45:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 14:45:33 +0000 Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #18 from Tomás Cohen Arazi --- (In reply to Owen Leonard from comment #17) > I'm getting an error from the test: > > t/db_dependent/HoldsQueue.t .. 1/58 No property queue for > Koha::BackgroundJob::BatchUpdateBiblioHoldsQueue# Looks like your test > exited with 11 just after 2. > t/db_dependent/HoldsQueue.t .. Dubious, test returned 11 (wstat 2816, 0xb00) > Failed 56/58 subtests > > Test Summary Report > ------------------- > t/db_dependent/HoldsQueue.t (Wstat: 2816 Tests: 2 Failed: 0) > Non-zero exit status: 11 > Parse errors: Bad plan. You planned 58 tests but ran 2. You need to run dbic on one of the dependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 16:58:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 14:58:26 +0000 Subject: [Koha-bugs] [Bug 21083] Batch patron modification does not allow to modify repeatable patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21083 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr Status|Needs Signoff |Failed QA --- Comment #4 from Séverine Queune --- I not sure I totally understood the expected behaviour of this patch, but here as some feedback about my first quick tests. If patrons have several entries for one attribute, the batch modification replace all the attributes by only the new value. I assume so but can you confirm it's the behaviour expected ? I also noticed : - when I check the box to empty the field, I still have empty entries in database instead of having no entries at all, e.g; : select * from borrower_attributes --> id borrowernumber code attribute --> 124 21 disc Maths --> 125 21 disc --> 126 21 disc Maths Shouldn't line 125 have been deleted ? -you can create several empty datas : to reproduce, select an attribute, checkbox the box, add the same attribute and check the box again. Is there a way to lock the use of an attribute that is selected 'to delete' ? Expect that points, I've tests with both free input and authorized values linked attributes and it seems to work quite fine. Failed though for the empty data issues in borrower_attributes table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 17:01:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 15:01:05 +0000 Subject: [Koha-bugs] [Bug 28264] Transaction type is empty in cash register statistics wizard report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28264 --- Comment #10 from Katrin Fischer --- I see this problem in a 20.11.16 :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 17:07:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 15:07:28 +0000 Subject: [Koha-bugs] [Bug 27859] MARC export for search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |severine.queune at bulac.fr --- Comment #10 from Séverine Queune --- Sorry David, patch needs rebase :/ Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27859: marc search result export Using index info to reconstruct a base tree... M Koha/SearchEngine/Elasticsearch/Search.pm M catalogue/search.pl M installer/data/mysql/mandatory/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Auto-merging installer/data/mysql/mandatory/sysprefs.sql Auto-merging catalogue/search.pl Auto-merging Koha/SearchEngine/Elasticsearch/Search.pm CONFLICT (content): Merge conflict in Koha/SearchEngine/Elasticsearch/Search.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 27859: marc search result export hint: Use 'git am --show-current-patch=diff' to see the failed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 17:17:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 15:17:40 +0000 Subject: [Koha-bugs] [Bug 20397] Implement Content Security Policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20397 --- Comment #5 from Jake Deery --- Hi, We are seeing more and more customers flag this in their security audits. Is there anything that can be done to expedite this bug (I was planning on taking a look at this myself in the near future, but if anyone has already taken an in-depth look, I would be more than happy to collaborate / offer a helping hand). In the land of Moodle, of which I was previously familiar, we used a combination of a SASS compiler to generate and deposit CSS user customisations from database to a file, and JShint to do the same for user JS user customisations. This has the added benefit of not having to call a Perl script more than once. Could this be applicable to Koha's usecase? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 17:19:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 15:19:41 +0000 Subject: [Koha-bugs] [Bug 30450] New: Batch extend due dates should filter on-site checkouts Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30450 Bug ID: 30450 Summary: Batch extend due dates should filter on-site checkouts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: severine.queune at bulac.fr QA Contact: testopia at bugs.koha-community.org The 'batch extend due dates' menu should have an option to unselect/exclude on-site checkouts form the batch modification. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 17:22:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 15:22:10 +0000 Subject: [Koha-bugs] [Bug 22632] Add logging of merged patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 17:22:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 15:22:32 +0000 Subject: [Koha-bugs] [Bug 20397] Implement Content Security Policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20397 --- Comment #6 from Michal Denar --- Hi, we can take inspiration from VuFind. It's not in Perl, but the basic principle is the same or similar. https://vufind.org/wiki/administration:security:content_security_policy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 17:31:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 15:31:20 +0000 Subject: [Koha-bugs] [Bug 30451] New: Delete a subscription delete the linked order Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30451 Bug ID: 30451 Summary: Delete a subscription delete the linked order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: severine.queune at bulac.fr QA Contact: testopia at bugs.koha-community.org Several issues happened when you delete a subscription linked to an order : - the warning message doesn't mentioned an existing order - the deletion of the subscription deleted the order too. That's annoying... I think the deletion should only empty the aqorder.subscriptionid datafield. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 17:50:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 15:50:02 +0000 Subject: [Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 17:50:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 15:50:07 +0000 Subject: [Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132801|0 |1 is obsolete| | Attachment #132802|0 |1 is obsolete| | --- Comment #24 from Owen Leonard --- Created attachment 132943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132943&action=edit Bug 28371: Unit tests Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 17:50:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 15:50:12 +0000 Subject: [Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371 --- Comment #25 from Owen Leonard --- Created attachment 132944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132944&action=edit Bug 28371: Passpreviously fetched branches and itemtypes through and fetch all needed AV at once This patch updates the searchResuls code to pass through the pre-constructed branches and itemtype lookups to XSLTParse4Display to avoid repeating this It also updates getAuthorisedValues4MARCSubfields to fetch the values for mapped subfields and pass then through to transforMarc4XSLT Note that we currently blank invalid branches and itemtypes - I presrve this, we should open another bug if we want to change this behaviour Changes are covered by tests To test: 1 - Perform searches in OPAC and staff client that return many records 2 - Use the 'Network' tab on the browser console (opened with F12 usually) to see the time taken 3 - Note the speed before the patch 4 - Apply patch 5 - restart all the things 6 - Note improvement in speed **Note: The improvement is more drastic the more items per record, try adding large numbers of items to your search results to test** Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 18:10:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 16:10:50 +0000 Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #62 from Shi Yao Wang --- Created attachment 132945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132945&action=edit Bug 27113: Removes items in OPACHiddenItems from autocomplete Items specified in OPACHiddenItems preference are removed from search suggestions in OPAC. Test plan: 1- Search for an item. Notice that the autocomplete functionnality is not available. (See "Result" attachment) 2- Make sure that you are using Elasticsearch as your searching engine. (Preference->SearchEngine->ElasticSearch) 3- Apply the patch. 4- Run ./installer/data/mysql/updatedatabase.pl 5- Looks for the following preferences : - IntranetAutocompleteElasticSearch - OPACAutocompleteElasticSearch 6- Set their value to show. 7- Rebuild the OPAC and staff client CSS (This step is important because the autocomplete CSS is moved to the main SCSS file): Instructions here: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 8- Search for an item and notice that the autocomplete functionnality is now available. 9- In the staff interface, go in "Search the catalog". 10- Notice that the buggy behavior is now fixed. 11- Search for an item with basic search and click on one of the options. 12- Notice it automatically sends you to the selected items page. 13- This time, search an item using the advanced search and click on one of the options. 14- Notice it just writes the chosen option in the input instead. 15- Go to Administration -> system preferences -> OPACHiddenItems. 16- Define a rule that applies to an existing item. 17- Search that item in OPAC and notice it doesn't give you the suggestion for that item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 18:13:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 16:13:31 +0000 Subject: [Koha-bugs] [Bug 30452] New: Add ability to use more than one Claims Returned status Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30452 Bug ID: 30452 Summary: Add ability to use more than one Claims Returned status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Other systems distinguish between "claims returned" and "claims never had." To replicate this distinction, it would be helpful if Koha could tie multiple LOST values to claims and allow the user to select which to use when creating the claim. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 18:16:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 16:16:45 +0000 Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shi-yao.wang at inLibro.com --- Comment #63 from Shi Yao Wang --- My concern is that searching with more than 1 prefix is going to be too slow when there are lots of items since it will go through a triple nested loop. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 18:24:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 16:24:00 +0000 Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #64 from Shi Yao Wang --- Sorry. I meant double nested loops. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 18:37:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 16:37:47 +0000 Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132945|0 |1 is obsolete| | --- Comment #65 from Shi Yao Wang --- Created attachment 132946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132946&action=edit Bug 27113: Removes items in OPACHiddenItems from autocomplete Items specified in OPACHiddenItems preference are removed from search suggestions in OPAC. Test plan: 1- Search for an item. Notice that the autocomplete functionnality is not available. (See "Result" attachment) 2- Make sure that you are using Elasticsearch as your searching engine. (Preference->SearchEngine->ElasticSearch) 3- Apply the patch. 4- Run ./installer/data/mysql/updatedatabase.pl 5- Looks for the following preferences : - IntranetAutocompleteElasticSearch - OPACAutocompleteElasticSearch 6- Set their value to show. 7- Rebuild the OPAC and staff client CSS (This step is important because the autocomplete CSS is moved to the main SCSS file): Instructions here: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 8- Search for an item and notice that the autocomplete functionnality is now available. 9- In the staff interface, go in "Search the catalog". 10- Notice that the buggy behavior is now fixed. 11- Search for an item with basic search and click on one of the options. 12- Notice it automatically sends you to the selected items page. 13- This time, search an item using the advanced search and click on one of the options. 14- Notice it just writes the chosen option in the input instead. 15- Go to Administration -> system preferences -> OPACHiddenItems. 16- Define a rule that applies to an existing item. 17- Search that item in OPAC and notice it doesn't give you the suggestion for that item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 18:38:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 16:38:50 +0000 Subject: [Koha-bugs] [Bug 30453] New: Convert offline circulation tabs to Bootstrap Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30453 Bug ID: 30453 Summary: Convert offline circulation tabs to Bootstrap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Blocks: 29226 Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in the offline circulation template with Bootstrap. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 18:38:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 16:38:50 +0000 Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30453 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30453 [Bug 30453] Convert offline circulation tabs to Bootstrap -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 18:45:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 16:45:29 +0000 Subject: [Koha-bugs] [Bug 20397] Implement Content Security Policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20397 --- Comment #7 from Jake Deery --- Hi Michal, I agree; long-term, having a syspref or sysprefs to manage these things would be preferable. In the meantime, I think our starting goal should be implementing something along the lines of: # Disable unsafe inline/eval, only allow loading of resources (images, fonts, scripts, etc.) over https # Note that this does not provide any XSS protection Content-Security-Policy: default-src https: ... as a basic (mandatory) rule. It does not provide any real security gains, but it begins to encourage good practice regarding not placing JavaScript inline in future (as it simply won't work). Once we've covered this as a base, I think that would be the time to move on to adding stricter and more customisable CSP headers. Discussion time; what are everyone's thoughts on this? I could perhaps write a patch as a proof-of-concept? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 18:46:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 16:46:02 +0000 Subject: [Koha-bugs] [Bug 10787] Linked Data/RDF Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10787 Jake Deery changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jake.deery at ptfs-europe.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 18:56:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 16:56:59 +0000 Subject: [Koha-bugs] [Bug 20424] New UNIMARC ZEBRA indexes according to last IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424 Thibault Keromnès changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #23 from Thibault Keromnès --- Does what it's supposed to do but we need to clarify a few changes in the code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 19:25:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 17:25:42 +0000 Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 --- Comment #25 from Owen Leonard --- Created attachment 132947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132947&action=edit Bug 29066: (follow-up) Use tooltip when SearchMyLibraryFirst in effect This patch proposes to add a Bootstrap tooltip to the OPAC masthead's search field to indicate to the user when SearchMyLibraryFirst is in effect. I think this lets the form layout stay clean-looking and is more informative to the user because they don't have to look for the HTML title tag tooltip. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Administration -> Global system preferences. - Set the OpacAddMastheadLibraryPulldown preference to "Don't add." - Set the SearchMyLibraryFirst preference to "Limit." - Go to the OPAC and confirm that the main search field in the masthead has a filter icon in the background, indicating that searches will be limited. - Hover your mouse over the search field and a tooltip should pop up, "Searching in only" - The message should also be triggered when you click inside the form field. - Change the OpacAddMastheadLibraryPulldown and SearchMyLibraryFirst preferences again and the form should return to its normal behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 19:27:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 17:27:51 +0000 Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 --- Comment #26 from Owen Leonard --- I'm not trying to derail the progress of this patch, but I thought this follow-up would be helpful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 19:45:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 17:45:25 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #44 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #43) > (In reply to Tomás Cohen Arazi from comment #42) > > (In reply to Jonathan Druart from comment #41) > > > Why is it bad to use __()? > > > It will get translated the usual way by translators. > > > > I might be wrong, but have the feeling that any place in which all (say) > > borrower table columns need to be displayed, will imply N file accesses if > > there's no caching of the file. > > You are wrong. Translations are cached, see Koha::I18N->init Thanks for explaining! > > I tested it to work correctly and didn't notice any drawbacks, but got me > > thinking of the approach. > > This is the correct way, we need to let perl code access the translation of > columns. Think CSV headers for instance, now we have to use TT for that, and > build the CSV manually when we could use a dedicated library (Text::CSV_XS > in our case). See also the code for reports to see how easy it is now. Gotcha. This is ready then :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 19:48:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 17:48:34 +0000 Subject: [Koha-bugs] [Bug 30454] New: Convert holds awaiting pickup tabs to Bootstrap Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30454 Bug ID: 30454 Summary: Convert holds awaiting pickup tabs to Bootstrap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Blocks: 29226 Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in the holds awaiting pickup template with Bootstrap. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 19:48:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 17:48:34 +0000 Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30454 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30454 [Bug 30454] Convert holds awaiting pickup tabs to Bootstrap -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 19:51:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 17:51:37 +0000 Subject: [Koha-bugs] [Bug 27783] Introduce background job queues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 --- Comment #27 from Tomás Cohen Arazi --- Created attachment 132948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132948&action=edit Bug 27783: DBIC update [DO NOT PUSH] Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 19:53:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 17:53:00 +0000 Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #19 from Tomás Cohen Arazi --- (In reply to Tomás Cohen Arazi from comment #18) > (In reply to Owen Leonard from comment #17) > > I'm getting an error from the test: > > > > t/db_dependent/HoldsQueue.t .. 1/58 No property queue for > > Koha::BackgroundJob::BatchUpdateBiblioHoldsQueue# Looks like your test > > exited with 11 just after 2. > > t/db_dependent/HoldsQueue.t .. Dubious, test returned 11 (wstat 2816, 0xb00) > > Failed 56/58 subtests > > > > Test Summary Report > > ------------------- > > t/db_dependent/HoldsQueue.t (Wstat: 2816 Tests: 2 Failed: 0) > > Non-zero exit status: 11 > > Parse errors: Bad plan. You planned 58 tests but ran 2. > > You need to run dbic on one of the dependencies I've added a [DO NOT PUSH] patch on bug 27783 for that. Please retry :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 20:14:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 18:14:04 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 20:14:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 18:14:08 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132918|0 |1 is obsolete| | --- Comment #25 from Owen Leonard --- Created attachment 132949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132949&action=edit Bug 12029: (follow-up) Adhering to coding guidelines This is a follow-up patch which (based on comment #19) does the following: 1) Removes newline from top of Koha/Patron/Messages.pm 2) Changes method Koha::Patron::Messages->unread to ->filter_by_unread 3) Removes method Koha::Patron::Messages->unread_count 4) (Will address tests in separate patch) 5) Removes changes to Koha/Schema/Result/Message.pm 6) Changes atomicupdate from qq{} to q{} 7) (Left for RM) 8) Removes extra copyright statement in opac/dismiss_message.pl 9) Removes extra comments from opac/dismiss_message.pl 10) (Left for now) 11) (Left for now) Sponsored-by: Horowhenua Library Trust Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 20:15:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 18:15:53 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #26 from Owen Leonard --- Thank you for the follow-up Hayley! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 21:07:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 19:07:23 +0000 Subject: [Koha-bugs] [Bug 30114] Koha offline circulation will always cancel the next hold when issuing item to a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 21:13:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 19:13:51 +0000 Subject: [Koha-bugs] [Bug 15750] Koha offline circulation Firefox addon does not prompt to clear old entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15750 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us --- Comment #1 from Rebecca Coert --- This would be a useful addition to the add-on and I completely support the request. We recently had an issue where transactions from 2021 were uploaded and processed because staff did not clear the data beforehand. Having a prompt at the beginning of a session would help alleviate any errors of this nature. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 21:18:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 19:18:01 +0000 Subject: [Koha-bugs] [Bug 17506] Offline circ needs to be logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17506 --- Comment #2 from Rebecca Coert --- I agree with Christopher - all Offline Circulation transactions should be logged for possible troubleshooting. Issues, Renewals AND Returns. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 21:56:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 19:56:29 +0000 Subject: [Koha-bugs] [Bug 29783] Account lockout message appears incorrectly for blank userid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29783 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #6 from Marcel de Rooy --- + my $patron = Koha::Patrons->find({ userid => $q_userid }) if $q_userid; "my $var if condition" does not meet the coding guidelines, at least I hope so :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 22:13:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 20:13:55 +0000 Subject: [Koha-bugs] [Bug 30451] Delete a subscription delete the linked order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30451 --- Comment #1 from Katrin Fischer --- +1 The least would be a warning, but I also think it should just 'unlink' the subscription from the order. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 22:16:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 20:16:10 +0000 Subject: [Koha-bugs] [Bug 27783] Introduce background job queues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 --- Comment #28 from Tomás Cohen Arazi --- Created attachment 132950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132950&action=edit Bug 27783: Add queue handling in packaging tools This patch adds queue name handling in is_worker_running and a handy method to centralize process name handling for queue-specific workers. To test: 1. Apply this patch 2. Run: $ source debian/scripts/koha-functions.sh $ get_worker_name kohadev kohadev-koha-worker => SUCCESS: Default queue means no queue name included $ get_worker_name kohadev default kohadev-koha-worker => SUCCESS: Default queue means no queue name included $ get_worker_name kohadev long_tasks kohadev-koha-worker-long_tasks => SUCCESS: Queue name appended to the name 4. Run: $ perl misc4dev/cp_debian_files.pl \ --koha_dir /kohadevbox/koha \ --gitify /kohadevbox/gitify \ --instance kohadev 5. Run: $ koha-worker --start --queue oleonard kohadev => SUCCESS: Starts! 6. Check: $ ps waux | grep oleonard => SUCCESS: It is running 7. Play with --stop, --restart, --status and different queue names, including 'default' and without the --queue param as well. => SUCCESS: All as expected! 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 22:22:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 20:22:59 +0000 Subject: [Koha-bugs] [Bug 27783] Introduce background job queues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132950|0 |1 is obsolete| | --- Comment #29 from Tomás Cohen Arazi --- Created attachment 132951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132951&action=edit Bug 27783: Add queue handling in packaging tools This patch adds queue name handling in is_worker_running and a handy method to centralize process name handling for queue-specific workers. To test: 1. Apply this patch 2. Run: $ source debian/scripts/koha-functions.sh $ get_worker_name kohadev kohadev-koha-worker => SUCCESS: Default queue means no queue name included $ get_worker_name kohadev default kohadev-koha-worker => SUCCESS: Default queue means no queue name included $ get_worker_name kohadev long_tasks kohadev-koha-worker-long_tasks => SUCCESS: Queue name appended to the name 4. Run: $ perl misc4dev/cp_debian_files.pl \ --koha_dir /kohadevbox/koha \ --gitify /kohadevbox/gitify \ --instance kohadev 5. Run: $ koha-worker --start --queue oleonard kohadev => SUCCESS: Starts! 6. Check: $ ps waux | grep oleonard => SUCCESS: It is running 7. Play with --stop, --restart, --status and different queue names, including 'default' and without the --queue param as well. => SUCCESS: All as expected! 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 22:36:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 20:36:29 +0000 Subject: [Koha-bugs] [Bug 20397] Implement Content Security Policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20397 --- Comment #8 from Katrin Fischer --- New to the topic, so I hope what I gathered from reading documentation is about right: "Aiming for default-src https: is a great first goal, as it disables inline code and requires https. For existing websites with large codebases that would require too much work to disable inline scripts, default-src https: 'unsafe-inline' is still helpful, as it keeps resources from being accidentally loaded over http. However, it does not provide any XSS protection." I think disabling all inline script would cause quite a lot of side effects at this point in time. I believe, we do still have page specific JS. Maybe we should start with default-src https: 'unsafe-inline' ? Content-Security-Policy-Report-Only might also be useful to get a better idea of the work that needs to be done. We'd also definitely need a solution for OpacUserJs and it needs to be something that doesn't require anything server side to be triggered manually as a lot of libraries don't have easy access. I know we have some use cases where we load external Javascript libraries for tracking, cookie banners and catalog enrichment. Would we need to be able to set script-src in configuration in order to keep that working? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 22:58:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 20:58:36 +0000 Subject: [Koha-bugs] [Bug 20397] Implement Content Security Policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20397 --- Comment #9 from Jake Deery --- Katrin - I didn't realise you could set 'unsafe-inline'. That would be a great first step, and something we could probably implement quite quickly with minimal disruption :-) The OpacUserJs problem is one that will need more thought and discussion. There are many ways to solve it, each with different benefits and drawbacks in my eyes * You could keep everything in the database, and have a Perl script fetch it on each pageload. E.g. . This has the benefit of keeping everything in the database, but the drawback of being slow (you're making a dynamic call on each pageload). * Or, you can keep everything in the database, and rebuild a file when you save the syspref. For example, using a filehandler to write to somewhere in /var/lib/koha (or another location, /tmp maybe?). This has the benefit of being faster and cachable using Apache headers, but the drawback of maybe being inconsistent for sites that are configured poorly. * The other option is to maybe do a bit of both? Keep everything in the database, but have the option in the Koha sysprefs page of having a save button and a rebuild button separate from each other. So you can manually rebuild the JS file in the filesystem if it becomes unusable or missing! Of course, these are ideas - and I have COVID at the moment, so I may be writing 100 words where I would usually find what I need to say in ten. Again - open discussion; please say if you think these ideas are all silly, or not useful for Koha's usecase. :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 23:02:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 21:02:08 +0000 Subject: [Koha-bugs] [Bug 20397] Implement Content Security Policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20397 --- Comment #10 from Katrin Fischer --- Hi Jake - first of all: hope you feel better soon! I worry about having silly suggestions too, so maybe that is not related :) I am not sure if save and rebuild being separate makes sense, if you save, you'd probably want to see if it works? I believe we cache system preferences, so maybe there would not necessary be a database call for every page. Would that change things? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 23:13:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 21:13:49 +0000 Subject: [Koha-bugs] [Bug 20397] Implement Content Security Policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20397 --- Comment #11 from Jake Deery --- Thank you, so far it's been very mild, so thankfully I'm feeling I will pass through it quickly and be able to return to normality soon! That's a valid point! Plus, provided the file is being stored somewhere that is unlikely to be touched, it shouldn't be an issue (assuming the static file route is chosen). I believe this is the case, too, using Memcached? While this is definitely beneficial from a performance standpoint, if delivering via a Perl script is chosen, it still wouldn't be quite as fast as using static files with 'Expire' headers set in the Apache2 config. In theory - the weight of Perl could be reduced a bit by moving this stuff out to static files! But it does come with the downside of having to manage the static file, and handle the behaviour quirks of that file being managed. My experience in Koha is still quite new - so I don't know how good it is at things like file management and database access! Do you think Koha/Perl is performant enough to make the benefit of static files worthwhile? And do you think on busier systems, the reduction of frequent dynamic requests to a Perl script would be beneficial enough to warrant a static file in place of a Perl script request? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 23:16:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 21:16:07 +0000 Subject: [Koha-bugs] [Bug 20397] Implement Content Security Policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20397 --- Comment #12 from Katrin Fischer --- I'll have to leave those questions for someone else I am afraid - a bit out of my depth here. :( -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 23:34:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 21:34:47 +0000 Subject: [Koha-bugs] [Bug 20397] Implement Content Security Policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20397 --- Comment #13 from Jake Deery --- Thanks for all your input, Katrin! I'll probably be back with some more questions, when I think of some. I need to get into the habit of using IRC to chat with everyone! :-) I can see this as being possibly a very good way to add new functionality, though! Take CSS, where we could introduce CSS::Sass to the mix and make OpacUserCss work with SASS for some super cool results (OpacUserScss)!! Or with JavaScript::JSLint for JavaScript validation prior to save ;-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 23:48:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 21:48:58 +0000 Subject: [Koha-bugs] [Bug 27783] Introduce background job queues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 00:14:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 22:14:29 +0000 Subject: [Koha-bugs] [Bug 30057] Move Virtualshelves exceptions to their own file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30057 --- Comment #4 from Tomás Cohen Arazi --- Can we move this forward to be closer to finish this cleaning stage? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 00:34:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 22:34:14 +0000 Subject: [Koha-bugs] [Bug 30360] Add helper methods to Koha::BackgroundJobs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 132952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132952&action=edit Bug 30360: Add methods for dealing with the JSON payload This patch adds high-level methods to handle the JSON payload (de)serialization as needed. This allows devs implementing background jobs to abstract themselves from the internals of the jobs handling. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/BackgroundJob.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:07:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 23:07:03 +0000 Subject: [Koha-bugs] [Bug 29783] Account lockout message appears incorrectly for blank userid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29783 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:08:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 23:08:43 +0000 Subject: [Koha-bugs] [Bug 30410] Add a way for plugins to register background tasks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410 --- Comment #6 from Tomás Cohen Arazi --- (In reply to David Cook from comment #5) > (In reply to Tomás Cohen Arazi from comment #4) > > There's a clear example in the patches. > > Thanks > > I suppose the plugin's "name" isn't usable since it's human-friendly and not > machine friendly. > > I suppose free text and auto-generated both have their pros and cons... The main problem is how big the column needs to be. I suggest you go try and sign the patches. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:15:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 23:15:59 +0000 Subject: [Koha-bugs] [Bug 27301] Harmonize methods for providing biblionumbers to opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27301 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:16:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 23:16:17 +0000 Subject: [Koha-bugs] [Bug 26248] Simplify keep_text Javascript function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26248 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:16:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 23:16:33 +0000 Subject: [Koha-bugs] [Bug 27198] Sync marc21-retrieval-info-auth-dom.xml with retrieval-info-auth-dom.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27198 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:16:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 23:16:53 +0000 Subject: [Koha-bugs] [Bug 22333] Replace duplicated code in CanBookBeRenewed with GetSoonestRenewDate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22333 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:17:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 23:17:12 +0000 Subject: [Koha-bugs] [Bug 26305] Warn IE users of staff interface that it is no longer supported and to use a supported browser instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26305 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:18:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 23:18:11 +0000 Subject: [Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:18:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 23:18:48 +0000 Subject: [Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:19:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 23:19:28 +0000 Subject: [Koha-bugs] [Bug 11583] Add WYSIWYG editor for HTML notices/letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11583 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:19:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 23:19:38 +0000 Subject: [Koha-bugs] [Bug 26684] Remove 'marc' column from auth_header table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:20:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 23:20:50 +0000 Subject: [Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #36 from David Cook --- Should the status of this one be updated? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:21:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 23:21:02 +0000 Subject: [Koha-bugs] [Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:21:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 23:21:28 +0000 Subject: [Koha-bugs] [Bug 28457] cleanup_database.pl self-registration options are not configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28457 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:21:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 23:21:53 +0000 Subject: [Koha-bugs] [Bug 25952] Github search for plugin throwing errors due to API rate limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25952 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:22:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 23:22:08 +0000 Subject: [Koha-bugs] [Bug 25934] RequireStrongPassword should be more complex (password policy complexity) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25934 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:22:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 23:22:23 +0000 Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:22:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 23:22:31 +0000 Subject: [Koha-bugs] [Bug 21359] Add RDF support to OAI-PMH harvester In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21359 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:23:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 23:23:06 +0000 Subject: [Koha-bugs] [Bug 23457] Can't pick the items when placing multiple holds on a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23457 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:23:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 23:23:21 +0000 Subject: [Koha-bugs] [Bug 26586] Koha should return a SIP2 64 response to a 63 request for fee items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26586 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:26:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 23:26:26 +0000 Subject: [Koha-bugs] [Bug 24781] Parse and build query strings more reliably In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24781 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:26:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 23:26:39 +0000 Subject: [Koha-bugs] [Bug 12442] Query... variables should be defined within loop in Search.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12442 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:26:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 23:26:51 +0000 Subject: [Koha-bugs] [Bug 22344] Limits cannot contain parentheses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22344 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:27:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 23:27:10 +0000 Subject: [Koha-bugs] [Bug 25523] Address lintian warnings when packaging Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25523 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:29:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 23:29:00 +0000 Subject: [Koha-bugs] [Bug 26055] Advanced Editor Rancor should use "visibility" and not "mandatory" for drawing new records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26055 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:29:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 23:29:44 +0000 Subject: [Koha-bugs] [Bug 28011] Add CLI script to update bibs from linked authority records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28011 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:30:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 23:30:22 +0000 Subject: [Koha-bugs] [Bug 25384] Label maker font list is not configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |cnighswonger at foundations.ed | |u -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:30:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2022 23:30:36 +0000 Subject: [Koha-bugs] [Bug 28477] INTRANET and OPAC loggers should print to STDERR instead of to file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28477 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 10:00:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2022 08:00:00 +0000 Subject: [Koha-bugs] [Bug 25253] Allow to apply modification template when exporting checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25253 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Séverine Queune --- Quite an old one, rebase is needed :/ $ git bz apply 25253 Bug 25253 Depends on bug 24679 (Failed QA) Follow? [(y)es, (n)o] y Bug 24679 - Allow to apply a MARC modification template in export tool 111519 - Bug 24679: Allow to apply a MARC modification template in export tool 111520 - Bug 24679: Return the correct id in AddModificationTemplate 111521 - Bug 24679: Fix exporter tests Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 24679: Allow to apply a MARC modification template in export tool Using index info to reconstruct a base tree... M C4/Record.pm M Koha/Exporter/Record.pm M koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt M t/db_dependent/Exporter/Record.t M tools/export.pl Falling back to patching base and 3-way merge... Auto-merging tools/export.pl CONFLICT (content): Merge conflict in tools/export.pl Auto-merging t/db_dependent/Exporter/Record.t Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt Auto-merging Koha/Exporter/Record.pm Auto-merging C4/Record.pm CONFLICT (content): Merge conflict in C4/Record.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 24679: Allow to apply a MARC modification template in export tool hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-24679-Allow-to-apply-a-MARC-modification-templ-6_q4PP.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 10:19:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2022 08:19:18 +0000 Subject: [Koha-bugs] [Bug 30410] Add a way for plugins to register background tasks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 10:48:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2022 08:48:11 +0000 Subject: [Koha-bugs] [Bug 27783] Introduce background job queues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com | |, | |kyle at bywatersolutions.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 10:49:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2022 08:49:20 +0000 Subject: [Koha-bugs] [Bug 30194] Update required JSON::Validator version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate |release-notes-needed --- Comment #97 from Tomás Cohen Arazi --- (In reply to Ere Maijala from comment #96) > I think the relnotes should be expanded a bit since this affects > backwards-compatibility. At least the fact that the validation is now > stricter and doesn't allow the invalid refs it used to should be mentioned, > as these can have a direct effect on REST API plugins. Indeed. We will need to add technical release notes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 10:54:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2022 08:54:37 +0000 Subject: [Koha-bugs] [Bug 30360] Add helper methods to Koha::BackgroundJobs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 132953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132953&action=edit Bug 30360: Make UpdateElasticIndex use the helper methods Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 11:04:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2022 09:04:28 +0000 Subject: [Koha-bugs] [Bug 30182] background_jobs.status should be an ENUM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30182 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 11:15:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2022 09:15:22 +0000 Subject: [Koha-bugs] [Bug 30332] SRU does not work via https In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30332 --- Comment #4 from Thomas Klausner --- (In reply to Marcel de Rooy from comment #3) > Not sure what your proxy script does. But if you would use nginx as a > reverse proxy between internet and Koha, I would not consider that an ugly > solution. The SSL with its certificates etc is handled in the reverse proxy. > Koha does not have to deal with that anymore. (We run Koha in a container at > the same time.) Hm, yes, using an external server as a proxy would also be a good workaround. But (at least on one installation we manage) we don't have nginx (only Apache, which can of course also proxy), but the Apache config is managed by the IT department, which is far, far away and does not care about the library a lot. So changes there are rather hard to get.. Anyway, I've since improved the code a bit and put it into a plugin: https://github.com/HKS3/HKS3-SRU-HTTPS-Proxy This allows the librarians to add/edit/remove new HTTPS SRU Servers without any action either our or the IT departments part. But this is still a hack, a proper solution would be to add HTTPS support to SRU, but I think this is not possible (or only with some work on the underlying ZOOM C code). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 11:45:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2022 09:45:08 +0000 Subject: [Koha-bugs] [Bug 24161] Add ability to track the claim dates of later orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #74 from Jonathan Druart --- (In reply to Katrin Fischer from comment #73) > I am not sure if the database for this one works correctly. It looks like > the timestamp was always set to the 'update date' instead of the last known > claim date as it should have been. :( > >
    > $DBversion = '19.12.00.085';
    > if( CheckVersion( $DBversion ) ) {
    >     unless ( TableExists( 'aqorders_claims' ) ) {
    >         $dbh->do(q|
    >             CREATE TABLE aqorders_claims (
    >                 id int(11) AUTO_INCREMENT,
    >                 ordernumber INT(11) NOT NULL,
    >                 claimed_on TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP,
    >                 PRIMARY KEY (id),
    >                 CONSTRAINT aqorders_claims_ibfk_1 FOREIGN KEY (ordernumber)
    > REFERENCES aqorders (ordernumber) ON DELETE CASCADE ON UPDATE CASCADE
    >             ) ENGINE = InnoDB DEFAULT CHARSET = utf8mb4 COLLATE =
    > utf8mb4_unicode_ci
    >         |);
    > 
    >         my $orders = $dbh->selectall_arrayref(q|
    >             SELECT ordernumber, claims_count, claimed_date
    >             FROM aqorders
    >             WHERE claims_count > 0
    >         |, { Slice => {} });
    >         my $insert_claim_sth = $dbh->prepare(q|
    >             INSERT INTO aqorders_claims (ordernumber, claimed_on)
    >             VALUES (?,?)
    >         |);
    > 
    >         for my $order ( @$orders ) {
    >             for my $claim (1..$order->{claims_count}) {
    >                 $insert_claim_sth->execute($order->{ordernumber},
    > $order->{claimed_on});
    >             }
    >         }
    > 
    >         $dbh->do(q|ALTER TABLE aqorders DROP COLUMN claims_count, DROP
    > COLUMN claimed_date|);
    >     }
    > 
    >     NewVersion( $DBversion, 24161, "Add new join table aqorders_claims to
    > keep track of claims");
    > }
    
    Looks like the following line
    22065                 $insert_claim_sth->execute($order->{ordernumber},
    $order->{claimed_on});
    should have used $order->{claimed_on} instead.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 11:53:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 09:53:42 +0000
    Subject: [Koha-bugs] [Bug 30063] Make the main patron search use the
     /patrons REST API route
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|22.05.00                    |
            released in|                            |
    
    --- Comment #71 from Jonathan Druart  ---
    Thanks to everybody involved in this huge patch series!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 11:59:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 09:59:17 +0000
    Subject: [Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor
     change for backwards compatibility
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                 Status|REOPENED                    |RESOLVED
    
    --- Comment #37 from Jonathan Druart  ---
    Back to "Resolved fixed"
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 12:32:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 10:32:23 +0000
    Subject: [Koha-bugs] [Bug 30328] Add ability to generate barcode with branch
     specific prefix
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328
    
    Emmi Takkinen  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132221|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Emmi Takkinen  ---
    Created attachment 132954
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132954&action=edit
    Bug 30328: Add ability to generate barcode with branch specific prefix
    
    We should add more flexibility to generating barcodes by letting libraries
    define branch specific prefix for their barcodes. This patch adds new option
    "preyyyymmincr" in systempreference "autoBarcode" and new systempreference
    "BarcodePrefix" to define branch specific prefix
    
    Test plan:
    
    1. Apply patch and update database
    2. Set syspref "autoBarcode" as
    3. Add some values to syspref "Barcodeprefix" e.g.:
            Default: DEF
            CPL: CPL
            FFL: FFL
    4. Now change your library to CPL (if needed) and add an item
    5. Click barcode input field
       => barcode should be CPL00001
    6. Add another item and click barcode field
       => barcode should be CPL00002
    7. Change your library to FFL and add an item
       => barcode should now be FFL00001
    8. Change your library to e.g. FPL (or another as long as it doesn't have
    prefix value
    in "Barcodeprefix"), add an item and click barcode field
       => barcode should now be DEF00001
    9. Try to add multiple items
       => barcodes incremental value should increase in order (no skipping values,
    no errors)
    
    Also prove t/db_dependent/Barcodes_ValueBuilder.t and
    t/Barcodes_preyyyymmincr.t
    
    Sponsored-by: Koha-Suomi Oy
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 12:42:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 10:42:01 +0000
    Subject: [Koha-bugs] [Bug 30172] Background jobs failing due to race
     condition
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172
    
    Owen Leonard  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Patch doesn't apply
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 12:43:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 10:43:46 +0000
    Subject: [Koha-bugs] [Bug 30172] Background jobs failing due to race
     condition
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172
    
    Tomás Cohen Arazi  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Patch doesn't apply         |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 12:44:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 10:44:01 +0000
    Subject: [Koha-bugs] [Bug 30172] Background jobs failing due to race
     condition
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172
    
    Tomás Cohen Arazi  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 12:44:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 10:44:19 +0000
    Subject: [Koha-bugs] [Bug 30345] Koha::BackgroundJob->enqueue should set
     borrowernumber=undef if no userenv
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345
    
    Tomás Cohen Arazi  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 12:48:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 10:48:53 +0000
    Subject: [Koha-bugs] [Bug 30453] Convert offline circulation tabs to
     Bootstrap
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30453
    
    Owen Leonard  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 12:48:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 10:48:56 +0000
    Subject: [Koha-bugs] [Bug 30453] Convert offline circulation tabs to
     Bootstrap
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30453
    
    --- Comment #1 from Owen Leonard  ---
    Created attachment 132955
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132955&action=edit
    Bug 30453: Convert offline circulation tabs to Bootstrap
    
    This patch updates the offline circulation page in the staff interface
    to use Bootstrap tabs instead of jQueryUI.
    
    To test, apply the patch and make sure the AllowOfflineCirculation
    system preference is enabled.
    
    - Go to Circulation -> Built-in offline circulation interface
    - Submit a patron barcode in the "Check out" field.
    - Under the barcode input field you should see two tabs: Checkouts and
      Fines. Confirm that they look correct and work correctly.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 12:56:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 10:56:16 +0000
    Subject: [Koha-bugs] [Bug 24644] Hold not marked filled if item set to
     positive not for loan value
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24644
    
    Andreas Jonsson  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |andreas.jonsson at kreablo.se
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 13:12:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 11:12:35 +0000
    Subject: [Koha-bugs] [Bug 30454] Convert holds awaiting pickup tabs to
     Bootstrap
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30454
    
    Owen Leonard  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 13:12:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 11:12:39 +0000
    Subject: [Koha-bugs] [Bug 30454] Convert holds awaiting pickup tabs to
     Bootstrap
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30454
    
    --- Comment #1 from Owen Leonard  ---
    Created attachment 132956
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132956&action=edit
    Bug 30454: Convert holds awaiting pickup tabs to Bootstrap
    
    This patch updates the holds awaiting pickup page to replace jQueryUI
    tabs with Bootstrap tabs. A minor JavaScript change is required to work
    with the new HTML structure.
    
    To test you should have multiple holds for one library: Some which are
    waiting for less than the number of days specified in
    ReservesMaxPickUpDelay, some which are waiting longer.
    
    - Apply the patch and go to Circulation -> Holds awaiting pickup.
    - You should see two tabs: "Holds waiting" and "Holds waiting over..."
    - Confirm that the tabs look correct and work correctly.
    - Confirm that the "Cancel selected" buttons work correctly under each
      tab.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 13:13:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 11:13:40 +0000
    Subject: [Koha-bugs] [Bug 29087] Holds to pull list can crash with a
     SQL::Abstract puke
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087
    
    Nick Clemens  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30155
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 13:13:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 11:13:40 +0000
    Subject: [Koha-bugs] [Bug 30155] We shouldn't calculate
     get_items_that_can_fill when we don't have any holds
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30155
    
    Nick Clemens  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=29087
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 13:15:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 11:15:45 +0000
    Subject: [Koha-bugs] [Bug 30455] New: Incorrect template filter breaks holds
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30455
    
                Bug ID: 30455
               Summary: Incorrect template filter breaks holds
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: critical
              Priority: P5 - low
             Component: Templates
              Assignee: oleonard at myacpl.org
              Reporter: oleonard at myacpl.org
            QA Contact: testopia at bugs.koha-community.org
            Depends on: 30063
    
    An incorrect filter was added to patron-search.inc:
    
    let defer_loading = [% defer_loading | html ? 1 : 0 %];
    
    Filters don't belong inside conditionals. This makes request.pl break with an
    error:
    
    Template process failed: file error - parse error - patron-search.inc line 252:
    unexpected token (?)
      [% defer_loading | html ? 1 : 0 %] at /kohadevbox/koha/C4/Templates.pm line
    127
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
    [Bug 30063] Make the main patron search use the /patrons REST API route
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 13:15:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 11:15:45 +0000
    Subject: [Koha-bugs] [Bug 30063] Make the main patron search use the
     /patrons REST API route
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
    
    Owen Leonard  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30455
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30455
    [Bug 30455] Incorrect template filter breaks holds
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 13:20:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 11:20:10 +0000
    Subject: [Koha-bugs] [Bug 30455] Incorrect template filter breaks holds
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30455
    
    --- Comment #1 from Owen Leonard  ---
    (In reply to Owen Leonard from comment #0)
    > This makes request.pl break with an error
    
    ...Or any other page which uses patron-search.inc.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 13:21:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 11:21:14 +0000
    Subject: [Koha-bugs] [Bug 30455] Incorrect template filter breaks holds
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30455
    
    Owen Leonard  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Trivial patch
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 13:21:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 11:21:17 +0000
    Subject: [Koha-bugs] [Bug 30455] Incorrect template filter breaks holds
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30455
    
    --- Comment #2 from Owen Leonard  ---
    Created attachment 132957
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132957&action=edit
    Bug 30455: Incorrect template filter breaks holds
    
    This patch removes an incorrect template filter from inside a T:T
    conditional. This change should fix a non-functional request.pl and
    anywhere else patron-search.inc is used.
    
    The QA failure for a missing filter is a false positive.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 13:26:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 11:26:29 +0000
    Subject: [Koha-bugs] [Bug 30063] Make the main patron search use the
     /patrons REST API route
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
    
    --- Comment #72 from Jonathan Druart  ---
    Created attachment 132958
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132958&action=edit
    Bug 30063: (follow-up) Fix missing TT filters
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 13:26:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 11:26:48 +0000
    Subject: [Koha-bugs] [Bug 30063] Make the main patron search use the
     /patrons REST API route
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |additional_work_needed
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 13:28:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 11:28:11 +0000
    Subject: [Koha-bugs] [Bug 30455] Incorrect template filter breaks holds
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30455
    
    Owen Leonard  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|Trivial patch               |---
                 Status|Needs Signoff               |RESOLVED
             Resolution|---                         |INVALID
    
    --- Comment #3 from Owen Leonard  ---
    Will be patched on 30063
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 13:28:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 11:28:58 +0000
    Subject: [Koha-bugs] [Bug 30332] SRU does not work via https
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30332
    
    --- Comment #5 from Marcel de Rooy  ---
    (In reply to Thomas Klausner from comment #4)
    > Hm, yes, using an external server as a proxy would also be a good
    > workaround. But (at least on one installation we manage) we don't have nginx
    > (only Apache, which can of course also proxy), but the Apache config is
    > managed by the IT department, which is far, far away and does not care about
    > the library a lot. So changes there are rather hard to get..
    
    Yes, this sounds awkward.
    
    > But this is still a hack, a proper solution would be to add HTTPS support to
    > SRU, but I think this is not possible (or only with some work on the
    > underlying ZOOM C code).
    
    I would not recommend doing so. You'd better concentrate on running Koha in a
    container and put a (standard) nginx container or so before it as reverse proxy
    handling https.
    By the way, you should be able to handle the same thing in Apache too without
    touching Zoom C code. Catch the https request, proxy it to the local http port
    where Zebra listens, etc.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 13:42:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 11:42:32 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #11 from Jonathan Druart  ---
    Hola Bernardo,
    
    About the test plan of "Bug 30373: Enable translation of UNIMARC frameworks":
    
        3. Create (or update) some language
        Ej.
            misc/translation/translate create xx-YY
    
            verify new file misc/translation/po/xx-YY-installer-UNIMARC.po
    
    The correct path is misc/translator/po/xx-YY-installer-UNIMARC.po
    
    Yes it got created!
    
    But:
    
        4. Install new language
            misc/translation/translate install xx-YY
    
            verify new dirs:
                installer/data/mysql/xx-YY/marcflavour/unimarc/{mandatory,optional}
    
    The 'unimarc' directory is not created. Tried with "fr-FR" and "es-ES".
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 13:43:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 11:43:39 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #12 from Jonathan Druart  ---
    kohadev-koha at kohadevbox:/kohadevbox/koha/misc/translator$ perl translate create
    es-ES
    kohadev-koha at kohadevbox:/kohadevbox/koha/misc/translator$ perl translate
    install es-ES
    
    kohadev-koha at kohadevbox:/kohadevbox/koha/misc/translator$ ls
    /kohadevbox/koha/installer/data/mysql/es-ES/marcflavour/
    marc21
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 14:06:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 12:06:16 +0000
    Subject: [Koha-bugs] [Bug 30406] Our DT tables not filtering on the correct
     column if hidden by default
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30406
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 14:06:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 12:06:20 +0000
    Subject: [Koha-bugs] [Bug 30406] Our DT tables not filtering on the correct
     column if hidden by default
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30406
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132921|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Jonathan Druart  ---
    Created attachment 132959
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132959&action=edit
    Bug 30406: Add column filters before hiding columns
    
    The code that adds column filters works only on visible columns, so we
    should hide columns after filters are created
    
    Test plan:
    1. Apply patch
    2. Go to Tables settings. Hide city_state for the cities table.
    3. Create some cities and go to the cities page
    4. Verify that filtering works as expected.
    5. Make the city_state column appear. Verify that filtering on this
       column works too
    
    Signed-off-by: Séverine QUEUNE 
    
    Signed-off-by: Jonathan Druart 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 14:07:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 12:07:48 +0000
    Subject: [Koha-bugs] [Bug 30406] Our DT tables not filtering on the correct
     column if hidden by default
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30406
    
    --- Comment #6 from Jonathan Druart  ---
    Ha! Good workaround, thanks Julian!
    
    We could apply the same fix to includes/columns_settings.inc but I didn't
    manage to recreate the problem on catalogue/detail.pl (I think it's the only
    place where column filters are used with KohaTable).
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 14:08:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 12:08:04 +0000
    Subject: [Koha-bugs] [Bug 30406] Our DT tables not filtering on the correct
     column if hidden by default
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30406
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30063
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 14:08:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 12:08:04 +0000
    Subject: [Koha-bugs] [Bug 30063] Make the main patron search use the
     /patrons REST API route
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30406
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 14:14:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 12:14:55 +0000
    Subject: [Koha-bugs] [Bug 9525] Add option to define float groups and rules
     for float
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525
    
    pierre.genty at biblibre.com changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |pierre.genty at biblibre.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 14:20:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 12:20:32 +0000
    Subject: [Koha-bugs] [Bug 30426] suggestion service missing Auth and Output
     imports
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30426
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 14:20:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 12:20:36 +0000
    Subject: [Koha-bugs] [Bug 30426] suggestion service missing Auth and Output
     imports
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30426
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132929|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Jonathan Druart  ---
    Created attachment 132960
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132960&action=edit
    Bug 30426: Add missing C4::Auth and C4::Output imports
    
    This patch adds missing function imports for C4::Auth and C4::Output
    in the opac/svc/suggestion script.
    
    Test plan:
    
    1. Go to http://localhost:8081/cgi-bin/koha/admin/didyoumean.pl
    2. Turn on some plugins
    3. Go to
    http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1
    4. Note in your browser's Network tab that the call to
       http://localhost:8080/cgi-bin/koha/svc/suggestion?render=stub&q=test
       generates a 200 response instead of a 500 error
    
    Signed-off-by: Owen Leonard 
    
    Signed-off-by: Jonathan Druart 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 14:24:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 12:24:48 +0000
    Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #129816|0                           |1
            is obsolete|                            |
     Attachment #129817|0                           |1
            is obsolete|                            |
     Attachment #129818|0                           |1
            is obsolete|                            |
     Attachment #129819|0                           |1
            is obsolete|                            |
    
    --- Comment #10 from Jonathan Druart  ---
    Created attachment 132961
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132961&action=edit
    Bug 29897: Rename get_marc_authors with get_marc_contributors
    
    get_marc_authors actually return authors from 700..712, not the first
    author from 200
    
    Sponsored-by: Orex Digital
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 14:24:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 12:24:52 +0000
    Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897
    
    --- Comment #11 from Jonathan Druart  ---
    Created attachment 132962
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132962&action=edit
    Bug 29897: Move code to private method for reusability
    
    Sponsored-by: Orex Digital
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 14:24:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 12:24:57 +0000
    Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897
    
    --- Comment #12 from Jonathan Druart  ---
    Created attachment 132963
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132963&action=edit
    Bug 29897: Add new pref OPACAuthorIdentifiers
    
    Sponsored-by: Orex Digital
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 14:25:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 12:25:01 +0000
    Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897
    
    --- Comment #13 from Jonathan Druart  ---
    Created attachment 132964
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132964&action=edit
    Bug 29897: Display author's identifiers
    
    This new enhancement add the capability to list the different
    identifiers of authors. It is helpful for research publications for
    instance.
    
    This patch will add a new "Author identifiers" tab on the detail page
    (OPAC) of a bibliographic record, with the list of the authors and their
    identifiers.
    On the detail page of the authority record, the same identifier list
    will be displayed.
    
    Test plan:
    Create some authority with
    024
      $a source
      $2 number
      $6 link to the source
    With the pref turned ON you will be able to see the new information.
    
    Sponsored-by: Orex Digital
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 14:36:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 12:36:39 +0000
    Subject: [Koha-bugs] [Bug 30456] New: Convert checkout history tabs to
     Bootstrap
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30456
    
                Bug ID: 30456
               Summary: Convert checkout history tabs to Bootstrap
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: enhancement
              Priority: P5 - low
             Component: Templates
              Assignee: oleonard at myacpl.org
              Reporter: oleonard at myacpl.org
            QA Contact: testopia at bugs.koha-community.org
                    CC: testopia at bugs.koha-community.org
                Blocks: 29226
    
    Continuing the process of phasing out jQueryUI, this patch will replace
    jQueryUI tabs in the checkout history template with Bootstrap.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
    [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 14:36:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 12:36:39 +0000
    Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
    
    Owen Leonard  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30456
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30456
    [Bug 30456] Convert checkout history tabs to Bootstrap
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 14:38:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 12:38:42 +0000
    Subject: [Koha-bugs] [Bug 30449] Missing FK constraint on
     borrower_attribute_types
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449
    
    Marcel de Rooy  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 14:38:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 12:38:46 +0000
    Subject: [Koha-bugs] [Bug 30449] Missing FK constraint on
     borrower_attribute_types
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449
    
    --- Comment #1 from Marcel de Rooy  ---
    Created attachment 132965
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132965&action=edit
    Bug 30449: Add missing FK constraint on borrower_attribute_types
    
    Old Koha databases probably have it, newer ones might not.
    See also BZ description.
    
    Test plan:
    [1} Check SHOW CREATE TABLE borrower_attribute_types to see if you
        have any index and FK constraint on category_code.
    [2] Run updatedatabase.
    [3] If you had category_code_fk, it should be replaced.
    [4] Remove index and constraint again using things like:
        alter table borrower_attribute_types drop constraint
    `borrower_attribute_types_ibfk_1`;
        alter table borrower_attribute_types drop index category_code;
    [5] Run updatedatabase.
    [6] You should have KEY category_code and FK borrower_attribute_types_ibfk_1.
    [7] Run updatedatabase. Idempotent, no changes.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 14:39:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 12:39:11 +0000
    Subject: [Koha-bugs] [Bug 30449] Missing FK constraint on
     borrower_attribute_types
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449
    
    Marcel de Rooy  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                       |ity.org                     |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 14:39:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 12:39:31 +0000
    Subject: [Koha-bugs] [Bug 30449] Missing FK constraint on
     borrower_attribute_types
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449
    
    Marcel de Rooy  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Version|unspecified                 |master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 14:42:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 12:42:32 +0000
    Subject: [Koha-bugs] [Bug 30449] Missing FK constraint on
     borrower_attribute_types
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449
    
    Marcel de Rooy  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132965|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Marcel de Rooy  ---
    Created attachment 132966
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132966&action=edit
    Bug 30449: Add missing FK constraint on borrower_attribute_types
    
    Old Koha databases probably have it, newer ones might not.
    See also BZ description.
    
    Test plan:
    [1} Check SHOW CREATE TABLE borrower_attribute_types to see if you
        have any index and FK constraint on category_code.
    [2] Run updatedatabase.
    [3] If you had category_code_fk, it should be replaced.
    [4] Remove index and constraint again using things like:
        alter table borrower_attribute_types drop constraint
    `borrower_attribute_types_ibfk_1`;
        alter table borrower_attribute_types drop index category_code;
    [5] Run updatedatabase.
    [6] You should have KEY category_code and FK borrower_attribute_types_ibfk_1.
    [7] Run updatedatabase. Idempotent, no changes.
    
    Signed-off-by: Marcel de Rooy 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 14:47:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 12:47:47 +0000
    Subject: [Koha-bugs] [Bug 30456] Convert checkout history tabs to Bootstrap
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30456
    
    Owen Leonard  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 14:47:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 12:47:50 +0000
    Subject: [Koha-bugs] [Bug 30456] Convert checkout history tabs to Bootstrap
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30456
    
    --- Comment #1 from Owen Leonard  ---
    Created attachment 132967
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132967&action=edit
    Bug 30456: Convert checkout history tabs to Bootstrap
    
    This patch updates the circulation history page to replace jQueryUI tabs
    with Bootstrap tabs. A minor JavaScript change is required to work
    with the new HTML structure.
    
    To test you'll view the staff interface circulation history page with
    the OnSiteCheckouts system preference on and off.
    
    - With OnSiteCheckouts off, locate a patron who has current and/or
      past checkouts.
    - View the "Circulation history" page for that patron.
    - The table of checkouts should display with no tabbed interface.
    
    - With OnSiteCheckouts on, the page should show three tabs: All,
      Checkouts, and On-site checkouts.
    - Confirm that clicking on each tab correctly filters the table, e.g.
      the On-site checkouts tab should show only on-site checkouts.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 14:48:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 12:48:09 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    --- Comment #46 from Jonathan Druart  ---
    This got broken at some point
    
    data: {"messages":[{"code":"index_error","type":"error","error":"Can't locate
    object method \"new\" via package \"Koha::SearchEngine::Indexer\" (perhaps you
    forgot to load \"Koha::SearchEngine::Indexer\"?) at
    /kohadevbox/koha/Koha/BackgroundJob/UpdateElasticIndex.pm line
    78.\n"}],"record_ids":["14"],"report":{"total_records":1,"total_success":0},"record_server":"biblioserver"}
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 14:48:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 12:48:18 +0000
    Subject: [Koha-bugs] [Bug 30456] Convert checkout history tabs to Bootstrap
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30456
    
    Owen Leonard  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132967|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Owen Leonard  ---
    Created attachment 132968
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132968&action=edit
    Bug 30456: Convert checkout history tabs to Bootstrap
    
    This patch updates the circulation history page to replace jQueryUI tabs
    with Bootstrap tabs. A minor JavaScript change is required to work
    with the new HTML structure.
    
    To test you'll view the staff interface circulation history page with
    the OnSiteCheckouts system preference on and off.
    
    - With OnSiteCheckouts off, locate a patron who has current and/or
      past checkouts.
    - View the "Circulation history" page for that patron.
    - The table of checkouts should display with no tabbed interface.
    
    - With OnSiteCheckouts on, the page should show three tabs: All,
      Checkouts, and On-site checkouts.
    - Confirm that clicking on each tab correctly filters the table, e.g.
      the On-site checkouts tab should show only on-site checkouts.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 14:51:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 12:51:28 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    --- Comment #47 from Jonathan Druart  ---
    Created attachment 132969
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132969&action=edit
    Bug 27344: Add missing imports
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 14:53:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 12:53:03 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    --- Comment #48 from Jonathan Druart  ---
    Created attachment 132970
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132970&action=edit
    Bug 27344: Warn the error in the log
    
    Otherwise info about the failure is hidden in DB
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 14:56:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 12:56:25 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com
    
    --- Comment #30 from Jonathan Druart  ---
    1. Shouldn't we force the job to define its queue? Otherwise I have the feeling
    that we will end up with "default" everywhere.
    2. What could be other queues?
    3. Is BatchCancelHold really a long task? How do you define a short/long task
    then?
    4. Do we really want long/short task distinction? If you index 1000 records
    (using batch update), it will be considered as "default" (/not long task), but
    it will take a while.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 15:00:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 13:00:04 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    --- Comment #49 from Jonathan Druart  ---
    Minor: Progress is 0/1
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 15:01:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 13:01:25 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    --- Comment #50 from Jonathan Druart  ---
    Batch item modification (for instance) will run in background, but will also
    run a new task for the indexation.
    I don't think we should run another task for the indexation in case of batch
    operations.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 15:10:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 13:10:48 +0000
    Subject: [Koha-bugs] [Bug 17506] Offline circ needs to be logged
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17506
    
    Kyle M Hall  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 15:10:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 13:10:51 +0000
    Subject: [Koha-bugs] [Bug 17506] Offline circ needs to be logged
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17506
    
    --- Comment #3 from Kyle M Hall  ---
    Created attachment 132971
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132971&action=edit
    Bug 17506: Offline circ needs to be logged
    
    Returns via offline circ are not logged.
    
    Test Plan:
    1) Via offline circ
       * Return some items checked out to patrons
       * Check out some items that are currently checked out to other
         patrons
    2) Apply the offline circs to Koha
    3) Note the checkouts are logged, but not the returns
    4) Apply this patch, restart all the things!
    5) Repeat steps 1 and 2
    6) Note the checkins are now logged both for returns and for checkouts
       where the item was checked out to a different patron
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 15:17:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 13:17:10 +0000
    Subject: [Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to
     use backend template
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909
    
    Andrew Isherwood  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #124174|1                           |0
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 15:19:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 13:19:13 +0000
    Subject: [Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to
     use backend template
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909
    
    Andrew Isherwood  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Patch doesn't apply         |Needs Signoff
    
    --- Comment #12 from Andrew Isherwood  ---
    Hi Katrin
    
    It looks like one of the patches got obsoleted at some point, no idea how that
    happened! Anyway, it should apply now. I'm just working on a development that
    depends on this bug, and it applied cleanly, so hopefully you won't have any
    problems.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 15:19:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 13:19:37 +0000
    Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859
    
    --- Comment #13 from Jonathan Druart  ---
    Created attachment 132972
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132972&action=edit
    Bug 29859: Fix club/enroll
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 15:19:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 13:19:58 +0000
    Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |additional_work_needed
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 15:24:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 13:24:47 +0000
    Subject: [Koha-bugs] [Bug 29312] Punctuation: Total number of results: 961
     (300 shown) .
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312
    
    Séverine Queune  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 15:24:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 13:24:51 +0000
    Subject: [Koha-bugs] [Bug 29312] Punctuation: Total number of results: 961
     (300 shown) .
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312
    
    --- Comment #1 from Séverine Queune  ---
    Created attachment 132973
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132973&action=edit
    Bug 29312: Remove unnecessary point
    
    This patch removes an extra point after the number of shown results.
    
    Test plan :
     - don't apply patch
     - run a report that brings you more than 20 results, e.g. SELECT * FROM biblio
    LIMIT 50
     - see extra ' .' after the number of shown results
     - apply patch
     - run the report again and see the point isn't displayed anymore
     - check the behaviour is still correct when you change the number of rows
    displayed
     - sign off !
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 15:27:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 13:27:31 +0000
    Subject: [Koha-bugs] [Bug 29312] Punctuation: Total number of results: 961
     (300 shown) .
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312
    
    Séverine Queune  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |severine.queune at bulac.fr
               Assignee|koha-bugs at lists.koha-commun |severine.queune at bulac.fr
                       |ity.org                     |
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 15:29:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 13:29:35 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    --- Comment #31 from Tomás Cohen Arazi  ---
    (In reply to Jonathan Druart from comment #30)
    > 1. Shouldn't we force the job to define its queue? Otherwise I have the
    > feeling that we will end up with "default" everywhere.
    
    I think this can be caught at QA time. See 4.
    
    > 2. What could be other queues?
    
    Chatter on this and bug 27344 pointed to devs wantings some flexibility to run
    their own queues. That's why I reorganized things, keeping that in mind. Maybe
    later someone adds a configuration page/file to point specific tasks to
    specific queues, in order to offload some tasks to a separate physical server.
    
    > 3. Is BatchCancelHold really a long task? How do you define a short/long
    > task then?
    
    I think that was a mistake I made. i.e. cancelling holds shouldn't wait for a
    long running batch import to finish.
    
    > 4. Do we really want long/short task distinction? If you index 1000 records
    > (using batch update), it will be considered as "default" (/not long task),
    > but it will take a while.
    
    We do want that. And maybe in the future we can add more queues... and
    priorities.
    I think a follow-up is needed in bug 27344 to make it resort to long_tasks if
    the record count is high (for example, because of a batch operation) and be
    real-time if we are just updating an item index because it's been checked-in.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 15:32:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 13:32:08 +0000
    Subject: [Koha-bugs] [Bug 30457] New: Convert holds page tabs to Bootstrap
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30457
    
                Bug ID: 30457
               Summary: Convert holds page tabs to Bootstrap
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: enhancement
              Priority: P5 - low
             Component: Templates
              Assignee: oleonard at myacpl.org
              Reporter: oleonard at myacpl.org
            QA Contact: testopia at bugs.koha-community.org
                    CC: testopia at bugs.koha-community.org
                Blocks: 29226
    
    Continuing the process of phasing out jQueryUI, this patch will replace
    jQueryUI tabs in the holds template with Bootstrap.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
    [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 15:32:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 13:32:08 +0000
    Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
    
    Owen Leonard  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30457
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30457
    [Bug 30457] Convert holds page tabs to Bootstrap
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 15:33:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 13:33:41 +0000
    Subject: [Koha-bugs] [Bug 29420] HTTP status code incorrect when calling
     error pages directly under Plack/PSGI
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 15:33:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 13:33:45 +0000
    Subject: [Koha-bugs] [Bug 29420] HTTP status code incorrect when calling
     error pages directly under Plack/PSGI
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #128204|0                           |1
            is obsolete|                            |
    
    --- Comment #32 from Jonathan Druart  ---
    Created attachment 132974
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132974&action=edit
    Bug 29420: HTTP status code incorrect when calling error pages directly under
    Plack/PSGI
    
    The error pages wrote a HTTP status code of 200 for all PSGI requests, even
    though it should have only done it for PSGI requests from the ErrorDocument
    middleware. This patch fixes that.
    
    0) Do not apply patch
    1) Open F12 dev tools and go to Network tab
    2) Go to http://localhost:8081/files/blah
    3) Note that the webpage is a 404 error but HTTP status code is 200
    4) Go to http://localhost:8081/cgi-bin/koha/circ/blah
    5) Note that the webpage is a 404 error and HTTP status code is 404
    
    6) Apply patch
    7) Go to http://localhost:8081/files/blah
    8) Note that the webpage is a 404 error and HTTP status code is 404
    9) Go to http://localhost:8081/cgi-bin/koha/circ/blah
    10) Note that the webpage is a 404 error and HTTP status code is 404
    
    Signed-off-by: Martin Renvoize 
    
    Signed-off-by: Jonathan Druart 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 15:35:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 13:35:09 +0000
    Subject: [Koha-bugs] [Bug 29744] Harmonize psgi/plack detection methods
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744
    
    --- Comment #3 from Jonathan Druart  ---
    Bug 27555 comment 3
    
    """
    I don't understand why psgi_env and safe_exit were in the BEGIN block.
    Should we expect a regression from CAS or Shib auth here?
    """
    
    Will see once it's pushed!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 15:35:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 13:35:29 +0000
    Subject: [Koha-bugs] [Bug 29744] Harmonize psgi/plack detection methods
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 15:35:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 13:35:33 +0000
    Subject: [Koha-bugs] [Bug 29744] Harmonize psgi/plack detection methods
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132299|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Jonathan Druart  ---
    Created attachment 132975
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132975&action=edit
    Bug 29744: Harmonize psgi/plack detection methods
    
    This patch updates and moves the existing psgi_env method out of Auth
    and into Context and then replaces any manual references of the same
    code to use the new method.
    
    Signed-off-by: Jonathan Druart 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 15:35:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 13:35:45 +0000
    Subject: [Koha-bugs] [Bug 29744] Harmonize psgi/plack detection methods
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 15:38:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 13:38:50 +0000
    Subject: [Koha-bugs] [Bug 30458] New: Librarian ( manager_id ) not included
     in accountline when using "Payout amount" button
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458
    
                Bug ID: 30458
               Summary: Librarian ( manager_id ) not included in accountline
                        when using "Payout amount" button
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Fines and fees
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: kyle at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 15:40:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 13:40:56 +0000
    Subject: [Koha-bugs] [Bug 30458] Librarian ( manager_id ) not included in
     accountline when using "Payout amount" button
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458
    
    Kyle M Hall  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                       |ity.org                     |
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 15:43:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 13:43:34 +0000
    Subject: [Koha-bugs] [Bug 30458] Librarian ( manager_id ) not included in
     accountline when using "Payout amount" button
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458
    
    Kyle M Hall  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 15:43:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 13:43:37 +0000
    Subject: [Koha-bugs] [Bug 30458] Librarian ( manager_id ) not included in
     accountline when using "Payout amount" button
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458
    
    --- Comment #1 from Kyle M Hall  ---
    Created attachment 132976
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132976&action=edit
    Bug 30458:- Librarian ( manager_id ) not included in accountline when using
    "Payout amount" button
    
    When using the "Payout amount" button, accountlines.manager_id is not
    populated. This is not the case with the "Issue payout" buttons.
    
    Test Plan:
    1) Create a manual credit
    2) Issue a payout using the "Payout amount" button
    3) Inspect the payout accountline, note it has no manager_id
    4) Apply this patch, restart all the things!
    5) Repeat steps 1 and 2
    6) Note the new payout accountline has a manager_id!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 15:43:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 13:43:50 +0000
    Subject: [Koha-bugs] [Bug 30458] Librarian ( manager_id ) not included in
     accountline when using "Payout amount" button
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458
    
    Kyle M Hall  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 15:46:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 13:46:57 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    --- Comment #32 from Jonathan Druart  ---
    (In reply to Tomás Cohen Arazi from comment #31)
    > (In reply to Jonathan Druart from comment #30)
    > > 1. Shouldn't we force the job to define its queue? Otherwise I have the
    > > feeling that we will end up with "default" everywhere.
    > 
    > I think this can be caught at QA time. See 4.
    
    We have job_type that is doing that already.
    Why asking a human to catch something that can be caught by a machine? :)
    
    170 sub job_type { croak "This method must be subclassed" }
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 15:51:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 13:51:04 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    --- Comment #33 from Jonathan Druart  ---
    I am not sure I am understanding what bring 'queue' that cannot be done with
    the job_type.
    
    We could have --job-type and a negation for this option.
    
    perl background_jobs_worker.pl --job-type update_elastic_index
    => Run only indexation tasks
    
    perl background_jobs_worker.pl --not-job-type update_elastic_index
    => Run all but indexation tasks
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 16:04:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 14:04:49 +0000
    Subject: [Koha-bugs] [Bug 30456] Convert checkout history tabs to Bootstrap
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30456
    
    Séverine Queune  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 16:04:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 14:04:52 +0000
    Subject: [Koha-bugs] [Bug 30456] Convert checkout history tabs to Bootstrap
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30456
    
    Séverine Queune  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132968|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Séverine Queune  ---
    Created attachment 132977
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132977&action=edit
    Bug 30456: Convert checkout history tabs to Bootstrap
    
    This patch updates the circulation history page to replace jQueryUI tabs
    with Bootstrap tabs. A minor JavaScript change is required to work
    with the new HTML structure.
    
    To test you'll view the staff interface circulation history page with
    the OnSiteCheckouts system preference on and off.
    
    - With OnSiteCheckouts off, locate a patron who has current and/or
      past checkouts.
    - View the "Circulation history" page for that patron.
    - The table of checkouts should display with no tabbed interface.
    
    - With OnSiteCheckouts on, the page should show three tabs: All,
      Checkouts, and On-site checkouts.
    - Confirm that clicking on each tab correctly filters the table, e.g.
      the On-site checkouts tab should show only on-site checkouts.
    
    Signed-off-by: Séverine QUEUNE 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 16:53:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 14:53:52 +0000
    Subject: [Koha-bugs] [Bug 26311] Add patron invalid age to
     search_for_data_inconsistencies.pl
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311
    
    --- Comment #25 from Fridolin Somers  ---
    Created attachment 132978
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132978&action=edit
    Bug 30063: Fix missing TT filters
    
    Signed-off-by: Fridolin Somers 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 16:54:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 14:54:27 +0000
    Subject: [Koha-bugs] [Bug 26311] Add patron invalid age to
     search_for_data_inconsistencies.pl
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311
    
    Fridolin Somers  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132978|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 16:56:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 14:56:07 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #13 from Bernardo Gonzalez Kriegel  ---
    > 
    > The correct path is misc/translator/po/xx-YY-installer-UNIMARC.po
    You're right, sorry
    
    > But:
    > 
    >     4. Install new language
    >         misc/translation/translate install xx-YY
    > 
    >         verify new dirs:
    >            
    > installer/data/mysql/xx-YY/marcflavour/unimarc/{mandatory,optional}
    > 
    > The 'unimarc' directory is not created. Tried with "fr-FR" and "es-ES".
    
    My tests using biblibre branch:
    
    $ git status
    En la rama bz30373
    Tu rama está actualizada con 'biblibre/bz30373'.
    
    $ misc/translator/translate create xx-YY
    
    $ ls -l misc/translator/po/xx-YY-installer*
    -rw-rw-r-- 1 bgkriegel bgkriegel 288499 abr  5 07:10
    misc/translator/po/xx-YY-installer-MARC21.po
    -rw-rw-r-- 1 bgkriegel bgkriegel 107615 abr  5 07:10
    misc/translator/po/xx-YY-installer.po
    -rw-rw-r-- 1 bgkriegel bgkriegel 201055 abr  5 07:10
    misc/translator/po/xx-YY-installer-UNIMARC.po
    
    $ misc/translator/translate install xx-YY
    ERROR parsing plural forms header [nplurals=INTEGER; plural=EXPRESSION;]
    
    $ ls -l installer/data/mysql/xx-YY/marcflavour/
    total 8
    drwxrwxr-x 4 bgkriegel bgkriegel 4096 abr  5 11:37 marc21
    drwxrwxr-x 4 bgkriegel bgkriegel 4096 abr  5 11:37 unimarc
    
    
    NOTE: check that installer/data/mysql/xx-YY (or es-ES) does *not* exists before
    doing the install phase. By design that dir is not overwritten or updated.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 17:04:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 15:04:13 +0000
    Subject: [Koha-bugs] [Bug 13952] Import and export of authority types
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952
    
    Fridolin Somers  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
    
    --- Comment #173 from Fridolin Somers  ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 17:08:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 15:08:23 +0000
    Subject: [Koha-bugs] [Bug 30063] Make the main patron search use the
     /patrons REST API route
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
    
    Fridolin Somers  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|additional_work_needed      |
    
    --- Comment #73 from Fridolin Somers  ---
    > Bug 30063: (follow-up) Fix missing TT filters
    Was also missing :
      $("#[% sticky_header | html %]").show();
    I've added my commit :
    c636b39a89 Bug 30063: Fix missing TT filters
    Then yours :
    5fdfed1ee5 Bug 30063: (follow-up) Fix missing TT filters
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 17:10:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 15:10:30 +0000
    Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859
    
    Fridolin Somers  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|additional_work_needed      |
    
    --- Comment #14 from Fridolin Somers  ---
    > Bug 29859: Fix club/enroll
    Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 17:12:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 15:12:42 +0000
    Subject: [Koha-bugs] [Bug 29915] Anonymous session generates 1 new session
     ID per hit
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29915
    
    --- Comment #127 from Fridolin Somers  ---
    (In reply to Fridolin Somers from comment #126)
    > > Bug 29915: Prevent bad cookie from corrupted session
    > Pushed to master
    
    @Kyle : backport this in 21.11.x
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 17:13:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 15:13:40 +0000
    Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
    
    Fridolin Somers  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|additional_work_needed      |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 17:14:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 15:14:23 +0000
    Subject: [Koha-bugs] [Bug 22038] When exporting account table to excel,
     decimal is lost
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22038
    
    Fridolin Somers  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
                 Status|Passed QA                   |Pushed to master
    
    --- Comment #15 from Fridolin Somers  ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 17:14:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 15:14:59 +0000
    Subject: [Koha-bugs] [Bug 26669] Last Run column not updated when report is
     run publicly (via CoverFlow or elsewhere)
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669
    
    Fridolin Somers  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    --- Comment #18 from Fridolin Somers  ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 17:18:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 15:18:43 +0000
    Subject: [Koha-bugs] [Bug 28610] Elasticsearch 7 - hits.total is now an
     object
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610
    
    Fridolin Somers  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    --- Comment #23 from Fridolin Somers  ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 17:19:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 15:19:04 +0000
    Subject: [Koha-bugs] [Bug 29501] gather_print_notices.pl does not use SMTP
     servers
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29501
    
    Fridolin Somers  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
                 Status|Passed QA                   |Pushed to master
    
    --- Comment #25 from Fridolin Somers  ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 17:19:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 15:19:36 +0000
    Subject: [Koha-bugs] [Bug 29517] CanItemBeReserved fetches biblio for
     agerestriction check if feature not enabled
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29517
    
    Fridolin Somers  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    --- Comment #5 from Fridolin Somers  ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 17:20:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 15:20:30 +0000
    Subject: [Koha-bugs] [Bug 29576] Add street type to fields which can be
     copied from guarantor to guarantee
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29576
    
    Fridolin Somers  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    --- Comment #6 from Fridolin Somers  ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 17:28:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 15:28:50 +0000
    Subject: [Koha-bugs] [Bug 30003] Register entries doubled up if form fails
     validation on first submission
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003
    
    Fridolin Somers  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 17:28:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 15:28:53 +0000
    Subject: [Koha-bugs] [Bug 30003] Register entries doubled up if form fails
     validation on first submission
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003
    
    --- Comment #15 from Fridolin Somers  ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 17:28:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 15:28:55 +0000
    Subject: [Koha-bugs] [Bug 30107] When editing a desk,
     the currently logged in library is selected
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107
    
    Fridolin Somers  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 17:28:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 15:28:58 +0000
    Subject: [Koha-bugs] [Bug 30107] When editing a desk,
     the currently logged in library is selected
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107
    
    --- Comment #8 from Fridolin Somers  ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 17:29:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 15:29:00 +0000
    Subject: [Koha-bugs] [Bug 30114] Koha offline circulation will always cancel
     the next hold when issuing item to a patron
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114
    
    Fridolin Somers  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 17:29:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 15:29:03 +0000
    Subject: [Koha-bugs] [Bug 30114] Koha offline circulation will always cancel
     the next hold when issuing item to a patron
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114
    
    --- Comment #10 from Fridolin Somers  ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 17:29:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 15:29:05 +0000
    Subject: [Koha-bugs] [Bug 30222] Auto_renew_digest still sends every day
     when renewals are not allowed
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222
    
    Fridolin Somers  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 17:29:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 15:29:08 +0000
    Subject: [Koha-bugs] [Bug 30222] Auto_renew_digest still sends every day
     when renewals are not allowed
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222
    
    --- Comment #29 from Fridolin Somers  ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 17:29:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 15:29:10 +0000
    Subject: [Koha-bugs] [Bug 30377] Fix two CGI::param called in list
     context-warnings
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30377
    
    Fridolin Somers  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 17:29:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 15:29:13 +0000
    Subject: [Koha-bugs] [Bug 30377] Fix two CGI::param called in list
     context-warnings
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30377
    
    --- Comment #4 from Fridolin Somers  ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 17:29:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 15:29:15 +0000
    Subject: [Koha-bugs] [Bug 30394] Add 'draw' handling to the datatables
     wrapper and REST API
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30394
    
    Fridolin Somers  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 17:29:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 15:29:17 +0000
    Subject: [Koha-bugs] [Bug 30394] Add 'draw' handling to the datatables
     wrapper and REST API
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30394
    
    --- Comment #15 from Fridolin Somers  ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 17:29:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 15:29:19 +0000
    Subject: [Koha-bugs] [Bug 30395] Internal server error at reserve/request.pl
     on a biblio with non-ISO formatted date in publicationyear
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30395
    
    Fridolin Somers  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 17:29:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 15:29:22 +0000
    Subject: [Koha-bugs] [Bug 30395] Internal server error at reserve/request.pl
     on a biblio with non-ISO formatted date in publicationyear
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30395
    
    --- Comment #5 from Fridolin Somers  ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 17:29:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 15:29:24 +0000
    Subject: [Koha-bugs] [Bug 30408] API and OpenAPI versions should be string
     in spec
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30408
    
    Fridolin Somers  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 17:29:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 15:29:27 +0000
    Subject: [Koha-bugs] [Bug 30408] API and OpenAPI versions should be string
     in spec
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30408
    
    --- Comment #4 from Fridolin Somers  ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 17:42:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 15:42:51 +0000
    Subject: [Koha-bugs] [Bug 17506] Offline circ needs to be logged
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17506
    
    Christopher Brannon  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Failed QA
    
    --- Comment #4 from Christopher Brannon  ---
    I tried two provisions in a sandbox with this patch.  Patch loaded, but when I
    restarted services in both provisions, I was greeted with these errors:
    
    Stopping Plack daemon for b17506:.
    Stopping Z39.50/SRU daemon for b17506:.
    Stopping Koha worker daemon for b17506:.
    Stopping Koha indexing daemon for b17506:.
    
    Starting Plack daemon for b17506:.
    Starting Z39.50/SRU daemon for b17506:"my" variable $operation masks earlier
    declaration in same scope at /kohadevbox/koha/C4/Circulation.pm line 4075.
    "my" variable $patron masks earlier declaration in same scope at
    /kohadevbox/koha/C4/Circulation.pm line 4077.
    syntax error at /kohadevbox/koha/C4/Circulation.pm line 4031, near "} else"
    Unmatched right curly bracket at /kohadevbox/koha/C4/Circulation.pm line 4034,
    at end of line
    Can't redeclare "my" in "my" at /kohadevbox/koha/C4/Circulation.pm line 4039,
    near "my"
    Global symbol "$operation" requires explicit package name (did you forget to
    declare "my $operation"?) at /kohadevbox/koha/C4/Circulation.pm line 4039.
    syntax error at /kohadevbox/koha/C4/Circulation.pm line 4069, near "}"
    Unmatched right curly bracket at /kohadevbox/koha/C4/Circulation.pm line 4072,
    at end of line
    Can't redeclare "my" in "my" at /kohadevbox/koha/C4/Circulation.pm line 4077,
    near "my"
    syntax error at /kohadevbox/koha/C4/Circulation.pm line 4088, near "}"
    Can't use global @_ in "my" at /kohadevbox/koha/C4/Circulation.pm line 4099,
    near "= @_"
    Global symbol "$itemnumber" requires explicit package name (did you forget to
    declare "my $itemnumber"?) at /kohadevbox/koha/C4/Circulation.pm line 4103.
    Global symbol "$itemnumber" requires explicit package name (did you forget to
    declare "my $itemnumber"?) at /kohadevbox/koha/C4/Circulation.pm line 4103.
    Global symbol "$barcode" requires explicit package name (did you forget to
    declare "my $barcode"?) at /kohadevbox/koha/C4/Circulation.pm line 4104.
    syntax error at /kohadevbox/koha/C4/Circulation.pm line 4118, near "}"
    /kohadevbox/koha/C4/Circulation.pm has too many errors.
    Compilation failed in require at /kohadevbox/koha/Koha/Items.pm line 27.
    BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Items.pm line 27.
    Compilation failed in require at /kohadevbox/koha/Koha/Recall.pm line 25.
    BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Recall.pm line 25.
    Compilation failed in require at /kohadevbox/koha/Koha/Recalls.pm line 23.
    BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Recalls.pm line 23.
    Compilation failed in require at /kohadevbox/koha/C4/XSLT.pm line 33.
    BEGIN failed--compilation aborted at /kohadevbox/koha/C4/XSLT.pm line 33.
    Compilation failed in require at /kohadevbox/koha/Koha/Biblio.pm line 27.
    BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Biblio.pm line 27.
    Compilation failed in require at /kohadevbox/koha/Koha/Biblios.pm line 25.
    BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Biblios.pm line 25.
    Compilation failed in require at /kohadevbox/koha/Koha/Libraries.pm line 25.
    BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Libraries.pm line
    25.
    Compilation failed in require at /kohadevbox/koha/Koha/Object/Limit/Library.pm
    line 22.
    BEGIN failed--compilation aborted at
    /kohadevbox/koha/Koha/Object/Limit/Library.pm line 22.
    Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl-base/base.pm
    line 135.
            ...propagated at /usr/lib/x86_64-linux-gnu/perl-base/base.pm line 157.
    BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/AuthorisedValue.pm
    line 25.
    Compilation failed in require at /kohadevbox/koha/Koha/AuthorisedValues.pm line
    25.
    BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/AuthorisedValues.pm
    line 25.
    Compilation failed in require at /kohadevbox/koha/C4/Koha.pm line 27.
    BEGIN failed--compilation aborted at /kohadevbox/koha/C4/Koha.pm line 27.
    Compilation failed in require at /kohadevbox/koha/C4/Biblio.pm line 91.
    BEGIN failed--compilation aborted at /kohadevbox/koha/C4/Biblio.pm line 91.
    Compilation failed in require at /kohadevbox/koha/Koha/Z3950Responder.pm line
    22.
    BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Z3950Responder.pm
    line 22.
    Compilation failed in require at /kohadevbox/koha/misc/z3950_responder.pl line
    27.
    BEGIN failed--compilation aborted at /kohadevbox/koha/misc/z3950_responder.pl
    line 27.
     [31mfailed![39;49m
    Starting Koha worker daemon for b17506:.
    Starting Koha indexing daemon for b17506:.
    
    Reloading Apache httpd web server: apache2.
    
    memcached
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 18:54:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 16:54:51 +0000
    Subject: [Koha-bugs] [Bug 30204] Add subtitle to serial subscription search
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204
    
    --- Comment #5 from Kyle M Hall  ---
    Created attachment 132979
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132979&action=edit
    Bug 30204: Add unit test
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 18:56:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 16:56:59 +0000
    Subject: [Koha-bugs] [Bug 30204] Add subtitle to serial subscription search
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204
    
    Lucas Gass  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 18:58:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 16:58:56 +0000
    Subject: [Koha-bugs] [Bug 30457] Convert holds page tabs to Bootstrap
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30457
    
    Owen Leonard  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 18:58:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 16:58:59 +0000
    Subject: [Koha-bugs] [Bug 30457] Convert holds page tabs to Bootstrap
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30457
    
    --- Comment #1 from Owen Leonard  ---
    Created attachment 132980
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132980&action=edit
    Bug 30457: Convert holds page tabs to Bootstrap
    
    This patch updates the holds page to replace jQueryUI tabs with
    Bootstrap.
    
    To test, apply the patch and begin the process of placing a hold on a
    title in the catalog.
    
    If you have one or more patron clubs configured:
     - You should see two tabs, Patrons and Clubs.
     - Both should look correct and work correctly.
     - The Patrons tab should be selected initially, with cursor focus in
       the form field.
     - Switch to the Clubs tab. The cursor focus should move to the form
       field under this tab.
     - Submit a club search which will return results.
     - The page should refresh and the clubs tab should be preselected,
       showing the search results.
    
    If you have no patron clubs configured, the page should show only the
    Patrons tab.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr  5 19:01:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 17:01:35 +0000
    Subject: [Koha-bugs] [Bug 30204] Add subtitle to serial subscription search
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204
    
    Lucas Gass  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132979|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from Lucas Gass  ---
    Created attachment 132981
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132981&action=edit
    Bug 30204: Add unit test
    
    Signed-off-by: Lucas Gass 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 01:06:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 23:06:25 +0000
    Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search
     function for staff interface
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077
    
    Lucas Gass  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 01:06:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 23:06:30 +0000
    Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search
     function for staff interface
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077
    
    --- Comment #13 from Lucas Gass  ---
    Created attachment 132982
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132982&action=edit
    Bug 30077: (follow-up) retain branch selection
    
    To test:
    1. Apply patch, updatedatabase, restart_all
    2. Search for the system pref 'IntranetAddMastheadLibraryPulldown'
    3. Set it to 'Show'.
    4. Go to any page that contains header search box and click on 'Search the
    catalog'.
    5. To the left of the search bar you should see a dropdown for branches.
    6. This should be defaulted to 'All libraries'.
    7. In the dropdown choose any branch and do a search and make sure it is
    correctly limiting to that branch.
    8. Try changing to a different branch and doing another search. It should
    correcrly limit to that branch and retain that branch in the dropdown, just
    like the OPAC.
    9. Try selecting 'All libraries' from the top of the dropdown and make sure it
    is correctly searching all branches.
    10. Turn on the system pref 'IntranetCatalogSearchPulldown' and make sure it
    looks nice with both of those dropdowns and functions when you use limiters
    from both dropdowns.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 01:23:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 05 Apr 2022 23:23:59 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    --- Comment #34 from David Cook  ---
    (In reply to Jonathan Druart from comment #33)
    > I am not sure I am understanding what bring 'queue' that cannot be done with
    > the job_type.
    > 
    > We could have --job-type and a negation for this option.
    > 
    > perl background_jobs_worker.pl --job-type update_elastic_index
    > => Run only indexation tasks
    > 
    > perl background_jobs_worker.pl --not-job-type update_elastic_index
    > => Run all but indexation tasks
    
    I think that would get really messy/confusing as the number of job types/queues
    grows.
    
    I still think pointing background_jobs_worker.pl at a configuration file makes
    the most sense.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 10:27:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 08:27:41 +0000
    Subject: [Koha-bugs] [Bug 30037] Set default profile when staging MARC
     records on import
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037
    
    Florian  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    --- Comment #4 from Florian  ---
    This is a first draft for making the profile selection process easier.
    Currently, if you have multiple profiles set up when staging Records on import,
    the defaut selection will always be "Do not use profile".
    With this patch, if at least one profile is already set up, the first one in
    the list (which should be the oldest) will be selected by default.
    
    To test:
    1) You will need a Marc record to stage.
    2) If you don't have any, create multiple profiles for staging Marc records for
    import (in the Tools section); two should be enough, they should have different
    settings.
    3) See that "Do not use profile" is always preselected.
    4) Apply patch.
    5) Reload the page : Now, the first profile of your list should be preselected.
    6) Confirm that manually picking a different profile still loads different
    settings
    7) Sign off.
    
    Thanks-to: Didier Gautheron 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 10:28:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 08:28:36 +0000
    Subject: [Koha-bugs] [Bug 30037] Set default profile when staging MARC
     records on import
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037
    
    --- Comment #5 from Florian  ---
    (In reply to Katrin Fischer from comment #2)
    > Just a note, I have seen notices used a lot by French devs when they mean
    > 'records', so it might be a false friend in French maybe?
    
    You're absolutely right, thank you for the correction
    
    And also yes, this is ready for testing.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 10:31:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 08:31:32 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    --- Comment #35 from Tomás Cohen Arazi  ---
    (In reply to David Cook from comment #34)
    > (In reply to Jonathan Druart from comment #33)
    > > I am not sure I am understanding what bring 'queue' that cannot be done with
    > > the job_type.
    > > 
    > > We could have --job-type and a negation for this option.
    > > 
    > > perl background_jobs_worker.pl --job-type update_elastic_index
    > > => Run only indexation tasks
    > > 
    > > perl background_jobs_worker.pl --not-job-type update_elastic_index
    > > => Run all but indexation tasks
    > 
    > I think that would get really messy/confusing as the number of job
    > types/queues grows.
    > 
    > I still think pointing background_jobs_worker.pl at a configuration file
    > makes the most sense.
    
    Right, as the job types grows, and we don't even have control of them (plugins)
    we need some other way of grouping them more generally. Otherwise we cannot do
    cool things like installing a plugin and it will just work. We would need to
    set a worker for that. I'm sure you will insist on the ---not use for that, but
    think how we would solve the real-time vs. no hurry use cases in a generic way.
    It is plain straight-forward to just 'subscribe to a queue' for authors.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 10:41:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 08:41:15 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    --- Comment #36 from Tomás Cohen Arazi  ---
    (In reply to Jonathan Druart from comment #30)
    > 1. Shouldn't we force the job to define its queue? Otherwise I have the
    > feeling that we will end up with "default" everywhere.
    
    I've been trying to think of use cases, and the authority merge came to my
    mind. If the record count is low enough it would be great to do it real-time
    (because librarians really want to keep working on those records, probably),
    and if it is too big, it would be great to do it in the long_tasks queue
    (because it wouldn't need to wait for the cronjob). So, in this case, ->enqueue
    could actually put the job in different queues depending on the scenario.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 10:44:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 08:44:55 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    --- Comment #51 from Tomás Cohen Arazi  ---
    (In reply to Jonathan Druart from comment #50)
    > Batch item modification (for instance) will run in background, but will also
    > run a new task for the indexation.
    > I don't think we should run another task for the indexation in case of batch
    > operations.
    
    This is your patch, right? We just moved the job_type/queue stuff to another
    bug.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 11:27:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 09:27:23 +0000
    Subject: [Koha-bugs] [Bug 30459] New: BatchDeleteAuthority task does not
     deal with indexation correctly
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30459
    
                Bug ID: 30459
               Summary: BatchDeleteAuthority task does not deal with
                        indexation correctly
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Architecture, internals, and plumbing
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: jonathan.druart+koha at gmail.com
            QA Contact: testopia at bugs.koha-community.org
    
    Indexation must be done at the end of the process, when all authorities have
    been deleted, not for each authority record.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 11:27:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 09:27:33 +0000
    Subject: [Koha-bugs] [Bug 30459] BatchDeleteAuthority task does not deal
     with indexation correctly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30459
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |27344
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    [Bug 27344] Implement Elastic's update_index_background using
    Koha::BackgroundJob
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 11:27:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 09:27:33 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30459
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30459
    [Bug 30459] BatchDeleteAuthority task does not deal with indexation correctly
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 11:29:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 09:29:34 +0000
    Subject: [Koha-bugs] [Bug 30460] New: BatchDeleteBiblio task does not deal
     with indexation correctly
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30460
    
                Bug ID: 30460
               Summary: BatchDeleteBiblio task does not deal with indexation
                        correctly
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Architecture, internals, and plumbing
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: jonathan.druart+koha at gmail.com
            QA Contact: testopia at bugs.koha-community.org
            Depends on: 27344
    
    skip_record_index should be passed to DelBiblio, and update the search engine's
    index at the end of the process.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    [Bug 27344] Implement Elastic's update_index_background using
    Koha::BackgroundJob
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 11:29:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 09:29:34 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30460
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30460
    [Bug 30460] BatchDeleteBiblio task does not deal with indexation correctly
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 11:32:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 09:32:18 +0000
    Subject: [Koha-bugs] [Bug 20424] New UNIMARC ZEBRA indexes according to last
     IFLA updates
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424
    
    Eric Balluto  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |eric.balluto at univ-lyon2.fr
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 11:36:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 09:36:29 +0000
    Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859
    
    --- Comment #15 from Jonathan Druart  ---
    Created attachment 132983
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132983&action=edit
    Bug 29859: Fix BatchUpdateAuthority
    
    Use of inherited AUTOLOAD for non-method
    Koha::BackgroundJob::BatchUpdateAuthority::ModAuthority() is
    no longer allowed
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 11:36:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 09:36:46 +0000
    Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132983|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 11:40:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 09:40:15 +0000
    Subject: [Koha-bugs] [Bug 30461] New: Batch authority tool is broken
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30461
    
                Bug ID: 30461
               Summary: Batch authority tool is broken
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: critical
              Priority: P5 - low
             Component: Tools
              Assignee: jonathan.druart+koha at gmail.com
              Reporter: jonathan.druart+koha at gmail.com
            QA Contact: testopia at bugs.koha-community.org
            Depends on: 17600, 22417
    
    Use of inherited AUTOLOAD for non-method
    Koha::BackgroundJob::BatchUpdateAuthority::ModAuthority() is no longer allowed
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600
    [Bug 17600] Standardize the EXPORT
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417
    [Bug 22417] Add a task queue
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 11:40:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 09:40:15 +0000
    Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30461
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30461
    [Bug 30461] Batch authority tool is broken
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 11:40:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 09:40:15 +0000
    Subject: [Koha-bugs] [Bug 22417] Add a task queue
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30461
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30461
    [Bug 30461] Batch authority tool is broken
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 11:41:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 09:41:06 +0000
    Subject: [Koha-bugs] [Bug 30461] Batch authority tool is broken
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30461
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 11:41:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 09:41:10 +0000
    Subject: [Koha-bugs] [Bug 30461] Batch authority tool is broken
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30461
    
    --- Comment #1 from Jonathan Druart  ---
    Created attachment 132984
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132984&action=edit
    Bug 30461: Fix BatchUpdateAuthority
    
    Use of inherited AUTOLOAD for non-method
    Koha::BackgroundJob::BatchUpdateAuthority::ModAuthority() is
    no longer allowed
    
    Test plan:
    Use the batch authority tools to edit authority record and confirm that
    the task processes correctly
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 11:41:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 09:41:31 +0000
    Subject: [Koha-bugs] [Bug 30461] Batch authority tool is broken
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30461
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |rel_21_11_candidate
                     CC|                            |kyle at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 11:46:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 09:46:37 +0000
    Subject: [Koha-bugs] [Bug 30462] New: Should the background job list view
     hide index tasks by default?
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462
    
                Bug ID: 30462
               Summary: Should the background job list view hide index tasks
                        by default?
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: System Administration
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: jonathan.druart+koha at gmail.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com
            Depends on: 27344
    
    We will certainly end up with lot of indexation tasks. Shouldn't we hide them
    by default when we list the tasks on Home > Administration > Background jobs ?
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    [Bug 27344] Implement Elastic's update_index_background using
    Koha::BackgroundJob
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 11:46:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 09:46:37 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30462
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462
    [Bug 30462] Should the background job list view hide index tasks by default?
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 11:49:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 09:49:24 +0000
    Subject: [Koha-bugs] [Bug 30463] New: Authority records are indexed on the
     fly
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30463
    
                Bug ID: 30463
               Summary: Authority records are indexed on the fly
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Architecture, internals, and plumbing
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: jonathan.druart+koha at gmail.com
            QA Contact: testopia at bugs.koha-community.org
            Depends on: 27344
    
    C4::AuthoritiesMarc::AddAuthority is indexing the record on the fly, we should
    index in background.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    [Bug 27344] Implement Elastic's update_index_background using
    Koha::BackgroundJob
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 11:49:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 09:49:24 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30463
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30463
    [Bug 30463] Authority records are indexed on the fly
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 11:51:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 09:51:02 +0000
    Subject: [Koha-bugs] [Bug 30464] New: BatchUpdateAuthority task does not
     deal with indexation correctly
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30464
    
                Bug ID: 30464
               Summary: BatchUpdateAuthority task does not deal with
                        indexation correctly
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Architecture, internals, and plumbing
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: jonathan.druart+koha at gmail.com
            QA Contact: testopia at bugs.koha-community.org
            Depends on: 30463
    
    We should call ModAuthority that will index in background mode, then update the
    search engine index once all the authority records have been modified.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30463
    [Bug 30463] Authority records are indexed on the fly
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 11:51:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 09:51:02 +0000
    Subject: [Koha-bugs] [Bug 30463] Authority records are indexed on the fly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30463
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30464
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30464
    [Bug 30464] BatchUpdateAuthority task does not deal with indexation correctly
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 11:53:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 09:53:54 +0000
    Subject: [Koha-bugs] [Bug 30465] New: BatchUpdateBiblio task does not deal
     with indexation correctly
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30465
    
                Bug ID: 30465
               Summary: BatchUpdateBiblio task does not deal with indexation
                        correctly
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Architecture, internals, and plumbing
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: jonathan.druart+koha at gmail.com
            QA Contact: testopia at bugs.koha-community.org
                Blocks: 27344
    
    ModBiblio must implement skip_index and we should update the search engine's
    index after all the biblio records have been modified.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    [Bug 27344] Implement Elastic's update_index_background using
    Koha::BackgroundJob
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 11:53:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 09:53:54 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30465
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30465
    [Bug 30465] BatchUpdateBiblio task does not deal with indexation correctly
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 11:56:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 09:56:18 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Failed QA
    
    --- Comment #52 from Jonathan Druart  ---
    I have opened several bug reports. There is a lot of work to provide before
    considering this one ready.
    
    I am not sure about the relations between the bug reports, but I think at least
    bug 30465 is a blocking this one.
    
    Otherwise we will see 1 task + X indexation tasks when you update X biblio
    records using the batch record modification tools.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 12:02:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 10:02:02 +0000
    Subject: [Koha-bugs] [Bug 30376] Unable to save item if field date acquired
     is set mandatory
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30376
    
    Johanna Räisä  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132317|0                           |1
            is obsolete|                            |
                     CC|                            |johanna.raisa at koha-suomi.fi
    
    --- Comment #2 from Johanna Räisä  ---
    Created attachment 132985
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132985&action=edit
    Bug 30376: Fix missing mandatory date acquired error on item  save
    
    If you set 952$d (date acquired or "dateaccessioned") as mandatory in
    your MARC framework, you'll be unable to edit or add items because item
    form validation fails with error "1 mandatory fields empty".
    
    To test:
    
    1. Edit a MARC framework of your choice (e.g. Default)
    2. Locate 952$d "Date acquired" and click Edit
    /cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=952&frameworkcode=#subdfield
    3. Tick "Mandatory" checkbox
    4. Save changes
    5. Edit any item using MARC framework you edited in step 1
    /cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=123&itemnumber=456
    6. Set "Date acquired" to any date
    7. Click Save
    8. Observe error "- 1 mandatory fields empty (highlighted)" (JavaScript alert)
    9. Apply patch
    10. Repeat steps 5-7
    11. Observe no error, item saves as expected
    
    Signed-off-by: Johanna Raisa 
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 12:03:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 10:03:50 +0000
    Subject: [Koha-bugs] [Bug 30376] Unable to save item if field date acquired
     is set mandatory
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30376
    
    Johanna Räisä  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 13:07:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 11:07:40 +0000
    Subject: [Koha-bugs] [Bug 30456] Convert checkout history tabs to Bootstrap
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30456
    
    Peter Vashchuk  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 13:07:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 11:07:44 +0000
    Subject: [Koha-bugs] [Bug 30456] Convert checkout history tabs to Bootstrap
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30456
    
    Peter Vashchuk  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132977|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Peter Vashchuk  ---
    Created attachment 132986
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132986&action=edit
    Bug 30456: Convert checkout history tabs to Bootstrap
    
    This patch updates the circulation history page to replace jQueryUI tabs
    with Bootstrap tabs. A minor JavaScript change is required to work
    with the new HTML structure.
    
    To test you'll view the staff interface circulation history page with
    the OnSiteCheckouts system preference on and off.
    
    - With OnSiteCheckouts off, locate a patron who has current and/or
      past checkouts.
    - View the "Circulation history" page for that patron.
    - The table of checkouts should display with no tabbed interface.
    
    - With OnSiteCheckouts on, the page should show three tabs: All,
      Checkouts, and On-site checkouts.
    - Confirm that clicking on each tab correctly filters the table, e.g.
      the On-site checkouts tab should show only on-site checkouts.
    
    Signed-off-by: Séverine QUEUNE 
    Signed-off-by: Petro Vashchuk 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 13:17:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 11:17:13 +0000
    Subject: [Koha-bugs] [Bug 30465] BatchUpdateBiblio task does not deal with
     indexation correctly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30465
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |27344
                 Blocks|27344                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    [Bug 27344] Implement Elastic's update_index_background using
    Koha::BackgroundJob
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 13:17:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 11:17:13 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30465
             Depends on|30465                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30465
    [Bug 30465] BatchUpdateBiblio task does not deal with indexation correctly
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 13:32:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 11:32:44 +0000
    Subject: [Koha-bugs] [Bug 30466] New: Convert serials pages tabs to Bootstrap
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466
    
                Bug ID: 30466
               Summary: Convert serials pages tabs to Bootstrap
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: enhancement
              Priority: P5 - low
             Component: Templates
              Assignee: oleonard at myacpl.org
              Reporter: oleonard at myacpl.org
            QA Contact: testopia at bugs.koha-community.org
                    CC: testopia at bugs.koha-community.org
                Blocks: 29226
    
    Continuing the process of phasing out jQueryUI, this patch will replace
    jQueryUI tabs in three serials templates with Bootstrap:
    
    - serials-collection.tt
    - serials-search.tt
    - subscription-detail.tt
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
    [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 13:32:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 11:32:44 +0000
    Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
    
    Owen Leonard  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30466
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466
    [Bug 30466] Convert serials pages tabs to Bootstrap
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 13:35:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 11:35:28 +0000
    Subject: [Koha-bugs] [Bug 30460] BatchDeleteBiblio task does not deal with
     indexation correctly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30460
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                       |ity.org                     |com
                 Status|NEW                         |ASSIGNED
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 13:35:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 11:35:36 +0000
    Subject: [Koha-bugs] [Bug 30465] BatchUpdateBiblio task does not deal with
     indexation correctly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30465
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |ASSIGNED
               Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                       |ity.org                     |com
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 13:35:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 11:35:46 +0000
    Subject: [Koha-bugs] [Bug 30459] BatchDeleteAuthority task does not deal
     with indexation correctly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30459
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |ASSIGNED
               Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                       |ity.org                     |com
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 13:36:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 11:36:24 +0000
    Subject: [Koha-bugs] [Bug 30464] BatchUpdateAuthority task does not deal
     with indexation correctly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30464
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |ASSIGNED
               Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                       |ity.org                     |com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 13:36:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 11:36:33 +0000
    Subject: [Koha-bugs] [Bug 30463] Authority records are indexed on the fly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30463
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                       |ity.org                     |com
                 Status|NEW                         |ASSIGNED
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 13:44:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 11:44:01 +0000
    Subject: [Koha-bugs] [Bug 30466] Convert serials pages tabs to Bootstrap
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466
    
    Owen Leonard  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 13:44:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 11:44:05 +0000
    Subject: [Koha-bugs] [Bug 30466] Convert serials pages tabs to Bootstrap
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466
    
    --- Comment #1 from Owen Leonard  ---
    Created attachment 132987
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132987&action=edit
    Bug 30466: Convert serials pages tabs to Bootstrap
    
    This patch modifies three serials templates in order to replace jQueryUI
    tabs with Bootstrap tabs.
    
    To test, apply the patch and rebuild the staff interface CSS
    (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
    
    - Go to Serials.
    - Perform a serials search which will return one or more results.
    - On the search results page you should see an Open and Closed tab.
    - The tabs should look correct and work correctly.
    - Confirm that "Select all" and "Clear all" controls work correctly in
      each tab.
    
    - Click one of the search results to view the details for that
      subscription.
    - You should see tabs for Information, Planning, Issues, and Summary.
      You may also see an Acquisition details tab depending on your data.
    
    - In the sidebar menu click "Serial collection."
    - On this page you should see tabs corresponding to each year the serial
      has been received.
    - Under each tab the "Select all" and "Clear all" controls should work
      correctly in the context of that tab. Other controls should apply to
      all tabs.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 13:48:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 11:48:48 +0000
    Subject: [Koha-bugs] [Bug 30463] Authority records are indexed on the fly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30463
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |In Discussion
    
    --- Comment #1 from Jonathan Druart  ---
    Not sure about this, side-effects possible?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 13:54:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 11:54:35 +0000
    Subject: [Koha-bugs] [Bug 30465] BatchUpdateBiblio task does not deal with
     indexation correctly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30465
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 13:54:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 11:54:38 +0000
    Subject: [Koha-bugs] [Bug 30465] BatchUpdateBiblio task does not deal with
     indexation correctly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30465
    
    --- Comment #1 from Jonathan Druart  ---
    Created attachment 132988
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132988&action=edit
    Bug 30465: Make BatchUpdateBiblio update the index in one request
    
    When using the batch record modification tool to modify several
    bibliographic records, we don't want to send one index request per
    biblio, we want to index them all on the fly after the records have been
    modified.
    Otherwise we will end up with one task per record, and records will be
    indexed in background.
    
    Test plan:
    Use the batch mod tool to modify bibliographic records and confirm the
    behaviour is correct.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 13:55:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 11:55:00 +0000
    Subject: [Koha-bugs] [Bug 30460] BatchDeleteBiblio task does not deal with
     indexation correctly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30460
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 13:55:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 11:55:04 +0000
    Subject: [Koha-bugs] [Bug 30460] BatchDeleteBiblio task does not deal with
     indexation correctly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30460
    
    --- Comment #1 from Jonathan Druart  ---
    Created attachment 132989
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132989&action=edit
    Bug 30460: Make BatchDeleteBiblio update the index in one request
    
    No need to send 1 indexation request per item + 1 per biblio.
    
    Test plan:
    Confirm that the batch biblio deletion tool still works correctly
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 13:55:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 11:55:22 +0000
    Subject: [Koha-bugs] [Bug 30464] BatchUpdateAuthority task does not deal
     with indexation correctly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30464
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 13:55:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 11:55:26 +0000
    Subject: [Koha-bugs] [Bug 30464] BatchUpdateAuthority task does not deal
     with indexation correctly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30464
    
    --- Comment #1 from Jonathan Druart  ---
    Created attachment 132990
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132990&action=edit
    Bug 30464: Make BatchUpdateAuthority update the index in one request
    
    Same as bug 30465 for authorities
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 13:55:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 11:55:46 +0000
    Subject: [Koha-bugs] [Bug 30459] BatchDeleteAuthority task does not deal
     with indexation correctly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30459
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 13:55:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 11:55:54 +0000
    Subject: [Koha-bugs] [Bug 30459] BatchDeleteAuthority task does not deal
     with indexation correctly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30459
    
    --- Comment #1 from Jonathan Druart  ---
    Created attachment 132991
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132991&action=edit
    Bug 30459: Make BatchDeleteAuthority update the index in one request
    
    Same as bug 30460 for authorities
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 13:56:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 11:56:32 +0000
    Subject: [Koha-bugs] [Bug 30460] BatchDeleteBiblio task does not deal with
     indexation correctly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30460
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |dcook at prosentient.com.au,
                       |                            |julian.maurice at biblibre.com
                       |                            |,
                       |                            |martin.renvoize at ptfs-europe
                       |                            |.com, tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 13:56:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 11:56:40 +0000
    Subject: [Koha-bugs] [Bug 30461] Batch authority tool is broken
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30461
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |dcook at prosentient.com.au,
                       |                            |julian.maurice at biblibre.com
                       |                            |,
                       |                            |martin.renvoize at ptfs-europe
                       |                            |.com, tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 13:56:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 11:56:58 +0000
    Subject: [Koha-bugs] [Bug 30464] BatchUpdateAuthority task does not deal
     with indexation correctly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30464
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |dcook at prosentient.com.au,
                       |                            |julian.maurice at biblibre.com
                       |                            |,
                       |                            |martin.renvoize at ptfs-europe
                       |                            |.com, tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 13:57:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 11:57:02 +0000
    Subject: [Koha-bugs] [Bug 30465] BatchUpdateBiblio task does not deal with
     indexation correctly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30465
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |dcook at prosentient.com.au,
                       |                            |julian.maurice at biblibre.com
                       |                            |,
                       |                            |martin.renvoize at ptfs-europe
                       |                            |.com, tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 14:04:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 12:04:15 +0000
    Subject: [Koha-bugs] [Bug 30467] New: BatchDeleteItem task does not deal
     with indexation correctly
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30467
    
                Bug ID: 30467
               Summary: BatchDeleteItem task does not deal with indexation
                        correctly
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: enhancement
              Priority: P5 - low
             Component: Architecture, internals, and plumbing
              Assignee: jonathan.druart+koha at gmail.com
              Reporter: jonathan.druart+koha at gmail.com
            QA Contact: testopia at bugs.koha-community.org
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 14:04:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 12:04:23 +0000
    Subject: [Koha-bugs] [Bug 30467] BatchDeleteItem task does not deal with
     indexation correctly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30467
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |27344
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    [Bug 27344] Implement Elastic's update_index_background using
    Koha::BackgroundJob
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 14:04:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 12:04:23 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30467
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30467
    [Bug 30467] BatchDeleteItem task does not deal with indexation correctly
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 14:14:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 12:14:55 +0000
    Subject: [Koha-bugs] [Bug 30467] BatchDeleteItem task does not deal with
     indexation correctly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30467
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 14:14:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 12:14:59 +0000
    Subject: [Koha-bugs] [Bug 30467] BatchDeleteItem task does not deal with
     indexation correctly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30467
    
    --- Comment #1 from Jonathan Druart  ---
    Created attachment 132992
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132992&action=edit
    Bug 30467: Don't send the delete request for each item
    
    We are sending the request when all the items have been deleted.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 14:15:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 12:15:40 +0000
    Subject: [Koha-bugs] [Bug 30467] BatchDeleteItem task does not deal with
     indexation correctly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30467
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |dcook at prosentient.com.au,
                       |                            |julian.maurice at biblibre.com
                       |                            |,
                       |                            |martin.renvoize at ptfs-europe
                       |                            |.com, tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 14:22:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 12:22:46 +0000
    Subject: [Koha-bugs] [Bug 27859] MARC export for search results
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859
    
    David Gustafsson  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131443|0                           |1
            is obsolete|                            |
    
    --- Comment #11 from David Gustafsson  ---
    Created attachment 132993
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132993&action=edit
    Bug 27859: marc search result export
    
    Enable export of staff interface search results in different marc formats.
    The export will be mailed to the configured mail address of the current user.
    This feature is Elasticsearch only.
    
    To test:
    1) Apply patch
    2) Run installer/data/mysql/updatedatabase.pl
    3) Make sure the syspref EnableSearchResultMARCExport is enabled
    4) Make sure the syspref EnableSearchResultMARCExportEmail is enabled
    5) Make sure the current user has the tools -> export_catalog permission
    6) Make sure the current user has an email under your control set
    7) Perform a search
    8) Export the serach result by choosing a format under the
       "Export results" drop down
    9) Verify that link(s) with exported data has been mailed to the
       provided email
    10) Revoke the permission in 3) and make sure exporting is no longer
       possible
    11) Run tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t
    
    Sponsored-by: Gothenburg University Library
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 14:23:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 12:23:22 +0000
    Subject: [Koha-bugs] [Bug 27859] MARC export for search results
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859
    
    David Gustafsson  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Patch doesn't apply         |Needs Signoff
    
    --- Comment #12 from David Gustafsson  ---
    Ok! Rebased against master.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 14:33:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 12:33:24 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    --- Comment #53 from Jonathan Druart  ---
    Created attachment 132994
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132994&action=edit
    Bug 27344: Fix tests
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 14:37:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 12:37:43 +0000
    Subject: [Koha-bugs] [Bug 30468] New: koha-mysql does not honor Koha's
     timezone setting
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30468
    
                Bug ID: 30468
               Summary: koha-mysql does not honor Koha's timezone setting
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Architecture, internals, and plumbing
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: kyle at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
    
    If I run a query like "SELECT NOW()" from a koha report, I will get a different
    answer than if I had run it from koha-mysql. In Koha, we set the timezone for
    each database connection. However, koha-mysql does not do this, so instead we
    are left using the default timezone of the database.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 14:39:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 12:39:19 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    --- Comment #54 from Jonathan Druart  ---
    Created attachment 132995
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132995&action=edit
    Bug 27344: Fix call to update_index with invalid ids
    
    Can't use an undefined value as an ARRAY reference at
    /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Indexer.pm line 121.
    
    Caught that when working on follow-up bug reports.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 14:40:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 12:40:27 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Needs Signoff
    
    --- Comment #55 from Jonathan Druart  ---
    Ready for testing again. I think we should push all the related bug reports
    along with this one.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 14:41:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 12:41:48 +0000
    Subject: [Koha-bugs] [Bug 30468] koha-mysql does not honor Koha's timezone
     setting
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30468
    
    --- Comment #1 from Kyle M Hall  ---
    Created attachment 132996
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132996&action=edit
    Bug 30468: koha-mysql does not honor Koha's timezone setting
    
    If I run a query like "SELECT NOW()" from a koha report, I will get a different
    answer than if I had run it from koha-mysql.
    In Koha, we set the timezone for each database connection.
    However, koha-mysql does not do this, so instead we are left using the default
    timezone of the database.
    
    Test Plan:
    1) Set your time zone to something other than the database time zone
    2) run "SELECT NOW()" using debian/scripts/koha-mysql
       *not* /usr/sbin/koha-mysql
    3) Note you get the database timezone's current time
    4) Apply this patch
    5) Repeat step 2
    6) Now you get the correct time!
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 14:42:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 12:42:04 +0000
    Subject: [Koha-bugs] [Bug 27859] MARC export for search results
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859
    
    David Gustafsson  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132993|0                           |1
            is obsolete|                            |
    
    --- Comment #13 from David Gustafsson  ---
    Created attachment 132997
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132997&action=edit
    Bug 27859: marc search result export
    
    Enable export of staff interface search results in different marc formats.
    The export will be mailed to the configured mail address of the current user.
    This feature is Elasticsearch only.
    
    To test:
    1) Apply patch
    2) Run installer/data/mysql/updatedatabase.pl
    3) Make sure the syspref EnableSearchResultMARCExport is enabled
    4) Make sure the syspref EnableSearchResultMARCExportEmail is enabled
    5) Add a custom filter in the SearchResultMARCExportCustomFormats syspref,
       for example by copying one of the example formats
    6) Make sure the current user has the tools -> export_catalog permission
    7) Make sure the current user has an email under your control set
    8) Perform a search
    9) Export the search result for each format in the
       "Export all results" drop down
    10) Verify that link(s) with exported data has been mailed to the
       provided email
    11) Revoke the permission in 3) and make sure exporting is no longer
       possible
    12) Run tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t
    
    Sponsored-by: Gothenburg University Library
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 14:44:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 12:44:28 +0000
    Subject: [Koha-bugs] [Bug 30469] New: Hold cancellation grace period
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30469
    
                Bug ID: 30469
               Summary: Hold cancellation grace period
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Hold requests
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: andrew at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com
    
    Sometimes a patron cancels a hold in error. They can place a new hold, but end
    up at the end of the priority list. It would be patron-friendly to allow a hold
    cancellation grace period -- a window in which a patron can recover a cancelled
    hold at their original priority. For the first X hours after the hold is
    cancelled, the patron can still see the hold on the OPAC and is given a button
    to recover the hold. After X hours, the hold is no longer shown to the patron
    and cannot be recovered.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 14:46:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 12:46:20 +0000
    Subject: [Koha-bugs] [Bug 30468] koha-mysql does not honor Koha's timezone
     setting
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30468
    
    Kyle M Hall  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132996|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Kyle M Hall  ---
    Created attachment 132998
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132998&action=edit
    Bug 30468: koha-mysql does not honor Koha's timezone setting
    
    If I run a query like "SELECT NOW()" from a koha report, I will get a different
    answer than if I had run it from koha-mysql.
    In Koha, we set the timezone for each database connection.
    However, koha-mysql does not do this, so instead we are left using the default
    timezone of the database.
    
    Test Plan:
    1) Set your time zone to something other than the database time zone
    2) run "SELECT NOW()" using debian/scripts/koha-mysql
       *not* /usr/sbin/koha-mysql
    3) Note you get the database timezone's current time
    4) Apply this patch
    5) Repeat step 2
    6) Now you get the correct time!
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:02:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:02:29 +0000
    Subject: [Koha-bugs] [Bug 30468] koha-mysql does not honor Koha's timezone
     setting
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30468
    
    Kyle M Hall  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:02:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:02:33 +0000
    Subject: [Koha-bugs] [Bug 30468] koha-mysql does not honor Koha's timezone
     setting
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30468
    
    Kyle M Hall  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132998|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Kyle M Hall  ---
    Created attachment 132999
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132999&action=edit
    Bug 30468: koha-mysql does not honor Koha's timezone setting
    
    If I run a query like "SELECT NOW()" from a koha report, I will get a different
    answer than if I had run it from koha-mysql.
    In Koha, we set the timezone for each database connection.
    However, koha-mysql does not do this, so instead we are left using the default
    timezone of the database.
    
    Test Plan:
    1) Set your time zone to something other than the database time zone
    2) run "SELECT NOW()" using debian/scripts/koha-mysql
       *not* /usr/sbin/koha-mysql
    3) Note you get the database timezone's current time
    4) Apply this patch
    5) Repeat step 2
    6) Now you get the correct time!
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:08:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:08:09 +0000
    Subject: [Koha-bugs] [Bug 30468] koha-mysql does not honor Koha's timezone
     setting
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30468
    
    Kyle M Hall  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132999|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Kyle M Hall  ---
    Created attachment 133000
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133000&action=edit
    Bug 30468: koha-mysql does not honor Koha's timezone setting
    
    If I run a query like "SELECT NOW()" from a koha report, I will get a different
    answer than if I had run it from koha-mysql.
    In Koha, we set the timezone for each database connection.
    However, koha-mysql does not do this, so instead we are left using the default
    timezone of the database.
    
    Test Plan:
    1) Set your time zone to something other than the database time zone
    2) run "SELECT NOW()" using debian/scripts/koha-mysql
       *not* /usr/sbin/koha-mysql
    3) Note you get the database timezone's current time
    4) Apply this patch
    5) Repeat step 2
    6) Now you get the correct time!
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:11:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:11:22 +0000
    Subject: [Koha-bugs] [Bug 30470] New: Apply CheckPrevCheckout logic when
     placing a hold on the OPAC
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30470
    
                Bug ID: 30470
               Summary: Apply CheckPrevCheckout logic when placing a hold on
                        the OPAC
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Hold requests
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: sally.healey at cheshiresharedservices.gov.uk
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com
    
    Bug 20421 introduced CheckPrevCheckout logic when placing a hold on the staff
    client.
    
    It would be useful to have the same CheckPrevCheckout logic implemented for
    patrons when placing a hold on the OPAC.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:11:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:11:22 +0000
    Subject: [Koha-bugs] [Bug 20421] Apply CheckPrevCheckout logic when placing
     a hold on the staff client
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20421
    
    Sally  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30470
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:16:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:16:11 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #14 from Jonathan Druart  ---
    (In reply to Bernardo Gonzalez Kriegel from comment #13)
    > NOTE: check that installer/data/mysql/xx-YY (or es-ES) does *not* exists
    > before doing the install phase. By design that dir is not overwritten or
    > updated.
    
    Ha! I didn't know (or forgot) that!
    That helped a lot, thanks.
    
    Everything is working for me now! :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:24:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:24:12 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #15 from Jonathan Druart  ---
    How hard would it be to provide patches for languages that had UNIMARC
    frameworks with the descriptions translated (it-IT, uk-UA, etc.)?
    
    I would like to push this ASAP and let testers test against master.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:24:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:24:20 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |rel_22_05_candidate
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:29:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:29:09 +0000
    Subject: [Koha-bugs] [Bug 30332] SRU does not work via https
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30332
    
    --- Comment #6 from Thomas Klausner  ---
    
    > I would not recommend doing so. You'd better concentrate on running Koha in
    > a container and put a (standard) nginx container or so before it as reverse
    > proxy handling https.
    > By the way, you should be able to handle the same thing in Apache too
    > without touching Zoom C code. Catch the https request, proxy it to the local
    > http port where Zebra listens, etc.
    
    While I prefer nginx, Koha comes with Apache, and adding another webserver
    seems a bit like overkill.
    
    And the problem is not related to Zebra or local code, but that some SRU
    servers only provide https access. And Koha cannot talk to those servers. It's
    not *incoming* https that's the problem!
    
    And finally, this solution would make it impossible for people with only access
    to the web interface to add SRU services (because the proxy config would have
    to be set in nginx/apache config files)
    
    Again, the proper solution would be to fix Koha to be able to use https SRU
    services. Currently this fails horrible, not even reporting any errors back,
    just "no hits".
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:33:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:33:17 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #16 from Jonathan Druart  ---
    Thibault, you can see the framework with translated descriptions on this
    sandbox:
    https://staff-bug30373.sandboxes.biblibre.eu/cgi-bin/koha/admin/marctagstructure.pl?frameworkcode=
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:35:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:35:19 +0000
    Subject: [Koha-bugs] [Bug 27619] Remove fr-FR installer data
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |ASSIGNED
               Keywords|                            |rel_22_05_candidate
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:35:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:35:27 +0000
    Subject: [Koha-bugs] [Bug 27619] Remove fr-FR installer data
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                       |ity.org                     |com
               Severity|minor                       |major
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:47:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:47:40 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #129780|0                           |1
            is obsolete|                            |
     Attachment #129781|0                           |1
            is obsolete|                            |
     Attachment #129782|0                           |1
            is obsolete|                            |
     Attachment #129783|0                           |1
            is obsolete|                            |
     Attachment #129784|0                           |1
            is obsolete|                            |
     Attachment #129785|0                           |1
            is obsolete|                            |
     Attachment #129786|0                           |1
            is obsolete|                            |
     Attachment #129787|0                           |1
            is obsolete|                            |
     Attachment #129788|0                           |1
            is obsolete|                            |
     Attachment #129790|0                           |1
            is obsolete|                            |
     Attachment #129791|0                           |1
            is obsolete|                            |
     Attachment #129792|0                           |1
            is obsolete|                            |
     Attachment #129793|0                           |1
            is obsolete|                            |
     Attachment #129794|0                           |1
            is obsolete|                            |
     Attachment #129795|0                           |1
            is obsolete|                            |
     Attachment #129796|0                           |1
            is obsolete|                            |
     Attachment #129797|0                           |1
            is obsolete|                            |
     Attachment #129798|0                           |1
            is obsolete|                            |
     Attachment #129799|0                           |1
            is obsolete|                            |
     Attachment #129800|0                           |1
            is obsolete|                            |
     Attachment #129801|0                           |1
            is obsolete|                            |
     Attachment #129802|0                           |1
            is obsolete|                            |
     Attachment #129803|0                           |1
            is obsolete|                            |
     Attachment #129804|0                           |1
            is obsolete|                            |
     Attachment #129805|0                           |1
            is obsolete|                            |
     Attachment #131875|0                           |1
            is obsolete|                            |
     Attachment #131876|0                           |1
            is obsolete|                            |
    
    --- Comment #90 from Jonathan Druart  ---
    Created attachment 133001
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133001&action=edit
    Bug 29648: Item types administration view
    
    Set noItemTypeImages and OpacNoItemTypeImages to "No" and confirm
    that the first column (the image) is not displayed. Otherwise test as
    "normal"
    
    Signed-off-by: Owen Leonard 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:47:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:47:46 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #91 from Jonathan Druart  ---
    Created attachment 133002
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133002&action=edit
    Bug 29648: Allow tables_settings.default_display_length to be NULL
    
    We actually want this value to be NULL. If set to NULL and
    default_display_length is not in the yml, then the option will not be
    displayed.
    
    Signed-off-by: Owen Leonard 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:47:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:47:51 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #92 from Jonathan Druart  ---
    Created attachment 133003
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133003&action=edit
    Bug 29648: DBIC Schema changes
    
    Signed-off-by: Owen Leonard 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:47:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:47:57 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #93 from Jonathan Druart  ---
    Created attachment 133004
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133004&action=edit
    Bug 29648: Catalogue detail - no default_display_length
    
    On the acquisition table the sort option is not available as we don't
    offer the ability to selection asc/desc and default to asc.
    We cannot offer default_display_length for those tables.
    
    Signed-off-by: Owen Leonard 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:48:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:48:02 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #94 from Jonathan Druart  ---
    Created attachment 133005
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133005&action=edit
    Bug 29648: Checkout history - normal no sort
    
    Signed-off-by: Owen Leonard 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:48:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:48:07 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #95 from Jonathan Druart  ---
    Created attachment 133006
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133006&action=edit
    Bug 29648: Cataloguing Z3950 search - no pagination
    
    Pagination is done server-side
    
    Signed-off-by: Owen Leonard 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:48:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:48:11 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #96 from Jonathan Druart  ---
    Created attachment 133007
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133007&action=edit
    Bug 29648: Overdue list - normal
    
    'stateSave' so need to test on the first try or delete the relevant local
    storage
    entry
    
    Signed-off-by: Owen Leonard 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:48:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:48:16 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #97 from Jonathan Druart  ---
    Created attachment 133008
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133008&action=edit
    Bug 29648: Holds to pull - normal
    
    Signed-off-by: Owen Leonard 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:48:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:48:21 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #98 from Jonathan Druart  ---
    Created attachment 133009
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133009&action=edit
    Bug 29648: Holds ratios - normal but no sort
    
    Signed-off-by: Owen Leonard 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:48:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:48:27 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #99 from Jonathan Druart  ---
    Created attachment 133010
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133010&action=edit
    Bug 29648: Holds queue - only sort
    
    Signed-off-by: Owen Leonard 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:48:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:48:31 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #100 from Jonathan Druart  ---
    Created attachment 133011
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133011&action=edit
    Bug 29648: Course reserve detail - normal
    
    Signed-off-by: Owen Leonard 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:48:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:48:36 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #101 from Jonathan Druart  ---
    Created attachment 133012
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133012&action=edit
    Bug 29648: Course reserve list - normal
    
    Signed-off-by: Owen Leonard 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:48:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:48:41 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #102 from Jonathan Druart  ---
    Created attachment 133013
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133013&action=edit
    Bug 29648: ILL - no change
    
    No change expected here for ILL
    
    Signed-off-by: Owen Leonard 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:48:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:48:46 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #103 from Jonathan Druart  ---
    Created attachment 133014
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133014&action=edit
    Bug 29648: Patron accounting page - no sort
    
    because of desc
    
    Signed-off-by: Owen Leonard 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:48:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:48:51 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #104 from Jonathan Druart  ---
    Created attachment 133015
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133015&action=edit
    Bug 29648: Patron page (PatronsPerPage) - no change
    
    PatronsPerPage should be done on a separate bug report, not trivial
    
    Signed-off-by: Owen Leonard 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:48:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:48:55 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #105 from Jonathan Druart  ---
    Created attachment 133016
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133016&action=edit
    Bug 29648: Payments - normal
    
    Signed-off-by: Owen Leonard 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:49:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:49:01 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #106 from Jonathan Druart  ---
    Created attachment 133017
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133017&action=edit
    Bug 29648: Checkout history - no sort
    
    Signed-off-by: Owen Leonard 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:49:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:49:06 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #107 from Jonathan Druart  ---
    Created attachment 133018
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133018&action=edit
    Bug 29648: patron list table - normal
    
    Signed-off-by: Owen Leonard 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:49:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:49:11 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #108 from Jonathan Druart  ---
    Created attachment 133019
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133019&action=edit
    Bug 29648: Item lost report - no change
    
    hum, there is no sort on this table, so it's displayed like it's coming
    from the controller, but perl code does not sort either.
    This could be improved and we could make it configurable easily
    
    Signed-off-by: Owen Leonard 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:49:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:49:16 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #109 from Jonathan Druart  ---
    Created attachment 133020
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133020&action=edit
    Bug 29648: Subscription detail - no change
    
    Signed-off-by: Owen Leonard 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:49:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:49:21 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #110 from Jonathan Druart  ---
    Created attachment 133021
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133021&action=edit
    Bug 29648: Log viewer - no sort
    
    Signed-off-by: Owen Leonard 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:49:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:49:26 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #111 from Jonathan Druart  ---
    Created attachment 133022
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133022&action=edit
    Bug 29648: Holds history - no sort
    
    because of desc
    
    Signed-off-by: Owen Leonard 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:49:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:49:29 +0000
    Subject: [Koha-bugs] [Bug 30471] New: Typo in Circulation Rules - Lost item
     fee refund policy
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30471
    
                Bug ID: 30471
               Summary: Typo in Circulation Rules - Lost item fee refund
                        policy
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Staff Client
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: nick at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com
    
    When setting a rules for a specific branch the default rule is displayed
    incorrectly
    
    To test:
    1 - Browse to 'Administration->Circulation and fines rules'
    2 - Make sure you are editing 'Standard rules for all libraries'
    3 - Set 'Lost item fee refund on return policy' to 'Refund lost item charge and
    charge new overdue fine'
    4 - Swtich to edit rules for a specific library, click on the dropdown for
    'Lost item fee refund on return policy' and note default says 'Use default
    (Refund lost item charge and restore overdue fine)'
    5 - Switch default/all libraries rule to 'Refund lost item charge and restore
    overdue fine'
    6 - On specific branch note the default option is now 'Use default (Refund lost
    item charge and charge new overdue fine)'
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:49:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:49:32 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #112 from Jonathan Druart  ---
    Created attachment 133023
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133023&action=edit
    Bug 29648: Notice template - only sort
    
    Signed-off-by: Owen Leonard 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:49:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:49:37 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #113 from Jonathan Druart  ---
    Created attachment 133024
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133024&action=edit
    Bug 29648: Remove default sort order for detail
    
    On the detail view the number of columns changed, we cannot use the
    default sort order here.
    It certainly can be done on a different way but I prefer to postpone it
    for now and see later.
    
    Signed-off-by: Owen Leonard 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:49:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:49:42 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #114 from Jonathan Druart  ---
    Created attachment 133025
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133025&action=edit
    Bug 29648: Upload tool - no sort
    
    Signed-off-by: Owen Leonard 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:49:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:49:47 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #115 from Jonathan Druart  ---
    Created attachment 133026
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133026&action=edit
    Bug 29648: Returns - no change
    
    No change expected here, there is no sort and no paginate possible.
    
    Signed-off-by: Owen Leonard 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:49:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:49:52 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #116 from Jonathan Druart  ---
    Created attachment 133027
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133027&action=edit
    Bug 29648: Fix occurrences of GetColumns
    
    We could add the configuration to these tables as well, but let go first
    but the others (read: feeling lazy right now).
    
    Signed-off-by: Owen Leonard 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:50:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:50:06 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #117 from Jonathan Druart  ---
    QA please? This is a nightmare to rebase!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:51:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:51:19 +0000
    Subject: [Koha-bugs] [Bug 30471] Typo in Circulation Rules - Lost item fee
     refund policy
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30471
    
    Nick Clemens  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:51:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:51:22 +0000
    Subject: [Koha-bugs] [Bug 30471] Typo in Circulation Rules - Lost item fee
     refund policy
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30471
    
    --- Comment #1 from Nick Clemens  ---
    Created attachment 133028
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133028&action=edit
    Bug 30471: Correct display of default rules
    
    To test:
    1 - Browse to 'Administration->Circulation and fines rules'
    2 - Make sure you are editing 'Standard rules for all libraries'
    3 - Set 'Lost item fee refund on return policy' to 'Refund lost item charge and
    charge new overdue fine'
    4 - Swtich to edit rules for a specific library, click on the dropdown for
    'Lost item fee refund on return policy' and note default says 'Use default
    (Refund lost item charge and restore overdue fine)'
    5 - Switch default/all libraries rule to 'Refund lost item charge and restore
    overdue fine'
    6 - On specific branch note the default option is now 'Use default (Refund lost
    item charge and charge new overdue fine)'
    7 - Apply patch and repeat, note the default descriptions now display correctly
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:51:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:51:30 +0000
    Subject: [Koha-bugs] [Bug 30471] Typo in Circulation Rules - Lost item fee
     refund policy
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30471
    
    Nick Clemens  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                       |ity.org                     |
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:52:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:52:15 +0000
    Subject: [Koha-bugs] [Bug 29723] Add a "Configure table" button for
     KohaTable tables
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #128648|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from Jonathan Druart  ---
    Created attachment 133029
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133029&action=edit
    Bug 29723: Add a "Configure table" button for KohaTable tables
    
    This patch suggests to have a "Configure table" button when a table can
    be configured in the "Table settings" administraition area.
    
    Test plan:
    Go to different views where the table can be configured (you an
    exhaustive list on bug 29648), notice the "Configure table" button (if
    you have the 'manage_column_config' subpermission.
    
    Note that the link is correct but the scrollbar is not adjusted at the
    correct position. Maybe we could improve that switching to the bootstrap
    accordion plugin?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 15:52:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 13:52:25 +0000
    Subject: [Koha-bugs] [Bug 29723] Add a "Configure table" button for
     KohaTable tables
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723
    
    --- Comment #7 from Jonathan Druart  ---
    (In reply to Lucas Gass from comment #5)
    > Jonathan,
    > 
    > The patch looks nice. The QA tool says you need a filter:
    > 
    > FAIL	koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc
    >    FAIL	  filters
    > 		missing_filter at line 28 (var CAN_user_parameters_manage_column_config =
    > [% CAN_user_parameters_manage_column_config ? 1 : 0 %];)
    
    Fixed, thanks Lucas!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 16:00:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 14:00:46 +0000
    Subject: [Koha-bugs] [Bug 30332] SRU does not work via https
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30332
    
    --- Comment #7 from Nick Clemens  ---
    Testing with the example config you give I am able to connect and retrieve
    results when using KTD - so I am not sure this is a Koha issue
    
    On the other hand, testing from the bywater koha demo - I get no results - so I
    wonder if it is a difference in master, or a configuration issue
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 16:05:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 14:05:12 +0000
    Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539
    
    David Gustafsson  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #127980|0                           |1
            is obsolete|                            |
    
    --- Comment #41 from David Gustafsson  ---
    Created attachment 133030
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133030&action=edit
    Bug 25539: Remove AddBiblio option "defer_marc_save"
    
    Items are no longer embedded in the MARCXML and because of this the MARC data
    does not need to be saved once more after changing record items data.
    The "defer_marc_save" is no longer needed since bulkmarcimport.pl was the only
    place this option was utilized in order to resave MARC data after possibly
    changing
    items data. There is also a bug bulkmarcimport.pl where the record data is
    re-saved
    without stripping items if duplicate items are found and the dedup barcodes
    option is enabled that is resolved by this change.
    
    This change enables MARC Overlay rules to be enabled for bulkmarkcimport.pl as
    using
    the defer_marc option would previously effectively bypass any defined rules.
    
    To test
    1) Apply patch 29440 (which this depends on), but no not yet apply this
       patch
    2) Remove comments around "overlay_context => { source => 'bulkmarcimport' }"
       in misc/migration_tools/bulkmarcimport.pl line 129
    3) Enable MARC overlay rules and add a rule (with source => "*" or
       'bulkmarcimport') to protect some field.
    4) Import a biblio using the bulkmarcimport script. Overlay rules will
       only be applied on updates so a match condition matching the
       record in Koha when bulkmarcimport.pl is run the next time for the same
       record needs to be supplied (for example -match "control-number,001")
    5) Edit the imported biblio and change the value of the protected field
    6) Run bulkmarcimport with the same parameters as in 4) and verify the
       the field that should have been protected has been overwritten
    7) Revert changes for line 129 in bulkmarcimport.pl (or will result in
       conflict applying the patch), apply the patch and repeat steps 4-5,
       verify that the field now was protected from being overwritten.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 16:05:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 14:05:17 +0000
    Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539
    
    David Gustafsson  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #127981|0                           |1
            is obsolete|                            |
    
    --- Comment #42 from David Gustafsson  ---
    Created attachment 133031
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133031&action=edit
    Bug 25539: Strip items when adding new biblio to preserve previous behaviour of
    the script
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 16:05:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 14:05:21 +0000
    Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539
    
    --- Comment #43 from David Gustafsson  ---
    Created attachment 133032
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133032&action=edit
    Bug 25539: Enable bulkmarcimport overlay context
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 16:05:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 14:05:59 +0000
    Subject: [Koha-bugs] [Bug 30472] New: Field
     borrower_relationships.guarantor_id should be marked as NOT NULL
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30472
    
                Bug ID: 30472
               Summary: Field borrower_relationships.guarantor_id should be
                        marked as NOT NULL
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Database
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: m.de.rooy at rijksmuseum.nl
            QA Contact: testopia at bugs.koha-community.org
    
    See also $DBversion = '19.06.00.022'; CREATE TABLE `borrower_relationships`
    [...]                   guarantor_id INT(11) NOT NULL,                  
    guarantee_id INT(11) NOT NULL,
    
    Many production db's will have both fields already NOT NULL.
    We need to adjust kohastructure and DBIx
    
    Note that non-patron guarantors are NOT saved in this table but in the
    borrowers table itself IIUC.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 16:11:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 14:11:03 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #17 from Bernardo Gonzalez Kriegel  ---
    (In reply to Jonathan Druart from comment #15)
    > How hard would it be to provide patches for languages that had UNIMARC
    > frameworks with the descriptions translated (it-IT, uk-UA, etc.)?
    > 
    > I would like to push this ASAP and let testers test against master.
    
    Ok, I'll open a new bug with all new *-installer-UNIMARC.po, and fill them as
    much as possible.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 16:11:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 14:11:20 +0000
    Subject: [Koha-bugs] [Bug 30471] Typo in Circulation Rules - Lost item fee
     refund policy
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30471
    
    Sara Brown  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |sbrown at bywatersolutions.com
    
    --- Comment #2 from Sara Brown  ---
    This appears to happen when the 'Standard' rule is 'Refund lost item charge and
    charge new overdue fine' (displayed for branches as 'Use default (Refund lost
    item charge and restore overdue fine)') or 'Refund lost item charge and restore
    overdue fine' (displayed for branches as 'Use default 'Refund lost item charge
    and charge new overdue fine)'. Branches display correctly when the 'Standard'
    is 'Leave lost item charge' or 'Refund lost item charge'.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 16:11:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 14:11:47 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    --- Comment #56 from Jonathan Druart  ---
    Created attachment 133033
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133033&action=edit
    Bug 27344: Add error detail if something wrong happened
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 16:17:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 14:17:06 +0000
    Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539
    
    --- Comment #44 from David Gustafsson  ---
    @(In reply to David Cook from comment #40)
    > I really want to get rid of "defer_marc_save" as it's a real pain
    > (especially when using Koha plugins).
    > 
    > But I'm not sure I understand the test plan...
    
    I sympathize with the fact the test-plan is probably not exactly crystal clear,
    compounded by or perhaps due to the fact that bulkmarcimport is not even
    selectable in the UI (as it's commented out because of the bug this patch
    should solve). I added a step to the testplan to remove the comments and enable
    bulkmarcimport as a source (now realizing i pointed to the wrong line in the
    wrong file, will fix this).
    
    Also the bulkmarcimport.pl command to test this could look something like this:
    
    ./bulkmarcimport.pl -b -file /tmp/test_record.marc -l /tmp/bulkmarcimport.log
    -append  -insert -update -c=MARC21 -match "control-number,001"
    
    It's not part of the test-plan, but it could be useful to use the logfile
    feature as to ensure that the biblio is really matched and updated on
    subsequent runs.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 16:19:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 14:19:18 +0000
    Subject: [Koha-bugs] [Bug 30432] get_items_that_can_fill needs to specify
     table for biblionumbers
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com
                 Status|Signed Off                  |Failed QA
    
    --- Comment #5 from Jonathan Druart  ---
    Tests are failing for me
    
    t/db_dependent/Koha/Holds.t .. 5/7 
        #   Failed test 'Items 1, 2, and 5 are available for filling the holds'
        #   at t/db_dependent/Koha/Holds.t line 516.
        #     Structures begin differing at:
        #          $got->[0] = '1006'
        #     $expected->[0] = '1005'
        # Looks like you failed 1 test of 6.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 16:20:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 14:20:29 +0000
    Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539
    
    David Gustafsson  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133030|0                           |1
            is obsolete|                            |
    
    --- Comment #45 from David Gustafsson  ---
    Created attachment 133034
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133034&action=edit
    Bug 25539: Remove AddBiblio option "defer_marc_save"
    
    Items are no longer embedded in the MARCXML and because of this the MARC data
    does not need to be saved once more after changing record items data.
    The "defer_marc_save" is no longer needed since bulkmarcimport.pl was the only
    place this option was utilized in order to resave MARC data after possibly
    changing
    items data. There is also a bug bulkmarcimport.pl where the record data is
    re-saved
    without stripping items if duplicate items are found and the dedup barcodes
    option is enabled that is resolved by this change.
    
    This change enables MARC Overlay rules to be enabled for bulkmarkcimport.pl as
    using
    the defer_marc option would previously effectively bypass any defined rules.
    
    To test
    1) Apply patch 29440 (which this depends on), but no not yet apply this
       patch
    2) Remove comments around "bulkmarcimport: _("bulkmarcimport.pl"),"
       in koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt
       line 463
    3) Enable MARC overlay rules and add a rule (with source => "*" or
       'bulkmarcimport') to protect some field.
    4) Import a biblio using the bulkmarcimport script. Overlay rules will
       only be applied on updates so a match condition matching the
       record in Koha when bulkmarcimport.pl is run the next time for the same
       record needs to be supplied (for example -match "control-number,001")
    5) Edit the imported biblio and change the value of the protected field
    6) Run bulkmarcimport with the same parameters as in 4) and verify the
       the field that should have been protected has been overwritten
    7) Revert changes for line 463 in marc-overlay-rules.tt (or will result in
       conflict applying the patch), apply the patch and repeat steps 4-5,
       verify that the field now was protected from being overwritten.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 16:20:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 14:20:34 +0000
    Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539
    
    David Gustafsson  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133031|0                           |1
            is obsolete|                            |
    
    --- Comment #46 from David Gustafsson  ---
    Created attachment 133035
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133035&action=edit
    Bug 25539: Strip items when adding new biblio to preserve previous behaviour of
    the script
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 16:20:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 14:20:39 +0000
    Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539
    
    David Gustafsson  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133032|0                           |1
            is obsolete|                            |
    
    --- Comment #47 from David Gustafsson  ---
    Created attachment 133036
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133036&action=edit
    Bug 25539: Enable bulkmarcimport overlay context
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr  6 16:21:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 14:21:27 +0000
    Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search
     function for staff interface
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077
    
    --- Comment #14 from Owen Leonard  ---
    Created attachment 133037
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133037&action=edit
    Bug 30077: (follow-up) Set max width for library drapdown
    
    If you have a library with a very long name the dropdown will expand to
    accommodate it. I think this is awkward-looking, so I propose to set a
    max width on  elements in the header search region.
    > 
    > The patch requires a rebuild of the staff interface CSS:
    > https://wiki.koha-community.org/wiki/
    > Working_with_SCSS_in_the_OPAC_and_staff_client
    
    Nice catch, thanks Owen!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 00:35:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 22:35:30 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #22 from Bernardo Gonzalez Kriegel  ---
    (In reply to Bernardo Gonzalez Kriegel from comment #20)
    > Yep, search is broken but without the patches.
    > 
    > Try master fr-FR or en UNIMARC installs, both shows the same when doing a
    > search (empty catalog)
    > 
    > "Unsupported UNIMARC character encoding [] for XML output for UNIMARC; 100$a
    > -> Rischkowsky, B. at /usr/share/perl5/MARC/File/XML.pm line 570
    > ... etc"
    
    Disabling plack it works :(
    
    root at kohadevbox:~$ koha-plack --disable kohadev
    Plack disabled for kohadev OPAC
    Plack disabled for kohadev Intranet
    root at kohadevbox:~$ restart_all 
    ...
    root at kohadevbox:~$ koha-rebuild-zebra --force -v -v -a -b kohadev 
    ...       
    
    and search gives no results, as expected, but also no errors
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 00:44:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 22:44:11 +0000
    Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538
    
    --- Comment #6 from Alex Buckley  ---
    Created attachment 133053
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133053&action=edit
    Bug 23538: (follow-up) Fix up notices
    
    - Add toolkit template syntax to notices
    - Add translated notice
    
    Sponsored-by: Catalyst IT
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 01:53:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 06 Apr 2022 23:53:38 +0000
    Subject: [Koha-bugs] [Bug 30465] BatchUpdateBiblio task does not deal with
     indexation correctly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30465
    
    --- Comment #2 from David Cook  ---
    I'm not sure I'll be much help, as it looks like this is an Elasticsearch
    specific dev? From the Zebra side I think we'd actually get worse performance
    with this change.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 02:41:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 00:41:29 +0000
    Subject: [Koha-bugs] [Bug 30479] New: Add index for dateaccessioned in items
     table
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30479
    
                Bug ID: 30479
               Summary: Add index for dateaccessioned in items table
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: MARC Bibliographic data support
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: dcook at prosentient.com.au
            QA Contact: testopia at bugs.koha-community.org
    
    Dateaccessioned is a common column used for querying items (like in the
    coverflow plugin: https://github.com/bywatersolutions/koha-plugin-coverflow),
    and it can be a bit slow on large datasets, so we're suggesting adding an index
    to the items table for dateaccessioned.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 02:53:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 00:53:30 +0000
    Subject: [Koha-bugs] [Bug 28911] Bcrypt settings are required for
     pseudonymization but are not set on upgrade
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28911
    
    --- Comment #4 from David Cook  ---
    (In reply to David Cook from comment #3)
    > Just got stung by this one. 
    > 
    > There are quite a few settings like this I think (e.g. plugin_repos,
    > koha_xslt_security, smtp_server).
    
    I'm writing a local script that fixes up a lot of the missing/bad config. It's
    not very elegant but I could probably share it once I'm done.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 02:56:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 00:56:14 +0000
    Subject: [Koha-bugs] [Bug 28911] Bcrypt settings are required for
     pseudonymization but are not set on upgrade
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28911
    
    --- Comment #5 from David Cook  ---
    (In reply to David Cook from comment #4)
    > (In reply to David Cook from comment #3)
    > > Just got stung by this one. 
    > > 
    > > There are quite a few settings like this I think (e.g. plugin_repos,
    > > koha_xslt_security, smtp_server).
    > 
    > I'm writing a local script that fixes up a lot of the missing/bad config.
    > It's not very elegant but I could probably share it once I'm done.
    
    Basically, I loop through /etc/koha/sites, check each koha-conf.xml, and then
    re-write it. 
    
    It does pretty well overall. The output of XML::LibXML is quite similar to
    /etc/koha/koha-conf-site.xml.in. The main difference is a bit of whitespace and
    self-closing tags in some of the Zebra-specific configuration within .
    Zebra seems fine with empty tags and different whitespace, so I'm fairly
    content. Half-tempted to submit a patch to make the whitespace for
    /etc/koha/koha-conf-site.xml.in be more in line with the output of XML::LibXML,
    but I don't know what folk would think of that...
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 07:43:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 05:43:28 +0000
    Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897
    
    --- Comment #14 from Hugo Agud  ---
    The basic functionality is there and it is awesome, good job! however there are
    some minor issues to fix
    
    At bibliographic level:
    
    I do not think it will available, yet
    https://opac-bug29897.sandboxes.biblibre.eu/cgi-bin/koha/opac-detail.pl?biblionumber=439
    
    Inside Authorities identifiers tab
    
    a) None Links are functional:
    https://opac-bug29897.sandboxes.biblibre.eu/cgi-bin/koha/https%3A%2F%2Fwww.scopus.com%2Fauthid%2Fdetail.uri%3FauthorId%3D670165077
    
    b) Tag 110 is not included in Authorities identifiers tab
    
    
    At authority level:
    https://opac-bug29897.sandboxes.biblibre.eu/cgi-bin/koha/opac-authoritiesdetail.pl?authid=1708
    
    a) Only orcid link is published, all other identifiers are published without
    the link
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 07:53:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 05:53:41 +0000
    Subject: [Koha-bugs] [Bug 30376] Unable to save item if field date acquired
     is set mandatory
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30376
    
    Johanna Räisä  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133043|0                           |1
            is obsolete|                            |
    
    --- Comment #7 from Johanna Räisä  ---
    Created attachment 133054
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133054&action=edit
    Bug 30376: [ALTERNATIVE PATCH] Fix missing mandatory date  acquired error on
    item save
    
    Signed-off-by: Johanna Raisa 
    
    This alternative patch works better. After testing the first patch more there
    was a problem of saving mandatory fields, it allowed to save all empty
    mandatory fields.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 07:58:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 05:58:08 +0000
    Subject: [Koha-bugs] [Bug 30376] Unable to save item if field date acquired
     is set mandatory
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30376
    
    Johanna Räisä  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 08:04:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 06:04:03 +0000
    Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
     characters from input fields when cataloguing
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358
    
    Aleisha Amohia  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 08:04:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 06:04:08 +0000
    Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
     characters from input fields when cataloguing
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358
    
    --- Comment #7 from Aleisha Amohia  ---
    Created attachment 133055
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133055&action=edit
    Bug 30358: (follow-up) Inner newlines should be replaced with a space
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 08:04:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 06:04:12 +0000
    Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
     characters from input fields when cataloguing
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358
    
    --- Comment #8 from Aleisha Amohia  ---
    Created attachment 133056
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133056&action=edit
    Bug 30358: (follow-up) Fixing tests and including for inner newlines
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 08:15:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 06:15:41 +0000
    Subject: [Koha-bugs] [Bug 30194] Update required JSON::Validator version
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194
    
    Marcel de Rooy  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |m.de.rooy at rijksmuseum.nl
    
    --- Comment #98 from Marcel de Rooy  ---
    How long do we need the 'exp' workaround for dev environments ?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 09:15:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 07:15:07 +0000
    Subject: [Koha-bugs] [Bug 20511] Seasonal prediction just in the staff
     language
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511
    
    --- Comment #6 from Hugo Agud  ---
    I a trying to test into sandbox, but i have no way of updating po.
    
    I have seen that If I the pattern include to season like spring-summer, it only
    translates one of two.
    
    sample
    Número  Fecha de publicación
    Vol. Primavera, Number Summer, Issue 0  04/01/2022
    Vol. Verano, Number Fall, Issue 1       07/01/2022
    Vol. Otoño, Number Winter, Issue 2      10/01/2022
    Vol. Winter, Number Primavera, Issue 3  01/01/2023
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 09:17:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 07:17:05 +0000
    Subject: [Koha-bugs] [Bug 30465] BatchUpdateBiblio task does not deal with
     indexation correctly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30465
    
    --- Comment #3 from Jonathan Druart  ---
    (In reply to David Cook from comment #2)
    > I'm not sure I'll be much help, as it looks like this is an Elasticsearch
    > specific dev? From the Zebra side I think we'd actually get worse
    > performance with this change.
    
    Why, can you detail please?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 09:18:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 07:18:24 +0000
    Subject: [Koha-bugs] [Bug 30465] BatchUpdateBiblio task does not deal with
     indexation correctly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30465
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132988|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Jonathan Druart  ---
    Created attachment 133057
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133057&action=edit
    Bug 30465: Make BatchUpdateBiblio update the index in one request
    
    When using the batch record modification tool to modify several
    bibliographic records, we don't want to send one index request per
    biblio, we want to index them all on the fly after the records have been
    modified.
    Otherwise we will end up with one task per record, and records will be
    indexed in background.
    
    Test plan:
    Use the batch mod tool to modify bibliographic records and confirm the
    behaviour is correct.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 09:20:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 07:20:10 +0000
    Subject: [Koha-bugs] [Bug 30465] BatchUpdateBiblio task does not deal with
     indexation correctly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30465
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133057|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Jonathan Druart  ---
    Created attachment 133058
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133058&action=edit
    Bug 30465: Make BatchUpdateBiblio update the index in one request
    
    When using the batch record modification tool to modify several
    bibliographic records, we don't want to send one index request per
    biblio, we want to index them all on the fly after the records have been
    modified.
    Otherwise we will end up with one task per record, and records will be
    indexed in background.
    
    Test plan:
    Use the batch mod tool to modify bibliographic records and confirm the
    behaviour is correct.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 09:33:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 07:33:22 +0000
    Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859
    
    Fridolin Somers  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132983|1                           |0
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 09:40:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 07:40:37 +0000
    Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859
    
    --- Comment #16 from Fridolin Somers  ---
    > Bug 29859: Fix BatchUpdateAuthority
    Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 09:56:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 07:56:37 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #23 from Jonathan Druart  ---
    Yes, and I don't recreate the problem locally.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 09:58:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 07:58:36 +0000
    Subject: [Koha-bugs] [Bug 30476] Remove NORMARC translation files
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30476
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 09:59:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 07:59:35 +0000
    Subject: [Koha-bugs] [Bug 30476] Remove NORMARC translation files
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30476
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com
    
    --- Comment #2 from Jonathan Druart  ---
    Signed-off-by: Jonathan Druart 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 10:02:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 08:02:24 +0000
    Subject: [Koha-bugs] [Bug 30477] Add new UNIMARC installer translation files
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30477
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com
    
    --- Comment #4 from Jonathan Druart  ---
    Signed-off-by: Jonathan Druart 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 10:02:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 08:02:30 +0000
    Subject: [Koha-bugs] [Bug 30477] Add new UNIMARC installer translation files
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30477
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 10:04:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 08:04:53 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    --- Comment #24 from Jonathan Druart  ---
    Asking for a quick push and let us time to find bugs before the 22.05 release.
    
    Signed-off-by: Jonathan Druart 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 10:05:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 08:05:41 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    Jonathan Druart  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    --- Comment #25 from Jonathan Druart  ---
    Fridolin, patches with signed-off-by lines are available at
    https://gitlab.com/joubu/Koha/-/commits/bug_30373
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 10:10:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 08:10:55 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #26 from Jonathan Druart  ---
    I would push this along with bug 27619. We will need to adjust koha-misc4dev as
    well.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 10:12:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 08:12:20 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #27 from Jonathan Druart  ---
    (In reply to Jonathan Druart from comment #26)
    > I would push this along with bug 27619. We will need to adjust koha-misc4dev
    > as well.
    
    https://gitlab.com/koha-community/koha-misc4dev/-/issues/54
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 10:16:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 08:16:29 +0000
    Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859
    
    --- Comment #17 from Jonathan Druart  ---
    (In reply to Fridolin Somers from comment #16)
    > > Bug 29859: Fix BatchUpdateAuthority
    > Pushed to master
    
    I obsoleted this.(In reply to Fridolin Somers from comment #16)
    > > Bug 29859: Fix BatchUpdateAuthority
    > Pushed to master
    
    Hum? This patch was marked as obsolete, it shouldn't have been pushed. It was a
    mistake to attach it here. See bug 30461.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 10:23:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 08:23:26 +0000
    Subject: [Koha-bugs] [Bug 29954] Fix C4::Context->unset_userenv and rename
     _new too
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29954
    
    Marcel de Rooy  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Product|Koha security               |Koha
              Component|Koha                        |Architecture, internals,
                       |                            |and plumbing
             QA Contact|                            |testopia at bugs.koha-communit
                       |                            |y.org
                Version|unspecified                 |master
                  Group|Koha security               |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 10:29:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 08:29:42 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #28 from Thibault Keromnès  ---
    Arf maybe it's too late to ask for modification on the biblio framework?
    Two new things we found : 
        - 995 (items) $5 (dateaccessionned) shouldn't be in the editor, it's
    automatically filled with the current day and if you type something else than a
    properly formatted date it creates an error. I checked in master for now it's
    not in the editor. 
        - 325$a shouldn't be hidden
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 10:41:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 08:41:05 +0000
    Subject: [Koha-bugs] [Bug 30480] New: Split cataloguing log into items and
     bibliographic records
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30480
    
                Bug ID: 30480
               Summary: Split cataloguing log into items and bibliographic
                        records
     Change sponsored?: ---
               Product: Koha
               Version: 20.11
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Cataloging
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: katrin.fischer at bsz-bw.de
            QA Contact: testopia at bugs.koha-community.org
                    CC: m.de.rooy at rijksmuseum.nl
    
    The cataloguing log can create a lot of entries that are not always
    interesting, especially when you work in a union catalog setting.
    
    Items on the other hand may only be managed in Koha, so there is a great
    interest to log these changes.
    
    It would be great if you could choose to log either changes on items or
    bibliogrpahic records or both.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 10:49:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 08:49:31 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #29 from Jonathan Druart  ---
    Created attachment 133059
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133059&action=edit
    Bug 30373: Hide items.dateaccessioned from the editor
    
    -6 was used in unimarc_complet/Obligatoire/framework_DEFAULT.sql
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 10:49:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 08:49:35 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #30 from Jonathan Druart  ---
    Created attachment 133060
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133060&action=edit
    Bug 30373: Show 325$a
    
    It was not hidden in unimarc_complet/Obligatoire/framework_DEFAULT.sql
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 10:49:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 08:49:50 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #31 from Jonathan Druart  ---
    (In reply to Thibault Keromnès from comment #28)
    > Arf maybe it's too late to ask for modification on the biblio framework?
    > Two new things we found : 
    >     - 995 (items) $5 (dateaccessionned) shouldn't be in the editor, it's
    > automatically filled with the current day and if you type something else
    > than a properly formatted date it creates an error. I checked in master for
    > now it's not in the editor. 
    >     - 325$a shouldn't be hidden
    
    Never too late, thanks!
    
    Bernardo, Do those 2 patches look correct to you?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 11:10:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 09:10:39 +0000
    Subject: [Koha-bugs] [Bug 27291] Change datetime format in Zebra logs
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27291
    
    David Cook  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|dcook at prosentient.com.au    |koha-bugs at lists.koha-commun
                       |                            |ity.org
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 11:23:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 09:23:45 +0000
    Subject: [Koha-bugs] [Bug 30481] New: Drop unique constraint
     deleteditemsstocknumberidx for deleteditems
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30481
    
                Bug ID: 30481
               Summary: Drop unique constraint deleteditemsstocknumberidx for
                        deleteditems
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: minor
              Priority: P5 - low
             Component: Database
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: m.de.rooy at rijksmuseum.nl
            QA Contact: testopia at bugs.koha-community.org
    
    Caused by inconsistencies between kohastructure and updatedatabase.
    This unique key may be present in older databases.
    
    L3267 ALTER TABLE deleteditems ADD UNIQUE INDEX deleteditemsstocknumberidx
    (stocknumber);
    
    Note that this comment is not in kohastructure too:
    L3264 ALTER TABLE deleteditems ADD stocknumber VARCHAR(32) DEFAULT NULL COMMENT
    "stores the inventory number of deleted items";
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 11:25:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 09:25:24 +0000
    Subject: [Koha-bugs] [Bug 30481] Drop unique constraint
     deleteditemsstocknumberidx for deleteditems
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30481
    
    --- Comment #1 from Marcel de Rooy  ---
    Not sure if deleteditems.enumchron is correct too for older production dbs.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 11:26:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 09:26:38 +0000
    Subject: [Koha-bugs] [Bug 26657] "Unlinked" output of
     LinkBibHeadingsToAuthorities is ambiguous
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26657
    
    David Cook  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|dcook at prosentient.com.au    |koha-bugs at lists.koha-commun
                       |                            |ity.org
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 11:27:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 09:27:44 +0000
    Subject: [Koha-bugs] [Bug 30481] Drop unique constraint
     deleteditemsstocknumberidx for deleteditems
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30481
    
    --- Comment #2 from Katrin Fischer  ---
    It's a rather old issue, actually this is a duplicate to bug 23330 that has
    some of the history. Closed not too long ago (by me), but I'd actually be quite
    happy to have this fixed.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 11:31:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 09:31:25 +0000
    Subject: [Koha-bugs] [Bug 30482] New: Fix display of validation of important
     fields when biblio cataloguing
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30482
    
                Bug ID: 30482
               Summary: Fix display of validation of important fields when
                        biblio cataloguing
     Change sponsored?: Sponsored
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: trivial
              Priority: P5 - low
             Component: Cataloging
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: oleonard at myacpl.org
            QA Contact: testopia at bugs.koha-community.org
                    CC: m.de.rooy at rijksmuseum.nl,
                        testopia at bugs.koha-community.org
            Depends on: 30159
    
    +++ This bug was initially created as a clone of Bug #30159 +++
    
    Fields that are marked as important in a biblio framework will trigger a
    confirmation box to the cataloguer if not filled, asking if they would still
    like to save. 
    
    Since Bug 28694, the validation for mandatory fields is nice and pretty, but it
    appears the validation for important fields was not tested. The confirmation
    pop-up now spits out the HTML markup and is unreadable. This should be fixed.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159
    [Bug 30159] Fix display of validation of important fields when biblio
    cataloguing
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 11:31:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 09:31:25 +0000
    Subject: [Koha-bugs] [Bug 30159] Fix display of validation of important
     fields when biblio cataloguing
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159
    
    Owen Leonard  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30482
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30482
    [Bug 30482] Fix display of validation of important fields when biblio
    cataloguing
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 11:33:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 09:33:57 +0000
    Subject: [Koha-bugs] [Bug 30482] Potential for bad string concatenation in
     cataloging validation error message
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30482
    
    Owen Leonard  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                       |ity.org                     |
                Summary|Fix display of validation   |Potential for bad string
                       |of important fields when    |concatenation in cataloging
                       |biblio cataloguing          |validation error message
    
    --- Comment #1 from Owen Leonard  ---
    We run AreFieldsNotOk() twice and concatenate the result when showing errors on
    the screen. If the second run of AreFieldsNotOk() returns false, the string
    concatenation adds "0"
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 11:34:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 09:34:16 +0000
    Subject: [Koha-bugs] [Bug 30482] Potential for bad string concatenation in
     cataloging validation error message
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30482
    
    Owen Leonard  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
      Change sponsored?|Sponsored                   |---
      Text to go in the|This patch adds a check for |
          release notes|both mandatory and          |
                       |important fields when       |
                       |validating bibliographic    |
                       |records during cataloguing. |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 11:43:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 09:43:58 +0000
    Subject: [Koha-bugs] [Bug 30483] New: Should issues.borrowernumber and
     issues.itemnumber be NOT NULL ?
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483
    
                Bug ID: 30483
               Summary: Should issues.borrowernumber and issues.itemnumber be
                        NOT NULL ?
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Database
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: m.de.rooy at rijksmuseum.nl
            QA Contact: testopia at bugs.koha-community.org
    
    Sync problem between structure and dbrevs.
    For old prod databases only (that passed the 3.05 dbrevs)
    Note that I did not expect such a difference in a vital table like issues !
    
    update     $DBversion = "3.05.00.009"; $dbh->do("ALTER TABLE issues MODIFY
    COLUMN borrowernumber int(11) NOT NULL");     $dbh->do("ALTER TABLE issues
    MODIFY COLUMN itemnumber int(11) NOT NULL");
    
    Current structure allows them to be NULL.
    I wonder if that is correct. An issue should have a borrower and an item,
    right?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 11:48:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 09:48:21 +0000
    Subject: [Koha-bugs] [Bug 23330] deleteditemsstocknumberidx should not be a
     unique index
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23330
    
    Marcel de Rooy  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30481
                     CC|                            |m.de.rooy at rijksmuseum.nl
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 11:48:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 09:48:21 +0000
    Subject: [Koha-bugs] [Bug 30481] Drop unique constraint
     deleteditemsstocknumberidx for deleteditems
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30481
    
    Marcel de Rooy  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=23330
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 11:50:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 09:50:33 +0000
    Subject: [Koha-bugs] [Bug 23330] deleteditemsstocknumberidx should not be a
     unique index
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23330
    
    --- Comment #4 from Marcel de Rooy  ---
    (In reply to David Cook from comment #2)
    > We could probably close this one off as it only affects pre-3.04 versions of
    > Koha.
    > 
    > I think there are other cases where similar things have happened, so I'm
    > sure upgraded databases vs new databases are already out of sync in other
    > ways...
    
    Yes, I have opened a few of these reports the last few days. Added some code on
    at least one of them. These patches are not very popular.
    But I would recommend to leave them open until they are fixed.
    These kind of sync problems could at some point cause issues..
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 11:51:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 09:51:59 +0000
    Subject: [Koha-bugs] [Bug 30482] Potential for bad string concatenation in
     cataloging validation error message
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30482
    
    --- Comment #2 from Owen Leonard  ---
    Created attachment 133061
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133061&action=edit
    Screenshot of an extra "0" output with a validation error
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 11:53:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 09:53:16 +0000
    Subject: [Koha-bugs] [Bug 30482] Potential for bad string concatenation in
     cataloging validation error message
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30482
    
    Owen Leonard  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 11:53:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 09:53:19 +0000
    Subject: [Koha-bugs] [Bug 30482] Potential for bad string concatenation in
     cataloging validation error message
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30482
    
    --- Comment #3 from Owen Leonard  ---
    Created attachment 133062
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133062&action=edit
    Bug 30482: Potential for bad string concatenation in cataloging validation
    error message
    
    In validating the basic MARC editor form before submission, we run
    AreFieldsNotOk() twice (once with the parameter "false") and concatenate
    the result for output. This creates the potential for the error string
    to be appended with "0" if AreFieldsNotOk() returns false.
    
    This patch improves the logic around building the error string.
    
    To test, apply the patch and make sure one of your MARC frameworks
    contains at least one mandatory field and at least one important field.
    
    - Edit or create a MARC record in the basic MARC editor.
    - Submit the form in various states of completion:
      - If a mandatory and an important field are empty, you should see two
        error messages at the top. "The following mandatory subfields aren't
        filled" and "The following important subfields aren’t filled."
      - If a mandatory OR an important field is empty, you should see a
        single message.
        - If it's the important field which is empty, a confirmation will
          ask if you want to save the record anyway. Test that both answers
          to this confirmation work correctly.
      - If no mandatory or important fields are empty the form should
        submit.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 12:06:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 10:06:41 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    Fridolin Somers  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Patch doesn't apply
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
    
    --- Comment #55 from Fridolin Somers  ---
    Sorry does not apply anymore since Bug 30394
    Rebase looks easy but i prefer it is done the author ;)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 12:12:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 10:12:36 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    Tomás Cohen Arazi  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Patch doesn't apply         |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 12:12:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 10:12:40 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    Tomás Cohen Arazi  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132341|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 12:12:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 10:12:43 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    Tomás Cohen Arazi  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132342|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 12:12:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 10:12:46 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    Tomás Cohen Arazi  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132343|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 12:12:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 10:12:49 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    Tomás Cohen Arazi  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132344|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 12:12:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 10:12:52 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    Tomás Cohen Arazi  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132345|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 12:12:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 10:12:55 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    Tomás Cohen Arazi  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132346|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 12:12:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 10:12:58 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    Tomás Cohen Arazi  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132347|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 12:13:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 10:13:01 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    Tomás Cohen Arazi  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132348|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 12:13:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 10:13:42 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    --- Comment #56 from Tomás Cohen Arazi  ---
    Created attachment 133063
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133063&action=edit
    Bug 29810: Add summary of x-koha-embed header to api spec
    
    Signed-off-by: Martin Renvoize 
    Signed-off-by: Tomas Cohen Arazi 
    
    Signed-off-by: Jonathan Druart 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 12:13:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 10:13:47 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    --- Comment #57 from Tomás Cohen Arazi  ---
    Created attachment 133064
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133064&action=edit
    Bug 29810: Document x-koha-embed header on patrons endpoints
    
    Signed-off-by: Martin Renvoize 
    Signed-off-by: Tomas Cohen Arazi 
    
    Signed-off-by: Jonathan Druart 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 12:13:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 10:13:52 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    --- Comment #58 from Tomás Cohen Arazi  ---
    Created attachment 133065
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133065&action=edit
    Bug 29810: Document x-koha-embed header on checkouts endpoints
    
    Signed-off-by: Martin Renvoize 
    Signed-off-by: Tomas Cohen Arazi 
    
    Signed-off-by: Jonathan Druart 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 12:13:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 10:13:57 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    --- Comment #59 from Tomás Cohen Arazi  ---
    Created attachment 133066
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133066&action=edit
    Bug 29810: Document x-koha-embed header on biblios endpoints
    
    Signed-off-by: Martin Renvoize 
    Signed-off-by: Tomas Cohen Arazi 
    
    Signed-off-by: Jonathan Druart 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 12:14:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 10:14:02 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    --- Comment #60 from Tomás Cohen Arazi  ---
    Created attachment 133067
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133067&action=edit
    Bug 29810: Document x-koha-embed header on cash registers endpoints
    
    Signed-off-by: Martin Renvoize 
    Signed-off-by: Tomas Cohen Arazi 
    
    Signed-off-by: Jonathan Druart 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 12:14:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 10:14:07 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    --- Comment #61 from Tomás Cohen Arazi  ---
    Created attachment 133068
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133068&action=edit
    Bug 29810: Document x-koha-embed header on libraries endpoints
    
    Signed-off-by: Martin Renvoize 
    Signed-off-by: Tomas Cohen Arazi 
    
    Signed-off-by: Jonathan Druart 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 12:14:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 10:14:12 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    --- Comment #62 from Tomás Cohen Arazi  ---
    Created attachment 133069
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133069&action=edit
    Bug 29810: Document x-koha-embed header on orders endpoints
    
    Signed-off-by: Martin Renvoize 
    Signed-off-by: Tomas Cohen Arazi 
    
    Signed-off-by: Jonathan Druart 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 12:14:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 10:14:17 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    --- Comment #63 from Tomás Cohen Arazi  ---
    Created attachment 133070
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133070&action=edit
    Bug 29810: Add 'x-koha-embed' to reserved words
    
    The maintainers of Mojolicious::Plugin::OpenAPI and friends fixed the
    problem with using collectionFormat for Headers in the upstream library.
    
    However, this highlighted an outstanding issue in our code when I ran
    the unit tests. We have not been stripping x-koha-embed at the query
    level as it did not exist in the reserved_words list.  This patch
    resolves that and gets the acquisitions_orders test passing again.
    
    Signed-off-by: Martin Renvoize 
    Signed-off-by: Tomas Cohen Arazi 
    
    Signed-off-by: Jonathan Druart 
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 12:14:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 10:14:43 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    --- Comment #64 from Tomás Cohen Arazi  ---
    (In reply to Fridolin Somers from comment #55)
    > Sorry does not apply anymore since Bug 30394
    > Rebase looks easy but i prefer it is done the author ;)
    
    Done :-D
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 12:16:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 10:16:39 +0000
    Subject: [Koha-bugs] [Bug 9525] Add option to define float groups and rules
     for float
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525
    
    Emmi Takkinen  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #124825|0                           |1
            is obsolete|                            |
    
    --- Comment #46 from Emmi Takkinen  ---
    Created attachment 133071
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133071&action=edit
    Bug 9525: Add ft_local_float_group column
    
    This patch adds new ft_local_float_group column
    to library_groups table.
    
    To test:
    1. Apply patch and update database
    2. Confirm new column is added correctly to the
    library_groups table
    
    Sponsored-by: Koha-Suomi Oy
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 12:17:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 10:17:05 +0000
    Subject: [Koha-bugs] [Bug 9525] Add option to define float groups and rules
     for float
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525
    
    Emmi Takkinen  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #124826|0                           |1
            is obsolete|                            |
    
    --- Comment #47 from Emmi Takkinen  ---
    Created attachment 133072
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133072&action=edit
    Bug 9525: DO NOT PUSH! Schema update
    
    Sponsored-by: Koha-Suomi Oy
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 12:17:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 10:17:40 +0000
    Subject: [Koha-bugs] [Bug 9525] Add option to define float groups and rules
     for float
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525
    
    Emmi Takkinen  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #124827|0                           |1
            is obsolete|                            |
    
    --- Comment #48 from Emmi Takkinen  ---
    Created attachment 133073
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133073&action=edit
    Bug 9525: Add option to define float groups and rules for float
    
    Bug 22284 introduced ability to create hold groups.
    We should have ability to create float groups in
    same manner. This patch adds checkbox "Is local
    float group" to group creation feature and new return
    policy "Item floats by librarygroup".
    
    To test:
    1. Add new float group and some libraries to it.
    2. From circulation and fine rules, set default
    return policy as "Item floats by library group".
    3. Check out an item for a patron.
    4. Set library as one that belongs in the same
    float group.
    5. Check in the item.
    => Observe that notice for transfer doesn't pop up.
    6. Check out again.
    7. This time set library as one that doen's
    belong in the same float group.
    8. Check in.
    => Observe that notice for transfer pops up.
    
    Experiment this feature by changing return policy
    per library, item type etc.
    
    Also prove t/db_dependent/Koha/Libraries.t
    
    Sponsored-by: Koha-Suomi Oy
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 12:18:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 10:18:20 +0000
    Subject: [Koha-bugs] [Bug 9525] Add option to define float groups and rules
     for float
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525
    
    --- Comment #49 from Emmi Takkinen  ---
    Rebased patches and made database update idempotent.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 12:19:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 10:19:51 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #32 from Bernardo Gonzalez Kriegel  ---
    (In reply to Jonathan Druart from comment #31)
    > 
    > Bernardo, Do those 2 patches look correct to you?
    
    Yes! I'm doing a complete check of hidden values (old/new)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 12:54:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 10:54:07 +0000
    Subject: [Koha-bugs] [Bug 30465] BatchUpdateBiblio task does not deal with
     indexation correctly
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30465
    
    --- Comment #6 from David Cook  ---
    (In reply to Jonathan Druart from comment #3)
    > (In reply to David Cook from comment #2)
    > > I'm not sure I'll be much help, as it looks like this is an Elasticsearch
    > > specific dev? From the Zebra side I think we'd actually get worse
    > > performance with this change.
    > 
    > Why, can you detail please?
    
    If I understand correctly, this change would mean that the zebraqueue would
    only be added to after all the updates are processed, right? At the moment, the
    zebraqueue is added to with each change, which means the koha-indexer can start
    processing them ASAP. In theory, this change could make it slower to get
    records indexed into Zebra.
    
    However, if we're passing record IDs through RabbitMQ to a worker to index
    records in Elasticsearch, I think it could make sense to defer the indexing, so
    that the background worker can fetch X biblios from the database with 1 DB call
    before sending them to Elasticsearch. 
    
    Anyway, I don't think it really matters, so feel free to ignore me hehe.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 12:57:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 10:57:52 +0000
    Subject: [Koha-bugs] [Bug 30289] Use Template::Toolkit WRAPPER to reduce
     template boilerplate
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30289
    
    David Cook  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131649|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 12:58:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 10:58:04 +0000
    Subject: [Koha-bugs] [Bug 30289] Use Template::Toolkit WRAPPER to reduce
     template boilerplate
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30289
    
    David Cook  changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
              Component|OPAC                        |Templates
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 13:27:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 11:27:17 +0000
    Subject: [Koha-bugs] [Bug 30289] Use Template::Toolkit WRAPPER to reduce
     template boilerplate
    In-Reply-To: 
    References: 
    Message-ID: 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30289
    
    --- Comment #5 from David Cook  ---
    Created attachment 133074
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133074&action=edit
    Bug 30289: Demonstrate using a WRAPPER with opac-library.pl
    
    This patch replaces template boiler plate by using the
    Template::Toolkit directive WRAPPER.
    
    Test plan:
    1. Go to http://localhost:8080/cgi-bin/koha/opac-library.pl
    2. Outputs a list of libraries
    3. Go to http://localhost:8080/cgi-bin/koha/opac-library.pl?branchcode=CPL
    4. Outputs details for Centerville library only
    
    FIXME: I still need to improve the handling of the  element
    and the breadcrumbs, but those shouldn't be too challenging.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 13:31:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 11:31:49 +0000
    Subject: [Koha-bugs] [Bug 30484] New: Interlibrary Loans should have the
     ability to send notices based on request supplier updates
    Message-ID: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484
    
                Bug ID: 30484
               Summary: Interlibrary Loans should have the ability to send
                        notices based on request supplier updates
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: ILL
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: andrew.isherwood at ptfs-europe.com
    
    It should be possible for the Interlibrary Loans module to inform a user when a
    request supplier makes a pertinent change to an outstanding request.
    
    Scenario defined by customer to be fulfilled by this bug:
    - A user places an ILL request for a journal article via the RapidILL backend.
    - RapidILL fulfil the request with an electronic resource.
    - The user is notified of the request fulfilment via their chosen communication
    method, the notice contains the link and password required to access the
    requested resource.
    
    The intended solution will add a mechanism to allow Koha ILL to periodically
    check outstanding requests with suppliers for updates and act accordingly.
    
    As an aside, there is a known customer requirement for notices to be sent when
    requests are modified locally, this requirement will be catered for in the
    design of the solution.
    
    Details of the intended implementation:
    - An ILL backend, or core Koha ILL, can define one or more "update processors",
    these are functions that can perform an action when supplied with an update
    meeting the criteria they're interested in
    - An ILL request will be given the ability to obtain its latest status with the
    supplier, known as an "update"
    - "Updates" can then be passed to "update processors" that are interested in
    them, which can then perform whatever actions they wish.
    
    Generic 
    - Core Koha ILL will provide:
      - An object to encapsulate supplier updates
      - A base class from which "update processors" can be subclassed
      - Functions to gather updates from backends and orchestrate the processing
      - A notice template which will be used to send update notices
      - A shell script that can be run to initiate the process
    
    For the customer use case defined above:
    - The RapidILL backend will:
      - Provide the ability to retrieve the latest update from the RapidILL API
      - Define a SendArticleLink processor
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 13:32:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 11:32:32 +0000
    Subject: [Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability
     to send notices based on request supplier updates
    In-Reply-To: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30484-70-YK0svII06T@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484
    
    Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |ASSIGNED
               Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ
                       |ity.org                     |e.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 13:35:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 11:35:51 +0000
    Subject: [Koha-bugs] [Bug 30289] Use Template::Toolkit WRAPPER to reduce
     template boilerplate
    In-Reply-To: <bug-30289-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30289-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30289-70-ReMCJBKUg1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30289
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|oleonard at myacpl.org         |dcook at prosentient.com.au
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 13:39:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 11:39:14 +0000
    Subject: [Koha-bugs] [Bug 26381] Koha should provide Koha plugins with a
     template to use with Template::Toolkit WRAPPER
    In-Reply-To: <bug-26381-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26381-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26381-70-vl7qSwk9TN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26381
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |DUPLICATE
                 Status|In Discussion               |RESOLVED
    
    --- Comment #5 from David Cook <dcook at prosentient.com.au> ---
    This is really a duplicate of bug 30289.
    
    *** This bug has been marked as a duplicate of bug 30289 ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 13:39:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 11:39:14 +0000
    Subject: [Koha-bugs] [Bug 30289] Use Template::Toolkit WRAPPER to reduce
     template boilerplate
    In-Reply-To: <bug-30289-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30289-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30289-70-LekXh85juP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30289
    
    --- Comment #6 from David Cook <dcook at prosentient.com.au> ---
    *** Bug 26381 has been marked as a duplicate of this bug. ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 13:42:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 11:42:49 +0000
    Subject: [Koha-bugs] [Bug 30289] Use Template::Toolkit WRAPPER to reduce
     template boilerplate
    In-Reply-To: <bug-30289-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30289-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30289-70-P1u9t7ypRd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30289
    
    --- Comment #7 from David Cook <dcook at prosentient.com.au> ---
    (In reply to David Cook from comment #6)
    > *** Bug 26381 has been marked as a duplicate of this bug. ***
    
    I just remembered that it would be useful for Koha plugins too if they could
    refer to a WRAPPER so that they just worried about the core content to fill in
    the page.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 14:02:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 12:02:49 +0000
    Subject: [Koha-bugs] [Bug 30481] Drop unique constraint
     deleteditemsstocknumberidx for deleteditems
    In-Reply-To: <bug-30481-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30481-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30481-70-T17g9tsJZR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30481
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
       Patch complexity|---                         |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 14:02:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 12:02:53 +0000
    Subject: [Koha-bugs] [Bug 30481] Drop unique constraint
     deleteditemsstocknumberidx for deleteditems
    In-Reply-To: <bug-30481-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30481-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30481-70-EuVl4Ygq80@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30481
    
    --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133075
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133075&action=edit
    Bug 30481: Drop unique constraint deleteditemsstocknumberidx
    
    Resolves a sync issue between database and schema caused by
    differences between structure and upgrades. Note: newer
    databases do not contain this index any longer.
    
    Test plan:
    Run dbrev.
    Check SHOW CREATE TABLE deleteditems.
    Verify that unique index has been dropped, regular index added.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 14:03:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 12:03:12 +0000
    Subject: [Koha-bugs] [Bug 30481] Drop unique constraint
     deleteditemsstocknumberidx for deleteditems
    In-Reply-To: <bug-30481-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30481-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30481-70-5cE01rirre@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30481
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
               Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                       |ity.org                     |
    
    --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Trivial: Self SO
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 14:18:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 12:18:10 +0000
    Subject: [Koha-bugs] [Bug 27859] MARC export for search results
    In-Reply-To: <bug-27859-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27859-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27859-70-CAhxQ5VFDd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859
    
    David Gustafsson <glasklas at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132997|0                           |1
            is obsolete|                            |
    
    --- Comment #14 from David Gustafsson <glasklas at gmail.com> ---
    Created attachment 133076
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133076&action=edit
    Bug 27859: marc search result export
    
    Enable export of staff interface search results in different marc formats.
    The export will be mailed to the configured mail address of the current user.
    This feature is Elasticsearch only.
    
    To test:
    1) Apply patch
    2) Run installer/data/mysql/updatedatabase.pl
    3) Make sure the syspref EnableSearchResultMARCExport is enabled
    4) Make sure the syspref EnableSearchResultMARCExportEmail is enabled
    5) Add a custom filter in the SearchResultMARCExportCustomFormats syspref,
       for example by copying one of the example formats
    6) Make sure the current user has the tools -> export_catalog permission
    7) Make sure the current user has an email under your control set
    8) Perform a search
    9) Export the search result for each format in the
       "Export all results" drop down
    10) Verify that link(s) with exported data has been mailed to the
       provided email
    11) Revoke the permission in 3) and make sure exporting is no longer
       possible
    12) Run tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t
    
    Sponsored-by: Gothenburg University Library
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 14:24:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 12:24:31 +0000
    Subject: [Koha-bugs] [Bug 30485] New: Searching all patrons from the header
     does not display the patron search view
    Message-ID: <bug-30485-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30485
    
                Bug ID: 30485
               Summary: Searching all patrons from the header does not display
                        the patron search view
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: normal
              Priority: P5 - low
             Component: Patrons
              Assignee: jonathan.druart+koha at gmail.com
              Reporter: jonathan.druart+koha at gmail.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
            Depends on: 30063
    
    Regression from bug 30063. If you are searching all patrons (not search term
    passed) from the header, the patron search result is not displayed.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
    [Bug 30063] Make the main patron search use the /patrons REST API route
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 14:24:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 12:24:31 +0000
    Subject: [Koha-bugs] [Bug 30063] Make the main patron search use the
     /patrons REST API route
    In-Reply-To: <bug-30063-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30063-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30063-70-tV8T6sGHn6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30485
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30485
    [Bug 30485] Searching all patrons from the header does not display the patron
    search view
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 14:24:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 12:24:46 +0000
    Subject: [Koha-bugs] [Bug 30485] Searching all patrons from the header does
     not display the patron search view
    In-Reply-To: <bug-30485-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30485-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30485-70-LuU5biz5TO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30485
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |rel_22_05_candidate
                     CC|                            |m.de.rooy at rijksmuseum.nl
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 14:26:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 12:26:48 +0000
    Subject: [Koha-bugs] [Bug 30485] Searching all patrons from the header does
     not display the patron search view
    In-Reply-To: <bug-30485-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30485-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30485-70-KTBY6X3IxE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30485
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 14:26:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 12:26:52 +0000
    Subject: [Koha-bugs] [Bug 30485] Searching all patrons from the header does
     not display the patron search view
    In-Reply-To: <bug-30485-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30485-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30485-70-xB0X6T7NWC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30485
    
    --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133077
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133077&action=edit
    Bug 30485: (bug 30063 follow-up) Display all patrons if not term passed
    
    Regression from bug 30063. If you are searching all patrons (not search term
    passed) from the header, the patron search result is not displayed.
    
    Test plan:
    Go to the Koha homepage, search patrons, don't enter a search term and
    click "submit"
    All patrons must be returned.
    Regression test: on the other patron search forms, confirm that there is
    no regression, ie. no patron displayed until you search for something
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 14:27:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 12:27:33 +0000
    Subject: [Koha-bugs] [Bug 30485] Searching all patrons from the header does
     not display the patron search view
    In-Reply-To: <bug-30485-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30485-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30485-70-vJNEwnDybH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30485
    
    --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Let me have a look :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 14:31:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 12:31:04 +0000
    Subject: [Koha-bugs] [Bug 30485] Searching all patrons from the header does
     not display the patron search view
    In-Reply-To: <bug-30485-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30485-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30485-70-AdnoUQFbzn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30485
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Trivial patch
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 14:31:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 12:31:09 +0000
    Subject: [Koha-bugs] [Bug 30485] Searching all patrons from the header does
     not display the patron search view
    In-Reply-To: <bug-30485-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30485-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30485-70-ZE6l2ujl8W@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30485
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133077|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133078
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133078&action=edit
    Bug 30485: (bug 30063 follow-up) Display all patrons if not term passed
    
    Regression from bug 30063. If you are searching all patrons (not search term
    passed) from the header, the patron search result is not displayed.
    
    Test plan:
    Go to the Koha homepage, search patrons, don't enter a search term and
    click "submit"
    All patrons must be returned.
    Regression test: on the other patron search forms, confirm that there is
    no regression, ie. no patron displayed until you search for something
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 14:31:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 12:31:51 +0000
    Subject: [Koha-bugs] [Bug 30485] Searching all patrons from the header does
     not display the patron search view
    In-Reply-To: <bug-30485-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30485-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30485-70-dVgCHjFwH3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30485
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
             QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                       |y.org                       |
    
    --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Taking the liberty to combine with QA: trivial change.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 14:32:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 12:32:33 +0000
    Subject: [Koha-bugs] [Bug 30483] Should issues.borrowernumber and
     issues.itemnumber be NOT NULL ?
    In-Reply-To: <bug-30483-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30483-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30483-70-c75yFGH8Hm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                       |ity.org                     |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 14:32:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 12:32:39 +0000
    Subject: [Koha-bugs] [Bug 30483] Should issues.borrowernumber and
     issues.itemnumber be NOT NULL ?
    In-Reply-To: <bug-30483-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30483-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30483-70-rFZtKbb3py@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |ASSIGNED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 14:40:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 12:40:52 +0000
    Subject: [Koha-bugs] [Bug 30486] New: [OMNIBUS] Synchronize database schema
     with (older) database revisions
    Message-ID: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
    
                Bug ID: 30486
               Summary: [OMNIBUS] Synchronize database schema with (older)
                        database revisions
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Database
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: m.de.rooy at rijksmuseum.nl
            QA Contact: testopia at bugs.koha-community.org
    
    When you are working with a Koha database, installed many years ago and
    upgraded since then, you may have quite a bit of small deviations from a
    freshly installed database.
    This may be due to small inconsistencies between the changes to kohastructure
    and the atomic update files, among other reasons (failing dbrevs, local
    changes, etc)
    
    Some changes only involve for instance the order of the database columns but
    others may be a bit more serious: NULL or NOT NULL, type of constraint
    (RESTRICT or CASCADE), etc.
    You can have an idea of the state of your database by running the dbix script
    in the misc folder [in a safe way :) ] and looking at git diff.
    
    This report only collects links to individual reports where such changes are
    reported / resolved.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 14:42:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 12:42:42 +0000
    Subject: [Koha-bugs] [Bug 30486] [OMNIBUS] Synchronize database schema with
     (older) database revisions
    In-Reply-To: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30486-70-Yc9triYWuO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30414, 30449, 30472, 30481,
                       |                            |30483
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30414
    [Bug 30414] Inconsistent (duplicated) FK constraint name:
    aqbudgets.aqbudgetperiods_ibfk_1
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449
    [Bug 30449] Missing FK constraint on borrower_attribute_types
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30472
    [Bug 30472] Field borrower_relationships.guarantor_id should be marked as NOT
    NULL
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30481
    [Bug 30481] Drop unique constraint deleteditemsstocknumberidx for deleteditems
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483
    [Bug 30483] Should issues.borrowernumber and issues.itemnumber be NOT NULL ?
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 14:42:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 12:42:42 +0000
    Subject: [Koha-bugs] [Bug 30414] Inconsistent (duplicated) FK constraint
     name: aqbudgets.aqbudgetperiods_ibfk_1
    In-Reply-To: <bug-30414-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30414-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30414-70-401PqYwPSl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30414
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30486
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
    [Bug 30486] [OMNIBUS] Synchronize database schema with (older) database
    revisions
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 14:42:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 12:42:42 +0000
    Subject: [Koha-bugs] [Bug 30449] Missing FK constraint on
     borrower_attribute_types
    In-Reply-To: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30449-70-xihU7qveF1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30486
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
    [Bug 30486] [OMNIBUS] Synchronize database schema with (older) database
    revisions
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 14:42:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 12:42:42 +0000
    Subject: [Koha-bugs] [Bug 30472] Field borrower_relationships.guarantor_id
     should be marked as NOT NULL
    In-Reply-To: <bug-30472-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30472-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30472-70-AEPA5Ug52V@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30472
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30486
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
    [Bug 30486] [OMNIBUS] Synchronize database schema with (older) database
    revisions
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 14:42:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 12:42:42 +0000
    Subject: [Koha-bugs] [Bug 30481] Drop unique constraint
     deleteditemsstocknumberidx for deleteditems
    In-Reply-To: <bug-30481-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30481-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30481-70-V7R35uvw4h@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30481
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30486
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
    [Bug 30486] [OMNIBUS] Synchronize database schema with (older) database
    revisions
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 14:42:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 12:42:42 +0000
    Subject: [Koha-bugs] [Bug 30483] Should issues.borrowernumber and
     issues.itemnumber be NOT NULL ?
    In-Reply-To: <bug-30483-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30483-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30483-70-bvQTwZbJls@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30486
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
    [Bug 30486] [OMNIBUS] Synchronize database schema with (older) database
    revisions
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 14:44:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 12:44:31 +0000
    Subject: [Koha-bugs] [Bug 30486] [OMNIBUS] Synchronize database schema with
     (older) database revisions
    In-Reply-To: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30486-70-YJ6HdfQXUZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |ASSIGNED
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 14:45:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 12:45:55 +0000
    Subject: [Koha-bugs] [Bug 30486] [OMNIBUS] Synchronize database schema with
     (older) database revisions
    In-Reply-To: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30486-70-1YHeZ6n8cd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
    
    --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Note that I counted changes in about 45 tables (read: DBIx schema files)
    recently before starting to resolve them.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 15:01:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 13:01:59 +0000
    Subject: [Koha-bugs] [Bug 30416] Patron search results page UX fixes
    In-Reply-To: <bug-30416-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30416-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30416-70-0HEOpaFAXl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30416
    
    --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    I have really no idea how to fix that. I found something related in Sticky
    code:
    
        const initSticky = () => { 
          // check if element or it's parents are visible
          if (elem.offsetParent === null || Helpers.getStyle(elem, 'display') ===
    'none') {
            disableSticky();
            return;
          }    
    
    
    I've tried to remove the disableSticky call but things get uglier...
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 15:03:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 13:03:37 +0000
    Subject: [Koha-bugs] [Bug 30225] Rewrite cities admin view in Vue
    In-Reply-To: <bug-30225-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30225-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30225-70-mhI4iDgAby@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30225
    
    --- Comment #13 from David Cook <dcook at prosentient.com.au> ---
    My test plan:
    1. yarn install
    2. yarn build_js
    3. http://localhost:8081/cgi-bin/koha/admin/cities.pl
    
    UI Feedback:
    1. Overall, the UI is looking pretty good!
    2. On http://localhost:8081/cgi-bin/koha/admin/cities.pl, the "Loading..." word
    should probably be in the centre, so that it's a smoother transition to "There
    are no cities defined"
    3. Adding a new city, the HTML could be styled more nicely (shorter input
    boxes, input boxes next to labels - so they're not as disjointed, maybe leaving
    off "City" from all the placeholders), but it works. 
    4. The datatable on http://localhost:8081/cgi-bin/koha/admin/cities.pl looks
    pretty good and the filters work
    5. However, the "City created" message hangs around too long. It still shows
    while I'm interacting with the data table, and that feels awkward.
    6. When I click on "Edit", the template momentarily says "New city" before
    switching to "Edit city", which is jarring. I don't know what's happening in
    the code, but an easy workaround would be to hide the form with CSS until after
    it's fully rendered.
    7. Delete city works, although it could also be styled more nicely.
    
    In summary, I think the functionality is all there, but it just needs some
    aesthetic polishing I think.
    
    Code Feedback:
    1. I'm not familiar with Vue 3, so I think I'll need to study it more. 
    2. I think we could probably remove more of cities.tt if I understand correctly
    since I don't think it's used anymore. 
    3. This would be a good candidate for Bug 30289 I think. Could use the WRAPPER
    to create the bulk of the page, and then have the Vue app in the main
    section...
    4. I like the idea of changing from
    http://localhost:8081/cgi-bin/koha/admin/cities.pl to something like
    http://localhost:8081/cgi-bin/koha/admin#cities and then using a router 
    5. While I don't know Vue 3, I keep thinking we should be able to create more
    generic CRUD templates. I think one of the great downsides of Koha at the
    moment is having too many different CRUD forms. This looks interesting:
    https://vuejsdevelopers.com/2017/06/11/vue-js-extending-components/
    
    In summary, I think this is on the right track, but I think it needs more
    polishing as well. 
    
    I could have a crack at making some more generic components... although I'm not
    sure when...
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 15:06:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 13:06:21 +0000
    Subject: [Koha-bugs] [Bug 30483] Should issues.borrowernumber and
     issues.itemnumber be NOT NULL ?
    In-Reply-To: <bug-30483-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30483-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30483-70-PvZ6HZoN7y@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 15:06:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 13:06:25 +0000
    Subject: [Koha-bugs] [Bug 30483] Should issues.borrowernumber and
     issues.itemnumber be NOT NULL ?
    In-Reply-To: <bug-30483-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30483-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30483-70-d9Y3dZfIGM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483
    
    --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133079
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133079&action=edit
    Bug 30483: Make issues.borrowernumber and itemnumber NOT NULL
    
    Note: This change does NOT apply to old_issues, where constraints
    may result in nullifying these columns.
    
    Test plan:
    Run dbrev.
    Try checkout, checkin.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 15:06:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 13:06:28 +0000
    Subject: [Koha-bugs] [Bug 30483] Should issues.borrowernumber and
     issues.itemnumber be NOT NULL ?
    In-Reply-To: <bug-30483-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30483-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30483-70-0dX5xht8Ph@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483
    
    --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133080
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133080&action=edit
    Bug 30483: DBIx changes for issues table
    
    Note: You may observe that DBIx drops the LEFT join_type here.
    There is no reason to be worried about that. If a FK column
    allows NULL values, DBIx sets it to LEFT. We remove the NULL
    here and DBIx now defaults to INNER again.
    
    No test plan.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 15:20:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 13:20:21 +0000
    Subject: [Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to
     the circulation rules
    In-Reply-To: <bug-25711-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25711-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25711-70-n23bDR5EZJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Patch doesn't apply
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 15:20:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 13:20:55 +0000
    Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
    In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29897-70-b8WXhEaBem@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897
    
    --- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133081
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133081&action=edit
    Bug 29897: Fix linkage
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 15:22:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 13:22:10 +0000
    Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
    In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29897-70-qW8XouWDZ2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897
    
    --- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Thanks Hugo! This last patch should fix the problems you found.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 15:22:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 13:22:27 +0000
    Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
    In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29897-70-6owE2Sbod7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897
    
    --- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    I've applied it on the sandbox.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 15:23:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 13:23:45 +0000
    Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
     more granular level
    In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-8367-70-1EfurgwnuN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Patch doesn't apply
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 15:25:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 13:25:52 +0000
    Subject: [Koha-bugs] [Bug 30487] New: Convert checkout and patron details
     page tabs to Bootstrap
    Message-ID: <bug-30487-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30487
    
                Bug ID: 30487
               Summary: Convert checkout and patron details page tabs to
                        Bootstrap
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: enhancement
              Priority: P5 - low
             Component: Templates
              Assignee: oleonard at myacpl.org
              Reporter: oleonard at myacpl.org
            QA Contact: testopia at bugs.koha-community.org
                    CC: testopia at bugs.koha-community.org
                Blocks: 29226
    
    Continuing the process of phasing out jQueryUI, this patch will replace
    jQueryUI tabs in two places:
    
    - circ/circulation.tt
    - members/moremember.tt
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
    [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 15:25:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 13:25:52 +0000
    Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
    In-Reply-To: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29226-70-Y5TjERaDQT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30487
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30487
    [Bug 30487] Convert checkout and patron details page tabs to Bootstrap
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 15:30:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 13:30:39 +0000
    Subject: [Koha-bugs] [Bug 30386] Prevent search errors if deleted record
     still remains in search indexes
    In-Reply-To: <bug-30386-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30386-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30386-70-WiJWL1rfw9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30386
    
    Liz Rea <wizzyrea at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |wizzyrea at gmail.com
    
    --- Comment #3 from Liz Rea <wizzyrea at gmail.com> ---
    This is for elastic search, I believe, not zebra.
    
    Cheers,
    Liz
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 15:38:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 13:38:57 +0000
    Subject: [Koha-bugs] [Bug 20511] Seasonal prediction just in the staff
     language
    In-Reply-To: <bug-20511-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20511-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20511-70-iGpXl05gqa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511
    
    --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    (In reply to Hugo Agud from comment #6)
    > I a trying to test into sandbox, but i have no way of updating po.
    > 
    > I have seen that If I the pattern include to season like spring-summer, it
    > only translates one of two.
    > 
    > sample
    > Número	Fecha de publicación
    > Vol. Primavera, Number Summer, Issue 0	04/01/2022
    > Vol. Verano, Number Fall, Issue 1	07/01/2022
    > Vol. Otoño, Number Winter, Issue 2	10/01/2022
    > Vol. Winter, Number Primavera, Issue 3	01/01/2023
    
    How did you generate that? On which page?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 15:44:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 13:44:50 +0000
    Subject: [Koha-bugs] [Bug 30488] New: Recalls for Koha
    Message-ID: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488
    
                Bug ID: 30488
               Summary: Recalls for Koha
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: major
              Priority: P1 - high
             Component: OPAC
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: oleonard at myacpl.org
            QA Contact: testopia at bugs.koha-community.org
                    CC: adussert at pacifica.edu, aleisha at catalyst.net.nz,
                        alexbuckley at catalyst.net.nz,
                        andrew at bywatersolutions.com,
                        arthur.suzuki at biblibre.com,
                        baselibrary.consortium at nhs.net, bob at calyx.net.au,
                        bolshawh at parliament.uk,
                        boutrosboutrosboutros at gmail.com,
                        brendan at bywatersolutions.com,
                        chris at bigballofwax.co.nz, clopez at dml.vic.edu.au,
                        david at davidnind.com, dcook at prosentient.com.au,
                        dpavlin at rot13.org, fridolin.somers at biblibre.com,
                        gmcharlt at gmail.com, hannah.co at northwestu.edu,
                        hc at interleaf.ie, hughr at brimbank.vic.gov.au,
                        jonathan.druart+koha at gmail.com,
                        katrin.fischer at bsz-bw.de, kelly at bywatersolutions.com,
                        kyle at bywatersolutions.com, liz at catalyst.net.nz,
                        m.de.rooy at rijksmuseum.nl,
                        marjorie.barry-vila at collecto.ca,
                        martin.renvoize at ptfs-europe.com,
                        niamh.walker-headon at it-tallaght.ie,
                        nick at bywatersolutions.com,
                        pasi.kallinen at koha-suomi.fi,
                        paul.thornton at educampus.ie,
                        testopia at bugs.koha-community.org,
                        tomascohen at gmail.com, victor at tuxayo.net
            Depends on: 19532
    
    I'm getting an error when placing a recall from the OPAC. It appears at the
    last stage, after clicking the submit button to place the recall.
    
    Validation failed for type named Month declared in package DateTime::Types
    (/usr/lib/x86_64-linux-gnu/perl5/5.28/DateTime/Types.pm) at line 119 in sub
    named (eval) with value 29
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
    [Bug 19532] Recalls for Koha
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 15:44:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 13:44:50 +0000
    Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
    In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-19532-70-kVuXsSZ2Kh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30488
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488
    [Bug 30488] Recalls for Koha
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 15:45:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 13:45:43 +0000
    Subject: [Koha-bugs] [Bug 30488] Error when placing a recall in the OPAC
    In-Reply-To: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30488-70-wmbxRCRPeT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Recalls for Koha            |Error when placing a recall
                       |                            |in the OPAC
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 15:46:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 13:46:22 +0000
    Subject: [Koha-bugs] [Bug 30488] Error when placing a recall in the OPAC
    In-Reply-To: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30488-70-RgggDqQDsn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|adussert at pacifica.edu,      |
                       |andrew at bywatersolutions.com |
                       |,                           |
                       |arthur.suzuki at biblibre.com, |
                       |baselibrary.consortium at nhs. |
                       |net, bob at calyx.net.au,      |
                       |bolshawh at parliament.uk,     |
                       |boutrosboutrosboutros at gmail |
                       |.com,                       |
                       |brendan at bywatersolutions.co |
                       |m,                          |
                       |chris at bigballofwax.co.nz,   |
                       |clopez at dml.vic.edu.au,      |
                       |david at davidnind.com,        |
                       |dcook at prosentient.com.au,   |
                       |dpavlin at rot13.org,          |
                       |gmcharlt at gmail.com,         |
                       |hannah.co at northwestu.edu,   |
                       |hc at interleaf.ie,            |
                       |hughr at brimbank.vic.gov.au,  |
                       |kelly at bywatersolutions.com, |
                       |kyle at bywatersolutions.com,  |
                       |liz at catalyst.net.nz,        |
                       |m.de.rooy at rijksmuseum.nl,   |
                       |marjorie.barry-vila at collect |
                       |o.ca,                       |
                       |martin.renvoize at ptfs-europe |
                       |.com,                       |
                       |niamh.walker-headon at it-tall |
                       |aght.ie,                    |
                       |nick at bywatersolutions.com,  |
                       |pasi.kallinen at koha-suomi.fi |
                       |,                           |
                       |paul.thornton at educampus.ie, |
                       |testopia at bugs.koha-communit |
                       |y.org,                      |
                       |tomascohen at gmail.com,       |
                       |victor at tuxayo.net           |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 15:49:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 13:49:58 +0000
    Subject: [Koha-bugs] [Bug 30482] Potential for bad string concatenation in
     cataloging validation error message
    In-Reply-To: <bug-30482-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30482-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30482-70-vQ9NYeLDNW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30482
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 15:50:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 13:50:08 +0000
    Subject: [Koha-bugs] [Bug 30482] Potential for bad string concatenation in
     cataloging validation error message
    In-Reply-To: <bug-30482-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30482-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30482-70-jAMUI7Qa3g@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30482
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |rel_21_11_candidate
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 15:55:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 13:55:20 +0000
    Subject: [Koha-bugs] [Bug 30085] Improve performance of CanItemBeReserved
    In-Reply-To: <bug-30085-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30085-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30085-70-bpWact5W0g@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30085
    
    --- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
    (In reply to Nick Clemens from comment #15)
    > Consider for backport?
    
    Sure! Can you rebase against 21.11.x?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 15:57:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 13:57:58 +0000
    Subject: [Koha-bugs] [Bug 26947] kohastructure.sql should be updated for
     each release
    In-Reply-To: <bug-26947-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26947-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26947-70-sOOo3OCesA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947
    
    --- Comment #58 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Reading this back while looking at changes between structure and actual tables,
    I am not so sure whether this patch (Move -- to COMMENT) was such a good idea.
    Note that this is an understatement.
    
    When you add a COMMENT to structure, you should add a db revision too with that
    clause for that field. Note that DBIx schema files also include those comments.
    
    Since this patch set only touched structure and did not add dbrev's, we will
    have as a result a very large set of differences between DBIx schema and the
    tables.
    I have been working on resolving differences for a 20.11 database, but I am now
    already looking forward to the massive output of the dbix script when I upgrade
    to 21.05 or higher ;)
    
    Note that running dbix script to get those differences would be very useful but
    will be hugely obscured by the move in this patch set.
    
    What can be done about it? Remove the COMMENT clauses again (revert) ? Adjust
    dbix script to remove comments (feels like a hack) ?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 16:00:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 14:00:53 +0000
    Subject: [Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point
     of Sale can make the Collect Payment field off
    In-Reply-To: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27801-70-TyLAnw0GFq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801
    
    Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |caroline.cyr-la-rose at inlibr
                       |                            |o.com
    
    --- Comment #16 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
    This causes a major problem with the FR currencyformat, see Bug 30139
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 16:00:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 14:00:59 +0000
    Subject: [Koha-bugs] [Bug 30486] [OMNIBUS] Synchronize database schema with
     (older) database revisions
    In-Reply-To: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30486-70-ApamSqndk6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=26947
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 16:00:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 14:00:59 +0000
    Subject: [Koha-bugs] [Bug 26947] kohastructure.sql should be updated for
     each release
    In-Reply-To: <bug-26947-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26947-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26947-70-OkBu4jw5Pw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30486
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 16:20:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 14:20:59 +0000
    Subject: [Koha-bugs] [Bug 30489] New: Convert MARC and authority subfield
     edit tabs to Bootstrap
    Message-ID: <bug-30489-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30489
    
                Bug ID: 30489
               Summary: Convert MARC and authority subfield edit tabs to
                        Bootstrap
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: enhancement
              Priority: P5 - low
             Component: Templates
              Assignee: oleonard at myacpl.org
              Reporter: oleonard at myacpl.org
            QA Contact: testopia at bugs.koha-community.org
                    CC: testopia at bugs.koha-community.org
                Blocks: 29226
    
    Continuing the process of phasing out jQueryUI, this patch will replace
    jQueryUI tabs in two places:
    
    - admin/auth_subfields_structure.tt
    - admin/marc_subfields_structure
    
    The difficulty with the templates is that in many cases Koha wants to use "@"
    as the tab text. jQueryUI didn't have any problem with this, but Bootstrap
    doesn't like it.
    
    One idea I had was to handle that specific case and create a variable
    specifically for the tab's anchor text:
    
            if( $row_data{tagsubfield} eq "@" ){
                $row_data{subfieldanchor} = "AT";
            } else {
                $row_data{subfieldanchor} = $row_data{tagsubfield};
            }
    
    Seems unfortunate to have to check for that one case, so maybe someone else has
    a better idea.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
    [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 16:20:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 14:20:59 +0000
    Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
    In-Reply-To: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29226-70-TifEU3EpH0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30489
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30489
    [Bug 30489] Convert MARC and authority subfield edit tabs to Bootstrap
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 16:32:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 14:32:54 +0000
    Subject: [Koha-bugs] [Bug 30490] New: Should deleting a parent itemtype be
     CASCADING?
    Message-ID: <bug-30490-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30490
    
                Bug ID: 30490
               Summary: Should deleting a parent itemtype be CASCADING?
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Database
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: m.de.rooy at rijksmuseum.nl
            QA Contact: testopia at bugs.koha-community.org
    
    This is a sync issue between schema and upgrades.
    
    MASTER structure:   CONSTRAINT `itemtypes_ibfk_1` FOREIGN KEY (`parent_type`)
    REFERENCES `itemtypes` (`itemtype`) ON DELETE CASCADE ON UPDATE CASCADE
    
    $DBversion = '20.06.00.022'; ALTER TABLE itemtypes ADD CONSTRAINT
    itemtypes_ibfk_1 FOREIGN KEY (parent_type) REFERENCES itemtypes (itemtype)
    
    NOTE: When you do not add CASCADE, you fallback to RESTRICT !
    
    Main question is now: Which is right? Should the delete be cascading or not? I
    would opt for RESTRICT here. A pragmatical choice too; deleting item types will
    normally not be done so much :)
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 16:33:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 14:33:12 +0000
    Subject: [Koha-bugs] [Bug 30486] [OMNIBUS] Synchronize database schema with
     (older) database revisions
    In-Reply-To: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30486-70-k8zkXI6AGY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30490
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30490
    [Bug 30490] Should deleting a parent itemtype be CASCADING?
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 16:33:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 14:33:12 +0000
    Subject: [Koha-bugs] [Bug 30490] Should deleting a parent itemtype be
     CASCADING?
    In-Reply-To: <bug-30490-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30490-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30490-70-WqJO8I4Bzi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30490
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30486
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
    [Bug 30486] [OMNIBUS] Synchronize database schema with (older) database
    revisions
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 17:13:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 15:13:42 +0000
    Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
    In-Reply-To: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29226-70-xSLHgWEPuB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30491
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30491
    [Bug 30491] Convert saved reports tabs to Bootstrap
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 17:13:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 15:13:42 +0000
    Subject: [Koha-bugs] [Bug 30491] New: Convert saved reports tabs to Bootstrap
    Message-ID: <bug-30491-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30491
    
                Bug ID: 30491
               Summary: Convert saved reports tabs to Bootstrap
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: enhancement
              Priority: P5 - low
             Component: Templates
              Assignee: oleonard at myacpl.org
              Reporter: oleonard at myacpl.org
            QA Contact: testopia at bugs.koha-community.org
                    CC: testopia at bugs.koha-community.org
                Blocks: 29226
    
    Continuing the process of phasing out jQueryUI, this patch will replace
    jQueryUI tabs in the saved report template (guided_reports_start.tt).
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
    [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 17:16:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 15:16:20 +0000
    Subject: [Koha-bugs] [Bug 30492] New: Tabs break in opac-detail.pl if item
     has an image but not enough labels
    Message-ID: <bug-30492-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30492
    
                Bug ID: 30492
               Summary: Tabs break in opac-detail.pl if item has an image but
                        not enough labels
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: OPAC
              Assignee: oleonard at myacpl.org
              Reporter: florian.bontemps at biblibre.com
            QA Contact: testopia at bugs.koha-community.org
    
    Created attachment 133082
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133082&action=edit
    Picture for exemple
    
    If a record has too few labels (author, date, language, country, etc) but does
    have a picture, the bibliodescriptions will take too much space.
    
    The tabs (Holdings, Descriptions, acquisitions details, etc) will be located
    below the labels but the content of the tabs will appear below the picture.
    
    See attachment for exemple.
    
    This is indeed a niche case since you need to have a picture but not a lot of
    labels showing, but I think the tabs should be attached to their contents and
    not separated to prevent potential errors like these.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 17:17:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 15:17:57 +0000
    Subject: [Koha-bugs] [Bug 30492] Tabs break in opac-detail.pl if item has an
     image but not enough labels
    In-Reply-To: <bug-30492-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30492-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30492-70-D67LlTry3O@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30492
    
    Florian <florian.bontemps at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133082|0                           |1
            is obsolete|                            |
    
    --- Comment #1 from Florian <florian.bontemps at biblibre.com> ---
    Created attachment 133083
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133083&action=edit
    Exemple picture but in english
    
    Replaced the original picture by the english version, apologies for that.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 17:33:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 15:33:29 +0000
    Subject: [Koha-bugs] [Bug 30248] Multiple Select elements randomly have
     small width
    In-Reply-To: <bug-30248-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30248-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30248-70-fVQWhXI1f5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30248
    
    --- Comment #9 from Christopher Brannon <cbrannon at cdalibrary.org> ---
    The issue seems to have died down.  I am not seeing it at the moment while I
    have my CSS workaround removed.
    
    However, it seems to be limiting the width to 275px currently.  This cuts off
    the full description in the dropdown when closed.
    
    I think some work needs to be done to determine the length of both the
    description and the contents and resize to the longest line so we can read
    everything.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 17:53:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 15:53:27 +0000
    Subject: [Koha-bugs] [Bug 28264] Transaction type is empty in cash register
     statistics wizard report
    In-Reply-To: <bug-28264-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28264-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28264-70-N0syWW77NX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28264
    
    --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    I've tried to fix it in 20.11, but I am a little puzzled, the code seems to be
    different than in master.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 17:57:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 15:57:14 +0000
    Subject: [Koha-bugs] [Bug 28264] Transaction type is empty in cash register
     statistics wizard report
    In-Reply-To: <bug-28264-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28264-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28264-70-ar2kJMQJdW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28264
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |29271
    
    --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    It's possibly because we are missing bug 29271 in 20.11.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271
    [Bug 29271] Cash register report not displaying or exporting correctly
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 17:57:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 15:57:14 +0000
    Subject: [Koha-bugs] [Bug 29271] Cash register report not displaying or
     exporting correctly
    In-Reply-To: <bug-29271-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29271-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29271-70-B1G35vg8N6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |28264
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28264
    [Bug 28264] Transaction type is empty in cash register statistics wizard report
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 18:14:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 16:14:09 +0000
    Subject: [Koha-bugs] [Bug 20424] New UNIMARC ZEBRA indexes according to last
     IFLA updates
    In-Reply-To: <bug-20424-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20424-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20424-70-PMe5ohkvc2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424
    
    --- Comment #24 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    field 901 wasn't in the IFLA updates. What is it's new index for?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 18:28:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 16:28:55 +0000
    Subject: [Koha-bugs] [Bug 29271] Cash register report not displaying or
     exporting correctly
    In-Reply-To: <bug-29271-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29271-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29271-70-pBWzWH6Jc3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271
    
    --- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133084
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133084&action=edit
    [20.11] Bug 29271: Fix cash register report results
    
    This patch changes accounts.inc to use the credit/debit type codes directly
    rather than needlessly fetching the credit_type/debit_type object jsut to get
    the code. This allows the BLOCK to work on non-object lines
    
    We also only pass a debit or credit type to csv (accountline cannot be both)
    
    empty-line.inc is also removed in favor of correcting the markup
    
    one more column added to total line
    
    To test:
    1 - Add some debits and credits to accounts
    2 - Browse to Reports->Cash register
    3 - Select transaction type 'All transactions'
    4 - Output to screen
    5 - Run report
    6 - Note transaction types column is empty
    7 - Output to a file
    8 - Run report
    9 - Open file and note:
          amount column is out of place
          extra line before total
    10 - Apply patch
    11 - Repeat and note display and export are correct
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 18:29:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 16:29:00 +0000
    Subject: [Koha-bugs] [Bug 29271] Cash register report not displaying or
     exporting correctly
    In-Reply-To: <bug-29271-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29271-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29271-70-KD1DN7moay@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271
    
    --- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133085
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133085&action=edit
    [20.11] Bug 29271: (QA follow-up) Add missing filter
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 18:29:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 16:29:05 +0000
    Subject: [Koha-bugs] [Bug 29271] Cash register report not displaying or
     exporting correctly
    In-Reply-To: <bug-29271-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29271-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29271-70-YbSETjqaXV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271
    
    --- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133086
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133086&action=edit
    [20.11] Bug 29271: (QA follow-up) Fetch and send descriptions to template
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 18:29:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 16:29:09 +0000
    Subject: [Koha-bugs] [Bug 29271] Cash register report not displaying or
     exporting correctly
    In-Reply-To: <bug-29271-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29271-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29271-70-O73X9qCmsZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271
    
    --- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133087
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133087&action=edit
    [20.11] Bug 29271: (follow-up) Remove changes to accounts.inc
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 18:29:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 16:29:40 +0000
    Subject: [Koha-bugs] [Bug 29271] Cash register report not displaying or
     exporting correctly
    In-Reply-To: <bug-29271-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29271-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29271-70-Sex0afnB74@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271
    
    --- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Tried my hand at a rebase, with it things seem to be ok in the latest 20.11.17.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 18:51:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 16:51:01 +0000
    Subject: [Koha-bugs] [Bug 30457] Convert holds page tabs to Bootstrap
    In-Reply-To: <bug-30457-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30457-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30457-70-gADMtteaa6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30457
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 18:51:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 16:51:05 +0000
    Subject: [Koha-bugs] [Bug 30457] Convert holds page tabs to Bootstrap
    In-Reply-To: <bug-30457-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30457-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30457-70-6LVPMQEjjN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30457
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132980|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
    Created attachment 133088
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133088&action=edit
    Bug 30457: Convert holds page tabs to Bootstrap
    
    This patch updates the holds page to replace jQueryUI tabs with
    Bootstrap.
    
    To test, apply the patch and begin the process of placing a hold on a
    title in the catalog.
    
    If you have one or more patron clubs configured:
     - You should see two tabs, Patrons and Clubs.
     - Both should look correct and work correctly.
     - The Patrons tab should be selected initially, with cursor focus in
       the form field.
     - Switch to the Clubs tab. The cursor focus should move to the form
       field under this tab.
     - Submit a club search which will return results.
     - The page should refresh and the clubs tab should be preselected,
       showing the search results.
    
    If you have no patron clubs configured, the page should show only the
    Patrons tab.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 19:01:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 17:01:00 +0000
    Subject: [Koha-bugs] [Bug 30493] New: Pending archived suggestions appear on
     intranet home page
    Message-ID: <bug-30493-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30493
    
                Bug ID: 30493
               Summary: Pending archived suggestions appear on intranet home
                        page
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: minor
              Priority: P5 - low
             Component: Acquisitions
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: caroline.cyr-la-rose at inlibro.com
            QA Contact: testopia at bugs.koha-community.org
    
    If suggestions are archived before their status is changed to something other
    than "Pending", they still appear on the intranet home page and the
    acquisitions home page as suggestions to be managed.
    
    1. Go to Acquisitions > Suggestions
    2. Click on New purchase suggestion
    3. Fill in the form (title only is fine)
    4. Click on Submit your suggestion
    5. Go to the home page (click the Koha logo)
       --> Notice it says that there is 1 pending suggestion
    6. Go to Acquisitions
       --> Notice it says that there is 1 pending suggestion
    7. Go to Suggestions
    8. Click on the up arrow to the right of the Edit button and choose Archive
       --> There are no more pending suggestions
    9. Go to the home page (click the Koha logo)
       --> Notice it says that there is 1 pending suggestion
    10. Go to Acquisitions
       --> Notice it says that there is 1 pending suggestion
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 19:14:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 17:14:17 +0000
    Subject: [Koha-bugs] [Bug 29224] OMNIBUS: Replace the use of jQueryUI
     Accordion
    In-Reply-To: <bug-29224-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29224-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29224-70-Udtx6AXOtM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29224
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30494
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30494
    [Bug 30494] Replace the use of jQueryUI Accordion on the table settings page
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 19:14:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 17:14:17 +0000
    Subject: [Koha-bugs] [Bug 30494] New: Replace the use of jQueryUI Accordion
     on the table settings page
    Message-ID: <bug-30494-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30494
    
                Bug ID: 30494
               Summary: Replace the use of jQueryUI Accordion on the table
                        settings page
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: enhancement
              Priority: P5 - low
             Component: Templates
              Assignee: oleonard at myacpl.org
              Reporter: oleonard at myacpl.org
            QA Contact: testopia at bugs.koha-community.org
                    CC: testopia at bugs.koha-community.org
                Blocks: 29224
    
    As part of Bug 29224, "OMNIBUS: Replace the use of jQueryUI Accordion" we
    should replace the use of the jQueryUI accordion component on the table
    settings page with Bootstrap's Collapse component.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29224
    [Bug 29224] OMNIBUS: Replace the use of jQueryUI Accordion
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 20:58:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 18:58:21 +0000
    Subject: [Koha-bugs] [Bug 29271] Cash register report not displaying or
     exporting correctly
    In-Reply-To: <bug-29271-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29271-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29271-70-SGaOihgrSW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |victor at tuxayo.net
    
    --- Comment #24 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Thanks Katrin.
    Question also in regard other branches: Is that expected that the patches add
    spaces?
    
    Before patch:
    Manager name;Patron cardnumber;Patron name;Transaction library;Transaction
    date;Transaction type;Notes;Amount;Title;Barcode;Item type
     koha;eda;Eda Eda;Centerville;2022-04-07T00:00:00;;LOST;;1.00;;;
     koha;eda;Eda Eda;Centerville;2022-04-07T00:00:00;;LOST;;3.00;;;
     koha;eda;Eda Eda;Centerville;2022-04-07T00:00:00;CREDIT;;;-343.00;;;
     koha;eda;Eda Eda;Centerville;2022-04-07T00:00:00;;LOST;;112.00;;;
    TOTAL
    ;;;;;;-227.00
    
    
    After patch:
    Manager name;Patron cardnumber;Patron name;Transaction library;Transaction
    date;Transaction type;Notes;Amount;Title;Barcode;Item type
         koha;eda;Eda Eda;Centerville;2022-04-07T00:00:00;Lost item;;1.00;;;
         koha;eda;Eda Eda;Centerville;2022-04-07T00:00:00;Lost item;;3.00;;;
         koha;eda;Eda Eda;Centerville;2022-04-07T00:00:00;Credit;;-343.00;;;
         koha;eda;Eda Eda;Centerville;2022-04-07T00:00:00;Lost item;;112.00;;;
    TOTAL;;;;;;;-227.00
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 21:59:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 19:59:49 +0000
    Subject: [Koha-bugs] [Bug 29271] Cash register report not displaying or
     exporting correctly
    In-Reply-To: <bug-29271-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29271-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29271-70-DtW7WpEbIZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271
    
    --- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    I didn't touch that file so I'd say no. Could some '-' in the variables be
    missing?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 23:53:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 21:53:23 +0000
    Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
     more granular level
    In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-8367-70-QBGHqMWkVo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Patch doesn't apply         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 23:53:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 21:53:31 +0000
    Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
     more granular level
    In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-8367-70-wOpnfpV531@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131718|0                           |1
            is obsolete|                            |
    
    --- Comment #181 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Created attachment 133089
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133089&action=edit
    Bug 8367: Add holds_pickup_period circulation rule
    
    So that pickup delay can have a different value per patron category,
       item type or branch.
    
    To test:
    
    1) Update database, restart services
    2) Set ReservesMaxPickUpDelay syspref (if not already set)
    3) Edit your circulation rules and set a value under 'Holds pickup
    period (day) that is DIFFERENT from ReservesMaxPickUpDelay. Set a few
    different numbers for different branches as well.
    4) Place a hold on a biblio from the staff client.
    5) Check in an item from that biblio and confirm the hold as waiting
    6) Confirm the expiration date is calculated using the 'Holds pickup
    period' value instead of the ReservesMaxPickUpDelay syspref
    7) Revert the waiting status and delete the hold
    8) Re-place the hold on the biblio on the OPAC. Notice that when you
    change the pick up location, the number of days in the pickup message
    below the dropdown changes based on the circ rules.
    9) Create a holiday with a date that will overlap with the 'Holds pickup
    period'
    10) Check in an item from that biblio and confirm the hold as waiting
    11) Confirm the expiration date is calculated using the 'Holds pickup
    period' value AND considers the special holiday
    12) Confirm tests pass t/db_dependent/Holds/WaitingReserves.t
    13) Test Talking Tech:
    13a) Enable TalkingTechItivaPhoneNotification
    13b) Go to Tools -> Notices & slips. Add content to the HOLD phone
    (itiva) notice.
    13c) In your terminal, run perl
    /path/to/koha/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl -o
    ~/itiva.tmp -w 0 --type=RESERVE
    
    Sponsored-by: Catalyst IT
    
    Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 23:53:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 21:53:40 +0000
    Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
     more granular level
    In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-8367-70-e331yOMt75@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131719|0                           |1
            is obsolete|                            |
    
    --- Comment #182 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Created attachment 133090
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133090&action=edit
    Bug 8367: Make database update idempotent
    
    Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 23:53:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 21:53:49 +0000
    Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
     more granular level
    In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-8367-70-OFVPR80cUm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131720|0                           |1
            is obsolete|                            |
    
    --- Comment #183 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Created attachment 133091
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133091&action=edit
    Bug 8367: Make database update idempotent (across different MariaDB versions)
    
    The previous query seemed to work on MariaDB 10.1.48 (used by
    koha-testing-docker),
    but it didn't work on MariaDB 10.3.29 (default in Debian 10 as of this
    writing),
    but this patched query works on both indempotently.
    
    Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 23:53:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 21:53:57 +0000
    Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
     more granular level
    In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-8367-70-VZapwqYFDy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131722|0                           |1
            is obsolete|                            |
    
    --- Comment #184 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Created attachment 133092
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133092&action=edit
    Bug 8367: (follow-up) Fix pickup delay text on OPAC and other bits
    
    Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 23:54:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 21:54:05 +0000
    Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
     more granular level
    In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-8367-70-u0uRU8SBQs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131723|0                           |1
            is obsolete|                            |
    
    --- Comment #185 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Created attachment 133093
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133093&action=edit
    Bug 8367: (follow-up) Remove pickup delay message from OPAC
    
    It adds unnecessary complexity and information.
    
    Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr  7 23:54:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 21:54:15 +0000
    Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
     more granular level
    In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-8367-70-vkDnx4eHE5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131724|0                           |1
            is obsolete|                            |
    
    --- Comment #186 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Created attachment 133094
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133094&action=edit
    Bug 8367: (follow-up) Fix tests
    
    Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 00:26:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 22:26:06 +0000
    Subject: [Koha-bugs] [Bug 30488] Error when placing a recall in the OPAC
    In-Reply-To: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30488-70-c8uRjB8ztc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 00:26:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 22:26:10 +0000
    Subject: [Koha-bugs] [Bug 30488] Error when placing a recall in the OPAC
    In-Reply-To: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30488-70-QlWduELBTf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488
    
    --- Comment #1 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Created attachment 133095
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133095&action=edit
    Bug 30488: Fix error when placing recall via OPAC
    
    This error occurs due to how UpdateStats is called in Koha/Recalls.pm
    
    To test:
    1) Enable the UseRecalls system preference and set some random values in
    the recalls circulation and fines rules.
    2) Find or create an item. Check this item out to Patron A.
    3) Log in to the OPAC as Patron B.
    4) Find the item you checked out to Patron A. Click the button to place
    a recall.
    5) Fill out whatever details you like. Click the Submit button. This
    should trigger the error.
    6) Apply the patch and refresh the page.
    7) Confirm the recall has now been requested successfully.
    
    Sponsored-by: Catalyst IT
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 00:35:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 22:35:47 +0000
    Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying
     types in put mapping requests is deprecated (incompatible with 7)
    In-Reply-To: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25669-70-fQydEIxtyZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669
    
    --- Comment #26 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Thanks Kevin for the clarifications.
    
    > It will work as long as support before 6.7 is not required
    
    I would say that's not a problem. ES <= 6.7 (even 6.8 actually) has security
    issues and is upgradable to 6.8.x directly.
    
    
    (In reply to Julian Maurice from comment #25)
    > Still unsure about how to do that. We have a few possible solutions:
    > 1) Have a switch in $KOHA_CONF or in a syspref that enable/disable types
    > 2) Have the version of ES in $KOHA_CONF or in a syspref (it might be better
    > to have the version than several "feature switches") 
    
    If we need a syspref or config switch, we can count on part of instances not
    knowing that it's needed.
    
    > 3) Detect the version of ES at indexing time.
    > 
    > solution 3 might cause performance issues when indexing directly (for
    > instance after a biblio modification). They can be mitigated by either:
    > a) put the version in memcached or L1 cache, but now there's a cache issue
    > (you'd have to remember to flush the cache when upgrading ES)
    
    What if we refresh the ES version cache value on each services start?
    Surely there isn't the need to upgrade ES on the fly without even restarting
    the services.
    (wait, for installs without plack, do we have the concept of "restarting the
    services"?)
    Or maybe on ES connection init? (I don't know if it's kept alive or opened on
    each request)
    
    > b) use bug 27344 to index in a background job
    
    It would make it not backportable.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 01:03:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 07 Apr 2022 23:03:56 +0000
    Subject: [Koha-bugs] [Bug 16791] Explanation of callnumber.pl plugin
    In-Reply-To: <bug-16791-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-16791-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-16791-70-7Wc0ByVCGO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16791
    
    Michael Kuhn <mik at adminkuhn.ch> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |mik at adminkuhn.ch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 03:29:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 01:29:32 +0000
    Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
    In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23538-70-lgWapfK4k2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538
    
    Alex Buckley <alexbuckley at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133053|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 03:30:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 01:30:07 +0000
    Subject: [Koha-bugs] [Bug 23528] Show 'log in to add tags' link on all
     search result entries
    In-Reply-To: <bug-23528-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23528-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23528-70-EK1mBkIhMz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23528
    
    --- Comment #6 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
    Created attachment 133096
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133096&action=edit
    Bug 23538: (follow-up) Fix up notices
    
    - Add toolkit template (TT) syntax to notices
    - Add TT conditionals to notices
    - Add translated notice
    
    Sponsored-by: Catalyst IT
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 03:31:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 01:31:07 +0000
    Subject: [Koha-bugs] [Bug 23528] Show 'log in to add tags' link on all
     search result entries
    In-Reply-To: <bug-23528-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23528-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23528-70-5YbXSrsf6s@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23528
    
    Alex Buckley <alexbuckley at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |alexbuckley at catalyst.net.nz
     Attachment #133096|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 03:31:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 01:31:17 +0000
    Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
    In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23538-70-lcMCCJJWto@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538
    
    --- Comment #7 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
    Created attachment 133097
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133097&action=edit
    Bug 23538: (follow-up) Fix up notices
    
    - Add toolkit template (TT) syntax to notices
    - Add TT conditionals to notices
    - Add translated notice
    
    Sponsored-by: Catalyst IT
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 03:36:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 01:36:30 +0000
    Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
    In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23538-70-XJxhwey5yi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538
    
    Alex Buckley <alexbuckley at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133097|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 03:36:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 01:36:39 +0000
    Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
    In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23538-70-THHLtDGIk4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538
    
    Alex Buckley <alexbuckley at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133052|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 03:36:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 01:36:48 +0000
    Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
    In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23538-70-20bN6aknIR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538
    
    Alex Buckley <alexbuckley at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133051|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 03:37:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 01:37:09 +0000
    Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
    In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23538-70-XM3y6gJvTe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538
    
    --- Comment #8 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
    Created attachment 133098
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133098&action=edit
    Bug 23538: Email library when new patron self-registers
    
    Test plan:
    1. Apply patchset
    2. Update database:
    - cd installer/data/mysql
    - sudo koha-shell <instance>
    - ./updatedatabase.pl
    3. Restart services
    4. Set email addresses in:
    - KohaAdminEmailAddress syspref
    - EmailAddressForPatronRegistrations syspref
    - Email address in the library branch
    5. Enable PatronSelfRegistration syspref
    6. Test the following use cases:
    6.a. EmailPatronRegistrations syspref = 'none'. Submit OPAC registration.
    = OUTCOME: Confirm no OPAC_REG notice in message_queue table
    
    6.b. EmailPatronRegistrations syspref = 'email address of branch'. Submit OPAC
    registration.
    = OUTCOME: Confirm OPAC_REG notice in message_queue with to_address of
    branch address
    
    6.c. EmailPatronRegistrations syspref =
    'EmailAddressForPatronRegistrations'. Submit OPAC registration.
    = OUTCOME: Confirm OPAC_REG notice in message_queue with to_address
    equalling EmailAddressForPatronRegistrations syspref
    
    6.d. EmailPatronRegistrations syspref = 'KohaAdminEmailAddress'. Submit
    OPAC registration.
    = OUTCOME: Confirm OPAC_REG notice in message_queue with to_address
    equalling KohaAdminEmaiLAddress syspref
    
    7. Enable PatronSelfRegistrationVerifyByEmail syspref
    8. Repeat steps 6.a, 6.b, 6.c, 6.d but this time confirm the expected
    outcomes only happen AFTER you have clicked the verification link in the
    OPAC_REG_VERIFY notice
    
    Sponsored-by: Catalyst IT
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 03:37:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 01:37:28 +0000
    Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
    In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23538-70-BpNQY5wCTn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538
    
    --- Comment #9 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
    Created attachment 133099
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133099&action=edit
    Bug 23538: Unit tests
    
    Test plan:
    1. Run unit tests:
    sudo koha-shell <instance>
    cd t/db_dependent/Koha
    prove -v Patron.t
    
    Sponsored-by: Catalyst IT
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 03:37:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 01:37:55 +0000
    Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
    In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23538-70-8XmgOMqKui@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538
    
    --- Comment #10 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
    Created attachment 133100
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133100&action=edit
    Bug 23538: (follow-up) Fix up notices
    
    - Add toolkit template (TT) syntax to notices
    - Add TT conditionals to notices
    - Add translated notice
    
    Sponsored-by: Catalyst IT
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 03:41:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 01:41:07 +0000
    Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
    In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23538-70-HCFjeLKOUE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538
    
    Alex Buckley <alexbuckley at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133100|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 03:41:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 01:41:17 +0000
    Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
    In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23538-70-pwXRJEo6DI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538
    
    Alex Buckley <alexbuckley at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133099|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 03:41:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 01:41:55 +0000
    Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
    In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23538-70-fdt2Uy11gK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538
    
    Alex Buckley <alexbuckley at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133098|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 03:42:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 01:42:14 +0000
    Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
    In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23538-70-3F3hBuNtkx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538
    
    --- Comment #11 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
    Created attachment 133101
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133101&action=edit
    Bug 23538: Email library when new patron self-registers
    
    Test plan:
    1. Apply patchset
    2. Update database:
    - cd installer/data/mysql
    - sudo koha-shell <instance>
    - ./updatedatabase.pl
    3. Restart services
    4. Set email addresses in:
    - KohaAdminEmailAddress syspref
    - EmailAddressForPatronRegistrations syspref
    - Email address in the library branch
    5. Enable PatronSelfRegistration syspref
    6. Test the following use cases:
    6.a. EmailPatronRegistrations syspref = 'none'. Submit OPAC registration.
    = OUTCOME: Confirm no OPAC_REG notice in message_queue table
    
    6.b. EmailPatronRegistrations syspref = 'email address of branch'. Submit OPAC
    registration.
    = OUTCOME: Confirm OPAC_REG notice in message_queue with to_address of
    branch address
    
    6.c. EmailPatronRegistrations syspref =
    'EmailAddressForPatronRegistrations'. Submit OPAC registration.
    = OUTCOME: Confirm OPAC_REG notice in message_queue with to_address
    equalling EmailAddressForPatronRegistrations syspref
    
    6.d. EmailPatronRegistrations syspref = 'KohaAdminEmailAddress'. Submit
    OPAC registration.
    = OUTCOME: Confirm OPAC_REG notice in message_queue with to_address
    equalling KohaAdminEmaiLAddress syspref
    
    7. Enable PatronSelfRegistrationVerifyByEmail syspref
    8. Repeat steps 6.a, 6.b, 6.c, 6.d but this time confirm the expected
    outcomes only happen AFTER you have clicked the verification link in the
    OPAC_REG_VERIFY notice
    
    Sponsored-by: Catalyst IT
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 03:42:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 01:42:38 +0000
    Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
    In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23538-70-wf2b9AHiAj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538
    
    --- Comment #12 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
    Created attachment 133102
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133102&action=edit
    Bug 23538: Unit tests
    
    Test plan:
    1. Run unit tests:
    sudo koha-shell <instance>
    cd t/db_dependent/Koha
    prove -v Patron.t
    
    Sponsored-by: Catalyst IT
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 03:42:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 01:42:57 +0000
    Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
    In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23538-70-WHZUAzHlkR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538
    
    --- Comment #13 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
    Created attachment 133103
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133103&action=edit
    Bug 23538: (follow-up) Fix up notices
    
    - Add toolkit template (TT) syntax to notices
    - Add TT conditionals to notices
    - Add translated notice
    
    Sponsored-by: Catalyst IT
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 04:15:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 02:15:50 +0000
    Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
    In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23538-70-sD0fVKx0Z3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538
    
    Alex Buckley <alexbuckley at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
      Change sponsored?|---                         |Sponsored
    
    --- Comment #14 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
    I linked bug 25090 in comment #2 but I think that will need me to do some
    re-work to get it working better. 
    
    So what I've done now is write this patchset, so librarians can at least choose
    if they are notified when a new patron self-registers. This is similar
    functionality to emails sent to the library when an OPAC purchase suggestion is
    made.
    
    Ready to test!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 08:08:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 06:08:20 +0000
    Subject: [Koha-bugs] [Bug 30194] Update required JSON::Validator version
    In-Reply-To: <bug-30194-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30194-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30194-70-ph480nJA5S@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194
    
    --- Comment #99 from Mason James <mtj at kohaaloha.com> ---
    (In reply to Marcel de Rooy from comment #98)
    > How long do we need the 'exp' workaround for dev environments ?
    
    we can remove the 'exp' repo now
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 08:27:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 06:27:16 +0000
    Subject: [Koha-bugs] [Bug 30495] New:
     marc_modification_template_actions.action should be NOT NULL
    Message-ID: <bug-30495-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30495
    
                Bug ID: 30495
               Summary: marc_modification_template_actions.action should be
                        NOT NULL
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Database
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: m.de.rooy at rijksmuseum.nl
            QA Contact: testopia at bugs.koha-community.org
    
    Compare kohastructure with:
    
    $DBversion = '18.06.00.008'; ALTER TABLE marc_modification_template_actions
    CHANGE action action
    ENUM('delete_field','add_field','update_field','move_field','copy_field','copy_and_replace_field')
    
    This dbrev forgot to add NOT NULL.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 08:27:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 06:27:45 +0000
    Subject: [Koha-bugs] [Bug 30495] marc_modification_template_actions.action
     should be NOT NULL
    In-Reply-To: <bug-30495-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30495-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30495-70-rBsZ1wkWdY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30495
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30486
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
    [Bug 30486] [OMNIBUS] Synchronize database schema with (older) database
    revisions
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 08:27:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 06:27:45 +0000
    Subject: [Koha-bugs] [Bug 30486] [OMNIBUS] Synchronize database schema with
     (older) database revisions
    In-Reply-To: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30486-70-UcvmmtHO8V@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30495
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30495
    [Bug 30495] marc_modification_template_actions.action should be NOT NULL
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 08:27:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 06:27:56 +0000
    Subject: [Koha-bugs] [Bug 30495] marc_modification_template_actions.action
     should be NOT NULL
    In-Reply-To: <bug-30495-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30495-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30495-70-2OrlCLUSeM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30495
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Severity|enhancement                 |minor
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 08:37:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 06:37:03 +0000
    Subject: [Koha-bugs] [Bug 30496] New: message_attributes.message_name should
     be NOT NULL
    Message-ID: <bug-30496-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30496
    
                Bug ID: 30496
               Summary: message_attributes.message_name should be NOT NULL
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: minor
              Priority: P5 - low
             Component: Database
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: m.de.rooy at rijksmuseum.nl
            QA Contact: testopia at bugs.koha-community.org
    
    Compare kohastructure with:
    
    $DBversion = '3.01.00.139'; ALTER TABLE message_attributes CHANGE message_name
    message_name varchar(40);
    
    This dbrev forgot to add NOT NULL.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 08:37:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 06:37:16 +0000
    Subject: [Koha-bugs] [Bug 30496] message_attributes.message_name should be
     NOT NULL
    In-Reply-To: <bug-30496-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30496-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30496-70-NXjqoJaPq7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30496
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30486
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
    [Bug 30486] [OMNIBUS] Synchronize database schema with (older) database
    revisions
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 08:37:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 06:37:16 +0000
    Subject: [Koha-bugs] [Bug 30486] [OMNIBUS] Synchronize database schema with
     (older) database revisions
    In-Reply-To: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30486-70-VArg12BQqi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30496
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30496
    [Bug 30496] message_attributes.message_name should be NOT NULL
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 09:16:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 07:16:17 +0000
    Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
    In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28787-70-eoc4KVXwUb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
      Change sponsored?|Seeking sponsor             |Sponsored
                 Status|NEW                         |ASSIGNED
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Will start this once bug 28786 is pushed.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 09:23:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 07:23:49 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27344-70-sVSA1KxK5s@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    --- Comment #57 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    I've pushed a remote branch with the different dependencies applied
    https://gitlab.com/joubu/Koha/-/commits/bug_27344
    
    If we decide to enqueue a new task for the indexing step (for the other
    background jobs), we just need to remove the { index_now => 1 } flag we pass to
    ->index_records.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 09:29:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 07:29:05 +0000
    Subject: [Koha-bugs] [Bug 21083] Batch patron modification does not allow to
     modify repeatable patron attributes
    In-Reply-To: <bug-21083-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21083-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21083-70-bPcXwF0DhE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21083
    
    --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133104
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133104&action=edit
    Bug 21083: Remove all attributes
    
    not only the first one
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 09:30:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 07:30:11 +0000
    Subject: [Koha-bugs] [Bug 21083] Batch patron modification does not allow to
     modify repeatable patron attributes
    In-Reply-To: <bug-21083-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21083-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21083-70-Mxou11HCEa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21083
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Needs Signoff
    
    --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Hi Séverine, I think this patch should fix the problems you found.
    
    
    (In reply to Séverine Queune from comment #4)
    > I not sure I totally understood the expected behaviour of this patch, but
    > here as some feedback about my first quick tests.
    > 
    > If patrons have several entries for one attribute, the batch modification
    > replace all the attributes by only the new value. I assume so but can you
    > confirm it's the behaviour expected ?
    
    I think so :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 09:35:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 07:35:24 +0000
    Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
    In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29897-70-jno5jUYEtt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897
    
    --- Comment #18 from Hugo Agud <hagud at orex.es> ---
    Thanks, have you seen this bug?
    
    b) Tag 110 is not included in Authorities identifiers tab?
    
    however tag 710 is included, but not 110 
    
    thanks you in advance
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 09:37:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 07:37:27 +0000
    Subject: [Koha-bugs] [Bug 26947] kohastructure.sql should be updated for
     each release
    In-Reply-To: <bug-26947-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26947-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26947-70-ULlLFeVBbn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947
    
    --- Comment #59 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    There are a few DBIx loader options that could be considered:
    
    generate_pod => 0 This seems to be overkill, too rigorous
    pod_comment_mode => switching between NAME and DESCRIPTION, not what we need
    table_comments_table and column_comments_table => adding those tables would
    make DBIx look first there instead of the COMMENT in the data source
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 09:54:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 07:54:28 +0000
    Subject: [Koha-bugs] [Bug 30497] New: Constraint old_reserves_ibfk_4 should
     be SET NULL instead of CASCADE
    Message-ID: <bug-30497-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30497
    
                Bug ID: 30497
               Summary: Constraint old_reserves_ibfk_4 should be SET NULL
                        instead of CASCADE
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Database
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: m.de.rooy at rijksmuseum.nl
            QA Contact: testopia at bugs.koha-community.org
    
    kohastructure defines it as SET NULL
    but this upgrade 'decided' differently:
    $DBversion = "3.23.00.055"; ALTER TABLE old_reserves ADD CONSTRAINT
    `old_reserves_ibfk_4` FOREIGN KEY (`itemtype`) REFERENCES `itemtypes`
    (`itemtype`) ON DELETE CASCADE ON UPDATE CASCADE;
    
    I think we should go for SET NULL here.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 09:54:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 07:54:54 +0000
    Subject: [Koha-bugs] [Bug 30497] Constraint old_reserves_ibfk_4 should be
     SET NULL instead of CASCADE
    In-Reply-To: <bug-30497-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30497-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30497-70-MkULuwh646@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30497
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30486
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
    [Bug 30486] [OMNIBUS] Synchronize database schema with (older) database
    revisions
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 09:54:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 07:54:54 +0000
    Subject: [Koha-bugs] [Bug 30486] [OMNIBUS] Synchronize database schema with
     (older) database revisions
    In-Reply-To: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30486-70-bmtKdvyn5t@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30497
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30497
    [Bug 30497] Constraint old_reserves_ibfk_4 should be SET NULL instead of
    CASCADE
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 10:01:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 08:01:08 +0000
    Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
    In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29897-70-Vq8gNSKMXG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897
    
    --- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    (In reply to Hugo Agud from comment #18)
    > Thanks, have you seen this bug?
    > 
    > b) Tag 110 is not included in Authorities identifiers tab?
    > 
    > however tag 710 is included, but not 110 
    > 
    > thanks you in advance
    
    I don't know if it's a bug. We are returning 700..712 and 100. That's the
    current behaviour in Koha to retrieve authors.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 10:01:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 08:01:37 +0000
    Subject: [Koha-bugs] [Bug 20511] Seasonal prediction just in the staff
     language
    In-Reply-To: <bug-20511-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20511-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20511-70-NgphHzdT30@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511
    
    --- Comment #8 from Hugo Agud <hagud at orex.es> ---
    Hi
    
    Pattern offer you the chance of define {x}, {y} , {z}... it is often use only
    one season, but there are certain serials that will need two season patter
    
    number: springer-summer, winter-auttum for example.
    
    when use season two times in the same pattern, koha it only translate one,
    perhaps it also happens with the rest of days, months...etc
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 10:22:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 08:22:46 +0000
    Subject: [Koha-bugs] [Bug 30405] Style of address in patron search result
     are 110%
    In-Reply-To: <bug-30405-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30405-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30405-70-AiKToSDW1p@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30405
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 10:22:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 08:22:50 +0000
    Subject: [Koha-bugs] [Bug 30405] Style of address in patron search result
     are 110%
    In-Reply-To: <bug-30405-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30405-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30405-70-nl8waoEs7N@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30405
    
    --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133105
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133105&action=edit
    Bug 30405: Reduce font-size for address in patron search result
    
    The address has a font-size: 110%, it's not needed here, 100% is enough.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 10:23:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 08:23:03 +0000
    Subject: [Koha-bugs] [Bug 30405] Style of address in patron search result
     are 110%
    In-Reply-To: <bug-30405-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30405-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30405-70-p4xP0vZM4q@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30405
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Severity|normal                      |minor
               Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                       |ity.org                     |com
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 10:27:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 08:27:54 +0000
    Subject: [Koha-bugs] [Bug 30497] Constraint old_reserves_ibfk_4 should be
     SET NULL instead of CASCADE
    In-Reply-To: <bug-30497-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30497-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30497-70-wCrtczGCai@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30497
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 10:27:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 08:27:59 +0000
    Subject: [Koha-bugs] [Bug 30497] Constraint old_reserves_ibfk_4 should be
     SET NULL instead of CASCADE
    In-Reply-To: <bug-30497-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30497-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30497-70-WE4H88vG4I@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30497
    
    --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133106
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133106&action=edit
    Bug 30497: Recreate old_reserves_ibfk_4 when it cascades
    
    Test plan:
    Drop old_reserves_ibfk_4.
    Add back with:
        alter table old_reserves ADD CONSTRAINT `old_reserves_ibfk_4` FOREIGN KEY
    (`itemtype`) REFERENCES `itemtypes` (`itemtype`) ON DELETE CASCADE ON UPDATE
    CASCADE;
    Run dbrev. Check that constraint has been replaced by SET NULL.
    Run dbrev again. No changes.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 10:28:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 08:28:13 +0000
    Subject: [Koha-bugs] [Bug 30497] Constraint old_reserves_ibfk_4 should be
     SET NULL instead of CASCADE
    In-Reply-To: <bug-30497-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30497-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30497-70-M4L2Z3asWL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30497
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                       |ity.org                     |
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 10:35:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 08:35:03 +0000
    Subject: [Koha-bugs] [Bug 20511] Seasonal prediction just in the staff
     language
    In-Reply-To: <bug-20511-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20511-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20511-70-clFyvqWT8Y@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511
    
    --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    (In reply to Hugo Agud from comment #8)
    > Hi
    > 
    > Pattern offer you the chance of define {x}, {y} , {z}... it is often use
    > only one season, but there are certain serials that will need two season
    > patter
    > 
    > number: springer-summer, winter-auttum for example.
    > 
    > when use season two times in the same pattern, koha it only translate one,
    > perhaps it also happens with the rest of days, months...etc
    
    I don't recreate the problem.
    
    Please post a screenshot of:
    1. The "Numbering patterns" edit view
    /cgi-bin/koha/serials/subscription-numberpatterns.pl?op=modify&id=XXX
    2. The view where you are seeing the problem
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 10:42:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 08:42:08 +0000
    Subject: [Koha-bugs] [Bug 20511] Seasonal prediction just in the staff
     language
    In-Reply-To: <bug-20511-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20511-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20511-70-LzkuYEzDrF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511
    
    --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133107
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133107&action=edit
    Bug 20511: Remove translation support for short version of season
    
    Everything get messy when we translate "Sum", then "Summer" as it's a
    substring.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 10:43:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 08:43:32 +0000
    Subject: [Koha-bugs] [Bug 20511] Seasonal prediction just in the staff
     language
    In-Reply-To: <bug-20511-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20511-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20511-70-iRRs1gnM7q@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511
    
    --- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Hum, may have found a bug however. This patch should fix a weirdness in
    translation.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 10:56:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 08:56:14 +0000
    Subject: [Koha-bugs] [Bug 14250] Can generate discharge for patrons with
     fines
    In-Reply-To: <bug-14250-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14250-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14250-70-bknwBCMtrN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250
    
    --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    I have not tested but this fix should be as simple as:
    
    diff --git a/Koha/Patron/Discharge.pm b/Koha/Patron/Discharge.pm
    index 76e04e8533a..b9ebc7653af 100644
    --- a/Koha/Patron/Discharge.pm
    +++ b/Koha/Patron/Discharge.pm
    @@ -39,7 +39,12 @@ sub can_be_discharged {
         return unless $patron;
    
         my $has_pending_checkouts = $patron->checkouts->count;
    -    return $has_pending_checkouts ? 0 : 1;
    +    return 0 if $has_pending_checkouts;
    +
    +    my $has_debt = $patron->account->outstanding_debits->total_outstanding
    +    return 0 if $has_debt;
    +
    +    return 1;
     }
    
     sub is_discharged {
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 11:11:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 09:11:11 +0000
    Subject: [Koha-bugs] [Bug 30488] Error when placing a recall in the OPAC
    In-Reply-To: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30488-70-s8uxllBO8Q@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Severity|major                       |blocker
               Keywords|                            |rel_22_05_candidate
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 11:12:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 09:12:24 +0000
    Subject: [Koha-bugs] [Bug 30142] ElasticSearch MARC mappings should not
     accept whitespaces
    In-Reply-To: <bug-30142-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30142-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30142-70-vDE1EGCc46@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30142
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Version|21.05                       |unspecified
               Severity|enhancement                 |normal
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 11:15:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 09:15:05 +0000
    Subject: [Koha-bugs] [Bug 30498] New: Enum search_field.type should contain
     year in kohastructure
    Message-ID: <bug-30498-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30498
    
                Bug ID: 30498
               Summary: Enum search_field.type should contain year in
                        kohastructure
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Database
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: m.de.rooy at rijksmuseum.nl
            QA Contact: testopia at bugs.koha-community.org
    
    Conflict with dbrev:
    
    $DBversion = '20.06.00.038'; ALTER TABLE `search_field` MODIFY COLUMN `type`
    enum('','string','date','number','boolean','sum','isbn','stdno','year') NOT
    NULL
    
    kohastructure:
      `type` enum('','string','date','number','boolean','sum','isbn','stdno')
    COLLATE utf8mb4_unicode_ci NOT NULL COMMENT 'what type of data this holds,
    relevant when storing it in the search engine',
    
    Subtle other change: no comment in dbrev.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 11:15:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 09:15:20 +0000
    Subject: [Koha-bugs] [Bug 30498] Enum search_field.type should contain year
     in kohastructure
    In-Reply-To: <bug-30498-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30498-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30498-70-pqXXcrkBfl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30498
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30486
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
    [Bug 30486] [OMNIBUS] Synchronize database schema with (older) database
    revisions
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 11:15:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 09:15:20 +0000
    Subject: [Koha-bugs] [Bug 30486] [OMNIBUS] Synchronize database schema with
     (older) database revisions
    In-Reply-To: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30486-70-IfKurHECEz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30498
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30498
    [Bug 30498] Enum search_field.type should contain year in kohastructure
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 11:23:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 09:23:31 +0000
    Subject: [Koha-bugs] [Bug 30498] Enum search_field.type should contain year
     in kohastructure
    In-Reply-To: <bug-30498-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30498-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30498-70-f9FGgywRoR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30498
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
       Patch complexity|---                         |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 11:23:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 09:23:34 +0000
    Subject: [Koha-bugs] [Bug 30498] Enum search_field.type should contain year
     in kohastructure
    In-Reply-To: <bug-30498-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30498-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30498-70-Wy75XgDRFm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30498
    
    --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133108
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133108&action=edit
    Bug 30498: Fix enum search_field.type
    
    Resolves sync issue with upgrades.
    
    Test plan:
    Run dbrev.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 11:23:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 09:23:57 +0000
    Subject: [Koha-bugs] [Bug 30498] Enum search_field.type should contain year
     in kohastructure
    In-Reply-To: <bug-30498-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30498-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30498-70-Yn0PvIBjDE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30498
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
               Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                       |ity.org                     |
    
    --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Trivial: self SO
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 11:24:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 09:24:25 +0000
    Subject: [Koha-bugs] [Bug 30279] Log when personal data is displayed in
     staff client
    In-Reply-To: <bug-30279-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30279-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30279-70-4JVMoNEz3l@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30279
    
    Andreas Jonsson <andreas.jonsson at kreablo.se> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |andreas.jonsson at kreablo.se
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 11:39:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 09:39:25 +0000
    Subject: [Koha-bugs] [Bug 30498] Enum search_field.type should contain year
     in kohastructure
    In-Reply-To: <bug-30498-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30498-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30498-70-RMlTh7kbeR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30498
    
    --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133109
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133109&action=edit
    Bug 30498: Corresponding DBIx change for SearchField
    
    No test plan.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 11:53:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 09:53:05 +0000
    Subject: [Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
    In-Reply-To: <bug-12285-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-12285-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-12285-70-5nhhqL5Pwv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285
    
    --- Comment #30 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
    Just noticed that accountlines with undefined amountoutstanding are printed in
    fineslip.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 12:04:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 10:04:31 +0000
    Subject: [Koha-bugs] [Bug 22827] Automatic item modifications by age: add
     age depencency on other field(s) than dateaccessioned
    In-Reply-To: <bug-22827-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22827-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22827-70-th7rl5J4bA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |release-notes-needed
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 12:04:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 10:04:39 +0000
    Subject: [Koha-bugs] [Bug 30385] Standardize our swagger yaml spec files
    In-Reply-To: <bug-30385-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30385-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30385-70-DTsiDGEkUN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30385
    
    --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133110
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133110&action=edit
    Bug 30385: Standardize our swagger yaml spec files
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 12:05:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 10:05:03 +0000
    Subject: [Koha-bugs] [Bug 22827] Automatic item modifications by age: add
     age depencency on other field(s) than dateaccessioned
    In-Reply-To: <bug-22827-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22827-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22827-70-VjP0TuT4BU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827
    
    --- Comment #16 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Nice enhancement.
    Please add a release notes to explain this new option
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 12:05:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 10:05:19 +0000
    Subject: [Koha-bugs] [Bug 30385] Standardize our swagger yaml spec files
    In-Reply-To: <bug-30385-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30385-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30385-70-ViV0IojC2d@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30385
    
    --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133111
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133111&action=edit
    Script to generate
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 12:06:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 10:06:07 +0000
    Subject: [Koha-bugs] [Bug 30385] Standardize our swagger yaml spec files
    In-Reply-To: <bug-30385-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30385-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30385-70-q963S2PuSy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30385
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com, tomascohen at gmail.com
               Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                       |ity.org                     |com
    
    --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Tomas, Martin, do we want that? If so it's now, it will be a nightmare to
    rebase.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 12:06:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 10:06:26 +0000
    Subject: [Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
    In-Reply-To: <bug-12285-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-12285-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-12285-70-NWG78pKqVf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285
    
    --- Comment #31 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
    Created attachment 133112
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133112&action=edit
    Bug 12285: Don't print fines with undef amountoutstanding
    
    Accountlines with undefined amountoutstading value are
    printed in fineslip.
    
    To test:
    1) Find patron with credit type accountlines.
    2) Edit some of those lines from database, set their
    amountoutstanding as NULL.
    3) Print fineslip.
    => Note that edited credit lines are displayed in the
    fineslip.
    4) Apply patch.
    5) Print fineslip.
    => Note that lines are no longer displayed in the
    fineslip.
    
    Sponsored-by: Koha-Suomi Oy
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 12:06:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 10:06:36 +0000
    Subject: [Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
    In-Reply-To: <bug-12285-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-12285-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-12285-70-FBVEeS0U5Z@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285
    
    Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 12:16:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 10:16:20 +0000
    Subject: [Koha-bugs] [Bug 30076] Add ability to check patron messaging
     preferences from a notice
    In-Reply-To: <bug-30076-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30076-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30076-70-wx9nHfk9Fv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30076
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
    
    --- Comment #8 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Great :)
    This can be useful in other places
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 12:37:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 10:37:25 +0000
    Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
    In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29897-70-3Hvxu4G8CQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897
    
    --- Comment #20 from Hugo Agud <hagud at orex.es> ---
    then it could be a more general bug, however this patch, does, what it suppouse
    to do in a very smart and beatiful way.
    
    the only it could be target blank in the url, but it works very fine!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 12:38:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 10:38:36 +0000
    Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
    In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29897-70-wDo1biLjG7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897
    
    sandboxes at biblibre.com <sandboxes at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132961|0                           |1
            is obsolete|                            |
    
    --- Comment #21 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
    Created attachment 133113
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133113&action=edit
    Bug 29897: Rename get_marc_authors with get_marc_contributors
    
    get_marc_authors actually return authors from 700..712, not the first
    author from 200
    
    Sponsored-by: Orex Digital
    
    Signed-off-by: Orex Digital <info at orex.es>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 12:38:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 10:38:40 +0000
    Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
    In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29897-70-uuQFHPvsDn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897
    
    sandboxes at biblibre.com <sandboxes at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132962|0                           |1
            is obsolete|                            |
    
    --- Comment #22 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
    Created attachment 133114
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133114&action=edit
    Bug 29897: Move code to private method for reusability
    
    Sponsored-by: Orex Digital
    
    Signed-off-by: Orex Digital <info at orex.es>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 12:38:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 10:38:44 +0000
    Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
    In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29897-70-263Td4Qbw7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897
    
    sandboxes at biblibre.com <sandboxes at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132963|0                           |1
            is obsolete|                            |
    
    --- Comment #23 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
    Created attachment 133115
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133115&action=edit
    Bug 29897: Add new pref OPACAuthorIdentifiers
    
    Sponsored-by: Orex Digital
    
    Signed-off-by: Orex Digital <info at orex.es>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 12:38:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 10:38:47 +0000
    Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
    In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29897-70-9NSpIaRaYi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897
    
    sandboxes at biblibre.com <sandboxes at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132964|0                           |1
            is obsolete|                            |
    
    --- Comment #24 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
    Created attachment 133116
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133116&action=edit
    Bug 29897: Display author's identifiers
    
    This new enhancement add the capability to list the different
    identifiers of authors. It is helpful for research publications for
    instance.
    
    This patch will add a new "Author identifiers" tab on the detail page
    (OPAC) of a bibliographic record, with the list of the authors and their
    identifiers.
    On the detail page of the authority record, the same identifier list
    will be displayed.
    
    Test plan:
    Create some authority with
    024
      $a source
      $2 number
      $6 link to the source
    With the pref turned ON you will be able to see the new information.
    
    Sponsored-by: Orex Digital
    
    Signed-off-by: Orex Digital <info at orex.es>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 12:38:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 10:38:51 +0000
    Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
    In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29897-70-SIKiMjsABX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897
    
    sandboxes at biblibre.com <sandboxes at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133081|0                           |1
            is obsolete|                            |
    
    --- Comment #25 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
    Created attachment 133117
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133117&action=edit
    Bug 29897: Fix linkage
    
    Signed-off-by: Orex Digital <info at orex.es>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 12:39:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 10:39:47 +0000
    Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
    In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29897-70-9ph308o9Fa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897
    
    Hugo Agud <hagud at orex.es> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 12:56:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 10:56:01 +0000
    Subject: [Koha-bugs] [Bug 30494] Replace the use of jQueryUI Accordion on
     the table settings page
    In-Reply-To: <bug-30494-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30494-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30494-70-lhCFWPSsdg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30494
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 12:56:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 10:56:05 +0000
    Subject: [Koha-bugs] [Bug 30494] Replace the use of jQueryUI Accordion on
     the table settings page
    In-Reply-To: <bug-30494-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30494-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30494-70-c9kCJwpw4m@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30494
    
    --- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133118
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133118&action=edit
    Bug 30494: Replace the use of jQueryUI Accordion on the table settings page
    
    This page updates the table settings page so that it uses Bootstrap's
    "Collapse" feature instead of jQueryUI's Accordion.
    
    To test, apply the patch and rebuild the staff interface CSS
    (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
    
    - Go to Administration -> Table settings.
    - You should see a list of table settings which looks much the same as
      it did before, with arrow icons prefixing each section header. All
      panels should be collapsed.
    - Test expanding and collapsing panels to confirm it's working
      correctly.
    - When you expand a section the heading arrow should change from
      right-pointing to down.
    - Make a change to one of the table configurations. After clicking
      "Save" the page should reload with the same panel expanded.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 13:02:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 11:02:27 +0000
    Subject: [Koha-bugs] [Bug 20511] Seasonal prediction just in the staff
     language
    In-Reply-To: <bug-20511-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20511-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20511-70-ctWFBhQmrJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511
    
    --- Comment #12 from Hugo Agud <hagud at orex.es> ---
    url:
    https://staff-bug20511.sandboxes.biblibre.eu/cgi-bin/koha/serials/subscription-add.pl?op=modify&subscriptionid=1
    
    screenshot:
    https://orex.es/wp-content/uploads/2022/04/Captura-de-pantalla-2022-04-08-a-las-13.00.39.png
    
    but I still have no way of accessing to .po, sorry
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 13:43:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 11:43:55 +0000
    Subject: [Koha-bugs] [Bug 23775] Claiming a serial issue doesn't create the
     next one
    In-Reply-To: <bug-23775-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23775-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23775-70-eEXfZ8fm9F@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775
    
    --- Comment #1 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> ---
    Created attachment 133119
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133119&action=edit
    Bug 23775: Claiming a serial issue doesn't create the next one
    
    Whenever we need to generate manually a new serial we go to page
    'serials-edit.pl'. With this patch it is possible to generate a new serial on
    page 'serials.pl'.
    
    Test Plan:
    -- Previously we need a serial which is in EXPECTED status & the Date received
    should not be later than today --
    1)On the intra. Make sure to have at least 1 subscription for a bibliographic
    record & 1 vendor linked
    2)Then Home > Serials > Claims > Claims for <your_vendor_name>
    3)Check the row of the serial with the EXPECTED status
    4)Click 'Send notification'
    5)Notice the status of the row : it is now CLAIMED
    6)To verify: Home > Serials > Serial collection information for
    <your_record_name>
    7)The status is CLAIMED too & a new serial with an EXPECTED status has appeared
    on the table
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 13:44:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 11:44:23 +0000
    Subject: [Koha-bugs] [Bug 23775] Claiming a serial issue doesn't create the
     next one
    In-Reply-To: <bug-23775-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23775-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23775-70-hpnQT0ObAE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 14:13:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 12:13:04 +0000
    Subject: [Koha-bugs] [Bug 30499] New: Keyboard shortcuts broken on several
     pages
    Message-ID: <bug-30499-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499
    
                Bug ID: 30499
               Summary: Keyboard shortcuts broken on several pages
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Staff Client
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: emmi.takkinen at koha-suomi.fi
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com
    
    Keyboard shortcuts fro catalog search, check in and renew should be following: 
    1) Alt-q for catalog search
    2) Alt-r for check in
    3) Alt-w for renew
    
    However on some of the pages shortcuts get mixed up:
    
    1) Alt-w for catalog search
    2) Alt-q for check in
    3) Alt-r for renew
    
    Problem occurs at least on the following pages:
    
    circulation-home.pl
    circulation.pl
    renew.pl
    set-library.pl
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 14:25:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 12:25:57 +0000
    Subject: [Koha-bugs] [Bug 30393] datatables wrapper should handle searching
     for %, _ and \
    In-Reply-To: <bug-30393-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30393-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30393-70-GDyOX8V9Rx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30393
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |Pushed to stable
             Version(s)|22.05.00                    |22.05.00,21.11.05
            released in|                            |
    
    --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 14:26:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 12:26:18 +0000
    Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make
     them use the REST API routes
    In-Reply-To: <bug-30055-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30055-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30055-70-b9ZW8LsPri@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                 Status|Pushed to master            |RESOLVED
                     CC|                            |kyle at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 14:26:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 12:26:19 +0000
    Subject: [Koha-bugs] [Bug 29509] GET /patrons* routes permissions excessive
    In-Reply-To: <bug-29509-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29509-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29509-70-6RBgqSP2nn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509
    Bug 29509 depends on bug 30055, which changed state.
    
    Bug 30055 Summary: Rewrite some of the patron searches to make them use the REST API routes
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 14:26:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 12:26:19 +0000
    Subject: [Koha-bugs] [Bug 30093] Rewrite the patron search when placing a
     hold with the REST API route
    In-Reply-To: <bug-30093-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30093-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30093-70-hMOXZjG3OH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093
    Bug 30093 depends on bug 30055, which changed state.
    
    Bug 30055 Summary: Rewrite some of the patron searches to make them use the REST API routes
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 14:26:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 12:26:46 +0000
    Subject: [Koha-bugs] [Bug 30093] Rewrite the patron search when placing a
     hold with the REST API route
    In-Reply-To: <bug-30093-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30093-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30093-70-uuqWEm1gS5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 14:26:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 12:26:47 +0000
    Subject: [Koha-bugs] [Bug 30094] Rewrite the patron search when requesting
     an article with the REST API route
    In-Reply-To: <bug-30094-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30094-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30094-70-eRtxgJcLlW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30094
    Bug 30094 depends on bug 30093, which changed state.
    
    Bug 30093 Summary: Rewrite the patron search when placing a hold with the REST API route
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 14:27:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 12:27:30 +0000
    Subject: [Koha-bugs] [Bug 30094] Rewrite the patron search when requesting
     an article with the REST API route
    In-Reply-To: <bug-30094-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30094-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30094-70-h3FFsLjMgm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30094
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
             Resolution|---                         |FIXED
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 14:27:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 12:27:30 +0000
    Subject: [Koha-bugs] [Bug 30063] Make the main patron search use the
     /patrons REST API route
    In-Reply-To: <bug-30063-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30063-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30063-70-sdM3cirYC1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
    Bug 30063 depends on bug 30094, which changed state.
    
    Bug 30094 Summary: Rewrite the patron search when requesting an article with the REST API route
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30094
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 14:27:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 12:27:51 +0000
    Subject: [Koha-bugs] [Bug 30063] Make the main patron search use the
     /patrons REST API route
    In-Reply-To: <bug-30063-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30063-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30063-70-U8GKZIiRaM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
                     CC|                            |kyle at bywatersolutions.com
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 14:27:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 12:27:52 +0000
    Subject: [Koha-bugs] [Bug 30404] Enlarge all patron searches pop-up
    In-Reply-To: <bug-30404-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30404-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30404-70-muJIYKlBfR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30404
    Bug 30404 depends on bug 30063, which changed state.
    
    Bug 30063 Summary: Make the main patron search use the /patrons REST API route
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 14:27:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 12:27:52 +0000
    Subject: [Koha-bugs] [Bug 30405] Style of address in patron search result
     are 110%
    In-Reply-To: <bug-30405-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30405-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30405-70-z2UWQWPtuL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30405
    Bug 30405 depends on bug 30063, which changed state.
    
    Bug 30063 Summary: Make the main patron search use the /patrons REST API route
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 14:27:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 12:27:53 +0000
    Subject: [Koha-bugs] [Bug 30416] Patron search results page UX fixes
    In-Reply-To: <bug-30416-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30416-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30416-70-S2cm7HcMmC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30416
    Bug 30416 depends on bug 30063, which changed state.
    
    Bug 30063 Summary: Make the main patron search use the /patrons REST API route
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 14:27:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 12:27:53 +0000
    Subject: [Koha-bugs] [Bug 30420] We don't need Koha::Patron::get_overdues
     AND ::overdues
    In-Reply-To: <bug-30420-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30420-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30420-70-cu3zEd6VMo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30420
    Bug 30420 depends on bug 30063, which changed state.
    
    Bug 30063 Summary: Make the main patron search use the /patrons REST API route
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 14:27:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 12:27:53 +0000
    Subject: [Koha-bugs] [Bug 30485] Searching all patrons from the header does
     not display the patron search view
    In-Reply-To: <bug-30485-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30485-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30485-70-pK4ySrvSdz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30485
    Bug 30485 depends on bug 30063, which changed state.
    
    Bug 30063 Summary: Make the main patron search use the /patrons REST API route
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 14:27:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 12:27:54 +0000
    Subject: [Koha-bugs] [Bug 30455] Incorrect template filter breaks holds
    In-Reply-To: <bug-30455-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30455-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30455-70-LMrNewBKux@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30455
    Bug 30455 depends on bug 30063, which changed state.
    
    Bug 30063 Summary: Make the main patron search use the /patrons REST API route
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 14:28:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 12:28:30 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-sHKyCZTDGk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Sally <sally.healey at cheshiresharedservices.gov.uk> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |sally.healey at cheshireshared
                       |                            |services.gov.uk
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 14:32:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 12:32:37 +0000
    Subject: [Koha-bugs] [Bug 29501] gather_print_notices.pl does not use SMTP
     servers
    In-Reply-To: <bug-29501-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29501-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29501-70-O34Yfm7w5m@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29501
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
             Version(s)|22.05.00                    |22.05.00,21.11.05
            released in|                            |
                 Status|Pushed to master            |Pushed to stable
    
    --- Comment #26 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 14:35:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 12:35:55 +0000
    Subject: [Koha-bugs] [Bug 30114] Koha offline circulation will always cancel
     the next hold when issuing item to a patron
    In-Reply-To: <bug-30114-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30114-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30114-70-WFK0RGMXaC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |Pushed to stable
             Version(s)|22.05.00                    |22.05.00,21.11.05
            released in|                            |
    
    --- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 14:40:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 12:40:20 +0000
    Subject: [Koha-bugs] [Bug 29517] CanItemBeReserved fetches biblio for
     agerestriction check if feature not enabled
    In-Reply-To: <bug-29517-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29517-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29517-70-X9gYmLvuHa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29517
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 14:40:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 12:40:21 +0000
    Subject: [Koha-bugs] [Bug 7923] Performance omnibus
    In-Reply-To: <bug-7923-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-7923-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-7923-70-RRlbJHSGOp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923
    Bug 7923 depends on bug 29517, which changed state.
    
    Bug 29517 Summary: CanItemBeReserved fetches biblio for agerestriction check if feature not enabled
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29517
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 14:43:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 12:43:03 +0000
    Subject: [Koha-bugs] [Bug 29576] Add street type to fields which can be
     copied from guarantor to guarantee
    In-Reply-To: <bug-29576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29576-70-ntTJ5KMKC6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29576
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |Pushed to stable
             Version(s)|22.05.00                    |22.05.00,21.11.05
            released in|                            |
                     CC|                            |kyle at bywatersolutions.com
    
    --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 14:45:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 12:45:41 +0000
    Subject: [Koha-bugs] [Bug 30003] Register entries doubled up if form fails
     validation on first submission
    In-Reply-To: <bug-30003-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30003-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30003-70-b8B6mh0fq7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |Pushed to stable
             Version(s)|22.05.00                    |22.05.00,21.11.05
            released in|                            |
                     CC|                            |kyle at bywatersolutions.com
    
    --- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 14:58:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 12:58:25 +0000
    Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search
     result highlighting in the staff interface
    In-Reply-To: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20398-70-upiAPi6sHy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 14:59:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 12:59:11 +0000
    Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search
     result highlighting in the staff interface
    In-Reply-To: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20398-70-hnvp7oo8Fi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
    
    --- Comment #41 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Commit messages corrected :
    no space before ':'
    Follow-up => follow-up
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:01:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:01:33 +0000
    Subject: [Koha-bugs] [Bug 29311] Do not allow editing of bibliographic
     information when entering suggestion from existing bibs
    In-Reply-To: <bug-29311-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29311-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29311-70-1kaXQESkEV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311
    
    --- Comment #1 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> ---
    Created attachment 133120
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133120&action=edit
    Bug 29311: Do not allow editing of bibliographic information when entering
    suggestion from existing bibs
    
    This patch changes the behavior of the suggestion form in OPAC. The suggestion
    form for an existing record has its total of inputs limited, otherwise the
    inputs are all available.
    
    Test plan:
    1)OPAC: Login to your OPAC account
    2)Choose a record and get onto its details page
    3)Click 'suggest for purchase'
    4)Notice: all the fields can be modified
    5)Apply patch
    6)Repeat 2) and 3) or refresh
    7)You see that the fields about bibliographic informations are disabled now
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:05:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:05:18 +0000
    Subject: [Koha-bugs] [Bug 23009] Add -deleted_marc_conditions argument to
     export_records script
    In-Reply-To: <bug-23009-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23009-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23009-70-SXOOocJGs1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23009
    
    David Gustafsson <glasklas at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
      Attachment #90189|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from David Gustafsson <glasklas at gmail.com> ---
    Created attachment 133121
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133121&action=edit
    Bug 23009: Add -set_deleted_marc_conditions to export_records
    
    Add -set_deleted_marc_conditions argument to export_records script
    for setting deleted flag on records if condition matches.
    
    To test:
    
    1) Run tests in t/db_dependent/Exporter/Record.t
    
    Sponsored-by: Gothenburg University Library
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:13:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:13:33 +0000
    Subject: [Koha-bugs] [Bug 23009] Add -deleted_marc_conditions argument to
     export_records script
    In-Reply-To: <bug-23009-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23009-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23009-70-tLrSuAz7Ap@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23009
    
    --- Comment #4 from David Gustafsson <glasklas at gmail.com> ---
    Rebased. Also renamed option to something more descriptive, the previous was
    pretty awful as you would probably expect the conditions be applied the same
    way as for normal records but for deleted ones. -set_deleted_marc_conditions
    will set the deleted flag for matching records, and are not conditions applied
    to filter records out as the previous parameter name implied.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:15:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:15:08 +0000
    Subject: [Koha-bugs] [Bug 29821] Add interface for generating barcodes using
     svc/barcode
    In-Reply-To: <bug-29821-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29821-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29821-70-bXt8MC9UqH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29821
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
    
    --- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    In the future we will use REST API I bet
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:17:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:17:15 +0000
    Subject: [Koha-bugs] [Bug 28884] ElasticSearch: Question mark in title
     search returns no results
    In-Reply-To: <bug-28884-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28884-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28884-70-KRqTTREdaL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28884
    
    Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |marjorie.barry-vila at collect
                       |                            |o.ca
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:23:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:23:16 +0000
    Subject: [Koha-bugs] [Bug 23775] Claiming a serial issue doesn't create the
     next one
    In-Reply-To: <bug-23775-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23775-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23775-70-66cbhcHlxR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133119|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> ---
    Created attachment 133122
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133122&action=edit
    Bug 23775: Claiming a serial issue doesn't create the next one
    
    Whenever we need to generate manually a new serial we go to page
    'serials-edit.pl'. With this patch it is possible to generate a new serial on
    page 'serials.pl'.
    
    Test Plan:
    -- Previously we need a serial which is in EXPECTED status & the Date received
    should not be later than today --
    1)On the intra. Make sure to have at least 1 subscription for a bibliographic
    record & 1 vendor linked
    2)Then Home > Serials > Claims > Claims for <your_vendor_name>
    3)Check the row of the serial with the EXPECTED status
    4)Click 'Send notification'
    5)Notice the status of the row : it is now CLAIMED
    6)To verify: Home > Serials > Serial collection information for
    <your_record_name>
    7)Here the status is CLAIMED too but nothing happened around
    8)Apply patch
    9)Repeat from 2) to 6)
    10)The status is still CLAIMED & the new serial with status EXPECTED is freshly
    generated
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:24:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:24:27 +0000
    Subject: [Koha-bugs] [Bug 29311] Do not allow editing of bibliographic
     information when entering suggestion from existing bibs
    In-Reply-To: <bug-29311-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29311-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29311-70-zg3u7PD1g2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:51:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:51:12 +0000
    Subject: [Koha-bugs] [Bug 14393] Add collection code filter to inventory
    In-Reply-To: <bug-14393-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14393-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14393-70-O0cEp67L1e@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
    
    --- Comment #32 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    There is actually no unit test for other filters so its OK.
    
    We should work on more tests for inventory, and move code from pl to a module.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:51:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:51:55 +0000
    Subject: [Koha-bugs] [Bug 11083] Authority search result display in staff
     interface should be XSLT driven
    In-Reply-To: <bug-11083-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-11083-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-11083-70-HA2OYm7Kcb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:51:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:51:58 +0000
    Subject: [Koha-bugs] [Bug 11083] Authority search result display in staff
     interface should be XSLT driven
    In-Reply-To: <bug-11083-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-11083-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-11083-70-swVRMZgto7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083
    
    --- Comment #14 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:52:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:52:02 +0000
    Subject: [Koha-bugs] [Bug 14393] Add collection code filter to inventory
    In-Reply-To: <bug-14393-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14393-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14393-70-EHfqfeHHsk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:52:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:52:06 +0000
    Subject: [Koha-bugs] [Bug 14393] Add collection code filter to inventory
    In-Reply-To: <bug-14393-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14393-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14393-70-vE5504G305@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393
    
    --- Comment #33 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:52:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:52:10 +0000
    Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search
     result highlighting in the staff interface
    In-Reply-To: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20398-70-5uoWmjQNzZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:52:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:52:14 +0000
    Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search
     result highlighting in the staff interface
    In-Reply-To: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20398-70-sqS8x5RWfz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
    
    --- Comment #42 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:52:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:52:17 +0000
    Subject: [Koha-bugs] [Bug 20517] Use the "sort bin" field in SIP2 Checkin
     Response
    In-Reply-To: <bug-20517-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20517-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20517-70-SP4nX2IWKg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:52:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:52:20 +0000
    Subject: [Koha-bugs] [Bug 20517] Use the "sort bin" field in SIP2 Checkin
     Response
    In-Reply-To: <bug-20517-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20517-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20517-70-RkywGYwbKo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517
    
    --- Comment #37 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:52:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:52:24 +0000
    Subject: [Koha-bugs] [Bug 21225] Add Syndetics cover images to staff client
    In-Reply-To: <bug-21225-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21225-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21225-70-1EKAbBFqMi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:52:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:52:27 +0000
    Subject: [Koha-bugs] [Bug 21225] Add Syndetics cover images to staff client
    In-Reply-To: <bug-21225-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21225-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21225-70-dZ2TOAygye@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225
    
    --- Comment #28 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:52:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:52:30 +0000
    Subject: [Koha-bugs] [Bug 22827] Automatic item modifications by age: add
     age depencency on other field(s) than dateaccessioned
    In-Reply-To: <bug-22827-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22827-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22827-70-8eMdJ5eQWQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:52:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:52:33 +0000
    Subject: [Koha-bugs] [Bug 22827] Automatic item modifications by age: add
     age depencency on other field(s) than dateaccessioned
    In-Reply-To: <bug-22827-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22827-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22827-70-MNOXvGpHLw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827
    
    --- Comment #17 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:52:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:52:36 +0000
    Subject: [Koha-bugs] [Bug 27212] Add column configuration to the
     acquisitions home page
    In-Reply-To: <bug-27212-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27212-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27212-70-e53rTOmJfO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:52:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:52:38 +0000
    Subject: [Koha-bugs] [Bug 27212] Add column configuration to the
     acquisitions home page
    In-Reply-To: <bug-27212-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27212-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27212-70-H81MItsBzS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212
    
    --- Comment #10 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:52:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:52:41 +0000
    Subject: [Koha-bugs] [Bug 29059] Keep non-repeatable attribute from patron
     to preserve
    In-Reply-To: <bug-29059-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29059-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29059-70-aFFUg5WgQ9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29059
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:52:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:52:44 +0000
    Subject: [Koha-bugs] [Bug 29059] Keep non-repeatable attribute from patron
     to preserve
    In-Reply-To: <bug-29059-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29059-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29059-70-SvSm4On0pm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29059
    
    --- Comment #7 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:52:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:52:47 +0000
    Subject: [Koha-bugs] [Bug 29228] Use Flatpickr on offline circulation page
    In-Reply-To: <bug-29228-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29228-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29228-70-PhRgqc2IfU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:52:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:52:50 +0000
    Subject: [Koha-bugs] [Bug 29228] Use Flatpickr on offline circulation page
    In-Reply-To: <bug-29228-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29228-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29228-70-Wiz6j8NWah@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228
    
    --- Comment #7 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:52:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:52:53 +0000
    Subject: [Koha-bugs] [Bug 29609] Links to guess the biblio default view need
     to be centralized
    In-Reply-To: <bug-29609-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29609-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29609-70-o6LJqcXF9L@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29609
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:52:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:52:57 +0000
    Subject: [Koha-bugs] [Bug 29609] Links to guess the biblio default view need
     to be centralized
    In-Reply-To: <bug-29609-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29609-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29609-70-SB2EpEmYVT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29609
    
    --- Comment #8 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:53:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:53:00 +0000
    Subject: [Koha-bugs] [Bug 29787] Add plugin version to plugin search results
    In-Reply-To: <bug-29787-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29787-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29787-70-ybxPUY8VHp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29787
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:53:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:53:03 +0000
    Subject: [Koha-bugs] [Bug 29787] Add plugin version to plugin search results
    In-Reply-To: <bug-29787-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29787-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29787-70-tYWY5bfpwQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29787
    
    --- Comment #10 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:53:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:53:06 +0000
    Subject: [Koha-bugs] [Bug 29821] Add interface for generating barcodes using
     svc/barcode
    In-Reply-To: <bug-29821-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29821-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29821-70-aL5S4tRr6g@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29821
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:53:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:53:08 +0000
    Subject: [Koha-bugs] [Bug 29821] Add interface for generating barcodes using
     svc/barcode
    In-Reply-To: <bug-29821-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29821-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29821-70-UVKjxEzEFD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29821
    
    --- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:53:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:53:10 +0000
    Subject: [Koha-bugs] [Bug 29990] Show authority heading use in search results
    In-Reply-To: <bug-29990-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29990-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29990-70-ZGFOJnjnS8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29990
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:53:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:53:13 +0000
    Subject: [Koha-bugs] [Bug 29990] Show authority heading use in search results
    In-Reply-To: <bug-29990-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29990-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29990-70-ebvuG3K1HW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29990
    
    --- Comment #11 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:53:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:53:16 +0000
    Subject: [Koha-bugs] [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and
     staff interface
    In-Reply-To: <bug-30011-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30011-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30011-70-uvwS0r0x9D@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:53:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:53:18 +0000
    Subject: [Koha-bugs] [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and
     staff interface
    In-Reply-To: <bug-30011-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30011-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30011-70-kddxYskkAr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011
    
    --- Comment #12 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:53:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:53:21 +0000
    Subject: [Koha-bugs] [Bug 30076] Add ability to check patron messaging
     preferences from a notice
    In-Reply-To: <bug-30076-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30076-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30076-70-HjVOwn2NC9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30076
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:53:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:53:23 +0000
    Subject: [Koha-bugs] [Bug 30076] Add ability to check patron messaging
     preferences from a notice
    In-Reply-To: <bug-30076-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30076-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30076-70-WRMiT4ejQe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30076
    
    --- Comment #9 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:53:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:53:25 +0000
    Subject: [Koha-bugs] [Bug 30118] holds_block_checkin behavior is different
     in Koha and in SIP
    In-Reply-To: <bug-30118-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30118-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30118-70-QVpZgWaGB2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30118
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:53:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:53:28 +0000
    Subject: [Koha-bugs] [Bug 30118] holds_block_checkin behavior is different
     in Koha and in SIP
    In-Reply-To: <bug-30118-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30118-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30118-70-tyn6N9YZ5d@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30118
    
    --- Comment #6 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:53:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:53:30 +0000
    Subject: [Koha-bugs] [Bug 30120] Allow extended attributes during self
     registration when using PatronSelfRegistrationVerifyByEmail
    In-Reply-To: <bug-30120-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30120-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30120-70-A1b0ocPPgm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30120
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:53:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:53:34 +0000
    Subject: [Koha-bugs] [Bug 30120] Allow extended attributes during self
     registration when using PatronSelfRegistrationVerifyByEmail
    In-Reply-To: <bug-30120-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30120-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30120-70-Ykv8HIOm2a@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30120
    
    --- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:53:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:53:36 +0000
    Subject: [Koha-bugs] [Bug 30243] When OPACSuggestionMandatoryFields includes
     branchcode the dropdown should default to an empty value
    In-Reply-To: <bug-30243-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30243-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30243-70-yaZ9u0XTa3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30243
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:53:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:53:40 +0000
    Subject: [Koha-bugs] [Bug 30243] When OPACSuggestionMandatoryFields includes
     branchcode the dropdown should default to an empty value
    In-Reply-To: <bug-30243-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30243-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30243-70-H463Z6oGt7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30243
    
    --- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:53:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:53:42 +0000
    Subject: [Koha-bugs] [Bug 30402] Authority import hanging when replacing
     matched record
    In-Reply-To: <bug-30402-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30402-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30402-70-1VVrdGjkhn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30402
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 15:53:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 13:53:44 +0000
    Subject: [Koha-bugs] [Bug 30402] Authority import hanging when replacing
     matched record
    In-Reply-To: <bug-30402-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30402-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30402-70-Bci8btZ4lb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30402
    
    --- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 16:09:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 14:09:19 +0000
    Subject: [Koha-bugs] [Bug 29517] CanItemBeReserved fetches biblio for
     agerestriction check if feature not enabled
    In-Reply-To: <bug-29517-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29517-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29517-70-O99v4nSie7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29517
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|RESOLVED                    |REOPENED
             Resolution|FIXED                       |---
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 16:09:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 14:09:19 +0000
    Subject: [Koha-bugs] [Bug 7923] Performance omnibus
    In-Reply-To: <bug-7923-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-7923-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-7923-70-4crVUKjqsM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923
    Bug 7923 depends on bug 29517, which changed state.
    
    Bug 29517 Summary: CanItemBeReserved fetches biblio for agerestriction check if feature not enabled
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29517
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|RESOLVED                    |REOPENED
             Resolution|FIXED                       |---
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 16:09:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 14:09:47 +0000
    Subject: [Koha-bugs] [Bug 29517] CanItemBeReserved fetches biblio for
     agerestriction check if feature not enabled
    In-Reply-To: <bug-29517-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29517-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29517-70-N60ZC2M4lv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29517
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|REOPENED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 16:09:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 14:09:59 +0000
    Subject: [Koha-bugs] [Bug 29517] CanItemBeReserved fetches biblio for
     agerestriction check if feature not enabled
    In-Reply-To: <bug-29517-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29517-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29517-70-oaPkWs9VlN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29517
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 16:10:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 14:10:07 +0000
    Subject: [Koha-bugs] [Bug 29517] CanItemBeReserved fetches biblio for
     agerestriction check if feature not enabled
    In-Reply-To: <bug-29517-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29517-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29517-70-dYekXDQvrh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29517
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 16:10:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 14:10:16 +0000
    Subject: [Koha-bugs] [Bug 29517] CanItemBeReserved fetches biblio for
     agerestriction check if feature not enabled
    In-Reply-To: <bug-29517-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29517-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29517-70-RsFQZzeLBQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29517
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 16:12:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 14:12:46 +0000
    Subject: [Koha-bugs] [Bug 29517] CanItemBeReserved fetches biblio for
     agerestriction check if feature not enabled
    In-Reply-To: <bug-29517-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29517-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29517-70-iNSwbvPXEe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29517
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |Pushed to stable
             Version(s)|22.05.00                    |22.05.00,21.11.05
            released in|                            |
    
    --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 16:13:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 14:13:31 +0000
    Subject: [Koha-bugs] [Bug 30222] Auto_renew_digest still sends every day
     when renewals are not allowed
    In-Reply-To: <bug-30222-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30222-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30222-70-J0pDY8T8es@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|22.05.00                    |22.05.00,21.11.05
            released in|                            |
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |Pushed to stable
    
    --- Comment #30 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 16:30:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 14:30:01 +0000
    Subject: [Koha-bugs] [Bug 13952] Import and export of authority types
    In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-13952-70-AVWmWAdOCu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
                     CC|                            |kyle at bywatersolutions.com
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 16:39:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 14:39:44 +0000
    Subject: [Koha-bugs] [Bug 22038] When exporting account table to excel,
     decimal is lost
    In-Reply-To: <bug-22038-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22038-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22038-70-pXcFP6qtcG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22038
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |Pushed to stable
             Version(s)|22.05.00                    |22.05.00,21.11.05
            released in|                            |
    
    --- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 16:40:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 14:40:24 +0000
    Subject: [Koha-bugs] [Bug 30377] Fix two CGI::param called in list
     context-warnings
    In-Reply-To: <bug-30377-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30377-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30377-70-Aka49hVCTN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30377
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |Pushed to stable
                     CC|                            |kyle at bywatersolutions.com
             Version(s)|22.05.00                    |22.05.00,21.11.05
            released in|                            |
    
    --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 16:41:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 14:41:11 +0000
    Subject: [Koha-bugs] [Bug 28610] Elasticsearch 7 - hits.total is now an
     object
    In-Reply-To: <bug-28610-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28610-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28610-70-7R4S6DdqIK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|22.05.00                    |22.05.00,21.11.05
            released in|                            |
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |Pushed to stable
    
    --- Comment #24 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 16:42:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 14:42:24 +0000
    Subject: [Koha-bugs] [Bug 30394] Add 'draw' handling to the datatables
     wrapper and REST API
    In-Reply-To: <bug-30394-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30394-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30394-70-Ygy2eapubr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30394
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 16:42:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 14:42:24 +0000
    Subject: [Koha-bugs] [Bug 30408] API and OpenAPI versions should be string
     in spec
    In-Reply-To: <bug-30408-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30408-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30408-70-ZSIP7or0rD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30408
    Bug 30408 depends on bug 30394, which changed state.
    
    Bug 30394 Summary: Add 'draw' handling to the datatables wrapper and REST API
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30394
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 16:44:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 14:44:16 +0000
    Subject: [Koha-bugs] [Bug 30408] API and OpenAPI versions should be string
     in spec
    In-Reply-To: <bug-30408-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30408-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30408-70-ChBt62Y2AF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30408
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
                     CC|                            |kyle at bywatersolutions.com
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 16:48:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 14:48:18 +0000
    Subject: [Koha-bugs] [Bug 26669] Last Run column not updated when report is
     run publicly (via CoverFlow or elsewhere)
    In-Reply-To: <bug-26669-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26669-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26669-70-EkvR0nmgzq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |Pushed to stable
             Version(s)|22.05.00                    |22.05.00,21.11.05
            released in|                            |
    
    --- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 16:48:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 14:48:58 +0000
    Subject: [Koha-bugs] [Bug 30107] When editing a desk,
     the currently logged in library is selected
    In-Reply-To: <bug-30107-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30107-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30107-70-xoXHbgFWoI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |Pushed to stable
                     CC|                            |kyle at bywatersolutions.com
             Version(s)|22.05.00                    |22.05.00,21.11.05
            released in|                            |
    
    --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 16:50:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 14:50:10 +0000
    Subject: [Koha-bugs] [Bug 30500] New: Add option to allow user to change the
     pickup location while a hold is in transit
    Message-ID: <bug-30500-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30500
    
                Bug ID: 30500
               Summary: Add option to allow user to change the pickup location
                        while a hold is in transit
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Hold requests
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: nick at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com
    
    Currently, when a hold is in transit form one library to another, the patron
    cannot change the pickup location.
    
    Some libraries would like to allow the option for the patron to switch the
    pickup location before the book has arrived.
    
    We should add a system preference that enables this change, Koha circulation
    can already handle this, if you change the location in the DB manually the hold
    is transferred again when arriving at initial location
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 16:55:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 14:55:07 +0000
    Subject: [Koha-bugs] [Bug 30395] Internal server error at reserve/request.pl
     on a biblio with non-ISO formatted date in publicationyear
    In-Reply-To: <bug-30395-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30395-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30395-70-gn3HEDIay1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30395
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
             Resolution|---                         |FIXED
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 20:00:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 18:00:06 +0000
    Subject: [Koha-bugs] [Bug 30474] Convert tools pages tabs to Bootstrap (part
     1)
    In-Reply-To: <bug-30474-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30474-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30474-70-YpuAe6KF0w@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lucas at bywatersolutions.com
    
    --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
    On additional-contents.tt this patch seems to have a unintended effect of
    moving the CodeMirror-linenumber. 
    
    When you use HTML customizations or New and use the CodeMirror editor (Edit
    with text editor) the line numbers are awkwardly placed now.
    
    This happens to me in both Chrome and FF with the patch applied.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 20:06:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 18:06:14 +0000
    Subject: [Koha-bugs] [Bug 30474] Convert tools pages tabs to Bootstrap (part
     1)
    In-Reply-To: <bug-30474-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30474-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30474-70-ok09vNaRB2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Failed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 20:24:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 18:24:40 +0000
    Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
     posts with common subject headings from different thesaurus
    In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30280-70-MgvRPs9jcV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280
    
    Phil Ringnalda <phil at chetcolibrary.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |phil at chetcolibrary.org
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 20:55:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 18:55:30 +0000
    Subject: [Koha-bugs] [Bug 22042] BlockReturnofWithdrawn Items does not block
     refund generation when item is withdrawn and lost
    In-Reply-To: <bug-22042-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22042-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22042-70-mNVPhfaqRY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22042
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
       Patch complexity|---                         |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 20:55:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 18:55:33 +0000
    Subject: [Koha-bugs] [Bug 22042] BlockReturnofWithdrawn Items does not block
     refund generation when item is withdrawn and lost
    In-Reply-To: <bug-22042-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22042-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22042-70-AcQmrxRCgB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22042
    
    --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133123
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133123&action=edit
    Bug 22042: Block all return actions when BlockReturnOfWithdrawn items is set to
    block
    
    Currently this syspref only bokcs the literal 'return' from a patron, i.e. the
    checkin
    
    It still processes transfers, refunds lost items, updates NotForLoan status
    etc.
    
    We should block all of these things
    
    To test:
    1 - Set BlockReturnOfWithdrawn to block
    2 - Set an item as lost and withdrawn
    3 - Check it in
    4 - Item is found
    5 - Apply patch
    6 - Repeat 1-3
    7 - Checkin is blocked, item still lost
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 20:55:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 18:55:54 +0000
    Subject: [Koha-bugs] [Bug 22042] BlockReturnofWithdrawn Items does not block
     refund generation when item is withdrawn and lost
    In-Reply-To: <bug-22042-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22042-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22042-70-jN1ZRqIJI0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22042
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Version|18.05                       |master
               Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                       |ity.org                     |
                     CC|                            |nick at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 21:25:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 19:25:24 +0000
    Subject: [Koha-bugs] [Bug 30494] Replace the use of jQueryUI Accordion on
     the table settings page
    In-Reply-To: <bug-30494-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30494-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30494-70-MrGVH2pnyl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30494
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 21:25:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 19:25:28 +0000
    Subject: [Koha-bugs] [Bug 30494] Replace the use of jQueryUI Accordion on
     the table settings page
    In-Reply-To: <bug-30494-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30494-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30494-70-1oZYbvblxf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30494
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133118|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
    Created attachment 133124
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133124&action=edit
    Bug 30494: Replace the use of jQueryUI Accordion on the table settings page
    
    This page updates the table settings page so that it uses Bootstrap's
    "Collapse" feature instead of jQueryUI's Accordion.
    
    To test, apply the patch and rebuild the staff interface CSS
    (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
    
    - Go to Administration -> Table settings.
    - You should see a list of table settings which looks much the same as
      it did before, with arrow icons prefixing each section header. All
      panels should be collapsed.
    - Test expanding and collapsing panels to confirm it's working
      correctly.
    - When you expand a section the heading arrow should change from
      right-pointing to down.
    - Make a change to one of the table configurations. After clicking
      "Save" the page should reload with the same panel expanded.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 22:44:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 20:44:08 +0000
    Subject: [Koha-bugs] [Bug 30501] New: sysprefs.sql has an error
    Message-ID: <bug-30501-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30501
    
                Bug ID: 30501
               Summary: sysprefs.sql has an error
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P1 - high
             Component: Architecture, internals, and plumbing
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: lucas at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
    
    If you try to run updatedatabase or reset_all you'll get an error from
    sysprefs.sql.
    
    I think it's because of this line:
    
    ('ShowHeadingUse', '0', NULL, 'Show whether authority record contains an
    established heading that conforms to descriptive cataloguing rules, and can
    therefore be used as a main/added entry, or subject, or series title', 'YesNo'
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 22:44:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 20:44:17 +0000
    Subject: [Koha-bugs] [Bug 30501] sysprefs.sql has an error
    In-Reply-To: <bug-30501-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30501-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30501-70-UMWfWw3xhj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30501
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |29990
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29990
    [Bug 29990] Show authority heading use in search results
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 22:44:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 20:44:17 +0000
    Subject: [Koha-bugs] [Bug 29990] Show authority heading use in search results
    In-Reply-To: <bug-29990-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29990-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29990-70-aaXiPYCVZY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29990
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30501
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30501
    [Bug 30501] sysprefs.sql has an error
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 23:09:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 21:09:31 +0000
    Subject: [Koha-bugs] [Bug 30501] sysprefs.sql has an error
    In-Reply-To: <bug-30501-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30501-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30501-70-6YN6GByJsf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30501
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 23:09:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 21:09:34 +0000
    Subject: [Koha-bugs] [Bug 30501] sysprefs.sql has an error
    In-Reply-To: <bug-30501-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30501-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30501-70-qtbqpT6M9n@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30501
    
    --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
    Created attachment 133125
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133125&action=edit
    Bug 30501: Fix typo in sysprefs.sql
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 23:21:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 21:21:38 +0000
    Subject: [Koha-bugs] [Bug 29596] Add Yiddish language
    In-Reply-To: <bug-29596-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29596-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29596-70-6WfEttj9hH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
               Severity|blocker                     |enhancement
                 Status|In Discussion               |RESOLVED
    
    --- Comment #25 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    comment 17 has been addressed. Reverting severity and status
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr  8 23:21:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 21:21:40 +0000
    Subject: [Koha-bugs] [Bug 18493] Add more languages to advanced search
     languages dropdown
    In-Reply-To: <bug-18493-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18493-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18493-70-BRaQNLDBYK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18493
    Bug 18493 depends on bug 29596, which changed state.
    
    Bug 29596 Summary: Add Yiddish language
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|In Discussion               |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr  9 00:25:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 22:25:12 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-R1Y2P63e5L@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #33 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
    Created attachment 133126
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133126&action=edit
    Bug 30373: Add TYPEDOC authorised_values_category
    
    TYPEDOC authorised value category is needed to permit
    correct loading of default UNIMARC bibliographic framework.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr  9 00:26:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 08 Apr 2022 22:26:08 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-Ca0U40vZnT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #34 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
    Created attachment 133127
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133127&action=edit
    Bug 30373: Fix visibility, authorised values and descriptions
    
    This patch fixes certain values of default bibliographic
    framework.
    
    It fixes hidden values using as reference default framework
    from biblibre demo site.
    
    Also adds some missing subfields, authorised values and
    fixes capitalization on some descriptions.
    
    To test:
    1) On biblibre demo site, run a report
       SELECT tagfield,tagsubfield,hidden
       FROM marc_subfield_structure
       WHERE frameworkcode = ''
       ORDER BY tagfield,tagsubfield;
    2) Download as tab separated values, ej. biblibre-hidden.txt
    3) Apply the patch, remove bib frameworks, load YAML file
    4) Run something like this to check correct hidden values
    
       while read -r -a l; do
        t="${l[0]}";
        s="${l[1]}";
        h="${l[2]}";
        b=$( mysql koha -N -B -e "select hidden from marc_subfield_structure where
    frameworkcode = '' and tagfield = '$t' and tagsubfield = '$s'");
        [ -n "$b" -a "$b" != "$h" ] && echo "$t:$s: -> change $b to $h";
       done < <( cat biblibre-hidden.txt )
    
       there must be no output
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr  9 04:38:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 09 Apr 2022 02:38:06 +0000
    Subject: [Koha-bugs] [Bug 23775] Claiming a serial issue doesn't create the
     next one
    In-Reply-To: <bug-23775-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23775-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23775-70-ac2hmiIwXp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|victor at tuxayo.net           |jeremy.breuillard at biblibre.
                       |                            |com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr  9 11:10:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 09 Apr 2022 09:10:48 +0000
    Subject: [Koha-bugs] [Bug 22827] Automatic item modifications by age: add
     age depencency on other field(s) than dateaccessioned
    In-Reply-To: <bug-22827-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22827-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22827-70-s94YXhEmFU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827
    
    Alex Buckley <alexbuckley at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
      Text to go in the|                            |This enhancement enables
          release notes|                            |librarians to automatically
                       |                            |modify items based on date
                       |                            |fields other than
                       |                            |items.dateaccessioned.
                       |                            |
                       |                            |The 'Automatic item
                       |                            |modifications by age' tool
                       |                            |can now key rules off any
                       |                            |one the following:
                       |                            |items.dateaccessioned,
                       |                            |items.replacementpricedate,
                       |                            |items.datelastborrowed,
                       |                            |items.datelastseen,
                       |                            |items.damaged_on,
                       |                            |items.itemlost_on,
                       |                            |items.withdrawn_on.
                       |                            |
                       |                            |Existing rules will
                       |                            |continue to key off the
                       |                            |items.dateaccessioned
                       |                            |field.
               Keywords|release-notes-needed        |
    
    --- Comment #18 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
    (In reply to Fridolin Somers from comment #16)
    > Nice enhancement.
    > Please add a release notes to explain this new option
    
    Thanks, Fridolin! I've added release notes, I hope they adequately explain this
    enhancement. 
    
    Cheers,
    Alex
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr  9 20:40:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 09 Apr 2022 18:40:15 +0000
    Subject: [Koha-bugs] [Bug 29271] Cash register report not displaying or
     exporting correctly
    In-Reply-To: <bug-29271-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29271-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29271-70-eD8V2PAokl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271
    
    --- Comment #26 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    > Could some '-' in the variables be missing?
    
    Is that about template toolkit whitespace chomping?
    http://www.template-toolkit.org/docs/manual/Syntax.html#section_Chomping_Whitespace
    
    Anyway, is that an issue? Can that cause issues to consume the export?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr  9 22:29:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 09 Apr 2022 20:29:08 +0000
    Subject: [Koha-bugs] [Bug 14250] Can generate discharge for patrons with
     fines
    In-Reply-To: <bug-14250-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14250-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14250-70-q13YmqETwL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250
    
    nikkom at devinimeurope.com changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |nikkom at devinimeurope.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr  9 22:29:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 09 Apr 2022 20:29:33 +0000
    Subject: [Koha-bugs] [Bug 14250] Can generate discharge for patrons with
     fines
    In-Reply-To: <bug-14250-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14250-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14250-70-vYDZqnFwa3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250
    
    nikkom at devinimeurope.com changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |nikkom at devinimeurope.com
                       |ity.org                     |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 10 00:35:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 09 Apr 2022 22:35:24 +0000
    Subject: [Koha-bugs] [Bug 29990] Show authority heading use in search results
    In-Reply-To: <bug-29990-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29990-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29990-70-Lt6iLWhAc9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29990
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |victor at tuxayo.net
    
    --- Comment #12 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Master broken due to "Add ShowHeadingUse system preference"
    Missing closing parenthesis.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 10 00:40:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 09 Apr 2022 22:40:58 +0000
    Subject: [Koha-bugs] [Bug 29990] Show authority heading use in search results
    In-Reply-To: <bug-29990-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29990-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29990-70-o9bEDioDtQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29990
    
    --- Comment #13 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Created attachment 133128
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133128&action=edit
    Bug 29990: (follow-up) add missing parenthesis
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 10 04:41:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 10 Apr 2022 02:41:11 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-aZU2m9BJQn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131424|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 10 04:45:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 10 Apr 2022 02:45:12 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-kzLUvATyNC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131934|0                           |1
            is obsolete|                            |
    
    --- Comment #68 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Created attachment 133129
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133129&action=edit
    Bug 29602: Surround strings with span tag
    
    To be nicer with translators.
    
    Update the PO files for whichever languages will show how this is
    useful.
    
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 10 04:45:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 10 Apr 2022 02:45:18 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-ErRNtJgLzU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131935|0                           |1
            is obsolete|                            |
    
    --- Comment #69 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Created attachment 133130
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133130&action=edit
    Bug 29602: (follow-up) Surround strings with span tag
    
    To be nicer with translators.
    
    Update the PO files for whichever languages will show how this is useful.
    
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 10 04:45:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 10 Apr 2022 02:45:24 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-39ediHXfeI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131936|0                           |1
            is obsolete|                            |
    
    --- Comment #70 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Created attachment 133131
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133131&action=edit
    Bug 29602: (follow-up) Fix TT tags broken due to missing %
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 10 04:45:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 10 Apr 2022 02:45:29 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-0wtzjiFGtL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    --- Comment #71 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Created attachment 133132
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133132&action=edit
    Bug 29602: (follow-up) fix crash: SET KohaSpan → USE KohaSpan
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 10 04:45:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 10 Apr 2022 02:45:34 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-ywbU8cYWTP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131938|0                           |1
            is obsolete|                            |
    
    --- Comment #72 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Created attachment 133133
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133133&action=edit
    Bug 29602: (follow-up) fix duplicate, missing or mismatching <span>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 10 04:47:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 10 Apr 2022 02:47:22 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-NkuiBSrPVh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131937|0                           |1
            is obsolete|                            |
    
    --- Comment #73 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Comment on attachment 131937
      --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131937
    Bug 29602: (follow-up) fix crash: SET KohaSpan → USE KohaSpan
    
    Oops, git bz doesn't support "→" and fails to mark the old patch as obsolete.
    
    /usr/local/bin/git-bz:1993: UnicodeWarning: Unicode equal comparison failed to
    convert both arguments to Unicode - interpreting them as being unequal
      if attachment.description == commit.subject:
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 10 04:47:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 10 Apr 2022 02:47:49 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-smRE71GwEJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    --- Comment #74 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Rebased
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 10 16:15:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 10 Apr 2022 14:15:29 +0000
    Subject: [Koha-bugs] [Bug 22632] Add logging of merged patrons
    In-Reply-To: <bug-22632-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22632-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22632-70-b2badfVjpC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632
    
    mathieu saby <mathsabypro at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |mathsabypro at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 10 20:24:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 10 Apr 2022 18:24:54 +0000
    Subject: [Koha-bugs] [Bug 30376] Unable to save item if field date acquired
     is set mandatory
    In-Reply-To: <bug-30376-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30376-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30376-70-BQPToekxeJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30376
    
    Joonas Kylmälä <joonas.kylmala at iki.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 10 20:24:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 10 Apr 2022 18:24:58 +0000
    Subject: [Koha-bugs] [Bug 30376] Unable to save item if field date acquired
     is set mandatory
    In-Reply-To: <bug-30376-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30376-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30376-70-xo25PFr1kN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30376
    
    Joonas Kylmälä <joonas.kylmala at iki.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132985|0                           |1
            is obsolete|                            |
     Attachment #133054|0                           |1
            is obsolete|                            |
    
    --- Comment #8 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
    Created attachment 133134
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133134&action=edit
    Bug 30376: Fix missing mandatory date acquired error on item save
    
    Signed-off-by: Johanna Raisa <johanna.raisa at gmail.com>
    
    Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 10 20:25:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 10 Apr 2022 18:25:29 +0000
    Subject: [Koha-bugs] [Bug 30376] Unable to save item if field date acquired
     is set mandatory
    In-Reply-To: <bug-30376-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30376-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30376-70-xdqqU4SJzC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30376
    
    Joonas Kylmälä <joonas.kylmala at iki.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |joonas.kylmala at iki.fi
             QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                       |y.org                       |
    
    --- Comment #9 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
    Passing QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 10 22:59:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 10 Apr 2022 20:59:32 +0000
    Subject: [Koha-bugs] [Bug 30481] Drop unique constraint
     deleteditemsstocknumberidx for deleteditems
    In-Reply-To: <bug-30481-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30481-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30481-70-tG2LssygHY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30481
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133075|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Created attachment 133135
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133135&action=edit
    Bug 30481: Drop unique constraint deleteditemsstocknumberidx
    
    Resolves a sync issue between database and schema caused by
    differences between structure and upgrades. Note: newer
    databases do not contain this index any longer.
    
    Test plan:
    Run dbrev.
    Check SHOW CREATE TABLE deleteditems.
    Verify that unique index has been dropped, regular index added.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 10 23:00:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 10 Apr 2022 21:00:17 +0000
    Subject: [Koha-bugs] [Bug 30481] Drop unique constraint
     deleteditemsstocknumberidx for deleteditems
    In-Reply-To: <bug-30481-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30481-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30481-70-7uP9rURV2E@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30481
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133135|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Created attachment 133136
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133136&action=edit
    Bug 30481: Drop unique constraint deleteditemsstocknumberidx
    
    Resolves a sync issue between database and schema caused by
    differences between structure and upgrades. Note: newer
    databases do not contain this index any longer.
    
    Test plan:
    Run dbrev.
    Check SHOW CREATE TABLE deleteditems.
    Verify that unique index has been dropped, regular index added.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 10 23:02:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 10 Apr 2022 21:02:08 +0000
    Subject: [Koha-bugs] [Bug 30481] Drop unique constraint
     deleteditemsstocknumberidx for deleteditems
    In-Reply-To: <bug-30481-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30481-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30481-70-LjBizIx7Ju@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30481
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
                     CC|                            |victor at tuxayo.net
    
    --- Comment #7 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Looks good :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 10 23:29:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 10 Apr 2022 21:29:28 +0000
    Subject: [Koha-bugs] [Bug 30488] Error when placing a recall in the OPAC
    In-Reply-To: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30488-70-T0bin8wDyy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
      Change sponsored?|---                         |Sponsored
               Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz
                       |ity.org                     |
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 00:06:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 10 Apr 2022 22:06:14 +0000
    Subject: [Koha-bugs] [Bug 24161] Add ability to track the claim dates of
     later orders
    In-Reply-To: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24161-70-WEr90ruRjh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
    
    --- Comment #75 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    (In reply to Jonathan Druart from comment #74)
    > (In reply to Katrin Fischer from comment #73)
    > Looks like the following line
    > 22065                 $insert_claim_sth->execute($order->{ordernumber},
    > $order->{claimed_on});
    > should have used $order->{claimed_on} instead.
    
    Did you mean claimed_date maybe?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 00:14:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 10 Apr 2022 22:14:36 +0000
    Subject: [Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point
     of Sale can make the Collect Payment field off
    In-Reply-To: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27801-70-pSaOkmGAxq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30139
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30139
    [Bug 30139] Point of sale sets wrong 'Amount being paid' with CurrencyFormat =
    FR
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 00:14:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 10 Apr 2022 22:14:36 +0000
    Subject: [Koha-bugs] [Bug 30139] Point of sale sets wrong 'Amount being
     paid' with CurrencyFormat = FR
    In-Reply-To: <bug-30139-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30139-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30139-70-BKXQxraYz0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30139
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |27801
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801
    [Bug 27801] Entering multiple lines of an item in Point of Sale can make the
    Collect Payment field off
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 00:31:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 10 Apr 2022 22:31:29 +0000
    Subject: [Koha-bugs] [Bug 30332] SRU does not work via https
    In-Reply-To: <bug-30332-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30332-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30332-70-2gj6UwIvsH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30332
    
    --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Usually I catch up on reading the bug list regularly. As I am CC on a lot of
    bugs that doesn't work quite as well for me.
    
    I think it would be nice to get to the source of this, because as noted a
    solution that requires no server side changes would be best. 
    
    The difference between the local installation and demo makes me curious...
    Maybe a difference between packages and gitified?
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 00:54:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 10 Apr 2022 22:54:00 +0000
    Subject: [Koha-bugs] [Bug 30498] Enum search_field.type should contain year
     in kohastructure
    In-Reply-To: <bug-30498-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30498-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30498-70-wnxxTf6Gro@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30498
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133108|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Created attachment 133137
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133137&action=edit
    Bug 30498: Fix enum search_field.type
    
    Resolves sync issue with upgrades.
    
    Test plan:
    Run dbrev.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 00:54:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 10 Apr 2022 22:54:04 +0000
    Subject: [Koha-bugs] [Bug 30498] Enum search_field.type should contain year
     in kohastructure
    In-Reply-To: <bug-30498-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30498-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30498-70-AA7gJar0Dh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30498
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133109|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Created attachment 133138
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133138&action=edit
    Bug 30498: Corresponding DBIx change for SearchField
    
    No test plan.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 00:55:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 10 Apr 2022 22:55:08 +0000
    Subject: [Koha-bugs] [Bug 30498] Enum search_field.type should contain year
     in kohastructure
    In-Reply-To: <bug-30498-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30498-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30498-70-QhlUlzT7HA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30498
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |victor at tuxayo.net
                 Status|Signed Off                  |Passed QA
    
    --- Comment #6 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Looks good, thanks for syncing the DB :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 01:51:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 10 Apr 2022 23:51:21 +0000
    Subject: [Koha-bugs] [Bug 29946] Sort profiles alphabetically when staging
     MARC records for import
    In-Reply-To: <bug-29946-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29946-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29946-70-llVa5vMeHF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29946
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132240|0                           |1
            is obsolete|                            |
    
    --- Comment #10 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Created attachment 133139
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133139&action=edit
    Bug 29946: Sort Marc profiles alphabetically
    
    To test:
    1- Go to Tools > Stage MARC records for import
    2- You'll need a MARC file, choose one and hit 'Upload file'
    3- Create many Profiles with different names. Add some that include
    accents/diacritics.
    4- Notice that the profiles sort in the order in which you create them
    5- Apply patch
    6- Try steps 1-2 again
    7- Now the dropdown should be sorted alphabetically
    8- Make a few more profiles and make sure they are being inserted in the right
    order alphabetically, including the profiles containing accents/diacritics.
    
    Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov>
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 01:55:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 10 Apr 2022 23:55:19 +0000
    Subject: [Koha-bugs] [Bug 29946] Sort profiles alphabetically when staging
     MARC records for import
    In-Reply-To: <bug-29946-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29946-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29946-70-jbCwfYLg5W@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29946
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |victor at tuxayo.net
                 Status|Signed Off                  |Passed QA
    
    --- Comment #11 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Works, qa script happy, code looks good, passing QA :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 03:34:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 01:34:17 +0000
    Subject: [Koha-bugs] [Bug 30332] SRU does not work via https
    In-Reply-To: <bug-30332-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30332-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30332-70-01s9UyuNqM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30332
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |dcook at prosentient.com.au
    
    --- Comment #10 from David Cook <dcook at prosentient.com.au> ---
    I think there's some confusion in these comments, and it took me some time to
    unpack what is going on.
    
    To clarify, the problem is when a Koha web user is doing a Z39.50/SRU search of
    a remote host using SRU with HTTPS, right?
    
    I'm going to take a quick look since this is the kind of problem that itches my
    brain...
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 03:34:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 01:34:40 +0000
    Subject: [Koha-bugs] [Bug 30332] SRU does not work via https
    In-Reply-To: <bug-30332-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30332-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30332-70-lSsrIzz2Yx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30332
    
    --- Comment #11 from David Cook <dcook at prosentient.com.au> ---
    Btw, Thomas, which version of Koha are you using?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 03:45:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 01:45:19 +0000
    Subject: [Koha-bugs] [Bug 30332] SRU does not work via https
    In-Reply-To: <bug-30332-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30332-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30332-70-509x6gUtSi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30332
    
    --- Comment #12 from David Cook <dcook at prosentient.com.au> ---
    (In reply to Thomas Klausner from comment #0)
    > I tried to add an SRU service for
    > https://www.obvsg.at/en/catalogues/access-via-sru. They only provide access
    > via https. So I set it up like this:
    > 
    > Server name: OBVSGT
    > Hostname: https://services.obvsg.at
    > Port: 443
    > Database: sru/OBV-LIT
    > Additional SRU Options: operation=searchRetrieve, sru=get, sru_version=1.1
    > SRU search field mappings:
    > title=alma.title,isbn=alma.isbn,srchany=alma.all_for_ui,author=alma.creator,
    > issn=alma.issn,subject=alma.subjects,dewey=alma.dewey_decimal_class_number
    > 
    
    I tried this in a custom Koha 21.11 (Ubuntu 20.04 OS and installed with Debian
    packages) and I had no problem. 
    
    Using libyaz5 version 5.31.1-1.indexdata.
    
    Searching for a Title of "test", I got 786 pages.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 03:45:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 01:45:46 +0000
    Subject: [Koha-bugs] [Bug 30332] Outbound SRU does not work via https
    In-Reply-To: <bug-30332-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30332-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30332-70-Pyn7SAg2Gl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30332
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|SRU does not work via https |Outbound SRU does not work
                       |                            |via https
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 03:46:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 01:46:33 +0000
    Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
     records with common subject headings from different thesaurus
    In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30280-70-cZ1YJ6pa8I@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |dcook at prosentient.com.au
                Summary|Koha does not currently     |Koha does not currently
                       |support authority posts     |support authority records
                       |with common subject         |with common subject
                       |headings from different     |headings from different
                       |thesaurus                   |thesaurus
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 05:11:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 03:11:35 +0000
    Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
     characters from input fields when cataloguing
    In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30358-70-wvwoZkxHq8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133056|0                           |1
            is obsolete|                            |
    
    --- Comment #9 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Created attachment 133140
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133140&action=edit
    Bug 30358: (follow-up) Fixing tests and including for inner newlines
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 05:18:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 03:18:07 +0000
    Subject: [Koha-bugs] [Bug 17096] [OMNIBUS] CSRF protections
    In-Reply-To: <bug-17096-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17096-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17096-70-w5a0Z6r779@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17096
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |RESOLVED
                     CC|                            |dcook at prosentient.com.au
             Resolution|---                         |DUPLICATE
    
    --- Comment #2 from David Cook <dcook at prosentient.com.au> ---
    
    
    *** This bug has been marked as a duplicate of bug 22990 ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 05:18:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 03:18:08 +0000
    Subject: [Koha-bugs] [Bug 17720] CSRF token is not generated correctly
    In-Reply-To: <bug-17720-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17720-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17720-70-6xL8k0deyR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17720
    Bug 17720 depends on bug 17096, which changed state.
    
    Bug 17096 Summary: [OMNIBUS] CSRF protections
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17096
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |RESOLVED
             Resolution|---                         |DUPLICATE
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 05:18:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 03:18:08 +0000
    Subject: [Koha-bugs] [Bug 17830] CSRF token is not generated correctly (bis)
    In-Reply-To: <bug-17830-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17830-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17830-70-0yhRKg8Bof@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17830
    Bug 17830 depends on bug 17096, which changed state.
    
    Bug 17096 Summary: [OMNIBUS] CSRF protections
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17096
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |RESOLVED
             Resolution|---                         |DUPLICATE
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 07:27:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 05:27:32 +0000
    Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
     characters from input fields when cataloguing
    In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30358-70-Hg1Q6S4Hit@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |dcook at prosentient.com.au
    
    --- Comment #10 from David Cook <dcook at prosentient.com.au> ---
    (In reply to Aleisha Amohia from comment #4)
    > text area fields in MARC records are not designed to
    > carry formatting, therefore it is implied that the data would be saved as a
    > plain text string with no added formatting.
    
    As far as I know, there is no prohibition against using carriage returns and
    line feeds in MARC records. The MARCXML schema seems to indicate that all
    whitespace is allowed:
    https://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd. 
    
    That said, I haven't ever seen an example that includes them either. 
    
    > For users who follow these cataloguing standards, there should be a setting
    > to ask Koha to strip these.
    > 
    > Planning to amend StripWhitespaceChars to also strip inner line breaks and
    > carriage returns.
    
    It would probably be a good idea to indicate that it's data fields and not the
    leader and control fields that are affected. 
    
    --
    
    I'd also suggest adding an additional option for inner newlines. While I can
    see the utility of trimming whitespace off the beginning and end, I imagine
    that many librarians would be frustrated by inner whitespace being trimmed (at
    least if there wasn't a clear warning about it).
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 08:02:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 06:02:20 +0000
    Subject: [Koha-bugs] [Bug 30332] Outbound SRU does not work via https
    In-Reply-To: <bug-30332-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30332-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30332-70-gLstsEVa0r@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30332
    
    --- Comment #13 from Thomas Klausner <domm at plix.at> ---
    Yes, we have problems with outbound SRU, thanks for fixing the subject
    
    (In reply to David Cook from comment #12)
    
    > I tried this in a custom Koha 21.11 (Ubuntu 20.04 OS and installed with
    > Debian packages) and I had no problem. 
    > 
    > Using libyaz5 version 5.31.1-1.indexdata.
    > 
    > Searching for a Title of "test", I got 786 pages.
    
    We're using Koha 21.05.04 on a Debian 10 (buster) via debian packages, and
    libyaz5 5.27.1-2
    
    So I guess we should at least try to upgrade libyaz5, because I did not see any
    relevant Koha commits between 21.05 and 21.11.
    
    And these version differences could also explain why it works on some test
    instances, but not on others...
    
    Greetings,
    domm
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 08:08:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 06:08:53 +0000
    Subject: [Koha-bugs] [Bug 30332] Outbound SRU does not work via https
    In-Reply-To: <bug-30332-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30332-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30332-70-HkgpdvE4Ae@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30332
    
    --- Comment #14 from Thomas Klausner <domm at plix.at> ---
    OK, I found something in the YAZ changelog that might be relevant:
    
    https://software.indexdata.com/yaz/doc/NEWS
    
    > --- 5.30.3 2020/06/10
    > 
    > Require getaddrinfo which has been available since 2003.
    > 
    > Provide server host for SSL by using gnutls_server_name_set(3).
    > Thx to Guillaume Jactat.
    
    So I'll try to get the sysadmin to update to a more recent libyaz5, and also
    get them to provide us with a more recent debian (11, stable; instead of 10,
    oldstable).
    
    If it's OK for you, I'll keep this ticket open until I have confirmed that a
    libyaz5 update is the way to go!
    
    Greetings,
    domm
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 08:10:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 06:10:11 +0000
    Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
     characters from input fields when cataloguing
    In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30358-70-CoCgq7cS0K@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358
    
    --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    As this is going to be tied to a new pref StripWhitespaceChars I think it will
    be ok. We had the same discussion I feel over adding HTML tags to records
    before. Ok, maybe that was a bit more extreme. I feel why some libraries won't
    want this, others will be happy as it helps when you copy&paste a lot of
    content from other sources.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 08:26:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 06:26:39 +0000
    Subject: [Koha-bugs] [Bug 30503] New: Ability to include graphic in labels
    Message-ID: <bug-30503-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30503
    
                Bug ID: 30503
               Summary: Ability to include graphic in labels
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Label/patron card printing
              Assignee: cnighswonger at foundations.edu
              Reporter: egpetridis at yahoo.com
            QA Contact: testopia at bugs.koha-community.org
    
    I wonder if koha could include a graphic/image to its labels -even better in
    overlay form- so that a decent ex-libris label could be produced.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 08:38:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 06:38:16 +0000
    Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
     item from a group of titles
    In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-15516-70-KvqXVoizyj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516
    
    --- Comment #415 from David Cook <dcook at prosentient.com.au> ---
    Yeah, as Martin says, it's totally different. 
    
    By the way, this has been used in production for years now. I can't recall if
    it's been 4 years or 6 years, but a while in any case.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 09:09:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 07:09:38 +0000
    Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
     characters from input fields when cataloguing
    In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30358-70-nnMDjGHIug@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358
    
    --- Comment #12 from David Cook <dcook at prosentient.com.au> ---
    (In reply to Katrin Fischer from comment #11)
    > As this is going to be tied to a new pref StripWhitespaceChars I think it
    > will be ok. We had the same discussion I feel over adding HTML tags to
    > records before. Ok, maybe that was a bit more extreme. I feel why some
    > libraries won't want this, others will be happy as it helps when you
    > copy&paste a lot of content from other sources.
    
    Yeah, the system preference default looks fine. I think adding clear
    description in the system preference is a good idea though. The current wording
    is misleading.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 09:13:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 07:13:16 +0000
    Subject: [Koha-bugs] [Bug 30332] Outbound SRU does not work via https
    In-Reply-To: <bug-30332-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30332-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30332-70-NIVLX3iim5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30332
    
    --- Comment #15 from David Cook <dcook at prosentient.com.au> ---
    (In reply to Thomas Klausner from comment #14)
    > OK, I found something in the YAZ changelog that might be relevant:
    > 
    > https://software.indexdata.com/yaz/doc/NEWS
    > 
    > > --- 5.30.3 2020/06/10
    > > 
    > > Require getaddrinfo which has been available since 2003.
    > > 
    > > Provide server host for SSL by using gnutls_server_name_set(3).
    > > Thx to Guillaume Jactat.
    > 
    > So I'll try to get the sysadmin to update to a more recent libyaz5, and also
    > get them to provide us with a more recent debian (11, stable; instead of 10,
    > oldstable).
    > 
    > If it's OK for you, I'll keep this ticket open until I have confirmed that a
    > libyaz5 update is the way to go!
    > 
    > Greetings,
    > domm
    
    Yeah that sounds reasonable to me. Plus, older versions of Debian are still
    listed as recommended for Koha on
    https://wiki.koha-community.org/wiki/System_requirements_and_recommendations so
    it would be good to determine that the YAZ library is the culprit here so we
    could note it down.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 09:25:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 07:25:39 +0000
    Subject: [Koha-bugs] [Bug 27123] Add messages to batch patrons modification
    In-Reply-To: <bug-27123-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27123-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27123-70-OpDUMXdBr5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132924|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 09:54:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 07:54:55 +0000
    Subject: [Koha-bugs] [Bug 21330] Add xslt for authority normal view in OPAC
    In-Reply-To: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21330-70-2LHAbxDI1x@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330
    
    Julian Maurice <julian.maurice at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |julian.maurice at biblibre.com
               Assignee|oleonard at myacpl.org         |jeremy.breuillard at biblibre.
                       |                            |com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 10:17:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 08:17:30 +0000
    Subject: [Koha-bugs] [Bug 25222] Add ability to let plugins live in
     individual subdirectories
    In-Reply-To: <bug-25222-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25222-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25222-70-ncbINHzahx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222
    
    --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Is this dead in the water?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 10:50:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 08:50:19 +0000
    Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
     item from a group of titles
    In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-15516-70-rPhrQCZyQl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516
    
    --- Comment #416 from Michal Denar <black23 at gmail.com> ---
    Hi,
    We have been waiting for this feature for a really long time. We will use it
    mainly when dealing with students who require documents for school work. The
    idea is that they receive reading lists and then request the titles from the
    local library. They don't actually care which particular title they get, but
    they need one from the list. This feature would be very helpful in processing
    this kind of requests. 
    Yes, Koha is a complex system. Because it is global and reflects different
    approaches to library work. Bundles of titles are actually an extension of
    this, which is almost done now. A sort of generalization of the ability to make
    reservations over a list of titles, extended with the ability to define groups
    more comprehensively than from search results.
    I'm in favor of pushing the feature into production. At the same time, let's
    debate how to deal with requests for complex functionality in general. Would it
    make sense to design functionality more generally and then provide extensions
    with plugins? We also need to keep sustainability in mind.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 11:05:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 09:05:19 +0000
    Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying
     types in put mapping requests is deprecated (incompatible with 7)
    In-Reply-To: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25669-70-oLfx8tZ43p@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669
    
    --- Comment #27 from Kevin Carnes <kevin.carnes at ub.lu.se> ---
    (In reply to Victor Grousset/tuxayo from comment #26)
    > > It will work as long as support before 6.7 is not required
    > 
    > I would say that's not a problem. ES <= 6.7 (even 6.8 actually) has security
    > issues and is upgradable to 6.8.x directly.
    > 
    
    In that case I think it would be possible to avoid checking the ES version. As
    long as the minimum version of ES is 6.7 and the minimum version of
    Search::Elasticsearch is 6.8, using include_type_name should work for both ES 6
    and 7.
    
    This will give systems with ES 6 time to upgrade to ES 7. When it's decided
    that support for ES 6 is no longer needed, include_type_name and specifying the
    type name can be removed from Koha without needing to check the ES version
    since it's assumed to be ES 7 or ES 8.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 11:52:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 09:52:40 +0000
    Subject: [Koha-bugs] [Bug 26370] Add ability to disable demagnetizing items
     via SIP2 for arbitrary patron categories
    In-Reply-To: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26370-70-xDjOF39KNs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #120834|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133144
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133144&action=edit
    Bug 26370: Add ability to disable demagnetizing items via SIP2 for arbitrary
    patron categories
    
    Some libraries have certain patron categories that can only do in house
    checkouts via SIP self check machines.
    In these cases, the items should not be demagnetized since the items cannot
    leave the library.
    
    Test Plan:
    1) Apply this patch
    2) prove t/db_dependent/SIP/Message.t
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 11:52:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 09:52:44 +0000
    Subject: [Koha-bugs] [Bug 26370] Add ability to disable demagnetizing items
     via SIP2 for arbitrary patron categories
    In-Reply-To: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26370-70-M7zfZb98K8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370
    
    --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133145
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133145&action=edit
    Bug 26370: (QA follow-up) Add new option to templates
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 11:54:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 09:54:31 +0000
    Subject: [Koha-bugs] [Bug 26370] Add ability to disable demagnetizing items
     via SIP2 for arbitrary patron categories
    In-Reply-To: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26370-70-TJmTHBzIt6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    This works well.. I've added a follow-up to add the new option to the
    templates.
    
    We still need to also document it on
    https://wiki.koha-community.org/wiki/SIP2_configuration#accounts.
    
    However, I'm not sure about the option name... it's a little opaque.
    `never_demagnetize`.. I think we should update it to something clearer..
    perhaps `inhouse_patron_categories` or something along those lines?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 11:54:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 09:54:50 +0000
    Subject: [Koha-bugs] [Bug 26370] Add ability to disable demagnetizing items
     via SIP2 for arbitrary patron categories
    In-Reply-To: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26370-70-dmpBhZWB9k@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370
    
    --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Lets agree on a name and then we can PQA this.. it's a trivial piece of code.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 12:05:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 10:05:55 +0000
    Subject: [Koha-bugs] [Bug 28498] Add CLI counterpart for plugin actions
    In-Reply-To: <bug-28498-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28498-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28498-70-Rc8hCzbyUt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28498
    
    --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    This would be great.. we do have
    https://git.koha-community.org/Koha-community/Koha/src/branch/master/misc/devel/install_plugins.pl
    of course.. but having a package friendly debian script with all the options
    described here would be much nicer.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 12:20:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 10:20:23 +0000
    Subject: [Koha-bugs] [Bug 30504] New: Value builder for field $181
    Message-ID: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30504
    
                Bug ID: 30504
               Summary: Value builder for field $181
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: minor
              Priority: P5 - low
             Component: Cataloging
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: jeremy.breuillard at biblibre.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: m.de.rooy at rijksmuseum.nl
    
    It could be easier to have plugins on each subfield for field $181 :
    $a, $b, $c and $2
    
    The value builder plugins let you choose a code based on unimarc official
    documents and depending on the item you want to store in koha
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 12:38:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 10:38:30 +0000
    Subject: [Koha-bugs] [Bug 26370] Add ability to disable demagnetizing items
     via SIP2 for arbitrary patron categories
    In-Reply-To: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26370-70-DXGHoEz4KE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133144|0                           |1
            is obsolete|                            |
     Attachment #133145|0                           |1
            is obsolete|                            |
    
    --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Created attachment 133146
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133146&action=edit
    Bug 26370: (QA follow-up) Rename option never_demagnitize to
    inhouse_patron_categories
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 12:40:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 10:40:55 +0000
    Subject: [Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
    In-Reply-To: <bug-12285-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-12285-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-12285-70-mJEzUcTrAh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285
    
    --- Comment #32 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
    Created attachment 133147
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133147&action=edit
    Bug 12285: Determine patrons preferred languge
    
    Fineslip is not printed by patrons preferred
    language choice.
    
    To test:
    1) Add content to fineslip under "en" tab.
    2) Find patron with fines.
    3) Set patrons preferred language as "en".
    4) Print fines.
    => Fineslip has default content.
    5) Apply patch.
    6) Print slip.
    => Fineslip has "en" content.
    
    Sponsored-by: Koha-Suomi Oy
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 12:41:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 10:41:43 +0000
    Subject: [Koha-bugs] [Bug 29990] Show authority heading use in search results
    In-Reply-To: <bug-29990-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29990-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29990-70-UBmUOm3JPd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29990
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |additional_work_needed
                     CC|                            |nick at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 12:46:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 10:46:39 +0000
    Subject: [Koha-bugs] [Bug 25222] Add ability to let plugins live in
     individual subdirectories
    In-Reply-To: <bug-25222-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25222-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25222-70-3Y8tJTBKif@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222
    
    --- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
    (In reply to Martin Renvoize from comment #13)
    > Is this dead in the water?
    
    I'm not opposed to continuing work on it if someone can tell me what needs
    done.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 12:52:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 10:52:10 +0000
    Subject: [Koha-bugs] [Bug 30488] Error when placing a recall in the OPAC
    In-Reply-To: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30488-70-ApVGMLbFTf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 12:52:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 10:52:14 +0000
    Subject: [Koha-bugs] [Bug 30488] Error when placing a recall in the OPAC
    In-Reply-To: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30488-70-FDsMwjQCok@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133095|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133148
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133148&action=edit
    Bug 30488: Fix error when placing recall via OPAC
    
    This error occurs due to how UpdateStats is called in Koha/Recalls.pm
    
    To test:
    1) Enable the UseRecalls system preference and set some random values in
    the recalls circulation and fines rules.
    2) Find or create an item. Check this item out to Patron A.
    3) Log in to the OPAC as Patron B.
    4) Find the item you checked out to Patron A. Click the button to place
    a recall.
    5) Fill out whatever details you like. Click the Submit button. This
    should trigger the error.
    6) Apply the patch and refresh the page.
    7) Confirm the recall has now been requested successfully.
    
    Sponsored-by: Catalyst IT
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 12:54:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 10:54:46 +0000
    Subject: [Koha-bugs] [Bug 27059] Adding elapsed times/durations to
     updatedatabase would be nice.
    In-Reply-To: <bug-27059-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27059-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27059-70-T7vr7GYp3u@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27059
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |WONTFIX
                 Status|Failed QA                   |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 13:02:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 11:02:36 +0000
    Subject: [Koha-bugs] [Bug 30505] New: Warning when issuing recalled item
     that has a hold
    Message-ID: <bug-30505-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30505
    
                Bug ID: 30505
               Summary: Warning when issuing recalled item that has a hold
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Hold requests
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: nick at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com
    
    Recalls take priority over holds on checkin, however, on issuing the recalled
    item there is a confirm box warning of a hold. Probably the recall should be
    completed with no warning
    
    To test:
    1 - Checkout an item to Patron A
    2 - Recall item to Patron B
    3 - Place a hold on the specific item for Patron C
    4 - Check in the item
    5 - You are notified only of recall
    6 - Attempt to issue the item to Patron B
    7 - "Please confirm checkout" prompt warns of hold for patron C
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 13:02:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 11:02:47 +0000
    Subject: [Koha-bugs] [Bug 30505] Warning when issuing recalled item that has
     a hold
    In-Reply-To: <bug-30505-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30505-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30505-70-3RAYIL18jA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30505
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |19532
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
    [Bug 19532] Recalls for Koha
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 13:02:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 11:02:47 +0000
    Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
    In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-19532-70-pGC836nTyU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30505
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30505
    [Bug 30505] Warning when issuing recalled item that has a hold
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 13:02:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 11:02:51 +0000
    Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in
     plugins
    In-Reply-To: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29008-70-bz88E2Mpny@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 13:03:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 11:03:02 +0000
    Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in
     plugins
    In-Reply-To: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29008-70-FBkrv5j1TS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 13:03:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 11:03:43 +0000
    Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in
     plugins
    In-Reply-To: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29008-70-aEHr6xswJq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008
    
    --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    I've added Kyle and Tomas as CC's here to get their thoughts around the
    different ways to check versions in Koha plugins.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 13:45:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 11:45:16 +0000
    Subject: [Koha-bugs] [Bug 10517] koha-restore fails to create
     mysqluser@mysql_hostname so zebra update fails
    In-Reply-To: <bug-10517-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-10517-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-10517-70-0TuJaPtHRv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517
    
    --- Comment #42 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Yes, it should have my SO line.. oops
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 13:46:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 11:46:52 +0000
    Subject: [Koha-bugs] [Bug 30501] sysprefs.sql has an error
    In-Reply-To: <bug-30501-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30501-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30501-70-SxMywGk3so@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30501
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133125|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133149
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133149&action=edit
    Bug 30501: Fix typo in sysprefs.sql
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 13:48:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 11:48:14 +0000
    Subject: [Koha-bugs] [Bug 30501] sysprefs.sql has an error
    In-Reply-To: <bug-30501-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30501-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30501-70-LXPbcC3GJl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30501
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    This matches the follow-up in bug 29990 and works perfectly.
    
    I'm Passing QA and promoting to critical as it stop k-t-d from starting among
    other things.. we need this pushed asap
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 13:48:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 11:48:22 +0000
    Subject: [Koha-bugs] [Bug 30501] sysprefs.sql has an error
    In-Reply-To: <bug-30501-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30501-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30501-70-KMOZSFrIPA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30501
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Severity|normal                      |critical
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 13:49:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 11:49:11 +0000
    Subject: [Koha-bugs] [Bug 29990] Show authority heading use in search results
    In-Reply-To: <bug-29990-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29990-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29990-70-o6QMutTwib@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29990
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Lucas also added the fix in bug 30501.. I QA'd is there to make sure it doesn't
    get held up in any way..
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 13:49:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 11:49:21 +0000
    Subject: [Koha-bugs] [Bug 30501] sysprefs.sql has an error
    In-Reply-To: <bug-30501-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30501-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30501-70-gdtZpb0h0y@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30501
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                       |y.org                       |.com
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 13:57:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 11:57:34 +0000
    Subject: [Koha-bugs] [Bug 30504] Value builder for field $181
    In-Reply-To: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30504-70-jdAhrB13ud@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30504
    
    --- Comment #1 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> ---
    Created attachment 133150
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133150&action=edit
    MT 35334: Value builder for field 181
    
    This patch provides values builders for the subfields $a, $b, $c and $2. Those
    are unimarc official codes who help to identify the kind of items
    
    Test plan:
    1)Go to Home > Cataloging > New record
    2)Section 1 - field 181 : it contains subfields $a, $b, $c & $2
    3)Inputs are writable but notice that no plugins are suggested
    4)Apply patch and repeat 1) to 3)
    5)Values builders plugins are available for $a, $b, $c and $2
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 14:03:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 12:03:50 +0000
    Subject: [Koha-bugs] [Bug 30504] Value builder for field $181
    In-Reply-To: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30504-70-Hvyeqa0T0j@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30504
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |ASSIGNED
                     CC|                            |jeremy.breuillard at biblibre.
                       |                            |com
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 14:04:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 12:04:17 +0000
    Subject: [Koha-bugs] [Bug 30506] New: Value builder for field 182
    Message-ID: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506
    
                Bug ID: 30506
               Summary: Value builder for field 182
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: minor
              Priority: P5 - low
             Component: Cataloging
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: jeremy.breuillard at biblibre.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: m.de.rooy at rijksmuseum.nl
    
    It could be easier to have plugins on each subfield for field $182 :
    $a, $c and $2
    
    The value builder plugins let you choose a alphanumeric code based on unimarc
    official documents and depending on the item you want to store in koha
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 14:04:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 12:04:28 +0000
    Subject: [Koha-bugs] [Bug 30506] Value builder for field 182
    In-Reply-To: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30506-70-Zoz6Be6VGf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |ASSIGNED
                     CC|                            |jeremy.breuillard at biblibre.
                       |                            |com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 14:07:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 12:07:03 +0000
    Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in
     plugins
    In-Reply-To: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29008-70-YBMBqSF6bl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008
    
    --- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
    (In reply to Martin Renvoize from comment #9)
    > I've added Kyle and Tomas as CC's here to get their thoughts around the
    > different ways to check versions in Koha plugins.
    
    The big problem is we've never defined how plugin versioning works. That being
    said, I think it's pretty safe to assume semver. In fact, it would be nice to
    get that set as a community standard. If we can assume semantic versioning,
    everything because much easier!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 14:09:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 12:09:37 +0000
    Subject: [Koha-bugs] [Bug 30506] Value builder for field 182
    In-Reply-To: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30506-70-WezIjxantF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506
    
    --- Comment #1 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> ---
    Created attachment 133151
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133151&action=edit
    MT 35336: Value builder for field 182
    
    This patch provides values builders for the subfields $a, $c and $2. Those are
    unimarc official codes who help to
    identify the kind of items
    Test plan:
    1)Go to Home > Cataloging > New record
    2)Section 1 - field 182 : it contains subfields $a, $c & $2
    3)Inputs are writable but notice that no plugins are suggested
    4)Apply patch and repeat 1) to 3)
    5)Values builders plugins are available for $a, $c and $2
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 14:12:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 12:12:52 +0000
    Subject: [Koha-bugs] [Bug 30507] New: Value builder $183
    Message-ID: <bug-30507-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30507
    
                Bug ID: 30507
               Summary: Value builder $183
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: minor
              Priority: P5 - low
             Component: Cataloging
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: jeremy.breuillard at biblibre.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: m.de.rooy at rijksmuseum.nl
    
    It could be easier to have plugins on each subfield for field $183 :
    $a and $2
    
    The value builder plugins let you choose a alphanumeric code based on unimarc
    official documents and depending on the item you want to store in koha
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 14:19:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 12:19:01 +0000
    Subject: [Koha-bugs] [Bug 30506] Value builder for field 182
    In-Reply-To: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30506-70-7mqKZgbaOs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133151|MT 35336: Value builder for |Bug 30506: Value builder
            description|field 182                   |for field 182
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 14:19:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 12:19:34 +0000
    Subject: [Koha-bugs] [Bug 30504] Value builder for field $181
    In-Reply-To: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30504-70-tYsCBNrWUs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30504
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133150|MT 35334: Value builder for |Bug 30504: Value builder
            description|field 181                   |for field 181
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 14:20:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 12:20:48 +0000
    Subject: [Koha-bugs] [Bug 30506] Value builder for field 182
    In-Reply-To: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30506-70-Xa5Tj83TgJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
             Depends on|                            |29159
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29159
    [Bug 29159] UNIMARC update from IFLA for new Koha installations
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 14:20:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 12:20:48 +0000
    Subject: [Koha-bugs] [Bug 29159] UNIMARC update from IFLA for new Koha
     installations
    In-Reply-To: <bug-29159-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29159-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29159-70-shP1arMJAR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29159
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30506
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506
    [Bug 30506] Value builder for field 182
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 14:20:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 12:20:56 +0000
    Subject: [Koha-bugs] [Bug 30504] Value builder for field $181
    In-Reply-To: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30504-70-aQKFqJt12l@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30504
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
             Depends on|                            |29159
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29159
    [Bug 29159] UNIMARC update from IFLA for new Koha installations
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 14:20:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 12:20:56 +0000
    Subject: [Koha-bugs] [Bug 29159] UNIMARC update from IFLA for new Koha
     installations
    In-Reply-To: <bug-29159-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29159-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29159-70-JMu91zMhaw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29159
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30504
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30504
    [Bug 30504] Value builder for field $181
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 14:21:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 12:21:30 +0000
    Subject: [Koha-bugs] [Bug 30507] Value builder $183
    In-Reply-To: <bug-30507-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30507-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30507-70-4IbhIcyAKG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30507
    
    --- Comment #1 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> ---
    Created attachment 133152
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133152&action=edit
    Bug 30507: Value builder for field 183
    
    This patch provides values builders for the subfields $a and $2. Those are
    unimarc official codes who help to
    identify the kind of items
    Test plan:
    1)Go to Home > Cataloging > New record
    2)Section 1 - field 183 : it contains subfields $a & $2
    3)Inputs are writable but notice that no plugins are suggested
    4)Apply patch and repeat 1) to 3)
    5)Values builders plugins are available for $a and $2
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 14:22:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 12:22:08 +0000
    Subject: [Koha-bugs] [Bug 30507] Value builder $183
    In-Reply-To: <bug-30507-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30507-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30507-70-Pc3jI08GSM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30507
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |29159
                 Status|NEW                         |Needs Signoff
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29159
    [Bug 29159] UNIMARC update from IFLA for new Koha installations
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 14:22:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 12:22:08 +0000
    Subject: [Koha-bugs] [Bug 29159] UNIMARC update from IFLA for new Koha
     installations
    In-Reply-To: <bug-29159-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29159-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29159-70-yPQ01HqzjJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29159
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30507
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30507
    [Bug 30507] Value builder $183
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 14:25:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 12:25:43 +0000
    Subject: [Koha-bugs] [Bug 30507] Value builder for field $183
    In-Reply-To: <bug-30507-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30507-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30507-70-2JaFZ3J6DO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30507
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Value builder $183          |Value builder for field
                       |                            |$183
                     CC|                            |jeremy.breuillard at biblibre.
                       |                            |com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 14:26:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 12:26:32 +0000
    Subject: [Koha-bugs] [Bug 30506] Value builder for field $182
    In-Reply-To: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30506-70-wt6WeHZtA2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Value builder for field 182 |Value builder for field
                       |                            |$182
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 15:00:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 13:00:22 +0000
    Subject: [Koha-bugs] [Bug 30508] New: Do not display OPAC message about
     block from holds when OPACHoldRequests is disabled
    Message-ID: <bug-30508-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508
    
                Bug ID: 30508
               Summary: Do not display OPAC message about block from holds
                        when OPACHoldRequests is disabled
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: OPAC
              Assignee: oleonard at myacpl.org
              Reporter: andrew at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
    
    When a patron has charges on their account in excess of the amount set in
    MaxOutstanding, they see a message on their account that says "Please note:
    Your account has outstanding fees & charges of X.XX. Holds are blocked because
    your fine balance is over the limit."
    
    If the syspref OPACHoldRequests (formerly known as RequestOnOPAC) is disabled,
    we should not show this alert to the patron even if they have fines over the
    MaxOutstanding amount.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 15:04:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 13:04:22 +0000
    Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in
     plugins
    In-Reply-To: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29008-70-bADIi37BU3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008
    
    --- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    (In reply to Martin Renvoize from comment #6)
    > Comparing version numbers is fraught with peril :(..
    > 
    > This error message has annoyed me too on a number of occasions.
    > 
    > Do you realise we already have a '_version_compare' routine in
    > Koha::Plugins::Base?  Was it a deliberate choice not to use it?
    
    The `_version_compare` sub is designed to validate plugin versions, so you can
    detect a db change is required, there are examples in the wild [1].
    
    Using it actually expects semver but deals with M.m as well.
    
    I believe we should use something similar for checking Koha versions, as Frido
    proposes. But I reckon it would probably be similar to what we do for plugin
    versions.
    
    
    [1]
    https://gitlab.com/thekesolutions/plugins/koha-plugin-innreach/-/blob/master/Koha/Plugin/Com/Theke/INNReach.pm#L269-274
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 15:08:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 13:08:55 +0000
    Subject: [Koha-bugs] [Bug 28498] Add CLI counterpart for plugin actions
    In-Reply-To: <bug-28498-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28498-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28498-70-jdpNF7uSnB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28498
    
    --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    (In reply to David Cook from comment #4)
    > (In reply to Nick Clemens from comment #0)
    > > We need a CLI counterpart for plugin actions:
    > >  - Install (from a URL, from a .kpz)
    > >  - Upgrade (from a URL, from a .kpz)
    > >  - Uninstall
    > >  - Configure based on some file format
    > 
    > I actually had another thought about this...
    > 
    > What if we had an instance-level configuration file that defined the plugin,
    > the plugin version, and the plugin configuration?
    
    I like baby steps. We should add the features to some script(s) and then we
    teach them to read from a config file.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 15:10:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 13:10:47 +0000
    Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in
     plugins
    In-Reply-To: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29008-70-WIHJpQKy0U@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008
    
    --- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    (In reply to Kyle M Hall from comment #10)
    > (In reply to Martin Renvoize from comment #9)
    > > I've added Kyle and Tomas as CC's here to get their thoughts around the
    > > different ways to check versions in Koha plugins.
    > 
    > The big problem is we've never defined how plugin versioning works. That
    > being said, I think it's pretty safe to assume semver. In fact, it would be
    > nice to get that set as a community standard. If we can assume semantic
    > versioning, everything because much easier!
    
    We should definitely have something similar to the qa tools, checking this. I
    already pass my plugin commits through the qa command before pushing :-D Maybe
    we can add a --plugin param to the command and start checking this annoyances.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 15:29:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 13:29:19 +0000
    Subject: [Koha-bugs] [Bug 30501] sysprefs.sql has an error
    In-Reply-To: <bug-30501-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30501-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30501-70-oCn8pNsNlO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30501
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 15:29:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 13:29:21 +0000
    Subject: [Koha-bugs] [Bug 30501] sysprefs.sql has an error
    In-Reply-To: <bug-30501-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30501-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30501-70-1hgYeTiXEs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30501
    
    --- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 15:31:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 13:31:23 +0000
    Subject: [Koha-bugs] [Bug 29990] Show authority heading use in search results
    In-Reply-To: <bug-29990-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29990-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29990-70-QP8c0r0U5P@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29990
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
     Attachment #133128|0                           |1
            is obsolete|                            |
    
    --- Comment #15 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Comment on attachment 133128
      --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133128
    Bug 29990: (follow-up) add missing parenthesis
    
    Fixed by Bug 30501
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 15:31:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 13:31:32 +0000
    Subject: [Koha-bugs] [Bug 29990] Show authority heading use in search results
    In-Reply-To: <bug-29990-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29990-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29990-70-zJUvN8oVUH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29990
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|additional_work_needed      |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 15:55:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 13:55:37 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-vwt8Sq7sVu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                       |y.org                       |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 16:02:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 14:02:33 +0000
    Subject: [Koha-bugs] [Bug 30237] Rename/rephrase
     AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use
    In-Reply-To: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30237-70-6EZXqQmqGD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132785|0                           |1
            is obsolete|                            |
    
    --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133153
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133153&action=edit
    Bug 30237: Replace ACCDETAILS notice with WELCOME notice
    
    This patch drops the ACCDETAILS notice in preference to a new WELCOME
    notice.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 16:02:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 14:02:37 +0000
    Subject: [Koha-bugs] [Bug 30237] Rename/rephrase
     AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use
    In-Reply-To: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30237-70-caZJoBni9K@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132786|0                           |1
            is obsolete|                            |
    
    --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133154
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133154&action=edit
    Bug 30237: Reference new WELCOME notice
    
    This patch updates all references to the former ACCTDETAILS notice to
    use the new WELCOME email notice instead.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 16:02:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 14:02:41 +0000
    Subject: [Koha-bugs] [Bug 30237] Rename/rephrase
     AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use
    In-Reply-To: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30237-70-wXAIgZVgOp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132787|0                           |1
            is obsolete|                            |
    
    --- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133155
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133155&action=edit
    Bug 30237: Replace AutoEmailOpacUser with AutoEmailNewUser
    
    This patch replaces the AutoEmailOpacUser system preference with a new
    AutoEmailNewUser preference. This makes the functionof the preference
    clearer.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 16:02:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 14:02:45 +0000
    Subject: [Koha-bugs] [Bug 30237] Rename/rephrase
     AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use
    In-Reply-To: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30237-70-V84rZ71N7V@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237
    
    --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133156
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133156&action=edit
    Bug 30237: (follow-up) Update Notice
    
    This patch updates the sample notice as suggested by Katrin.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 16:02:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 14:02:49 +0000
    Subject: [Koha-bugs] [Bug 30237] Rename/rephrase
     AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use
    In-Reply-To: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30237-70-bY0D213FeU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237
    
    --- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133157
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133157&action=edit
    Bug 30237: (follow-up) Add french sample notice
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 16:02:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 14:02:53 +0000
    Subject: [Koha-bugs] [Bug 30237] Rename/rephrase
     AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use
    In-Reply-To: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30237-70-SbLqVpdGuL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237
    
    --- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133158
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133158&action=edit
    Bug 30237: Add a note about WELCOME notice to system preference
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 16:05:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 14:05:44 +0000
    Subject: [Koha-bugs] [Bug 30237] Rename/rephrase
     AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use
    In-Reply-To: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30237-70-Ssh4Ekcrxn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Signed Off
    
    --- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    (In reply to Katrin Fischer from comment #11)
    > Hi all,
    > 
    > almost there!
    > 
    > 1) This includes a database update to insert a new letter. I am not sure
    > about this approach. I think it would be better if we changed the letter
    > code on the existing ACCTDETAILS instead, because it will cause less
    > surprising behaviour. The existing notice will kept to be sent for libraries
    > using the feature instead of it suddenly changing text and turning English.
    > (blocker)
    
    This was actually a deliberate choice. The notice text is all changed, as you
    see below. By leaving the old notice there but no longer referencing it I felt
    users could use it as a reference when updating the new notice.  With the
    password functionality having already been removed it makes a lot of sense to
    require users update this notice to reflect it's clarified use.  I was
    intending to add such a comment in the release notes too.
    
    > 
    > 2) We could add a note to the system preference about the letter code, so
    > people will be able to see the change a little better. (suggestion)
    
    Done in last follow-up.
    
    > 3) QA test tools:
    > 
    >  FAIL	installer/data/mysql/atomicupdate/bug_30237.pl
    >    FAIL	  file permissions
    > 		File must have the exec flag
    
    Done
    
    > 4) New letter
    > 
    > Thank you for doing this, I already had filed a separate bug before
    > stumbling onto this here! Some small stuff and hopefully good suggestions:
    > 
    > a) Tiny typo: Thank you
    > 
    > +            - "Thankyou for joining [% Koha.Preference('LibraryName') %]"
    > 
    > b) Linking 'here'
    > 
    > Never link "here", it's a known accessibility issue with screen readers, but
    > also because we are all used to scan for links now and it doesn't give an
    > useful clue on where it leads.
    > 
    > "The library's catalog can be found <a href='[%
    > Koha.Preference('OPACBaseURL') %]'>here</a>."
    > 
    > Better to say something like:
    > You can search for all our materials in our <a href='[%
    > Koha.Preference('OPACBaseURL') %]'>catalog</a>."
    > 
    > And patron's won't know that this is Koha or who the administrator is,
    > better to ask them to get in touch with the library staff :)
    > 
    > If you have any problems or questions regarding your account, please contact
    > your Koha Administrator.
    > 
    > Better:
    > If you have any problems or questions regarding your account, please contact
    > your library.
    
    Done
    
    > 5) French installer
    > 
    > As we don't know yet if the French installer will be gone in time for
    > release, we should update the installer with the new notice:
    > 
    > installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql
    
    Done
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 16:09:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 14:09:45 +0000
    Subject: [Koha-bugs] [Bug 30237] Rename/rephrase
     AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use
    In-Reply-To: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30237-70-g129dKzIGe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237
    
    --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    (In reply to Katrin Fischer from comment #12)
    > 6) While testing bug 9097 I noticed that the branch name is not resolved in
    > the subject line:
    > 
    > Welcome to 
    > 
    > We might want to remove the name there for now and fix the subject
    > replacement for TT on a separate bug?
    
    This actually works for me.. are you sure you have the relevant syspref set?
    
    I did wonder where we should check the pref is filled.. would you like me to
    add that follow-up too?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 16:14:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 14:14:44 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-tp80VELDgK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 16:14:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 14:14:46 +0000
    Subject: [Koha-bugs] [Bug 30237] Rename/rephrase
     AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use
    In-Reply-To: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30237-70-fwiV21SiIL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237
    
    --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133159
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133159&action=edit
    Bug 30237: (follow-up) Make LibraryName conditional
    
    It's easy to forget to set the LibraryName preference.. as such we can
    make this a conditional and fall back to a default of 'the library'.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 16:14:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 14:14:49 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-DeGCeOpokt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132875|0                           |1
            is obsolete|                            |
     Attachment #132876|0                           |1
            is obsolete|                            |
     Attachment #132877|0                           |1
            is obsolete|                            |
     Attachment #132878|0                           |1
            is obsolete|                            |
     Attachment #132879|0                           |1
            is obsolete|                            |
     Attachment #132880|0                           |1
            is obsolete|                            |
     Attachment #132948|0                           |1
            is obsolete|                            |
     Attachment #132951|0                           |1
            is obsolete|                            |
    
    --- Comment #37 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Created attachment 133160
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133160&action=edit
    Bug 27783: Add --job-type to background_jobs_worker.pl
    
    This will let sysop adjust the number of workers and how they want to
    manage them.
    For instance one could want to have one worker for ES indexation and
    another worker for other jobs, to prevent ES index to be stuck behind
    bigger batch process.
    
    Signed-off-by: Arthur Suzuki <arthur.suzuki at biblibre.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 16:15:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 14:15:45 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-XLicbjGeKU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133160|0                           |1
            is obsolete|                            |
    
    --- Comment #38 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Created attachment 133161
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133161&action=edit
    Bug 27783: Add --job-type to background_jobs_worker.pl
    
    This will let sysop adjust the number of workers and how they want to
    manage them.
    For instance one could want to have one worker for ES indexation and
    another worker for other jobs, to prevent ES index to be stuck behind
    bigger batch process.
    
    Signed-off-by: Arthur Suzuki <arthur.suzuki at biblibre.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 16:16:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 14:16:15 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-Foe6iFgmqf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    --- Comment #39 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Created attachment 133162
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133162&action=edit
    Bug 27783: Replace --job-type by --queue
    
    This patch adds a new column background_jobs.queue, which default to
    'default'
    By default, new jobs are enqueued into this default queue, and the
    background job worker will subscribe to the default queue unless told
    otherwise by the --job-queue option
    
    The new job UpdateElasticIndex is automatically enqueued in another
    queue named 'index'
    So you can have 'default' worker with
        misc/background_jobs_worker.pl
    and a dedicated indexing worker with
        misc/background_jobs_worker.pl --queue index
    
    This is to address bug 27344 comment #15
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 16:16:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 14:16:19 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-28is3273yG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    --- Comment #40 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Created attachment 133163
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133163&action=edit
    Bug 27783: Add missing atomicupdate file
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 16:16:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 14:16:23 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-J1K2K1YWMn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    --- Comment #41 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Created attachment 133164
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133164&action=edit
    Bug 27783: (follow-up) Add DB change to installer
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 16:16:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 14:16:27 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-Sy9PjLbcFC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    --- Comment #42 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Created attachment 133165
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133165&action=edit
    Bug 27783: Rename queues and adjust currently defined jobs
    
    This patch renames the queues so the default is the **real-time** one, and
    the other (*long_tasks*) is kept for **long running** tasks.
    
    All current *batch* tasks are explicitly assigned to the **long_tasks**
    queue as well.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 16:16:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 14:16:32 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-Dzhc5Qwp6X@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    --- Comment #43 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Created attachment 133166
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133166&action=edit
    Bug 27783: (QA follow-up) Make dbrev idempotent
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 16:16:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 14:16:37 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-hd6qdSF5vo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    --- Comment #44 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Created attachment 133167
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133167&action=edit
    Bug 27783: DBIC update [DO NOT PUSH]
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 16:16:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 14:16:43 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-I6U9a7NBLT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    --- Comment #45 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Created attachment 133168
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133168&action=edit
    Bug 27783: Add queue handling in packaging tools
    
    This patch adds queue name handling in is_worker_running and a handy
    method to centralize process name handling for queue-specific workers.
    
    To test:
    1. Apply this patch
    2. Run:
       $ source debian/scripts/koha-functions.sh
       $ get_worker_name kohadev
       kohadev-koha-worker
    => SUCCESS: Default queue means no queue name included
       $ get_worker_name kohadev default
       kohadev-koha-worker
    => SUCCESS: Default queue means no queue name included
       $ get_worker_name kohadev long_tasks
       kohadev-koha-worker-long_tasks
    => SUCCESS: Queue name appended to the name
    4. Run:
       $ perl misc4dev/cp_debian_files.pl \
                  --koha_dir /kohadevbox/koha \
                  --gitify /kohadevbox/gitify \
                  --instance kohadev
    5. Run:
       $ koha-worker --start --queue oleonard kohadev
    => SUCCESS: Starts!
    6. Check:
       $ ps waux | grep oleonard
    => SUCCESS: It is running
    7. Play with --stop, --restart, --status and different queue names,
       including 'default' and without the --queue param as well.
    => SUCCESS: All as expected!
    8. Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 16:16:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 14:16:47 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-PitcOl8Nz7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    --- Comment #46 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Created attachment 133169
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133169&action=edit
    Bug 27783: (QA follow-up) Make dbrev executable
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 16:18:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 14:18:28 +0000
    Subject: [Koha-bugs] [Bug 30385] Standardize our swagger yaml spec files
    In-Reply-To: <bug-30385-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30385-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30385-70-8R7kmmZAgf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30385
    
    --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    I like consistency.. looks good to me :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 16:20:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 14:20:39 +0000
    Subject: [Koha-bugs] [Bug 30410] Add a way for plugins to register
     background tasks
    In-Reply-To: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30410-70-wY8o1MWs9P@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                       |y.org                       |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 16:42:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 14:42:36 +0000
    Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in
     plugins
    In-Reply-To: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29008-70-KrXXyHo8ru@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008
    
    --- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
    (In reply to Tomás Cohen Arazi from comment #12)
    > (In reply to Kyle M Hall from comment #10)
    > > (In reply to Martin Renvoize from comment #9)
    > > > I've added Kyle and Tomas as CC's here to get their thoughts around the
    > > > different ways to check versions in Koha plugins.
    > > 
    > > The big problem is we've never defined how plugin versioning works. That
    > > being said, I think it's pretty safe to assume semver. In fact, it would be
    > > nice to get that set as a community standard. If we can assume semantic
    > > versioning, everything because much easier!
    > 
    > We should definitely have something similar to the qa tools, checking this.
    > I already pass my plugin commits through the qa command before pushing :-D
    > Maybe we can add a --plugin param to the command and start checking this
    > annoyances.
    
    Sounds good to me! We could have Koha report invalid semver versions on the
    plugins page as well.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 16:56:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 14:56:30 +0000
    Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in
     plugins
    In-Reply-To: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29008-70-AF02L2hdX2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008
    
    --- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    (In reply to Kyle M Hall from comment #13)
    > (In reply to Tomás Cohen Arazi from comment #12)
    > > (In reply to Kyle M Hall from comment #10)
    > > > (In reply to Martin Renvoize from comment #9)
    > > > > I've added Kyle and Tomas as CC's here to get their thoughts around the
    > > > > different ways to check versions in Koha plugins.
    > > > 
    > > > The big problem is we've never defined how plugin versioning works. That
    > > > being said, I think it's pretty safe to assume semver. In fact, it would be
    > > > nice to get that set as a community standard. If we can assume semantic
    > > > versioning, everything because much easier!
    > > 
    > > We should definitely have something similar to the qa tools, checking this.
    > > I already pass my plugin commits through the qa command before pushing :-D
    > > Maybe we can add a --plugin param to the command and start checking this
    > > annoyances.
    > 
    > Sounds good to me! We could have Koha report invalid semver versions on the
    > plugins page as well.
    
    I like your thinking!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 17:13:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 15:13:26 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-DRYucctCbi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133161|0                           |1
            is obsolete|                            |
    
    --- Comment #47 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133170
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133170&action=edit
    Bug 27783: Add --job-type to background_jobs_worker.pl
    
    This will let sysop adjust the number of workers and how they want to
    manage them.
    For instance one could want to have one worker for ES indexation and
    another worker for other jobs, to prevent ES index to be stuck behind
    bigger batch process.
    
    Signed-off-by: Arthur Suzuki <arthur.suzuki at biblibre.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 17:13:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 15:13:30 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-dh60Yig7Vx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133162|0                           |1
            is obsolete|                            |
    
    --- Comment #48 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133171
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133171&action=edit
    Bug 27783: Replace --job-type by --queue
    
    This patch adds a new column background_jobs.queue, which default to
    'default'
    By default, new jobs are enqueued into this default queue, and the
    background job worker will subscribe to the default queue unless told
    otherwise by the --job-queue option
    
    The new job UpdateElasticIndex is automatically enqueued in another
    queue named 'index'
    So you can have 'default' worker with
        misc/background_jobs_worker.pl
    and a dedicated indexing worker with
        misc/background_jobs_worker.pl --queue index
    
    This is to address bug 27344 comment #15
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 17:13:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 15:13:35 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-G9PhFFkuhM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133163|0                           |1
            is obsolete|                            |
    
    --- Comment #49 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133172
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133172&action=edit
    Bug 27783: Add missing atomicupdate file
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 17:13:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 15:13:39 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-Zc4D8TCCNx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133164|0                           |1
            is obsolete|                            |
    
    --- Comment #50 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133173
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133173&action=edit
    Bug 27783: (follow-up) Add DB change to installer
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 17:13:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 15:13:44 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-ycXThdaHXP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133165|0                           |1
            is obsolete|                            |
    
    --- Comment #51 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133174
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133174&action=edit
    Bug 27783: Rename queues and adjust currently defined jobs
    
    This patch renames the queues so the default is the **real-time** one, and
    the other (*long_tasks*) is kept for **long running** tasks.
    
    All current *batch* tasks are explicitly assigned to the **long_tasks**
    queue as well.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 17:13:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 15:13:48 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-jg1Wagjjyy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133166|0                           |1
            is obsolete|                            |
    
    --- Comment #52 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133175
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133175&action=edit
    Bug 27783: (QA follow-up) Make dbrev idempotent
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 17:13:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 15:13:53 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-LzzGKy5eD7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133167|0                           |1
            is obsolete|                            |
    
    --- Comment #53 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133176
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133176&action=edit
    Bug 27783: DBIC update [DO NOT PUSH]
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 17:13:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 15:13:57 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-u0w9bdfk4d@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133168|0                           |1
            is obsolete|                            |
    
    --- Comment #54 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133177
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133177&action=edit
    Bug 27783: Add queue handling in packaging tools
    
    This patch adds queue name handling in is_worker_running and a handy
    method to centralize process name handling for queue-specific workers.
    
    To test:
    1. Apply this patch
    2. Run:
       $ source debian/scripts/koha-functions.sh
       $ get_worker_name kohadev
       kohadev-koha-worker
    => SUCCESS: Default queue means no queue name included
       $ get_worker_name kohadev default
       kohadev-koha-worker
    => SUCCESS: Default queue means no queue name included
       $ get_worker_name kohadev long_tasks
       kohadev-koha-worker-long_tasks
    => SUCCESS: Queue name appended to the name
    4. Run:
       $ perl misc4dev/cp_debian_files.pl \
                  --koha_dir /kohadevbox/koha \
                  --gitify /kohadevbox/gitify \
                  --instance kohadev
    5. Run:
       $ koha-worker --start --queue oleonard kohadev
    => SUCCESS: Starts!
    6. Check:
       $ ps waux | grep oleonard
    => SUCCESS: It is running
    7. Play with --stop, --restart, --status and different queue names,
       including 'default' and without the --queue param as well.
    => SUCCESS: All as expected!
    8. Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 17:14:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 15:14:02 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-NP9fSbFZAB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133169|0                           |1
            is obsolete|                            |
    
    --- Comment #55 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133178
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133178&action=edit
    Bug 27783: (QA follow-up) Make dbrev executable
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 17:14:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 15:14:07 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-CBldiCTWqf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    --- Comment #56 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133179
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133179&action=edit
    Bug 27783: (follow-up) Rename options
    
    Why require `job_`.. it's easiery to just use 'queue' and we have 'job'
    from the context of the script we're calling.  This also inproves
    consistency between the debian commands and the script params.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 17:17:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 15:17:24 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-3gVmXTMCP2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    --- Comment #57 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Just another QA stamp here having re-tested the set.
    
    This gives us two workers by default, one working through long-running tasks
    sequentially and the second working through short running tasks sequentially..
    thus we can now work on short and long tasks in parallel and not cause hold-ups
    with a short running task waiting on a long-running one.
    
    This gets us a good way towards where we want to be eventually with a
    configurable manager daemon with a config file and self spawning workers as
    Davids config file approach mentioned above suggests.. this is a great interim
    measure though for now and allows us to continue working on tasks whilst we
    consider the options for implementing such a manager daemon. (Job dependencies
    and things will need to be added too to allow for such a manager system to
    work).
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 17:34:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 15:34:20 +0000
    Subject: [Koha-bugs] [Bug 19814] Batch Check-in function
    In-Reply-To: <bug-19814-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-19814-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-19814-70-xM076D1y1s@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814
    
    Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |marjorie.barry-vila at collect
                       |                            |o.ca
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 17:34:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 15:34:26 +0000
    Subject: [Koha-bugs] [Bug 30410] Add a way for plugins to register
     background tasks
    In-Reply-To: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30410-70-M0wvVWkyRA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132814|0                           |1
            is obsolete|                            |
    
    --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133180
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133180&action=edit
    Bug 30410: Unit tests
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 17:34:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 15:34:30 +0000
    Subject: [Koha-bugs] [Bug 30410] Add a way for plugins to register
     background tasks
    In-Reply-To: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30410-70-ozwloRqrUO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132815|0                           |1
            is obsolete|                            |
    
    --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133181
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133181&action=edit
    Bug 30410: Add a way for plugins to expose tasks they implement
    
    This patch implements a mechanism for plugins to tell Koha they
    implement background jobs, by returning a mapping
    
    ```
        task => class
    ```
    
    * _task_ is a string that will be used when queueing new tasks, to let
      the workers know which class to instantiate to launch the job (a.k.a.
      process).
    
    * _class_ is a string for a class name.
    
    For this to  work, plugins need to include the 'namespace' attribute in
    their metadata. If they don't, they will be skipped when listing the
    valid _background jobs_.
    
    After this, high-level methods for letting plugins (easily) enqueue
    their tasks will be provided.
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Plugins/BackgroundJob.t
    => SUCCESS: Tests pass!
    3. Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 17:35:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 15:35:11 +0000
    Subject: [Koha-bugs] [Bug 30410] Add a way for plugins to register
     background tasks
    In-Reply-To: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30410-70-QHg3Yydg5d@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Nice clear code and gives us a great way to develop background tasks.
    
    All works as expected, Signing off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 17:35:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 15:35:25 +0000
    Subject: [Koha-bugs] [Bug 30509] New: Accordion on letter.tt is broken
    Message-ID: <bug-30509-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30509
    
                Bug ID: 30509
               Summary: Accordion on letter.tt is broken
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Notices
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: lucas at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
    
    At '/cgi-bin/koha/tools/letter.pl' the accordion for changing between Email,
    Print, SMS notice templates is broken. All of the templates are showing at the
    same time.
    
    It looks to be related to a JS error coming from letter.js:
    
    Uncaught TypeError: t.find(...).even is not a function
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 17:45:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 15:45:00 +0000
    Subject: [Koha-bugs] [Bug 30473] Convert suggestions page tabs to Bootstrap
    In-Reply-To: <bug-30473-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30473-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30473-70-iHrkg11f4E@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30473
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lucas at bywatersolutions.com
    
    --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
    Everything works as described. I have no very minor complaint:
    
    Before the patch there is some padding-top of the UI tabs which gives them a
    little bit of space after the select dropdown. ( #branchcode )
    
    With the patch there is no padding and the select dropdown sits right on top of
    the tabs.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 17:49:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 15:49:52 +0000
    Subject: [Koha-bugs] [Bug 30473] Convert suggestions page tabs to Bootstrap
    In-Reply-To: <bug-30473-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30473-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30473-70-UeV8VSDOFn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30473
    
    --- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> ---
    (In reply to Lucas Gass from comment #2)
    > Everything works as described. I have no very minor complaint:
    > 
    > Before the patch there is some padding-top of the UI tabs which gives them a
    > little bit of space after the select dropdown. ( #branchcode )
    > 
    > With the patch there is no padding and the select dropdown sits right on top
    > of the tabs.
    
    It's a very nit-picky problem and not enough to 'Fail QA' imo, so I am signing
    off.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 17:50:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 15:50:35 +0000
    Subject: [Koha-bugs] [Bug 30473] Convert suggestions page tabs to Bootstrap
    In-Reply-To: <bug-30473-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30473-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30473-70-JmuFRzvpgX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30473
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 17:50:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 15:50:38 +0000
    Subject: [Koha-bugs] [Bug 30473] Convert suggestions page tabs to Bootstrap
    In-Reply-To: <bug-30473-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30473-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30473-70-55iBFaW60U@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30473
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133044|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> ---
    Created attachment 133182
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133182&action=edit
    Bug 30473: Convert suggestions page tabs to Bootstrap
    
    This patch updates the suggestions page to use Bootstrap tabs
    instead of jQueryUI.
    
    To test you should have multiple suggestions from different libraries,
    different item types, and different statuses.
    
    Apply the patch and go to Suggestions.
    
    - Suggestions should initially be displayed in tabs by status.
    - Confirm that the tabs look correct and work correctly.
    - Test that tabs work correctly for each option in the "Organize by"
      dropdown in the left-hand sidebar.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 18:22:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 16:22:37 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-Ov61GnYWzR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132078|0                           |1
            is obsolete|                            |
    
    --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133183
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133183&action=edit
    Bug 29346: Refactor loop code into a subroutine
    
    The CreateQueue() method deletes the holds queue data, fetches some
    configuration (branches to use, transport cost matrix) and then loops
    through a list of biblionumbers, generating the tmp_holdsqueue and
    hold_fill_targets rows for the specified biblio.
    
    This patch simply moves that last bit that is run inside the biblios
    loop into a separate sub.
    
    The update_queue_for_biblio sub is designed so it does the exact same
    thing it did inside the loop, but also gets added the capability of
    querying those parameters if not passed, and it also gets a 'delete'
    parameter so it deletes the biblio-specific holds queue rows before
    starting to work.
    
    This way, it can be reused to write a background job for real-time holds
    queue update :-D
    
    To test:
    1. Run:
       $ kshell
      k$ prove t/db_dependent/HoldsQueue.t
    => SUCCESS: Tests pass!
    2. Apply this patch
    3. Repeat 1
    => SUCCESS: Tests still pass! Behavior is kept!
    4. Sign off :-D
    
    Sponsored-by: Montgomery County Public Libraries
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 18:22:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 16:22:42 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-e3qH0Rkq00@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132079|0                           |1
            is obsolete|                            |
    
    --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133184
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133184&action=edit
    Bug 29346: Add holds queue update background job
    
    This patch adds a background job that takes care of updating the holds
    queue rows for a given list of biblios.
    
    It is designed to be used for real-time batch updating the holds queue
    when required. Tasks would be added by the relevant methods under the
    right use cases.
    
    Sponsored-by: Montgomery County Public Libraries
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 18:22:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 16:22:46 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-WO1DKwQmlw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132080|0                           |1
            is obsolete|                            |
    
    --- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133185
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133185&action=edit
    Bug 29346: Hold actions triggers
    
    This patch makes several holds related actions schedule the background
    job for real-time update of the holds queue.
    
    This actions are:
    
    - place (C4::Reserves::AddReserve)
    - fill (Koha::Hold->fill)
    - cancel (Koha::Hold->cancel)
    - suspend (Koha::Hold->suspend)
    - resume (Koha::Hold->resume)
    
    The cancel() action is added a *skip_holds_queue* parameter to skip
    triggering the background job entirely. It targets cases like
    C4::Biblio::DelBiblio in which all biblio holds are cancelled in a loop.
    In that case, we just want to cancel them and let a single backgroung
    job take care of the holds queue, once the biblio is deleted.
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Hold.t \
               t/db_dependent/Reserves.t
    => SUCCESS: Tests pass! Triggers are triggered
    3. Sign off :-D
    
    Sponsored-by: Montgomery County Public Libraries
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 18:22:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 16:22:51 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-kYinzR2G7C@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132081|0                           |1
            is obsolete|                            |
    
    --- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133186
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133186&action=edit
    Bug 29346: Circulation actions triggers
    
    This patch introduces triggers for real-time updating the holds queue at
    check out and check in.
    
    The following high-level methods are involved:
    
    - C4::Circulation::AddIssue
    - C4::Circulation::AddReturn
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Circulation_holdsqueue.t
    => SUCCESS: Tests pass! Triggers are triggered
    3. Sign off :-D
    
    Note: I put the tests on a separate file because the other one was too
    big already.
    
    Sponsored-by: Montgomery County Public Libraries
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 18:22:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 16:22:57 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-rKigilqWTo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132082|0                           |1
            is obsolete|                            |
    
    --- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133187
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133187&action=edit
    Bug 29346: Biblio actions triggers
    
    This patch adds the trigger for the holds queue update on teh following
    methods:
    
    - C4::Biblio::DelBiblio
    - C4::Biblio::ModBiblio
    
    The ModBiblio use case could be improved by checking if itemtype is one
    of the updated attributes... but it felt there was no way to do it
    without some overhead. So I leave it as-is.
    
    It also mocks the ->enqueue method in the tests that call DelBiblio and
    ModBiblio to avoid breakages [1]
    
    Tests are added to check the trigger is called.
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Biblio.t
    => SUCCESS: Tests pass! It means the trigger is triggered :-D
    3. Sign off :-D
    
    [1] This breakages could be avoided if we solve Koha/BackgrounJob.pm:101
    FIXME.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 18:23:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 16:23:01 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-evzYSbaG6T@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132083|0                           |1
            is obsolete|                            |
    
    --- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133188
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133188&action=edit
    Bug 29346: Item action trigger
    
    This patch makes the following actions trigger a holds queue rebuild for
    the related biblio:
    
    - Adding an item
    - Updating an item
    - Deleting an item
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Item.t
    => SUCCESS: Tests pass! Background job scheduled
    3. Sign off :-D
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 18:23:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 16:23:06 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-DaJpFXCjJm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133189
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133189&action=edit
    Bug 29346: (follow-up) Fix typo
    
    We set biblio_ids in enqueue then referred to biblio_id in process ;)
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 18:23:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 16:23:11 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-LUkas4Y1Qf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133190
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133190&action=edit
    Bug 29346: (follow-up) Fix import issue in HoldsQueue
    
    For some reason `t/db_dependent/HoldsQueue..t` starts failing for me
    without this patch.. using the full module path resolves the issue but
    I'd love to understand why/how this creeps in.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 18:23:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 16:23:15 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-oV4OPDOuIo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133191
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133191&action=edit
    Bug 29346: FIXME: Highlight double enqueue
    
    This patch highlights a possible issue with the triggers.. though it may
    not actually matter in reality.
    
    I appear to already see test failures before this patch with a double
    enqueue of the rebuild for both AddIssue and AddReturn.. I couldn't spot
    what was causing that but whilst digging I did find another case where
    it could happen as highlighted here...
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 18:25:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 16:25:49 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-jXRPWwpVUA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    This is cool.. and mostly appears to work in testing.
    
    I've added a few tiny follow-ups to fix things I found whilst running the
    tests.. not idea where the imports get a bit confused and require that second
    fix though.
    
    As for the third patch, it highlights a case I think we may need to deal with..
    we're already getting double enqueued on AddIssue and AddReturn (I reckon the
    test passed before we added the next patches that add triggers to ModBiblio and
    ModItem).. they now double trigger for these cases.. or even triple trigger in
    certainly preference setups.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 18:30:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 16:30:25 +0000
    Subject: [Koha-bugs] [Bug 30473] Convert suggestions page tabs to Bootstrap
    In-Reply-To: <bug-30473-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30473-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30473-70-DB9x4pyA61@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30473
    
    --- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
    (In reply to Lucas Gass from comment #2)
    
    > With the patch there is no padding and the select dropdown sits right on top
    > of the tabs.
    
    The fix for this is in Bug 30466. I didn't make them dependent because it's
    such a small thing.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 18:35:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 16:35:09 +0000
    Subject: [Koha-bugs] [Bug 30509] Accordion on letter.tt is broken
    In-Reply-To: <bug-30509-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30509-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30509-70-yEBxfvl3CT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30509
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |ASSIGNED
             Depends on|                            |30011
               Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                       |ity.org                     |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011
    [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 18:35:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 16:35:09 +0000
    Subject: [Koha-bugs] [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and
     staff interface
    In-Reply-To: <bug-30011-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30011-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30011-70-3zl3KoQWo0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30509
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30509
    [Bug 30509] Accordion on letter.tt is broken
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 18:48:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 16:48:05 +0000
    Subject: [Koha-bugs] [Bug 30360] Add helper methods to Koha::BackgroundJobs
    In-Reply-To: <bug-30360-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30360-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30360-70-PpqjyLnIce@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360
    
    --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Looking forward to this one :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 18:49:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 16:49:47 +0000
    Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in
     plugins
    In-Reply-To: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29008-70-G6a5snQi8S@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008
    
    --- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    This is all very cool thoughts.. but this bug is more around dealing with Koha
    version comparisons than it is about Plugin versioning ;).
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 18:57:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 16:57:16 +0000
    Subject: [Koha-bugs] [Bug 30410] Add a way for plugins to register
     background tasks
    In-Reply-To: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30410-70-YxU2Go5Bou@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 18:57:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 16:57:19 +0000
    Subject: [Koha-bugs] [Bug 30410] Add a way for plugins to register
     background tasks
    In-Reply-To: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30410-70-7ouLKQph5V@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133180|0                           |1
            is obsolete|                            |
     Attachment #133181|0                           |1
            is obsolete|                            |
    
    --- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Created attachment 133192
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133192&action=edit
    Bug 30410: Unit tests
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 18:57:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 16:57:53 +0000
    Subject: [Koha-bugs] [Bug 30410] Add a way for plugins to register
     background tasks
    In-Reply-To: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30410-70-ilz0ejI7sE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410
    
    --- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Created attachment 133193
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133193&action=edit
    Bug 30410: Add a way for plugins to expose tasks they implement
    
    This patch implements a mechanism for plugins to tell Koha they
    implement background jobs, by returning a mapping
    
    ```
        task => class
    ```
    
    * _task_ is a string that will be used when queueing new tasks, to let
      the workers know which class to instantiate to launch the job (a.k.a.
      process).
    
    * _class_ is a string for a class name.
    
    For this to  work, plugins need to include the 'namespace' attribute in
    their metadata. If they don't, they will be skipped when listing the
    valid _background jobs_.
    
    After this, high-level methods for letting plugins (easily) enqueue
    their tasks will be provided.
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Plugins/BackgroundJob.t
    => SUCCESS: Tests pass!
    3. Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 18:57:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 16:57:57 +0000
    Subject: [Koha-bugs] [Bug 30410] Add a way for plugins to register
     background tasks
    In-Reply-To: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30410-70-S3EUZL4ril@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410
    
    --- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Created attachment 133194
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133194&action=edit
    Bug 30410: (QA follow-up) Pluralise new methods, fix minor issues with language
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 19:03:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 17:03:06 +0000
    Subject: [Koha-bugs] [Bug 30410] Add a way for plugins to register
     background tasks
    In-Reply-To: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30410-70-SNXZiQpxFO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410
    
    --- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Created attachment 133195
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133195&action=edit
    Bug 30410: (QA follow-up) Only fetch plugins mapping once
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 19:07:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 17:07:27 +0000
    Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in
     plugins
    In-Reply-To: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29008-70-pDn682w7pj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008
    
    --- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
    (In reply to Martin Renvoize from comment #15)
    > This is all very cool thoughts.. but this bug is more around dealing with
    > Koha version comparisons than it is about Plugin versioning ;).
    
    Good point. I think these patches are fine as they are. Again, we could report
    of the passed in Koha version is non-semver, but in this case it's even less of
    an issue.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 19:08:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 17:08:01 +0000
    Subject: [Koha-bugs] [Bug 30509] Accordion on letter.tt is broken
    In-Reply-To: <bug-30509-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30509-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30509-70-ZSNW5oU1OJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30509
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
       Patch complexity|---                         |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 19:08:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 17:08:05 +0000
    Subject: [Koha-bugs] [Bug 30509] Accordion on letter.tt is broken
    In-Reply-To: <bug-30509-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30509-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30509-70-nijUmsjTzG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30509
    
    --- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133196
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133196&action=edit
    Bug 30509: Fix configuration of Notices accordion widget
    
    The jQueryUI upgrade broke the Accordion on the notices edit page. I'm
    not sure why, but defining a "header" option in the accordion
    configuration fixes it.
    
    To test, apply the patch and test the notices edit page both with and
    without TranslateNotices and multiple languages installed. In both cases
    the different sections (Email, Print, SMS) should open and close
    correctly.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 19:31:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 17:31:57 +0000
    Subject: [Koha-bugs] [Bug 30509] Accordion on letter.tt is broken
    In-Reply-To: <bug-30509-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30509-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30509-70-FNq6yQSw0w@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30509
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 19:32:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 17:32:01 +0000
    Subject: [Koha-bugs] [Bug 30509] Accordion on letter.tt is broken
    In-Reply-To: <bug-30509-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30509-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30509-70-XIv00dtCWE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30509
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133196|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
    Created attachment 133197
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133197&action=edit
    Bug 30509: Fix configuration of Notices accordion widget
    
    The jQueryUI upgrade broke the Accordion on the notices edit page. I'm
    not sure why, but defining a "header" option in the accordion
    configuration fixes it.
    
    To test, apply the patch and test the notices edit page both with and
    without TranslateNotices and multiple languages installed. In both cases
    the different sections (Email, Print, SMS) should open and close
    correctly.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 19:35:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 17:35:30 +0000
    Subject: [Koha-bugs] [Bug 30466] Convert serials pages tabs to Bootstrap
    In-Reply-To: <bug-30466-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30466-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30466-70-wQETDwEVCw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Patch doesn't apply
                     CC|                            |lucas at bywatersolutions.com
    
    --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
    I think because of Bug 29609 this one no longer cleanly applies to master.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 20:44:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 18:44:12 +0000
    Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying
     types in put mapping requests is deprecated (incompatible with 7)
    In-Reply-To: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25669-70-Vo7u8MLzqd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669
    
    --- Comment #28 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    > In that case I think it would be possible to avoid checking the ES version
    
    Even if someone wants to support ES 8, no version check is needed for this?
    Maybe your last paragraph actually is about this and we can't have ES 6 to 8
    support without check?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 21:09:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 19:09:54 +0000
    Subject: [Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap
     (amount) results in data loss
    In-Reply-To: <bug-30346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30346-70-mXJWbDj4rd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |andrew at bywatersolutions.com
    
    --- Comment #1 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    +1, unexpected changes to circ & fine rules are exceptionally unwelcome.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 21:10:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 19:10:09 +0000
    Subject: [Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap
     (amount) results in data loss and extra fines
    In-Reply-To: <bug-30346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30346-70-11mMApB9oC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Editing circ rule with      |Editing circ rule with
                       |Overdue fines cap (amount)  |Overdue fines cap (amount)
                       |results in data loss        |results in data loss and
                       |                            |extra fines
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 21:34:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 19:34:51 +0000
    Subject: [Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap
     (amount) results in data loss and extra fines
    In-Reply-To: <bug-30346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30346-70-3WlJr8ahGQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lucas at bywatersolutions.com
    
    --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
    This is because we are erroneously trying get the value from the 'Cap fine at
    replacement price' column which is a checked or not checked value. 
    
    When we go through each of the columns we copy the current values over. There
    is a line like:
    
    else if ( i == 15 ) 
    
    And that is wrong.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 21:39:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 19:39:30 +0000
    Subject: [Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap
     (amount) results in data loss and extra fines
    In-Reply-To: <bug-30346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30346-70-KZtndYJfzw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 21:39:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 19:39:35 +0000
    Subject: [Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap
     (amount) results in data loss and extra fines
    In-Reply-To: <bug-30346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30346-70-hoGgk7AMLk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346
    
    --- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> ---
    Created attachment 133198
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133198&action=edit
    Bug 30346: Correctly transfer values when editing rules
    
    To test:
    --Create a circulation rule with a value in "Overdue fines cap (amount), or
    edit an existing rule to add it
    -Save the new (or edited) rule.
    -Edit the same rule again to change any other field. Note that "Overdue fines
    cap (amount)" is now blank
    -Save your edited rule - "Overdue fines cap (amount)" will save as blank.
    
    Apply patch
    
    --Create a circ rule with a value in Overdue fines cap (amount) and check "Cap
    fine at replacement price" for that same rule.
    -Save the rule
    -Try ediding the rule and make sure both of those values now save correctly.
    -Add several more rules and try playing with both "Cap fine at replacement
    price" and "Overdue fines cap (amount)". Make sure everything saves right.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 21:39:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 19:39:52 +0000
    Subject: [Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap
     (amount) results in data loss and extra fines
    In-Reply-To: <bug-30346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30346-70-Tzb2GXR6dg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Version|21.05                       |master
               Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                       |ity.org                     |
       Patch complexity|---                         |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 21:41:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 19:41:56 +0000
    Subject: [Koha-bugs] [Bug 29610] "Cap fine at replacement price" un-checks
     when circulation rule is edited
    In-Reply-To: <bug-29610-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29610-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29610-70-P1rfdvAv4A@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29610
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lucas at bywatersolutions.com
    
    --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
    The fix for this is tied into the fix for Bug 30346.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 22:06:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 20:06:54 +0000
    Subject: [Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap
     (amount) results in data loss and extra fines
    In-Reply-To: <bug-30346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30346-70-wJD537El58@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 22:06:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 20:06:58 +0000
    Subject: [Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap
     (amount) results in data loss and extra fines
    In-Reply-To: <bug-30346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30346-70-HDWBr6AAvb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133198|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Created attachment 133199
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133199&action=edit
    Bug 30346: Correctly transfer values when editing rules
    
    To test:
    --Create a circulation rule with a value in "Overdue fines cap (amount), or
    edit an existing rule to add it
    -Save the new (or edited) rule.
    -Edit the same rule again to change any other field. Note that "Overdue fines
    cap (amount)" is now blank
    -Save your edited rule - "Overdue fines cap (amount)" will save as blank.
    
    Apply patch
    
    --Create a circ rule with a value in Overdue fines cap (amount) and check "Cap
    fine at replacement price" for that same rule.
    -Save the rule
    -Try ediding the rule and make sure both of those values now save correctly.
    -Add several more rules and try playing with both "Cap fine at replacement
    price" and "Overdue fines cap (amount)". Make sure everything saves right.
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 22:09:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 20:09:40 +0000
    Subject: [Koha-bugs] [Bug 19814] Batch Check-in function
    In-Reply-To: <bug-19814-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-19814-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-19814-70-rT8GaQaZVI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814
    
    Noémie Labine <noemie.labine at collecto.ca> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |noemie.labine at collecto.ca
    
    --- Comment #26 from Noémie Labine <noemie.labine at collecto.ca> ---
    +1 !
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 22:39:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 20:39:44 +0000
    Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
    In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-12446-70-jElwjOGCJc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Failed QA
    
    --- Comment #178 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Your schema update patch has some merge markers in it and causes Koha to
    explode when I try to reset_all after applying the patch to my testing docker.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 23:35:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 21:35:23 +0000
    Subject: [Koha-bugs] [Bug 30510] New: Add a Patron reason column to the
     suggestion tables on suggestion.tt
    Message-ID: <bug-30510-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30510
    
                Bug ID: 30510
               Summary: Add a Patron reason column to the suggestion tables on
                        suggestion.tt
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Acquisitions
              Assignee: lucas at bywatersolutions.com
              Reporter: lucas at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
    
    On /cgi-bin/koha/suggestion/suggestion.pl there are several tables for
    Suggestions management. Some librarians would find it helpful if there was a
    column here showing the patron's reason for suggestion from the authorized
    value OPAC_SUG.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 23:38:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 21:38:54 +0000
    Subject: [Koha-bugs] [Bug 30237] Rename/rephrase
     AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use
    In-Reply-To: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30237-70-ghetApAsT9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237
    
    --- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    (In reply to Martin Renvoize from comment #21)
    > Created attachment 133159 [details] [review]
    > Bug 30237: (follow-up) Make LibraryName conditional
    > 
    > It's easy to forget to set the LibraryName preference.. as such we can
    > make this a conditional and fall back to a default of 'the library'.
    
    Ah, I expected the name of the branch, should have read the notice template
    more carefully. It certainly was the missing pref then.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 23:43:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 21:43:54 +0000
    Subject: [Koha-bugs] [Bug 30510] Add a Patron reason column to the
     suggestion tables on suggestion.tt
    In-Reply-To: <bug-30510-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30510-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30510-70-lAVTKt3VAF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30510
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 11 23:43:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 21:43:57 +0000
    Subject: [Koha-bugs] [Bug 30510] Add a Patron reason column to the
     suggestion tables on suggestion.tt
    In-Reply-To: <bug-30510-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30510-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30510-70-DB6jrNsYRD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30510
    
    --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
    Created attachment 133200
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133200&action=edit
    Bug 30510: Add Patron reason column to suggestion tables
    
    To test:
    1. Make some patron reasons for suggestion via Home > Administration >
    Authorized values > OPAC_SUG
    2. Give those reasons a description.
    3. Make several suggestions via staff client and/or OPAC and apply some of the
    reasons you just made
    4. Apply patch
    5. Go to Home > Acquistions > Suggestions management
    6. Give some of the suggestions some different status
    (PENDING/REJECTED/ACCEPTED/ect)
    7. Make sure on each of the tables you can see the column 'Patron reason'
    8. Go to Administration > Table settings and attempt to hide the column.
    9. Confirm that the column is properly hidden on the Suggestions management
    page
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 00:51:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 22:51:57 +0000
    Subject: [Koha-bugs] [Bug 30204] Add subtitle to serial subscription search
    In-Reply-To: <bug-30204-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30204-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30204-70-dvNDkM7UCK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132981|0                           |1
            is obsolete|                            |
    
    --- Comment #7 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Created attachment 133201
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133201&action=edit
    Bug 30204: Add unit test
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 00:52:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 22:52:02 +0000
    Subject: [Koha-bugs] [Bug 30204] Add subtitle to serial subscription search
    In-Reply-To: <bug-30204-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30204-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30204-70-Btl96Y8odR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132907|0                           |1
            is obsolete|                            |
    
    --- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Created attachment 133202
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133202&action=edit
    Bug 30204: Add subtitle to serial search results
    
    To test:
    1. Make some new serial subscriptions and connect them to biblios that contain
    subtitles.
    2. Do a serial search that will return your newly created subscription.
    3. Notice the subtitle doesn't appear.
    4. Apply patch and restart_all
    5. Again try step 2.
    6. Notice the subtitle appears alongside the title now.
    7. Make sure it still sorts that column correctly.
    
    Signed-off-by: shiyao <shiyao at inlibro.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 00:52:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 22:52:46 +0000
    Subject: [Koha-bugs] [Bug 30204] Add subtitle to serial subscription search
    In-Reply-To: <bug-30204-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30204-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30204-70-dlUqDrluLH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |victor at tuxayo.net
                 Status|Signed Off                  |Passed QA
    
    --- Comment #9 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Works, qa script happy, code looks good, passing QA :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 01:21:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 23:21:50 +0000
    Subject: [Koha-bugs] [Bug 28498] Add CLI counterpart for plugin actions
    In-Reply-To: <bug-28498-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28498-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28498-70-UePLxdLaP5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28498
    
    --- Comment #7 from David Cook <dcook at prosentient.com.au> ---
    (In reply to Tomás Cohen Arazi from comment #6)
    > I like baby steps. We should add the features to some script(s) and then we
    > teach them to read from a config file.
    
    Sounds like a plan to me. If the logic is in a module, then it should be
    trivial  controlling the module from either CLI args or a config file I reckon. 
    
    I've been revising my TODO list, and while this functionality has fallen down
    the list, it's still something I would still like to have. Happy to test
    patches on this one.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 01:42:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 11 Apr 2022 23:42:23 +0000
    Subject: [Koha-bugs] [Bug 28498] Add CLI counterpart for plugin actions
    In-Reply-To: <bug-28498-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28498-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28498-70-25PReX8zA3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28498
    
    --- Comment #8 from David Cook <dcook at prosentient.com.au> ---
    (In reply to Martin Renvoize from comment #5)
    > This would be great.. we do have
    > https://git.koha-community.org/Koha-community/Koha/src/branch/master/misc/
    > devel/install_plugins.pl of course.. but having a package friendly debian
    > script with all the options described here would be much nicer.
    
    I didn't used to understand this script, but I think I understand it better
    now...
    
    I suppose a person could add a "pluginsdir" that points to a central location
    of curated plugins and then run this script to install them across the board.
    Or symlink from /var/lib/koha/<instance>/plugins/Koha/Plugins/<plugin>.
    
    We don't really use plugins except for one or two here or there, but I wonder
    sometimes if we would use them more if it were easier to install en masse. And
    maybe it has been and I just haven't been creative enough... ;)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 02:00:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 00:00:45 +0000
    Subject: [Koha-bugs] [Bug 25222] Add ability to let plugins live in
     individual subdirectories
    In-Reply-To: <bug-25222-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25222-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25222-70-nWPcDUIezv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222
    
    --- Comment #15 from David Cook <dcook at prosentient.com.au> ---
    I don't have anything to ad from a QA perspective... but I'm intrigued by this
    one!
    
    In Discourse, the named plugins go into /var/www/discourse/plugins, so you wind
    up with something like /var/www/discourse/plugins/discourse-jwt/plugin.rb
    (https://github.com/discourse/discourse-jwt). I found it super convenient.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 02:54:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 00:54:17 +0000
    Subject: [Koha-bugs] [Bug 28507] Create Koha::Session wrapper to create
     consistent sessions throughout Koha
    In-Reply-To: <bug-28507-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28507-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28507-70-dxOsDOmI4P@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28507
    
    --- Comment #3 from David Cook <dcook at prosentient.com.au> ---
    Actually, I think the key thing is having Koha::Session enforce a number of
    mandatory session variables.
    
    After reviewing C4::Auth::check_api_auth(), C4::Auth::checkauth(),
    C4::InstallAuth::checkauth(), the required keys for an authenticated user
    appear to be:
    
    - number
    - id
    - cardnumber
    - firstname
    - surname
    - branch
    - branchname
    - flags
    - emailaddress
    - ip 
    - lasttime
    - interface (not set by C4::InstallAuth::checkauth() but is by the other 2)
    
    C4::Auth::checkauth() also sets "search_history", "desk_id", "desk_name",
    "shibboleth", "register_id", "register_name", "sco_user", and "cas_ticket". 
    
    C4::Auth::check_api_auth() also sets "cas_ticket".
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 04:20:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 02:20:51 +0000
    Subject: [Koha-bugs] [Bug 30511] New: Don't lock entire database when
     dumping Koha instance
    Message-ID: <bug-30511-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30511
    
                Bug ID: 30511
               Summary: Don't lock entire database when dumping Koha instance
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Command-line Utilities
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: alexbuckley at catalyst.net.nz
            QA Contact: testopia at bugs.koha-community.org
                    CC: robin at catalyst.net.nz
    
    koha-dump should use the --single-transaction flag, like
    misc/cronjobs/backup.sh does. This is to avoid koha-dump locking up the whole
    database.
    
    More information on the single-transaction flag can be found here:
    https://dev.mysql.com/doc/refman/5.7/en/mysqldump.html#option_mysqldump_single-transaction
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 04:22:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 02:22:23 +0000
    Subject: [Koha-bugs] [Bug 30511] Don't lock entire database when dumping
     Koha instance
    In-Reply-To: <bug-30511-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30511-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30511-70-dEKBKENaoO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30511
    
    --- Comment #1 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
    Created attachment 133203
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133203&action=edit
    Bug 30511: Don't lock up entire database while running koha-dump
    
    Test plan:
    1. Apply the patch
    2. Restart services
    3. Run koha-dump
    4. Confirm the .sql.gz and .tar.gz files are generated successfully
    
    Sponsored-by: Catalyst IT
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 04:22:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 02:22:47 +0000
    Subject: [Koha-bugs] [Bug 30511] Don't lock entire database when dumping
     Koha instance
    In-Reply-To: <bug-30511-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30511-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30511-70-0QiQagsyEg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30511
    
    Alex Buckley <alexbuckley at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
      Change sponsored?|---                         |Sponsored
                 Status|NEW                         |Needs Signoff
               Assignee|koha-bugs at lists.koha-commun |alexbuckley at catalyst.net.nz
                       |ity.org                     |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 04:25:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 02:25:28 +0000
    Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from
     UpdateNotForLoanStatusOnCheckin
    In-Reply-To: <bug-25560-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25560-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25560-70-O9yAQ0rPQA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560
    
    --- Comment #46 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
    This patchset still applies cleanly to master and is ready for testing if
    someone is available :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 04:27:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 02:27:56 +0000
    Subject: [Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when
     adding/editing items
    In-Reply-To: <bug-29815-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29815-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29815-70-paRddIGW6e@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815
    
    --- Comment #8 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
    This patchset still applies cleanly to master and is ready for testing if
    someone is available :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 04:27:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 02:27:59 +0000
    Subject: [Koha-bugs] [Bug 23352] Define serial's collection in the
     subscription
    In-Reply-To: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23352-70-ey3rDgEgM4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352
    
    --- Comment #43 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
    This patchset still applies cleanly to master and is ready for testing if
    someone is available :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 09:05:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 07:05:45 +0000
    Subject: [Koha-bugs] [Bug 30511] Don't lock entire database when dumping
     Koha instance
    In-Reply-To: <bug-30511-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30511-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30511-70-OcOh9LQTtE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30511
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 09:05:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 07:05:49 +0000
    Subject: [Koha-bugs] [Bug 30511] Don't lock entire database when dumping
     Koha instance
    In-Reply-To: <bug-30511-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30511-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30511-70-rekqa5Agdb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30511
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133203|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from David Cook <dcook at prosentient.com.au> ---
    Created attachment 133204
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133204&action=edit
    Bug 30511: Don't lock up entire database while running koha-dump
    
    Test plan:
    1. Apply the patch
    2. Restart services
    3. Run koha-dump
    4. Confirm the .sql.gz and .tar.gz files are generated successfully
    
    Sponsored-by: Catalyst IT
    
    Signed-off-by: David Cook <dcook at prosentient.com.au>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 09:12:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 07:12:02 +0000
    Subject: [Koha-bugs] [Bug 30511] Don't lock entire database when dumping
     Koha instance
    In-Reply-To: <bug-30511-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30511-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30511-70-qo0IGw5fx3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30511
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |dcook at prosentient.com.au
    
    --- Comment #3 from David Cook <dcook at prosentient.com.au> ---
    I've been using this in production for a while and it's been great.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 09:35:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 07:35:19 +0000
    Subject: [Koha-bugs] [Bug 26777] Give the user the option to display their
     patron card barcode from the OPAC
    In-Reply-To: <bug-26777-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26777-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26777-70-rjzhfS4CMF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777
    
    --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Is this something you're still experimenting with Owen?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 09:47:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 07:47:28 +0000
    Subject: [Koha-bugs] [Bug 1937] Scan barcode with webcam
    In-Reply-To: <bug-1937-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-1937-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-1937-70-dXTLzPLMLY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1937
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
                 Status|CLOSED                      |REOPENED
             Resolution|WONTFIX                     |---
    
    --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    I think this is actually a great idea.. I see it working as a little barcode
    icon in search boxes that allow for barcode entry.. on touching the icon we
    open the camera (best on a mobile in my thinking) and allow one to scan
    barcodes in.
    
    -- 
    You are receiving this mail because:
    You are the QA Contact for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 09:51:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 07:51:04 +0000
    Subject: [Koha-bugs] [Bug 1937] Scan barcode with webcam
    In-Reply-To: <bug-1937-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-1937-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-1937-70-UnRxVUepMw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1937
    
    --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    https://github.com/ericblade/quagga2 appears to be a pretty well respected and
    maintained JS library for doing this.
    
    -- 
    You are receiving this mail because:
    You are the QA Contact for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 10:21:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 08:21:25 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-xcXsMoRcWT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133191|0                           |1
            is obsolete|                            |
    
    --- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133205
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133205&action=edit
    Bug 29346: FIXME: Highlight double enqueue
    
    This patch highlights a possible issue with the triggers.. though it may
    not actually matter in reality.
    
    I appear to already see test failures before this patch with a double
    enqueue of the rebuild for both AddIssue and AddReturn.. I couldn't spot
    what was causing that but whilst digging I did find another case where
    it could happen as highlighted here...
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 10:22:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 08:22:34 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-ba7Zzqxcug@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #31 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Adding caller in the test here is pretty useful for debugging.. you can now see
    which module is calling the enqueue each time :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 10:24:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 08:24:07 +0000
    Subject: [Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 -
     ES7
    In-Reply-To: <bug-25439-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25439-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25439-70-BVJjG6KjOx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439
    
    Mason James <mtj at kohaaloha.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |mtj at kohaaloha.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 10:24:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 08:24:42 +0000
    Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying
     types in put mapping requests is deprecated (incompatible with 7)
    In-Reply-To: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25669-70-WpW36ICCBv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669
    
    Mason James <mtj at kohaaloha.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |mtj at kohaaloha.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 10:26:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 08:26:00 +0000
    Subject: [Koha-bugs] [Bug 28610] Elasticsearch 7 - hits.total is now an
     object
    In-Reply-To: <bug-28610-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28610-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28610-70-0JCgf73uFn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610
    
    Mason James <mtj at kohaaloha.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |mtj at kohaaloha.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:35:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:35:09 +0000
    Subject: [Koha-bugs] [Bug 26370] Add ability to disable demagnetizing items
     via SIP2 for arbitrary patron categories
    In-Reply-To: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26370-70-kHVZsHC5HH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133145|1                           |0
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:35:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:35:30 +0000
    Subject: [Koha-bugs] [Bug 26370] Add ability to disable demagnetizing items
     via SIP2 for arbitrary patron categories
    In-Reply-To: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26370-70-odgKsqFuzH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133144|1                           |0
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:37:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:37:39 +0000
    Subject: [Koha-bugs] [Bug 26019] Koha should set SameSite attribute on
     cookies
    In-Reply-To: <bug-26019-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26019-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26019-70-s5M6YAFW9z@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26019
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
                 Status|Passed QA                   |Patch doesn't apply
    
    --- Comment #19 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Sorry does not apply anymore, maybe because of Bug 29957.
    Please rebase
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:38:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:38:34 +0000
    Subject: [Koha-bugs] [Bug 26370] Add ability to disable demagnetizing items
     via SIP2 for arbitrary patron categories
    In-Reply-To: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26370-70-cnmyUXfNhR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133144|0                           |1
            is obsolete|                            |
    
    --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133206
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133206&action=edit
    Bug 26370: Add ability to disable demagnetizing items via SIP2 for arbitrary
    patron categories
    
    Some libraries have certain patron categories that can only do in house
    checkouts via SIP self check machines.
    In these cases, the items should not be demagnetized since the items cannot
    leave the library.
    
    Test Plan:
    1) Apply this patch
    2) prove t/db_dependent/SIP/Message.t
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:38:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:38:38 +0000
    Subject: [Koha-bugs] [Bug 26370] Add ability to disable demagnetizing items
     via SIP2 for arbitrary patron categories
    In-Reply-To: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26370-70-wTRJrniNKR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133146|0                           |1
            is obsolete|                            |
    
    --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133207
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133207&action=edit
    Bug 26370: (QA follow-up) Rename option never_demagnitize to
    inhouse_patron_categories
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:38:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:38:42 +0000
    Subject: [Koha-bugs] [Bug 26370] Add ability to disable demagnetizing items
     via SIP2 for arbitrary patron categories
    In-Reply-To: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26370-70-8BuHvLT6sx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133145|0                           |1
            is obsolete|                            |
    
    --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133208
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133208&action=edit
    Bug 26370: (QA follow-up) Add new option to templates
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:39:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:39:36 +0000
    Subject: [Koha-bugs] [Bug 26370] Add ability to disable demagnetizing items
     via SIP2 for arbitrary patron categories
    In-Reply-To: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26370-70-3nJYKHIoUh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    This all works as designed and doesn't cause any regressions.
    
    Passing QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:41:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:41:04 +0000
    Subject: [Koha-bugs] [Bug 26244] Move translatable strings out of
     memberentrygen.tt and into JavaScript
    In-Reply-To: <bug-26244-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26244-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26244-70-lkBApgfeJx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26244
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:41:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:41:07 +0000
    Subject: [Koha-bugs] [Bug 26244] Move translatable strings out of
     memberentrygen.tt and into JavaScript
    In-Reply-To: <bug-26244-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26244-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26244-70-AqOdy8Ettn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26244
    
    --- Comment #8 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:41:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:41:10 +0000
    Subject: [Koha-bugs] [Bug 27035] Shows the number of results in a facets
     after facet selection
    In-Reply-To: <bug-27035-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27035-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27035-70-8klRLB5GAj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:41:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:41:14 +0000
    Subject: [Koha-bugs] [Bug 27035] Shows the number of results in a facets
     after facet selection
    In-Reply-To: <bug-27035-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27035-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27035-70-TYIxWueji7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035
    
    --- Comment #15 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:41:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:41:17 +0000
    Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions
    In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29695-70-qKjok0ENG8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:41:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:41:22 +0000
    Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions
    In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29695-70-XEZWABMhls@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695
    
    --- Comment #45 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:41:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:41:27 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: <bug-29810-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29810-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29810-70-pyPflIAksS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:41:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:41:28 +0000
    Subject: [Koha-bugs] [Bug 26370] Add ability to disable demagnetizing items
     via SIP2 for arbitrary patron categories
    In-Reply-To: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26370-70-JGH8xnGb8X@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |This patch adds a new
            released in|                            |option to the SIP config,
                       |                            |`inhouse_patron_categories`
                       |                            |. Adding a comma-separated
                       |                            |list of patron category
                       |                            |codes to this option will
                       |                            |cause the SIP checkout to
                       |                            |never send the
                       |                            |'demagnetize' command to
                       |                            |the checkout preventing
                       |                            |said users from removing
                       |                            |the items from the library.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:41:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:41:30 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: <bug-29810-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29810-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29810-70-rdive7neNt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    --- Comment #65 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:41:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:41:34 +0000
    Subject: [Koha-bugs] [Bug 29957] Cookies not removed after logout
    In-Reply-To: <bug-29957-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29957-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29957-70-JIYS19Au7H@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29957
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:41:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:41:37 +0000
    Subject: [Koha-bugs] [Bug 29957] Cookies not removed after logout
    In-Reply-To: <bug-29957-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29957-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29957-70-0I9W43S8q3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29957
    
    --- Comment #124 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:41:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:41:41 +0000
    Subject: [Koha-bugs] [Bug 30378] Convert about page tabs to Bootstrap
    In-Reply-To: <bug-30378-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30378-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30378-70-3SvmZV1zom@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30378
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:41:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:41:44 +0000
    Subject: [Koha-bugs] [Bug 30378] Convert about page tabs to Bootstrap
    In-Reply-To: <bug-30378-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30378-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30378-70-Tux5Si9fRw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30378
    
    --- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:41:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:41:46 +0000
    Subject: [Koha-bugs] [Bug 30396] Convert basket groups page tabs to Bootstrap
    In-Reply-To: <bug-30396-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30396-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30396-70-i6gCXolFv0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30396
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:41:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:41:49 +0000
    Subject: [Koha-bugs] [Bug 30396] Convert basket groups page tabs to Bootstrap
    In-Reply-To: <bug-30396-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30396-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30396-70-8tw0KSFvIF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30396
    
    --- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:41:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:41:53 +0000
    Subject: [Koha-bugs] [Bug 30398] Reindent invoices template
    In-Reply-To: <bug-30398-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30398-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30398-70-tYKfh1OO84@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:41:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:41:55 +0000
    Subject: [Koha-bugs] [Bug 30398] Reindent invoices template
    In-Reply-To: <bug-30398-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30398-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30398-70-PZAr4L0v5c@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398
    
    --- Comment #10 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:41:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:41:58 +0000
    Subject: [Koha-bugs] [Bug 30400] Convert invoices page tabs to Bootstrap
    In-Reply-To: <bug-30400-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30400-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30400-70-EceFaP3tZI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30400
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:42:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:42:00 +0000
    Subject: [Koha-bugs] [Bug 30400] Convert invoices page tabs to Bootstrap
    In-Reply-To: <bug-30400-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30400-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30400-70-9Yka57mjzT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30400
    
    --- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:42:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:42:03 +0000
    Subject: [Koha-bugs] [Bug 30401] Convert budgets administration page tabs to
     Bootstrap
    In-Reply-To: <bug-30401-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30401-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30401-70-aouhuQnhkq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30401
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:42:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:42:07 +0000
    Subject: [Koha-bugs] [Bug 30401] Convert budgets administration page tabs to
     Bootstrap
    In-Reply-To: <bug-30401-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30401-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30401-70-NTyjItqa5s@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30401
    
    --- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:42:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:42:11 +0000
    Subject: [Koha-bugs] [Bug 30417] Switch to Bootstrap tabs on the basic
     library transfer limit page
    In-Reply-To: <bug-30417-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30417-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30417-70-GSZUns5tnM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30417
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:42:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:42:14 +0000
    Subject: [Koha-bugs] [Bug 30417] Switch to Bootstrap tabs on the basic
     library transfer limit page
    In-Reply-To: <bug-30417-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30417-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30417-70-xTecnDllGG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30417
    
    --- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:42:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:42:17 +0000
    Subject: [Koha-bugs] [Bug 30419] Convert authority detail page tabs to
     Bootstrap
    In-Reply-To: <bug-30419-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30419-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30419-70-yc7HuJvmZC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30419
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:42:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:42:20 +0000
    Subject: [Koha-bugs] [Bug 30419] Convert authority detail page tabs to
     Bootstrap
    In-Reply-To: <bug-30419-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30419-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30419-70-wkBybRzH9C@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30419
    
    --- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:42:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:42:23 +0000
    Subject: [Koha-bugs] [Bug 30423] Convert authority merge page tabs to
     Bootstrap
    In-Reply-To: <bug-30423-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30423-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30423-70-XA2z1bzA47@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30423
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:42:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:42:26 +0000
    Subject: [Koha-bugs] [Bug 30423] Convert authority merge page tabs to
     Bootstrap
    In-Reply-To: <bug-30423-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30423-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30423-70-ZwIaBoCVvp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30423
    
    --- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:42:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:42:30 +0000
    Subject: [Koha-bugs] [Bug 30432] get_items_that_can_fill needs to specify
     table for biblionumbers
    In-Reply-To: <bug-30432-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30432-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30432-70-UBhDExzeSd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:42:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:42:32 +0000
    Subject: [Koha-bugs] [Bug 30432] get_items_that_can_fill needs to specify
     table for biblionumbers
    In-Reply-To: <bug-30432-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30432-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30432-70-BVrhA01lNA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432
    
    --- Comment #10 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:42:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:42:35 +0000
    Subject: [Koha-bugs] [Bug 30456] Convert checkout history tabs to Bootstrap
    In-Reply-To: <bug-30456-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30456-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30456-70-jgbYYg9D7i@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30456
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:42:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:42:41 +0000
    Subject: [Koha-bugs] [Bug 30456] Convert checkout history tabs to Bootstrap
    In-Reply-To: <bug-30456-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30456-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30456-70-aJOgWrMFv6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30456
    
    --- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:44:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:44:23 +0000
    Subject: [Koha-bugs] [Bug 26370] Add ability to disable demagnetizing items
     via SIP2 for arbitrary patron categories
    In-Reply-To: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26370-70-cWo36ui3z3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370
    
    --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    I've documented to new config option on the wiki now too :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 11:46:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 09:46:33 +0000
    Subject: [Koha-bugs] [Bug 22347] Translatability of ILSDI results for
     getavaibility
    In-Reply-To: <bug-22347-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22347-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22347-70-oSIxDybVpB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22347
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
               Keywords|                            |release-notes-needed
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 12:19:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 10:19:41 +0000
    Subject: [Koha-bugs] [Bug 26370] Add ability to disable demagnetizing items
     via SIP2 for arbitrary patron categories
    In-Reply-To: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26370-70-8vrmSnW3cf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370
    
    --- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
    (In reply to Martin Renvoize from comment #13)
    > I've documented to new config option on the wiki now too :)
    
    Awesome! Thanks!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 12:23:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 10:23:42 +0000
    Subject: [Koha-bugs] [Bug 30466] Convert serials pages tabs to Bootstrap
    In-Reply-To: <bug-30466-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30466-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30466-70-rCT0AI7NVS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30204
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204
    [Bug 30204] Add subtitle to serial subscription search
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 12:23:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 10:23:42 +0000
    Subject: [Koha-bugs] [Bug 30204] Add subtitle to serial subscription search
    In-Reply-To: <bug-30204-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30204-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30204-70-du8NIZNoTH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30466
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466
    [Bug 30466] Convert serials pages tabs to Bootstrap
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 12:25:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 10:25:23 +0000
    Subject: [Koha-bugs] [Bug 30466] Convert serials pages tabs to Bootstrap
    In-Reply-To: <bug-30466-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30466-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30466-70-5qEdPt4XQC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Patch doesn't apply         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 12:25:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 10:25:27 +0000
    Subject: [Koha-bugs] [Bug 30466] Convert serials pages tabs to Bootstrap
    In-Reply-To: <bug-30466-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30466-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30466-70-4u8ObTz831@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132987|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133209
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133209&action=edit
    Bug 30466: Convert serials pages tabs to Bootstrap
    
    This patch modifies three serials templates in order to replace jQueryUI
    tabs with Bootstrap tabs.
    
    To test, apply the patch and rebuild the staff interface CSS
    (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
    
    - Go to Serials.
    - Perform a serials search which will return one or more results.
    - On the search results page you should see an Open and Closed tab.
    - The tabs should look correct and work correctly.
    - Confirm that "Select all" and "Clear all" controls work correctly in
      each tab.
    
    - Click one of the search results to view the details for that
      subscription.
    - You should see tabs for Information, Planning, Issues, and Summary.
      You may also see an Acquisition details tab depending on your data.
    
    - In the sidebar menu click "Serial collection."
    - On this page you should see tabs corresponding to each year the serial
      has been received.
    - Under each tab the "Select all" and "Clear all" controls should work
      correctly in the context of that tab. Other controls should apply to
      all tabs.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 12:28:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 10:28:58 +0000
    Subject: [Koha-bugs] [Bug 30474] Convert tools pages tabs to Bootstrap (part
     1)
    In-Reply-To: <bug-30474-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30474-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30474-70-lSLIG9IAeg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |ASSIGNED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 12:34:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 10:34:58 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-rPIX70qWKI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Adding discussion from Slack..
    
    I don't think we need the trigger in DelBiblio.. but we likely do need to think
    about preventing Item level triggers for batch operations and then triggering
    at the end of said batch operations (like BatchDeleteBiblio).
    
    I think we can drop the triggers in circ (but keep the tests to ensure the
    triggers do actually still get triggered once).. circ operations affect items
    and as such trigger the task there.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 12:36:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 10:36:18 +0000
    Subject: [Koha-bugs] [Bug 29777] Fields 580 are wrong displayed in summary
     column
    In-Reply-To: <bug-29777-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29777-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29777-70-3IpennAe49@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29777
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |jeremy.breuillard at biblibre.
                       |                            |com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 12:49:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 10:49:58 +0000
    Subject: [Koha-bugs] [Bug 29308] Regression: NewItemsDefaultLocation should
     not be applied to items.permanent_location
    In-Reply-To: <bug-29308-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29308-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29308-70-eGp6qfqVz4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29308
    
    George Veranis <gveranis at dataly.gr> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |gveranis at dataly.gr
    
    --- Comment #2 from George Veranis <gveranis at dataly.gr> ---
    Μaybe should be a good option to add a second preference with value Yes/No to
    ask if librarian needs to set that temporary location later also as permanent
    location and add this logic also to the appropriate code.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 12:50:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 10:50:52 +0000
    Subject: [Koha-bugs] [Bug 26777] Give the user the option to display their
     patron card barcode from the OPAC
    In-Reply-To: <bug-26777-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26777-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26777-70-UL5r6DpfNj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777
    
    --- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
    (In reply to Martin Renvoize from comment #7)
    > Is this something you're still experimenting with Owen?
    
    I started working on Bug 27825 - Add preference for choosing the default format
    for patron barcodes - and got stalled. I don't recall what the sticking point
    was or if I just got redirected.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 13:54:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 11:54:01 +0000
    Subject: [Koha-bugs] [Bug 30512] New: Staff interface search results
     template error
    Message-ID: <bug-30512-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512
    
                Bug ID: 30512
               Summary: Staff interface search results template error
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: normal
              Priority: P5 - low
             Component: Templates
              Assignee: oleonard at myacpl.org
              Reporter: oleonard at myacpl.org
            QA Contact: testopia at bugs.koha-community.org
                    CC: testopia at bugs.koha-community.org
            Depends on: 29609
    
    Bug 29609 made a change to results.tt which result in broken markup:
    
     <a href="[% PROCESS biblio_a_href biblionumber => SEARCH_RESULT.biblionumber
    %]" class => 'p1'>
    
    biblio_a_href doesn't accept a "class" property.
    
    The problem will only appear if you have IntranetCoce, AmazonCoverImages, or
    LocalCoverImages enabled.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29609
    [Bug 29609] Links to guess the biblio default view need to be centralized
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 13:54:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 11:54:01 +0000
    Subject: [Koha-bugs] [Bug 29609] Links to guess the biblio default view need
     to be centralized
    In-Reply-To: <bug-29609-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29609-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29609-70-8a4vxdQbtr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29609
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30512
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512
    [Bug 30512] Staff interface search results template error
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 13:54:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 11:54:09 +0000
    Subject: [Koha-bugs] [Bug 30512] Staff interface search results template
     error
    In-Reply-To: <bug-30512-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30512-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30512-70-KV2PQpTQxw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Version|unspecified                 |master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 13:56:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 11:56:05 +0000
    Subject: [Koha-bugs] [Bug 23780] Batch check out fails to inform or trap
    In-Reply-To: <bug-23780-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23780-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23780-70-sEyZk6ZMCP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23780
    
    Patrick Robitaille <patrick.robitaille at collecto.ca> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |patrick.robitaille at collecto
                       |                            |.ca
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 13:57:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 11:57:31 +0000
    Subject: [Koha-bugs] [Bug 25222] Add ability to let plugins live in
     individual subdirectories
    In-Reply-To: <bug-25222-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25222-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25222-70-6EUJsGTAVX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222
    
    --- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
    (In reply to David Cook from comment #15)
    > I don't have anything to ad from a QA perspective... but I'm intrigued by
    > this one!
    > 
    > In Discourse, the named plugins go into /var/www/discourse/plugins, so you
    > wind up with something like
    > /var/www/discourse/plugins/discourse-jwt/plugin.rb
    > (https://github.com/discourse/discourse-jwt). I found it super convenient.
    
    Yeah, that's basically the gist of what we are trying do to here as well!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 14:06:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 12:06:44 +0000
    Subject: [Koha-bugs] [Bug 30512] Staff interface search results template
     error
    In-Reply-To: <bug-30512-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30512-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30512-70-d0RQXsSxu4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512
    
    --- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133210
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133210&action=edit
    Screenshot showing the problem
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 14:07:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 12:07:14 +0000
    Subject: [Koha-bugs] [Bug 30512] Staff interface search results template
     error
    In-Reply-To: <bug-30512-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30512-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30512-70-EqjNT22dzB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Trivial patch
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 14:07:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 12:07:17 +0000
    Subject: [Koha-bugs] [Bug 30512] Staff interface search results template
     error
    In-Reply-To: <bug-30512-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30512-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30512-70-5PxhDDUqsZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512
    
    --- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133211
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133211&action=edit
    Bug 30512: Staff interface search results template error
    
    This patch removes some markup from the search results template which
    was causing markup to be output on the screen. Rather than correct the
    markup so that the "p1" class is correctly added to the relevant links
    I'm removing it. The "p1" class isn't used anywhere.
    
    The patch also corrects two incorrect template filters on one of the
    page's links.
    
    To test, apply the patch and enable the following system preferences:
    
    - AmazonCoverImages
    - IntranetCoce (if available)
    - LocalCoverImages
    
    - Perform a catalog search in the staff interface which will return
      results with cover images from each of the enabled services.
    - The covers should show correctly in the search results with no markup
      being output on screen.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 14:15:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 12:15:26 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-3ZSFy1Z5ZT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    --- Comment #141 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Revisiting this one again now
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 14:21:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 12:21:24 +0000
    Subject: [Koha-bugs] [Bug 30513] New: Add option to update pickup location
     of pending holds when changing patron home library
    Message-ID: <bug-30513-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30513
    
                Bug ID: 30513
               Summary: Add option to update pickup location of pending holds
                        when changing patron home library
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Hold requests
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: andrew at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com
    
    When changing a patron's home library, it would be helpful if Koha could update
    the patron's pending holds to be picked up at the new home library.
    
    This would be especially helpful for systems where all holds are required to be
    picked up at the patron's home library, who might want this change to always
    happen to all holds when a patron is moved. If the update is fully automatic
    and without exceptions, we could do it on both single and batch patron updates.
    
    For libraries that allow more flexibility in hold pickups, it could be helpful
    to have something more like a modal that lists the patron's holds and asks
    which should be moved to pickup at the new home library. That'd have to be only
    for single patron updates.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 14:22:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 12:22:52 +0000
    Subject: [Koha-bugs] [Bug 26019] Koha should set SameSite attribute on
     cookies
    In-Reply-To: <bug-26019-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26019-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26019-70-zXcFt8ZoA3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26019
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Patch doesn't apply         |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 14:22:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 12:22:56 +0000
    Subject: [Koha-bugs] [Bug 26019] Koha should set SameSite attribute on
     cookies
    In-Reply-To: <bug-26019-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26019-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26019-70-lSqr4XrqLV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26019
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132804|0                           |1
            is obsolete|                            |
     Attachment #132805|0                           |1
            is obsolete|                            |
    
    --- Comment #20 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133212
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133212&action=edit
    Bug 26019: Koha should set SameSite attribute on cookies
    
    This patch modifies the way Koha sets cookies so that the "sameSite"
    attribute is explicitly set to "Lax." This option is chosen because it
    is the value which is currently assumed by browsers when the sameSite
    attribute is not set.
    
    To test, apply the patch and restart services.
    
    - Log in to the staff interface and open your browser's developer tools.
      - In Firefox, look for a "Storage" tab.
      - In Chrome, look for an "Application" tab.
    - Under "Cookies," click the URL of the staff interface.
    - You should see all the cookies which are set for that domain.
    - The CGISESSID cookie should have sameSite set to "Lax."
    
    - Go to Cataloging -> New record.
      - Check the "marcdocs" and "marctags" cookies.
    - Switch to the Advanced MARC editor (you may need to enable
      theEnableAdvancedCatalogingEditor preference).
      - Check the "catalogue_editor" cookie.
    - Add a new item to an existing bibliographic record.
      - Check the "LastCreatedItem" cookie which is set after you save the
        new item.
    - Go to Authorities -> Authority search.
      - In authority search results, click "Merge" from the "Actions" menu
        next to one of the results..
        - Check the "auth_to_merge" cookie.
    - Go to Administration -> MARC bibliographic framework
      - Choose "MARC structure" from the menu corresponding to one of the
        frameworks.
      - Check the "Display only used tags/subfields" checkbox.
        - Check the "marctagstructure_selectdisplay" cookie.
    - Go to Circulation -> Check out to a patron with checkouts.
      - Check the "Always show checkouts immediately" checkbox.
        - Check the "issues-table-load-immediately-circulation" cookie.
    - Go to Tools -> Patron clubs. You will need at least one active club
      with one or more patrons enrolled.
      - From the list of clubs, click Actions -> Search to hold.
        - Check the "holdforclub" cookie.
    - Go to Tools -> Batch item modification and submit a batch of items.
      - Uncheck one or more checkboxes in the "Show/hide columns" area.
        - Check the "showColumns" cookie.
    - View a patron -> Search to hold.
      - Check the 'holdfor' cookie.
    - With WebBasedSelfCheck enabled, log in to the self-checkout page.
      - Check the "JWT" cookie.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 14:23:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 12:23:00 +0000
    Subject: [Koha-bugs] [Bug 26019] Koha should set SameSite attribute on
     cookies
    In-Reply-To: <bug-26019-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26019-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26019-70-dXVl29eJ5S@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26019
    
    --- Comment #21 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133213
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133213&action=edit
    Bug 26019: Add two other js cookies
    
    Test plan:
    Same as former patch. Use OPAC adv search here.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 14:23:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 12:23:05 +0000
    Subject: [Koha-bugs] [Bug 26019] Koha should set SameSite attribute on
     cookies
    In-Reply-To: <bug-26019-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26019-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26019-70-xVDUClUmvo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26019
    
    --- Comment #22 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133214
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133214&action=edit
    Bug 26019: (follow-up) Set SameSite attribute on Cart cookies
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 14:23:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 12:23:56 +0000
    Subject: [Koha-bugs] [Bug 26019] Koha should set SameSite attribute on
     cookies
    In-Reply-To: <bug-26019-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26019-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26019-70-drIvsnr22a@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26019
    
    --- Comment #23 from Owen Leonard <oleonard at myacpl.org> ---
    I've added an additional followup, so if RM would like another signoff please
    reset the status.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 14:28:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 12:28:56 +0000
    Subject: [Koha-bugs] [Bug 29311] Do not allow editing of bibliographic
     information when entering suggestion from existing bibs
    In-Reply-To: <bug-29311-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29311-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29311-70-Ry9mwE9xWY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|oleonard at myacpl.org         |jeremy.breuillard at biblibre.
                       |                            |com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 14:45:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 12:45:10 +0000
    Subject: [Koha-bugs] [Bug 25815] SIP Checkout: add more information on why
     the patron is blocked
    In-Reply-To: <bug-25815-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25815-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25815-70-m76TJa6HnB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815
    
    --- Comment #6 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
    Thanks for your feedback, Nick. The following patch restores the correct order
    and adds unit tests.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 14:46:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 12:46:26 +0000
    Subject: [Koha-bugs] [Bug 25815] SIP Checkout: add more information on why
     the patron is blocked
    In-Reply-To: <bug-25815-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25815-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25815-70-jC7IPEnmFi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815
    
    Matthias Meusburger <matthias.meusburger at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132652|0                           |1
            is obsolete|                            |
    
    --- Comment #7 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
    Created attachment 133215
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133215&action=edit
    updated patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 14:55:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 12:55:51 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-fmh7FWT7gn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    --- Comment #142 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    No rebase problems found, tested. Passing QA again.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 15:28:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 13:28:16 +0000
    Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing
     secret via HTTP GET
    In-Reply-To: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29873-70-tuXCB5whbH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|dependency                  |
    
    --- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Second try
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 16:20:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 14:20:27 +0000
    Subject: [Koha-bugs] [Bug 30514] New: Error in date format check following
     datepicker removal
    Message-ID: <bug-30514-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30514
    
                Bug ID: 30514
               Summary: Error in date format check following datepicker
                        removal
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: normal
              Priority: P5 - low
             Component: Templates
              Assignee: oleonard at myacpl.org
              Reporter: oleonard at myacpl.org
            QA Contact: testopia at bugs.koha-community.org
                    CC: dcook at prosentient.com.au, lucas at bywatersolutions.com,
                        testopia at bugs.koha-community.org
            Depends on: 30011
    
    calendar.inc still contains a reference to a variable which was removed by Bug
    30011. This creates an error when using Flatpickr in some contexts.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011
    [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 16:20:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 14:20:27 +0000
    Subject: [Koha-bugs] [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and
     staff interface
    In-Reply-To: <bug-30011-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30011-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30011-70-aFCNGPXl6v@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30514
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30514
    [Bug 30514] Error in date format check following datepicker removal
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 16:30:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 14:30:56 +0000
    Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing
     secret via HTTP GET
    In-Reply-To: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29873-70-MkRGRd8CuV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 16:31:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 14:31:00 +0000
    Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing
     secret via HTTP GET
    In-Reply-To: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29873-70-1gzp39S57P@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #129576|0                           |1
            is obsolete|                            |
     Attachment #129579|0                           |1
            is obsolete|                            |
     Attachment #129580|0                           |1
            is obsolete|                            |
     Attachment #129581|0                           |1
            is obsolete|                            |
     Attachment #129605|0                           |1
            is obsolete|                            |
    
    --- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133216
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133216&action=edit
    Bug 29873: Create QR code
    
    Instead of using deprecated Google Charts API, and exposing our
    secret in a GET parameter, we generate QR data ourselves.
    
    Test plan:
    [1] Enable two factor authentication in the prefs.
    [2] Login in staff. Go to account. Select Manage 2FA.
    [3] Verify that QR code is displayed.
    [4] Register the QR in your authenticator app and test 2FA
        by logging in again.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Tested with Google Authenticator and FreeOTP.
    
    Bug 29873: (follow-up) Rename qr_dataurl
    
    As requested by a QA team member.
    We're moving to qr_code as method name. This is the same name as
    the method in the underlying base class.
    Apart from one sed statement, changing to self->SUPER on one line.
    
    Test plan:
    Can you still register, logout and login?
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Bug 29873: (follow-up) Switch to GD
    
    We do not need a new module, we could use GD instead.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 16:31:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 14:31:04 +0000
    Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing
     secret via HTTP GET
    In-Reply-To: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29873-70-UC8gQ8tR7b@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873
    
    --- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133217
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133217&action=edit
    Bug 29873: Add unit test
    
    Test plan:
    Run t/db_dependent/Koha/Auth/TwoFactorAuth.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Amended to reflect requested changes.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 16:44:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 14:44:16 +0000
    Subject: [Koha-bugs] [Bug 30514] Error in date format check following
     datepicker removal
    In-Reply-To: <bug-30514-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30514-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30514-70-LFVveMF6yb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30514
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 16:44:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 14:44:20 +0000
    Subject: [Koha-bugs] [Bug 30514] Error in date format check following
     datepicker removal
    In-Reply-To: <bug-30514-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30514-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30514-70-69TJWY41RK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30514
    
    --- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133218
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133218&action=edit
    Bug 30514: Error in date format check following datepicker removal
    
    This patch corrects the is_valid_date function in the OPAC and staff
    interface so that it work correctly with Flatpickr.
    
    To test, apply the patch and clear your browser cache if necessary.
    
    - In the staff client, locate a bibliographic record and edit its items.
    - Test that the "Date acquired" date picker works correctly and that
      there are no errors in the browser console.
    - Test other date input fields to check that they still work, e.g.
      specify due date during checkout; Catalog statistics wizard; Patron
      entry/modification, etc.
    - Perform similar tests in the OPAC: Hold suspension; Update your
      personal details.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 17:01:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 15:01:33 +0000
    Subject: [Koha-bugs] [Bug 30136] Add back to top button when scrolling
    In-Reply-To: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30136-70-CceDZ2KBKR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 17:01:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 15:01:39 +0000
    Subject: [Koha-bugs] [Bug 30136] Add back to top button when scrolling
    In-Reply-To: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30136-70-Mf95VQ9nDX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #130902|0                           |1
            is obsolete|                            |
    
    --- Comment #8 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Created attachment 133219
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133219&action=edit
    Bug 30136: Add back to top button to OPAC
    
    Like in many websites, when scrolling down the page make a button appear to go
    back to top.
    This can be very useful specially in search results page.
    
    This patch adds to OPAC using Javascript a button with id "backtotop".
    Button appears when 300 pixels from top are hidden.
    This value may be adapted.
    
    Test plan
    1) Go to OPAC
    2) Perform a search with many results
    3) Scroll down
    => Back to top button appears
    4) Manually scroll back to top
    => Button disappears
    5) Scroll down and click on Back to top button
    => You get to top
    
    Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 17:02:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 15:02:03 +0000
    Subject: [Koha-bugs] [Bug 30136] Add back to top button when scrolling
    In-Reply-To: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30136-70-fd9s2d3Mlz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #130903|0                           |1
            is obsolete|                            |
    
    --- Comment #9 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Created attachment 133220
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133220&action=edit
    Bug 30136: [DO NO PUSH] CSS styling for OPAC
    
    This patch is for easy testing of the CSS to apply on button.
    
    If feature is validated this must be written in opac SCSS file.
    
    Maybe this sould only appear on large screens.
    
    Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 17:02:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 15:02:44 +0000
    Subject: [Koha-bugs] [Bug 30136] Add back to top button when scrolling
    In-Reply-To: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30136-70-npyQm9yt7z@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136
    
    --- Comment #10 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    (In reply to Katrin Fischer from comment #7)
    > Hi Frido, can you please check?
    > 
    >  FAIL	koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc
    >    FAIL	  forbidden patterns
    > 		forbidden pattern: Font Awesome icons need the aria-hidden attribute for
    > accessibility purpose (see bug 25166)  (line 220)
    
    Ah oupsy.
    Fixed
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 17:09:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 15:09:25 +0000
    Subject: [Koha-bugs] [Bug 30265] Hide 'Log into your account' in OPAC
     authentication page
    In-Reply-To: <bug-30265-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30265-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30265-70-q4OVPuqVWD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30265
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|In Discussion               |RESOLVED
             Resolution|---                         |INVALID
    
    --- Comment #11 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    OK lets keep it.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 17:10:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 15:10:58 +0000
    Subject: [Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when
     adding/editing items
    In-Reply-To: <bug-29815-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29815-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29815-70-Xkpu116TgK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
       Patch complexity|---                         |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 17:11:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 15:11:02 +0000
    Subject: [Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when
     adding/editing items
    In-Reply-To: <bug-29815-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29815-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29815-70-NfmgCh59wq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #129237|0                           |1
            is obsolete|                            |
    
    --- Comment #9 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133221
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133221&action=edit
    Bug 29815: Pre-populate 'Date acquired' field when adding/editing items
    
    This patch pre-fills the 952$d (Date acquired) item subfield on page
    load. Users can still click on the field to fill this subfield.
    
    Test plan:
    1. Visit a biblio. Add an item, observe on page load the 'Date acquired'
    subfield is
    empty
    2. Visit a subscription. Receive a serial, observe after setting the serial
    status to 'Arrived' the item form loads with an empty 'Date acquired' subfield
    3. Apply patch and restart services
    4. Repeat step 1 and confirm now on page load the 'Date acquired'
    subfield populates with today's date
    5. Delete the populated 'Date acquired' subfield value. Click in the
    field and confirm the field is populated and the calendar input displays
    6. Delete the 'Date acquired' subfield value again. Confirm that tabbing
    from a different field into the date acquired field behaves the same as
    click
    7. Repeat step 2. This time confirm on page load the 'Date acquired' subfield
    contains the current date
    8. Delete the populated 'Date acquired' subfield value. Click in the
    field and confirm it is populated
    9. Delete the populated 'Date acquired' subfield value. Tab to the field
    from another field and confirm it behaves the same as click
    10. Visit a biblio. Edit an item with a date acquired value in
    the past. Confirm the date acquired value is unchanged after saving.
    
    Sponsored-By: Brimbank Library, Australia
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 17:13:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 15:13:51 +0000
    Subject: [Koha-bugs] [Bug 17018] Split AdvancedSearchTypes for staff and OPAC
    In-Reply-To: <bug-17018-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17018-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17018-70-gT3IRutfPm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 17:13:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 15:13:54 +0000
    Subject: [Koha-bugs] [Bug 17018] Split AdvancedSearchTypes for staff and OPAC
    In-Reply-To: <bug-17018-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17018-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17018-70-DQGuGo1ro8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018
    
    --- Comment #19 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 17:13:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 15:13:57 +0000
    Subject: [Koha-bugs] [Bug 22347] Translatability of ILSDI results for
     getavaibility
    In-Reply-To: <bug-22347-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22347-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22347-70-DLtRVmvtl3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22347
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 17:14:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 15:14:01 +0000
    Subject: [Koha-bugs] [Bug 22347] Translatability of ILSDI results for
     getavaibility
    In-Reply-To: <bug-22347-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22347-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22347-70-7OGwYyGxde@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22347
    
    --- Comment #10 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 17:14:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 15:14:05 +0000
    Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
     by library staff only
    In-Reply-To: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26346-70-rsAeMQVcvP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 17:14:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 15:14:08 +0000
    Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
     by library staff only
    In-Reply-To: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26346-70-JMtAKuvi6W@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
    
    --- Comment #144 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 17:22:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 15:22:36 +0000
    Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list
    In-Reply-To: <bug-29859-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29859-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29859-70-kQw11oSB9T@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132983|0                           |1
            is obsolete|                            |
    
    --- Comment #18 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Comment on attachment 132983
      --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132983
    Bug 29859: Fix BatchUpdateAuthority
    
    Ah ok, reverted from master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 17:24:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 15:24:16 +0000
    Subject: [Koha-bugs] [Bug 29304] Add a first time login page
    In-Reply-To: <bug-29304-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29304-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29304-70-Nf2durDxyE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29304
    
    Sally <sally.healey at cheshiresharedservices.gov.uk> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |sally.healey at cheshireshared
                       |                            |services.gov.uk
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 17:28:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 15:28:20 +0000
    Subject: [Koha-bugs] [Bug 30504] Value builder for field $181
    In-Reply-To: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30504-70-jL8jc0VVPs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30504
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |jeremy.breuillard at biblibre.
                       |ity.org                     |com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 17:28:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 15:28:38 +0000
    Subject: [Koha-bugs] [Bug 30506] Value builder for field $182
    In-Reply-To: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30506-70-XjFuUaBzrC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |jeremy.breuillard at biblibre.
                       |ity.org                     |com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 17:28:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 15:28:43 +0000
    Subject: [Koha-bugs] [Bug 30507] Value builder for field $183
    In-Reply-To: <bug-30507-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30507-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30507-70-EflwZxVJTy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30507
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |jeremy.breuillard at biblibre.
                       |ity.org                     |com
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 17:47:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 15:47:55 +0000
    Subject: [Koha-bugs] [Bug 30515] New: Move Overdue transports to patron
     messaging preferences
    Message-ID: <bug-30515-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515
    
                Bug ID: 30515
               Summary: Move Overdue transports to patron messaging
                        preferences
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Circulation
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: nick at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
    
    The idea of this bug would be to allow patrons to choose which format they
    would like to receive their overdues in while maintaining at least one
    selection as mandatory
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 17:48:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 15:48:46 +0000
    Subject: [Koha-bugs] [Bug 30515] Move Overdue transports to patron messaging
     preferences
    In-Reply-To: <bug-30515-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30515-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30515-70-MgdL6mQEBx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |dcook at prosentient.com.au,
                       |                            |jonathan.druart+koha at gmail.
                       |                            |com,
                       |                            |joy at bywatersolutions.com,
                       |                            |julian.maurice at biblibre.com
                       |                            |, katrin.fischer at bsz-bw.de,
                       |                            |m.de.rooy at rijksmuseum.nl,
                       |                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 18:06:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 16:06:35 +0000
    Subject: [Koha-bugs] [Bug 30516] New: Add primary phone to members.pl
    Message-ID: <bug-30516-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30516
    
                Bug ID: 30516
               Summary: Add primary phone to members.pl
     Change sponsored?: ---
               Product: Koha
               Version: 21.05
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Patrons
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: bwsdonna at gmail.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
    
    When searching for a patron, the primary phone number is a standard search
    option, but that information does not display in the search results.  This is a
    very common way of searching for a patron, and for distinguishing between
    patrons with similar info.  The primary phone number should be added to the
    table settings configuration.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 18:37:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 16:37:31 +0000
    Subject: [Koha-bugs] [Bug 29885] Add the option to customise Z39.50 searches
    In-Reply-To: <bug-29885-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29885-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29885-70-xEXawJOAFu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29885
    
    Donna <bwsdonna at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |bwsdonna at gmail.com
    
    --- Comment #1 from Donna <bwsdonna at gmail.com> ---
    This sort of enhancement has been requested by a number of libraries.  One of
    the most common requests is to have a way to see in the search results what the
    format of the record is.  For instance, if I do a search and get three results,
    all containing the same ISBN, I have to look at each record to determine if the
    record is the print, ebook, audio etc as that info is not readily displayed. 
    So in this case, some way to see the leader and 008.  
    
    While we can add additional search fields to the results display, it gets
    rather unwieldy quickly.  
    
    Being able to choose what fields should show in the search results would be
    very helpful.  Perhaps a system preference where you can list which fields are
    wanted/unwanted?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 18:41:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 16:41:50 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-UitlABbS0K@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    --- Comment #143 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133222
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133222&action=edit
    Bug 28786: (follow-up) Improve style of 2FA code input
    
    This patch cleans up login.css a little bit so that the same style rules
    which apply to the login screen apply to the 2FA input form as well.
    
    The patch also changes the "Log out" link on the 2FA form to a "Cancel"
    link alongside the "Verify" button.
    
    To test, apply the patch and start the process of logging in to the
    staff client using an account with 2FA enabled.
    
    On both the login form and 2FA code views, confirm that everything is
    styled consistently.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 18:42:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 16:42:43 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-H3GjLBfsvh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    --- Comment #144 from Owen Leonard <oleonard at myacpl.org> ---
    If this follow-up doesn't work for everyone please just ignore it. I don't want
    to hold up the process.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 18:43:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 16:43:43 +0000
    Subject: [Koha-bugs] [Bug 29304] Add a first time login page
    In-Reply-To: <bug-29304-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29304-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29304-70-wGgE8Vq2TR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29304
    
    --- Comment #3 from Christopher Brannon <cbrannon at cdalibrary.org> ---
    (In reply to Fridolin Somers from comment #2)
    > Awesome idea.
    > 
    > Maybe we create an HTML additional content for this (like
    > OpacLoginInstructions).
    > 
    > Maybe use borrowers.lastseen
    
    Preferably a unique identifier.  There might be cases where a library would
    want to retrigger this page if information has been updated.
    
    What if you could specify on a news article that this particular article show
    in an alert modal (maybe replacing the banner at the top)?
    
    Each article has it's own id.  What if any messages/articles (including a
    welcome message) are listed in a modal that has a scroller...and each article
    had a check box to indicate read/hide.  The modal only appears if there are
    unchecked items.
    
    This would mean maintaining a table of borrowernumbers, and article ids.  A new
    row is added with the borrowernumber and article id when the patron checks off
    an article.
    
    A patron could have a link to get to old articles (if they still exist)
    somewhere.
    
    This list would be cleaned up if either the patron unchecked this article in
    the above link, or if the article is deleted.
    
    I think this would be a great mechanism, and it would be ideal for welcome
    messages and all other alerts/news/articles.
    
    Thoughts?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 19:43:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 17:43:40 +0000
    Subject: [Koha-bugs] [Bug 28079] Set focus to search box field when adding
     an order to basket
    In-Reply-To: <bug-28079-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28079-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28079-70-SZNZCxOpON@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28079
    
    Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |marjorie.barry-vila at collect
                       |                            |o.ca
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 20:12:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 18:12:11 +0000
    Subject: [Koha-bugs] [Bug 28757] Allow users to place a reservation when
     their account is restricted
    In-Reply-To: <bug-28757-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28757-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28757-70-0GECuNPnk4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28757
    
    Lisette Scheer <lisetteslatah at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lisetteslatah at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 20:59:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 18:59:18 +0000
    Subject: [Koha-bugs] [Bug 30516] Add primary phone to members.pl
    In-Reply-To: <bug-30516-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30516-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30516-70-ZMM5s1vdUK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30516
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lucas at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 21:23:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 19:23:15 +0000
    Subject: [Koha-bugs] [Bug 29863] Show requested transfers in the holdings
     table
    In-Reply-To: <bug-29863-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29863-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29863-70-l2wlirofOs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29863
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Rotating collections also adds to requested transfers.. currently, all others
    still get pushed straight into transfer so would appear in transfers to receive
    as always.
    
    I like this idea though.. will take a quick look at implementing it.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 21:23:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 19:23:21 +0000
    Subject: [Koha-bugs] [Bug 29863] Show requested transfers in the holdings
     table
    In-Reply-To: <bug-29863-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29863-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29863-70-NkWWUAr8cx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29863
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                       |ity.org                     |.com
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 21:25:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 19:25:17 +0000
    Subject: [Koha-bugs] [Bug 22567] Stock rotation manage rotas should show
     items current and desired locations
    In-Reply-To: <bug-22567-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22567-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22567-70-DWfYuaKJ7M@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22567
    
    --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Can we close this one Nick.. or do you happen to remember what you meant?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 21:27:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 19:27:24 +0000
    Subject: [Koha-bugs] [Bug 30517] New: Translation breaks editing parent type
     circulation rule
    Message-ID: <bug-30517-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517
    
                Bug ID: 30517
               Summary: Translation breaks editing parent type circulation
                        rule
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: I18N/L10N
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: caroline.cyr-la-rose at inlibro.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: frederic at tamil.fr
    
    If using Koha in a language other than English, and using parent item types,
    you can't easily edit a rule for the parent type. When you click on "Edit" next
    to the rule, the line at the bottom keeps "All" as the item type and if you're
    not careful, it doesn't modify the parent type rule, but the All rule.
    
    I can't explain it well, but here's how to replicate this problem:
    
    1. Install another language in the staff interface
       1. ./translate install xx-XX
       2. Check the box of the language in the 'language' system preference
       3. Refresh
    2. Create an item type with a parent
       1. Go to Administration > Item types
       2. Create a new item type or modify an existing one, assigning a parent type
    (I created a 'Children's books' type and assigned 'Books' as its parent)
    3. Create a circulation rule for the parent type (I created All/Books, with 10
    checkouts allowed)
    4. Create a circulation rule for All/All (I created All/All with 30 checkouts
    allowed)
    5. In English, click on "Edit" next to the parent type rule (All/Books)
    --> Note that the item type in the bottom row (the modifiable row) is changed
    to 'Books (All)'
    6. Modify the number of checkouts allowed (e.g. 99)
    --> The All/Books rule is modified
    7. Switch the interface to the other language
    8. Click on "Edit" next to the parent type rule (All/Books)
    --> Note that the item type in the bottom row stays on 'All'
    9. Modify the number of checkouts allowed (e.g. 88)
    --> The All/All rule is modified
    
    I hope my steps are clear...
    
    I tried this in fr-CA and de-DE, and the behaviour is the same.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 21:31:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 19:31:22 +0000
    Subject: [Koha-bugs] [Bug 30517] Translation breaks editing parent type
     circulation rule
    In-Reply-To: <bug-30517-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30517-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30517-70-kOxwNJ0o7R@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517
    
    --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
    This is the string that is causing the problem
    
    #. %1$s:  itemtypeloo.translated_description | html 
    #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:374
    #, c-format
    msgid "%s (All)"
    msgstr "%s (Toutes)"
    
    If I add fuzzy to the last commented line and reapply the translation, the
    problem goes away.
    
    #. %1$s:  itemtypeloo.translated_description | html 
    #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:374
    #, fuzzy,c-format
    msgid "%s (All)"
    msgstr "%s (Toutes)"
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 21:41:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 19:41:07 +0000
    Subject: [Koha-bugs] [Bug 30517] Translation breaks editing parent type
     circulation rule
    In-Reply-To: <bug-30517-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30517-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30517-70-Rc25IHGePl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517
    
    Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |philippe.blouin at inlibro.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 22:03:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 20:03:34 +0000
    Subject: [Koha-bugs] [Bug 30518] New: StockRotationItems crossing DST
     boundary throw invalid local time exception
    Message-ID: <bug-30518-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30518
    
                Bug ID: 30518
               Summary: StockRotationItems crossing DST boundary throw invalid
                        local time exception
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: NEW
              Severity: major
              Priority: P5 - low
             Component: Tools
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: martin.renvoize at ptfs-europe.com
            QA Contact: testopia at bugs.koha-community.org
    
    The 'needs_advance' method can fall foul of DateTime math errors when crossing
    a DST boundary which can in turn the cron script failing.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 22:03:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 20:03:47 +0000
    Subject: [Koha-bugs] [Bug 30518] StockRotationItems crossing DST boundary
     throw invalid local time exception
    In-Reply-To: <bug-30518-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30518-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30518-70-wk9T0pnLq3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30518
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                       |ity.org                     |.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 22:21:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 20:21:32 +0000
    Subject: [Koha-bugs] [Bug 30506] Value builder for field 182
    In-Reply-To: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30506-70-h00HFT7KTc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Value builder for field     |Value builder for field 182
                       |$182                        |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 22:21:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 20:21:58 +0000
    Subject: [Koha-bugs] [Bug 30506] Value builder for UNIMARC field 182
    In-Reply-To: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30506-70-8794x7bzUo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Value builder for field 182 |Value builder for UNIMARC
                       |                            |field 182
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 22:22:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 20:22:52 +0000
    Subject: [Koha-bugs] [Bug 30507] Value builder for UNIMARC field 183
    In-Reply-To: <bug-30507-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30507-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30507-70-Oel6uhTLOU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30507
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Value builder for field     |Value builder for UNIMARC
                       |$183                        |field 183
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 22:23:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 20:23:11 +0000
    Subject: [Koha-bugs] [Bug 30504] Value builder for UNIMARC field 181
    In-Reply-To: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30504-70-1m18LkIumB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30504
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Value builder for field     |Value builder for UNIMARC
                       |$181                        |field 181
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 22:29:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 20:29:36 +0000
    Subject: [Koha-bugs] [Bug 30515] Move Overdue transports to patron messaging
     preferences
    In-Reply-To: <bug-30515-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30515-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30515-70-hjIOYrSJM8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515
    
    --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Some libraries need to send the third notice as print or even all of them. I
    like the idea of having at least one mandatory, so you can't opt out, but could
    we also have an option to not have it appear in the messaging preferences?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 22:38:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 20:38:54 +0000
    Subject: [Koha-bugs] [Bug 30194] Update required JSON::Validator version
    In-Reply-To: <bug-30194-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30194-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30194-70-Cz6YJktKI5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194
    
    Michael Hafen <michael.hafen at washk12.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |michael.hafen at washk12.org
    
    --- Comment #100 from Michael Hafen <michael.hafen at washk12.org> ---
    Please keep the exp repo until the dev repo has the newer packages for all the
    affected libraries.
    Also, shouldn't the required module versions be updated on the About Koha page?
    Also, I seem to have the wrong version of Mojolicious::Plugin::OpenAPI in my
    dev install.  It's complaining about JSON::Validator::Ref being missing.  I
    have 2.16 from the dev repo.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 23:01:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 21:01:39 +0000
    Subject: [Koha-bugs] [Bug 30322] Holds to pull list shows ordered items if
     there are other items for the same biblio records
    In-Reply-To: <bug-30322-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30322-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30322-70-2Vd3xEwqip@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30322
    
    Tanya <tgriffith at hollislibrary.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |tgriffith at hollislibrary.org
    
    --- Comment #1 from Tanya <tgriffith at hollislibrary.org> ---
    This is happening to us as well. Our Holds to Pull is showing items that are in
    a Not For Loan status of in processing. These items are not currently available
    for patrons.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 23:08:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 21:08:44 +0000
    Subject: [Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when
     adding/editing items
    In-Reply-To: <bug-29815-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29815-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29815-70-WDMjfwEhxB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815
    
    --- Comment #10 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
    Thanks for testing Owen!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 23:29:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 21:29:47 +0000
    Subject: [Koha-bugs] [Bug 30435] Remove unused MACLES cataloging plugin
    In-Reply-To: <bug-30435-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30435-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30435-70-1QlxGcgq98@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30435
    
    Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 12 23:29:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 21:29:50 +0000
    Subject: [Koha-bugs] [Bug 30435] Remove unused MACLES cataloging plugin
    In-Reply-To: <bug-30435-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30435-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30435-70-zeq3VW1JnB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30435
    
    Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132869|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
    Created attachment 133223
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133223&action=edit
    Bug 30435: Remove unused MACLES cataloging plugin
    
    This patch removes the files associated with the MACLES cataloging
    plugin. The feature is unmaintained.
    
    Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 00:53:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 22:53:21 +0000
    Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
     characters from input fields when cataloguing
    In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30358-70-CEwCajS7Vb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133140|0                           |1
            is obsolete|                            |
    
    --- Comment #13 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Created attachment 133224
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133224&action=edit
    Bug 30358: (follow-up) Fixing tests and including for inner newlines
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 00:53:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 22:53:25 +0000
    Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
     characters from input fields when cataloguing
    In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30358-70-yPFqEyyCAO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358
    
    --- Comment #14 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Created attachment 133225
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133225&action=edit
    Bug 30358: (follow-up) Clarify syspref wording about fields affected
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 01:03:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 12 Apr 2022 23:03:19 +0000
    Subject: [Koha-bugs] [Bug 30194] Update required JSON::Validator version
    In-Reply-To: <bug-30194-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30194-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30194-70-ypdWcU3mxA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194
    
    --- Comment #101 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    (In reply to Michael Hafen from comment #100)
    > Please keep the exp repo until the dev repo has the newer packages for all
    > the affected libraries.
    > Also, shouldn't the required module versions be updated on the About Koha
    > page?
    > Also, I seem to have the wrong version of Mojolicious::Plugin::OpenAPI in my
    > dev install.  It's complaining about JSON::Validator::Ref being missing.  I
    > have 2.16 from the dev repo.
    
    Please pull the latest docker images, and if it doesn't ship the right
    versions, report back with more info so we fix the repo.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 02:23:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 00:23:08 +0000
    Subject: [Koha-bugs] [Bug 30519] New: Regression: using sys pref
     CircConfirmItemParts prevents checkin from moremember.pl and circulation.pl
    Message-ID: <bug-30519-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30519
    
                Bug ID: 30519
               Summary: Regression: using sys pref CircConfirmItemParts
                        prevents checkin from moremember.pl and circulation.pl
     Change sponsored?: ---
               Product: Koha
               Version: 21.05
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Circulation
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: bwsdonna at gmail.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
    
    With the addition of bug 25261, utilizing the sys pref CircConfirmItemParts and
    materials specified 952$3, you can no longer use the Check In column on either
    the morememeber.pl or circulation.pl.  
    
    To test:
    --set sys pref to require confirmation
    --add a materials specified note to an item
    --check item out to a patron, confirming the note
    --go to patron record, either moremember or circulation
    --using the Check In column, attempt to check in the item
    --notice no confirmation box, and item is not checked in
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 02:30:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 00:30:23 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-q0e9deR9Ri@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Patch doesn't apply
    
    --- Comment #6 from David Cook <dcook at prosentient.com.au> ---
    Sorry, Owen. It looks like this needs a rebase.
    
    root at kohadevbox:koha(bug29155)$ git bz apply 29155
    
    Bug 29155 - Upgrade jquery version
    
    130408 - Bug 29155: Upgrade jQuery and jQuery Migrate to latest versions
    130409 - Bug 29155: Update links to jQuery and jQuery Migrate files
    
    Apply? [(y)es, (n)o, (i)nteractive] y
    Applying: Bug 29155: Upgrade jQuery and jQuery Migrate to latest versions
    Applying: Bug 29155: Update links to jQuery and jQuery Migrate files
    error: sha1 information is lacking or useless
    (koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc).
    error: could not build fake ancestor
    Patch failed at 0001 Bug 29155: Update links to jQuery and jQuery Migrate files
    hint: Use 'git am --show-current-patch=diff' to see the failed patch
    When you have resolved this problem run "git bz apply --continue".
    If you would prefer to skip this patch, instead run "git bz apply --skip".
    To restore the original branch and stop patching run "git bz apply --abort".
    Patch left in
    /tmp/Bug-29155-Update-links-to-jQuery-and-jQuery-Migrat-86JbZg.patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 02:32:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 00:32:55 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-zQLrW3LvM7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    
    --- Comment #7 from David Cook <dcook at prosentient.com.au> ---
    In 6.5 hours, I'm on holidays until Tuesday, but I could take a look at this
    tonight if you rebase and shoot me an out-of-band message to let me know.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 03:04:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 01:04:32 +0000
    Subject: [Koha-bugs] [Bug 30518] StockRotationItems crossing DST boundary
     throw invalid local time exception
    In-Reply-To: <bug-30518-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30518-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30518-70-WTiYAcwNrR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30518
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |dcook at prosentient.com.au
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 03:05:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 01:05:42 +0000
    Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list
    In-Reply-To: <bug-29859-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29859-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29859-70-wlX7Iol9qI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |dcook at prosentient.com.au
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 04:17:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 02:17:58 +0000
    Subject: [Koha-bugs] [Bug 30194] Update required JSON::Validator version
    In-Reply-To: <bug-30194-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30194-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30194-70-oQ8YIw8276@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194
    
    --- Comment #102 from Mason James <mtj at kohaaloha.com> ---
    (In reply to Michael Hafen from comment #100)
    > Please keep the exp repo until the dev repo has the newer packages for all
    > the affected libraries.
    > Also, shouldn't the required module versions be updated on the About Koha
    > page?
    > Also, I seem to have the wrong version of Mojolicious::Plugin::OpenAPI in my
    > dev install.  It's complaining about JSON::Validator::Ref being missing.  I
    > have 2.16 from the dev repo.
    
    hi Michael, if you use the 'koha-staging' repo, your problems should be
    resolved
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 09:05:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 07:05:17 +0000
    Subject: [Koha-bugs] [Bug 30520] New: Command line stage and import broken
     since 21.11.
    Message-ID: <bug-30520-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520
    
                Bug ID: 30520
               Summary: Command line stage and import broken since 21.11.
     Change sponsored?: ---
               Product: Koha
               Version: 21.11
              Hardware: All
                    OS: All
                Status: NEW
              Severity: critical
              Priority: P5 - low
             Component: Command-line Utilities
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: andreas.jonsson at kreablo.se
            QA Contact: testopia at bugs.koha-community.org
                    CC: robin at catalyst.net.nz
    
    As part of the work done for bug 14957, a change was made where it is assumed
    the import is made by a logged in user, and crashes if there isn't one. 
    Specifically, this change causes the problem:
    
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126754&action=diff
    
    This affects the command line tools stage_file.pl and commit_file.pl, when
    using the --match flag to match and replace existing records.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 09:14:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 07:14:38 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-vKhPx8hqGm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    
    --- Comment #8 from David Cook <dcook at prosentient.com.au> ---
    (In reply to David Cook from comment #7)
    > In 6.5 hours, I'm on holidays until Tuesday, but I could take a look at this
    > tonight if you rebase and shoot me an out-of-band message to let me know.
    
    It looks like I got my timezones a bit confused and it's unlikely that we'll
    cross paths tonight/this morning. 
    
    If no one else comes along first, I'd be happy to sign this off on Tuesday when
    I'm back at work.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 09:23:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 07:23:55 +0000
    Subject: [Koha-bugs] [Bug 30520] Command line stage and import broken since
     21.11.
    In-Reply-To: <bug-30520-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30520-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30520-70-kIPILfDIfp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520
    
    --- Comment #1 from Andreas Jonsson <andreas.jonsson at kreablo.se> ---
    Created attachment 133232
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133232&action=edit
    Bug 30520: Allow BatchImport to be used by command line tools.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 09:32:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 07:32:07 +0000
    Subject: [Koha-bugs] [Bug 30520] Command line stage and import broken since
     21.11.
    In-Reply-To: <bug-30520-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30520-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30520-70-7zr2yRTIii@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520
    
    --- Comment #2 from Andreas Jonsson <andreas.jonsson at kreablo.se> ---
    Test plan:
    
    * Stage and commit a marc file with a match rule such that a replacement will
    be triggered (either using the tool in the staff interface or the command line
    tools)
    * Code review patch and observe:
      - If $logged_in_user is undefined the code will crash without patch and will
    not crash with patch
      - If $logged_in_user is defined the code will behave identically both with
    and without patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 09:32:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 07:32:34 +0000
    Subject: [Koha-bugs] [Bug 30520] Command line stage and import broken since
     21.11.
    In-Reply-To: <bug-30520-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30520-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30520-70-OyysRYUxuE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520
    
    Andreas Jonsson <andreas.jonsson at kreablo.se> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 10:28:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 08:28:18 +0000
    Subject: [Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to
     use backend template
    In-Reply-To: <bug-28909-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28909-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28909-70-ZV8B7yQJYR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909
    
    Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30484
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484
    [Bug 30484] Interlibrary Loans should have the ability to send notices based on
    request supplier updates
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 10:28:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 08:28:18 +0000
    Subject: [Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability
     to send notices based on request supplier updates
    In-Reply-To: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30484-70-T2orZMFjwL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484
    
    Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |28909
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909
    [Bug 28909] Allow Interlibrary Loans illview method to use backend template
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 11:06:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 09:06:19 +0000
    Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use
     Font Awesome icons
    In-Reply-To: <bug-29066-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29066-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29066-70-95IzcqXZ2K@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
    
    --- Comment #27 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    (In reply to Owen Leonard from comment #26)
    > I'm not trying to derail the progress of this patch, but I thought this
    > follow-up would be helpful.
    
    Just perfect :D
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 11:37:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 09:37:28 +0000
    Subject: [Koha-bugs] [Bug 30521] New: Create a sys pref that will allow the
     selection of fields on the OPAC form to be 'required'
    Message-ID: <bug-30521-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30521
    
                Bug ID: 30521
               Summary: Create a sys pref that will allow the selection of
                        fields on the OPAC form to be 'required'
     Change sponsored?: ---
               Product: Koha
               Version: 20.11
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: ILL
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: Niamh.WalkerHeadon at hse.ie
    
    The out-of-the-box ILL functionality does not require any of the request
    metadata fields to be completed on the form except for the destination library. 
    
    For example, an article request can be submitted without the article title. 
    
    I suggest creating a sys pref that would allow the selection of fields that are
    required before the form can be submitted, based on the request type [Book /
    Book Chapter / Journal / Journal Article / Conference Proceeding, etc.].
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 11:37:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 09:37:40 +0000
    Subject: [Koha-bugs] [Bug 30521] Create a sys pref that will allow the
     selection of fields on the OPAC form to be 'required'
    In-Reply-To: <bug-30521-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30521-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30521-70-ruB12Fgvvf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30521
    
    Niamh Walker-Headon <Niamh.WalkerHeadon at hse.ie> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |Niamh.WalkerHeadon at hse.ie
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 11:51:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 09:51:54 +0000
    Subject: [Koha-bugs] [Bug 30518] StockRotationItems crossing DST boundary
     throw invalid local time exception
    In-Reply-To: <bug-30518-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30518-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30518-70-hFcCboO3Zq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30518
    
    --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133233
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133233&action=edit
    Bug 30518: Unit test
    
    This patch adds tests for checking the needs_advancing method against
    a timezone and datetime that would cause an Invalid local time failure
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
       k$ prove t/db_dependent/StockRotationItems.t
    => FAIL: The feature is not implemented, tests fail to complete
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 11:51:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 09:51:59 +0000
    Subject: [Koha-bugs] [Bug 30518] StockRotationItems crossing DST boundary
     throw invalid local time exception
    In-Reply-To: <bug-30518-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30518-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30518-70-5GUmtkMwx7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30518
    
    --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133234
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133234&action=edit
    Bug 30518: Correct DateTime maths for needs_advancing
    
    The needs_advancing method prior to this patch used basic DateTime
    arithmatic, adding a DateTime::Duration in Days to the Arrival date of
    the item and then comparing that to today. This, however, can cause bugs
    when the arrival + duration date coincides with a DST boundary and as
    such may result in an invalid local date.  See
    https://metacpan.org/pod/DateTime#Making-Things-Simple for further
    details.
    
    This patch updates the code to use the DST safe delta_days method to
    count the days between arrival and now instead and then compares this
    integer to the defined duration of the stage.
    
    To test:
    1. Re-run the unit tests, they should now pass.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 11:52:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 09:52:19 +0000
    Subject: [Koha-bugs] [Bug 30518] StockRotationItems crossing DST boundary
     throw invalid local time exception
    In-Reply-To: <bug-30518-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30518-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30518-70-iXx8R8POFT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30518
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 12:50:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 10:50:22 +0000
    Subject: [Koha-bugs] [Bug 18986] High Hold Items with Decreased Loan Period
     Can't Be Checked-Out with Self-Check
    In-Reply-To: <bug-18986-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18986-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18986-70-3NvxcObB1g@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18986
    
    Kalle Karlsson <kalle at imcode.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kalle at imcode.com
    
    --- Comment #6 from Kalle Karlsson <kalle at imcode.com> ---
    (In reply to Martin Renvoize from comment #5)
    > I believe this may have been another manifestation of bug 26301.. can we
    > varify whether this is still a problem on current master?
    
    It is still an issue for our clients atleast. Haven't found a workaround to it.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 13:21:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 11:21:08 +0000
    Subject: [Koha-bugs] [Bug 29596] Add Yiddish language
    In-Reply-To: <bug-29596-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29596-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29596-70-mPXQjM4jYl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596
    
    Hans Pålsson <hans.palsson at hkr.se> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |hans.palsson at hkr.se
    
    --- Comment #26 from Hans Pålsson <hans.palsson at hkr.se> ---
    (In reply to David Nind from comment #8)
    > I have tested on top of bug 15067.
    > 
    > After applying 29956 I ran databaseupdate several times (x4) - this makes
    > the language appear multiple times (x4) as well.
    > 
    > I'm not sure that is what you meant though...
    
    Having issues upgrading to 21.11.02.003 possibly related to this. 
    "Upgrade to 21.11.02.003 [13:16:35]: Bug 29605 - Resync DB structure for
    existing installations
    ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry 'yi'
    for key 'PRIMARY' at /usr/share/koha/lib/C4/Installer.pm line 738"
    
    Looking in PMA for the DB table `language_script_mapping` looks like this;
    language_subtag script_subtag
    ar              Arab
    he              Hebr
    yi              Hebr
    yi              Hebr
    yi              Hebr
    yi              Hebr
    yi              Hebr
    yi              Hebr
    yi              Hebr
    yi              Hebr
    
    I am unsure if clearing the table of multiple entries will make or brake the
    instance further.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 13:30:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 11:30:24 +0000
    Subject: [Koha-bugs] [Bug 30522] New: merge authorities has a max limit of
     100 on number of linked biblios it will modify
    Message-ID: <bug-30522-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30522
    
                Bug ID: 30522
               Summary: merge authorities has a max limit of 100 on number of
                        linked biblios it will modify
     Change sponsored?: ---
               Product: Koha
               Version: 21.11
              Hardware: All
                    OS: All
                Status: NEW
              Severity: minor
              Priority: P5 - low
             Component: Cataloging
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: bernard.scaife at ptfs-europe.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: m.de.rooy at rijksmuseum.nl
    
    With systempreference AuthorityMergeLimit set to say 50, if you amend an
    authority record which has more than 100 linked bibs and run merge_authorities
    -b -v - then only the first 100 bibs are amended to match the authority. The
    remaining ones are unmodified.
    
    I think it relates to line 81 of /Koha/Authorities.pm and what is returned to
    the variable  $result.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 13:32:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 11:32:03 +0000
    Subject: [Koha-bugs] [Bug 30430] UNIMARC XSLT : displaying field B_214
    In-Reply-To: <bug-30430-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30430-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30430-70-z86iZDvnAi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430
    
    François Pichenot <fpichenot at ville-roubaix.fr> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132872|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from François Pichenot <fpichenot at ville-roubaix.fr> ---
    Created attachment 133235
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133235&action=edit
    Bug 30430: UNIMARC XSLT add field B214 display
    
    test plan :
    - Apply patch
    - Find a record with a B214
    - Check on both Opac-Details and Opac-Result that the field is
      displayed.
    - Do the same checks on catalogue/search results and catalogue/details
      in Staff interface.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 13:36:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 11:36:57 +0000
    Subject: [Koha-bugs] [Bug 29596] Add Yiddish language
    In-Reply-To: <bug-29596-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29596-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29596-70-rvx80jiykq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596
    
    --- Comment #27 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    (In reply to Hans Pålsson from comment #26)
    > (In reply to David Nind from comment #8)
    > > I have tested on top of bug 15067.
    > > 
    > > After applying 29956 I ran databaseupdate several times (x4) - this makes
    > > the language appear multiple times (x4) as well.
    > > 
    > > I'm not sure that is what you meant though...
    > 
    > Having issues upgrading to 21.11.02.003 possibly related to this. 
    > "Upgrade to 21.11.02.003 [13:16:35]: Bug 29605 - Resync DB structure for
    > existing installations
    > ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry
    > 'yi' for key 'PRIMARY' at /usr/share/koha/lib/C4/Installer.pm line 738"
    > 
    > Looking in PMA for the DB table `language_script_mapping` looks like this;
    > language_subtag script_subtag
    > ar              Arab
    > he              Hebr
    > yi              Hebr
    > yi              Hebr
    > yi              Hebr
    > yi              Hebr
    > yi              Hebr
    > yi              Hebr
    > yi              Hebr
    > yi              Hebr
    > 
    > I am unsure if clearing the table of multiple entries will make or brake the
    > instance further.
    
    Remove the repeated entries. You're safe.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 13:40:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 11:40:30 +0000
    Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail
    In-Reply-To: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29631-70-a0eNEGJeMm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631
    
    Hans Pålsson <hans.palsson at hkr.se> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |hans.palsson at hkr.se
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 13:56:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 11:56:28 +0000
    Subject: [Koha-bugs] [Bug 30474] Convert tools pages tabs to Bootstrap (part
     1)
    In-Reply-To: <bug-30474-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30474-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30474-70-pnN4BwjFt7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 13:56:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 11:56:32 +0000
    Subject: [Koha-bugs] [Bug 30474] Convert tools pages tabs to Bootstrap (part
     1)
    In-Reply-To: <bug-30474-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30474-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30474-70-buoCMSs8QC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133046|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133236
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133236&action=edit
    Bug 30474: Convert tools pages tabs to Bootstrap (part 1)
    
    This patch converts jQueryUI tabs on three tools templates to Bootstrap
    tabs.
    
    To test, apply the patch and go to Tools -> HTML customizations.
    
    - Click "New entry."
    - On the entry form you should see two tabs, "Default" and "English
      (en)"
    - The tabs should look correct and work correctly.
    
    Go to Tools -> Batch record deletion.
    
     - Test the three tabs: "Upload a file", "Select a list of records", and
       "Enter a list of record numbers."
    
    Go to Tools -> Batch record modification.
    
     -  Test the same three tabs on this page.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 13:56:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 11:56:37 +0000
    Subject: [Koha-bugs] [Bug 30474] Convert tools pages tabs to Bootstrap (part
     1)
    In-Reply-To: <bug-30474-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30474-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30474-70-hpDos7Dj6R@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474
    
    --- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133237
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133237&action=edit
    Bug 30474: (follow-up) Tie editor initialization to tab activation
    
    The way Bootstrap tabs manipulate the DOM, CodeMirror has problems
    initializing correctly, I think because of redraws and CodeMirror's
    attemps to position things absolutely.
    
    The solution seems to be to wait until after a Bootstrap tab has
    activated before initializing the CodeMirror instance. This patch
    implements that, along with a check to prevent double-initializing the
    same textarea.
    
    I've also made a similar change to the way TinyMCE is initialized, which
    I hope will help with the issue of the editor not always loading
    correctly.
    
    To test, apply the patch and go to Tools -> HTML customizations.
    
    - Test creation and editing of HTML customization entries using both
      the default editor and the text editor (Edit -> Edit with text
      editor).
    - Verify that the editor (CodeMirror or TinyMCE) loads correctly and
      looks correct, both upon page load and upon switching tabs between
      "Default" and other language tabs
    - Verify that your edits are saved correctly.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 14:04:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 12:04:39 +0000
    Subject: [Koha-bugs] [Bug 29146] Default values from the framework should
     only be applied at biblio/item creation
    In-Reply-To: <bug-29146-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29146-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29146-70-uSV3mgoXGJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146
    
    pierre.genty at biblibre.com changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |pierre.genty at biblibre.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 14:10:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 12:10:39 +0000
    Subject: [Koha-bugs] [Bug 30522] merge authorities has a max limit of 100 on
     number of linked biblios it will modify
    In-Reply-To: <bug-30522-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30522-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30522-70-HLBnmclDki@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30522
    
    --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Interesting. Could provide details about the version you experience this?
    
    I tested this:
    
    use Modern::Perl;
    use Data::Dumper qw/Dumper/;
    use Koha::Authorities;
    my @biblionumbers = Koha::Authorities->linked_biblionumbers({ authid => 1 });
    print Dumper( scalar @biblionumbers );
    
    I have 149 biblionumbers attached to authid 1.
    And got this result:
    
    $VAR1 = 149;
    
    So that should be fine (as a first check).
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 14:13:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 12:13:13 +0000
    Subject: [Koha-bugs] [Bug 30518] StockRotationItems crossing DST boundary
     throw invalid local time exception
    In-Reply-To: <bug-30518-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30518-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30518-70-xpPoUiCyel@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30518
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |nick at bywatersolutions.com,
                       |                            |tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 14:15:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 12:15:10 +0000
    Subject: [Koha-bugs] [Bug 30522] merge authorities has a max limit of 100 on
     number of linked biblios it will modify
    In-Reply-To: <bug-30522-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30522-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30522-70-BP7bS5skGA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30522
    
    --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    But I am seeing something funny.
    >From my 149 records, 148 records have been updated when I made a change in the
    authority. But one record (somewhere in the middle) has not been updated!
    
    Note that 148 > 100 records and this tells me that your problem does not occur
    in current master. And I do think that 21.11 and master are not different as to
    merging authorities.
    
    Could you clarify/show more details about your conclusion that only 100 records
    were updated in your catalog? How do you reach that conclusion?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 14:16:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 12:16:01 +0000
    Subject: [Koha-bugs] [Bug 30522] merge authorities has a max limit of 100 on
     number of linked biblios it will modify
    In-Reply-To: <bug-30522-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30522-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30522-70-bRRoBoHxZj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30522
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
              Component|Cataloging                  |MARC Authority data support
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 14:17:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 12:17:54 +0000
    Subject: [Koha-bugs] [Bug 30523] New: Quiet console warning about missing
     shortcut-buttons map file
    Message-ID: <bug-30523-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30523
    
                Bug ID: 30523
               Summary: Quiet console warning about missing shortcut-buttons
                        map file
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: enhancement
              Priority: P5 - low
             Component: Templates
              Assignee: oleonard at myacpl.org
              Reporter: oleonard at myacpl.org
            QA Contact: testopia at bugs.koha-community.org
    
    The Flatpickr addon shortcut-buttons-flatpickr includes a line referring to a
    non-existent map file:
    
    //# sourceMappingURL=shortcut-buttons-flatpickr.min.js.map
    
    I propose removing this line, and updating the addon to the latest version
    while I'm at it.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 14:26:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 12:26:24 +0000
    Subject: [Koha-bugs] [Bug 29596] Add Yiddish language
    In-Reply-To: <bug-29596-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29596-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29596-70-U3SMaINGNh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596
    
    --- Comment #28 from Hans Pålsson <hans.palsson at hkr.se> ---
    Cleared, problem solved. Thanks!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 14:31:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 12:31:57 +0000
    Subject: [Koha-bugs] [Bug 30522] merge authorities has a max limit of 100 on
     number of linked biblios it will modify
    In-Reply-To: <bug-30522-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30522-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30522-70-Gvndijx3qi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30522
    
    --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Marcel de Rooy from comment #2)
    > From my 149 records, 148 records have been updated when I made a change in
    > the authority. But one record (somewhere in the middle) has not been updated!
    
    This must have been something else. From a previous test. Created with
    build_sample_biblio.
    
    I removed all those records. Created 200 records. Linked to authid 1.
    Changed authid 1. All 200 records are merged by the cron script.
    All working fine.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 14:32:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 12:32:41 +0000
    Subject: [Koha-bugs] [Bug 30522] Issue with merge_authorities script ?
    In-Reply-To: <bug-30522-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30522-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30522-70-lD98zK3CQF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30522
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|merge authorities has a max |Issue with
                       |limit of 100 on number of   |merge_authorities script ?
                       |linked biblios it will      |
                       |modify                      |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 14:36:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 12:36:22 +0000
    Subject: [Koha-bugs] [Bug 25995] Log changes to due date using bulk edit
     tool in circulation log
    In-Reply-To: <bug-25995-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25995-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25995-70-JojJw6f108@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25995
    
    Sally <sally.healey at cheshiresharedservices.gov.uk> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |sally.healey at cheshireshared
                       |                            |services.gov.uk
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 14:51:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 12:51:32 +0000
    Subject: [Koha-bugs] [Bug 30410] Add a way for plugins to register
     background tasks
    In-Reply-To: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30410-70-AO7d7FbUai@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
    
    --- Comment #14 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Please add to https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:07:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:07:35 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-btJkkRMWCn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Patch doesn't apply         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:07:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:07:46 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-Q7Ldb14FWf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #130408|0                           |1
            is obsolete|                            |
     Attachment #130409|0                           |1
            is obsolete|                            |
    
    --- Comment #9 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133252
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133252&action=edit
    Bug 29155: Upgrade jQuery and jQuery Migrate to latest versions
    
    jQuery is upgraded from 2.2.3 to 3.6.0.
    jQuery Migrate is upgraded from 1.3.0 to 3.3.2.
    
    The next patch will update links to point to the new assets.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:07:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:07:52 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-x8qzncBjjU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    
    --- Comment #10 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133253
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133253&action=edit
    Bug 29155: Update links to jQuery and jQuery Migrate files
    
    With these patches, jQuery versions in the OPAC and staff interface are
    both updated to 3.6.0. The latest version of jQuery Migrate is installed
    to allow us to take a slower approach to updating out-of-date syntax.
    
    To test, apply the patch and try as many pages as you can, paying
    attention to the browser console to watch for errors.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:09:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:09:21 +0000
    Subject: [Koha-bugs] [Bug 30522] Issue with merge_authorities script ?
    In-Reply-To: <bug-30522-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30522-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30522-70-PVg8DtvFL9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30522
    
    --- Comment #4 from Bernard <bernard.scaife at ptfs-europe.com> ---
    It's version 21.11.01.000
    
    I've just run your little script:
    
    use Modern::Perl;
    use Data::Dumper qw/Dumper/;
    use Koha::Authorities;
    my @biblionumbers = Koha::Authorities->linked_biblionumbers({ authid => 7307
    });
    print Dumper( scalar @biblionumbers );
    
    >>>
    
    $ perl /home2/kfc/kohaclone/Koha/bertest.pl
    $VAR1 = 100;
    
    There are 104 bib records linked to this authority
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:12:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:12:26 +0000
    Subject: [Koha-bugs] [Bug 30135] We should allow configuration of whether
     EDI LSQ segments map to 'location' or 'collection'
    In-Reply-To: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30135-70-e8jX46Iqhn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135
    
    --- Comment #15 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Created attachment 133259
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133259&action=edit
    Bug 30135: (QA follow-up) Fix typo in sysprefs.sql
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:13:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:13:01 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-ZBnwUdPZ0f@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    
    --- Comment #11 from Owen Leonard <oleonard at myacpl.org> ---
    (In reply to David Cook from comment #6)
    > error: sha1 information is lacking or useless
    
    Applying on master resulted in a little auto-merging but nothing like this. I
    don't know what was happening for you. Please try again!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:18:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:18:45 +0000
    Subject: [Koha-bugs] [Bug 30139] Point of sale sets wrong 'Amount being
     paid' with CurrencyFormat = FR
    In-Reply-To: <bug-30139-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30139-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30139-70-nk9AEk8I5Z@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30139
    
    Hanna Dehlin <hanna.dehlin at hkr.se> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |hanna.dehlin at hkr.se
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:21:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:21:11 +0000
    Subject: [Koha-bugs] [Bug 30279] Log when personal data is displayed in
     staff client
    In-Reply-To: <bug-30279-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30279-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30279-70-gQksZ5kyt4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30279
    
    Ola Andersson <ola.andersson at ltu.se> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |In Discussion
    
    --- Comment #14 from Ola Andersson <ola.andersson at ltu.se> ---
    There will be various ways of accessing personal information if you are skilled
    in Koha but the idea is to log obvious upfront abuse by staff. There will, when
    this patch is in place, be possible to communicate in the organisation that the
    system logs abuse of the Koha system.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:40:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:40:51 +0000
    Subject: [Koha-bugs] [Bug 29744] Harmonize psgi/plack detection methods
    In-Reply-To: <bug-29744-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29744-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29744-70-cxB4GpAGZj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
                 Status|Passed QA                   |Failed QA
    
    --- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    I cant get this working.
    With Bug 29420 and this one I get directly the error :
    
    psgi:exit at /kohadevbox/koha/C4/Auth.pm line 59
           59:     if   (C4::Context::psgi_env) { die 'psgi:exit' }
    
    I tried to remove manually the session cookie but same problem.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:44:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:44:34 +0000
    Subject: [Koha-bugs] [Bug 30525] New: Items batch modification broken
    Message-ID: <bug-30525-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30525
    
                Bug ID: 30525
               Summary: Items batch modification broken
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: critical
              Priority: P5 - low
             Component: Templates
              Assignee: oleonard at myacpl.org
              Reporter: fridolin.somers at biblibre.com
            QA Contact: testopia at bugs.koha-community.org
    
    Items batch modification is broken looks like it is since Bug 29957
    
    I get the error :
    
    Can't call method "value" on an undefined value at
    /kohadevbox/koha/tools/batchMod.pl line 87
           86: my %cookies = parse CGI::Cookie($cookie);
           87: my $sessionID = $cookies{'CGISESSID'}->value;
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:44:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:44:55 +0000
    Subject: [Koha-bugs] [Bug 30525] Items batch modification broken
    In-Reply-To: <bug-30525-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30525-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30525-70-SY0k3Xsita@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30525
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |29957
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29957
    [Bug 29957] Cookies not removed after logout
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:44:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:44:55 +0000
    Subject: [Koha-bugs] [Bug 29957] Cookies not removed after logout
    In-Reply-To: <bug-29957-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29957-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29957-70-KcHBrNqz3Z@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29957
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30525
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30525
    [Bug 30525] Items batch modification broken
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:56:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:56:42 +0000
    Subject: [Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off
    In-Reply-To: <bug-16258-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-16258-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-16258-70-S5IDaEawlk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:56:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:56:45 +0000
    Subject: [Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off
    In-Reply-To: <bug-16258-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-16258-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-16258-70-hDZdodvSVY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258
    
    --- Comment #61 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:56:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:56:48 +0000
    Subject: [Koha-bugs] [Bug 26019] Koha should set SameSite attribute on
     cookies
    In-Reply-To: <bug-26019-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26019-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26019-70-SP950s0S4C@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26019
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:56:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:56:51 +0000
    Subject: [Koha-bugs] [Bug 26019] Koha should set SameSite attribute on
     cookies
    In-Reply-To: <bug-26019-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26019-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26019-70-fHNTUP05ON@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26019
    
    --- Comment #24 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:56:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:56:54 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-00xfYv77qv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:56:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:56:57 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-f0V6sG427s@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    --- Comment #58 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:57:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:57:00 +0000
    Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use
     Font Awesome icons
    In-Reply-To: <bug-29066-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29066-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29066-70-v66XF0uLcl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:57:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:57:03 +0000
    Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use
     Font Awesome icons
    In-Reply-To: <bug-29066-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29066-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29066-70-NYMXhHbEiX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
    
    --- Comment #28 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:57:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:57:07 +0000
    Subject: [Koha-bugs] [Bug 29946] Sort profiles alphabetically when staging
     MARC records for import
    In-Reply-To: <bug-29946-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29946-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29946-70-p3hk2X8R97@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29946
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:57:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:57:09 +0000
    Subject: [Koha-bugs] [Bug 29946] Sort profiles alphabetically when staging
     MARC records for import
    In-Reply-To: <bug-29946-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29946-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29946-70-ZKBoDgWtaU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29946
    
    --- Comment #12 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:57:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:57:14 +0000
    Subject: [Koha-bugs] [Bug 30130] Allow setting EDI type at the vendor level
    In-Reply-To: <bug-30130-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30130-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30130-70-OD9fR7YKKw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:57:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:57:18 +0000
    Subject: [Koha-bugs] [Bug 30130] Allow setting EDI type at the vendor level
    In-Reply-To: <bug-30130-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30130-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30130-70-v9yG0mGkIm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130
    
    --- Comment #24 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:57:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:57:20 +0000
    Subject: [Koha-bugs] [Bug 30135] We should allow configuration of whether
     EDI LSQ segments map to 'location' or 'collection'
    In-Reply-To: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30135-70-6O2qX4dAPv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:57:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:57:28 +0000
    Subject: [Koha-bugs] [Bug 30135] We should allow configuration of whether
     EDI LSQ segments map to 'location' or 'collection'
    In-Reply-To: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30135-70-tVWgEuID2m@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135
    
    --- Comment #16 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:57:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:57:33 +0000
    Subject: [Koha-bugs] [Bug 30142] ElasticSearch MARC mappings should not
     accept whitespaces
    In-Reply-To: <bug-30142-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30142-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30142-70-ZulCQnqKPM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30142
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:57:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:57:36 +0000
    Subject: [Koha-bugs] [Bug 30142] ElasticSearch MARC mappings should not
     accept whitespaces
    In-Reply-To: <bug-30142-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30142-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30142-70-ePIsp2pI3b@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30142
    
    --- Comment #6 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:57:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:57:40 +0000
    Subject: [Koha-bugs] [Bug 30376] Unable to save item if field date acquired
     is set mandatory
    In-Reply-To: <bug-30376-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30376-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30376-70-cAWzM3sxqb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30376
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:57:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:57:44 +0000
    Subject: [Koha-bugs] [Bug 30376] Unable to save item if field date acquired
     is set mandatory
    In-Reply-To: <bug-30376-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30376-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30376-70-4bc6iCuJlr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30376
    
    --- Comment #10 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:57:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:57:47 +0000
    Subject: [Koha-bugs] [Bug 30406] Our DT tables not filtering on the correct
     column if hidden by default
    In-Reply-To: <bug-30406-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30406-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30406-70-xw2FRXWdjj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30406
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:57:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:57:50 +0000
    Subject: [Koha-bugs] [Bug 30406] Our DT tables not filtering on the correct
     column if hidden by default
    In-Reply-To: <bug-30406-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30406-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30406-70-Rk2iDX8crt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30406
    
    --- Comment #7 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:57:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:57:54 +0000
    Subject: [Koha-bugs] [Bug 30410] Add a way for plugins to register
     background tasks
    In-Reply-To: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30410-70-pFGNp9kVSV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:58:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:58:00 +0000
    Subject: [Koha-bugs] [Bug 30410] Add a way for plugins to register
     background tasks
    In-Reply-To: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30410-70-SuLrCOSHgt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410
    
    --- Comment #15 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:58:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:58:04 +0000
    Subject: [Koha-bugs] [Bug 30426] suggestion service missing Auth and Output
     imports
    In-Reply-To: <bug-30426-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30426-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30426-70-H0jmA0Rp47@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30426
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:58:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:58:10 +0000
    Subject: [Koha-bugs] [Bug 30426] suggestion service missing Auth and Output
     imports
    In-Reply-To: <bug-30426-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30426-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30426-70-lcJAwS2YBQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30426
    
    --- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:58:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:58:13 +0000
    Subject: [Koha-bugs] [Bug 30476] Remove NORMARC translation files
    In-Reply-To: <bug-30476-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30476-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30476-70-R0UrmryLhg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30476
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:58:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:58:17 +0000
    Subject: [Koha-bugs] [Bug 30476] Remove NORMARC translation files
    In-Reply-To: <bug-30476-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30476-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30476-70-fgVFvBCKE9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30476
    
    --- Comment #3 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:58:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:58:22 +0000
    Subject: [Koha-bugs] [Bug 30481] Drop unique constraint
     deleteditemsstocknumberidx for deleteditems
    In-Reply-To: <bug-30481-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30481-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30481-70-4n2oN3km39@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30481
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:58:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:58:29 +0000
    Subject: [Koha-bugs] [Bug 30481] Drop unique constraint
     deleteditemsstocknumberidx for deleteditems
    In-Reply-To: <bug-30481-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30481-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30481-70-zdqecfQCQc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30481
    
    --- Comment #8 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:58:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:58:33 +0000
    Subject: [Koha-bugs] [Bug 30485] Searching all patrons from the header does
     not display the patron search view
    In-Reply-To: <bug-30485-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30485-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30485-70-RG692goKvV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30485
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:58:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:58:38 +0000
    Subject: [Koha-bugs] [Bug 30485] Searching all patrons from the header does
     not display the patron search view
    In-Reply-To: <bug-30485-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30485-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30485-70-7rsuebbrGu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30485
    
    --- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:58:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:58:43 +0000
    Subject: [Koha-bugs] [Bug 30498] Enum search_field.type should contain year
     in kohastructure
    In-Reply-To: <bug-30498-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30498-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30498-70-wvxMybIst9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30498
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 15:58:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 13:58:48 +0000
    Subject: [Koha-bugs] [Bug 30498] Enum search_field.type should contain year
     in kohastructure
    In-Reply-To: <bug-30498-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30498-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30498-70-v8E0UyHvIS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30498
    
    --- Comment #7 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 16:06:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 14:06:19 +0000
    Subject: [Koha-bugs] [Bug 30526] New: The pagination in the REST API does
     not work if $c->objects->search is called multiple times.
    Message-ID: <bug-30526-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30526
    
                Bug ID: 30526
               Summary: The pagination in the REST API does not work if
                        $c->objects->search is called multiple times.
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: REST API
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: andreas.jonsson at kreablo.se
                    CC: tomascohen at gmail.com
    
    The REST-plugin Koha::REST::Plugin::Pagination defines two methods:
    dbic_merge_pagination and add_pagination_headers.  The method
    add_pagination_headers use the helper subroutine _build_link.  The last
    call in add_pagination_headers looks like this:
    
                push @links,
                    _build_link( $c,
                    { page => $pages, per_page => $per_page, rel => 'last', params
    => $args->{params} } );
    
    Here is _build_link:
    
    sub _build_link {
        my ( $c, $args ) = @_;
    
        my $params = $args->{params};
    
        $params->{_page}     = $args->{page};
        $params->{_per_page} = $args->{per_page};
    
    
    Note that the original parameters _page and _per_page is overwritten
    here.  This means that _page will be $pages.  Subsequent calls to
    $c->objects->search will, thus, always return the last page.
    
    At least REST::V1::Holds::pickup_locations is affected by this
    (because a redundant call to $c->objects->search is made if
    AllowHoldPolicyOverride is activated).  This causes the dropdown menu with
    pickup locations in the holds view to only contain the last page of libraries
    if there are more than 20 pickup libraries and AllowHoldPolicyOverride is
    activated.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 16:06:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 14:06:31 +0000
    Subject: [Koha-bugs] [Bug 30525] Items batch modification broken
    In-Reply-To: <bug-30525-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30525-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30525-70-SAUfPO0zpK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30525
    
    --- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    We see 2 ways :
    
     > git grep 'CGI::Cookie->fetch'
    admin/import_export_authtype.pl:my %cookies = CGI::Cookie->fetch();
    admin/import_export_framework.pl:my %cookies = CGI::Cookie->fetch();
    authorities/merge_ajax.pl:my %cookies = CGI::Cookie->fetch;
    cataloguing/merge_ajax.pl:my %cookies = CGI::Cookie->fetch;
    opac/opac-ratings-ajax.pl:    my %cookies      = CGI::Cookie->fetch;
    opac/opac-tags.pl:    my %cookies = CGI::Cookie->fetch;
    tags/review.pl:    my %cookies = CGI::Cookie->fetch;
    tools/background-job-progress.pl:my %cookies = CGI::Cookie->fetch;
    tools/upload-file.pl:my %cookies = CGI::Cookie->fetch;
    16:05:46 ~/git/koha-master [ master | v21.11.00 p+1076 | u= ]
     > git grep 'parse CGI::Cookie'
    offline_circ/enqueue_koc.pl:my %cookies = parse CGI::Cookie($cookie);
    offline_circ/process_koc.pl:my %cookies = parse CGI::Cookie($cookie);
    tools/batchMod.pl:my %cookies = parse CGI::Cookie($cookie);
    tools/manage-marc-import.pl:my %cookies = parse CGI::Cookie($cookie);
    tools/modborrowers.pl:my %cookies   = parse CGI::Cookie($cookie);
    tools/stage-marc-import.pl:my %cookies = parse CGI::Cookie($cookie);
    tools/upload-cover-image.pl:my %cookies   = parse CGI::Cookie($cookie);
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 16:09:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 14:09:26 +0000
    Subject: [Koha-bugs] [Bug 30526] The pagination in the REST API does not
     work if $c->objects->search is called multiple times.
    In-Reply-To: <bug-30526-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30526-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30526-70-CogOYD0dUP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30526
    
    --- Comment #1 from Andreas Jonsson <andreas.jonsson at kreablo.se> ---
    Created attachment 133262
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133262&action=edit
    Bug 30526: Copy parameters when building links in rest api.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 16:09:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 14:09:42 +0000
    Subject: [Koha-bugs] [Bug 30522] SearchEngine::simple_search_compat should
     not limit to 100 records for ElasticSearch
    In-Reply-To: <bug-30522-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30522-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30522-70-h8gzEeC2rI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30522
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Severity|minor                       |normal
             QA Contact|testopia at bugs.koha-communit |
                       |y.org                       |
                     CC|                            |nick at bywatersolutions.com,
                       |                            |tomascohen at gmail.com
                Version|21.11                       |master
              Component|MARC Authority data support |Searching - Elasticsearch
                Summary|Issue with                  |SearchEngine::simple_search
                       |merge_authorities script ?  |_compat should not limit to
                       |                            |100 records for
                       |                            |ElasticSearch
    
    --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Bernard from comment #4)
    > It's version 21.11.01.000
    > 
    > I've just run your little script:
    > 
    > use Modern::Perl;
    > use Data::Dumper qw/Dumper/;
    > use Koha::Authorities;
    > my @biblionumbers = Koha::Authorities->linked_biblionumbers({ authid => 7307
    > });
    > print Dumper( scalar @biblionumbers );
    > 
    > >>>
    > 
    > $ perl /home2/kfc/kohaclone/Koha/bertest.pl
    > $VAR1 = 100;
    > 
    > There are 104 bib records linked to this authority
    
    Found it!
    You are using ElasticSearch, I used Zebra.
    The cause is in the Koha/SearchEngine/ElasticSearch/Search.pm module:
    
    sub simple_search_compat {
        my ($self, $query, $offset, $max_results) = @_;
        return ('No query entered', undef, undef) unless $query;
        my %options;
        $offset = 0 if not defined $offset or $offset < 0;
        $options{offset} = $offset;
        $max_results //= 100;
    
    => This sub expects a max_results parameter for Elastic while the Zebra one
    does not require it. No max_results means there all results.
    So we need to adjust that one somehow. CCing Nick and Tomas.
    
    Good catch !
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 16:11:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 14:11:23 +0000
    Subject: [Koha-bugs] [Bug 30522] SearchEngine::simple_search_compat should
     not limit to 100 records for ElasticSearch
    In-Reply-To: <bug-30522-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30522-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30522-70-Z3ktjWyIie@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30522
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Severity|normal                      |major
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 16:18:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 14:18:10 +0000
    Subject: [Koha-bugs] [Bug 30522] SearchEngine::simple_search_compat should
     not limit to 100 records for ElasticSearch (causing incomplete authority
     merges)
    In-Reply-To: <bug-30522-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30522-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30522-70-0er8pk8jTE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30522
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|SearchEngine::simple_search |SearchEngine::simple_search
                       |_compat should not limit to |_compat should not limit to
                       |100 records for             |100 records for
                       |ElasticSearch               |ElasticSearch (causing
                       |                            |incomplete authority
                       |                            |merges)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 16:23:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 14:23:11 +0000
    Subject: [Koha-bugs] [Bug 30526] The pagination in the REST API does not
     work if $c->objects->search is called multiple times.
    In-Reply-To: <bug-30526-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30526-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30526-70-xT3NlzWWeX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30526
    
    Andreas Jonsson <andreas.jonsson at kreablo.se> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    --- Comment #2 from Andreas Jonsson <andreas.jonsson at kreablo.se> ---
    Test plan:
    
    * Make sure you have at least 3 libraries that may be pickup locations.
    * Activate the system preference AllowHoldPolicyOverride
    * Change the system preference  RESTdefaultPageSize to 1
    * Go to a record and make a place a hold.
    * In the Holds view for the record, verify that all libraries appear in the
    pickup library drop down menu on the hold.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 16:36:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 14:36:40 +0000
    Subject: [Koha-bugs] [Bug 30522] SearchEngine::simple_search_compat should
     not limit to 100 records for ElasticSearch (causing incomplete authority
     merges)
    In-Reply-To: <bug-30522-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30522-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30522-70-neyKqxAWUm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30522
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 16:52:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 14:52:59 +0000
    Subject: [Koha-bugs] [Bug 30527] New: Limits are not correctly parsed when
     query contains CCL
    Message-ID: <bug-30527-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30527
    
                Bug ID: 30527
               Summary: Limits are not correctly parsed when query contains
                        CCL
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Searching - Zebra
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: nick at bywatersolutions.com
    
    This was made more apparent by bug 17170 - when a special limit that needs
    parsing is passed along witha query containing CCL indexes then the limits are
    not parsed (with exception of 'available' which is handled)
    
    This is due to a clause the prevents the normal parsing in
    C4::Search::buildQuery
    
    To test:
    1 - Perform advanced search in staff client
    2 - Select 'More options'
    3 - In first box with keyword as index type 'ti:a'
    4 - Enter a year into Limits
    5 - Search
    6 - You see only 'ti:a' in description, and search fails
    
    with bug 17170
    1 - Save a search filter visible in staff client
    2 - Perform a search like 'ti:a'
    3 - Attempt to filter using custom filter
    4 - In plack intranet error log:
    [2022/04/13 14:14:51] [WARN] WARNING: query problem with ti=a and
    search_filter=94 ZOOM error 10014 "CCL parsing error" (addinfo: "Unknown
    qualifier") from diag-set 'ZOOM' at /kohadevbox/koha/C4/Search.pm line 352.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 16:53:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 14:53:19 +0000
    Subject: [Koha-bugs] [Bug 30528] New: Limits are not correctly parsed when
     query contains CCL
    Message-ID: <bug-30528-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30528
    
                Bug ID: 30528
               Summary: Limits are not correctly parsed when query contains
                        CCL
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Searching - Zebra
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: nick at bywatersolutions.com
    
    This was made more apparent by bug 17170 - when a special limit that needs
    parsing is passed along witha query containing CCL indexes then the limits are
    not parsed (with exception of 'available' which is handled)
    
    This is due to a clause the prevents the normal parsing in
    C4::Search::buildQuery
    
    To test:
    1 - Perform advanced search in staff client
    2 - Select 'More options'
    3 - In first box with keyword as index type 'ti:a'
    4 - Enter a year into Limits
    5 - Search
    6 - You see only 'ti:a' in description, and search fails
    
    with bug 17170
    1 - Save a search filter visible in staff client
    2 - Perform a search like 'ti:a'
    3 - Attempt to filter using custom filter
    4 - In plack intranet error log:
    [2022/04/13 14:14:51] [WARN] WARNING: query problem with ti=a and
    search_filter=94 ZOOM error 10014 "CCL parsing error" (addinfo: "Unknown
    qualifier") from diag-set 'ZOOM' at /kohadevbox/koha/C4/Search.pm line 352.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 16:53:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 14:53:40 +0000
    Subject: [Koha-bugs] [Bug 30528] Limits are not correctly parsed when query
     contains CCL
    In-Reply-To: <bug-30528-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30528-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30528-70-eMw3UblNZJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30528
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=17170,
                       |                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=5274
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 16:53:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 14:53:40 +0000
    Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
     for use as filters when searching the catalog
    In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17170-70-cDcZfqsv4E@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30528
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 16:53:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 14:53:40 +0000
    Subject: [Koha-bugs] [Bug 5274] CCL prefixes break search limits
    In-Reply-To: <bug-5274-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-5274-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-5274-70-h3bGg7zmqx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5274
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30528
    
    -- 
    You are receiving this mail because:
    You are the QA Contact for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 16:57:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 14:57:53 +0000
    Subject: [Koha-bugs] [Bug 30529] New: Allow all item fields to be set in
     MARCItemFieldsToOrder
    Message-ID: <bug-30529-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30529
    
                Bug ID: 30529
               Summary: Allow all item fields to be set in
                        MARCItemFieldsToOrder
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Acquisitions
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: andrew at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
    
    The MARCItemFieldsToOrder syspref allows values for a set list of item/order
    fields to be sent in MARC file used in acquisitions. We should broaden that out
    to include any item field to support a broader array of workflows.
    
    Bug 24334 already suggested adding barcode, but I see no reason not to take
    that idea further.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 16:57:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 14:57:53 +0000
    Subject: [Koha-bugs] [Bug 24334] Barcode should be included in
     Marcitemfieldstoorder
    In-Reply-To: <bug-24334-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24334-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24334-70-C45Js0FBjZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24334
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30529
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 16:58:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 14:58:11 +0000
    Subject: [Koha-bugs] [Bug 30526] The pagination in the REST API does not
     work if $c->objects->search is called multiple times.
    In-Reply-To: <bug-30526-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30526-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30526-70-9MCopLsOYO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30526
    
    --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    (In reply to Andreas Jonsson from comment #2)
    > Test plan:
    > 
    > * Make sure you have at least 3 libraries that may be pickup locations.
    > * Activate the system preference AllowHoldPolicyOverride
    > * Change the system preference  RESTdefaultPageSize to 1
    > * Go to a record and make a place a hold.
    > * In the Holds view for the record, verify that all libraries appear in the
    > pickup library drop down menu on the hold.
    
    Hi, nice catch and really happy to see your patch.
    I suggest you take a look at this files:
    
    - t/Koha/REST/Plugin/Pagination.t
    - t/db_dependent/api/v1/pagination.t
    
    in those files, you should add regression tests at different levels.
    
    In case you need it, ping me on IRC (tcohen) or just drop an email to
    koha-devel.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 17:07:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 15:07:19 +0000
    Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
     for use as filters when searching the catalog
    In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17170-70-NKH9YUa2hS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
       Patch complexity|---                         |Medium patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 17:07:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 15:07:23 +0000
    Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
     for use as filters when searching the catalog
    In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17170-70-xg7571Zwwu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170
    
    --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133263
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133263&action=edit
    Bug 17170: DB Updates
    
    This patch adds the new table, permission, and a syspref to enable the feature
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 17:07:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 15:07:28 +0000
    Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
     for use as filters when searching the catalog
    In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17170-70-LGEbi6HWzT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170
    
    --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133264
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133264&action=edit
    Bug 17170: DO NOT PUSH - Schema Updates
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 17:07:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 15:07:31 +0000
    Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
     for use as filters when searching the catalog
    In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17170-70-royNf8mfjd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170
    
    --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133265
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133265&action=edit
    Bug 17170: Update schema for boolean
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 17:07:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 15:07:36 +0000
    Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
     for use as filters when searching the catalog
    In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17170-70-0KvQkyIaLr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170
    
    --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133266
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133266&action=edit
    Bug 17170: Add API route for SearchFilters
    
    This adds the API routes and tests
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 17:07:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 15:07:39 +0000
    Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
     for use as filters when searching the catalog
    In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17170-70-3i3e9ErKQB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170
    
    --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133267
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133267&action=edit
    Bug 17170: Add search filters to staff and opac interfaces
    
    This patch displays the filters on the results pages with the facets
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 17:07:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 15:07:44 +0000
    Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
     for use as filters when searching the catalog
    In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17170-70-ZDA2EmAlel@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170
    
    --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133268
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133268&action=edit
    Bug 17170: Handle search filters in query builders
    
    This patch updates the query building code to expand filters when searching
    and pass them back as part of the cgi and descriptive search strings
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 17:07:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 15:07:47 +0000
    Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
     for use as filters when searching the catalog
    In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17170-70-JFCkckJ4zZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170
    
    --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133269
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133269&action=edit
    Bug 17170: Add admin page for filters and ability to edit/save existing filters
    
    This patchset adds a new ability to save searches on the staff client, and
    display them in the results
    page on staff or opac as a new filter.
    
    New filters can be added from the resuilts page after a search, and there is an
    admin page for updating
    deleting and renaming filters
    
    There is a new permission to control management of these filters
    
    New filters can be added that are not displayed along with facets, this allows
    for building custom links
    using these filters to keep URLs shorter
    
    Due to bug 30528 testing in ES is recommended
    
    To test:
     1 - Apply patches and update database and restart all
     2 - Enable new system preference 'SavedSearchFilters'
     3 - As superlibrarian perform a search in staff client, something broad like
    'a'
     4 - Note new 'Save search as filter' link on results page
     5 - Click it, save search as new filter, check 'Staff client' visibility
     6 - Perform another search
     7 - Note the filter now appears above facets
     8 - Click to it filter results
     9 - Note results are limited by the new filter, and it is checked in the
    facets
    10 - Confirm click the [x] removes the filter
    11 - Go to administration->search filters
    12 - Confirm the filter appears
    13 - Edit and mark as OPAC visible
    14 - Test OPAC to ensure it shows and can be applied/removed
    15 - Copy URL with filter applied
    16 - In adminsitration mark filter as not visible on staff or opac
    17 - Confirm link above still works
    18 - Create a new staff with catalogue and search filters permission
    19 - Ensure they can access/save filters
    20 - Remove filter permission and ensure they cannot
    21 - Disable system preference
    22 - Confirm links to search filters page are removed from admin home and admin
    sidebar
    23 - Confirm filters do not appear on results and cannot be created
    24 - Enable pref
    25 - Create a filter
    26 - From search filters page, click 'Edit search'
    27 - Confirm you are taken to advanced search page letting you know which
    filter you are editing
    28 - Confirm you can change searhc options and save
    29 - Confirm you can perform the search from this page
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 17:07:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 15:07:51 +0000
    Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
     for use as filters when searching the catalog
    In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17170-70-zf8J67uYoP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170
    
    --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133270
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133270&action=edit
    Bug 17170: Unit tests
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 17:08:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 15:08:23 +0000
    Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
     for use as filters when searching the catalog
    In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17170-70-8BiDcZo5kv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |andrew at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 17:22:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 15:22:58 +0000
    Subject: [Koha-bugs] [Bug 30530] New: The translation updates for 21.11.03
     contains the updates made for bug 29525,
     which has not been backported to 21.11
    Message-ID: <bug-30530-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30530
    
                Bug ID: 30530
               Summary: The translation updates for 21.11.03 contains the
                        updates made for bug 29525, which has not been
                        backported to 21.11
     Change sponsored?: ---
               Product: Koha
               Version: 21.11
              Hardware: All
                    OS: All
                Status: NEW
              Severity: major
              Priority: P5 - low
             Component: translate.koha-community.org
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: andreas.jonsson at kreablo.se
            QA Contact: testopia at bugs.koha-community.org
    
    The translation updates for 21.11.03 (commit
    4cd5997464d8c39c48888ca79d1b4437a4e4d260) contains the updates made for bug
    29525 which cause some on the messages on the privacy page to remain
    untranslated.
    
    In particular, these messages are affected:
    
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130256&action=diff
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 17:35:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 15:35:28 +0000
    Subject: [Koha-bugs] [Bug 30307] 21.11 files contain strings from master
     (Recalls)
    In-Reply-To: <bug-30307-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30307-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30307-70-4BGSnAhWn1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30307
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |andreas.jonsson at kreablo.se
    
    --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    *** Bug 30530 has been marked as a duplicate of this bug. ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 17:35:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 15:35:28 +0000
    Subject: [Koha-bugs] [Bug 30530] The translation updates for 21.11.03
     contains the updates made for bug 29525,
     which has not been backported to 21.11
    In-Reply-To: <bug-30530-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30530-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30530-70-TtiETmH42u@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30530
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |RESOLVED
             Resolution|---                         |DUPLICATE
    
    --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Hi Andreas, we have fixed this on Pootle on bug 30307. It should be fixed for
    the latest release 21.11.04.
    
    *** This bug has been marked as a duplicate of bug 30307 ***
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 17:35:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 15:35:34 +0000
    Subject: [Koha-bugs] [Bug 30474] Convert tools pages tabs to Bootstrap (part
     1)
    In-Reply-To: <bug-30474-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30474-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30474-70-OgInTaq6tc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 17:35:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 15:35:37 +0000
    Subject: [Koha-bugs] [Bug 30474] Convert tools pages tabs to Bootstrap (part
     1)
    In-Reply-To: <bug-30474-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30474-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30474-70-4LvDE6hz3a@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133236|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
    Created attachment 133271
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133271&action=edit
    Bug 30474: Convert tools pages tabs to Bootstrap (part 1)
    
    This patch converts jQueryUI tabs on three tools templates to Bootstrap
    tabs.
    
    To test, apply the patch and go to Tools -> HTML customizations.
    
    - Click "New entry."
    - On the entry form you should see two tabs, "Default" and "English
      (en)"
    - The tabs should look correct and work correctly.
    
    Go to Tools -> Batch record deletion.
    
     - Test the three tabs: "Upload a file", "Select a list of records", and
       "Enter a list of record numbers."
    
    Go to Tools -> Batch record modification.
    
     -  Test the same three tabs on this page.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 17:35:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 15:35:40 +0000
    Subject: [Koha-bugs] [Bug 30474] Convert tools pages tabs to Bootstrap (part
     1)
    In-Reply-To: <bug-30474-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30474-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30474-70-XqvaixcadI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133237|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
    Created attachment 133272
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133272&action=edit
    Bug 30474: (follow-up) Tie editor initialization to tab activation
    
    The way Bootstrap tabs manipulate the DOM, CodeMirror has problems
    initializing correctly, I think because of redraws and CodeMirror's
    attemps to position things absolutely.
    
    The solution seems to be to wait until after a Bootstrap tab has
    activated before initializing the CodeMirror instance. This patch
    implements that, along with a check to prevent double-initializing the
    same textarea.
    
    I've also made a similar change to the way TinyMCE is initialized, which
    I hope will help with the issue of the editor not always loading
    correctly.
    
    To test, apply the patch and go to Tools -> HTML customizations.
    
    - Test creation and editing of HTML customization entries using both
      the default editor and the text editor (Edit -> Edit with text
      editor).
    - Verify that the editor (CodeMirror or TinyMCE) loads correctly and
      looks correct, both upon page load and upon switching tabs between
      "Default" and other language tabs
    - Verify that your edits are saved correctly.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 17:54:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 15:54:01 +0000
    Subject: [Koha-bugs] [Bug 30531] New: Search.t needs update for Recalls
    Message-ID: <bug-30531-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30531
    
                Bug ID: 30531
               Summary: Search.t needs update for Recalls
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Test Suite
              Assignee: chris at bigballofwax.co.nz
              Reporter: nick at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
    
    The tests complain:
    The syspref UseRecalls was requested but I don't know what to say; this
    indicates that the test requires updating at t/db_dependent/Search.t line 158.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 17:54:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 15:54:53 +0000
    Subject: [Koha-bugs] [Bug 30525] Items batch modification broken
    In-Reply-To: <bug-30525-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30525-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30525-70-sWV26zrQro@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30525
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 17:54:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 15:54:56 +0000
    Subject: [Koha-bugs] [Bug 30525] Items batch modification broken
    In-Reply-To: <bug-30525-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30525-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30525-70-J3MN5PLIoe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30525
    
    --- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133273
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133273&action=edit
    Bug 30525: Items batch modification broken
    
    This patch modifies instances in the code which try to get cookies
    using:
    
    my %cookies = parse CGI::Cookie($cookie);
    
    In some cases the relevant lines can be removed because they are unused.
    In others it can be replaced with:
    
    my %cookies = CGI::Cookie->fetch();
    
    To test, apply the patch and restart_all. Test the following pages to
    confirm they load without errors:
    
    - Circulation -> Offline circulation file upload
    - Circulation -> Offline circulation -> Add to queue
    
    - Tools -> Batch item modification
    - Tools -> Stage MARC for import
    - Tools -> Staged MARC management
    - Tools -> Batch patron modification
    - Tools -> Upload local cover image
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 18:12:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 16:12:30 +0000
    Subject: [Koha-bugs] [Bug 30220] Purchase suggestion defaults to first
     library
    In-Reply-To: <bug-30220-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30220-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30220-70-fYXzUNq9kv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30220
    
    koha-US bug tracker <bugzilla at koha-us.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |bugzilla at koha-us.org
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 18:14:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 16:14:29 +0000
    Subject: [Koha-bugs] [Bug 29971] Remember selections across patron search
     pages
    In-Reply-To: <bug-29971-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29971-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29971-70-CEQNjA1fng@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Patch doesn't apply
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 18:14:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 16:14:39 +0000
    Subject: [Koha-bugs] [Bug 30248] Multiple Select elements randomly have
     small width
    In-Reply-To: <bug-30248-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30248-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30248-70-752xra05Hl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30248
    
    koha-US bug tracker <bugzilla at koha-us.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |bugzilla at koha-us.org
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 18:21:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 16:21:21 +0000
    Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the
     staff interface with separate system preference
    In-Reply-To: <bug-28307-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28307-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28307-70-sCCFPWUv5l@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131784|0                           |1
            is obsolete|                            |
     Attachment #131785|0                           |1
            is obsolete|                            |
     Attachment #131786|0                           |1
            is obsolete|                            |
    
    --- Comment #18 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133274
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133274&action=edit
    Bug 28307: Make BakerTaylorEnabled preference separate for staff and OPAC
    
    This patch updates the system preferences controlling Baker & Taylor
    content so that there are separate preferences for the OPAC and the
    staff interface. The patch also adds Baker & Taylor cover images to the
    staff client.
    
    To test, apply the patch and run the database update.
    
    - Go to Admnistration -> System preferences -> Enhanced content
    - You should see a BakerTaylorEnabled and a OPACBakerTaylorEnabled
      preference. The OPACBakerTaylorEnabled should have the same setting
      you previously had for BakerTaylorEnabled. The BakerTaylorEnabled
      preference should be turned off.
      - Note that the description of the preferences have been updated to
        include links to the Baker & Taylor username and password
        preferences.
    - Enable both and make sure you have a valid Baker & Taylor username
      and password entered.
    - Perform a search in both the OPAC and staff interface. A Baker &
      Taylor cover image should appear on the bibliographic detail page in
      the OPAC, and on the search results and bibliographic detail page in
      the staff interface.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 18:21:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 16:21:25 +0000
    Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the
     staff interface with separate system preference
    In-Reply-To: <bug-28307-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28307-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28307-70-2AYluRAfw4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307
    
    --- Comment #19 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133275
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133275&action=edit
    Bug 28307: (follow-up) Add proper check for BakerTaylorEnabled
    
    This patch adds a missing check for the BakerTaylorEnabled system
    preference in staff interface search results.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 18:21:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 16:21:30 +0000
    Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the
     staff interface with separate system preference
    In-Reply-To: <bug-28307-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28307-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28307-70-TkJcqmA3RW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307
    
    --- Comment #20 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133276
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133276&action=edit
    Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled
    
    This patch adds the new OPACBakerTaylorEnabled preferences to OPAC
    templates and scripts which were missed in the first patch. The patch
    also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql.
    
    Check these pages in the OPAC:
    
     - Catalog -> Search results
       - And search results -> RSS
     - Catalog -> Bibliographic details page -> Shelf browser
     - Catalog -> Lists -> List contents
     - Catalog -> Recent comments
       - And recent comments -> RSS
     - Your summary -> Checkouts and Overdues
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 18:26:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 16:26:27 +0000
    Subject: [Koha-bugs] [Bug 27750] Remove jquery.cookie.js plugin
    In-Reply-To: <bug-27750-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27750-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27750-70-0I5HfDLHLc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27750
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131118|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133277
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133277&action=edit
    Bug 27750: Remove jquery.cookie.js plugin
    
    This patch removes references to the jquery.cookie.js plugin which is
    now unused, replaced by js-cookie.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 18:29:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 16:29:02 +0000
    Subject: [Koha-bugs] [Bug 30434] Convert catalog merge page tabs to Bootstrap
    In-Reply-To: <bug-30434-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30434-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30434-70-mlksIShSAY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30434
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132868|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133278
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133278&action=edit
    Bug 30434: Convert catalog merge page tabs to Bootstrap
    
    This patch updates the catalog merge template so that it uses Bootstrap
    tabs instead of jQueryUI. Some JavaScript is modified to accommodate the
    new DOM structure.
    
    The patch also makes a minor HTML correction, adding a missing "</ol>".
    
    To test, apply the patch and search the catalog in the staff client.
    
    - In the search results, check the checkbox for two records.
    - Choose Edit -> Merge records.
    - Click next to accept the merge reference selection.
    - On the next page you should see two tabs under "Source records."
      Confirm that they work correctly.
    - All checkboxes in the first tab should be checked by default.
    - Confirm that tag and subfield selection still works correctly.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 18:35:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 16:35:54 +0000
    Subject: [Koha-bugs] [Bug 30453] Convert offline circulation tabs to
     Bootstrap
    In-Reply-To: <bug-30453-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30453-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30453-70-SHRSvEiPLH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30453
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132955|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133279
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133279&action=edit
    Bug 30453: Convert offline circulation tabs to Bootstrap
    
    This patch updates the offline circulation page in the staff interface
    to use Bootstrap tabs instead of jQueryUI.
    
    To test, apply the patch and make sure the AllowOfflineCirculation
    system preference is enabled.
    
    - Go to Circulation -> Built-in offline circulation interface
    - Submit a patron barcode in the "Check out" field.
    - Under the barcode input field you should see two tabs: Checkouts and
      Fines. Confirm that they look correct and work correctly.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 19:12:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 17:12:00 +0000
    Subject: [Koha-bugs] [Bug 30532] New: guided_reports.pl has a problem
    Message-ID: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30532
    
                Bug ID: 30532
               Summary: guided_reports.pl has a problem
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P1 - high
             Component: Reports
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: lucas at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
    
    To recreate:
    
    Go to: Home >  Reports > Create from SQL
    
    Can't call method "value" on unblessed reference at
    /kohadevbox/koha/reports/guided_reports.pl line 80
    
    
    Maybe caused by Bug 26019?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 19:15:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 17:15:36 +0000
    Subject: [Koha-bugs] [Bug 28634] ILL partner request notices are attached to
     the request creator rather than the partner recipient
    In-Reply-To: <bug-28634-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28634-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28634-70-ABfTommV4R@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28634
    
    Ray Delahunty <r.delahunty at arts.ac.uk> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |r.delahunty at arts.ac.uk
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 20:27:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 18:27:38 +0000
    Subject: [Koha-bugs] [Bug 30194] Update required JSON::Validator version
    In-Reply-To: <bug-30194-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30194-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30194-70-cJDngC04Tf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194
    
    --- Comment #103 from Michael Hafen <michael.hafen at washk12.org> ---
    Yep, that fixed it.  Thanks.
    
    (In reply to Mason James from comment #102)
    > (In reply to Michael Hafen from comment #100)
    > > Please keep the exp repo until the dev repo has the newer packages for all
    > > the affected libraries.
    > > Also, shouldn't the required module versions be updated on the About Koha
    > > page?
    > > Also, I seem to have the wrong version of Mojolicious::Plugin::OpenAPI in my
    > > dev install.  It's complaining about JSON::Validator::Ref being missing.  I
    > > have 2.16 from the dev repo.
    > 
    > hi Michael, if you use the 'koha-staging' repo, your problems should be
    > resolved
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 20:34:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 18:34:50 +0000
    Subject: [Koha-bugs] [Bug 30532] guided_reports.pl has a problem
    In-Reply-To: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30532-70-rydfPHtKLB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30532
    
    --- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
    This is basically the same issue as Bug 30525, though the problematic code is
    different than what I'd searched for to fix that bug.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 21:12:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 19:12:40 +0000
    Subject: [Koha-bugs] [Bug 30533] New: Add exact search option for patrons
    Message-ID: <bug-30533-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30533
    
                Bug ID: 30533
               Summary: Add exact search option for patrons
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Patrons
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: andrew at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
    
    A patron search for names like "JOHN JOHNSON" ends up getting parsed something
    like "WHERE surname like "%JOHN%" OR firstname like "%JOHN%" OR surname like
    "%JOHNSON%" OR firstname like "%JOHNSON%"" and finds a really unhelpfully large
    pile of patrons.
    
    Bug 17500 suggests implementing Elastic for patron searching, which would be
    great.
    
    In the meantime, we could give a little help for searches like this by giving
    an exact search option -- so the query would parse more or less the same but
    without the wildcards. That's also a problematic search for many situations,
    but would work better here.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 21:12:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 19:12:40 +0000
    Subject: [Koha-bugs] [Bug 17500] Use Elasticsearch to search for patrons
    In-Reply-To: <bug-17500-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17500-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17500-70-4zuCCvMmZw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17500
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30533
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 21:31:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 19:31:13 +0000
    Subject: [Koha-bugs] [Bug 30534] New: borrowers.guarantorid not present on
     database
    Message-ID: <bug-30534-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30534
    
                Bug ID: 30534
               Summary: borrowers.guarantorid not present on database
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: REST API
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: tomascohen at gmail.com
                    CC: tomascohen at gmail.com
    
    The column was removed on bug 14570 (19.11) but the API mapping was
    inadvertedly kept.
    
    We should remove it.
    
    To test:
    - Try to filter a request by that attribute:
    
    http://kohadev-intra.myDNSname.org:8081/api/v1/patrons?guarantor_id=1
    http://kohadev-intra.myDNSname.org:8081/api/v1/patrons?q={"guarantor_id"=1}
    
    => FAIL: You get a 500
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 21:31:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 19:31:45 +0000
    Subject: [Koha-bugs] [Bug 30534] borrowers.guarantorid not present on
     database
    In-Reply-To: <bug-30534-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30534-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30534-70-NoYi4uo4cs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30534
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lucas at bywatersolutions.com,
                       |                            |martin.renvoize at ptfs-europe
                       |                            |.com
               Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                       |ity.org                     |
                 Status|NEW                         |ASSIGNED
             Depends on|                            |14570
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570
    [Bug 14570] Make it possible to add multiple guarantors to a record
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 21:31:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 19:31:45 +0000
    Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors
     to a record
    In-Reply-To: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14570-70-iEQDYVUYv2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30534
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30534
    [Bug 30534] borrowers.guarantorid not present on database
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 21:43:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 19:43:30 +0000
    Subject: [Koha-bugs] [Bug 18392] Allow importing/exporting circulation
     conditions as CSV or spreadsheet
    In-Reply-To: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18392-70-MfVUDfsYbD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 21:43:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 19:43:33 +0000
    Subject: [Koha-bugs] [Bug 18392] Allow importing/exporting circulation
     conditions as CSV or spreadsheet
    In-Reply-To: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18392-70-m0J5XyWUdr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392
    
    --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133280
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133280&action=edit
    Bug 18392: use KohaTable for circ rules to allow export of matrix
    
    To test:
    1 - Define some circ rules
    2 - View them, note the appearance
    3 - Apply patch
    4 - Reload and note change of header
    5 - Use the new button to export, try various formats
    6 - Test the filter and export
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 21:43:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 19:43:36 +0000
    Subject: [Koha-bugs] [Bug 18392] Allow importing/exporting circulation
     conditions as CSV or spreadsheet
    In-Reply-To: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18392-70-Ch8Ey12XoO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392
    
    --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133281
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133281&action=edit
    Bug 18392: Add noExport of rows and don't export 'edit' row
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 21:43:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 19:43:49 +0000
    Subject: [Koha-bugs] [Bug 18392] Allow importing/exporting circulation
     conditions as CSV or spreadsheet
    In-Reply-To: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18392-70-5LsUCpy4Iq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                       |ity.org                     |
                     CC|                            |nick at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 21:43:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 19:43:55 +0000
    Subject: [Koha-bugs] [Bug 30535] New: Add "Tool plugins" to the main tools
     screen
    Message-ID: <bug-30535-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30535
    
                Bug ID: 30535
               Summary: Add "Tool plugins" to the main tools screen
     Change sponsored?: ---
               Product: Koha
               Version: 21.05
              Hardware: All
                    OS: All
                Status: NEW
              Severity: trivial
              Priority: P5 - low
             Component: Tools
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: fred.king at medstar.net
            QA Contact: testopia at bugs.koha-community.org
    
    On the main Tools page in 21.05, "Tool plugins" is missing from "Additional
    tools." If you select any one of the tools, it appears in the column of tools
    on the left side of the screen.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 21:44:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 19:44:26 +0000
    Subject: [Koha-bugs] [Bug 18392] Allow importing/exporting circulation
     conditions as CSV or spreadsheet
    In-Reply-To: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18392-70-IDoBvIeGmN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |andrew at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 22:09:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 20:09:22 +0000
    Subject: [Koha-bugs] [Bug 30534] borrowers.guarantorid not present on
     database
    In-Reply-To: <bug-30534-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30534-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30534-70-gyA279AP7g@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30534
    
    --- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133282
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133282&action=edit
    Bug 30534: Remove guarantor_id attribute from the patron object
    
    This patch removes an attribute that was actually removed 3 years ago
    and causes an exception when trying to search for it. The API responses
    don't include it anyways.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 22:09:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 20:09:38 +0000
    Subject: [Koha-bugs] [Bug 30534] borrowers.guarantorid not present on
     database
    In-Reply-To: <bug-30534-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30534-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30534-70-FLNyfBDHOd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30534
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 22:11:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 20:11:57 +0000
    Subject: [Koha-bugs] [Bug 18392] Allow importing/exporting circulation
     conditions as CSV or spreadsheet
    In-Reply-To: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18392-70-hBOslEzuZP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 22:12:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 20:12:01 +0000
    Subject: [Koha-bugs] [Bug 18392] Allow importing/exporting circulation
     conditions as CSV or spreadsheet
    In-Reply-To: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18392-70-zXMd3UgpBw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133280|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
    Created attachment 133283
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133283&action=edit
    Bug 18392: use KohaTable for circ rules to allow export of matrix
    
    To test:
    1 - Define some circ rules
    2 - View them, note the appearance
    3 - Apply patch
    4 - Reload and note change of header
    5 - Use the new button to export, try various formats
    6 - Test the filter and export
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 22:12:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 20:12:06 +0000
    Subject: [Koha-bugs] [Bug 18392] Allow importing/exporting circulation
     conditions as CSV or spreadsheet
    In-Reply-To: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18392-70-QXETgZcQqV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133281|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
    Created attachment 133284
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133284&action=edit
    Bug 18392: Add noExport of rows and don't export 'edit' row
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 22:14:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 20:14:26 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: <bug-29810-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29810-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29810-70-uLYJeX50aa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    --- Comment #66 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133285
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133285&action=edit
    Bug 29810: Fix patron embed definitions
    
    Due to a race and a bad rebase, the patrons embeds added on bug 30063
    didn't get copied to the parameters secition, thus breaking embedding.
    
    To test:
    1. In master, open the patron search page and the inspector
    2. Perform a search
    => FAIL: No results
    => FAIL: There's an error 500 in the API response, mentioning embedding
    is not allowed
    3. Apply this patch
    4. Restart all
    6. Repeat 2
    => SUCCESS: Results are back!
    => SUCCESS: No more API errors
    7. Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 22:22:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 20:22:45 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: <bug-29810-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29810-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29810-70-Ulo5RyNhVP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |additional_work_needed
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 22:27:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 20:27:06 +0000
    Subject: [Koha-bugs] [Bug 30536] New: Embeds should be defined in a single
     place
    Message-ID: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
                Bug ID: 30536
               Summary: Embeds should be defined in a single place
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: REST API
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: tomascohen at gmail.com
                    CC: tomascohen at gmail.com
    
    Right now, our specs need two places:
    
    (1) path top level x-koha-embed entry
    (2) path header parameters definition for x-koha-embed as an enum
    
    The first one was the right one in the first place, but JSON::Validator didn't
    manage that correctly (reliably I'd say). So we used it as in (1).
    
    Bug 29810 added (2), which is great and correct, but our 'stash_embed' helper
    [1] called from Koha/REST/V1/Auth.pm is relying on (1) to build the allow-list
    for embeds.
    
    So we need to have both, and we should fix it.
    
    [1] Koha/REST/Plugin/Query.pm:237
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 22:27:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 20:27:17 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-3adI7s740q@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |29810
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    [Bug 29810] Add embed options documentation
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 22:27:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 20:27:17 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: <bug-29810-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29810-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29810-70-cskIz9JxOS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30536
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    [Bug 30536] Embeds should be defined in a single place
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 22:27:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 20:27:36 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-BJX0gqidBq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 22:27:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 20:27:51 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-eJaVAGhDfi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com,
                       |                            |nick at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 13 22:45:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 20:45:06 +0000
    Subject: [Koha-bugs] [Bug 30537] New: Patron searches are broken
    Message-ID: <bug-30537-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30537
    
                Bug ID: 30537
               Summary: Patron searches are broken
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P1 - high
             Component: Searching
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: lucas at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
    
    To recreate:
    
    -Go to "cgi-bin/koha/members/members-home.pl".
    -Try and do any patron search
    -You won't see any results
    -Open your console and notice the "400 Bad request" error.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 01:34:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 13 Apr 2022 23:34:48 +0000
    Subject: [Koha-bugs] [Bug 30538] New: Regression: rotating collections does
     not update status
    Message-ID: <bug-30538-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30538
    
                Bug ID: 30538
               Summary: Regression: rotating collections does not update
                        status
     Change sponsored?: ---
               Product: Koha
               Version: 21.05
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Tools
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: bwsdonna at gmail.com
            QA Contact: testopia at bugs.koha-community.org
    
    In 20.05, when a rotating collection is transferred, the status of the items
    update to indicate the item is In Transit to the library the collection is
    being sent to.  In 21.05. the status is no longer updating.  
    
    If an item is checked in, the correct message shows to transfer the item to the
    appropriate location, and updates when checked in at the correct location. 
    However the functionality of having the status update when the collection is
    transferred is a key part of the process and needs to be restored.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 03:02:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 01:02:40 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-PQ7tTJ2fM9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |victor at tuxayo.net
    
    --- Comment #12 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Applies without issue on master (412d4f4864)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 08:13:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 06:13:26 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-yIn7KxQQ1l@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |20476
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20476
    [Bug 20476] Two factor authentication for the staff client - omnibus
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 08:13:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 06:13:26 +0000
    Subject: [Koha-bugs] [Bug 20476] Two factor authentication for the staff
     client - omnibus
    In-Reply-To: <bug-20476-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20476-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20476-70-RAMXtxmoj5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20476
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |29894
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    [Bug 29894] 2FA: Add few validations, clear secret, send register notice
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 08:27:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 06:27:31 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-I4012aOV8B@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #129689|0                           |1
            is obsolete|                            |
    
    --- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133286
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133286&action=edit
    Bug 29894: Add some exceptions to TwoFactorAuth module
    
    Test updated accordingly.
    Adding utf8 flag to CGI in staff script.
    
    Test plan:
    Run t/db_dependent/Koha/Auth/TwoFactorAuth.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 08:27:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 06:27:35 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-mHugBZUIKE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #129690|0                           |1
            is obsolete|                            |
    
    --- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133287
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133287&action=edit
    Bug 29894: Clear secret when disabling 2FA
    
    Test plan:
    Deregister 2FA for patron.
    Check if secret is empty in borrowers.secret.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 08:27:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 06:27:39 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-rtJ4mtReDb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #129691|0                           |1
            is obsolete|                            |
    
    --- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133288
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133288&action=edit
    Bug 29894: Db rev for adding notices
    
    This dbrev adds two notices:
    2FA_REGISTER and 2FA_DEREGISTER
    
    Test plan:
    Run the dbrev.
    Check if you see them on Tools/Notices.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 08:27:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 06:27:44 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-ollvnkpVy9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #129692|0                           |1
            is obsolete|                            |
    
    --- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133289
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133289&action=edit
    Bug 29894: Send a confirmation notice
    
    When registering or deregistering, send a confirmation.
    
    Test plan:
    Register or deregister with patron having email address.
    Verify that you got a confirmation mail.
    Run t/db_dependent/Koha/Auth/TwoFactorAuth.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 08:28:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 06:28:04 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-uqyZKvHbvf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    --- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Rebased
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 08:48:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 06:48:02 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-ugaAmcbc1g@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |BLOCKED
    
    --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Looking here. Might propose some changes?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 09:04:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 07:04:16 +0000
    Subject: [Koha-bugs] [Bug 30539] New: Koha upgrade error "Column
     'claimed_on' cannot be null"
    Message-ID: <bug-30539-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30539
    
                Bug ID: 30539
               Summary: Koha upgrade error "Column 'claimed_on' cannot be
                        null"
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Installation and upgrade (command-line installer)
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: saiful at semanticconsulting.com
            QA Contact: testopia at bugs.koha-community.org
    
    Running koha-upgrade-schema for migration (from 17.x to 21.x) encountered this
    error which breaks the upgrade during '19.12.00.085':
    
    {UNKNOWN}: DBI Exception: DBD::mysql::st execute failed: Column 'claimed_on'
    cannot be null  at /usr/share/perl5/DBIx/C8.
     ...[snip]...
      DBIx::Class::Storage::DBI::__ANON__("DBD::mysql::st execute failed: Column
    'claimed_on' cannot be "..., DBI::stundef) called at
    /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line
    22065
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 09:18:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 07:18:33 +0000
    Subject: [Koha-bugs] [Bug 30539] Koha upgrade error "Column 'claimed_on'
     cannot be null"
    In-Reply-To: <bug-30539-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30539-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30539-70-kveaDAM3oS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30539
    
    --- Comment #1 from Saiful Amin <saiful at semanticconsulting.com> ---
    There is a possible bug in:
    /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl
    (OR [master]/installer/data/mysql/updatedatabase.pl)
    
    While checking the code I observed that the orders object has three values and
    'claimed_on' is not one of them:
    
    22053   my $orders = $dbh->selectall_arrayref(q|
    22054       SELECT ordernumber, claims_count, claimed_date
    22055       FROM aqorders
    
    
    So, the possible patch is making following change in the line 22065 of the
    updatedatabase.pl:
    
    22063   for my $order ( @$orders ) {
    22064       for my $claim (1..$order->{claims_count}) {
    -22065           $insert_claim_sth->execute($order->{ordernumber},
    $order->{claimed_on});
    +22065           $insert_claim_sth->execute($order->{ordernumber},
    $order->{claimed_date});
    22066       }
    22067   }
    
    The above change fixed the upgrade process for us.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 09:33:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 07:33:27 +0000
    Subject: [Koha-bugs] [Bug 30539] Koha upgrade error "Column 'claimed_on'
     cannot be null"
    In-Reply-To: <bug-30539-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30539-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30539-70-Yn9IqkrW95@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30539
    
    Saiful Amin <saiful at semanticconsulting.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Trivial patch
                Version|unspecified                 |master
                     CC|                            |saiful at semanticconsulting.c
                       |                            |om
               Severity|enhancement                 |normal
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 09:40:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 07:40:04 +0000
    Subject: [Koha-bugs] [Bug 30540] New: Double processing invalid dates can
     lead to ISE
    Message-ID: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30540
    
                Bug ID: 30540
               Summary: Double processing invalid dates can lead to ISE
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: major
              Priority: P5 - low
             Component: Architecture, internals, and plumbing
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: martin.renvoize at ptfs-europe.com
            QA Contact: testopia at bugs.koha-community.org
    
    In the KohaDates filter we process our passed date using dt_from_string before
    passing it to output_pref.
    
    dt_from_string handles bad dates in an eval block, falling back to assigning a
    floating timezone. However, in the subsequent call to output_pref we try to set
    the timezone a second time and this time it is not in an eval and so will throw
    an internal server error for such dates.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 09:42:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 07:42:41 +0000
    Subject: [Koha-bugs] [Bug 30540] Double processing invalid dates can lead to
     ISE
    In-Reply-To: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30540-70-gaO4jHY9EA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30540
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                       |ity.org                     |.com
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 09:55:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 07:55:04 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-Gk6TASaKtE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Marcel de Rooy from comment #7)
    > Since we are only crypting a short secret here, I wonder if we should not
    > stick to Blowfish here and use what we already have instead of yet another
    > module?
    
    Using Crypt::Eksblowfish is a bit of a pain (you need to chunk yourself, add
    padding etc.) So just scratch that.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 10:02:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 08:02:40 +0000
    Subject: [Koha-bugs] [Bug 29304] Add a first time login page
    In-Reply-To: <bug-29304-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29304-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29304-70-ZAnfksHAgl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29304
    
    Marie <marie.hedbom at musikverket.se> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |marie.hedbom at musikverket.se
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 10:15:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 08:15:56 +0000
    Subject: [Koha-bugs] [Bug 30540] Double processing invalid dates can lead to
     ISE
    In-Reply-To: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30540-70-wwL2Rx0ITG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30540
    
    --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133290
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133290&action=edit
    Bug 30540: eval on set_time_zone
    
    This patch adds an eval around the call to set_time_zone so that we
    don't crash on invalid local dates and instead just keep the passed
    floating timezone.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 10:17:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 08:17:51 +0000
    Subject: [Koha-bugs] [Bug 30540] Double processing invalid dates can lead to
     ISE
    In-Reply-To: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30540-70-ye8I2b59Gl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30540
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    2017-03-26 01:35:00 is such a date in Europe/London time.. it's a DST boundary
    day so anything between 12.59.59 and 02.00.00 doesn't exist ;)
    
    Set any checkout date in the database to this and set your tz config to
    Europe/London and you'll find the issuehistory page will crash without the
    patch here.
    
    Unit test to follow.. once my brain has worked out how to write one.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 10:18:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 08:18:13 +0000
    Subject: [Koha-bugs] [Bug 30540] Double processing invalid dates can lead to
     ISE
    In-Reply-To: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30540-70-ni4JADZMFI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30540
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com, tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 10:20:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 08:20:07 +0000
    Subject: [Koha-bugs] [Bug 20476] Two factor authentication for the staff
     client - omnibus
    In-Reply-To: <bug-20476-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20476-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20476-70-YD45OXJD7Y@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20476
    
    Hanna Dehlin <hanna.dehlin at hkr.se> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |hanna.dehlin at hkr.se
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 10:45:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 08:45:06 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-T4fHknxHM5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    --- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133291
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133291&action=edit
    Bug 28998: Introduce Koha::Encryption
    
    Test plan:
    Run t/db_dependent/Koha/Encryption.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 10:45:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 08:45:08 +0000
    Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and
     list displays and e-mails
    In-Reply-To: <bug-16522-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-16522-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-16522-70-bvnxZW11j7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522
    
    --- Comment #9 from Christian Stelzenmüller <christian.stelzenmueller at bsz-bw.de> ---
    I was testing this using a sandbox. 
    Unfortunately, on step 8 and 9 i couldn't see the "host item entry" link...
    
    In the list, i can see the source (step 11) with the title (245 $a), but no
    link (?)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 11:22:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 09:22:09 +0000
    Subject: [Koha-bugs] [Bug 30540] Double processing invalid dates can lead to
     ISE
    In-Reply-To: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30540-70-zZArz2R6EX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30540
    
    --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133292
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133292&action=edit
    Bug 30540: Unit test
    
    This patch adds tests for checking the output_pref method against
    a timezone and datetime that would cause an Invalid local time failure
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
       k$ prove t/DateUtils.t
    => FAIL: The feature is not implemented, tests fail to complete
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 11:22:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 09:22:13 +0000
    Subject: [Koha-bugs] [Bug 30540] Double processing invalid dates can lead to
     ISE
    In-Reply-To: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30540-70-CcHUm8oF06@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30540
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133290|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133293
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133293&action=edit
    Bug 30540: eval on set_time_zone
    
    This patch adds an eval around the call to set_time_zone so that we
    don't crash on invalid local dates and instead just keep the passed
    floating timezone.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 11:22:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 09:22:53 +0000
    Subject: [Koha-bugs] [Bug 30540] Double processing invalid dates can lead to
     ISE
    In-Reply-To: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30540-70-QRUBjjt0g1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30540
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |nick at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 11:40:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 09:40:03 +0000
    Subject: [Koha-bugs] [Bug 30135] We should allow configuration of whether
     EDI LSQ segments map to 'location' or 'collection'
    In-Reply-To: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30135-70-07NRwjqV5a@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |additional_work_needed
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 11:40:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 09:40:21 +0000
    Subject: [Koha-bugs] [Bug 30135] We should allow configuration of whether
     EDI LSQ segments map to 'location' or 'collection'
    In-Reply-To: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30135-70-OJLTLU1q1F@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135
    
    --- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Seems I missed a unit test update.. looking now.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 11:46:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 09:46:53 +0000
    Subject: [Koha-bugs] [Bug 30135] We should allow configuration of whether
     EDI LSQ segments map to 'location' or 'collection'
    In-Reply-To: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30135-70-wA4Td9tR9g@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135
    
    --- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133294
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133294&action=edit
    Bug 30135: (follow-up) Rename accessor in failing test
    
    We renamed the LSQ seqment accessor from 'collection_code' to
    'sequenece_code' to more clearly reflect the EDI segment name instead of
    the Koha field we had mapped it to. (Especially as that mapping is not
    optionally to ccode or location).
    
    However, I forgot to update the corresponding test. This patch does that
    update.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 12:40:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 10:40:17 +0000
    Subject: [Koha-bugs] [Bug 30537] Patron searches are broken
    In-Reply-To: <bug-30537-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30537-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30537-70-4LUquESwTn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30537
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    See follow-up on bug 29810
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 12:44:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 10:44:26 +0000
    Subject: [Koha-bugs] [Bug 30518] StockRotationItems crossing DST boundary
     throw invalid local time exception
    In-Reply-To: <bug-30518-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30518-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30518-70-HjpAA7aEmb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30518
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 12:44:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 10:44:30 +0000
    Subject: [Koha-bugs] [Bug 30518] StockRotationItems crossing DST boundary
     throw invalid local time exception
    In-Reply-To: <bug-30518-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30518-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30518-70-vqpEnuUjR4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30518
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133233|0                           |1
            is obsolete|                            |
     Attachment #133234|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133295
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133295&action=edit
    Bug 30518: Unit test
    
    This patch adds tests for checking the needs_advancing method against
    a timezone and datetime that would cause an Invalid local time failure
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
       k$ prove t/db_dependent/StockRotationItems.t
    => FAIL: The feature is not implemented, tests fail to complete
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 12:44:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 10:44:34 +0000
    Subject: [Koha-bugs] [Bug 30518] StockRotationItems crossing DST boundary
     throw invalid local time exception
    In-Reply-To: <bug-30518-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30518-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30518-70-Nw5PmxohVB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30518
    
    --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133296
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133296&action=edit
    Bug 30518: Correct DateTime maths for needs_advancing
    
    The needs_advancing method prior to this patch used basic DateTime
    arithmatic, adding a DateTime::Duration in Days to the Arrival date of
    the item and then comparing that to today. This, however, can cause bugs
    when the arrival + duration date coincides with a DST boundary and as
    such may result in an invalid local date.  See
    https://metacpan.org/pod/DateTime#Making-Things-Simple for further
    details.
    
    This patch updates the code to use the DST safe delta_days method to
    count the days between arrival and now instead and then compares this
    integer to the defined duration of the stage.
    
    To test:
    1. Re-run the unit tests, they should now pass.
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 12:44:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 10:44:58 +0000
    Subject: [Koha-bugs] [Bug 30518] StockRotationItems crossing DST boundary
     throw invalid local time exception
    In-Reply-To: <bug-30518-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30518-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30518-70-PaKk6Hvjyb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30518
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
    Trivial and good change, covered by tests, passing QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 12:49:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 10:49:11 +0000
    Subject: [Koha-bugs] [Bug 30537] Patron searches are broken
    In-Reply-To: <bug-30537-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30537-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30537-70-dRO4BJVPWD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30537
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |DUPLICATE
                 Status|NEW                         |RESOLVED
    
    --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    I used my powers as an RM Assistant to push the follow-up provided by Tomas on
    bug 29810 so this should be working again now.
    
    *** This bug has been marked as a duplicate of bug 29810 ***
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 12:49:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 10:49:11 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: <bug-29810-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29810-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29810-70-vKniuCeLpc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lucas at bywatersolutions.com
    
    --- Comment #67 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    *** Bug 30537 has been marked as a duplicate of this bug. ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 12:49:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 10:49:38 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: <bug-29810-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29810-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29810-70-71gXeNryiB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    --- Comment #68 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Follow-up pushed as RM assistant to get people back up and running. :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 12:52:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 10:52:25 +0000
    Subject: [Koha-bugs] [Bug 30134] We should allow configuration of whether
     EDI LSQ segments map to 'location' or 'collection'
    In-Reply-To: <bug-30134-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30134-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30134-70-SYcKgD2leh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30134
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |DUPLICATE
                 Status|NEW                         |RESOLVED
    
    --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Double submission somehow.. bz error.
    
    *** This bug has been marked as a duplicate of bug 30135 ***
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 12:52:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 10:52:25 +0000
    Subject: [Koha-bugs] [Bug 30135] We should allow configuration of whether
     EDI LSQ segments map to 'location' or 'collection'
    In-Reply-To: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30135-70-WSPnG91uEr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135
    
    --- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    *** Bug 30134 has been marked as a duplicate of this bug. ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 12:53:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 10:53:16 +0000
    Subject: [Koha-bugs] [Bug 30135] We should allow configuration of whether
     EDI LSQ segments map to 'location' or 'collection'
    In-Reply-To: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30135-70-eaMrfEziIR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135
    
    --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Follow-up pushed as RM Assistant.. I was pushing something else to get peoples
    dev envs back up and running and thought it not a bad idea to push this one too
    and try and get the dashboard green ;)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 12:53:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 10:53:24 +0000
    Subject: [Koha-bugs] [Bug 30135] We should allow configuration of whether
     EDI LSQ segments map to 'location' or 'collection'
    In-Reply-To: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30135-70-AuqpzfMPJ3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|additional_work_needed      |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 12:53:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 10:53:44 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: <bug-29810-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29810-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29810-70-QUbYF9Dblk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|additional_work_needed      |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 12:57:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 10:57:04 +0000
    Subject: [Koha-bugs] [Bug 30540] Double processing invalid dates can lead to
     ISE
    In-Reply-To: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30540-70-JDEwqlUe3n@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30540
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 12:57:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 10:57:08 +0000
    Subject: [Koha-bugs] [Bug 30540] Double processing invalid dates can lead to
     ISE
    In-Reply-To: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30540-70-aiAVOb2k6i@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30540
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133292|0                           |1
            is obsolete|                            |
     Attachment #133293|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133297
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133297&action=edit
    Bug 30540: Unit test
    
    This patch adds tests for checking the output_pref method against
    a timezone and datetime that would cause an Invalid local time failure
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
       k$ prove t/DateUtils.t
    => FAIL: The feature is not implemented, tests fail to complete
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 12:57:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 10:57:11 +0000
    Subject: [Koha-bugs] [Bug 30540] Double processing invalid dates can lead to
     ISE
    In-Reply-To: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30540-70-Mzr0xK9QmX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30540
    
    --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133298
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133298&action=edit
    Bug 30540: eval on set_time_zone
    
    This patch adds an eval around the call to set_time_zone so that we
    don't crash on invalid local dates and instead just keep the passed
    floating timezone.
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 12:57:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 10:57:16 +0000
    Subject: [Koha-bugs] [Bug 30540] Double processing invalid dates can lead to
     ISE
    In-Reply-To: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30540-70-wd5vW4WMSq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30540
    
    --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133299
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133299&action=edit
    Bug 30540: Fix perl critic complaint of leading zeros
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 12:58:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 10:58:24 +0000
    Subject: [Koha-bugs] [Bug 30541] New: Resolve return claim works but "hangs"
     if MarkLostItemsAsReturned is set for return claims
    Message-ID: <bug-30541-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541
    
                Bug ID: 30541
               Summary: Resolve return claim works but "hangs" if
                        MarkLostItemsAsReturned is set for return claims
     Change sponsored?: ---
               Product: Koha
               Version: 21.05
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Circulation
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: kyle at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
    
    Basically, if MarkLostItemsAsReturned is set for return claims, the code will
    crash while trying to pull the checkout so it can update the lost status of the
    item. This is because the code assumes there must be a checkout and never
    checks the old_checkouts table.
    
    This bug appears to only exist in 21.11 at this time. It was fixed by a
    combination of bugs 29495 and 28588.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 12:58:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 10:58:34 +0000
    Subject: [Koha-bugs] [Bug 30541] Resolve return claim works but "hangs" if
     MarkLostItemsAsReturned is set for return claims
    In-Reply-To: <bug-30541-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30541-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30541-70-AZHyd1D3Hr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                       |ity.org                     |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 13:01:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 11:01:12 +0000
    Subject: [Koha-bugs] [Bug 30541] Resolve return claim works but "hangs" if
     MarkLostItemsAsReturned is set for return claims
    In-Reply-To: <bug-30541-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30541-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30541-70-3fWcH8diwY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541
    
    --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Created attachment 133300
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133300&action=edit
    Bug 30541 - Resolve return claim works but "hangs" if MarkLostItemsAsReturned
    is set for return claims
    
    Basically, if MarkLostItemsAsReturned is set for return claims, the code will
    crash while trying to pull the checkout so it can update the lost status of the
    item. This is because the code assumes there must be a checkout and never
    checks the old_checkouts table.
    
    This bug appears to only exist in 21.05 at this time. It was fixed by a
    combination of bugs 29495 and 28588.
    
    Test Plan:
    1) Set MarkLostItemsAsReturned for return claims
    2) Mark a checkout as claims returned
    3) Verify the checkout is no longer on the patron record
    4) Resolve the claim
    5) Note the attempt "hangs" but refreshing the page shows it worked
    6) Apply this patch, restart all the things!
    7) Repeat steps 2-4
    8) It works!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 13:02:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 11:02:00 +0000
    Subject: [Koha-bugs] [Bug 30541] Resolve return claim works but "hangs" if
     MarkLostItemsAsReturned is set for return claims
    In-Reply-To: <bug-30541-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30541-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30541-70-IlKTaWgaiz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541
    
    --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Typo, this bug appears to only exist in 21.05 at this time. Not 21.11 as
    previously stated.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 13:02:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 11:02:31 +0000
    Subject: [Koha-bugs] [Bug 30541] Resolve return claim works but "hangs" if
     MarkLostItemsAsReturned is set for return claims
    In-Reply-To: <bug-30541-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30541-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30541-70-JTuci7spzE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 13:02:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 11:02:35 +0000
    Subject: [Koha-bugs] [Bug 30541] Resolve return claim works but "hangs" if
     MarkLostItemsAsReturned is set for return claims
    In-Reply-To: <bug-30541-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30541-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30541-70-XBZVJzDVHE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133300|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Created attachment 133301
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133301&action=edit
    Bug 30541 - Resolve return claim works but "hangs" if MarkLostItemsAsReturned
    is set for return claims
    
    Basically, if MarkLostItemsAsReturned is set for return claims, the code will
    crash while trying to pull the checkout so it can update the lost status of the
    item. This is because the code assumes there must be a checkout and never
    checks the old_checkouts table.
    
    This bug appears to only exist in 21.05 at this time. It was fixed by a
    combination of bugs 29495 and 28588.
    
    Test Plan:
    1) Set MarkLostItemsAsReturned for return claims
    2) Mark a checkout as claims returned
    3) Verify the checkout is no longer on the patron record
    4) Resolve the claim
    5) Note the attempt "hangs" but refreshing the page shows it worked
    6) Apply this patch, restart all the things!
    7) Repeat steps 2-4
    8) It works!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 13:04:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 11:04:12 +0000
    Subject: [Koha-bugs] [Bug 29898] Overdues.pm line 663,
     Use of uninitialized value in string eq
    In-Reply-To: <bug-29898-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29898-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29898-70-Z1vBql633e@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29898
    
    Anke <anke.bruns at gwdg.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |anke.bruns at gwdg.de
    
    --- Comment #2 from Anke <anke.bruns at gwdg.de> ---
    (In reply to Elias from comment #0)
    > After migrating 37 instances from v19.11 to v20.11.13 the
    > /etc/cron.daily/koha-common logs the following on 7 instances:
    > 
    > "Use of uninitialized value in string eq at
    > /usr/share/koha/lib/C4/Overdues.pm line 663."
    > 
    > We've checked the settings across the instances and the database.
    > We can't find the root of this warning/error.
    
    Do you mean to say that in the other 30 instances the error doesn't occur and
    the overdues are processed correctly?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 13:05:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 11:05:31 +0000
    Subject: [Koha-bugs] [Bug 30542] New: Use x-koha-embed parameter definition
    Message-ID: <bug-30542-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30542
    
                Bug ID: 30542
               Summary: Use x-koha-embed parameter definition
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: REST API
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: martin.renvoize at ptfs-europe.com
                    CC: tomascohen at gmail.com
            Depends on: 29810
    
    Now that we're documenting, and properly validating, the x-koha-embed parameter
    we can actually use this parameter definition list instead of the custom
    x-koha-embed array from the top level of the endpoint definition.
    
    This would reduce overhead of adding embeds.. we would only need to add them to
    the enum list in the parameter definition instead of to both the parameter
    definition and a top level x-koha-embed key.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    [Bug 29810] Add embed options documentation
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 13:05:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 11:05:31 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: <bug-29810-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29810-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29810-70-6lOsv55Bkf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30542
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30542
    [Bug 30542] Use x-koha-embed parameter definition
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 13:05:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 11:05:54 +0000
    Subject: [Koha-bugs] [Bug 30542] Use x-koha-embed parameter definition
    In-Reply-To: <bug-30542-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30542-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30542-70-g4s2qXiNwG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30542
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                       |ity.org                     |.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 13:07:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 11:07:38 +0000
    Subject: [Koha-bugs] [Bug 30542] Use x-koha-embed parameter definition
    In-Reply-To: <bug-30542-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30542-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30542-70-9jBoJsCf4s@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30542
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |DUPLICATE
                 Status|NEW                         |RESOLVED
    
    --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    
    
    *** This bug has been marked as a duplicate of bug 30536 ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 13:07:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 11:07:38 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-89ZYwtq7Xe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    *** Bug 30542 has been marked as a duplicate of this bug. ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 13:08:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 11:08:53 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-XuUgK6SE5H@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Description copied from bug 30542 - I jumped before I found this bug.. haha
    
    >Now that we're documenting, and properly validating, the x-koha-embed parameter we can actually use this parameter definition list instead of the custom x-koha-embed array from the top level of the endpoint definition.
    
    >This would reduce overhead of adding embeds.. we would only need to add them to the enum list in the parameter definition instead of to both the parameter definition and a top level x-koha-embed key.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 13:25:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 11:25:10 +0000
    Subject: [Koha-bugs] [Bug 30531] Search.t needs update for Recalls
    In-Reply-To: <bug-30531-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30531-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30531-70-1FaljCaxFF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30531
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 13:25:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 11:25:14 +0000
    Subject: [Koha-bugs] [Bug 30531] Search.t needs update for Recalls
    In-Reply-To: <bug-30531-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30531-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30531-70-B2XYbOTGRZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30531
    
    --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133302
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133302&action=edit
    BUg 30531: Add mock of UseRecalls to Search.t
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 13:25:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 11:25:32 +0000
    Subject: [Koha-bugs] [Bug 30531] Search.t needs update for Recalls
    In-Reply-To: <bug-30531-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30531-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30531-70-cFgh0icrgL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30531
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|chris at bigballofwax.co.nz    |nick at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 13:28:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 11:28:04 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-Ihosg7eMU8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133303
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133303&action=edit
    Bug 30536: Refer to parameters enum
    
    This patch updates the stash_embed method to use the parameters hash
    enum instead of the top level x-koha-embed custom definition. This way
    we can remove the requirement for defining this list twice.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 13:29:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 11:29:09 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-1Ul7GrZQcw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Attached a first draft for golfing.. I have a hunch we can now drop at least
    some of the local validation we're doing in this method as we now validate
    properly at the openapi plugin level?
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 13:46:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 11:46:55 +0000
    Subject: [Koha-bugs] [Bug 30489] Convert MARC and authority subfield edit
     tabs to Bootstrap
    In-Reply-To: <bug-30489-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30489-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30489-70-95WC8Bl6Jg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30489
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 13:46:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 11:46:58 +0000
    Subject: [Koha-bugs] [Bug 30489] Convert MARC and authority subfield edit
     tabs to Bootstrap
    In-Reply-To: <bug-30489-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30489-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30489-70-wPbPNFR9qv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30489
    
    --- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133304
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133304&action=edit
    Bug 30489: Convert MARC and authority subfield edit tabs to Bootstrap
    
    This patch updates the MARC and authority subfield edit interface to
    replace jQueryUI tabs with Bootstrap. The code for handling
    drag-to-reorder tabs is updated to accommodate the new markup.
    
    To test, apply the patch and restart_all.
    
    - Go to Administration -> MARC bibliographic framework -> Default
      framework and choose "MARC structure" from the Actions menu.
    - In the row for 000 LEADER, click Actions -> View subfields.
    - Click "Edit." On the edit page the tabs should look correct and work
      correctly.
    - Return to the list of tags and click "View subfields" for the 245 tag.
    - Click one of the "Edit" buttons for any but the first subfield, e.g.
      "a".
    - On the "Tag 245 Subfield constraints" page the "a" tab should be
      pre-selected.
    - Click any of the subfield tabs and drag it to re-order it in the
      sequence of tags.
    - It should stay in the correct slot when you release it.
    - Save and confirm that the new sequence of subfields has been saved.
    
    Perform all the same tests under Administration -> Authority types.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 14:05:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 12:05:15 +0000
    Subject: [Koha-bugs] [Bug 30523] Quiet console warning about missing
     shortcut-buttons map file
    In-Reply-To: <bug-30523-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30523-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30523-70-IWBjBZ6jjD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30523
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Trivial patch
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 14:05:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 12:05:18 +0000
    Subject: [Koha-bugs] [Bug 30523] Quiet console warning about missing
     shortcut-buttons map file
    In-Reply-To: <bug-30523-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30523-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30523-70-m4t52TMVff@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30523
    
    --- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133305
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133305&action=edit
    Bug 30523: Quiet console warning about missing shortcut-buttons map file
    
    This patch updates the Flatpickr plugin shortcut-buttons which adds the
    "Yesterday," "Today," and "Tomorrow" links to Flatpickr widgets.  This
    updates it to the latest version, 0.4.0.
    
    The file is modified in two ways: The version information is added to
    the top of the file, and the sourceMappingURL line is removed from the
    bottom. This quiets browser console warnings about a missing map file.
    
    To test, apply the patch and clear your browser cache.
    
    - Go to Circulation -> Check out and check out to a patron.
    - Click "Checkout settings" and click the "Specify due date" field.
    - In the pop-up calendar, test all controls, including the shortcut
      links, to confirm that everything works as before.
    - In the browser console there should be no warning related to
      shortcut-buttons-flatpickr.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 14:18:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 12:18:59 +0000
    Subject: [Koha-bugs] [Bug 30321] Order receive page dies if quantity
     received is more than 0
    In-Reply-To: <bug-30321-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30321-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30321-70-v7b1kqffRP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30321
    
    --- Comment #6 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
    So I've been testing this and it occurs in version 21.11.03 and the conditions
    are following:
    
    - order has _only one item_ attached to it
    - orders quantityreceived value is more than 0
    
    For some reason when there's only one item on order template orderreceived.tt
    handles it as Koha::Item, not Koha::Items as it should, thus "Koha::Item->count
    is not covered by tests!". In orderreceived.pl order->items returns
    Koha::Items.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 14:23:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 12:23:15 +0000
    Subject: [Koha-bugs] [Bug 30528] Limits are not correctly parsed when query
     contains CCL
    In-Reply-To: <bug-30528-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30528-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30528-70-lqj5e1Amci@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30528
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 14:23:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 12:23:19 +0000
    Subject: [Koha-bugs] [Bug 30528] Limits are not correctly parsed when query
     contains CCL
    In-Reply-To: <bug-30528-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30528-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30528-70-FUZBpRJYdo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30528
    
    --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133306
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133306&action=edit
    Bug 30528: Unit tests
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 14:23:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 12:23:22 +0000
    Subject: [Koha-bugs] [Bug 30528] Limits are not correctly parsed when query
     contains CCL
    In-Reply-To: <bug-30528-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30528-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30528-70-FBIQ6b1NSs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30528
    
    --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133307
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133307&action=edit
    Bug 30528: Process limits before handling CCL query
    
    This patch moves the code that handles limit processing before that for CCL
    queries to ensure that special limit cases (branch, multibranch, etc) are
    handled before adding the limits to the query string
    
    To test:
    1 - Apply unit tests patch only
    2 - prove -v t/db_dependent/Search.t
    3 - It fails
    4 - Apply this patch
    5 - It passes!
    6 - Test searching and confirm things work as epxected
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 14:23:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 12:23:32 +0000
    Subject: [Koha-bugs] [Bug 30528] Limits are not correctly parsed when query
     contains CCL
    In-Reply-To: <bug-30528-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30528-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30528-70-IpzfDBi6a8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30528
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                       |ity.org                     |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 14:38:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 12:38:25 +0000
    Subject: [Koha-bugs] [Bug 30508] Do not display OPAC message about block
     from holds when OPACHoldRequests is disabled
    In-Reply-To: <bug-30508-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30508-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30508-70-fyIgdaOkmL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |ASSIGNED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 14:47:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 12:47:07 +0000
    Subject: [Koha-bugs] [Bug 30508] Do not display OPAC message about block
     from holds when OPACHoldRequests is disabled
    In-Reply-To: <bug-30508-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30508-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30508-70-6M5hUvbhL0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Trivial patch
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 14:47:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 12:47:11 +0000
    Subject: [Koha-bugs] [Bug 30508] Do not display OPAC message about block
     from holds when OPACHoldRequests is disabled
    In-Reply-To: <bug-30508-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30508-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30508-70-zyisC7TT80@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508
    
    --- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133308
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133308&action=edit
    Bug 30508: Do not display OPAC message about block from holds when
    OPACHoldRequests is disabled
    
    This patch adds a check for the OPACHoldRequests to determine whether a
    message should be shown to patrons whose account is over the
    maxoutstanding limit.
    
    To test, apply the patch and set the "maxoutstanding" system preference
    to a low value. Set OPACHoldRequests to "Allow."
    
    - Log in to the OPAC as a patron who has outstanding fines or charges
      which exceed the maxoutstanding value you set.
    - You should see a message on the "Your summary" page, "Holds are
      blocked because your fine balance is over the limit."
    - Set OPACHoldRequests to "Don't allow" and refresh the "Your summary"
      page in the OPAC. The message should disappear.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 14:51:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 12:51:49 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-PnV9J4QRD6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133309
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133309&action=edit
    Bug 30536: Remove validation overhead
    
    With the introduction of proper validation of collection headers in
    OpenAPI we no longer need to do our own validation here.
    
    This patch removes the early validation of x-koha-embed headers in
    preference to letting OpenAPI do it once and only once instead.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 15:18:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 13:18:24 +0000
    Subject: [Koha-bugs] [Bug 30543] New: Decouple DumpSearchQueryTemplate from
     other template dump preferences
    Message-ID: <bug-30543-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30543
    
                Bug ID: 30543
               Summary: Decouple DumpSearchQueryTemplate from other template
                        dump preferences
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Architecture, internals, and plumbing
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: nick at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
    
    When using dump search query to debug search issues it would be simpler if we
    could get only the search query
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 15:20:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 13:20:15 +0000
    Subject: [Koha-bugs] [Bug 30543] Decouple DumpSearchQueryTemplate from other
     template dump preferences
    In-Reply-To: <bug-30543-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30543-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30543-70-g3nL37GySY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30543
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 15:20:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 13:20:19 +0000
    Subject: [Koha-bugs] [Bug 30543] Decouple DumpSearchQueryTemplate from other
     template dump preferences
    In-Reply-To: <bug-30543-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30543-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30543-70-WyK5wlwQRM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30543
    
    --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133310
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133310&action=edit
    Bug 30543: Decouple DumpSearchQueryTemplate from other tempalte dump
    preferences
    
    To test:
    1 - Enable DumpSearchQueryTemplate
    2 - Confirm you can find the search query in the HTML as a comment
    3 - Enable other template dump preference
    4 - Confirm they work as before
    5 - Confirm new description of preference makes sense
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 15:20:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 13:20:44 +0000
    Subject: [Koha-bugs] [Bug 30543] Decouple DumpSearchQueryTemplate from other
     template dump preferences
    In-Reply-To: <bug-30543-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30543-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30543-70-d3GHBrGvIZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30543
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                       |ity.org                     |
             Depends on|                            |24103
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103
    [Bug 24103] Add option to dump built search query to templates
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 15:20:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 13:20:44 +0000
    Subject: [Koha-bugs] [Bug 24103] Add option to dump built search query to
     templates
    In-Reply-To: <bug-24103-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24103-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24103-70-gSZhiuC4hh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30543
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30543
    [Bug 30543] Decouple DumpSearchQueryTemplate from other template dump
    preferences
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 15:25:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 13:25:02 +0000
    Subject: [Koha-bugs] [Bug 30544] New: Add font awesome version to licenses
     page
    Message-ID: <bug-30544-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30544
    
                Bug ID: 30544
               Summary: Add font awesome version to licenses page
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: About
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: nick at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 15:28:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 13:28:45 +0000
    Subject: [Koha-bugs] [Bug 30544] Add font awesome version to licenses page
    In-Reply-To: <bug-30544-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30544-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30544-70-JdyaZQwMoZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30544
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 15:28:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 13:28:49 +0000
    Subject: [Koha-bugs] [Bug 30544] Add font awesome version to licenses page
    In-Reply-To: <bug-30544-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30544-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30544-70-IQqrowWxPo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30544
    
    --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133311
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133311&action=edit
    Bug 30544: Add font awesome version to licenses page
    
    This patch simply adds the version number we are using
    and updates the link to point to our version
    
    To test:
    1 - Confirm the About->Licenses page points to the correct Font Awesome version
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 15:29:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 13:29:00 +0000
    Subject: [Koha-bugs] [Bug 30544] Add font awesome version to licenses page
    In-Reply-To: <bug-30544-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30544-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30544-70-nKxuOaitcI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30544
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                       |ity.org                     |
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 15:29:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 13:29:55 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-ubc3ynD6qY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    I'm still pottering here.. if we can move the call later, after validation has
    taken place, we can save ourselves both the validation and param extraction
    overhead.  Not sure how far down the rabbit hole it's worth going for now.
    
    Of course.. we'd also want to clean up our spec files here, removing existing
    x-koha-embed top level keys.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 15:34:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 13:34:37 +0000
    Subject: [Koha-bugs] [Bug 30544] Add font awesome version to licenses page
    In-Reply-To: <bug-30544-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30544-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30544-70-LqbFyr12E8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30544
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Trivial patch
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 15:34:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 13:34:40 +0000
    Subject: [Koha-bugs] [Bug 30544] Add font awesome version to licenses page
    In-Reply-To: <bug-30544-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30544-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30544-70-PK2YqJrbf7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30544
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133311|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133312
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133312&action=edit
    Bug 30544: Add font awesome version to licenses page
    
    This patch simply adds the version number we are using
    and updates the link to point to our version
    
    To test:
    1 - Confirm the About->Licenses page points to the correct Font Awesome
        version
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 15:35:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 13:35:07 +0000
    Subject: [Koha-bugs] [Bug 30537] Patron searches are broken
    In-Reply-To: <bug-30537-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30537-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30537-70-jeWjZB3vwo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30537
    
    --- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> ---
    (In reply to Martin Renvoize from comment #2)
    > I used my powers as an RM Assistant to push the follow-up provided by Tomas
    > on bug 29810 so this should be working again now.
    
    Thanks Martin!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 16:16:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 14:16:54 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-AwkqgPs0Xx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133303|0                           |1
            is obsolete|                            |
    
    --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133313
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133313&action=edit
    Bug 30536: Refer to parameters enum
    
    This patch updates the stash_embed method to use the parameters hash
    enum instead of the top level x-koha-embed custom definition. This way
    we can remove the requirement for defining this list twice.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 16:16:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 14:16:59 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-bHAVvNFVfm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133309|0                           |1
            is obsolete|                            |
    
    --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133314
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133314&action=edit
    Bug 30536: Remove validation overhead
    
    With the introduction of proper validation of collection headers in
    OpenAPI we no longer need to do our own validation here.
    
    This patch removes the early validation of x-koha-embed headers in
    preference to letting OpenAPI do it once and only once instead.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 16:17:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 14:17:04 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-nwYF8Ps0bU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133315
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133315&action=edit
    Bug 30536: Use objects->find in Cashups controller
    
    This patch removes the direct reference to the koha.embed stashed
    variable in the Cashups controller and switches us to the modern
    objects->find approach.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 16:17:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 14:17:08 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-TmbIajAQuh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133316
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133316&action=edit
    Bug 30536: Use objects->find in SMTP Servers controller
    
    This patch removes the direct reference to the koha.embed
    stashed variable in the SMTP controller and switches us
    to the modern objects->find approach.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 16:22:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 14:22:17 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-vn7Qe7n1mz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133315|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 16:22:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 14:22:28 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-lT2xnyQFJo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133316|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 16:28:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 14:28:33 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-72UpZF2Kpo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #124772|0                           |1
            is obsolete|                            |
     Attachment #133291|0                           |1
            is obsolete|                            |
    
    --- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133317
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133317&action=edit
    Bug 28998: Introduce Koha::Encryption
    
    Test plan:
    Run t/db_dependent/Koha/Encryption.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    [AMENDED] Added copyright line to module.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 16:28:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 14:28:38 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-m3jriAv1vr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133318
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133318&action=edit
    Bug 28998: (follow-up) Add Patron->encode_secret and ->decoded_secret
    
    Test plan:
    Run t/db_dependent/Koha/Patron.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 16:28:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 14:28:44 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-z9wv5siL8n@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    --- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133319
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133319&action=edit
    Bug 28998: (follow-up) Apply changes to TwoFactorAuth module and script
    
    Test plan:
    Run t/db_dependent/Koha/Auth/TwoFactorAuth.t
    Walk thru cycle register - logout/login - deregister - logout/login.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 16:28:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 14:28:48 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-ShSrBLFsSS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    --- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133320
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133320&action=edit
    Bug 28998: Adjust Selenium test
    
    Test plan:
    Run t/db_dependent/selenium/authentication_2fa.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 16:28:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 14:28:53 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-XUzUN7yyYM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    --- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133321
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133321&action=edit
    Bug 28998: [TO_BE_SQUASHED] Adjust secret in Selenium test
    
    This patch can be squashed with the previous one, if all is ok.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 16:28:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 14:28:56 +0000
    Subject: [Koha-bugs] [Bug 30545] New: Replace the use of jQueryUI Accordion
     on the notices page
    Message-ID: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545
    
                Bug ID: 30545
               Summary: Replace the use of jQueryUI Accordion on the notices
                        page
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: enhancement
              Priority: P5 - low
             Component: Templates
              Assignee: oleonard at myacpl.org
              Reporter: oleonard at myacpl.org
            QA Contact: testopia at bugs.koha-community.org
                    CC: testopia at bugs.koha-community.org
            Depends on: 30494
                Blocks: 29224
    
    As part of Bug 29224, "OMNIBUS: Replace the use of jQueryUI Accordion" we
    should replace the use of the jQueryUI accordion component on the notices page
    with Bootstrap's Collapse component.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29224
    [Bug 29224] OMNIBUS: Replace the use of jQueryUI Accordion
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30494
    [Bug 30494] Replace the use of jQueryUI Accordion on the table settings page
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 16:28:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 14:28:56 +0000
    Subject: [Koha-bugs] [Bug 30494] Replace the use of jQueryUI Accordion on
     the table settings page
    In-Reply-To: <bug-30494-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30494-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30494-70-LcJL9rxpWM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30494
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30545
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545
    [Bug 30545] Replace the use of jQueryUI Accordion on the notices page
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 16:28:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 14:28:56 +0000
    Subject: [Koha-bugs] [Bug 29224] OMNIBUS: Replace the use of jQueryUI
     Accordion
    In-Reply-To: <bug-29224-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29224-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29224-70-mNCLRgOCvu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29224
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30545
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545
    [Bug 30545] Replace the use of jQueryUI Accordion on the notices page
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 16:31:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 14:31:09 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-W0EScxLpfO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #124773|0                           |1
            is obsolete|                            |
     Attachment #124774|0                           |1
            is obsolete|                            |
    
    --- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133322
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133322&action=edit
    Bug 28998: Add encryption_key to the config file
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 16:31:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 14:31:13 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-hepPLMUKwG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    --- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133323
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133323&action=edit
    Bug 28998: Add Crypt::CBC dependency
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 16:32:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 14:32:04 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-XKq1KiH4qs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    --- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Marcel de Rooy from comment #17)
    > Created attachment 133322 [details] [review]
    > Bug 28998: Add encryption_key to the config file
    > 
    > Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Recently a QAer insisted that I should adjust koha-create when adding
    koha-conf.xml entries :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 16:32:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 14:32:49 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-LTXcrFrN54@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|28786                       |29894
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    [Bug 28786] Two-factor authentication for staff client - TOTP
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    [Bug 29894] 2FA: Add few validations, clear secret, send register notice
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 16:32:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 14:32:49 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-hSGM9a5ChE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|28998                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    [Bug 28998] Encrypt borrowers.secret
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 16:32:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 14:32:49 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-xxvqZlxzzX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |28998
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    [Bug 28998] Encrypt borrowers.secret
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 16:33:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 14:33:28 +0000
    Subject: [Koha-bugs] [Bug 30545] Replace the use of jQueryUI Accordion on
     the notices page
    In-Reply-To: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30545-70-36uzPtiQZq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |29226
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
    [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 16:33:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 14:33:28 +0000
    Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
    In-Reply-To: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29226-70-6HH4HroSOI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30545
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545
    [Bug 30545] Replace the use of jQueryUI Accordion on the notices page
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 16:36:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 14:36:21 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-Qlhc810xb1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|BLOCKED                     |Signed Off
    
    --- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Reworked this a bit and tested on top of 28786 - 29873 - 29894.
    Main thing is splitting the first patch and moving some code to Koha::Patron.
    Taking the liberty to set it to Signed Off with one request: Please run the
    Selenium test. And if you agree, squash patch 4 and patch 5.
    If you would not agree, feel free to change status and tell me about it :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 16:53:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 14:53:28 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-xZxeasG5w3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133314|0                           |1
            is obsolete|                            |
    
    --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133324
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133324&action=edit
    Bug 30536: Remove validation overhead
    
    With the introduction of proper validation of collection headers in
    OpenAPI we no longer need to do our own validation here.
    
    This patch removes the early validation of x-koha-embed headers in
    preference to letting OpenAPI do it once and only once instead.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 17:08:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 15:08:45 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-a4XBjE2FA9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133325
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133325&action=edit
    Bug 30536: Update spec files
    
    This patch removes superflous x-koha-embed defintions at the top level
    of the endpoint specifications. It also replaces a few x-koha-embeds at
    the top level with parameter lists where this had been missed in
    preceeding patches.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 17:16:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 15:16:10 +0000
    Subject: [Koha-bugs] [Bug 30546] New: Initial articles not ignored when
     sorting by the summary column in the pending_orders table
    Message-ID: <bug-30546-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30546
    
                Bug ID: 30546
               Summary: Initial articles not ignored when sorting by the
                        summary column in the pending_orders table
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: minor
              Priority: P5 - low
             Component: Acquisitions
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: barbara.johnson at bedfordtx.gov
            QA Contact: testopia at bugs.koha-community.org
    
    Bug 29570 (Unable to sort summary column of pending_orders table on parcel.pl
    by summary column) added sorting capability back to the summary column for the
    pending orders table.  However, search results do not ignore the articles 'a',
    'an' and 'the' when displaying the results. I don't believe it used to be like
    this and other areas in acquisitions, such as invoices, ignore initial articles
    when displaying search results.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 17:17:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 15:17:27 +0000
    Subject: [Koha-bugs] [Bug 30546] Initial articles not ignored when sorting
     by the summary column in the pending_orders table
    In-Reply-To: <bug-30546-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30546-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30546-70-1s1Ar9pHFl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30546
    
    --- Comment #1 from Barbara Johnson <barbara.johnson at bedfordtx.gov> ---
    Created attachment 133326
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133326&action=edit
    Title with initial articles not sorted correctly
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 17:25:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 15:25:04 +0000
    Subject: [Koha-bugs] [Bug 26646] Holds to Pull should show distinct
     item-level holds
    In-Reply-To: <bug-26646-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26646-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26646-70-lh5VSKWhXc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26646
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #111403|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Comment on attachment 111403
      --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111403
    Bug 26646: Group holds to pull by item rather than bib
    
    Obsoleting this patch that didn't quite work when I wrote it and almost
    certainly won't apply now.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 18:02:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 16:02:23 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-odq3uFRqm4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    --- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Marking as NSO to gather other's opinions
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 18:02:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 16:02:27 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-f63s9SjXsw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133313|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 18:02:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 16:02:30 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-6ZnV0AkSWZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133324|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 18:02:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 16:02:34 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-Ilp8LXWO4n@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133325|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 18:02:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 16:02:59 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-tHjBHeevtm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    --- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133327
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133327&action=edit
    Bug 30536: Unit tests
    
    This patch adds tests to make sure there's no behavior change regarding
    error conditions. When requests include wrong x-koha-embed values, a 400
    error should be returned, both in our original implementation or relying
    on the Mojolicious::Plugin::OpenAPI features.
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/api/v1/query.t
    => SUCCESS: Tests pass
    3. Apply the rest of the patches
    4. Repeat 2
    => SUCCESS: Tests still pass
    5. Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 18:03:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 16:03:04 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-uy3ZpClBPe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    --- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133328
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133328&action=edit
    Bug 30536: Refer to parameters enum
    
    This patch updates the stash_embed method to use the parameters hash
    enum instead of the top level x-koha-embed custom definition. This way
    we can remove the requirement for defining this list twice.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 18:03:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 16:03:09 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-djFiNxQYMK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    --- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133329
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133329&action=edit
    Bug 30536: Remove validation overhead
    
    With the introduction of proper validation of collection headers in
    OpenAPI we no longer need to do our own validation here.
    
    This patch removes the early validation of x-koha-embed headers in
    preference to letting OpenAPI do it once and only once instead.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 18:03:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 16:03:16 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-hg0Im8zntO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    --- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133330
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133330&action=edit
    Bug 30536: Update spec files
    
    This patch removes superflous x-koha-embed defintions at the top level
    of the endpoint specifications. It also replaces a few x-koha-embeds at
    the top level with parameter lists where this had been missed in
    preceeding patches.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 18:04:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 16:04:17 +0000
    Subject: [Koha-bugs] [Bug 28075] Add missing UNIMARC for coded data 135a
    In-Reply-To: <bug-28075-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28075-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28075-70-Cbp92d0n7k@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28075
    
    Igor A. Sychev <Igor.A.Sychev at mail.ru> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |Igor.A.Sychev at mail.ru
    
    --- Comment #10 from Igor A. Sychev <Igor.A.Sychev at mail.ru> ---
    Now only one character
    ---
    All data in $a is identified by character position within the subfield.
    Conventionally the character positions are numbered 0-12. Not repeatable.
    
    Table of Subfield $a Fixed-length Data Elements
    Name of Data Element | Number of Characters | Character Positions
    Type of electronic resource 1 0
    Special material designation 1 1
    Colour 1 2
    Dimensions 1 3
    Sound 1 4
    Image bit depth 3 5-7
    Number of file formats 1 8
    Quality assurance target(s) 1 9
    Antecedent/Source 1 10
    Level of compression 1 11
    Reformatting quality 1 12
    ---
    
    https://archive.ifla.org/VI/8/unimarc-concise-bibliographic-format-2008.pdf
    See also
    https://cdn.ifla.org/wp-content/uploads/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u_b_135a_1_update2019_onlne_final.pdf
    https://cdn.ifla.org/wp-content/uploads/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/b_135_update2017.pdf
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 18:16:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 16:16:54 +0000
    Subject: [Koha-bugs] [Bug 28072] Z39.50/SRU servers would be a great
     addition to Mana KB
    In-Reply-To: <bug-28072-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28072-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28072-70-h6RJ9iRRzH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28072
    
    Cab Vinton <bibliwho at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |bibliwho at gmail.com
    
    --- Comment #4 from Cab Vinton <bibliwho at gmail.com> ---
    +1 for this idea!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 18:18:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 16:18:42 +0000
    Subject: [Koha-bugs] [Bug 26646] Holds to Pull should show distinct
     item-level holds
    In-Reply-To: <bug-26646-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26646-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26646-70-ADvuUhoHJU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26646
    
    Rhonda Kuiper <rkuiper at roundrocktexas.gov> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |rkuiper at roundrocktexas.gov
    
    --- Comment #4 from Rhonda Kuiper <rkuiper at roundrocktexas.gov> ---
    We are interested in getting the holds to pull to show all item level holds for
    a biblio.  The situation that brought this problem to our attention is as
    follows:  Patron A puts item-level holds on two items on a single biblio
    record.  We run the hold to pull report and only one item shows on the report. 
    We pull it and scan it in.  Then later that day or the next morning we run the
    report again and the second item show up.  We pull it and scan it in.  The
    experience for the patron is that they get two hold notices between 4 and 18
    hours apart which could lead to two trips to the library when they could have
    received the hold notices at the 'same' time and made one trip. 
    Rhonda K.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 18:29:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 16:29:09 +0000
    Subject: [Koha-bugs] [Bug 30545] Replace the use of jQueryUI Accordion on
     the notices page
    In-Reply-To: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30545-70-nqyhBlHCQJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 18:29:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 16:29:12 +0000
    Subject: [Koha-bugs] [Bug 30545] Replace the use of jQueryUI Accordion on
     the notices page
    In-Reply-To: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30545-70-pOvpK6men8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545
    
    --- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133331
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133331&action=edit
    Bug 30545: Replace the use of jQueryUI Accordion on the notices page
    
    This patch updates the notices edit interface in order to replace
    jQueryUI accordion and tabs widgets with Bootstrap collapse and tabs.
    
    To test, apply the patch and rebuild the staff interface CSS
    (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
    
    - Set the TranslateNotices system preference to "Don't allow."
    - Go to Tools -> Notices and edit any notice.
    - On the "Modify notice" page you should see three collapsed sections:
      Email, Print, and SMS.
    - Clicking the section headings should expand and collapse the panels.
    - With one of the panels open, click Save -> Save and continue editing.
      - When the page reloads the same panel should be expanded.
    
    - Enable the TranslateNotices system preference.
    - Return to the edit interface for one of your notices.
    - You should now see at least two tabs: Default and English.
    - The sections under each tab should continue to work correctly.
    - Test the "Save and continue" functionality again. When redirected you
      should return to both the correct tab and the correct panel, e.g. the
      "Print" section under the "English (en)" tab.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 19:07:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 17:07:03 +0000
    Subject: [Koha-bugs] [Bug 30547] New: Plugin for coded data 123p UNIMARC
    Message-ID: <bug-30547-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30547
    
                Bug ID: 30547
               Summary: Plugin for coded data 123p UNIMARC
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: MARC Bibliographic data support
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: Igor.A.Sychev at mail.ru
            QA Contact: testopia at bugs.koha-community.org
    
    Please, add plugin for coded data 123p UNIMARC
    
    $p Planet (Mandatory for planets other than Earth, Not repeatable) 
    $p/0-1 Planet 
    ea Earth 
    ju Jupiter 
    ma Mars 
    me Mercury 
    ne Neptune 
    pl Pluto 
    sa Saturn 
    ur Uranus 
    ve Venus 
    zz Other 
    $p/2 Satellite 
    s The body whose co-ordinates are recorded in subfields $d-$g is a satellite of
    the planet coded on pos. 0-1. 
    y Not applicable: the body whose co-ordinates are recorded in subfields $d-$g
    is the planet itself, as coded on pos. 0-1. 
    
    https://archive.ifla.org/VI/8/unimarc-concise-bibliographic-format-2008.pdf
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 19:14:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 17:14:40 +0000
    Subject: [Koha-bugs] [Bug 30547] Plugin for coded data 123p UNIMARC
    In-Reply-To: <bug-30547-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30547-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30547-70-C3Gb6dBCXD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30547
    
    --- Comment #1 from Igor A. Sychev <Igor.A.Sychev at mail.ru> ---
    https://cdn.ifla.org/wp-content/uploads/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u-b_123_update.pdf
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 19:27:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 17:27:51 +0000
    Subject: [Koha-bugs] [Bug 30548] New: Plugin for coded data 181 UNIMARC
    Message-ID: <bug-30548-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30548
    
                Bug ID: 30548
               Summary: Plugin for coded data 181 UNIMARC
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: MARC Bibliographic data support
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: Igor.A.Sychev at mail.ru
            QA Contact: testopia at bugs.koha-community.org
    
    Please, add plugins for coded data 181a and 181b UNIMARC
    
    https://cdn.ifla.org/wp-content/uploads/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/b_181_new2016.pdf
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 20:00:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 18:00:17 +0000
    Subject: [Koha-bugs] [Bug 30549] New: Replace the use of jQueryUI Accordion
     on pending patron updates page
    Message-ID: <bug-30549-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549
    
                Bug ID: 30549
               Summary: Replace the use of jQueryUI Accordion on pending
                        patron updates page
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Templates
              Assignee: oleonard at myacpl.org
              Reporter: oleonard at myacpl.org
            QA Contact: testopia at bugs.koha-community.org
                    CC: testopia at bugs.koha-community.org
            Depends on: 30494
                Blocks: 29224
    
    As part of Bug 29224, "OMNIBUS: Replace the use of jQueryUI Accordion" we
    should replace the use of the jQueryUI accordion component on the pending
    patron updates page with Bootstrap's Collapse component.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29224
    [Bug 29224] OMNIBUS: Replace the use of jQueryUI Accordion
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30494
    [Bug 30494] Replace the use of jQueryUI Accordion on the table settings page
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 20:00:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 18:00:17 +0000
    Subject: [Koha-bugs] [Bug 30494] Replace the use of jQueryUI Accordion on
     the table settings page
    In-Reply-To: <bug-30494-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30494-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30494-70-Fy5C53x4JP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30494
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30549
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549
    [Bug 30549] Replace the use of jQueryUI Accordion on pending patron updates
    page
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 20:00:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 18:00:17 +0000
    Subject: [Koha-bugs] [Bug 29224] OMNIBUS: Replace the use of jQueryUI
     Accordion
    In-Reply-To: <bug-29224-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29224-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29224-70-INFIdCVBTt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29224
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30549
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549
    [Bug 30549] Replace the use of jQueryUI Accordion on pending patron updates
    page
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 20:08:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 18:08:26 +0000
    Subject: [Koha-bugs] [Bug 30535] Add "Tool plugins" to the main tools screen
    In-Reply-To: <bug-30535-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30535-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30535-70-GHyVOcEvlo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30535
    
    --- Comment #1 from Fred King <fred.king at medstar.net> ---
    Update: I added a tool plugin, and now "Tool plugins" appears on the main Tools
    page, with my plugin listed under it. Maybe it needs a plugin to appear?
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 20:11:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 18:11:58 +0000
    Subject: [Koha-bugs] [Bug 30549] Replace the use of jQueryUI Accordion on
     pending patron updates page
    In-Reply-To: <bug-30549-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30549-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30549-70-qzPg90aBPH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 20:12:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 18:12:02 +0000
    Subject: [Koha-bugs] [Bug 30549] Replace the use of jQueryUI Accordion on
     pending patron updates page
    In-Reply-To: <bug-30549-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30549-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30549-70-MQXstezI2A@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549
    
    --- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133332
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133332&action=edit
    Bug 30549: Replace the use of jQueryUI Accordion on pending patron updates page
    
    This patch updates the pending patron updates page to use Bootstrap
    collapse instead of jQueryUI.
    
    This patch contains whitespace changes, so view the diff with this in
    mind.
    
    To test, apply the patch and rebuild the staff client CSS
    (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
    
    - If necessary, log into the OPAC and submit an update via the "Your
      personal details" page. Ideally do this for two or more patrons.
    - In the staff client, follow the "Patrons requesting modifications"
      link.
    - On the "Update patron records" page you should see the headings
      representing each of the patrons with pending updates. The first panel
      should be expanded.
    - Confirm that the panels expand and collapse correctly.
    - Follow the "Patron details" link for one of these patrons.
    - Click the "Review pending modifications" link on the patron detail
      page.
    - When the update page opens that patron's panel should be expanded.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 20:23:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 18:23:16 +0000
    Subject: [Koha-bugs] [Bug 3935] Schedule tasks periodically
    In-Reply-To: <bug-3935-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-3935-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-3935-70-epDwzByuPb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3935
    
    Patrick Robitaille <patrick.robitaille at collecto.ca> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |patrick.robitaille at collecto
                       |                            |.ca
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 20:26:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 18:26:41 +0000
    Subject: [Koha-bugs] [Bug 30550] New: OPAC recalls page tries to use
     jQueryUI datepicker
    Message-ID: <bug-30550-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30550
    
                Bug ID: 30550
               Summary: OPAC recalls page tries to use jQueryUI datepicker
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: normal
              Priority: P5 - low
             Component: OPAC
              Assignee: oleonard at myacpl.org
              Reporter: oleonard at myacpl.org
            QA Contact: testopia at bugs.koha-community.org
            Depends on: 29212
    
    The OPAC recalls template predates the switch to Flatpickr, but without
    jQueryUI datepicker available the calendar popup doesn't work.
    
    This patch will implement Flatpickr for that field.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212
    [Bug 29212] Use Flatpickr on OPAC pages
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 20:26:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 18:26:41 +0000
    Subject: [Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
    In-Reply-To: <bug-29212-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29212-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29212-70-kHO5jlCUHW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30550
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30550
    [Bug 30550] OPAC recalls page tries to use jQueryUI datepicker
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 20:33:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 18:33:40 +0000
    Subject: [Koha-bugs] [Bug 30550] OPAC recalls page tries to use jQueryUI
     datepicker
    In-Reply-To: <bug-30550-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30550-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30550-70-eQRZYzL7Fo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30550
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
       Patch complexity|---                         |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 20:33:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 18:33:44 +0000
    Subject: [Koha-bugs] [Bug 30550] OPAC recalls page tries to use jQueryUI
     datepicker
    In-Reply-To: <bug-30550-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30550-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30550-70-UVxkx7JRvV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30550
    
    --- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133333
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133333&action=edit
    Bug 30550: OPAC recalls page tries to use jQueryUI datepicker
    
    This patch updates the recalls page in the OPAC so that it uses
    Flatpickr for the "Recall not needed after" field.
    
    To test apply the patch and enable the UseRecalls preference if
    necessary. You made need to update your circulation rules as well,
    defining some default values for recalls.
    
    - Log in to the OPAC.
    - Locate a bibliographic record which has one item and that item is
      checked out.
    - Click "Place recall."
    - The "Recall not needed after" field should be styled correctly, and
      clicking it should trigger the calendar popup.
    - You should be limited to selections after today's date.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 23:37:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 21:37:56 +0000
    Subject: [Koha-bugs] [Bug 30551] New: Cash register report shows wrong
     library when paying fees in two different libraries
    Message-ID: <bug-30551-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30551
    
                Bug ID: 30551
               Summary: Cash register report shows wrong library when paying
                        fees in two different libraries
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: minor
              Priority: P5 - low
             Component: Reports
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: shi-yao.wang at inLibro.com
            QA Contact: testopia at bugs.koha-community.org
    
    Cash register report shows wrong transaction library when paying fees in
    different libraries using the same account.
    
    Test plan to reproduce the bug:
    1- Use cash registers (administration > system preferences > UseCashRegisters)
    2- Create another library if you only have one (administration > libraries >
    new library)
    3- Create a cash register in each library if they don't already have one
    (administration > cash registers > new cash register)
    4- Create a fee on your own account and pay it right after in both libraries.
    5- Go to reports > cash register and generate the statistics.
    6- Notice "transaction library" in both rows are the same even though the fees
    were paid in two different libraries and two different cash registers.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 14 23:38:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 14 Apr 2022 21:38:07 +0000
    Subject: [Koha-bugs] [Bug 30551] Cash register report shows wrong library
     when paying fees in two different libraries
    In-Reply-To: <bug-30551-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30551-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30551-70-Dmsx2sZf6W@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30551
    
    Shi Yao Wang <shi-yao.wang at inLibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |shi-yao.wang at inLibro.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 02:28:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 00:28:42 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-k4scx57LFX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Failed QA
    
    --- Comment #13 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Issues found:
    - make a hold
    - go the patron detail page
    - click on the holds tab
    - list is empty, but it shouldn't
    - js console:
    
    Uncaught TypeError: can't access property "id", ui.newTab.context is undefined
        activate
    http://localhost:8081/intranet-tmpl/prog/js/pages/circulation_21.1200033.js:14
        jQuery 32
        <anonymous>
    http://localhost:8081/intranet-tmpl/prog/js/pages/circulation_21.1200033.js:12
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 08:29:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 06:29:07 +0000
    Subject: [Koha-bugs] [Bug 30435] Remove unused MACLES cataloging plugin
    In-Reply-To: <bug-30435-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30435-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30435-70-E5qgwdq3lU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30435
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 08:29:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 06:29:13 +0000
    Subject: [Koha-bugs] [Bug 30435] Remove unused MACLES cataloging plugin
    In-Reply-To: <bug-30435-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30435-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30435-70-aJTxECS353@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30435
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133223|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133334
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133334&action=edit
    Bug 30435: Remove unused MACLES cataloging plugin
    
    This patch removes the files associated with the MACLES cataloging
    plugin. The feature is unmaintained.
    
    Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 08:29:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 06:29:30 +0000
    Subject: [Koha-bugs] [Bug 30435] Remove unused MACLES cataloging plugin
    In-Reply-To: <bug-30435-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30435-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30435-70-iyh7h23XPe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30435
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                       |y.org                       |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 08:32:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 06:32:54 +0000
    Subject: [Koha-bugs] [Bug 30544] Add font awesome version to licenses page
    In-Reply-To: <bug-30544-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30544-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30544-70-9pHLjEjqMN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30544
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 08:32:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 06:32:58 +0000
    Subject: [Koha-bugs] [Bug 30544] Add font awesome version to licenses page
    In-Reply-To: <bug-30544-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30544-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30544-70-wQz60PzaLz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30544
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133312|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133335
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133335&action=edit
    Bug 30544: Add font awesome version to licenses page
    
    This patch simply adds the version number we are using
    and updates the link to point to our version
    
    To test:
    1 - Confirm the About->Licenses page points to the correct Font Awesome
        version
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 08:33:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 06:33:16 +0000
    Subject: [Koha-bugs] [Bug 30544] Add font awesome version to licenses page
    In-Reply-To: <bug-30544-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30544-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30544-70-xtjatoOPaz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30544
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                       |y.org                       |
                     CC|                            |m.de.rooy at rijksmuseum.nl
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 08:36:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 06:36:46 +0000
    Subject: [Koha-bugs] [Bug 30540] Double processing invalid dates can lead to
     ISE
    In-Reply-To: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30540-70-GcDlzIc5MC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30540
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Trivial patch
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 08:36:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 06:36:50 +0000
    Subject: [Koha-bugs] [Bug 30540] Double processing invalid dates can lead to
     ISE
    In-Reply-To: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30540-70-iljt48ZTrz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30540
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133297|0                           |1
            is obsolete|                            |
    
    --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133336
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133336&action=edit
    Bug 30540: Unit test
    
    This patch adds tests for checking the output_pref method against
    a timezone and datetime that would cause an Invalid local time failure
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
       k$ prove t/DateUtils.t
    => FAIL: The feature is not implemented, tests fail to complete
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 08:36:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 06:36:55 +0000
    Subject: [Koha-bugs] [Bug 30540] Double processing invalid dates can lead to
     ISE
    In-Reply-To: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30540-70-wWUgPpHqWI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30540
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133298|0                           |1
            is obsolete|                            |
    
    --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133337
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133337&action=edit
    Bug 30540: eval on set_time_zone
    
    This patch adds an eval around the call to set_time_zone so that we
    don't crash on invalid local dates and instead just keep the passed
    floating timezone.
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 08:36:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 06:36:59 +0000
    Subject: [Koha-bugs] [Bug 30540] Double processing invalid dates can lead to
     ISE
    In-Reply-To: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30540-70-poSr3H2IUt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30540
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133299|0                           |1
            is obsolete|                            |
    
    --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133338
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133338&action=edit
    Bug 30540: Fix perl critic complaint of leading zeros
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 08:37:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 06:37:15 +0000
    Subject: [Koha-bugs] [Bug 30540] Double processing invalid dates can lead to
     ISE
    In-Reply-To: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30540-70-XGeOCFePyf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30540
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |m.de.rooy at rijksmuseum.nl
             QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                       |y.org                       |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 08:44:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 06:44:31 +0000
    Subject: [Koha-bugs] [Bug 18392] Allow importing/exporting circulation
     conditions as CSV or spreadsheet
    In-Reply-To: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18392-70-wRUq5mtYil@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 08:44:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 06:44:36 +0000
    Subject: [Koha-bugs] [Bug 18392] Allow importing/exporting circulation
     conditions as CSV or spreadsheet
    In-Reply-To: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18392-70-Z21w9gK2Dt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133283|0                           |1
            is obsolete|                            |
    
    --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133339
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133339&action=edit
    Bug 18392: use KohaTable for circ rules to allow export of matrix
    
    To test:
    1 - Define some circ rules
    2 - View them, note the appearance
    3 - Apply patch
    4 - Reload and note change of header
    5 - Use the new button to export, try various formats
    6 - Test the filter and export
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 08:44:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 06:44:40 +0000
    Subject: [Koha-bugs] [Bug 18392] Allow importing/exporting circulation
     conditions as CSV or spreadsheet
    In-Reply-To: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18392-70-bKprAz3nVv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133284|0                           |1
            is obsolete|                            |
    
    --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133340
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133340&action=edit
    Bug 18392: Add noExport of rows and don't export 'edit' row
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 08:45:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 06:45:03 +0000
    Subject: [Koha-bugs] [Bug 18392] Allow importing/exporting circulation
     conditions as CSV or spreadsheet
    In-Reply-To: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18392-70-ydNDEdHYp6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |m.de.rooy at rijksmuseum.nl
             QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                       |y.org                       |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 08:57:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 06:57:43 +0000
    Subject: [Koha-bugs] [Bug 30488] Error when placing a recall in the OPAC
    In-Reply-To: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30488-70-lcaiKGk1Fc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |m.de.rooy at rijksmuseum.nl
    
    --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Owen Leonard from comment #0)
    > I'm getting an error when placing a recall from the OPAC. It appears at the
    > last stage, after clicking the submit button to place the recall.
    > 
    > Validation failed for type named Month declared in package DateTime::Types
    > (/usr/lib/x86_64-linux-gnu/perl5/5.28/DateTime/Types.pm) at line 119 in sub
    > named (eval) with value 29
    
    I'm crashing too but the error described does not come up. Instead I see:
    
    Use of inherited AUTOLOAD for non-method Koha::Recalls::UpdateStats() is no
    longer allowed at /usr/share/koha/Koha/Recalls.pm line 168
    
    And this message fits the suggested solution better ;)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 08:59:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 06:59:18 +0000
    Subject: [Koha-bugs] [Bug 30488] Error when placing a recall in the OPAC
    In-Reply-To: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30488-70-ngiZAVqAwt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 08:59:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 06:59:22 +0000
    Subject: [Koha-bugs] [Bug 30488] Error when placing a recall in the OPAC
    In-Reply-To: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30488-70-o3zzaHcn6q@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133148|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133341
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133341&action=edit
    Bug 30488: Fix error when placing recall via OPAC
    
    This error occurs due to how UpdateStats is called in Koha/Recalls.pm
    
    To test:
    1) Enable the UseRecalls system preference and set some random values in
    the recalls circulation and fines rules.
    2) Find or create an item. Check this item out to Patron A.
    3) Log in to the OPAC as Patron B.
    4) Find the item you checked out to Patron A. Click the button to place
    a recall.
    5) Fill out whatever details you like. Click the Submit button. This
    should trigger the error.
    6) Apply the patch and refresh the page.
    7) Confirm the recall has now been requested successfully.
    
    Sponsored-by: Catalyst IT
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 08:59:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 06:59:43 +0000
    Subject: [Koha-bugs] [Bug 30488] Error when placing a recall in the OPAC
    In-Reply-To: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30488-70-9vV74OpNuc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                       |y.org                       |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 09:31:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 07:31:31 +0000
    Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on
     fresh install, but can be null with upgrade
    In-Reply-To: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27253-70-3L23mf5nXd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |m.de.rooy at rijksmuseum.nl
             QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                       |y.org                       |
    
    --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    QA: Looking here
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 09:34:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 07:34:42 +0000
    Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on
     fresh install, but can be null with upgrade
    In-Reply-To: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27253-70-8ZzpC9rzfz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253
    
    --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Kyle M Hall from comment #0)
    > Simply put, the borrowers table column updated_on in kohastructure.sql
    > specifies  that it cannot be null, but the updatedatabase.pl it can. It
    > appears the NOT got lost when the column as renamed 'updated_on' from
    > 'timestamp' in a followup on bug 10459.
    > 
    > Fixing it is easy, the question is, what do we do with currently NULL
    > updated_on's? My though is to set them to the unix epoch ( 1970-01-01 ).
    
    (In reply to Jonathan Druart from comment #1)
    > What about MAX(date_renewed, dateenrolled, last_seen)?
    
    I think it is an arbitrary choice.
    For my part NOW() would have been good either (and much easier). After all, we
    are updating those borrowers .. now, right?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 09:37:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 07:37:57 +0000
    Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on
     fresh install, but can be null with upgrade
    In-Reply-To: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27253-70-ANa7fYXpQF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253
    
    --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    $DBversion = "16.06.00.002";
    if ( CheckVersion($DBversion) ) {
        unless ( column_exists('borrowers', 'updated_on') ) {
            $dbh->do(q{
                ALTER TABLE borrowers
                    ADD COLUMN updated_on timestamp NULL DEFAULT CURRENT_TIMESTAMP
                    ON UPDATE CURRENT_TIMESTAMP
                    AFTER privacy_guarantor_checkouts;
            });
            $dbh->do(q{
                ALTER TABLE deletedborrowers
                    ADD COLUMN updated_on timestamp NULL DEFAULT CURRENT_TIMESTAMP
                    ON UPDATE CURRENT_TIMESTAMP
                    AFTER privacy_guarantor_checkouts;
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 09:39:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 07:39:52 +0000
    Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on
     fresh install, but can be null with upgrade
    In-Reply-To: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27253-70-EuipnhVYTj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 09:39:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 07:39:56 +0000
    Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on
     fresh install, but can be null with upgrade
    In-Reply-To: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27253-70-QqeOG7oPDo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132934|0                           |1
            is obsolete|                            |
    
    --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133342
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133342&action=edit
    Bug 27253: Fix definition of updated_on in borrowers and deletedborrowers
    
    Test plan:
    1. First you have to be in a state where updated_on is NULL-able. You
       can do that by either:
       a) do a fresh install of Koha 16.05 and update to master, or
       b) execute the following SQL queries:
    
         ALTER TABLE borrowers MODIFY updated_on timestamp NULL
         DEFAULT current_timestamp() ON UPDATE current_timestamp()
         COMMENT 'time of last change could be useful for synchronization
         with external systems (among others)'
    
         ALTER TABLE deletedborrowers MODIFY updated_on timestamp NULL
         DEFAULT current_timestamp() ON UPDATE current_timestamp()
         COMMENT 'time of last change could be useful for synchronization
         with external systems (among others)'
    2. Create two borrowers (let's name them X and Y)
    3. Delete borrower Y
    4. Set the column updated_on to NULL for both borrowers by executing the
       following SQL query:
       UPDATE borrowers SET updated_on = NULL WHERE borrowernumber =
       <borrowernumber of X>
       UPDATE deletedborrowers SET updated_on = NULL WHERE borrowernumber =
       <borrowernumber of Y>
    5. Apply patch and run updatedatabase
    6. Verify that borrowers.updated_on and deletedborrowers.updated_on are
       not NULL-able.
       Verify that updated_on for X and Y have taken the value of
       dateenrolled.
    7. Repeat step 2 to 6 but this time renew the patron and/or log in with
       its account in order to set the columns borrowers.date_renewed and
       borrowers.lastseen before executing updatedatabase
       borrowers.updated_on should take the greatest value among
       dateenrolled, date_renewed, and lastseen
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 09:40:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 07:40:55 +0000
    Subject: [Koha-bugs] [Bug 30486] [OMNIBUS] Synchronize database schema with
     (older) database revisions
    In-Reply-To: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30486-70-7WKu6x1CR8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |27253
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253
    [Bug 27253] borrowers.updated_on cannot be null on fresh install, but can be
    null with upgrade
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 09:40:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 07:40:55 +0000
    Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on
     fresh install, but can be null with upgrade
    In-Reply-To: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27253-70-zJtnuyd4Dh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30486
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
    [Bug 30486] [OMNIBUS] Synchronize database schema with (older) database
    revisions
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 09:49:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 07:49:58 +0000
    Subject: [Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when
     adding/editing items
    In-Reply-To: <bug-29815-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29815-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29815-70-Ve40xOYmLN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 09:50:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 07:50:02 +0000
    Subject: [Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when
     adding/editing items
    In-Reply-To: <bug-29815-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29815-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29815-70-RxYzZtroDZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133221|0                           |1
            is obsolete|                            |
    
    --- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133343
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133343&action=edit
    Bug 29815: Pre-populate 'Date acquired' field when adding/editing items
    
    This patch pre-fills the 952$d (Date acquired) item subfield on page
    load. Users can still click on the field to fill this subfield.
    
    Test plan:
    1. Visit a biblio. Add an item, observe on page load the 'Date acquired'
    subfield is
    empty
    2. Visit a subscription. Receive a serial, observe after setting the serial
    status to 'Arrived' the item form loads with an empty 'Date acquired' subfield
    3. Apply patch and restart services
    4. Repeat step 1 and confirm now on page load the 'Date acquired'
    subfield populates with today's date
    5. Delete the populated 'Date acquired' subfield value. Click in the
    field and confirm the field is populated and the calendar input displays
    6. Delete the 'Date acquired' subfield value again. Confirm that tabbing
    from a different field into the date acquired field behaves the same as
    click
    7. Repeat step 2. This time confirm on page load the 'Date acquired' subfield
    contains the current date
    8. Delete the populated 'Date acquired' subfield value. Click in the
    field and confirm it is populated
    9. Delete the populated 'Date acquired' subfield value. Tab to the field
    from another field and confirm it behaves the same as click
    10. Visit a biblio. Edit an item with a date acquired value in
    the past. Confirm the date acquired value is unchanged after saving.
    
    Sponsored-By: Brimbank Library, Australia
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 09:50:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 07:50:23 +0000
    Subject: [Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when
     adding/editing items
    In-Reply-To: <bug-29815-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29815-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29815-70-LM0OVsoaHF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |m.de.rooy at rijksmuseum.nl
             QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                       |y.org                       |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 09:53:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 07:53:14 +0000
    Subject: [Koha-bugs] [Bug 30438] Add select all/clear buttons to invoices.tt
     open and closed tables
    In-Reply-To: <bug-30438-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30438-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30438-70-nKsoeVlTp8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30438
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |m.de.rooy at rijksmuseum.nl
                 Status|Signed Off                  |Patch doesn't apply
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 11:02:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 09:02:15 +0000
    Subject: [Koha-bugs] [Bug 24865] Customize the Accountlines Description
    In-Reply-To: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24865-70-gNeZ0s2QiZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Failed QA
                     CC|                            |m.de.rooy at rijksmuseum.nl
    
    --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    I have my doubts about whats going on here. Maybe I dont fully understand.
    
    [1] Isnt it a very expensive way to go thru notices to concatenate two fields:
    [% item.biblio.title %] [% checkout.date_due | $KohaDates %]
    
    [2] In the description a reference is made to deleted items. If an item is
    deleted, there is no issue anymore too. I dont see how you create a better
    description here? Can you explain in which exact situation you reach the else
    block where you call the letter? (No accountline found, amount>0, item
    deleted?)
    
    Note: commit message refers to item deletion, but test plan does not include
    it.
    
    Changing status: need for feedback.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 11:02:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 09:02:26 +0000
    Subject: [Koha-bugs] [Bug 24865] Customize the Accountlines Description
    In-Reply-To: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24865-70-h8RE6pH5WX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                       |y.org                       |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 11:16:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 09:16:37 +0000
    Subject: [Koha-bugs] [Bug 24865] Customize the Accountlines Description
    In-Reply-To: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24865-70-BNHnsZOlSV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131286|0                           |1
            is obsolete|                            |
    
    --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133344
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133344&action=edit
    Bug 24865: Customize the Accountlines Description
    
    It would be great if we could customize what information was added to the
    "Description of charges" field when a fine was made so data could be stored
    even when the item is deleted.
    
    Test Plan:
    1) Create an overdue checkout that will get a fine
    2) Run fines.pl
    3) Note the description for the fine
    4) Delete the fine from the database
    5) Apply this patch
    6) Run updatedatabase.pl
    7) Restart all the things!
    8) Run fines.pl
    9) Note the description of the fine is unchanged
    10) Delete the fine again
    11) Browse to Slips & Notices
    12) Edit the new notice OVERDUE_FINE_DESC
        You will have access to the objects checkout, item, and borrower
    13) Run fines.pl
    14) Note your new description was used
    
    Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 11:30:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 09:30:31 +0000
    Subject: [Koha-bugs] [Bug 30237] Rename/rephrase
     AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use
    In-Reply-To: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30237-70-mB15U2kHZV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 11:30:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 09:30:35 +0000
    Subject: [Koha-bugs] [Bug 30237] Rename/rephrase
     AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use
    In-Reply-To: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30237-70-B7ZaNhPxpc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133153|0                           |1
            is obsolete|                            |
    
    --- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133345
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133345&action=edit
    Bug 30237: Replace ACCDETAILS notice with WELCOME notice
    
    This patch drops the ACCDETAILS notice in preference to a new WELCOME
    notice.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 11:30:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 09:30:40 +0000
    Subject: [Koha-bugs] [Bug 30237] Rename/rephrase
     AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use
    In-Reply-To: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30237-70-pTdeYkwJhN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133154|0                           |1
            is obsolete|                            |
    
    --- Comment #24 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133346
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133346&action=edit
    Bug 30237: Reference new WELCOME notice
    
    This patch updates all references to the former ACCTDETAILS notice to
    use the new WELCOME email notice instead.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 11:30:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 09:30:44 +0000
    Subject: [Koha-bugs] [Bug 30237] Rename/rephrase
     AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use
    In-Reply-To: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30237-70-r2c24VbZYH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133155|0                           |1
            is obsolete|                            |
    
    --- Comment #25 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133347
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133347&action=edit
    Bug 30237: Replace AutoEmailOpacUser with AutoEmailNewUser
    
    This patch replaces the AutoEmailOpacUser system preference with a new
    AutoEmailNewUser preference. This makes the functionof the preference
    clearer.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 11:30:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 09:30:48 +0000
    Subject: [Koha-bugs] [Bug 30237] Rename/rephrase
     AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use
    In-Reply-To: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30237-70-KMD70jUrGY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133156|0                           |1
            is obsolete|                            |
    
    --- Comment #26 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133348
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133348&action=edit
    Bug 30237: (follow-up) Update Notice
    
    This patch updates the sample notice as suggested by Katrin.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 11:30:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 09:30:52 +0000
    Subject: [Koha-bugs] [Bug 30237] Rename/rephrase
     AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use
    In-Reply-To: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30237-70-PUwmWmwkBO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133157|0                           |1
            is obsolete|                            |
    
    --- Comment #27 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133349
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133349&action=edit
    Bug 30237: (follow-up) Add french sample notice
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 11:30:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 09:30:57 +0000
    Subject: [Koha-bugs] [Bug 30237] Rename/rephrase
     AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use
    In-Reply-To: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30237-70-BvbaKLOTAc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133158|0                           |1
            is obsolete|                            |
    
    --- Comment #28 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133350
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133350&action=edit
    Bug 30237: Add a note about WELCOME notice to system preference
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 11:31:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 09:31:02 +0000
    Subject: [Koha-bugs] [Bug 30237] Rename/rephrase
     AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use
    In-Reply-To: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30237-70-IXxh72jX8x@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133159|0                           |1
            is obsolete|                            |
    
    --- Comment #29 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133351
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133351&action=edit
    Bug 30237: (follow-up) Make LibraryName conditional
    
    It's easy to forget to set the LibraryName preference.. as such we can
    make this a conditional and fall back to a default of 'the library'.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 11:31:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 09:31:07 +0000
    Subject: [Koha-bugs] [Bug 30237] Rename/rephrase
     AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use
    In-Reply-To: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30237-70-XydX7YoeDt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237
    
    --- Comment #30 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133352
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133352&action=edit
    Bug 30237: (QA follow-up) Spelling
    
    Thankyou => Thank you
    No thanks ;)
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 11:31:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 09:31:22 +0000
    Subject: [Koha-bugs] [Bug 30237] Rename/rephrase
     AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use
    In-Reply-To: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30237-70-ZEKTxav0NC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                       |y.org                       |
                     CC|                            |m.de.rooy at rijksmuseum.nl
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 11:32:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 09:32:46 +0000
    Subject: [Koha-bugs] [Bug 30226] Add system preference to disable auto-renew
     checkbox at checkout
    In-Reply-To: <bug-30226-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30226-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30226-70-71dPZ8J6On@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                       |ity.org                     |
                     CC|                            |m.de.rooy at rijksmuseum.nl
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 11:34:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 09:34:55 +0000
    Subject: [Koha-bugs] [Bug 30226] Add system preference to disable auto-renew
     checkbox at checkout
    In-Reply-To: <bug-30226-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30226-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30226-70-oFtrRdEY0p@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226
    
    --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    +            INSERT IGNORE INTO systempreferences (`variable`, `value`,
    `options`, `explanation`, `type` ) VALUES('AllowSetAutomaticRenewal', '1',
    '|yes|no', 'Allow or Prevent staff from flagging items for autorenewal on the
    checkout page', 'YesNo')
    
    | before yes seems unneeded
    Allow or Prevent should probably be Allow or prevent
    
    No blocker
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 11:35:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 09:35:37 +0000
    Subject: [Koha-bugs] [Bug 30226] Add system preference to disable auto-renew
     checkbox at checkout
    In-Reply-To: <bug-30226-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30226-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30226-70-d4gE0uk3nH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226
    
    --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    +        # Finished adding system preference AllowSetAutomaticRenewal
    +        say $out "Added system preference AllowSetAutomaticRenewal";
    
    Not needed. You just repeat yourself here.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 11:36:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 09:36:18 +0000
    Subject: [Koha-bugs] [Bug 30226] Add system preference to disable auto-renew
     checkbox at checkout
    In-Reply-To: <bug-30226-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30226-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30226-70-xXHnMYPyXT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226
    
    --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    +('AllowSetAutomaticRenewal','1',NULL,'If ON, allows staff to set items for
    automatic renewal on the check out page','YesNo'),
    
    Other description. Not consistent.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 11:40:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 09:40:22 +0000
    Subject: [Koha-bugs] [Bug 30226] Add system preference to disable auto-renew
     checkbox at checkout
    In-Reply-To: <bug-30226-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30226-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30226-70-Z14XzZIcRK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226
    
    --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Marcel de Rooy from comment #5)
    > | before yes seems unneeded
    
    Actually it is a YesNo, so there should be no choices.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 11:47:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 09:47:35 +0000
    Subject: [Koha-bugs] [Bug 30226] Add system preference to disable auto-renew
     checkbox at checkout
    In-Reply-To: <bug-30226-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30226-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30226-70-Lqsdw9BnJ7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 11:47:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 09:47:39 +0000
    Subject: [Koha-bugs] [Bug 30226] Add system preference to disable auto-renew
     checkbox at checkout
    In-Reply-To: <bug-30226-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30226-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30226-70-640JhHqYTJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131618|0                           |1
            is obsolete|                            |
    
    --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133353
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133353&action=edit
    Bug 30226: Add system preference AllowSetAutomaticRenewal
    
    To test:
    1. Apply patch, restart the things, and run updatedatabase
    2. Look for the system preference 'AllowSetAutomaticRenewal'.
    3. To preserve current behavior the system preference should be set to allow by
    default.
    4. Go to the circulation page and see that under 'Checkout settings' there is
    the option to set a particular item for auto renewal.
    5. Set 'AllowSetAutomaticRenewal' to 'don't allow'.
    6. Go back to the circulation page and under checkout settings you should no
    longer see the option to set an item for auto renewal.
    
    Signed-off-by: Kelly mcElligott <kelly at bywatersolutions.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 11:47:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 09:47:44 +0000
    Subject: [Koha-bugs] [Bug 30226] Add system preference to disable auto-renew
     checkbox at checkout
    In-Reply-To: <bug-30226-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30226-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30226-70-SwSeVBrX0J@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226
    
    --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133354
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133354&action=edit
    Bug 30226: (QA follow-up) Sync atomicupdate with sysprefs.sql
    
    Description and remove choices.
    Set items => flag items (as in circulation.pref)
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 11:48:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 09:48:18 +0000
    Subject: [Koha-bugs] [Bug 30226] Add system preference to disable auto-renew
     checkbox at checkout
    In-Reply-To: <bug-30226-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30226-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30226-70-gtjHXfJuXc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                       |y.org                       |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 11:54:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 09:54:34 +0000
    Subject: [Koha-bugs] [Bug 30288] Provide links to OPACUserJS and OPACUserCSS
     in tools
    In-Reply-To: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30288-70-nTOhkht9lq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 11:54:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 09:54:38 +0000
    Subject: [Koha-bugs] [Bug 30288] Provide links to OPACUserJS and OPACUserCSS
     in tools
    In-Reply-To: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30288-70-NNL5pkuGg6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131704|0                           |1
            is obsolete|                            |
     Attachment #131765|0                           |1
            is obsolete|                            |
    
    --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133355
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133355&action=edit
    Bug 30288: Provide links to OPACUserJS and OPACUserCSS in tools
    
    This patch provides easy access to the OPACUserJS and OPACUserCSS
    system  preferences in the Additional Contents (News and HTML
    customisations) sections.
    
    To test:
    
    1. In the staff client, go to Tools -> News. Notice there is a button to
       add a New entry. Confirm this button is also there when you go to
       Tools -> HTML customisations.
    2. Apply the patch and refresh the page.
    3. Confirm there are now two new buttons to take you to OPACUserJS and
       OPACUserCSS. Confirm these buttons take you to the correct system
       preference.
    
    Sponsored-by: Catalyst IT
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Bug 30288: (follow-up) Add permissions check
    
    This follow-up wraps the system preference links in a check for
    "parameters_manage_sysprefs" permission so that the links don't display
    to those without permission to access system preferences.
    
    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 11:55:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 09:55:02 +0000
    Subject: [Koha-bugs] [Bug 30288] Provide links to OPACUserJS and OPACUserCSS
     in tools
    In-Reply-To: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30288-70-Uts19WzsM6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |m.de.rooy at rijksmuseum.nl
             QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                       |y.org                       |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 12:16:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 10:16:33 +0000
    Subject: [Koha-bugs] [Bug 30404] Enlarge all patron searches pop-up
    In-Reply-To: <bug-30404-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30404-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30404-70-FdPjhl4e8v@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30404
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
             Resolution|---                         |FIXED
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 12:24:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 10:24:03 +0000
    Subject: [Koha-bugs] [Bug 30172] Background jobs failing due to race
     condition
    In-Reply-To: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30172-70-7KXL36We3j@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
    
    --- Comment #38 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Doesn't apply to 21.11.x. Please rebase if you'd like this to be backported.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 12:26:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 10:26:05 +0000
    Subject: [Koha-bugs] [Bug 22490] Some strings in javascript files are
     untranslatable
    In-Reply-To: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22490-70-5zlyfeQ9Qj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22490
    
    Julian Maurice <julian.maurice at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |ASSIGNED
               Assignee|koha-bugs at lists.koha-commun |jeremy.breuillard at biblibre.
                       |ity.org                     |com
                     CC|                            |julian.maurice at biblibre.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 12:35:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 10:35:43 +0000
    Subject: [Koha-bugs] [Bug 30402] Authority import hanging when replacing
     matched record
    In-Reply-To: <bug-30402-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30402-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30402-70-JrMU86XzgD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30402
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |Pushed to stable
             Version(s)|22.05.00                    |22.05.00,21.11.05
            released in|                            |
    
    --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 12:36:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 10:36:20 +0000
    Subject: [Koha-bugs] [Bug 11083] Authority search result display in staff
     interface should be XSLT driven
    In-Reply-To: <bug-11083-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-11083-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-11083-70-3J56r6bfsg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 12:36:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 10:36:21 +0000
    Subject: [Koha-bugs] [Bug 21330] Add xslt for authority normal view in OPAC
    In-Reply-To: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21330-70-gGn6tisjF6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330
    Bug 21330 depends on bug 11083, which changed state.
    
    Bug 11083 Summary: Authority search result display in staff interface should be XSLT driven
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 12:37:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 10:37:02 +0000
    Subject: [Koha-bugs] [Bug 29787] Add plugin version to plugin search results
    In-Reply-To: <bug-29787-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29787-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29787-70-nUVYwFjZGQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29787
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |Pushed to stable
             Version(s)|22.05.00                    |22.05.00,21.11.05
            released in|                            |
    
    --- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 12:38:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 10:38:53 +0000
    Subject: [Koha-bugs] [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and
     staff interface
    In-Reply-To: <bug-30011-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30011-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30011-70-DundZKgoyw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
             Resolution|---                         |FIXED
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 12:38:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 10:38:53 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-zFhBgqykSn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    Bug 29155 depends on bug 30011, which changed state.
    
    Bug 30011 Summary: Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 12:38:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 10:38:53 +0000
    Subject: [Koha-bugs] [Bug 30509] Accordion on letter.tt is broken
    In-Reply-To: <bug-30509-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30509-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30509-70-tqClItVoQQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30509
    Bug 30509 depends on bug 30011, which changed state.
    
    Bug 30011 Summary: Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 12:38:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 10:38:53 +0000
    Subject: [Koha-bugs] [Bug 30514] Error in date format check following
     datepicker removal
    In-Reply-To: <bug-30514-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30514-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30514-70-GStjDSKbsU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30514
    Bug 30514 depends on bug 30011, which changed state.
    
    Bug 30011 Summary: Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 12:39:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 10:39:24 +0000
    Subject: [Koha-bugs] [Bug 30120] Allow extended attributes during self
     registration when using PatronSelfRegistrationVerifyByEmail
    In-Reply-To: <bug-30120-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30120-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30120-70-sTS6NjvJct@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30120
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 12:49:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 10:49:04 +0000
    Subject: [Koha-bugs] [Bug 27212] Add column configuration to the
     acquisitions home page
    In-Reply-To: <bug-27212-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27212-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27212-70-7BQPtuqH8j@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:06:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:06:33 +0000
    Subject: [Koha-bugs] [Bug 29609] Links to guess the biblio default view need
     to be centralized
    In-Reply-To: <bug-29609-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29609-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29609-70-UikLLwqT6E@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29609
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:06:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:06:33 +0000
    Subject: [Koha-bugs] [Bug 30512] Staff interface search results template
     error
    In-Reply-To: <bug-30512-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30512-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30512-70-h8XKkQknDE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512
    Bug 30512 depends on bug 29609, which changed state.
    
    Bug 29609 Summary: Links to guess the biblio default view need to be centralized
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29609
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:06:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:06:55 +0000
    Subject: [Koha-bugs] [Bug 22827] Automatic item modifications by age: add
     age depencency on other field(s) than dateaccessioned
    In-Reply-To: <bug-22827-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22827-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22827-70-s6AIPxBHy1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:07:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:07:15 +0000
    Subject: [Koha-bugs] [Bug 21225] Add Syndetics cover images to staff client
    In-Reply-To: <bug-21225-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21225-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21225-70-yEp93nPnQv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:07:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:07:40 +0000
    Subject: [Koha-bugs] [Bug 30076] Add ability to check patron messaging
     preferences from a notice
    In-Reply-To: <bug-30076-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30076-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30076-70-PvU3ubNmx7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30076
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:08:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:08:49 +0000
    Subject: [Koha-bugs] [Bug 29059] Keep non-repeatable attribute from patron
     to preserve
    In-Reply-To: <bug-29059-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29059-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29059-70-2xgedICH9H@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29059
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:09:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:09:08 +0000
    Subject: [Koha-bugs] [Bug 20517] Use the "sort bin" field in SIP2 Checkin
     Response
    In-Reply-To: <bug-20517-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20517-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20517-70-lpSXlHpTh6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:09:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:09:46 +0000
    Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search
     result highlighting in the staff interface
    In-Reply-To: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20398-70-EJArQCoFi7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                 Status|Pushed to master            |RESOLVED
                     CC|                            |kyle at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:10:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:10:18 +0000
    Subject: [Koha-bugs] [Bug 29821] Add interface for generating barcodes using
     svc/barcode
    In-Reply-To: <bug-29821-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29821-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29821-70-BTMSIhthKZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29821
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
             Resolution|---                         |FIXED
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:10:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:10:37 +0000
    Subject: [Koha-bugs] [Bug 29990] Show authority heading use in search results
    In-Reply-To: <bug-29990-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29990-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29990-70-Z3XUKvtYvx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29990
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:10:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:10:38 +0000
    Subject: [Koha-bugs] [Bug 30501] sysprefs.sql has an error
    In-Reply-To: <bug-30501-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30501-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30501-70-FtokhXLB1B@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30501
    Bug 30501 depends on bug 29990, which changed state.
    
    Bug 29990 Summary: Show authority heading use in search results
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29990
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:10:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:10:59 +0000
    Subject: [Koha-bugs] [Bug 30243] When OPACSuggestionMandatoryFields includes
     branchcode the dropdown should default to an empty value
    In-Reply-To: <bug-30243-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30243-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30243-70-U8VIrMgeYw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30243
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:13:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:13:04 +0000
    Subject: [Koha-bugs] [Bug 30118] holds_block_checkin behavior is different
     in Koha and in SIP
    In-Reply-To: <bug-30118-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30118-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30118-70-ptZMq3v3b8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30118
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|22.05.00                    |22.05.00,21.11.05
            released in|                            |
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |Pushed to stable
    
    --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:13:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:13:19 +0000
    Subject: [Koha-bugs] [Bug 14393] Add collection code filter to inventory
    In-Reply-To: <bug-14393-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14393-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14393-70-SgVeukny53@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:13:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:13:56 +0000
    Subject: [Koha-bugs] [Bug 30501] sysprefs.sql has an error
    In-Reply-To: <bug-30501-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30501-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30501-70-uybzUHTGCn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30501
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
                     CC|                            |kyle at bywatersolutions.com
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:14:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:14:25 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: <bug-29810-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29810-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29810-70-xOI3ihMSbz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
             Resolution|---                         |FIXED
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:14:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:14:26 +0000
    Subject: [Koha-bugs] [Bug 30385] Standardize our swagger yaml spec files
    In-Reply-To: <bug-30385-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30385-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30385-70-UStVRKaWVi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30385
    Bug 30385 depends on bug 29810, which changed state.
    
    Bug 29810 Summary: Add embed options documentation
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:14:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:14:26 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-OOQP51PfXo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    Bug 30536 depends on bug 29810, which changed state.
    
    Bug 29810 Summary: Add embed options documentation
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:14:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:14:27 +0000
    Subject: [Koha-bugs] [Bug 30542] Use x-koha-embed parameter definition
    In-Reply-To: <bug-30542-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30542-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30542-70-KdNXcOZeTQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30542
    Bug 30542 depends on bug 29810, which changed state.
    
    Bug 29810 Summary: Add embed options documentation
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:14:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:14:48 +0000
    Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions
    In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29695-70-LgwF4a8Nfs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                 Status|Pushed to master            |RESOLVED
                     CC|                            |kyle at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:16:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:16:17 +0000
    Subject: [Koha-bugs] [Bug 29957] Cookies not removed after logout
    In-Reply-To: <bug-29957-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29957-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29957-70-RwQBgDBiIB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29957
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |Pushed to stable
                     CC|                            |kyle at bywatersolutions.com
             Version(s)|22.05.00                    |22.05.00,21.11.05
            released in|                            |
    
    --- Comment #125 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:18:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:18:38 +0000
    Subject: [Koha-bugs] [Bug 30378] Convert about page tabs to Bootstrap
    In-Reply-To: <bug-30378-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30378-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30378-70-S1j8DDUlXq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30378
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
                     CC|                            |kyle at bywatersolutions.com
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:18:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:18:38 +0000
    Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
    In-Reply-To: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29226-70-CdpSKBR5GV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
    Bug 29226 depends on bug 30378, which changed state.
    
    Bug 30378 Summary: Convert about page tabs to Bootstrap
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30378
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:18:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:18:50 +0000
    Subject: [Koha-bugs] [Bug 30396] Convert basket groups page tabs to Bootstrap
    In-Reply-To: <bug-30396-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30396-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30396-70-Kfy8zEOibh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30396
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:18:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:18:50 +0000
    Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
    In-Reply-To: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29226-70-l95gUjBwDQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
    Bug 29226 depends on bug 30396, which changed state.
    
    Bug 30396 Summary: Convert basket groups page tabs to Bootstrap
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30396
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:19:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:19:03 +0000
    Subject: [Koha-bugs] [Bug 30398] Reindent invoices template
    In-Reply-To: <bug-30398-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30398-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30398-70-umSfeSsVPE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
             Resolution|---                         |FIXED
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:19:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:19:03 +0000
    Subject: [Koha-bugs] [Bug 30400] Convert invoices page tabs to Bootstrap
    In-Reply-To: <bug-30400-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30400-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30400-70-oTjB9lRRxx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30400
    Bug 30400 depends on bug 30398, which changed state.
    
    Bug 30398 Summary: Reindent invoices template
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:19:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:19:22 +0000
    Subject: [Koha-bugs] [Bug 30400] Convert invoices page tabs to Bootstrap
    In-Reply-To: <bug-30400-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30400-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30400-70-YI3tRTb2rX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30400
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
                     CC|                            |kyle at bywatersolutions.com
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:19:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:19:23 +0000
    Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
    In-Reply-To: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29226-70-TZFxFADam7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
    Bug 29226 depends on bug 30400, which changed state.
    
    Bug 30400 Summary: Convert invoices page tabs to Bootstrap
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30400
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:19:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:19:34 +0000
    Subject: [Koha-bugs] [Bug 30401] Convert budgets administration page tabs to
     Bootstrap
    In-Reply-To: <bug-30401-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30401-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30401-70-04OIB9Q1fv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30401
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
                     CC|                            |kyle at bywatersolutions.com
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:19:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:19:34 +0000
    Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
    In-Reply-To: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29226-70-Ym8uBiQhqg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
    Bug 29226 depends on bug 30401, which changed state.
    
    Bug 30401 Summary: Convert budgets administration page tabs to Bootstrap
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30401
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:19:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:19:46 +0000
    Subject: [Koha-bugs] [Bug 30419] Convert authority detail page tabs to
     Bootstrap
    In-Reply-To: <bug-30419-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30419-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30419-70-P3woBlIJer@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30419
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                 Status|Pushed to master            |RESOLVED
                     CC|                            |kyle at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:19:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:19:47 +0000
    Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
    In-Reply-To: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29226-70-FViA28x5Ah@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
    Bug 29226 depends on bug 30419, which changed state.
    
    Bug 30419 Summary: Convert authority detail page tabs to Bootstrap
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30419
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:19:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:19:47 +0000
    Subject: [Koha-bugs] [Bug 30422] Authorities editor update broke the feature
     added by Bug 20154
    In-Reply-To: <bug-30422-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30422-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30422-70-p7cG2Q1LnJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30422
    Bug 30422 depends on bug 30419, which changed state.
    
    Bug 30419 Summary: Convert authority detail page tabs to Bootstrap
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30419
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:20:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:20:04 +0000
    Subject: [Koha-bugs] [Bug 30423] Convert authority merge page tabs to
     Bootstrap
    In-Reply-To: <bug-30423-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30423-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30423-70-96zYXeWi7W@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30423
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:20:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:20:04 +0000
    Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
    In-Reply-To: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29226-70-wHrpBV0SnW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
    Bug 29226 depends on bug 30423, which changed state.
    
    Bug 30423 Summary: Convert authority merge page tabs to Bootstrap
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30423
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:20:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:20:20 +0000
    Subject: [Koha-bugs] [Bug 30456] Convert checkout history tabs to Bootstrap
    In-Reply-To: <bug-30456-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30456-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30456-70-gyYkszN2NE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30456
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
                     CC|                            |kyle at bywatersolutions.com
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:20:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:20:20 +0000
    Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
    In-Reply-To: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29226-70-LpzezfDwbz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
    Bug 29226 depends on bug 30456, which changed state.
    
    Bug 30456 Summary: Convert checkout history tabs to Bootstrap
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30456
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:21:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:21:49 +0000
    Subject: [Koha-bugs] [Bug 30432] get_items_that_can_fill needs to specify
     table for biblionumbers
    In-Reply-To: <bug-30432-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30432-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30432-70-wAzQ1Gpyl3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |Pushed to stable
             Version(s)|22.05.00                    |22.05.00,21.11.05
            released in|                            |
    
    --- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:22:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:22:18 +0000
    Subject: [Koha-bugs] [Bug 30417] Switch to Bootstrap tabs on the basic
     library transfer limit page
    In-Reply-To: <bug-30417-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30417-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30417-70-grtoug8o48@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30417
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:22:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:22:19 +0000
    Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
    In-Reply-To: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29226-70-eTHkKwmzYh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
    Bug 29226 depends on bug 30417, which changed state.
    
    Bug 30417 Summary: Switch to Bootstrap tabs on the basic library transfer limit page
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30417
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:22:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:22:32 +0000
    Subject: [Koha-bugs] [Bug 26244] Move translatable strings out of
     memberentrygen.tt and into JavaScript
    In-Reply-To: <bug-26244-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26244-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26244-70-CL6trn2ALM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26244
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:22:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:22:48 +0000
    Subject: [Koha-bugs] [Bug 27035] Shows the number of results in a facets
     after facet selection
    In-Reply-To: <bug-27035-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27035-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27035-70-wVSjtEmHIK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:23:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:23:05 +0000
    Subject: [Koha-bugs] [Bug 22347] Translatability of ILSDI results for
     getavaibility
    In-Reply-To: <bug-22347-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22347-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22347-70-8Xb0PdvBHb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22347
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:23:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:23:23 +0000
    Subject: [Koha-bugs] [Bug 17018] Split AdvancedSearchTypes for staff and OPAC
    In-Reply-To: <bug-17018-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17018-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17018-70-xwYfZPFMjZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:23:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:23:50 +0000
    Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
     by library staff only
    In-Reply-To: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26346-70-QDUZFXNMSE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
             Resolution|---                         |FIXED
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:23:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:23:51 +0000
    Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists
     to allow staff with permission to edit contents
    In-Reply-To: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30418-70-dPBZFfGkXw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418
    Bug 30418 depends on bug 26346, which changed state.
    
    Bug 26346 Summary: Add option to make a public list editable by library staff only
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:24:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:24:44 +0000
    Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use
     Font Awesome icons
    In-Reply-To: <bug-29066-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29066-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29066-70-A0sBDVrkbg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:25:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:25:54 +0000
    Subject: [Koha-bugs] [Bug 26019] Koha should set SameSite attribute on
     cookies
    In-Reply-To: <bug-26019-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26019-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26019-70-uAmUIEsqN6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26019
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:36:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:36:02 +0000
    Subject: [Koha-bugs] [Bug 30426] suggestion service missing Auth and Output
     imports
    In-Reply-To: <bug-30426-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30426-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30426-70-SGHa3Sjk8c@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30426
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |Pushed to stable
             Version(s)|22.05.00                    |22.05.00,21.11.05
            released in|                            |
                     CC|                            |kyle at bywatersolutions.com
    
    --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:36:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:36:55 +0000
    Subject: [Koha-bugs] [Bug 30406] Our DT tables not filtering on the correct
     column if hidden by default
    In-Reply-To: <bug-30406-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30406-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30406-70-KqMYTKL7Qj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30406
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|22.05.00                    |22.05.00,21.11.05
            released in|                            |
                 Status|Pushed to master            |Pushed to stable
                     CC|                            |kyle at bywatersolutions.com
    
    --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:37:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:37:11 +0000
    Subject: [Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off
    In-Reply-To: <bug-16258-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-16258-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-16258-70-Vol2D59NaV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:38:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:38:10 +0000
    Subject: [Koha-bugs] [Bug 30130] Allow setting EDI type at the vendor level
    In-Reply-To: <bug-30130-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30130-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30130-70-lAyzZd85HE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:38:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:38:36 +0000
    Subject: [Koha-bugs] [Bug 30135] We should allow configuration of whether
     EDI LSQ segments map to 'location' or 'collection'
    In-Reply-To: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30135-70-0LalN4m9h8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:39:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:39:11 +0000
    Subject: [Koha-bugs] [Bug 30476] Remove NORMARC translation files
    In-Reply-To: <bug-30476-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30476-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30476-70-T2c0qtip1r@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30476
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
                     CC|                            |kyle at bywatersolutions.com
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:40:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:40:04 +0000
    Subject: [Koha-bugs] [Bug 30485] Searching all patrons from the header does
     not display the patron search view
    In-Reply-To: <bug-30485-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30485-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30485-70-lcVViJ9O2D@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30485
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                 Status|Pushed to master            |RESOLVED
                     CC|                            |kyle at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 13:40:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 11:40:43 +0000
    Subject: [Koha-bugs] [Bug 30142] ElasticSearch MARC mappings should not
     accept whitespaces
    In-Reply-To: <bug-30142-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30142-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30142-70-fPN6LolqJH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30142
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |Pushed to stable
             Version(s)|22.05.00                    |22.05.00,21.11.05
            released in|                            |
    
    --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 14:03:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 12:03:20 +0000
    Subject: [Koha-bugs] [Bug 30376] Unable to save item if field date acquired
     is set mandatory
    In-Reply-To: <bug-30376-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30376-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30376-70-s5D6ck96lK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30376
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
             Resolution|---                         |FIXED
                 Status|Pushed to master            |RESOLVED
    
    --- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Unable to replicate bug in 21.11.x. If I am mistaken please let me know!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 14:07:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 12:07:05 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-I8k6f8dxTj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 14:07:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 12:07:10 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-D7FOGhsXBJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    
    --- Comment #14 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133356
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133356&action=edit
    Bug 29155: (follow-up) Work around change to jQueryUI tab API
    
    For some reason, with the combination of jQuery 3.6.0 and jQueryUI
    1.13.1, the way to access the current active tab's link has changed.
    Previously the tab activate event would provide information about the
    link as "ui.newTab.context." It appears that "context" is no longer
    available.
    
    This patch updates the two instances in Koha where this process is
    broken.
    
    To test, apply the patch and check out to a patron with holds on their
    account.
    
    - When the checkout page loads, confirm that each tab loads its contents
      correctly when clicked.
    - Check that the correct tab is activated when you append the tab link
      to the page url, e.g.
    
      /cgi-bin/koha/circ/circulation.pl?borrowernumber=XXX#reldebarments
    
      ...which should select the "Restrictions" tab for you. You may need to
      try this in a new tab or shift-reload to get the browser to look for
      the hash.
    
    - Perform the same tests on the patron details page.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 14:08:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 12:08:39 +0000
    Subject: [Koha-bugs] [Bug 30481] Drop unique constraint
     deleteditemsstocknumberidx for deleteditems
    In-Reply-To: <bug-30481-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30481-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30481-70-n8ut1phYw6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30481
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |Pushed to stable
             Version(s)|22.05.00                    |22.05.00,21.11.05
            released in|                            |
                     CC|                            |kyle at bywatersolutions.com
    
    --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 14:14:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 12:14:50 +0000
    Subject: [Koha-bugs] [Bug 30498] Enum search_field.type should contain year
     in kohastructure
    In-Reply-To: <bug-30498-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30498-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30498-70-xCiVPD1Q8Q@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30498
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |Pushed to stable
             Version(s)|22.05.00                    |22.05.00,21.11.05
            released in|                            |
                     CC|                            |kyle at bywatersolutions.com
    
    --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 14:19:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 12:19:20 +0000
    Subject: [Koha-bugs] [Bug 29946] Sort profiles alphabetically when staging
     MARC records for import
    In-Reply-To: <bug-29946-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29946-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29946-70-gJ3clUJEUc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29946
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 14:21:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 12:21:53 +0000
    Subject: [Koha-bugs] [Bug 24865] Customize the Accountlines Description
    In-Reply-To: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24865-70-efSOUT0qGD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Signed Off
    
    --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
    1 - The idea though is adding the ability to customize which fields are being
    concatenated there, to allow librarians to add their own values in an
    understandable format. Additionally, we are now adding the ability to add
    translation here by getting patron language. I think it is worth the cost for
    new functionality
    
    2 - The code addresses the creation of new overdue accountlines - the code is
    hit whenever a new overdue amount is generated. The note about deleted refers
    to the fact the info like 'Barcode' is calculated on display from information
    in the accountlines - when an item is deleted that link is broken and that info
    is not displayed. If [% item.barcode %] is added to the description it will be
    retained after deletion
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 14:29:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 12:29:41 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-3XhkviZn1w@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 14:29:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 12:29:42 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27344-70-l1Us7U0rWK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    Bug 27344 depends on bug 27783, which changed state.
    
    Bug 27783 Summary: Introduce background job queues
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 14:29:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 12:29:42 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-KBdyCbQujr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    Bug 29346 depends on bug 27783, which changed state.
    
    Bug 27783 Summary: Introduce background job queues
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 14:29:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 12:29:43 +0000
    Subject: [Koha-bugs] [Bug 30410] Add a way for plugins to register
     background tasks
    In-Reply-To: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30410-70-g6TEHqeT8n@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410
    Bug 30410 depends on bug 27783, which changed state.
    
    Bug 27783 Summary: Introduce background job queues
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 14:30:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 12:30:54 +0000
    Subject: [Koha-bugs] [Bug 30492] Tabs break in opac-detail.pl if item has an
     image but not enough labels
    In-Reply-To: <bug-30492-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30492-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30492-70-LMfNiJTEax@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30492
    
    --- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
    Do you have some custom CSS or JavaScript in place to change the layout of this
    page? Normally the image is displayed on the left.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 14:31:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 12:31:04 +0000
    Subject: [Koha-bugs] [Bug 30410] Add a way for plugins to register
     background tasks
    In-Reply-To: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30410-70-jGlBxfuGn1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 14:31:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 12:31:52 +0000
    Subject: [Koha-bugs] [Bug 30356] Author facets for names with single quotes
     (') don't work
    In-Reply-To: <bug-30356-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30356-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30356-70-2Ewxsw2eU0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30356
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
              Component|OPAC                        |Searching - Zebra
               Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                       |                            |ity.org
             QA Contact|testopia at bugs.koha-communit |
                       |y.org                       |
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 14:31:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 12:31:56 +0000
    Subject: [Koha-bugs] [Bug 18392] Allow exporting circulation conditions as
     CSV or spreadsheet
    In-Reply-To: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18392-70-pPZbVa6qbv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Allow importing/exporting   |Allow exporting circulation
                       |circulation conditions as   |conditions as CSV or
                       |CSV or spreadsheet          |spreadsheet
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 14:33:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 12:33:12 +0000
    Subject: [Koha-bugs] [Bug 30552] New: Add a way to import circulation rules
    Message-ID: <bug-30552-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30552
    
                Bug ID: 30552
               Summary: Add a way to import circulation rules
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Circulation
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: nick at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
    
    bug 18392 added a method for exporting the circ table, however, that bug
    originally requested both import/export - opening this to allow import to be
    explored in the future
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 14:33:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 12:33:21 +0000
    Subject: [Koha-bugs] [Bug 18392] Allow exporting circulation conditions as
     CSV or spreadsheet
    In-Reply-To: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18392-70-d4eMTlYgya@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30552
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 14:33:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 12:33:21 +0000
    Subject: [Koha-bugs] [Bug 30552] Add a way to import circulation rules
    In-Reply-To: <bug-30552-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30552-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30552-70-A20NDbTzlE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30552
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=18392
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 15:44:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 13:44:15 +0000
    Subject: [Koha-bugs] [Bug 30541] Resolve return claim works but "hangs" if
     MarkLostItemsAsReturned is set for return claims
    In-Reply-To: <bug-30541-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30541-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30541-70-B1lNOVmXIp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
                     CC|                            |andrew at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 15:44:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 13:44:47 +0000
    Subject: [Koha-bugs] [Bug 30541] Resolve return claim works but "hangs" if
     MarkLostItemsAsReturned is set for return claims
    In-Reply-To: <bug-30541-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30541-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30541-70-fZBJN0AvsG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133301|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Created attachment 133357
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133357&action=edit
    Bug 30541 - Resolve return claim works but "hangs" if MarkLostItemsAsReturned
    is set for return claims
    
    Basically, if MarkLostItemsAsReturned is set for return claims, the code will
    crash while trying to pull the checkout so it can update the lost status of the
    item. This is because the code assumes there must be a checkout and never
    checks the old_checkouts table.
    
    This bug appears to only exist in 21.05 at this time. It was fixed by a
    combination of bugs 29495 and 28588.
    
    Test Plan:
    1) Set MarkLostItemsAsReturned for return claims
    2) Mark a checkout as claims returned
    3) Verify the checkout is no longer on the patron record
    4) Resolve the claim
    5) Note the attempt "hangs" but refreshing the page shows it worked
    6) Apply this patch, restart all the things!
    7) Repeat steps 2-4
    8) It works!
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 16:01:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 14:01:27 +0000
    Subject: [Koha-bugs] [Bug 30438] Add select all/clear buttons to invoices.tt
     open and closed tables
    In-Reply-To: <bug-30438-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30438-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30438-70-fuOtf9ke6I@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30438
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Patch doesn't apply         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 16:01:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 14:01:32 +0000
    Subject: [Koha-bugs] [Bug 30438] Add select all/clear buttons to invoices.tt
     open and closed tables
    In-Reply-To: <bug-30438-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30438-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30438-70-H6QmsMjHi0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30438
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132922|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> ---
    Created attachment 133358
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133358&action=edit
    Bug 30438: Add select all/clear all buttons to invoices.tt
    
    To test:
    1. Apply patch
    2. Have a bunch of invoices, some open and some closed.
    3. Go to Home > Acquisitions > Invoices and do a search that will return you
    many of those invoices, some open and some closed.
    4. Notice the 'Select all' and 'Clear all' buttons.
    5. Try clicking 'Select all' on the Open invoices tab. All Open invoices should
    become checked.
    6. Try clicking 'Clear all' on the Open invoices tab. All open invoices should
    become unchecked.
    7. Try 5 - 6 again but on the Closed invoices tab.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 16:01:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 14:01:59 +0000
    Subject: [Koha-bugs] [Bug 30438] Add select all/clear buttons to invoices.tt
     open and closed tables
    In-Reply-To: <bug-30438-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30438-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30438-70-FjEhV0pMh5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30438
    
    --- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
    rebased for current master, setting back to NSO
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 16:20:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 14:20:26 +0000
    Subject: [Koha-bugs] [Bug 30032] Can't reserve from local holds group from
     OPAC
    In-Reply-To: <bug-30032-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30032-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30032-70-zDMbf9WUGT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30032
    
    Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |RESOLVED
             Resolution|---                         |WORKSFORME
    
    --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
    Must-ve been a glitch on my part. I can't recreate, now, and my colleague
    either, so... *shrugs*
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 16:34:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 14:34:31 +0000
    Subject: [Koha-bugs] [Bug 30553] New: Add a count to borrower Files tab in
     patroninfo
    Message-ID: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30553
    
                Bug ID: 30553
               Summary: Add a count to borrower Files tab in patroninfo
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: enhancement
              Priority: P5 - low
             Component: Patrons
              Assignee: lucas at bywatersolutions.com
              Reporter: lucas at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
    
    If you have the sys pref EnableBorrowerFiles turned on you will see a tab for
    'Files' on the patroninfo navigation bar. Some librarians would find it useful
    to have count on that tab so they can see how many files a borrower has. 
    
    i.e.: Files(2)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 17:21:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 15:21:50 +0000
    Subject: [Koha-bugs] [Bug 30492] Tabs break in opac-detail.pl if item has an
     image but not enough labels
    In-Reply-To: <bug-30492-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30492-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30492-70-V1nKLRFkB7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30492
    
    Florian <florian.bontemps at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |RESOLVED
             Resolution|---                         |INVALID
    
    --- Comment #3 from Florian <florian.bontemps at biblibre.com> ---
    Interesting, you're right, I've stumbled upon this bug on two different version
    but I guess they both had this modification.
    
    If anyone's interested, I fixed the problem by putting this in OpacUserCSS:
    #bibliodescriptions{
      display:flex;
      width:100%;
      flex-direction: column;
    }
    
    Otherwise, i'll close that bug.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 17:31:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 15:31:55 +0000
    Subject: [Koha-bugs] [Bug 30554] New: Wrong display of authorities records
     in the Authority search plugin
    Message-ID: <bug-30554-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30554
    
                Bug ID: 30554
               Summary: Wrong display of authorities records in the Authority
                        search plugin
     Change sponsored?: ---
               Product: Koha
               Version: 20.11
              Hardware: All
                    OS: All
                Status: NEW
              Severity: minor
              Priority: P5 - low
             Component: Cataloging
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: jeremy.breuillard at biblibre.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: m.de.rooy at rijksmuseum.nl
    
    Once the search is done with this plugin some of the authorities are wrong
    displayed because parts and links are missing. It is not the case if the search
    is made via authority mobile
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 17:32:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 15:32:37 +0000
    Subject: [Koha-bugs] [Bug 30554] Wrong display of authorities records in the
     Authority search plugin
    In-Reply-To: <bug-30554-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30554-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30554-70-G3Ek1DbbnN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30554
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |jeremy.breuillard at biblibre.
                       |                            |com
               Assignee|koha-bugs at lists.koha-commun |jeremy.breuillard at biblibre.
                       |ity.org                     |com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 17:34:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 15:34:03 +0000
    Subject: [Koha-bugs] [Bug 30554] Wrong display of authorities records in the
     Authority search plugin
    In-Reply-To: <bug-30554-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30554-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30554-70-LxG2aZU9xb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30554
    
    --- Comment #1 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> ---
    Created attachment 133359
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133359&action=edit
    MT 36361: Wrong display of authorities records in the Authority search plugin
    
    With this patch the display of the authorities records is available at XSLT
    format
    
    Test plan:
    1)Make sure to have at least one Authority Type defined
    2)Home > Cataloging > New record > tab.7 Field 700$a
    3)Click on the Tag editor button
    4)Click on Search button and notice the displaying of the results
    5)Apply patch and repeat 3) and 4)
    6)The results are now displayed at XSLT format
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 17:34:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 15:34:20 +0000
    Subject: [Koha-bugs] [Bug 30554] Wrong display of authorities records in the
     Authority search plugin
    In-Reply-To: <bug-30554-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30554-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30554-70-ORAKWdzVJk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30554
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 17:35:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 15:35:13 +0000
    Subject: [Koha-bugs] [Bug 30554] Wrong display of authorities records in the
     Authority search plugin
    In-Reply-To: <bug-30554-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30554-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30554-70-1xqMTp85f9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30554
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133359|MT 36361: Wrong display of  |Bug 30554: Wrong display of
            description|authorities records in the  |authorities records in the
                       |Authority search plugin     |Authority search plugin
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 17:42:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 15:42:09 +0000
    Subject: [Koha-bugs] [Bug 30555] New: Add more sample notice for sms messages
    Message-ID: <bug-30555-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30555
    
                Bug ID: 30555
               Summary: Add more sample notice for sms messages
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Notices
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: shi-yao.wang at inLibro.com
            QA Contact: testopia at bugs.koha-community.org
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 17:45:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 15:45:08 +0000
    Subject: [Koha-bugs] [Bug 30555] Add more sample notice for sms messages
    In-Reply-To: <bug-30555-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30555-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30555-70-bqSj78SoZA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30555
    
    --- Comment #1 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
    Created attachment 133360
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133360&action=edit
    Bug 30555 : Add more sample notice for sms messages
    
    It would be nice if we had sms sample notice for due, hold, checkin and
    checkout
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 17:45:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 15:45:33 +0000
    Subject: [Koha-bugs] [Bug 30555] Add more sample notice for sms messages
    In-Reply-To: <bug-30555-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30555-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30555-70-UaBwseFhri@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30555
    
    Shi Yao Wang <shi-yao.wang at inLibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |shi-yao.wang at inLibro.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 18:30:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 16:30:31 +0000
    Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
     for use as filters when searching the catalog
    In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17170-70-kloeMABrOu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Failed QA
    
    --- Comment #9 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    A user with manage_search_filters permission can create filters from the search
    results page and can open admin-home.pl, but does not get a link to the search
    filters page. A superlibrarian does get the intended link.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 18:39:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 16:39:38 +0000
    Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
     for use as filters when searching the catalog
    In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17170-70-hwpjztLUnm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 18:39:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 16:39:42 +0000
    Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
     for use as filters when searching the catalog
    In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17170-70-65w49dfzpe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170
    
    --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133361
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133361&action=edit
    Bug 17170: (follow-up) Display search filters admin links when apprropriate
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 18:48:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 16:48:53 +0000
    Subject: [Koha-bugs] [Bug 28943] Lower the risk of accidental patron
     deletion by cleanup_database.pl
    In-Reply-To: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28943-70-GuXysQIXnU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28943
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to stable            |Pushed to oldstable
             Version(s)|22.05.00,21.11.03           |22.05.00,21.11.03,21.05.14
            released in|                            |
    
    --- Comment #25 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Pushed to 21.05.x for 21.05.14
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 18:49:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 16:49:51 +0000
    Subject: [Koha-bugs] [Bug 30551] Cash register report shows wrong library
     when paying fees in two different libraries
    In-Reply-To: <bug-30551-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30551-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30551-70-dc8EUS45Pc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30551
    
    --- Comment #1 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
    Created attachment 133362
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133362&action=edit
    Bug 30551: Make cash register report take branchcode from cash register
    
    This patch makes it so cash register reports puts branchcode from the
    cash register where the payment was made into "Transaction library"
    column instead of taking the branchcode of the manager.
    
    Test plan:
    1- Use cash registers (administration > system preferences > UseCashRegisters)
    2- Create another library if you only have one (administration > libraries >
    new library)
    3- Create a cash register in each library if they don't already have one
    (administration > cash registers > new cash register)
    4- Create a fee on your own account and pay it right after in both libraries.
    5- Go to reports > cash register and generate the statistics.
    6- Notice "transaction library" in both rows are the same even though the fees
    were paid in two different libraries and two different cash registers.
    7- Apply the patch and click submit to re-generate statistics
    8- Notice it now shows the correct library where the transactions were done
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 18:50:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 16:50:12 +0000
    Subject: [Koha-bugs] [Bug 30551] Cash register report shows wrong library
     when paying fees in two different libraries
    In-Reply-To: <bug-30551-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30551-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30551-70-3dCOeAcP4c@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30551
    
    Shi Yao Wang <shi-yao.wang at inLibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 18:51:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 16:51:47 +0000
    Subject: [Koha-bugs] [Bug 29875] Update text on MaxReserves system
     preference to describe functionality.
    In-Reply-To: <bug-29875-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29875-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29875-70-zcFJPEdzEq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|22.05.00,21.11.03           |22.05.00,21.11.03,21.05.14
            released in|                            |
                 Status|Pushed to stable            |Pushed to oldstable
    
    --- Comment #11 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Pushed to 21.05.x for 21.05.14
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 18:52:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 16:52:02 +0000
    Subject: [Koha-bugs] [Bug 22567] Stock rotation manage rotas should show
     items current and desired locations
    In-Reply-To: <bug-22567-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22567-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22567-70-3L6tzdY6Y3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22567
    
    --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133363
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133363&action=edit
    Tools -Stock Rotation -Manage Items
    
    The stages shwo where it is at in terms of rotation, but I cannot see where the
    item physically is
    
    I was thinking the 'In transit' column should show holding library and transfer
    date (in transit from A to B since 01-01-1900)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 18:57:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 16:57:37 +0000
    Subject: [Koha-bugs] [Bug 29482] Terminology: This item belongs to another
     branch.
    In-Reply-To: <bug-29482-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29482-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29482-70-zFXcNaV6s8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29482
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |andrew at bywatersolutions.com
             Version(s)|22.05.00,21.11.03           |22.05.00,21.11.03,21.05.14
            released in|                            |
                 Status|Pushed to stable            |Pushed to oldstable
    
    --- Comment #7 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Pushed to 21.05.x for 21.05.14
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 19:17:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 17:17:47 +0000
    Subject: [Koha-bugs] [Bug 29338] Reprinting holds slip with updated
     expiration date
    In-Reply-To: <bug-29338-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29338-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29338-70-Ke2oNChzx6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29338
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|22.05.00,21.11.04           |22.05.00,21.11.04,21.05.14
            released in|                            |
                     CC|                            |andrew at bywatersolutions.com
                 Status|Pushed to stable            |Pushed to oldstable
    
    --- Comment #12 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Pushed to 21.05.x for 21.05.14
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 19:50:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 17:50:28 +0000
    Subject: [Koha-bugs] [Bug 30035] Wrong month name in numbering pattern
    In-Reply-To: <bug-30035-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30035-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30035-70-qJ061lMVLR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30035
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|22.05.00,21.11.04           |22.05.00,21.11.04,21.05.14
            released in|                            |
                     CC|                            |andrew at bywatersolutions.com
                 Status|Pushed to stable            |Pushed to oldstable
    
    --- Comment #9 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Pushed to 21.05.x for 21.05.14
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 19:52:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 17:52:07 +0000
    Subject: [Koha-bugs] [Bug 29589] Translation issue with formatting in MARC
     overlay rules page
    In-Reply-To: <bug-29589-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29589-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29589-70-9wqahsJUMd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |andrew at bywatersolutions.com
             Resolution|---                         |FIXED
                 Status|Pushed to stable            |RESOLVED
    
    --- Comment #14 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Missing dependency, not backported to 21.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 19:57:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 17:57:46 +0000
    Subject: [Koha-bugs] [Bug 30220] Purchase suggestion defaults to first
     library
    In-Reply-To: <bug-30220-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30220-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30220-70-l2WTEaDSYa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30220
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |andrew at bywatersolutions.com
             Version(s)|22.05.00,21.11.05           |22.05.00,21.11.05,21.05.14
            released in|                            |
                 Status|Pushed to stable            |Pushed to oldstable
    
    --- Comment #10 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Pushed to 21.05.x for 21.05.14
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 20:04:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 18:04:02 +0000
    Subject: [Koha-bugs] [Bug 30220] Purchase suggestion defaults to first
     library
    In-Reply-To: <bug-30220-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30220-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30220-70-F8q2gixOPa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30220
    
    --- Comment #11 from Christopher Brannon <cbrannon at cdalibrary.org> ---
    (In reply to Andrew Fuerste-Henry from comment #10)
    > Pushed to 21.05.x for 21.05.14
    
    Cool beans!  Thanks Andrew!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 20:09:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 18:09:19 +0000
    Subject: [Koha-bugs] [Bug 29020] Missing Background jobs link in admin-home
    In-Reply-To: <bug-29020-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29020-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29020-70-OPdpXc1iQX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29020
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|21.11.00                    |21.11.00,21.05.14
            released in|                            |
                 Status|Pushed to stable            |Pushed to oldstable
    
    --- Comment #26 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Pushed to 21.05.x for 21.05.14
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 20:15:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 18:15:15 +0000
    Subject: [Koha-bugs] [Bug 26328] incremental barcode generation fails when
     incorrectly converting strings to numbers
    In-Reply-To: <bug-26328-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26328-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26328-70-vA1nhdSB6B@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26328
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |andrew at bywatersolutions.com
             Version(s)|22.05.00,21.11.05           |22.05.00,21.11.05,21.05.14
            released in|                            |
                 Status|Pushed to stable            |Pushed to oldstable
    
    --- Comment #21 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Pushed to 21.05.x for 21.05.14
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 20:21:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 18:21:15 +0000
    Subject: [Koha-bugs] [Bug 30222] Auto_renew_digest still sends every day
     when renewals are not allowed
    In-Reply-To: <bug-30222-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30222-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30222-70-IKF45CuCxD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to stable            |Pushed to oldstable
             Version(s)|22.05.00,21.11.05           |22.05.00,21.11.05,21.05.14
            released in|                            |
    
    --- Comment #31 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Pushed to 21.05.x for 21.05.14
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 20:43:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 18:43:15 +0000
    Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
     for use as filters when searching the catalog
    In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17170-70-0g8wQFEEIy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Failed QA
    
    --- Comment #11 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Something off about how saved filters are getting parsed here. We're ANDing
    where we should OR.
    
    I created a filter limiting to item types Book (BK) and Music (MU).
    
    If I search for "Street" and then apply my filter, I get no results.
    'street'  with limit(s): '(itype:("BK")) AND (itype:("MU"))'
    
    If I clicked to edit my filter from the admin page and then search for "street"
    from that page, I get 4 results.
    'street'  with limit(s): 'itype:(("BK") OR ("MU"))'
    
    If I just construct an advanced search for "street" limited to book and music I
    get 4 results.
    '(street*)' with limit(s): 'itype:(("BK") OR ("MU"))'.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 22:10:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 20:10:16 +0000
    Subject: [Koha-bugs] [Bug 30556] New: OPAC shows "Place hold" button on
     available items even if on shelf holds aren't allowed
    Message-ID: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556
    
                Bug ID: 30556
               Summary: OPAC shows "Place hold" button on available items even
                        if on shelf holds aren't allowed
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Hold requests
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: caroline.cyr-la-rose at inlibro.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com
    
    When circulation rules don't allow on shelf holds, the "Place hold" button
    still appears on the OPAC next to available items.
    
    1. Create a circulation rule with on shelf holds set to "If all unavailable"
    2. Create or modify a record to match the items itype to the circulation rule
    3. Use a patron matching the circ rule category to log into the opac
    4. Look for the record
    
    The Place hold button should not appear, but currently, it does.
    
    I think this may be related to Bug 3142? I'm not sure...
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 23:20:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 21:20:49 +0000
    Subject: [Koha-bugs] [Bug 30517] Translation breaks editing parent type
     circulation rule
    In-Reply-To: <bug-30517-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30517-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30517-70-SES0xc4ge3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517
    
    --- Comment #2 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
    Created attachment 133364
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133364&action=edit
    Bug 30517: Translation breaks editing parent type circulation rule fix
    
    Test plan:
    1. Install another language in the staff interface
       1. ./translate install xx-XX
       2. Check the box of the language in the 'language' system preference
       3. Refresh
    2. Create an item type with a parent
       1. Go to Administration > Item types
       2. Create a new item type or modify an existing one, assigning a parent type
    (I created a 'Children's books' type and assigned 'Books' as its parent)
    3. Create a circulation rule for the parent type (I created All/Books, with 10
    checkouts allowed)
    4. Create a circulation rule for All/All (I created All/All with 30 checkouts
    allowed)
    5. In English, click on "Edit" next to the parent type rule (All/Books)
    --> Note that the item type in the bottom row (the modifiable row) is changed
    to 'Books (All)'
    6. Modify the number of checkouts allowed (e.g. 99)
    --> The All/Books rule is modified
    7. Switch the interface to the other language
    8. Click on "Edit" next to the parent type rule (All/Books)
    --> Note that the item type in the bottom row stays on 'All'
    9. Modify the number of checkouts allowed (e.g. 88)
    --> The All/All rule is modified
    10. Apply the patch and refresh
    11. Do step 8-9 again and notice it now behaves as it should
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 23:29:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 21:29:40 +0000
    Subject: [Koha-bugs] [Bug 30553] Add a count to borrower Files tab in
     patroninfo
    In-Reply-To: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30553-70-YOk4uZcILC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30553
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 23:29:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 21:29:43 +0000
    Subject: [Koha-bugs] [Bug 30553] Add a count to borrower Files tab in
     patroninfo
    In-Reply-To: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30553-70-0q8Tsc4qv0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30553
    
    --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
    Created attachment 133365
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133365&action=edit
    Bug 30553: Add file count to patron circ-menu
    
    To test:
    1. Apply patch
    2. Enable the system preference 'EnableBorrowerFiles'
    3. Go to a patron account and noticet the Files tab on left nav bar.
    4. It should read "Files (0)"
    5. Begin uploading some files to the borrower. The tab should reflect the
    number of files uploaded.
    6. Go to other pages on the borrower account ( Checkout, Details, etc. )
    7. The number of files should display from all borrower pages
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 23:30:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 21:30:15 +0000
    Subject: [Koha-bugs] [Bug 30553] Add a count to borrower Files tab in
     patroninfo
    In-Reply-To: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30553-70-dW436q6O0V@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30553
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 15 23:57:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 21:57:35 +0000
    Subject: [Koha-bugs] [Bug 30557] New: Add ability to create Item lists
    Message-ID: <bug-30557-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557
    
                Bug ID: 30557
               Summary: Add ability to create Item lists
     Change sponsored?: ---
               Product: Koha
               Version: 21.05
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Lists
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: estherm at sodaspringsid.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: m.de.rooy at rijksmuseum.nl
    
    This is relevant for multi-branch installations.
    
    Lists currently appear to be primarily bibliographic lists. This creates a
    problem when sorting lists by call number. In this scenario there may be
    multiple items from different libraries using different call number schema
    attached to a single bibliographic record. The list cannot be sorted accurately
    by call number.
    
    It would be helpful if there was an option for an item based list. In this
    scenario items are added to a list for a specific branch. The call number sort
    will then sort correctly because the call number schema will be consistent for
    the branch. An item list would display the same information as a bibliographic
    list with the exception of additional branches which may also have the item.
    
    A typical use case would a library creating an item list, sort by call number,
    and then use that list to go to the shelf to pull the items in order. This is
    currently not possible in a multi-branch installation without a bit of work. It
    would require downloading the list and then cleaning up the list to be useful
    for this kind of work. It may be possible to create a report that will do this,
    but it would be a nice added functionality in the List tool.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 16 00:13:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 22:13:32 +0000
    Subject: [Koha-bugs] [Bug 21330] Add XSLT for authority normal view in OPAC
    In-Reply-To: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21330-70-Ww6Lp2zHDh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Add xslt for authority      |Add XSLT for authority
                       |normal view in OPAC         |normal view in OPAC
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 16 00:14:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 22:14:25 +0000
    Subject: [Koha-bugs] [Bug 22490] Some strings in JavaScript files are
     untranslatable
    In-Reply-To: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22490-70-5Urxxs14go@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22490
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Some strings in javascript  |Some strings in JavaScript
                       |files are untranslatable    |files are untranslatable
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 16 00:22:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 15 Apr 2022 22:22:26 +0000
    Subject: [Koha-bugs] [Bug 28075] Add missing UNIMARC value for coded data
     135a
    In-Reply-To: <bug-28075-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28075-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28075-70-1mWgKPc37c@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28075
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Add missing UNIMARC for     |Add missing UNIMARC value
                       |coded data 135a             |for coded data 135a
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 16 09:47:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 16 Apr 2022 07:47:32 +0000
    Subject: [Koha-bugs] [Bug 30558] New: Ticket for git-bz utiliti testing
     (some bugs in git-bz? researching)
    Message-ID: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
                Bug ID: 30558
               Summary: Ticket for git-bz utiliti testing (some bugs in
                        git-bz? researching)
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: trivial
              Priority: P5 - low
             Component: bugs.koha-community.org
              Assignee: slavashishkin at gmail.com
              Reporter: slavashishkin at gmail.com
            QA Contact: testopia at bugs.koha-community.org
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 16 13:08:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 16 Apr 2022 11:08:19 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-4hlR1GoyvK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    Zeno Tajoli <ztajoli at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |ztajoli at gmail.com
    
    --- Comment #75 from Zeno Tajoli <ztajoli at gmail.com> ---
    Hi Victor, I'm sorry that there are still problem on check this patch.
    1)There are problems on try it on sandboxes, see
    https://sandbox.bywatersolutions.com/provision_log/nicetrad
    2)I try to check it 'manualy' but it needs rebase.
    Git log:
    koha at deb10:~/kohaclone$ git checkout -b qa_bug_29602
    Switched to a new branch 'qa_bug_29602'
    koha at deb10:~/kohaclone$ git am -3 -i -u /home/koha/b29602_1
    Commit Body is:
    --------------------------
    Bug 29602: Surround strings with span tag
    
    To be nicer with translators.
    
    Update the PO files for whichever languages will show how this is
    useful.
    
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    --------------------------
    Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all: y
    Applying: Bug 29602: Surround strings with span tag
    Using index info to reconstruct a base tree...
    M       koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
    M       koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
    M       koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt
    M       koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt
    M       koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt
    M       koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
    M       koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt
    M       koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
    Falling back to patching base and 3-way merge...
    Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
    Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt
    Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
    Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt
    Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt
    Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt
    CONFLICT (content): Merge conflict in
    koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt
    Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
    Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
    error: Failed to merge in the changes.
    Patch failed at 0001 Bug 29602: Surround strings with span tag
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 16 15:04:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 16 Apr 2022 13:04:48 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-OAE5MAdQyG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 16 15:18:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 16 Apr 2022 13:18:09 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-Yd51QmtyT6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    --- Comment #1 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133366
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133366&action=edit
    Test for git-bz attach
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 16 15:22:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 16 Apr 2022 13:22:22 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-dPZotlhYSG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133366|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133367
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133367&action=edit
    Test for git-bz attach
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 16 15:42:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 16 Apr 2022 13:42:21 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-yhBfZgBgJ5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133367|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133368
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133368&action=edit
    Test for git-bz attach
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 16 16:02:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 16 Apr 2022 14:02:10 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-vwjCBbsv7i@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133368|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133369
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133369&action=edit
    Bug 30558: Add some changes for test
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 16 19:00:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 16 Apr 2022 17:00:17 +0000
    Subject: [Koha-bugs] [Bug 12772] Add item type and on-hold status to overdue
     notice/status triggers tool
    In-Reply-To: <bug-12772-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-12772-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-12772-70-0rEx8qF063@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772
    
    Yuval Hager <yhager at yhager.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |yhager at yhager.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 17 11:03:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 17 Apr 2022 09:03:06 +0000
    Subject: [Koha-bugs] [Bug 3935] Schedule tasks periodically
    In-Reply-To: <bug-3935-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-3935-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-3935-70-wkLPmnl65V@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3935
    
    mathieu saby <mathsabypro at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |mathsabypro at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 17 21:00:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 17 Apr 2022 19:00:23 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-0HNQcKjwPN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133129|0                           |1
            is obsolete|                            |
    
    --- Comment #76 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Created attachment 133370
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133370&action=edit
    Bug 29602: Surround strings with span tag
    
    To be nicer with translators.
    
    Update the PO files for whichever languages will show how this is
    useful.
    
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    Rebased-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 17 21:00:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 17 Apr 2022 19:00:30 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-RBKy2YBcE1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133130|0                           |1
            is obsolete|                            |
    
    --- Comment #77 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Created attachment 133371
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133371&action=edit
    Bug 29602: (follow-up) Surround strings with span tag
    
    To be nicer with translators.
    
    Update the PO files for whichever languages will show how this is useful.
    
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    Rebased-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 17 21:00:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 17 Apr 2022 19:00:36 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-IiavPJHU6I@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133131|0                           |1
            is obsolete|                            |
    
    --- Comment #78 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Created attachment 133372
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133372&action=edit
    Bug 29602: (follow-up) Fix TT tags broken due to missing %
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 17 21:00:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 17 Apr 2022 19:00:42 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-IzuI4fvtGS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    --- Comment #79 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Created attachment 133373
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133373&action=edit
    Bug 29602: (follow-up) fix crash: SET KohaSpan => USE KohaSpan
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 17 21:00:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 17 Apr 2022 19:00:47 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-SeLTp2KaQ8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133133|0                           |1
            is obsolete|                            |
    
    --- Comment #80 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Created attachment 133374
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133374&action=edit
    Bug 29602: (follow-up) fix duplicate, missing or mismatching <span>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 17 21:01:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 17 Apr 2022 19:01:15 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-BRCuEMwMbF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133132|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 17 21:04:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 17 Apr 2022 19:04:06 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-zOVA1r98pp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    --- Comment #81 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Hi Zeno, this patch needs frequent rebases to fix conflicts because it touches
    stuff in a lot of places. Here is another rebase, thanks for testing :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 17 22:04:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 17 Apr 2022 20:04:38 +0000
    Subject: [Koha-bugs] [Bug 28943] Lower the risk of accidental patron
     deletion by cleanup_database.pl
    In-Reply-To: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28943-70-XCSmjbYDsq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28943
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|22.05.00,21.11.03,21.05.14  |22.05.00,21.11.03,21.05.14,
            released in|                            |20.11.18
                 Status|Pushed to oldstable         |Pushed to oldoldstable
                     CC|                            |victor at tuxayo.net
    
    --- Comment #26 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Backported: Pushed to 20.11.x branch for 20.11.18
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 17 22:06:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 17 Apr 2022 20:06:28 +0000
    Subject: [Koha-bugs] [Bug 29875] Update text on MaxReserves system
     preference to describe functionality.
    In-Reply-To: <bug-29875-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29875-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29875-70-eYYO1qW93n@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |victor at tuxayo.net
                 Status|Pushed to oldstable         |RESOLVED
             Resolution|---                         |FIXED
    
    --- Comment #12 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 17 22:07:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 17 Apr 2022 20:07:22 +0000
    Subject: [Koha-bugs] [Bug 29482] Terminology: This item belongs to another
     branch.
    In-Reply-To: <bug-29482-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29482-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29482-70-0asmGzjdry@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29482
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to oldstable         |RESOLVED
             Resolution|---                         |FIXED
                     CC|                            |victor at tuxayo.net
    
    --- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 17 22:08:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 17 Apr 2022 20:08:42 +0000
    Subject: [Koha-bugs] [Bug 29338] Reprinting holds slip with updated
     expiration date
    In-Reply-To: <bug-29338-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29338-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29338-70-g07lTc4aSQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29338
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                     CC|                            |victor at tuxayo.net
                 Status|Pushed to oldstable         |RESOLVED
    
    --- Comment #13 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 17 22:09:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 17 Apr 2022 20:09:03 +0000
    Subject: [Koha-bugs] [Bug 30035] Wrong month name in numbering pattern
    In-Reply-To: <bug-30035-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30035-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30035-70-NpJIn78ms9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30035
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |victor at tuxayo.net
             Resolution|---                         |FIXED
                 Status|Pushed to oldstable         |RESOLVED
    
    --- Comment #10 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 17 22:09:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 17 Apr 2022 20:09:23 +0000
    Subject: [Koha-bugs] [Bug 30220] Purchase suggestion defaults to first
     library
    In-Reply-To: <bug-30220-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30220-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30220-70-CXk11tuW4V@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30220
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to oldstable         |RESOLVED
                     CC|                            |victor at tuxayo.net
             Resolution|---                         |FIXED
    
    --- Comment #12 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 17 22:09:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 17 Apr 2022 20:09:46 +0000
    Subject: [Koha-bugs] [Bug 29020] Missing Background jobs link in admin-home
    In-Reply-To: <bug-29020-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29020-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29020-70-wQWJSyGKgY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29020
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                 Status|Pushed to oldstable         |RESOLVED
                     CC|                            |victor at tuxayo.net
    
    --- Comment #27 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 17 22:09:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 17 Apr 2022 20:09:47 +0000
    Subject: [Koha-bugs] [Bug 29178] Only users with manage_background_jobs can
     cancel a job
    In-Reply-To: <bug-29178-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29178-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29178-70-xqB6xtdo6N@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29178
    Bug 29178 depends on bug 29020, which changed state.
    
    Bug 29020 Summary: Missing Background jobs link in admin-home
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29020
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to oldstable         |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 17 22:20:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 17 Apr 2022 20:20:54 +0000
    Subject: [Koha-bugs] [Bug 26328] incremental barcode generation fails when
     incorrectly converting strings to numbers
    In-Reply-To: <bug-26328-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26328-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26328-70-knlS1w7ZxT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26328
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|22.05.00,21.11.05,21.05.14  |22.05.00,21.11.05,21.05.14,
            released in|                            |20.11.18
             Resolution|---                         |FIXED
                 Status|Pushed to oldstable         |RESOLVED
                     CC|                            |victor at tuxayo.net
    
    --- Comment #22 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Backported: Pushed to 20.11.x branch for 20.11.18
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 17 22:25:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 17 Apr 2022 20:25:25 +0000
    Subject: [Koha-bugs] [Bug 30222] Auto_renew_digest still sends every day
     when renewals are not allowed
    In-Reply-To: <bug-30222-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30222-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30222-70-tvGJxmI9Xh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                 Status|Pushed to oldstable         |RESOLVED
                     CC|                            |victor at tuxayo.net
    
    --- Comment #32 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Missing dependencies for 20.11.x, it shouldn't be affected, no backport.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 17 22:25:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 17 Apr 2022 20:25:26 +0000
    Subject: [Koha-bugs] [Bug 30278] Auto renewal should be moved to an object
     method
    In-Reply-To: <bug-30278-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30278-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30278-70-rpvZoFDrA4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30278
    Bug 30278 depends on bug 30222, which changed state.
    
    Bug 30222 Summary: Auto_renew_digest still sends every day when renewals are not allowed
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to oldstable         |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 18 02:40:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 18 Apr 2022 00:40:05 +0000
    Subject: [Koha-bugs] [Bug 30559] New: Batch Number Auto Increment Goes Awry
     -- Cannot Determine How
    Message-ID: <bug-30559-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30559
    
                Bug ID: 30559
               Summary: Batch Number Auto Increment Goes Awry -- Cannot
                        Determine How
     Change sponsored?: ---
               Product: Koha
               Version: 20.05
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Tools
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: cmkelleymls at gmail.com
            QA Contact: testopia at bugs.koha-community.org
    
    We have noticed that after last several batch loads, the auto increment for the
    next batch number increases by a seemingly random number.
    
    #       File name       Comments        Type    Status  Staged  # Records      
    # Items
    8911    Missing Translated Title 740 Fields.mrc Restoration of records lacking
    searchable title fields  Bibliographic   Imported        04/15/2022 20:08      
     371     0
    8543    Dahm -- Inter-Island Communications.mrc Short record with link -- TEST 
    Bibliographic   Imported        04/06/2022 22:06        1       0
    8409    SN 7036 -- Методика Строевой Быучки.mrc Corrections to added title,
    008, and 040 fields and to other fields as needed   Bibliographic   Imported   
        03/31/2022 21:38        1       0
    7998    Kim Il-Song Related Works.mrc   Corrections to added title, 008, and
    040 fields and to other fields as needed; correction to item fields as needed  
       Bibliographic   Imported        03/30/2022 01:03        3       14 (Create
    label batch)
    7471    Reznichenko -- Taktika.mrc      Restored missing work   Bibliographic  
    Imported        03/24/2022 20:08        1       0
    7422    SN 8507 -- Zhengce yanjiu yu juece zixun 2015-nian.mrc  Corrections to
    added title and 008 fields       Bibliographic   Imported        03/22/2022
    23:26        1       0
    
    We don't know what prompted this, but we would like to know whether or not this
    is worrisome. If it is worrisome, we would like to recommend it be fixed.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 18 13:51:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 18 Apr 2022 11:51:03 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-Mm9YWzG18X@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 18 14:20:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 18 Apr 2022 12:20:35 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-8ZYWwwUJr7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133369|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133375
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133375&action=edit
    Bug 30558: some commit
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 18 16:22:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 18 Apr 2022 14:22:25 +0000
    Subject: [Koha-bugs] [Bug 30172] Background jobs failing due to race
     condition
    In-Reply-To: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30172-70-ZrRWg2rQ1H@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |ASSIGNED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 18 16:22:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 18 Apr 2022 14:22:36 +0000
    Subject: [Koha-bugs] [Bug 30172] Background jobs failing due to race
     condition
    In-Reply-To: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30172-70-BlsFUd2KJc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 18 16:22:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 18 Apr 2022 14:22:45 +0000
    Subject: [Koha-bugs] [Bug 30172] Background jobs failing due to race
     condition
    In-Reply-To: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30172-70-9R33EXLUmK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 18 16:22:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 18 Apr 2022 14:22:51 +0000
    Subject: [Koha-bugs] [Bug 30172] Background jobs failing due to race
     condition
    In-Reply-To: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30172-70-SElIvo1fPm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |Pushed to stable
             Version(s)|                            |,21.11.05
            released in|                            |
    
    --- Comment #39 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 18 16:23:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 18 Apr 2022 14:23:22 +0000
    Subject: [Koha-bugs] [Bug 30172] Background jobs failing due to race
     condition
    In-Reply-To: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30172-70-0RWiz2Q00y@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|,21.11.05                   |22.05.00,21.11.05
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 18 16:24:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 18 Apr 2022 14:24:18 +0000
    Subject: [Koha-bugs] [Bug 30172] Background jobs failing due to race
     condition
    In-Reply-To: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30172-70-EYz4XiPKKq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to stable            |ASSIGNED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 18 16:31:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 18 Apr 2022 14:31:12 +0000
    Subject: [Koha-bugs] [Bug 30172] Background jobs failing due to race
     condition
    In-Reply-To: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30172-70-LqhJVlFCkj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 18 16:31:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 18 Apr 2022 14:31:20 +0000
    Subject: [Koha-bugs] [Bug 30172] Background jobs failing due to race
     condition
    In-Reply-To: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30172-70-uVHVh88NOB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to stable
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 18 16:57:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 18 Apr 2022 14:57:24 +0000
    Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
     for use as filters when searching the catalog
    In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17170-70-8HGIeDg2X1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 18 16:57:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 18 Apr 2022 14:57:28 +0000
    Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
     for use as filters when searching the catalog
    In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17170-70-JPrVOu9bd8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170
    
    --- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133376
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133376&action=edit
    Bug 17170: (follow-up) Correct handling of limits in ES
    
    This patch alters the code in the ES QueryBuilder. Reflecting
    how things are handled in build_query_compat we clean the query,
    but not the limits. In Zebra we simply recursivly call buildQuery,
    but the ES query structure is more complex, so we handle the pieces
    individually
    
    Additionally I add more tests to cover other cases
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 18 18:36:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 18 Apr 2022 16:36:59 +0000
    Subject: [Koha-bugs] [Bug 30541] Resolve return claim works but "hangs" if
     MarkLostItemsAsReturned is set for return claims
    In-Reply-To: <bug-30541-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30541-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30541-70-NlCLHFWoB3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133357|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Created attachment 133377
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133377&action=edit
    Bug 30541 - Resolve return claim works but "hangs" if MarkLostItemsAsReturned
    is set for return claims
    
    Basically, if MarkLostItemsAsReturned is set for return claims, the code will
    crash while trying to pull the checkout so it can update the lost status of the
    item. This is because the code assumes there must be a checkout and never
    checks the old_checkouts table.
    
    This bug appears to only exist in 21.05 at this time. It was fixed by a
    combination of bugs 29495 and 28588.
    
    Test Plan:
    1) Set MarkLostItemsAsReturned for return claims
    2) Mark a checkout as claims returned
    3) Verify the checkout is no longer on the patron record
    4) Resolve the claim
    5) Note the attempt "hangs" but refreshing the page shows it worked
    6) Apply this patch, restart all the things!
    7) Repeat steps 2-4
    8) It works!
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    Signed-off-by: Christine Lee <chlee at pascolibraries.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 18 18:58:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 18 Apr 2022 16:58:24 +0000
    Subject: [Koha-bugs] [Bug 21494] No checkin notice created for offline
     circulation checkins
    In-Reply-To: <bug-21494-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21494-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21494-70-XTb2Qm9d8v@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21494
    
    Rebecca Coert <rcoert at arlingtonva.us> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |rcoert at arlingtonva.us
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 18 21:39:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 18 Apr 2022 19:39:47 +0000
    Subject: [Koha-bugs] [Bug 28896] Checkin Slip doesn't work for anonymized
     checkouts
    In-Reply-To: <bug-28896-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28896-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28896-70-FheBgIJJ0Q@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28896
    
    Rebecca Coert <rcoert at arlingtonva.us> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |rcoert at arlingtonva.us
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 00:00:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 18 Apr 2022 22:00:34 +0000
    Subject: [Koha-bugs] [Bug 30559] Batch Number Auto Increment Miscalculation
    In-Reply-To: <bug-30559-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30559-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30559-70-0vcQfgd5kE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30559
    
    Charles Kelley <cmkelleymls at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Batch Number Auto Increment |Batch Number Auto Increment
                       |Goes Awry -- Cannot         |Miscalculation
                       |Determine How               |
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 04:55:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 02:55:47 +0000
    Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
    In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22456-70-7yk0j941Ho@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456
    
    --- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    I have started coding this. The first thing I did was making it an entry in the
    circulation rules page so this can be set per library and per patron category.
    
    More on this tomorrow :-D
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 06:38:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 04:38:10 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-lNJDYzfdir@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    
    --- Comment #15 from David Cook <dcook at prosentient.com.au> ---
    (In reply to Owen Leonard from comment #11)
    > (In reply to David Cook from comment #6)
    > > error: sha1 information is lacking or useless
    > 
    > Applying on master resulted in a little auto-merging but nothing like this.
    > I don't know what was happening for you. Please try again!
    
    I'd say that there was probably somehow an ancestor commit that only existed in
    your local repo. All good though this time!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 06:48:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 04:48:22 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-5c9ilWwdjH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    
    --- Comment #16 from David Cook <dcook at prosentient.com.au> ---
    While I'm finding issues in master, they don't appear to be related to this
    change. Looking good to me.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 06:50:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 04:50:01 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-g8rxcbpoII@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 06:50:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 04:50:14 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-lAqX3dXusM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133252|0                           |1
            is obsolete|                            |
    
    --- Comment #17 from David Cook <dcook at prosentient.com.au> ---
    Created attachment 133378
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133378&action=edit
    Bug 29155: Upgrade jQuery and jQuery Migrate to latest versions
    
    jQuery is upgraded from 2.2.3 to 3.6.0.
    jQuery Migrate is upgraded from 1.3.0 to 3.3.2.
    
    The next patch will update links to point to the new assets.
    
    Signed-off-by: David Cook <dcook at prosentient.com.au>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 06:50:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 04:50:19 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-5Scuh11ro6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133253|0                           |1
            is obsolete|                            |
    
    --- Comment #18 from David Cook <dcook at prosentient.com.au> ---
    Created attachment 133379
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133379&action=edit
    Bug 29155: Update links to jQuery and jQuery Migrate files
    
    With these patches, jQuery versions in the OPAC and staff interface are
    both updated to 3.6.0. The latest version of jQuery Migrate is installed
    to allow us to take a slower approach to updating out-of-date syntax.
    
    To test, apply the patch and try as many pages as you can, paying
    attention to the browser console to watch for errors.
    
    Signed-off-by: David Cook <dcook at prosentient.com.au>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 06:50:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 04:50:24 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-gcIpjBfezx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133356|0                           |1
            is obsolete|                            |
    
    --- Comment #19 from David Cook <dcook at prosentient.com.au> ---
    Created attachment 133380
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133380&action=edit
    Bug 29155: (follow-up) Work around change to jQueryUI tab API
    
    For some reason, with the combination of jQuery 3.6.0 and jQueryUI
    1.13.1, the way to access the current active tab's link has changed.
    Previously the tab activate event would provide information about the
    link as "ui.newTab.context." It appears that "context" is no longer
    available.
    
    This patch updates the two instances in Koha where this process is
    broken.
    
    To test, apply the patch and check out to a patron with holds on their
    account.
    
    - When the checkout page loads, confirm that each tab loads its contents
      correctly when clicked.
    - Check that the correct tab is activated when you append the tab link
      to the page url, e.g.
    
      /cgi-bin/koha/circ/circulation.pl?borrowernumber=XXX#reldebarments
    
      ...which should select the "Restrictions" tab for you. You may need to
      try this in a new tab or shift-reload to get the browser to look for
      the hash.
    
    - Perform the same tests on the patron details page.
    
    Signed-off-by: David Cook <dcook at prosentient.com.au>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 06:54:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 04:54:26 +0000
    Subject: [Koha-bugs] [Bug 30561] New: Javascript error when clicking "Date
     acquired"
    Message-ID: <bug-30561-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30561
    
                Bug ID: 30561
               Summary: Javascript error when clicking "Date acquired"
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Cataloging
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: dcook at prosentient.com.au
            QA Contact: testopia at bugs.koha-community.org
                    CC: m.de.rooy at rijksmuseum.nl
    
    When I'm clicking on "Date acquired" in koha-testing-docker, the field is
    populating but I'm getting this Javascript error:
    
    calendar_21.1200033.js:11 Uncaught ReferenceError: dateformat_string is not
    defined
        at is_valid_date (calendar_21.1200033.js:11:22)
        at validate_date (calendar_21.1200033.js:48:10)
        at Object.onClose (additem.pl?biblionumber=29:500:1942)
        at pe (flatpickr.min_21.1200033.js:2:34535)
        at Object.E.w.close (flatpickr.min_21.1200033.js:2:30421)
        at HTMLDocument.Z (flatpickr.min_21.1200033.js:2:20063)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 06:55:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 04:55:20 +0000
    Subject: [Koha-bugs] [Bug 30559] Batch Import Number Auto Increment
     Miscalculation
    In-Reply-To: <bug-30559-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30559-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30559-70-cc7s72h7Zl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30559
    
    Charles Kelley <cmkelleymls at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Batch Number Auto Increment |Batch Import Number Auto
                       |Miscalculation              |Increment Miscalculation
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 06:55:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 04:55:50 +0000
    Subject: [Koha-bugs] [Bug 30562] New: "Use saved" throwing fatal error on
     page load
    Message-ID: <bug-30562-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30562
    
                Bug ID: 30562
               Summary: "Use saved" throwing fatal error on page load
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: blocker
              Priority: P5 - low
             Component: Reports
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: dcook at prosentient.com.au
            QA Contact: testopia at bugs.koha-community.org
    
    Can't call method "value" on unblessed reference at
    /kohadevbox/koha/reports/guided_reports.pl line 80
    
       80: my $session = $cookie ? get_session($cookie->value) : undef;
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 06:56:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 04:56:46 +0000
    Subject: [Koha-bugs] [Bug 30562] "Use saved" throwing fatal error on page
     load
    In-Reply-To: <bug-30562-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30562-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30562-70-pziAJO97YA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30562
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |RESOLVED
             Resolution|---                         |DUPLICATE
    
    --- Comment #1 from David Cook <dcook at prosentient.com.au> ---
    
    
    *** This bug has been marked as a duplicate of bug 30532 ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 06:56:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 04:56:46 +0000
    Subject: [Koha-bugs] [Bug 30532] guided_reports.pl has a problem
    In-Reply-To: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30532-70-glxytZoYh7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30532
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |dcook at prosentient.com.au
    
    --- Comment #2 from David Cook <dcook at prosentient.com.au> ---
    *** Bug 30562 has been marked as a duplicate of this bug. ***
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 06:59:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 04:59:50 +0000
    Subject: [Koha-bugs] [Bug 30532] guided_reports.pl has a problem
    In-Reply-To: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30532-70-hKflKfX26O@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30532
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |29957
    
    --- Comment #3 from David Cook <dcook at prosentient.com.au> ---
    Based off Owen's comment, I'm guessing this depends on Bug 29957
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29957
    [Bug 29957] Cookies not removed after logout
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 06:59:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 04:59:50 +0000
    Subject: [Koha-bugs] [Bug 29957] Cookies not removed after logout
    In-Reply-To: <bug-29957-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29957-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29957-70-oFSJsdwrMv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29957
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30532
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30532
    [Bug 30532] guided_reports.pl has a problem
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 07:01:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 05:01:51 +0000
    Subject: [Koha-bugs] [Bug 26632] BatchStageMarcRecords passes a random
     number to AddBiblioToBatch / AddAuthToBatch
    In-Reply-To: <bug-26632-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26632-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26632-70-ngR0OwrxlE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26632
    
    Charles Kelley <cmkelleymls at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |cmkelleymls at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 09:20:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 07:20:07 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-8p6df8akbu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133370|0                           |1
            is obsolete|                            |
    
    --- Comment #82 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133381
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133381&action=edit
    Bug 29602: Surround strings with span tag
    
    To be nicer with translators.
    
    Update the PO files for whichever languages will show how this is
    useful.
    
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    Rebased-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 09:20:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 07:20:12 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-t1SJP4l6K3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133371|0                           |1
            is obsolete|                            |
    
    --- Comment #83 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133382
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133382&action=edit
    Bug 29602: (follow-up) Surround strings with span tag
    
    To be nicer with translators.
    
    Update the PO files for whichever languages will show how this is useful.
    
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    Rebased-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 09:20:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 07:20:17 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-voqE2suWEH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133372|0                           |1
            is obsolete|                            |
    
    --- Comment #84 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133383
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133383&action=edit
    Bug 29602: (follow-up) Fix TT tags broken due to missing %
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 09:20:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 07:20:23 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-L95hxbzVqR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133373|0                           |1
            is obsolete|                            |
    
    --- Comment #85 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133384
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133384&action=edit
    Bug 29602: (follow-up) fix crash: SET KohaSpan => USE KohaSpan
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 09:20:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 07:20:28 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-TTABW5CQPf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133374|0                           |1
            is obsolete|                            |
    
    --- Comment #86 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133385
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133385&action=edit
    Bug 29602: (follow-up) fix duplicate, missing or mismatching <span>
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 09:21:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 07:21:27 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-4NTwNi03w0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    --- Comment #87 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    All looking good here from my perspective. I'm not an active translator, but
    this appears to improve things from my untrained eye.
    
    Signing off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 09:22:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 07:22:10 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-NfEy5tRQ2g@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |julian.maurice at biblibre.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 09:33:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 07:33:24 +0000
    Subject: [Koha-bugs] [Bug 30410] Add a way for plugins to register
     background tasks
    In-Reply-To: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30410-70-rhSzRaSgct@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410
    
    --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133386
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133386&action=edit
    Bug 30410: (follow-up) Instantiate object in unit test
    
    This patch updates the unit test for the BackgroundJob->_derived_class()
    private method to instantiate a proper object to work on instead of
    calling the type_to_class_mapping method directly as non-object method.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 09:35:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 07:35:37 +0000
    Subject: [Koha-bugs] [Bug 25815] SIP Checkout: add more information on why
     the patron is blocked
    In-Reply-To: <bug-25815-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25815-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25815-70-lM8GHFZE3o@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815
    
    Matthias Meusburger <matthias.meusburger at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 09:45:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 07:45:25 +0000
    Subject: [Koha-bugs] [Bug 30541] Resolve return claim works but "hangs" if
     MarkLostItemsAsReturned is set for return claims
    In-Reply-To: <bug-30541-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30541-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30541-70-ChgG8aMltg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133377|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133387
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133387&action=edit
    Bug 30541 - Resolve return claim works but "hangs" if MarkLostItemsAsReturned
    is set for return claims
    
    Basically, if MarkLostItemsAsReturned is set for return claims, the code will
    crash while trying to pull the checkout so it can update the lost status of the
    item. This is because the code assumes there must be a checkout and never
    checks the old_checkouts table.
    
    This bug appears to only exist in 21.05 at this time. It was fixed by a
    combination of bugs 29495 and 28588.
    
    Test Plan:
    1) Set MarkLostItemsAsReturned for return claims
    2) Mark a checkout as claims returned
    3) Verify the checkout is no longer on the patron record
    4) Resolve the claim
    5) Note the attempt "hangs" but refreshing the page shows it worked
    6) Apply this patch, restart all the things!
    7) Repeat steps 2-4
    8) It works!
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Christine Lee <chlee at pascolibraries.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 09:47:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 07:47:07 +0000
    Subject: [Koha-bugs] [Bug 30541] Resolve return claim works but "hangs" if
     MarkLostItemsAsReturned is set for return claims
    In-Reply-To: <bug-30541-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30541-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30541-70-ncwZEvQiYb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Simple fix that causes no regressions.
    
    Passing QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 09:57:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 07:57:27 +0000
    Subject: [Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap
     (amount) results in data loss and extra fines
    In-Reply-To: <bug-30346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30346-70-B2J9DVkjGn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133199|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133388
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133388&action=edit
    Bug 30346: Correctly transfer values when editing rules
    
    To test:
    --Create a circulation rule with a value in "Overdue fines cap (amount), or
    edit an existing rule to add it
    -Save the new (or edited) rule.
    -Edit the same rule again to change any other field. Note that "Overdue fines
    cap (amount)" is now blank
    -Save your edited rule - "Overdue fines cap (amount)" will save as blank.
    
    Apply patch
    
    --Create a circ rule with a value in Overdue fines cap (amount) and check "Cap
    fine at replacement price" for that same rule.
    -Save the rule
    -Try ediding the rule and make sure both of those values now save correctly.
    -Add several more rules and try playing with both "Cap fine at replacement
    price" and "Overdue fines cap (amount)". Make sure everything saves right.
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 09:57:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 07:57:43 +0000
    Subject: [Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap
     (amount) results in data loss and extra fines
    In-Reply-To: <bug-30346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30346-70-MkRwy9p1iz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Good catch, PQA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 10:12:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 08:12:34 +0000
    Subject: [Koha-bugs] [Bug 18493] Add more languages to advanced search
     languages dropdown
    In-Reply-To: <bug-18493-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18493-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18493-70-SxlZN3ACe7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18493
    
    --- Comment #7 from Séverine Queune <severine.queune at bulac.fr> ---
    (In reply to Fridolin Somers from comment #6)
    > This would be useful.
    I completely agree !
    
    Maybe a silly proposition (or technically impossible to apply...) but why don't
    use the authorized values list dedicated to languages for this list ?
    
    That way, each library would have available in this list only the languages
    ​​actually present in its catalog.
    It would also be easier to find the language we want, because the order of this
    list is a little bit esoteric in my view :/
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 10:14:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 08:14:50 +0000
    Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor
     performance for records with many items
    In-Reply-To: <bug-29483-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29483-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29483-70-BbinWC6TO0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132094|0                           |1
            is obsolete|                            |
    
    --- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133389
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133389&action=edit
    Bug 29483: Unit tests
    
    This patch updates the AllowRenewalIfOtherItemsAvailable tests to
    remove deletion of all data, and create specific circ rules for this
    test. It adjust several other tests that were relying on the rules from
    this test, so thy too create their opwn specific rules.
    
    Additionally, we add tests to cover the case of mutliple items on the record,
    and some items cannot fill some reserves.
    
    What is uncovered here is that the same patron is checked twice, so two holds
    can
    be filled, but they only satisfy a single patron
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 10:14:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 08:14:55 +0000
    Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor
     performance for records with many items
    In-Reply-To: <bug-29483-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29483-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29483-70-Swsc22uhXr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132095|0                           |1
            is obsolete|                            |
    
    --- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133390
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133390&action=edit
    Bug 29483: Check ItemsAnyAvailableAndNotRestricted once per patron
    
    ItemsAnyAvailableAndNotRestricted can take a long time and create nested loops.
    We can check it once per patron, however, this requires us to flip the loops.
    Since an item can only be used once, we now add a check to see if this item has
    already
    been assigned to a borrower.
    
    To test:
    1 - Find or create a biblio with 100 items
    2 - Place ten 'Next available' holds on a biblio
    3 - Set preference 'AllowRenewalIfOtherItemsAvailable' to 'Allow'
        Set circ rules 'On shelf holds allowed' to 'If any unavailable'
    4 - Checkout one of the items to a patron, backdated to be overdue
    5 - Note a long loading time for the patron's checkouts
    6 - Apply patch, restart_all
    7 - Patron loads much faster
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 10:14:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 08:14:59 +0000
    Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor
     performance for records with many items
    In-Reply-To: <bug-29483-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29483-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29483-70-HhFHflC3ft@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132113|0                           |1
            is obsolete|                            |
    
    --- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133391
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133391&action=edit
    Bug 29483: Further improve performance of script
    
    This patch adds a few tests to cover more cases, and to highlight current
    functionality.
    
    The script only allows renewal if all outstanding holds can be filled by
    available items.
    This means we can return as soon as we have determined that not all holds can
    be filled.
    
    I add FIXME and some explanatory comments - I will file a follow-up bug for
    those, but
    I feel we can accept these improvements to the performance and deal with the
    issues
    of how it 'should' work versus how it does work on another report.
    
    To test:
    1 - prove -v t/db_dependent/Circulation.t
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 10:16:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 08:16:02 +0000
    Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor
     performance for records with many items
    In-Reply-To: <bug-29483-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29483-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29483-70-xKboo7x3U7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
                 Status|Signed Off                  |Passed QA
    
    --- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    It took me a little while to wrap my head around the logic change, but all made
    sense in the end.
    
    I concur, it does improve performance and I found no regressions.
    
    QA scripts are happy and unit tests are all passing.
    
    Passing QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 10:16:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 08:16:08 +0000
    Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor
     performance for records with many items
    In-Reply-To: <bug-29483-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29483-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29483-70-fYAV84CYU7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                       |y.org                       |.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 10:28:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 08:28:36 +0000
    Subject: [Koha-bugs] [Bug 30509] Accordion on letter.tt is broken
    In-Reply-To: <bug-30509-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30509-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30509-70-hObEUyurW0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30509
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133197|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133392
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133392&action=edit
    Bug 30509: Fix configuration of Notices accordion widget
    
    The jQueryUI upgrade broke the Accordion on the notices edit page. I'm
    not sure why, but defining a "header" option in the accordion
    configuration fixes it.
    
    To test, apply the patch and test the notices edit page both with and
    without TranslateNotices and multiple languages installed. In both cases
    the different sections (Email, Print, SMS) should open and close
    correctly.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 10:29:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 08:29:58 +0000
    Subject: [Koha-bugs] [Bug 30509] Accordion on letter.tt is broken
    In-Reply-To: <bug-30509-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30509-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30509-70-3fReBEN8FX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30509
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Hmm, fix works as described and I'm not seeing any other regressions.. No idea
    why it works though, I can't find anything in the jQueryUI docs to suggest this
    is required.. 
    
    But.. it works.. so Passing QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 10:48:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 08:48:44 +0000
    Subject: [Koha-bugs] [Bug 30376] Unable to save item if field date acquired
     is set mandatory
    In-Reply-To: <bug-30376-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30376-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30376-70-gpUeaYAW0j@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30376
    
    --- Comment #12 from Johanna Räisä <johanna.raisa at koha-suomi.fi> ---
    (In reply to Kyle M Hall from comment #11)
    > Unable to replicate bug in 21.11.x. If I am mistaken please let me know!
    
    I tested on 21.11.x and the bug was also in it.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 12:01:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 10:01:15 +0000
    Subject: [Koha-bugs] [Bug 30563] New: Add system preference to make the cash
     register field required when collecting a payment
    Message-ID: <bug-30563-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30563
    
                Bug ID: 30563
               Summary: Add system preference to make the cash register field
                        required when collecting a payment
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: enhancement
              Priority: P5 - low
             Component: Patrons
              Assignee: julian.maurice at biblibre.com
              Reporter: julian.maurice at biblibre.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
    
    Currently, the cash register field is required only if the CASH payment type is
    selected.
    Some users want to make it required no matter which payment type is selected.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 12:01:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 10:01:16 +0000
    Subject: [Koha-bugs] [Bug 28138] Add system preference to make the payment
     type required
    In-Reply-To: <bug-28138-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28138-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28138-70-lW6MRghX1I@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28138
    
    Julian Maurice <julian.maurice at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30563
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 12:11:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 10:11:10 +0000
    Subject: [Koha-bugs] [Bug 30563] Add system preference to make the cash
     register field required when collecting a payment
    In-Reply-To: <bug-30563-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30563-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30563-70-y9z34JRyoU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30563
    
    --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> ---
    Created attachment 133393
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133393&action=edit
    Bug 30563: Add syspref to make the "cash register" field mandatory
    
    Test plan:
    1. Apply patch and run updatedatabase
    2. Enable 'UseCashRegisters' syspref and create at least one cash
       register for your library
    3. Verify that you have several authorized values in the 'PAYMENT_TYPE'
       category. One of them should be 'CASH'
    4. Go to a patron accounting tab, create a manual invoice and go to the
       payment form. Select payment type 'CASH' and verify that you cannot
       submit the form if no cash register is selected.
       Select another payment type and verify that you can submit the form
       even if no cash register is selected
    5. Set syspref 'RequireCashRegister' to 'always require a cash register'
    6. Repeat step 4 but this time you should not be able to submit the form
       if no cash register is selected, no matter which payment type is
       selected.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 12:11:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 10:11:18 +0000
    Subject: [Koha-bugs] [Bug 30376] Unable to save item if field date acquired
     is set mandatory
    In-Reply-To: <bug-30376-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30376-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30376-70-jF08ESlICv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30376
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|FIXED                       |---
                 Status|RESOLVED                    |REOPENED
    
    --- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
    (In reply to Johanna Räisä from comment #12)
    > (In reply to Kyle M Hall from comment #11)
    > > Unable to replicate bug in 21.11.x. If I am mistaken please let me know!
    > 
    > I tested on 21.11.x and the bug was also in it.
    
    Thanks for the confirmation! I'll get this backported.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 12:11:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 10:11:26 +0000
    Subject: [Koha-bugs] [Bug 30563] Add system preference to make the cash
     register field required when collecting a payment
    In-Reply-To: <bug-30563-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30563-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30563-70-cD8AOlsr7u@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30563
    
    Julian Maurice <julian.maurice at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 12:11:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 10:11:28 +0000
    Subject: [Koha-bugs] [Bug 30376] Unable to save item if field date acquired
     is set mandatory
    In-Reply-To: <bug-30376-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30376-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30376-70-ijUsgw2ANT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30376
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|REOPENED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 12:11:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 10:11:38 +0000
    Subject: [Koha-bugs] [Bug 30376] Unable to save item if field date acquired
     is set mandatory
    In-Reply-To: <bug-30376-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30376-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30376-70-WlzOPnUeFs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30376
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 12:11:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 10:11:49 +0000
    Subject: [Koha-bugs] [Bug 30376] Unable to save item if field date acquired
     is set mandatory
    In-Reply-To: <bug-30376-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30376-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30376-70-Kfli6rVsnv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30376
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 12:11:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 10:11:58 +0000
    Subject: [Koha-bugs] [Bug 30376] Unable to save item if field date acquired
     is set mandatory
    In-Reply-To: <bug-30376-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30376-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30376-70-cUIJY2bfl9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30376
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 12:13:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 10:13:32 +0000
    Subject: [Koha-bugs] [Bug 30376] Unable to save item if field date acquired
     is set mandatory
    In-Reply-To: <bug-30376-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30376-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30376-70-qPbxCHEeFM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30376
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|22.05.00                    |22.05.00,21.11.05
            released in|                            |
                 Status|Pushed to master            |Pushed to stable
    
    --- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 12:16:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 10:16:41 +0000
    Subject: [Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability
     to send notices based on request supplier updates
    In-Reply-To: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30484-70-yvigvzPYqk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484
    
    --- Comment #1 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
    Created attachment 133394
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133394&action=edit
    Bug 30484: Add ILL update notice
    
    Adds a new ILL_REQUEST_UPDATE notice which is to be used for the
    formation of notices informing users of updates to ILL requests.
    
    Commit includes database updates and template changes for messaging
    preferences
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 12:16:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 10:16:45 +0000
    Subject: [Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability
     to send notices based on request supplier updates
    In-Reply-To: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30484-70-6WFfzqO2qz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484
    
    --- Comment #2 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
    Created attachment 133395
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133395&action=edit
    Bug 30484: Implement support for ILL request updates
    
    This commit adds support for the concept of ILL request update notices.
    
    - Adds a new Koha::Illrequest::SupplierUpdate class that is used to
    encapsulate an update to a request, this update may come from a
    supplier via a backend or from core ILL via, perhaps, a user action
    - Adds a new Koha::Illrequest::SupplierUpdateProcessor base class that
    can be subclassed in order to create a processor that can be passed an
    update and act accordingly.
    - Updates to Illrequest.pm to support the above classes and allow core
    Koha to offer update processors
    - A shell script to initiate a periodic process to check for updates
    meeting given criteria and run the appropriate processors
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 12:16:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 10:16:49 +0000
    Subject: [Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability
     to send notices based on request supplier updates
    In-Reply-To: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30484-70-pVIt9ZcmGP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484
    
    --- Comment #3 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
    Created attachment 133396
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133396&action=edit
    Bug 30484: Add unit tests
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 12:33:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 10:33:26 +0000
    Subject: [Koha-bugs] [Bug 25815] SIP Checkout: add more information on why
     the patron is blocked
    In-Reply-To: <bug-25815-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25815-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25815-70-G0pPezpLkT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815
    
    --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133397
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133397&action=edit
    Bug 25815: SIP Checkout: add more information on why the patron is blocked.
    
    Currently, on SIP checkout, Koha only returns "Patron Blocked" when there is
    a problem with the patron.
    
    This patch adds more specific informations, with the following messages:
    
     - "Patron expired"
     - "Patron debarred"
     - "Patron has fines" (see system preference "noissuescharge")
     - "Patron blocked" (see system preference "OverduesBlockCirc")
    
    Test plan:
    
     - Try to do a SIP checkout with a patron that is in one of the above
    situations.
     - Check that the displayed message matches the patron's situation.
    
    Signed-off-by: Sonia <sonia.bouis at univ-lyon3.fr>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 12:33:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 10:33:47 +0000
    Subject: [Koha-bugs] [Bug 25815] SIP Checkout: add more information on why
     the patron is blocked
    In-Reply-To: <bug-25815-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25815-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25815-70-trsB02Or3i@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
     Attachment #133215|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 12:34:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 10:34:21 +0000
    Subject: [Koha-bugs] [Bug 25815] SIP Checkout: add more information on why
     the patron is blocked
    In-Reply-To: <bug-25815-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25815-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25815-70-lro7Yosb1z@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Issues raised by Nick all fixed and patch all works as expected here.
    
    QA scripts are happy, and we have Unit tests.. Passing QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 12:48:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 10:48:53 +0000
    Subject: [Koha-bugs] [Bug 24865] Customize the Accountlines Description
    In-Reply-To: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24865-70-tvOLxgCADD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Hmm, this is clever and I generally like it.
    
    It feels like a bit of a hack being in letters/notices though, which is a bit
    of a shame, but I can appreciate why you added it there.
    
    I wonder if this might helpful elsewhere too and a future work might split it
    out of notices and into a simplified interface a little more like the News and
    HTML Content stuff.. i.e. without the superfluous transport types handling.
    
    We almost need a base class for the template handling and then more specific
    classes for the use cases like letters/notices vs blocks/pages.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 12:50:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 10:50:05 +0000
    Subject: [Koha-bugs] [Bug 30534] borrowers.guarantorid not present on
     database
    In-Reply-To: <bug-30534-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30534-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30534-70-GFTJDmaFHI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30534
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 12:50:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 10:50:11 +0000
    Subject: [Koha-bugs] [Bug 30534] borrowers.guarantorid not present on
     database
    In-Reply-To: <bug-30534-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30534-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30534-70-RxJ2tv939c@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30534
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133282|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from David Nind <david at davidnind.com> ---
    Created attachment 133398
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133398&action=edit
    Bug 30534: Remove guarantor_id attribute from the patron object
    
    This patch removes an attribute that was actually removed 3 years ago
    and causes an exception when trying to search for it. The API responses
    don't include it anyways.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 12:58:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 10:58:25 +0000
    Subject: [Koha-bugs] [Bug 24865] Customize the Accountlines Description
    In-Reply-To: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24865-70-syZflzPcR4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865
    
    --- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
    (In reply to Martin Renvoize from comment #10)
    > Hmm, this is clever and I generally like it.
    > 
    > It feels like a bit of a hack being in letters/notices though, which is a
    > bit of a shame, but I can appreciate why you added it there.
    > 
    > I wonder if this might helpful elsewhere too and a future work might split
    > it out of notices and into a simplified interface a little more like the
    > News and HTML Content stuff.. i.e. without the superfluous transport types
    > handling.
    > 
    > We almost need a base class for the template handling and then more specific
    > classes for the use cases like letters/notices vs blocks/pages.
    
    FWIW Bug 27334 adds template toolkit support to news. If that makes it in we
    could move this template from slips to there.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 13:02:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 11:02:28 +0000
    Subject: [Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability
     to send notices based on request supplier updates
    In-Reply-To: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30484-70-zWksTLEV9w@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484
    
    Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133394|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
    Created attachment 133399
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133399&action=edit
    Bug 30484: Add ILL update notice
    
    Adds a new ILL_REQUEST_UPDATE notice which is to be used for the
    formation of notices informing users of updates to ILL requests.
    
    Commit includes database updates and template changes for messaging
    preferences
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 13:02:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 11:02:32 +0000
    Subject: [Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability
     to send notices based on request supplier updates
    In-Reply-To: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30484-70-wBZ27VkjEE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484
    
    Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133395|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
    Created attachment 133400
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133400&action=edit
    Bug 30484: Implement support for ILL request updates
    
    This commit adds support for the concept of ILL request update notices.
    
    - Adds a new Koha::Illrequest::SupplierUpdate class that is used to
    encapsulate an update to a request, this update may come from a
    supplier via a backend or from core ILL via, perhaps, a user action
    - Adds a new Koha::Illrequest::SupplierUpdateProcessor base class that
    can be subclassed in order to create a processor that can be passed an
    update and act accordingly.
    - Updates to Illrequest.pm to support the above classes and allow core
    Koha to offer update processors
    - A shell script to initiate a periodic process to check for updates
    meeting given criteria and run the appropriate processors
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 13:02:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 11:02:36 +0000
    Subject: [Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability
     to send notices based on request supplier updates
    In-Reply-To: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30484-70-O0god1CZGv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484
    
    Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133396|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
    Created attachment 133401
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133401&action=edit
    Bug 30484: Add unit tests
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 13:04:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 11:04:07 +0000
    Subject: [Koha-bugs] [Bug 30561] Javascript error when clicking "Date
     acquired"
    In-Reply-To: <bug-30561-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30561-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30561-70-KrouNFnBFs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30561
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |RESOLVED
             Resolution|---                         |DUPLICATE
    
    --- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
    
    
    *** This bug has been marked as a duplicate of bug 30514 ***
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 13:04:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 11:04:07 +0000
    Subject: [Koha-bugs] [Bug 30514] Error in date format check following
     datepicker removal
    In-Reply-To: <bug-30514-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30514-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30514-70-KqN5u97Wig@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30514
    
    --- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
    *** Bug 30561 has been marked as a duplicate of this bug. ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 13:38:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 11:38:43 +0000
    Subject: [Koha-bugs] [Bug 24865] Customize the Accountlines Description
    In-Reply-To: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24865-70-sGN9IIepx0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865
    
    --- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Nick Clemens from comment #9)
    > 1 - The idea though is adding the ability to customize which fields are
    > being concatenated there, to allow librarians to add their own values in an
    > understandable format. Additionally, we are now adding the ability to add
    > translation here by getting patron language. I think it is worth the cost
    > for new functionality
    > 
    > 2 - The code addresses the creation of new overdue accountlines - the code
    > is hit whenever a new overdue amount is generated. The note about deleted
    > refers to the fact the info like 'Barcode' is calculated on display from
    > information in the accountlines - when an item is deleted that link is
    > broken and that info is not displayed. If [% item.barcode %] is added to the
    > description it will be retained after deletion
    
    Thx. Will finish it this one now.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 13:40:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 11:40:25 +0000
    Subject: [Koha-bugs] [Bug 24865] Customize the Accountlines Description
    In-Reply-To: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24865-70-ufUbyUflUC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865
    
    --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Martin Renvoize from comment #10)
    > It feels like a bit of a hack being in letters/notices though, which is a
    > bit of a shame, but I can appreciate why you added it there.
    
    True. We might resolve that with a small follow-up.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 13:59:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 11:59:45 +0000
    Subject: [Koha-bugs] [Bug 24865] Customize the Accountlines Description
    In-Reply-To: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24865-70-g9S3qqBbBW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 13:59:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 11:59:50 +0000
    Subject: [Koha-bugs] [Bug 24865] Customize the Accountlines Description
    In-Reply-To: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24865-70-RGosojuRhy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133344|0                           |1
            is obsolete|                            |
    
    --- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133402
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133402&action=edit
    Bug 24865: Customize the Accountlines Description
    
    It would be great if we could customize what information was added to the
    "Description of charges" field when a fine was made so data could be stored
    even when the item is deleted.
    
    Test Plan:
    1) Create an overdue checkout that will get a fine
    2) Run fines.pl
    3) Note the description for the fine
    4) Delete the fine from the database
    5) Apply this patch
    6) Run updatedatabase.pl
    7) Restart all the things!
    8) Run fines.pl
    9) Note the description of the fine is unchanged
    10) Delete the fine again
    11) Browse to Slips & Notices
    12) Edit the new notice OVERDUE_FINE_DESC
        You will have access to the objects checkout, item, and borrower
    13) Run fines.pl
    14) Note your new description was used
    
    Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 13:59:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 11:59:55 +0000
    Subject: [Koha-bugs] [Bug 24865] Customize the Accountlines Description
    In-Reply-To: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24865-70-3lDeeGjWDM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865
    
    --- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133403
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133403&action=edit
    Bug 24865: (QA follow-up) Remove hardcoded notice name from protected_letters
    
    If the letter has been removed, fall back to itemnumber/due date. (Title is
    no longer fetched.) We may assume that the notice is present.
    
    Note: The option to 'protect' a notice may need some more thought. Perhaps
    it needs to be an attribute on itself.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Tested by deleting notice, running fines again.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 14:26:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 12:26:16 +0000
    Subject: [Koha-bugs] [Bug 18986] High Hold Items with Decreased Loan Period
     Can't Be Checked-Out with Self-Check
    In-Reply-To: <bug-18986-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18986-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18986-70-9xd7dt22Ks@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18986
    
    Magnus Enger <magnus at libriotech.no> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |magnus at libriotech.no
    
    --- Comment #7 from Magnus Enger <magnus at libriotech.no> ---
    (In reply to Kalle Karlsson from comment #6)
    > (In reply to Martin Renvoize from comment #5)
    > > I believe this may have been another manifestation of bug 26301.. can we
    > > varify whether this is still a problem on current master?
    > 
    > It is still an issue for our clients atleast. Haven't found a workaround to
    > it.
    
    What versions?
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 14:33:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 12:33:43 +0000
    Subject: [Koha-bugs] [Bug 27334] Add Template Toolkit support to news items
    In-Reply-To: <bug-27334-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27334-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27334-70-OgdwBZilNJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27334
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Bug 24865 highlights a good use case for this, though I feel we should probably
    limit the data we allow users to fetch using it similar to the notices..
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 14:34:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 12:34:10 +0000
    Subject: [Koha-bugs] [Bug 24865] Customize the Accountlines Description
    In-Reply-To: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24865-70-uk7z0sdwTQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865
    
    --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Good call on QA.. I was about to say, lets be pragmatic and handle follow-ups
    and follow-ups :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 14:35:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 12:35:56 +0000
    Subject: [Koha-bugs] [Bug 9097] Add option to trigger 'Welcome mail' manually
    In-Reply-To: <bug-9097-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-9097-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-9097-70-JcJb0QTX2O@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|BLOCKED                     |Passed QA
    
    --- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    The blocking bugs are now PQA so resetting this one too.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 14:38:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 12:38:47 +0000
    Subject: [Koha-bugs] [Bug 30385] Standardize our swagger yaml spec files
    In-Reply-To: <bug-30385-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30385-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30385-70-cp0hHaDJfl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30385
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|29810                       |30536
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    [Bug 29810] Add embed options documentation
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    [Bug 30536] Embeds should be defined in a single place
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 14:38:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 12:38:47 +0000
    Subject: [Koha-bugs] [Bug 29810] Add embed options documentation
    In-Reply-To: <bug-29810-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29810-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29810-70-Rr1h0xj1Ok@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|30385                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30385
    [Bug 30385] Standardize our swagger yaml spec files
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 14:38:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 12:38:47 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-LlVGh1GKjq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30385
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30385
    [Bug 30385] Standardize our swagger yaml spec files
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 14:42:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 12:42:43 +0000
    Subject: [Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability
     to send notices based on request supplier updates
    In-Reply-To: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30484-70-25PoyNXVmt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484
    
    Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    --- Comment #7 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
    TEST PLAN:
    
    This test plan tests the provided functionality by using a mocked update
    supplied by the FreeForm backend. The command line script is run which will
    look for requests that match the supplied criteria, obtain a mocked update from
    them, and process the update. The processor simply prints the message supplied
    in the update to the screen.
    
    - Ensure you have Interlibrary Loans turned on and have the FreeForm backend
    installed. It is important you are using the "bug_30484_mock_request_update"
    branch of the FreeForm backend as this enables the backend to provide mock
    updates that this functionality uses.
    - Create a FreeForm ILL request
    - On the "Manage ILL request" page for the newly created request, click the
    "Confirm request" button, thereby setting the request status to "Requested"
    - Run the script, in the "misc" directory, run:
    
      perl process_ill_updates.pl --statuses REQ --backend FreeForm
    
    - TEST: You should see the following:
      - The message "This is a mock update from the FreeForm backend"
      - The following run report:
    
    Run details:
    Request ID: xxx
      Processing by: FreeForm
      Number of processors run: 1
      Processor details:
        Processor name: Print to STDERR
        Success messages: PRINTED
        Error messages:
    
    - If the above messages were printed, the test plan can be considered
    successful.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 15:10:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 13:10:16 +0000
    Subject: [Koha-bugs] [Bug 30405] Style of address in patron search result
     are 110%
    In-Reply-To: <bug-30405-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30405-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30405-70-GAMj0wOIp1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30405
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com, oleonard at myacpl.org
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 15:11:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 13:11:26 +0000
    Subject: [Koha-bugs] [Bug 29302] The dataTables Koha RESTful API wrapper
     should allow picking match type at the column level
    In-Reply-To: <bug-29302-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29302-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29302-70-fslvEVzuJp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29302
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Failed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 15:12:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 13:12:57 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-VHv5ErDn9K@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                       |ity.org                     |.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 15:16:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 13:16:09 +0000
    Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in
     plugins
    In-Reply-To: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29008-70-YdMIKAXMNi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|In Discussion               |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 15:30:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 13:30:41 +0000
    Subject: [Koha-bugs] [Bug 27334] Add Template Toolkit support to news items
    In-Reply-To: <bug-27334-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27334-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27334-70-aWdHXOo6cf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27334
    
    Magnus Enger <magnus at libriotech.no> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |magnus at libriotech.no
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 15:35:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 13:35:11 +0000
    Subject: [Koha-bugs] [Bug 30517] Translation breaks editing parent type
     circulation rule
    In-Reply-To: <bug-30517-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30517-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30517-70-YsUg02YXRe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517
    
    Shi Yao Wang <shi-yao.wang at inLibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |shi-yao.wang at inLibro.com
     Attachment #133364|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 16:17:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 14:17:23 +0000
    Subject: [Koha-bugs] [Bug 30564] New: Prevent user in staff interface from
     setting incorrect pickup location on item-level hold
    Message-ID: <bug-30564-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30564
    
                Bug ID: 30564
               Summary: Prevent user in staff interface from setting incorrect
                        pickup location on item-level hold
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Hold requests
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: andrew at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com
    
    When placing a hold in the staff interface, we have one pickup location
    dropdown at the top of the page for bib-level holds, and then separate
    dropdowns for the pickup location for an item-level hold. The interface here
    makes it easy to mistakenly place an item-level hold for the wrong pickup
    location. 
    
    To recreate:
    - go to request.pl
    - change the pickup location at the top of the form
    - then pick a specific item and click "Place hold"
    - Koha ignores the change you made to the bib-level dropdown and maintains the
    default pickup from the item-level line
    
    When one changes the bib-level pickup, Koha should automatically change all the
    item-level locations to match the new selection. If that would result in an
    invalid pickup location, the item should instead go to a blank pickup so the
    user is forced to pick something.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 16:43:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 14:43:29 +0000
    Subject: [Koha-bugs] [Bug 30204] Add subtitle to serial subscription search
    In-Reply-To: <bug-30204-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30204-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30204-70-vhEoSEPQGI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Severity|enhancement                 |normal
                     CC|                            |andrew at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 16:43:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 14:43:40 +0000
    Subject: [Koha-bugs] [Bug 30205] Add biblio.subtitle to the
     subscription-detail.pl page
    In-Reply-To: <bug-30205-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30205-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30205-70-zUcfjs1SuL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Severity|enhancement                 |normal
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 16:45:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 14:45:04 +0000
    Subject: [Koha-bugs] [Bug 29777] Fields 580 are wrong displayed in summary
     column
    In-Reply-To: <bug-29777-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29777-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29777-70-HyA5rBKEOZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29777
    
    George Veranis <gveranis at dataly.gr> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
              Component|About                       |MARC Authority data support
                     CC|                            |gveranis at dataly.gr
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 16:45:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 14:45:15 +0000
    Subject: [Koha-bugs] [Bug 21682] Stock Rotation: Update DB is failing with
     strict_sql_modes ON
    In-Reply-To: <bug-21682-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21682-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21682-70-UHtDSHJZ71@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21682
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |m.de.rooy at rijksmuseum.nl
    
    --- Comment #30 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Jonathan Druart from comment #26)
    > Created attachment 81815 [details] [review]
    > Bug 21682: Add update DB entry for existing installs
    > 
    > Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    This patch removed the NOT NULL from the title field at upgrade time.
    WIll open a report for it.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 16:46:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 14:46:57 +0000
    Subject: [Koha-bugs] [Bug 21682] Stock Rotation: Update DB is failing with
     strict_sql_modes ON
    In-Reply-To: <bug-21682-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21682-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21682-70-Mkx33RhPFj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21682
    
    --- Comment #31 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Marcel de Rooy from comment #30)
    > (In reply to Jonathan Druart from comment #26)
    > > Created attachment 81815 [details] [review] [review]
    > > Bug 21682: Add update DB entry for existing installs
    > > 
    > > Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    > 
    > This patch removed the NOT NULL from the title field at upgrade time.
    > WIll open a report for it.
    
    Description field
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 16:48:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 14:48:02 +0000
    Subject: [Koha-bugs] [Bug 30565] New: Field stockrotationrotas.description
     should be NOT NULL, title UNIQUE
    Message-ID: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30565
    
                Bug ID: 30565
               Summary: Field stockrotationrotas.description should be NOT
                        NULL, title UNIQUE
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Database
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: m.de.rooy at rijksmuseum.nl
            QA Contact: testopia at bugs.koha-community.org
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 16:48:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 14:48:54 +0000
    Subject: [Koha-bugs] [Bug 30565] Field stockrotationrotas.description should
     be NOT NULL, title UNIQUE
    In-Reply-To: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30565-70-E8DTucv0Wu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30565
    
    --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Compare this
    
    $DBversion = '18.06.00.040'; CONSTRAINT `stockrotationrotas_title` UNIQUE
    (`title`)  EN `title` varchar(100) NOT NULL,            -- Title for this rota
    $DBversion = '18.06.00.048';     $dbh->do( "ALTER TABLE stockrotationrotas
    CHANGE COLUMN description description text" );  #Bug 21682
    
    with kohastructure.sql.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 16:51:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 14:51:05 +0000
    Subject: [Koha-bugs] [Bug 30037] Set default profile when staging MARC
     records on import
    In-Reply-To: <bug-30037-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30037-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30037-70-OvRRb2tJAX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037
    
    George Veranis <gveranis at dataly.gr> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |gveranis at dataly.gr
              Component|Notices                     |MARC Bibliographic record
                       |                            |staging/import
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 16:57:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 14:57:48 +0000
    Subject: [Koha-bugs] [Bug 30565] Field stockrotationrotas.description should
     be NOT NULL, title UNIQUE
    In-Reply-To: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30565-70-QehgKhP2nD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30565
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30486
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
    [Bug 30486] [OMNIBUS] Synchronize database schema with (older) database
    revisions
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 16:57:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 14:57:48 +0000
    Subject: [Koha-bugs] [Bug 30486] [OMNIBUS] Synchronize database schema with
     (older) database revisions
    In-Reply-To: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30486-70-2T25CkrFWm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30565
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30565
    [Bug 30565] Field stockrotationrotas.description should be NOT NULL, title
    UNIQUE
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 17:24:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 15:24:25 +0000
    Subject: [Koha-bugs] [Bug 30541] Resolve return claim works but "hangs" if
     MarkLostItemsAsReturned is set for return claims
    In-Reply-To: <bug-30541-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30541-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30541-70-dxolnuS8JU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541
    
    Rebecca Coert <rcoert at arlingtonva.us> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |rcoert at arlingtonva.us
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 17:26:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 15:26:16 +0000
    Subject: [Koha-bugs] [Bug 30566] New: Incorporate link handling in OPAC's
     biblio-title include
    Message-ID: <bug-30566-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30566
    
                Bug ID: 30566
               Summary: Incorporate link handling in OPAC's biblio-title
                        include
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: enhancement
              Priority: P5 - low
             Component: OPAC
              Assignee: oleonard at myacpl.org
              Reporter: oleonard at myacpl.org
            QA Contact: testopia at bugs.koha-community.org
            Depends on: 11529, 29609
    
    Output of titles in the OPAC has been centralized into an include file, but
    unlike the staff interface this include file doesn't include the option of
    adding a link using the default bibliographic view.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529
    [Bug 11529] Add subtitle, medium and part fields to biblio table
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29609
    [Bug 29609] Links to guess the biblio default view need to be centralized
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 17:26:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 15:26:16 +0000
    Subject: [Koha-bugs] [Bug 11529] Add subtitle,
     medium and part fields to biblio table
    In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-11529-70-i2xqda1EIa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30566
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30566
    [Bug 30566] Incorporate link handling in OPAC's biblio-title include
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 17:26:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 15:26:16 +0000
    Subject: [Koha-bugs] [Bug 29609] Links to guess the biblio default view need
     to be centralized
    In-Reply-To: <bug-29609-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29609-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29609-70-qw5cZRMC8u@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29609
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30566
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30566
    [Bug 30566] Incorporate link handling in OPAC's biblio-title include
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 17:36:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 15:36:16 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-Zbo6JNMUqe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |ASSIGNED
               Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                       |ity.org                     |.com
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 17:55:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 15:55:44 +0000
    Subject: [Koha-bugs] [Bug 30517] Translation breaks editing parent type
     circulation rule
    In-Reply-To: <bug-30517-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30517-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30517-70-1IRAAvvFmz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517
    
    --- Comment #3 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
    Created attachment 133404
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133404&action=edit
    Bug 30517: Translation breaks editing parent type circulation rule fix
    
    Test plan:
    1. Install another language in the staff interface
       1. ./translate install xx-XX
       2. Check the box of the language in the 'language' system preference
       3. Refresh
    2. Create an item type with a parent
       1. Go to Administration > Item types
       2. Create a new item type or modify an existing one, assigning a parent type
    (I created a 'Children's books' type and assigned 'Books' as its parent)
    3. Create a circulation rule for the parent type (I created All/Books, with 10
    checkouts allowed)
    4. Create a circulation rule for All/All (I created All/All with 30 checkouts
    allowed)
    5. In English, click on "Edit" next to the parent type rule (All/Books)
    --> Note that the item type in the bottom row (the modifiable row) is changed
    to 'Books (All)'
    6. Modify the number of checkouts allowed (e.g. 99)
    --> The All/Books rule is modified
    7. Switch the interface to the other language
    8. Click on "Edit" next to the parent type rule (All/Books)
    --> Note that the item type in the bottom row stays on 'All'
    9. Modify the number of checkouts allowed (e.g. 88)
    --> The All/All rule is modified
    10. Apply the patch and refresh
    11. Do step 8-9 again and notice it now behaves as it should
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 17:57:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 15:57:57 +0000
    Subject: [Koha-bugs] [Bug 30566] Incorporate link handling in OPAC's
     biblio-title include
    In-Reply-To: <bug-30566-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30566-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30566-70-l58xCY8JSy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30566
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 17:58:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 15:58:01 +0000
    Subject: [Koha-bugs] [Bug 30566] Incorporate link handling in OPAC's
     biblio-title include
    In-Reply-To: <bug-30566-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30566-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30566-70-mzBH2ok7xM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30566
    
    --- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133405
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133405&action=edit
    Bug 30566: Incorporate link handling in OPAC's biblio-title include
    
    This patch modifies the biblio-title include so that it can be used to
    link to the bibliographic record using the default biblio view.
    
    On pages where the biblio-title include was wrapped in an anchor tag, a
    link parameter is added: [% INCLUDE 'biblio-title.inc' link=> 1 %]
    
    To test, apply the patch and view the following pages in the OPAC to
    confirm that titles are displayed correctly and that the link to the
    bibliographic record is correct:
    
    - Log in to the OPAC: On the "your summary" page, check checkouts,
      overdues, holds, and article requests.
    - Check the "your holds history" page.
    - Locate a bibliographic record and click "Save to your lists."
      In the popup, the title should be displayed correctly without a link.
    - Place a hold, and check the hold confirmation page.
    - Check the "Recent comments" page.
    - Locate a record which has a local cover image attached, and view the
      image.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 18:40:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 16:40:22 +0000
    Subject: [Koha-bugs] [Bug 30510] Add a Patron reason column to the
     suggestion tables on suggestion.tt
    In-Reply-To: <bug-30510-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30510-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30510-70-LhoKf1XVi0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30510
    
    ByWater Sandboxes <bws.sandboxes at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133200|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
    Created attachment 133406
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133406&action=edit
    Bug 30510: Add Patron reason column to suggestion tables
    
    To test:
    1. Make some patron reasons for suggestion via Home > Administration >
    Authorized values > OPAC_SUG
    2. Give those reasons a description.
    3. Make several suggestions via staff client and/or OPAC and apply some of the
    reasons you just made
    4. Apply patch
    5. Go to Home > Acquistions > Suggestions management
    6. Give some of the suggestions some different status
    (PENDING/REJECTED/ACCEPTED/ect)
    7. Make sure on each of the tables you can see the column 'Patron reason'
    8. Go to Administration > Table settings and attempt to hide the column.
    9. Confirm that the column is properly hidden on the Suggestions management
    page
    
    Signed-off-by: Rhonda Kuiper <rkuiper at roundrocktexas.gov>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 18:40:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 16:40:59 +0000
    Subject: [Koha-bugs] [Bug 30510] Add a Patron reason column to the
     suggestion tables on suggestion.tt
    In-Reply-To: <bug-30510-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30510-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30510-70-DEtWu65GSS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30510
    
    Rhonda Kuiper <rkuiper at roundrocktexas.gov> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
                     CC|                            |rkuiper at roundrocktexas.gov
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 19:18:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 17:18:35 +0000
    Subject: [Koha-bugs] [Bug 5316] Limit Z39.50 targets to specific users
    In-Reply-To: <bug-5316-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-5316-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-5316-70-at8YV88nH0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5316
    
    Carl <ctodd at hcc.edu> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |ctodd at hcc.edu
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 19:23:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 17:23:17 +0000
    Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
    In-Reply-To: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27113-70-uihU6kUxCQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113
    
    Blou <philippe.blouin at inlibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132360|0                           |1
            is obsolete|                            |
    
    --- Comment #68 from Blou <philippe.blouin at inlibro.com> ---
    Created attachment 133407
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133407&action=edit
    Bug 27113: ElasticSearch: Autocomplete in input search
    
    Usually the user knows only part of the title of the book or only the name of
    the author, etc. When he start search something Koha (ElasticSearch) predicts
    the rest of a word or expression which user is typing.  Autocomplete predicts
    that thanks to index of ElasticSearch.
    
    TEST PLAN
    Important! In this patch we need to do reindex ElasticSearch. ElasticSearch
    must have all information in his index.
    1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch
    !! APPLY PATCH !!
    2. Mapping is good (Intranet -> Catalog -> Search engine configuration
    (Elasticsearch) ).
    !Recommended 'Reset Mapping'  -> 'Yes'
    3. In your koha-conf.xml file you must have good <index_name> for
    <elasticsearch> and version ES
    4. Update Preference:
    ./installer/data/mysql/updatedatabase.pl
    If that passe good you can look the lines:
     - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl
     - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with
    elasticsearch
    5. After that we can look two options in the preferences:
    -  IntranetAutocompleteElasticSearch;
    -  OPACAutocompleteElasticSearch;
    4. For add information in the index we must run script for reindexing:
    ./misc/search_tools/rebuild_elasticsearch.pl -v -d
    5. Waiting for the end of indexing
    6. Go on Preference and find :
    -  IntranetAutocompleteElasticSearch;
    -  OPACAutocompleteElasticSearch;
    Value "Show" turn on autocomplete.
    7. Now we have Autocomplete for Intranet/OPAC search input (advanced search
    also).
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 19:25:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 17:25:35 +0000
    Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
    In-Reply-To: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27113-70-HsneHUt10i@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113
    
    Blou <philippe.blouin at inlibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133045|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 19:26:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 17:26:07 +0000
    Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
    In-Reply-To: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27113-70-42mRk7uCLG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113
    
    Blou <philippe.blouin at inlibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133042|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 19:26:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 17:26:30 +0000
    Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
    In-Reply-To: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27113-70-95gF6jBCAT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113
    
    Blou <philippe.blouin at inlibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132808|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 19:26:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 17:26:58 +0000
    Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
    In-Reply-To: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27113-70-VtijnwTayH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113
    
    Blou <philippe.blouin at inlibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132362|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 19:27:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 17:27:16 +0000
    Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
    In-Reply-To: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27113-70-o1IKvhH28z@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113
    
    Blou <philippe.blouin at inlibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132361|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 19:28:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 17:28:50 +0000
    Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
    In-Reply-To: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27113-70-TjB96mfogu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113
    
    Blou <philippe.blouin at inlibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132364|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 19:29:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 17:29:30 +0000
    Subject: [Koha-bugs] [Bug 30545] Replace the use of jQueryUI Accordion on
     the notices page
    In-Reply-To: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30545-70-Ig5Rv2Flxk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 19:29:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 17:29:34 +0000
    Subject: [Koha-bugs] [Bug 30545] Replace the use of jQueryUI Accordion on
     the notices page
    In-Reply-To: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30545-70-R90iWPfRms@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133331|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
    Created attachment 133408
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133408&action=edit
    Bug 30545: Replace the use of jQueryUI Accordion on the notices page
    
    This patch updates the notices edit interface in order to replace
    jQueryUI accordion and tabs widgets with Bootstrap collapse and tabs.
    
    To test, apply the patch and rebuild the staff interface CSS
    (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
    
    - Set the TranslateNotices system preference to "Don't allow."
    - Go to Tools -> Notices and edit any notice.
    - On the "Modify notice" page you should see three collapsed sections:
      Email, Print, and SMS.
    - Clicking the section headings should expand and collapse the panels.
    - With one of the panels open, click Save -> Save and continue editing.
      - When the page reloads the same panel should be expanded.
    
    - Enable the TranslateNotices system preference.
    - Return to the edit interface for one of your notices.
    - You should now see at least two tabs: Default and English.
    - The sections under each tab should continue to work correctly.
    - Test the "Save and continue" functionality again. When redirected you
      should return to both the correct tab and the correct panel, e.g. the
      "Print" section under the "English (en)" tab.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 19:31:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 17:31:32 +0000
    Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
    In-Reply-To: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27113-70-zl53kFjwNl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113
    
    Blou <philippe.blouin at inlibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133407|0                           |1
            is obsolete|                            |
    
    --- Comment #69 from Blou <philippe.blouin at inlibro.com> ---
    Created attachment 133409
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133409&action=edit
    Bug 27113: ElasticSearch: Autocomplete in input search
    
    Usually the user knows only part of the title of the book or only the name of
    the author, etc. When he start search something Koha (ElasticSearch) predicts
    the rest of a word or expression which user is typing.  Autocomplete predicts
    that thanks to index of ElasticSearch.
    
    TEST PLAN
    Important! In this patch we need to do reindex ElasticSearch. ElasticSearch
    must have all information in his index.
    1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch
    !! APPLY PATCH !!
    2. Mapping is good (Intranet -> Catalog -> Search engine configuration
    (Elasticsearch) ).
    !Recommended 'Reset Mapping'  -> 'Yes'
    3. In your koha-conf.xml file you must have good <index_name> for
    <elasticsearch> and version ES
    4. Update Preference:
    ./installer/data/mysql/updatedatabase.pl
    If that passe good you can look the lines:
     - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl
     - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with
    elasticsearch
    5. After that we can look two options in the preferences:
    -  IntranetAutocompleteElasticSearch;
    -  OPACAutocompleteElasticSearch;
    4. For add information in the index we must run script for reindexing:
    ./misc/search_tools/rebuild_elasticsearch.pl -v -d
    5. Waiting for the end of indexing
    6. Go on Preference and find :
    -  IntranetAutocompleteElasticSearch;
    -  OPACAutocompleteElasticSearch;
    Value "Show" turn on autocomplete.
    7. Now we have Autocomplete for Intranet/OPAC search input (advanced search
    also).
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 19:31:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 17:31:37 +0000
    Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
    In-Reply-To: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27113-70-EoRcrraxeO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113
    
    Blou <philippe.blouin at inlibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132363|0                           |1
            is obsolete|                            |
    
    --- Comment #70 from Blou <philippe.blouin at inlibro.com> ---
    Created attachment 133410
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133410&action=edit
    Bug 27113: (follow-up) Move new CSS to main SCSS files
    
    This patch removes the separate CSS files added for the autocomplete
    feature and puts them into the "main" SCSS files. I think a separate
    file isn't necessary because the amount of CSS it adds is so small.
    
    I've also tweaked the style of the autocomplete menu shown when you use
    the arrow keys to navigate through the autocomplete choices. I think the
    previous white-on-light-green didn't have enough contrast.
    
    To test you must rebuild the OPAC and staff client CSS:
    https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client
    
    Follow the previous test plan, being careful to observe how it
    works when the autocomplete menu has been triggered and you use the
    arrow keys to navigate through the results.
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 19:36:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 17:36:30 +0000
    Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
    In-Reply-To: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27113-70-dY0Tx1l5M7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113
    
    --- Comment #71 from Blou <philippe.blouin at inlibro.com> ---
    I know it's bad form, but since we've been told the functionality requires a
    re-engineering to use the REST api, a lot of rebase are going to happen until
    we get this on the master, so I squashed it all.
    
    Well, not all, I kept the one patch contributed from outside our company.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 19:40:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 17:40:33 +0000
    Subject: [Koha-bugs] [Bug 28138] Add system preference to make the payment
     type required
    In-Reply-To: <bug-28138-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28138-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28138-70-dT7PSCpJxU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28138
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lucas at bywatersolutions.com
    
    --- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
    When RequirePaymentType is enabled the dropdown for 'Payment type' defaults to
    the first choice in the list. I know this has been a problem in other parts of
    Koha since the user can submit the form without actually making a choice about
    payment type. In my opinion, if RequirePaymentType we should also add an empty
    value as the defualt choice. This actually forces the user to make a selection,
    instead of just clicking through.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 19:41:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 17:41:46 +0000
    Subject: [Koha-bugs] [Bug 30525] Items batch modification broken
    In-Reply-To: <bug-30525-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30525-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30525-70-bXLoludeH8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30525
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 19:41:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 17:41:49 +0000
    Subject: [Koha-bugs] [Bug 30525] Items batch modification broken
    In-Reply-To: <bug-30525-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30525-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30525-70-75ZfEDnKxh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30525
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133273|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133411
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133411&action=edit
    Bug 30525: Items batch modification broken
    
    This patch modifies instances in the code which try to get cookies
    using:
    
    my %cookies = parse CGI::Cookie($cookie);
    
    In some cases the relevant lines can be removed because they are unused.
    In others it can be replaced with:
    
    my %cookies = CGI::Cookie->fetch();
    
    To test, apply the patch and restart_all. Test the following pages to
    confirm they load without errors:
    
    - Circulation -> Offline circulation file upload
    - Circulation -> Offline circulation -> Add to queue
    
    - Tools -> Batch item modification
    - Tools -> Stage MARC for import
    - Tools -> Staged MARC management
    - Tools -> Batch patron modification
    - Tools -> Upload local cover image
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 20:00:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 18:00:10 +0000
    Subject: [Koha-bugs] [Bug 29863] Show requested transfers in the holdings
     table
    In-Reply-To: <bug-29863-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29863-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29863-70-2SIIUyxEmE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29863
    
    Lisette Scheer <lisetteslatah at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lisetteslatah at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 20:00:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 18:00:51 +0000
    Subject: [Koha-bugs] [Bug 22567] Stock rotation manage rotas should show
     items current and desired locations
    In-Reply-To: <bug-22567-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22567-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22567-70-kujAuVma41@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22567
    
    Lisette Scheer <lisetteslatah at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lisetteslatah at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 20:06:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 18:06:09 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-zQbOUaE9fD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    --- Comment #88 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    After having reread a lot the code and tested a lot of the pages, this look
    pretty safe and a very welcome change.
    Passing QA :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 20:06:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 18:06:59 +0000
    Subject: [Koha-bugs] [Bug 30538] Regression: rotating collections does not
     update status
    In-Reply-To: <bug-30538-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30538-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30538-70-jhdKW9JcE5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30538
    
    Lisette Scheer <lisetteslatah at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lisetteslatah at gmail.com
    
    --- Comment #1 from Lisette Scheer <lisetteslatah at gmail.com> ---
    Donna, 
    The item isn't in transit though. It has been requested for transit similar to
    a hold.
    
    It was a huge problem for our library that it was just putting everything into
    transit. 
    
    I would love a status that was something like "Requested for transit" so it was
    clear if you were looking at the record though, like suggested on Bug 29863. 
    
    Lisette
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 20:10:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 18:10:34 +0000
    Subject: [Koha-bugs] [Bug 30552] Add a way to import circulation rules
    In-Reply-To: <bug-30552-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30552-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30552-70-SRpIOmuKEH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30552
    
    Lisette Scheer <lisetteslatah at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lisetteslatah at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 20:11:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 18:11:49 +0000
    Subject: [Koha-bugs] [Bug 30552] Add a way to import circulation rules
    In-Reply-To: <bug-30552-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30552-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30552-70-YoCnbv47Lh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30552
    
    --- Comment #1 from Lisette Scheer <lisetteslatah at gmail.com> ---
    Yes, this would be great. Our consortium recently overhauled our circulation
    rules and being able to change them in a file and import them on the day of
    would have been much simpler than we were able to do.
    Lisette
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 20:15:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 18:15:49 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-osS2LvrurI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    --- Comment #89 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    The QA script complained about some existing missing filters. It's not from the
    patch, but are they worth a follow up here or should it be a separate ticket?
    This one isn't meant to be backported anyway.
    
     FAIL  
    koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_authority_record_modification.inc
       FAIL   filters
                    missing_filter at line 32 (                <span>Authority
    record [% authority_link | $KohaSpan %] has not been modified. An error
    occurred on modifying it</span>)
                    missing_filter at line 35 (                <span>Authority
    record [% authority_link | $KohaSpan %] has successfully been modified.</span>)
    
    ---
    
     FAIL  
    koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_biblio_record_modification.inc
       FAIL   filters
                    missing_filter at line 43 (                <span>Bibliographic
    record [% biblio_link %] has not been modified. An error occurred on modifying
    it.</span>)
                    missing_filter at line 46 (                <span>Bibliographic
    record [% biblio_link %] has successfully been modified.</span>)
    
    ---
    
     FAIL  
    koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_hold_cancel.inc
       FAIL   filters
                    missing_filter at line 43 (                <span>Hold on [%
    biblio_link | $KohaSpan %] for [% patron_link | $KohaSpan %] has successfully
    been cancelled.</span>)
                    missing_filter at line 43 (                <span>Hold on [%
    biblio_link | $KohaSpan %] for [% patron_link | $KohaSpan %] has successfully
    been cancelled.</span>)
    
    ---
    
     FAIL  
    koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_item_record_deletion.inc
       FAIL   filters
                    missing_filter at line 44 (                    <span>Item with
    barcode [% item_link | $KohaSpan%] cannot be deleted:</span>)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 20:19:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 18:19:34 +0000
    Subject: [Koha-bugs] [Bug 30549] Replace the use of jQueryUI Accordion on
     pending patron updates page
    In-Reply-To: <bug-30549-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30549-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30549-70-u3P1ARl1YT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549
    
    ByWater Sandboxes <bws.sandboxes at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133332|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
    Created attachment 133412
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133412&action=edit
    Bug 30549: Replace the use of jQueryUI Accordion on pending patron updates page
    
    This patch updates the pending patron updates page to use Bootstrap
    collapse instead of jQueryUI.
    
    This patch contains whitespace changes, so view the diff with this in
    mind.
    
    To test, apply the patch and rebuild the staff client CSS
    (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
    
    - If necessary, log into the OPAC and submit an update via the "Your
      personal details" page. Ideally do this for two or more patrons.
    - In the staff client, follow the "Patrons requesting modifications"
      link.
    - On the "Update patron records" page you should see the headings
      representing each of the patrons with pending updates. The first panel
      should be expanded.
    - Confirm that the panels expand and collapse correctly.
    - Follow the "Patron details" link for one of these patrons.
    - Click the "Review pending modifications" link on the patron detail
      page.
    - When the update page opens that patron's panel should be expanded.
    
    Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 20:19:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 18:19:58 +0000
    Subject: [Koha-bugs] [Bug 30549] Replace the use of jQueryUI Accordion on
     pending patron updates page
    In-Reply-To: <bug-30549-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30549-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30549-70-kgwaE0AOM0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549
    
    Lisette Scheer <lisetteslatah at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
                     CC|                            |lisetteslatah at gmail.com
    
    --- Comment #3 from Lisette Scheer <lisetteslatah at gmail.com> ---
    Worked as expected. Lisette
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 20:23:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 18:23:16 +0000
    Subject: [Koha-bugs] [Bug 30567] New: Create manual invoice with FR currency
     format show the incorrect format
    Message-ID: <bug-30567-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567
    
                Bug ID: 30567
               Summary: Create manual invoice with FR currency format show the
                        incorrect format
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Acquisitions
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: the-minh.luong at inlibro.com
            QA Contact: testopia at bugs.koha-community.org
    
    When creating a manual invoice with  CurrencyFormat = FR , it shows the
    incorrect format.
    
    To test:
    1- Go in Administration->Debit types
    2- Click on New debit type
    3- Fill the form:
       Code: USEDBOOK
       Default amount: 0.50
       Description: Used book
       Can be manually invoiced: Yes
       Can be sold: Optionnal
    4- Save
    5- Go in Patrons
    6- Go in a patron's page
    7- Go in the "Accounting" section
    8- Click on "Create manual invoice"
    9- Fill the form 
    10- Choose the created debit (Used book)
    11- Notice that the format is incorrect (0,50 instead of 0.50)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 20:23:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 18:23:57 +0000
    Subject: [Koha-bugs] [Bug 30567] Create manual invoice with FR currency
     format show the incorrect format
    In-Reply-To: <bug-30567-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30567-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30567-70-WUtIx3iFJ4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567
    
    The Minh Luong <the-minh.luong at inlibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |caroline.cyr-la-rose at inlibr
                       |                            |o.com,
                       |                            |philippe.blouin at inlibro.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 20:30:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 18:30:55 +0000
    Subject: [Koha-bugs] [Bug 30567] Create manual invoice with FR currency
     format show the incorrect format
    In-Reply-To: <bug-30567-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30567-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30567-70-xcXihWJtDq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567
    
    --- Comment #1 from The Minh Luong <the-minh.luong at inlibro.com> ---
    Created attachment 133413
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133413&action=edit
    Bug 30567: Create manual invoice with FR currency format show the correct
    format
    
    This patch correct the format of the price when creating a manual invoice with
    CurrencyFormat = FR
    
    To test:
    1- Go in Administration->Debit types
    2- Click on New debit type
    3- Fill the form:
       Code: USEDBOOK
       Default amount: 0.50
       Description: Used book
       Can be manually invoiced: Yes
       Can be sold: Optionnal
    4- Save
    5- Go in Patrons
    6- Go in a patron's page
    7- Go in the "Accounting" section
    8- Click on "Create manual invoice"
    9- Fill the form
    10- Choose the created debit (Used book)
    11- Notice that the format is incorrect (0,50 instead of 0.50)
    12 - Apply the patch
    13- We now see the correct format
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 20:31:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 18:31:13 +0000
    Subject: [Koha-bugs] [Bug 30567] Create manual invoice with FR currency
     format show the incorrect format
    In-Reply-To: <bug-30567-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30567-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30567-70-FTck0dfACq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567
    
    The Minh Luong <the-minh.luong at inlibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 20:31:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 18:31:23 +0000
    Subject: [Koha-bugs] [Bug 30567] Create manual invoice with FR currency
     format show the incorrect format
    In-Reply-To: <bug-30567-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30567-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30567-70-4kcA4X0uiJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567
    
    The Minh Luong <the-minh.luong at inlibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 20:38:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 18:38:59 +0000
    Subject: [Koha-bugs] [Bug 30510] Add a Patron reason column to the
     suggestion tables on suggestion.tt
    In-Reply-To: <bug-30510-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30510-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30510-70-lKeisO575e@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30510
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |victor at tuxayo.net
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 20:52:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 18:52:18 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-gwN00jgjdi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Medium patch
                     CC|                            |victor at tuxayo.net
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 20:52:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 18:52:53 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-LnAydLEFyE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |david at davidnind.com
                 Status|Needs Signoff               |Failed QA
    
    --- Comment #33 from David Nind <david at davidnind.com> ---
    All tests pass except this one:
    
    prove t/db_dependent/Circulation_holdsqueue.t
    t/db_dependent/Circulation_holdsqueue.t .. Use of uninitialized value in
    addition (+) at /kohadevbox/koha/C4/Biblio.pm line 3107.
        # Looks like you planned 2 tests but ran 5.
    t/db_dependent/Circulation_holdsqueue.t .. 1/1 
    #   Failed test 'AddIssue() and AddReturn() real-time holds queue tests'
    #   at t/db_dependent/Circulation_holdsqueue.t line 66.
    # Looks like you failed 1 test of 1.
    t/db_dependent/Circulation_holdsqueue.t .. Dubious, test returned 1 (wstat 256,
    0x100)
    Failed 1/1 subtests 
    
    Test Summary Report
    -------------------
    t/db_dependent/Circulation_holdsqueue.t (Wstat: 256 Tests: 1 Failed: 1)
      Failed test:  1
      Non-zero exit status: 1
    Files=1, Tests=1,  2 wallclock secs ( 0.01 usr  0.01 sys +  1.98 cusr  0.11
    csys =  2.11 CPU)
    Result: FAIL
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 20:53:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 18:53:38 +0000
    Subject: [Koha-bugs] [Bug 30534] borrowers.guarantorid not present on
     database
    In-Reply-To: <bug-30534-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30534-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30534-70-rFv80AYTjr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30534
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Trivial patch
                     CC|                            |victor at tuxayo.net
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 20:58:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 18:58:39 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-2vvHb9bUeW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |victor at tuxayo.net
       Patch complexity|---                         |Medium patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 21:00:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 19:00:20 +0000
    Subject: [Koha-bugs] [Bug 30511] Don't lock entire database when dumping
     Koha instance
    In-Reply-To: <bug-30511-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30511-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30511-70-W5vyW8WjPf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30511
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |victor at tuxayo.net
       Patch complexity|---                         |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 21:09:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 19:09:39 +0000
    Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
    In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29897-70-VCk34eNOXs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Medium patch
                     CC|                            |victor at tuxayo.net
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 21:20:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 19:20:36 +0000
    Subject: [Koha-bugs] [Bug 30182] background_jobs.status should be an ENUM
    In-Reply-To: <bug-30182-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30182-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30182-70-FQuDqsHHKh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30182
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Patch doesn't apply
                     CC|                            |david at davidnind.com
    
    --- Comment #3 from David Nind <david at davidnind.com> ---
    Patch no longer applies 8-(
    
     git bz apply 30182
    
    Bug 30182 - background_jobs.status should be an ENUM
    
    131109 - Bug 30182: Make background_jobs.status an ENUM
    131110 - Bug 30182: DBIC update
    
    Apply? [(y)es, (n)o, (i)nteractive] y
    Applying: Bug 30182: Make background_jobs.status an ENUM
    Applying: Bug 30182: DBIC update
    Using index info to reconstruct a base tree...
    M       Koha/Schema/Result/BackgroundJob.pm
    Falling back to patching base and 3-way merge...
    Auto-merging Koha/Schema/Result/BackgroundJob.pm
    CONFLICT (content): Merge conflict in Koha/Schema/Result/BackgroundJob.pm
    error: Failed to merge in the changes.
    Patch failed at 0001 Bug 30182: DBIC update
    hint: Use 'git am --show-current-patch=diff' to see the failed patch
    
    
    Testing notes:
    - Before patch is applied show details for column in the database: 
      . show create table background_jobs;
      .  select * from background_jobs where status=0;
    - After patch is applied: should show enum values as per the patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 21:32:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 19:32:42 +0000
    Subject: [Koha-bugs] [Bug 30057] Move Virtualshelves exceptions to their own
     file
    In-Reply-To: <bug-30057-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30057-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30057-70-Tg0Wn1scGt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30057
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 21:32:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 19:32:46 +0000
    Subject: [Koha-bugs] [Bug 30057] Move Virtualshelves exceptions to their own
     file
    In-Reply-To: <bug-30057-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30057-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30057-70-2VWoaH1Ao8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30057
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #130359|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from David Nind <david at davidnind.com> ---
    Created attachment 133414
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133414&action=edit
    Bug 30057: Move virtualshelf-related exceptions to a separate library
    
    This patch moves the not-generic virtualshelf-related exceptions to
    their own file. Callers are adjusted as required.
    
    To test:
    1. Run:
       $ kshell
      k$ prove t/db_dependent/Virtualshelves.t
    => SUCCESS: Tests pass
    2. Apply this patch
    3. Repeat 1
    => SUCCESS: Tests pass
    4. Check virtualshelves work as expected
    5. Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 21:35:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 19:35:43 +0000
    Subject: [Koha-bugs] [Bug 30057] Move Virtualshelves exceptions to their own
     file
    In-Reply-To: <bug-30057-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30057-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30057-70-y7V2tr04CN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30057
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |david at davidnind.com
    
    --- Comment #6 from David Nind <david at davidnind.com> ---
    Testing notes:
    
    1. Tests pass before and after patch applied.
    
    2. Ran through basic processes for creating and deleting a list, and adding
    items to a list, removing items, downloading, sending, etc. Tested in the staff
    interface and OPAC. Everything worked as expected.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 21:37:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 19:37:40 +0000
    Subject: [Koha-bugs] [Bug 27123] Add messages to batch patrons modification
    In-Reply-To: <bug-27123-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27123-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27123-70-Slxpc3UOFz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Medium patch
                     CC|                            |victor at tuxayo.net
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 21:39:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 19:39:51 +0000
    Subject: [Koha-bugs] [Bug 30057] Move Virtualshelves exceptions to their own
     file
    In-Reply-To: <bug-30057-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30057-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30057-70-md8Cgm7cZg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30057
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |victor at tuxayo.net
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 21:42:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 19:42:32 +0000
    Subject: [Koha-bugs] [Bug 30180] Deprecate after_hold_create hook
    In-Reply-To: <bug-30180-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30180-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30180-70-wXZ7yNnn3P@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30180
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 21:42:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 19:42:38 +0000
    Subject: [Koha-bugs] [Bug 30180] Deprecate after_hold_create hook
    In-Reply-To: <bug-30180-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30180-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30180-70-CiAjVTSAL3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30180
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131101|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from David Nind <david at davidnind.com> ---
    Created attachment 133415
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133415&action=edit
    Bug 30180: Unit tests
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 21:42:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 19:42:43 +0000
    Subject: [Koha-bugs] [Bug 30180] Deprecate after_hold_create hook
    In-Reply-To: <bug-30180-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30180-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30180-70-5vvGjY2394@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30180
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131102|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from David Nind <david at davidnind.com> ---
    Created attachment 133416
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133416&action=edit
    Bug 30180: Add 'placed' after_hold_hook
    
    This patch adds a new 'after_hold_action' hook, that is called with the
    'placed' action parameter.
    
    To test:
    1. Apply the unit tests patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Plugins/Holds_hooks.t
    => FAIL: Boo, the hook is not called
    3. Apply this patch
    4. Repeat 2
    => SUCCESS: Tests pass!
    5. Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 21:42:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 19:42:48 +0000
    Subject: [Koha-bugs] [Bug 30180] Deprecate after_hold_create hook
    In-Reply-To: <bug-30180-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30180-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30180-70-8yHcOt94tk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30180
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131103|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from David Nind <david at davidnind.com> ---
    Created attachment 133417
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133417&action=edit
    Bug 30180: (follow-up) Add temporary deprecation warning
    
    This patch adds a temporary deprecation warning to let users know the
    plugin needs to get updated before the next release.
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Plugins/Holds_hooks.t
    => SUCCESS: Tests pass, warning is displayed
    3. Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 21:52:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 19:52:43 +0000
    Subject: [Koha-bugs] [Bug 30191] Authority search result list in the OPAC
     should use 'record' instead of 'biblios'
    In-Reply-To: <bug-30191-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30191-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30191-70-c0LU0qenJo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30191
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 21:52:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 19:52:47 +0000
    Subject: [Koha-bugs] [Bug 30191] Authority search result list in the OPAC
     should use 'record' instead of 'biblios'
    In-Reply-To: <bug-30191-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30191-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30191-70-Ut0vwdEzlz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30191
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131285|0                           |1
            is obsolete|                            |
    
    --- Comment #7 from David Nind <david at davidnind.com> ---
    Created attachment 133418
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133418&action=edit
    Bug 30191: Authority search result list in the OPAC should use 'record' instead
    of 'biblios'
    
    This patch updates the OPAC authority search results page so that it
    uses the term "record" instead of "biblio."
    
    The patch also changes how the template outputs the count of records so
    that it is correctly pluralized, e.g. "1 record" vs. "2 records."
    
    To test, apply the patch and perform an authority search in the OPAC.
    
    In the search results, confirm that the last table header reads
    "Records." The information in that column should be correct, using the
    word record or records.
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 22:32:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 20:32:12 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-GnyOfn01UP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    --- Comment #90 from Zeno Tajoli <ztajoli at gmail.com> ---
    Hi Victor Grousset, I test the patch on sanbox and on my VM.
    I confirm that it works and there are not problems on templates. For me OK on
    sign-off.
    I see that  the patch is on 'Passed QA' so I don't re-upload patches with my
    sign-off.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 22:33:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 20:33:00 +0000
    Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
    In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23838-70-OmF8KH5pVN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |andrew at bywatersolutions.com
    
    --- Comment #56 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    I applied this and 30275 and tried to run through the test plan here. I'm not
    getting a View button next to the renewal count in patron Circulation History
    even when the Renewal Log is enabled and there are renewals in the action_logs
    for the checkout. Is there something else I should be doing to get it to show?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 19 23:47:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 21:47:59 +0000
    Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and
     list displays and e-mails
    In-Reply-To: <bug-16522-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-16522-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-16522-70-ZSzdBYaei5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Failed QA
    
    --- Comment #10 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Thanks for testing Christian. Please mark bug as 'Failed QA' if they don't
    behave according to the test plan.
    
    I'll take a look at this when I get a chance.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 00:03:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 22:03:47 +0000
    Subject: [Koha-bugs] [Bug 30135] We should allow configuration of whether
     EDI LSQ segments map to 'location' or 'collection'
    In-Reply-To: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30135-70-4yB7vIJdP8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
    
    --- Comment #21 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    (In reply to Martin Renvoize from comment #20)
    > Follow-up pushed as RM Assistant.. I was pushing something else to get
    > peoples dev envs back up and running and thought it not a bad idea to push
    > this one too and try and get the dashboard green ;)
    
    RM likes a green dashboard ;)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 00:06:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 22:06:47 +0000
    Subject: [Koha-bugs] [Bug 30410] Add a way for plugins to register
     background tasks
    In-Reply-To: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30410-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30410-70-UOWwhSMbQ6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410
    
    --- Comment #17 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master :
      Bug 30410: (follow-up) Instantiate object in unit test
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 00:42:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 19 Apr 2022 22:42:52 +0000
    Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck
     modules for Koha
    In-Reply-To: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30444-70-HXASf2PBPE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444
    
    --- Comment #1 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
    Created attachment 133419
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133419&action=edit
    Bug 30444: Add shibboleth login to self checkout
    
    This patch adds a 'Shibboleth' option to the SelfCheckoutByLogin system
    preference. When 'Shibboleth' is selected the user should be logged
    straight into the self check module - assuming the AutoSelfCheckAllowed,
    AutoSelfCheckID and AutoSelfCheckPass system preferences are set.
    
    Test plan:
    
    1. Have your Koha setup to do Shibboleth login
    2. Set the following system preferences:
    - AutoSelfCheckAllowed => 'Allow'
    - AutoSelfCheckId and AutoSelfCheckPass => Set these to a patron with
    'circulate' permissions
    - WebBasedSelfCheck -> 'Enable'
    - OpacShibOnly -> "Don't allow"
    3. Visit the self checkout page /cgi-bin/koha/sco/sco-main.pl and notice
    a local login page loads
    4. Apply patchset, update database and restart services
    5. Set the new syspref:
    - SelfCheckoutByLogin -> 'Shibboleth'
    6. Visit the self checkout page and notice you're logged into the sco
    interface straight away, without the local login page loading
    
    Sponsored-by: Catalyst IT
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 03:00:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 01:00:09 +0000
    Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck
     modules for Koha
    In-Reply-To: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30444-70-Ae1BaafEwR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |dcook at prosentient.com.au
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 03:01:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 01:01:38 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-8Uso97CYs2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |dcook at prosentient.com.au
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 03:15:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 01:15:48 +0000
    Subject: [Koha-bugs] [Bug 30289] Use Template::Toolkit WRAPPER to reduce
     template boilerplate
    In-Reply-To: <bug-30289-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30289-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30289-70-mxcF2nnLeR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30289
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |oleonard at myacpl.org
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 03:16:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 01:16:20 +0000
    Subject: [Koha-bugs] [Bug 30289] Use Template::Toolkit WRAPPER to reduce
     template boilerplate
    In-Reply-To: <bug-30289-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30289-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30289-70-BKFrFLGdkt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30289
    
    --- Comment #8 from David Cook <dcook at prosentient.com.au> ---
    This isn't quite ready for sign off, but I'd like to get Owen's feedback before
    progressing this further.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 04:15:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 02:15:32 +0000
    Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing,
     please ignore)
    In-Reply-To: <bug-30034-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30034-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30034-70-HZCd6oAzyD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034
    
    Mason James <mtj at kohaaloha.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Automatic debian/control    |Automatic debian/control
                       |updates (testing)           |updates (testing, please
                       |                            |ignore)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 04:19:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 02:19:44 +0000
    Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing,
     please ignore)
    In-Reply-To: <bug-30034-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30034-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30034-70-5q0hKvjVog@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034
    
    --- Comment #23 from Mason James <mtj at kohaaloha.com> ---
    (In reply to Katrin Fischer from comment #22)
    > (In reply to Mason James from comment #0)
    > > a bug to use for testing debian/control updates
    > 
    > Is this supposed to go through QA?
    
    hiya... no, its just for testing a script to attach debian/control file updates
    to bugzilla
    
    pleeze ignore :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 04:20:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 02:20:24 +0000
    Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing,
     please ignore)
    In-Reply-To: <bug-30034-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30034-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30034-70-oI9uzEz5C5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034
    
    Mason James <mtj at kohaaloha.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |ASSIGNED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 05:57:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 03:57:32 +0000
    Subject: [Koha-bugs] [Bug 30514] Error in date format check following
     datepicker removal
    In-Reply-To: <bug-30514-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30514-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30514-70-CkTQYTkXaP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30514
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 05:57:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 03:57:36 +0000
    Subject: [Koha-bugs] [Bug 30514] Error in date format check following
     datepicker removal
    In-Reply-To: <bug-30514-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30514-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30514-70-LPYTHLmbdU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30514
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133218|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from David Cook <dcook at prosentient.com.au> ---
    Created attachment 133428
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133428&action=edit
    Bug 30514: Error in date format check following datepicker removal
    
    This patch corrects the is_valid_date function in the OPAC and staff
    interface so that it work correctly with Flatpickr.
    
    To test, apply the patch and clear your browser cache if necessary.
    
    - In the staff client, locate a bibliographic record and edit its items.
    - Test that the "Date acquired" date picker works correctly and that
      there are no errors in the browser console.
    - Test other date input fields to check that they still work, e.g.
      specify due date during checkout; Catalog statistics wizard; Patron
      entry/modification, etc.
    - Perform similar tests in the OPAC: Hold suspension; Update your
      personal details.
    
    Signed-off-by: David Cook <dcook at prosentient.com.au>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 06:54:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 04:54:42 +0000
    Subject: [Koha-bugs] [Bug 29744] Harmonize psgi/plack detection methods
    In-Reply-To: <bug-29744-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29744-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29744-70-rcQ0o8EoC1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744
    
    --- Comment #6 from David Cook <dcook at prosentient.com.au> ---
    (In reply to Fridolin Somers from comment #5)
    > I cant get this working.
    > With Bug 29420 and this one I get directly the error :
    > 
    > psgi:exit at /kohadevbox/koha/C4/Auth.pm line 59
    >        59:     if   (C4::Context::psgi_env) { die 'psgi:exit' }
    > 
    > I tried to remove manually the session cookie but same problem.
    
    I just applied bug 29420 and bug 29744 to master, ran "koha-plack --restart
    kohadev", and navigated through both the OPAC and staff interface with no
    problems.
    
    However, when I logged out of the Staff Interface, I encountered the same
    problem as Fridolin (as the logout code calls C4::Auth's safe_exit function).
    
    I'll do a little bit of troubleshooting on this, but I think the answer is to
    not change the BEGIN block in this bug report, since it's really a secondary
    change that doesn't really relate to the majority of what this bug report is
    trying to accomplish...
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 07:16:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 05:16:12 +0000
    Subject: [Koha-bugs] [Bug 29744] Harmonize psgi/plack detection methods
    In-Reply-To: <bug-29744-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29744-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29744-70-fuRnjtE1Oo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744
    
    --- Comment #7 from David Cook <dcook at prosentient.com.au> ---
    Comment on attachment 132975
      --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132975
    Bug 29744: Harmonize psgi/plack detection methods
    
    Review of attachment 132975:
     --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=29744&attachment=132975)
    -----------------------------------------------------------------
    
    ::: C4/Auth.pm
    @@ +56,3 @@
    >  
    > +sub safe_exit {
    > +    if   (C4::Context::psgi_env) { die 'psgi:exit' }
    
    Ok, so the problem here isn't the BEGIN block, but rather that the old
    psgi_env() checked only for "psgi." keys whereas the new C4::Context::psgi_env
    checks for "psgi." keys or "plack." keys.
    
    This is significant because CGI::Emulate::PSGI (which runs our CGI scripts as
    PSGI functions) removes all "psgi." keys from the environment:
    https://metacpan.org/dist/CGI-Emulate-PSGI/source/lib/CGI/Emulate/PSGI.pm#L53
    
    That's why to detect Plack/PSGI in Koha we have to look for those "plack."
    variables like plack.file.SCRIPT_NAME and plack.file.PATH_INFO, which are added
    by Plack::App::File (via Plack::App::CGIBin.
    
    It's fine for us to "exit" because CGI::Compile (used in Plack::App::WrapCGI)
    redefines "exit" for us automatically.
    
    Since we only seem to use C4::Auth::safe_exit in a CGI context, we don't
    actually need this PSGI detection at all here.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 07:21:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 05:21:11 +0000
    Subject: [Koha-bugs] [Bug 29744] Harmonize psgi/plack detection methods
    In-Reply-To: <bug-29744-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29744-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29744-70-2oJksMeRzU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744
    
    --- Comment #8 from David Cook <dcook at prosentient.com.au> ---
    (In reply to David Cook from comment #7)
    > Since we only seem to use C4::Auth::safe_exit in a CGI context, we don't
    > actually need this PSGI detection at all here.
    
    Tracked the origin of this back to 
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630#c10
    
    https://lists.koha-community.org/pipermail/koha-patches/2011-March/014376.html
    
    It looks like antique code that probably hasn't done anything useful for many
    years.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 07:23:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 05:23:26 +0000
    Subject: [Koha-bugs] [Bug 29744] Harmonize psgi/plack detection methods
    In-Reply-To: <bug-29744-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29744-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29744-70-D9laz64eNR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744
    
    --- Comment #9 from David Cook <dcook at prosentient.com.au> ---
    (In reply to David Cook from comment #8)
    > It looks like antique code that probably hasn't done anything useful for
    > many years.
    
    This is made all the more obvious by the usage of "exit" all over our CGI code
    and our very slim usage of "safe_exit" (limited only to C4::Auth).
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 07:28:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 05:28:40 +0000
    Subject: [Koha-bugs] [Bug 29744] Harmonize psgi/plack detection methods
    In-Reply-To: <bug-29744-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29744-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29744-70-A3pkU7V581@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 07:28:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 05:28:44 +0000
    Subject: [Koha-bugs] [Bug 29744] Harmonize psgi/plack detection methods
    In-Reply-To: <bug-29744-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29744-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29744-70-dLUiNVP7Kv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132975|0                           |1
            is obsolete|                            |
    
    --- Comment #10 from David Cook <dcook at prosentient.com.au> ---
    Created attachment 133429
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133429&action=edit
    Bug 29744: Harmonize psgi/plack detection methods
    
    This patch updates and moves the existing psgi_env method out of Auth
    and into Context and then replaces any manual references of the same
    code to use the new method.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: David Cook <dcook at prosentient.com.au>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 07:28:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 05:28:48 +0000
    Subject: [Koha-bugs] [Bug 29744] Harmonize psgi/plack detection methods
    In-Reply-To: <bug-29744-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29744-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29744-70-N4wchEIHA7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744
    
    --- Comment #11 from David Cook <dcook at prosentient.com.au> ---
    Created attachment 133430
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133430&action=edit
    Bug 29744: Remove unnecessary condition in C4::Auth::safe_exit
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 07:29:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 05:29:21 +0000
    Subject: [Koha-bugs] [Bug 29744] Harmonize psgi/plack detection methods
    In-Reply-To: <bug-29744-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29744-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29744-70-upBwgvFvKk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744
    
    --- Comment #12 from David Cook <dcook at prosentient.com.au> ---
    I've signed off Martin's patch, added my own to fix the issue Frido found, and
    moved back to Needs Signoff.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 09:23:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 07:23:39 +0000
    Subject: [Koha-bugs] [Bug 25815] SIP Checkout: add more information on why
     the patron is blocked
    In-Reply-To: <bug-25815-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25815-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25815-70-XhrXxKd5sQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 09:23:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 07:23:42 +0000
    Subject: [Koha-bugs] [Bug 25815] SIP Checkout: add more information on why
     the patron is blocked
    In-Reply-To: <bug-25815-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25815-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25815-70-IJZJ0lWtkK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815
    
    --- Comment #10 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 09:23:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 07:23:45 +0000
    Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor
     performance for records with many items
    In-Reply-To: <bug-29483-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29483-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29483-70-oMAtA49xET@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 09:23:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 07:23:47 +0000
    Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor
     performance for records with many items
    In-Reply-To: <bug-29483-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29483-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29483-70-D10STWcvKk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483
    
    --- Comment #30 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 09:23:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 07:23:50 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-9A1WATSDvl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 09:23:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 07:23:52 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-ShfWhMXdyh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    --- Comment #91 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 09:23:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 07:23:55 +0000
    Subject: [Koha-bugs] [Bug 30223] Move book cover image upload JS to a
     separate file
    In-Reply-To: <bug-30223-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30223-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30223-70-rgxuyAK1CH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30223
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 09:23:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 07:23:57 +0000
    Subject: [Koha-bugs] [Bug 30223] Move book cover image upload JS to a
     separate file
    In-Reply-To: <bug-30223-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30223-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30223-70-nsY7qIG0EV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30223
    
    --- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 09:24:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 07:24:00 +0000
    Subject: [Koha-bugs] [Bug 30435] Remove unused MACLES cataloging plugin
    In-Reply-To: <bug-30435-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30435-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30435-70-ekb5ZsAPlE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30435
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 09:24:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 07:24:03 +0000
    Subject: [Koha-bugs] [Bug 30435] Remove unused MACLES cataloging plugin
    In-Reply-To: <bug-30435-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30435-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30435-70-OkaCut0Pk9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30435
    
    --- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 09:24:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 07:24:08 +0000
    Subject: [Koha-bugs] [Bug 30488] Error when placing a recall in the OPAC
    In-Reply-To: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30488-70-is4JkMkTcX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 09:24:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 07:24:11 +0000
    Subject: [Koha-bugs] [Bug 30488] Error when placing a recall in the OPAC
    In-Reply-To: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30488-70-aHVdOFz3g3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488
    
    --- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 09:24:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 07:24:16 +0000
    Subject: [Koha-bugs] [Bug 30509] Accordion on letter.tt is broken
    In-Reply-To: <bug-30509-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30509-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30509-70-rIzbkKNHIp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30509
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 09:24:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 07:24:18 +0000
    Subject: [Koha-bugs] [Bug 30509] Accordion on letter.tt is broken
    In-Reply-To: <bug-30509-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30509-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30509-70-6QYOFNIZ9j@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30509
    
    --- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 09:24:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 07:24:21 +0000
    Subject: [Koha-bugs] [Bug 30518] StockRotationItems crossing DST boundary
     throw invalid local time exception
    In-Reply-To: <bug-30518-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30518-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30518-70-v27WbO7GNr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30518
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 09:24:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 07:24:24 +0000
    Subject: [Koha-bugs] [Bug 30518] StockRotationItems crossing DST boundary
     throw invalid local time exception
    In-Reply-To: <bug-30518-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30518-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30518-70-YS4NYA1VQQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30518
    
    --- Comment #6 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 09:24:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 07:24:27 +0000
    Subject: [Koha-bugs] [Bug 30540] Double processing invalid dates can lead to
     ISE
    In-Reply-To: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30540-70-s34vTmoDbl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30540
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 09:24:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 07:24:30 +0000
    Subject: [Koha-bugs] [Bug 30540] Double processing invalid dates can lead to
     ISE
    In-Reply-To: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30540-70-y3TlkgeHGY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30540
    
    --- Comment #11 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 09:27:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 07:27:46 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-HIwwk5K8h4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    --- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133431
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133431&action=edit
    Bug 21978: Add middle_name field to the database
    
    This patch adds a new field, middle_name, to the borrowers,
    deletedborrowers and borrower_modifications tables.
    
    It also updates the DefaultPatronSearchFields preference to include the
    new field if the preference is still set to it's default settings from
    install.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 09:27:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 07:27:51 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-SgkYJZGnGh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133432
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133432&action=edit
    Bug 21978: Add middle_name to api specification
    
    This patch adds middle_name to the accaeptable fields in API requests
    and responses.
    
    Test plan
    1) Search for a user using the API
    2) Confirm the API responds with a 200
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 09:27:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 07:27:56 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-Da4v7uwaaP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133433
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133433&action=edit
    Bug 21978: Add support for middle name
    
    This patch adds the new 'Middle name' field to the patron record.
    
    To test:
    1) Apply patches
    2) Update database, restart all and clear the browser cache
    3) Load a patron in the staff module
    4) Confirm you can see and edit the new 'Middle name' field
    5) Confirm the new middle name data displays on patron details
    6) Confirm the new middle name data displays on patron search results
    7) Confirm the new middle name data displays everywhere patron names are
       displayed.
    8) Confirm the new middle name data displays on the OPAC
    9) Confirm the 'Middle name' field appears in the OPAC borrower
       modification screens
    10) Edit syspref BorrowerMandatoryFields and BorrowerUnwantedFields to
        confirm you can make the new field required or hidden
    11) Verify that DefaultPatronSearchFields contains the new field if you
        already had 'firstname' in the field list
    12) Enable PatronAutoComplete system preference
    13) Type patrons surname into checkout or patron search but don't hit
        return
    14) Confirm the patrons middle name is displayed in the preview
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 09:28:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 07:28:01 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-HdafqvckT2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    --- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133434
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133434&action=edit
    Bug 21978: Schema Update
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 09:33:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 07:33:38 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-vpSYyIFMtC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133431|0                           |1
            is obsolete|                            |
    
    --- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133435
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133435&action=edit
    Bug 21978: Add middle_name field to the database
    
    This patch adds a new field, middle_name, to the borrowers,
    deletedborrowers and borrower_modifications tables.
    
    It also updates the DefaultPatronSearchFields preference to include the
    new field if the preference is still set to it's default settings from
    install.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 09:33:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 07:33:43 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-K1Hyzc24lg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133432|0                           |1
            is obsolete|                            |
    
    --- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133436
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133436&action=edit
    Bug 21978: Add middle_name to api specification
    
    This patch adds middle_name to the accaeptable fields in API requests
    and responses.
    
    Test plan
    1) Search for a user using the API
    2) Confirm the API responds with a 200
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 09:33:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 07:33:48 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-SuiXIwbbSG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133433|0                           |1
            is obsolete|                            |
    
    --- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133437
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133437&action=edit
    Bug 21978: Add support for middle name
    
    This patch adds the new 'Middle name' field to the patron record.
    
    To test:
    1) Apply patches
    2) Update database, restart all and clear the browser cache
    3) Load a patron in the staff module
    4) Confirm you can see and edit the new 'Middle name' field
    5) Confirm the new middle name data displays on patron details
    6) Confirm the new middle name data displays on patron search results
    7) Confirm the new middle name data displays everywhere patron names are
       displayed.
    8) Confirm the new middle name data displays on the OPAC
    9) Confirm the 'Middle name' field appears in the OPAC borrower
       modification screens
    10) Edit syspref BorrowerMandatoryFields and BorrowerUnwantedFields to
        confirm you can make the new field required or hidden
    11) Verify that DefaultPatronSearchFields contains the new field if you
        already had 'firstname' in the field list
    12) Enable PatronAutoComplete system preference
    13) Type patrons surname into checkout or patron search but don't hit
        return
    14) Confirm the patrons middle name is displayed in the preview
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 09:33:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 07:33:53 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-aXGZ4mAPe8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133434|0                           |1
            is obsolete|                            |
    
    --- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133438
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133438&action=edit
    Bug 21978: Schema Update
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 09:35:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 07:35:09 +0000
    Subject: [Koha-bugs] [Bug 28943] Lower the risk of accidental patron
     deletion by cleanup_database.pl
    In-Reply-To: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28943-70-xatiPE7uFs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28943
    
    Chris Cormack <chris at bigballofwax.co.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to oldoldstable      |Pushed to oldoldoldstable
                     CC|                            |chris at bigballofwax.co.nz
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 10:32:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 08:32:59 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-32w0j01Tzv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 10:43:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 08:43:35 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-WAyXt6Vh5C@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    --- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    I've stuck to the basics here to get the ball rolling and I want to open a new
    bug for allowing for more fine-grained control over display and search ordering
    and things... there's some great idea's above around that so I'll copy those in
    to the new bug too.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 10:47:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 08:47:42 +0000
    Subject: [Koha-bugs] [Bug 30568] New: Make patron name fields more flexible
    Message-ID: <bug-30568-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568
    
                Bug ID: 30568
               Summary: Make patron name fields more flexible
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Patrons
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: martin.renvoize at ptfs-europe.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
    
    We've had a number of bugs around patron name fields..
    
    * Requests for additional fields
    * Requests for changes in display order
    * Requests for improved duplicate finding
    * Requests for improved table sorting
    
    I intend to collect opinions here and try to come up with a solution that suits
    more options.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 11:01:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 09:01:25 +0000
    Subject: [Koha-bugs] [Bug 30568] Make patron name fields more flexible
    In-Reply-To: <bug-30568-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30568-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30568-70-xzSvHQoXMG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568
    
    --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    In bug 21978 comment 9 Christopher Brannon suggests
    
    >What if we could just get away from the name structures, and have 5 or 6 generic >name fields (i.e. Name1, Name2, Name3 etc.), and we can label them in the editor >for whatever purpose we need, and on screens they appear in the order that they >are used.  For example, Name1 is used as Surname, Name2 is First Name, Name3 is >Middle Name, and so on.  Sort will always sort in order of the fields (Name1 >first, Name2 next, and so on), and would display similar to how they appear now:
    >
    >In results:
    >Name1, Name2 [Name3] [Name4] [Name5] [Name6]
    >
    >On patron account:
    >Name2 [Name3] [Name4] [Name5] [Name6] Name1
    >
    
    I think this approach could work well, but it needs a little thought as to how
    it would work with de-duplicating and sorting and we may still need to
    implement display templating on top as currently you can call the patron-title
    include with various options for different displays in different places.
    
    I wonder if we could refine our display to a couple of more formal options..
    'short' and 'long' form perhaps.. right now we have various combinations of
    options in the template.. like including title or not, othernames, inverse
    ordering, cardnumber, linking.. etc etc
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 11:09:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 09:09:13 +0000
    Subject: [Koha-bugs] [Bug 30568] Make patron name fields more flexible
    In-Reply-To: <bug-30568-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30568-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30568-70-s1hqYVsWYE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=28633
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 11:09:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 09:09:13 +0000
    Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
     effective_name method to patrons
    In-Reply-To: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28633-70-bzZhsbsUoa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30568
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 11:09:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 09:09:24 +0000
    Subject: [Koha-bugs] [Bug 30568] Make patron name fields more flexible
    In-Reply-To: <bug-30568-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30568-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30568-70-Efd9BU0awc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=26146
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 11:09:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 09:09:24 +0000
    Subject: [Koha-bugs] [Bug 26146] Patron duplicate matching - fuzzy matching?
    In-Reply-To: <bug-26146-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26146-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26146-70-I3aKohl3uD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26146
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30568
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 11:09:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 09:09:34 +0000
    Subject: [Koha-bugs] [Bug 30568] Make patron name fields more flexible
    In-Reply-To: <bug-30568-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30568-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30568-70-g8741Mj9o8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=21978
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 11:09:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 09:09:34 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-mk6RRZ4EsI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30568
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 11:17:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 09:17:23 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-QLoslP2RvR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Sally <sally.healey at cheshiresharedservices.gov.uk> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Patch doesn't apply
    
    --- Comment #28 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
    Sorry, Martin - patch doesn't apply with the following message:
    
    Applying: Bug 21978: Add support for middle name
    .git/rebase-apply/patch:75: trailing whitespace.
    
    .git/rebase-apply/patch:155: trailing whitespace.
        [%- ELSE %] 
    warning: 2 lines add whitespace errors.
    Using index info to reconstruct a base tree...
    M       koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc
    M       koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
    M       koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
    .git/rebase-apply/patch:75: trailing whitespace.
    
    .git/rebase-apply/patch:155: trailing whitespace.
        [%- ELSE %] 
    warning: 2 lines applied after fixing whitespace errors.
    Falling back to patching base and 3-way merge...
    Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
    Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
    Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc
    CONFLICT (content): Merge conflict in
    koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc
    error: Failed to merge in the changes.
    Patch failed at 0001 Bug 21978: Add support for middle name
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 11:26:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 09:26:30 +0000
    Subject: [Koha-bugs] [Bug 30568] Make patron name fields more flexible
    In-Reply-To: <bug-30568-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30568-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30568-70-ZqQd4ixx8t@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568
    
    --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    patron-title.inc currently allows for the following output formats
    
    * surname (othernames)
    * <span class="patron-title">title</span> surname, firstname (othernames) 
    * <span class="patron-title">title</span> firtname (othernames) surname
    * title surname, firstname (othernames)
    * title firstname (othernames) surname
    * surname (othernames) (cardnumber)
    * <span class="patron-title">title</span> surname, firstname (othernames)
    (cardnumber)
    * <span class="patron-title">title</span> firtname (othernames) surname
    (cardnumber)
    * title surname, firstname (othernames) (cardnumber)
    * title firstname (othernames) surname (cardnumber)
    * cardnumber
    * <span>A patron from library [% Branches.GetName( patron.branchcode ) | html
    -%]</span>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 11:44:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 09:44:26 +0000
    Subject: [Koha-bugs] [Bug 30569] New: mana_enabled gets set incorrectly
    Message-ID: <bug-30569-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30569
    
                Bug ID: 30569
               Summary: mana_enabled gets set incorrectly
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Mana-kb
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: sebastian at imcode.com
                    CC: alex.arnaud at biblibre.com
    
    In
    /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/sv-SE/modules/serials/subscription-add.tt:509
    
    This row:
    var mana_enabled = [% IF (Koha.Preference('Mana') == 1 && mana_url) %]1[% ELSE
    %][% END %];
    
    Should be:
    var mana_enabled = [% IF (Koha.Preference('Mana') == 1 && mana_url) %]1[% ELSE
    %]0[% END %];
    
    like it is in the english version.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:16:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:16:19 +0000
    Subject: [Koha-bugs] [Bug 24633] Add support for gitlab searching of plugins
    In-Reply-To: <bug-24633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24633-70-8iSevxh17v@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24633
    
    --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133439
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133439&action=edit
    Bug 28633: DB update
    
    This adds the field to necessary tables and updates API and columns def
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:16:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:16:23 +0000
    Subject: [Koha-bugs] [Bug 24633] Add support for gitlab searching of plugins
    In-Reply-To: <bug-24633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24633-70-7jq3sutHd4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24633
    
    --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133440
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133440&action=edit
    Bug 28633: Add preferred name field to patrons
    
    This patch adds a new field 'preferred_name' to the patron record.
    
    Additionally it adds a method 'effective_name' to choose the preferred name if
    present
    and fall back to firstname
    
    The 'firstname' is displayed as 'First name' on the details page, with id/class
    patron_first_name to allow ajusting via JS/CSS if library wants to
    highlight/hide
    the non-preferred name
    
    PatronAutoComplete/ysearch is updated to use 'effective_name' method
    
    To test:
     1 - Apply patches
     2 - Update database and restart all, clear browser cache
     3 - Load a patron in staff module
     4 - Confirm you see and can add a preferred name
     5 - Confirm the preferred name and first name now displays on patron details
     6 - Remove first name from patron record and confirm it no longer shows
     7 - Edit sysprefs BorrowerMandatoryFields and BorrowerUnwantedFields to
    confirm you can make
         new field required or hidden
     8 - Sign in as patron to opac
     9 - Confirm preferred name shows
    10 - Edit account on opac and confirm field is present
    11 - Verify DefaultPatronSearchFields contains 'preferredname' if your pref had
    firstname
    12 - Perform checkout and patron search using preferred_name, confirm patron is
    found
    13 - Enable PatronAutoComplete system preference
    14 - Type patron's surname into Checkout or patron search but don't hit enter
    15 - Confirm patron is displayed with 'preferred_name' in the preview
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:16:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:16:28 +0000
    Subject: [Koha-bugs] [Bug 24633] Add support for gitlab searching of plugins
    In-Reply-To: <bug-24633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24633-70-bQLYAA8AYJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24633
    
    --- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133441
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133441&action=edit
    Bug 28633: (follow-up) Account for bug 29695 changes
    
    During rebase of this patchset we drop the columns.def and
    borrowers.json changes introduced.
    
    We store this mapping in the module now, so this patch does
    that.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:16:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:16:33 +0000
    Subject: [Koha-bugs] [Bug 24633] Add support for gitlab searching of plugins
    In-Reply-To: <bug-24633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24633-70-HDEiY6HE1r@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24633
    
    --- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133442
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133442&action=edit
    Bug 28633: (follow-up) Account for changes with bug 30063
    
    Bug 30063 removes the C4/Utils/DataTables/Members.pm module and instead
    uses the API and a patron-search include to define the default search
    fields. This follow-up adds preferred_name into the default fields in
    that include now the the module has been removed
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:16:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:16:37 +0000
    Subject: [Koha-bugs] [Bug 24633] Add support for gitlab searching of plugins
    In-Reply-To: <bug-24633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24633-70-0ExNcPqrg5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24633
    
    --- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133443
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133443&action=edit
    Bug 28633: DO NOT PUSH Schema Changes
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:16:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:16:41 +0000
    Subject: [Koha-bugs] [Bug 24633] Add support for gitlab searching of plugins
    In-Reply-To: <bug-24633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24633-70-DS0qkdzzd2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24633
    
    --- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133444
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133444&action=edit
    Bug 28633: (QA follow-up) Add preferred_name to ysearch
    
    This adds preferred_name to the search fields in the autocomplete search
    system.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:18:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:18:44 +0000
    Subject: [Koha-bugs] [Bug 24633] Add support for gitlab searching of plugins
    In-Reply-To: <bug-24633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24633-70-aRd1YeCJIe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24633
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133439|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:18:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:18:55 +0000
    Subject: [Koha-bugs] [Bug 24633] Add support for gitlab searching of plugins
    In-Reply-To: <bug-24633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24633-70-uxQuZJ46Ra@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24633
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133440|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:19:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:19:04 +0000
    Subject: [Koha-bugs] [Bug 24633] Add support for gitlab searching of plugins
    In-Reply-To: <bug-24633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24633-70-D08TczSLUx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24633
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133441|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:19:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:19:15 +0000
    Subject: [Koha-bugs] [Bug 24633] Add support for gitlab searching of plugins
    In-Reply-To: <bug-24633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24633-70-FpuuzhXmcY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24633
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133442|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:19:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:19:25 +0000
    Subject: [Koha-bugs] [Bug 24633] Add support for gitlab searching of plugins
    In-Reply-To: <bug-24633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24633-70-l5koxa92fd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24633
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133443|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:19:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:19:35 +0000
    Subject: [Koha-bugs] [Bug 24633] Add support for gitlab searching of plugins
    In-Reply-To: <bug-24633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24633-70-dT5kNqrJje@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24633
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133444|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:20:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:20:08 +0000
    Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
     effective_name method to patrons
    In-Reply-To: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28633-70-o0P9M76CQh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #130000|0                           |1
            is obsolete|                            |
    
    --- Comment #31 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133445
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133445&action=edit
    Bug 28633: DB update
    
    This adds the field to necessary tables and updates API and columns def
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:20:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:20:13 +0000
    Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
     effective_name method to patrons
    In-Reply-To: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28633-70-3oXAKDAQ9U@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #130001|0                           |1
            is obsolete|                            |
    
    --- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133446
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133446&action=edit
    Bug 28633: Add preferred name field to patrons
    
    This patch adds a new field 'preferred_name' to the patron record.
    
    Additionally it adds a method 'effective_name' to choose the preferred name if
    present
    and fall back to firstname
    
    The 'firstname' is displayed as 'First name' on the details page, with id/class
    patron_first_name to allow ajusting via JS/CSS if library wants to
    highlight/hide
    the non-preferred name
    
    PatronAutoComplete/ysearch is updated to use 'effective_name' method
    
    To test:
     1 - Apply patches
     2 - Update database and restart all, clear browser cache
     3 - Load a patron in staff module
     4 - Confirm you see and can add a preferred name
     5 - Confirm the preferred name and first name now displays on patron details
     6 - Remove first name from patron record and confirm it no longer shows
     7 - Edit sysprefs BorrowerMandatoryFields and BorrowerUnwantedFields to
    confirm you can make
         new field required or hidden
     8 - Sign in as patron to opac
     9 - Confirm preferred name shows
    10 - Edit account on opac and confirm field is present
    11 - Verify DefaultPatronSearchFields contains 'preferredname' if your pref had
    firstname
    12 - Perform checkout and patron search using preferred_name, confirm patron is
    found
    13 - Enable PatronAutoComplete system preference
    14 - Type patron's surname into Checkout or patron search but don't hit enter
    15 - Confirm patron is displayed with 'preferred_name' in the preview
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:20:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:20:18 +0000
    Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
     effective_name method to patrons
    In-Reply-To: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28633-70-eRRiipksZF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633
    
    --- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133447
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133447&action=edit
    Bug 28633: (follow-up) Account for bug 29695 changes
    
    During rebase of this patchset we drop the columns.def and
    borrowers.json changes introduced.
    
    We store this mapping in the module now, so this patch does
    that.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:20:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:20:23 +0000
    Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
     effective_name method to patrons
    In-Reply-To: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28633-70-kGwfKwE776@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633
    
    --- Comment #34 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133448
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133448&action=edit
    Bug 28633: (follow-up) Account for changes with bug 30063
    
    Bug 30063 removes the C4/Utils/DataTables/Members.pm module and instead
    uses the API and a patron-search include to define the default search
    fields. This follow-up adds preferred_name into the default fields in
    that include now the the module has been removed
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:20:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:20:28 +0000
    Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
     effective_name method to patrons
    In-Reply-To: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28633-70-dqjkVlZ3VY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #130002|0                           |1
            is obsolete|                            |
    
    --- Comment #35 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133449
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133449&action=edit
    Bug 28633: DO NOT PUSH Schema Changes
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:20:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:20:33 +0000
    Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
     effective_name method to patrons
    In-Reply-To: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28633-70-Fvtk5jV3xF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633
    
    --- Comment #36 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133450
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133450&action=edit
    Bug 28633: (QA follow-up) Add preferred_name to ysearch
    
    This adds preferred_name to the search fields in the autocomplete search
    system.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:23:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:23:46 +0000
    Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
     effective_name method to patrons
    In-Reply-To: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28633-70-4wo16k8AsS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Signed Off
    
    --- Comment #37 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    This is mostly a rebase taking into account bug 29695 and bug 30063.  I also
    added a QA follow-up to allow searching on the preferred name in the
    autocomplete searches.
    
    I'm not entirely sure about the complete replacement of firstname with
    preferred_name everywhere.. it can lead to confusion in a few places as Katrin
    suggests... with the discussion on bug 21978 which lead to me opening bug 30568
    I think this could play a bigger part here too.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:38:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:38:33 +0000
    Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
     effective_name method to patrons
    In-Reply-To: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28633-70-wrwjkpUdda@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633
    
    --- Comment #38 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133451
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133451&action=edit
    Bug 28633: (follow-up) Display effective name in JS search
    
    Also I fix the other header  search, and ensure the 'Standard' option wil
    appear in dropdowns
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:42:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:42:57 +0000
    Subject: [Koha-bugs] [Bug 30405] Style of address in patron search result
     are 110%
    In-Reply-To: <bug-30405-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30405-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30405-70-T3yxjXKmcM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30405
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Trivial patch
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:43:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:43:01 +0000
    Subject: [Koha-bugs] [Bug 30405] Style of address in patron search result
     are 110%
    In-Reply-To: <bug-30405-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30405-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30405-70-ixReUxMCPP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30405
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133105|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133452
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133452&action=edit
    Bug 30405: Reduce font-size for address in patron search result
    
    The address has a font-size: 110%, it's not needed here, 100% is enough.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:43:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:43:19 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-xGEOqVJNFC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133435|0                           |1
            is obsolete|                            |
    
    --- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133453
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133453&action=edit
    Bug 21978: Add middle_name field to the database
    
    This patch adds a new field, middle_name, to the borrowers,
    deletedborrowers and borrower_modifications tables.
    
    It also updates the DefaultPatronSearchFields preference to include the
    new field if the preference is still set to it's default settings from
    install.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:43:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:43:24 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-SpcXlZYeF1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133436|0                           |1
            is obsolete|                            |
    
    --- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133454
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133454&action=edit
    Bug 21978: Add middle_name to api specification
    
    This patch adds middle_name to the accaeptable fields in API requests
    and responses.
    
    Test plan
    1) Search for a user using the API
    2) Confirm the API responds with a 200
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:43:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:43:29 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-i4jXzpe85f@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133437|0                           |1
            is obsolete|                            |
    
    --- Comment #31 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133455
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133455&action=edit
    Bug 21978: Add support for middle name
    
    This patch adds the new 'Middle name' field to the patron record.
    
    To test:
    1) Apply patches
    2) Update database, restart all and clear the browser cache
    3) Load a patron in the staff module
    4) Confirm you can see and edit the new 'Middle name' field
    5) Confirm the new middle name data displays on patron details
    6) Confirm the new middle name data displays on patron search results
    7) Confirm the new middle name data displays everywhere patron names are
       displayed.
    8) Confirm the new middle name data displays on the OPAC
    9) Confirm the 'Middle name' field appears in the OPAC borrower
       modification screens
    10) Edit syspref BorrowerMandatoryFields and BorrowerUnwantedFields to
        confirm you can make the new field required or hidden
    11) Verify that DefaultPatronSearchFields contains the new field if you
        already had 'firstname' in the field list
    12) Enable PatronAutoComplete system preference
    13) Type patrons surname into checkout or patron search but don't hit
        return
    14) Confirm the patrons middle name is displayed in the preview
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:43:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:43:34 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-56hHOOI9hA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133438|0                           |1
            is obsolete|                            |
    
    --- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133456
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133456&action=edit
    Bug 21978: Schema Update
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:44:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:44:50 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-yMiMOnb8cN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Patch doesn't apply         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:45:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:45:19 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-e9X04XN1CI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    --- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Ooop.. master moved.. rebased for you Sally.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 12:46:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 10:46:06 +0000
    Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
     effective_name method to patrons
    In-Reply-To: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28633-70-H8Cul1XUUq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633
    
    --- Comment #39 from Nick Clemens <nick at bywatersolutions.com> ---
    (In reply to Katrin Fischer from comment #30)
    > 1) Tiny typo
    > +    description: patron's preferred named
    
    I am not sure where you are referring to
    
    > 2) Patron search results
    > 
    > In patron search results I still see the "firstname" instead of the
    > "preferred name". 
    
    Fixed
    
    > 
    > This seems a little confusing, as this is the only place now showing the
    > firstname. On the other hand, if someone presents an ID and I want to search
    > forthem, I will need to make the connection. Maybe we could display the
    > preferred name additionally to the firstname somehow?
    
    Preferred name is meant to be stronger than 'othernames' - it is how the patron
    wants to be addressed - I think in the case where there is a difference with an
    ID they will tell you which name to expect
    
    > 3) Auto-complete for patrons
    > 
    > When I type "Cait" the entry doesn't show, only when I type "Katrin". But in
    > the preview, it shows 'Cait' ... So there is a mismatch with what you need
    > to type and what will show.
    
    Martin fixed this
    
    > I am not sure how to resolve this, but maybe you have an idea or can explain
    > reasoning?
    
    As above, the idea is that a preferred name is intended to the name a patron
    wants to be called. It is the case where the patron is not using their first
    name, but may still legally have that name. If a patron is using a nickname,
    that would be 'othernames'
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 13:40:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 11:40:24 +0000
    Subject: [Koha-bugs] [Bug 30565] Field stockrotationrotas.description should
     be NOT NULL, title UNIQUE
    In-Reply-To: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30565-70-AS47FRIzAQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30565
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 13:40:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 11:40:28 +0000
    Subject: [Koha-bugs] [Bug 30565] Field stockrotationrotas.description should
     be NOT NULL, title UNIQUE
    In-Reply-To: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30565-70-zzFSUxcVv8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30565
    
    --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133457
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133457&action=edit
    Bug 30565: Correct kohastructure
    
    The unique key was added in a dbrev and is referred to in code.
    But forgotten in kohastructure.
    
    Test plan:
    Run new install or kohastructure.sql on empty db.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 13:40:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 11:40:32 +0000
    Subject: [Koha-bugs] [Bug 30565] Field stockrotationrotas.description should
     be NOT NULL, title UNIQUE
    In-Reply-To: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30565-70-ZsSuf4nmeX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30565
    
    --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133458
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133458&action=edit
    Bug 30565: Database revision for stockrotationrotas
    
    Add unique key if needed.
    Adjust description column to make it NOT NULL.
    
    Test plan:
    (Optionally:) Drop unique key, make description nullable.
    Run dbrev.
    Check if unique key present, and description not-nullable.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 13:40:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 11:40:37 +0000
    Subject: [Koha-bugs] [Bug 30565] Field stockrotationrotas.description should
     be NOT NULL, title UNIQUE
    In-Reply-To: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30565-70-LWJjJIGPzY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30565
    
    --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133459
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133459&action=edit
    Bug 30565: DBIx schema change for stockrotationrotas
    
    No test plan.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 13:40:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 11:40:48 +0000
    Subject: [Koha-bugs] [Bug 30565] Field stockrotationrotas.description should
     be NOT NULL, title UNIQUE
    In-Reply-To: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30565-70-iuNv2uxejH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30565
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                       |ity.org                     |
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 13:44:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 11:44:19 +0000
    Subject: [Koha-bugs] [Bug 30565] Field stockrotationrotas.description should
     be NOT NULL, description UNIQUE
    In-Reply-To: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30565-70-zWy9dBuiCN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30565
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Field                       |Field
                       |stockrotationrotas.descript |stockrotationrotas.descript
                       |ion should be NOT NULL,     |ion should be NOT NULL,
                       |title UNIQUE                |description UNIQUE
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 13:44:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 11:44:35 +0000
    Subject: [Koha-bugs] [Bug 30565] Field stockrotationrotas.description should
     be NOT NULL, title UNIQUE
    In-Reply-To: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30565-70-2oHTd4kkuI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30565
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Field                       |Field
                       |stockrotationrotas.descript |stockrotationrotas.descript
                       |ion should be NOT NULL,     |ion should be NOT NULL,
                       |description UNIQUE          |title UNIQUE
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 13:46:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 11:46:53 +0000
    Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
     effective_name method to patrons
    In-Reply-To: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28633-70-N07pLlAJfQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633
    
    --- Comment #40 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    (In reply to Nick Clemens from comment #39)
    > (In reply to Katrin Fischer from comment #30)
    > > 1) Tiny typo
    > > +    description: patron's preferred named
    > 
    > I am not sure where you are referring to
    
    I fixed it inline 'named -> name'
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 13:47:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 11:47:20 +0000
    Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on
     fresh install, but can be null with upgrade
    In-Reply-To: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27253-70-j18Btq8WTR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 13:49:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 11:49:14 +0000
    Subject: [Koha-bugs] [Bug 30491] Convert saved reports tabs to Bootstrap
    In-Reply-To: <bug-30491-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30491-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30491-70-q6FExrx4wL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30491
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30532
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30532
    [Bug 30532] guided_reports.pl has a problem
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 13:49:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 11:49:14 +0000
    Subject: [Koha-bugs] [Bug 30532] guided_reports.pl has a problem
    In-Reply-To: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30532-70-XQbxL46tRU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30532
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30491
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30491
    [Bug 30491] Convert saved reports tabs to Bootstrap
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 13:50:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 11:50:14 +0000
    Subject: [Koha-bugs] [Bug 30532] guided_reports.pl has a problem
    In-Reply-To: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30532-70-uwycrklJj2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30532
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Severity|normal                      |critical
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:19:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:19:12 +0000
    Subject: [Koha-bugs] [Bug 30446] Add a test for GetTagsLabels
    In-Reply-To: <bug-30446-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30446-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30446-70-5OfcEWb2fC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30446
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |tomascohen at gmail.com
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:19:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:19:15 +0000
    Subject: [Koha-bugs] [Bug 30446] Add a test for GetTagsLabels
    In-Reply-To: <bug-30446-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30446-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30446-70-Ov2xdQ09JX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30446
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132932|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:19:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:19:45 +0000
    Subject: [Koha-bugs] [Bug 30446] Add a test for GetTagsLabels
    In-Reply-To: <bug-30446-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30446-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30446-70-zdG6soSj2p@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30446
    
    --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133460
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133460&action=edit
    Bug 30446: Add a test for GetTagsLabels
    
    Moved from obsoleted bug 2222 on its own.
    
    Test plan:
    Run t/db_dependent/AuthoritiesMarc_GetTagsLabels.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:19:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:19:51 +0000
    Subject: [Koha-bugs] [Bug 30446] Add a test for GetTagsLabels
    In-Reply-To: <bug-30446-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30446-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30446-70-eoo11hK8QS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30446
    
    --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133461
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133461&action=edit
    Bug 30446: (follow-up) Remove warning
    
    This patch removes a trivial warning caused by a parameter being
    compared to a literal but not being defined. Doing a
    
    $ git grep GetTagsLabels
    
    shows the change is safe as the function is always called with a value
    of either 0 or 1.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:20:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:20:49 +0000
    Subject: [Koha-bugs] [Bug 30108] Allow making hold dates required
    In-Reply-To: <bug-30108-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30108-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30108-70-Ul4XI1r6Ew@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                       |y.org                       |
                     CC|                            |tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:22:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:22:11 +0000
    Subject: [Koha-bugs] [Bug 29951] Cannot add splitting rule to classification
     sources
    In-Reply-To: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29951-70-GpuYvcyr4c@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29951
    
    MichaelaSieber <michaela.sieber at kit.edu> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |michaela.sieber at kit.edu
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:25:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:25:00 +0000
    Subject: [Koha-bugs] [Bug 30108] Allow making hold dates required
    In-Reply-To: <bug-30108-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30108-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30108-70-ZLzrlsyaFp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:25:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:25:04 +0000
    Subject: [Koha-bugs] [Bug 30108] Allow making hold dates required
    In-Reply-To: <bug-30108-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30108-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30108-70-V2cgDtNMkH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131376|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:25:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:25:08 +0000
    Subject: [Koha-bugs] [Bug 30108] Allow making hold dates required
    In-Reply-To: <bug-30108-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30108-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30108-70-cAZuQYyQAu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131377|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:25:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:25:11 +0000
    Subject: [Koha-bugs] [Bug 30108] Allow making hold dates required
    In-Reply-To: <bug-30108-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30108-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30108-70-hbrOMZOXyz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131378|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:25:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:25:15 +0000
    Subject: [Koha-bugs] [Bug 30108] Allow making hold dates required
    In-Reply-To: <bug-30108-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30108-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30108-70-63AAem7LMm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131379|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:25:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:25:19 +0000
    Subject: [Koha-bugs] [Bug 30446] Add a test for GetTagsLabels
    In-Reply-To: <bug-30446-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30446-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30446-70-VQRueaczFf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30446
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                       |y.org                       |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:25:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:25:40 +0000
    Subject: [Koha-bugs] [Bug 30108] Allow making hold dates required
    In-Reply-To: <bug-30108-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30108-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30108-70-ozFSqTqYE4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108
    
    --- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133462
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133462&action=edit
    Bug 30108: Database revision, adding new preference
    
    Test plan:
    Run upgrade or new install.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:25:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:25:46 +0000
    Subject: [Koha-bugs] [Bug 30108] Allow making hold dates required
    In-Reply-To: <bug-30108-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30108-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30108-70-7vK5Euwn3t@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108
    
    --- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133463
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133463&action=edit
    Bug 30108: Preference description
    
    Test plan:
    Check the preferences form, tab Circulation, tab Hold policy.
    Look for OPACMandatoryHoldDates.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:25:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:25:52 +0000
    Subject: [Koha-bugs] [Bug 30108] Allow making hold dates required
    In-Reply-To: <bug-30108-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30108-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30108-70-BtfFShBDYd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108
    
    --- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133464
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133464&action=edit
    Bug 30108: Allow making hold dates required
    
    Side note: Template still referred to class holddateto while not
    being used any longer. Replaced this occurrence by futuredate.
    
    Test plan:
    [1] Disable OPACAllowHoldDateInFuture.
    [2] Set pref OPACMandatoryHoldDates to "end date".
    [3] Verify that the end date is mandatory on opac-reserve.
    [4] Set pref OPACMandatoryHoldDates to "start date".
    [5] Verify that no dates are required.
    [6] Enable OPACAllowHoldDateInFuture.
    [7] Verify that start dates are required.
    [8] Set pref OPACMandatoryHoldDates to "no dates".
    [9] Verify that no dates are required again.
    
    Bonus:
    Check that more options box is opened when a date still is required.
    In case of item level being forced, verify that more options is opened
    regardless of pref setting.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:26:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:26:00 +0000
    Subject: [Koha-bugs] [Bug 30108] Allow making hold dates required
    In-Reply-To: <bug-30108-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30108-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30108-70-BXLKnQVmR9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108
    
    --- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133465
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133465&action=edit
    Bug 30108: (follow-up) Add required indication, differentiate alert
    
    As asked on comment4:
    [1] Add a required div as a visible hint when applicable.
    [2] Differentiate alert for hold start and end date.
    
    Test plan:
    See former patch.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:26:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:26:04 +0000
    Subject: [Koha-bugs] [Bug 30446] Add a test for GetTagsLabels
    In-Reply-To: <bug-30446-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30446-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30446-70-QniEbzLWLN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30446
    
    --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Tomás Cohen Arazi from comment #6)
    
    Thx
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:29:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:29:47 +0000
    Subject: [Koha-bugs] [Bug 22333] Replace duplicated code in CanBookBeRenewed
     with GetSoonestRenewDate
    In-Reply-To: <bug-22333-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22333-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22333-70-t2s8N6n6Va@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22333
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |DUPLICATE
                     CC|                            |nick at bywatersolutions.com
                 Status|Failed QA                   |RESOLVED
    
    --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
    I think this has been addressed elsewhere and can be closed
    
    *** This bug has been marked as a duplicate of bug 29474 ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:29:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:29:47 +0000
    Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on
     systems with large numbers of reserves
    In-Reply-To: <bug-29474-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29474-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29474-70-XnI4rm1KhU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
    
    --- Comment #54 from Nick Clemens <nick at bywatersolutions.com> ---
    *** Bug 22333 has been marked as a duplicate of this bug. ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:38:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:38:48 +0000
    Subject: [Koha-bugs] [Bug 29314] Move some OpenURL code to Koha::Biblio
    In-Reply-To: <bug-29314-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29314-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29314-70-HxZ7eeBgZE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29314
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Failed QA
                     CC|                            |tomascohen at gmail.com
    
    --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    I would like to know what the overall goal is. As I see it, we are making the
    callers need to pass the OpenURLResolverURL variable, instead of taking it for
    granted implicitly.
    
    I'm failing it because it makes some tests fail:
    
    t/db_dependent/Search.t ..........     # Looks like you planned 90 tests but
    ran 27.
    t/db_dependent/Search.t .......... 1/3 
    #   Failed test 'MARC21 + DOM'
    #   at t/db_dependent/Search.t line 906.
    Can't use an undefined value as a HASH reference at
    /kohadevbox/koha/C4/Search.pm line 1994.
    # Looks like your test exited with 255 just after 1.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:41:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:41:08 +0000
    Subject: [Koha-bugs] [Bug 30531] Search.t needs update for Recalls
    In-Reply-To: <bug-30531-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30531-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30531-70-WFtFkjh1Vc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30531
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                       |y.org                       |
                     CC|                            |tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:41:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:41:38 +0000
    Subject: [Koha-bugs] [Bug 30531] Search.t needs update for Recalls
    In-Reply-To: <bug-30531-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30531-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30531-70-tUtBGOO3Wb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30531
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |29734
    
    --- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Thank you, Nick :-D
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734
    [Bug 29734] [OMNIBUS] Recalls for Koha
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:41:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:41:38 +0000
    Subject: [Koha-bugs] [Bug 29734] [OMNIBUS] Recalls for Koha
    In-Reply-To: <bug-29734-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29734-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29734-70-dKO6jDwrZl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30531
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30531
    [Bug 30531] Search.t needs update for Recalls
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:42:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:42:48 +0000
    Subject: [Koha-bugs] [Bug 30570] New: Replace the use of jQueryUI tabs in
     OPAC templates
    Message-ID: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570
    
                Bug ID: 30570
               Summary: Replace the use of jQueryUI tabs in OPAC templates
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: enhancement
              Priority: P5 - low
             Component: Templates
              Assignee: oleonard at myacpl.org
              Reporter: oleonard at myacpl.org
            QA Contact: testopia at bugs.koha-community.org
                    CC: testopia at bugs.koha-community.org
                Blocks: 29226
    
    As part of Bug 29226, "OMNIBUS: Replace the use of jQueryUI tabs," we should
    replace the use of the jQueryUI tabs component in OPAC templates.
    
    - OPAC -> Advanced search
    - OPAC -> Authority details
    - OPAC -> Bibliographic details
    - OPAC -> Patron checkout history
    - OPAC -> Search history
    - OPAC -> Patron summary
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
    [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:42:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:42:48 +0000
    Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
    In-Reply-To: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29226-70-4YLWA3ON3h@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30570
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570
    [Bug 30570] Replace the use of jQueryUI tabs in OPAC templates
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:42:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:42:56 +0000
    Subject: [Koha-bugs] [Bug 30531] Search.t needs update for Recalls
    In-Reply-To: <bug-30531-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30531-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30531-70-cvscE2yWwq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30531
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:42:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:42:59 +0000
    Subject: [Koha-bugs] [Bug 30531] Search.t needs update for Recalls
    In-Reply-To: <bug-30531-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30531-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30531-70-ZpDvzYyQ9L@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30531
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133302|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:43:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:43:57 +0000
    Subject: [Koha-bugs] [Bug 30531] Search.t needs update for Recalls
    In-Reply-To: <bug-30531-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30531-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30531-70-rhnYqt9b1a@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30531
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:44:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:44:01 +0000
    Subject: [Koha-bugs] [Bug 30531] Search.t needs update for Recalls
    In-Reply-To: <bug-30531-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30531-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30531-70-EI1QUYXbZr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30531
    
    --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133466
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133466&action=edit
    Bug 30531: Add mock of UseRecalls to Search.t
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:47:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:47:08 +0000
    Subject: [Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates
    In-Reply-To: <bug-24239-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24239-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24239-70-4qxL7igZND@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Patch doesn't apply
    
    --- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Please rebase! Willing to test it!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:56:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:56:09 +0000
    Subject: [Koha-bugs] [Bug 30466] Convert serials pages tabs to Bootstrap
    In-Reply-To: <bug-30466-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30466-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30466-70-c345Je0tl5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133209|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133467
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133467&action=edit
    Bug 30466: Convert serials pages tabs to Bootstrap
    
    This patch modifies three serials templates in order to replace jQueryUI
    tabs with Bootstrap tabs.
    
    To test, apply the patch and rebuild the staff interface CSS
    (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
    
    - Go to Serials.
    - Perform a serials search which will return one or more results.
    - On the search results page you should see an Open and Closed tab.
    - The tabs should look correct and work correctly.
    - Confirm that "Select all" and "Clear all" controls work correctly in
      each tab.
    
    - Click one of the search results to view the details for that
      subscription.
    - You should see tabs for Information, Planning, Issues, and Summary.
      You may also see an Acquisition details tab depending on your data.
    
    - In the sidebar menu click "Serial collection."
    - On this page you should see tabs corresponding to each year the serial
      has been received.
    - Under each tab the "Select all" and "Clear all" controls should work
      correctly in the context of that tab. Other controls should apply to
      all tabs.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:56:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:56:41 +0000
    Subject: [Koha-bugs] [Bug 30290] Article requests: Specify TOC on AR notices
    In-Reply-To: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30290-70-FI2rOsO4Aw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|Small patch                 |Trivial patch
                     CC|                            |tomascohen at gmail.com
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:56:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:56:44 +0000
    Subject: [Koha-bugs] [Bug 30290] Article requests: Specify TOC on AR notices
    In-Reply-To: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30290-70-jMIir5Dj5D@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131656|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:56:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:56:47 +0000
    Subject: [Koha-bugs] [Bug 30290] Article requests: Specify TOC on AR notices
    In-Reply-To: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30290-70-eSwXMhNHIh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131654|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:56:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:56:49 +0000
    Subject: [Koha-bugs] [Bug 30290] Article requests: Specify TOC on AR notices
    In-Reply-To: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30290-70-5nPTkDKaWB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131655|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:57:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:57:43 +0000
    Subject: [Koha-bugs] [Bug 30290] Article requests: Specify TOC on AR notices
    In-Reply-To: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30290-70-rhMgEnyxw1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290
    
    --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133468
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133468&action=edit
    Bug 30290: Adjust sample_notices.yml
    
    Test plan:
    Run a new install. Check the AR notices.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:57:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:57:48 +0000
    Subject: [Koha-bugs] [Bug 30290] Article requests: Specify TOC on AR notices
    In-Reply-To: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30290-70-GMfN9QQiQf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290
    
    --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133469
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133469&action=edit
    Bug 30290: Database revision for existing notices
    
    Note: It will be hard to update translated notices. If we cannot find
    the part 'Pages:' then the replace does not do anything.
    
    Test plan:
    Run db rev.
    Check an existing AR notice (English).
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 14:57:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 12:57:53 +0000
    Subject: [Koha-bugs] [Bug 30290] Article requests: Specify TOC on AR notices
    In-Reply-To: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30290-70-syuYgyDgSL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290
    
    --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133470
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133470&action=edit
    Bug 30290: (follow-up) Add warning for translated notices
    
    Note: Problem is that we cannot know if default was translated
    or en contains the original notice. Actually this holds for
    the other languages too. So this is an educated guess without
    using the lang field.
    
    Test plan:
    Run db rev.
    Trigger the warning by replacing Pages by PPages in an AR notice.
    Run db rev again.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 15:02:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 13:02:01 +0000
    Subject: [Koha-bugs] [Bug 30290] Article requests: Specify TOC on AR notices
    In-Reply-To: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30290-70-Hab2zURsH7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290
    
    --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    I tested this and works as expected. My only doubt would be the wording. I'd
    prefer to see:
    
    Include TOC: yes/no
    
    but no strongly attached to it.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 15:07:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 13:07:20 +0000
    Subject: [Koha-bugs] [Bug 30545] Replace the use of jQueryUI Accordion on
     the notices page
    In-Reply-To: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30545-70-ktOLRU82Wn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                       |y.org                       |
                     CC|                            |tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 15:09:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 13:09:08 +0000
    Subject: [Koha-bugs] [Bug 30494] Replace the use of jQueryUI Accordion on
     the table settings page
    In-Reply-To: <bug-30494-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30494-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30494-70-8JarwhbZNq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30494
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |tomascohen at gmail.com
             QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                       |y.org                       |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 15:13:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 13:13:10 +0000
    Subject: [Koha-bugs] [Bug 30545] Replace the use of jQueryUI Accordion on
     the notices page
    In-Reply-To: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30545-70-2m4nk3Q0BZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Really nice.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 15:13:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 13:13:13 +0000
    Subject: [Koha-bugs] [Bug 30545] Replace the use of jQueryUI Accordion on
     the notices page
    In-Reply-To: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30545-70-ZdX30wcoBN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133408|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 15:13:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 13:13:53 +0000
    Subject: [Koha-bugs] [Bug 30494] Replace the use of jQueryUI Accordion on
     the table settings page
    In-Reply-To: <bug-30494-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30494-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30494-70-3xPsH3B4Qi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30494
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 15:13:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 13:13:56 +0000
    Subject: [Koha-bugs] [Bug 30494] Replace the use of jQueryUI Accordion on
     the table settings page
    In-Reply-To: <bug-30494-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30494-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30494-70-UDJ3BORYzn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30494
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133124|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 15:14:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 13:14:31 +0000
    Subject: [Koha-bugs] [Bug 30494] Replace the use of jQueryUI Accordion on
     the table settings page
    In-Reply-To: <bug-30494-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30494-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30494-70-xCWtwEgzzc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30494
    
    --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133471
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133471&action=edit
    Bug 30494: Replace the use of jQueryUI Accordion on the table settings page
    
    This page updates the table settings page so that it uses Bootstrap's
    "Collapse" feature instead of jQueryUI's Accordion.
    
    To test, apply the patch and rebuild the staff interface CSS
    (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
    
    - Go to Administration -> Table settings.
    - You should see a list of table settings which looks much the same as
      it did before, with arrow icons prefixing each section header. All
      panels should be collapsed.
    - Test expanding and collapsing panels to confirm it's working
      correctly.
    - When you expand a section the heading arrow should change from
      right-pointing to down.
    - Make a change to one of the table configurations. After clicking
      "Save" the page should reload with the same panel expanded.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 15:15:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 13:15:10 +0000
    Subject: [Koha-bugs] [Bug 30545] Replace the use of jQueryUI Accordion on
     the notices page
    In-Reply-To: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30545-70-80HqvpfjNm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133408|1                           |0
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 15:15:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 13:15:14 +0000
    Subject: [Koha-bugs] [Bug 30568] Make patron name fields more flexible
    In-Reply-To: <bug-30568-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30568-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30568-70-rD56LXiayB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |andrew at bywatersolutions.com
                       |                            |,
                       |                            |nick at bywatersolutions.com,
                       |                            |sally.healey at cheshireshared
                       |                            |services.gov.uk
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 15:17:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 13:17:19 +0000
    Subject: [Koha-bugs] [Bug 30545] Replace the use of jQueryUI Accordion on
     the notices page
    In-Reply-To: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30545-70-P4xh36tBAz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Patch doesn't apply
    
    --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    I mistakenly marked this as PQA. It doesn't apply anymore.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 15:20:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 13:20:43 +0000
    Subject: [Koha-bugs] [Bug 22223] Item url double-encode when parameter is an
     encoded URL
    In-Reply-To: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22223-70-1Tn9YtnHcm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22223
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |tomascohen at gmail.com
    
    --- Comment #30 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Do you need this?
    
    use Template::Plugin::Filter;
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 15:26:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 13:26:34 +0000
    Subject: [Koha-bugs] [Bug 30549] Replace the use of jQueryUI Accordion on
     pending patron updates page
    In-Reply-To: <bug-30549-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30549-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30549-70-vo4KmZqmM2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                       |y.org                       |
                     CC|                            |tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 15:26:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 13:26:57 +0000
    Subject: [Koha-bugs] [Bug 30549] Replace the use of jQueryUI Accordion on
     pending patron updates page
    In-Reply-To: <bug-30549-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30549-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30549-70-OgjK8JUKry@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 15:27:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 13:27:00 +0000
    Subject: [Koha-bugs] [Bug 30549] Replace the use of jQueryUI Accordion on
     pending patron updates page
    In-Reply-To: <bug-30549-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30549-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30549-70-6pJ8983Dw0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133412|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 15:27:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 13:27:50 +0000
    Subject: [Koha-bugs] [Bug 30549] Replace the use of jQueryUI Accordion on
     pending patron updates page
    In-Reply-To: <bug-30549-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30549-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30549-70-ifGq2oTmGr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549
    
    --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133472
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133472&action=edit
    Bug 30549: Replace the use of jQueryUI Accordion on pending patron updates page
    
    This patch updates the pending patron updates page to use Bootstrap
    collapse instead of jQueryUI.
    
    This patch contains whitespace changes, so view the diff with this in
    mind.
    
    To test, apply the patch and rebuild the staff client CSS
    (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
    
    - If necessary, log into the OPAC and submit an update via the "Your
      personal details" page. Ideally do this for two or more patrons.
    - In the staff client, follow the "Patrons requesting modifications"
      link.
    - On the "Update patron records" page you should see the headings
      representing each of the patrons with pending updates. The first panel
      should be expanded.
    - Confirm that the panels expand and collapse correctly.
    - Follow the "Patron details" link for one of these patrons.
    - Click the "Review pending modifications" link on the patron detail
      page.
    - When the update page opens that patron's panel should be expanded.
    
    Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 15:30:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 13:30:42 +0000
    Subject: [Koha-bugs] [Bug 30436] Convert article requests tabs to Bootstrap
    In-Reply-To: <bug-30436-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30436-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30436-70-WZpdy2vtsK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                       |y.org                       |
                     CC|                            |tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 15:34:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 13:34:47 +0000
    Subject: [Koha-bugs] [Bug 30571] New: Table z3950servers: which fields
     should be NOT NULL ?
    Message-ID: <bug-30571-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571
    
                Bug ID: 30571
               Summary: Table z3950servers: which fields should be NOT NULL ?
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Database
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: m.de.rooy at rijksmuseum.nl
            QA Contact: testopia at bugs.koha-community.org
    
    `host` varchar(255) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'target''s
    host name',
      `port` int(11) DEFAULT NULL COMMENT 'port number used to connect to target',
      `db` varchar(255) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'target''s
    database name',
      `syntax` varchar(80) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'marc
    format provided by this target',
      `encoding` mediumtext COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT
    'characters encoding provided by this target',
    
    Seems to me that those fields should be NOT NULL.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 15:37:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 13:37:35 +0000
    Subject: [Koha-bugs] [Bug 30571] Table z3950servers: which fields should be
     NOT NULL ?
    In-Reply-To: <bug-30571-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30571-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30571-70-a9EXkqNkeC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571
    
    --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Noting that my production table looks like:
    
      `host` varchar(255) COLLATE utf8mb4_unicode_ci NOT NULL,
      `port` int(11) DEFAULT NULL,
      `db` varchar(255) COLLATE utf8mb4_unicode_ci DEFAULT NULL,
      `syntax` varchar(80) COLLATE utf8mb4_unicode_ci NOT NULL,
      `encoding` mediumtext COLLATE utf8mb4_unicode_ci NOT NULL,
    
    Cannot find out why my host, syntax and encoding are NOT NULL. But it looks
    like that it is more correct.
    Did not find wrong dbrevs.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 15:37:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 13:37:46 +0000
    Subject: [Koha-bugs] [Bug 30436] Convert article requests tabs to Bootstrap
    In-Reply-To: <bug-30436-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30436-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30436-70-4zJTB9ugeW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Failed QA
    
    --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Hi, with the patch there's a minor style issue, spacing between the library
    dropdown and the tabs is too little:
    
    https://snipboard.io/8eNKCI.jpg
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 15:39:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 13:39:08 +0000
    Subject: [Koha-bugs] [Bug 30571] Table z3950servers: which fields should be
     NOT NULL ?
    In-Reply-To: <bug-30571-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30571-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30571-70-FL62WV7T0Z@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30486
    
    --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Linking it to the sync omnibus since it is at least very related in nature.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
    [Bug 30486] [OMNIBUS] Synchronize database schema with (older) database
    revisions
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 15:39:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 13:39:08 +0000
    Subject: [Koha-bugs] [Bug 30486] [OMNIBUS] Synchronize database schema with
     (older) database revisions
    In-Reply-To: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30486-70-hgCvCTNZcG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30571
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571
    [Bug 30571] Table z3950servers: which fields should be NOT NULL ?
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 15:40:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 13:40:02 +0000
    Subject: [Koha-bugs] [Bug 30545] Replace the use of jQueryUI Accordion on
     the notices page
    In-Reply-To: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30545-70-aS6WWLHyyj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Patch doesn't apply         |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 15:40:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 13:40:08 +0000
    Subject: [Koha-bugs] [Bug 30545] Replace the use of jQueryUI Accordion on
     the notices page
    In-Reply-To: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30545-70-41ZN61qIrp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133408|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133473
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133473&action=edit
    Bug 30545: Replace the use of jQueryUI Accordion on the notices page
    
    This patch updates the notices edit interface in order to replace
    jQueryUI accordion and tabs widgets with Bootstrap collapse and tabs.
    
    To test, apply the patch and rebuild the staff interface CSS
    (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
    
    - Set the TranslateNotices system preference to "Don't allow."
    - Go to Tools -> Notices and edit any notice.
    - On the "Modify notice" page you should see three collapsed sections:
      Email, Print, and SMS.
    - Clicking the section headings should expand and collapse the panels.
    - With one of the panels open, click Save -> Save and continue editing.
      - When the page reloads the same panel should be expanded.
    
    - Enable the TranslateNotices system preference.
    - Return to the edit interface for one of your notices.
    - You should now see at least two tabs: Default and English.
    - The sections under each tab should continue to work correctly.
    - Test the "Save and continue" functionality again. When redirected you
      should return to both the correct tab and the correct panel, e.g. the
      "Print" section under the "English (en)" tab.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 15:40:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 13:40:28 +0000
    Subject: [Koha-bugs] [Bug 30326] Cronjob that checks biblios for MARC errors
    In-Reply-To: <bug-30326-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30326-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30326-70-AGJ84RdDTg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30326
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                       |y.org                       |
                     CC|                            |tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 15:52:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 13:52:46 +0000
    Subject: [Koha-bugs] [Bug 30326] Cronjob that checks biblios for MARC errors
    In-Reply-To: <bug-30326-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30326-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30326-70-CQ4J3wEYfq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30326
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Failed QA
    
    --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Hi, a couple remarks:
    
    1. I'm not sure about the output, meaning that maybe as other scripts do, it
    could have an option switch for different formats. Not a blocker
    
    2. In the --bibnum use case, it is not handling non-existing records correctly.
    It should report it correctly (right now it tells 'Must pass a MARC::Record
    object to check_record' which might be misleading for the end user).
    
    3. I suggest you add a --where parameter, that is passed as a literal query to 
    
    Koha::Biblios->search( $query, { prefetch => ['biblio_metadata'] } );
    
    and use $biblio->metadata->record instead of GetMarcBiblio.
    
    Failing because of 2, primarily.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 15:56:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 13:56:27 +0000
    Subject: [Koha-bugs] [Bug 30475] Convert tools pages tabs to Bootstrap (part
     2)
    In-Reply-To: <bug-30475-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30475-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30475-70-o5LZGZDeFV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30475
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133047|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133474
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133474&action=edit
    Bug 30475: Convert tools pages tabs to Bootstrap (part 2)
    
    This patch converts jQueryUI tabs on three tools templates to Bootstrap
    tabs. The patch contains indentation changes, so diff accordingly.
    
    To test, apply the patch and go to Tools -> Export.
    
    - You should see at least two tabs, "Export bibliographic records" and
      "Export authority records."
    - Confirm that they look correct and work correctly.
    
    Go to Tools -> Batch patron modification.
    
    - Check the "By card number," "By borrowernumber," and "By patron list"
      tabs.
    
    Go to Tools -> Overdue notice/status triggers.
    
     - Check the "First," "Second," and "Third" tabs.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 16:04:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 14:04:31 +0000
    Subject: [Koha-bugs] [Bug 30436] Convert article requests tabs to Bootstrap
    In-Reply-To: <bug-30436-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30436-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30436-70-5P1NPziO8l@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30466
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466
    [Bug 30466] Convert serials pages tabs to Bootstrap
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 16:04:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 14:04:31 +0000
    Subject: [Koha-bugs] [Bug 30466] Convert serials pages tabs to Bootstrap
    In-Reply-To: <bug-30466-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30466-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30466-70-qRFgW5Ixth@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30436
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436
    [Bug 30436] Convert article requests tabs to Bootstrap
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 16:09:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 14:09:33 +0000
    Subject: [Koha-bugs] [Bug 30436] Convert article requests tabs to Bootstrap
    In-Reply-To: <bug-30436-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30436-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30436-70-AtGGPDoA9d@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Signed Off
    
    --- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
    (In reply to Tomás Cohen Arazi from comment #6)
    > Hi, with the patch there's a minor style issue, spacing between the library
    > dropdown and the tabs is too little:
    
    Fixed in Bug 30466. I've added it as a dependency.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 16:16:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 14:16:44 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-eUPvrcujqT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Sally <sally.healey at cheshiresharedservices.gov.uk> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Failed QA
    
    --- Comment #34 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
    Great, thanks Martin!
    
    It seems as though the patch changes the default patron search from the
    standard fields to surname only.  To replicate:
    
    1)  Add two patrons called Henry - e.g. Henry Jones and Henry Smith
    2)  On the homepage, set the search to 'check out' and search for Henry
    
    Results:  
    
    i)  Note that at least two patrons are returned
    ii)  Note that in the 'Search for patron' box on the left, the Search field is
    listed as 'Standard'
    iii)  Note that the search text says:  Patrons found for: Standard containing
    'henry'
    
    Add the patch and repeat step 2.
    
    i)  Note that the search brings back no results
    ii)  Note that in the 'Search for patron' box on the left, the Search field is
    listed as 'Surname'
    iii)  Note that the search text says:  Patrons found for: Surname containing
    'henry'
    iv)  Note that if you attempt to change the Search field in the 'Search for
    patron' box, Standard is not available as an option.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 16:25:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 14:25:39 +0000
    Subject: [Koha-bugs] [Bug 30515] Move Overdue transports to patron messaging
     preferences
    In-Reply-To: <bug-30515-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30515-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30515-70-cBByqdzB2d@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515
    
    --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
    Do you mean an option to not have a given transport appear in preferences?
    Or an option to not show preferences for ODUE2, and only ODUE1?
    
    I think we envisioned a single preference for overdues - the triggers still
    controlling which ones we send
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 16:29:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 14:29:57 +0000
    Subject: [Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates
    In-Reply-To: <bug-24239-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24239-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24239-70-EwqAm9eGQO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239
    
    Lari Taskula <lari.taskula at hypernova.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #130414|0                           |1
            is obsolete|                            |
    
    --- Comment #17 from Lari Taskula <lari.taskula at hypernova.fi> ---
    Created attachment 133475
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133475&action=edit
    Bug 24239: Add column illrequests.date_due
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 16:30:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 14:30:02 +0000
    Subject: [Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates
    In-Reply-To: <bug-24239-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24239-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24239-70-ClUtMrwKYj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239
    
    Lari Taskula <lari.taskula at hypernova.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #130415|0                           |1
            is obsolete|                            |
    
    --- Comment #18 from Lari Taskula <lari.taskula at hypernova.fi> ---
    Created attachment 133476
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133476&action=edit
    Bug 24239: Unit tests
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 16:30:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 14:30:07 +0000
    Subject: [Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates
    In-Reply-To: <bug-24239-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24239-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24239-70-8nPs1PKIxF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239
    
    Lari Taskula <lari.taskula at hypernova.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #130416|0                           |1
            is obsolete|                            |
    
    --- Comment #19 from Lari Taskula <lari.taskula at hypernova.fi> ---
    Created attachment 133477
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133477&action=edit
    Bug 24239: Let the ILL module set ad hoc hard due dates
    
    The Swedish Libris ILL backend lets librarians store a specific due date
    when an ILL loan is received. This is stored as a ILL request attribute.
    
    This patch adds a syspref that can take the name of the
    illrequestattribute used to store the specific date. If the syspref is
    set, and if an item is connected to an ILL request, the due date will be
    taken from the illrequestattribute, instead of being calculated in the
    regular way, based on patroncategory and itemtype.
    
    To test:
    - Apply the patch and make sure the atomic database update is run
    - Use the FreeForm backend to add one ILL request. Take note  of the
      illrequest_id of the request you created. We refer to this as
      "x" below.
    - Connect a biblio (with biblionumber y), that has an item with a
      barcode, to the ILL request directly in the database:
      UPADTE illrequests SET biblio_id = y WHERE illrequest_id = x;
    - Add an attribute to the ILL request directly in the database:
      INSERT INTO illrequestattributes SET illrequest_id = x, type =
      'illduedate', value = '2023-01-01';
    - Enter 'illduedate' as a value for the ILLUseExactDueDate syspref.
    - Go to circulation and issue the barcode of the item to the
      patron associated with the FreeForm ILL request. Verify that the
      loan gets a due date of 2023-01-01.
    - Ideally: return the item and issue it again through SIP2 and SCO,
      and verify that the due date is still 2023-01-01.
      (I don't think the REST API supports issuing yet?)
    - Verify that there are no regressions, so that regular calculation
      of due dates still work, if ILLUseExactDueDate is empty or not.
    - prove t/db_dependent/Circulation.t
    
    (Patch description, test plan and partial code credits to Magnus Enger)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 16:37:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 14:37:33 +0000
    Subject: [Koha-bugs] [Bug 30466] Convert serials pages tabs to Bootstrap
    In-Reply-To: <bug-30466-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30466-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30466-70-2NnlO9FTwU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
                     CC|                            |tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 16:37:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 14:37:36 +0000
    Subject: [Koha-bugs] [Bug 30466] Convert serials pages tabs to Bootstrap
    In-Reply-To: <bug-30466-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30466-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30466-70-WCatnIBYRN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133467|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 16:37:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 14:37:58 +0000
    Subject: [Koha-bugs] [Bug 30466] Convert serials pages tabs to Bootstrap
    In-Reply-To: <bug-30466-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30466-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30466-70-V1lcM12up4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466
    
    --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133478
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133478&action=edit
    Bug 30466: Convert serials pages tabs to Bootstrap
    
    This patch modifies three serials templates in order to replace jQueryUI
    tabs with Bootstrap tabs.
    
    To test, apply the patch and rebuild the staff interface CSS
    (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
    
    - Go to Serials.
    - Perform a serials search which will return one or more results.
    - On the search results page you should see an Open and Closed tab.
    - The tabs should look correct and work correctly.
    - Confirm that "Select all" and "Clear all" controls work correctly in
      each tab.
    
    - Click one of the search results to view the details for that
      subscription.
    - You should see tabs for Information, Planning, Issues, and Summary.
      You may also see an Acquisition details tab depending on your data.
    
    - In the sidebar menu click "Serial collection."
    - On this page you should see tabs corresponding to each year the serial
      has been received.
    - Under each tab the "Select all" and "Clear all" controls should work
      correctly in the context of that tab. Other controls should apply to
      all tabs.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 16:43:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 14:43:34 +0000
    Subject: [Koha-bugs] [Bug 30436] Convert article requests tabs to Bootstrap
    In-Reply-To: <bug-30436-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30436-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30436-70-EolOkPEK4K@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 16:43:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 14:43:39 +0000
    Subject: [Koha-bugs] [Bug 30436] Convert article requests tabs to Bootstrap
    In-Reply-To: <bug-30436-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30436-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30436-70-NF5PodFjKa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132933|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 16:44:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 14:44:22 +0000
    Subject: [Koha-bugs] [Bug 30436] Convert article requests tabs to Bootstrap
    In-Reply-To: <bug-30436-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30436-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30436-70-DCnHRzVsLZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436
    
    --- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133479
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133479&action=edit
    Bug 30436: Convert article requests tabs to Bootstrap
    
    This patch converts the jQuery tabs on the article requests page to
    Bootstrap.
    
    To test you should have the "ArticleRequests" system preference
    enabled. If necessary, create some article requests and mark some
    "Pending," some "Processing," and leave some new.
    
    - Apply the patch and go to Circulation -> Article requests.
    - The page should show three tabs: New, Pending, and Processing.
    - The tabs should look correct and work correctly.
    - The DataTables under each tab should work correctly.
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 16:45:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 14:45:11 +0000
    Subject: [Koha-bugs] [Bug 30436] Convert article requests tabs to Bootstrap
    In-Reply-To: <bug-30436-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30436-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30436-70-lRKabNBqLa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436
    
    --- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    All works correctly using the scss generated from bug 30466 solved the (minor)
    visual glitch.
    
    Well done!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 16:47:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 14:47:20 +0000
    Subject: [Koha-bugs] [Bug 30553] Add a count to borrower Files tab in
     patroninfo
    In-Reply-To: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30553-70-Cu3M2du3HD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30553
    
    ByWater Sandboxes <bws.sandboxes at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133365|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
    Created attachment 133480
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133480&action=edit
    Bug 30553: Add file count to patron circ-menu
    
    To test:
    1. Apply patch
    2. Enable the system preference 'EnableBorrowerFiles'
    3. Go to a patron account and noticet the Files tab on left nav bar.
    4. It should read "Files (0)"
    5. Begin uploading some files to the borrower. The tab should reflect the
    number of files uploaded.
    6. Go to other pages on the borrower account ( Checkout, Details, etc. )
    7. The number of files should display from all borrower pages
    
    Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 16:47:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 14:47:50 +0000
    Subject: [Koha-bugs] [Bug 30553] Add a count to borrower Files tab in
     patroninfo
    In-Reply-To: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30553-70-lBTzuIxneB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30553
    
    Barbara Johnson <barbara.johnson at bedfordtx.gov> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
                     CC|                            |barbara.johnson at bedfordtx.g
                       |                            |ov
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 16:48:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 14:48:54 +0000
    Subject: [Koha-bugs] [Bug 30457] Convert holds page tabs to Bootstrap
    In-Reply-To: <bug-30457-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30457-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30457-70-m42FJO4dec@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30457
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |tomascohen at gmail.com
             QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                       |y.org                       |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 16:51:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 14:51:37 +0000
    Subject: [Koha-bugs] [Bug 30457] Convert holds page tabs to Bootstrap
    In-Reply-To: <bug-30457-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30457-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30457-70-bApMrbvuFp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30457
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Failed QA
    
    --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Hi, tabs are not aligned correctly on my testing:
    
    https://snipboard.io/lqO09T.jpg
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 16:52:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 14:52:18 +0000
    Subject: [Koha-bugs] [Bug 27470] Improve link text for logging in
    In-Reply-To: <bug-27470-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27470-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27470-70-0xYidNqfv6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27470
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Patch doesn't apply
                     CC|                            |lucas at bywatersolutions.com
    
    --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> ---
    Patch no longer cleanly applies to current master.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 16:54:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 14:54:54 +0000
    Subject: [Koha-bugs] [Bug 28061] Cash Register Stats table
     (cash_register_stats.pl) should include a timestamp
    In-Reply-To: <bug-28061-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28061-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28061-70-g87aXXve49@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28061
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Patch doesn't apply
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 16:55:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 14:55:19 +0000
    Subject: [Koha-bugs] [Bug 30466] Convert serials pages tabs to Bootstrap
    In-Reply-To: <bug-30466-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30466-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30466-70-eETtSUa6Pb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133478|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133481
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133481&action=edit
    Bug 30466: Convert serials pages tabs to Bootstrap
    
    This patch modifies three serials templates in order to replace jQueryUI
    tabs with Bootstrap tabs.
    
    To test, apply the patch and rebuild the staff interface CSS
    (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
    
    - Go to Serials.
    - Perform a serials search which will return one or more results.
    - On the search results page you should see an Open and Closed tab.
    - The tabs should look correct and work correctly.
    - Confirm that "Select all" and "Clear all" controls work correctly in
      each tab.
    
    - Click one of the search results to view the details for that
      subscription.
    - You should see tabs for Information, Planning, Issues, and Summary.
      You may also see an Acquisition details tab depending on your data.
    
    - In the sidebar menu click "Serial collection."
    - On this page you should see tabs corresponding to each year the serial
      has been received.
    - Under each tab the "Select all" and "Clear all" controls should work
      correctly in the context of that tab. Other controls should apply to
      all tabs.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 16:55:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 14:55:57 +0000
    Subject: [Koha-bugs] [Bug 30466] Convert serials pages tabs to Bootstrap
    In-Reply-To: <bug-30466-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30466-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30466-70-AAf2evbNxU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Looks great! Passing QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 16:56:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 14:56:30 +0000
    Subject: [Koha-bugs] [Bug 30572] New: Field search_marc_to_field.sort needs
     syncing too
    Message-ID: <bug-30572-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30572
    
                Bug ID: 30572
               Summary: Field search_marc_to_field.sort needs syncing too
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Database
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: m.de.rooy at rijksmuseum.nl
            QA Contact: testopia at bugs.koha-community.org
    
    $DBversion = '20.11.03.003';
    if( CheckVersion( $DBversion ) ) {
        $dbh->do( "UPDATE search_marc_to_field SET sort = 1 WHERE sort IS NULL" );
        $dbh->do( "ALTER TABLE search_marc_to_field MODIFY COLUMN sort tinyint(1)
    DEFAULT 1 NOT NULL COMMENT 'Sort defaults to 1 (Yes) and creates sort fields in
    the index, 0 (no) will prevent this'" );
    
    kohastructure:
    
    CREATE TABLE `search_marc_to_field` (
      `sort` tinyint(1) DEFAULT NULL COMMENT 'true/false creates special sort
    handling, null doesn''t',
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 16:56:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 14:56:45 +0000
    Subject: [Koha-bugs] [Bug 30572] Field search_marc_to_field.sort needs
     syncing too
    In-Reply-To: <bug-30572-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30572-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30572-70-A0Xm8teXC3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30572
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30486
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
    [Bug 30486] [OMNIBUS] Synchronize database schema with (older) database
    revisions
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 16:56:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 14:56:45 +0000
    Subject: [Koha-bugs] [Bug 30486] [OMNIBUS] Synchronize database schema with
     (older) database revisions
    In-Reply-To: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30486-70-VpPwHQ4B6X@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30572
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30572
    [Bug 30572] Field search_marc_to_field.sort needs syncing too
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 17:03:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 15:03:40 +0000
    Subject: [Koha-bugs] [Bug 30434] Convert catalog merge page tabs to Bootstrap
    In-Reply-To: <bug-30434-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30434-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30434-70-Mwssr1euVV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30434
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133278|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133482
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133482&action=edit
    Bug 30434: Convert catalog merge page tabs to Bootstrap
    
    This patch updates the catalog merge template so that it uses Bootstrap
    tabs instead of jQueryUI. Some JavaScript is modified to accommodate the
    new DOM structure.
    
    The patch also makes a minor HTML correction, adding a missing "</ol>".
    
    To test, apply the patch and search the catalog in the staff client.
    
    - In the search results, check the checkbox for two records.
    - Choose Edit -> Merge records.
    - Click next to accept the merge reference selection.
    - On the next page you should see two tabs under "Source records."
      Confirm that they work correctly.
    - All checkboxes in the first tab should be checked by default.
    - Confirm that tag and subfield selection still works correctly.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 17:06:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 15:06:12 +0000
    Subject: [Koha-bugs] [Bug 30434] Convert catalog merge page tabs to Bootstrap
    In-Reply-To: <bug-30434-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30434-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30434-70-NtyaGxc4n4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30434
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    All works as expected.. being bold and going straight for PQA here as it's a
    simple patch and I can't find any regressions.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 17:06:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 15:06:22 +0000
    Subject: [Koha-bugs] [Bug 30434] Convert catalog merge page tabs to Bootstrap
    In-Reply-To: <bug-30434-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30434-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30434-70-XfdZHi4Nf4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30434
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 17:12:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 15:12:18 +0000
    Subject: [Koha-bugs] [Bug 30454] Convert holds awaiting pickup tabs to
     Bootstrap
    In-Reply-To: <bug-30454-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30454-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30454-70-NyQakg3TFw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30454
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132956|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133483
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133483&action=edit
    Bug 30454: Convert holds awaiting pickup tabs to Bootstrap
    
    This patch updates the holds awaiting pickup page to replace jQueryUI
    tabs with Bootstrap tabs. A minor JavaScript change is required to work
    with the new HTML structure.
    
    To test you should have multiple holds for one library: Some which are
    waiting for less than the number of days specified in
    ReservesMaxPickUpDelay, some which are waiting longer.
    
    - Apply the patch and go to Circulation -> Holds awaiting pickup.
    - You should see two tabs: "Holds waiting" and "Holds waiting over..."
    - Confirm that the tabs look correct and work correctly.
    - Confirm that the "Cancel selected" buttons work correctly under each
      tab.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 17:12:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 15:12:55 +0000
    Subject: [Koha-bugs] [Bug 30454] Convert holds awaiting pickup tabs to
     Bootstrap
    In-Reply-To: <bug-30454-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30454-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30454-70-5mHe36z46A@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30454
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
                 Status|Needs Signoff               |Signed Off
    
    --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Looks great and works as expected.. being bold and going straight for QA again
    here.  QA scripts are happy.
    
    Passing QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 17:13:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 15:13:04 +0000
    Subject: [Koha-bugs] [Bug 30454] Convert holds awaiting pickup tabs to
     Bootstrap
    In-Reply-To: <bug-30454-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30454-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30454-70-jU13DwbAo6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30454
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 17:15:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 15:15:28 +0000
    Subject: [Koha-bugs] [Bug 30457] Convert holds page tabs to Bootstrap
    In-Reply-To: <bug-30457-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30457-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30457-70-Wv1CvydUbm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30457
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Confirmed, alignment is out
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 17:29:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 15:29:55 +0000
    Subject: [Koha-bugs] [Bug 30473] Convert suggestions page tabs to Bootstrap
    In-Reply-To: <bug-30473-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30473-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30473-70-stAJUTl8A8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30473
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133182|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133484
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133484&action=edit
    Bug 30473: Convert suggestions page tabs to Bootstrap
    
    This patch updates the suggestions page to use Bootstrap tabs
    instead of jQueryUI.
    
    To test you should have multiple suggestions from different libraries,
    different item types, and different statuses.
    
    Apply the patch and go to Suggestions.
    
    - Suggestions should initially be displayed in tabs by status.
    - Confirm that the tabs look correct and work correctly.
    - Test that tabs work correctly for each option in the "Organize by"
      dropdown in the left-hand sidebar.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 17:31:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 15:31:12 +0000
    Subject: [Koha-bugs] [Bug 30473] Convert suggestions page tabs to Bootstrap
    In-Reply-To: <bug-30473-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30473-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30473-70-h7CeVOqzhl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30473
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
                 Status|Signed Off                  |Passed QA
    
    --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Great to hear my only concern is already fixed in bug 30466.. PQA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 17:35:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 15:35:45 +0000
    Subject: [Koha-bugs] [Bug 30474] Convert tools pages tabs to Bootstrap (part
     1)
    In-Reply-To: <bug-30474-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30474-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30474-70-nZ5E0SfifA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133271|0                           |1
            is obsolete|                            |
    
    --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133485
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133485&action=edit
    Bug 30474: Convert tools pages tabs to Bootstrap (part 1)
    
    This patch converts jQueryUI tabs on three tools templates to Bootstrap
    tabs.
    
    To test, apply the patch and go to Tools -> HTML customizations.
    
    - Click "New entry."
    - On the entry form you should see two tabs, "Default" and "English
      (en)"
    - The tabs should look correct and work correctly.
    
    Go to Tools -> Batch record deletion.
    
     - Test the three tabs: "Upload a file", "Select a list of records", and
       "Enter a list of record numbers."
    
    Go to Tools -> Batch record modification.
    
     -  Test the same three tabs on this page.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 17:35:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 15:35:49 +0000
    Subject: [Koha-bugs] [Bug 30474] Convert tools pages tabs to Bootstrap (part
     1)
    In-Reply-To: <bug-30474-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30474-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30474-70-8u0X45lOZV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133272|0                           |1
            is obsolete|                            |
    
    --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133486
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133486&action=edit
    Bug 30474: (follow-up) Tie editor initialization to tab activation
    
    The way Bootstrap tabs manipulate the DOM, CodeMirror has problems
    initializing correctly, I think because of redraws and CodeMirror's
    attemps to position things absolutely.
    
    The solution seems to be to wait until after a Bootstrap tab has
    activated before initializing the CodeMirror instance. This patch
    implements that, along with a check to prevent double-initializing the
    same textarea.
    
    I've also made a similar change to the way TinyMCE is initialized, which
    I hope will help with the issue of the editor not always loading
    correctly.
    
    To test, apply the patch and go to Tools -> HTML customizations.
    
    - Test creation and editing of HTML customization entries using both
      the default editor and the text editor (Edit -> Edit with text
      editor).
    - Verify that the editor (CodeMirror or TinyMCE) loads correctly and
      looks correct, both upon page load and upon switching tabs between
      "Default" and other language tabs
    - Verify that your edits are saved correctly.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 17:37:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 15:37:49 +0000
    Subject: [Koha-bugs] [Bug 30474] Convert tools pages tabs to Bootstrap (part
     1)
    In-Reply-To: <bug-30474-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30474-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30474-70-gEfNyyhN9X@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Looking good.. again the top padding is fixed elsewhere already.. Passing QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 17:40:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 15:40:29 +0000
    Subject: [Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check
     CanReserveBeCanceledFromOpac
    In-Reply-To: <bug-22379-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22379-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22379-70-eCTj8r12SY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379
    
    Arthur Suzuki <arthur.suzuki at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 17:43:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 15:43:47 +0000
    Subject: [Koha-bugs] [Bug 30545] Replace the use of jQueryUI Accordion on
     the notices page
    In-Reply-To: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30545-70-dS47pvypQT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133473|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133487
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133487&action=edit
    Bug 30545: Replace the use of jQueryUI Accordion on the notices page
    
    This patch updates the notices edit interface in order to replace
    jQueryUI accordion and tabs widgets with Bootstrap collapse and tabs.
    
    To test, apply the patch and rebuild the staff interface CSS
    (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
    
    - Set the TranslateNotices system preference to "Don't allow."
    - Go to Tools -> Notices and edit any notice.
    - On the "Modify notice" page you should see three collapsed sections:
      Email, Print, and SMS.
    - Clicking the section headings should expand and collapse the panels.
    - With one of the panels open, click Save -> Save and continue editing.
      - When the page reloads the same panel should be expanded.
    
    - Enable the TranslateNotices system preference.
    - Return to the edit interface for one of your notices.
    - You should now see at least two tabs: Default and English.
    - The sections under each tab should continue to work correctly.
    - Test the "Save and continue" functionality again. When redirected you
      should return to both the correct tab and the correct panel, e.g. the
      "Print" section under the "English (en)" tab.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 17:45:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 15:45:55 +0000
    Subject: [Koha-bugs] [Bug 30545] Replace the use of jQueryUI Accordion on
     the notices page
    In-Reply-To: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30545-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30545-70-dnUDtg9AWZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    This is great.. Passing QA
    
    Minor annoyance that predates this though.. when you switch the language tab,
    we don't keep the context of the open accordion.. would be great if we could..
    but that can wait on another bug.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 17:47:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 15:47:42 +0000
    Subject: [Koha-bugs] [Bug 30573] New: Do not hide "Total Tax Inc" on invoice
     details when tax has been charged
    Message-ID: <bug-30573-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30573
    
                Bug ID: 30573
               Summary: Do not hide "Total Tax Inc" on invoice details when
                        tax has been charged
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Acquisitions
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: andrew at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
    
    On invoice.pl, if the vendor is set up so prices at receiving do not include
    tax, we hide the "Total tax inc" column in invoice details. If there is a tax
    rate associated with this vendor and tax has been calculated and charged, we
    should show the "Total tax inc" column. Otherwise the user ends up having to
    either click the reveal the column or do the math themselves.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 17:51:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 15:51:36 +0000
    Subject: [Koha-bugs] [Bug 30453] Convert offline circulation tabs to
     Bootstrap
    In-Reply-To: <bug-30453-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30453-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30453-70-D2B5bL5LPr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30453
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133279|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133488
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133488&action=edit
    Bug 30453: Convert offline circulation tabs to Bootstrap
    
    This patch updates the offline circulation page in the staff interface
    to use Bootstrap tabs instead of jQueryUI.
    
    To test, apply the patch and make sure the AllowOfflineCirculation
    system preference is enabled.
    
    - Go to Circulation -> Built-in offline circulation interface
    - Submit a patron barcode in the "Check out" field.
    - Under the barcode input field you should see two tabs: Checkouts and
      Fines. Confirm that they look correct and work correctly.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 17:52:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 15:52:11 +0000
    Subject: [Koha-bugs] [Bug 30453] Convert offline circulation tabs to
     Bootstrap
    In-Reply-To: <bug-30453-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30453-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30453-70-ic90NWvQLy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30453
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Looking good.. PQA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 17:52:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 15:52:17 +0000
    Subject: [Koha-bugs] [Bug 30453] Convert offline circulation tabs to
     Bootstrap
    In-Reply-To: <bug-30453-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30453-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30453-70-Bw6O3ucIJX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30453
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 18:02:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 16:02:18 +0000
    Subject: [Koha-bugs] [Bug 30475] Convert tools pages tabs to Bootstrap (part
     2)
    In-Reply-To: <bug-30475-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30475-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30475-70-Py5V0R6FAr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30475
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133474|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133489
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133489&action=edit
    Bug 30475: Convert tools pages tabs to Bootstrap (part 2)
    
    This patch converts jQueryUI tabs on three tools templates to Bootstrap
    tabs. The patch contains indentation changes, so diff accordingly.
    
    To test, apply the patch and go to Tools -> Export.
    
    - You should see at least two tabs, "Export bibliographic records" and
      "Export authority records."
    - Confirm that they look correct and work correctly.
    
    Go to Tools -> Batch patron modification.
    
    - Check the "By card number," "By borrowernumber," and "By patron list"
      tabs.
    
    Go to Tools -> Overdue notice/status triggers.
    
     - Check the "First," "Second," and "Third" tabs.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 18:02:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 16:02:36 +0000
    Subject: [Koha-bugs] [Bug 30475] Convert tools pages tabs to Bootstrap (part
     2)
    In-Reply-To: <bug-30475-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30475-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30475-70-qOoRStFMwf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30475
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 18:02:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 16:02:48 +0000
    Subject: [Koha-bugs] [Bug 30475] Convert tools pages tabs to Bootstrap (part
     2)
    In-Reply-To: <bug-30475-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30475-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30475-70-UfNLqd9c62@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30475
    
    --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Looks great, Signing off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 18:09:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 16:09:37 +0000
    Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
    In-Reply-To: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23991-70-UMaoaNctUJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                       |y.org                       |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 18:10:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 16:10:05 +0000
    Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
    In-Reply-To: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23991-70-nCXG7Tug36@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991
    
    --- Comment #50 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    I already tested this one. Will do a second round to check the rebase fixes and
    Nick's follow-up
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 18:15:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 16:15:09 +0000
    Subject: [Koha-bugs] [Bug 30489] Convert MARC and authority subfield edit
     tabs to Bootstrap
    In-Reply-To: <bug-30489-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30489-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30489-70-W2xeUkCow6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30489
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133304|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133490
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133490&action=edit
    Bug 30489: Convert MARC and authority subfield edit tabs to Bootstrap
    
    This patch updates the MARC and authority subfield edit interface to
    replace jQueryUI tabs with Bootstrap. The code for handling
    drag-to-reorder tabs is updated to accommodate the new markup.
    
    To test, apply the patch and restart_all.
    
    - Go to Administration -> MARC bibliographic framework -> Default
      framework and choose "MARC structure" from the Actions menu.
    - In the row for 000 LEADER, click Actions -> View subfields.
    - Click "Edit." On the edit page the tabs should look correct and work
      correctly.
    - Return to the list of tags and click "View subfields" for the 245 tag.
    - Click one of the "Edit" buttons for any but the first subfield, e.g.
      "a".
    - On the "Tag 245 Subfield constraints" page the "a" tab should be
      pre-selected.
    - Click any of the subfield tabs and drag it to re-order it in the
      sequence of tags.
    - It should stay in the correct slot when you release it.
    - Save and confirm that the new sequence of subfields has been saved.
    
    Perform all the same tests under Administration -> Authority types.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 18:15:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 16:15:50 +0000
    Subject: [Koha-bugs] [Bug 30489] Convert MARC and authority subfield edit
     tabs to Bootstrap
    In-Reply-To: <bug-30489-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30489-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30489-70-AjP8mp9PB7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30489
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Looking great and working great.. nice one..
    
    Going straight for PQA here too.. Scripts are happy and no regressions found.
    
    PQA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 18:15:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 16:15:56 +0000
    Subject: [Koha-bugs] [Bug 30489] Convert MARC and authority subfield edit
     tabs to Bootstrap
    In-Reply-To: <bug-30489-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30489-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30489-70-NWZ0e0T0gM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30489
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 18:17:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 16:17:43 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-U8CSyPc7Rh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    George Williams (NEKLS) <george at nekls.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |george at nekls.org
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 18:26:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 16:26:57 +0000
    Subject: [Koha-bugs] [Bug 30457] Convert holds page tabs to Bootstrap
    In-Reply-To: <bug-30457-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30457-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30457-70-qudTcMirpI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30457
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 18:27:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 16:27:01 +0000
    Subject: [Koha-bugs] [Bug 30457] Convert holds page tabs to Bootstrap
    In-Reply-To: <bug-30457-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30457-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30457-70-cIbI7jvteq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30457
    
    --- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133491
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133491&action=edit
    Bug 30457: (follow-up) Tweak markup around search form
    
    This patch makes a change to the markup around the patron/clubs search
    form on the holds page. This change prevents the Bootstrap tabs from
    inheriting an unwanted margin from the fieldset.brief definition.
    
    The change also replaces a <label> tag with an <h2>. I think a heading
    makes more sense than a free-floating <label>.
    
    To test, apply the patch and confirm that the holds page
    (/cgi-bin/koha/reserve/request.pl?biblionumber=XXX) looks correct.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 18:34:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 16:34:41 +0000
    Subject: [Koha-bugs] [Bug 17787] Hidden items included in count of search
     results
    In-Reply-To: <bug-17787-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17787-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17787-70-sFTbDgBMIB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
                     CC|                            |lucas at bywatersolutions.com
    
    --- Comment #13 from Lucas Gass <lucas at bywatersolutions.com> ---
    This is still a problem in master and this bugfix seems to fix the problem, I
    am setting it to NSO.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 18:47:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 16:47:12 +0000
    Subject: [Koha-bugs] [Bug 30433] Convert advanced search tabs to Bootstrap
    In-Reply-To: <bug-30433-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30433-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30433-70-udocVbjc3G@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30433
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132867|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133492
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133492&action=edit
    Bug 30433: Convert advanced search tabs to Bootstrap
    
    This patch updates the advanced search page in the staff interface to
    use Bootstrap tabs instead of jQueryUI.
    
    To test, apply the patch and test the advanced search interface. The
    tabs should look correct and work correctly.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 18:47:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 16:47:42 +0000
    Subject: [Koha-bugs] [Bug 30433] Convert advanced search tabs to Bootstrap
    In-Reply-To: <bug-30433-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30433-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30433-70-x4Bv0MZRZv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30433
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
                 Status|Needs Signoff               |Signed Off
    
    --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Perfec, PQA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 18:47:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 16:47:48 +0000
    Subject: [Koha-bugs] [Bug 30433] Convert advanced search tabs to Bootstrap
    In-Reply-To: <bug-30433-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30433-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30433-70-rYdlYCN5GG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30433
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 18:54:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 16:54:02 +0000
    Subject: [Koha-bugs] [Bug 30457] Convert holds page tabs to Bootstrap
    In-Reply-To: <bug-30457-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30457-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30457-70-OgWFoNW2SJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30457
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133088|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133493
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133493&action=edit
    Bug 30457: Convert holds page tabs to Bootstrap
    
    This patch updates the holds page to replace jQueryUI tabs with
    Bootstrap.
    
    To test, apply the patch and begin the process of placing a hold on a
    title in the catalog.
    
    If you have one or more patron clubs configured:
     - You should see two tabs, Patrons and Clubs.
     - Both should look correct and work correctly.
     - The Patrons tab should be selected initially, with cursor focus in
       the form field.
     - Switch to the Clubs tab. The cursor focus should move to the form
       field under this tab.
     - Submit a club search which will return results.
     - The page should refresh and the clubs tab should be preselected,
       showing the search results.
    
    If you have no patron clubs configured, the page should show only the
    Patrons tab.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 18:54:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 16:54:06 +0000
    Subject: [Koha-bugs] [Bug 30457] Convert holds page tabs to Bootstrap
    In-Reply-To: <bug-30457-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30457-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30457-70-jFNnoQA6Ur@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30457
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133491|0                           |1
            is obsolete|                            |
    
    --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133494
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133494&action=edit
    Bug 30457: (follow-up) Tweak markup around search form
    
    This patch makes a change to the markup around the patron/clubs search
    form on the holds page. This change prevents the Bootstrap tabs from
    inheriting an unwanted margin from the fieldset.brief definition.
    
    The change also replaces a <label> tag with an <h2>. I think a heading
    makes more sense than a free-floating <label>.
    
    To test, apply the patch and confirm that the holds page
    (/cgi-bin/koha/reserve/request.pl?biblionumber=XXX) looks correct.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 18:54:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 16:54:49 +0000
    Subject: [Koha-bugs] [Bug 30457] Convert holds page tabs to Bootstrap
    In-Reply-To: <bug-30457-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30457-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30457-70-snInF7oeU1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30457
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Excellent, thanks for the quick follow-up.
    
    PQA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 19:45:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 17:45:27 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-2bZCZ9IeOT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    --- Comment #92 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133495
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133495&action=edit
    Bug 29602: (follow-up) Fix TemplateToolkit test
    
    This patch fixes the t/db_dependent/Letters/TemplateToolkit.t by adding
    the nested `<span>` into the expected output string to reflect the
    change added to the primary include.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 19:45:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 17:45:52 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-8JaSkPILMv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |additional_work_needed
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 19:46:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 17:46:26 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-ZrbL2YK2YG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    --- Comment #93 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Final follow-up fixes one of the failing unit tests on master.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 19:57:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 17:57:05 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-KfCiZaSxuc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |ASSIGNED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 19:57:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 17:57:52 +0000
    Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches
     for authority links on a Z39.50 server.
    In-Reply-To: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-11300-70-wjGy88KMTy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300
    
    Shi Yao Wang <shi-yao.wang at inLibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #115217|0                           |1
            is obsolete|                            |
    
    --- Comment #41 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
    Created attachment 133496
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133496&action=edit
    Bug 11300: Add a new authority linker which searches for authority links on a
    Z39.50 server.
    
    This patch adds a Z39.50 Linker which searches for authority links on a remote
    server.
    
    If a matching authority is found, it's imported in the local database for
    linking with the current biblio record.
    
    If no matching authority was found on the remote server, the Linker falls back
    to a local authority search.
    
    Configuration :
    * The option "Z39.50 Server" is added to the LinkerModule preference. You must
    choose this to use the new Linker.
    * The preference LinkerZ3950Server is required and specifies which server to
    use for linking. It must contain the "name" of the server, as defined in the
    z3950servers table.
    * You can set the "local_first" option in the LinkerOptions preference to force
    the Linker to search for authorities in the local database first. If no local
    authority match was found, the Linker falls back to a remote Z39.50 search.
    
    Sponsored-by: CCSR ( http://www.ccsr.qc.ca )
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 20:36:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 18:36:06 +0000
    Subject: [Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC
     templates
    In-Reply-To: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30570-70-DxkN4iqEfJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lucas at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 20:40:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 18:40:35 +0000
    Subject: [Koha-bugs] [Bug 30573] Do not hide "Total Tax Inc" on invoice
     details when tax has been charged
    In-Reply-To: <bug-30573-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30573-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30573-70-POd7NFF9xv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30573
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lucas at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 20:48:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 18:48:56 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-1F6C8yDcOC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                    URL|                            |https://gitlab.com/joubu/Ko
                       |                            |ha/-/commits/bug_30373
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 20:54:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 18:54:25 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-dKPLJru8Xu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #35 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    (In reply to Jonathan Druart from comment #25)
    > Fridolin, patches with signed-off-by lines are available at
    > https://gitlab.com/joubu/Koha/-/commits/bug_30373
    
    Hi, could you please apply last patch :
     Bug 30373: Fix visibility, authorised values and descriptions
    
    It does not work with 'git bz apply'
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 21:04:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 19:04:22 +0000
    Subject: [Koha-bugs] [Bug 9097] Add option to trigger 'Welcome mail' manually
    In-Reply-To: <bug-9097-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-9097-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-9097-70-4cILQ0dxHn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 21:04:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 19:04:25 +0000
    Subject: [Koha-bugs] [Bug 9097] Add option to trigger 'Welcome mail' manually
    In-Reply-To: <bug-9097-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-9097-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-9097-70-FFjl1FOU8C@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097
    
    --- Comment #24 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 21:04:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 19:04:29 +0000
    Subject: [Koha-bugs] [Bug 26370] Add ability to disable demagnetizing items
     via SIP2 for arbitrary patron categories
    In-Reply-To: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26370-70-mCcmES20FV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|This patch adds a new       |This patch adds a new
            released in|option to the SIP config,   |option to the SIP
                       |`inhouse_patron_categories` |config,22.05.00,
                       |. Adding a comma-separated  |`inhouse_patron_categories`
                       |list of patron category     |. Adding a comma-separated
                       |codes to this option will   |list of patron category
                       |cause the SIP checkout to   |codes to this option will
                       |never send the              |cause the SIP checkout to
                       |'demagnetize' command to    |never send the
                       |the checkout preventing     |'demagnetize' command to
                       |said users from removing    |the checkout preventing
                       |the items from the library. |said users from removing
                       |                            |the items from the library.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 21:04:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 19:04:31 +0000
    Subject: [Koha-bugs] [Bug 26370] Add ability to disable demagnetizing items
     via SIP2 for arbitrary patron categories
    In-Reply-To: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26370-70-lTHSaBPm9n@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370
    
    --- Comment #15 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 21:04:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 19:04:34 +0000
    Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface - <h1> on
     each page is Logo but should be page description/title
    In-Reply-To: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27631-70-KMSQjoAD50@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 21:04:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 19:04:36 +0000
    Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface - <h1> on
     each page is Logo but should be page description/title
    In-Reply-To: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27631-70-u617WT6ZqU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631
    
    --- Comment #134 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 21:04:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 19:04:39 +0000
    Subject: [Koha-bugs] [Bug 29005] Add option to send ACCTDETAILS notice for
     new patrons added via patron imports
    In-Reply-To: <bug-29005-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29005-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29005-70-uLSgr4ktzY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 21:04:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 19:04:42 +0000
    Subject: [Koha-bugs] [Bug 29005] Add option to send ACCTDETAILS notice for
     new patrons added via patron imports
    In-Reply-To: <bug-29005-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29005-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29005-70-xbtGvdJQDn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005
    
    --- Comment #21 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 21:04:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 19:04:45 +0000
    Subject: [Koha-bugs] [Bug 29420] HTTP status code incorrect when calling
     error pages directly under Plack/PSGI
    In-Reply-To: <bug-29420-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29420-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29420-70-nuHy2SOKDV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 21:04:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 19:04:48 +0000
    Subject: [Koha-bugs] [Bug 29420] HTTP status code incorrect when calling
     error pages directly under Plack/PSGI
    In-Reply-To: <bug-29420-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29420-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29420-70-oJPChcNGu8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420
    
    --- Comment #33 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 21:04:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 19:04:50 +0000
    Subject: [Koha-bugs] [Bug 30237] Rename/rephrase
     AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use
    In-Reply-To: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30237-70-X7ijcUTPvK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 21:04:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 19:04:53 +0000
    Subject: [Koha-bugs] [Bug 30237] Rename/rephrase
     AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use
    In-Reply-To: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30237-70-s3SCbjGVej@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237
    
    --- Comment #31 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 21:04:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 19:04:55 +0000
    Subject: [Koha-bugs] [Bug 30544] Add font awesome version to licenses page
    In-Reply-To: <bug-30544-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30544-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30544-70-IalVAEnhew@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30544
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 21:04:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 19:04:58 +0000
    Subject: [Koha-bugs] [Bug 30544] Add font awesome version to licenses page
    In-Reply-To: <bug-30544-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30544-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30544-70-5LiMQZFYdJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30544
    
    --- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 21:08:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 19:08:12 +0000
    Subject: [Koha-bugs] [Bug 26370] Add ability to disable demagnetizing items
     via SIP2 for arbitrary patron categories
    In-Reply-To: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26370-70-1jFnVTKQB6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
      Text to go in the|                            |This patch adds a new
          release notes|                            |option to the SIP config,
                       |                            |`inhouse_patron_categories`
                       |                            |. Adding a comma-separated
                       |                            |list of patron category
                       |                            |codes to this option will
                       |                            |cause the SIP checkout to
                       |                            |never send the
                       |                            |'demagnetize' command to
                       |                            |the checkout preventing
                       |                            |said users from removing
                       |                            |the items from the library.
             Version(s)|This patch adds a new       |22.05.00
            released in|option to the SIP           |
                       |config,22.05.00,            |
                       |`inhouse_patron_categories` |
                       |. Adding a comma-separated  |
                       |list of patron category     |
                       |codes to this option will   |
                       |cause the SIP checkout to   |
                       |never send the              |
                       |'demagnetize' command to    |
                       |the checkout preventing     |
                       |said users from removing    |
                       |the items from the library. |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 21:18:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 19:18:34 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-jlL7jXabyj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #36 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
    (In reply to Fridolin Somers from comment #35)
    > (In reply to Jonathan Druart from comment #25)
    > > Fridolin, patches with signed-off-by lines are available at
    > > https://gitlab.com/joubu/Koha/-/commits/bug_30373
    > 
    > Hi, could you please apply last patch :
    >  Bug 30373: Fix visibility, authorised values and descriptions
    > 
    > It does not work with 'git bz apply'
    
    Hi, you need to apply the last four patches over Jonathan's branch.
    The last patch depends on #29 and #30
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 21:21:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 19:21:22 +0000
    Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available
     items even if on shelf holds aren't allowed
    In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30556-70-U5aBwjGnMj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556
    
    --- Comment #1 from The Minh Luong <the-minh.luong at inlibro.com> ---
    Created attachment 133497
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133497&action=edit
    Bug 30556: Place hold button doesn't show when not allowed
    
    When On shelf holds holds allowed is on "If all unavailable", the Place hold
    button is not showed.
    
    To test:
    
    1. Create a circulation rule with on shelf holds set to "If all unavailable"
    2. Create or modify a record to match the items itype to the circulation rule
    3. Use a patron matching the circ rule category to log into the opac
    4. Look for the record
    5. Notice that the Place hold button is there, even thought it's not allowed
    6. Apply the patch.
    7. The button is not there.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 21:23:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 19:23:43 +0000
    Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface - <h1> on
     each page is Logo but should be page description/title
    In-Reply-To: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27631-70-hHnA8Y1kxo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
    
    --- Comment #135 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    I add to resolve some conflicts on patrons search due to Bug 30063
    
    I fixed to h1 to div in follow-up :
    https://git.koha-community.org/Koha-community/Koha/commit/05ba079814facb569feb9327992a1dc441753754
    
    Feel free to add some other follow-up if needed.
    
    Best regards,
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 21:33:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 19:33:59 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-qwGlY0z2s6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
    
    --- Comment #145 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    This follow-up looks nice.
    I have a branch prepared for push.
    Waiting for Mason about perl dep.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 21:45:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 19:45:40 +0000
    Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
     records
    In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17385-70-QSRsghPXCf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385
    
    The Minh Luong <the-minh.luong at inlibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132488|0                           |1
            is obsolete|                            |
    
    --- Comment #105 from The Minh Luong <the-minh.luong at inlibro.com> ---
    Created attachment 133498
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133498&action=edit
    Bug 17385: Add custom export XSLT
    
    Rebase
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 21:45:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 19:45:46 +0000
    Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
     records
    In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17385-70-IPislZp99g@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385
    
    The Minh Luong <the-minh.luong at inlibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132489|0                           |1
            is obsolete|                            |
    
    --- Comment #106 from The Minh Luong <the-minh.luong at inlibro.com> ---
    Created attachment 133499
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133499&action=edit
    Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder
    
    Performance: We need to return an empty list if OpacExportOptions does not
    contain Custom.  No need to scan the directory for custom files, if we are not
    using them at all.
    
    Note: The test only pertains to OPAC now, since the pref should not control
    intranet behavior. We have no intranet counterpart. See further next follow-up.
    
    Test plan:
    Run t/db_dependent/XSLT.t
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 21:45:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 19:45:52 +0000
    Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
     records
    In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17385-70-QoRONNNeUa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385
    
    The Minh Luong <the-minh.luong at inlibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132490|0                           |1
            is obsolete|                            |
    
    --- Comment #107 from The Minh Luong <the-minh.luong at inlibro.com> ---
    Created attachment 133500
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133500&action=edit
    Bug 17385: (QA follow-up) Add caching
    
    Performance: We should add caching in CustomXSLTExportList.
    
    Note: This resolves the lack of an intranet test in the former patch too.
    
    Test plan:
    Run t/db_dependent/XSLT.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 21:45:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 19:45:58 +0000
    Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
     records
    In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17385-70-J6QqnXSnYE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385
    
    The Minh Luong <the-minh.luong at inlibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132491|0                           |1
            is obsolete|                            |
    
    --- Comment #108 from The Minh Luong <the-minh.luong at inlibro.com> ---
    Created attachment 133501
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133501&action=edit
    Bug 17385: Add tests for CustomXSLTExportList
    
    Tests are now in one patch.
    One test does not pass and I am not able to fix it.
    
    The test who fails :
    
    <pre>
    $ prove -l t/db_dependent/XSLT.t
    t/db_dependent/XSLT.t .. 1/3
        #   Failed test 'This list comes from the cache and that is fine'
        #   at t/db_dependent/XSLT.t line 122.
        #          got: '1'
        #     expected: '2'
        # Looks like you failed 1 test of 1.
    
     #   Failed test 'CustomXSLTExportList: Caching'
     #   at t/db_dependent/XSLT.t line 124.
     # Looks like you failed 1 test of 3.
    t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100)
    Failed 1/3 subtests
    
    Test Summary Report
    -------------------
    t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1)
      Failed test:  2
      Non-zero exit status: 1
    Files=1, Tests=3,  3 wallclock secs ( 0.03 usr  0.00 sys +  1.74 cusr  0.14
    csys =  1.91 CPU)
    Result: FAIL
    </pre>
    
    This one works fine :
    
    <pre>
    $ prove -l t/XSLT.t
    t/XSLT.t .. ok
    All tests successful.
    Files=1, Tests=12,  4 wallclock secs ( 0.02 usr  0.00 sys +  2.55 cusr  0.17
    csys =  2.74 CPU)
    Result: PASS
    </pre>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 21:46:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 19:46:05 +0000
    Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
     records
    In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17385-70-5BOfaQcZyW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385
    
    The Minh Luong <the-minh.luong at inlibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132492|0                           |1
            is obsolete|                            |
    
    --- Comment #109 from The Minh Luong <the-minh.luong at inlibro.com> ---
    Created attachment 133502
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133502&action=edit
    Bug 17385: Add custum export format option when saving a record
    
    This patch adds "XSL-Simple Export" when saving a bibliographic
    record. Previous patches are combined into this one.
    
    To test:
    1) Search for a record in the intranet.
    2) Click on the "Save" button and observe the dropdown menu.
    3) Notice that "XSL- Simple Export" is not in the menu.
    4) Apply the patch.
    5) Repeat the steps 1 and 2.
    6) Notice that "XSL - Simple Export" is in the menu.
    7) Click on "XSL - Simple Export". A .html file should be downloaded.
    8) Open the .html file. You should see the record's informations.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 21:46:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 19:46:11 +0000
    Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
     records
    In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17385-70-zIQD9SNqf9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385
    
    The Minh Luong <the-minh.luong at inlibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132493|0                           |1
            is obsolete|                            |
    
    --- Comment #110 from The Minh Luong <the-minh.luong at inlibro.com> ---
    Created attachment 133503
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133503&action=edit
    Bug 17385: Correction of opac-detail-sidebar.inc
    
    This patch reverts the changes made in opac-detail-sidebar.inc, so the sidebar
    is
    displayed as wanted. Tests are now passing properly.
    
    TEST PLAN:
    1- Apply the patch and search for a record in the OPAC.
    2- Click on "Save record". Notice that the dropdown menu is unchanged.
    3- Run t/db_dependent/XSLT.t (All tests should pass)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 21:46:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 19:46:18 +0000
    Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
     records
    In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17385-70-JwEuFilMAk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385
    
    The Minh Luong <the-minh.luong at inlibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132581|0                           |1
            is obsolete|                            |
    
    --- Comment #111 from The Minh Luong <the-minh.luong at inlibro.com> ---
    Created attachment 133504
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133504&action=edit
    Bug 17385: Fixing display for XSL-Simple Export in OPAC
    
    This attachment correct the placement of XSL-Simple Export in the OPAC's page.
    It is now displayed in the "Save record" dropdown menu.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 21:59:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 19:59:00 +0000
    Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
    In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-12446-70-pVZvJPpVVx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
    
    The Minh Luong <the-minh.luong at inlibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Needs Signoff
    
    --- Comment #179 from The Minh Luong <the-minh.luong at inlibro.com> ---
    I tried to apply the patch and it seems to apply cleanly. I do not have any
    merge markers when I apply the patch. Did you make sure that your environment
    is up to date?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 21:59:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 19:59:36 +0000
    Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search
     result highlighting in the staff interface
    In-Reply-To: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20398-70-fKCGZsTkZ2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
      Text to go in the|This enhancement adds a new |This enhancement adds a new
          release notes|system preference           |system preference
                       |StaffHghlightWords. This    |StaffHighlightWords. This
                       |enables highlighting of     |enables highlighting of
                       |words in search results for |words in search results for
                       |the staff interface to be   |the staff interface to be
                       |turned on or off.           |turned on or off.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 22:11:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 20:11:57 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-L0VxKFVuud@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    --- Comment #94 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Thanks Zeno for another test, more eyes are always welcome.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 22:18:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 20:18:20 +0000
    Subject: [Koha-bugs] [Bug 14797] Cancelling orders with no alert to existing
     holds
    In-Reply-To: <bug-14797-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14797-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14797-70-FRGNFBA17g@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14797
    
    CB <balestrieri at monterey.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |balestrieri at monterey.org
    
    --- Comment #6 from CB <balestrieri at monterey.org> ---
    My current practice is to cancel the order and delete the Bib record when
    cancelling an item on order.  If we have another copy of the same item on the
    existing Bib record, koha will not let you delete the Bib record; it will only
    allow you to cancel the order for the item.  This should be fine as far as a
    hold is concerned, as the hold will now still be in place for the item
    currently in circulation.
    
    As such, koha will not allow you to cancel the order and delete the Bib record
    if there is a hold on the item (and this is the only item attached to the Bib
    record).  This automatically alerts me that there is a hold on the item.
    
    I do not find this "bug" to be an issue in my workflow or with koha.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 20 22:40:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 20:40:46 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-dOLpvyDKIt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    --- Comment #95 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    (In reply to Victor Grousset/tuxayo from comment #89)
    > The QA script complained about some existing missing filters. It's not from
    > the patch
    
    Actually they are new from the patch. And find-missing-filters.t is failing
    because of that. It's when changing the way of displaying the item link using
    KohaSpan.
    
    from:
    
    Item with barcode <a
    href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% m.biblionumber |
    uri %]&itemnumber=[% m.itemnumber | uri %]">[% m.barcode | html %]</a> cannot
    be deleted:
    
    to:
    
    [% item_link = BLOCK %]<a
    href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% m.biblionumber |
    uri %]&itemnumber=[% m.itemnumber | uri %]">[% m.barcode | html %]</a>[% END %]
    
    <span>Item with barcode [% item_link | $KohaSpan%] cannot be deleted:</span>
    
    --------
    
    Actually it's a false positive because when assigning item_link, variables
    already go though a filter. Anyway to make the check happy which filter to use?
    raw?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 00:14:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 22:14:55 +0000
    Subject: [Koha-bugs] [Bug 29537] Simplify auto-renewal code in
     CanBookBeRenewed
    In-Reply-To: <bug-29537-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29537-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29537-70-nWj1E2xfoF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 00:15:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 22:15:01 +0000
    Subject: [Koha-bugs] [Bug 29537] Simplify auto-renewal code in
     CanBookBeRenewed
    In-Reply-To: <bug-29537-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29537-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29537-70-JAOAR6HYRG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132129|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from David Nind <david at davidnind.com> ---
    Created attachment 133505
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133505&action=edit
    Bug 29537: Remove unnecessary if-else checks for soonest renew date
    
    GetSoonestRenewDate() calculates the renewal due date now also
    correctly for auto-renewals after the fixes from bug 29476 so we don't
    have to add any if-else checks because of it being buggy anymore.
    
    To test:
     1) prove t/db_dependent/Circulation.t
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 01:37:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 23:37:33 +0000
    Subject: [Koha-bugs] [Bug 30482] Potential for bad string concatenation in
     cataloging validation error message
    In-Reply-To: <bug-30482-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30482-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30482-70-GjYnouF9lm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30482
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 01:37:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 20 Apr 2022 23:37:39 +0000
    Subject: [Koha-bugs] [Bug 30482] Potential for bad string concatenation in
     cataloging validation error message
    In-Reply-To: <bug-30482-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30482-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30482-70-5bgl7kZq95@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30482
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133062|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from David Nind <david at davidnind.com> ---
    Created attachment 133506
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133506&action=edit
    Bug 30482: Potential for bad string concatenation in cataloging validation
    error message
    
    In validating the basic MARC editor form before submission, we run
    AreFieldsNotOk() twice (once with the parameter "false") and concatenate
    the result for output. This creates the potential for the error string
    to be appended with "0" if AreFieldsNotOk() returns false.
    
    This patch improves the logic around building the error string.
    
    To test, apply the patch and make sure one of your MARC frameworks
    contains at least one mandatory field and at least one important field.
    
    - Edit or create a MARC record in the basic MARC editor.
    - Submit the form in various states of completion:
      - If a mandatory and an important field are empty, you should see two
        error messages at the top. "The following mandatory subfields aren't
        filled" and "The following important subfields aren’t filled."
      - If a mandatory OR an important field is empty, you should see a
        single message.
        - If it's the important field which is empty, a confirmation will
          ask if you want to save the record anyway. Test that both answers
          to this confirmation work correctly.
      - If no mandatory or important fields are empty the form should
        submit.
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 02:44:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 00:44:54 +0000
    Subject: [Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when
     adding/editing items
    In-Reply-To: <bug-29815-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29815-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29815-70-YAdpE1njla@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
    
    --- Comment #12 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Makes sens.
    For a total free input, one must not use this value builder.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 02:48:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 00:48:43 +0000
    Subject: [Koha-bugs] [Bug 25029] AllowPatronToControlAutorenewal needs to
     have a disable setting
    In-Reply-To: <bug-25029-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25029-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25029-70-R9eVLHi6ba@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30226
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 02:48:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 00:48:43 +0000
    Subject: [Koha-bugs] [Bug 30226] Add system preference to disable auto-renew
     checkbox at checkout
    In-Reply-To: <bug-30226-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30226-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30226-70-LLvJ9yCfIR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=25029
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 03:02:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 01:02:51 +0000
    Subject: [Koha-bugs] [Bug 30226] Add system preference to disable auto-renew
     checkbox at checkout
    In-Reply-To: <bug-30226-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30226-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30226-70-KKEQWW1EdF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226
    
    --- Comment #11 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Created attachment 133507
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133507&action=edit
    Bug 30226: (follow-up) Remove text from database update
    
    The text displayed by database update is not really helpful.
    And it will be incorrect if update is run several times.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 03:19:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 01:19:16 +0000
    Subject: [Koha-bugs] [Bug 30288] Provide links to OPACUserJS and OPACUserCSS
     in tools
    In-Reply-To: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30288-70-iaikwmysX5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
    
    --- Comment #9 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Ah this patch adds pipes as separator.
    
    Please use CSS for this, like in #moresearches :
    
    https://git.koha-community.org/Koha-community/Koha/src/commit/833c9efee0c0e01a0223318b578efa77272ed958/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss#L377
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 03:24:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 01:24:58 +0000
    Subject: [Koha-bugs] [Bug 27470] Improve link text for logging in
    In-Reply-To: <bug-27470-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27470-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27470-70-EwepAJyehp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27470
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Patch doesn't apply         |Needs Signoff
       Patch complexity|---                         |String patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 03:25:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 01:25:03 +0000
    Subject: [Koha-bugs] [Bug 27470] Improve link text for logging in
    In-Reply-To: <bug-27470-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27470-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27470-70-xybdQPsZQf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27470
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #115402|0                           |1
            is obsolete|                            |
     Attachment #115403|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Created attachment 133508
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133508&action=edit
    Bug 27470: Improved link text for shibboleth login
    
    TEST PLAN:
    1) Enable shibboleth by adding shibboleth to koha-conf.xml, you can do
    this by following
    
    https://wiki.koha-community.org/wiki/Shibboleth_Configuration#Using_AD_FS_Metadata
    
    2) If you are logged in Koha, log out, on the login screen the text
    at the top should say the following, "Log in using a Shibboleth account"
    
    Sponsored-by: Catalyst IT
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 03:44:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 01:44:24 +0000
    Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and
     list displays and e-mails
    In-Reply-To: <bug-16522-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-16522-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-16522-70-Egd9LqRSIU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 03:44:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 01:44:29 +0000
    Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and
     list displays and e-mails
    In-Reply-To: <bug-16522-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-16522-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-16522-70-Cp7sqxD5MY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #130250|0                           |1
            is obsolete|                            |
    
    --- Comment #11 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Created attachment 133509
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133509&action=edit
    Bug 16522: Adding 773 to cart and list displays and emails
    
    This patch adds a new subroutine get_host_item_entries in the
    Koha::Biblio module which retrieves any 773 fields from the biblio
    record. The subroutine is used to show a host item entry and a link to
    the record in the following places:
    - staff client list
    - staff client cart
    - staff client send list email
    - staff client send cart email
    - opac list
    - opac cart
    - opac send list email email
    - opac send cart email
    
    To test:
    
    1. apply patch, restart services
    2. log into the staff client and enable the syspref EasyAnalyticalRecords
    3. find a record with an item. take note of the barcode.
    4. go to another record (biblio 2). click Edit -> Link to host record
    5. enter the barcode in the input and submit.
    6. click the MARC tab and confirm the host record has been linked under
    MARC field 773.
    7. add biblio 2 to your cart, and to a list.
    8. go to your cart. confirm you see the 'host item entry' link.
    9. click on 'more details' and confirm you see the 'host item entries'
    link.
    10. click 'send' to email the cart. confirm the email contains the host
    item entry and the link sends you to the catalogue page for the record
    in the OPAC.
    11. go to the list you added the record to. confirm you see the 'source'
    link for the host item entry.
    12. click 'send list' to email the list. confirm the email contains the
    host item entry and the link sends you to the catalogue page for the
    record in the OPAC.
    13. log into the OPAC. repeat steps 7 to 12 on the OPAC and confirm they
    all pass as expected.
    14. confirm tests pass: t/db_dependent/Koha/Biblio.t
    
    Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 04:10:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 02:10:03 +0000
    Subject: [Koha-bugs] [Bug 30288] Provide links to OPACUserJS and OPACUserCSS
     in tools
    In-Reply-To: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30288-70-cTUdZok1nr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 04:10:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 02:10:08 +0000
    Subject: [Koha-bugs] [Bug 30288] Provide links to OPACUserJS and OPACUserCSS
     in tools
    In-Reply-To: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30288-70-r2OFOIHR8D@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288
    
    --- Comment #10 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Created attachment 133510
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133510&action=edit
    Bug 30288: (follow-up) Use CSS for separator pipes
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 04:39:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 02:39:02 +0000
    Subject: [Koha-bugs] [Bug 30326] Cronjob that checks biblios for MARC errors
    In-Reply-To: <bug-30326-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30326-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30326-70-0eztttSfDL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30326
    
    --- Comment #6 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    (In reply to Tomás Cohen Arazi from comment #5)
    > 3. I suggest you add a --where parameter, that is passed as a literal query
    > to 
    > 
    > Koha::Biblios->search( $query, { prefetch => ['biblio_metadata'] } );
    > 
    > and use $biblio->metadata->record instead of GetMarcBiblio.
    
    I thought about doing it this way but it's significantly slower, not ideal when
    there are lots of biblios to check through.
    
    I can implement the other suggestions.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 04:43:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 02:43:16 +0000
    Subject: [Koha-bugs] [Bug 30326] Cronjob that checks biblios for MARC errors
    In-Reply-To: <bug-30326-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30326-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30326-70-WB9XJ3btrj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30326
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 04:43:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 02:43:23 +0000
    Subject: [Koha-bugs] [Bug 30326] Cronjob that checks biblios for MARC errors
    In-Reply-To: <bug-30326-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30326-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30326-70-F8TkqG4dnD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30326
    
    --- Comment #7 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Created attachment 133511
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133511&action=edit
    Bug 30326: (follow-up) Add output parameter and handle bad biblionumbers
    
    When the script is run without the --html parameter, the output will be
    simply text. When the script is run with the --html parameter, the
    output will display in an HTML table.
    
    Additional test plan:
    
    5. Test running script with and without --html parameter and confirm
    output is correct.
    
    6. Test running script with a --bibnum that does not exist and confirm
    the output acknowledges this.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 05:07:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 03:07:19 +0000
    Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck
     modules for Koha
    In-Reply-To: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30444-70-i5bp1jAY1s@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 05:07:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 03:07:24 +0000
    Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck
     modules for Koha
    In-Reply-To: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30444-70-wfEXlKYCMD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133419|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Created attachment 133512
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133512&action=edit
    Bug 30444: Add shibboleth login to self checkout
    
    This patch adds a 'Shibboleth' option to the SelfCheckoutByLogin system
    preference. When 'Shibboleth' is selected the user should be logged
    straight into the self check module - assuming the AutoSelfCheckAllowed,
    AutoSelfCheckID and AutoSelfCheckPass system preferences are set.
    
    Test plan:
    
    1. Have your Koha setup to do Shibboleth login
    2. Set the following system preferences:
    - AutoSelfCheckAllowed => 'Allow'
    - AutoSelfCheckId and AutoSelfCheckPass => Set these to a patron with
    'circulate' permissions
    - WebBasedSelfCheck -> 'Enable'
    - OpacShibOnly -> "Don't allow"
    3. Visit the self checkout page /cgi-bin/koha/sco/sco-main.pl and notice
    a local login page loads
    4. Apply patchset, update database and restart services
    5. Set the new syspref:
    - SelfCheckoutByLogin -> 'Shibboleth'
    6. Visit the self checkout page and notice you're logged into the sco
    interface straight away, without the local login page loading
    
    Sponsored-by: Catalyst IT
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 06:01:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 04:01:59 +0000
    Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck
     modules for Koha
    In-Reply-To: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30444-70-Y9VRqkneF9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133512|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Created attachment 133513
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133513&action=edit
    Bug 30444: Add shibboleth login to self checkout
    
    This patch adds a 'Shibboleth' option to the SelfCheckoutByLogin system
    preference. When 'Shibboleth' is selected the user should be logged
    straight into the self check module - assuming the AutoSelfCheckAllowed,
    AutoSelfCheckID and AutoSelfCheckPass system preferences are set.
    
    Test plan:
    
    1. Have your Koha setup to do Shibboleth login
    2. Set the following system preferences:
    - AutoSelfCheckAllowed => 'Allow'
    - AutoSelfCheckId and AutoSelfCheckPass => Set these to a patron with
    'circulate' permissions
    - WebBasedSelfCheck -> 'Enable'
    - OpacShibOnly -> "Don't allow"
    3. Visit the self checkout page /cgi-bin/koha/sco/sco-main.pl and notice
    a local login page loads
    4. Apply patchset, update database and restart services
    5. Set the new syspref:
    - SelfCheckoutByLogin -> 'Shibboleth'
    6. Visit the self checkout page and notice you're logged into the sco
    interface straight away, without the local login page loading
    
    Sponsored-by: Catalyst IT
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 06:08:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 04:08:38 +0000
    Subject: [Koha-bugs] [Bug 28512] spinelabel-print.tt should include the
     logged in branchcode
    In-Reply-To: <bug-28512-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28512-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28512-70-rpk6gk5Xmb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 06:08:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 04:08:42 +0000
    Subject: [Koha-bugs] [Bug 28512] spinelabel-print.tt should include the
     logged in branchcode
    In-Reply-To: <bug-28512-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28512-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28512-70-Np73w9G7lC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #121607|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Created attachment 133514
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133514&action=edit
    Bug 28512: add logged in branch as class to spinelabel-print.tt body
    
    To test:
    -Apply patch and generate a quick spine label.
    -Inscept the page and notice that the body should contain a new class which
    corresponds with that the of the logged in branch.
    
    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 06:20:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 04:20:27 +0000
    Subject: [Koha-bugs] [Bug 29077] Warns when searching blank index
    In-Reply-To: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29077-70-PmqpkdhjGv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29077
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 06:20:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 04:20:32 +0000
    Subject: [Koha-bugs] [Bug 29077] Warns when searching blank index
    In-Reply-To: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29077-70-0f0z4WJ5Xy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29077
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #125132|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Created attachment 133515
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133515&action=edit
    Bug 29077: Remove blank indexes before convert
    
    To test:
    1 - Be using Elasticsearch
    2 - Search on OPAC with dropdown set to 'Library catalog'
    3 - Warns in plack-opac-error.log
    4 - Apply patch
    5 - Repeat
    6 - No warns
    7 - Search returns correct results
    
    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 06:22:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 04:22:42 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-LtK3G2PtPu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    --- Comment #146 from Mason James <mtj at kohaaloha.com> ---
    Created attachment 133516
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133516&action=edit
    Bug 28786: add Auth::GoogleAuth module to cpanfile
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 06:24:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 04:24:10 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-33bi4XqYjE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    --- Comment #147 from Mason James <mtj at kohaaloha.com> ---
    (In reply to Fridolin Somers from comment #145)
    > This follow-up looks nice.
    > I have a branch prepared for push.
    > Waiting for Mason about perl dep.
    
    hi Frido, i've added a patch for the dep
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 06:30:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 04:30:21 +0000
    Subject: [Koha-bugs] [Bug 20615] Add the link of number of times the
     authority are used in edit mode
    In-Reply-To: <bug-20615-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20615-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20615-70-zh95BasbHV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |aleisha at catalyst.net.nz
                 Status|Needs Signoff               |Signed Off
    
    --- Comment #10 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Looks like this was signed off so adjusting bug status.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 06:33:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 04:33:02 +0000
    Subject: [Koha-bugs] [Bug 30196] Odd number of elements warning caused by
     dt_from_string
    In-Reply-To: <bug-30196-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30196-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30196-70-rKJnmSpNzN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30196
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |aleisha at catalyst.net.nz
                 Status|Needs Signoff               |ASSIGNED
    
    --- Comment #2 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Can you please attach a test plan?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 06:42:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 04:42:05 +0000
    Subject: [Koha-bugs] [Bug 29057] Use font awesome icons on request.pl
    In-Reply-To: <bug-29057-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29057-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29057-70-lBMWbwYBjq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |ASSIGNED
                     CC|                            |aleisha at catalyst.net.nz
    
    --- Comment #19 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    It sounds like this is not yet ready for testing and awaiting a new patch?
    Adjusting bug status - feel free to change back if I'm wrong
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 06:50:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 04:50:48 +0000
    Subject: [Koha-bugs] [Bug 28082] Add acquisitions toolbar to vendors on
     vendor search page
    In-Reply-To: <bug-28082-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28082-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28082-70-BI5LrVoaYW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28082
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 06:50:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 04:50:53 +0000
    Subject: [Koha-bugs] [Bug 28082] Add acquisitions toolbar to vendors on
     vendor search page
    In-Reply-To: <bug-28082-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28082-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28082-70-lYhMcatPdN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28082
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131986|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Created attachment 133517
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133517&action=edit
    Bug 28082: Add acquisitions toolbar to vendors on vendor search page
    
    This patch makes a number of changes to the vendor search/view template
    in order to make it work better in different contexts:
    
    - Add a vendor-specific toolbar under each vendor search result. This
      gives instant access to the options for a new basket, new contract,
      vendor edit, or to receive shipments. A delete button will appear if
      available.
    - Add a summary of the number of baskets and subscriptions. This helps
      the user know if there are closed baskets and whether an outstanding
      subscription might be blocking the option to delete. Each number is
      linked to the view of those entries.
    - Indicate whether a vendor is inactive. The vendor name appears in a
      different color when it is inactve and is labeled as such.
    
    To test, apply the patch and rebuild the staff interface CSS
    (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
    
    - To test you should have multiple vendors in your system, some active
      and some inactive. Add some baskets and subscriptions to one or more
      if necessary.
    - Go to Acquisitions and submit an empty vendor search to show all
      vendors.
    - Verify that the page looks correct and that all controls work as
      expected.
    - Open the basket view for a single vendor and compare the two views.
    
    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 07:33:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 05:33:30 +0000
    Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck
     modules for Koha
    In-Reply-To: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30444-70-dNPIr7QIzp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444
    
    Alex Buckley <alexbuckley at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133513|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 07:34:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 05:34:13 +0000
    Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck
     modules for Koha
    In-Reply-To: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30444-70-Q8wKnCuWJI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444
    
    --- Comment #4 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
    Created attachment 133518
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133518&action=edit
    Bug 30444: Add shibboleth login to self checkout
    
    This patch adds a 'Shibboleth' option to the SelfCheckoutByLogin system
    preference. When 'Shibboleth' is selected the user should be logged
    straight into the self check module - assuming the AutoSelfCheckAllowed,
    AutoSelfCheckID and AutoSelfCheckPass system preferences are set.
    
    Test plan:
    
    1. Have your Koha setup to do Shibboleth login
    2. Set the following system preferences:
    - AutoSelfCheckAllowed => 'Allow'
    - AutoSelfCheckId and AutoSelfCheckPass => Set these to a patron with
    'circulate' permissions
    - WebBasedSelfCheck -> 'Enable'
    - OpacShibOnly -> "Don't allow"
    3. Visit the self checkout page /cgi-bin/koha/sco/sco-main.pl and notice
    a local login page loads
    4. Apply patchset, update database and restart services
    5. Set the new syspref:
    - SelfCheckoutByLogin -> 'Shibboleth'
    6. Visit the self checkout page and notice you're logged into the sco
    interface straight away, without the local login page loading
    
    Sponsored-by: Catalyst IT
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 08:13:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 06:13:01 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-xHbiTL4mkF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #37 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Ah sorry does not work.
    
    I see Jonathan's branch contains until patch "Show 325$a".
    
    git bz apply shows error :
    
    Applying: Bug 30373: Fix visibility, authorised values and descriptions
    error: sha1 information is lacking or useless
    (installer/data/mysql/en/marcflavour/unimarc/mandatory/unimarc_framework_DEFAULT.yml).
    error: could not build fake ancestor
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 08:20:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 06:20:24 +0000
    Subject: [Koha-bugs] [Bug 30574] New: Cannot add patron
    Message-ID: <bug-30574-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30574
    
                Bug ID: 30574
               Summary: Cannot add patron
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Patrons
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: manojshahu07 at gmail.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
    
    Created attachment 133519
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133519&action=edit
    Cannot add patron There are no patron categories defined. An administrator must
    define at least one patron category.
    
    Error while creating a new patron.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 08:22:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 06:22:12 +0000
    Subject: [Koha-bugs] [Bug 30574] Cannot add patron
    In-Reply-To: <bug-30574-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30574-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30574-70-D8Co6pyDLp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30574
    
    Manoj <manojshahu07 at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Priority|P5 - low                    |P1 - high
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 08:29:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 06:29:19 +0000
    Subject: [Koha-bugs] [Bug 29092] Table Settings for account_fines table
     missing Updated On column and hide the wrong things
    In-Reply-To: <bug-29092-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29092-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29092-70-Io0gadnJbW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29092
    
    Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |emmi.takkinen at koha-suomi.fi
                       |ity.org                     |
                 Status|NEW                         |Needs Signoff
                     CC|                            |emmi.takkinen at koha-suomi.fi
    
    --- Comment #1 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
    Created attachment 133520
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133520&action=edit
    Bug 29092: Add timestamp to account-fines table column settings
    
    Table settings for the account_fines table (in the Patrons
    section, the "Transactions" table in a patron account) are
    missing a checkbox for the "Updated On" column. Because
    of this, one cannot hide the Updated On column and any
    other values one sets here get applied to the wrong
    columns.
    
    This patch adds timestamp to account-fines column settings.
    To test:
    
    1) Navigate to columns settings page and modify
    account-fines tables column.
    => Note that if you hide e.g. account_type column, column
    credit_number is hidden on patrons account page
    2) Apply patch and update database.
    => Account-fines column settings has now a option to hide
    timestamp.
    => Correct columns should now be hidden.
    
    Sponsored-by: Koha-Suomi Oy
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 08:32:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 06:32:16 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-aCmZ8RAh2U@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    --- Comment #148 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    (In reply to Mason James from comment #147)
    > (In reply to Fridolin Somers from comment #145)
    > > This follow-up looks nice.
    > > I have a branch prepared for push.
    > > Waiting for Mason about perl dep.
    > 
    > hi Frido, i've added a patch for the dep
    
    Super fast, thanks ;)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 08:43:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 06:43:47 +0000
    Subject: [Koha-bugs] [Bug 18392] Allow exporting circulation conditions as
     CSV or spreadsheet
    In-Reply-To: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18392-70-xq8UaIl5Za@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 08:43:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 06:43:50 +0000
    Subject: [Koha-bugs] [Bug 18392] Allow exporting circulation conditions as
     CSV or spreadsheet
    In-Reply-To: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18392-70-RwSIo8qD0d@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392
    
    --- Comment #9 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 08:43:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 06:43:53 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-SOAn5NHBxd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 08:43:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 06:43:56 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-d3vyOqoiQV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    --- Comment #149 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 08:43:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 06:43:59 +0000
    Subject: [Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when
     adding/editing items
    In-Reply-To: <bug-29815-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29815-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29815-70-lf5IpUqmTU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 08:44:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 06:44:01 +0000
    Subject: [Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when
     adding/editing items
    In-Reply-To: <bug-29815-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29815-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29815-70-cDZ8zobDco@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815
    
    --- Comment #13 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 08:44:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 06:44:04 +0000
    Subject: [Koha-bugs] [Bug 30204] Add subtitle to serial subscription search
    In-Reply-To: <bug-30204-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30204-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30204-70-iFK8AWHoOr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 08:44:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 06:44:06 +0000
    Subject: [Koha-bugs] [Bug 30204] Add subtitle to serial subscription search
    In-Reply-To: <bug-30204-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30204-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30204-70-PP9oQVM85e@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204
    
    --- Comment #10 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 08:44:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 06:44:09 +0000
    Subject: [Koha-bugs] [Bug 30205] Add biblio.subtitle to the
     subscription-detail.pl page
    In-Reply-To: <bug-30205-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30205-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30205-70-wXyAgnR7in@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 08:44:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 06:44:12 +0000
    Subject: [Koha-bugs] [Bug 30205] Add biblio.subtitle to the
     subscription-detail.pl page
    In-Reply-To: <bug-30205-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30205-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30205-70-tRM4huELtq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205
    
    --- Comment #8 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 08:44:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 06:44:14 +0000
    Subject: [Koha-bugs] [Bug 30226] Add system preference to disable auto-renew
     checkbox at checkout
    In-Reply-To: <bug-30226-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30226-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30226-70-ghyv53cDHS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 08:44:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 06:44:17 +0000
    Subject: [Koha-bugs] [Bug 30226] Add system preference to disable auto-renew
     checkbox at checkout
    In-Reply-To: <bug-30226-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30226-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30226-70-pi9AqPtHnC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226
    
    --- Comment #12 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 08:44:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 06:44:20 +0000
    Subject: [Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap
     (amount) results in data loss and extra fines
    In-Reply-To: <bug-30346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30346-70-CgeHM3wAqj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 08:44:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 06:44:22 +0000
    Subject: [Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap
     (amount) results in data loss and extra fines
    In-Reply-To: <bug-30346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30346-70-6Vq07WuHgr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346
    
    --- Comment #7 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 08:50:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 06:50:56 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-o0CJG4pgQZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133495|0                           |1
            is obsolete|                            |
    
    --- Comment #96 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Comment on attachment 133495
      --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133495
    Bug 29602: (follow-up) Fix TemplateToolkit test
    
    Thanks for the followup.
    
    I had already fixed.
    I prefer to edit the include to avoid adding surrounding span :
    
    https://git.koha-community.org/Koha-community/Koha/commit/f55b16145c96167afc63784447cdb8420d49dbae
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 08:51:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 06:51:12 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-SJjDQbLmRe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|additional_work_needed      |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 08:55:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 06:55:54 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-7jJRanx6A5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    --- Comment #97 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133521
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133521&action=edit
    Bug 29602: (follow-up) Fix missing filters
    
    $KohaSpan is not seen as a filter by xt/find-missing-filters.t and thus
    we need to filter the block variables before passing them to $KohaSpan
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 09:15:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 07:15:10 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-ZCec8EO1wH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133521|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 09:15:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 07:15:23 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-Jl0jTtcZ8E@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    --- Comment #98 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    You also fixed that one, thanks
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 09:22:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 07:22:49 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-fBjs1I0cDg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    --- Comment #150 from Mason James <mtj at kohaaloha.com> ---
    Created attachment 133522
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133522&action=edit
    decrease Auth::GoogleAuth version to 1.02
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 10:18:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 08:18:29 +0000
    Subject: [Koha-bugs] [Bug 20511] Seasonal prediction just in the staff
     language
    In-Reply-To: <bug-20511-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20511-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20511-70-7tiLoUPloh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511
    
    --- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Yes, it should work if "Summer" is translated in the po file.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 10:41:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 08:41:12 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-BmpodEwiQ0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133317|0                           |1
            is obsolete|                            |
    
    --- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133523
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133523&action=edit
    Bug 28998: Introduce Koha::Encryption
    
    Test plan:
    Run t/db_dependent/Koha/Encryption.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    [AMENDED] Added copyright line to module.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 10:41:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 08:41:17 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-UE8a1nsSyM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133318|0                           |1
            is obsolete|                            |
    
    --- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133524
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133524&action=edit
    Bug 28998: (follow-up) Add Patron->encode_secret and ->decoded_secret
    
    Test plan:
    Run t/db_dependent/Koha/Patron.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 10:41:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 08:41:21 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-v35rUtDzkP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133319|0                           |1
            is obsolete|                            |
    
    --- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133525
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133525&action=edit
    Bug 28998: (follow-up) Apply changes to TwoFactorAuth module and script
    
    Test plan:
    Run t/db_dependent/Koha/Auth/TwoFactorAuth.t
    Walk thru cycle register - logout/login - deregister - logout/login.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 10:41:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 08:41:26 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-9XK1SrpwxK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133320|0                           |1
            is obsolete|                            |
    
    --- Comment #24 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133526
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133526&action=edit
    Bug 28998: Adjust Selenium test
    
    Test plan:
    Run t/db_dependent/selenium/authentication_2fa.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 10:41:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 08:41:30 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-XTNdTQHzBL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133321|0                           |1
            is obsolete|                            |
    
    --- Comment #25 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133527
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133527&action=edit
    Bug 28998: [TO_BE_SQUASHED] Adjust secret in Selenium test
    
    This patch can be squashed with the previous one, if all is ok.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 10:41:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 08:41:34 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-tTQkcpoaOD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133322|0                           |1
            is obsolete|                            |
    
    --- Comment #26 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133528
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133528&action=edit
    Bug 28998: Add encryption_key to the config file
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 10:41:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 08:41:39 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-mQZbhvrxX2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133323|0                           |1
            is obsolete|                            |
    
    --- Comment #27 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133529
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133529&action=edit
    Bug 28998: Add Crypt::CBC dependency
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 10:42:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 08:42:26 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-zJwTbkvVSj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    --- Comment #28 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Trivial rebase on Patron
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 11:04:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 09:04:12 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-DJQsSjlNqA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Patch doesn't apply
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 11:17:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 09:17:11 +0000
    Subject: [Koha-bugs] [Bug 24161] Add ability to track the claim dates of
     later orders
    In-Reply-To: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24161-70-n3S0UJmRuC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
    
    --- Comment #76 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    (In reply to Katrin Fischer from comment #75)
    > (In reply to Jonathan Druart from comment #74)
    > > (In reply to Katrin Fischer from comment #73)
    > > Looks like the following line
    > > 22065                 $insert_claim_sth->execute($order->{ordernumber},
    > > $order->{claimed_on});
    > > should have used $order->{claimed_on} instead.
    > 
    > Did you mean claimed_date maybe?
    
    Yes!...
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 11:19:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 09:19:23 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-BgmBBZHrYQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com
    
    --- Comment #20 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    How hard would it be to switch to v5?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 11:26:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 09:26:29 +0000
    Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors
     to a record
    In-Reply-To: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14570-70-TsNEINojUa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570
    
    --- Comment #251 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    It seems that the following occurrences of "guarantorid" should have been
    removed:
    
    koha-tmpl/intranet-tmpl/prog/en/includes/patronfields.inc:     [%- CASE
    'guarantorid' -%]<span>Guarantor ID</span>
    
    koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt:                 
                          <a class="btn btn-default btn-xs"
    href="memberentry.pl?op=modify&borrowernumber=[% patron.borrowernumber |
    html %]&step=1&guarantorid=[% guarantor.borrowernumber | html %]"><i
    class="fa fa-pencil"></i> Edit</a>
    
    t/db_dependent/Koha/Patrons.t:                guarantorid =>
    $guarantor->borrowernumber
    
    t/db_dependent/Koha/Patrons.t:                guarantorid =>
    $guarantor->borrowernumber
    
    t/lib/TestBuilder.pm:        # skip when FK points to itself: e.g.
    borrowers:guarantorid
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 11:27:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 09:27:31 +0000
    Subject: [Koha-bugs] [Bug 30534] borrowers.guarantorid not present on
     database
    In-Reply-To: <bug-30534-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30534-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30534-70-LTUZY5U9u4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30534
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 11:27:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 09:27:36 +0000
    Subject: [Koha-bugs] [Bug 30534] borrowers.guarantorid not present on
     database
    In-Reply-To: <bug-30534-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30534-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30534-70-K5vMDm08Aq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30534
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133398|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133530
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133530&action=edit
    Bug 30534: Remove guarantor_id attribute from the patron object
    
    This patch removes an attribute that was actually removed 3 years ago
    and causes an exception when trying to search for it. The API responses
    don't include it anyways.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 11:28:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 09:28:27 +0000
    Subject: [Koha-bugs] [Bug 30534] borrowers.guarantorid not present on
     database
    In-Reply-To: <bug-30534-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30534-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30534-70-67FSKu6Dsj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30534
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com
    
    --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    There are more occurrences that haven't been removed, see bug 14570 comment 251
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 11:43:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 09:43:39 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-nNx7jizdmX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    --- Comment #151 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133531
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133531&action=edit
    Bug 28786: Don't set auth_method to NULL in ->anonymize
    
    DBI Exception: DBD::mysql::st execute failed: Column 'auth_method' cannot be
    null
    
    caught by t/db_dependent/Koha/Patrons.t
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 11:44:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 09:44:20 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-YPmCTq7G55@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |additional_work_needed
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 11:45:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 09:45:51 +0000
    Subject: [Koha-bugs] [Bug 27750] Remove jquery.cookie.js plugin
    In-Reply-To: <bug-27750-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27750-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27750-70-hnoVEDmtvH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27750
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 11:45:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 09:45:56 +0000
    Subject: [Koha-bugs] [Bug 27750] Remove jquery.cookie.js plugin
    In-Reply-To: <bug-27750-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27750-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27750-70-Mu8ne6dvKj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27750
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133277|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133532
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133532&action=edit
    Bug 27750: Remove jquery.cookie.js plugin
    
    This patch removes references to the jquery.cookie.js plugin which is
    now unused, replaced by js-cookie.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 11:46:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 09:46:31 +0000
    Subject: [Koha-bugs] [Bug 27750] Remove jquery.cookie.js plugin
    In-Reply-To: <bug-27750-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27750-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27750-70-XWfaGTUcI0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27750
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 11:46:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 09:46:51 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-mGoQsPhyR7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #38 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
    (In reply to Fridolin Somers from comment #37)
    > Ah sorry does not work.
    > 
    > I see Jonathan's branch contains until patch "Show 325$a".
    > 
    > git bz apply shows error :
    > 
    > Applying: Bug 30373: Fix visibility, authorised values and descriptions
    > error: sha1 information is lacking or useless
    > (installer/data/mysql/en/marcflavour/unimarc/mandatory/
    > unimarc_framework_DEFAULT.yml).
    > error: could not build fake ancestor
    
    Strange. Using Jonathan's remote, I don't find any problem.
    
    $ git fetch joubu
    $ git checkout -b bz30373 joubu/bug_30373
      Rama 'bz30373' configurada para hacer seguimiento a la rama remota
    'bug_30373' de 'joubu'.
      Cambiado a nueva rama 'bz30373'
    $ git log --oneline | head -8
      01eba5253d Bug 30373: Show 325$a
      88798576db Bug 30373: Hide items.dateaccessioned from the editor
      5e4e37c704 Bug 30477: Add new UNIMARC installer translation files
      b81b2c107b Bug 30373: Enable translation of UNIMARC frameworks
      b57c4ea2bd Bug 30373: Rewrite authorities_normal_unimarc to YAML
      60106a4780 Bug 30373: Add UNIMARC FA (fast add) framework
      8ca3f24f4b Bug 30373: Rewrite unimarc_framework_DEFAULT to YAML
      3dd12b8ea2 Bug 30476: Remove NORMARC translation files
    $ git bz apply 30373
    
      Bug 30373 - Rewrite UNIMARC installer data to YAML
    
      132280 - Bug 30373: Add UNIMARC FA (fast add) framework
      132282 - Bug 30373: Enable translation of UNIMARC frameworks
      133059 - Bug 30373: Hide items.dateaccessioned from the editor
      133060 - Bug 30373: Show 325$a
      133126 - Bug 30373: Add TYPEDOC authorised_values_category
      133127 - Bug 30373: Fix visibility, authorised values and descriptions
    
      Apply? [(y)es, (n)o, (i)nteractive] i
      Aplicando: Bug 30373: Add TYPEDOC authorised_values_category
      Aplicando: Bug 30373: Fix visibility, authorised values and descriptions
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 11:49:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 09:49:09 +0000
    Subject: [Koha-bugs] [Bug 30550] OPAC recalls page tries to use jQueryUI
     datepicker
    In-Reply-To: <bug-30550-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30550-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30550-70-TGPLPcMQJR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30550
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com
               Keywords|                            |rel_22_05_candidate
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 11:50:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 09:50:11 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-2IrIh4GmDN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    Mason James <mtj at kohaaloha.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133531|0                           |1
            is obsolete|                            |
    
    --- Comment #152 from Mason James <mtj at kohaaloha.com> ---
    Created attachment 133533
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133533&action=edit
    Bug 28786: Don't set auth_method to NULL in ->anonymize
    
    DBI Exception: DBD::mysql::st execute failed: Column 'auth_method' cannot be
    null
    
    caught by t/db_dependent/Koha/Patrons.t
    
    Signed-off-by: Mason James <mtj at kohaaloha.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 12:12:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 10:12:38 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-z9PxGOpeD4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #39 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    (In reply to Bernardo Gonzalez Kriegel from comment #38)
    > (In reply to Fridolin Somers from comment #37)
    > > Ah sorry does not work.
    > > 
    > > I see Jonathan's branch contains until patch "Show 325$a".
    > > 
    > > git bz apply shows error :
    > > 
    > > Applying: Bug 30373: Fix visibility, authorised values and descriptions
    > > error: sha1 information is lacking or useless
    > > (installer/data/mysql/en/marcflavour/unimarc/mandatory/
    > > unimarc_framework_DEFAULT.yml).
    > > error: could not build fake ancestor
    > 
    > Strange. Using Jonathan's remote, I don't find any problem.
    
    I am getting the same error than Fridolin. Can you resubmit the two patches or
    push a remote branch please?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 12:14:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 10:14:43 +0000
    Subject: [Koha-bugs] [Bug 29898] Overdues.pm line 663,
     Use of uninitialized value in string eq
    In-Reply-To: <bug-29898-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29898-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29898-70-pLOZHsuuYg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29898
    
    --- Comment #3 from Anke <anke.bruns at gwdg.de> ---
    We implemented a solution, replacing line 663 in
    /usr/share/koha/lib/C4/Overdues.pm, which originally reads:   
    
        if ( $branchcodes->[0] eq '' ) {
    
    by:
    
      if ( !defined ($branchcodes->[0]) || $branchcodes->[0] eq '' ) {
    
    Hope this is useful.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 12:51:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 10:51:07 +0000
    Subject: [Koha-bugs] [Bug 29898] Overdues.pm line 663,
     Use of uninitialized value in string eq
    In-Reply-To: <bug-29898-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29898-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29898-70-fn4Hqjj1pT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29898
    
    --- Comment #4 from Anke <anke.bruns at gwdg.de> ---
    My colleague just sent me this update to (In reply to Anke from comment #3)
    > We implemented a solution, replacing line 663 in
    > /usr/share/koha/lib/C4/Overdues.pm, which originally reads:   
    > 
    >     if ( $branchcodes->[0] eq '' ) {
    > 
    > by:
    > 
    >   if ( !defined ($branchcodes->[0]) || $branchcodes->[0] eq '' ) {
    > 
    > Hope this is useful.
    
    
    I just received this enhancement:
    
      if ( @$branchcodes >= 1 && ( !defined ($branchcodes->[0]) ||
    $branchcodes->[0] eq '' ) ) {
    
    This prevents the routine from returning libraries if there are no overdue
    rules.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 12:55:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 10:55:30 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-JNufbWUPiR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133453|0                           |1
            is obsolete|                            |
    
    --- Comment #35 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133534
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133534&action=edit
    Bug 21978: Add middle_name field to the database
    
    This patch adds a new field, middle_name, to the borrowers,
    deletedborrowers and borrower_modifications tables.
    
    It also updates the DefaultPatronSearchFields preference to include the
    new field if the preference is still set to it's default settings from
    install.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 12:55:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 10:55:36 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-ZKeRDN3i2V@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133454|0                           |1
            is obsolete|                            |
    
    --- Comment #36 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133535
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133535&action=edit
    Bug 21978: Add middle_name to api specification
    
    This patch adds middle_name to the accaeptable fields in API requests
    and responses.
    
    Test plan
    1) Search for a user using the API
    2) Confirm the API responds with a 200
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 12:55:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 10:55:41 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-K8p7mkjfqh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133455|0                           |1
            is obsolete|                            |
    
    --- Comment #37 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133536
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133536&action=edit
    Bug 21978: Add support for middle name
    
    This patch adds the new 'Middle name' field to the patron record.
    
    To test:
    1) Apply patches
    2) Update database, restart all and clear the browser cache
    3) Load a patron in the staff module
    4) Confirm you can see and edit the new 'Middle name' field
    5) Confirm the new middle name data displays on patron details
    6) Confirm the new middle name data displays on patron search results
    7) Confirm the new middle name data displays everywhere patron names are
       displayed.
    8) Confirm the new middle name data displays on the OPAC
    9) Confirm the 'Middle name' field appears in the OPAC borrower
       modification screens
    10) Edit syspref BorrowerMandatoryFields and BorrowerUnwantedFields to
        confirm you can make the new field required or hidden
    11) Verify that DefaultPatronSearchFields contains the new field if you
        already had 'firstname' in the field list
    12) Enable PatronAutoComplete system preference
    13) Type patrons surname into checkout or patron search but don't hit
        return
    14) Confirm the patrons middle name is displayed in the preview
    15) Go to tools > patron lists and attempt to add a patron to a list
    16) Patrons middle name should appear in the autocomplete here too
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 12:55:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 10:55:46 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-w9IS0gehT1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133456|0                           |1
            is obsolete|                            |
    
    --- Comment #38 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133537
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133537&action=edit
    Bug 21978: Schema Update
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 12:57:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 10:57:34 +0000
    Subject: [Koha-bugs] [Bug 30575] New: Returning an ILL item shouldn't just
     change the request status
    Message-ID: <bug-30575-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30575
    
                Bug ID: 30575
               Summary: Returning an ILL item shouldn't just change the
                        request status
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: ILL
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: tomascohen at gmail.com
    
    In the context of more complex ILL backends, in which returning an item could
    imply, for example, notifying an external source it is just not enough to call
    $req->status('RET')->store
    
    We should be calling something like ->backend_return instead, as we do with
    other actions, and let the plugin handle it however they need to.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 12:57:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 10:57:46 +0000
    Subject: [Koha-bugs] [Bug 30575] Returning an ILL item shouldn't just change
     the request status
    In-Reply-To: <bug-30575-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30575-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30575-70-x59dBlSXI2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30575
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |23112
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
    [Bug 23112] Add circulation process to inter-library loans
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 12:57:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 10:57:46 +0000
    Subject: [Koha-bugs] [Bug 23112] Add circulation process to inter-library
     loans
    In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23112-70-gTrVlM4LJO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30575
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30575
    [Bug 30575] Returning an ILL item shouldn't just change the request status
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 12:59:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 10:59:00 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-eZxLGxvj8I@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #40 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
    (In reply to Jonathan Druart from comment #39)
    > 
    > I am getting the same error than Fridolin. Can you resubmit the two patches
    > or push a remote branch please?
    
    Pushed to https://gitlab.com/bgkriegel/Koha/-/commits/bz30373
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 13:00:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 11:00:08 +0000
    Subject: [Koha-bugs] [Bug 30576] New: DefaultPatronSearchFields no longer
     takes effect
    Message-ID: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
                Bug ID: 30576
               Summary: DefaultPatronSearchFields no longer takes effect
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Patrons
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: martin.renvoize at ptfs-europe.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
    
    Searching from the header search for patrons in the staff client no longer
    takes notice of the DefaultPatronSearchFields preference... and 'Standard'
    search once on the member search page, also doesn't reflect the preference
    either.
    
    To replicate:
    1) Remove a field or two from the preference, but ensure at least some fields
    are present
    2) Submit a patron search
    3) Note that the search appears to user the 'Standard' option in the search
    4) Inspect the network traffic and note that the fields searched upon do not
    reflect the preference.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 13:03:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 11:03:13 +0000
    Subject: [Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC
     templates
    In-Reply-To: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30570-70-tu007t0B9d@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Medium patch
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 13:03:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 11:03:18 +0000
    Subject: [Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC
     templates
    In-Reply-To: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30570-70-RLAiJfu8t3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570
    
    --- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133538
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133538&action=edit
    Bug 30570: Replace the use of jQueryUI tabs in OPAC templates
    
    This patch switches to Bootstrap tabs anywhere in the OPAC where
    jQueryUI tabs were used.
    
    To test, apply the patch and rebuild the OPAC CSS
    (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
    
    - Test the item type/collection/shelvinglocation tabs on the advanced
      search page. Test that it works correctly with different variations of
      the OpacAdvancedSearchTypes system preference.
    - Search for an authority record and view the details. The "Notes"
      tab should be styled correctly.
    - Locate a bibliographic record and view the detail page. Verify
      that tabs are working, including all the options:
      - Holdings
      - Other holdings ( If OpacSeparateHoldings is enabled)
      - Descriptions ( MARC notes )
      - Subscriptions
      - Serial collection (UNIMARC, untested)
      - Components ( If ShowComponentRecords is enabled. Link to sample
        record: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78023 )
      - Comments
      - Editions (OPACFRBRizeEditions)
      - Html5media ( If HTML5MediaEnabled is on. Link to sample records:
        (https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10685)
      - Images ( If OPACLocalCoverImages is enabled )
    
      Bonus points for testing these tabs for which I don't have
      credentials:
      - Syndetics TOC
      - Syndetics Excerpt
      - Syndetics Reviews
      - Syndetics AuthorNotes
      - LibraryThing for Libraries (with LibraryThingForLibrariesTabbedView
        set to "in tabs."
      - NovelistSelect
    
    - Check tabs on these patron-related pages:
      - Checkout history
      - Search history
      - Patron summary. The following tabs are
        ✓ Checkouts
        ✓ Relatives' checkouts
        ✓ Overdues
        ✓ Fines
        ✓ Relatives' fines
        ✓ Holds
        ✓ Recalls
        ✓ Article requests
        ✓ Overdrive
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 13:04:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 11:04:43 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-gIYXhwP4tU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    --- Comment #39 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Good catch Sally, I think I've resolved that here now, but it has lead me to
    submit a new bug 'Bug 30576 - DefaultPatronSearchFields no longer takes effect'
    as I think the core feature has broken in the recent patron search changes
    push.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 13:04:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 11:04:50 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-BvZIp4z3hE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 13:08:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 11:08:13 +0000
    Subject: [Koha-bugs] [Bug 25063] OPAC Renewal Option
    In-Reply-To: <bug-25063-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25063-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25063-70-G9daisffYM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25063
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |m.de.rooy at rijksmuseum.nl
    
    --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Christopher Brannon from comment #5)
    > I've broken this down into separate bugs.  Look at see also.
    
    It is not completely clear to me what you did. Does this report only stay as
    the omnibus report, or is development here needed too? You could use the
    dependencies to indicate that.
    
    Also note that OPAC Renewal lets me think first of renewing loans, not patron
    accounts.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 13:09:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 11:09:52 +0000
    Subject: [Koha-bugs] [Bug 26355] Tie account renewals to patron modification
     requests
    In-Reply-To: <bug-26355-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26355-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26355-70-na5hgIcwxb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |m.de.rooy at rijksmuseum.nl
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 13:16:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 11:16:30 +0000
    Subject: [Koha-bugs] [Bug 30577] New: Item specific holds location can be
     missed when placing title level holds
    Message-ID: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577
    
                Bug ID: 30577
               Summary: Item specific holds location can be missed when
                        placing title level holds
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Hold requests
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: nick at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 13:18:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 11:18:32 +0000
    Subject: [Koha-bugs] [Bug 30577] Item specific holds location can be missed
     when placing title level holds
    In-Reply-To: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30577-70-qV2XA9dv1m@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 13:18:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 11:18:35 +0000
    Subject: [Koha-bugs] [Bug 30577] Item specific holds location can be missed
     when placing title level holds
    In-Reply-To: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30577-70-2GGdbt0nT6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577
    
    --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133539
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133539&action=edit
    Bug 30577: Move item specific pickup locations to the left
    
    When placing holds, staff will set the pickup location at the top,
    choose an item, then place the hold.
    It is easy not to notice the item specific locations dropdown.
    
    This patch moves it in line with the other selction areas on the request
    screen.
    
    To test:
     1 - Find a record on staff client, place hold
     2 - Select a patron to load the request screen
     3 - Note the location dropdown for next available hold
     4 - Note the item specific locations on the far right
     5 - Apply patch
     6 - Reload the page
     7 - Note the item specific location dropdowns are now moved to the left
     8 - Place the hold, verify it works with the dropdowns
     9 - Verify title levelholds still work as expected
    10 - Verify multi-holds still work
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 13:18:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 11:18:38 +0000
    Subject: [Koha-bugs] [Bug 30577] Item specific holds location can be missed
     when placing title level holds
    In-Reply-To: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30577-70-f0HhQHW4F5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577
    
    --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133540
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133540&action=edit
    Bug 30577: Fix a missing closing tag
    
    This didn't affect table display, but when there was a biblioloo.warn
    we were not closing the first <td> tag
    
    Confirm multi-holds table loads correctly when one (or more) records cannot be
    held
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 13:18:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 11:18:55 +0000
    Subject: [Koha-bugs] [Bug 30577] Item specific holds location can be missed
     when placing title level holds
    In-Reply-To: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30577-70-XpGBYZXZca@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |andrew at bywatersolutions.com
               Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                       |ity.org                     |
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 13:36:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 11:36:08 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-TaJUBES9Ri@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    
    --- Comment #21 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    (In reply to Jonathan Druart from comment #20)
    > How hard would it be to switch to v5?
    
    Scratch that, I had bootstrap in mind.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 13:52:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 11:52:42 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-1rhPnkX9Km@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    --- Comment #153 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133541
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133541&action=edit
    Bug 28786: Fix Patrons/Import.t
    
    DBI Exception: DBD::mysql::st execute failed: Data truncated for column
    'auth_method' at row 1 at /kohadevbox/koha/Koha/Object.pm line 170
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 13:57:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 11:57:29 +0000
    Subject: [Koha-bugs] [Bug 30574] Cannot add patron
    In-Reply-To: <bug-30574-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30574-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30574-70-wZk1GofhKM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30574
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Severity|enhancement                 |normal
                Version|unspecified                 |master
                 Status|NEW                         |RESOLVED
               Priority|P1 - high                   |P5 - low
             Resolution|---                         |INVALID
    
    --- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
    This sounds like a support request rather than a bug.
    
    Questions about Koha should be asked on the Koha mailing list
    (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC
    channel (http://koha-community.org/get-involved/irc/).
    
    Hopefully you've already seen the Koha documentation:
    http://koha-community.org/documentation/
    
    You can also find options for paid support here:
    https://koha-community.org/support/
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 13:57:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 11:57:50 +0000
    Subject: [Koha-bugs] [Bug 29768] hidepatronname hides guarantor name on
     borrower edit screen
    In-Reply-To: <bug-29768-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29768-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29768-70-JXlf6rP38z@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768
    
    Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
                     CC|                            |emmi.takkinen at koha-suomi.fi
               Assignee|koha-bugs at lists.koha-commun |emmi.takkinen at koha-suomi.fi
                       |ity.org                     |
    
    --- Comment #1 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
    Created attachment 133542
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133542&action=edit
    Bug 29768: Do not hide guarantor name from memberentry.pl
    
    Syspref "hidepatronname" currently hides guarantors name
    on memberentry.pl. This is inconsistent since name isn't
    hidden e.g. on moremember.pl and staff can already see
    patrons other personal information during edit.
    
    To test:
    1) Disable syspref "hidepatronname"
    2) Edit guarantee patrons information
    => Field "Guarantor" only shows guarantors cardnumber (or
    is empty if guarantor has no cardnumber)
    3) Apply patch
    => Guarantors name is now displayed
    
    Sponsored-by: Koha-Suomi Oy
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:02:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:02:48 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-AtmoRpea54@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    --- Comment #154 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    +        $borrower{auth_method} = undef if $borrower{auth_method} eq "";
    
    `auth_method` ENUM('password', 'two-factor') NOT NULL DEFAULT 'password'
    COMMENT 'Authentication method',
    
    Are you sure?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:08:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:08:05 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-LwFeDEXpfk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133543
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133543&action=edit
    Bug 30576: Use DefaultPatronSearchFields in patron search
    
    This patch corrects the handling of the 'Standard' search field in
    patron searches such that it accurately reflects the contents of the
    DefaultPatronSearchFields system preference and falls back to a hard
    coded list instead of always using the hard coded list.
    
    To test:
    1) Empty the contents of DefaultPatronSearchFields systempreference
    2) Perform a patron search from the header search
    3) Inspect the patrons API request and note that we search on the
       default fallback fields of firstname, surname, othernames,
       cardnumber and userid (and some extended attributes which are
       historically hard coded).
    4) Navigate to the memebers-home by clicking the 'Patrons' button from
       the main page
    5) Perform another search using the filters on the left with 'Standard'
       selected.
    6) Note the same list of search fields used as above in the patrons API
       request.
    7) Update the DefaultPatronSearchFields systempreference adding one or
       more borrower fields in a comma delimited list.
    8) Repeat steps 2 -> 6 but this time upon inspecting the API request you
       should find that only the fields in your DefaultPatronSearchFields
       list are searched (along with the hard coded extended attributes
       list).
    9) Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:08:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:08:22 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-0gUKr2h8rf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:08:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:08:44 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-JtpoK95fet@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com,
                       |                            |nick at bywatersolutions.com,
                       |                            |tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:08:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:08:54 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-FFjrhTZWAa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Severity|enhancement                 |normal
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:08:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:08:59 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-h81GSv202I@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                       |ity.org                     |.com
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:09:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:09:20 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-YEBdlUOQ7d@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30576
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    [Bug 30576] DefaultPatronSearchFields no longer takes effect
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:09:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:09:20 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-ZJTIFcIu76@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |21978
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    [Bug 21978] Add middle name field
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:09:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:09:57 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-lu5V0foRxn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133534|0                           |1
            is obsolete|                            |
    
    --- Comment #40 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133544
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133544&action=edit
    Bug 21978: Add middle_name field to the database
    
    This patch adds a new field, middle_name, to the borrowers,
    deletedborrowers and borrower_modifications tables.
    
    It also updates the DefaultPatronSearchFields preference to include the
    new field if the preference is still set to it's default settings from
    install.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:10:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:10:03 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-hljK6j2wLZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133535|0                           |1
            is obsolete|                            |
    
    --- Comment #41 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133545
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133545&action=edit
    Bug 21978: Add middle_name to api specification
    
    This patch adds middle_name to the accaeptable fields in API requests
    and responses.
    
    Test plan
    1) Search for a user using the API
    2) Confirm the API responds with a 200
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:10:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:10:09 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-KbCjWsFYzY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133536|0                           |1
            is obsolete|                            |
    
    --- Comment #42 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133546
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133546&action=edit
    Bug 21978: Add support for middle name
    
    This patch adds the new 'Middle name' field to the patron record.
    
    To test:
    1) Apply patches
    2) Update database, restart all and clear the browser cache
    3) Load a patron in the staff module
    4) Confirm you can see and edit the new 'Middle name' field
    5) Confirm the new middle name data displays on patron details
    6) Confirm the new middle name data displays on patron search results
    7) Confirm the new middle name data displays everywhere patron names are
       displayed.
    8) Confirm the new middle name data displays on the OPAC
    9) Confirm the 'Middle name' field appears in the OPAC borrower
       modification screens
    10) Edit syspref BorrowerMandatoryFields and BorrowerUnwantedFields to
        confirm you can make the new field required or hidden
    11) Verify that DefaultPatronSearchFields contains the new field if you
        already had 'firstname' in the field list
    12) Enable PatronAutoComplete system preference
    13) Type patrons surname into checkout or patron search but don't hit
        return
    14) Confirm the patrons middle name is displayed in the preview
    15) Go to tools > patron lists and attempt to add a patron to a list
    16) Patrons middle name should appear in the autocomplete here too
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:10:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:10:16 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-JsnoeqsTze@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133537|0                           |1
            is obsolete|                            |
    
    --- Comment #43 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133547
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133547&action=edit
    Bug 21978: Schema Update
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:11:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:11:01 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-uQW5qmZmkN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    --- Comment #44 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Added 30576 as a dependency here and rebased appropriately.  That should fix
    the DefaultPatronSearchFields preference handling.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:13:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:13:34 +0000
    Subject: [Koha-bugs] [Bug 30578] New: We should drop circ/ysearch.pl in
     preference to using the REST API's
    Message-ID: <bug-30578-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578
    
                Bug ID: 30578
               Summary: We should drop circ/ysearch.pl in preference to using
                        the REST API's
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Architecture, internals, and plumbing
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: martin.renvoize at ptfs-europe.com
            QA Contact: testopia at bugs.koha-community.org
    
    As the title says, we should really stop using ysearch.pl for autocomplete.. it
    doesn't fully respect the various restrictions and the REST API is well
    developed now.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:13:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:13:46 +0000
    Subject: [Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in
     preference to using the REST API's
    In-Reply-To: <bug-30578-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30578-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30578-70-CRLv10JuZJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:17:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:17:39 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-kTvdTvwRev@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    --- Comment #45 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    I'm reconsidering whether this should be hard coded to be included in the
    autocomplete searches.  Those searches only allow for ten results at a time and
    adding another field into the mix could actually reduce their relevance.. How
    often is a staff user going to start typing a middle name in preference to a
    firstname, surname or cardnumber?
    
    We can still display the middle name in the results to allow easily picking
    between them, but actually searching on middle name seems like an odd
    practice..?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:18:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:18:15 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-ogkdRKEM8j@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133541|0                           |1
            is obsolete|                            |
    
    --- Comment #155 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133548
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133548&action=edit
    Bug 28786: Fix Patrons/Import.t
    
    DBI Exception: DBD::mysql::st execute failed: Data truncated for column
    'auth_method' at row 1 at /kohadevbox/koha/Koha/Object.pm line 170
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:19:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:19:13 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-9LZu5UkRX6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    --- Comment #156 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    This part in import_patrons is arguable:
    
                    else {
                        $borrower{$key} = '';
                    }
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:32:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:32:05 +0000
    Subject: [Koha-bugs] [Bug 30579] New: When placing item level hold,
     some options that are not used are not disabled
    Message-ID: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579
    
                Bug ID: 30579
               Summary: When placing item level hold, some options that are
                        not used are not disabled
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Hold requests
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: nick at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:33:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:33:05 +0000
    Subject: [Koha-bugs] [Bug 30579] When placing item level hold,
     some options that are not used are not disabled
    In-Reply-To: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30579-70-WAGWgSsYpq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Trivial patch
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:33:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:33:09 +0000
    Subject: [Koha-bugs] [Bug 30579] When placing item level hold,
     some options that are not used are not disabled
    In-Reply-To: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30579-70-Wpcd9XDsE3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579
    
    --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133549
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133549&action=edit
    Bug 30579: Disentangle multi-hold and single bib forms
    
    This patch simply groups the forms so that multi-hold and single
    hold are each in their own section
    
    While there is some duplication from this, it makes the sections easier to read
    and allows for more variation in the two forms
    
    To test:
    1 - Place a single bib and multi bib hold in staff client
    2 - Apply this patch
    3 - Repeat and confirm nothing changes with this patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:33:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:33:14 +0000
    Subject: [Koha-bugs] [Bug 30579] When placing item level hold,
     some options that are not used are not disabled
    In-Reply-To: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30579-70-jYJkCfRLIM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579
    
    --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133550
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133550&action=edit
    Bug 30579: Group next available hold options, and disable when item is chosen
    
    This patch rearranges options that only apply to next available holds
    and disables them when an item is checked. This is intended to make it
    more obvious which parts of the form apply to this selection
    
    To test:
    1 - Apply patches
    2 - Confirm you can successfully place single or multiple items on hold
    3 - Confirm that when placing a single hold the next available options are
    grouped
    4 - Confirm pickup location, specific item type, and number of holds all work
    for next available
    5 - Confirm item level holds save pickup location correctly
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:34:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:34:01 +0000
    Subject: [Koha-bugs] [Bug 30579] When placing item level hold,
     some options that are not used are not disabled
    In-Reply-To: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30579-70-KGx2AynanO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |andrew at bywatersolutions.com
                       |                            |, oleonard at myacpl.org
               Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                       |ity.org                     |
             Depends on|                            |30577
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577
    [Bug 30577] Item specific holds location can be missed when placing title level
    holds
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:34:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:34:01 +0000
    Subject: [Koha-bugs] [Bug 30577] Item specific holds location can be missed
     when placing title level holds
    In-Reply-To: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30577-70-XacboA1tga@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30579
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579
    [Bug 30579] When placing item level hold, some options that are not used are
    not disabled
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:49:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:49:23 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-vaVMYg7JjS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30063
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
    [Bug 30063] Make the main patron search use the /patrons REST API route
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:49:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:49:23 +0000
    Subject: [Koha-bugs] [Bug 30063] Make the main patron search use the
     /patrons REST API route
    In-Reply-To: <bug-30063-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30063-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30063-70-TkpJ1ombGE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30576
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    [Bug 30576] DefaultPatronSearchFields no longer takes effect
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:51:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:51:48 +0000
    Subject: [Koha-bugs] [Bug 30224] Wrong important field shown in cataloguing
     validation
    In-Reply-To: <bug-30224-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30224-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30224-70-GKzOBU3mBI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224
    
    Peter Vashchuk <stalkernoid at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:51:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:51:53 +0000
    Subject: [Koha-bugs] [Bug 30224] Wrong important field shown in cataloguing
     validation
    In-Reply-To: <bug-30224-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30224-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30224-70-fDkQNrPYYq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224
    
    Peter Vashchuk <stalkernoid at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131367|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Peter Vashchuk <stalkernoid at gmail.com> ---
    Created attachment 133551
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133551&action=edit
    Bug 30224: Show correct important field in cataloguing validation
    
    This patch fxes the cataloguing validation messages to show the correct tag,
    when the whole field is important (not just a subfield).
    
    Note: Look at Bug 30159 to fix the formatting of the validation popup.
    
    1. Go to Administration -> MARC bibliographic frameworks
    2. Click Actions next to a framework, view MARC structure
    3. Edit multiple tags (at least 2) and check the Important checkbox.
    4. Go to cataloguing and create a new record using the framework you just
    edited
    5. Don't fill any of the important fields. Click Save to force the validation
    for the important tags
    6. Notice that the error message shows that an important field isn't filled,
    but the tag number shown is repeated for each message. The 'Go to field' link
    goes to the right tag, but the tag number shown is incorrect.
    7. Apply patch and refresh page
    8. Click Save to force validation again.
    9. Confirm the correct tag number is now showing for each error message.
    
    Sponsored-by: Education Services Australia SCIS
    Signed-off-by: Petro Vashchuk <stalkernoid at gmail.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:51:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:51:57 +0000
    Subject: [Koha-bugs] [Bug 30572] Field search_marc_to_field.sort needs
     syncing too
    In-Reply-To: <bug-30572-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30572-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30572-70-aCiedbJXch@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30572
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
       Patch complexity|---                         |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:52:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:52:01 +0000
    Subject: [Koha-bugs] [Bug 30572] Field search_marc_to_field.sort needs
     syncing too
    In-Reply-To: <bug-30572-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30572-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30572-70-G51sEkqrm3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30572
    
    --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133552
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133552&action=edit
    Bug 30572: Adjust search_marc_to_field.sort in kohastructure
    
    Test plan:
    New install or run kohastructure on empty database.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:52:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:52:05 +0000
    Subject: [Koha-bugs] [Bug 30572] Field search_marc_to_field.sort needs
     syncing too
    In-Reply-To: <bug-30572-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30572-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30572-70-wVvvzKUYSE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30572
    
    --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133553
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133553&action=edit
    Bug 30572: Dbrev for search_marc_to_field.sort
    
    Test plan:
    Run updatedatabase.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:52:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:52:09 +0000
    Subject: [Koha-bugs] [Bug 30572] Field search_marc_to_field.sort needs
     syncing too
    In-Reply-To: <bug-30572-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30572-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30572-70-mQLsvmb0nl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30572
    
    --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133554
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133554&action=edit
    Bug 30572: DBIx schema change for SearchMarcToField
    
    No test plan.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:53:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:53:12 +0000
    Subject: [Koha-bugs] [Bug 30572] Field search_marc_to_field.sort needs
     syncing too
    In-Reply-To: <bug-30572-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30572-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30572-70-oQi6c8c0yr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30572
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
               Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                       |ity.org                     |
    
    --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Trivial: self SO
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:53:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:53:44 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-L23D9n9ubx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:53:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:53:49 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-5iPaqLvOab@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133543|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133555
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133555&action=edit
    Bug 30576: Use DefaultPatronSearchFields in patron search
    
    This patch corrects the handling of the 'Standard' search field in
    patron searches such that it accurately reflects the contents of the
    DefaultPatronSearchFields system preference and falls back to a hard
    coded list instead of always using the hard coded list.
    
    To test:
    1) Empty the contents of DefaultPatronSearchFields systempreference
    2) Perform a patron search from the header search
    3) Inspect the patrons API request and note that we search on the
       default fallback fields of firstname, surname, othernames,
       cardnumber and userid (and some extended attributes which are
       historically hard coded).
    4) Navigate to the memebers-home by clicking the 'Patrons' button from
       the main page
    5) Perform another search using the filters on the left with 'Standard'
       selected.
    6) Note the same list of search fields used as above in the patrons API
       request.
    7) Update the DefaultPatronSearchFields systempreference adding one or
       more borrower fields in a comma delimited list.
    8) Repeat steps 2 -> 6 but this time upon inspecting the API request you
       should find that only the fields in your DefaultPatronSearchFields
       list are searched (along with the hard coded extended attributes
       list).
    9) Signoff
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 14:54:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 12:54:03 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-RyVV0EIEAP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 15:03:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 13:03:31 +0000
    Subject: [Koha-bugs] [Bug 29698] items are not available for TT syntax for
     PREDUEDGST
    In-Reply-To: <bug-29698-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29698-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29698-70-fPD2n4FHQn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29698
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131644|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Created attachment 133556
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133556&action=edit
    Bug 29698: Make items available for PREDUEDGST
    
    With this patch you can access items using:
    Number of items [% items.count %]
    [% FOR i IN items %]
        [% SET checkout = i.checkout %]
        Item [% i.itemnumber %] is due on [% checkout.date_due | $KohaDates %]
    [% END %]
    
    == test plan ==
    1. Add the following to PREDUEDGST and DUEDST:
    Number of items [% items.count %]
    [% FOR i IN items %]
        [% SET checkout = i.checkout %]
        Item [% i.itemnumber %] is due on [% checkout.date_due | $KohaDates %]
    [% END %]
    
    2. Find a patron and set there messaging prefs 'Item due' and 'Advanced
      notices' so they get an email and 'digest only'.
      On 'Advanced notices' set Days in advance to 1.
    3. Check some things out to a patron and make them due tomorrow.
    4. perl /kohadevbox/koha/misc/cronjobs/advance_notices.pl -v -c
    5. Check the patrons notices and make sure the PREDUEDGST looks right.
    6. Check some things out to a patron and make them due today.
    7. Repeat 4.
    8. Check the patrons notices and make sure the DUEDGST looks right.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 15:03:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 13:03:54 +0000
    Subject: [Koha-bugs] [Bug 29698] items are not available for TT syntax for
     PREDUEDGST
    In-Reply-To: <bug-29698-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29698-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29698-70-1yzqEvzMkc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29698
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |victor at tuxayo.net
                 Status|Signed Off                  |Passed QA
    
    --- Comment #6 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Works, qa script happy, code looks good, passing QA :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 15:07:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 13:07:09 +0000
    Subject: [Koha-bugs] [Bug 30532] guided_reports.pl has a problem
    In-Reply-To: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30532-70-6qTOLJezFI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30532
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 15:07:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 13:07:15 +0000
    Subject: [Koha-bugs] [Bug 30532] guided_reports.pl has a problem
    In-Reply-To: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30532-70-Z64tHz05NL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30532
    
    --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133557
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133557&action=edit
    Bug 30532: (bug 29957 follow-up) Fix '$cookie->value'
    
    We got
     Can't call method "value" on unblessed reference at
    /kohadevbox/koha/opac/opac-messaging.pl line 86
    
    $cookie can be an arrayref, we should retrieve the session id using
    CGI->cookie('CGISESSID')
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 15:07:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 13:07:28 +0000
    Subject: [Koha-bugs] [Bug 30532] guided_reports.pl has a problem
    In-Reply-To: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30532-70-qOUaSzYxT2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30532
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Severity|critical                    |blocker
               Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                       |ity.org                     |com
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 15:15:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 13:15:28 +0000
    Subject: [Koha-bugs] [Bug 30532] guided_reports.pl has a problem
    In-Reply-To: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30532-70-Cpiv3bO2aC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30532
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |rel_21_11_candidate
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 15:15:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 13:15:44 +0000
    Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing
     secret via HTTP GET
    In-Reply-To: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29873-70-Dgk8jl848j@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133216|0                           |1
            is obsolete|                            |
    
    --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133558
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133558&action=edit
    Bug 29873: Create QR code
    
    Instead of using deprecated Google Charts API, and exposing our
    secret in a GET parameter, we generate QR data ourselves.
    
    Test plan:
    [1] Enable two factor authentication in the prefs.
    [2] Login in staff. Go to account. Select Manage 2FA.
    [3] Verify that QR code is displayed.
    [4] Register the QR in your authenticator app and test 2FA
        by logging in again.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Tested with Google Authenticator and FreeOTP.
    
    Bug 29873: (follow-up) Rename qr_dataurl
    
    As requested by a QA team member.
    We're moving to qr_code as method name. This is the same name as
    the method in the underlying base class.
    Apart from one sed statement, changing to self->SUPER on one line.
    
    Test plan:
    Can you still register, logout and login?
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Bug 29873: (follow-up) Switch to GD
    
    We do not need a new module, we could use GD instead.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 15:15:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 13:15:49 +0000
    Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing
     secret via HTTP GET
    In-Reply-To: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29873-70-K2mBomno3p@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133217|0                           |1
            is obsolete|                            |
    
    --- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133559
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133559&action=edit
    Bug 29873: Add unit test
    
    Test plan:
    Run t/db_dependent/Koha/Auth/TwoFactorAuth.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Amended to reflect requested changes.
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 15:20:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 13:20:31 +0000
    Subject: [Koha-bugs] [Bug 30580] New:
     GetItemsAvailableToFillHoldRequestsForBib should get transfers during
     initial query
    Message-ID: <bug-30580-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30580
    
                Bug ID: 30580
               Summary: GetItemsAvailableToFillHoldRequestsForBib should get
                        transfers during initial query
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Hold requests
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: nick at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com
    
    Currently we get the items, then loop over them checking for transfers - we can
    simply join to branch transfers in the initial query
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 15:21:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 13:21:23 +0000
    Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing
     secret via HTTP GET
    In-Reply-To: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29873-70-KShX8nbmd2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    --- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Good call.. works as expected. Signing of..
    
    Must admit, I still wonder if we aught to have gone with Authen::OATH rather
    than Auth::GoogleAuth for 2FA.. but that's another question entirely.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 15:22:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 13:22:26 +0000
    Subject: [Koha-bugs] [Bug 30580] GetItemsAvailableToFillHoldRequestsForBib
     should get transfers during initial query
    In-Reply-To: <bug-30580-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30580-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30580-70-ywlmuxc2Bp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30580
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 15:22:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 13:22:30 +0000
    Subject: [Koha-bugs] [Bug 30580] GetItemsAvailableToFillHoldRequestsForBib
     should get transfers during initial query
    In-Reply-To: <bug-30580-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30580-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30580-70-Y3ooPtw2ZV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30580
    
    --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133560
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133560&action=edit
    Bug 30580: Don't use GetTransfers in GetItemsAvailableToFillHoldRequestsForBib
    
    This patch simply moves the check for transfers into the initial query
    
    To test:
    1 - Place some holds that show in the holds queue
    2 - Add a manual transfer to one item
    3 - Confirm it no longer hsows in the queue
    4 - Apply patch
    5 - Confirm item still does not appear in the queue
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 15:25:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 13:25:30 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-3Y7wZHV2Mc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    --- Comment #157 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    (In reply to Marcel de Rooy from comment #154)
    > +        $borrower{auth_method} = undef if $borrower{auth_method} eq "";
    > 
    > `auth_method` ENUM('password', 'two-factor') NOT NULL DEFAULT 'password'
    > COMMENT 'Authentication method',
    > 
    > Are you sure?
    
    If set to null the DBMS will use the default value.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 15:25:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 13:25:37 +0000
    Subject: [Koha-bugs] [Bug 30581] New: Items should show on the Holds Queue
     and Holds to Pull even if they have requested transfers
    Message-ID: <bug-30581-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30581
    
                Bug ID: 30581
               Summary: Items should show on the Holds Queue and Holds to Pull
                        even if they have requested transfers
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Hold requests
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: andrew at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com
            Depends on: 23092
    
    In bug 23092 Koha added the idea of a transfer that has been requested but not
    yet sent. The Holds Queue and and Holds to Pull will not show titles/items that
    have transfers that are not either complete or cancelled, so staff are not
    alerted to holds on Available items if those items have requested transfers on
    them. But if the item is checked in, it will trigger the hold.
    
    We should show items in the Holds Queue and Holds to Pull if they have
    transfers that are requested but not sent.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092
    [Bug 23092] Add 'daterequested' to the transfers table
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 15:25:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 13:25:37 +0000
    Subject: [Koha-bugs] [Bug 23092] Add 'daterequested' to the transfers table
    In-Reply-To: <bug-23092-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23092-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23092-70-uIxPrMBTlu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30581
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30581
    [Bug 30581] Items should show on the Holds Queue and Holds to Pull even if they
    have requested transfers
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 15:34:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 13:34:46 +0000
    Subject: [Koha-bugs] [Bug 30532] guided_reports.pl has a problem
    In-Reply-To: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30532-70-TOgAJbcPM5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30532
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 15:34:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 13:34:50 +0000
    Subject: [Koha-bugs] [Bug 30532] guided_reports.pl has a problem
    In-Reply-To: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30532-70-vERR6MtOtt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30532
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133557|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133561
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133561&action=edit
    Bug 30532: (bug 29957 follow-up) Fix '$cookie->value'
    
    We got
     Can't call method "value" on unblessed reference at
    /kohadevbox/koha/opac/opac-messaging.pl line 86
    
    $cookie can be an arrayref, we should retrieve the session id using
    CGI->cookie('CGISESSID')
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 15:34:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 13:34:54 +0000
    Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing
     secret via HTTP GET
    In-Reply-To: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29873-70-b5hZuny4aL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873
    
    --- Comment #24 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    (In reply to Martin Renvoize from comment #23)
    > Must admit, I still wonder if we aught to have gone with Authen::OATH rather
    > than Auth::GoogleAuth for 2FA.. but that's another question entirely.
    
    Discussed extensively on bug 28786 already.
    
    tldr; With this patch there is no bad reason to not switch (but do we have a
    good reason to switch?).
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 15:40:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 13:40:52 +0000
    Subject: [Koha-bugs] [Bug 30385] Standardize our swagger yaml spec files
    In-Reply-To: <bug-30385-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30385-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30385-70-rq900GdCHa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30385
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Patch doesn't apply
               Assignee|jonathan.druart+koha at gmail. |koha-bugs at lists.koha-commun
                       |com                         |ity.org
    
    --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Now conflicting with bug 30536. No idea was the deps have been reversed.
    Abandoning it as it's a mess to rebase and wasn't supposed to wait that much in
    the queue.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 15:41:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 13:41:33 +0000
    Subject: [Koha-bugs] [Bug 30385] Standardize our swagger yaml spec files
    In-Reply-To: <bug-30385-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30385-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30385-70-2A1JrauRUT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30385
    
    --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Now conflicting with bug 30536. No idea why the deps have been reversed. I am
    abandoning it as it's a mess to rebase and it wasn't supposed to wait that much
    in the queue.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 15:55:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 13:55:28 +0000
    Subject: [Koha-bugs] [Bug 22223] Item url double-encode when parameter is an
     encoded URL
    In-Reply-To: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22223-70-qaSqBos1iY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22223
    
    --- Comment #31 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Nope. It's a common mistake in Koha/Template/Plugin/, certainly coming from a
    copy/paste.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 15:57:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 13:57:40 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-vlU5JSGhar@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133286|0                           |1
            is obsolete|                            |
    
    --- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133562
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133562&action=edit
    Bug 29894: Add some exceptions to TwoFactorAuth module
    
    Test updated accordingly.
    Adding utf8 flag to CGI in staff script.
    
    Test plan:
    Run t/db_dependent/Koha/Auth/TwoFactorAuth.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 15:57:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 13:57:45 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-uyscFU4cJw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133287|0                           |1
            is obsolete|                            |
    
    --- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133563
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133563&action=edit
    Bug 29894: Clear secret when disabling 2FA
    
    Test plan:
    Deregister 2FA for patron.
    Check if secret is empty in borrowers.secret.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 15:57:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 13:57:50 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-Y4u9L9OP3C@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133288|0                           |1
            is obsolete|                            |
    
    --- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133564
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133564&action=edit
    Bug 29894: Db rev for adding notices
    
    This dbrev adds two notices:
    2FA_REGISTER and 2FA_DEREGISTER
    
    Test plan:
    Run the dbrev.
    Check if you see them on Tools/Notices.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 15:57:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 13:57:54 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-AW8BUz4c8T@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133289|0                           |1
            is obsolete|                            |
    
    --- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133565
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133565&action=edit
    Bug 29894: Send a confirmation notice
    
    When registering or deregistering, send a confirmation.
    
    Test plan:
    Register or deregister with patron having email address.
    Verify that you got a confirmation mail.
    Run t/db_dependent/Koha/Auth/TwoFactorAuth.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 15:57:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 13:57:59 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-HEygtlEPZB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    --- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133566
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133566&action=edit
    Bug 29894: (follow-up) Update notice terms
    
    Register and Derigister didn't sound right, in reality we we enabling
    and disabling 2FA for the user so I think those terms are more
    understandable.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 15:58:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 13:58:14 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-d8pemF76h1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 15:59:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 13:59:55 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-eUkvFdj5lS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    --- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    All works well so signing off.. I added a follow-up to use what I feel are
    clearer terms in the notices.
    
    My one caveat is something doesn't feel quite right about the introduction of
    'send_confirm_notice' as a method in Koha::Auth::TwoFactorAuth, but I can see
    why you do it so it's testable.. I'll leave that query to QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 16:01:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 14:01:51 +0000
    Subject: [Koha-bugs] [Bug 22223] Item url double-encode when parameter is an
     encoded URL
    In-Reply-To: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22223-70-F9qFB9nIKM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22223
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132027|0                           |1
            is obsolete|                            |
    
    --- Comment #32 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133567
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133567&action=edit
    Bug 22223: Try to not double encoded URIs in items.uri
    
    This is just a POC and is not ready for inclusion (Filter.pm and naming
    need to be discussed).
    
    Test plan:
    Create 2 items, with uri:
      https://www.google.com/url?q=https://buttercup.pw
      https://www.google.com/url?q=https%3A%2F%2Fbuttercup.pw
    
    Go to the OPAC detail page of the bib record, see that the links are
    displayed how you entered them.
    Click on them and confirm that the uri/page is correct
    
    Signed-off-by: Séverine Queune <severine.queune at bulac.fr>
    
    JD amended patch:
    * Remove use Template::Plugin::Filter;
    * Fix license statement
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 16:20:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 14:20:46 +0000
    Subject: [Koha-bugs] [Bug 30582] New: MARC 952$c won't show in OPAC when not
     linked to category of authorized values
    Message-ID: <bug-30582-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30582
    
                Bug ID: 30582
               Summary: MARC 952$c won't show in OPAC when not linked to
                        category of authorized values
     Change sponsored?: ---
               Product: Koha
               Version: 21.11
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: OPAC
              Assignee: oleonard at myacpl.org
              Reporter: mik at adminkuhn.ch
            QA Contact: testopia at bugs.koha-community.org
    
    The content of MARC 952$c is only shown if MARC 952$c is linked to category of
    authorized values "LOC". In this case the content of MARC 952$c is shown in the
    item data field "current library" in both OPAC and staff client.
    
    If MARC 952$c is not linked to a category of authorized values, then the
    content of MARC 952$c is only shown in the staff client, but not in the OPAC.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 16:21:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 14:21:45 +0000
    Subject: [Koha-bugs] [Bug 30385] Standardize our swagger yaml spec files
    In-Reply-To: <bug-30385-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30385-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30385-70-gNfJHHidFv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30385
    
    --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    I'm less sure about this now.. having delved through it I don't like how we
    re-order the keys within the parameters block..
    
    We were pretty consistently as below:
    
    parameters:
      - name: x-koha-embed
        in: header
        description: Embed list sent as request header
        required: false
        type: array
        items:
          enum:
            - extended_attributes
          type: string
        collectionFormat: csv
    
    This now comes out as:
    
    parameters:
        - collectionFormat: csv
          description: Embed list send as request header
          in: header
          items:
            enum:
              - extened_attributes
            type: string
          name: x-koha-embed
          required: false
          type: array
    
    I find the second much harder to read at a glance.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 16:22:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 14:22:46 +0000
    Subject: [Koha-bugs] [Bug 30385] Standardize our swagger yaml spec files
    In-Reply-To: <bug-30385-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30385-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30385-70-p5Oop11kQb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30385
    
    --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    That's why I reversed the dependencies.. because I felt there was still work to
    be done here.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 16:25:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 14:25:21 +0000
    Subject: [Koha-bugs] [Bug 30405] Style of address in patron search result
     are 110%
    In-Reply-To: <bug-30405-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30405-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30405-70-n4BpUqNXsC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30405
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |tomascohen at gmail.com
             QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                       |y.org                       |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 16:27:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 14:27:40 +0000
    Subject: [Koha-bugs] [Bug 30583] New: Hold system broken for translated
     template
    Message-ID: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30583
    
                Bug ID: 30583
               Summary: Hold system broken for translated template
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: NEW
              Severity: blocker
              Priority: P5 - low
             Component: Hold requests
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: jonathan.druart+koha at gmail.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com
    
    With es-ES:
    Template process failed: file error - parse error - holds_table.inc line
    216-217: unexpected token (hold)                                               
                                                                  [% "
    hold.reserve_id="hold.reserve_id" html="html" name="printholdslip"
    type="button" value="Recibo" |="|"></td>                                        
     [% ELSE %] at /kohadevbox/koha/C4/Templates.pm line 127
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 16:28:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 14:28:48 +0000
    Subject: [Koha-bugs] [Bug 30405] Style of address in patron search result
     are 110%
    In-Reply-To: <bug-30405-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30405-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30405-70-ep5mOMS5bF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30405
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 16:28:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 14:28:52 +0000
    Subject: [Koha-bugs] [Bug 30405] Style of address in patron search result
     are 110%
    In-Reply-To: <bug-30405-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30405-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30405-70-A4yUxlzsf7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30405
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133452|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 16:29:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 14:29:13 +0000
    Subject: [Koha-bugs] [Bug 30405] Style of address in patron search result
     are 110%
    In-Reply-To: <bug-30405-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30405-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30405-70-ni5ZBXDiTq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30405
    
    --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133568
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133568&action=edit
    Bug 30405: Reduce font-size for address in patron search result
    
    The address has a font-size: 110%, it's not needed here, 100% is enough.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 16:29:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 14:29:35 +0000
    Subject: [Koha-bugs] [Bug 30583] Hold system broken for translated template
    In-Reply-To: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30583-70-DumsJnGTvZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30583
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |ASSIGNED
             Depends on|                            |29338
               Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                       |ity.org                     |com
    
    --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Caused by
      commit a68021a2387ff1caf854c17fc5331e85926c1f7e
      Bug 29338: Add print hold/transfer button to request.tt
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29338
    [Bug 29338] Reprinting holds slip with updated expiration date
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 16:29:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 14:29:35 +0000
    Subject: [Koha-bugs] [Bug 29338] Reprinting holds slip with updated
     expiration date
    In-Reply-To: <bug-29338-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29338-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29338-70-TkwEVTdHKX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29338
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30583
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30583
    [Bug 30583] Hold system broken for translated template
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 16:32:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 14:32:06 +0000
    Subject: [Koha-bugs] [Bug 30583] Hold system broken for translated template
    In-Reply-To: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30583-70-1notRw5rel@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30583
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 16:32:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 14:32:12 +0000
    Subject: [Koha-bugs] [Bug 30583] Hold system broken for translated template
    In-Reply-To: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30583-70-QSQvW6z46x@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30583
    
    --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133569
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133569&action=edit
    Bug 30583: Fix hold system for translated templates
    
    There are missing quotes, and the translate script is messing up with
    the generated template.
    
    Error is:
    Template process failed: file error - parse error - holds_table.inc line
    216-217: unexpected token (hold)
    
    The generated line, without this patch is:
    216 <td><input %]="%]" class="printholdslip" data-reserve_id="[%"
    hold.reserve_id="hold.reserve_id" html="html" name="printholdslip"
    type="button" value="Recibo" |="|"></td>
    With this patch applied:
    216  <td><input class="printholdslip" data-reserve_id="[% hold.reserve_id |
    html %]" name="printholdslip" type="button" value="Recibo"></td>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 16:34:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 14:34:04 +0000
    Subject: [Koha-bugs] [Bug 30583] Hold system broken for translated template
    In-Reply-To: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30583-70-7n69QpzI4l@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30583
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |rel_21_05_candidate,
                       |                            |rel_21_11_candidate
                     CC|                            |andrew at bywatersolutions.com
                       |                            |, kyle at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 16:36:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 14:36:05 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-l1CyaWHnZP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Severity|enhancement                 |normal
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 16:42:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 14:42:59 +0000
    Subject: [Koha-bugs] [Bug 30583] Hold system broken for translated template
    In-Reply-To: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30583-70-LfHYg6msaA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30583
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 16:43:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 14:43:03 +0000
    Subject: [Koha-bugs] [Bug 30583] Hold system broken for translated template
    In-Reply-To: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30583-70-IQpkWFD3al@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30583
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133569|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> ---
    Created attachment 133570
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133570&action=edit
    Bug 30583: Fix hold system for translated templates
    
    There are missing quotes, and the translate script is messing up with
    the generated template.
    
    Error is:
    Template process failed: file error - parse error - holds_table.inc line
    216-217: unexpected token (hold)
    
    The generated line, without this patch is:
    216 <td><input %]="%]" class="printholdslip" data-reserve_id="[%"
    hold.reserve_id="hold.reserve_id" html="html" name="printholdslip"
    type="button" value="Recibo" |="|"></td>
    With this patch applied:
    216  <td><input class="printholdslip" data-reserve_id="[% hold.reserve_id |
    html %]" name="printholdslip" type="button" value="Recibo"></td>
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 16:43:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 14:43:34 +0000
    Subject: [Koha-bugs] [Bug 30583] Hold system broken for translated template
    In-Reply-To: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30583-70-PvTT7OV508@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30583
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lucas at bywatersolutions.com
    
    --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> ---
    Thanks Jonathan, sorry about that one :(
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 16:45:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 14:45:15 +0000
    Subject: [Koha-bugs] [Bug 30580] GetItemsAvailableToFillHoldRequestsForBib
     should get transfers during initial query
    In-Reply-To: <bug-30580-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30580-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30580-70-Kp7aNdnjrk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30580
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                       |ity.org                     |
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 16:45:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 14:45:25 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-lFVuBSRDE3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    --- Comment #29 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    (In reply to Martin Renvoize from comment #28)
    > My one caveat is something doesn't feel quite right about the introduction
    > of 'send_confirm_notice' as a method in Koha::Auth::TwoFactorAuth, but I can
    > see why you do it so it's testable.. I'll leave that query to QA
    
    That's something I noticed as well, it feels misplaced.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 16:49:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 14:49:55 +0000
    Subject: [Koha-bugs] [Bug 22223] Item url double-encode when parameter is an
     encoded URL
    In-Reply-To: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22223-70-bRMOdQ9nT7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22223
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 16:49:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 14:49:59 +0000
    Subject: [Koha-bugs] [Bug 22223] Item url double-encode when parameter is an
     encoded URL
    In-Reply-To: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22223-70-Wgo8fd7zjw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22223
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133567|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 16:56:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 14:56:33 +0000
    Subject: [Koha-bugs] [Bug 30512] Staff interface search results template
     error
    In-Reply-To: <bug-30512-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30512-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30512-70-QLhFe7qy6L@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 16:56:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 14:56:39 +0000
    Subject: [Koha-bugs] [Bug 30512] Staff interface search results template
     error
    In-Reply-To: <bug-30512-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30512-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30512-70-8t14p87E9s@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133211|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133571
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133571&action=edit
    Bug 30512: Staff interface search results template error
    
    This patch removes some markup from the search results template which
    was causing markup to be output on the screen. Rather than correct the
    markup so that the "p1" class is correctly added to the relevant links
    I'm removing it. The "p1" class isn't used anywhere.
    
    The patch also corrects two incorrect template filters on one of the
    page's links.
    
    To test, apply the patch and enable the following system preferences:
    
    - AmazonCoverImages
    - IntranetCoce (if available)
    - LocalCoverImages
    
    - Perform a catalog search in the staff interface which will return
      results with cover images from each of the enabled services.
    - The covers should show correctly in the search results with no markup
      being output on screen.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 16:56:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 14:56:55 +0000
    Subject: [Koha-bugs] [Bug 30512] Staff interface search results template
     error
    In-Reply-To: <bug-30512-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30512-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30512-70-MXXRS3pKLj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com
    
    --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Oops, thanks Owen!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 17:00:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 15:00:18 +0000
    Subject: [Koha-bugs] [Bug 22223] Item url double-encode when parameter is an
     encoded URL
    In-Reply-To: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22223-70-DP9OUokxpE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22223
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 17:00:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 15:00:22 +0000
    Subject: [Koha-bugs] [Bug 30577] Item specific holds location can be missed
     when placing title level holds
    In-Reply-To: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30577-70-Vpn1awlM8b@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 17:00:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 15:00:26 +0000
    Subject: [Koha-bugs] [Bug 30577] Item specific holds location can be missed
     when placing title level holds
    In-Reply-To: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30577-70-nv6SZ1Cf01@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133539|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Created attachment 133572
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133572&action=edit
    Bug 30577: Move item specific pickup locations to the left
    
    When placing holds, staff will set the pickup location at the top,
    choose an item, then place the hold.
    It is easy not to notice the item specific locations dropdown.
    
    This patch moves it in line with the other selction areas on the request
    screen.
    
    To test:
     1 - Find a record on staff client, place hold
     2 - Select a patron to load the request screen
     3 - Note the location dropdown for next available hold
     4 - Note the item specific locations on the far right
     5 - Apply patch
     6 - Reload the page
     7 - Note the item specific location dropdowns are now moved to the left
     8 - Place the hold, verify it works with the dropdowns
     9 - Verify title levelholds still work as expected
    10 - Verify multi-holds still work
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 17:00:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 15:00:31 +0000
    Subject: [Koha-bugs] [Bug 30577] Item specific holds location can be missed
     when placing title level holds
    In-Reply-To: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30577-70-4kAYQxaegv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133540|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Created attachment 133573
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133573&action=edit
    Bug 30577: Fix a missing closing tag
    
    This didn't affect table display, but when there was a biblioloo.warn
    we were not closing the first <td> tag
    
    Confirm multi-holds table loads correctly when one (or more) records cannot be
    held
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 17:00:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 15:00:34 +0000
    Subject: [Koha-bugs] [Bug 22223] Item url double-encode when parameter is an
     encoded URL
    In-Reply-To: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22223-70-mal0ylKl4K@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22223
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133567|1                           |0
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 17:01:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 15:01:27 +0000
    Subject: [Koha-bugs] [Bug 30584] New: Cannot add field mappings to
     Elasticsearch configuration
    Message-ID: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584
    
                Bug ID: 30584
               Summary: Cannot add field mappings to Elasticsearch
                        configuration
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: major
              Priority: P5 - low
             Component: Searching - Elasticsearch
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: nick at bywatersolutions.com
    
    bug 29893 redraws the table before submission - this appears to remove any rows
    we have added
    
    To test:
    1 - Browse to Administration -> Catalog -> Search engine configuration
    (Elasticsearch)
    2 - Click on 'Bibliographic records' tab
    3 - Scroll to bottom and enter a new mapping and click '+Add' button at far
    right
    4 - Click 'Save' button at bottom
    5 - You may notice your new row disappears, then the page reloads
    6 - Check for your new mapping - it has not been added
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 17:01:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 15:01:47 +0000
    Subject: [Koha-bugs] [Bug 22223] Item url double-encode when parameter is an
     encoded URL
    In-Reply-To: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22223-70-t6ftfRZmdv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22223
    
    --- Comment #33 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Can you provide some regression tests for this?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 17:01:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 15:01:49 +0000
    Subject: [Koha-bugs] [Bug 30584] Cannot add field mappings to Elasticsearch
     configuration
    In-Reply-To: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30584-70-byP8cD5rt1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |29893
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29893
    [Bug 29893] ElasticSearch Config UI deletes mappings
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 17:01:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 15:01:49 +0000
    Subject: [Koha-bugs] [Bug 29893] ElasticSearch Config UI deletes mappings
    In-Reply-To: <bug-29893-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29893-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29893-70-iGoVu1NzUL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29893
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30584
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584
    [Bug 30584] Cannot add field mappings to Elasticsearch configuration
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 17:08:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 15:08:44 +0000
    Subject: [Koha-bugs] [Bug 30564] Prevent user in staff interface from
     setting incorrect pickup location on item-level hold
    In-Reply-To: <bug-30564-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30564-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30564-70-wD5ZsaAGOa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30564
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |DUPLICATE
                 Status|NEW                         |RESOLVED
    
    --- Comment #1 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    
    
    *** This bug has been marked as a duplicate of bug 30579 ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 17:08:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 15:08:44 +0000
    Subject: [Koha-bugs] [Bug 30579] When placing item level hold,
     some options that are not used are not disabled
    In-Reply-To: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30579-70-3k4i3gpyvs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579
    
    --- Comment #3 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    *** Bug 30564 has been marked as a duplicate of this bug. ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 17:11:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 15:11:23 +0000
    Subject: [Koha-bugs] [Bug 23111] Setting a custom framework as the default
     for cataloguing is not possible
    In-Reply-To: <bug-23111-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23111-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23111-70-rJJMgyFswg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111
    
    --- Comment #36 from Holly <hc at interleaf.ie> ---
    Is the test from comment 26 still valid?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 17:11:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 15:11:54 +0000
    Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing
     secret via HTTP GET
    In-Reply-To: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29873-70-wMK5wVMf35@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|20476                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20476
    [Bug 20476] Two factor authentication for the staff client - omnibus
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 17:11:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 15:11:54 +0000
    Subject: [Koha-bugs] [Bug 20476] Two factor authentication for the staff
     client - omnibus
    In-Reply-To: <bug-20476-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20476-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20476-70-Jtt3eHCw6l@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20476
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|29873                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873
    [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 17:16:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 15:16:48 +0000
    Subject: [Koha-bugs] [Bug 30579] When placing item level hold,
     some options that are not used are not disabled
    In-Reply-To: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30579-70-dBsikvtwWT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 17:16:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 15:16:52 +0000
    Subject: [Koha-bugs] [Bug 30579] When placing item level hold,
     some options that are not used are not disabled
    In-Reply-To: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30579-70-OpOOXBv0Nl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133549|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Created attachment 133574
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133574&action=edit
    Bug 30579: Disentangle multi-hold and single bib forms
    
    This patch simply groups the forms so that multi-hold and single
    hold are each in their own section
    
    While there is some duplication from this, it makes the sections easier to read
    and allows for more variation in the two forms
    
    To test:
    1 - Place a single bib and multi bib hold in staff client
    2 - Apply this patch
    3 - Repeat and confirm nothing changes with this patch
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 17:16:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 15:16:57 +0000
    Subject: [Koha-bugs] [Bug 30579] When placing item level hold,
     some options that are not used are not disabled
    In-Reply-To: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30579-70-4y4T0TkzIm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133550|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Created attachment 133575
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133575&action=edit
    Bug 30579: Group next available hold options, and disable when item is chosen
    
    This patch rearranges options that only apply to next available holds
    and disables them when an item is checked. This is intended to make it
    more obvious which parts of the form apply to this selection
    
    To test:
    1 - Apply patches
    2 - Confirm you can successfully place single or multiple items on hold
    3 - Confirm that when placing a single hold the next available options are
    grouped
    4 - Confirm pickup location, specific item type, and number of holds all work
    for next available
    5 - Confirm item level holds save pickup location correctly
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 17:34:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 15:34:25 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-gotZNFgzfN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    --- Comment #6 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133576
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133576&action=edit
    Bug 30558: All is well!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 17:43:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 15:43:15 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-lqbN2Am1AP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133375|0                           |1
            is obsolete|                            |
     Attachment #133576|0                           |1
            is obsolete|                            |
    
    --- Comment #7 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133577
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133577&action=edit
    Bug 30558: All is well! 2
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 17:45:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 15:45:36 +0000
    Subject: [Koha-bugs] [Bug 22223] Item url double-encode when parameter is an
     encoded URL
    In-Reply-To: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22223-70-ary0pWMwSI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22223
    
    --- Comment #34 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133578
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133578&action=edit
    Bug 22223: Add tests
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 17:56:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 15:56:08 +0000
    Subject: [Koha-bugs] [Bug 27470] Improve link text for logging in
    In-Reply-To: <bug-27470-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27470-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27470-70-aJ1tVCoU4s@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27470
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 17:56:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 15:56:12 +0000
    Subject: [Koha-bugs] [Bug 27470] Improve link text for logging in
    In-Reply-To: <bug-27470-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27470-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27470-70-wPj35e1CNB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27470
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133508|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133579
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133579&action=edit
    Bug 27470: Improved link text for shibboleth login
    
    TEST PLAN:
    1) Enable shibboleth by adding shibboleth to koha-conf.xml, you can do
       this by following
    
      
    https://wiki.koha-community.org/wiki/Shibboleth_Configuration#Using_AD_FS_Metadata
    
    2) If you are logged in Koha, log out, on the login screen the text
       at the top should say the following, "Log in using a Shibboleth
       account"
    
    Sponsored-by: Catalyst IT
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 17:56:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 15:56:25 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-oPnErCyz8R@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Christopher Brannon <cbrannon at cdalibrary.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Failed QA
    
    --- Comment #46 from Christopher Brannon <cbrannon at cdalibrary.org> ---
    Some of these were in your test plan and didn't show.  Others were not and need
    to be considered.
    
    * Middle name does not show when typing name to search for patron when placing
    hold (request.pl)
    * Middle name does not show in dialog at top of hold form (request.pl)
    * Middle name does not show in patron details at top of hold form (request.pl)
    * Middle name field does not show in opac-memberentry.pl
    * Middle name is not an option on SelfModificationBorrowerUnwantedField in
    preferences.pl
    * Middle name is not an option on PatronSelfModificationMandatoryField in
    preferences.pl
    * Middle name is not an option on PatronSelfRegistrationBorrowerMandatoryField
    in preferences.pl
    * Middle name is not an option on PatronSelfRegistrationBorrowerUnwantedField
    in preferences.pl
    * Middle name is not an option on BorrowerUnwantedField in preferences.pl
    * Middle name is not an option on BorrowerMandatoryField in preferences.pl
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 17:57:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 15:57:37 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-i4tj8VFOuW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    --- Comment #47 from Christopher Brannon <cbrannon at cdalibrary.org> ---
    Otherwise, everything else looked great.  Searching was not a problem.  Just a
    few missed areas, and the controls are just not all there for mandatory or
    unwanted preferences.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 17:58:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 15:58:16 +0000
    Subject: [Koha-bugs] [Bug 23111] Setting a custom framework as the default
     for cataloguing is not possible
    In-Reply-To: <bug-23111-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23111-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23111-70-WddEc5Xg9z@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Patch doesn't apply
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 17:59:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 15:59:31 +0000
    Subject: [Koha-bugs] [Bug 30584] Cannot add field mappings to Elasticsearch
     configuration
    In-Reply-To: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30584-70-Yau0Z5WfpJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com
    
    --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    This template is a nightmare...
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:01:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:01:15 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-aVkUnYcOfp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133523|0                           |1
            is obsolete|                            |
    
    --- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133580
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133580&action=edit
    Bug 28998: Introduce Koha::Encryption
    
    Test plan:
    Run t/db_dependent/Koha/Encryption.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    [AMENDED] Added copyright line to module.
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:01:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:01:20 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-8GApsbhCyU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133524|0                           |1
            is obsolete|                            |
    
    --- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133581
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133581&action=edit
    Bug 28998: (follow-up) Add Patron->encode_secret and ->decoded_secret
    
    Test plan:
    Run t/db_dependent/Koha/Patron.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:01:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:01:25 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-hsh56Texaq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133525|0                           |1
            is obsolete|                            |
    
    --- Comment #31 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133582
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133582&action=edit
    Bug 28998: (follow-up) Apply changes to TwoFactorAuth module and script
    
    Test plan:
    Run t/db_dependent/Koha/Auth/TwoFactorAuth.t
    Walk thru cycle register - logout/login - deregister - logout/login.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:01:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:01:29 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-yklc0CApG4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133526|0                           |1
            is obsolete|                            |
    
    --- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133583
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133583&action=edit
    Bug 28998: Adjust Selenium test
    
    Test plan:
    Run t/db_dependent/selenium/authentication_2fa.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:01:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:01:34 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-rdYmctQqUg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133527|0                           |1
            is obsolete|                            |
    
    --- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133584
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133584&action=edit
    Bug 28998: [TO_BE_SQUASHED] Adjust secret in Selenium test
    
    This patch can be squashed with the previous one, if all is ok.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:01:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:01:38 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-XytWwDchsb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133528|0                           |1
            is obsolete|                            |
    
    --- Comment #34 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133585
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133585&action=edit
    Bug 28998: Add encryption_key to the config file
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:01:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:01:43 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-UpnxKTFQ5t@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133529|0                           |1
            is obsolete|                            |
    
    --- Comment #35 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133586
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133586&action=edit
    Bug 28998: Add Crypt::CBC dependency
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:04:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:04:37 +0000
    Subject: [Koha-bugs] [Bug 30583] Hold system broken for translated template
    In-Reply-To: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30583-70-hajn0dgdQZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30583
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |tomascohen at gmail.com
                 Status|Signed Off                  |Passed QA
       Patch complexity|---                         |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:04:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:04:40 +0000
    Subject: [Koha-bugs] [Bug 30583] Hold system broken for translated template
    In-Reply-To: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30583-70-tTG8dsL1G7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30583
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133570|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:05:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:05:29 +0000
    Subject: [Koha-bugs] [Bug 30583] Hold system broken for translated template
    In-Reply-To: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30583-70-ot8Hzd1yjJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30583
    
    --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133587
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133587&action=edit
    Bug 30583: Fix hold system for translated templates
    
    There are missing quotes, and the translate script is messing up with
    the generated template.
    
    Error is:
    Template process failed: file error - parse error - holds_table.inc line
    216-217: unexpected token (hold)
    
    The generated line, without this patch is:
    216 <td><input %]="%]" class="printholdslip" data-reserve_id="[%"
    hold.reserve_id="hold.reserve_id" html="html" name="printholdslip"
    type="button" value="Recibo" |="|"></td>
    With this patch applied:
    216  <td><input class="printholdslip" data-reserve_id="[% hold.reserve_id |
    html %]" name="printholdslip" type="button" value="Recibo"></td>
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:05:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:05:39 +0000
    Subject: [Koha-bugs] [Bug 30583] Hold system broken for translated template
    In-Reply-To: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30583-70-gJLiY044pk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30583
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                       |y.org                       |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:07:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:07:04 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-ZvTpbZy8yi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    --- Comment #36 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    This all makes a lot of sense to me.. I can see a case in the future for a
    distinct table, but I'm not aware of an allow-list on reports yet so that can
    come later in my opinion.
    
    I wonder slightly about the accessor names in Koha::Patron.. we could just
    silently encrypt/descrypt and continue to rely on 'secret' as our accessor
    name.. but that's not a big issue.  I also wonder if the field in general
    should be clearer.. this secret us specific to this form of on time password
    for 2FA.. calling is 'secret' is very generic.. but again.. that's from the
    earlier bug.
    
    As is it.. PQA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:08:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:08:42 +0000
    Subject: [Koha-bugs] [Bug 30585] New: Table settings for
     course_reserves_table are wrong due to lack of "Holding library" option
    Message-ID: <bug-30585-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30585
    
                Bug ID: 30585
               Summary: Table settings for course_reserves_table are wrong due
                        to lack of "Holding library" option
     Change sponsored?: ---
               Product: Koha
               Version: 21.05
              Hardware: All
                    OS: All
                Status: NEW
              Severity: trivial
              Priority: P5 - low
             Component: System Administration
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: jrobb at sekls.org
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com
    
    The table generated at course-details.pl has columns for both Home library and
    Holding library, but course_reserves_table in the Table settings admin area
    only has a single toggle for 'library'.
    
    Hiding 'library' hides the Home library column. Anything after that is off by
    one. Hiding 'staff_note' actually hides the Holding library column, 'link'
    hides Public note, etc.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:09:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:09:17 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-L4sxk3ffbZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:11:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:11:58 +0000
    Subject: [Koha-bugs] [Bug 22223] Item url double-encode when parameter is an
     encoded URL
    In-Reply-To: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22223-70-8ESJgxBO2k@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22223
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                       |y.org                       |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:16:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:16:12 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-xfkTazkIWK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    --- Comment #37 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133588
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133588&action=edit
    Bug 28998: (QA follow-up) POD Fix
    
    This POD fix keeps the QA script happy
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:16:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:16:17 +0000
    Subject: [Koha-bugs] [Bug 22223] Item url double-encode when parameter is an
     encoded URL
    In-Reply-To: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22223-70-2UvywoKnEv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22223
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
       Patch complexity|---                         |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:16:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:16:20 +0000
    Subject: [Koha-bugs] [Bug 22223] Item url double-encode when parameter is an
     encoded URL
    In-Reply-To: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22223-70-If3eKH4lA7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22223
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133578|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:16:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:16:24 +0000
    Subject: [Koha-bugs] [Bug 22223] Item url double-encode when parameter is an
     encoded URL
    In-Reply-To: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22223-70-wpNbh5c3ON@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22223
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133567|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:16:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:16:59 +0000
    Subject: [Koha-bugs] [Bug 22223] Item url double-encode when parameter is an
     encoded URL
    In-Reply-To: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22223-70-wKh16KVfXb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22223
    
    --- Comment #35 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133589
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133589&action=edit
    Bug 22223: Try to not double encoded URIs in items.uri
    
    This is just a POC and is not ready for inclusion (Filter.pm and naming
    need to be discussed).
    
    Test plan:
    Create 2 items, with uri:
      https://www.google.com/url?q=https://buttercup.pw
      https://www.google.com/url?q=https%3A%2F%2Fbuttercup.pw
    
    Go to the OPAC detail page of the bib record, see that the links are
    displayed how you entered them.
    Click on them and confirm that the uri/page is correct
    
    Signed-off-by: Séverine Queune <severine.queune at bulac.fr>
    
    JD amended patch:
    * Remove use Template::Plugin::Filter;
    * Fix license statement
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:17:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:17:05 +0000
    Subject: [Koha-bugs] [Bug 22223] Item url double-encode when parameter is an
     encoded URL
    In-Reply-To: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22223-70-Au66zrI12v@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22223
    
    --- Comment #36 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133590
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133590&action=edit
    Bug 22223: Add tests
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Edit: fixed tests count
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:18:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:18:23 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-bIv2YF8WlB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:20:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:20:34 +0000
    Subject: [Koha-bugs] [Bug 22223] Item url double-encode when parameter is an
     encoded URL
    In-Reply-To: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22223-70-kl4clOPQeu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22223
    
    --- Comment #37 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    (In reply to Jonathan Druart from comment #34)
    > Created attachment 133578 [details] [review]
    > Bug 22223: Add tests
    
    Great job, thanks
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:31:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:31:57 +0000
    Subject: [Koha-bugs] [Bug 30586] New: The fallback option when enabling MFA
     for login doesn't work
    Message-ID: <bug-30586-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30586
    
                Bug ID: 30586
               Summary: The fallback option when enabling MFA for login
                        doesn't work
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Patrons
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: martin.renvoize at ptfs-europe.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
            Depends on: 28786
    
    We are missing the shared secret from the fallback display for when a user
    cannot use a QR scanner when enabling 2FA.
    
    I'm not sure how wise it is to display it in full text immediately anyway,
    perhaps it should be hidden by default.. but as it is, I can't see how the
    fallback would ever work..
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    [Bug 28786] Two-factor authentication for staff client - TOTP
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:31:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:31:57 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-G1DyNdW9Zp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30586
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30586
    [Bug 30586] The fallback option when enabling MFA for login doesn't work
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:32:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:32:41 +0000
    Subject: [Koha-bugs] [Bug 30587] New: Incorrect translations in some
     templates
    Message-ID: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30587
    
                Bug ID: 30587
               Summary: Incorrect translations in some templates
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Templates
              Assignee: oleonard at myacpl.org
              Reporter: tomascohen at gmail.com
            QA Contact: testopia at bugs.koha-community.org
    
    Searching for [% in the https://translate.koha-community.org site on some
    language highlights some problems. I open this bug to tackle them.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:33:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:33:18 +0000
    Subject: [Koha-bugs] [Bug 30587] Incorrect translations in some templates
    In-Reply-To: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30587-70-mb5gtb2FYP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30587
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com,
                       |                            |katrin.fischer at bsz-bw.de,
                       |                            |lucas at bywatersolutions.com,
                       |                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:34:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:34:24 +0000
    Subject: [Koha-bugs] [Bug 30588] New: Add the option to require 2FA setup on
     first login
    Message-ID: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588
    
                Bug ID: 30588
               Summary: Add the option to require 2FA setup on first login
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Authentication
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: martin.renvoize at ptfs-europe.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: dpavlin at rot13.org
    
    We should add the option to require 2FA configuration at first login for staff
    users when 2FA is enabled on the system.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:34:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:34:36 +0000
    Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on
     first login
    In-Reply-To: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30588-70-ni3laMkkqv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |28786
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    [Bug 28786] Two-factor authentication for staff client - TOTP
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:34:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:34:36 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-42vTajgFa6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30588
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588
    [Bug 30588] Add the option to require 2FA setup on first login
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:34:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:34:44 +0000
    Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on
     first login
    In-Reply-To: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30588-70-QeZx0Yvbpl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |20476
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20476
    [Bug 20476] Two factor authentication for the staff client - omnibus
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:34:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:34:44 +0000
    Subject: [Koha-bugs] [Bug 20476] Two factor authentication for the staff
     client - omnibus
    In-Reply-To: <bug-20476-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20476-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20476-70-WsgvmnJhj5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20476
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30588
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588
    [Bug 30588] Add the option to require 2FA setup on first login
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:35:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:35:31 +0000
    Subject: [Koha-bugs] [Bug 29835] 2FA - ask for the password when 2FA is
     disabled
    In-Reply-To: <bug-29835-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29835-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29835-70-Svr7hZsp9l@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29835
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
                 Blocks|                            |20476
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20476
    [Bug 20476] Two factor authentication for the staff client - omnibus
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:35:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:35:31 +0000
    Subject: [Koha-bugs] [Bug 20476] Two factor authentication for the staff
     client - omnibus
    In-Reply-To: <bug-20476-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20476-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20476-70-P675vt8s8R@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20476
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |29835
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29835
    [Bug 29835] 2FA - ask for the password when 2FA is disabled
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:36:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:36:38 +0000
    Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
    In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28787-70-2ZH3mYoNxl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |20476
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20476
    [Bug 20476] Two factor authentication for the staff client - omnibus
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:36:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:36:38 +0000
    Subject: [Koha-bugs] [Bug 20476] Two factor authentication for the staff
     client - omnibus
    In-Reply-To: <bug-20476-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20476-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20476-70-tltM5Eb5cC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20476
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |28787
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787
    [Bug 28787] Send a notice with the TOTP token
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:42:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:42:29 +0000
    Subject: [Koha-bugs] [Bug 19887] Two Factor Authentication: Google
     Authenticator
    In-Reply-To: <bug-19887-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-19887-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-19887-70-79vxHIQDcK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19887
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |DUPLICATE
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
                 Status|NEW                         |RESOLVED
    
    --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    
    
    *** This bug has been marked as a duplicate of bug 28786 ***
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:42:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:42:29 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-TTCq1FSY88@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |black23 at gmail.com
    
    --- Comment #158 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    *** Bug 19887 has been marked as a duplicate of this bug. ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:42:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:42:31 +0000
    Subject: [Koha-bugs] [Bug 20476] Two factor authentication for the staff
     client - omnibus
    In-Reply-To: <bug-20476-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20476-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20476-70-ItwOObxCmz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20476
    Bug 20476 depends on bug 19887, which changed state.
    
    Bug 19887 Summary: Two Factor Authentication: Google Authenticator
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19887
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |RESOLVED
             Resolution|---                         |DUPLICATE
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:42:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:42:42 +0000
    Subject: [Koha-bugs] [Bug 30587] Incorrect translations in some templates
    In-Reply-To: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30587-70-mF7uCIyvZz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30587
    
    --- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133591
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133591&action=edit
    Bug 30587: Fix opac-tags.tt translate issues
    
    This patch addresses one specific case.
    
    To test:
    1. Run:
       $ kshell
      k$ cd misc/translator
      k$ perl translate update es-ES
    2. On your git checkout run:
       $ git diff | grep '\[% limit or'
    => FAIL: That shouldn't be translated
    3. Run:
       $ git reset --hard HEAD
    4. Apply this patch
    5. Repeat 1 and 2
    => SUCCESS: No attempt to translate that tag
    6. Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:43:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:43:25 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-3GaJ1mYhhE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Signed Off
    
    --- Comment #38 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Still working here.. I just found it not working on my checkout and I'm not
    sure why.. setting back to give me time to work backwards.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:47:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:47:58 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-QBHUdYRyYE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    --- Comment #39 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    OK, I spotted it..
    
    I had dropped the config between first and second test.
    
    So.. I think this highlights an issue.. we should probably try/catch to give a
    better error than the 500 we currently throw on lack of configuration.. or
    fallback to unencrypted secrets when the key is missing.. but that
    re-introduces the security issue.
    
    Might even be worth a script to quickly encrypt un-encrypted secrets at upgrade
    if we don't get this pushed prior to release
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:48:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:48:06 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-788N0SkgOj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Failed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:51:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:51:44 +0000
    Subject: [Koha-bugs] [Bug 30587] Incorrect translations in some templates
    In-Reply-To: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30587-70-xm5lzpVRlV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30587
    
    --- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133592
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133592&action=edit
    Bug 30587: Fix acqui/supplier.tt translate issues
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:52:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:52:00 +0000
    Subject: [Koha-bugs] [Bug 30587] Incorrect translations in some templates
    In-Reply-To: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30587-70-1sCmvX62uu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30587
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:52:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:52:33 +0000
    Subject: [Koha-bugs] [Bug 30532] guided_reports.pl has a problem
    In-Reply-To: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30532-70-YQ0CMQj6m6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30532
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |tomascohen at gmail.com
             QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                       |y.org                       |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:53:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:53:48 +0000
    Subject: [Koha-bugs] [Bug 30532] guided_reports.pl has a problem
    In-Reply-To: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30532-70-dQL9OqtbkA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30532
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:53:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:53:51 +0000
    Subject: [Koha-bugs] [Bug 30532] guided_reports.pl has a problem
    In-Reply-To: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30532-70-VXA3cijA1f@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30532
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133561|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:54:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:54:17 +0000
    Subject: [Koha-bugs] [Bug 30532] guided_reports.pl has a problem
    In-Reply-To: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30532-70-nmH2s0VJHs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30532
    
    --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133593
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133593&action=edit
    Bug 30532: (bug 29957 follow-up) Fix '$cookie->value'
    
    We got
     Can't call method "value" on unblessed reference at
    /kohadevbox/koha/opac/opac-messaging.pl line 86
    
    $cookie can be an arrayref, we should retrieve the session id using
    CGI->cookie('CGISESSID')
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:55:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:55:48 +0000
    Subject: [Koha-bugs] [Bug 30525] Items batch modification broken
    In-Reply-To: <bug-30525-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30525-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30525-70-t6RLoXyqGX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30525
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
                     CC|                            |tomascohen at gmail.com
       Patch complexity|Small patch                 |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:55:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:55:51 +0000
    Subject: [Koha-bugs] [Bug 30525] Items batch modification broken
    In-Reply-To: <bug-30525-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30525-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30525-70-yAR5QolZVy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30525
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133411|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:56:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:56:55 +0000
    Subject: [Koha-bugs] [Bug 30525] Items batch modification broken
    In-Reply-To: <bug-30525-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30525-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30525-70-pBNIlScgwm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30525
    
    --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133594
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133594&action=edit
    Bug 30525: Items batch modification broken
    
    This patch modifies instances in the code which try to get cookies
    using:
    
    my %cookies = parse CGI::Cookie($cookie);
    
    In some cases the relevant lines can be removed because they are unused.
    In others it can be replaced with:
    
    my %cookies = CGI::Cookie->fetch();
    
    To test, apply the patch and restart_all. Test the following pages to
    confirm they load without errors:
    
    - Circulation -> Offline circulation file upload
    - Circulation -> Offline circulation -> Add to queue
    
    - Tools -> Batch item modification
    - Tools -> Stage MARC for import
    - Tools -> Staged MARC management
    - Tools -> Batch patron modification
    - Tools -> Upload local cover image
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 18:57:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 16:57:06 +0000
    Subject: [Koha-bugs] [Bug 30525] Items batch modification broken
    In-Reply-To: <bug-30525-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30525-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30525-70-gsOdpEiila@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30525
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                       |y.org                       |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 19:08:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 17:08:15 +0000
    Subject: [Koha-bugs] [Bug 30581] Items should show on the Holds Queue and
     Holds to Pull even if they have requested transfers
    In-Reply-To: <bug-30581-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30581-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30581-70-KXf6P1r4dV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30581
    
    Lisette Scheer <lisetteslatah at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lisetteslatah at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 19:09:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 17:09:50 +0000
    Subject: [Koha-bugs] [Bug 30585] Table settings for course_reserves_table
     are wrong due to lack of "Holding library" option
    In-Reply-To: <bug-30585-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30585-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30585-70-0uqiOZhl95@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30585
    
    koha-US bug tracker <bugzilla at koha-us.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |bugzilla at koha-us.org
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 19:09:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 17:09:52 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-E5FTWqCGSU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    --- Comment #159 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    (In reply to Jonathan Druart from comment #28)
    > (In reply to Martin Renvoize from comment #27)
    > > I've finally found a moment to look at this.
    > > 
    > > Whilst I like Tomas's proposal to normalise the database by having a
    > > distinct table.. I think that can certainly come as a followup later.
    > 
    > If we are talking about 3NF, I don't think having a separate table with a
    > single column (different than the FK) is what can be called normalisation.
    > 
    > If that is what you have in mind, I think it's wrong:
    > borrowers < 1-1 > secrets
    >                   - borrowernumber (FK borrowers.borrowernumber)
    >                   - secret
    
    Look at bug 29924 and it will become obvious that we are just delaying the
    inevitable discussion. Which is fine. But I hope we solve on the next cycle.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 19:12:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 17:12:30 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-quFODjfe1W@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    --- Comment #160 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    (In reply to David Cook from comment #25)
    > Note having a credential table could also make it easier to add "temporary"
    > passwords. 
    > 
    > For instance, it would be great if staff could reset a password, tell the
    > patron the password, and then the patron would be forced to reset that
    > password on first login. I'm going to raise a ticket for that and link it to
    > here...
    
    And that'd be yet another attribute for the credential (needs_reset?)... which
    shouldn't belong to the patron object itself.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 19:14:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 17:14:38 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-ZUV4HGH80p@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |tomascohen at gmail.com
    
    --- Comment #62 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Nick, do you *need* the password expiration on the API response? Can we remove
    it and have a separate route for dealing with that? It will become tricky with
    security, and also in light of the discussion on bug 28786 and friends, I think
    we should expose it in some other way if required.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 19:30:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 17:30:23 +0000
    Subject: [Koha-bugs] [Bug 30584] Cannot add field mappings to Elasticsearch
     configuration
    In-Reply-To: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30584-70-Z1gt8tZQ9V@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 19:30:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 17:30:27 +0000
    Subject: [Koha-bugs] [Bug 30584] Cannot add field mappings to Elasticsearch
     configuration
    In-Reply-To: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30584-70-NYSm1fO6rY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584
    
    --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133595
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133595&action=edit
    Bug 30584: Fix ES mapping creation
    
    We need to tell DT that we are adding/removing row, not only deal
    manually with the DOM.
    
    This patch also fixes the following bug: if you add or remove a row from
    the "biblio" tab, then go to another tab and back to "biblio", all
    changes were gone (bug existed prior to bug 29893).
    
    Test plan:
    Add, edit and remove mappings, switch from tabs and save.
    Use the filters, save (29893 regression test)
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 19:31:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 17:31:26 +0000
    Subject: [Koha-bugs] [Bug 30584] Cannot add field mappings to Elasticsearch
     configuration
    In-Reply-To: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30584-70-4ZPcAUFBlV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
               Severity|major                       |critical
               Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                       |ity.org                     |com
               Keywords|                            |rel_21_11_candidate
    
    --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Upping severity, it impacts stable.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 19:41:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 17:41:07 +0000
    Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
    In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-12446-70-Eih5aFLLSj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Failed QA
    
    --- Comment #180 from Owen Leonard <oleonard at myacpl.org> ---
    This seems to be working well. There's just one issue raised by the QA tool:
    
     FAIL   members/memberentry.pl
       FAIL   critic
                    # Variables::ProhibitUnusedVariables: Got 1 violation(s).
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 19:56:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 17:56:51 +0000
    Subject: [Koha-bugs] [Bug 11989] Holds Queue Scheduling
    In-Reply-To: <bug-11989-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-11989-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-11989-70-iBgq2BwoAl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11989
    
    Lisette Scheer <lisetteslatah at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lisetteslatah at gmail.com
    
    --- Comment #3 from Lisette Scheer <lisetteslatah at gmail.com> ---
    +1
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 20:00:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 18:00:00 +0000
    Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
    In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17015-70-T95FJHSpSl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015
    
    Shi Yao Wang <shi-yao.wang at inLibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131634|0                           |1
            is obsolete|                            |
    
    --- Comment #274 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
    Created attachment 133596
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133596&action=edit
    Bug 17015: Performance comparison (images)
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 20:00:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 18:00:12 +0000
    Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
    In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17015-70-Se1QdFnRfz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015
    
    Shi Yao Wang <shi-yao.wang at inLibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131635|0                           |1
            is obsolete|                            |
    
    --- Comment #275 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
    Created attachment 133597
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133597&action=edit
    Bug 17015: DiscreteCalendar UI, Back-End and necessary scripts
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 20:00:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 18:00:23 +0000
    Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
    In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17015-70-k2wDOmRRDb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015
    
    Shi Yao Wang <shi-yao.wang at inLibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131636|0                           |1
            is obsolete|                            |
    
    --- Comment #276 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
    Created attachment 133598
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133598&action=edit
    Bug 17015: Install scripts for DiscreteCalendar
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 20:00:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 18:00:32 +0000
    Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
    In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17015-70-FF9jQUmHfO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015
    
    Shi Yao Wang <shi-yao.wang at inLibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131637|0                           |1
            is obsolete|                            |
    
    --- Comment #277 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
    Created attachment 133599
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133599&action=edit
    Bug 17015: Schema file for new discrete_calendar table
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 20:00:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 18:00:42 +0000
    Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
    In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17015-70-EKtVzq0gf7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015
    
    Shi Yao Wang <shi-yao.wang at inLibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131638|0                           |1
            is obsolete|                            |
    
    --- Comment #278 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
    Created attachment 133600
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133600&action=edit
    Bug 17015: Tests for DiscreteCalendar
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 20:00:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 18:00:51 +0000
    Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
    In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17015-70-SAwd9c3Ckd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015
    
    Shi Yao Wang <shi-yao.wang at inLibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131639|0                           |1
            is obsolete|                            |
    
    --- Comment #279 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
    Created attachment 133601
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133601&action=edit
    Bug 17015: When using book drop mode, set check in time as closing hours
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 20:01:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 18:01:03 +0000
    Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
    In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17015-70-3cwpPROe17@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015
    
    Shi Yao Wang <shi-yao.wang at inLibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131640|0                           |1
            is obsolete|                            |
    
    --- Comment #280 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
    Created attachment 133602
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133602&action=edit
    Bug 17015: Automatically update calendar when creating or deleting a branch
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 20:01:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 18:01:15 +0000
    Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
    In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17015-70-jdk6uTbNiU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015
    
    Shi Yao Wang <shi-yao.wang at inLibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131641|0                           |1
            is obsolete|                            |
    
    --- Comment #281 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
    Created attachment 133603
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133603&action=edit
    Bug 17015: Rebase and tests for discrete calendar
    
    This patch is a rebase of all the previous patches in order to show the
    discrete calendar.
    
    TEST PLAN:
    1- Apply the patch
    2- Run installer/data/mysql/updatedatabase.pl
    3- Run misc/cronjobs/add_days_discrete_calendar.pl
    4- Check that the max date is today + 1 day
    5- Run t/db_dependent/DiscreteCalendar.t (All tests should pass)
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 20:01:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 18:01:26 +0000
    Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
    In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17015-70-sfbAi1ztRF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015
    
    Shi Yao Wang <shi-yao.wang at inLibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131667|0                           |1
            is obsolete|                            |
    
    --- Comment #282 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
    Created attachment 133604
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133604&action=edit
    Bug 17015: DiscreteCalendar->new() method is now in a HASH
    
    This patch adds missing curly brackets in all new() calls.
    All tests in t/ should pass too (The one that don't pass are not passing before
    the patch)
    
    TEST PLAN:
    1- Apply the patch
    2- Run installer/data/mysql/updatedatabase.pl
    3- Run misc/cronjobs/add_days_discrete_calendar.pl
    4- Check that the max date is today + 1 day
    5- Attempt a checkout
     ~ The error "Can't use string ("branchcode") as a HASH ref while
       "strict refs" in use at /kohadevbox/koha/Koha/DiscreteCalendar.pm line 79"
    is no longer here
    5- Run t/db_dependent/DiscreteCalendar.t (prove -l
    t/db_dependent/DiscreteCalendar.t)
    6- Run all koha test in t/ (prove t). All tests should pass
    7- Use Discrete Calendar in Tools->Calendar
    
    USING THE DISCRETE CALENDAR:
    1- New UI
      a) Calendar on the left
      b) Holidays list on the right
    2- New color system for holiday types:
      a) Working day : white
      b) Unique holiday: red
      c) Holiday repeating weekly: yellow
      d) Holiday repeating yearly: orange
      e) Floating holiday: green
      f) Need validation: blue
    3- When clicking on a date in the calendar, opening, closing hours and holiday
    type are displayed.
    4- All the fields are editable
    5- New radio button to Edit selected dates or Copy to different dates
    6- Option to copy the calendar to another branch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 20:01:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 18:01:37 +0000
    Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
    In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17015-70-I0MKuQgyBH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015
    
    Shi Yao Wang <shi-yao.wang at inLibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132199|0                           |1
            is obsolete|                            |
    
    --- Comment #283 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
    Created attachment 133605
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133605&action=edit
    Bug 17015: Fixing QA tools failures
    
    This patch fixes tests that fails with the QA tool.
    
    To test, run the QA tool
    All tests should say OK except 2 that fails.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 20:19:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 18:19:19 +0000
    Subject: [Koha-bugs] [Bug 26839] Add a 'date published' feature to the facets
    In-Reply-To: <bug-26839-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26839-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26839-70-24kkzJA1fX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26839
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
    
    --- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Duplicate of Bug 10734 ?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 20:19:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 18:19:35 +0000
    Subject: [Koha-bugs] [Bug 26839] Add a 'date published' feature to the facets
    In-Reply-To: <bug-26839-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26839-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26839-70-vOPWfleUfk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26839
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=10734
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 20:19:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 18:19:35 +0000
    Subject: [Koha-bugs] [Bug 10734] Add Publication Date Facet in Searching
    In-Reply-To: <bug-10734-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-10734-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-10734-70-9nG5KLEeww@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10734
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=26839
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 20:22:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 18:22:07 +0000
    Subject: [Koha-bugs] [Bug 10734] Add Publication Date Facet in Searching
    In-Reply-To: <bug-10734-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-10734-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-10734-70-1jFWVK6Qv8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10734
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
    
    --- Comment #8 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    We should add this facet at least for Elasticsearch where it can be configured
    and disabled via staff interface.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 20:28:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 18:28:02 +0000
    Subject: [Koha-bugs] [Bug 28138] Add system preference to make the payment
     type required
    In-Reply-To: <bug-28138-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28138-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28138-70-YTt0nzpQUA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28138
    
    --- Comment #10 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133606
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133606&action=edit
    Bug 28138: (follow-up) Add empty option to payment type selection
    
    This patch adds an empty <option> to the "Payment type" selection when
    paying fine. This forces the user to actively make a selection. I've
    also added the text "None selected" to the other empty <option> on the
    page for consistency.
    
    To test, apply the patch and test the pay fine interface with and
    without the RequirePaymentType preference enabled. When enabled the
    payment type should be required and it should default to "None
    selected."
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 21:03:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 19:03:15 +0000
    Subject: [Koha-bugs] [Bug 13412] Allow configuration of auto-created
     authorities
    In-Reply-To: <bug-13412-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-13412-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-13412-70-ki2KcSkdoS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13412
    
    Shi Yao Wang <shi-yao.wang at inLibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
      Attachment #99710|0                           |1
            is obsolete|                            |
    
    --- Comment #7 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
    Created attachment 133607
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133607&action=edit
    Bug 13412: Allow configuration of auto-created authorities
    
    This patch add 2 new system preferences:
    - GenerateAuthorityField667
    - GenerateAuthorityField670
    
    When Koha creates authority records from biblios, use these preferences instead
    of the hard-coded "Machine generated authority record." and "Work cat." values.
    
    Test plan:
        1. Make sure AutoCreateAuthorities and BiblioAddsAuthorities are enabled in
    the system preferences
        2. Go to Home › Cataloging › Add MARC record and add a new record
        3. Fill in the required fields and add a name in the 100$a field. Note the
    name, and add the new record.
        4. run rebuild_zebra.pl -a
        5. Go to Home › Authorities and search for the name you entered in 100$a
        6. Select details and look at the 667 and 670 fields. They should default
    to the hard-coded values.
        7. Apply patch, run update database
        8. Edit the new GenerateAuthorityField667 and GenerateAuthorityField670
    system preferences
        9. Do 2-6 . Now the 667 and 670 fields should be what you entered in the
    system preferences.
    
    Thanks for testing
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Works well, no errors
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 21:03:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 19:03:20 +0000
    Subject: [Koha-bugs] [Bug 30589] New: Allow importing circulation conditions
     as CSV or spreadsheet
    Message-ID: <bug-30589-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30589
    
                Bug ID: 30589
               Summary: Allow importing circulation conditions as CSV or
                        spreadsheet
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: System Administration
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: katrin.fischer at bsz-bw.de
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com
            Depends on: 18392
    
    Bug 18392 covers exporting, but it would be great if the rules could be
    imported from a spreadsheet as well.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392
    [Bug 18392] Allow exporting circulation conditions as CSV or spreadsheet
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 21:03:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 19:03:20 +0000
    Subject: [Koha-bugs] [Bug 18392] Allow exporting circulation conditions as
     CSV or spreadsheet
    In-Reply-To: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18392-70-QAEJmiCMw8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30589
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30589
    [Bug 30589] Allow importing circulation conditions as CSV or spreadsheet
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 21:03:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 19:03:44 +0000
    Subject: [Koha-bugs] [Bug 13412] Allow configuration of auto-created
     authorities
    In-Reply-To: <bug-13412-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-13412-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-13412-70-IVIKYesm2R@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13412
    
    Shi Yao Wang <shi-yao.wang at inLibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |shi-yao.wang at inLibro.com
                 Status|Failed QA                   |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 21:04:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 19:04:22 +0000
    Subject: [Koha-bugs] [Bug 18392] Allow exporting circulation conditions as
     CSV or spreadsheet
    In-Reply-To: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18392-70-aPjzMx7r41@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |release-notes-needed
    
    --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    I have filed a new bug 30589 to cover importing as I think this would make
    editing much more fun :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 21:11:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 19:11:02 +0000
    Subject: [Koha-bugs] [Bug 18493] Add more languages to advanced search
     languages dropdown
    In-Reply-To: <bug-18493-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18493-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18493-70-KJ1u3cxWLR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18493
    
    --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    I think sorting/display could be improved by using the "translated name" of the
    language for sorting.
    
    A reason why we don't use authorised values is translatability, especially if
    you offer the OPAC in multiple languages. I know that Bernardo once tried to
    move them out of the database and make them translatable in Pootle: bug 12017
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 21:18:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 19:18:26 +0000
    Subject: [Koha-bugs] [Bug 25977] Koha Offline Circulation tool to handle
     trigger for sending necessary notices after successful .koc upload and
     processing
    In-Reply-To: <bug-25977-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25977-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25977-70-tiUhL56pon@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25977
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |RESOLVED
             Resolution|---                         |DUPLICATE
    
    --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    
    
    *** This bug has been marked as a duplicate of bug 21494 ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 21:18:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 19:18:26 +0000
    Subject: [Koha-bugs] [Bug 21494] No checkin notice created for offline
     circulation checkins
    In-Reply-To: <bug-21494-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21494-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21494-70-VCQItbf3pg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21494
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |tgoatley at gmail.com
    
    --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    *** Bug 25977 has been marked as a duplicate of this bug. ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 21:44:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 19:44:03 +0000
    Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available
     items even if on shelf holds aren't allowed
    In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30556-70-DBoofJrL3F@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556
    
    The Minh Luong <the-minh.luong at inlibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |the-minh.luong at inlibro.com
     Attachment #133497|1                           |0
               is patch|                            |
     Attachment #133497|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 22:08:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 20:08:30 +0000
    Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
    In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23838-70-MzrYneVWM7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
    
    --- Comment #57 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    (In reply to Andrew Fuerste-Henry from comment #56)
    > I applied this and 30275 and tried to run through the test plan here. I'm
    > not getting a View button next to the renewal count in patron Circulation
    > History even when the Renewal Log is enabled and there are renewals in the
    > action_logs for the checkout. Is there something else I should be doing to
    > get it to show?
    
    Setting to FQA to get attention on this.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 22:26:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 20:26:27 +0000
    Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available
     items even if on shelf holds aren't allowed
    In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30556-70-7Rr5kNTjWx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556
    
    --- Comment #2 from The Minh Luong <the-minh.luong at inlibro.com> ---
    Created attachment 133608
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133608&action=edit
    Bug 30556: Place hold button doesn't show when not allowed
    
    When On shelf holds holds allowed is on "If all unavailable", the Place hold
    button is not showed.
    
    To test:
    
    1. Create a circulation rule with on shelf holds set to "If all unavailable"
    2. Create or modify a record to match the items itype to the circulation rule
    3. Use a patron matching the circ rule category to log into the opac
    4. Look for the record
    5. Notice that the Place hold button is there, even thought it's not allowed
    6. Apply the patch.
    7. The button is not there.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 22:28:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 20:28:20 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-Np572Zs9eK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Severity|enhancement                 |new feature
    
    --- Comment #161 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    I feel like we should highlight this as a 'new feature' in release notes :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 23:11:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 21:11:01 +0000
    Subject: [Koha-bugs] [Bug 28138] Add system preference to make the payment
     type required
    In-Reply-To: <bug-28138-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28138-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28138-70-DjyIAdwevz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28138
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 23:11:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 21:11:10 +0000
    Subject: [Koha-bugs] [Bug 28138] Add system preference to make the payment
     type required
    In-Reply-To: <bug-28138-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28138-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28138-70-O1DYDpBUfX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28138
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131530|0                           |1
            is obsolete|                            |
    
    --- Comment #11 from Lucas Gass <lucas at bywatersolutions.com> ---
    Created attachment 133609
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133609&action=edit
    Bug 28138: Add syspref to make the payment type required
    
    The payment type is already required when using the cash register
    feature, but some users want to force selecting a payment type even
    when cash registers are not used
    
    The new system preference name is RequirePaymentType
    
    Test plan:
    1. Apply patch and run updatedatabase.pl
    2. Disable UseCashRegisters and RequirePaymentType sysprefs
    3. Create some authorised values in PAYMENT_TYPE category if needed
    4. Create a manual invoice and pay it. Notice that the payment type is
       optional.
    5. Enable RequirePaymentType
    6. Create a manual invoice and pay it. Notice that the payment type is
       now required.
    7. Enable UseCashRegisters and verify that the payment type is always
       required, even if RequirePaymentType is disabled
    
    Rebased by Thibaud Guillot <thibaud.guillot at biblibre.com> on 21-12-02
    
    Signed-off-by: shiyao <shiyao at inlibro.com>
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 23:11:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 21:11:15 +0000
    Subject: [Koha-bugs] [Bug 28138] Add system preference to make the payment
     type required
    In-Reply-To: <bug-28138-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28138-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28138-70-AOow5sHQcG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28138
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131643|0                           |1
            is obsolete|                            |
    
    --- Comment #12 from Lucas Gass <lucas at bywatersolutions.com> ---
    Created attachment 133610
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133610&action=edit
    Bug 28138: (follow-up) New atomic update
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 23:11:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 21:11:20 +0000
    Subject: [Koha-bugs] [Bug 28138] Add system preference to make the payment
     type required
    In-Reply-To: <bug-28138-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28138-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28138-70-IAeL4JmPr9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28138
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133606|0                           |1
            is obsolete|                            |
    
    --- Comment #13 from Lucas Gass <lucas at bywatersolutions.com> ---
    Created attachment 133611
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133611&action=edit
    Bug 28138: (follow-up) Add empty option to payment type selection
    
    This patch adds an empty <option> to the "Payment type" selection when
    paying fine. This forces the user to actively make a selection. I've
    also added the text "None selected" to the other empty <option> on the
    page for consistency.
    
    To test, apply the patch and test the pay fine interface with and
    without the RequirePaymentType preference enabled. When enabled the
    payment type should be required and it should default to "None
    selected."
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 23:20:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 21:20:25 +0000
    Subject: [Koha-bugs] [Bug 30508] Do not display OPAC message about block
     from holds when OPACHoldRequests is disabled
    In-Reply-To: <bug-30508-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30508-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30508-70-ZAAWLD2Mxh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lucas at bywatersolutions.com
    
    --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
    Shouldn't we just hide the "Holds are blocked because your fine balance is over
    the limit" part of the message?
    
    Seems like it would still be useful to show the "Please note: Your account has
    outstanding fees & charges of X.XX" part of the message, regardless of
    OPACHoldRequests.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 23:26:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 21:26:47 +0000
    Subject: [Koha-bugs] [Bug 30288] Provide links to OPACUserJS and OPACUserCSS
     in tools
    In-Reply-To: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30288-70-gmh6OU6zis@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 23:26:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 21:26:52 +0000
    Subject: [Koha-bugs] [Bug 30288] Provide links to OPACUserJS and OPACUserCSS
     in tools
    In-Reply-To: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30288-70-LfX23FoLC6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288
    
    --- Comment #11 from Lucas Gass <lucas at bywatersolutions.com> ---
    Created attachment 133612
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133612&action=edit
    Bug 28786: Don't set auth_method to NULL in ->anonymize
    
    DBI Exception: DBD::mysql::st execute failed: Column 'auth_method' cannot be
    null
    
    caught by t/db_dependent/Koha/Patrons.t
    
    Signed-off-by: Mason James <mtj at kohaaloha.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 23:26:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 21:26:56 +0000
    Subject: [Koha-bugs] [Bug 30288] Provide links to OPACUserJS and OPACUserCSS
     in tools
    In-Reply-To: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30288-70-bPdeANZ8C8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133510|0                           |1
            is obsolete|                            |
    
    --- Comment #12 from Lucas Gass <lucas at bywatersolutions.com> ---
    Created attachment 133613
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133613&action=edit
    Bug 30288: (follow-up) Use CSS for separator pipes
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 23:31:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 21:31:16 +0000
    Subject: [Koha-bugs] [Bug 30288] Provide links to OPACUserJS and OPACUserCSS
     in tools
    In-Reply-To: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30288-70-Gn9l9sGwcb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133612|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 23:36:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 21:36:25 +0000
    Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck
     modules for Koha
    In-Reply-To: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30444-70-yFiSmZ2SUb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444
    
    Alex Buckley <alexbuckley at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |ASSIGNED
    
    --- Comment #5 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
    Still doing some testing of this patchset locally.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 23:46:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 21:46:50 +0000
    Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck
     modules for Koha
    In-Reply-To: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30444-70-3b0HsyfNqR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444
    
    Alex Buckley <alexbuckley at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133518|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 21 23:47:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 21:47:15 +0000
    Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck
     modules for Koha
    In-Reply-To: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30444-70-KR2XwG4ACu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444
    
    --- Comment #6 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
    Created attachment 133614
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133614&action=edit
    Bug 30444: Add shibboleth login to self checkout
    
    This patch adds a 'Shibboleth' option to the SelfCheckoutByLogin system
    preference. When 'Shibboleth' is selected the user should be logged
    straight into the self check module - assuming the AutoSelfCheckAllowed,
    AutoSelfCheckID and AutoSelfCheckPass system preferences are set.
    
    Test plan:
    
    1. Have your Koha setup to do Shibboleth login
    2. Set the following system preferences:
    - AutoSelfCheckAllowed => 'Allow'
    - AutoSelfCheckId and AutoSelfCheckPass => Set these to a patron with
    'circulate' permissions
    - WebBasedSelfCheck -> 'Enable'
    - OpacShibOnly -> "Don't allow"
    3. Visit the self checkout page /cgi-bin/koha/sco/sco-main.pl and notice
    a local login page loads
    4. Apply patchset, update database and restart services
    5. Set the new syspref:
    - SelfCheckoutByLogin -> 'Shibboleth'
    6. Visit the self checkout page and notice you're logged into the sco
    interface straight away, without the local login page loading
    
    Sponsored-by: Catalyst IT
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 00:40:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 22:40:43 +0000
    Subject: [Koha-bugs] [Bug 30515] Move Overdue transports to patron messaging
     preferences
    In-Reply-To: <bug-30515-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30515-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30515-70-1CYydt3MOn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515
    
    --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    I'd like an option to not have the overdue notices appear at all or only as
    read only.
    
    I think a single preference for all overdues notice levels would not work
    without regressions. At the moment you can set the transport preferences in
    staff individually for each notice and can even opt to have multiple transports
    for each (send by email AND print).
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 00:43:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 22:43:17 +0000
    Subject: [Koha-bugs] [Bug 30534] borrowers.guarantorid not present on
     database
    In-Reply-To: <bug-30534-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30534-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30534-70-ZzJt4nV2bV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30534
    
    --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    The bug description makes it sound a bit like the column should be in the
    database, but I think this is about removing some left-over code, right?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 00:51:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 22:51:45 +0000
    Subject: [Koha-bugs] [Bug 29898] Overdues.pm line 663,
     Use of uninitialized value in string eq
    In-Reply-To: <bug-29898-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29898-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29898-70-PTdbInKaIg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29898
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Version|20.11                       |master
    
    --- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pb still exists in actual master 21.12
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 00:52:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 22:52:47 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-RsTYzerR3V@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Medium patch
                    URL|https://gitlab.com/joubu/Ko |https://gitlab.com/bgkriege
                       |ha/-/commits/bug_30373      |l/Koha/-/commits/bz30373
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 00:58:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 22:58:50 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-GAHCxIhZjw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
      Text to go in the|This enhancement adds an    |This new feature adds an
          release notes|initial optional            |initial optional
                       |implementation of           |implementation of
                       |two-factor authentication   |two-factor authentication
                       |(2FA) to improve security   |(2FA) to improve security
                       |when logging into the staff |when logging into the staff
                       |interface.
                     |interface.
                       |
                               |
                       |This                        |This
                       |implementation uses         |implementation uses
                       |time-based, one-time        |time-based, one-time
                       |passwords (TOTP) as the     |passwords (TOTP) as the
                       |second factor, letting      |second factor, letting
                       |librarians use an           |librarians use an
                       |application to handle it    |application to handle it
                       |and provide them the code   |and provide them the code
                       |they need when logging in.
     |they need when logging in.
                       |                            |
                       |It is enabled using the new |It is enabled using the new
                       |system preference           |system preference
                       |"TwoFactorAuthentication".  |"TwoFactorAuthentication".
                       |
                               |
                       |Librarians can then enable  |Librarians can then enable
                       |2FA for their account from  |2FA for their account from
                       |More > Manage Two-Factor    |More > Manage Two-Factor
                       |authentication. To setup:   |authentication. To setup:
                       |1) Scan the QR code with an |1) Scan the QR code with an
                       |authenticator app. 2) Enter |authenticator app. 2) Enter
                       |the one time code           |the one time code
                       |generated. For future       |generated. For future
                       |logins, librarians are      |logins, librarians are
                       |prompted to enter the       |prompted to enter the
                       |authenticator code after    |authenticator code after
                       |entering their normal login |entering their normal login
                       |credentials.
                   |credentials.
                       |
                               |
                       |Any                         |Any
                       |authenticator app, such as  |authenticator app, such as
                       |Google Authenticator,       |Google Authenticator,
                       |andOTP, and many others can |andOTP, and many others can
                       |be used. Applications that  |be used. Applications that
                       |enable backup of their 2FA  |enable backup of their 2FA
                       |accounts (either            |accounts (either
                       |cloud-based or automatic)   |cloud-based or automatic)
                       |are recommended.            |are recommended.
    
    --- Comment #162 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    (In reply to Katrin Fischer from comment #161)
    > I feel like we should highlight this as a 'new feature' in release notes :)
    
    Indeed. I changed the start of release notes.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 01:00:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 23:00:47 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-7Ua7hTr35u@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    --- Comment #163 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master :
      Bug 28786: Fix Patrons/Import.t
    
    Can we remove 'additional_work_needed' ?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 01:28:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 23:28:05 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-Fu7V8Wy2kj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Patch doesn't apply         |Passed QA
    
    --- Comment #41 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Super, it works now.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 01:30:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 23:30:47 +0000
    Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck
     modules for Koha
    In-Reply-To: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30444-70-YeB4I6OrRi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444
    
    Alex Buckley <alexbuckley at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133614|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 01:31:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 23:31:14 +0000
    Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck
     modules for Koha
    In-Reply-To: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30444-70-oH2COLsjsl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444
    
    --- Comment #7 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
    Created attachment 133615
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133615&action=edit
    Bug 30444: Add shibboleth login to self checkout
    
    This patch adds a 'Shibboleth' option to the SelfCheckoutByLogin system
    preference. When 'Shibboleth' is selected the user should be logged
    straight into the self check module - assuming the AutoSelfCheckAllowed,
    AutoSelfCheckID and AutoSelfCheckPass system preferences are set.
    
    Test plan:
    
    1. Have your Koha setup to do Shibboleth login
    2. Set the following system preferences:
    - AutoSelfCheckAllowed => 'Allow'
    - AutoSelfCheckId and AutoSelfCheckPass => Set these to a patron with
    'circulate' permissions
    - WebBasedSelfCheck -> 'Enable'
    - OpacShibOnly -> "Don't allow"
    3. Visit the self checkout page /cgi-bin/koha/sco/sco-main.pl and notice
    a local login page loads
    4. Apply patchset, update database and restart services
    5. Set the new syspref:
    - SelfCheckoutByLogin -> 'Shibboleth'
    6. Visit the self checkout page and notice you're logged into the sco
    interface straight away, without the local login page loading
    
    Sponsored-by: Catalyst IT
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 01:42:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 23:42:06 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-Db6fEGIim2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 01:42:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 23:42:08 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-YkuHoOmzhM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #42 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 01:42:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 23:42:11 +0000
    Subject: [Koha-bugs] [Bug 30477] Add new UNIMARC installer translation files
    In-Reply-To: <bug-30477-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30477-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30477-70-VnzOlpZkQ6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30477
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 01:42:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 23:42:14 +0000
    Subject: [Koha-bugs] [Bug 30477] Add new UNIMARC installer translation files
    In-Reply-To: <bug-30477-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30477-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30477-70-f0n7gmuNX3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30477
    
    --- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 01:42:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 23:42:17 +0000
    Subject: [Koha-bugs] [Bug 30525] Items batch modification broken
    In-Reply-To: <bug-30525-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30525-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30525-70-BE3D9D4wvs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30525
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 01:42:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 23:42:19 +0000
    Subject: [Koha-bugs] [Bug 30525] Items batch modification broken
    In-Reply-To: <bug-30525-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30525-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30525-70-2xSifXYaL0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30525
    
    --- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 01:42:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 23:42:22 +0000
    Subject: [Koha-bugs] [Bug 30532] guided_reports.pl has a problem
    In-Reply-To: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30532-70-qfNwHDwViC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30532
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 01:42:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 23:42:25 +0000
    Subject: [Koha-bugs] [Bug 30532] guided_reports.pl has a problem
    In-Reply-To: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30532-70-ga30zTywZI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30532
    
    --- Comment #7 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 01:42:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 23:42:27 +0000
    Subject: [Koha-bugs] [Bug 30583] Hold system broken for translated template
    In-Reply-To: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30583-70-ybu6XduiA9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30583
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 01:42:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 23:42:30 +0000
    Subject: [Koha-bugs] [Bug 30583] Hold system broken for translated template
    In-Reply-To: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30583-70-f2Uka2ditU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30583
    
    --- Comment #6 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 01:51:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 23:51:00 +0000
    Subject: [Koha-bugs] [Bug 13412] Allow configuration of auto-created
     authorities
    In-Reply-To: <bug-13412-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-13412-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-13412-70-ZrqXtcfozF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13412
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 01:53:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 23:53:26 +0000
    Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing
     secret via HTTP GET
    In-Reply-To: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29873-70-AHwPxkMvoI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 01:54:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 23:54:37 +0000
    Subject: [Koha-bugs] [Bug 30577] Item specific holds location can be missed
     when placing title level holds
    In-Reply-To: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30577-70-ClFSB9jn4u@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 01:55:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 21 Apr 2022 23:55:52 +0000
    Subject: [Koha-bugs] [Bug 30224] Wrong important field shown in cataloguing
     validation
    In-Reply-To: <bug-30224-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30224-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30224-70-VAGbZb0Lfn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 02:59:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 00:59:31 +0000
    Subject: [Koha-bugs] [Bug 30590] New: Add option for using AutoSelfCheckID
     and AutoSelfCheckPass values to log into OPAC self check-in module
    Message-ID: <bug-30590-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30590
    
                Bug ID: 30590
               Summary: Add option for using AutoSelfCheckID and
                        AutoSelfCheckPass values to log into OPAC self
                        check-in module
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Circulation
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: alexbuckley at catalyst.net.nz
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
    
    It would be useful if all patrons, regardless of whether they have the
    self_checkin_module sub-permission enabled, could check items in using the OPAC
    self check-in module.
    
    This could be achieved by adding a syspref allowing libraries to choose if the
    Koha patron defined in the AutoSelfCheckID and AutoSelfCheckPassw sysprefs can
    log into the self check-in module. 
    We want this so that it can be an option to add behaviour that mirrors the self
    check-out.
    
    Currently, the patron in the AutoSelfCheckID and AutoSelfCheckPass sysprefs can
    only be used to log into the self check-out module.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 02:59:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 00:59:46 +0000
    Subject: [Koha-bugs] [Bug 30590] Add option for using AutoSelfCheckID and
     AutoSelfCheckPass values to log into OPAC self check-in module
    In-Reply-To: <bug-30590-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30590-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30590-70-1ntB9QDDzV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30590
    
    Alex Buckley <alexbuckley at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |ASSIGNED
      Change sponsored?|---                         |Sponsored
               Assignee|koha-bugs at lists.koha-commun |alexbuckley at catalyst.net.nz
                       |ity.org                     |
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 05:43:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 03:43:16 +0000
    Subject: [Koha-bugs] [Bug 29077] Warns when searching blank index
    In-Reply-To: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29077-70-AM0dHD26vg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29077
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |victor at tuxayo.net
       Patch complexity|---                         |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 05:43:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 03:43:33 +0000
    Subject: [Koha-bugs] [Bug 29077] Warns when searching blank index
    In-Reply-To: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29077-70-mcbmOAtTU3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29077
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|victor at tuxayo.net           |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 05:44:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 03:44:24 +0000
    Subject: [Koha-bugs] [Bug 28512] spinelabel-print.tt should include the
     logged in branchcode
    In-Reply-To: <bug-28512-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28512-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28512-70-IFAhregLtO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 05:45:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 03:45:05 +0000
    Subject: [Koha-bugs] [Bug 29537] Simplify auto-renewal code in
     CanBookBeRenewed
    In-Reply-To: <bug-29537-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29537-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29537-70-DIvBRiervR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 06:21:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 04:21:43 +0000
    Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck
     modules for Koha
    In-Reply-To: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30444-70-zm3TBMpxKN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444
    
    --- Comment #8 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
    Created attachment 133616
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133616&action=edit
    Bug 30444: (follow-up) WIP:
    
    Don't re-direct infinite loop if SelfCheckoutByLogin not equal to 'shibboleth'
    
    Test plan:
    1. On a Koha setup to do Shibboleth set the following sysprefs:
    - OPACShibOnly = "Don't allow"
    - AutoSelfCheckAllowed = Allow
    - AutoSelfCheckID and AutoSelfCheckPass = The username and password of a
    patron with 'self_checkout_module' sub-permission enabled
    - SelfCheckoutByLogin = 'cardnumber'
    2. Visit the self checkout page, confirm it does not indefinitely loop
    3. Change SelfCheckoutbyLogin = 'username and password'
    4. Repeat step 2 and confirm the same results
    5. Change SelfCheckoutByLogin = 'shibboleth'
    6. Repeat step 2 and confirm the same results
    
    Sponsored-by: Catalyst IT
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 06:48:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 04:48:23 +0000
    Subject: [Koha-bugs] [Bug 30591] New: Cannot add patron
    Message-ID: <bug-30591-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30591
    
                Bug ID: 30591
               Summary: Cannot add patron
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Patrons
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: manojshahu07 at gmail.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
    
    Created attachment 133617
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133617&action=edit
    not allowed to create new patron
    
    Even though we are created 11 patron categories. 
    Getting below error While adding a new patron
    
    
    There are no patron categories defined. An administrator must define at least
    one patron category.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 08:04:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 06:04:59 +0000
    Subject: [Koha-bugs] [Bug 30592] New: Move borrowers.secret to a new generic
     credentials table
    Message-ID: <bug-30592-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30592
    
                Bug ID: 30592
               Summary: Move borrowers.secret to a new generic credentials
                        table
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Architecture, internals, and plumbing
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: m.de.rooy at rijksmuseum.nl
            QA Contact: testopia at bugs.koha-community.org
    
    This generic credentials table should allow for storing other secrets,
    passwords, etc. too.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 08:07:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 06:07:31 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-e4jsUX03Za@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    --- Comment #164 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Tomás Cohen Arazi from comment #160)
    > (In reply to David Cook from comment #25)
    > > Note having a credential table could also make it easier to add "temporary"
    > > passwords. 
    > > 
    > > For instance, it would be great if staff could reset a password, tell the
    > > patron the password, and then the patron would be forced to reset that
    > > password on first login. I'm going to raise a ticket for that and link it to
    > > here...
    > 
    > And that'd be yet another attribute for the credential (needs_reset?)...
    > which shouldn't belong to the patron object itself.
    
    Opened bug 30592 for you, Tomas. Feel free to take assignee ;)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 08:12:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 06:12:15 +0000
    Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing
     secret via HTTP GET
    In-Reply-To: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29873-70-s2AbKTQd31@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873
    
    --- Comment #25 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Jonathan Druart from comment #24)
    > (In reply to Martin Renvoize from comment #23)
    > > Must admit, I still wonder if we aught to have gone with Authen::OATH rather
    > > than Auth::GoogleAuth for 2FA.. but that's another question entirely.
    > 
    > Discussed extensively on bug 28786 already.
    > 
    > tldr; With this patch there is no bad reason to not switch (but do we have a
    > good reason to switch?).
    
    Lets not do that now anymore. Go ahead, Joubu. QA time!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 08:13:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 06:13:29 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-Yn1Tz4cfee@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    --- Comment #30 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Jonathan Druart from comment #29)
    > (In reply to Martin Renvoize from comment #28)
    > > My one caveat is something doesn't feel quite right about the introduction
    > > of 'send_confirm_notice' as a method in Koha::Auth::TwoFactorAuth, but I can
    > > see why you do it so it's testable.. I'll leave that query to QA
    > 
    > That's something I noticed as well, it feels misplaced.
    
    Yeah. This was kind of expected. Will try to find another home for him.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 08:13:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 06:13:41 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-KdhIeV8PWF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |BLOCKED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 08:23:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 06:23:17 +0000
    Subject: [Koha-bugs] [Bug 10734] Add Publication Date Facet in Searching
    In-Reply-To: <bug-10734-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-10734-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-10734-70-m7jkAAD7V1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10734
    
    pierre.genty at biblibre.com changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |pierre.genty at biblibre.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 08:31:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 06:31:37 +0000
    Subject: [Koha-bugs] [Bug 30592] Move borrowers.secret to a new generic
     credentials table
    In-Reply-To: <bug-30592-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30592-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30592-70-OgYY6n0tMJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30592
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
             Depends on|                            |29924
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    [Bug 29924] Introduce password expiration to patron categories
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 08:31:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 06:31:37 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-R5bmR0YHvf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30592
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30592
    [Bug 30592] Move borrowers.secret to a new generic credentials table
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 08:33:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 06:33:13 +0000
    Subject: [Koha-bugs] [Bug 30592] Move borrowers.secret to a new generic
     credentials table
    In-Reply-To: <bug-30592-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30592-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30592-70-bbWaYQTVE8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30592
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|29924                       |28998
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    [Bug 28998] Encrypt borrowers.secret
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    [Bug 29924] Introduce password expiration to patron categories
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 08:33:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 06:33:13 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-cR5pSSMYjX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30592
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30592
    [Bug 30592] Move borrowers.secret to a new generic credentials table
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 08:33:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 06:33:13 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-VGgGO4A0Un@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|30592                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30592
    [Bug 30592] Move borrowers.secret to a new generic credentials table
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 08:33:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 06:33:43 +0000
    Subject: [Koha-bugs] [Bug 30592] Move borrowers.secret to a new generic
     credentials table
    In-Reply-To: <bug-30592-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30592-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30592-70-wHKTgzcmj7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30592
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=29924
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 08:33:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 06:33:43 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-QwGFbpCnAm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30592
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 08:50:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 06:50:27 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-cdUY5s10j1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|BLOCKED                     |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 08:50:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 06:50:31 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-4Vnqxuoi53@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    --- Comment #31 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133618
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133618&action=edit
    Bug 29894: (QA follow-up) Get rid of send_confirm_notice
    
    Chose here to fall back to $patron->queue_notice. Which is tested
    already, so removing the additional test code.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 08:51:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 06:51:30 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-Ew1nlGZxb9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    --- Comment #32 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Martin Renvoize from comment #28)
    > All works well so signing off.. I added a follow-up to use what I feel are
    > clearer terms in the notices.
    > 
    > My one caveat is something doesn't feel quite right about the introduction
    > of 'send_confirm_notice' as a method in Koha::Auth::TwoFactorAuth, but I can
    > see why you do it so it's testable.. I'll leave that query to QA
    
    Thanks, Martin. Addressed the misplaced method now. Joubu, go ahead!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 08:51:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 06:51:55 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-zBA9APiAma@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |jonathan.druart+koha at gmail.
                       |y.org                       |com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 09:11:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 07:11:34 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-c25njVnwCl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |BLOCKED
    
    --- Comment #40 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Looking here
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 09:14:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 07:14:21 +0000
    Subject: [Koha-bugs] [Bug 30593] New: Should we switch from Modular Crypt
     Format to PHC string format
    Message-ID: <bug-30593-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30593
    
                Bug ID: 30593
               Summary: Should we switch from Modular Crypt Format to PHC
                        string format
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Architecture, internals, and plumbing
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: martin.renvoize at ptfs-europe.com
            QA Contact: testopia at bugs.koha-community.org
    
    When we switched from MD5 to Bcrypt we updated our storage to use Modular Crypt
    Format.. a new scheme now exists with minor improvements called PHC String
    Format.
    
    Switching to PHC should allow us to support newer crypt cyphers easily,
    including argon2
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 09:14:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 07:14:52 +0000
    Subject: [Koha-bugs] [Bug 30593] Should we switch from Modular Crypt Format
     to PHC string format
    In-Reply-To: <bug-30593-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30593-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30593-70-BQ2FQZQWz7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30593
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |chris at bigballofwax.co.nz,
                       |                            |jake.deery at ptfs-europe.com,
                       |                            |tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 09:15:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 07:15:26 +0000
    Subject: [Koha-bugs] [Bug 30593] Should we switch from Modular Crypt Format
     to PHC string format
    In-Reply-To: <bug-30593-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30593-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30593-70-co0OvmdQVg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30593
    
    --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    For the uninitiated, this isn't a bad writeup of the comparison:
    https://passlib.readthedocs.io/en/stable/modular_crypt_format.html#:~:text=In%20short%2C%20the%20modular%20crypt,only%20the%20characters%20in%20the
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 09:15:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 07:15:59 +0000
    Subject: [Koha-bugs] [Bug 30593] Should we switch from Modular Crypt Format
     to PHC string format
    In-Reply-To: <bug-30593-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30593-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30593-70-W7Jh6EIruk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30593
    
    --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    For the uninitiated this isn't a bad writeup:
    https://passlib.readthedocs.io/en/stable/modular_crypt_format.html
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 09:36:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 07:36:26 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-Po39jrhaom@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133580|0                           |1
            is obsolete|                            |
    
    --- Comment #41 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133619
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133619&action=edit
    Bug 28998: Introduce Koha::Encryption
    
    Test plan:
    Run t/db_dependent/Koha/Encryption.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    [AMENDED] Added copyright line to module.
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 09:36:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 07:36:31 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-r9V1gM2mkX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133581|0                           |1
            is obsolete|                            |
    
    --- Comment #42 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133620
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133620&action=edit
    Bug 28998: (follow-up) Add Patron->encode_secret and ->decoded_secret
    
    Test plan:
    Run t/db_dependent/Koha/Patron.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 09:36:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 07:36:36 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-ukGxGPKO5S@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133582|0                           |1
            is obsolete|                            |
    
    --- Comment #43 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133621
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133621&action=edit
    Bug 28998: (follow-up) Apply changes to TwoFactorAuth module and script
    
    Test plan:
    Run t/db_dependent/Koha/Auth/TwoFactorAuth.t
    Walk thru cycle register - logout/login - deregister - logout/login.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 09:36:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 07:36:41 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-NecvbuiGEQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133583|0                           |1
            is obsolete|                            |
    
    --- Comment #44 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133622
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133622&action=edit
    Bug 28998: Adjust Selenium test
    
    Test plan:
    Run t/db_dependent/selenium/authentication_2fa.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 09:36:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 07:36:47 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-isezCWABPv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133584|0                           |1
            is obsolete|                            |
    
    --- Comment #45 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133623
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133623&action=edit
    Bug 28998: [TO_BE_SQUASHED] Adjust secret in Selenium test
    
    This patch can be squashed with the previous one, if all is ok.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 09:36:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 07:36:51 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-cGU0c1fUhR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133585|0                           |1
            is obsolete|                            |
    
    --- Comment #46 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133624
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133624&action=edit
    Bug 28998: Add encryption_key to the config file
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 09:36:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 07:36:58 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-j0hQWTcKpJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133586|0                           |1
            is obsolete|                            |
    
    --- Comment #47 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133625
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133625&action=edit
    Bug 28998: Add Crypt::CBC dependency
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 09:37:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 07:37:04 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-cSrwg34duZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133588|0                           |1
            is obsolete|                            |
    
    --- Comment #48 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133626
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133626&action=edit
    Bug 28998: (QA follow-up) POD Fix
    
    This POD fix keeps the QA script happy
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 09:37:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 07:37:10 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-6tNgEjERLe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    --- Comment #49 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133627
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133627&action=edit
    Bug 28998: (follow-up) Add warning on about for missing key
    
    Test plan:
    Make sure that you have no encryption_key in koha-conf.
    Check about page, system information tab.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 09:50:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 07:50:47 +0000
    Subject: [Koha-bugs] [Bug 18493] Add more languages to advanced search
     languages dropdown
    In-Reply-To: <bug-18493-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18493-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18493-70-0wqPOSjhhq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18493
    
    --- Comment #9 from Séverine Queune <severine.queune at bulac.fr> ---
    (In reply to Katrin Fischer from comment #8)
    > A reason why we don't use authorised values is translatability, especially
    > if you offer the OPAC in multiple languages.
    
    Oh ! You're totally right, I completely missed this point !
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 09:51:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 07:51:30 +0000
    Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
     too
    In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28269-70-j4Pq0ChXlo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |ASSIGNED
                     CC|                            |slavashishkin at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 09:51:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 07:51:48 +0000
    Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
     too
    In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28269-70-cc6KvdUsWv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |slavashishkin at gmail.com
                       |ity.org                     |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 09:55:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 07:55:38 +0000
    Subject: [Koha-bugs] [Bug 10734] Add Publication Date Facet in Searching
    In-Reply-To: <bug-10734-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-10734-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-10734-70-ih0xaZ4iga@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10734
    
    --- Comment #9 from Séverine Queune <severine.queune at bulac.fr> ---
    (In reply to Fridolin Somers from comment #8)
    > We should add this facet at least for Elasticsearch where it can be
    > configured and disabled via staff interface.
    
    +1 !
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 10:07:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 08:07:26 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-msK8xg1cqv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    --- Comment #50 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133628
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133628&action=edit
    Bug 28998: Check missing encryption key in script and module
    
    Script prints a warning.
    Module raises an exception.
    Unit test added.
    
    Test plan:
    Run unit test.
    Remove entry and check script.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 10:08:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 08:08:14 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-IPzPRoxXQc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    --- Comment #51 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133629
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133629&action=edit
    Bug 28998: (follow-up) Check missing encryption key in script and module
    
    Script prints a warning.
    Module raises an exception.
    Unit test added.
    
    Test plan:
    Run unit test.
    Remove entry and check script.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 10:08:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 08:08:41 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-q5sahPwvdg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133628|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 10:10:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 08:10:23 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-U85B0VWwLg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                       |y.org                       |.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 10:10:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 08:10:47 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-wPDbX966RH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|BLOCKED                     |Signed Off
    
    --- Comment #52 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Added two follow-ups to address your concerns.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 10:11:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 08:11:30 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-ELCHdpi6VQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |rel_22_05_candidate
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 10:17:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 08:17:52 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-LRZOrmHmdE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #43 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    (In reply to Bernardo Gonzalez Kriegel from comment #34)
    > Created attachment 133127 [details] [review]
    > Bug 30373: Fix visibility, authorised values and descriptions
    > 
    > This patch fixes certain values of default bibliographic
    > framework.
    > 
    > It fixes hidden values using as reference default framework
    > from biblibre demo site.
    > 
    > Also adds some missing subfields, authorised values and
    > fixes capitalization on some descriptions.
    
    This patch is buggy, it uses authorised values that have not been inserted.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 10:22:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 08:22:19 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-31epQZo79a@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #44 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133630
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133630&action=edit
    Bug 30373: Fix unimarc authorised values
    
    1. Replace
      authorised_value: ""
    with
      authorised_value:
    to match what is done for marc21
    
    2. Fix some wrong category names
    -          authorised_value: 146a
    +          authorised_value: unimarc_146a
    
    -          authorised_value: 182a
    +          authorised_value: unimarc_182a
    
    -          authorised_value: 182c
    +          authorised_value: unimarc_182c
    
    3. Remove some category that have not been inserted (should we insert
    them then?)
    -          authorised_value: 183a
    +          authorised_value:
    
    -          authorised_value: qualif
    +          authorised_value:
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 10:22:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 08:22:44 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-Rp1o3RMKS0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |additional_work_needed
    
    --- Comment #45 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Bernardo, is this patch correct?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 10:25:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 08:25:08 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-4DRCTbGI42@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    --- Comment #53 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Martin Renvoize from comment #36)
    > I wonder slightly about the accessor names in Koha::Patron.. we could just
    > silently encrypt/descrypt and continue to rely on 'secret' as our accessor
    > name.. but that's not a big issue.  I also wonder if the field in general
    > should be clearer.. this secret us specific to this form of on time password
    > for 2FA.. calling is 'secret' is very generic.. but again.. that's from the
    > earlier bug.
    
    Actually, I did that at first and decided to go for another accessor name. This
    is more transparent.
    We could address that (if needed) when we move it out of borrowers.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 10:36:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 08:36:18 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-L88UkaAo0H@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133619|0                           |1
            is obsolete|                            |
    
    --- Comment #54 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133631
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133631&action=edit
    Bug 28998: Introduce Koha::Encryption
    
    Test plan:
    Run t/db_dependent/Koha/Encryption.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    [AMENDED] Added copyright line to module.
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 10:36:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 08:36:23 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-s2NAQvljFe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133620|0                           |1
            is obsolete|                            |
    
    --- Comment #55 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133632
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133632&action=edit
    Bug 28998: (follow-up) Add Patron->encode_secret and ->decoded_secret
    
    Test plan:
    Run t/db_dependent/Koha/Patron.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 10:36:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 08:36:28 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-qYa0oMnBx5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133621|0                           |1
            is obsolete|                            |
    
    --- Comment #56 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133633
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133633&action=edit
    Bug 28998: (follow-up) Apply changes to TwoFactorAuth module and script
    
    Test plan:
    Run t/db_dependent/Koha/Auth/TwoFactorAuth.t
    Walk thru cycle register - logout/login - deregister - logout/login.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 10:36:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 08:36:32 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-0S3e6EvE3p@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133622|0                           |1
            is obsolete|                            |
    
    --- Comment #57 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133634
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133634&action=edit
    Bug 28998: Adjust Selenium test
    
    Test plan:
    Run t/db_dependent/selenium/authentication_2fa.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 10:36:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 08:36:37 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-HFkwLOFjx6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133623|0                           |1
            is obsolete|                            |
    
    --- Comment #58 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133635
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133635&action=edit
    Bug 28998: [TO_BE_SQUASHED] Adjust secret in Selenium test
    
    This patch can be squashed with the previous one, if all is ok.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 10:36:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 08:36:42 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-IxxHdSeQ6Y@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133624|0                           |1
            is obsolete|                            |
    
    --- Comment #59 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133636
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133636&action=edit
    Bug 28998: Add encryption_key to the config file
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 10:36:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 08:36:47 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-gBOhjdg9Ma@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133625|0                           |1
            is obsolete|                            |
    
    --- Comment #60 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133637
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133637&action=edit
    Bug 28998: Add Crypt::CBC dependency
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 10:36:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 08:36:51 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-sKbKkvXJ6K@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133626|0                           |1
            is obsolete|                            |
    
    --- Comment #61 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133638
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133638&action=edit
    Bug 28998: (QA follow-up) POD Fix
    
    This POD fix keeps the QA script happy
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 10:36:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 08:36:57 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-JMlY7VeYDj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133627|0                           |1
            is obsolete|                            |
    
    --- Comment #62 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133639
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133639&action=edit
    Bug 28998: (follow-up) Add warning on about for missing key
    
    Test plan:
    Make sure that you have no encryption_key in koha-conf.
    Check about page, system information tab.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 10:37:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 08:37:02 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-9ziZk8y0CX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133629|0                           |1
            is obsolete|                            |
    
    --- Comment #63 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133640
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133640&action=edit
    Bug 28998: (follow-up) Check missing encryption key in script and module
    
    Script prints a warning.
    Module raises an exception.
    Unit test added.
    
    Test plan:
    Run unit test.
    Remove entry and check script.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 10:37:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 08:37:03 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-JeVuBtCc77@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133629|0                           |1
            is obsolete|                            |
    
    --- Comment #63 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133640
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133640&action=edit
    Bug 28998: (follow-up) Check missing encryption key in script and module
    
    Script prints a warning.
    Module raises an exception.
    Unit test added.
    
    Test plan:
    Run unit test.
    Remove entry and check script.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    --- Comment #64 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133641
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133641&action=edit
    Bug 28998: (follow-up) Check missing encryption key in script and module
    
    Script prints a warning.
    Module raises an exception.
    Unit test added.
    
    Test plan:
    Run t/db_dependent/Koha/Encryption.t
    Run t/db_dependent/Koha/Auth/TwoFactorAuth.t
    Remove entry and check script.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 10:41:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 08:41:09 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-f5aYtzTH6i@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133640|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 10:49:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 08:49:53 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-3JsBsjVIgx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133641|0                           |1
            is obsolete|                            |
    
    --- Comment #65 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133642
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133642&action=edit
    Bug 28998: (follow-up) Check missing encryption key in script and module
    
    Script prints a warning.
    Module raises an exception.
    Unit test added.
    
    Test plan:
    Run t/db_dependent/Koha/Encryption.t
    Run t/db_dependent/Koha/Auth/TwoFactorAuth.t
    Remove entry and check script.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 10:55:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 08:55:16 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-j9NTQcFcG3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    --- Comment #165 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133643
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133643&action=edit
    Bug 28786: Fix 2FA selenium tests
    
    Looks like there was a bad rebase at some point.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:11:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:11:29 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-jyMZRhzlWZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|martin.renvoize at ptfs-europe |jonathan.druart+koha at gmail.
                       |.com                        |com
                 Status|Passed QA                   |ASSIGNED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:21:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:21:43 +0000
    Subject: [Koha-bugs] [Bug 30594] New: Package Crypt::CBC 2.35 or higher to
     increase security
    Message-ID: <bug-30594-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30594
    
                Bug ID: 30594
               Summary: Package Crypt::CBC 2.35 or higher to increase security
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Packaging
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: martin.renvoize at ptfs-europe.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: mtj at kohaaloha.com
    
    Currently, Debian mostly comes with Crypt::CBC 2.33 pre-packaged.  If we
    package 2.35 or above we can benefit from a performance boost as well as having
    the ability to update our derivation function to using the recommended pbkdf2
    algorithm instead of the backwards compatible default of opensslv1.
    
    If we choose to package this, we should also update Koha::Encryption to reflect
    the change and use pbkdf2.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:21:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:21:54 +0000
    Subject: [Koha-bugs] [Bug 30594] Package Crypt::CBC 2.35 or higher to
     increase security
    In-Reply-To: <bug-30594-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30594-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30594-70-4CTgWIpOU5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30594
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |28998
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    [Bug 28998] Encrypt borrowers.secret
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:21:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:21:54 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-qsPChehW5v@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30594
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30594
    [Bug 30594] Package Crypt::CBC 2.35 or higher to increase security
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:23:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:23:55 +0000
    Subject: [Koha-bugs] [Bug 19886] Two Factor Authentication: Yubikey
    In-Reply-To: <bug-19886-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-19886-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-19886-70-hLwY7zmwPi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19886
    
    --- Comment #9 from Michal Denar <black23 at gmail.com> ---
    Hi,
    can we add this feature as extension of Bug 28786? HW USK key is "one touch" as
    opposed to TOTP, which requires writing code from apliaction from toter device,
    usualy smartphone?
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:25:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:25:04 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-WWCfYM9dy0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|jonathan.druart+koha at gmail. |martin.renvoize at ptfs-europe
                       |com                         |.com
    
    --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    t/db_dependent/selenium/patrons_search.t should pass after this patch. We are
    fixing a bug but introducing a regression. Double check the syspref's
    description.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:42:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:42:03 +0000
    Subject: [Koha-bugs] [Bug 30595] New: update_child_to_adult.t is failing
     randomly
    Message-ID: <bug-30595-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30595
    
                Bug ID: 30595
               Summary: update_child_to_adult.t is failing randomly
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: normal
              Priority: P5 - low
             Component: Test Suite
              Assignee: jonathan.druart+koha at gmail.com
              Reporter: jonathan.druart+koha at gmail.com
            QA Contact: testopia at bugs.koha-community.org
    
    t/db_dependent/selenium/update_child_to_adult.t ..         # Looks like you
    planned 3 tests but ran 2.
    
        #   Failed test 'Update child to adult'
        #   at t/db_dependent/selenium/update_child_to_adult.t line 132.
        # Looks like you planned 3 tests but ran 2.
        # Looks like you failed 1 test of 2 run.
    t/db_dependent/selenium/update_child_to_adult.t .. 1/1 
    #   Failed test 'Update child to patron'
    #   at t/db_dependent/selenium/update_child_to_adult.t line 153.
    Cannot wait more for element '//input[@type="submit"]' to be visible at
    /kohadevbox/koha/t/lib/Selenium.pm line 189.
    # Looks like your test exited with 255 just after 1.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:43:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:43:46 +0000
    Subject: [Koha-bugs] [Bug 30595] update_child_to_adult.t is failing randomly
    In-Reply-To: <bug-30595-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30595-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30595-70-x5mbdqr6sg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30595
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:43:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:43:50 +0000
    Subject: [Koha-bugs] [Bug 30595] update_child_to_adult.t is failing randomly
    In-Reply-To: <bug-30595-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30595-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30595-70-J39CeAkIBs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30595
    
    --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133644
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133644&action=edit
    Bug 30595: Prevent update_child_to_adult.t to fail randomly
    
    t/db_dependent/selenium/update_child_to_adult.t ..         # Looks like you
    planned 3 tests but ran 2.
    
        #   Failed test 'Update child to adult'
        #   at t/db_dependent/selenium/update_child_to_adult.t line 132.
        # Looks like you planned 3 tests but ran 2.
        # Looks like you failed 1 test of 2 run.
    t/db_dependent/selenium/update_child_to_adult.t .. 1/1
     #   Failed test 'Update child to patron'
     #   at t/db_dependent/selenium/update_child_to_adult.t line 153.
    Cannot wait more for element '//input[@type="submit"]' to be visible at
    /kohadevbox/koha/t/lib/Selenium.pm line 189.
    
    It happens when there are too many patron's categories and the submit
    button is not in the viewport.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:44:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:44:03 +0000
    Subject: [Koha-bugs] [Bug 30595] update_child_to_adult.t is failing randomly
    In-Reply-To: <bug-30595-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30595-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30595-70-UW0ZaDS1Uk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30595
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:44:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:44:09 +0000
    Subject: [Koha-bugs] [Bug 30595] update_child_to_adult.t is failing randomly
    In-Reply-To: <bug-30595-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30595-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30595-70-JSVYPirVom@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30595
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:48:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:48:58 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-9f1Iu56bPv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133631|0                           |1
            is obsolete|                            |
    
    --- Comment #66 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133645
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133645&action=edit
    Bug 28998: Introduce Koha::Encryption
    
    Test plan:
    Run t/db_dependent/Koha/Encryption.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    [AMENDED] Added copyright line to module.
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:49:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:49:03 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-FgLD4ykc0V@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133632|0                           |1
            is obsolete|                            |
    
    --- Comment #67 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133646
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133646&action=edit
    Bug 28998: (follow-up) Add Patron->encode_secret and ->decoded_secret
    
    Test plan:
    Run t/db_dependent/Koha/Patron.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:49:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:49:08 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-wgh3JesFAw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133633|0                           |1
            is obsolete|                            |
    
    --- Comment #68 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133647
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133647&action=edit
    Bug 28998: (follow-up) Apply changes to TwoFactorAuth module and script
    
    Test plan:
    Run t/db_dependent/Koha/Auth/TwoFactorAuth.t
    Walk thru cycle register - logout/login - deregister - logout/login.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:49:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:49:12 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-VixRJNRtbD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133634|0                           |1
            is obsolete|                            |
    
    --- Comment #69 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133648
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133648&action=edit
    Bug 28998: Adjust Selenium test
    
    Test plan:
    Run t/db_dependent/selenium/authentication_2fa.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:49:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:49:17 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-nDvBKHfkYF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133635|0                           |1
            is obsolete|                            |
    
    --- Comment #70 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133649
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133649&action=edit
    Bug 28998: [TO_BE_SQUASHED] Adjust secret in Selenium test
    
    This patch can be squashed with the previous one, if all is ok.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:49:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:49:23 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-RuH1EVvfoW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133636|0                           |1
            is obsolete|                            |
    
    --- Comment #71 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133650
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133650&action=edit
    Bug 28998: Add encryption_key to the config file
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:49:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:49:27 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-GUnZkS3l5B@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133637|0                           |1
            is obsolete|                            |
    
    --- Comment #72 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133651
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133651&action=edit
    Bug 28998: Add Crypt::CBC dependency
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:49:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:49:32 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-wFiAraaYDB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133638|0                           |1
            is obsolete|                            |
    
    --- Comment #73 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133652
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133652&action=edit
    Bug 28998: (QA follow-up) POD Fix
    
    This POD fix keeps the QA script happy
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:49:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:49:38 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-DZveYO47Qh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133639|0                           |1
            is obsolete|                            |
    
    --- Comment #74 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133653
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133653&action=edit
    Bug 28998: (follow-up) Add warning on about for missing key
    
    Test plan:
    Make sure that you have no encryption_key in koha-conf.
    Check about page, system information tab.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:49:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:49:43 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-OIZTphzzrs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133642|0                           |1
            is obsolete|                            |
    
    --- Comment #75 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133654
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133654&action=edit
    Bug 28998: (follow-up) Check missing encryption key in script and module
    
    Script prints a warning.
    Module raises an exception.
    Unit test added.
    
    Test plan:
    Run t/db_dependent/Koha/Encryption.t
    Run t/db_dependent/Koha/Auth/TwoFactorAuth.t
    Remove entry and check script.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:49:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:49:48 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-5BK3bVVjEt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    --- Comment #76 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133655
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133655&action=edit
    Bug 28998: (QA follow-up) Improve output on error
    
    This patch updates the output_and_exit call to instead pass an error
    parameter in the template and use it to display the warning instead of
    the rest of the page content in the 'Manage two-factor authentication'
    page.
    
    This allows for translation and makes the page adhere to normal
    practices.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:50:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:50:33 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-989PWqnPDh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    --- Comment #77 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Right, I'm happy with this all now.. PQA.. (except it'll be blocked until the
    dependency bugs are all PQA too)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:55:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:55:22 +0000
    Subject: [Koha-bugs] [Bug 30596] New: api/v1/acquisitions_baskets.t is
     failing randomly
    Message-ID: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596
    
                Bug ID: 30596
               Summary: api/v1/acquisitions_baskets.t is failing randomly
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: normal
              Priority: P5 - low
             Component: Test Suite
              Assignee: jonathan.druart+koha at gmail.com
              Reporter: jonathan.druart+koha at gmail.com
            QA Contact: testopia at bugs.koha-community.org
    
    Because of date comparison
    
    03:57:34 koha_1       |     #   Failed test 'exact match for JSON Pointer ""'
    03:57:34 koha_1       |     #   at t/db_dependent/api/v1/acquisitions_baskets.t
    line 59.
    03:57:34 koha_1       |     #     Structures begin differing at:
    03:57:34 koha_1       |     #          $got->[1]{updated_on} =
    '2022-04-22T01:54:35+00:00'
    03:57:34 koha_1       |     #     $expected->[1]{updated_on} =
    '2022-04-22T01:54:34+00:00'
    03:57:34 koha_1       |     # Looks like you failed 1 test of 3.
    03:57:34 koha_1       | 
    03:57:34 koha_1       | #   Failed test 'list_managers() tests'
    03:57:34 koha_1       | #   at t/db_dependent/api/v1/acquisitions_baskets.t
    line 63.
    03:57:34 koha_1       | # Looks like you failed 1 test of 1.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:55:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:55:31 +0000
    Subject: [Koha-bugs] [Bug 30596] api/v1/acquisitions_baskets.t is failing
     randomly
    In-Reply-To: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30596-70-zCXMi5ddtY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30055
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055
    [Bug 30055] Rewrite some of the patron searches to make them use the REST API
    routes
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:55:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:55:31 +0000
    Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make
     them use the REST API routes
    In-Reply-To: <bug-30055-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30055-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30055-70-JOvmqmOHG5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30596
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596
    [Bug 30596] api/v1/acquisitions_baskets.t is failing randomly
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:56:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:56:48 +0000
    Subject: [Koha-bugs] [Bug 30596] api/v1/acquisitions_baskets.t is failing
     randomly
    In-Reply-To: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30596-70-VKXrysthG4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596
    
    --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133656
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133656&action=edit
    Bug 30596: Prevent api/v1/acquisitions_baskets.t to fail randomly
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:57:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:57:06 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-1YpqsuDm65@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |BLOCKED
    
    --- Comment #78 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Selenium tests failing further down the tree so blocked until those have been
    fixed and PQA'd
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 11:58:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 09:58:19 +0000
    Subject: [Koha-bugs] [Bug 30596] api/v1/acquisitions_baskets.t is failing
     randomly
    In-Reply-To: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30596-70-YUOOKCKG7U@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m,
                       |                            |martin.renvoize at ptfs-europe
                       |                            |.com, tomascohen at gmail.com
                 Status|ASSIGNED                    |In Discussion
    
    --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    This is a bit ugly, and we will need to reuse it in (at least)
    api/v1/acquisitions_funds.t
    
    See 
    commit 9bbbed2a4024311cbbd9b828eba0512f63069735
    Bug 30055: API unit tests
    
    Tomas, did you deal with that already in other REST api tests?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 12:01:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 10:01:31 +0000
    Subject: [Koha-bugs] [Bug 30584] Cannot add field mappings to Elasticsearch
     configuration
    In-Reply-To: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30584-70-i0AbAh8yRY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 12:01:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 10:01:34 +0000
    Subject: [Koha-bugs] [Bug 30584] Cannot add field mappings to Elasticsearch
     configuration
    In-Reply-To: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30584-70-NjchHt2B3m@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133595|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from David Nind <david at davidnind.com> ---
    Created attachment 133657
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133657&action=edit
    Bug 30584: Fix ES mapping creation
    
    We need to tell DT that we are adding/removing row, not only deal
    manually with the DOM.
    
    This patch also fixes the following bug: if you add or remove a row from
    the "biblio" tab, then go to another tab and back to "biblio", all
    changes were gone (bug existed prior to bug 29893).
    
    Test plan:
    Add, edit and remove mappings, switch from tabs and save.
    Use the filters, save (29893 regression test)
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 12:03:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 10:03:02 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-5nGI20ue6F@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #46 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133658
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133658&action=edit
    Bug 30373: Fix xt/find-license-problems.t
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 12:19:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 10:19:27 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-9ewQ0soE1O@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #47 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
    (In reply to Jonathan Druart from comment #45)
    > Bernardo, is this patch correct?
    
    Unfortunately it has errors.
    
    I'll provide a patch asap. Most of the authorised values are inserted,
    correctly, at the beginning of the bib framework file, ej. 
            - category_name: "unimarc_146a"
            - category_name: "unimarc_181c"
            - category_name: "unimarc_182a"
            - category_name: "unimarc_182c"
            - category_name: "unimarc_325h"
    
    The values like '146a' are missing the 'unimarc_' part, 'qualif' already exist.
    
    I suppose a new bug should be used for this.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 12:25:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 10:25:51 +0000
    Subject: [Koha-bugs] [Bug 30591] Cannot add patron
    In-Reply-To: <bug-30591-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30591-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30591-70-jBx83DCkmL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30591
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |RESOLVED
             Resolution|---                         |INVALID
    
    --- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
    This sounds like a support request rather than a bug.
    
    Questions about Koha should be asked on the Koha mailing list
    (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC
    channel (http://koha-community.org/get-involved/irc/).
    
    Hopefully you've already seen the Koha documentation:
    http://koha-community.org/documentation/
    
    You can also find options for paid support here:
    https://koha-community.org/support/
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 12:28:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 10:28:45 +0000
    Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing
     secret via HTTP GET
    In-Reply-To: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29873-70-sgcIticxan@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 12:28:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 10:28:50 +0000
    Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing
     secret via HTTP GET
    In-Reply-To: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29873-70-kiCBYVCtqB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133558|0                           |1
            is obsolete|                            |
     Attachment #133559|0                           |1
            is obsolete|                            |
    
    --- Comment #26 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133659
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133659&action=edit
    Bug 29873: Create QR code
    
    Instead of using deprecated Google Charts API, and exposing our
    secret in a GET parameter, we generate QR data ourselves.
    
    Test plan:
    [1] Enable two factor authentication in the prefs.
    [2] Login in staff. Go to account. Select Manage 2FA.
    [3] Verify that QR code is displayed.
    [4] Register the QR in your authenticator app and test 2FA
        by logging in again.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Tested with Google Authenticator and FreeOTP.
    
    Bug 29873: (follow-up) Rename qr_dataurl
    
    As requested by a QA team member.
    We're moving to qr_code as method name. This is the same name as
    the method in the underlying base class.
    Apart from one sed statement, changing to self->SUPER on one line.
    
    Test plan:
    Can you still register, logout and login?
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Bug 29873: (follow-up) Switch to GD
    
    We do not need a new module, we could use GD instead.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 12:28:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 10:28:56 +0000
    Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing
     secret via HTTP GET
    In-Reply-To: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29873-70-BCTCyX5OxF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873
    
    --- Comment #27 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133660
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133660&action=edit
    Bug 29873: Add unit test
    
    Test plan:
    Run t/db_dependent/Koha/Auth/TwoFactorAuth.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Amended to reflect requested changes.
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 12:30:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 10:30:01 +0000
    Subject: [Koha-bugs] [Bug 30577] Item specific holds location can be missed
     when placing title level holds
    In-Reply-To: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30577-70-wgcB2czx28@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577
    
    Marie <marie.hedbom at musikverket.se> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |marie.hedbom at musikverket.se
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 12:30:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 10:30:09 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-1iXgr3vE6z@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 12:30:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 10:30:15 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-T4kmSIJYyW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133562|0                           |1
            is obsolete|                            |
     Attachment #133563|0                           |1
            is obsolete|                            |
     Attachment #133564|0                           |1
            is obsolete|                            |
     Attachment #133565|0                           |1
            is obsolete|                            |
     Attachment #133566|0                           |1
            is obsolete|                            |
     Attachment #133618|0                           |1
            is obsolete|                            |
    
    --- Comment #33 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133661
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133661&action=edit
    Bug 29894: Add some exceptions to TwoFactorAuth module
    
    Test updated accordingly.
    Adding utf8 flag to CGI in staff script.
    
    Test plan:
    Run t/db_dependent/Koha/Auth/TwoFactorAuth.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 12:30:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 10:30:21 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-FDsqspo90H@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    --- Comment #34 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133662
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133662&action=edit
    Bug 29894: Clear secret when disabling 2FA
    
    Test plan:
    Deregister 2FA for patron.
    Check if secret is empty in borrowers.secret.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 12:30:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 10:30:28 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-SjJGk14VmZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    --- Comment #35 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133663
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133663&action=edit
    Bug 29894: Db rev for adding notices
    
    This dbrev adds two notices:
    2FA_REGISTER and 2FA_DEREGISTER
    
    Test plan:
    Run the dbrev.
    Check if you see them on Tools/Notices.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 12:30:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 10:30:35 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-HKmdFv1Avb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    --- Comment #36 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133664
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133664&action=edit
    Bug 29894: Send a confirmation notice
    
    When registering or deregistering, send a confirmation.
    
    Test plan:
    Register or deregister with patron having email address.
    Verify that you got a confirmation mail.
    Run t/db_dependent/Koha/Auth/TwoFactorAuth.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 12:30:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 10:30:41 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-WS9gZlWqyZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    --- Comment #37 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133665
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133665&action=edit
    Bug 29894: (follow-up) Update notice terms
    
    Register and Derigister didn't sound right, in reality we we enabling
    and disabling 2FA for the user so I think those terms are more
    understandable.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 12:30:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 10:30:45 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-PCFRf8L7iK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    --- Comment #38 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133666
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133666&action=edit
    Bug 29894: (QA follow-up) Get rid of send_confirm_notice
    
    Chose here to fall back to $patron->queue_notice. Which is tested
    already, so removing the additional test code.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 12:30:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 10:30:50 +0000
    Subject: [Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret,
     send register notice
    In-Reply-To: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29894-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29894-70-9xqp9NfDYt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894
    
    --- Comment #39 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133667
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133667&action=edit
    Bug 29894: Add Selenium tests for disable 2FA
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 12:32:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 10:32:40 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-5koNrx7u0y@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #48 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    (In reply to Bernardo Gonzalez Kriegel from comment #47)
    > (In reply to Jonathan Druart from comment #45)
    > > Bernardo, is this patch correct?
    > 
    > Unfortunately it has errors.
    > 
    > I'll provide a patch asap. Most of the authorised values are inserted,
    > correctly, at the beginning of the bib framework file, ej. 
    >         - category_name: "unimarc_146a"
    >         - category_name: "unimarc_181c"
    >         - category_name: "unimarc_182a"
    >         - category_name: "unimarc_182c"
    >         - category_name: "unimarc_325h"
    > 
    > The values like '146a' are missing the 'unimarc_' part, 'qualif' already
    > exist.
    > 
    > I suppose a new bug should be used for this.
    
    Nope, please attach a follow-up here. Feel free to scratch mine! Thanks! :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 13:06:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 11:06:12 +0000
    Subject: [Koha-bugs] [Bug 30575] Returning an ILL item shouldn't just change
     the request status
    In-Reply-To: <bug-30575-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30575-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30575-70-AKp0jL0Kfa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30575
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |andrew.isherwood at ptfs-europ
                       |                            |e.com,
                       |                            |katrin.fischer at bsz-bw.de
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 13:09:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 11:09:20 +0000
    Subject: [Koha-bugs] [Bug 30596] api/v1/acquisitions_baskets.t is failing
     randomly
    In-Reply-To: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30596-70-q1NAGp5Wbp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596
    
    --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    (In reply to Jonathan Druart from comment #2)
    > This is a bit ugly, and we will need to reuse it in (at least)
    > api/v1/acquisitions_funds.t
    > 
    > See 
    > commit 9bbbed2a4024311cbbd9b828eba0512f63069735
    > Bug 30055: API unit tests
    > 
    > Tomas, did you deal with that already in other REST api tests?
    
    Maybe we need a new is_deeply, that accepts a list of things to exclude in the
    comparisson?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 13:10:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 11:10:32 +0000
    Subject: [Koha-bugs] [Bug 30596] api/v1/acquisitions_baskets.t is failing
     randomly
    In-Reply-To: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30596-70-2PmDiBTPrK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596
    
    --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
    (In reply to Jonathan Druart from comment #2)
    > This is a bit ugly, and we will need to reuse it in (at least)
    > api/v1/acquisitions_funds.t
    > 
    > See 
    > commit 9bbbed2a4024311cbbd9b828eba0512f63069735
    > Bug 30055: API unit tests
    > 
    > Tomas, did you deal with that already in other REST api tests?
    
    Why not:
    +    $superlibrarian->discard_changes;
    +    $patron_with_permission->discard_changes;
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 13:18:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 11:18:09 +0000
    Subject: [Koha-bugs] [Bug 29704] Holds reminder emails should allow
     configuration for a specific number of days
    In-Reply-To: <bug-29704-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29704-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29704-70-eK6eBMgDP6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|FIXED                       |---
             Depends on|28153                       |15986
                 Status|RESOLVED                    |REOPENED
    
    --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
    (In reply to Andrew Fuerste-Henry from comment #7)
    > Missing dependency, not backported to 21.05
    
    Does not rely on 28153 - only 15986 - please reconsider?
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
    [Bug 15986] Add a script for sending hold waiting reminder notices
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28153
    [Bug 28153] Add 'Hold reminder' messaging preference
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 13:18:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 11:18:09 +0000
    Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting
     reminder notices
    In-Reply-To: <bug-15986-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-15986-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-15986-70-q0khx5doZr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |29704
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704
    [Bug 29704] Holds reminder emails should allow configuration for a specific
    number of days
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 13:18:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 11:18:09 +0000
    Subject: [Koha-bugs] [Bug 28153] Add 'Hold reminder' messaging preference
    In-Reply-To: <bug-28153-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28153-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28153-70-jwRW9WHsWo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28153
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|29704                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704
    [Bug 29704] Holds reminder emails should allow configuration for a specific
    number of days
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 13:18:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 11:18:19 +0000
    Subject: [Koha-bugs] [Bug 29704] Holds reminder emails should allow
     configuration for a specific number of days
    In-Reply-To: <bug-29704-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29704-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29704-70-W0LuvpLtT5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|REOPENED                    |ASSIGNED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 13:18:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 11:18:29 +0000
    Subject: [Koha-bugs] [Bug 29704] Holds reminder emails should allow
     configuration for a specific number of days
    In-Reply-To: <bug-29704-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29704-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29704-70-e3xlN1Umlj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 13:18:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 11:18:41 +0000
    Subject: [Koha-bugs] [Bug 29704] Holds reminder emails should allow
     configuration for a specific number of days
    In-Reply-To: <bug-29704-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29704-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29704-70-fTQVxHpTlI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to stable
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 13:24:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 11:24:26 +0000
    Subject: [Koha-bugs] [Bug 30596] api/v1/acquisitions_baskets.t is failing
     randomly
    In-Reply-To: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30596-70-IAaqy312wE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596
    
    --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    (In reply to Nick Clemens from comment #4)
    > (In reply to Jonathan Druart from comment #2)
    > > This is a bit ugly, and we will need to reuse it in (at least)
    > > api/v1/acquisitions_funds.t
    > > 
    > > See 
    > > commit 9bbbed2a4024311cbbd9b828eba0512f63069735
    > > Bug 30055: API unit tests
    > > 
    > > Tomas, did you deal with that already in other REST api tests?
    > 
    > Why not:
    > +    $superlibrarian->discard_changes;
    > +    $patron_with_permission->discard_changes;
    
    +1
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 13:25:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 11:25:43 +0000
    Subject: [Koha-bugs] [Bug 30596] api/v1/acquisitions_baskets.t is failing
     randomly
    In-Reply-To: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30596-70-LPeWIrO54J@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133656|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133668
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133668&action=edit
    Bug 30596: Prevent api/v1/acquisitions_baskets.t to fail randomly
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 13:26:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 11:26:17 +0000
    Subject: [Koha-bugs] [Bug 30596] api/v1/acquisitions_baskets.t is failing
     randomly
    In-Reply-To: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30596-70-6TDxEaRGQy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596
    
    --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    (In reply to Nick Clemens from comment #4)
    > (In reply to Jonathan Druart from comment #2)
    > > This is a bit ugly, and we will need to reuse it in (at least)
    > > api/v1/acquisitions_funds.t
    > > 
    > > See 
    > > commit 9bbbed2a4024311cbbd9b828eba0512f63069735
    > > Bug 30055: API unit tests
    > > 
    > > Tomas, did you deal with that already in other REST api tests?
    > 
    > Why not:
    > +    $superlibrarian->discard_changes;
    > +    $patron_with_permission->discard_changes;
    
    Yes, I think I actually focused on the wrong thing. updated_on is modified
    because of the set_password call. Having an up-to-date object should fix the
    problem. Thanks, Nick!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 13:26:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 11:26:40 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-DpH1XIMfOk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #34 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    (In reply to David Nind from comment #33)
    > All tests pass except this one:
    > 
    > prove t/db_dependent/Circulation_holdsqueue.t
    
    Hi, David. Thanks for testing! Martin highlighted with this the fact that some
    calls (circulation) trigger item/biblio updates and thus duplicate actions.
    
    I have worked on chasing those cases and will wrap the code and new tests on
    monday.
    
    Have a great weekend!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 13:28:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 11:28:29 +0000
    Subject: [Koha-bugs] [Bug 30596] api/v1/acquisitions_baskets.t is failing
     randomly
    In-Reply-To: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30596-70-BIak2EIThm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|In Discussion               |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 13:28:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 11:28:33 +0000
    Subject: [Koha-bugs] [Bug 30596] api/v1/acquisitions_baskets.t is failing
     randomly
    In-Reply-To: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30596-70-ZBkhuOJqaw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133668|0                           |1
            is obsolete|                            |
    
    --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133669
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133669&action=edit
    Bug 30596: Prevent api/v1/acquisitions_baskets.t and
    api/v1/acquisitions_funds.t to fail randomly
    
    because of updated_on
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 13:41:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 11:41:11 +0000
    Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on
     fresh install, but can be null with upgrade
    In-Reply-To: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27253-70-vE9OL27wr9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253
    
    --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    FROM_UNIXTIME(0) does not seem to work
    
    MariaDB [koha_kohadev]> update borrowers set updated_on="1970-01-01 00:00:01"
    where borrowernumber=1;
    Query OK, 1 row affected (0.011 sec)
    Rows matched: 1  Changed: 1  Warnings: 0
    
    MariaDB [koha_kohadev]> update borrowers set updated_on="1970-01-01 00:00:00"
    where borrowernumber=1;
    Query OK, 1 row affected, 1 warning (0.012 sec)
    Rows matched: 1  Changed: 1  Warnings: 1
    
    MariaDB [koha_kohadev]> select updated_on from borrowers where
    borrowernumber=1;
    +---------------------+
    | updated_on          |
    +---------------------+
    | 0000-00-00 00:00:00 |
    +---------------------+
    1 row in set (0.001 sec)
    
    MariaDB [koha_kohadev]> show warnings;
    +---------+------+-----------------------------------------------------+
    | Level   | Code | Message                                             |
    +---------+------+-----------------------------------------------------+
    | Warning | 1264 | Out of range value for column 'updated_on' at row 1 |
    +---------+------+-----------------------------------------------------+
    1 row in set (0.000 sec)
    
    MariaDB [koha_kohadev]> update borrowers set updated_on="1970-01-01 00:00:01"
    where borrowernumber=1;
    Query OK, 1 row affected (0.011 sec)
    Rows matched: 1  Changed: 1  Warnings: 0
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 13:44:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 11:44:28 +0000
    Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on
     fresh install, but can be null with upgrade
    In-Reply-To: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27253-70-tXkcD5aeRb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253
    
    --- Comment #10 from Owen Leonard <oleonard at myacpl.org> ---
    I get this error:
    
    ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Incorrect datetime
    value: '1970-01-01 00:00:00' for column `koha_kohadev`.`borrowers`.`updated_on`
    at row 4739 at /kohadevbox/koha/C4/Installer.pm line 738
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 13:45:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 11:45:55 +0000
    Subject: [Koha-bugs] [Bug 30385] Standardize our swagger yaml spec files
    In-Reply-To: <bug-30385-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30385-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30385-70-tFOG1kLCRz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30385
    
    --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    I am failing at writing a script that will order the second (and more) level or
    keys. Help welcomed! :)
    Might be a Friday effect.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 13:57:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 11:57:42 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-7zqVQ10k9u@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |RESOLVED
             Resolution|---                         |DUPLICATE
    
    --- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
    
    
    *** This bug has been marked as a duplicate of bug 6473 ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 13:57:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 11:57:42 +0000
    Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz
    In-Reply-To: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-6473-70-KIMQQt0q83@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |slavashishkin at gmail.com
    
    --- Comment #258 from Owen Leonard <oleonard at myacpl.org> ---
    *** Bug 30558 has been marked as a duplicate of this bug. ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 14:08:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 12:08:21 +0000
    Subject: [Koha-bugs] [Bug 29092] Table Settings for account_fines table
     missing Updated On column and hide the wrong things
    In-Reply-To: <bug-29092-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29092-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29092-70-SsNNmcgIM3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29092
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
       Patch complexity|---                         |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 14:08:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 12:08:25 +0000
    Subject: [Koha-bugs] [Bug 29092] Table Settings for account_fines table
     missing Updated On column and hide the wrong things
    In-Reply-To: <bug-29092-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29092-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29092-70-Xc0tEzTDRV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29092
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133520|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133670
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133670&action=edit
    Bug 29092: Add timestamp to account-fines table column settings
    
    Table settings for the account_fines table (in the Patrons section, the
    "Transactions" table in a patron account) are missing a checkbox for the
    "Updated On" column. Because of this, one cannot hide the Updated On
    column and any other values one sets here get applied to the wrong
    columns.
    
    This patch adds timestamp to account-fines column settings.
    To test:
    
    1) Navigate to columns settings page and modify account-fines tables
       column.
       => Note that if you hide e.g. account_type column, column
       credit_number is hidden on patrons account page
    2) Apply patch and update database.
       => Account-fines column settings has now a option to hide timestamp.
       => Correct columns should now be hidden.
    
    Sponsored-by: Koha-Suomi Oy
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 14:09:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 12:09:00 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-8G8u05rs5I@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 14:09:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 12:09:08 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-UfeCDAdeXQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133378|0                           |1
            is obsolete|                            |
     Attachment #133379|0                           |1
            is obsolete|                            |
     Attachment #133380|0                           |1
            is obsolete|                            |
    
    --- Comment #22 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133671
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133671&action=edit
    Bug 29155: Upgrade jQuery and jQuery Migrate to latest versions
    
    jQuery is upgraded from 2.2.3 to 3.6.0.
    jQuery Migrate is upgraded from 1.3.0 to 3.3.2.
    
    The next patch will update links to point to the new assets.
    
    Signed-off-by: David Cook <dcook at prosentient.com.au>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 14:09:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 12:09:13 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-u7Xg6tXAGq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    
    --- Comment #23 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133672
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133672&action=edit
    Bug 29155: Update links to jQuery and jQuery Migrate files
    
    With these patches, jQuery versions in the OPAC and staff interface are
    both updated to 3.6.0. The latest version of jQuery Migrate is installed
    to allow us to take a slower approach to updating out-of-date syntax.
    
    To test, apply the patch and try as many pages as you can, paying
    attention to the browser console to watch for errors.
    
    Signed-off-by: David Cook <dcook at prosentient.com.au>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 14:09:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 12:09:18 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-BTy3wew25j@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    
    --- Comment #24 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133673
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133673&action=edit
    Bug 29155: (follow-up) Work around change to jQueryUI tab API
    
    For some reason, with the combination of jQuery 3.6.0 and jQueryUI
    1.13.1, the way to access the current active tab's link has changed.
    Previously the tab activate event would provide information about the
    link as "ui.newTab.context." It appears that "context" is no longer
    available.
    
    This patch updates the two instances in Koha where this process is
    broken.
    
    To test, apply the patch and check out to a patron with holds on their
    account.
    
    - When the checkout page loads, confirm that each tab loads its contents
      correctly when clicked.
    - Check that the correct tab is activated when you append the tab link
      to the page url, e.g.
    
      /cgi-bin/koha/circ/circulation.pl?borrowernumber=XXX#reldebarments
    
      ...which should select the "Restrictions" tab for you. You may need to
      try this in a new tab or shift-reload to get the browser to look for
      the hash.
    
    - Perform the same tests on the patron details page.
    
    Signed-off-by: David Cook <dcook at prosentient.com.au>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 14:10:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 12:10:09 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-KUeRDPvV0h@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    
    --- Comment #25 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    I haven't caught anything obvious, we should push this ASAP to let us a bit of
    time to find possible regressions before the release.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 14:10:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 12:10:29 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version to 3.6.0
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-3BouJkXY1M@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Upgrade jquery version      |Upgrade jquery version to
                       |                            |3.6.0
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 14:19:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 12:19:41 +0000
    Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
     $biblio->metadata->record
    In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29697-70-UDmccpr9jF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
    
    --- Comment #20 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Can we move this one forward please?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 14:33:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 12:33:09 +0000
    Subject: [Koha-bugs] [Bug 30122] Display note fields in authority result list
    In-Reply-To: <bug-30122-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30122-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30122-70-gzhrkl6LpX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30122
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |In Discussion
    
    --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    We are displaying the notes at the OPAC, on the detail page of the authority.
    
    I think I am identifying 2 different needs here, one is to display the notes on
    the result page, the other one is to make configurable the notes we display.
    
    If we add a syspref to list the subfields we want to display, should it drive
    the behaviour for the OPAC as well?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 14:33:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 12:33:35 +0000
    Subject: [Koha-bugs] [Bug 30326] Cronjob that checks biblios for MARC errors
    In-Reply-To: <bug-30326-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30326-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30326-70-6DSdXRx2lY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30326
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 14:33:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 12:33:38 +0000
    Subject: [Koha-bugs] [Bug 30326] Cronjob that checks biblios for MARC errors
    In-Reply-To: <bug-30326-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30326-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30326-70-xJbSGln1FJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30326
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133511|0                           |1
            is obsolete|                            |
    
    --- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133674
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133674&action=edit
    Bug 30326: (follow-up) Add output parameter and handle bad biblionumbers
    
    When the script is run without the --html parameter, the output will be
    simply text. When the script is run with the --html parameter, the
    output will display in an HTML table.
    
    Additional test plan:
    
    5. Test running script with and without --html parameter and confirm
    output is correct.
    
    6. Test running script with a --bibnum that does not exist and confirm
    the output acknowledges this.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 14:38:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 12:38:06 +0000
    Subject: [Koha-bugs] [Bug 30482] Potential for bad string concatenation in
     cataloging validation error message
    In-Reply-To: <bug-30482-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30482-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30482-70-qz1VVUDLwj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30482
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 14:38:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 12:38:10 +0000
    Subject: [Koha-bugs] [Bug 30482] Potential for bad string concatenation in
     cataloging validation error message
    In-Reply-To: <bug-30482-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30482-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30482-70-Anc74orgi0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30482
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133506|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133675
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133675&action=edit
    Bug 30482: Potential for bad string concatenation in cataloging validation
    error message
    
    In validating the basic MARC editor form before submission, we run
    AreFieldsNotOk() twice (once with the parameter "false") and concatenate
    the result for output. This creates the potential for the error string
    to be appended with "0" if AreFieldsNotOk() returns false.
    
    This patch improves the logic around building the error string.
    
    To test, apply the patch and make sure one of your MARC frameworks
    contains at least one mandatory field and at least one important field.
    
    - Edit or create a MARC record in the basic MARC editor.
    - Submit the form in various states of completion:
      - If a mandatory and an important field are empty, you should see two
        error messages at the top. "The following mandatory subfields aren't
        filled" and "The following important subfields aren’t filled."
      - If a mandatory OR an important field is empty, you should see a
        single message.
        - If it's the important field which is empty, a confirmation will
          ask if you want to save the record anyway. Test that both answers
          to this confirmation work correctly.
      - If no mandatory or important fields are empty the form should
        submit.
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 14:39:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 12:39:24 +0000
    Subject: [Koha-bugs] [Bug 30589] Allow importing circulation conditions as
     CSV or spreadsheet
    In-Reply-To: <bug-30589-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30589-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30589-70-P1zTSjYXhp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30589
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |andrew at bywatersolutions.com
    
    --- Comment #1 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    I'd be uncomfortable with this feature moving forward until we've first adding
    logging for changes to circ rules (Bug 16544). The idea of someone importing a
    malformed csv and wiping out their circ rules is unpleasant.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 14:40:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 12:40:30 +0000
    Subject: [Koha-bugs] [Bug 30224] Wrong important field shown in cataloguing
     validation
    In-Reply-To: <bug-30224-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30224-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30224-70-MfFGVGNSMQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com
             Depends on|                            |28694
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694
    [Bug 28694] Check alert in cataloguing should be a static message
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 14:40:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 12:40:30 +0000
    Subject: [Koha-bugs] [Bug 28694] Check alert in cataloguing should be a
     static message
    In-Reply-To: <bug-28694-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28694-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28694-70-vTCKhhbsAf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30224
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224
    [Bug 30224] Wrong important field shown in cataloguing validation
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 14:40:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 12:40:35 +0000
    Subject: [Koha-bugs] [Bug 30438] Add select all/clear buttons to invoices.tt
     open and closed tables
    In-Reply-To: <bug-30438-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30438-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30438-70-UTBCxqJ3Ea@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30438
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 14:40:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 12:40:40 +0000
    Subject: [Koha-bugs] [Bug 30438] Add select all/clear buttons to invoices.tt
     open and closed tables
    In-Reply-To: <bug-30438-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30438-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30438-70-10DRM55cmY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30438
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133358|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133676
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133676&action=edit
    Bug 30438: Add select all/clear all buttons to invoices.tt
    
    To test:
    1. Apply patch
    2. Have a bunch of invoices, some open and some closed.
    3. Go to Home > Acquisitions > Invoices and do a search that will
       return you many of those invoices, some open and some closed.
    4. Notice the 'Select all' and 'Clear all' buttons.
    5. Try clicking 'Select all' on the Open invoices tab. All Open invoices
       should become checked.
    6. Try clicking 'Clear all' on the Open invoices tab. All open invoices
       should become unchecked.
    7. Try 5 - 6 again but on the Closed invoices tab.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 14:48:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 12:48:07 +0000
    Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
     $biblio->metadata->record
    In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29697-70-h5eKxSL3j4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
    
    --- Comment #21 from Nick Clemens <nick at bywatersolutions.com> ---
    (In reply to Jonathan Druart from comment #20)
    > Can we move this one forward please?
    
    Test plan?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 15:05:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 13:05:08 +0000
    Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
     $biblio->metadata->record
    In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29697-70-I1k6wskyYy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
    
    --- Comment #22 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    (In reply to Nick Clemens from comment #21)
    > (In reply to Jonathan Druart from comment #20)
    > > Can we move this one forward please?
    > 
    > Test plan?
    
    No test plan, the diff it too big. What we need here are QA eyes :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 15:13:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 13:13:23 +0000
    Subject: [Koha-bugs] [Bug 30224] Wrong important field shown in cataloguing
     validation
    In-Reply-To: <bug-30224-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30224-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30224-70-3mFnhWPPD6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133551|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 133677
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133677&action=edit
    Bug 30224: Show correct important field in cataloguing validation
    
    This patch fxes the cataloguing validation messages to show the correct tag,
    when the whole field is important (not just a subfield).
    
    Note: Look at Bug 30159 to fix the formatting of the validation popup.
    
    1. Go to Administration -> MARC bibliographic frameworks
    2. Click Actions next to a framework, view MARC structure
    3. Edit multiple tags (at least 2) and check the Important checkbox.
    4. Go to cataloguing and create a new record using the framework you just
    edited
    5. Don't fill any of the important fields. Click Save to force the validation
    for the important tags
    6. Notice that the error message shows that an important field isn't filled,
    but the tag number shown is repeated for each message. The 'Go to field' link
    goes to the right tag, but the tag number shown is incorrect.
    7. Apply patch and refresh page
    8. Click Save to force validation again.
    9. Confirm the correct tag number is now showing for each error message.
    
    Sponsored-by: Education Services Australia SCIS
    Signed-off-by: Petro Vashchuk <stalkernoid at gmail.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 15:13:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 13:13:37 +0000
    Subject: [Koha-bugs] [Bug 30224] Wrong important field shown in cataloguing
     validation
    In-Reply-To: <bug-30224-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30224-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30224-70-GHurQuHCIj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 15:31:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 13:31:21 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-zqck8WTl7i@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Behaviour on 21.11.x:
    
    1. DefaultPatronSearchFields has the default value
    (surname,firstname,othernames,cardnumber,userid)
    => standard will search "standard" (retrieved from the pref in the pm)
    
    2. DefaultPatronSearchFields=surname,initials,borrowernotes
    => standard will search "standard" (retrieved from the pref in the pm)
    => 2 new options are added to the dropdown, "Initials" and "Circulation note"
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 15:40:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 13:40:05 +0000
    Subject: [Koha-bugs] [Bug 30520] Command line stage and import broken since
     21.11.
    In-Reply-To: <bug-30520-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30520-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30520-70-vz7hL4leZr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |andreas.jonsson at kreablo.se
                       |ity.org                     |
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 15:41:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 13:41:40 +0000
    Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
    In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17015-70-F5le0N5d4d@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015
    
    --- Comment #284 from The Minh Luong <the-minh.luong at inlibro.com> ---
    Created attachment 133678
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133678&action=edit
    Bug 17015: Check out with the useDaysMode preference
    
    When checking out with useDaysMode preference set to "Use the calendar to push
    the due date to the next open day",
    an error 500 appears. This patch fixes this error.
    
    To test:
    1. Go in Administration->useDaysMode
    2. Set this preference t0 "Use the calendar to push the due date to the next
    open day"
    3. Make sure you have a patron and a item (note the patron's category and the
    item's type)
    4. Make sure you have a circulation rule with the patron's category and the
    item type in step 3
    5. Attempt a checkout
    6. An error 500 appears
    7. Apply the patch
    8. The error is no longer there
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 15:42:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 13:42:05 +0000
    Subject: [Koha-bugs] [Bug 15461] Add staff equivalent for
     OpacLocationOnDetail
    In-Reply-To: <bug-15461-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-15461-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-15461-70-lWBVJEl9Gy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461
    
    Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |marjorie.barry-vila at collect
                       |                            |o.ca
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 15:43:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 13:43:06 +0000
    Subject: [Koha-bugs] [Bug 29704] Holds reminder emails should allow
     configuration for a specific number of days
    In-Reply-To: <bug-29704-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29704-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29704-70-NwkifNB6W2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|22.05.00,21.11.03           |22.05.00,21.11.03,21.05.14
            released in|                            |
                 Status|Pushed to stable            |Pushed to oldstable
    
    --- Comment #9 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Pushed to 21.05.x for 21.05.14
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 15:43:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 13:43:10 +0000
    Subject: [Koha-bugs] [Bug 30412] Shelving location column in holdings table
    In-Reply-To: <bug-30412-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30412-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30412-70-pnnfDicOHJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30412
    
    Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |marjorie.barry-vila at collect
                       |                            |o.ca
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 16:02:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 14:02:03 +0000
    Subject: [Koha-bugs] [Bug 30412] Shelving location column in holdings table
    In-Reply-To: <bug-30412-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30412-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30412-70-rYdOjvPtK2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30412
    
    Patrick Robitaille <patrick.robitaille at collecto.ca> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |patrick.robitaille at collecto
                       |                            |.ca
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 16:02:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 14:02:09 +0000
    Subject: [Koha-bugs] [Bug 15461] Add staff equivalent for
     OpacLocationOnDetail
    In-Reply-To: <bug-15461-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-15461-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-15461-70-Ejsz4Lcjjf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461
    
    Patrick Robitaille <patrick.robitaille at collecto.ca> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |patrick.robitaille at collecto
                       |                            |.ca
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 16:03:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 14:03:04 +0000
    Subject: [Koha-bugs] [Bug 23352] Define serial's collection in the
     subscription
    In-Reply-To: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23352-70-rR8RkL7HO0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 16:03:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 14:03:09 +0000
    Subject: [Koha-bugs] [Bug 23352] Define serial's collection in the
     subscription
    In-Reply-To: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23352-70-51erp1gdpl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131435|0                           |1
            is obsolete|                            |
     Attachment #131437|0                           |1
            is obsolete|                            |
     Attachment #131438|0                           |1
            is obsolete|                            |
     Attachment #131439|0                           |1
            is obsolete|                            |
     Attachment #132920|0                           |1
            is obsolete|                            |
    
    --- Comment #44 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133679
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133679&action=edit
    Bug 23352: Database changes
    
    Sponsored-By: Brimbank Library, Australia
    
    Signed-off-by: Samu Heiskanen <samu.heiskanen at hypernova.fi>
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 16:03:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 14:03:14 +0000
    Subject: [Koha-bugs] [Bug 23352] Define serial's collection in the
     subscription
    In-Reply-To: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23352-70-x7tVaJhURQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352
    
    --- Comment #45 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133680
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133680&action=edit
    Bug 23352: Updated schema file
    
    Sponsored-By: Brimbank Library, Australia
    
    Signed-off-by: Samu Heiskanen <samu.heiskanen at hypernova.fi>
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 16:03:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 14:03:18 +0000
    Subject: [Koha-bugs] [Bug 23352] Define serial's collection in the
     subscription
    In-Reply-To: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23352-70-DxiB3krSI2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352
    
    --- Comment #46 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133681
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133681&action=edit
    Bug 23352: Set default collection code when creating subscription
    
    The default collection code set in the subscription will be applied if
    item records are created when receiving the serial.
    
    Test plan:
    1. Apply 3 patches
    2. Run updatedatabase.pl and restart services
    3. Create a subscription:
    - Tick the 'Create an item record when receiving this serial' radio
    button
    - Select values in the Location, Collection code and Item type dropdowns
    - Save the subscription
    4. Confirm the Location, and Collection code default values
    you choose in #3 are displaying in the 'Information' tab of page that's
    loaded
    5. Receive the serial:
    - Click 'Receive'
    - Change the status dropdown from 'Expected' to 'Arrived'
    - Confirm the 'Collection Code', 'Shelving location' and 'Koha item
    type' dropdowns are pre-filled with the values you defined in #3
    6. Run unit test t/db_dependent/Serials.t
    
    Sponsored-By: Brimbank Library, Australia
    
    Signed-off-by: Samu Heiskanen <samu.heiskanen at hypernova.fi>
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 16:03:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 14:03:22 +0000
    Subject: [Koha-bugs] [Bug 23352] Define serial's collection in the
     subscription
    In-Reply-To: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23352-70-8KIb3jbL1x@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352
    
    --- Comment #47 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133682
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133682&action=edit
    Bug 23352: (follow-up) Fixes for QA review
    
    Test plan:
    1. Confirm that
    installer/data/mysql/atomicupdate/bug_23352-add_ccode_column_to_subscriptions_table.pl
    has the exec flag
    
    2. Create a subscription. Notice the 'Collection' dropdown defaults to
    the 'None' option - same as Location
    
    3. Save the subscription without changing the 'None' collection
    
    4. Receive the serial and confirm the 'Collection' field is empty
    
    5. Create a second subscription. Change the 'Collection' dropdown to
    'Fiction', then save the subscription
    
    6. Receive the serial and confirm the 'Collection' dropdown is set to
    'Fiction'
    
    7. Confirm that the 'Collection code' terminology in the template is replaced
    with
    'Collection'
    
    Sponsored-By: Brimbank Library, Australia
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 16:03:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 14:03:27 +0000
    Subject: [Koha-bugs] [Bug 23352] Define serial's collection in the
     subscription
    In-Reply-To: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23352-70-mAosAhKCfb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352
    
    --- Comment #48 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133683
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133683&action=edit
    Bug 23352: (follow-up) Fix QA test failure
    
    Sponsored-by: Catalyst IT
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 16:21:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 14:21:56 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-tgbHCzHHoz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133555|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133684
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133684&action=edit
    Bug 30576: Use DefaultPatronSearchFields in patron search
    
    This patch corrects the handling of the 'Standard' search field in
    patron searches such that it accurately reflects the contents of the
    DefaultPatronSearchFields system preference and falls back to a hard
    coded list instead of always using the hard coded list.
    
    To test:
    1) Empty the contents of DefaultPatronSearchFields systempreference
    2) Perform a patron search from the header search
    3) Inspect the patrons API request and note that we search on the
       default fallback fields of firstname, surname, othernames,
       cardnumber and userid (and some extended attributes which are
       historically hard coded).
    4) Navigate to the memebers-home by clicking the 'Patrons' button from
       the main page
    5) Perform another search using the filters on the left with 'Standard'
       selected.
    6) Note the same list of search fields used as above in the patrons API
       request.
    7) Update the DefaultPatronSearchFields systempreference adding one or
       more borrower fields in a comma delimited list.
    8) Repeat steps 2 -> 6 but this time upon inspecting the API request you
       should find that only the fields in your DefaultPatronSearchFields
       list are searched (along with the hard coded extended attributes
       list).
    9) Signoff
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 16:22:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 14:22:00 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-pxTLVc4Kbj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133685
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133685&action=edit
    Bug 30576: (follow-up) Corrections to behaviour to reflect unit tests
    
    The unit tests highlighted my original patch didn't cover the full
    preference description.
    
    We now replace the 'standard' option with the fields from the preference
    and we also add those fields as options to the field selection in
    advanced searches.
    
    This patch also adjusts the tests to test for that and reflects the
    expected changes to the number of options displayed in the select boxes.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 16:23:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 14:23:38 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-n9PZi1HsbG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    As discussed, there is still an issue should someone add a bad field into the
    system preference.. but we decided that was out of scope for here.
    
    I'm also still stuck with one last test failure.. I have no idea how this
    patchset causes it.. hopefully it'll be something obvious for Jonathan to spot.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 16:31:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 14:31:31 +0000
    Subject: [Koha-bugs] [Bug 30172] Background jobs failing due to race
     condition
    In-Reply-To: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30172-70-4OpTIzOvuv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |andrew at bywatersolutions.com
                 Status|Pushed to stable            |Pushed to oldstable
             Version(s)|22.05.00,21.11.05           |22.05.00,21.11.05,21.05.14
            released in|                            |
    
    --- Comment #40 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Pushed to 21.05.x for 21.05.14
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 16:40:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 14:40:53 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-D4xtEc2AYz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133643|0                           |1
            is obsolete|                            |
    
    --- Comment #166 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133686
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133686&action=edit
    Bug 28786: Fix 2FA selenium tests
    
    Looks like there was a bad rebase at some point.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 16:43:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 14:43:41 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-1wQHDkN0gM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Ho.. that last failure is also on master.. I'll fix it on master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 16:57:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 14:57:20 +0000
    Subject: [Koha-bugs] [Bug 30025] BiblioAddsAuthorities is poorly named
    In-Reply-To: <bug-30025-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30025-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30025-70-HWXOYN5mNg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025
    
    --- Comment #1 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    We should split this functionality out into two sysprefs -- one about whether
    or not one can type free text into authority-controlled fields and a second
    about whether or not bibs link automatically on creation and import. Both of
    those new sysprefs should have more accurate and descriptive names than
    BiblioAddsAuthorities.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 17:01:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 15:01:45 +0000
    Subject: [Koha-bugs] [Bug 30577] Item specific holds location can be missed
     when placing title level holds
    In-Reply-To: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30577-70-JG9mC8cktE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133572|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Created attachment 133687
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133687&action=edit
    Bug 30577: Move item specific pickup locations to the left
    
    When placing holds, staff will set the pickup location at the top,
    choose an item, then place the hold.
    It is easy not to notice the item specific locations dropdown.
    
    This patch moves it in line with the other selction areas on the request
    screen.
    
    To test:
     1 - Find a record on staff client, place hold
     2 - Select a patron to load the request screen
     3 - Note the location dropdown for next available hold
     4 - Note the item specific locations on the far right
     5 - Apply patch
     6 - Reload the page
     7 - Note the item specific location dropdowns are now moved to the left
     8 - Place the hold, verify it works with the dropdowns
     9 - Verify title levelholds still work as expected
    10 - Verify multi-holds still work
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 17:01:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 15:01:49 +0000
    Subject: [Koha-bugs] [Bug 30577] Item specific holds location can be missed
     when placing title level holds
    In-Reply-To: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30577-70-KBr5Sbw8eK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133573|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Created attachment 133688
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133688&action=edit
    Bug 30577: Fix a missing closing tag
    
    This didn't affect table display, but when there was a biblioloo.warn
    we were not closing the first <td> tag
    
    Confirm multi-holds table loads correctly when one (or more) records cannot be
    held
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 17:03:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 15:03:05 +0000
    Subject: [Koha-bugs] [Bug 30579] When placing item level hold,
     some options that are not used are not disabled
    In-Reply-To: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30579-70-MEGR1hGUoU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133574|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Created attachment 133689
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133689&action=edit
    Bug 30579: Disentangle multi-hold and single bib forms
    
    This patch simply groups the forms so that multi-hold and single
    hold are each in their own section
    
    While there is some duplication from this, it makes the sections easier to read
    and allows for more variation in the two forms
    
    To test:
    1 - Place a single bib and multi bib hold in staff client
    2 - Apply this patch
    3 - Repeat and confirm nothing changes with this patch
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 17:03:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 15:03:09 +0000
    Subject: [Koha-bugs] [Bug 30579] When placing item level hold,
     some options that are not used are not disabled
    In-Reply-To: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30579-70-tjCHim6Kft@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133575|0                           |1
            is obsolete|                            |
    
    --- Comment #7 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Created attachment 133690
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133690&action=edit
    Bug 30579: Group next available hold options, and disable when item is chosen
    
    This patch rearranges options that only apply to next available holds
    and disables them when an item is checked. This is intended to make it
    more obvious which parts of the form apply to this selection
    
    To test:
    1 - Apply patches
    2 - Confirm you can successfully place single or multiple items on hold
    3 - Confirm that when placing a single hold the next available options are
    grouped
    4 - Confirm pickup location, specific item type, and number of holds all work
    for next available
    5 - Confirm item level holds save pickup location correctly
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 17:27:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 15:27:01 +0000
    Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
    In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-12446-70-lDLOFOxWbN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
    
    --- Comment #181 from The Minh Luong <the-minh.luong at inlibro.com> ---
    Created attachment 133691
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133691&action=edit
    Bug 12446: Fixing QA tool's tests
    
    This patch fixes tests that fails by the QA test tool.
    I removed the debug variable, since it is not used.
    I also got a few spelling check errors when I ran the QA test tool. I corrected
    them too.
    
    To test:
    1) Create an Adult AND Child category in Administration/Patron
    categories
    2) Create a child AND adult patron.
    3) Go in your child patron's page.
    4) Click on "Edit".
    5) Notice that you can add a guarantor with "Add guarantor" button.
    6) Go in your adult patron's page.
    7) Click on "Edit".
    8) Notice that there is no "Add guarantor" button. Therefore, you can't
    add a guarantor for this patron.
    9) Apply patch and run updatedatabase.pl
    10) Go in Administration/Patron categories and edit one of them.
    12) Notice that you can see the new "Can be guarantee" field.
    13) Set "Yes" on the "Can be guarantee" field for your Child AND Adult
    category.
    14) Repeat steps 6 to 7.
    15) Notice that your adult patron can now add guarantors with the "Add
    guarantor" button.
    16) prove t/db_dependent/Patrons.t
        => All tests should still pass
    17) Run the QA test tool. All tests should say OK
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 17:29:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 15:29:56 +0000
    Subject: [Koha-bugs] [Bug 11989] Holds Queue Scheduling
    In-Reply-To: <bug-11989-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-11989-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-11989-70-QyAsUcP8pp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11989
    
    --- Comment #4 from George Williams (NEKLS) <george at nekls.org> ---
    Good idea.  Would be great to see it implemented.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 17:36:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 15:36:07 +0000
    Subject: [Koha-bugs] [Bug 30063] Make the main patron search use the
     /patrons REST API route
    In-Reply-To: <bug-30063-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30063-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30063-70-TRqfTx4atn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |additional_work_needed
    
    --- Comment #74 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    patrons_search.t selenium test is failing and I'm not entirely sure why :(
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 17:52:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 15:52:43 +0000
    Subject: [Koha-bugs] [Bug 28430] [DOCS] Spelling error in the manual
     (tools): alreay
    In-Reply-To: <bug-28430-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28430-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28430-70-TKNCuh9vWx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28430
    
    Aude Charillon <aude.charillon at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|Manual                      |Manual-updated
                     CC|                            |aude.charillon at ptfs-europe.
                       |                            |com
                 Status|NEW                         |RESOLVED
             Resolution|---                         |FIXED
    
    --- Comment #2 from Aude Charillon <aude.charillon at ptfs-europe.com> ---
    Manual updated
    (https://gitlab.com/koha-community/koha-manual/-/merge_requests/555)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 17:52:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 15:52:43 +0000
    Subject: [Koha-bugs] [Bug 27382] [DOCS] [Omnibus] Spelling errors in the
     manual
    In-Reply-To: <bug-27382-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27382-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27382-70-QBORWAgVx9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27382
    Bug 27382 depends on bug 28430, which changed state.
    
    Bug 28430 Summary: [DOCS] Spelling error in the manual (tools): alreay
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28430
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 17:58:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 15:58:48 +0000
    Subject: [Koha-bugs] [Bug 30597] New: Update wording of
     RestrictionBlockRenewing to include auto-renew
    Message-ID: <bug-30597-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30597
    
                Bug ID: 30597
               Summary: Update wording of RestrictionBlockRenewing to include
                        auto-renew
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: System Administration
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: andrew at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com
            Depends on: 28747
    
    In bug 28747 we changed the wording on this syspref to:
    If a patron is restricted, (allow/block) renewing of items from the staff
    interface.
    
    In retrospect, we should mentioned auto-renewals:
    
    If a patron is restricted, (allow/block) renewing of items from the staff
    interface and via the automatic_renewals cronjob.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28747
    [Bug 28747] Clarify wording on RestrictionBlockRenewing syspref
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 17:58:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 15:58:48 +0000
    Subject: [Koha-bugs] [Bug 28747] Clarify wording on RestrictionBlockRenewing
     syspref
    In-Reply-To: <bug-28747-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28747-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28747-70-IH6uxwITFL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28747
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30597
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30597
    [Bug 30597] Update wording of RestrictionBlockRenewing to include auto-renew
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 18:05:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 16:05:34 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-3f60a2YvWE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|BLOCKED                     |Failed QA
    
    --- Comment #79 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Hmm, OK.. the selenium failures are now introduced by this bug..
    
    Is there any way to mock the config (encrpytion_key) for a selenium test?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 18:16:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 16:16:08 +0000
    Subject: [Koha-bugs] [Bug 30597] Update wording of RestrictionBlockRenewing
     to include auto-renew
    In-Reply-To: <bug-30597-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30597-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30597-70-Lo32TfohoJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30597
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 18:16:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 16:16:12 +0000
    Subject: [Koha-bugs] [Bug 30597] Update wording of RestrictionBlockRenewing
     to include auto-renew
    In-Reply-To: <bug-30597-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30597-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30597-70-hYN8DpXJDl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30597
    
    --- Comment #1 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Created attachment 133692
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133692&action=edit
    Bug 30597: Update RestrictionBlockRenewal description to include auto renew
    
    To test:
    - apply the patch, find the syspref, see the new wording
    
    To confirm the behavior:
    - set the syspref to Block
    - give a patron an auto-renewing checkout and a restriction
    - run automatic_renewal.pl, see item does not renew
    - switch syspref to allow, repeat, see renewal
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 18:19:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 16:19:01 +0000
    Subject: [Koha-bugs] [Bug 30584] Cannot add field mappings to Elasticsearch
     configuration
    In-Reply-To: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30584-70-gdBxxTVXLp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |victor at tuxayo.net
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 18:21:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 16:21:16 +0000
    Subject: [Koha-bugs] [Bug 29704] Holds reminder emails should allow
     configuration for a specific number of days
    In-Reply-To: <bug-29704-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29704-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29704-70-Y1v9fXUZpL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                 Status|Pushed to oldstable         |RESOLVED
                     CC|                            |victor at tuxayo.net
    
    --- Comment #10 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 18:36:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 16:36:23 +0000
    Subject: [Koha-bugs] [Bug 26635] Expand authorised values in REST API call
    In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26635-70-nBsUYRZ8z1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
    
    George Williams (NEKLS) <george at nekls.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |george at nekls.org
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 19:02:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 17:02:29 +0000
    Subject: [Koha-bugs] [Bug 21903] koha-dump be able to include koha-upload
    In-Reply-To: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21903-70-oyccJOKYPp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21903
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |victor at tuxayo.net
       Patch complexity|---                         |Small patch
    
    --- Comment #21 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    > 2) What do I need to do to make this work on ktd?
    
    running `reset_all` or restarting ktd after applying the patches will make the
    new files be copied in the right place.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 19:49:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 17:49:02 +0000
    Subject: [Koha-bugs] [Bug 23775] Claiming a serial issue doesn't create the
     next one
    In-Reply-To: <bug-23775-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23775-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23775-70-g1pnIdEEDJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775
    
    --- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
    > 3)Check the row of the serial with the EXPECTED status
    > 4)Click 'Send notification'
    > 5)Notice the status of the row : it is now CLAIMED
    
    I don't know if I'm doing something wrong, but this step doesn't work for me.
    The status of the issue remains EXPECTED.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 20:29:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 18:29:25 +0000
    Subject: [Koha-bugs] [Bug 30532] guided_reports.pl has a problem
    In-Reply-To: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30532-70-iTdyhF06tP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30532
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |Pushed to stable
             Version(s)|22.05.00                    |,21.11.05
            released in|                            |
                     CC|                            |kyle at bywatersolutions.com
    
    --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 20:29:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 18:29:54 +0000
    Subject: [Koha-bugs] [Bug 30525] Items batch modification broken
    In-Reply-To: <bug-30525-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30525-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30525-70-2JB1gql8up@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30525
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |Pushed to stable
             Version(s)|22.05.00                    |22.05.00,21.11.05
            released in|                            |
                     CC|                            |kyle at bywatersolutions.com
    
    --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 20:39:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 18:39:49 +0000
    Subject: [Koha-bugs] [Bug 30598] New: Replacement cost is not copied from
     retail price when ordering from file
    Message-ID: <bug-30598-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30598
    
                Bug ID: 30598
               Summary: Replacement cost is not copied from retail price when
                        ordering from file
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Acquisitions
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: caroline.cyr-la-rose at inlibro.com
            QA Contact: testopia at bugs.koha-community.org
    
    In acquisitions, when you order an individual title, and you enter the "vendor
    price", it is copied in the retail price, the replacement cost, and the
    budgeted cost. However, if you order from a file, when you enter the price, the
    replacement price field stays empty.
    
    To test :
    1- In Acquisitions, create a basket
    2- Add an order from a new (empty) record 
     --> Note that when you enter the "vendor price", it is copied in the
    "replacement cost" field
    3- Add an order from a new file
     --> Note that when you enter the "price", the "replacement price" field stays
    empty
    
    This means you have to enter the price twice for each item ordered.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 20:41:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 18:41:04 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-Dr5A2neUEO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|additional_work_needed      |
    
    --- Comment #167 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    "Fix 2FA selenium tests" pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 20:48:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 18:48:27 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-C05RkBPU6k@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|additional_work_needed      |
    
    --- Comment #49 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master :
     Fix unimarc authorised values
     Fix xt/find-license-problems.t
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 20:52:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 18:52:43 +0000
    Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on
     fresh install, but can be null with upgrade
    In-Reply-To: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27253-70-7U7zateDQO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 20:52:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 18:52:46 +0000
    Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on
     fresh install, but can be null with upgrade
    In-Reply-To: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27253-70-2AWGjFONUY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253
    
    --- Comment #11 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 20:52:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 18:52:48 +0000
    Subject: [Koha-bugs] [Bug 30446] Add a test for GetTagsLabels
    In-Reply-To: <bug-30446-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30446-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30446-70-ASX0R0aesl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30446
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 20:52:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 18:52:51 +0000
    Subject: [Koha-bugs] [Bug 30446] Add a test for GetTagsLabels
    In-Reply-To: <bug-30446-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30446-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30446-70-WVsVaYtPKQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30446
    
    --- Comment #8 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 20:52:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 18:52:53 +0000
    Subject: [Koha-bugs] [Bug 30512] Staff interface search results template
     error
    In-Reply-To: <bug-30512-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30512-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30512-70-Tgj1p7CnJq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 20:52:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 18:52:55 +0000
    Subject: [Koha-bugs] [Bug 30512] Staff interface search results template
     error
    In-Reply-To: <bug-30512-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30512-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30512-70-mxMgBPl1MR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512
    
    --- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 20:52:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 18:52:58 +0000
    Subject: [Koha-bugs] [Bug 30531] Search.t needs update for Recalls
    In-Reply-To: <bug-30531-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30531-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30531-70-aIpO92jBst@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30531
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 20:53:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 18:53:00 +0000
    Subject: [Koha-bugs] [Bug 30531] Search.t needs update for Recalls
    In-Reply-To: <bug-30531-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30531-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30531-70-z6QduTsGmc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30531
    
    --- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 20:53:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 18:53:03 +0000
    Subject: [Koha-bugs] [Bug 30595] update_child_to_adult.t is failing randomly
    In-Reply-To: <bug-30595-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30595-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30595-70-8ZVhvkxt1t@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30595
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 20:53:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 18:53:05 +0000
    Subject: [Koha-bugs] [Bug 30595] update_child_to_adult.t is failing randomly
    In-Reply-To: <bug-30595-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30595-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30595-70-pYGABohtwa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30595
    
    --- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 20:53:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 18:53:44 +0000
    Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on
     fresh install, but can be null with upgrade
    In-Reply-To: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27253-70-CChC0V776Z@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
    
    --- Comment #12 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    (In reply to Fridolin Somers from comment #11)
    > Pushed to master for 22.05, thanks to everybody involved 🦄
    
    Sorry I forgot yesterday to update status
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 20:55:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 18:55:19 +0000
    Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on
     fresh install, but can be null with upgrade
    In-Reply-To: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27253-70-0hJdtmcpfs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253
    
    --- Comment #13 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    May I revert ?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 20:55:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 18:55:42 +0000
    Subject: [Koha-bugs] [Bug 25996] Changes to debarments should be logged
    In-Reply-To: <bug-25996-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25996-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25996-70-XVb6yWe0XD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25996
    
    Benjamin Daeuber <bdaeuber at cityoffargo.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |bdaeuber at cityoffargo.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 21:14:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 19:14:53 +0000
    Subject: [Koha-bugs] [Bug 30596] api/v1/acquisitions_baskets.t is failing
     randomly
    In-Reply-To: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30596-70-NfMIRUy852@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
       Patch complexity|---                         |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 21:14:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 19:14:57 +0000
    Subject: [Koha-bugs] [Bug 30596] api/v1/acquisitions_baskets.t is failing
     randomly
    In-Reply-To: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30596-70-rUowk99Aau@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133669|0                           |1
            is obsolete|                            |
    
    --- Comment #9 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Created attachment 133693
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133693&action=edit
    Bug 30596: Prevent api/v1/acquisitions_baskets.t and
    api/v1/acquisitions_funds.t to fail randomly
    
    because of updated_on
    
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 21:15:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 19:15:38 +0000
    Subject: [Koha-bugs] [Bug 30599] New: Allow archiving multiple suggestions
    Message-ID: <bug-30599-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30599
    
                Bug ID: 30599
               Summary: Allow archiving multiple suggestions
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Acquisitions
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: nick at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
    
    The code on the staff client can accept multiple suggestions for archiving,
    however, there is no button to do so
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 21:18:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 19:18:17 +0000
    Subject: [Koha-bugs] [Bug 30599] Allow archiving multiple suggestions
    In-Reply-To: <bug-30599-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30599-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30599-70-AnGTwcib0N@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30599
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
       Patch complexity|---                         |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 21:18:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 19:18:20 +0000
    Subject: [Koha-bugs] [Bug 30599] Allow archiving multiple suggestions
    In-Reply-To: <bug-30599-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30599-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30599-70-HIRgORG10I@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30599
    
    --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133694
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133694&action=edit
    Bug 30599: Add an 'Archive selected' button
    
    This patch simply adds a new button on the suggestions interface to allow
    for archiving multiple suggestions.
    
    To test:
    1 - Apply patch
    2 - Create some purchase suggestions
    3 - Select several suggestions
    4 - Click 'Archive selected'
    5 - Suggestions are archived
    6 - You can view archived suggestions by selecting 'Suggestion
    information'->'Include archived'
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 21:18:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 19:18:29 +0000
    Subject: [Koha-bugs] [Bug 30599] Allow archiving multiple suggestions
    In-Reply-To: <bug-30599-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30599-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30599-70-gTe8PJKI1P@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30599
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                       |ity.org                     |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 21:40:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 19:40:47 +0000
    Subject: [Koha-bugs] [Bug 21860] Marc modification templates cannot check or
     change indicators
    In-Reply-To: <bug-21860-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21860-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21860-70-YgC4RwrtZg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860
    
    Abbey Holt <aholt at dubuque.lib.ia.us> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |aholt at dubuque.lib.ia.us
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 21:53:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 19:53:15 +0000
    Subject: [Koha-bugs] [Bug 30599] Allow archiving multiple suggestions
    In-Reply-To: <bug-30599-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30599-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30599-70-CRWFEuWGyA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30599
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 21:53:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 19:53:18 +0000
    Subject: [Koha-bugs] [Bug 30599] Allow archiving multiple suggestions
    In-Reply-To: <bug-30599-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30599-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30599-70-IeWLcKbt5b@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30599
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133694|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Created attachment 133695
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133695&action=edit
    Bug 30599: Add an 'Archive selected' button
    
    This patch simply adds a new button on the suggestions interface to allow
    for archiving multiple suggestions.
    
    To test:
    1 - Apply patch
    2 - Create some purchase suggestions
    3 - Select several suggestions
    4 - Click 'Archive selected'
    5 - Suggestions are archived
    6 - You can view archived suggestions by selecting 'Suggestion
    information'->'Include archived'
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 22:01:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 20:01:16 +0000
    Subject: [Koha-bugs] [Bug 30600] New: Recalls sync problem between DBIx and
     kohastructure.sql
    Message-ID: <bug-30600-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30600
    
                Bug ID: 30600
               Summary: Recalls sync problem between DBIx and
                        kohastructure.sql
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: critical
              Priority: P5 - low
             Component: Database
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: fridolin.somers at biblibre.com
            QA Contact: testopia at bugs.koha-community.org
    
    Created attachment 133696
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133696&action=edit
    DBIx schema diff
    
    Bug 19532 Recalls added several db changes.
    
    Comparing a structure from v21.11.00 + updatedatabase.pl and a structure
    generated from current master kohastructure.sql, after updating DBIx schema
    (via misc/devel/update_dbix_class_files.pl not dbic) we see a difference in
    Koha/Schema/Result/Branchtransfer.pm.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 22:01:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 20:01:25 +0000
    Subject: [Koha-bugs] [Bug 30600] Recalls sync problem between DBIx and
     kohastructure.sql
    In-Reply-To: <bug-30600-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30600-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30600-70-l5fkRPj1nQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30600
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |19532
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
    [Bug 19532] Recalls for Koha
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 22:01:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 20:01:25 +0000
    Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
    In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-19532-70-9L015206Av@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30600
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30600
    [Bug 30600] Recalls sync problem between DBIx and kohastructure.sql
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 22:12:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 20:12:27 +0000
    Subject: [Koha-bugs] [Bug 30600] Recalls sync problem between DBIx and
     kohastructure.sql
    In-Reply-To: <bug-30600-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30600-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30600-70-FP0H8uJyRT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30600
    
    --- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    We see that kohastructure.sql has 'Recall' and 'CancelRecall' in
    branchtransfers.reason and branchtransfers.cancellation_reason :
    https://git.koha-community.org/Koha-community/Koha/src/commit/74792b35a83a863fa5e68c37f0c0f552f0c21a7b/installer/data/mysql/kohastructure.sql#L1560
    
    But DBRev only add in branchtransfers.reason :
    https://git.koha-community.org/Koha-community/Koha/src/commit/74792b35a83a863fa5e68c37f0c0f552f0c21a7b/installer/data/mysql/db_revs/211200018.pl#L93
    
    Which one is correct :/
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 22:22:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 20:22:40 +0000
    Subject: [Koha-bugs] [Bug 30600] Recalls sync problem between DBIx and
     kohastructure.sql
    In-Reply-To: <bug-30600-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30600-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30600-70-7Z5Np5TMmd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30600
    
    --- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Second :
    
    DBRev removes from ENUM branchtransfers.reason the value 'TransferCancellation'
    added by Bug 12362
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 22:33:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 20:33:33 +0000
    Subject: [Koha-bugs] [Bug 30599] Allow archiving multiple suggestions
    In-Reply-To: <bug-30599-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30599-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30599-70-F0Wmgs8Blo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30599
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133695|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Created attachment 133697
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133697&action=edit
    Bug 30599: Add an 'Archive selected' button
    
    This patch simply adds a new button on the suggestions interface to allow
    for archiving multiple suggestions.
    
    To test:
    1 - Apply patch
    2 - Create some purchase suggestions
    3 - Select several suggestions
    4 - Click 'Archive selected'
    5 - Suggestions are archived
    6 - You can view archived suggestions by selecting 'Suggestion
    information'->'Include archived'
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    Signed-off-by: Felicity Brown <felicity.brown at montgomerycountymd.gov>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 23:53:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 21:53:48 +0000
    Subject: [Koha-bugs] [Bug 30563] Add system preference to make the cash
     register field required when collecting a payment
    In-Reply-To: <bug-30563-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30563-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30563-70-zLQG0uHiKh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30563
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 23:53:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 21:53:51 +0000
    Subject: [Koha-bugs] [Bug 30563] Add system preference to make the cash
     register field required when collecting a payment
    In-Reply-To: <bug-30563-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30563-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30563-70-YfXdYss61z@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30563
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133393|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
    Created attachment 133698
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133698&action=edit
    Bug 30563: Add syspref to make the "cash register" field mandatory
    
    Test plan:
    1. Apply patch and run updatedatabase
    2. Enable 'UseCashRegisters' syspref and create at least one cash
       register for your library
    3. Verify that you have several authorized values in the 'PAYMENT_TYPE'
       category. One of them should be 'CASH'
    4. Go to a patron accounting tab, create a manual invoice and go to the
       payment form. Select payment type 'CASH' and verify that you cannot
       submit the form if no cash register is selected.
       Select another payment type and verify that you can submit the form
       even if no cash register is selected
    5. Set syspref 'RequireCashRegister' to 'always require a cash register'
    6. Repeat step 4 but this time you should not be able to submit the form
       if no cash register is selected, no matter which payment type is
       selected.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 23:56:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 21:56:12 +0000
    Subject: [Koha-bugs] [Bug 23011] AuthenticatePatron could alert if password
     is not safe
    In-Reply-To: <bug-23011-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23011-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23011-70-pouSkWTjSd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23011
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Patch doesn't apply
                     CC|                            |lucas at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 23:57:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 21:57:00 +0000
    Subject: [Koha-bugs] [Bug 20384] Elasticsearch rebuild script improvements -
     options for indexing
    In-Reply-To: <bug-20384-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20384-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20384-70-DJJxe4xGZ6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20384
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lucas at bywatersolutions.com
                 Status|Needs Signoff               |Patch doesn't apply
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 22 23:59:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 21:59:59 +0000
    Subject: [Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display
    In-Reply-To: <bug-25813-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25813-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25813-70-1JmIaSL1ue@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Patch doesn't apply
                     CC|                            |lucas at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 23 00:03:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 22:03:01 +0000
    Subject: [Koha-bugs] [Bug 22622] Add Koha::Object method _new_from_hashref
    In-Reply-To: <bug-22622-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22622-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22622-70-Kz6oSBQoWS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22622
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lucas at bywatersolutions.com
                 Status|Needs Signoff               |Patch doesn't apply
    
    --- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
    It looks like your unit tests no longer cleanly apply.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 23 00:05:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 22:05:10 +0000
    Subject: [Koha-bugs] [Bug 23426] Empty AV field returned in Patron Info in
     addition to those requested
    In-Reply-To: <bug-23426-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23426-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23426-70-LSN7PnlzXW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23426
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lucas at bywatersolutions.com
                 Status|Needs Signoff               |Patch doesn't apply
    
    --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> ---
    It looks like a pretty simple fix but unfortunately this patch no longer
    cleanly applies to master.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 23 00:10:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 22:10:32 +0000
    Subject: [Koha-bugs] [Bug 17511] Change authority linking subfield from $9
     to $0
    In-Reply-To: <bug-17511-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-17511-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-17511-70-wrqQnlz92c@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17511
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Patch doesn't apply
                     CC|                            |lucas at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 23 01:56:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 22 Apr 2022 23:56:38 +0000
    Subject: [Koha-bugs] [Bug 27546] Add option to search within results on the
     staff client
    In-Reply-To: <bug-27546-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27546-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27546-70-grhdHT5fcD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27546
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    --- Comment #21 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Retested, still good, passing QA :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 23 03:51:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 23 Apr 2022 01:51:34 +0000
    Subject: [Koha-bugs] [Bug 30563] Add system preference to make the cash
     register field required when collecting a payment
    In-Reply-To: <bug-30563-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30563-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30563-70-8v8l2JiMre@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30563
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 23 14:32:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 23 Apr 2022 12:32:42 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-tphghscRT8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                       |y.org                       |
                 Status|Signed Off                  |Patch doesn't apply
    
    --- Comment #63 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Please rebase.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 23 17:07:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 23 Apr 2022 15:07:04 +0000
    Subject: [Koha-bugs] [Bug 29925] Add a 'set new password' page for patron's
     with expired passwords
    In-Reply-To: <bug-29925-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29925-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29925-70-APP0pyzf4E@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29925
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |m.de.rooy at rijksmuseum.nl
    
    --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    diff --git a/opac/opac-reset-password.pl b/opac/opac-reset-password.pl
    new file mode 100755
    index 0000000000..c871cd534a
    --- /dev/null
    +++ b/opac/opac-reset-password.pl
    @@ -0,0 +1,110 @@
    +#!/usr/bin/perl
    +# This script lets the users change the passwords by themselves.
    +#
    +# (c) 2005 Universidad ORT Uruguay.
    
    Hmm New file from 2005 ?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 23 18:32:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 23 Apr 2022 16:32:20 +0000
    Subject: [Koha-bugs] [Bug 29925] Add a 'set new password' page for patron's
     with expired passwords
    In-Reply-To: <bug-29925-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29925-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29925-70-TuuGg4WACY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29925
    
    --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    +                if ( $newpassword ne $confirmpassword ) {
    +                    $template->param( 'error' => 'passwords_mismatch' );
    
    If my password was 123Jim+1, and I just change to 123Jim+2, or change 3Jim at abc
    to 4Jim at abc, could we refuse such changes?
    Look for some 'large enough' string that they have in common or so?
    Or compare the number of positions where they are different?
    
    Since this could well be considered scope creep, we could open a new report?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 23 18:34:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 23 Apr 2022 16:34:50 +0000
    Subject: [Koha-bugs] [Bug 29925] Add a 'set new password' page for patron's
     with expired passwords
    In-Reply-To: <bug-29925-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29925-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29925-70-vG1ghZJOuy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29925
    
    --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Marcel de Rooy from comment #9)
    > +                if ( $newpassword ne $confirmpassword ) {
    > +                    $template->param( 'error' => 'passwords_mismatch' );
    > 
    > If my password was 123Jim+1, and I just change to 123Jim+2, or change
    > 3Jim at abc to 4Jim at abc, could we refuse such changes?
    > Look for some 'large enough' string that they have in common or so?
    > Or compare the number of positions where they are different?
    > 
    > Since this could well be considered scope creep, we could open a new report?
    
    We needed these lines in code obviously:
    
    +                elsif ( $currentpassword eq $newpassword ) {
    +                    $template->param( 'error' => 'no_change' );
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 23 19:25:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 23 Apr 2022 17:25:47 +0000
    Subject: [Koha-bugs] [Bug 29768] hidepatronname hides guarantor name on
     borrower edit screen
    In-Reply-To: <bug-29768-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29768-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29768-70-InFFFbrOz7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768
    
    Joonas Kylmälä <joonas.kylmala at iki.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |joonas.kylmala at iki.fi
             Depends on|                            |25879
    
    --- Comment #2 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
    Regression from bug 25879
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25879
    [Bug 25879] Improve display of guarantor information in the patron entry form
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 23 19:25:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 23 Apr 2022 17:25:47 +0000
    Subject: [Koha-bugs] [Bug 25879] Improve display of guarantor information in
     the patron entry form
    In-Reply-To: <bug-25879-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25879-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25879-70-7lRERzVUbo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25879
    
    Joonas Kylmälä <joonas.kylmala at iki.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |29768
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768
    [Bug 29768] hidepatronname hides guarantor name on borrower edit screen
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 23 19:43:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 23 Apr 2022 17:43:31 +0000
    Subject: [Koha-bugs] [Bug 29768] hidepatronname hides guarantor name on
     borrower edit screen
    In-Reply-To: <bug-29768-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29768-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29768-70-MRAKLVotgP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768
    
    Joonas Kylmälä <joonas.kylmala at iki.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Failed QA
    
    --- Comment #3 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
    The patch is certainly wanted, however it has a bug, it removes the hyperlink
    to the guarantor info. I'd say it should be fixed in
    intranet-tmpl/prog/en/includes/patron-title.inc The hyperlink should be added
    regardless of the hide_patron_infos_if_needed value. Also, please remove the
    hide_patron_infos_if_needed=0 parameter completely, since that's the default
    default.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 23 19:44:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 23 Apr 2022 17:44:56 +0000
    Subject: [Koha-bugs] [Bug 29768] hidepatronname hides guarantor name on
     borrower edit screen
    In-Reply-To: <bug-29768-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29768-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29768-70-vAOAuHLfxA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768
    
    Joonas Kylmälä <joonas.kylmala at iki.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Version|20.05                       |master
    
    --- Comment #4 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
    Changed the version to master as the bug happens with the latest version as
    well.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 23 20:03:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 23 Apr 2022 18:03:42 +0000
    Subject: [Koha-bugs] [Bug 30461] Batch authority tool is broken
    In-Reply-To: <bug-30461-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30461-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30461-70-i4zhQ2Fzfp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30461
    
    Joonas Kylmälä <joonas.kylmala at iki.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 23 20:03:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 23 Apr 2022 18:03:46 +0000
    Subject: [Koha-bugs] [Bug 30461] Batch authority tool is broken
    In-Reply-To: <bug-30461-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30461-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30461-70-gA8EoIDFSK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30461
    
    Joonas Kylmälä <joonas.kylmala at iki.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132984|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
    Created attachment 133699
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133699&action=edit
    Bug 30461: Fix BatchUpdateAuthority
    
    Use of inherited AUTOLOAD for non-method
    Koha::BackgroundJob::BatchUpdateAuthority::ModAuthority() is
    no longer allowed
    
    Test plan:
    Use the batch authority tools to edit authority record and confirm that
    the task processes correctly
    
    Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 23 20:04:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 23 Apr 2022 18:04:25 +0000
    Subject: [Koha-bugs] [Bug 30461] Batch authority tool is broken
    In-Reply-To: <bug-30461-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30461-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30461-70-thnnWKp9VU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30461
    
    Joonas Kylmälä <joonas.kylmala at iki.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |joonas.kylmala at iki.fi
             QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                       |y.org                       |
                 Status|Signed Off                  |Passed QA
    
    --- Comment #3 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
    Trivial fix, straight to PQA.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 23 20:30:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 23 Apr 2022 18:30:48 +0000
    Subject: [Koha-bugs] [Bug 27259] HomeOrHoldingBranch is not used in all
     places
    In-Reply-To: <bug-27259-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27259-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27259-70-vKkMHOLnJG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27259
    
    Joonas Kylmälä <joonas.kylmala at iki.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #114591|0                           |1
            is obsolete|                            |
     Attachment #114592|0                           |1
            is obsolete|                            |
     Attachment #114593|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
    Created attachment 133700
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133700&action=edit
    Bug 27259: Test HomeOrHoldingBranch usage in TooMany()
    
    This shows that HomeOrHoldingBranch syspref is incorrectly not used by
    TooMany() when it decides which circ rule to use.
    
    Run "prove t/db_dependent/Circulation/TooMany.t" to notice the tests
    now fail.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 23 20:30:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 23 Apr 2022 18:30:52 +0000
    Subject: [Koha-bugs] [Bug 27259] HomeOrHoldingBranch is not used in all
     places
    In-Reply-To: <bug-27259-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27259-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27259-70-Ot5osRngvl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27259
    
    --- Comment #5 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
    Created attachment 133701
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133701&action=edit
    Bug 27259: Test HomeOrHoldingBranch usage in _CalculateAndUpdateFine()
    
    This shows that HomeOrHoldingBranch syspref is incorrectly not used by
    _CalculateAndUpdateFine() when it decides which circ rule to use.
    
    Run "prove t/db_dependent/Circulation/_CalculateAndUpdateFine.t" to
    notice the tests now fail.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 23 20:30:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 23 Apr 2022 18:30:56 +0000
    Subject: [Koha-bugs] [Bug 27259] HomeOrHoldingBranch is not used in all
     places
    In-Reply-To: <bug-27259-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27259-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27259-70-nfqRDM7Fhp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27259
    
    --- Comment #6 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
    Created attachment 133702
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133702&action=edit
    Bug 27259: Add HomeOrHoldingBranch checks where it was missing from
    
    The TooMany() function and fine calculation functions were incorrectly
    hard coded to use homebranch for fetching the circulation rules. Those
    ignored completely the syspref HomeOrHoldingBranch where the user
    might have set it to holdingbranch and therefore the fines and whether
    patron has too many checkouts (TooMany()) were counted using the
    unintended branch's rules. This problem only arises in the cases where
    there are branch specific circulation rules defined.
    
    Test plan:
    1. Make sure following tests pass:
       $ prove t/db_dependent/Circulation/_CalculateAndUpdateFine.t
       $ prove t/db_dependent/Circulation/TooMany.t
    
    Test plan for fines.pl:
    1. Add branch specific fine rules for branches A and B. A having a
       fine of 1 per day and B having a fine of 0 per day.
    2. Set sysprefs:
       CircControl = the library the items is from
       finesMode = Calculate and charge
       HomeOrHoldingBranch = holdingbranch
    3. Create an item with home and holding branch of A
    4. Checkout the item with a due date in the past (the past due date can be
       specified by clicking "Checkout settings" in the checkout page) and
       make sure the branch you are checking from is B.
    5. Run perl /usr/share/koha/bin/cronjobs/fines.pl
    6. Notice that fines have popped up now to the patron incorrectly
    7. Apply patch
    8. Pay fines, Check-in the item and check it out again
    9. Run perl /usr/share/koha/bin/cronjobs/fines.pl
    10. Notice that fine is now 0. This means that the branch
        B (holdingbranch of the checked-out item) specific rule is used.
    
    Test plan for staticfines.pl:
    1. Add branch specific fine rules for branches A and B. A having a
       fine of 1 per day and B having a fine of 0 per day.
    2. Set sysprefs:
       CircControl = the library the items is from
       finesMode = Calculate and charge
       HomeOrHoldingBranch = holdingbranch
    3. Create an item with homebranch A and holding branch of A
    4. Checkout the item with a due date in the past (the past due date can be
       specified by clicking "Checkout settings" in the checkout page) and
       make sure the branch you are checking from is B.
    5. Run perl staticfines.pl --library A --library B --category
    <PATRONS_CATEGORYCODE>
       and notice that now there is inccorectly fines
    6. Apply patch
    7. Pay fines, Check-in the item and check it out again
    8. Run perl staticfines.pl --library A --library B --category
    <PATRONS_CATEGORYCODE>
        and notice the fines are now not generated
    
    Rebased-by: Joonas Kylmälä <joonas.kylmala at iki.fi>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 23 21:27:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 23 Apr 2022 19:27:58 +0000
    Subject: [Koha-bugs] [Bug 30143] OAI-PMH provider may end up in an eternal
     loop due to missing sort
    In-Reply-To: <bug-30143-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30143-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30143-70-ou5PyvS8P8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30143
    
    Joonas Kylmälä <joonas.kylmala at iki.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |29135
                Version|21.11                       |master
                     CC|                            |joonas.kylmala at iki.fi
    
    --- Comment #4 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
    Depends on bug 29135. The fix is correct, however maybe it would make to sense
    to move out the common SQL above the if-else condition like it was before bug
    29135, this way we wouldn't accidentally forget to change this SQL query in
    both places in the future. Not a blocker for this, gonna add my sign-off.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135
    [Bug 29135] OAI should not include biblionumbers from deleteditems when
    determining deletedbiblios
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 23 21:27:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 23 Apr 2022 19:27:58 +0000
    Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from
     deleteditems when determining deletedbiblios
    In-Reply-To: <bug-29135-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29135-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29135-70-2JlN5oIa77@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135
    
    Joonas Kylmälä <joonas.kylmala at iki.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30143
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30143
    [Bug 30143] OAI-PMH provider may end up in an eternal loop due to missing sort
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 23 21:31:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 23 Apr 2022 19:31:50 +0000
    Subject: [Koha-bugs] [Bug 30143] OAI-PMH provider may end up in an eternal
     loop due to missing sort
    In-Reply-To: <bug-30143-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30143-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30143-70-qhhbYAFRp5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30143
    
    Joonas Kylmälä <joonas.kylmala at iki.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 23 21:31:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 23 Apr 2022 19:31:54 +0000
    Subject: [Koha-bugs] [Bug 30143] OAI-PMH provider may end up in an eternal
     loop due to missing sort
    In-Reply-To: <bug-30143-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30143-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30143-70-yOhUVBa8fZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30143
    
    Joonas Kylmälä <joonas.kylmala at iki.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #130961|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
    Created attachment 133703
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133703&action=edit
    Bug 30143: OAI-PMH: Fix SQL query used to fetch deleted records
    
    The query was missing the "ORDER BY" and "LIMIT" clauses, which could make
    retrieve a wrong set of records.
    
    Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 23 22:39:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 23 Apr 2022 20:39:24 +0000
    Subject: [Koha-bugs] [Bug 29925] Add a 'set new password' page for patron's
     with expired passwords
    In-Reply-To: <bug-29925-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29925-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29925-70-o7WyHipwmg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29925
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Medium patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 23 22:40:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 23 Apr 2022 20:40:21 +0000
    Subject: [Koha-bugs] [Bug 30143] OAI-PMH provider may end up in an eternal
     loop due to missing sort
    In-Reply-To: <bug-30143-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30143-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30143-70-6u7nzSTJVS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30143
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |victor at tuxayo.net
       Patch complexity|---                         |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 23 22:53:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 23 Apr 2022 20:53:09 +0000
    Subject: [Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved
     should check "opacitemholds" policy
    In-Reply-To: <bug-25408-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25408-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25408-70-WLWObPak8f@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Needs Signoff
    
    --- Comment #73 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    There has been a confusion. My last testing was from before the last changes to
    fix issues found afterwards. So my signoff isn't valid anymore and this patch
    is still waiting for me or someone else to test it again.
    
    Switching back to need SO
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 02:01:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 00:01:06 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-v22heB0Ols@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #50 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
    Created attachment 133704
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133704&action=edit
    Bug 30373: (followup) Country codes auth values
    
    This patch adds COUNTRY codes (ISO 3166-1) into
    mandatory auth_values.yml
    
    This authorized value is used in UNIMARC default bibliographic
    framework.
    
    To test:
    1) Do a clean install or load the YAML file
    2) Verify new country codes are in the database
        SELECT * FROM authorised_values WHERE category = 'COUNTRY';
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 02:01:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 00:01:12 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-sCkKfXbEAB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #51 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
    Created attachment 133705
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133705&action=edit
    Bug 30373: (followup) Language codes auth values
    
    This patch adds language codes (ISO 639-2) into
    mandatory auth_values.yml
    
    This authorized value is used in UNIMARC default bibliographic
    framework.
    
    To test:
    1) Do a clean install or load the YAML file
    2) Verify new language codes are in the database
        SELECT * FROM authorised_values WHERE category = 'LANG';
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 02:01:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 00:01:18 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-Viwi6c4nfg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #52 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
    Created attachment 133706
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133706&action=edit
    Bug 30373: (followup) UNIMARC relator codes auth values
    
    This patch adds UNIMARC relator codes into
    mandatory auth_values.yml
    
    This authorized value is used in UNIMARC default bibliographic
    framework.
    
    To test:
    1) Do a clean install or load the YAML file
    2) Verify new language codes are in the database
        SELECT * FROM authorised_values WHERE category = 'qualif';
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 02:01:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 00:01:23 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-UTk6OZR1Tv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #53 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
    Created attachment 133707
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133707&action=edit
    Bug 30373: (followup) Optional SUGGEST auth values
    
    This patch adds 3 SUGGEST optional auth_val.yml
    
    This authorized value is used in UNIMARC default bibliographic
    framework.
    
    To test:
    1) Do a clean install with optional files or load the YAML file
    2) Verify new SUGGEST values are in the database
        SELECT * FROM authorised_values WHERE category = 'SUGGEST';
    
        Check new values Budget, Expensive and Poldoc
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 02:06:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 00:06:34 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-iNe9TlNJQC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #54 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
    (In reply to Jonathan Druart from comment #48)
    > Nope, please attach a follow-up here. Feel free to scratch mine! Thanks! :)
    
    Your patch was fine!
    I only think that we can add again the entries using qualif's authorised
    values, they are UNIMARC relator codes
    
    I added 4 follow-ups, all authorised values from fr-FR SQL files needed by the
    UNIMARC framework
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 11:14:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 09:14:40 +0000
    Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through Stage
     Marc Record Import
    In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22785-70-HiDDcrsQOl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Patch doesn't apply
    
    --- Comment #69 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    I am sorry, but it looks like this will need a bigger rebase:
    
    Apply? [(y)es, (n)o, (i)nteractive] y
    Applying: Bug 22785: Allow option to choose which record match is applied
    during import
    Using index info to reconstruct a base tree...
    M       C4/ImportBatch.pm
    A       api/v1/swagger/definitions.yaml
    A       api/v1/swagger/parameters.yaml
    A       api/v1/swagger/paths.yaml
    A       api/v1/swagger/x-primitives.yaml
    M       installer/data/mysql/kohastructure.sql
    M       koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt
    Falling back to patching base and 3-way merge...
    Auto-merging
    koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt
    Auto-merging installer/data/mysql/kohastructure.sql
    CONFLICT (modify/delete): api/v1/swagger/x-primitives.yaml deleted in HEAD and
    modified in Bug 22785: Allow option to choose which record match is applied
    during import. Version Bug 22785: Allow option to choose which record match is
    applied during import of api/v1/swagger/x-primitives.yaml left in tree.
    CONFLICT (modify/delete): api/v1/swagger/paths.yaml deleted in HEAD and
    modified in Bug 22785: Allow option to choose which record match is applied
    during import. Version Bug 22785: Allow option to choose which record match is
    applied during import of api/v1/swagger/paths.yaml left in tree.
    CONFLICT (modify/delete): api/v1/swagger/parameters.yaml deleted in HEAD and
    modified in Bug 22785: Allow option to choose which record match is applied
    during import. Version Bug 22785: Allow option to choose which record match is
    applied during import of api/v1/swagger/parameters.yaml left in tree.
    CONFLICT (modify/delete): api/v1/swagger/definitions.yaml deleted in HEAD and
    modified in Bug 22785: Allow option to choose which record match is applied
    during import. Version Bug 22785: Allow option to choose which record match is
    applied during import of api/v1/swagger/definitions.yaml left in tree.
    Auto-merging C4/ImportBatch.pm
    error: Failed to merge in the changes.
    Patch failed at 0001 Bug 22785: Allow option to choose which record match is
    applied during import
    hint: Use 'git am --show-current-patch=diff' to see the failed patch
    When you have resolved this problem run "git bz apply --continue".
    If you would prefer to skip this patch, instead run "git bz apply --skip".
    To restore the original branch and stop patching run "git bz apply --abort".
    Patch left in
    /tmp/Bug-22785-Allow-option-to-choose-which-record-matc-Drlq9o.patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 11:15:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 09:15:03 +0000
    Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through stage
     MARC record import
    In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22785-70-Tsv3JMkvs7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Manage matches when         |Manage matches when
                       |importing through Stage     |importing through stage
                       |Marc Record Import          |MARC record import
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 11:19:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 09:19:49 +0000
    Subject: [Koha-bugs] [Bug 30601] New: Fix warnings in ill-requests
    Message-ID: <bug-30601-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30601
    
                Bug ID: 30601
               Summary: Fix warnings in ill-requests
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Architecture, internals, and plumbing
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: katrin.fischer at bsz-bw.de
            QA Contact: testopia at bugs.koha-community.org
                Blocks: 25790
    
    Argument "" isn't numeric in numeric gt (>) at
    /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
    line 851.
    Argument "" isn't numeric in numeric gt (>) at
    /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
    line 854.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790
    [Bug 25790] [OMNIBUS] warnings removal
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 11:19:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 09:19:49 +0000
    Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal
    In-Reply-To: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25790-70-rkwNWgEcsp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30601
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30601
    [Bug 30601] Fix warnings in ill-requests
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 11:24:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 09:24:38 +0000
    Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on
     fresh install, but can be null with upgrade
    In-Reply-To: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27253-70-Ek52quNJcu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253
    
    --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Hi,
    
    we recently had some issues with updated timestamps on updates. Can you confirm
    that this will only change records where the updated_on was NULL before?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 11:38:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 09:38:22 +0000
    Subject: [Koha-bugs] [Bug 30602] New: Street type on patron form showing
     although no road types are defined
    Message-ID: <bug-30602-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30602
    
                Bug ID: 30602
               Summary: Street type on patron form showing although no road
                        types are defined
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Patrons
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: katrin.fischer at bsz-bw.de
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
    
    In the past the street type would not show on the patron form, if no ROADTYPE
    have been defined.
    
    If this has changed, we should at least do a database update to add them to the
    unwanted fields so we keep current behaviour.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 11:38:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 09:38:57 +0000
    Subject: [Koha-bugs] [Bug 30602] Street type on patron form showing although
     no ROADTYPE entries exist
    In-Reply-To: <bug-30602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30602-70-UCTcViVyA5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30602
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Street type on patron form  |Street type on patron form
                       |showing although no road    |showing although no
                       |types are defined           |ROADTYPE entries exist
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 11:42:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 09:42:14 +0000
    Subject: [Koha-bugs] [Bug 30603] New: Sort 1 and Sort 2 on patron form are
     on longer free text when AV categories are empty
    Message-ID: <bug-30603-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30603
    
                Bug ID: 30603
               Summary: Sort 1 and Sort 2 on patron form are on longer free
                        text when AV categories are empty
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Keywords: regression
              Severity: major
              Priority: P5 - low
             Component: Patrons
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: katrin.fischer at bsz-bw.de
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
    
    Before a recent change Sort 1 and Sort 2 would appear as free text input fields
    when there were no AV values for Bsort1 and Bsort2. Now it appears as an empty
    pull down instead.
    
    This is a bigger regression and could possibly cause data loss if records are
    saved where Sort 1 and Sort 2 have been filled.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 11:45:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 09:45:13 +0000
    Subject: [Koha-bugs] [Bug 30602] Street type on patron form showing although
     no ROADTYPE entries exist
    In-Reply-To: <bug-30602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30602-70-IhjO2K8Y2e@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30602
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30603
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 11:45:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 09:45:13 +0000
    Subject: [Koha-bugs] [Bug 30603] Sort 1 and Sort 2 on patron form are on
     longer free text when AV categories are empty
    In-Reply-To: <bug-30603-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30603-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30603-70-BK8soF7GbJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30603
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30602
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 11:52:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 09:52:26 +0000
    Subject: [Koha-bugs] [Bug 22531] Allow for multiple requests to partners and
     display partners in audit log
    In-Reply-To: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22531-70-TLjFmYRbuy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 11:52:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 09:52:31 +0000
    Subject: [Koha-bugs] [Bug 22531] Allow for multiple requests to partners and
     display partners in audit log
    In-Reply-To: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22531-70-5KUUzUvYr9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131234|0                           |1
            is obsolete|                            |
    
    --- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133708
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133708&action=edit
    Bug 22531: Add logging & display of req partners
    
    This patch adds:
    
    - The ability to send request to partners multiple times.
    - Logging of requested partners
    - Display of requested partners in "ILL Request Log" display
    
    Signed-ff-by: Barry Cannon <bc at interleaf.ie>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 11:52:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 09:52:36 +0000
    Subject: [Koha-bugs] [Bug 22531] Allow for multiple requests to partners and
     display partners in audit log
    In-Reply-To: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22531-70-0grCGphw4t@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131235|0                           |1
            is obsolete|                            |
    
    --- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133709
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133709&action=edit
    Bug 22531: Add unit tests
    
    Add tests for new and modified methods
    
    Signed-off-by: Barry Cannon <bc at interleaf.ie>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 11:52:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 09:52:41 +0000
    Subject: [Koha-bugs] [Bug 22531] Allow for multiple requests to partners and
     display partners in audit log
    In-Reply-To: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22531-70-eK28eJPIWp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131236|0                           |1
            is obsolete|                            |
    
    --- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133710
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133710&action=edit
    Bug 22531: (QA follow-up) Fix filter and tab issues
    
    Correction to template filters and replace tabs with spaces in code to
    pass the QA script.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 11:52:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 09:52:46 +0000
    Subject: [Koha-bugs] [Bug 22531] Allow for multiple requests to partners and
     display partners in audit log
    In-Reply-To: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22531-70-72YwuV37C9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131237|0                           |1
            is obsolete|                            |
    
    --- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133711
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133711&action=edit
    Bug 22531: (QA follow-up) Fix Unit Tests
    
    This patch series adds the ability to generate a partners request
    multiple times from the same ILL request. It does this be adding the
    'GENREQ' action to both 'prev_actions' and 'next_actions' in the
    'GENREQ' status segment of the status graph.
    
    This QA followup updates the status graph tests to reflect this change.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 11:56:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 09:56:29 +0000
    Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
    In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20447-70-KaKXfywEY6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Patch doesn't apply
    
    --- Comment #650 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    At the moment this patch set doesn't apply, but it might make sense to wait
    with the rebase until 22.05 is out the door and then make a focused effort. 
    
    Unfortunately we only have a week now until soft feature freeze and I feel this
    would be too huge to get tested well in this timeframe :(
    
    Applying: Bug 20447: MARC Holdings support
    Using index info to reconstruct a base tree...
    M       C4/Biblio.pm
    M       C4/ImportBatch.pm
    M       C4/Items.pm
    M       C4/Search.pm
    M       C4/XSLT.pm
    M       Koha/Biblio.pm
    M       Koha/Item.pm
    M       catalogue/detail.pl
    M       cataloguing/additem.pl
    M       installer/data/mysql/kohastructure.sql
    M       installer/data/mysql/mandatory/auth_val_cat.sql
    M       installer/data/mysql/mandatory/sysprefs.sql
    M       koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
    M       koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
    M       koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt
    M       koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
    M       koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
    M       koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
    M       koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt
    M       koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl
    M       t/db_dependent/Koha/Biblio.t
    M       t/db_dependent/Koha/Item.t
    M       t/lib/TestBuilder.pm
    M       tools/stage-marc-import.pl
    Falling back to patching base and 3-way merge...
    Auto-merging tools/stage-marc-import.pl
    Auto-merging t/lib/TestBuilder.pm
    Auto-merging t/db_dependent/Koha/Item.t
    Auto-merging t/db_dependent/Koha/Biblio.t
    Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl
    Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt
    Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
    Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
    Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
    CONFLICT (content): Merge conflict in
    koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
    Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt
    Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
    Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
    Auto-merging installer/data/mysql/mandatory/sysprefs.sql
    Auto-merging installer/data/mysql/mandatory/auth_val_cat.sql
    Auto-merging installer/data/mysql/kohastructure.sql
    Auto-merging cataloguing/additem.pl
    Auto-merging catalogue/detail.pl
    Auto-merging Koha/Item.pm
    Auto-merging Koha/Biblio.pm
    CONFLICT (content): Merge conflict in Koha/Biblio.pm
    Auto-merging C4/XSLT.pm
    Auto-merging C4/Search.pm
    Auto-merging C4/Items.pm
    Auto-merging C4/ImportBatch.pm
    Auto-merging C4/Biblio.pm
    error: Failed to merge in the changes.
    Patch failed at 0001 Bug 20447: MARC Holdings support
    hint: Use 'git am --show-current-patch=diff' to see the failed patch
    When you have resolved this problem run "git bz apply --continue".
    If you would prefer to skip this patch, instead run "git bz apply --skip".
    To restore the original branch and stop patching run "git bz apply --abort".
    Patch left in /tmp/Bug-20447-MARC-Holdings-support-BYfeaD.patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 12:51:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 10:51:33 +0000
    Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when
     adding on order item to existing record
    In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20817-70-zTMGTh7ShY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Failed QA
    
    --- Comment #104 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    I am sorry, but I need a more detailed test plan. I am not sure what I am
    looking for here as I have never really used the stage feature much.
    
    Provided test plan:
    
    1) Choose an existing record from "Add order to basket" area either searching a
    record or clicking "From a staged file" section
    2) After you reach "New order" page for existing record you will see new
    fieldset called "Existing items" which are existing items belong to a record
    not previously ordered
    3) When you choose item(s) from this new tab fields of "Accounting details" tab
    will be automatically filled
    4) When you finished click save button.
    
    
    What I have tried:
    
    * Exported "Intermediate Perl" from sample database
      http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=12
    * Add to basket > From a new file
    * Imported my record
    * When I look at the MARC view, I can see the 952
    
    Next I tried:
    
    * Add to basket > From existing record
    * Searched for "Intermediate Perl"
    * Picked it for my order
    
    Each time, there was no "Existing items" section on the form.
    
    ... and now I am stuck.
    
    How do I need to set up the system preferences?
    What is the behavior I should see?
    
    My basket was set to create items on order.
    
    
    Note: We should at least write up a follow-up bug to change the new methods to
    snake case.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 12:58:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 10:58:17 +0000
    Subject: [Koha-bugs] [Bug 29623] Cache circulation rules
    In-Reply-To: <bug-29623-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29623-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29623-70-MznHtyMOdE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
    
    --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Could I get a test plan for this please?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 13:00:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 11:00:49 +0000
    Subject: [Koha-bugs] [Bug 29623] Cache circulation rules
    In-Reply-To: <bug-29623-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29623-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29623-70-gSPwXYCqvo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Patch doesn't apply
    
    --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Also, patch doesn't apply on top of dependency patch:
    
    128576 - Bug 29623: Cache circulation rules
    
    Apply? [(y)es, (n)o, (i)nteractive] y
    Applying: Bug 29623: Cache circulation rules
    error: sha1 information is lacking or useless (C4/Circulation.pm).
    error: could not build fake ancestor
    Patch failed at 0001 Bug 29623: Cache circulation rules
    hint: Use 'git am --show-current-patch=diff' to see the failed patch
    When you have resolved this problem run "git bz apply --continue".
    If you would prefer to skip this patch, instead run "git bz apply --skip".
    To restore the original branch and stop patching run "git bz apply --abort".
    Patch left in /tmp/Bug-29623-Cache-circulation-rules-SDQmaq.patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 13:25:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 11:25:07 +0000
    Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired
     waiting holds to fill the next hold
    In-Reply-To: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14364-70-KEDs1QkYgb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Failed QA
    
    --- Comment #58 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    1) Capitalization
    
    It's all good, but in the database update statement:
    
    Canceled Hold Available for Different Patron', '0', 'Canceled Hold Available
    for Different Patron', 'The patron picking up <<biblio.title>>
    (<<items.barcode>>) has changed to <<borrowers.firstname>>
    <<borrowers.surname>> (<<borrowers.cardnumber
    
    2) Spelling
    
    Should this be reply-to address?
    
    +            - . If no address is defined here, the email will be sent to the
    library's reply to address.
    
    
    2) Tests are failing :(
    
    prove t/db_dependent/Holds/ExpireReservesAutoFill.t
    t/db_dependent/Holds/ExpireReservesAutoFill.t .. 1/3     # No tests run!
    t/db_dependent/Holds/ExpireReservesAutoFill.t .. 2/3 
    #   Failed test 'No tests run for subtest "Test automatically canceled expired
    waiting holds to fill the next hold, without a transfer"'
    #   at t/db_dependent/Holds/ExpireReservesAutoFill.t line 131.
    Undefined subroutine &main::CancelExpiredReserves called at
    t/db_dependent/Holds/ExpireReservesAutoFill.t line 101.
    # Looks like your test exited with 11 just after 2.
    t/db_dependent/Holds/ExpireReservesAutoFill.t .. Dubious, test returned 11
    (wstat 2816, 0xb00)
    Failed 2/3 subtests 
    
    Test Summary Report
    -------------------
    t/db_dependent/Holds/ExpireReservesAutoFill.t (Wstat: 2816 Tests: 2 Failed: 1)
      Failed test:  2
      Non-zero exit status: 11
      Parse errors: Bad plan.  You planned 3 tests but ran 2.
    Files=1, Tests=2,  3 wallclock secs ( 0.03 usr  0.00 sys +  2.66 cusr  0.30
    csys =  2.99 CPU)
    Result: FAIL
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 13:35:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 11:35:54 +0000
    Subject: [Koha-bugs] [Bug 30031] Add lists to table settings
    In-Reply-To: <bug-30031-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30031-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30031-70-OJFsYOfIzT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Failed QA
    
    --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    1) Setting columns on the page
    
    This part of the test plan doesn't work for me, as there is no "Columns"
    button:
    
    6. Go to the view of your list (
    /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 )
    7. Make sure you can hide the columns properly. ( The checkbox and Title
    columns should not be hidable )
    
    Can you please have a look?
    
    
    2) Configuration
    
    I believe as Lists appears as it's own module, we should also have it's own
    section for it on administration > table configuration. What do you think?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 13:38:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 11:38:28 +0000
    Subject: [Koha-bugs] [Bug 29926] Add ability for superlibrarians to edit
     password expiration dates
    In-Reply-To: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29926-70-MsrUvbh8oM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29926
    
    --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    The patch currently doesn't apply, can you please fix?
    
    Apply? [(y)es, (n)o, (i)nteractive] y
    Applying: Bug 29926: Add pasword expiration route for API
    Using index info to reconstruct a base tree...
    A       api/v1/swagger/paths.yaml
    Falling back to patching base and 3-way merge...
    CONFLICT (modify/delete): api/v1/swagger/paths.yaml deleted in HEAD and
    modified in Bug 29926: Add pasword expiration route for API. Version Bug 29926:
    Add pasword expiration route for API of api/v1/swagger/paths.yaml left in tree.
    error: Failed to merge in the changes.
    Patch failed at 0001 Bug 29926: Add pasword expiration route for API
    hint: Use 'git am --show-current-patch=diff' to see the failed patch
    When you have resolved this problem run "git bz apply --continue".
    If you would prefer to skip this patch, instead run "git bz apply --skip".
    To restore the original branch and stop patching run "git bz apply --abort".
    Patch left in /tmp/Bug-29926-Add-pasword-expiration-route-for-API-QJheMn.patch
    
    
    Wondering: This is kind of an "undocumented" extra for the superlibrarians,
    that is not covered by any of the permissions. How can we document or should
    this not better be a new permission?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 13:38:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 11:38:41 +0000
    Subject: [Koha-bugs] [Bug 29926] Add ability for superlibrarians to edit
     password expiration dates
    In-Reply-To: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29926-70-AjI8ZHKNqz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29926
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Patch doesn't apply
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 13:40:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 11:40:31 +0000
    Subject: [Koha-bugs] [Bug 29887] Create system preference
     IndependentBranchesLoggedInLibrary
    In-Reply-To: <bug-29887-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29887-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29887-70-hcMVfPSgbK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |BLOCKED
    
    --- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    This is currently BLOCKED by the depenency requiring sign-off.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 13:45:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 11:45:31 +0000
    Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on
     fresh install, but can be null with upgrade
    In-Reply-To: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27253-70-vZQxar7Sdx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253
    
    --- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Katrin Fischer from comment #14)
    > Hi,
    > 
    > we recently had some issues with updated timestamps on updates. Can you
    > confirm that this will only change records where the updated_on was NULL
    > before?
    
    +            WHERE updated_on IS NULL
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 13:54:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 11:54:33 +0000
    Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on
     fresh install, but can be null with upgrade
    In-Reply-To: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27253-70-buO5k30PVj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253
    
    --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Reading helps - thx Marcel.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 13:57:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 11:57:41 +0000
    Subject: [Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on
     display
    In-Reply-To: <bug-27943-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27943-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27943-70-CXh9MEQzDP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943
    
    --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133712
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133712&action=edit
    Bug 27943: (QA follow-up) Add missing TT filters
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 14:00:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 12:00:59 +0000
    Subject: [Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on
     display
    In-Reply-To: <bug-27943-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27943-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27943-70-lx9vexg0lU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Failed QA
    
    --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    I have added a follow-up to fix the missing TT filters, but there are 2 issues
    that are a bit more than QA can fix:
    
    1) Tests are failing
    
    Changes to any core routines in C4 and Koha need to be accompanied by unit
    tests per the coding guidelines, but there is a little more here as the
    existing tests fail with the patches applied:
    
    prove t/db_dependent/AuthoritiesMarc.t
    
    t/db_dependent/AuthoritiesMarc.t .. 2/12 
    #   Failed test 'test BuildSummary for MARC21'
    #   at t/db_dependent/AuthoritiesMarc.t line 158.
    #     Structures begin differing at:
    #          $got->{equalterm} = ARRAY(0x563fe77a47f0)
    #     $expected->{equalterm} = Does not exist
    
    #   Failed test 'test BuildSummary for UNIMARC'
    #   at t/db_dependent/AuthoritiesMarc.t line 202.
    #     Structures begin differing at:
    #          $got->{equalterm} = ARRAY(0x563fe36e6b00)
    #     $expected->{equalterm} = Does not exist
    Cannot determine authority type for record: 1710 at
    /kohadevbox/koha/Koha/SearchEngine/Elasticsearch.pm line 566.
    t/db_dependent/AuthoritiesMarc.t .. 12/12 # Looks like you failed 2 tests of
    12.
    t/db_dependent/AuthoritiesMarc.t .. Dubious, test returned 2 (wstat 512, 0x200)
    Failed 2/12 subtests 
    
    Test Summary Report
    -------------------
    t/db_dependent/AuthoritiesMarc.t (Wstat: 512 Tests: 12 Failed: 2)
      Failed tests:  6, 8
      Non-zero exit status: 2
    
    
    2) Hardcode delimiter
    
    This hardcodes the delimiter for subheadings to "--", but I believe it should
    be using the system preference AuthoritySeparator instead.
    
    
    Please let us know if you need help in fixing those.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 14:01:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 12:01:41 +0000
    Subject: [Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on
     display
    In-Reply-To: <bug-27943-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27943-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27943-70-D7h1aPq9SS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943
    
    --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    My testing record had 2 700 fields, as the field is repeatable. It works nicely
    for display.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 14:31:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 12:31:11 +0000
    Subject: [Koha-bugs] [Bug 28840] Better texts in batch record
     modification/deletion
    In-Reply-To: <bug-28840-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28840-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28840-70-tSkuTFFY8k@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 14:31:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 12:31:16 +0000
    Subject: [Koha-bugs] [Bug 28840] Better texts in batch record
     modification/deletion
    In-Reply-To: <bug-28840-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28840-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28840-70-zHZTfzwPi7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131781|0                           |1
            is obsolete|                            |
    
    --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133713
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133713&action=edit
    Bug 28840: Better texts in batch record modification/deletion
    
    Tools batch record modification/deletion form contains texts in legends,
    labels, hints.
    
    I feel like :
    Labels are sometimes too long, showing them on multi-lines, like "Modify record
    using the following template". Long texts should be in legend or hint.
    Legend are sometimes contains redundant text, like in tabs.
    Also I propose to use "record id" instead of "record number".
    
    Test plan :
    Compare texts in page without and with patch
    
    Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 14:31:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 12:31:21 +0000
    Subject: [Koha-bugs] [Bug 28840] Better texts in batch record
     modification/deletion
    In-Reply-To: <bug-28840-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28840-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28840-70-ignYNSd2eD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840
    
    --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133714
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133714&action=edit
    Bug 28840: (QA follow-up) Update id to ID
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 14:31:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 12:31:51 +0000
    Subject: [Koha-bugs] [Bug 28840] Better texts in batch record
     modification/deletion
    In-Reply-To: <bug-28840-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28840-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28840-70-HZ1iSlQgOZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840
    
    --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    (In reply to Katrin Fischer from comment #9)
    > I believe it should probably be IDs instead of ids? The internet suggests
    > so, but maybe we could still have a native speaker weigh in?
    > 
    > Example:
    > <li><a href="#enterlist_tab">Enter a list of record ids</a></li>
    
    I didn't get a reply, so I have decided to provide a follow-up patch for
    consideration.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 14:36:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 12:36:05 +0000
    Subject: [Koha-bugs] [Bug 30424] Reindent advanced search template in the
     staff interface
    In-Reply-To: <bug-30424-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30424-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30424-70-ZZvyKFP7KT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30424
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 14:36:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 12:36:09 +0000
    Subject: [Koha-bugs] [Bug 30424] Reindent advanced search template in the
     staff interface
    In-Reply-To: <bug-30424-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30424-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30424-70-qMylqPkPiO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30424
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132939|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133715
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133715&action=edit
    Bug 30424: Reindent advanced search template in the staff interface
    
    This patch reindents the advanced search template. Some lines have been
    split to make the markup more readable.
    
    To test, apply the patch and test the advanced search page in the staff
    interface. Everything should work as normal. Be sure to test both the
    "More options" and "Fewer options" views.
    
    When viewing the diff for this change, ignore whitespace. The only
    visible changes should be split lines.
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 14:36:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 12:36:13 +0000
    Subject: [Koha-bugs] [Bug 30424] Reindent advanced search template in the
     staff interface
    In-Reply-To: <bug-30424-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30424-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30424-70-8u7fPQ0czs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30424
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132940|0                           |1
            is obsolete|                            |
    
    --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133716
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133716&action=edit
    Bug 30424: (follow-up) Markup comments
    
    This patch adds comments to the template to highlight the markup
    structure.
    
    This patch should have no effect on the page's appearance or
    functionality.
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 14:46:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 12:46:02 +0000
    Subject: [Koha-bugs] [Bug 22276] Add client storage of user-selected
     DataTables configuration
    In-Reply-To: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22276-70-48WkjAp5C0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 14:46:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 12:46:06 +0000
    Subject: [Koha-bugs] [Bug 22276] Add client storage of user-selected
     DataTables configuration
    In-Reply-To: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22276-70-1xi29KOdUD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #130548|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133717
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133717&action=edit
    Bug 22276: Add client storage of user-selected DataTables configuration
    
    This patch enables use of DataTables' built-in session storage of table
    configurations. DataTables by default uses the browser's localstorage
    feature to store the state of each DataTable, including which columns
    have been hidden by the user.
    
    Our table settings system has always overridden this saved state. This
    patch adds a check for a saved configuration state and if present loads
    the saved state instead of the default state.
    
    The system is enabled in this patch on the libraries administration
    page. To test, apply the patch and open go to Administration ->
    Libraries.
    
    - Use the "Columns" button to change the visibility setting of multiple
      columns.
    - Navigate away from the page and then back to test that the visibility
      settings have been kept.
    - Go to Administration -> Table settings -> Administration and change
      the visibility settings for the "libraries" table in a way that it
      differs from the visibility settings you set manually.
    - Return to the libraries administration page and confirm that your
      manual settings are still being loaded instead of the defaults from
      table settings.
    
    Signed-off-by: Solène Desvaux <solene.desvaux at biblibre.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 14:46:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 12:46:11 +0000
    Subject: [Koha-bugs] [Bug 22276] Add client storage of user-selected
     DataTables configuration
    In-Reply-To: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22276-70-jVIk8VpstY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276
    
    --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133718
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133718&action=edit
    Bug 22276: (QA follow-up) Add missing USE
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 14:59:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 12:59:48 +0000
    Subject: [Koha-bugs] [Bug 22276] Add client storage of user-selected
     DataTables configuration
    In-Reply-To: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22276-70-KW7z9Y1QEp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276
    
    --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    I've added a follow-up to fix a complaint by the QA script. 
    
    I think I agree with Kyle here - I like that this seems to work really nicely
    and is not a big change.
    
    I'd still like even more permanent storage, but this here would already be very
    useful and doesn't seem not too risky at this point in the release cycle. 
    
    If we can extend it even further as a next step, that would be great too.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 15:16:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 13:16:55 +0000
    Subject: [Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display
    In-Reply-To: <bug-28371-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28371-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28371-70-nHmkzc3Shq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 15:17:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 13:17:00 +0000
    Subject: [Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display
    In-Reply-To: <bug-28371-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28371-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28371-70-vAOOvmlmG3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132943|0                           |1
            is obsolete|                            |
    
    --- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133719
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133719&action=edit
    Bug 28371: Unit tests
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 15:17:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 13:17:05 +0000
    Subject: [Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display
    In-Reply-To: <bug-28371-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28371-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28371-70-IkEzhnAKir@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132944|0                           |1
            is obsolete|                            |
    
    --- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133720
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133720&action=edit
    Bug 28371: Passpreviously fetched branches and itemtypes through and fetch all
    needed AV at once
    
    This patch updates the searchResuls code to pass through the pre-constructed
    branches and itemtype lookups
    to XSLTParse4Display to avoid repeating this
    
    It also updates getAuthorisedValues4MARCSubfields to fetch the values for
    mapped subfields and pass
    then through to transforMarc4XSLT
    
    Note that we currently blank invalid branches and itemtypes - I presrve this,
    we should open another bug
    if we want to change this behaviour
    
    Changes are covered by tests
    
    To test:
    1 - Perform searches in OPAC and staff client that return many records
    2 - Use the 'Network' tab on the browser console (opened with F12 usually) to
    see the time taken
    3 - Note the speed before the patch
    4 - Apply patch
    5 - restart all the things
    6 - Note improvement in speed
    
    **Note: The improvement is more drastic the more items per record, try adding
    large numbers of items to your search results to test**
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 16:29:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 14:29:35 +0000
    Subject: [Koha-bugs] [Bug 30508] Do not display OPAC message about block
     from holds when OPACHoldRequests is disabled
    In-Reply-To: <bug-30508-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30508-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30508-70-pjxWBYHns5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508
    
    Amit Gupta <amitddng135 at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133308|0                           |1
            is obsolete|                            |
                     CC|                            |amitddng135 at gmail.com
    
    --- Comment #3 from Amit Gupta <amitddng135 at gmail.com> ---
    Created attachment 133721
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133721&action=edit
    Bug 30508: Do not display OPAC message about block from holds  when
    OPACHoldRequests is disabled
    
    To test, apply the patch and set the "maxoutstanding" system preference
    to a low value. Set OPACHoldRequests to "Allow."
    
    - Log in to the OPAC as a patron who has outstanding fines or charges
      which exceed the maxoutstanding value you set.
    - You should see a message on the "Your summary" page, "Holds are
      blocked because your fine balance is over the limit."
    - Set OPACHoldRequests to "Don't allow" and refresh the "Your summary"
      page in the OPAC. The message should disappear.
    
    Works OK!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 16:29:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 14:29:52 +0000
    Subject: [Koha-bugs] [Bug 30508] Do not display OPAC message about block
     from holds when OPACHoldRequests is disabled
    In-Reply-To: <bug-30508-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30508-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30508-70-VcYPmn2aU3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508
    
    Amit Gupta <amitddng135 at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 16:32:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 14:32:24 +0000
    Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase
     suggestions (using an Ajax-request)
    In-Reply-To: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14242-70-G2qLs05iz4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242
    
    Amit Gupta <amitddng135 at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |amit.gupta at informaticsgloba
                       |                            |l.com,
                       |                            |amitddng135 at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 16:34:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 14:34:40 +0000
    Subject: [Koha-bugs] [Bug 20119] Ability to print claims for late orders
    In-Reply-To: <bug-20119-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20119-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20119-70-o69AMmnH7O@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119
    
    Amit Gupta <amitddng135 at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |amit.gupta at informaticsgloba
                       |                            |l.com,
                       |                            |amitddng135 at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 19:24:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 17:24:03 +0000
    Subject: [Koha-bugs] [Bug 30508] Do not display OPAC message about block
     from holds when OPACHoldRequests is disabled
    In-Reply-To: <bug-30508-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30508-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30508-70-wUwnDUn6Gv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133721|application/mbox            |text/plain
              mime type|                            |
     Attachment #133721|0                           |1
               is patch|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 19:27:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 17:27:46 +0000
    Subject: [Koha-bugs] [Bug 30508] Do not display OPAC message about block
     from holds when OPACHoldRequests is disabled
    In-Reply-To: <bug-30508-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30508-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30508-70-CliIoSI4KI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508
    
    --- Comment #4 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Created attachment 133722
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133722&action=edit
    Bug 30508: Do not display OPAC message about block from holds when
    OPACHoldRequests is disabled
    
    This patch adds a check for the OPACHoldRequests to determine whether a
    message should be shown to patrons whose account is over the
    maxoutstanding limit.
    
    To test, apply the patch and set the "maxoutstanding" system preference
    to a low value. Set OPACHoldRequests to "Allow."
    
    - Log in to the OPAC as a patron who has outstanding fines or charges
      which exceed the maxoutstanding value you set.
    - You should see a message on the "Your summary" page, "Holds are
      blocked because your fine balance is over the limit."
    - Set OPACHoldRequests to "Don't allow" and refresh the "Your summary"
      page in the OPAC. The message should disappear.
    
    Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 19:37:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 17:37:00 +0000
    Subject: [Koha-bugs] [Bug 30508] Do not display OPAC message about block
     from holds when OPACHoldRequests is disabled
    In-Reply-To: <bug-30508-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30508-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30508-70-FB3mPBVcn9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |victor at tuxayo.net
    
    --- Comment #5 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Thanks for testing Amit :) . For some reason when attaching the patch it hasn't
    been marked as a patch.
    And don't forget to add your signoff line to the patch with:
    git format-patch -s origin/master
    
    Here has been attached a version of the patch with your signoff added (assuming
    you want to use the same email address as in Bugzilla)
    
    Wait, it's not the same email address as the one I tried to attach!
    So there has been something else weird with the patch attachment. Comment 3
    doesn't show the signoff line but it was there and resurfaced when I attached
    the patch.
    (Also for some reason, my attempt to add a SO line with a custom name and email
    didn't work)
    
    Anyway, what is your procedure to attach a patch here?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 20:45:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 18:45:39 +0000
    Subject: [Koha-bugs] [Bug 22531] Allow for multiple requests to partners and
     display partners in audit log
    In-Reply-To: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22531-70-L5ljptVDqo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531
    
    --- Comment #24 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    I like the idea. Isn't this a bit hacky?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sun Apr 24 22:56:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sun, 24 Apr 2022 20:56:14 +0000
    Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
     too
    In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28269-70-6QKiHXLwpX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269
    
    Andrew Nugged <nugged at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |nugged at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 03:54:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 01:54:28 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-eTOjJx19NS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #55 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
    Created attachment 133723
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133723&action=edit
    Bug 30373: (followup) Enable 'qualif' authorised_value
    
    This patch reinstates the authorised value 'qualif'
    to it's corresponding place
    
    This authorized value is used in UNIMARC default bibliographic
    framework.
    
    To test:
    1) Do a clean install or load the YAML file
    2) Verify 'qualif' authorised_value is present in subfield $4 of
       fields 700/1/2/3, 710/1/2/3, 720/1/2/3 and 730
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 04:32:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 02:32:29 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-ZVFj0ifRpk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    --- Comment #56 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
    Created attachment 133724
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133724&action=edit
    Bug 30373: (followup) Add BNF z3950 server
    
    This is not strictly necessary, but is useful to do the testing
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 08:50:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 06:50:54 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-Ovg5mpTMNE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Passed QA
    
    --- Comment #80 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    OK, so the tests do pass.. However, you need to have the encryption_key config
    variable set.
    
    We can't easily set this using our Mock libs, as it won't work with the
    selenium tests.. so I think the solution is to just ensure k-t-d has that
    variable always set.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 08:51:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 06:51:12 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-ANkNf5rS7N@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |mtj at kohaaloha.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 09:00:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 07:00:48 +0000
    Subject: [Koha-bugs] [Bug 29835] 2FA - ask for the users password when the
     choose to disable 2FA
    In-Reply-To: <bug-29835-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29835-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29835-70-1FX0Giq6SB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29835
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|2FA - ask for the password  |2FA - ask for the users
                       |when 2FA is disabled        |password when the choose to
                       |                            |disable 2FA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 09:05:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 07:05:42 +0000
    Subject: [Koha-bugs] [Bug 29768] hidepatronname hides guarantor name on
     borrower edit screen
    In-Reply-To: <bug-29768-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29768-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29768-70-GT3M6eu0CO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768
    
    Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133542|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
    Created attachment 133725
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133725&action=edit
    Bug 29768: Do not hide guarantor name from memberentry.pl
    
    Syspref "hidepatronname" currently hides guarantors name on memberentry.pl. 
    This is inconsistent since name isn't hidden e.g. on moremember.pl and staff
    can already see patrons other personal information during edit.
    
    To test:
    1) Disable syspref "hidepatronname"
    2) Edit guarantee patrons information
    => Field "Guarantor" only shows guarantors cardnumber (or
    is empty if guarantor has no cardnumber)
    3) Apply patch
    => Guarantors name is now displayed (as a hyperlink)
    
    Also confirm  hidepatronname still works as expected
    on other pages (holds table, items detail page etc.).
    
    Sponsored-by: Koha-Suomi Oy
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 10:13:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 08:13:25 +0000
    Subject: [Koha-bugs] [Bug 22531] Allow for multiple requests to partners and
     display partners in audit log
    In-Reply-To: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22531-70-AVgCMxNLzq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531
    
    --- Comment #25 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
    (In reply to Tomás Cohen Arazi from comment #24)
    > I like the idea. Isn't this a bit hacky?
    
    Possibly, as I noted in the patch, I wasn't 100% happy with the solution. I
    can't remember any of the thought processes involved when I did it, it was
    written over three years ago, but I'm sure the decisions I made were made for
    good reasons.
    
    I'm not inclined to revisit it now, it has been in use by multiple customers
    over the past three years with no issues. It would be really nice to see it
    finally merged after all this time.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 10:46:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 08:46:14 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-ydlMAzZex9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    --- Comment #64 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Also interesting in testing this once rebased :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 10:46:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 08:46:58 +0000
    Subject: [Koha-bugs] [Bug 29835] 2FA - ask for the users password when they
     choose to disable 2FA
    In-Reply-To: <bug-29835-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29835-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29835-70-BJCO3RIjks@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29835
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|2FA - ask for the users     |2FA - ask for the users
                       |password when the choose to |password when they choose
                       |disable 2FA                 |to disable 2FA
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 10:59:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 08:59:09 +0000
    Subject: [Koha-bugs] [Bug 30510] Add a Patron reason column to the
     suggestion tables on suggestion.tt
    In-Reply-To: <bug-30510-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30510-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30510-70-4hZSxXZuij@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30510
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 10:59:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 08:59:14 +0000
    Subject: [Koha-bugs] [Bug 30510] Add a Patron reason column to the
     suggestion tables on suggestion.tt
    In-Reply-To: <bug-30510-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30510-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30510-70-9e0xILPSUu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30510
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133406|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133726
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133726&action=edit
    Bug 30510: Add Patron reason column to suggestion tables
    
    To test:
    1. Make some patron reasons for suggestion via Home > Administration >
    Authorized values > OPAC_SUG
    2. Give those reasons a description.
    3. Make several suggestions via staff client and/or OPAC and apply some of the
    reasons you just made
    4. Apply patch
    5. Go to Home > Acquistions > Suggestions management
    6. Give some of the suggestions some different status
    (PENDING/REJECTED/ACCEPTED/ect)
    7. Make sure on each of the tables you can see the column 'Patron reason'
    8. Go to Administration > Table settings and attempt to hide the column.
    9. Confirm that the column is properly hidden on the Suggestions management
    page
    
    Signed-off-by: Rhonda Kuiper <rkuiper at roundrocktexas.gov>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 10:59:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 08:59:38 +0000
    Subject: [Koha-bugs] [Bug 30510] Add a Patron reason column to the
     suggestion table in the staff interface
    In-Reply-To: <bug-30510-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30510-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30510-70-SmjNVnVFIL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30510
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Add a Patron reason column  |Add a Patron reason column
                       |to the suggestion tables on |to the suggestion table in
                       |suggestion.tt               |the staff interface
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 11:00:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 09:00:27 +0000
    Subject: [Koha-bugs] [Bug 30510] Add a Patron reason column to the
     suggestion table in the staff interface
    In-Reply-To: <bug-30510-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30510-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30510-70-FcSoOZVUP0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30510
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
      Text to go in the|                            |This adds the patron reason
          release notes|                            |for a suggestion to the
                       |                            |suggestions summary table
                       |                            |in the staff interface.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 11:22:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 09:22:38 +0000
    Subject: [Koha-bugs] [Bug 30604] New: Add value builders for UNIMARC 146 ($a,
     $h and $i)
    Message-ID: <bug-30604-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30604
    
                Bug ID: 30604
               Summary: Add value builders for UNIMARC 146 ($a, $h and $i)
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: enhancement
              Priority: P5 - low
             Component: Cataloging
              Assignee: julian.maurice at biblibre.com
              Reporter: julian.maurice at biblibre.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: m.de.rooy at rijksmuseum.nl
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 11:27:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 09:27:05 +0000
    Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their
     patron messages
    In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-12029-70-QEUAKFRTxR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Failed QA
    
    --- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Hi Hayley and all, 
    
    trying to give this another push forward.
    
    1) Unit tests (blocker)
    We are still missing the unit tests. Is there any update on that?
    
    2) Database update
    The database update is still a bit too verbose, as noted earlier, using some
    uncommon output pattern (ALTERATION, NOTICE and INFO are not needed). We said
    RM could deal with it, so just explaining a bit more what people meant earlier
    on:
    
    +use Modern::Perl;
    +
    +return {
    +    bug_number => "12029",
    +    description => "Enable patrons to delete messages",
    +    up => sub {
    +        my ($args) = @_;
    +        my ($dbh, $out) = @$args{qw(dbh out)};
    +
    +        # Do you stuffs here
    +        my $alteration = q{
    +            ALTER TABLE messages
    +            ADD COLUMN `patron_read_date` timestamp NULL DEFAULT NULL
    +            COMMENT 'date and time patron dismissed message'
    +            AFTER `manager_id`
    +        };
    +        if( column_exists('messages', 'patron_read_date') ) {
    +            say $out "NOTICE: Column 'messages.patron_read_date' already
    exists";
    +        }
    +        else {
    +            say $out "ALTERATION: $alteration";
    +            $dbh->do($alteration);
    +        }
    +
    +        # Print useful stuff here
    +        say $out "INFO: Bug 12029 migration applied";
    +    },
    +};
    
    3) Translatability
    
    There is some code in opac/dismiss_message.pl that I wondered about. It
    contains messages that are not translatable, but I am not sure yet if this
    would show to patrons, in my tests it didn't seem like it.
    
    comment => "Patron read date already set",
    comment => "Set patron_read_date to ($patron_read_date)",
    
    Hm, they might not be used after all?
    
    >11. What are you doing with $result? $inputs and comment are returned from the dismiss_patron_message sub but never >reused. This script could be 10 lines long IMO.
    
    
    Failing for 1). Testing in the GUI worked well!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 11:33:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 09:33:31 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-Lp2gpwMaTJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Patch doesn't apply
    
    --- Comment #118 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    (In reply to Jonathan Druart from comment #117)
    > QA please? This is a nightmare to rebase!
    
    Sorry to be late :(
    
    Apply? [(y)es, (n)o, (i)nteractive] y
    Applying: Bug 29648: Improve existing code
    Using index info to reconstruct a base tree...
    M       koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc
    M       koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
    M       koha-tmpl/intranet-tmpl/prog/en/modules/reports/orders_by_budget.tt
    Falling back to patching base and 3-way merge...
    Auto-merging
    koha-tmpl/intranet-tmpl/prog/en/modules/reports/orders_by_budget.tt
    Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
    CONFLICT (content): Merge conflict in
    koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
    Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc
    error: Failed to merge in the changes.
    Patch failed at 0001 Bug 29648: Improve existing code
    
    Could you please rebase? I'll try to get back to this ASAP after.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 11:42:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 09:42:28 +0000
    Subject: [Koha-bugs] [Bug 30604] Add value builders for UNIMARC 146 ($a,
     $h and $i)
    In-Reply-To: <bug-30604-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30604-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30604-70-IM6GHDjxnI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30604
    
    --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> ---
    Created attachment 133727
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133727&action=edit
    Bug 30604: Add value builders for UNIMARC 146 ($a, $h and $i)
    
    Test plan:
    1. Configure the default MARC framework to use those value builders:
       - unimarc_field_146a for 146$a
       - unimarc_field_146h for 146$h
       - unimarc_field_146i for 146$i
    2. Verify that they all work correctly according to
    https://www.ifla.org/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u-b_146.pdf
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 11:43:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 09:43:38 +0000
    Subject: [Koha-bugs] [Bug 30604] Add value builders for UNIMARC 146 ($a,
     $h and $i)
    In-Reply-To: <bug-30604-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30604-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30604-70-GsuXxVCypr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30604
    
    Julian Maurice <julian.maurice at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 12:01:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 10:01:48 +0000
    Subject: [Koha-bugs] [Bug 30136] Add back to top button when scrolling
    In-Reply-To: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30136-70-4mTZPpCuJk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |wainuiwitikapark at catalyst.n
                       |                            |et.nz
    
    --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    I wonder if we still need to improve accessibility here. 
    
    In my understanding aria-hidden="true" is usually used when we have text in
    addition to the FA icon and want the screen readers to ignore the icon.
    
    In this case, we have the FA icon _only_. There is no alt text or similar,
    nothing is shown when hovering over the icon. I feel like we should have kind
    of a textual fallback here.
    
    Does that make sense? Would really love to get some additional feedback -
    adding Owen and Wainui in hope of some insight!
    
    Functionality wise this works ok!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 12:02:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 10:02:28 +0000
    Subject: [Koha-bugs] [Bug 30136] Add back to top button when scrolling
    In-Reply-To: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30136-70-xYsWklpBtq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Failed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 12:18:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 10:18:25 +0000
    Subject: [Koha-bugs] [Bug 27123] Add messages to batch patrons modification
    In-Reply-To: <bug-27123-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27123-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27123-70-rBmos2JmgD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Patch doesn't apply
    
    --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    I am sorry, Jérémy, this no longer applies. I fixed the first conflict, but got
    stuck on the second:
    
    Applying: Bug 27123: Add messages to batch patrons modification
    Applying: Bug 27123: whitespaces deleted
    Applying: Bug 27123: Delete useless code
    error: sha1 information is lacking or useless
    (koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt).
    error: could not build fake ancestor
    Patch failed at 0001 Bug 27123: Delete useless code
    hint: Use 'git am --show-current-patch=diff' to see the failed patch
    When you have resolved this problem run "git bz apply --continue".
    If you would prefer to skip this patch, instead run "git bz apply --skip".
    To restore the original branch and stop patching run "git bz apply --abort".
    Patch left in /tmp/Bug-27123-Delete-useless-code-g_KXIH.patch
    
    Can you please rebase?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 12:21:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 10:21:32 +0000
    Subject: [Koha-bugs] [Bug 30191] Authority search result list in the OPAC
     should use 'record' instead of 'biblios'
    In-Reply-To: <bug-30191-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30191-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30191-70-t6613muxrk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30191
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 12:21:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 10:21:37 +0000
    Subject: [Koha-bugs] [Bug 30191] Authority search result list in the OPAC
     should use 'record' instead of 'biblios'
    In-Reply-To: <bug-30191-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30191-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30191-70-bVt5KVDFvo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30191
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133418|0                           |1
            is obsolete|                            |
    
    --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133728
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133728&action=edit
    Bug 30191: Authority search result list in the OPAC should use 'record' instead
    of 'biblios'
    
    This patch updates the OPAC authority search results page so that it
    uses the term "record" instead of "biblio."
    
    The patch also changes how the template outputs the count of records so
    that it is correctly pluralized, e.g. "1 record" vs. "2 records."
    
    To test, apply the patch and perform an authority search in the OPAC.
    
    In the search results, confirm that the last table header reads
    "Records." The information in that column should be correct, using the
    word record or records.
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 12:26:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 10:26:44 +0000
    Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on
     fresh install, but can be null with upgrade
    In-Reply-To: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27253-70-iXCB8YQOu6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253
    
    --- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    MariaDB [koha_myclone]> update borrowers set updated_on=COALESCE( NULL,
    FROM_UNIXTIME(0) ) where borrowernumber=51;
    ERROR 1292 (22007): Incorrect datetime value: '1970-01-01 00:00:00' for column
    `koha_myclone`.`borrowers`.`updated_on` at row 1
    
    MariaDB [koha_myclone]> update borrowers set updated_on=COALESCE( NULL,
    FROM_UNIXTIME(1) ) where borrowernumber=51;
    Query OK, 1 row affected (0.008 sec)
    Rows matched: 1  Changed: 1  Warnings: 0
    
    So I would propose to switch to UNIXTIME(1).
    Note that I would consider this a bug in SQL.
    
    Will add a follow-up
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 12:29:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 10:29:27 +0000
    Subject: [Koha-bugs] [Bug 28840] Better texts in batch record
     modification/deletion
    In-Reply-To: <bug-28840-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28840-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28840-70-oee3vGjo5o@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133714|0                           |1
            is obsolete|                            |
    
    --- Comment #13 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133729
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133729&action=edit
    Bug 28840: (QA follow-up) Update id to ID
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 12:29:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 10:29:58 +0000
    Subject: [Koha-bugs] [Bug 28840] Better texts in batch record
     modification/deletion
    In-Reply-To: <bug-28840-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28840-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28840-70-uPhaPEHTxe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840
    
    --- Comment #14 from Owen Leonard <oleonard at myacpl.org> ---
    (In reply to Katrin Fischer from comment #12)
    > I didn't get a reply, so I have decided to provide a follow-up patch for
    > consideration.
    
    I agree with your change!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 12:31:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 10:31:43 +0000
    Subject: [Koha-bugs] [Bug 30290] Article requests: Specify TOC on AR notices
    In-Reply-To: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30290-70-9qJNVnfzWo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290
    
    --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133730
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133730&action=edit
    Bug 30290: (QA follow-up) Sample notices: Change phrasing to Yes/No
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 12:34:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 10:34:24 +0000
    Subject: [Koha-bugs] [Bug 28840] Better texts in batch record
     modification/deletion
    In-Reply-To: <bug-28840-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28840-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28840-70-eKj2nAgddB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840
    
    --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    (In reply to Owen Leonard from comment #14)
    > (In reply to Katrin Fischer from comment #12)
    > > I didn't get a reply, so I have decided to provide a follow-up patch for
    > > consideration.
    > 
    > I agree with your change!
    
    Thx for the feedback!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 12:39:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 10:39:22 +0000
    Subject: [Koha-bugs] [Bug 30290] Article requests: Specify TOC on AR notices
    In-Reply-To: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30290-70-L7IUOsJOKO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 12:39:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 10:39:27 +0000
    Subject: [Koha-bugs] [Bug 30290] Article requests: Specify TOC on AR notices
    In-Reply-To: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30290-70-Ul1zL0du4Z@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133468|0                           |1
            is obsolete|                            |
    
    --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133731
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133731&action=edit
    Bug 30290: Adjust sample_notices.yml
    
    Test plan:
    Run a new install. Check the AR notices.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 12:39:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 10:39:31 +0000
    Subject: [Koha-bugs] [Bug 30290] Article requests: Specify TOC on AR notices
    In-Reply-To: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30290-70-HcRbAo60wn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133469|0                           |1
            is obsolete|                            |
    
    --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133732
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133732&action=edit
    Bug 30290: Database revision for existing notices
    
    Note: It will be hard to update translated notices. If we cannot find
    the part 'Pages:' then the replace does not do anything.
    
    Test plan:
    Run db rev.
    Check an existing AR notice (English).
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 12:39:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 10:39:36 +0000
    Subject: [Koha-bugs] [Bug 30290] Article requests: Specify TOC on AR notices
    In-Reply-To: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30290-70-tZUdg2D3uJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133470|0                           |1
            is obsolete|                            |
    
    --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133733
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133733&action=edit
    Bug 30290: (follow-up) Add warning for translated notices
    
    Note: Problem is that we cannot know if default was translated
    or en contains the original notice. Actually this holds for
    the other languages too. So this is an educated guess without
    using the lang field.
    
    Test plan:
    Run db rev.
    Trigger the warning by replacing Pages by PPages in an AR notice.
    Run db rev again.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 12:39:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 10:39:40 +0000
    Subject: [Koha-bugs] [Bug 30290] Article requests: Specify TOC on AR notices
    In-Reply-To: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30290-70-HcaL1LwnGN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290
    
    --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133734
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133734&action=edit
    Bug 30290: (QA follow-up) Sample notices/database update: Change phrasing to
    Yes/No
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 12:40:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 10:40:39 +0000
    Subject: [Koha-bugs] [Bug 30290] Article requests: Specify TOC on AR notices
    In-Reply-To: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30290-70-e9S00dBDoZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133730|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 12:41:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 10:41:15 +0000
    Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on
     fresh install, but can be null with upgrade
    In-Reply-To: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27253-70-9T07Tg21bO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253
    
    --- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133735
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133735&action=edit
    Bug 27253: (follow-up) Fix UNIXTIME(0) in db_revs/211200037.pl
    
    MariaDB [koha_myclone]> update borrowers set updated_on=COALESCE( NULL,
    FROM_UNIXTIME(0) ) where borrowernumber=51;
    ERROR 1292 (22007): Incorrect datetime value: '1970-01-01 00:00:00' for column
    `koha_myclone`.`borrowers`.`updated_on` at row 1
    
    MariaDB [koha_myclone]> update borrowers set updated_on=COALESCE( NULL,
    FROM_UNIXTIME(1) ) where borrowernumber=51;
    Query OK, 1 row affected (0.008 sec)
    Rows matched: 1  Changed: 1  Warnings: 0
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Tested by switching updated_on to datetime. Remove NOT NULL, etc.
    Copied dbrev to atomicupdate folder.
    Resulted in:
        Updated all NULL values of borrowers.updated_on to GREATEST(date_renewed,
    dateenrolled, lastseen): 51 rows updated
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 12:41:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 10:41:42 +0000
    Subject: [Koha-bugs] [Bug 30290] Article requests: Specify TOC on AR notices
    In-Reply-To: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30290-70-3qPDStQeUz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290
    
    --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    (In reply to Tomás Cohen Arazi from comment #7)
    > I tested this and works as expected. My only doubt would be the wording. I'd
    > prefer to see:
    > 
    > Include TOC: yes/no
    > 
    > but no strongly attached to it.
    
    I had the same feeling so I povided a follow-up with this change.
    
    As we had been burnt on bug 29805 with old MySQL versions, I also verified that
    RLIKE and REGEXP are both ok to use:
    https://dev.mysql.com/doc/refman/5.7/en/regexp.html
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 12:42:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 10:42:19 +0000
    Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on
     fresh install, but can be null with upgrade
    In-Reply-To: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27253-70-kNGHCVYpZ0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |ASSIGNED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 12:42:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 10:42:46 +0000
    Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on
     fresh install, but can be null with upgrade
    In-Reply-To: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27253-70-B1jwYAMHXY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 12:42:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 10:42:59 +0000
    Subject: [Koha-bugs] [Bug 30290] Article requests: Add TOC information to AR
     notices
    In-Reply-To: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30290-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30290-70-UT2CHnBNjR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Article requests: Specify   |Article requests: Add TOC
                       |TOC on AR notices           |information to AR notices
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 12:43:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 10:43:52 +0000
    Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on
     fresh install, but can be null with upgrade
    In-Reply-To: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27253-70-cuhHvRbiM7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253
    
    --- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Fridolin Somers from comment #13)
    > May I revert ?
    
    Push the follow-up please.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 12:46:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 10:46:55 +0000
    Subject: [Koha-bugs] [Bug 30553] Add a count to the Files tab in the patron
     account
    In-Reply-To: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30553-70-KcPESJf5Vf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30553
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Add a count to borrower     |Add a count to the Files
                       |Files tab in patroninfo     |tab in the patron account
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 12:52:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 10:52:16 +0000
    Subject: [Koha-bugs] [Bug 30553] Add a count to the Files tab in the patron
     account
    In-Reply-To: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30553-70-WtfqSHwdZ6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30553
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Failed QA
    
    --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Hi Lucas,
    
    someone else might be able to help better here, but this leaves some question
    marks for me.
    
    1) We are missing unit tests for the new method.
    
    2) The new method is named filecount, but it doesn't appear to return an actual
    count, as then in the templates we have: patron.filecount.size
    
    I believe, either the name is not quite right or the return value should be the
    number.
    
    Maybe it should be patron_files instead?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:03:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:03:42 +0000
    Subject: [Koha-bugs] [Bug 28082] Add acquisitions toolbar to vendors on
     vendor search page
    In-Reply-To: <bug-28082-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28082-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28082-70-KLA847E2YS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28082
    
    --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    It feels a little bulky, but all works well. I like the new counts and I like
    that it could all be hidden with CSS just in case.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:03:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:03:53 +0000
    Subject: [Koha-bugs] [Bug 28082] Add acquisitions toolbar to vendors on
     vendor search page
    In-Reply-To: <bug-28082-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28082-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28082-70-uUofJY76pd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28082
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |release-notes-needed
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:04:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:04:21 +0000
    Subject: [Koha-bugs] [Bug 28082] Add acquisitions toolbar to vendors on
     vendor search page
    In-Reply-To: <bug-28082-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28082-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28082-70-WTjQGzD1fr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28082
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:04:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:04:26 +0000
    Subject: [Koha-bugs] [Bug 28082] Add acquisitions toolbar to vendors on
     vendor search page
    In-Reply-To: <bug-28082-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28082-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28082-70-BS4U8BbRip@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28082
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133517|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133736
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133736&action=edit
    Bug 28082: Add acquisitions toolbar to vendors on vendor search page
    
    This patch makes a number of changes to the vendor search/view template
    in order to make it work better in different contexts:
    
    - Add a vendor-specific toolbar under each vendor search result. This
      gives instant access to the options for a new basket, new contract,
      vendor edit, or to receive shipments. A delete button will appear if
      available.
    - Add a summary of the number of baskets and subscriptions. This helps
      the user know if there are closed baskets and whether an outstanding
      subscription might be blocking the option to delete. Each number is
      linked to the view of those entries.
    - Indicate whether a vendor is inactive. The vendor name appears in a
      different color when it is inactve and is labeled as such.
    
    To test, apply the patch and rebuild the staff interface CSS
    (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
    
    - To test you should have multiple vendors in your system, some active
      and some inactive. Add some baskets and subscriptions to one or more
      if necessary.
    - Go to Acquisitions and submit an empty vendor search to show all
      vendors.
    - Verify that the page looks correct and that all controls work as
      expected.
    - Open the basket view for a single vendor and compare the two views.
    
    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:06:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:06:21 +0000
    Subject: [Koha-bugs] [Bug 30136] Add back to top button when scrolling
    In-Reply-To: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30136-70-makZ1GN4Qo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:06:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:06:25 +0000
    Subject: [Koha-bugs] [Bug 30136] Add back to top button when scrolling
    In-Reply-To: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30136-70-gFRfAeQOAG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136
    
    --- Comment #12 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133737
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133737&action=edit
    Bug 30136: (follow-up) CSS and accessibility update
    
    This patch adds the new CSS to the global CSS file. Rebuild the OPAC CSS
    to test.
    
    The patch also moves the JavaScript for the button from opac-bottom.inc
    into global.js and adds accessibility labels to the generated markup.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:11:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:11:07 +0000
    Subject: [Koha-bugs] [Bug 30438] Add select all/clear buttons to invoices.tt
     open and closed tables
    In-Reply-To: <bug-30438-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30438-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30438-70-LvfDnQBUfY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30438
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:11:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:11:12 +0000
    Subject: [Koha-bugs] [Bug 30438] Add select all/clear buttons to invoices.tt
     open and closed tables
    In-Reply-To: <bug-30438-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30438-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30438-70-HP4tFJfJNQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30438
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133676|0                           |1
            is obsolete|                            |
    
    --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133738
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133738&action=edit
    Bug 30438: Add select all/clear all buttons to invoices.tt
    
    To test:
    1. Apply patch
    2. Have a bunch of invoices, some open and some closed.
    3. Go to Home > Acquisitions > Invoices and do a search that will
       return you many of those invoices, some open and some closed.
    4. Notice the 'Select all' and 'Clear all' buttons.
    5. Try clicking 'Select all' on the Open invoices tab. All Open invoices
       should become checked.
    6. Try clicking 'Clear all' on the Open invoices tab. All open invoices
       should become unchecked.
    7. Try 5 - 6 again but on the Closed invoices tab.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:18:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:18:15 +0000
    Subject: [Koha-bugs] [Bug 30599] Allow archiving multiple suggestions
    In-Reply-To: <bug-30599-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30599-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30599-70-KTQn2DFDyx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30599
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:18:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:18:20 +0000
    Subject: [Koha-bugs] [Bug 30599] Allow archiving multiple suggestions
    In-Reply-To: <bug-30599-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30599-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30599-70-f4if3mydjI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30599
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133697|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133739
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133739&action=edit
    Bug 30599: Add an 'Archive selected' button
    
    This patch simply adds a new button on the suggestions interface to allow
    for archiving multiple suggestions.
    
    To test:
    1 - Apply patch
    2 - Create some purchase suggestions
    3 - Select several suggestions
    4 - Click 'Archive selected'
    5 - Suggestions are archived
    6 - You can view archived suggestions by selecting 'Suggestion
    information'->'Include archived'
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    Signed-off-by: Felicity Brown <felicity.brown at montgomerycountymd.gov>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:18:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:18:52 +0000
    Subject: [Koha-bugs] [Bug 30599] Allow archiving multiple suggestions
    In-Reply-To: <bug-30599-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30599-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30599-70-nyci5PyXf3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30599
    
    --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Spotting a new name here - thx for your sign-off, Felicity :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:20:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:20:54 +0000
    Subject: [Koha-bugs] [Bug 30508] Do not display OPAC message about block
     from holds when OPACHoldRequests is disabled
    In-Reply-To: <bug-30508-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30508-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30508-70-AoALvV5fcF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133722|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:22:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:22:07 +0000
    Subject: [Koha-bugs] [Bug 30508] Do not display OPAC message about block
     from holds when OPACHoldRequests is disabled
    In-Reply-To: <bug-30508-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30508-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30508-70-jpI412LKLu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508
    
    --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Hi Victor, not sure about the confusion here, but Amit's sign-off line seems ok
    to me in his attached patch:
    
    Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com>
    
    Maybe it was uploaded manually, that could explain the missing 'patch' flag.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:26:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:26:32 +0000
    Subject: [Koha-bugs] [Bug 30508] Do not display OPAC message about block
     from holds when OPACHoldRequests is disabled
    In-Reply-To: <bug-30508-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30508-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30508-70-2AtoO25fp9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:26:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:26:37 +0000
    Subject: [Koha-bugs] [Bug 30508] Do not display OPAC message about block
     from holds when OPACHoldRequests is disabled
    In-Reply-To: <bug-30508-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30508-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30508-70-05IzLSxdGx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508
    
    --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133740
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133740&action=edit
    Bug 30508: Do not display OPAC message about block from holds when
    OPACHoldRequests is disabled
    
    This patch adds a check for the OPACHoldRequests to determine whether a
    message should be shown to patrons whose account is over the
    maxoutstanding limit.
    
    To test, apply the patch and set the "maxoutstanding" system preference
    to a low value. Set OPACHoldRequests to "Allow."
    
    - Log in to the OPAC as a patron who has outstanding fines or charges
      which exceed the maxoutstanding value you set.
    - You should see a message on the "Your summary" page, "Holds are
      blocked because your fine balance is over the limit."
    - Set OPACHoldRequests to "Don't allow" and refresh the "Your summary"
      page in the OPAC. The message should disappear.
    
    Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:30:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:30:32 +0000
    Subject: [Koha-bugs] [Bug 29092] Table settings for account_fines table is
     missing Updated on column and hides the wrong things
    In-Reply-To: <bug-29092-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29092-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29092-70-7ltJx5a4VX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29092
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Table Settings for          |Table settings for
                       |account_fines table missing |account_fines table is
                       |Updated On column and hide  |missing Updated on column
                       |the wrong things            |and hides the wrong things
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:31:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:31:58 +0000
    Subject: [Koha-bugs] [Bug 28082] Add acquisitions toolbar to vendors on
     vendor search page
    In-Reply-To: <bug-28082-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28082-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28082-70-45mazJzxMj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28082
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
      Text to go in the|                            |This patch updates the
          release notes|                            |vendor search results page
                       |                            |in acquisitions so that a
                       |                            |button toolbar is shown for
                       |                            |each vendor in search
                       |                            |results. This gives quick
                       |                            |access to operations for
                       |                            |each vendor, like editing
                       |                            |the vendor, adding a
                       |                            |basket, or receiving a
                       |                            |shipment.
                       |                            |
                       |                            |Now the number
                       |                            |of open baskets and
                       |                            |subscriptions is shown for
                       |                            |each vendor in the search
                       |                            |result, linking to the
                       |                            |details of those entries.
                       |                            |
                       |                            |Inactive vendors are now
                       |                            |styled differently than
                       |                            |active vendors in order to
                       |                            |improve clarity.
               Keywords|release-notes-needed        |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:32:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:32:29 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-rh4oyxE8Zr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Patch doesn't apply         |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:32:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:32:34 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-K1SV7UWrN9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132085|0                           |1
            is obsolete|                            |
     Attachment #132086|0                           |1
            is obsolete|                            |
     Attachment #132087|0                           |1
            is obsolete|                            |
     Attachment #132088|0                           |1
            is obsolete|                            |
     Attachment #132089|0                           |1
            is obsolete|                            |
     Attachment #132090|0                           |1
            is obsolete|                            |
     Attachment #132091|0                           |1
            is obsolete|                            |
     Attachment #132092|0                           |1
            is obsolete|                            |
    
    --- Comment #65 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133741
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133741&action=edit
    Bug 29924: Database updates
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:32:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:32:39 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-ZRzxfPYQNJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    --- Comment #66 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133742
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133742&action=edit
    Bug 29924: Add password expiration feature
    
    This patch adds the ability to define password_expiry_days for a patron
    category.
    
    When defined a patron's password will expire after X days and they will
    be required to reset their password. If OPAC resets are enabled for the
    catgeory they may do so on their own, otherwise they will need to
    contact the library
    
    To test:
     1 - Apply patch, updatedatabase
     2 - Set 'Password expiration' for a patron category
         Home-> Administration-> Patron categories-> Edit
     3 - Create a new patron in this category with a userid/password set,
         and an email
     4 - Confirm their password_expiration_date field is set
         SELECT password_expiration_date FROM borrowers WHERE borrowernumber=51;
     5 - Create a new patron, do not set a password
     6 - Confirm their password_expiration_date field is NULL
     7 - Update the patron with an expiration to be expired
         UPDATE borrowers SET password_expiration_date='2022-01-01' WHERE
    borrowernumber=51;
     8 - Give the borrower catalogue permission
     9 - Attempt to log in to Straff interface
    10 - Confirm you are signed out and notified that password must be
         reset
    11 - Attempt to sign in to OPAC
    12 - Confirm you are signed out and notified password must be reset
    13 - Enable password reset for the patron's category and perform a
         password reset
         Note: you will have to find the link in the message_queue unless
         you have emails setup on your test environment
         SELECT * FROM message_queue WHERE borrowernumber=51;
    14 - Confirm that you can now sign in and password_expiration_date field
         is set 10 days in the future
    15 - Expire the patron's password again
    16 - Change the patron's password via the staff interface
    17 - Confirm they can sign in and the expiration is updated
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:32:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:32:44 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-AAJpSqAE7i@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    --- Comment #67 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133743
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133743&action=edit
    Bug 29924: Unit tests
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:32:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:32:48 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-VoabnXxL4E@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    --- Comment #68 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133744
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133744&action=edit
    Bug 29924: (follow-up) Add bug number to atomicupdate; Style OPAC message
    
    - The atomicupdate didn't have "bug_number" defined.
    - The "Your password has expired" message is now styled with the same
      class as other OPAC login messages.
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:32:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:32:53 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-xIDRiuSLCC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    --- Comment #69 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133745
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133745&action=edit
    Bug 29924: (follow-up) Add password_expiration_date to API
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:32:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:32:57 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-DyFRAjxpVu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    --- Comment #70 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133746
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133746&action=edit
    Bug 29924: (follow-up) Add default value undef for TestBuilder
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:33:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:33:03 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-JjMLN0rlh3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    --- Comment #71 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133747
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133747&action=edit
    Bug 29924: Update ILSDI to be aware of expired passwords
    
    To test:
    1 - Enable ILSDI
    2 - Set a patron password with expired password
    3 -
    http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=AuthenticatePatron&username=usernam&password=password
    4 - Confirm 'PasswordExpired' returned
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:33:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:33:08 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-m5XfMqWei8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    --- Comment #72 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133748
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133748&action=edit
    Bug 29924: DO NOT PUSH - Schema updates
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:39:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:39:13 +0000
    Subject: [Koha-bugs] [Bug 26839] Add a 'date published' feature to the facets
    In-Reply-To: <bug-26839-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26839-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26839-70-WShDrSsnNO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26839
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |DUPLICATE
                 Status|NEW                         |RESOLVED
    
    --- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
    (In reply to Fridolin Somers from comment #1)
    > Duplicate of Bug 10734 ?
    
    I agree.
    
    *** This bug has been marked as a duplicate of bug 10734 ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:39:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:39:13 +0000
    Subject: [Koha-bugs] [Bug 29925] Add a 'set new password' page for patron's
     with expired passwords
    In-Reply-To: <bug-29925-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29925-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29925-70-9sfRWt6GAG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29925
    
    --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133749
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133749&action=edit
    Bug 29925: (follow-up) Fix copyright statement
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:39:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:39:13 +0000
    Subject: [Koha-bugs] [Bug 10734] Add Publication Date Facet in Searching
    In-Reply-To: <bug-10734-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-10734-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-10734-70-2FHgDnrVwG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10734
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |barbara.johnson at bedfordtx.g
                       |                            |ov
    
    --- Comment #10 from Owen Leonard <oleonard at myacpl.org> ---
    *** Bug 26839 has been marked as a duplicate of this bug. ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:39:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:39:43 +0000
    Subject: [Koha-bugs] [Bug 29925] Add a 'set new password' page for patron's
     with expired passwords
    In-Reply-To: <bug-29925-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29925-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29925-70-opVThqH8Ap@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29925
    
    --- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
    (In reply to Marcel de Rooy from comment #9)
    > If my password was 123Jim+1, and I just change to 123Jim+2, or change
    > 3Jim at abc to 4Jim at abc, could we refuse such changes?
    > Look for some 'large enough' string that they have in common or so?
    > Or compare the number of positions where they are different?
    > 
    > Since this could well be considered scope creep, we could open a new report?
    
    Yes, please
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:40:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:40:49 +0000
    Subject: [Koha-bugs] [Bug 30136] Add back to top button when scrolling
    In-Reply-To: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30136-70-UsPAXGBfms@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136
    
    --- Comment #13 from Owen Leonard <oleonard at myacpl.org> ---
    By the way, Font Awesome provides accessibility suggestions for the version we
    are using here:
    
    https://fontawesome.com/v4/accessibility/
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:42:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:42:19 +0000
    Subject: [Koha-bugs] [Bug 29092] Table settings for account_fines table is
     missing Updated on column and hides the wrong things
    In-Reply-To: <bug-29092-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29092-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29092-70-DivdUd93cI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29092
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:42:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:42:24 +0000
    Subject: [Koha-bugs] [Bug 29092] Table settings for account_fines table is
     missing Updated on column and hides the wrong things
    In-Reply-To: <bug-29092-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29092-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29092-70-wkxSmJBLbm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29092
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133670|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133750
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133750&action=edit
    Bug 29092: Add timestamp to account-fines table column settings
    
    Table settings for the account_fines table (in the Patrons section, the
    "Transactions" table in a patron account) are missing a checkbox for the
    "Updated On" column. Because of this, one cannot hide the Updated On
    column and any other values one sets here get applied to the wrong
    columns.
    
    This patch adds timestamp to account-fines column settings.
    To test:
    
    1) Navigate to columns settings page and modify account-fines tables
       column.
       => Note that if you hide e.g. account_type column, column
       credit_number is hidden on patrons account page
    2) Apply patch and update database.
       => Account-fines column settings has now a option to hide timestamp.
       => Correct columns should now be hidden.
    
    Sponsored-by: Koha-Suomi Oy
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:49:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:49:17 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-uwRnltSwD0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    --- Comment #48 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133751
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133751&action=edit
    Bug 30576: Use DefaultPatronSearchFields in patron search
    
    This patch corrects the handling of the 'Standard' search field in
    patron searches such that it accurately reflects the contents of the
    DefaultPatronSearchFields system preference and falls back to a hard
    coded list instead of always using the hard coded list.
    
    To test:
    1) Empty the contents of DefaultPatronSearchFields systempreference
    2) Perform a patron search from the header search
    3) Inspect the patrons API request and note that we search on the
       default fallback fields of firstname, surname, othernames,
       cardnumber and userid (and some extended attributes which are
       historically hard coded).
    4) Navigate to the memebers-home by clicking the 'Patrons' button from
       the main page
    5) Perform another search using the filters on the left with 'Standard'
       selected.
    6) Note the same list of search fields used as above in the patrons API
       request.
    7) Update the DefaultPatronSearchFields systempreference adding one or
       more borrower fields in a comma delimited list.
    8) Repeat steps 2 -> 6 but this time upon inspecting the API request you
       should find that only the fields in your DefaultPatronSearchFields
       list are searched (along with the hard coded extended attributes
       list).
    9) Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:49:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:49:22 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-s3Op2F3L5c@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133544|0                           |1
            is obsolete|                            |
    
    --- Comment #49 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133752
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133752&action=edit
    Bug 21978: Add middle_name field to the database
    
    This patch adds a new field, middle_name, to the borrowers,
    deletedborrowers and borrower_modifications tables.
    
    It also updates the DefaultPatronSearchFields preference to include the
    new field if the preference is still set to it's default settings from
    install.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:49:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:49:28 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-DYv674tYkO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133545|0                           |1
            is obsolete|                            |
    
    --- Comment #50 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133753
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133753&action=edit
    Bug 21978: Add middle_name to api specification
    
    This patch adds middle_name to the accaeptable fields in API requests
    and responses.
    
    Test plan
    1) Search for a user using the API
    2) Confirm the API responds with a 200
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:49:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:49:33 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-O0z8nIJAk5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133546|0                           |1
            is obsolete|                            |
    
    --- Comment #51 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133754
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133754&action=edit
    Bug 21978: Add support for middle name
    
    This patch adds the new 'Middle name' field to the patron record.
    
    To test:
    1) Apply patches
    2) Update database, restart all and clear the browser cache
    3) Load a patron in the staff module
    4) Confirm you can see and edit the new 'Middle name' field
    5) Confirm the new middle name data displays on patron details
    6) Confirm the new middle name data displays on patron search results
    7) Confirm the new middle name data displays everywhere patron names are
       displayed.
    8) Confirm the new middle name data displays on the OPAC
    9) Confirm the 'Middle name' field appears in the OPAC borrower
       modification screens
    10) Edit sysprefs `BorrowerMandatoryFields`, `BorrowerUnwantedFields`,
        `SelfModificationBorrowerUnwantedField`,
    `PatronSelfModificationMandatoryField`,
        `PatronSelfRegistrationBorrowerMandatoryField` and
        `PatronSelfRegistrationBorrowerUnwantedField` to confirm you can make
        the new field required or hidden.
    11) Verify that DefaultPatronSearchFields contains the new field if you
        already had 'firstname' in the field list
    12) Enable PatronAutoComplete system preference
    13) Type patrons surname into checkout or patron search but don't hit
        return
    14) Confirm the patrons middle name is displayed in the preview
    15) Go to tools > patron lists and attempt to add a patron to a list
    16) Patrons middle name should appear in the autocomplete here too
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:49:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:49:38 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-eEMEilnD90@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133547|0                           |1
            is obsolete|                            |
    
    --- Comment #52 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133755
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133755&action=edit
    Bug 21978: Schema Update
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:49:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:49:45 +0000
    Subject: [Koha-bugs] [Bug 18986] High Hold Items with Decreased Loan Period
     Can't Be Checked-Out with Self-Check
    In-Reply-To: <bug-18986-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18986-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18986-70-GtOIpMaO2D@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18986
    
    --- Comment #8 from Kalle Karlsson <kalle at imcode.com> ---
    (In reply to Magnus Enger from comment #7)
    > (In reply to Kalle Karlsson from comment #6)
    > > (In reply to Martin Renvoize from comment #5)
    > > > I believe this may have been another manifestation of bug 26301.. can we
    > > > varify whether this is still a problem on current master?
    > > 
    > > It is still an issue for our clients atleast. Haven't found a workaround to
    > > it.
    > 
    > What versions?
    
    20.11 and 21.11 from the ones that have reported the issue.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:49:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:49:45 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-tcA84k9clL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    --- Comment #53 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133756
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133756&action=edit
    Bug 21978: Add middle_name into hold request autocomplete
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:49:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:49:51 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-LUIqiFsjX1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    --- Comment #54 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133757
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133757&action=edit
    Bug 21978: Use patron-title.inc in request.tt
    
    This patch updates all manual accurences of the patron title display
    to use the patron-title.inc include (so we get middlename handling)
    in request.tt.
    
    We also add the option to hide the cardnumber from the include and set
    the link_to to 'members_pay' to retain the current display format on
    this page.
    
    Test plan
    You'll need to trigger the following cases to test all cases:
    1) Too many holds
    2) Account expired
    3) Has restrictions
    4) Outstanding fines
    5) Already has hold on item
    6) No holds allowed
    7) Too many holds for this record
    8) Already in possession
    9) Already has a hold
    10) Already has a recall
    11) Pickup library doesn't many patron home library
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:50:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:50:43 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-IHPCI07zyI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133751|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:51:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:51:36 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-fWLCV4Aali@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Needs Signoff
    
    --- Comment #55 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Thanks for the thorough testing.. I think those issues should now all be
    resolved now :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 13:53:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 11:53:24 +0000
    Subject: [Koha-bugs] [Bug 10517] koha-restore fails to create
     mysqluser@mysql_hostname so zebra update fails
    In-Reply-To: <bug-10517-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-10517-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-10517-70-eR1IGsjhru@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #127865|0                           |1
            is obsolete|                            |
    
    --- Comment #43 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133758
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133758&action=edit
    Bug 10517: Use `DROP USER IF EXISTS` and remove ` || true`.
    
    When restoring a Koha instance, and the database user does not exist, an error
    is shown,
    although it is prevented from stopping the script by ` || true`. This patch
    removes the
    ` || true` guard, and rather uses `DROP USER IF EXISTS` which does exactly what
    one
    would expect, without confusing error messages, whether the user existed or
    not.
    
    To test:
    1) Assume your Koha instance is called `asdf`.
    1) Export the Koha instance using `koha-dump`.
    2) Remove the instance completely using `koha-remove`.
    3) Import it again using `koha-restore`.
    4) No error should be shown, and the import should work. There was NO user to
    drop, therefore `DROP USER IF EXISTS` did nothing.
    5) A database user called `koha_asdf` should exist, and have all privileges on
    the database of the same name.
    6) Remove the instance again using `koha-remove`.
    7) Now create a database user in MySQL called `koha_instance` where instance is
    the name of your dumped koha instance.
    8) Import your koha instance again using `koha-restore`.
    9) Again, no error should be shown, and the import should work. There WAS a
    user to drop, therefore `DROP USER IF EXISTS` dropped the user before creating
    a new one.
    10) Again, a database user called `koha_asdf` should exist, and have all
    privileges on the database of the same name.
    
    Sponsored-by: Reformational Study Centre
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:01:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:01:39 +0000
    Subject: [Koha-bugs] [Bug 30605] New: New password should be more than just
     unequal to old password
    Message-ID: <bug-30605-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30605
    
                Bug ID: 30605
               Summary: New password should be more than just unequal to old
                        password
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Authentication
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: m.de.rooy at rijksmuseum.nl
            QA Contact: testopia at bugs.koha-community.org
                    CC: dpavlin at rot13.org
    
    >From a comment on bug 29925:
    
    If my password was 123Jim+1, and I just change to 123Jim+2, or change 3Jim at abc
    to 4Jim at abc, could we refuse such changes?
    Look for some 'large enough' string that they have in common or so?
    Or compare the number of positions where they are different?
    
    Note that it might be possible to move such code into a check_password plugin,
    but we would need the old and new password when calling ->set_password.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:01:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:01:53 +0000
    Subject: [Koha-bugs] [Bug 29925] Add a 'set new password' page for patron's
     with expired passwords
    In-Reply-To: <bug-29925-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29925-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29925-70-ImxqP3Dlja@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29925
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30605
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:01:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:01:53 +0000
    Subject: [Koha-bugs] [Bug 30605] New password should be more than just
     unequal to old password
    In-Reply-To: <bug-30605-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30605-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30605-70-ZKGV0q0mGV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30605
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=29925
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:01:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:01:54 +0000
    Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on
     fresh install, but can be null with upgrade
    In-Reply-To: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27253-70-aij94fP99F@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253
    
    --- Comment #20 from Julian Maurice <julian.maurice at biblibre.com> ---
    (In reply to Marcel de Rooy from comment #17)
    > So I would propose to switch to UNIXTIME(1).
    > Note that I would consider this a bug in SQL.
    
    It's weird that '1970-01-01 00:00:00' is not a valid timestamp but it's not
    really a bug IMO. MySQL documentation says that:
    
    The TIMESTAMP data type is used for values that contain both date and time
    parts. TIMESTAMP has a range of '1970-01-01 00:00:01' UTC to '2038-01-19
    03:14:07' UTC.
    
    https://dev.mysql.com/doc/refman/8.0/en/datetime.html
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:04:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:04:37 +0000
    Subject: [Koha-bugs] [Bug 30605] New password should be more than just
     unequal to old password
    In-Reply-To: <bug-30605-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30605-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30605-70-w1SOt0cEYY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30605
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |nick at bywatersolutions.com,
                       |                            |tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:05:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:05:17 +0000
    Subject: [Koha-bugs] [Bug 29926] Add ability for superlibrarians to edit
     password expiration dates
    In-Reply-To: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29926-70-JSXFiPaR2j@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29926
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Patch doesn't apply         |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:05:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:05:21 +0000
    Subject: [Koha-bugs] [Bug 29926] Add ability for superlibrarians to edit
     password expiration dates
    In-Reply-To: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29926-70-B5X7XFvyYa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29926
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #130686|0                           |1
            is obsolete|                            |
     Attachment #130687|0                           |1
            is obsolete|                            |
     Attachment #130688|0                           |1
            is obsolete|                            |
    
    --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133759
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133759&action=edit
    Bug 29926: Add pasword expiration route for API
    
    To test:
    1 - prove -v t/db_dependent/api/v1/patrons_password_expiration.t
    
    Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:05:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:05:25 +0000
    Subject: [Koha-bugs] [Bug 29926] Add ability for superlibrarians to edit
     password expiration dates
    In-Reply-To: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29926-70-fxLR6ypzPb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29926
    
    --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133760
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133760&action=edit
    Bug 29926: Add ability for superlibrarian to view/edit password expiration
    
    To  test:
     1 - Sign in as a superlibrarian
     2 - Find a patron account with no password expiration set
     3 - View member detials
     4 - note expiration says 'Never'
     5 - Edit patron
     6 - Set patron expiration
     7- Save
     8 - View details, confirm password expiration shows correctly
     9 - Sign in as non-superlibrarian
    10 - Confirm you don't see expirationdate on details page
    11 - Edit patron and confirm password expiration does not show
    12 - Edit HTML and confirm you epxiration date not saved
         <input type="text" name="password_expiration_date" value="2052-05-02">
    
    Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:05:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:05:29 +0000
    Subject: [Koha-bugs] [Bug 29926] Add ability for superlibrarians to edit
     password expiration dates
    In-Reply-To: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29926-70-mEqLgj8YO6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29926
    
    --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133761
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133761&action=edit
    Bug 29926: Add ability for superlibrarians to batch edit password expiration
    dates
    
    To test:
    1 - Sign in as a superlibrarian
    2 - Tools->Batch patron modification
    3 - Add patrons with and without pasword expiration set
    4 - Confirm dates display correctly on modification page, or show never
    5 - Check the box to delete all dates
    6 - Confirm patrons now show 'Never'
    7 - Edit patrons again, set a date
    8 - Confirm date is set correctly
    9 - Sign in as a user with catalogue/tools/borrowers permissions, but not
    superlibrarian
    10 - Confirm y9ou do not see, and cannnot edit password expiration dates
    
    Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:06:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:06:57 +0000
    Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
     $biblio->metadata->record
    In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29697-70-cBXVbM3TSo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Patch doesn't apply
    
    --- Comment #23 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    (In reply to Jonathan Druart from comment #22)
    > (In reply to Nick Clemens from comment #21)
    > > (In reply to Jonathan Druart from comment #20)
    > > > Can we move this one forward please?
    > > 
    > > Test plan?
    > 
    > No test plan, the diff it too big. What we need here are QA eyes :)
    
    I doesn't apply. Please rebase and I'll test it right away.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:07:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:07:36 +0000
    Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on
     fresh install, but can be null with upgrade
    In-Reply-To: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27253-70-SxKuyXhp0h@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253
    
    --- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Julian Maurice from comment #20)
    > (In reply to Marcel de Rooy from comment #17)
    > > So I would propose to switch to UNIXTIME(1).
    > > Note that I would consider this a bug in SQL.
    > 
    > It's weird that '1970-01-01 00:00:00' is not a valid timestamp but it's not
    > really a bug IMO. MySQL documentation says that:
    > 
    > The TIMESTAMP data type is used for values that contain both date and time
    > parts. TIMESTAMP has a range of '1970-01-01 00:00:01' UTC to '2038-01-19
    > 03:14:07' UTC.
    > 
    > https://dev.mysql.com/doc/refman/8.0/en/datetime.html
    
    Ok no bug, inconsistency then :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:09:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:09:16 +0000
    Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths
    In-Reply-To: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-19318-70-EMVHF8EyT4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Patch doesn't apply
    
    --- Comment #23 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Can I have a quick rebase please?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:14:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:14:50 +0000
    Subject: [Koha-bugs] [Bug 29936] Add ability to disable hold capture via SIP
     checkin
    In-Reply-To: <bug-29936-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29936-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29936-70-agbVynsst0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |tomascohen at gmail.com
             QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                       |y.org                       |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:15:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:15:46 +0000
    Subject: [Koha-bugs] [Bug 28512] spinelabel-print.tt should include the
     logged in branchcode
    In-Reply-To: <bug-28512-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28512-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28512-70-UBgBz2tILM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:15:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:15:51 +0000
    Subject: [Koha-bugs] [Bug 28512] spinelabel-print.tt should include the
     logged in branchcode
    In-Reply-To: <bug-28512-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28512-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28512-70-XqkWhb7HEV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133514|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133762
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133762&action=edit
    Bug 28512: add logged in branch as class to spinelabel-print.tt body
    
    To test:
    -Apply patch and generate a quick spine label.
    -Inscept the page and notice that the body should contain a new class which
    corresponds with that the of the logged in branch.
    
    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:16:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:16:40 +0000
    Subject: [Koha-bugs] [Bug 30605] New password should be more than just
     unequal to old password
    In-Reply-To: <bug-30605-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30605-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30605-70-1Pw3sVpkkB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30605
    
    --- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
    I hope this change can be made optional.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:18:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:18:19 +0000
    Subject: [Koha-bugs] [Bug 28512] Quick spine label creator: Add CSS class
     with logged in library's branchcode
    In-Reply-To: <bug-28512-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28512-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28512-70-P0YgYNC7ZR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|spinelabel-print.tt should  |Quick spine label creator:
                       |include the logged in       |Add CSS class with logged
                       |branchcode                  |in library's branchcode
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:19:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:19:35 +0000
    Subject: [Koha-bugs] [Bug 29936] Add ability to disable hold capture via SIP
     checkin
    In-Reply-To: <bug-29936-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29936-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29936-70-UJkhxE2VlQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:19:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:19:45 +0000
    Subject: [Koha-bugs] [Bug 29936] Add ability to disable hold capture via SIP
     checkin
    In-Reply-To: <bug-29936-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29936-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29936-70-FRyRj2zSTm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131577|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:19:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:19:55 +0000
    Subject: [Koha-bugs] [Bug 29936] Add ability to disable hold capture via SIP
     checkin
    In-Reply-To: <bug-29936-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29936-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29936-70-4XKxsP9tv4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131578|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:20:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:20:33 +0000
    Subject: [Koha-bugs] [Bug 29936] Add ability to disable hold capture via SIP
     checkin
    In-Reply-To: <bug-29936-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29936-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29936-70-zXFojawRXZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936
    
    --- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133763
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133763&action=edit
    Bug 29936: Add unit tests
    
    This patch adds a unit test for the new functionality introduced with
    holds_get_captured allowing for holds to still be highlighted to patrons
    at checkin but not mark them as found/transfered in the system.
    
    Sponsored-by: Cheshire Libraries Shared Services
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:20:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:20:51 +0000
    Subject: [Koha-bugs] [Bug 29936] Add ability to disable hold capture via SIP
     checkin
    In-Reply-To: <bug-29936-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29936-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29936-70-qBi5TBk88x@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936
    
    --- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133764
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133764&action=edit
    Bug 29936: Add holds_get_captured option to sip config
    
    This patch adds a new option to the SIP config, allowing for hold
    capture to be disabled on difference devices. We still notice the hold
    and alert the user, but we do not trigger the update in the system to
    mark the hold as found (waiting, processing or in transit).
    
    Sponsored-by: Cheshire Libraries Shared Services
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:21:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:21:06 +0000
    Subject: [Koha-bugs] [Bug 29936] Add ability to disable hold capture via SIP
     checkin
    In-Reply-To: <bug-29936-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29936-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29936-70-a7n70UzWjo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936
    
    --- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133765
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133765&action=edit
    Bug 29936: (follow-up) Remove useless warining
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:23:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:23:51 +0000
    Subject: [Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have
     different timezones on the same server
    In-Reply-To: <bug-20123-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20123-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20123-70-RtZHtWLIv7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123
    
    Satish Pandharpurkar <satish at maplibraryservices.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |satish at maplibraryservices.c
                       |                            |om
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:29:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:29:41 +0000
    Subject: [Koha-bugs] [Bug 30565] Field stockrotationrotas.description should
     be NOT NULL, title UNIQUE
    In-Reply-To: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30565-70-o7z6CScdrL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30565
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
                     CC|                            |tomascohen at gmail.com
       Patch complexity|Small patch                 |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:29:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:29:48 +0000
    Subject: [Koha-bugs] [Bug 30565] Field stockrotationrotas.description should
     be NOT NULL, title UNIQUE
    In-Reply-To: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30565-70-yaLuY28a78@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30565
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133457|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:29:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:29:59 +0000
    Subject: [Koha-bugs] [Bug 30565] Field stockrotationrotas.description should
     be NOT NULL, title UNIQUE
    In-Reply-To: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30565-70-hqHSezJqAY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30565
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133458|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:30:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:30:07 +0000
    Subject: [Koha-bugs] [Bug 30565] Field stockrotationrotas.description should
     be NOT NULL, title UNIQUE
    In-Reply-To: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30565-70-8EWtJeVeSt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30565
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133459|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:30:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:30:43 +0000
    Subject: [Koha-bugs] [Bug 30565] Field stockrotationrotas.description should
     be NOT NULL, title UNIQUE
    In-Reply-To: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30565-70-XWbUkA6N8S@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30565
    
    --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133766
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133766&action=edit
    Bug 30565: Correct kohastructure
    
    The unique key was added in a dbrev and is referred to in code.
    But forgotten in kohastructure.
    
    Test plan:
    Run new install or kohastructure.sql on empty db.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:30:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:30:56 +0000
    Subject: [Koha-bugs] [Bug 30565] Field stockrotationrotas.description should
     be NOT NULL, title UNIQUE
    In-Reply-To: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30565-70-9MEvN2Ajji@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30565
    
    --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133767
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133767&action=edit
    Bug 30565: Database revision for stockrotationrotas
    
    Add unique key if needed.
    Adjust description column to make it NOT NULL.
    
    Test plan:
    (Optionally:) Drop unique key, make description nullable.
    Run dbrev.
    Check if unique key present, and description not-nullable.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:31:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:31:09 +0000
    Subject: [Koha-bugs] [Bug 30565] Field stockrotationrotas.description should
     be NOT NULL, title UNIQUE
    In-Reply-To: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30565-70-LLqQLSaf8b@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30565
    
    --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133768
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133768&action=edit
    Bug 30565: DBIx schema change for stockrotationrotas
    
    No test plan.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:32:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:32:04 +0000
    Subject: [Koha-bugs] [Bug 30565] Field stockrotationrotas.description should
     be NOT NULL, title UNIQUE
    In-Reply-To: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30565-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30565-70-74umkdyTzk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30565
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    --- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Trivial fix, straight QA for me.
    
    Great work, Marcel!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:32:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:32:24 +0000
    Subject: [Koha-bugs] [Bug 30587] Incorrect translations in some templates
    In-Reply-To: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30587-70-jQNi3a943L@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30587
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|oleonard at myacpl.org         |tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:36:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:36:39 +0000
    Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
    In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-12446-70-baBenVuPxI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
    
    Shi Yao Wang <shi-yao.wang at inLibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |shi-yao.wang at inLibro.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:37:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:37:37 +0000
    Subject: [Koha-bugs] [Bug 30449] Missing FK constraint on
     borrower_attribute_types
    In-Reply-To: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30449-70-vhsenTmOrY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                       |y.org                       |
                     CC|                            |tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:37:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:37:59 +0000
    Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
    In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-12446-70-eHfZAIbNiV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
    
    Shi Yao Wang <shi-yao.wang at inLibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:39:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:39:38 +0000
    Subject: [Koha-bugs] [Bug 30475] Convert tools pages tabs to Bootstrap (part
     2)
    In-Reply-To: <bug-30475-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30475-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30475-70-A6KBa6aPtk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30475
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:39:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:39:42 +0000
    Subject: [Koha-bugs] [Bug 30475] Convert tools pages tabs to Bootstrap (part
     2)
    In-Reply-To: <bug-30475-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30475-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30475-70-qcPfVk1pAO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30475
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133489|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133769
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133769&action=edit
    Bug 30475: Convert tools pages tabs to Bootstrap (part 2)
    
    This patch converts jQueryUI tabs on three tools templates to Bootstrap
    tabs. The patch contains indentation changes, so diff accordingly.
    
    To test, apply the patch and go to Tools -> Export.
    
    - You should see at least two tabs, "Export bibliographic records" and
      "Export authority records."
    - Confirm that they look correct and work correctly.
    
    Go to Tools -> Batch patron modification.
    
    - Check the "By card number," "By borrowernumber," and "By patron list"
      tabs.
    
    Go to Tools -> Overdue notice/status triggers.
    
     - Check the "First," "Second," and "Third" tabs.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:41:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:41:03 +0000
    Subject: [Koha-bugs] [Bug 30449] Missing FK constraint on
     borrower_attribute_types
    In-Reply-To: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30449-70-ffx4xURTkB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|tomascohen at gmail.com        |testopia at bugs.koha-communit
                       |                            |y.org
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:45:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:45:44 +0000
    Subject: [Koha-bugs] [Bug 30514] Error in date format check following
     datepicker removal
    In-Reply-To: <bug-30514-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30514-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30514-70-UqmBWNl7EE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30514
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Failed QA
    
    --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    With different date formats, things don't appear quite right:
    
    * Changed Dateformat DD.MM.YYYY
    * Edit any patron
    * Set or edit date of birth
    * Verify the date is shown with / still, instead of selected dateformat
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:48:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:48:58 +0000
    Subject: [Koha-bugs] [Bug 30606] New: Koha multiple instances on same server
     with 2 ports only 80 and 443 for multiple customers
    Message-ID: <bug-30606-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30606
    
                Bug ID: 30606
               Summary: Koha multiple instances on same server with 2 ports
                        only 80 and 443 for multiple customers
     Change sponsored?: ---
               Product: Koha
               Version: 21.05
              Hardware: All
                    OS: All
                Status: NEW
              Severity: major
              Priority: P5 - low
             Component: Websites, Mailing Lists, etc
              Assignee: wizzyrea at gmail.com
              Reporter: satish at maplibraryservices.com
            QA Contact: testopia at bugs.koha-community.org
    
    Hello,
    
    
    We would like to install multiple Koha instances on the same server with only 2
    ports opened 80 and 443 for all customers for STAFF and OPAC pages in AWS cloud
    
    Pls let us know how do we achieve this using virtual hosts or configuration
    changes in Ubuntu OS
    
    
    Best Regards,
    Satish P
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:49:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:49:34 +0000
    Subject: [Koha-bugs] [Bug 30449] Missing FK constraint on
     borrower_attribute_types
    In-Reply-To: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30449-70-X23ckbfwqP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449
    
    --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    I've checked on 3.0.X original Koha deployments I have, (already in 21.05) and
    the constraint is there!
    
    Good catch, Marcel!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:52:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:52:26 +0000
    Subject: [Koha-bugs] [Bug 21459] Allow migrating requests between ILL and
     purchase suggestions
    In-Reply-To: <bug-21459-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21459-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21459-70-CnCfayLPa1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21459
    
    Felicity Brown <felicity.brown at montgomerycountymd.gov> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |felicity.brown at montgomeryco
                       |                            |untymd.gov
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:52:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:52:52 +0000
    Subject: [Koha-bugs] [Bug 30587] Incorrect translations in some templates
    In-Reply-To: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30587-70-1jW69Wt3ON@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30587
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
       Patch complexity|---                         |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:52:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:52:56 +0000
    Subject: [Koha-bugs] [Bug 30587] Incorrect translations in some templates
    In-Reply-To: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30587-70-NFDYLIKJUM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30587
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133591|0                           |1
            is obsolete|                            |
     Attachment #133592|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133770
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133770&action=edit
    Bug 30587: Fix opac-tags.tt translate issues
    
    This patch addresses one specific case.
    
    To test:
    1. Run:
       $ kshell
      k$ cd misc/translator
      k$ perl translate update es-ES
    2. On your git checkout run:
       $ git diff | grep '\[% limit or'
    => FAIL: That shouldn't be translated
    3. Run:
       $ git reset --hard HEAD
    4. Apply this patch
    5. Repeat 1 and 2
    => SUCCESS: No attempt to translate that tag
    6. Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:53:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:53:00 +0000
    Subject: [Koha-bugs] [Bug 30587] Incorrect translations in some templates
    In-Reply-To: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30587-70-OS7EzhMtuP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30587
    
    --- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133771
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133771&action=edit
    Bug 30587: Fix acqui/supplier.tt translate issues
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:54:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:54:47 +0000
    Subject: [Koha-bugs] [Bug 30449] Missing FK constraint on
     borrower_attribute_types
    In-Reply-To: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30449-70-b31OwpmqTk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449
    
    --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    I am wondering how DBIx::RunSQL handles our /*4xxx SET FOREIGN KEY CHECKS OFF*/
    line.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:55:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:55:05 +0000
    Subject: [Koha-bugs] [Bug 30587] Incorrect translations in some templates
    In-Reply-To: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30587-70-AwPg7y04tf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30587
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Version|unspecified                 |master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:59:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:59:13 +0000
    Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths
    In-Reply-To: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-19318-70-3Jyfv6jK7K@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318
    
    Julian Maurice <julian.maurice at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #128844|0                           |1
            is obsolete|                            |
    
    --- Comment #24 from Julian Maurice <julian.maurice at biblibre.com> ---
    Created attachment 133772
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133772&action=edit
    Bug 19318: DO NOT PUSH - SCHEMA CHANGES
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:59:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:59:20 +0000
    Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths
    In-Reply-To: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-19318-70-h4XcqexQsq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318
    
    Julian Maurice <julian.maurice at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #128845|0                           |1
            is obsolete|                            |
    
    --- Comment #25 from Julian Maurice <julian.maurice at biblibre.com> ---
    Created attachment 133773
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133773&action=edit
    Bug 19318: Allow multiple storage spaces for file uploads
    
    This patch allow to configure multiple storage spaces to be used when
    uploading a file.
    
    Configuration is done in $KOHA_CONF. Element 'upload_path' is replaced
    by 'storage', which is repeatable and can contain the following
    elements:
    - name: The storage's identifier (also used for display)
    - adapter: The storage's adapter is a Perl module who is responsible for
      actually writing in the storage (creating/deleting files/directories).
      There is actually only one adapter, 'directory', which writes directly
      on the filesystem.
    - adapter_params: Additional parameters required for the storage's
      adapter
    - hash_filename: Whether to prepend hashvalue to the filename or not
    - temporary: Whether the storage is temporary or not
    - baseurl: Base URL of the storage, if one doesn't want to (or can't)
      use opac-retrieve-file.pl
    This is all documented in Koha::Storage
    
    There is two built-in storages:
    - 'TMP', the default temporary storage (not configurable)
    - 'DEFAULT', the default persistent storage (configurable in $KOHA_CONF)
    
    Note that if $KOHA_CONF is not updated, uploads should continues to work
    (the 'DEFAULT' storage will use 'upload_path', if set)
    
    This patch affects the following pages:
    - Tools › Upload
    - Tools › Upload local cover image (ZIP file upload)
    - Tools › Stage MARC records for import
    - Tools › Upload patron images
    - Circulation › Offline circulation file upload
    - Cataloguing plugin upload.pl
    
    Test plan:
    0. Before applying the patch, be sure to use the pages mentioned above
       and upload some files, those files should continue to be accessible
       after the patch
    1. Apply the patch, run updatedatabase and update_dbix_class_files
    2. Without modifying $KOHA_CONF, verify that files uploaded in step 0
       are still accessible (you can find them in tools/upload.pl)
    3. Verify that you can still upload files using the pages mentioned
       above
    4. Edit your $KOHA_CONF, copy the <storage> element from
       etc/koha-conf.xml in the source, set the <path> using the value of
       <upload_path> and remove <upload_path>
    5. Verify that you can still upload files
    6. Add another storage in $KOHA_CONF, set <hash_filename> to 0,
       and a <baseurl>. Now try to use the cataloguing plugin and see how
       the generated URL change. Also note that the files keep their
       original filename (without the hashvalue prepended)
    7. Create some subdirectories under the main storage's path (using a
       shell). Try to upload a new files and see that these directories
       appear in a dropdown list. Select one, finish the upload and verify
       that the file has been uploaded to the selected subdirectory.
    8. Run prove t/ImportBatch.t t/Koha/Storage.t
       t/db_dependent/ImportBatch.t t/db_dependent/Upload.t
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:59:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:59:26 +0000
    Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths
    In-Reply-To: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-19318-70-BhLiL1DAwW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318
    
    Julian Maurice <julian.maurice at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #128846|0                           |1
            is obsolete|                            |
    
    --- Comment #26 from Julian Maurice <julian.maurice at biblibre.com> ---
    Created attachment 133774
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133774&action=edit
    Bug 19318: Normalize uploaded file name
    
    The uploaded file name can appear in the MARC record (if using the
    upload plugin), and all the strings in the MARC record are normalized
    using Unicode::Normalize::NFC.
    So the file name must be normalized everywhere (in the filesystem and in
    the uploaded_files table too).
    
    Test plan:
    1. Create a file whose name contains combining characters. For instance:
       echo 'contents' > $(perl -e 'print "cine\x{cc}\x{81}ma"')
    
       0xcc 0x81 is utf8 for "Combining acute accent" (́ )
       https://unicode-table.com/fr/0301/
       Once normalized it should be 0xc3 0xa9 (é)
    
    2. Use the upload tool to upload this file
    3. Verify on your filesystem that the filename is normalized
       % ls cin* | xxd
       00000000: 6369 6ec3 a96d 610a                      cin..ma.
                        ^^ ^^
    4. If you have configured the storage with a `baseurl`, use the upload
       cataloguing plugin, and verify that the generated URL works correctly
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 14:59:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 12:59:31 +0000
    Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths
    In-Reply-To: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-19318-70-EPeMugPsqr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318
    
    Julian Maurice <julian.maurice at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #128847|0                           |1
            is obsolete|                            |
    
    --- Comment #27 from Julian Maurice <julian.maurice at biblibre.com> ---
    Created attachment 133775
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133775&action=edit
    Bug 19318: (follow-up) remove uploadcategory column from tests
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:00:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:00:24 +0000
    Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths
    In-Reply-To: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-19318-70-GiMGASwL1p@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318
    
    Julian Maurice <julian.maurice at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Patch doesn't apply         |Needs Signoff
    
    --- Comment #28 from Julian Maurice <julian.maurice at biblibre.com> ---
    (In reply to Tomás Cohen Arazi from comment #23)
    > Can I have a quick rebase please?
    
    Here you go ;)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:00:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:00:43 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-Xrq2ELd1L8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133577|0                           |1
            is obsolete|                            |
    
    --- Comment #9 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133776
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133776&action=edit
    Bug 30558: Add one more commit
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:03:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:03:16 +0000
    Subject: [Koha-bugs] [Bug 30607] New: Enable 'Clear filter' option on
     DataTables Search for patron searches
    Message-ID: <bug-30607-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30607
    
                Bug ID: 30607
               Summary: Enable 'Clear filter' option on DataTables Search for
                        patron searches
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Patrons
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: martin.renvoize at ptfs-europe.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
    
    The 'clear filter' button is permanently disabled on the patron search results
    page (member.pl). It shouldn't be.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:10:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:10:12 +0000
    Subject: [Koha-bugs] [Bug 30449] Missing FK constraint on
     borrower_attribute_types
    In-Reply-To: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30449-70-6CExw0Iv0B@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:10:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:10:21 +0000
    Subject: [Koha-bugs] [Bug 30449] Missing FK constraint on
     borrower_attribute_types
    In-Reply-To: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30449-70-zqU0DW2wIm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132966|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:11:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:11:18 +0000
    Subject: [Koha-bugs] [Bug 30607] Enable 'Clear filter' option on DataTables
     Search for patron searches
    In-Reply-To: <bug-30607-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30607-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30607-70-f9vvMA26P3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30607
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Severity|enhancement                 |normal
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:12:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:12:32 +0000
    Subject: [Koha-bugs] [Bug 30449] Missing FK constraint on
     borrower_attribute_types
    In-Reply-To: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30449-70-zbnxW3EZjQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449
    
    --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133777
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133777&action=edit
    Bug 30449: Add missing FK constraint on borrower_attribute_types
    
    Old Koha databases probably have it, newer ones might not.
    See also BZ description.
    
    Test plan:
    [1} Check SHOW CREATE TABLE borrower_attribute_types to see if you
        have any index and FK constraint on category_code.
    [2] Run updatedatabase.
    [3] If you had category_code_fk, it should be replaced.
    [4] Remove index and constraint again using things like:
        alter table borrower_attribute_types drop constraint
    `borrower_attribute_types_ibfk_1`;
        alter table borrower_attribute_types drop index category_code;
    [5] Run updatedatabase.
    [6] You should have KEY category_code and FK borrower_attribute_types_ibfk_1.
    [7] Run updatedatabase. Idempotent, no changes.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:12:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:12:47 +0000
    Subject: [Koha-bugs] [Bug 30449] Missing FK constraint on
     borrower_attribute_types
    In-Reply-To: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30449-70-RABw2QVJSn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449
    
    --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133778
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133778&action=edit
    Bug 30449: DBIC updates
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:13:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:13:04 +0000
    Subject: [Koha-bugs] [Bug 30449] Missing FK constraint on
     borrower_attribute_types
    In-Reply-To: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30449-70-x90Y0HBEXp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449
    
    --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133779
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133779&action=edit
    Bug 30446: (QA follow-up) Report back on problematic situations
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:14:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:14:16 +0000
    Subject: [Koha-bugs] [Bug 30606] Koha multiple instances on same server with
     2 ports only 80 and 443 for multiple customers
    In-Reply-To: <bug-30606-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30606-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30606-70-VaIgZYY0nL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30606
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |INVALID
                 Status|NEW                         |RESOLVED
    
    --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Hi Satish,
    
    Bugzilla is used for enhancement requests and bug/error reports.
    
    Support requests like your question about setup/configuration can be asked on
    the mailing lists or in our IRC channel (see
    https://koha-community.org/support/community-support/)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:14:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:14:38 +0000
    Subject: [Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability
     to send notices based on request supplier updates
    In-Reply-To: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30484-70-iTpYVu1dxM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484
    
    --- Comment #8 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
    Revised test plan:
    
    
    This test plan tests the provided functionality by using a mocked update
    supplied by the FreeForm backend. The command line script is run which will
    look for requests that match the supplied criteria, obtain a mocked update from
    them, and process the update. The processor simply prints the message supplied
    in the update to the screen.
    
    - Ensure you have Interlibrary Loans turned on and have the FreeForm backend
    installed. It is important you are using the "bug_30484_mock_request_update"
    branch of the FreeForm backend as this enables the backend to provide mock
    updates that this functionality uses.
    - Ensure that the patron that will be creating the request has the
    "Interlibrary loan updated" notice enabled for at least "Email"
    - Create a FreeForm ILL request
    - On the "Manage ILL request" page for the newly created request, click the
    "Confirm request" button, thereby setting the request status to "Requested"
    - Run the script, in the "misc" directory, run:
    
      perl process_ill_updates.pl --statuses REQ --backend FreeForm
    
    - TEST: You should see the following:
      - The message "This is a mock update from the FreeForm backend"
      - The following run report:
    
    Run details:
    Request ID: xxx
      Processing by: FreeForm
      Number of processors run: 1
      Processor details:
        Processor name: Print to STDERR
        Success messages: PRINTED
        Error messages:
    
    - If the above messages were printed, the test plan can be considered
    successful.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:30:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:30:13 +0000
    Subject: [Koha-bugs] [Bug 30607] Enable 'Clear filter' option on DataTables
     Search for patron searches
    In-Reply-To: <bug-30607-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30607-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30607-70-FLoU9mSdDF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30607
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:30:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:30:32 +0000
    Subject: [Koha-bugs] [Bug 30607] Enable 'Clear filter' option on DataTables
     Search for patron searches
    In-Reply-To: <bug-30607-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30607-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30607-70-bd9O1EqpyS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30607
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |oleonard at myacpl.org
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:30:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:30:59 +0000
    Subject: [Koha-bugs] [Bug 30607] Enable 'Clear filter' option on DataTables
     Search for patron searches
    In-Reply-To: <bug-30607-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30607-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30607-70-NaGS8gIDV3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30607
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30063
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
    [Bug 30063] Make the main patron search use the /patrons REST API route
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:30:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:30:59 +0000
    Subject: [Koha-bugs] [Bug 30063] Make the main patron search use the
     /patrons REST API route
    In-Reply-To: <bug-30063-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30063-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30063-70-xn2XkK04ZD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30607
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30607
    [Bug 30607] Enable 'Clear filter' option on DataTables Search for patron
    searches
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:31:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:31:04 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-ihQyGzeWyf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133776|0                           |1
            is obsolete|                            |
    
    --- Comment #10 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133780
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133780&action=edit
    Bug 30558: 1
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:31:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:31:09 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-KxrVZGvylH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    --- Comment #11 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133781
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133781&action=edit
    Bug 30558: 2
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:31:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:31:51 +0000
    Subject: [Koha-bugs] [Bug 30288] Provide links to OPACUserJS and OPACUserCSS
     from News/HTML customizations
    In-Reply-To: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30288-70-lpf0hEKRty@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Provide links to OPACUserJS |Provide links to OPACUserJS
                       |and OPACUserCSS in tools    |and OPACUserCSS from
                       |                            |News/HTML customizations
    
    --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    It appears like the first patch was already pushed, so only the follow-up is
    needed now:
    
    https://git.koha-community.org/Koha-community/Koha/commit/aa1def3180f8bc2b0d08b0ac2e57bed29e47d27a
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:32:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:32:41 +0000
    Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
     too
    In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28269-70-ioAFlkJ9P2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269
    
    --- Comment #2 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133782
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133782&action=edit
    Bug 28269: Add new system preference SearchWithISSNVariations
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:33:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:33:05 +0000
    Subject: [Koha-bugs] [Bug 30288] Provide links to OPACUserJS and OPACUserCSS
     from News/HTML customizations
    In-Reply-To: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30288-70-7ALCnMb8N0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:33:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:33:10 +0000
    Subject: [Koha-bugs] [Bug 30288] Provide links to OPACUserJS and OPACUserCSS
     from News/HTML customizations
    In-Reply-To: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30288-70-IOuaqhPSGu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133613|0                           |1
            is obsolete|                            |
    
    --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133783
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133783&action=edit
    Bug 30288: (follow-up) Use CSS for separator pipes
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:33:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:33:45 +0000
    Subject: [Koha-bugs] [Bug 30608] New: Add the column picker modal to
     DefaultPatronSearchFields
    Message-ID: <bug-30608-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30608
    
                Bug ID: 30608
               Summary: Add the column picker modal to
                        DefaultPatronSearchFields
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: System Administration
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: martin.renvoize at ptfs-europe.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com
    
    With bug 30576 it becomes more important to ensure we don't get errant data in
    this preference (with a bad column name included here, we will break patron
    searching).
    
    We should add the column picker modal to this system preference.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:34:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:34:00 +0000
    Subject: [Koha-bugs] [Bug 30608] Add the column picker modal to
     DefaultPatronSearchFields
    In-Reply-To: <bug-30608-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30608-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30608-70-xpb2yzsFHJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30608
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |oleonard at myacpl.org
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:34:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:34:07 +0000
    Subject: [Koha-bugs] [Bug 30608] Add the column picker modal to
     DefaultPatronSearchFields
    In-Reply-To: <bug-30608-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30608-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30608-70-OLWGddlIp7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30608
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30576
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:34:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:34:07 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-q3F7lVLw7j@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30608
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:39:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:39:57 +0000
    Subject: [Koha-bugs] [Bug 30587] Incorrect translations in some templates
    In-Reply-To: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30587-70-fU9fHduggU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30587
    
    --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Looking here...
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:41:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:41:41 +0000
    Subject: [Koha-bugs] [Bug 30587] Incorrect translations in some templates
    In-Reply-To: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30587-70-oDpnpxshEk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30587
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:41:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:41:45 +0000
    Subject: [Koha-bugs] [Bug 30587] Incorrect translations in some templates
    In-Reply-To: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30587-70-2g4SdTy1lL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30587
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133770|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133784
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133784&action=edit
    Bug 30587: Fix opac-tags.tt translate issues
    
    This patch addresses one specific case.
    
    To test:
    1. Run:
       $ kshell
      k$ cd misc/translator
      k$ perl translate update es-ES
    2. On your git checkout run:
       $ git diff | grep '\[% limit or'
    => FAIL: That shouldn't be translated
    3. Run:
       $ git reset --hard HEAD
    4. Apply this patch
    5. Repeat 1 and 2
    => SUCCESS: No attempt to translate that tag
    6. Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:41:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:41:50 +0000
    Subject: [Koha-bugs] [Bug 30587] Incorrect translations in some templates
    In-Reply-To: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30587-70-sXId4kQEFu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30587
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133771|0                           |1
            is obsolete|                            |
    
    --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133785
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133785&action=edit
    Bug 30587: Fix acqui/supplier.tt translate issues
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:46:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:46:18 +0000
    Subject: [Koha-bugs] [Bug 23352] Define serial's collection in the
     subscription
    In-Reply-To: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23352-70-mjlBZ1Lbrb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:46:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:46:24 +0000
    Subject: [Koha-bugs] [Bug 23352] Define serial's collection in the
     subscription
    In-Reply-To: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23352-70-jvhuO5AbBs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133679|0                           |1
            is obsolete|                            |
    
    --- Comment #49 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133786
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133786&action=edit
    Bug 23352: Database changes
    
    Sponsored-By: Brimbank Library, Australia
    
    Signed-off-by: Samu Heiskanen <samu.heiskanen at hypernova.fi>
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:46:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:46:29 +0000
    Subject: [Koha-bugs] [Bug 23352] Define serial's collection in the
     subscription
    In-Reply-To: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23352-70-HWnARb72UP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133680|0                           |1
            is obsolete|                            |
    
    --- Comment #50 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133787
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133787&action=edit
    Bug 23352: Updated schema file
    
    Sponsored-By: Brimbank Library, Australia
    
    Signed-off-by: Samu Heiskanen <samu.heiskanen at hypernova.fi>
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:46:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:46:35 +0000
    Subject: [Koha-bugs] [Bug 23352] Define serial's collection in the
     subscription
    In-Reply-To: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23352-70-gj6sYxV6PT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133681|0                           |1
            is obsolete|                            |
    
    --- Comment #51 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133788
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133788&action=edit
    Bug 23352: Set default collection code when creating subscription
    
    The default collection code set in the subscription will be applied if
    item records are created when receiving the serial.
    
    Test plan:
    1. Apply 3 patches
    2. Run updatedatabase.pl and restart services
    3. Create a subscription:
    - Tick the 'Create an item record when receiving this serial' radio
    button
    - Select values in the Location, Collection code and Item type dropdowns
    - Save the subscription
    4. Confirm the Location, and Collection code default values
    you choose in #3 are displaying in the 'Information' tab of page that's
    loaded
    5. Receive the serial:
    - Click 'Receive'
    - Change the status dropdown from 'Expected' to 'Arrived'
    - Confirm the 'Collection Code', 'Shelving location' and 'Koha item
    type' dropdowns are pre-filled with the values you defined in #3
    6. Run unit test t/db_dependent/Serials.t
    
    Sponsored-By: Brimbank Library, Australia
    
    Signed-off-by: Samu Heiskanen <samu.heiskanen at hypernova.fi>
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:46:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:46:41 +0000
    Subject: [Koha-bugs] [Bug 23352] Define serial's collection in the
     subscription
    In-Reply-To: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23352-70-kypq0IbGpQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133682|0                           |1
            is obsolete|                            |
    
    --- Comment #52 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133789
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133789&action=edit
    Bug 23352: (follow-up) Fixes for QA review
    
    Test plan:
    1. Confirm that
    installer/data/mysql/atomicupdate/bug_23352-add_ccode_column_to_subscriptions_table.pl
    has the exec flag
    
    2. Create a subscription. Notice the 'Collection' dropdown defaults to
    the 'None' option - same as Location
    
    3. Save the subscription without changing the 'None' collection
    
    4. Receive the serial and confirm the 'Collection' field is empty
    
    5. Create a second subscription. Change the 'Collection' dropdown to
    'Fiction', then save the subscription
    
    6. Receive the serial and confirm the 'Collection' dropdown is set to
    'Fiction'
    
    7. Confirm that the 'Collection code' terminology in the template is replaced
    with
    'Collection'
    
    Sponsored-By: Brimbank Library, Australia
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:46:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:46:47 +0000
    Subject: [Koha-bugs] [Bug 23352] Define serial's collection in the
     subscription
    In-Reply-To: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23352-70-MNwSKENxFx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133683|0                           |1
            is obsolete|                            |
    
    --- Comment #53 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133790
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133790&action=edit
    Bug 23352: (follow-up) Fix QA test failure
    
    Sponsored-by: Catalyst IT
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:51:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:51:44 +0000
    Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
    In-Reply-To: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23991-70-U5F6e0KT51@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991
    
    --- Comment #51 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    (In reply to Nick Clemens from comment #49)
    > (In reply to Jonathan Druart from comment #41)
    > > I found another weirdness but it's in master as well.
    > > If you have 2 suggestions, branchcodes are 'CPL' and NULL, organize by
    > > "library".
    > > You will see CPL (1) and Any (2).
    > > 
    > > Will fix on a follow-up bug report if it's needed.
    > 
    > Yeah, 'Any' looks like 'All libraries' - we could add a new tab for 'Any' -
    > but another report indeed
    
    I believe it was supposed to work that way... but I don't remember why anymore
    :) So possibly a rename would do?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:59:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:59:47 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-7aTRxVF6vX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133780|0                           |1
            is obsolete|                            |
    
    --- Comment #12 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133791
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133791&action=edit
    Bug 30558: 1
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 15:59:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 13:59:51 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-z7OmzuKwkn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133781|0                           |1
            is obsolete|                            |
    
    --- Comment #13 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133792
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133792&action=edit
    Bug 30558: 2
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:01:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:01:21 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-YoUJxNtFMi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    --- Comment #14 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133793
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133793&action=edit
    Bug 30558: Add one more commit
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:01:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:01:25 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-7QOXABQTWe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133791|0                           |1
            is obsolete|                            |
    
    --- Comment #15 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133794
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133794&action=edit
    Bug 30558: 1
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:01:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:01:29 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-sdgQ9DmR2z@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133792|0                           |1
            is obsolete|                            |
    
    --- Comment #16 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133795
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133795&action=edit
    Bug 30558: 2
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:02:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:02:08 +0000
    Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
     too
    In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28269-70-h4YhnPxUjx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133782|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133796
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133796&action=edit
    Bug 28269: Add new system preference SearchWithISSNVariations
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:04:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:04:29 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-bnFiVQn0oT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133793|0                           |1
            is obsolete|                            |
    
    --- Comment #17 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133797
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133797&action=edit
    Bug 30558: Add one more commit
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:04:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:04:33 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-CIWjDZcZkP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133794|0                           |1
            is obsolete|                            |
    
    --- Comment #18 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133798
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133798&action=edit
    Bug 30558: 1
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:04:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:04:38 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-zAuo2UamQ0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133795|0                           |1
            is obsolete|                            |
    
    --- Comment #19 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133799
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133799&action=edit
    Bug 30558: 2
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:09:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:09:00 +0000
    Subject: [Koha-bugs] [Bug 30609] New: Reindent serial claims template
    Message-ID: <bug-30609-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30609
    
                Bug ID: 30609
               Summary: Reindent serial claims template
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: enhancement
              Priority: P5 - low
             Component: Templates
              Assignee: oleonard at myacpl.org
              Reporter: oleonard at myacpl.org
            QA Contact: testopia at bugs.koha-community.org
    
    I propose to reformat the serial claims template in the staff interface
    (claims.tt) so that it has consistent spacing and indentation.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:09:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:09:20 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-TxePMHZ0Hp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133741|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:09:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:09:49 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-CdOZMn8yF6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133742|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:10:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:10:18 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-czYTs46EaU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133743|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:10:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:10:46 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-BNSYx5s7vp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133744|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:10:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:10:55 +0000
    Subject: [Koha-bugs] [Bug 30584] Cannot add field mappings to Elasticsearch
     configuration
    In-Reply-To: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30584-70-n83U41WXPw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584
    
    --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Holding of on release of 21.11.05 until this has been pushed to master so I can
    backport it.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:11:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:11:16 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-2EmgIO0LrP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133745|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:11:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:11:44 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-b8BBcCWGCg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133746|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:12:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:12:15 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-d2nCIQE1nc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133747|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:12:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:12:43 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-CKdYwymU3D@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133748|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:15:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:15:28 +0000
    Subject: [Koha-bugs] [Bug 30584] Cannot add field mappings to Elasticsearch
     configuration
    In-Reply-To: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30584-70-H7DO9adjAU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:15:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:15:32 +0000
    Subject: [Koha-bugs] [Bug 30584] Cannot add field mappings to Elasticsearch
     configuration
    In-Reply-To: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30584-70-mclMPjYr3O@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133657|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133800
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133800&action=edit
    Bug 30584: Fix ES mapping creation
    
    We need to tell DT that we are adding/removing row, not only deal
    manually with the DOM.
    
    This patch also fixes the following bug: if you add or remove a row from
    the "biblio" tab, then go to another tab and back to "biblio", all
    changes were gone (bug existed prior to bug 29893).
    
    Test plan:
    Add, edit and remove mappings, switch from tabs and save.
    Use the filters, save (29893 regression test)
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:29:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:29:05 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-bnGyIQmjKr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    --- Comment #73 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133801
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133801&action=edit
    Bug 29924: Database updates
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:29:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:29:34 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-g441AJYVpc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    --- Comment #74 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133802
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133802&action=edit
    Bug 29924: Add password expiration feature
    
    This patch adds the ability to define password_expiry_days for a patron
    category.
    
    When defined a patron's password will expire after X days and they will
    be required to reset their password. If OPAC resets are enabled for the
    catgeory they may do so on their own, otherwise they will need to
    contact the library
    
    To test:
     1 - Apply patch, updatedatabase
     2 - Set 'Password expiration' for a patron category
         Home-> Administration-> Patron categories-> Edit
     3 - Create a new patron in this category with a userid/password set,
         and an email
     4 - Confirm their password_expiration_date field is set
         SELECT password_expiration_date FROM borrowers WHERE borrowernumber=51;
     5 - Create a new patron, do not set a password
     6 - Confirm their password_expiration_date field is NULL
     7 - Update the patron with an expiration to be expired
         UPDATE borrowers SET password_expiration_date='2022-01-01' WHERE
    borrowernumber=51;
     8 - Give the borrower catalogue permission
     9 - Attempt to log in to Straff interface
    10 - Confirm you are signed out and notified that password must be
         reset
    11 - Attempt to sign in to OPAC
    12 - Confirm you are signed out and notified password must be reset
    13 - Enable password reset for the patron's category and perform a
         password reset
         Note: you will have to find the link in the message_queue unless
         you have emails setup on your test environment
         SELECT * FROM message_queue WHERE borrowernumber=51;
    14 - Confirm that you can now sign in and password_expiration_date field
         is set 10 days in the future
    15 - Expire the patron's password again
    16 - Change the patron's password via the staff interface
    17 - Confirm they can sign in and the expiration is updated
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:30:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:30:01 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-qP9DkAWMea@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    --- Comment #75 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133803
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133803&action=edit
    Bug 29924: Unit tests
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:30:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:30:40 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-f9AFMqpQln@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    --- Comment #76 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133804
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133804&action=edit
    Bug 29924: (follow-up) Add bug number to atomicupdate; Style OPAC message
    
    - The atomicupdate didn't have "bug_number" defined.
    - The "Your password has expired" message is now styled with the same
      class as other OPAC login messages.
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:31:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:31:17 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-PyekPQofTw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    --- Comment #77 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133805
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133805&action=edit
    Bug 29924: (follow-up) Add password_expiration_date to API
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:31:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:31:40 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-CyE38h4kfM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    --- Comment #78 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133806
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133806&action=edit
    Bug 29924: (follow-up) Add default value undef for TestBuilder
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:32:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:32:02 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-ZjzluHj3xN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    --- Comment #79 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133807
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133807&action=edit
    Bug 29924: Update ILSDI to be aware of expired passwords
    
    To test:
    1 - Enable ILSDI
    2 - Set a patron password with expired password
    3 -
    http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=AuthenticatePatron&username=usernam&password=password
    4 - Confirm 'PasswordExpired' returned
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:32:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:32:35 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-wxoYYxz0oD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    --- Comment #80 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133808
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133808&action=edit
    Bug 29924: DO NOT PUSH - Schema updates
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:32:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:32:57 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-jgk8a4CFMp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    --- Comment #81 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133809
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133809&action=edit
    Bug 29924: (QA follow-up) Remove password_expiration_date from API
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:33:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:33:24 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-i0ubqKm76Z@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    --- Comment #82 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133810
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133810&action=edit
    Bug 29924: Add tests for API Basic auth behavior
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:33:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:33:47 +0000
    Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
     too
    In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28269-70-RRcAVKUn1U@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133796|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:34:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:34:21 +0000
    Subject: [Koha-bugs] [Bug 29926] Add ability for superlibrarians to edit
     password expiration dates
    In-Reply-To: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29926-70-iLzLyudVt1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29926
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                       |y.org                       |
                     CC|                            |tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:35:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:35:50 +0000
    Subject: [Koha-bugs] [Bug 30610] New: The 'Print receipt' button on cash
     management registers page fails on second datatables page
    Message-ID: <bug-30610-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30610
    
                Bug ID: 30610
               Summary: The 'Print receipt' button on cash management
                        registers page fails on second datatables page
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Staff Client
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: martin.renvoize at ptfs-europe.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com
    
    On the register details page in cash management, we display a table of
    transactions.
    
    Right now, the printReceipt button is bound to tightly and as such when you
    navigate around the transactions table and onto the second page of results the
    "Print receipt" button stops working.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:35:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:35:58 +0000
    Subject: [Koha-bugs] [Bug 30610] The 'Print receipt' button on cash
     management registers page fails on second datatables page
    In-Reply-To: <bug-30610-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30610-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30610-70-MAf4cX2Zl0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30610
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                       |ity.org                     |.com
               Severity|enhancement                 |major
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:40:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:40:21 +0000
    Subject: [Koha-bugs] [Bug 30610] The 'Print receipt' button on cash
     management registers page fails on second datatables page
    In-Reply-To: <bug-30610-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30610-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30610-70-bFvP7zuPsW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30610
    
    --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133811
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133811&action=edit
    Bug 30610: Update on click binding for print receipt
    
    This patch updates the binding for the on click even of the print
    receipt button so that subsequent pages in the datatable work with the
    reciept printing button.
    
    Test plan
    1) Enable cash management and process enough transactions to display
       more than one page of transactions in the register details page.
    2) Confirm the 'Print receipt' button works on the first page of
       transactions
    3) Confirm the 'Print receipt' button works on subsequent transactions
       pages in the datatable.
    4) Confirm the same for the past transactions table.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:40:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:40:36 +0000
    Subject: [Koha-bugs] [Bug 30610] The 'Print receipt' button on cash
     management registers page fails on second datatables page
    In-Reply-To: <bug-30610-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30610-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30610-70-0HiRBwf4U7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30610
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:43:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:43:36 +0000
    Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired
     waiting holds to fill the next hold
    In-Reply-To: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14364-70-KduDv3hQjr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:43:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:43:42 +0000
    Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired
     waiting holds to fill the next hold
    In-Reply-To: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14364-70-vzCqk8QQ8E@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364
    
    --- Comment #59 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133812
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133812&action=edit
    Bug 14364: Fix spelling and tests
    
    Moved the installer to pl file
    Adjusted capitalization / reply-to
    Fix tests by importing needed fuction and adjusting a wrong call
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:46:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:46:20 +0000
    Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their
     patron messages
    In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-12029-70-Khaq8ahoKB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
    
    --- Comment #28 from Christopher Brannon <cbrannon at cdalibrary.org> ---
    Auto-Parallel, who wrote the patch, is supposed to be uploading the unit tests.
     We are waiting for them to do this.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:51:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:51:00 +0000
    Subject: [Koha-bugs] [Bug 22490] Some strings in JavaScript files are
     untranslatable
    In-Reply-To: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22490-70-tAFq2ebGJy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22490
    
    --- Comment #7 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> ---
    Created attachment 133813
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133813&action=edit
    Bug 22490: Some strings in JavaScript files are untranslatable
    
    This patch updates the translation functions of the strings in Javascript files
    
    Test Plan:
    1) Find a string in a popup or from a Javascript file who is still not
    translated
    or
    1) Home > Administration > Authority types
    2) Make sure to have at least one Authority type saved
    3) Click on Action > Import
    4) Import button without adding any file to trigger the popup
    5) The string inside the popup appears without translation
    6) Apply patch and repeat from 3) to 5) : now the string is translated
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 16:51:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 14:51:28 +0000
    Subject: [Koha-bugs] [Bug 22490] Some strings in JavaScript files are
     untranslatable
    In-Reply-To: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22490-70-RQKsn7mX5z@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22490
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
                     CC|                            |jeremy.breuillard at biblibre.
                       |                            |com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 17:01:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 15:01:03 +0000
    Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their
     patron messages
    In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-12029-70-9NqZXC0Phe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
    
    --- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Thx for the update, Christopher. 
    
    If we could get the unit tests within the next few days, we still might make
    the release.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 17:10:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 15:10:17 +0000
    Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
    In-Reply-To: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23991-70-1r0hy5Vqfm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Failed QA
    
    --- Comment #52 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    I have 2 suggestions for Centerville, both are Pending and archived.
    
    On master, I can make them display by choosing "Include archived" and starting
    the search:
    
    http://localhost:8081/cgi-bin/koha/suggestion/suggestion.pl?branchcode=CPL&displayby=branchcode&title=&author=&isbn=&publishercode=©rightdate=&collectiontitle=&filter_archived=on&STATUS=&suggestedby=&suggesteddate_from=&suggesteddate_to=&managedby=&manageddate_from=&manageddate_to=&acceptedby=&accepteddate_from=&accepteddate_to=&budgetid=__ANY__
    
    This doesn't work with the patch set applied. I can't get archived suggestions
    to display.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 17:22:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 15:22:21 +0000
    Subject: [Koha-bugs] [Bug 30611] New: Add ability to send passwordreseturl
     in the Welcome email
    Message-ID: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611
    
                Bug ID: 30611
               Summary: Add ability to send passwordreseturl in the Welcome
                        email
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Patrons
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: martin.renvoize at ptfs-europe.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
    
    With the removal of the ability to include the plaintext password in the
    acctdetails, now welcome, notice it would be great to give patrons another
    option for setting their login details.
    
    We have the ability to reset forgotten passwords from the OPAC using a limited
    time token embedded in a URL. It would be great to have the same option in the
    WELCOME notice.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 17:22:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 15:22:35 +0000
    Subject: [Koha-bugs] [Bug 30254] New overdue fine applied to incorrectly
     when using "Refund lost item charge and charge new overdue fine" option in
     circ rules
    In-Reply-To: <bug-30254-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30254-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30254-70-LfNDPp5u6q@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30254
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Version|21.05                       |master
    
    --- Comment #1 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Confirmed in master. To recreate:
    1 - set Lost item fee refund on return policy to "Refund lost item charge and
    charge new overdue fine", turn on FinesMode, make sure your circ rules charge
    fines
    2 - have an itemtype / patron combo that charges an overdue fine
    3 - check item out (with a due date in the future) and then right back in again
    4 - confirm patron doesn't have a fine because the item was not late
    5 - set the item to Lost
    6 - in the database, edit the date_due of your checkout to a date in the past
    7 - check the item in, it is marked found
    8 - confirm your patron now has a fine
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 17:22:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 15:22:38 +0000
    Subject: [Koha-bugs] [Bug 30611] Add ability to send passwordreseturl in the
     Welcome email
    In-Reply-To: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30611-70-Cq9NB38Rda@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |9097
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097
    [Bug 9097] Add option to trigger 'Welcome mail' manually
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 17:22:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 15:22:38 +0000
    Subject: [Koha-bugs] [Bug 9097] Add option to trigger 'Welcome mail' manually
    In-Reply-To: <bug-9097-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-9097-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-9097-70-1RcRJnomxs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30611
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611
    [Bug 30611] Add ability to send passwordreseturl in the Welcome email
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 17:23:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 15:23:52 +0000
    Subject: [Koha-bugs] [Bug 30611] Add ability to send passwordreseturl in the
     Welcome email
    In-Reply-To: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30611-70-SHqbGjVR5H@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611
    
    --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Should this be part of the 'WELCOME' notice, or should it be it's own notice
    entirely which can be triggered independently from the various places the
    welcome notice can be triggered?
    
    Perhaps it could be an optional part of the welcome notice that is picked at
    the trigger time?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 17:23:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 15:23:58 +0000
    Subject: [Koha-bugs] [Bug 30611] Add ability to send passwordreseturl in the
     Welcome email
    In-Reply-To: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30611-70-jVT93QXmtO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                       |ity.org                     |.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 17:48:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 15:48:01 +0000
    Subject: [Koha-bugs] [Bug 30611] Add ability to send passwordreseturl in the
     Welcome email
    In-Reply-To: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30611-70-ojGGZUaH65@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611
    
    --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    I think maybe it would make sense to have an option to trigger the password
    reset email manually instead. 
    
    The validity of the password reset URLs is limited, so it might be better to
    point people to the feature itself, maybe by including a direct link to the
    password request form.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 18:04:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 16:04:43 +0000
    Subject: [Koha-bugs] [Bug 30597] Update wording of RestrictionBlockRenewing
     to include auto-renew
    In-Reply-To: <bug-30597-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30597-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30597-70-zfxE1PIcHn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30597
    
    Rebecca Coert <rcoert at arlingtonva.us> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |rcoert at arlingtonva.us
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 18:05:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 16:05:27 +0000
    Subject: [Koha-bugs] [Bug 28138] Add system preference to make the payment
     type required
    In-Reply-To: <bug-28138-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28138-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28138-70-zU6MvYCY7V@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28138
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 18:05:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 16:05:31 +0000
    Subject: [Koha-bugs] [Bug 28138] Add system preference to make the payment
     type required
    In-Reply-To: <bug-28138-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28138-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28138-70-B2fIbp1i3w@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28138
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133609|0                           |1
            is obsolete|                            |
    
    --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133814
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133814&action=edit
    Bug 28138: Add syspref to make the payment type required
    
    The payment type is already required when using the cash register
    feature, but some users want to force selecting a payment type even
    when cash registers are not used
    
    The new system preference name is RequirePaymentType
    
    Test plan:
    1. Apply patch and run updatedatabase.pl
    2. Disable UseCashRegisters and RequirePaymentType sysprefs
    3. Create some authorised values in PAYMENT_TYPE category if needed
    4. Create a manual invoice and pay it. Notice that the payment type is
       optional.
    5. Enable RequirePaymentType
    6. Create a manual invoice and pay it. Notice that the payment type is
       now required.
    7. Enable UseCashRegisters and verify that the payment type is always
       required, even if RequirePaymentType is disabled
    
    Rebased by Thibaud Guillot <thibaud.guillot at biblibre.com> on 21-12-02
    
    Signed-off-by: shiyao <shiyao at inlibro.com>
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 18:05:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 16:05:36 +0000
    Subject: [Koha-bugs] [Bug 28138] Add system preference to make the payment
     type required
    In-Reply-To: <bug-28138-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28138-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28138-70-xTAXNjPUVe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28138
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133610|0                           |1
            is obsolete|                            |
    
    --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133815
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133815&action=edit
    Bug 28138: (follow-up) New atomic update
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 18:05:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 16:05:41 +0000
    Subject: [Koha-bugs] [Bug 28138] Add system preference to make the payment
     type required
    In-Reply-To: <bug-28138-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28138-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28138-70-PbLSQdKIS3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28138
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133611|0                           |1
            is obsolete|                            |
    
    --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133816
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133816&action=edit
    Bug 28138: (follow-up) Add empty option to payment type selection
    
    This patch adds an empty <option> to the "Payment type" selection when
    paying fine. This forces the user to actively make a selection. I've
    also added the text "None selected" to the other empty <option> on the
    page for consistency.
    
    To test, apply the patch and test the pay fine interface with and
    without the RequirePaymentType preference enabled. When enabled the
    payment type should be required and it should default to "None
    selected."
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 18:05:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 16:05:46 +0000
    Subject: [Koha-bugs] [Bug 28138] Add system preference to make the payment
     type required
    In-Reply-To: <bug-28138-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28138-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28138-70-NC81topaTk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28138
    
    --- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133817
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133817&action=edit
    Bug 28138: (QA follow-up) Slight rephrase of system preference text
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 18:06:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 16:06:16 +0000
    Subject: [Koha-bugs] [Bug 29704] Holds reminder emails should allow
     configuration for a specific number of days
    In-Reply-To: <bug-29704-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29704-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29704-70-djrADAKzo2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704
    
    Rebecca Coert <rcoert at arlingtonva.us> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |rcoert at arlingtonva.us
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 18:16:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 16:16:16 +0000
    Subject: [Koha-bugs] [Bug 30180] Deprecate after_hold_create hook
    In-Reply-To: <bug-30180-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30180-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30180-70-DHNrvDtH0i@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30180
    
    --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    How can we keep an eye on the need to remove the hook for 22.11? A new bug?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 18:17:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 16:17:24 +0000
    Subject: [Koha-bugs] [Bug 30180] Deprecate after_hold_create hook
    In-Reply-To: <bug-30180-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30180-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30180-70-Soy3nFg5KX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30180
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 18:17:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 16:17:29 +0000
    Subject: [Koha-bugs] [Bug 30180] Deprecate after_hold_create hook
    In-Reply-To: <bug-30180-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30180-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30180-70-NytBXL0M2f@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30180
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133415|0                           |1
            is obsolete|                            |
    
    --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133818
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133818&action=edit
    Bug 30180: Unit tests
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 18:17:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 16:17:33 +0000
    Subject: [Koha-bugs] [Bug 30180] Deprecate after_hold_create hook
    In-Reply-To: <bug-30180-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30180-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30180-70-l7NjTxQMYs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30180
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133416|0                           |1
            is obsolete|                            |
    
    --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133819
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133819&action=edit
    Bug 30180: Add 'placed' after_hold_hook
    
    This patch adds a new 'after_hold_action' hook, that is called with the
    'placed' action parameter.
    
    To test:
    1. Apply the unit tests patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Plugins/Holds_hooks.t
    => FAIL: Boo, the hook is not called
    3. Apply this patch
    4. Repeat 2
    => SUCCESS: Tests pass!
    5. Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 18:17:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 16:17:38 +0000
    Subject: [Koha-bugs] [Bug 30180] Deprecate after_hold_create hook
    In-Reply-To: <bug-30180-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30180-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30180-70-Pbe6vjWWyx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30180
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133417|0                           |1
            is obsolete|                            |
    
    --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133820
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133820&action=edit
    Bug 30180: (follow-up) Add temporary deprecation warning
    
    This patch adds a temporary deprecation warning to let users know the
    plugin needs to get updated before the next release.
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Plugins/Holds_hooks.t
    => SUCCESS: Tests pass, warning is displayed
    3. Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 18:40:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 16:40:28 +0000
    Subject: [Koha-bugs] [Bug 28138] Add system preference to make the payment
     type required
    In-Reply-To: <bug-28138-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28138-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28138-70-17iqcuNs2v@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28138
    
    --- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133821
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133821&action=edit
    Bug 28138: (QA follow-up) Link system preference in new system preference
    description
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 18:51:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 16:51:50 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-ZHNv7x74wX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133797|0                           |1
            is obsolete|                            |
    
    --- Comment #20 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133822
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133822&action=edit
    Bug 30558: Add one more commit
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 18:51:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 16:51:54 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-r1mU5rqCDC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133798|0                           |1
            is obsolete|                            |
    
    --- Comment #21 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133823
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133823&action=edit
    Bug 30558: 1
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 18:51:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 16:51:59 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-9Z3e7bb4Yd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133799|0                           |1
            is obsolete|                            |
    
    --- Comment #22 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133824
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133824&action=edit
    Bug 30558: 2
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 18:53:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 16:53:44 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-VqGCFVUAw6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133822|0                           |1
            is obsolete|                            |
    
    --- Comment #23 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133825
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133825&action=edit
    Bug 30558: Add one more commit
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 18:53:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 16:53:48 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-69uFWkGIs7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    --- Comment #24 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133826
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133826&action=edit
    Bug 30558: 1 test messages
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 18:53:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 16:53:53 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-oaBQN6xyfQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    --- Comment #25 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133827
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133827&action=edit
    Bug 30558: 2 ok test
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 18:58:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 16:58:09 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-wSVDHH5hUE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133823|0                           |1
            is obsolete|                            |
     Attachment #133824|0                           |1
            is obsolete|                            |
     Attachment #133825|0                           |1
            is obsolete|                            |
     Attachment #133826|0                           |1
            is obsolete|                            |
     Attachment #133827|0                           |1
            is obsolete|                            |
    
    --- Comment #26 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133828
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133828&action=edit
    Bug 30558: Add one more commit
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 18:58:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 16:58:13 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-eD5mqBVGme@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    --- Comment #27 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133829
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133829&action=edit
    Bug 30558: 1 test messages
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 18:58:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 16:58:17 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-BH3yoQy5dg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    --- Comment #28 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133830
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133830&action=edit
    Bug 30558: 2 ok test
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 19:15:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 17:15:41 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-uJChZiA7p7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133828|0                           |1
            is obsolete|                            |
     Attachment #133829|0                           |1
            is obsolete|                            |
     Attachment #133830|0                           |1
            is obsolete|                            |
    
    --- Comment #29 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133831
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133831&action=edit
    Bug 30558: Add new system preference SearchWithISSNVariations
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 19:17:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 17:17:34 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-syYvAtoQK7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133831|0                           |1
            is obsolete|                            |
    
    --- Comment #30 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133832
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133832&action=edit
    Bug 30558: Add new system preference SearchWithISSNVariations
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 19:19:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 17:19:56 +0000
    Subject: [Koha-bugs] [Bug 15461] Add staff equivalent for
     OpacLocationOnDetail
    In-Reply-To: <bug-15461-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-15461-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-15461-70-Z0ro6CLFAE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461
    
    Noémie Labine <noemie.labine at collecto.ca> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |noemie.labine at collecto.ca
    
    --- Comment #4 from Noémie Labine <noemie.labine at collecto.ca> ---
    +1
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 19:21:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 17:21:42 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-n03orxof7E@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133832|0                           |1
            is obsolete|                            |
    
    --- Comment #31 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133833
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133833&action=edit
    Bug 30558: Add new system preference SearchWithISSNVariations
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 19:23:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 17:23:35 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-fKdp1NEC8s@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133833|0                           |1
            is obsolete|                            |
    
    --- Comment #32 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133834
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133834&action=edit
    Bug 30558: Add new system preference SearchWithISSNVariations
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 19:23:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 17:23:40 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-1he6zdDJaR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    --- Comment #33 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133835
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133835&action=edit
    Bug 30558: Add feature to search Acquisitions Orders by ISSN
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 19:23:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 17:23:44 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-gZ5LtofclG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    --- Comment #34 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133836
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133836&action=edit
    Bug 30558: Add tests for Acquisitions Orders search by ISSN
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 19:32:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 17:32:40 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-eHAwHUeqo9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133836|0                           |1
            is obsolete|                            |
    
    --- Comment #35 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133837
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133837&action=edit
    Bug 30558: Add tests for Acquisitions Orders search by ISSN
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 19:38:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 17:38:11 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-vhMlVA7mrY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133834|0                           |1
            is obsolete|                            |
    
    --- Comment #36 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133838
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133838&action=edit
    Bug 30558: Add new system preference SearchWithISSNVariations
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 19:38:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 17:38:17 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-MoMERBX13E@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133835|0                           |1
            is obsolete|                            |
    
    --- Comment #37 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133839
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133839&action=edit
    Bug 30558: Add feature to search Acquisitions Orders by ISSN
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 19:38:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 17:38:22 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-zJQqRhHA9H@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133837|0                           |1
            is obsolete|                            |
    
    --- Comment #38 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133840
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133840&action=edit
    Bug 30558: Add tests for Acquisitions Orders search by ISSN
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 19:39:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 17:39:09 +0000
    Subject: [Koha-bugs] [Bug 30612] New: Add accountlines method to
     Koha::Checkout and Koha::Old::Checkout
    Message-ID: <bug-30612-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30612
    
                Bug ID: 30612
               Summary: Add accountlines method to Koha::Checkout and
                        Koha::Old::Checkout
     Change sponsored?: ---
               Product: Koha
               Version: 21.05
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Architecture, internals, and plumbing
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: kyle at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
    
    It would be very useful to have an accountlines method on checkouts objects. In
    particular it would make fees related to a checkout available from the checkout
    objects in overdue notices.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 19:39:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 17:39:16 +0000
    Subject: [Koha-bugs] [Bug 30612] Add accountlines method to Koha::Checkout
     and Koha::Old::Checkout
    In-Reply-To: <bug-30612-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30612-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30612-70-VsGpOFZLVM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30612
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Version|21.05                       |master
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 19:39:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 17:39:20 +0000
    Subject: [Koha-bugs] [Bug 30612] Add accountlines method to Koha::Checkout
     and Koha::Old::Checkout
    In-Reply-To: <bug-30612-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30612-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30612-70-ITH7K0xwzm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30612
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                       |ity.org                     |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 19:40:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 17:40:25 +0000
    Subject: [Koha-bugs] [Bug 30612] Add accountlines method to Koha::Checkout
     and Koha::Old::Checkout
    In-Reply-To: <bug-30612-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30612-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30612-70-tBxPIsqJ9h@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30612
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 19:40:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 17:40:28 +0000
    Subject: [Koha-bugs] [Bug 30612] Add accountlines method to Koha::Checkout
     and Koha::Old::Checkout
    In-Reply-To: <bug-30612-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30612-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30612-70-DXpwMZOIVU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30612
    
    --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Created attachment 133841
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133841&action=edit
    Bug 30612: Add accountlines method to Koha::Checkout and Koha::Old::Checkout
    
    It would be very useful to have an accountlines method on checkouts objects. In
    particular it would make fees related to a checkout available from the checkout
    objects in overdue notices.
    
    Test Plan:
    1) Apply this patch
    2) prove t/db_dependent/Koha/Account/Line.t
    3) prove t/db_dependent/Koha/Checkouts.t
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 19:41:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 17:41:11 +0000
    Subject: [Koha-bugs] [Bug 30612] Add accountlines method to Koha::Checkout
     and Koha::Old::Checkout
    In-Reply-To: <bug-30612-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30612-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30612-70-4K8TGG1HcL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30612
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lucas at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 19:43:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 17:43:14 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-JeKY4Fitv0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    --- Comment #39 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133842
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133842&action=edit
    Bug 30558: test commit - test sub
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 19:52:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 17:52:05 +0000
    Subject: [Koha-bugs] [Bug 30613] New: Hide RSS feed link when viewing
     private list in the OPAC
    Message-ID: <bug-30613-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30613
    
                Bug ID: 30613
               Summary: Hide RSS feed link when viewing private list in the
                        OPAC
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: minor
              Priority: P5 - low
             Component: OPAC
              Assignee: oleonard at myacpl.org
              Reporter: oleonard at myacpl.org
            QA Contact: testopia at bugs.koha-community.org
    
    Koha requires that you be logged in to the OPAC in order to view a private
    list. This is true from the RSS view of a private list as well. We don't
    provide an alternative authentication method to enable access by RSS readers.
    
    Unless and until someone develops a means to provide RSS access to private
    lists it is logical to hide the RSS icon when viewing a private list.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 19:58:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 17:58:37 +0000
    Subject: [Koha-bugs] [Bug 30610] The 'Print receipt' button on cash
     management registers page fails on second datatables page
    In-Reply-To: <bug-30610-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30610-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30610-70-u1oEatcJWl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30610
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
       Patch complexity|---                         |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 19:58:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 17:58:40 +0000
    Subject: [Koha-bugs] [Bug 30610] The 'Print receipt' button on cash
     management registers page fails on second datatables page
    In-Reply-To: <bug-30610-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30610-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30610-70-OMx7oGR9Jd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30610
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133811|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133843
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133843&action=edit
    Bug 30610: Update on click binding for print receipt
    
    This patch updates the binding for the on click even of the print
    receipt button so that subsequent pages in the datatable work with the
    reciept printing button.
    
    Test plan
    1) Enable cash management and process enough transactions to display
       more than one page of transactions in the register details page.
    2) Confirm the 'Print receipt' button works on the first page of
       transactions
    3) Confirm the 'Print receipt' button works on subsequent transactions
       pages in the datatable.
    4) Confirm the same for the past transactions table.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 20:20:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 18:20:07 +0000
    Subject: [Koha-bugs] [Bug 30532] guided_reports.pl has a problem
    In-Reply-To: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30532-70-tcpr9glrM6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30532
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|,21.11.05                   |22.05.00,21.11.05
            released in|                            |
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 20:38:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 18:38:18 +0000
    Subject: [Koha-bugs] [Bug 30402] Authority import hanging when replacing
     matched record
    In-Reply-To: <bug-30402-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30402-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30402-70-q72RXZFkTm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30402
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                     CC|                            |andrew at bywatersolutions.com
                 Status|Pushed to stable            |RESOLVED
    
    --- Comment #7 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Missing dependency, not backported to 21.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 20:39:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 18:39:22 +0000
    Subject: [Koha-bugs] [Bug 29787] Add plugin version to plugin search results
    In-Reply-To: <bug-29787-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29787-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29787-70-SykvenmfL1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29787
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to stable            |RESOLVED
             Resolution|---                         |FIXED
    
    --- Comment #12 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    not backported to 21.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 20:44:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 18:44:43 +0000
    Subject: [Koha-bugs] [Bug 30118] holds_block_checkin behavior is different
     in Koha and in SIP
    In-Reply-To: <bug-30118-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30118-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30118-70-BdTaEP6frC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30118
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|22.05.00,21.11.05           |22.05.00,21.11.05,21.05.14
            released in|                            |
                 Status|Pushed to stable            |Pushed to oldstable
                     CC|                            |andrew at bywatersolutions.com
    
    --- Comment #8 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Pushed to 21.05.x for 21.05.14
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 21:05:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 19:05:54 +0000
    Subject: [Koha-bugs] [Bug 30583] Hold system broken for translated template
    In-Reply-To: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30583-70-sLwaAR4FjU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30583
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |Pushed to stable
             Version(s)|22.05.00                    |22.05.00,21.11.05
            released in|                            |
    
    --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 21:23:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 19:23:25 +0000
    Subject: [Koha-bugs] [Bug 29915] Anonymous session generates 1 new session
     ID per hit
    In-Reply-To: <bug-29915-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29915-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29915-70-pCTSFO4fF5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29915
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |andrew at bywatersolutions.com
    
    --- Comment #128 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    I've been unable to get this to apply to 21.05. Please rebase for backport.
    Thanks!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 21:25:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 19:25:08 +0000
    Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on
     fresh install, but can be null with upgrade
    In-Reply-To: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27253-70-TjFz9NvF1k@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253
    
    --- Comment #22 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    (In reply to Marcel de Rooy from comment #19)
    > (In reply to Fridolin Somers from comment #13)
    > > May I revert ?
    > 
    > Push the follow-up please.
    
    Done
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 21:25:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 19:25:28 +0000
    Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on
     fresh install, but can be null with upgrade
    In-Reply-To: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27253-70-fAETXvjOCP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 21:28:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 19:28:44 +0000
    Subject: [Koha-bugs] [Bug 29957] Cookies not removed after logout
    In-Reply-To: <bug-29957-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29957-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29957-70-8uzXjLuBNU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29957
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |andrew at bywatersolutions.com
    
    --- Comment #126 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    I can't get this to apply to 21.05 for backport. Please rebase. Some of this
    code has been touched by bug 29915, which I was also unable to apply and
    backport.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 21:31:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 19:31:18 +0000
    Subject: [Koha-bugs] [Bug 30614] New: check-url-quick gives false error 404
    Message-ID: <bug-30614-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30614
    
                Bug ID: 30614
               Summary: check-url-quick gives false error 404
     Change sponsored?: ---
               Product: Koha
               Version: 20.05
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Architecture, internals, and plumbing
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: marjorie.barry-vila at collecto.ca
            QA Contact: testopia at bugs.koha-community.org
    
    Hi,
    
    Many 404 errors come out after running the check-quick-url script while the
    urls are correct when checked manually. 
    Apparently this is because the script uses HTTP HEAD instead of HTTP GET.
    HTTP HEAD returns only the headers of the urls and the header can return an
    error but the url is accessible when you do a GET.
    
    Is there a reason for this?
    
    My fellow analyst was pointing to line 104 of
    https://github.com/Koha-Community/Koha/blob/master/misc/cronjobs/check-url-quick.pl
    
    Thank you
    Marjorie
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 21:35:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 19:35:52 +0000
    Subject: [Koha-bugs] [Bug 30583] Hold system broken for translated template
    In-Reply-To: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30583-70-SAizQDM9Nr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30583
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to stable            |Pushed to oldstable
             Version(s)|22.05.00,21.11.05           |22.05.00,21.11.05,21.05.14
            released in|                            |
    
    --- Comment #8 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Pushed to 21.05.x for 21.05.14
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 21:39:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 19:39:57 +0000
    Subject: [Koha-bugs] [Bug 30288] Provide links to OPACUserJS and OPACUserCSS
     from News/HTML customizations
    In-Reply-To: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30288-70-BZAG1GTHer@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288
    
    --- Comment #15 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    (In reply to Katrin Fischer from comment #13)
    > It appears like the first patch was already pushed, so only the follow-up is
    > needed now:
    > 
    > https://git.koha-community.org/Koha-community/Koha/commit/
    > aa1def3180f8bc2b0d08b0ac2e57bed29e47d27a
    
    Oups sorry for that.
    
    I've pushed follow-up and will update status.
    
    Very nice btw ;)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 21:41:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 19:41:00 +0000
    Subject: [Koha-bugs] [Bug 30461] Batch authority tool is broken
    In-Reply-To: <bug-30461-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30461-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30461-70-x5hiYVrPbo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30461
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
       Patch complexity|---                         |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 21:44:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 19:44:44 +0000
    Subject: [Koha-bugs] [Bug 30615] New: Wrong URL to OAI-PMH-Tutorial
    Message-ID: <bug-30615-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30615
    
                Bug ID: 30615
               Summary: Wrong URL to OAI-PMH-Tutorial
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Documentation
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: michaela.sieber at kit.edu
            QA Contact: testopia at bugs.koha-community.org
    
    Wrong URL to OAI-PMH-Tutorial in Koha manual
    
    https://koha-community.org/manual/21.05/en/html/webservices.html#oai-pmh 
    
    second paragraph, last sentence: "Visit
    http://www.oaforum.org/tutorial/english/page3.htm for diagrams of how OAI-PMH
    works."
    
    
    See official Website: 
    https://www.openarchives.org/documents/
    
    Tutorials and Primers: OAI for Beginners - the Open Archives Forum online
    tutorial -- No longer live at http://www.oaforum.org/tutorial/ but available
    from the Internet Archive.
    
    New URL:
    https://web.archive.org/web/20171221103825/http://www.oaforum.org/tutorial/
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 21:53:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 19:53:42 +0000
    Subject: [Koha-bugs] [Bug 29771] Get rid of CGI::param in list context
     warnings
    In-Reply-To: <bug-29771-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29771-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29771-70-MRnvv0WbFp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |andrew at bywatersolutions.com
             Version(s)|22.05.00,21.11.04           |22.05.00,21.11.04,21.05.14
            released in|                            |
                 Status|Pushed to stable            |Pushed to oldstable
    
    --- Comment #15 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Pushed to 21.05.x for 21.05.14
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 21:53:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 19:53:49 +0000
    Subject: [Koha-bugs] [Bug 22223] Item url double-encode when parameter is an
     encoded URL
    In-Reply-To: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22223-70-HDalrDC9XI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22223
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
    
    --- Comment #38 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    > This is just a POC
    No push to master then ?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 21:55:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 19:55:55 +0000
    Subject: [Koha-bugs] [Bug 19169] Add a test to detect unneeded
     'atomicupdate' files
    In-Reply-To: <bug-19169-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-19169-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-19169-70-6qZo0fySeU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|22.05.00,21.11.05           |22.05.00,21.11.05,21.05.14
            released in|                            |
                 Status|Pushed to stable            |Pushed to oldstable
    
    --- Comment #13 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Pushed to 21.05.x for 21.05.14
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 21:58:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 19:58:20 +0000
    Subject: [Koha-bugs] [Bug 27546] Add option to search within results on the
     staff client
    In-Reply-To: <bug-27546-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27546-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27546-70-JwMY36UugP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27546
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
    
    --- Comment #22 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    +            window.location.href = "/cgi-bin/koha/catalogue/search.pl?[%
    query_cgi | $raw %]&[% limit_cgi | $raw %]&[% sort_cgi | $raw
    %]&limit="+index+$("#refiner").val();
    Arf we must URI-espace $("#refiner").val() no ?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:01:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:01:12 +0000
    Subject: [Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display
    In-Reply-To: <bug-28371-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28371-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28371-70-ggXkH4mvCD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:01:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:01:17 +0000
    Subject: [Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display
    In-Reply-To: <bug-28371-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28371-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28371-70-HtjHUNIgIF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371
    
    --- Comment #28 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:01:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:01:20 +0000
    Subject: [Koha-bugs] [Bug 28840] Better texts in batch record
     modification/deletion
    In-Reply-To: <bug-28840-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28840-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28840-70-xfm7Re6AoE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:01:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:01:23 +0000
    Subject: [Koha-bugs] [Bug 28840] Better texts in batch record
     modification/deletion
    In-Reply-To: <bug-28840-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28840-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28840-70-m5kJ1T9GDV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840
    
    --- Comment #16 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:01:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:01:27 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version to 3.6.0
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-AQITOsnmiS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:01:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:01:30 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version to 3.6.0
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-Ji5dSOXbfu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    
    --- Comment #26 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:01:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:01:33 +0000
    Subject: [Koha-bugs] [Bug 30191] Authority search result list in the OPAC
     should use 'record' instead of 'biblios'
    In-Reply-To: <bug-30191-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30191-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30191-70-T5bubxwzas@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30191
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:01:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:01:37 +0000
    Subject: [Koha-bugs] [Bug 30191] Authority search result list in the OPAC
     should use 'record' instead of 'biblios'
    In-Reply-To: <bug-30191-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30191-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30191-70-Q65AKipGB7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30191
    
    --- Comment #9 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:01:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:01:40 +0000
    Subject: [Koha-bugs] [Bug 30288] Provide links to OPACUserJS and OPACUserCSS
     from News/HTML customizations
    In-Reply-To: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30288-70-828oxWbSj0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:01:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:01:43 +0000
    Subject: [Koha-bugs] [Bug 30288] Provide links to OPACUserJS and OPACUserCSS
     from News/HTML customizations
    In-Reply-To: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30288-70-Pdm1oLmU1k@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288
    
    --- Comment #16 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:01:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:01:46 +0000
    Subject: [Koha-bugs] [Bug 30405] Style of address in patron search result
     are 110%
    In-Reply-To: <bug-30405-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30405-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30405-70-IHoL4ZTTaW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30405
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:01:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:01:49 +0000
    Subject: [Koha-bugs] [Bug 30405] Style of address in patron search result
     are 110%
    In-Reply-To: <bug-30405-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30405-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30405-70-DMOzCcv17l@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30405
    
    --- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:01:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:01:52 +0000
    Subject: [Koha-bugs] [Bug 30461] Batch authority tool is broken
    In-Reply-To: <bug-30461-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30461-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30461-70-4DdqtxRbV4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30461
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:01:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:01:56 +0000
    Subject: [Koha-bugs] [Bug 30461] Batch authority tool is broken
    In-Reply-To: <bug-30461-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30461-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30461-70-qD9g39L9aB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30461
    
    --- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:02:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:02:00 +0000
    Subject: [Koha-bugs] [Bug 30534] borrowers.guarantorid not present on
     database
    In-Reply-To: <bug-30534-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30534-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30534-70-Ol5pE98RuH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30534
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:02:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:02:03 +0000
    Subject: [Koha-bugs] [Bug 30534] borrowers.guarantorid not present on
     database
    In-Reply-To: <bug-30534-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30534-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30534-70-dcBH1opSOw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30534
    
    --- Comment #6 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:02:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:02:07 +0000
    Subject: [Koha-bugs] [Bug 30584] Cannot add field mappings to Elasticsearch
     configuration
    In-Reply-To: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30584-70-cLFFCBeY4R@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:02:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:02:09 +0000
    Subject: [Koha-bugs] [Bug 30584] Cannot add field mappings to Elasticsearch
     configuration
    In-Reply-To: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30584-70-DcUtF0ZdwG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584
    
    --- Comment #7 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:02:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:02:17 +0000
    Subject: [Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display
    In-Reply-To: <bug-28371-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28371-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28371-70-6x7KKmzgro@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371
    
    --- Comment #29 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    I hope this performance fix can be backported to 21.11.x
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:02:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:02:32 +0000
    Subject: [Koha-bugs] [Bug 30159] Fix display of validation of important
     fields when biblio cataloguing
    In-Reply-To: <bug-30159-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30159-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30159-70-p7Q1lgiIBX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to stable            |RESOLVED
             Resolution|---                         |FIXED
                     CC|                            |andrew at bywatersolutions.com
    
    --- Comment #13 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Missing dependency, not backported to 21.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:02:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:02:32 +0000
    Subject: [Koha-bugs] [Bug 30482] Potential for bad string concatenation in
     cataloging validation error message
    In-Reply-To: <bug-30482-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30482-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30482-70-QXkcIyJGNy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30482
    Bug 30482 depends on bug 30159, which changed state.
    
    Bug 30159 Summary: Fix display of validation of important fields when biblio cataloguing
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to stable            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:11:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:11:07 +0000
    Subject: [Koha-bugs] [Bug 30535] Add "Tool plugins" to the main tools screen
    In-Reply-To: <bug-30535-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30535-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30535-70-y7SzPHbWGD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30535
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |RESOLVED
             Resolution|---                         |INVALID
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
    
    --- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    (In reply to Fred King from comment #1)
    > Update: I added a tool plugin, and now "Tool plugins" appears on the main
    > Tools page, with my plugin listed under it. Maybe it needs a plugin to
    > appear?
    
    Yes, it is a change of behavior not a bug ;)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:25:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:25:01 +0000
    Subject: [Koha-bugs] [Bug 30616] New: Place hold button doesn't always
     display when it should
    Message-ID: <bug-30616-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30616
    
                Bug ID: 30616
               Summary: Place hold button doesn't always display when it
                        should
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Circulation
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: lucas at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
    
    To recreate:
    
    1. Set all library 'Default holds policy by item type' to No Holds Allowed
    2. Set another library's ( Centerville ) 'Default holds policy by item
    type''Default holds policy by item type' to 'any library'.
    3. Find an item of that type from Centerville.
    4. No place hold button on the toolbar in the staff client
    5. Log into the OPAC as a patron from Centerville and try to place a hold on
    that item type. There is no place hold button when there should be.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:35:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:35:23 +0000
    Subject: [Koha-bugs] [Bug 30432] get_items_that_can_fill needs to specify
     table for biblionumbers
    In-Reply-To: <bug-30432-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30432-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30432-70-vdyTBN8tpb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |andrew at bywatersolutions.com
    
    --- Comment #12 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    I get a bunch of errors from the QA tool after applying these to 21.05. Please
    rebase for backport:
    
     FAIL   t/db_dependent/Koha/Holds.t
       FAIL   valid
                    Use of bare << to mean <<"" is deprecated 
                    Use of bare << to mean <<"" is deprecated 
                    Global symbol "$biblio" requires explicit package name (did you
    forget to declare "my $biblio"?) 
                    Global symbol "$itype_1" requires explicit package name (did
    you forget to declare "my $itype_1"?) 
                    Global symbol "$itype_2" requires explicit package name (did
    you forget to declare "my $itype_2"?) 
                    Global symbol "$item_1" requires explicit package name (did you
    forget to declare "my $item_1"?) 
                    Global symbol "$biblio" requires explicit package name (did you
    forget to declare "my $biblio"?) 
                    Global symbol "$itype_1" requires explicit package name (did
    you forget to declare "my $itype_1"?) 
                    Global symbol "$item_2" requires explicit package name (did you
    forget to declare "my $item_2"?) 
                    Global symbol "$biblio" requires explicit package name (did you
    forget to declare "my $biblio"?) 
                    Global symbol "$itype_1" requires explicit package name (did
    you forget to declare "my $itype_1"?) 
                    Global symbol "$item_3" requires explicit package name (did you
    forget to declare "my $item_3"?) 
                    Global symbol "$biblio" requires explicit package name (did you
    forget to declare "my $biblio"?) 
                    Global symbol "$itype_1" requires explicit package name (did
    you forget to declare "my $itype_1"?) 
                    Global symbol "$item_4" requires explicit package name (did you
    forget to declare "my $item_4"?) 
                    Global symbol "$biblio" requires explicit package name (did you
    forget to declare "my $biblio"?) 
                    Global symbol "$itype_1" requires explicit package name (did
    you forget to declare "my $itype_1"?) 
                    Global symbol "$item_5" requires explicit package name (did you
    forget to declare "my $item_5"?) 
                    Global symbol "$biblio" requires explicit package name (did you
    forget to declare "my $biblio"?) 
                    Global symbol "$itype_2" requires explicit package name (did
    you forget to declare "my $itype_2"?) 
                    Global symbol "$lost" requires explicit package name (did you
    forget to declare "my $lost"?) 
                    Global symbol "$biblio" requires explicit package name (did you
    forget to declare "my $biblio"?) 
                    Global symbol "$withdrawn" requires explicit package name (did
    you forget to declare "my $withdrawn"?) 
                    Global symbol "$biblio" requires explicit package name (did you
    forget to declare "my $biblio"?) 
                    Global symbol "$notforloan" requires explicit package name (did
    you forget to declare "my $notforloan"?) 
                    Global symbol "$biblio" requires explicit package name (did you
    forget to declare "my $biblio"?) 
                    syntax error 
                        my "
                      (Might be a runaway multi-line << string starting on line
    419)
                    t/db_dependent/Koha/Holds.t has too many errors.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:36:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:36:04 +0000
    Subject: [Koha-bugs] [Bug 30426] suggestion service missing Auth and Output
     imports
    In-Reply-To: <bug-30426-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30426-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30426-70-pP2nUHK4gM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30426
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to stable            |RESOLVED
                     CC|                            |andrew at bywatersolutions.com
             Resolution|---                         |FIXED
    
    --- Comment #7 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Missing dependency, not backported to 21.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:39:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:39:11 +0000
    Subject: [Koha-bugs] [Bug 30406] Our DT tables not filtering on the correct
     column if hidden by default
    In-Reply-To: <bug-30406-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30406-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30406-70-qDb1WX27V6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30406
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|22.05.00,21.11.05           |22.05.00,21.11.05,21.05.14
            released in|                            |
                     CC|                            |andrew at bywatersolutions.com
                 Status|Pushed to stable            |Pushed to oldstable
    
    --- Comment #9 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Pushed to 21.05.x for 21.05.14
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:39:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:39:57 +0000
    Subject: [Koha-bugs] [Bug 30172] Background jobs failing due to race
     condition
    In-Reply-To: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30172-70-8zly7OLNqX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |victor at tuxayo.net
             Version(s)|22.05.00,21.11.05,21.05.14  |22.05.00,21.11.05,21.05.14,
            released in|                            |20.11.18
                 Status|Pushed to oldstable         |Pushed to oldoldstable
    
    --- Comment #41 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Backported: Pushed to 20.11.x branch for 20.11.18
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:42:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:42:33 +0000
    Subject: [Koha-bugs] [Bug 30142] ElasticSearch MARC mappings should not
     accept whitespaces
    In-Reply-To: <bug-30142-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30142-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30142-70-wWnvlQKplw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30142
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |andrew at bywatersolutions.com
             Version(s)|22.05.00,21.11.05           |22.05.00,21.11.05,21.05.14
            released in|                            |
                 Status|Pushed to stable            |Pushed to oldstable
    
    --- Comment #8 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Pushed to 21.05.x for 21.05.14
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:44:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:44:09 +0000
    Subject: [Koha-bugs] [Bug 30366] Warn when running
     automatic_item_modification_by_age.pl
    In-Reply-To: <bug-30366-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30366-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30366-70-YgQG5A3jau@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30366
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
               Severity|enhancement                 |minor
               Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co
                       |ity.org                     |m
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:44:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:44:32 +0000
    Subject: [Koha-bugs] [Bug 30366] Warn when running
     automatic_item_modification_by_age.pl
    In-Reply-To: <bug-30366-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30366-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30366-70-h99mC3NQF1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30366
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Trivial patch
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:44:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:44:38 +0000
    Subject: [Koha-bugs] [Bug 30366] Warn when running
     automatic_item_modification_by_age.pl
    In-Reply-To: <bug-30366-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30366-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30366-70-mEbIffmFx3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30366
    
    --- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Created attachment 133844
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133844&action=edit
    Bug 30366: Remove warn when running automatic_item_modification_by_age.pl
    
    When using the ./misc/cronjobs/automatic_item_modification_by_age.pl -v
    after setting up rules under Tools > Automatic item modifications by age
    the script outputs several lines of warnings:
    Use of uninitialized value in string eq at /kohadevbox/koha/C4/Items.pm line
    1864.
    
    This is because even when there is no condition defined, modification rule is
    stored with empty hash, like :
    [{"substitutions":[{"field":"items.new_status","value":"0"}],"conditions":[{}],"age":"60","agefield":"items.dateaccessioned"}]
    
    Test plan :
    1) Go to Tools > Automatic item modifications by age
    2) Create a rule with no conditions, just a substitution
    3) Run misc/cronjobs/automatic_item_modification_by_age.pl -v
    4) Check there is no warning
    5) Edit the rule to add a condition
    6) Run misc/cronjobs/automatic_item_modification_by_age.pl -v
    7) Check the condition is applied
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:48:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:48:08 +0000
    Subject: [Koha-bugs] [Bug 30118] holds_block_checkin behavior is different
     in Koha and in SIP
    In-Reply-To: <bug-30118-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30118-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30118-70-ZuLmnEkZ5r@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30118
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |victor at tuxayo.net
                 Status|Pushed to oldstable         |RESOLVED
             Resolution|---                         |FIXED
    
    --- Comment #9 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:50:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:50:32 +0000
    Subject: [Koha-bugs] [Bug 30583] Hold system broken for translated template
    In-Reply-To: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30583-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30583-70-0G8awaxifu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30583
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                 Status|Pushed to oldstable         |RESOLVED
                     CC|                            |victor at tuxayo.net
    
    --- Comment #9 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Missing dependencies for 20.11.x, it shouldn't be affected, no backport.
    Bullet dodged :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:51:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:51:21 +0000
    Subject: [Koha-bugs] [Bug 29771] Get rid of CGI::param in list context
     warnings
    In-Reply-To: <bug-29771-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29771-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29771-70-3tQ9nAgBy4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                     CC|                            |victor at tuxayo.net
                 Status|Pushed to oldstable         |RESOLVED
    
    --- Comment #16 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:51:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:51:22 +0000
    Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal
    In-Reply-To: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25790-70-P7rBVZILBx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790
    Bug 25790 depends on bug 29771, which changed state.
    
    Bug 29771 Summary: Get rid of CGI::param in list context warnings
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to oldstable         |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:53:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:53:48 +0000
    Subject: [Koha-bugs] [Bug 19169] Add a test to detect unneeded
     'atomicupdate' files
    In-Reply-To: <bug-19169-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-19169-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-19169-70-LKPRBjaQps@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|22.05.00,21.11.05,21.05.14  |22.05.00,21.11.05,21.05.14,
            released in|                            |20.11.18
                 Status|Pushed to oldstable         |Pushed to oldoldstable
    
    --- Comment #14 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Backported: Pushed to 20.11.x branch for 20.11.18
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:54:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:54:56 +0000
    Subject: [Koha-bugs] [Bug 30406] Our DT tables not filtering on the correct
     column if hidden by default
    In-Reply-To: <bug-30406-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30406-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30406-70-cgvUAqtug3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30406
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                 Status|Pushed to oldstable         |RESOLVED
                     CC|                            |victor at tuxayo.net
    
    --- Comment #10 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 22:55:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 20:55:21 +0000
    Subject: [Koha-bugs] [Bug 30142] ElasticSearch MARC mappings should not
     accept whitespaces
    In-Reply-To: <bug-30142-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30142-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30142-70-cHryJJdBNI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30142
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to oldstable         |RESOLVED
             Resolution|---                         |FIXED
                     CC|                            |victor at tuxayo.net
    
    --- Comment #9 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 23:03:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 21:03:20 +0000
    Subject: [Koha-bugs] [Bug 30541] Resolve return claim works but "hangs" if
     MarkLostItemsAsReturned is set for return claims
    In-Reply-To: <bug-30541-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30541-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30541-70-pfsWhE3A8n@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to oldstable
             Version(s)|                            |21.05.14
            released in|                            |
                     CC|                            |victor at tuxayo.net
    
    --- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Note about oldstable: It has been pushed to 21.05.x for 21.05.14
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 23:03:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 21:03:27 +0000
    Subject: [Koha-bugs] [Bug 30541] Resolve return claim works but "hangs" if
     MarkLostItemsAsReturned is set for return claims
    In-Reply-To: <bug-30541-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30541-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30541-70-k94Py0sdxe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                 Status|Pushed to oldstable         |RESOLVED
    
    --- Comment #9 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 23:13:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 21:13:02 +0000
    Subject: [Koha-bugs] [Bug 29957] Cookies not removed after logout
    In-Reply-To: <bug-29957-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29957-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29957-70-wCBgjQYYl7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29957
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |victor at tuxayo.net
    
    --- Comment #127 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    (In reply to Andrew Fuerste-Henry from comment #126)
    > I can't get this to apply to 21.05 for backport. Please rebase. Some of this
    > code has been touched by bug 29915, which I was also unable to apply and
    > backport.
    
    No need, it's actually the cause for bug 30525 and likely bug 30532. So
    backporting this isn't necessary to fix them. On the contrary, let's dodge
    them.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 23:17:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 21:17:14 +0000
    Subject: [Koha-bugs] [Bug 30532] guided_reports.pl has a problem
    In-Reply-To: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30532-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30532-70-qIe7hNU5zD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30532
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |victor at tuxayo.net
                 Status|Pushed to stable            |RESOLVED
             Resolution|---                         |FIXED
    
    --- Comment #9 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    > This is basically the same issue as Bug 30525, though the problematic code is different than what I'd searched for to fix that bug.
    
    > [...]
    
    > Go to: Home >  Reports > Create from SQL
    > Can't call method "value" on unblessed reference at /kohadevbox/koha/reports/guided_reports.pl line 80
    
    Andrew tested, 21.05.x not affected that kinda confirms it's due to bug 29957.
    No need to further backports then.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 23:17:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 21:17:15 +0000
    Subject: [Koha-bugs] [Bug 30491] Convert saved reports tabs to Bootstrap
    In-Reply-To: <bug-30491-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30491-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30491-70-OE0Xo3sAJ4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30491
    Bug 30491 depends on bug 30532, which changed state.
    
    Bug 30532 Summary: guided_reports.pl has a problem
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30532
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to stable            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Mon Apr 25 23:56:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 21:56:02 +0000
    Subject: [Koha-bugs] [Bug 19169] Add a test to detect unneeded
     'atomicupdate' files
    In-Reply-To: <bug-19169-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-19169-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-19169-70-jdpaEPrc22@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169
    
    Chris Cormack <chris at bigballofwax.co.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |chris at bigballofwax.co.nz
                 Status|Pushed to oldoldstable      |Pushed to oldoldoldstable
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 00:06:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 22:06:11 +0000
    Subject: [Koha-bugs] [Bug 30596] api/v1/acquisitions_baskets.t is failing
     randomly
    In-Reply-To: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30596-70-TYNVk0Ij3Y@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133693|0                           |1
            is obsolete|                            |
    
    --- Comment #10 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Created attachment 133845
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133845&action=edit
    Bug 30596: Prevent api/v1/acquisitions_baskets.t and
    api/v1/acquisitions_funds.t to fail randomly
    
    because of updated_on
    
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 00:06:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 22:06:26 +0000
    Subject: [Koha-bugs] [Bug 30596] api/v1/acquisitions_baskets.t is failing
     randomly
    In-Reply-To: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30596-70-2OsLAosZ5h@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |victor at tuxayo.net
                 Status|Signed Off                  |Passed QA
    
    --- Comment #11 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Works, qa script happy, code looks good, passing QA :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 00:42:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 22:42:19 +0000
    Subject: [Koha-bugs] [Bug 30553] Add a count to the Files tab in the patron
     account
    In-Reply-To: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30553-70-ETfrmE0g7W@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30553
    
    --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> ---
    Cait,
    
    Thanks for looking. I think, unless there is another reason, we should just
    return the file count.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 00:43:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 22:43:44 +0000
    Subject: [Koha-bugs] [Bug 30553] Add a count to the Files tab in the patron
     account
    In-Reply-To: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30553-70-26L4LO9GBe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30553
    
    --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    I am fine with either, I just felt like here was some mismatch here.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 00:43:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 22:43:57 +0000
    Subject: [Koha-bugs] [Bug 30510] Add a Patron reason column to the
     suggestion table in the staff interface
    In-Reply-To: <bug-30510-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30510-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30510-70-Is2rW04emN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30510
    
    --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> ---
    Created attachment 133846
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133846&action=edit
    Bug 30510: Return only the count from the  new filecount method
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 00:44:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 22:44:29 +0000
    Subject: [Koha-bugs] [Bug 30510] Add a Patron reason column to the
     suggestion table in the staff interface
    In-Reply-To: <bug-30510-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30510-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30510-70-7ndgLG7DdZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30510
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133846|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 00:44:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 22:44:57 +0000
    Subject: [Koha-bugs] [Bug 30510] Add a Patron reason column to the
     suggestion table in the staff interface
    In-Reply-To: <bug-30510-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30510-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30510-70-I99RU6dm0i@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30510
    
    --- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
    (In reply to Lucas Gass from comment #4)
    > Created attachment 133846 [details] [review]
    > Bug 30510: Return only the count from the  new filecount method
    
    Sorry, I attached this patch to the wrong bug number.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 00:45:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 22:45:28 +0000
    Subject: [Koha-bugs] [Bug 30553] Add a count to the Files tab in the patron
     account
    In-Reply-To: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30553-70-f7yw6geNNs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30553
    
    --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
    Created attachment 133847
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133847&action=edit
    Bug 30510: Return only the count from the  new filecount method
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 01:52:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Mon, 25 Apr 2022 23:52:06 +0000
    Subject: [Koha-bugs] [Bug 27546] Add option to search within results on the
     staff client
    In-Reply-To: <bug-27546-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27546-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27546-70-xKku2AtTk1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27546
    
    --- Comment #23 from David Cook <dcook at prosentient.com.au> ---
    (In reply to Fridolin Somers from comment #22)
    > +            window.location.href = "/cgi-bin/koha/catalogue/search.pl?[%
    > query_cgi | $raw %]&[% limit_cgi | $raw %]&[% sort_cgi | $raw
    > %]&limit="+index+$("#refiner").val();
    > Arf we must URI-espace $("#refiner").val() no ?
    
    100% needs an escape_str() there to prevent XSS.
    
    Great catch, Frido!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 03:09:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 01:09:26 +0000
    Subject: [Koha-bugs] [Bug 7798] admin/item_circulation_alerts.pl plack
     scoping
    In-Reply-To: <bug-7798-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-7798-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-7798-70-NCZ4M4U4gR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7798
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |dcook at prosentient.com.au
    
    --- Comment #5 from David Cook <dcook at prosentient.com.au> ---
    This seems like one of the last changes specific to the
    item_circulation_alerts.pl page. 
    
    I'm curious if anyone actually uses this functionality?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 07:45:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 05:45:37 +0000
    Subject: [Koha-bugs] [Bug 22490] Some strings in JavaScript files are
     untranslatable
    In-Reply-To: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22490-70-ReJRZ2wPNJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22490
    
    Julian Maurice <julian.maurice at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |ASSIGNED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 07:58:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 05:58:57 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-2rAObfM6Rw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133842|0                           |1
            is obsolete|                            |
    
    --- Comment #40 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133848
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133848&action=edit
    Bug 30558: test commit - test sub
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 07:59:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 05:59:48 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-xlluYGnAng@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    --- Comment #41 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133849
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133849&action=edit
    Bug 30558: test commit test sub
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 08:00:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 06:00:48 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-tBHkxkDz7i@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133839|0                           |1
            is obsolete|                            |
    
    --- Comment #42 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133850
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133850&action=edit
    Bug 30558: Add feature to search Acquisitions Orders by ISSN
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 08:00:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 06:00:52 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-QSO655Gvd4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133849|0                           |1
            is obsolete|                            |
    
    --- Comment #43 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133851
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133851&action=edit
    Bug 30558: test commit test sub
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 08:03:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 06:03:14 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-Xb65TLCYJZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    --- Comment #44 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133852
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133852&action=edit
    Bug 30558: Add feature to search Acquisitions Orders by ISSN - add search form
    field for ISSN number - add search logic including ISSN variations search   if
    SearchWithISSNVariations preference is set
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 08:20:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 06:20:27 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-9WGFRrKDTA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    --- Comment #45 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133853
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133853&action=edit
    Bug 30558: test commit  substring with enter before
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 08:25:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 06:25:30 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-dnq7rHpZaG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    --- Comment #46 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133854
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133854&action=edit
    Bug 30558: test commit
    
     substring with enter before
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 08:27:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 06:27:44 +0000
    Subject: [Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display
    In-Reply-To: <bug-28371-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28371-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28371-70-fFEfJEZMMy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |additional_work_needed
    
    --- Comment #30 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    This breaks t/db_dependent/Koha/Biblio.t :
        #   Failed test 'Authorised value is correctly parsed to show description
    rather than code'
        #   at t/db_dependent/Koha/Biblio.t line 708.
        #          got: 'CODE'
        #     expected: 'Description should show'
    
    How should we fix all calls of transformMARCXML4XSLT ?
    
     > git grep 'transformMARCXML4XSLT('
    C4/XSLT.pm:    my $record = transformMARCXML4XSLT($biblionumber, $orig_record,
    undef, $branches, $itemtypes, $authorised_values );
    Koha/Biblio.pm:    $record = transformMARCXML4XSLT( $self->biblionumber,
    $record, $opac );
    Koha/OAI/Server/Repository.pm:    $record = transformMARCXML4XSLT(
    $biblionumber, $record )
    t/db_dependent/XSLT.t:    C4::XSLT::transformMARCXML4XSLT( 3, $record, 0,
    $branches, $itemtypes, $av );
    t/db_dependent/XSLT.t:    C4::XSLT::transformMARCXML4XSLT( 3, $record,
    $branches, $itemtypes, $av );
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 08:54:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 06:54:06 +0000
    Subject: [Koha-bugs] [Bug 30587] Incorrect translations in some templates
    In-Reply-To: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30587-70-qAZcJj4M2W@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30587
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 08:54:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 06:54:09 +0000
    Subject: [Koha-bugs] [Bug 30587] Incorrect translations in some templates
    In-Reply-To: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30587-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30587-70-2DHNRnbszf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30587
    
    --- Comment #8 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 08:54:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 06:54:12 +0000
    Subject: [Koha-bugs] [Bug 30596] api/v1/acquisitions_baskets.t is failing
     randomly
    In-Reply-To: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30596-70-0Nts0LlFhW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 08:54:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 06:54:14 +0000
    Subject: [Koha-bugs] [Bug 30596] api/v1/acquisitions_baskets.t is failing
     randomly
    In-Reply-To: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30596-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30596-70-wc6IMC8iTX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596
    
    --- Comment #12 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 08:54:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 06:54:25 +0000
    Subject: [Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display
    In-Reply-To: <bug-28371-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28371-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28371-70-o60qQxkU9v@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |ASSIGNED
             Version(s)|22.05.00                    |
            released in|                            |
    
    --- Comment #31 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Reverted from master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 09:09:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 07:09:29 +0000
    Subject: [Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display
    In-Reply-To: <bug-28371-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28371-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28371-70-syFp4t7p8h@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371
    
    --- Comment #32 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    We may reconsider keeping code logic and add cache
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 09:18:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 07:18:55 +0000
    Subject: [Koha-bugs] [Bug 30617] New: We should consistently use includes
     for patron name display
    Message-ID: <bug-30617-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30617
    
                Bug ID: 30617
               Summary: We should consistently use includes for patron name
                        display
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Staff Client
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: martin.renvoize at ptfs-europe.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com
    
    Our templates are littered with various invocations of `[% patron.surname %],
    [% patron.firstname %]` and similar in varying orders and varying levels of
    detail (with or without cardnumber, with or without title, surname first or
    firstname first, linked and unlinked).
    
    We have two ways of constructing a patron display block, patron-title.inc tt
    include and js-patron-format.inc for use in JS based displays.
    
    We should congregate our templates around these two includes so that we can
    make our display consistent throughout with perhaps just a couple of display
    variations.. short and long forms perhaps?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 09:19:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 07:19:08 +0000
    Subject: [Koha-bugs] [Bug 30617] We should consistently use includes for
     patron name display
    In-Reply-To: <bug-30617-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30617-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30617-70-ayrnhPXH2N@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30617
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |21978
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    [Bug 21978] Add middle name field
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 09:19:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 07:19:08 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-TOXW3qoXwb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30617
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30617
    [Bug 30617] We should consistently use includes for patron name display
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 09:19:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 07:19:31 +0000
    Subject: [Koha-bugs] [Bug 30617] We should consistently use includes for
     patron name display
    In-Reply-To: <bug-30617-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30617-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30617-70-IiYwnvYtee@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30617
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30568
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568
    [Bug 30568] Make patron name fields more flexible
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 09:19:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 07:19:31 +0000
    Subject: [Koha-bugs] [Bug 30568] Make patron name fields more flexible
    In-Reply-To: <bug-30568-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30568-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30568-70-5GR3pBkatr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30617
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30617
    [Bug 30617] We should consistently use includes for patron name display
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 09:19:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 07:19:48 +0000
    Subject: [Koha-bugs] [Bug 30617] We should consistently use includes for
     patron name display
    In-Reply-To: <bug-30617-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30617-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30617-70-e8ZJzKsNvs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30617
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |oleonard at myacpl.org
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 09:19:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 07:19:57 +0000
    Subject: [Koha-bugs] [Bug 30617] We should consistently use includes for
     patron name display
    In-Reply-To: <bug-30617-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30617-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30617-70-o3gJTkqYBd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30617
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |katrin.fischer at bsz-bw.de
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 09:22:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 07:22:12 +0000
    Subject: [Koha-bugs] [Bug 30617] We should consistently use includes for
     patron name display
    In-Reply-To: <bug-30617-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30617-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30617-70-aDjUy5mgau@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30617
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 09:46:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 07:46:45 +0000
    Subject: [Koha-bugs] [Bug 30618] New: Important and mandatory select fields
     not highlighted on additem.pl
    Message-ID: <bug-30618-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30618
    
                Bug ID: 30618
               Summary: Important and mandatory select fields not highlighted
                        on additem.pl
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Cataloging
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: emmi.takkinen at koha-suomi.fi
            QA Contact: testopia at bugs.koha-community.org
                    CC: m.de.rooy at rijksmuseum.nl
    
    If one tries to add an item and mandatory or important select field isn't
    filled, field isn't highlighted like input fields.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 09:58:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 07:58:19 +0000
    Subject: [Koha-bugs] [Bug 30136] Add back to top button when scrolling
    In-Reply-To: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30136-70-IULv1zwhjx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136
    
    Séverine Queune <severine.queune at bulac.fr> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Patch doesn't apply
                     CC|                            |severine.queune at bulac.fr
    
    --- Comment #14 from Séverine Queune <severine.queune at bulac.fr> ---
    Sorry Frido, I'd be happy to try again when it's fixed.
    
    error: sha1 information is lacking or useless
    (koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc).
    error: could not build fake ancestor
    Patch failed at 0001 Bug 30136: (follow-up) CSS and accessibility update
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 10:08:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 08:08:03 +0000
    Subject: [Koha-bugs] [Bug 30136] Add back to top button when scrolling
    In-Reply-To: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30136-70-SRNJ2BGdK4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133220|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 10:09:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 08:09:06 +0000
    Subject: [Koha-bugs] [Bug 30136] Add back to top button when scrolling
    In-Reply-To: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30136-70-rZysXEYwMe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Patch doesn't apply         |Needs Signoff
    
    --- Comment #15 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Ah it comes from patch "[DO NO PUSH] CSS styling for OPAC", I set it as
    obsolete.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 10:29:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 08:29:20 +0000
    Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying
     types in put mapping requests is deprecated (incompatible with 7)
    In-Reply-To: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25669-70-eot0t77Ezv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669
    
    --- Comment #29 from Kevin Carnes <kevin.carnes at ub.lu.se> ---
    (In reply to Victor Grousset/tuxayo from comment #28)
    > > In that case I think it would be possible to avoid checking the ES version
    > 
    > Even if someone wants to support ES 8, no version check is needed for this?
    > Maybe your last paragraph actually is about this and we can't have ES 6 to 8
    > support without check?
    
    In order to avoid version checking, support for ES 8 wouldn't be available
    while there is support for ES 6. So it would be support for ES 6 to 7 and then
    support for ES 7 to 8.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 10:44:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 08:44:57 +0000
    Subject: [Koha-bugs] [Bug 30136] Add back to top button when scrolling
    In-Reply-To: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30136-70-8vVa8neSj8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136
    
    --- Comment #16 from Séverine Queune <severine.queune at bulac.fr> ---
    Thanks Frido !
    I tested on both personal devbox and sandbox and the display of the button is
    completely different from the one described and shown on screenshot.
    The behaviour is also slightly different as the one described as the button is
    stuck on the bottom of the page so I don't see it before I reach the end of the
    page.
    Is that expected ?
    
    See sandbox : 
    https://opac-bz30136.sandboxes.biblibre.eu/cgi-bin/koha/opac-search.pl?idx=&q=a&weight_search=1
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 10:54:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 08:54:23 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-Jpr3uxUFnh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133854|0                           |1
            is obsolete|                            |
    
    --- Comment #47 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133855
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133855&action=edit
    Bug 30558: test commit
    
     substring with enter before
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 10:55:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 08:55:35 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-Kog7wK4TUu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133855|0                           |1
            is obsolete|                            |
    
    --- Comment #48 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133856
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133856&action=edit
    Bug 30558: test commit
    
    - add search... $$$
    - add search ... &&&
      if ... ^^^
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 11:05:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 09:05:19 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-TQe3BD3NXn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    --- Comment #49 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133857
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133857&action=edit
    Bug 30558: Lorem ipsum dolor sit amet - Lorem ipsum dolor sit amet Lorem ipsum
    dolor sit amet Lorem ipsum dolor sit amet
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 11:10:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 09:10:45 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-EYhAIeggjY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133856|0                           |1
            is obsolete|                            |
    
    --- Comment #50 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133858
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133858&action=edit
    Bug 30558: test commit
    
    - add search... $$$
    - add search ... &&&
      if ... ^^^
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 11:12:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 09:12:08 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-dv4aYcLlw0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133857|0                           |1
            is obsolete|                            |
    
    --- Comment #51 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133859
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133859&action=edit
    Bug 30558: Lorem ipsum dolor sit amet - Lorem ipsum dolor sit amet Lorem ipsum
    dolor sit amet Lorem ipsum dolor sit amet
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 11:12:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 09:12:13 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-ABjUeqbzIo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133858|0                           |1
            is obsolete|                            |
    
    --- Comment #52 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133860
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133860&action=edit
    Bug 30558: test commit
    
    - add search... $$$
    - add search ... &&&
      if ... ^^^
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 11:13:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 09:13:07 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-hxtp9FvBOL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    --- Comment #53 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133861
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133861&action=edit
    Bug 30558: Lorem ipsum dolor sit amet  - Lorem ipsum dolor sit amet  Lorem
    ipsum dolor sit amet  Lorem ipsum dolor sit amet
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 11:13:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 09:13:12 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-vQtJh8dh6h@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133860|0                           |1
            is obsolete|                            |
    
    --- Comment #54 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133862
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133862&action=edit
    Bug 30558: test commit
    
    - add search... $$$
    - add search ... &&&
      if ... ^^^
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 11:14:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 09:14:18 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-oopApZToXI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133838|0                           |1
            is obsolete|                            |
    
    --- Comment #55 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133863
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133863&action=edit
    Bug 30558: Add new system preference SearchWithISSNVariations
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 11:14:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 09:14:23 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-mha7kn0MQY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    --- Comment #56 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133864
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133864&action=edit
    Bug 30558: Lorem ipsum dolor sit amet
    
     - Lorem ipsum dolor sit amet
     Lorem ipsum dolor sit amet
     Lorem ipsum dolor sit amet
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 11:14:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 09:14:27 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-xNVvkVZqGi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133862|0                           |1
            is obsolete|                            |
    
    --- Comment #57 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133865
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133865&action=edit
    Bug 30558: test commit
    
    - add search... $$$
    - add search ... &&&
      if ... ^^^
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 11:55:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 09:55:10 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-5QmcS5vthF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133863|0                           |1
            is obsolete|                            |
    
    --- Comment #58 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133866
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133866&action=edit
    Bug 30558: Add new system preference SearchWithISSNVariations
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 11:55:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 09:55:15 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-IaLzv4LNeT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133864|0                           |1
            is obsolete|                            |
    
    --- Comment #59 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133867
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133867&action=edit
    Bug 30558: Lorem ipsum dolor sit amet
    
     - Lorem ipsum dolor sit amet
     Lorem ipsum dolor sit amet
     Lorem ipsum dolor sit amet
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 11:55:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 09:55:20 +0000
    Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utiliti testing (some
     bugs in git-bz? researching)
    In-Reply-To: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30558-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30558-70-oXDLyzJ925@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133865|0                           |1
            is obsolete|                            |
    
    --- Comment #60 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133868
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133868&action=edit
    Bug 30558: test commit
    
    - add search... $$$
    - add search ... &&&
      if ... ^^^
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 11:56:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 09:56:51 +0000
    Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
     too
    In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28269-70-89wPzUAPrd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 11:56:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 09:56:55 +0000
    Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
     too
    In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28269-70-pbIwBnnZYR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269
    
    --- Comment #4 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133869
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133869&action=edit
    Bug 28269: Add new system preference SearchWithISSNVariations
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 11:57:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 09:57:00 +0000
    Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
     too
    In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28269-70-LDRMlzqByH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269
    
    --- Comment #5 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133870
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133870&action=edit
    Bug 28269: Add feature to search Acquisitions Orders by ISSN
    
    - add search form field for ISSN number
    - add search logic including ISSN variations search
      if SearchWithISSNVariations preference is set
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 11:57:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 09:57:04 +0000
    Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
     too
    In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28269-70-FXcgR1PE8q@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269
    
    --- Comment #6 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 133871
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133871&action=edit
    Bug 28269: Add tests for Acquisitions Orders search by ISSN also with
    SearchWithISSNVariations on and off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 12:51:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 10:51:59 +0000
    Subject: [Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display
    In-Reply-To: <bug-28371-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28371-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28371-70-WedDOi8K27@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 12:52:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 10:52:04 +0000
    Subject: [Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display
    In-Reply-To: <bug-28371-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28371-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28371-70-3qZIEd1vUa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371
    
    --- Comment #33 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133872
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133872&action=edit
    Bug 28371: (follow-up) Fetch values if not passed
    
    There are two places where transformMARC4XSLT is called ouside of
    XSLTParse4Display
    
    ILS-DI if expanding avs
    get_marc_notes
    
    The first was pushed after the initial patches here (bug 26195)
    The second will only take effect if a notes field is mapped to an av
    
    This patch adds a fallback in transformMARC4XSLT to cover these uses
    and fixes a wrong call in tests
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 12:57:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 10:57:13 +0000
    Subject: [Koha-bugs] [Bug 27546] Add option to search within results on the
     staff client
    In-Reply-To: <bug-27546-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27546-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27546-70-J0dBDmLdcY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27546
    
    --- Comment #24 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133873
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133873&action=edit
    Bug 27546: (follow-up) Escape new search string
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 12:57:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 10:57:52 +0000
    Subject: [Koha-bugs] [Bug 30610] The 'Print receipt' button on cash
     management registers page fails on second datatables page
    In-Reply-To: <bug-30610-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30610-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30610-70-skfgiMMroo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30610
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |13985
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
    [Bug 13985] Cash Management - Koha as 'Point of Sale'
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 12:57:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 10:57:52 +0000
    Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
    In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-13985-70-83oytqlerR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30610
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30610
    [Bug 30610] The 'Print receipt' button on cash management registers page fails
    on second datatables page
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:02:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:02:38 +0000
    Subject: [Koha-bugs] [Bug 30619] New: Add the option to email receipts as an
     alternative to printing
    Message-ID: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619
    
                Bug ID: 30619
               Summary: Add the option to email receipts as an alternative to
                        printing
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Fines and fees
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: martin.renvoize at ptfs-europe.com
            QA Contact: testopia at bugs.koha-community.org
    
    We have the 'UseEmailReceipts' preference, but we don't have any way for
    patrons to opt in/out of an email receipt at payment time or for anonymous
    payments in the point of sale system.
    
    It would be great to have a 'Email receipt' option wherever we display the
    option to 'Print receipt' with the ability to either use the borrowers primary
    notices address or, for the anonymous case, define an email address there and
    then for the receipt to be sent to.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:02:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:02:57 +0000
    Subject: [Koha-bugs] [Bug 30619] Add the option to email receipts as an
     alternative to printing
    In-Reply-To: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30619-70-XLiww16qsd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |13985
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
    [Bug 13985] Cash Management - Koha as 'Point of Sale'
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:02:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:02:57 +0000
    Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
    In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-13985-70-P90oftyHec@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30619
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619
    [Bug 30619] Add the option to email receipts as an alternative to printing
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:05:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:05:34 +0000
    Subject: [Koha-bugs] [Bug 23461] Popup blockers triggered by option to
     automatically display payment receipt for printing after making a payment
    In-Reply-To: <bug-23461-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23461-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23461-70-gladQNcoT8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23461
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |RESOLVED
             Resolution|---                         |WORKSFORME
    
    --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    I can't replicate this any more so am marking is closed.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:05:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:05:35 +0000
    Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
    In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-13985-70-roADs7t4Ga@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
    Bug 13985 depends on bug 23461, which changed state.
    
    Bug 23461 Summary: Popup blockers triggered by option to automatically display payment receipt for printing after making a payment
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23461
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |RESOLVED
             Resolution|---                         |WORKSFORME
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:07:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:07:09 +0000
    Subject: [Koha-bugs] [Bug 27804] Convert register transactions table to a
     single ajax driven datatable
    In-Reply-To: <bug-27804-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27804-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27804-70-jNdgytsAon@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27804
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |13985
                 Blocks|13985                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
    [Bug 13985] Cash Management - Koha as 'Point of Sale'
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:07:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:07:09 +0000
    Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
    In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-13985-70-PmcFSvlVSq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |27804
             Depends on|27804                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27804
    [Bug 27804] Convert register transactions table to a single ajax driven
    datatable
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:08:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:08:15 +0000
    Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
    In-Reply-To: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23991-70-GlQZbbdNbP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:08:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:08:20 +0000
    Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
    In-Reply-To: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23991-70-vvSWSnDAhS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991
    
    --- Comment #53 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133874
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133874&action=edit
    Bug 23991: (follow-up) Add value to filter_archived
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:08:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:08:45 +0000
    Subject: [Koha-bugs] [Bug 28544] Add API's for account transactions
    In-Reply-To: <bug-28544-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28544-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28544-70-oWqg1S2mmx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28544
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|13985                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
    [Bug 13985] Cash Management - Koha as 'Point of Sale'
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:08:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:08:45 +0000
    Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
    In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-13985-70-VeUlXLFd35@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|28544                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28544
    [Bug 28544] Add API's for account transactions
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:09:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:09:34 +0000
    Subject: [Koha-bugs] [Bug 30619] Add the option to email receipts as an
     alternative to printing
    In-Reply-To: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30619-70-7nJ468Jmhx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |13985
                 Blocks|13985                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
    [Bug 13985] Cash Management - Koha as 'Point of Sale'
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:09:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:09:34 +0000
    Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
    In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-13985-70-I0ahZsJZlC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30619
             Depends on|30619                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619
    [Bug 30619] Add the option to email receipts as an alternative to printing
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:10:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:10:24 +0000
    Subject: [Koha-bugs] [Bug 28192] Archived credit/debit types should be
     filtered by default
    In-Reply-To: <bug-28192-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28192-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28192-70-QYqgVilY03@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28192
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |13985
                 Blocks|13985                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
    [Bug 13985] Cash Management - Koha as 'Point of Sale'
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:10:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:10:24 +0000
    Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
    In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-13985-70-s72hZcFit1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |28192
             Depends on|28192                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28192
    [Bug 28192] Archived credit/debit types should be filtered by default
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:11:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:11:24 +0000
    Subject: [Koha-bugs] [Bug 27780] Add ability to set a customised default
     sort order for sale items
    In-Reply-To: <bug-27780-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27780-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27780-70-EVIAy7xDo4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27780
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|13985                       |
             Depends on|                            |13985
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
    [Bug 13985] Cash Management - Koha as 'Point of Sale'
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:11:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:11:24 +0000
    Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
    In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-13985-70-6emmTXwPfA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |27780
             Depends on|27780                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27780
    [Bug 27780] Add ability to set a customised default sort order for sale items
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:11:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:11:34 +0000
    Subject: [Koha-bugs] [Bug 27791] Add 'fixed price' and 'variable price'
     options to debit types
    In-Reply-To: <bug-27791-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27791-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27791-70-FBN1nMfXMw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27791
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |13985
                 Blocks|13985                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
    [Bug 13985] Cash Management - Koha as 'Point of Sale'
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:11:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:11:34 +0000
    Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
    In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-13985-70-wOMQ8frlyr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |27791
             Depends on|27791                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27791
    [Bug 27791] Add 'fixed price' and 'variable price' options to debit types
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:14:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:14:28 +0000
    Subject: [Koha-bugs] [Bug 30610] The 'Print receipt' button on cash
     management registers page fails on second datatables page
    In-Reply-To: <bug-30610-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30610-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30610-70-1Q1ju7JslR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30610
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133843|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133875
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133875&action=edit
    Bug 30610: Update on click binding for print receipt
    
    This patch updates the binding for the on click even of the print
    receipt button so that subsequent pages in the datatable work with the
    reciept printing button.
    
    Test plan
    1) Enable cash management and process enough transactions to display
       more than one page of transactions in the register details page.
    2) Confirm the 'Print receipt' button works on the first page of
       transactions
    3) Confirm the 'Print receipt' button works on subsequent transactions
       pages in the datatable.
    4) Confirm the same for the past transactions table.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:15:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:15:31 +0000
    Subject: [Koha-bugs] [Bug 30610] The 'Print receipt' button on cash
     management registers page fails on second datatables page
    In-Reply-To: <bug-30610-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30610-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30610-70-PoSoEC8AUx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30610
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    I think we can/should trust Owens SO here as a QA stamp ;).
    
    I have double-checked my work and can confirm I've run the QA script against it
    and it's happy.. (And we now have this in live running at a site)
    
    Updating the status, thanks for testing Owen. :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:16:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:16:26 +0000
    Subject: [Koha-bugs] [Bug 23046] Add tax handling to accounts
    In-Reply-To: <bug-23046-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23046-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23046-70-wC73Pb0XD3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23046
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|13985                       |
             Depends on|23049                       |13985
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
    [Bug 13985] Cash Management - Koha as 'Point of Sale'
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
    [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:16:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:16:26 +0000
    Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
    In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-13985-70-eVjBJqkoq1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |23046
             Depends on|23046                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23046
    [Bug 23046] Add tax handling to accounts
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:16:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:16:26 +0000
    Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a
     dedicated table
    In-Reply-To: <bug-23049-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23049-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23049-70-WTTZv0heJX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|23046                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23046
    [Bug 23046] Add tax handling to accounts
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:18:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:18:21 +0000
    Subject: [Koha-bugs] [Bug 26947] kohastructure.sql should be updated for
     each release
    In-Reply-To: <bug-26947-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26947-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26947-70-t1AGLPLNb3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947
    
    --- Comment #60 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Ha, stumbled over this report again now.
    Why does 20.11 not accept my change in kohastructure, and why does master do?
    
    commit affa3164eb475ff09654c690c9df810be8dc670f
    Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Date:   Wed Nov 18 17:08:11 2020 +0000
        Bug 26947: (follow-up) Set key checks to disabled for kohastructure
    
    +    # Disable checks before load
    +    $self->{'dbh'}->do(q{SET NAMES utf8mb4});
    +    $self->{'dbh'}->do(q{SET @OLD_UNIQUE_CHECKS=@@UNIQUE_CHECKS,
    UNIQUE_CHECKS=0});
    +    $self->{'dbh'}->do(q{SET @OLD_FOREIGN_KEY_CHECKS=@@FOREIGN_KEY_CHECKS,
    FOREIGN_KEY_CHECKS=0});
    +    $self->{'dbh'}->do(q{SET @OLD_SQL_MODE=@@SQL_MODE,
    SQL_MODE='NO_AUTO_VALUE_ON_ZERO'});
    +    $self->{'dbh'}->do(q{SET @OLD_SQL_NOTES=@@SQL_NOTES, SQL_NOTES=0});
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:21:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:21:12 +0000
    Subject: [Koha-bugs] [Bug 26947] kohastructure.sql should be updated for
     each release
    In-Reply-To: <bug-26947-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26947-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26947-70-86lbVDQa5e@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947
    
    --- Comment #61 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    This latter change could have been backported since it actually resolves a
    problem that existed in Koha since we introduced DBIx::RunSQL.
    DBIx::RunSQL just silently ignore the first lines in kohastructure.sql that are
    dependent on version:
    
    /*!40101 SET @OLD_CHARACTER_SET_CLIENT=@@CHARACTER_SET_CLIENT */;
    /*!40101 SET @OLD_CHARACTER_SET_RESULTS=@@CHARACTER_SET_RESULTS */;
    /*!40101 SET @OLD_COLLATION_CONNECTION=@@COLLATION_CONNECTION */;
    /*!40101 SET NAMES utf8mb4 */;
    /*!40103 SET @OLD_TIME_ZONE=@@TIME_ZONE */;
    /*!40103 SET TIME_ZONE='+00:00' */;
    /*!40014 SET @OLD_UNIQUE_CHECKS=@@UNIQUE_CHECKS, UNIQUE_CHECKS=0 */;
    /*!40014 SET @OLD_FOREIGN_KEY_CHECKS=@@FOREIGN_KEY_CHECKS, FOREIGN_KEY_CHECKS=0
    */;
    /*!40101 SET @OLD_SQL_MODE=@@SQL_MODE, SQL_MODE='NO_AUTO_VALUE_ON_ZERO' */;
    /*!40111 SET @OLD_SQL_NOTES=@@SQL_NOTES, SQL_NOTES=0 */;
    
    I wonder if we should remove them from this sql file now, since they are
    misleading! They are never executed.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:29:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:29:36 +0000
    Subject: [Koha-bugs] [Bug 28138] Add system preference to make the payment
     type required
    In-Reply-To: <bug-28138-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28138-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28138-70-QP2cvFmI5A@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28138
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    --- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Nice :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:30:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:30:04 +0000
    Subject: [Koha-bugs] [Bug 30620] New: Add a warning close to /*!VERSION
     lines in kohastructure.sql
    Message-ID: <bug-30620-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30620
    
                Bug ID: 30620
               Summary: Add a warning close to /*!VERSION lines in
                        kohastructure.sql
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Database
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: m.de.rooy at rijksmuseum.nl
            QA Contact: testopia at bugs.koha-community.org
    
    These first lines in kohastructure are just ignored by DBIx::RunSQL.
    They could serve a purpose however when running the file directly on the sql
    command line.
    So we should at least add a comment to warn people.
    On bug 26947 some of these settings are taken over in
    C4::Installer::load_db_schema.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:30:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:30:33 +0000
    Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
     too
    In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28269-70-9IvVoOXv9k@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269
    
    --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Hi Slava, thx for your patches! 
    
    I haven't tested yet, but looking at this, I wonder if it's not actually 2
    great features :) We try to break things into small steps wherever possible, so
    I wonder if it would make sense to move your first patch to bug 23919 and link
    them both with a depends on (that will ensure the right sequence in testing).
    
    It will also have the benefit of this showing up more clearly in release notes.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:30:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:30:50 +0000
    Subject: [Koha-bugs] [Bug 30620] Add a warning close to /*!VERSION lines in
     kohastructure.sql
    In-Reply-To: <bug-30620-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30620-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30620-70-Xeghbct6dW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30620
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=26947
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:30:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:30:50 +0000
    Subject: [Koha-bugs] [Bug 26947] kohastructure.sql should be updated for
     each release
    In-Reply-To: <bug-26947-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26947-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26947-70-ZbwF3uZ9t0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30620
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:31:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:31:00 +0000
    Subject: [Koha-bugs] [Bug 30620] Add a warning close to /*!VERSION lines in
     kohastructure.sql
    In-Reply-To: <bug-30620-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30620-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30620-70-0Dyhl1pHGV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30620
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=13669
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:31:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:31:00 +0000
    Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
     MySQL 5.6+
    In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-13669-70-WAL7VmDAuJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30620
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:32:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:32:34 +0000
    Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
     MySQL 5.6+
    In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-13669-70-B90IP6byOv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
    
    --- Comment #72 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    IN the period between this push and the the push of bug 26947, the /*! version
    dependent lines at the start of kohastructure appear to have been silently
    ignored by DBIx::RunSQL.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:33:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:33:46 +0000
    Subject: [Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display
    In-Reply-To: <bug-28371-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28371-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28371-70-qhjkCkWh55@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371
    
    --- Comment #34 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Thx to the tests! But at least it seems like it was hard to catch without them,
    which makes me feel a little less guilty for missing it!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:33:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:33:47 +0000
    Subject: [Koha-bugs] [Bug 30620] Add a warning close to /*!VERSION lines in
     kohastructure.sql
    In-Reply-To: <bug-30620-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30620-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30620-70-litenrUlod@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30620
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                       |ity.org                     |
                 Status|NEW                         |ASSIGNED
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:41:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:41:45 +0000
    Subject: [Koha-bugs] [Bug 30617] [OMNIBUS] We should consistently use
     includes for patron name display
    In-Reply-To: <bug-30617-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30617-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30617-70-8ce4vQknga@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30617
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|We should consistently use  |[OMNIBUS] We should
                       |includes for patron name    |consistently use includes
                       |display                     |for patron name display
               Keywords|                            |Academy
    
    --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    I guess this calls for a lot of smaller bugs in a way trying to clean up
    various templates.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:51:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:51:39 +0000
    Subject: [Koha-bugs] [Bug 26947] kohastructure.sql should be updated for
     each release
    In-Reply-To: <bug-26947-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26947-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26947-70-MH5Bt7LaeL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947
    
    --- Comment #62 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Marcel de Rooy from comment #61)
    > This latter change could have been backported since it actually resolves a
    > problem that existed in Koha since we introduced DBIx::RunSQL.
    > DBIx::RunSQL just silently ignore the first lines in kohastructure.sql that
    > are dependent on version:
    > 
    > /*!40101 SET @OLD_CHARACTER_SET_CLIENT=@@CHARACTER_SET_CLIENT */;
    > /*!40101 SET @OLD_CHARACTER_SET_RESULTS=@@CHARACTER_SET_RESULTS */;
    > /*!40101 SET @OLD_COLLATION_CONNECTION=@@COLLATION_CONNECTION */;
    > /*!40101 SET NAMES utf8mb4 */;
    > /*!40103 SET @OLD_TIME_ZONE=@@TIME_ZONE */;
    > /*!40103 SET TIME_ZONE='+00:00' */;
    > /*!40014 SET @OLD_UNIQUE_CHECKS=@@UNIQUE_CHECKS, UNIQUE_CHECKS=0 */;
    > /*!40014 SET @OLD_FOREIGN_KEY_CHECKS=@@FOREIGN_KEY_CHECKS,
    > FOREIGN_KEY_CHECKS=0 */;
    > /*!40101 SET @OLD_SQL_MODE=@@SQL_MODE, SQL_MODE='NO_AUTO_VALUE_ON_ZERO' */;
    > /*!40111 SET @OLD_SQL_NOTES=@@SQL_NOTES, SQL_NOTES=0 */;
    > 
    > I wonder if we should remove them from this sql file now, since they are
    > misleading! They are never executed.
    
    Opened bug 30620 to add at least a comment leaving the possibility to run this
    directly.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:56:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:56:36 +0000
    Subject: [Koha-bugs] [Bug 26947] kohastructure.sql should be updated for
     each release
    In-Reply-To: <bug-26947-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26947-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26947-70-UbuzrUNVOt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947
    
    --- Comment #63 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    And in line with the former comments, the following commit made lots of useless
    changes in kohastructure:
    
    commit 8c5845ef9ecd92584723cd60a221ecd4710a2516
    Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Date:   Fri Dec 4 15:39:32 2020 +0100
    
        Bug 26947: Update kohastructure.sql
    
    The following pattern was added:
    -DROP TABLE IF EXISTS `auth_header`;
    -CREATE TABLE `auth_header` (
    +DROP TABLE IF EXISTS `account_credit_types`;
    +/*!40101 SET @saved_cs_client     = @@character_set_client */;
    +/*!40101 SET character_set_client = utf8 */;
    +CREATE TABLE `account_credit_types` (
    
    But note that if we run the file in the usual way via Installer, these lines
    with /*! pass DBIx::RunSQL and are just IGNORED ! They are useless !
    
    Could you remove them, Jonathan ?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 13:57:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 11:57:27 +0000
    Subject: [Koha-bugs] [Bug 26947] kohastructure.sql should be updated for
     each release
    In-Reply-To: <bug-26947-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26947-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26947-70-WvQwYmFlbR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947
    
    --- Comment #64 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Marcel de Rooy from comment #63)
    > And in line with the former comments, the following commit made lots of
    > useless changes in kohastructure:
    > 
    > commit 8c5845ef9ecd92584723cd60a221ecd4710a2516
    > Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    > Date:   Fri Dec 4 15:39:32 2020 +0100
    > 
    >     Bug 26947: Update kohastructure.sql
    > 
    > The following pattern was added:
    > -DROP TABLE IF EXISTS `auth_header`;
    > -CREATE TABLE `auth_header` (
    > +DROP TABLE IF EXISTS `account_credit_types`;
    > +/*!40101 SET @saved_cs_client     = @@character_set_client */;
    > +/*!40101 SET character_set_client = utf8 */;
    > +CREATE TABLE `account_credit_types` (
    > 
    > But note that if we run the file in the usual way via Installer, these lines
    > with /*! pass DBIx::RunSQL and are just IGNORED ! They are useless !
    > 
    > Could you remove them, Jonathan ?
    
    Ha copied the wrong DROP/CREATE example, but you ll probaly understand it :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 14:02:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 12:02:32 +0000
    Subject: [Koha-bugs] [Bug 30620] Add a warning close to /*!VERSION lines in
     kohastructure.sql
    In-Reply-To: <bug-30620-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30620-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30620-70-s5AyA3WxFJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30620
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
       Patch complexity|---                         |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 14:02:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 12:02:36 +0000
    Subject: [Koha-bugs] [Bug 30620] Add a warning close to /*!VERSION lines in
     kohastructure.sql
    In-Reply-To: <bug-30620-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30620-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30620-70-HjnNZFbOYf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30620
    
    --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133876
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133876&action=edit
    Bug 30620: Add a warning about /*!VERSION lines in kohastructure
    
    Also adding a similar comment in C4::Installer.
    
    No test plan, just documentation.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 14:03:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 12:03:01 +0000
    Subject: [Koha-bugs] [Bug 30620] Add a warning close to /*!VERSION lines in
     kohastructure.sql
    In-Reply-To: <bug-30620-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30620-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30620-70-IXyf3D5Mq1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30620
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Trivial: self SO
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 14:03:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 12:03:32 +0000
    Subject: [Koha-bugs] [Bug 30620] Add a warning close to /*!VERSION lines in
     kohastructure.sql
    In-Reply-To: <bug-30620-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30620-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30620-70-a8vdgTzqbY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30620
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com, tomascohen at gmail.com
    
    --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    QA should be trivial too ?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 14:10:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 12:10:25 +0000
    Subject: [Koha-bugs] [Bug 30432] get_items_that_can_fill needs to specify
     table for biblionumbers
    In-Reply-To: <bug-30432-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30432-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30432-70-77Xh4pfzhk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432
    
    --- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133877
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133877&action=edit
    Bug 30432: [21.05.x] Specify 'me' for biblionumber when limiting items
    
    To test:
    1 - Apply only unit tests
    2 - prove t/db_dependent/Koha/Holds.t
    3 - It fails
    4 - Apply this patch
    5 - prove t/db_dependent/Koha/Holds.t
    6 - It passes!
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Bug 30432: Unit test
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Bug 30432: Fix random failure
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 14:14:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 12:14:00 +0000
    Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen
    In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23919-70-2LajdArS37@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |slavashishkin at gmail.com
                       |ity.org                     |
                     CC|                            |slavashishkin at gmail.com
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 14:15:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 12:15:57 +0000
    Subject: [Koha-bugs] [Bug 30563] Add system preference to make the cash
     register field required when collecting a payment
    In-Reply-To: <bug-30563-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30563-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30563-70-WYyutvrzr6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30563
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 14:16:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 12:16:02 +0000
    Subject: [Koha-bugs] [Bug 30563] Add system preference to make the cash
     register field required when collecting a payment
    In-Reply-To: <bug-30563-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30563-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30563-70-NO5cJfyjCa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30563
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133698|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133878
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133878&action=edit
    Bug 30563: Add syspref to make the "cash register" field mandatory
    
    Test plan:
    1. Apply patch and run updatedatabase
    2. Enable 'UseCashRegisters' syspref and create at least one cash
       register for your library
    3. Verify that you have several authorized values in the 'PAYMENT_TYPE'
       category. One of them should be 'CASH'
    4. Go to a patron accounting tab, create a manual invoice and go to the
       payment form. Select payment type 'CASH' and verify that you cannot
       submit the form if no cash register is selected.
       Select another payment type and verify that you can submit the form
       even if no cash register is selected
    5. Set syspref 'RequireCashRegister' to 'always require a cash register'
    6. Repeat step 4 but this time you should not be able to submit the form
       if no cash register is selected, no matter which payment type is
       selected.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 14:16:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 12:16:06 +0000
    Subject: [Koha-bugs] [Bug 30563] Add system preference to make the cash
     register field required when collecting a payment
    In-Reply-To: <bug-30563-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30563-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30563-70-0HroDhj1ca@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30563
    
    --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133879
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133879&action=edit
    Bug 30563: (QA follow-up) Fix permission on atomicupdate file
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 14:16:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 12:16:10 +0000
    Subject: [Koha-bugs] [Bug 30563] Add system preference to make the cash
     register field required when collecting a payment
    In-Reply-To: <bug-30563-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30563-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30563-70-6VkKyobqOG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30563
    
    --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133880
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133880&action=edit
    Bug 30563: (QA follow-up) Fix system preference values and add link to
    description
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 14:19:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 12:19:39 +0000
    Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
     too
    In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28269-70-HfiiEIXv0U@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269
    
    --- Comment #8 from Slava Shishkin <slavashishkin at gmail.com> ---
    Hi Katrin,
    Okay, I'll deal with these issues.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 14:23:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 12:23:04 +0000
    Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
     too
    In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28269-70-ZvE6X2G3X4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269
    
    --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Let us know if we can help in any way :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 14:24:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 12:24:02 +0000
    Subject: [Koha-bugs] [Bug 30449] Missing FK constraint on
     borrower_attribute_types
    In-Reply-To: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30449-70-Z32tYpHQS3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449
    
    --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Marcel de Rooy from comment #4)
    > I am wondering how DBIx::RunSQL handles our /*4xxx SET FOREIGN KEY CHECKS
    > OFF*/ line.
    
    Well, quite simple. It does ignore such lines. The following commit added these
    checks in Installer:
        Bug 26947: (follow-up) Set key checks to disabled for kohastructure
    
    But note that DBIx::RunSQL was already added on bug 13669 ;)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 14:25:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 12:25:40 +0000
    Subject: [Koha-bugs] [Bug 27470] Improve link text for logging in
    In-Reply-To: <bug-27470-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27470-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27470-70-Ud64JyfoWc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27470
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 14:25:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 12:25:45 +0000
    Subject: [Koha-bugs] [Bug 27470] Improve link text for logging in
    In-Reply-To: <bug-27470-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27470-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27470-70-L0B0wnjM54@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27470
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133579|0                           |1
            is obsolete|                            |
    
    --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133881
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133881&action=edit
    Bug 27470: Improved link text for shibboleth login
    
    TEST PLAN:
    1) Enable shibboleth by adding shibboleth to koha-conf.xml, you can do
       this by following
    
      
    https://wiki.koha-community.org/wiki/Shibboleth_Configuration#Using_AD_FS_Metadata
    
    2) If you are logged in Koha, log out, on the login screen the text
       at the top should say the following, "Log in using a Shibboleth
       account"
    
    Sponsored-by: Catalyst IT
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 14:25:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 12:25:49 +0000
    Subject: [Koha-bugs] [Bug 30449] Missing FK constraint on
     borrower_attribute_types
    In-Reply-To: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30449-70-A1BlBgaimc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449
    
    --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Anyway, we do not need to move the (re)definition of borrower_attribute_types
    below categories now.
    You should however when you backport this patch BELOW 21.05 !
    Or add these lines too in Installer:
    
    +    # Disable checks before load
    +    $self->{'dbh'}->do(q{SET NAMES utf8mb4});
    +    $self->{'dbh'}->do(q{SET @OLD_UNIQUE_CHECKS=@@UNIQUE_CHECKS,
    UNIQUE_CHECKS=0});
    +    $self->{'dbh'}->do(q{SET @OLD_FOREIGN_KEY_CHECKS=@@FOREIGN_KEY_CHECKS,
    FOREIGN_KEY_CHECKS=0});
    +    $self->{'dbh'}->do(q{SET @OLD_SQL_MODE=@@SQL_MODE,
    SQL_MODE='NO_AUTO_VALUE_ON_ZERO'});
    +    $self->{'dbh'}->do(q{SET @OLD_SQL_NOTES=@@SQL_NOTES, SQL_NOTES=0});
    +
    +    # Load kohastructure
         my $error = $self->load_sql("$datadir/kohastructure.sql");
    +
    +    # Re-enable checks after load
    +    $self->{'dbh'}->do(q{SET SQL_MODE=@OLD_SQL_MODE});
    +    $self->{'dbh'}->do(q{SET FOREIGN_KEY_CHECKS=@OLD_FOREIGN_KEY_CHECKS});
    +    $self->{'dbh'}->do(q{SET UNIQUE_CHECKS=@OLD_UNIQUE_CHECKS});
    +    $self->{'dbh'}->do(q{SET SQL_NOTES=@OLD_SQL_NOTES});
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 14:45:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 12:45:08 +0000
    Subject: [Koha-bugs] [Bug 30514] Error in date format check following
     datepicker removal
    In-Reply-To: <bug-30514-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30514-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30514-70-wN6Y91rmqs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30514
    
    --- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
    In my testing today I found that it works but only after "restart_all." I don't
    know why this would be. Individually restarting plack, memcached, or apache
    doesn't help. Other system preferences, like IntranetUserCSS, are applied
    immediately without restart.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 14:54:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 12:54:06 +0000
    Subject: [Koha-bugs] [Bug 30139] Point of sale sets wrong 'Amount being
     paid' with CurrencyFormat = FR
    In-Reply-To: <bug-30139-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30139-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30139-70-yRCVa7BLpd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30139
    
    --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    It's the interaction between format_price and moneyFormat.. moneyFormat appears
    to be hard coded to '.' decimal separators.. but then Koha's internals expect
    point decimal separators in inputs too.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:03:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:03:20 +0000
    Subject: [Koha-bugs] [Bug 30057] Move Virtualshelves exceptions to their own
     file
    In-Reply-To: <bug-30057-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30057-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30057-70-IFWwMkyIdS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30057
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:03:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:03:25 +0000
    Subject: [Koha-bugs] [Bug 30057] Move Virtualshelves exceptions to their own
     file
    In-Reply-To: <bug-30057-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30057-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30057-70-T2Lyqjhqyn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30057
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133414|0                           |1
            is obsolete|                            |
    
    --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 133882
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133882&action=edit
    Bug 30057: Move virtualshelf-related exceptions to a separate library
    
    This patch moves the not-generic virtualshelf-related exceptions to
    their own file. Callers are adjusted as required.
    
    To test:
    1. Run:
       $ kshell
      k$ prove t/db_dependent/Virtualshelves.t
    => SUCCESS: Tests pass
    2. Apply this patch
    3. Repeat 1
    => SUCCESS: Tests pass
    4. Check virtualshelves work as expected
    5. Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:03:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:03:43 +0000
    Subject: [Koha-bugs] [Bug 30057] Move Virtualshelves exceptions to their own
     file
    In-Reply-To: <bug-30057-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30057-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30057-70-rafZdAV1TZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30057
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |m.de.rooy at rijksmuseum.nl
             QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                       |y.org                       |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:03:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:03:57 +0000
    Subject: [Koha-bugs] [Bug 30449] Missing FK constraint on
     borrower_attribute_types
    In-Reply-To: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30449-70-vpwJhWRNiz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133777|0                           |1
            is obsolete|                            |
    
    --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133883
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133883&action=edit
    Bug 30449: Add missing FK constraint on borrower_attribute_types
    
    Old Koha databases probably have it, newer ones might not.
    See also BZ description.
    
    Test plan:
    [1} Check SHOW CREATE TABLE borrower_attribute_types to see if you
        have any index and FK constraint on category_code.
    [2] Run updatedatabase.
    [3] If you had category_code_fk, it should be replaced.
    [4] Remove index and constraint again using things like:
        alter table borrower_attribute_types drop constraint
    `borrower_attribute_types_ibfk_1`;
        alter table borrower_attribute_types drop index category_code;
    [5] Run updatedatabase.
    [6] You should have KEY category_code and FK borrower_attribute_types_ibfk_1.
    [7] Run updatedatabase. Idempotent, no changes.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:04:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:04:02 +0000
    Subject: [Koha-bugs] [Bug 30449] Missing FK constraint on
     borrower_attribute_types
    In-Reply-To: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30449-70-NhB6AX4226@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133778|0                           |1
            is obsolete|                            |
    
    --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133884
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133884&action=edit
    Bug 30449: DBIC updates
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:04:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:04:07 +0000
    Subject: [Koha-bugs] [Bug 30449] Missing FK constraint on
     borrower_attribute_types
    In-Reply-To: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30449-70-kpf58D70mC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449
    
    --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133885
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133885&action=edit
    Bug 30449: (QA follow-up) Report back on problematic situations
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:04:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:04:25 +0000
    Subject: [Koha-bugs] [Bug 30449] Missing FK constraint on
     borrower_attribute_types
    In-Reply-To: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30449-70-Fg0p5CKttC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
     Attachment #133779|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:04:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:04:39 +0000
    Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
     contents into notices tool
    In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-3150-70-gt7mincE79@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150
    
    Christian Stelzenmüller <christian.stelzenmueller at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Failed QA
    
    --- Comment #81 from Christian Stelzenmüller <christian.stelzenmueller at bsz-bw.de> ---
    Hi everyone,
    
    i'm sorry, step 7 in the test plan doesn't work for me. There are no messages
    in the message queue.
    
    I hope i'm not doing anything wrong. I also tried applying bug 3150 and 27266,
    one after the other, because i wasn't sure, but the results were the same.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:04:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:04:42 +0000
    Subject: [Koha-bugs] [Bug 30449] Missing FK constraint on
     borrower_attribute_types
    In-Reply-To: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30449-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30449-70-DqDA3UoL6m@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Working well, a good job resyncing.  Thanks
    
    PQA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:09:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:09:17 +0000
    Subject: [Koha-bugs] [Bug 29077] Warns when searching blank index
    In-Reply-To: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29077-70-scGKdKKMSB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29077
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133515|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133886
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133886&action=edit
    Bug 29077: Remove blank indexes before convert
    
    To test:
    1 - Be using Elasticsearch
    2 - Search on OPAC with dropdown set to 'Library catalog'
    3 - Warns in plack-opac-error.log
    4 - Apply patch
    5 - Repeat
    6 - No warns
    7 - Search returns correct results
    
    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:11:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:11:05 +0000
    Subject: [Koha-bugs] [Bug 29077] Warns when searching blank index
    In-Reply-To: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29077-70-HS6sH2llNI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29077
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
                 Status|Signed Off                  |Passed QA
    
    --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    This works, so Passing QA.. but I agree it's a little easier to read in the
    other form.. happy for that to be an RM follow-up?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:13:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:13:03 +0000
    Subject: [Koha-bugs] [Bug 29926] Add ability for superlibrarians to edit
     password expiration dates
    In-Reply-To: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29926-70-PDarhlCbfc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29926
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:13:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:13:06 +0000
    Subject: [Koha-bugs] [Bug 29926] Add ability for superlibrarians to edit
     password expiration dates
    In-Reply-To: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29926-70-qowzmFhTiP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29926
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133760|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:13:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:13:09 +0000
    Subject: [Koha-bugs] [Bug 29926] Add ability for superlibrarians to edit
     password expiration dates
    In-Reply-To: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29926-70-TfRET2QyRj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29926
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133761|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:13:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:13:12 +0000
    Subject: [Koha-bugs] [Bug 29926] Add ability for superlibrarians to edit
     password expiration dates
    In-Reply-To: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29926-70-tULbSrfZ65@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29926
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133759|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:13:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:13:46 +0000
    Subject: [Koha-bugs] [Bug 29926] Add ability for superlibrarians to edit
     password expiration dates
    In-Reply-To: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29926-70-IW7GbFFVXs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29926
    
    --- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133887
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133887&action=edit
    Bug 29926: Add pasword expiration route for API
    
    To test:
    1 - prove -v t/db_dependent/api/v1/patrons_password_expiration.t
    
    Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:13:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:13:57 +0000
    Subject: [Koha-bugs] [Bug 29926] Add ability for superlibrarians to edit
     password expiration dates
    In-Reply-To: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29926-70-Q1Hk8TBg57@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29926
    
    --- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133888
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133888&action=edit
    Bug 29926: Add ability for superlibrarian to view/edit password expiration
    
    To  test:
     1 - Sign in as a superlibrarian
     2 - Find a patron account with no password expiration set
     3 - View member detials
     4 - note expiration says 'Never'
     5 - Edit patron
     6 - Set patron expiration
     7- Save
     8 - View details, confirm password expiration shows correctly
     9 - Sign in as non-superlibrarian
    10 - Confirm you don't see expirationdate on details page
    11 - Edit patron and confirm password expiration does not show
    12 - Edit HTML and confirm you epxiration date not saved
         <input type="text" name="password_expiration_date" value="2052-05-02">
    
    Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:14:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:14:03 +0000
    Subject: [Koha-bugs] [Bug 29926] Add ability for superlibrarians to edit
     password expiration dates
    In-Reply-To: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29926-70-SIKqoRjnvX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29926
    
    --- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133889
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133889&action=edit
    Bug 29926: Add ability for superlibrarians to batch edit password expiration
    dates
    
    To test:
    1 - Sign in as a superlibrarian
    2 - Tools->Batch patron modification
    3 - Add patrons with and without pasword expiration set
    4 - Confirm dates display correctly on modification page, or show never
    5 - Check the box to delete all dates
    6 - Confirm patrons now show 'Never'
    7 - Edit patrons again, set a date
    8 - Confirm date is set correctly
    9 - Sign in as a user with catalogue/tools/borrowers permissions, but not
    superlibrarian
    10 - Confirm y9ou do not see, and cannnot edit password expiration dates
    
    Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:14:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:14:09 +0000
    Subject: [Koha-bugs] [Bug 29926] Add ability for superlibrarians to edit
     password expiration dates
    In-Reply-To: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29926-70-IeDJUcb8co@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29926
    
    --- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133890
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133890&action=edit
    Bug 29926: (QA follow-up) API design fixes
    
    This patch makes the following changes to the spec:
    
    * Password being the resource and expiration_date an attribute for it,
      so reorganizing things and also renaming the route.
    * Be it undefined or defined, expiration date is only one and thus
      should use the PUT verb (as in overwrite).
    * Minor bug 30194-related fixes.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:14:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:14:15 +0000
    Subject: [Koha-bugs] [Bug 29926] Add ability for superlibrarians to edit
     password expiration dates
    In-Reply-To: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29926-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29926-70-yITDQkUfcJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29926
    
    --- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133891
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133891&action=edit
    Bug 29926: (QA follow-up) Date format missing in spec
    
    On fixing the spec to have `format: date` I noticed the tests were
    expecting explosions because of date handling not being done. The
    OpenAPI plugin does this correctly when you set the format right.
    
    So, I adapted the tests so they expect 400 and return the type error.
    
    We don't usually add such tests (i.e. test the plugin does its job
    correctly) but it doesn't hurt to keep them just in case something
    really changes badly there (plugin bug?).
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:15:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:15:30 +0000
    Subject: [Koha-bugs] [Bug 30572] Field search_marc_to_field.sort needs
     syncing too
    In-Reply-To: <bug-30572-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30572-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30572-70-UKfDWQLXll@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30572
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133552|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133892
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133892&action=edit
    Bug 30572: Adjust search_marc_to_field.sort in kohastructure
    
    Test plan:
    New install or run kohastructure on empty database.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:15:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:15:34 +0000
    Subject: [Koha-bugs] [Bug 30572] Field search_marc_to_field.sort needs
     syncing too
    In-Reply-To: <bug-30572-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30572-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30572-70-mse19mpPWW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30572
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133553|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133893
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133893&action=edit
    Bug 30572: Dbrev for search_marc_to_field.sort
    
    Test plan:
    Run updatedatabase.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:15:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:15:38 +0000
    Subject: [Koha-bugs] [Bug 30572] Field search_marc_to_field.sort needs
     syncing too
    In-Reply-To: <bug-30572-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30572-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30572-70-RqjoXTH6zv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30572
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133554|0                           |1
            is obsolete|                            |
    
    --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133894
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133894&action=edit
    Bug 30572: DBIx schema change for SearchMarcToField
    
    No test plan.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:16:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:16:01 +0000
    Subject: [Koha-bugs] [Bug 30572] Field search_marc_to_field.sort needs
     syncing too
    In-Reply-To: <bug-30572-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30572-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30572-70-fCpK9SiXzq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30572
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Works well, PQA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:19:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:19:17 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-fwdTOdPsXY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:28:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:28:30 +0000
    Subject: [Koha-bugs] [Bug 30491] Convert saved reports tabs to Bootstrap
    In-Reply-To: <bug-30491-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30491-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30491-70-zmqg60HbCf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30491
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:28:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:28:35 +0000
    Subject: [Koha-bugs] [Bug 30491] Convert saved reports tabs to Bootstrap
    In-Reply-To: <bug-30491-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30491-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30491-70-aHTfIF6dex@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30491
    
    --- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133895
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133895&action=edit
    Bug 30491: Convert saved reports tabs to Bootstrap
    
    This patch updates the saved reports page so that it uses Bootstrap tabs
    instead of jQueryUI.
    
    To test, apply the patch and go to Reports -> Use saved.
    
     - On the Saved Reports page you should see multiple tabs.
     - Each should look correct and work correctly.
     - Clicking each tab should result in the table of reports filtering
       correctly for that tab (Patrons tab showing only patrons reports).
     - If necessary, edit one or more reports so that they have a subgroup.
     - Confirm that each subgroup selector is correct for each tab, i.e. a
       subgroup created under "Catalog" should only be available under the
       Catalog tab.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:29:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:29:44 +0000
    Subject: [Koha-bugs] [Bug 30577] Item specific holds location can be missed
     when placing title level holds
    In-Reply-To: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30577-70-b4rzwfl40Q@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    A change to ysearch.pl crept in here Nick.. I'll fix it up for you whilst QAing
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:31:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:31:33 +0000
    Subject: [Koha-bugs] [Bug 30584] Cannot add field mappings to Elasticsearch
     configuration
    In-Reply-To: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30584-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30584-70-mmnShTMnMQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|22.05.00                    |22.05.00,21.11.05
            released in|                            |
                 Status|Pushed to master            |Pushed to stable
    
    --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:32:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:32:15 +0000
    Subject: [Koha-bugs] [Bug 30577] Item specific holds location can be missed
     when placing title level holds
    In-Reply-To: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30577-70-1rH01zXNzW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133687|0                           |1
            is obsolete|                            |
    
    --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133896
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133896&action=edit
    Bug 30577: Move item specific pickup locations to the left
    
    When placing holds, staff will set the pickup location at the top,
    choose an item, then place the hold.
    It is easy not to notice the item specific locations dropdown.
    
    This patch moves it in line with the other selction areas on the request
    screen.
    
    To test:
     1 - Find a record on staff client, place hold
     2 - Select a patron to load the request screen
     3 - Note the location dropdown for next available hold
     4 - Note the item specific locations on the far right
     5 - Apply patch
     6 - Reload the page
     7 - Note the item specific location dropdowns are now moved to the left
     8 - Place the hold, verify it works with the dropdowns
     9 - Verify title levelholds still work as expected
    10 - Verify multi-holds still work
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:32:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:32:20 +0000
    Subject: [Koha-bugs] [Bug 30577] Item specific holds location can be missed
     when placing title level holds
    In-Reply-To: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30577-70-mZ5t1c5lwI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133688|0                           |1
            is obsolete|                            |
    
    --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133897
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133897&action=edit
    Bug 30577: Fix a missing closing tag
    
    This didn't affect table display, but when there was a biblioloo.warn
    we were not closing the first <td> tag
    
    Confirm multi-holds table loads correctly when one (or more) records cannot be
    held
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:32:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:32:46 +0000
    Subject: [Koha-bugs] [Bug 30577] Item specific holds location can be missed
     when placing title level holds
    In-Reply-To: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30577-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30577-70-KO7T0SV3q4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Looks good, works as expceted.. QA scripts happy.
    
    PQA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:38:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:38:02 +0000
    Subject: [Koha-bugs] [Bug 30620] Add a warning close to /*!VERSION lines in
     kohastructure.sql
    In-Reply-To: <bug-30620-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30620-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30620-70-RSzUsiAm2U@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30620
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133876|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133898
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133898&action=edit
    Bug 30620: Add a warning about /*!VERSION lines in kohastructure
    
    Also adding a similar comment in C4::Installer.
    
    No test plan, just documentation.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:39:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:39:35 +0000
    Subject: [Koha-bugs] [Bug 30620] Add a warning close to /*!VERSION lines in
     kohastructure.sql
    In-Reply-To: <bug-30620-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30620-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30620-70-gCNBPSxvmL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30620
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Trivial improvement, Passing QA.
    
    Note however that we will need to consider the .SQL file change as if we start
    to use koha-dump to generate the structure file regularly (to keep
    updatedatabase and the kohastrucutre files in sync as intended) it will wipe
    out the change here.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:40:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:40:15 +0000
    Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
    In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29897-70-tJ5kBg9z9n@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Failed QA
    
    --- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    I'd really love to have this feature, but going through the code sadly found a
    bigger issue with the specification :(
    
    I am making this 0) now, although I caught it last at the bottom of the source
    tree:
    
    0) Linkage $6
    
    In your code you assume that $6 is a URL, but that will NEVER be the case
    according to MARC standard.
    
    $6 is a very specialized field that will never contain a URL. Linkage here
    means 'linking MARC fields within the record'. For example it is used to link
    an original script tag with the corresponding tag in transliteration. See:
    https://www.loc.gov/marc/authority/ecadcntf.html
    
    So I don't think we can push this as is. :(
    
    If at all, a link would probably be in $1, but that's a quite new field and
    quite unlikely. I think our best bet for a universally working feature right
    now is to buidl the URLs to the corresponding portals using the cataloged IDs
    form $a ourselves.
    
    This also means, that we should limit our efforts on a short list of $2 codes
    for now. The 4 you have in there would be fine with me. We could add others
    later. 
    
    We should also limit $2 display to the ones we have implemented and checked,
    some are just not useful to patrons.
    
    
    1) Missing POD for _get_marc_authors
    
    Could it be a little confusing having _get_marc_authors and get_marc_authors?
    
    2) On get_marc_contributurs, you write:
    
    (700..712 for MARC21)
    
    but:
    
    +    if ( $marcflavour eq "UNIMARC" ) {
    +        $mintag = "700";
    +        $maxtag = "712";
    +        $fields_filter = '7..';
    +    } else { # marc21/normarc
    +        $mintag = "700";
    +        $maxtag = "720";
    +        $fields_filter = '7..';
    +    }
    
    Overall using a range instead of a list seems a little risky, but works for
    MARC21. It looks like a lot of fields, but actually it's only: 700, 710, 711
    and 720. 
    (https://www.loc.gov/marc/bibliographic/bd70x75x.html)
    
    
    3) Missing 110, 111
    
    If we get 710 and 711 we should probably include 110 and 111 in
    get_marc_authors as well. As it was 'wrong' before, should we file a separate
    bug report to extend this method?
    
    4) Pref description
    
    I am struggling a bit with the description.
    
    [Display|Don't display] author identifiers for research publications.
    
    It makes it sound, like it was limited to research publications, while the
    limit is actually the 024 existing or not.
    
    Adding information that this requires authorities and 024 would be good I
    think. Maybe:
    
    
    [Display|Don't display] identifiers for authors and contributors to the detail
    pages in the OPAC. This feature requires authorities with 024
    
    
    5) Selection of $2
    
    +  [% CASE 'orcid' %]ORCID:
    +  [% CASE 'scopus' %]ScopusID:
    +  [% CASE 'loop' %]loop:
    +  [% CASE 'rid' %]Publons:
    
    a) Should these be surrounded by <span>?
    b) $2 are usually taken from the official LOC list:
    https://www.loc.gov/standards/sourcelist/standard-identifier.html
    
    orcid = ORCID OK
    scopus = ScopusID OK
    loop = doesn't exist in official list. I am fine with it if that is a custom
    one, but maybe worth checking?
    rid = ResearcherID, linking to:
    http://www.researcherid.com/#rid-for-researchers, stating:
    ResearcherID profiles moved to Publons on 15 April 2019 - so probably OK
    
    viaf might be a good candidate (for another bug).
    
    The fallback worries me: 
    [% CASE %][% identifier.source | html %]:
    
    I think we should stick with a hardcoded list as not all $2 codes and
    identifiers are useful to patrons (and they might get into the catalog, if you
    use a central authority file)
    
    c) I'd also suggest to add a class with the $2 to the <li> element, this way
    each entry could be hidden and customized easily.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:42:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:42:57 +0000
    Subject: [Koha-bugs] [Bug 30199] self checkout login by cardnumber is broken
     if you input a non-existent cardnumber
    In-Reply-To: <bug-30199-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30199-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30199-70-EjKZ79Finu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30199
    
    Sarah Cornell <sbcornell at cityofportsmouth.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |sbcornell at cityofportsmouth.
                       |                            |com
    
    --- Comment #17 from Sarah Cornell <sbcornell at cityofportsmouth.com> ---
    We'd love to have this backported to 21.05 as soon as possible.  It's starting
    to show up on machines that were previously well-behaved.  Thanks!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:44:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:44:14 +0000
    Subject: [Koha-bugs] [Bug 30366] Warn when running
     automatic_item_modification_by_age.pl
    In-Reply-To: <bug-30366-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30366-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30366-70-RYk70d3qho@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30366
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:44:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:44:17 +0000
    Subject: [Koha-bugs] [Bug 30366] Warn when running
     automatic_item_modification_by_age.pl
    In-Reply-To: <bug-30366-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30366-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30366-70-Dx61ErjiS0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30366
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133844|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133899
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133899&action=edit
    Bug 30366: Remove warn when running automatic_item_modification_by_age.pl
    
    When using the ./misc/cronjobs/automatic_item_modification_by_age.pl -v
    after setting up rules under Tools > Automatic item modifications by
    age the script outputs several lines of warnings:
    
    Use of uninitialized value in string eq at /kohadevbox/koha/C4/Items.pm
    line 1864.
    
    This is because even when there is no condition defined, modification
    rule is stored with empty hash, like :
    [{"substitutions":[{"field":"items.new_status","value":"0"}],"conditions":[{}],"age":"60","agefield":"items.dateaccessioned"}]
    
    Test plan :
    1) Go to Tools > Automatic item modifications by age
    2) Create a rule with no conditions, just a substitution
    3) Run misc/cronjobs/automatic_item_modification_by_age.pl -v
    4) Check there is no warning
    5) Edit the rule to add a condition
    6) Run misc/cronjobs/automatic_item_modification_by_age.pl -v
    7) Check the condition is applied
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:45:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:45:06 +0000
    Subject: [Koha-bugs] [Bug 30597] Update wording of RestrictionBlockRenewing
     to include auto-renew
    In-Reply-To: <bug-30597-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30597-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30597-70-qnXTdCokiR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30597
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |andrew at bywatersolutions.com
                       |ity.org                     |
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:48:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:48:27 +0000
    Subject: [Koha-bugs] [Bug 30597] Update wording of RestrictionBlockRenewing
     to include auto-renew
    In-Reply-To: <bug-30597-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30597-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30597-70-mfoFyyMGAa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30597
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
       Patch complexity|---                         |String patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:48:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:48:31 +0000
    Subject: [Koha-bugs] [Bug 30597] Update wording of RestrictionBlockRenewing
     to include auto-renew
    In-Reply-To: <bug-30597-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30597-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30597-70-3zEG0qXLn5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30597
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133692|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133900
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133900&action=edit
    Bug 30597: Update RestrictionBlockRenewing description to include auto renew
    
    To test:
    - apply the patch, find the syspref, see the new wording
    
    To confirm the behavior:
    - set the syspref to Block
    - give a patron an auto-renewing checkout and a restriction
    - run automatic_renewal.pl, see item does not renew
    - switch syspref to allow, repeat, see renewal
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:49:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:49:56 +0000
    Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to
     Koha::Object
    In-Reply-To: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18606-70-4BfriPl0yu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606
    
    Patrick Robitaille <patrick.robitaille at collecto.ca> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |patrick.robitaille at collecto
                       |                            |.ca
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:52:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:52:07 +0000
    Subject: [Koha-bugs] [Bug 19470] Add information about item being in
     rotating collection on detail page
    In-Reply-To: <bug-19470-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-19470-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-19470-70-3MtsgArD20@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19470
    
    Patrick Robitaille <patrick.robitaille at collecto.ca> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |patrick.robitaille at collecto
                       |                            |.ca
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:52:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:52:55 +0000
    Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths
    In-Reply-To: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-19318-70-4MJGzGZnzu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |nick at bywatersolutions.com
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:56:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:56:08 +0000
    Subject: [Koha-bugs] [Bug 30366] Warn when running
     automatic_item_modification_by_age.pl
    In-Reply-To: <bug-30366-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30366-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30366-70-T9iREd5NBe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30366
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133899|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133901
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133901&action=edit
    Bug 30366: Remove warn when running automatic_item_modification_by_age.pl
    
    When using the ./misc/cronjobs/automatic_item_modification_by_age.pl -v
    after setting up rules under Tools > Automatic item modifications by
    age the script outputs several lines of warnings:
    
    Use of uninitialized value in string eq at /kohadevbox/koha/C4/Items.pm
    line 1864.
    
    This is because even when there is no condition defined, modification
    rule is stored with empty hash, like :
    [{"substitutions":[{"field":"items.new_status","value":"0"}],"conditions":[{}],"age":"60","agefield":"items.dateaccessioned"}]
    
    Test plan :
    1) Go to Tools > Automatic item modifications by age
    2) Create a rule with no conditions, just a substitution
    3) Run misc/cronjobs/automatic_item_modification_by_age.pl -v
    4) Check there is no warning
    5) Edit the rule to add a condition
    6) Run misc/cronjobs/automatic_item_modification_by_age.pl -v
    7) Check the condition is applied
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:56:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:56:43 +0000
    Subject: [Koha-bugs] [Bug 30366] Warn when running
     automatic_item_modification_by_age.pl
    In-Reply-To: <bug-30366-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30366-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30366-70-aWNqEr4bl8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30366
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
                 Status|Signed Off                  |Passed QA
    
    --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Trivial and clear fix, works as expected, no regressions found and QA scripts
    happy.
    
    PQA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 15:57:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 13:57:08 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-oq5xYgoJzC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |ASSIGNED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:02:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:02:26 +0000
    Subject: [Koha-bugs] [Bug 30597] Update wording of RestrictionBlockRenewing
     to include auto-renew
    In-Reply-To: <bug-30597-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30597-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30597-70-YGm214TfMf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30597
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:02:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:02:31 +0000
    Subject: [Koha-bugs] [Bug 30597] Update wording of RestrictionBlockRenewing
     to include auto-renew
    In-Reply-To: <bug-30597-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30597-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30597-70-iZhryFOeNN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30597
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133900|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133902
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133902&action=edit
    Bug 30597: Update RestrictionBlockRenewing description to include auto renew
    
    To test:
    - apply the patch, find the syspref, see the new wording
    
    To confirm the behavior:
    - set the syspref to Block
    - give a patron an auto-renewing checkout and a restriction
    - run automatic_renewal.pl, see item does not renew
    - switch syspref to allow, repeat, see renewal
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:08:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:08:07 +0000
    Subject: [Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check
     CanReserveBeCanceledFromOpac
    In-Reply-To: <bug-22379-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22379-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22379-70-t5vsWqRyIu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #125230|0                           |1
            is obsolete|                            |
    
    --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133903
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133903&action=edit
    Bug 22379: Fix checks not made by ILS-DI method CancelHold
    
    Disable the possibility for a borrower to cancel a reservation
    which is either in a Transit or Waiting state.
    This reproduce the behaviour seen on the OPAC.
    Also replaces previous checks on the borrowernumber
    since CanReserveBeCanceledFromOpac already checks this.
    
    --------------------------------
    
    Test plan (before patch) :
    -Put a reserve for a borrower
    -Try to cancel the reserve providing another borrowernumber as argument
            -> Should fail and reply "RecordNotFound"
            -> Reserve still appears in the list of holds.
    
    -Try to cancel the reserve providing the borrowernumber the reserve is
    for.
            -> Should succeed, reply with "Canceled"
            -> Reserve do not show up in the list of holds for the borrower
    
    -Put a new reserve with a pickup branch != from the homebranch
    -Transfer the item to the pickup branch (reserve status = Transit)
    -Try to cancel the reserve (with proper borrowernumber)
            -> Should succeed, reply with "Canceled"
            -> Reserve do not show up in the list of holds for the borrower
    
    -Checkout the reserved item in the pickup branch (reserve status =
    Waiting)
    -Try to cancel the reserve (with proper borrowernumber)
            -> Should succeed, reply with "Canceled"
            -> Reserve do not show up in the list of holds for the borrower
    
    --------------------------------
    
    Test plan (after patch) :
    -Put a reserve for a borrower
    -Try to cancel the reserve providing another borrowernumber as argument
            -> Should fail and reply "BorrowerCannotCancelHold"
            -> Reserve still appears in the list of holds.
    
    -Try to cancel the reserve providing the borrowernumber the reserve is
    for.
            -> Should succeed, reply with "Canceled"
            -> Reserve do not show up in the list of holds for the borrower
    
    -Put a new reserve with a pickup branch != from the homebranch
    -Transfer the item to the pickup branch (reserve status = Transit)
    -Try to cancel the reserve (with proper borrowernumber)
            -> Should fail and reply "BorrowerCannotCancelHold"
            -> Reserve still appears in the list of holds.
    
    -Checkout the reserved item in the pickup branch (reserve status =
    Waiting)
    -Try to cancel the reserve (with proper borrowernumber)
            -> Should fail and reply "BorrowerCannotCancelHold"
            -> Reserve still appears in the list of holds.
    
    Signed-off-by: Laurence Rault <laurence.rault at biblibre.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:08:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:08:11 +0000
    Subject: [Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check
     CanReserveBeCanceledFromOpac
    In-Reply-To: <bug-22379-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22379-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22379-70-gWLeByT0Vr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #125232|0                           |1
            is obsolete|                            |
    
    --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133904
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133904&action=edit
    Bug 22379: Unit tests for CancelHold service
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:08:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:08:49 +0000
    Subject: [Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check
     CanReserveBeCanceledFromOpac
    In-Reply-To: <bug-22379-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22379-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22379-70-plWer90FfS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
                 Status|Signed Off                  |Passed QA
    
    --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Nice one Arthur, great to see these getting some love
    
    All working, Unit tests reads well and passes.. QA script happy
    
    PQA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:10:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:10:23 +0000
    Subject: [Koha-bugs] [Bug 30491] Convert saved reports tabs to Bootstrap
    In-Reply-To: <bug-30491-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30491-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30491-70-qpTG4TprC8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30491
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:10:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:10:27 +0000
    Subject: [Koha-bugs] [Bug 30491] Convert saved reports tabs to Bootstrap
    In-Reply-To: <bug-30491-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30491-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30491-70-toBh8yNvU8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30491
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133895|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
    Created attachment 133905
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133905&action=edit
    Bug 30491: Convert saved reports tabs to Bootstrap
    
    This patch updates the saved reports page so that it uses Bootstrap tabs
    instead of jQueryUI.
    
    To test, apply the patch and go to Reports -> Use saved.
    
     - On the Saved Reports page you should see multiple tabs.
     - Each should look correct and work correctly.
     - Clicking each tab should result in the table of reports filtering
       correctly for that tab (Patrons tab showing only patrons reports).
     - If necessary, edit one or more reports so that they have a subgroup.
     - Confirm that each subgroup selector is correct for each tab, i.e. a
       subgroup created under "Catalog" should only be available under the
       Catalog tab.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:11:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:11:56 +0000
    Subject: [Koha-bugs] [Bug 24865] Customize the accountlines description
    In-Reply-To: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24865-70-7PbQASV8LJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Customize the Accountlines  |Customize the accountlines
                       |Description                 |description
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:13:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:13:59 +0000
    Subject: [Koha-bugs] [Bug 22490] Some strings in JavaScript files are
     untranslatable
    In-Reply-To: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22490-70-S8783ts3Vk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22490
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133813|0                           |1
            is obsolete|                            |
    
    --- Comment #8 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> ---
    Created attachment 133906
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133906&action=edit
    Bug 22490: Some strings in JavaScript files are untranslatable
    
    This patch updates the translation functions of the strings in Javascript files
    
    Test Plan:
    1) Find a string in a popup or from a Javascript file who is still not
    translated
    or
    1) Home > Administration > Authority types
    2) Make sure to have at least one Authority type saved
    3) Click on Action > Import
    4) Import button without adding any file to trigger the popup
    5) The string inside the popup appears without translation
    6) Apply patch and repeat from 3) to 5) : now the string is translated
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:15:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:15:58 +0000
    Subject: [Koha-bugs] [Bug 30491] Convert saved reports tabs to Bootstrap
    In-Reply-To: <bug-30491-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30491-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30491-70-WTYvbn0QmT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30491
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133905|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133907
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133907&action=edit
    Bug 30491: Convert saved reports tabs to Bootstrap
    
    This patch updates the saved reports page so that it uses Bootstrap tabs
    instead of jQueryUI.
    
    To test, apply the patch and go to Reports -> Use saved.
    
     - On the Saved Reports page you should see multiple tabs.
     - Each should look correct and work correctly.
     - Clicking each tab should result in the table of reports filtering
       correctly for that tab (Patrons tab showing only patrons reports).
     - If necessary, edit one or more reports so that they have a subgroup.
     - Confirm that each subgroup selector is correct for each tab, i.e. a
       subgroup created under "Catalog" should only be available under the
       Catalog tab.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:16:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:16:22 +0000
    Subject: [Koha-bugs] [Bug 30491] Convert saved reports tabs to Bootstrap
    In-Reply-To: <bug-30491-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30491-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30491-70-VzfDDQ7a8u@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30491
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Nice work again, all works well in testing.
    
    Passing QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:18:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:18:26 +0000
    Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
    In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23838-70-jV1qANVere@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Failed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:23:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:23:56 +0000
    Subject: [Koha-bugs] [Bug 10734] Add Publication Date Facet in Searching
    In-Reply-To: <bug-10734-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-10734-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-10734-70-T6BpMmT4mu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10734
    
    --- Comment #11 from Barbara Johnson <barbara.johnson at bedfordtx.gov> ---
    Being able to limit search results by publication date would help our patrons
    as well as staff who are assisting them.  This is really needed.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:27:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:27:43 +0000
    Subject: [Koha-bugs] [Bug 10734] Add Publication Date Facet in Searching
    In-Reply-To: <bug-10734-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-10734-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-10734-70-Y4QXYh9blQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10734
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |michaela.sieber at kit.edu
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:33:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:33:42 +0000
    Subject: [Koha-bugs] [Bug 30621] New: Author should be its own column on
     opac-readingrecord.tt
    Message-ID: <bug-30621-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30621
    
                Bug ID: 30621
               Summary: Author should be its own column on
                        opac-readingrecord.tt
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: OPAC
              Assignee: oleonard at myacpl.org
              Reporter: lucas at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
    
    It would be handy if users could go to the reading history page and be able to
    sort their reading history by author. If author was in its own column, instead
    of in the 'Title' column, it would be easy to sort by author.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:41:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:41:53 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-KAWE0HLxc4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131897|0                           |1
            is obsolete|                            |
    
    --- Comment #54 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133908
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133908&action=edit
    Bug 30275: Add checkout_renewals table
    
    This patch adds the new checkout_renewals table using an atomicupdate
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:41:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:41:58 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-GfTW3jXcvT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131898|0                           |1
            is obsolete|                            |
    
    --- Comment #55 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133909
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133909&action=edit
    Bug 30275: Generated kohastructure.sql
    
    This kohastructure update was generated using `koha-dump --schema-only`
    in koha-testing-docker once the atomicupdate had been run against the
    previous atomicupdate patch.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:42:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:42:03 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-8PoXnPWU4n@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131899|0                           |1
            is obsolete|                            |
    
    --- Comment #56 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133910
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133910&action=edit
    Bug 30275: DBIC Schema Changes
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:42:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:42:08 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-sc6FOWfRR3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131900|0                           |1
            is obsolete|                            |
    
    --- Comment #57 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133911
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133911&action=edit
    Bug 30275: Record renewals
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:42:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:42:12 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-Zi4WtYNqTc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131901|0                           |1
            is obsolete|                            |
    
    --- Comment #58 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133912
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133912&action=edit
    Bug 30275: DBIC Schema Additions
    
    Add checkout and old_checkout relations to CheckoutRenewal schema and
    mark 'seen' as a boolean.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:42:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:42:16 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-DXpLpZ5Gkl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131902|0                           |1
            is obsolete|                            |
    
    --- Comment #59 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133913
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133913&action=edit
    Bug 30275: Add Koha::Objects for Renewals
    
    Add Koha::Checkouts::Renewals|Renewal classes
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:42:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:42:21 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-UnTeub9QjM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131903|0                           |1
            is obsolete|                            |
    
    --- Comment #60 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133914
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133914&action=edit
    Bug 30275: Rename issues.renewals to issues.renewals_count
    
    Rename the issues.renewals field to renewals_count to prevent a method
    name collision with the new relation accessor introduced by this
    patchset.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:42:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:42:26 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-fDuGFWW9hK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131904|0                           |1
            is obsolete|                            |
    
    --- Comment #61 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133915
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133915&action=edit
    Bug 30275: renewals_count DBIC Update
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:42:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:42:30 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-Zklt1VKdAK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131905|0                           |1
            is obsolete|                            |
    
    --- Comment #62 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133916
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133916&action=edit
    Bug 30275: Add 'renewals' relation to Issue Schema
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:42:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:42:34 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-0KNkgyawCh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131906|0                           |1
            is obsolete|                            |
    
    --- Comment #63 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133917
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133917&action=edit
    Bug 30275: Add renewals relation to Koha::Checkout
    
    Add the new 'renewals' relation to Koha::Checkout to return a list of
    Koha::Checkouts::Renewal objects.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:42:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:42:39 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-6UCotLBL2b@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131907|0                           |1
            is obsolete|                            |
    
    --- Comment #64 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133918
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133918&action=edit
    Bug 30275: Add `/api/v1/checkouts/{checkout_id}/renewals`
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:42:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:42:43 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-V7clgGbdRa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131908|0                           |1
            is obsolete|                            |
    
    --- Comment #65 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133919
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133919&action=edit
    Bug 30275: Add alias to create renewal in api routes
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:42:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:42:48 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-pDUbrn9SUv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131909|0                           |1
            is obsolete|                            |
    
    --- Comment #66 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133920
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133920&action=edit
    Bug 30275: Fix checkouts.t unit test
    
    We no longer require a mocked userenv for these tests to pass, we're
    setting the userenv in api auth now. The mock just serves to break tests
    for the renew method now that AddRenewal required a correctly set
    userenv for 'number'.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:42:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:42:53 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-rgWNlq1kJo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131910|0                           |1
            is obsolete|                            |
    
    --- Comment #67 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133921
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133921&action=edit
    Bug 30275: Add basic unit test for fetching renewals
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:42:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:42:58 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-u8E2IpE25R@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #68 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133922
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133922&action=edit
    Bug 30275: (follow-up) Rebase fixes
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:48:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:48:00 +0000
    Subject: [Koha-bugs] [Bug 30622] New: Search for cardnumber needs to go
     directly to patron record
    Message-ID: <bug-30622-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622
    
                Bug ID: 30622
               Summary: Search for cardnumber needs to go directly to patron
                        record
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Keywords: regression
              Severity: major
              Priority: P5 - low
             Component: Patrons
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: katrin.fischer at bsz-bw.de
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
    
    When searching for a cardnumber that matches exactly an existing cardnumber,
    the corresponding patron needs to 'found' directly, without displaying a result
    list.
    
    To test:
    - Place a hold on anything in staff
    - Search for 42 or any other existing cardnumber in your database
    - Verify the result list is shown instead of selecting the patron
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:49:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:49:33 +0000
    Subject: [Koha-bugs] [Bug 30622] Search for cardnumber needs to go directly
     to patron record when placing a hold
    In-Reply-To: <bug-30622-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30622-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30622-70-FDDZnyHJuM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30063
                Summary|Search for cardnumber needs |Search for cardnumber needs
                       |to go directly to patron    |to go directly to patron
                       |record                      |record when placing a hold
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
    [Bug 30063] Make the main patron search use the /patrons REST API route
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:49:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:49:33 +0000
    Subject: [Koha-bugs] [Bug 30063] Make the main patron search use the
     /patrons REST API route
    In-Reply-To: <bug-30063-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30063-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30063-70-jKiKEPz52D@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30622
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622
    [Bug 30622] Search for cardnumber needs to go directly to patron record when
    placing a hold
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:55:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:55:31 +0000
    Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired
     waiting holds to fill the next hold
    In-Reply-To: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14364-70-lG3TlGSgbG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:55:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:55:38 +0000
    Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired
     waiting holds to fill the next hold
    In-Reply-To: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14364-70-gMGCRnc45Q@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132019|0                           |1
            is obsolete|                            |
    
    --- Comment #60 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133923
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133923&action=edit
    Bug 14364: Allow automatically canceled expired waiting holds to fill the next
    hold
    
    Right now, if a library automatically cancels expired waiting holds, a
    librarian must still re-checkin an item to trap the next available hold
    for that item. It would be better if the next hold was automatically
    trapped and the librarians receive an email notification so they can
    make any changes to the item if need be ( hold area, hold slip in item,
    etc ).
    
    Test Plan:
     1) Apply this patch
     2) Run updatedatabase.pl
     3) Create a record with one item
     4) Place two holds on that record
     5) Check in the item and set it to waiting for the first patron
     6) Set ReservesMaxPickUpDelay to 1
     7) Enable ExpireReservesMaxPickUpDelay
     8) Enable ExpireReservesAutoFill
     9) Set an email address in ExpireReservesAutoFillEmail
    10) Modify the holds waitingdate to be in the past
    11) Run misc/cronjobs/holds/cancel_expired_holds.pl
    12) Note the hold is now waiting for the next patron
    12) Note a waiting hold notification email was sent to that patron
    13) Note a hold changed notification email was sent to the library
    
    Signed-off-by: Victoria Faafia <vfaafia29 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:55:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:55:45 +0000
    Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired
     waiting holds to fill the next hold
    In-Reply-To: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14364-70-UpAbavJqn6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132020|0                           |1
            is obsolete|                            |
    
    --- Comment #61 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133924
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133924&action=edit
    Bug 14364: (QA follow-up) Generate message for transfers as well
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:55:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:55:52 +0000
    Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired
     waiting holds to fill the next hold
    In-Reply-To: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14364-70-UpyUe6hVo0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132021|0                           |1
            is obsolete|                            |
    
    --- Comment #62 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133925
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133925&action=edit
    Bug 14364: (follow-up) Cleanup duplicate code and adjust notices and prefs
    
    This patch removes a duplicated stanza left form moving routine
    Changes the routines to use inbound_library_address
    Improves the display if the system preferences
    Updates the update file
    Moves smaple notice
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:55:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:55:59 +0000
    Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired
     waiting holds to fill the next hold
    In-Reply-To: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14364-70-DmhXbrKf16@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133812|0                           |1
            is obsolete|                            |
    
    --- Comment #63 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133926
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133926&action=edit
    Bug 14364: Fix spelling and tests
    
    Moved the installer to pl file
    Adjusted capitalization / reply-to
    Fix tests by importing needed fuction and adjusting a wrong call
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:56:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:56:06 +0000
    Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired
     waiting holds to fill the next hold
    In-Reply-To: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14364-70-jy3qGA4S9K@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364
    
    --- Comment #64 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133927
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133927&action=edit
    Bug 14364: (QA follow-up) Fix capitalization
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:56:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:56:14 +0000
    Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired
     waiting holds to fill the next hold
    In-Reply-To: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14364-70-RdFkLXGMtP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364
    
    --- Comment #65 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 133928
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133928&action=edit
    Bug 14364: (QA follow-up) Add email validation to ExpireReservesAutoFillEmail
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:59:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:59:31 +0000
    Subject: [Koha-bugs] [Bug 27123] Add messages to batch patrons modification
    In-Reply-To: <bug-27123-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27123-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27123-70-KUQTxXRVtz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123
    
    --- Comment #10 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> ---
    Thanks Katrin for this, I fix it asap :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 16:59:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 14:59:49 +0000
    Subject: [Koha-bugs] [Bug 30199] self checkout login by cardnumber is broken
     if you input a non-existent cardnumber
    In-Reply-To: <bug-30199-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30199-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30199-70-aC92gsj3Rz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30199
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |Pushed to stable
             Version(s)|22.05.00                    |22.05.00,21.11.05
            released in|                            |
    
    --- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.05
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:03:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:03:15 +0000
    Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
     effective_name method to patrons
    In-Reply-To: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28633-70-Nli0HIDSLH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Patch doesn't apply
    
    --- Comment #41 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Can you please rebase?
    
    Careful with the first conflict - h3 changed to h1 in master and the section
    was moved a little downwards.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:05:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:05:17 +0000
    Subject: [Koha-bugs] [Bug 30535] Add "Tool plugins" to the main tools screen
    In-Reply-To: <bug-30535-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30535-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30535-70-vUivtG6iUV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30535
    
    Fred King <fred.king at medstar.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|INVALID                     |---
                 Status|RESOLVED                    |REOPENED
    
    --- Comment #3 from Fred King <fred.king at medstar.net> ---
    Agreed, but my original point which I should have explained in greater detail
    was that on the Tools home page Koha displays the following options: Calendar,
    CSV profiles, Log viewer, News, Task scheduler, Edit quotes for QOTD feature,
    Upload, Access files. There's no plugin link.
    
    If you don't have any plugins installed, the only way you can get to the plugin
    link is if you happen to click on any of the other tools. On the left column,
    even if you don't have any plugins installed, you get Calendar, CSV profiles,
    Log viewer, News, Task scheduler, Quote editor, Tool plugins, Upload any file,
    Access files.
    
    If plugins are enabled in the koha-conf.xml file, the Reports page has a link
    to Reports plugins. For those of use who are still learning Koha functions as
    we need them, having a Tools plugin link on the Tools page where it's easy to
    find would reduce the frustration level rather a lot. :-)
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:09:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:09:52 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-kNiyJUDfN1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133908|0                           |1
            is obsolete|                            |
    
    --- Comment #69 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133929
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133929&action=edit
    Bug 30275: Add checkout_renewals table
    
    This patch adds the new checkout_renewals table using an atomicupdate
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:09:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:09:57 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-cFwmbOUgHo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133909|0                           |1
            is obsolete|                            |
    
    --- Comment #70 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133930
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133930&action=edit
    Bug 30275: Generated kohastructure.sql
    
    This kohastructure update was generated using `koha-dump --schema-only`
    in koha-testing-docker once the atomicupdate had been run against the
    previous atomicupdate patch.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:10:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:10:02 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-WoIKgU9zt1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133910|0                           |1
            is obsolete|                            |
    
    --- Comment #71 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133931
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133931&action=edit
    Bug 30275: DBIC Schema Changes
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:10:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:10:08 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-rWz3RjGPlg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133911|0                           |1
            is obsolete|                            |
    
    --- Comment #72 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133932
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133932&action=edit
    Bug 30275: Record renewals
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:10:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:10:12 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-rmmn5sOT7R@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133912|0                           |1
            is obsolete|                            |
    
    --- Comment #73 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133933
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133933&action=edit
    Bug 30275: DBIC Schema Additions
    
    Add checkout and old_checkout relations to CheckoutRenewal schema and
    mark 'seen' as a boolean.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:10:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:10:17 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-F6zP3IBeXF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133913|0                           |1
            is obsolete|                            |
    
    --- Comment #74 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133934
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133934&action=edit
    Bug 30275: Add Koha::Objects for Renewals
    
    Add Koha::Checkouts::Renewals|Renewal classes
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:10:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:10:22 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-kbNYAuGHYx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133914|0                           |1
            is obsolete|                            |
    
    --- Comment #75 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133935
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133935&action=edit
    Bug 30275: Rename issues.renewals to issues.renewals_count
    
    Rename the issues.renewals field to renewals_count to prevent a method
    name collision with the new relation accessor introduced by this
    patchset.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:10:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:10:27 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-dDoWAHFhIe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133915|0                           |1
            is obsolete|                            |
    
    --- Comment #76 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133936
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133936&action=edit
    Bug 30275: renewals_count DBIC Update
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:10:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:10:32 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-lIXbmPcoZp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133916|0                           |1
            is obsolete|                            |
    
    --- Comment #77 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133937
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133937&action=edit
    Bug 30275: Add 'renewals' relation to Issue Schema
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:10:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:10:37 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-MV2JK2zITk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133917|0                           |1
            is obsolete|                            |
    
    --- Comment #78 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133938
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133938&action=edit
    Bug 30275: Add renewals relation to Koha::Checkout
    
    Add the new 'renewals' relation to Koha::Checkout to return a list of
    Koha::Checkouts::Renewal objects.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:10:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:10:42 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-hgSvbS7nDU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133918|0                           |1
            is obsolete|                            |
    
    --- Comment #79 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133939
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133939&action=edit
    Bug 30275: Add `/api/v1/checkouts/{checkout_id}/renewals`
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:10:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:10:47 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-m8AftYxHm9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133919|0                           |1
            is obsolete|                            |
    
    --- Comment #80 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133940
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133940&action=edit
    Bug 30275: Add alias to create renewal in api routes
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:10:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:10:51 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-t3HZoc3iBk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133920|0                           |1
            is obsolete|                            |
    
    --- Comment #81 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133941
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133941&action=edit
    Bug 30275: Fix checkouts.t unit test
    
    We no longer require a mocked userenv for these tests to pass, we're
    setting the userenv in api auth now. The mock just serves to break tests
    for the renew method now that AddRenewal required a correctly set
    userenv for 'number'.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:10:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:10:56 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-eYKoBklrzr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133921|0                           |1
            is obsolete|                            |
    
    --- Comment #82 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133942
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133942&action=edit
    Bug 30275: Add basic unit test for fetching renewals
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:11:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:11:02 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-dRqFLkgMNa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133922|0                           |1
            is obsolete|                            |
    
    --- Comment #83 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133943
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133943&action=edit
    Bug 30275: (follow-up) Rebase fixes
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:11:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:11:07 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-lCgPR6TWEr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #84 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133944
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133944&action=edit
    Bug 30275: Add renewals relation to Koha::Old::Checkout
    
    Add the new 'renewals' relation to Koha::Old::Checkout to return a
    list of Koha::Checkouts::Renewal objects.
    
    We also add the same relation to the OldIssue schema inline.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:11:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:11:35 +0000
    Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
    In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23838-70-VZduSjJNEH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131914|0                           |1
            is obsolete|                            |
    
    --- Comment #58 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133945
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133945&action=edit
    Bug 23838: Add renewals modal
    
    This patch adds the display of the renewals modal when appropriate. A
    "View" link is displayed next to renewals count where appropriate.
    Clicking the link opens the modal that displays the logged renewals.
    
    Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
    Signed-off-by: Ben Veasey <B.T.Veasey at lboro.ac.uk>
    
    Rescued-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    I rescued this patchset by squashing previous work and updating it to
    utilise the new renewals API routes introduced in bug 30275.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:11:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:11:40 +0000
    Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
    In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23838-70-0l4ilxp7PY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131915|0                           |1
            is obsolete|                            |
    
    --- Comment #59 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 133946
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133946&action=edit
    Bug 23838: Use $datetime formater
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:12:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:12:41 +0000
    Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
    In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23838-70-V7CcVtJPFe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:19:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:19:58 +0000
    Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
    In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23838-70-XKUzPkY1Xg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
    
    --- Comment #60 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    (In reply to Andrew Fuerste-Henry from comment #56)
    > I applied this and 30275 and tried to run through the test plan here. I'm
    > not getting a View button next to the renewal count in patron Circulation
    > History even when the Renewal Log is enabled and there are renewals in the
    > action_logs for the checkout. Is there something else I should be doing to
    > get it to show?
    
    OK, We're back to ready for testing here.
    
    Right, the test plan comment way above is now rather out of date.. we moved the
    code from action logs into it's own table and a more traditional API route..
    soo.
    
    1) Apply bug 30275 and run the database update
    2) Renewal some on loan items
    3) Check that the Circulation history displays `X [View]` in the 'Number of
    renewals' column where 'X' is the number of renewals that have taken place and
    `[View]` is a link that pops up a modal.
    4) For renewals that have taken place prior to the patch being applied, you
    should see the correct number but the 'View' modal will give a message 'Note: 0
    out of X renewals have been logged'
    5) For renewals that have taken place since applying this patch you should see
    details in the modal that pops up on clicking 'View'
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:35:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:35:52 +0000
    Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through stage
     MARC record import
    In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22785-70-ffeNrlWJ4e@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Patch doesn't apply         |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:35:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:35:57 +0000
    Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through stage
     MARC record import
    In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22785-70-50IGzQ6i17@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131143|0                           |1
            is obsolete|                            |
     Attachment #131144|0                           |1
            is obsolete|                            |
     Attachment #131145|0                           |1
            is obsolete|                            |
     Attachment #131146|0                           |1
            is obsolete|                            |
     Attachment #131147|0                           |1
            is obsolete|                            |
    
    --- Comment #70 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133947
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133947&action=edit
    Bug 22785: Allow option to choose which record match is applied during import
    
    This patchset adds the display of all matches found during import to the import
    management screen
    
    A staff member with the permission to manage batches will be able to select for
    any individual record which match, or none, should be used during import
    
    To test:
    1 - Import a batch of records or export existing records from your catalog
    2 - Import the file (again) and select a matching rule that will find matches
    3 - Note that you now have radio buttons allowing you to select a record, or
    none
    4 - Test scenarios:
        I - When 'Action if matching record found' is 'Ignore'
            a - Imported record ignored if match is selected
            b - 'Action if no match found' followed if no match is selected (Ignore
    matches)
        II - When 'Action if matching record found' is 'Replace'
            a - The chosen record is the one overlayed (you can edit the chosen
    record before importing to confirm)
            b - 'Action if no match found' followed if no match is selected (Ignore
    matches)
        III - When 'Action if matching record found' is 'Add incoming record'
            a - Record is added regardless of matches
    5 - Confirm 'Diff' 'View' links work as expected
    6 - Confirm that after records are imported the radio buttons to choose are
    disabled
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    Bug 22785: API files
    
    Signed-off-by: Ben Daeuber <bdaeuber at cityoffargo.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:36:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:36:03 +0000
    Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through stage
     MARC record import
    In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22785-70-x0vgrLnPXs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    
    --- Comment #71 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133948
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133948&action=edit
    Bug 22785: DO NOT PUSH Schema Updates
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:36:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:36:08 +0000
    Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through stage
     MARC record import
    In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22785-70-hc2UL9bYDl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    
    --- Comment #72 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133949
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133949&action=edit
    Bug 22785: Update Schema for boolean
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Ben Daeuber <bdaeuber at cityoffargo.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:36:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:36:14 +0000
    Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through stage
     MARC record import
    In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22785-70-WjZF9lEf0N@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    
    --- Comment #73 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133950
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133950&action=edit
    Bug 22785: (follow-up) Don't sort by chosen and fix selection of matches
    
    Previously the sorting took 'chosen' into account and would move a selected
    match to the
    top on next load - it is better to preserve the same sorting every time
    
    When loading matches the 'cehcked' variable was not being cleared, so multiple
    matches were
    being marked 'checked="checked"'. Fixing this ensures the correct record
    displays as chosen
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Ben Daeuber <bdaeuber at cityoffargo.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:36:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:36:20 +0000
    Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through stage
     MARC record import
    In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22785-70-EzDmNjEbPU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    
    --- Comment #74 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133951
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133951&action=edit
    Bug 22785: (follow-up) Fix translatability
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 17:51:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 15:51:26 +0000
    Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
     contents into notices tool
    In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-3150-70-TyUbcBd3vi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150
    
    --- Comment #82 from Owen Leonard <oleonard at myacpl.org> ---
    I got errors from each of these scripts:
    
    basket/sendbasket.pl
    opac/opac-sendbasket.pl
    opac/opac-sendshelf.pl
    virtualshelves/sendshelf.pl
    
    The default CART and LIST notices contain HTML but the "HTML message" checkbox
    is not checked when I edit the notice.
    
    When viewing the list of notices, I see this:
    
    +─────────+───────+────────────+
    | module  | Code  | Name       |
    +─────────+───────+────────────+
    | catalog | CART  | Send cart  |
    | catalog | LIST  | Send list  |
    +─────────+───────+────────────+
    
    But when I edit either of those notices "Acquisitions" is selected as the
    module. This isn't the case with other notices.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 18:21:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 16:21:31 +0000
    Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
    In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-12446-70-0V3gbO3v4w@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Medium patch
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 18:21:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 16:21:42 +0000
    Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
    In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-12446-70-hId1RRUBHq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131965|0                           |1
            is obsolete|                            |
     Attachment #131966|0                           |1
            is obsolete|                            |
     Attachment #131967|0                           |1
            is obsolete|                            |
     Attachment #131968|0                           |1
            is obsolete|                            |
     Attachment #131969|0                           |1
            is obsolete|                            |
     Attachment #133691|0                           |1
            is obsolete|                            |
    
    --- Comment #182 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133952
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133952&action=edit
    Bug 12446: Ability to allow guarantor relationship for all patron category
    types
    
    This adds a new field "Can be guarantee" to patron categories so it
    becomes possible for any category type to have a guarantor.
    
    To test:
    1) Have a patron category of type 'Adult' and one of type 'Child'
    2) Confirm, by searching for the "Patron guarantor" fieldset in the
    edit/create form, that:
        => a patron of the first category can't have a guarantor
        => a patron from the second category can
    3) Apply patch and run updatedatabase.pl
    4) Edit the categories and note the new "Can be guarantee" field
    5) It should have been set to "yes" for the "Child" and to "no" for
    the "Adult"
    5) Repeat step 2. It should behave in the same way.
    6) Edit the "Can be guarantee" for any of the category and check
    that the fieldset only appears when "Can be guarantee" is set to "yes"
    7) prove t/db_dependent/Patrons.t
        => tests should still pass
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 18:21:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 16:21:53 +0000
    Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
    In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-12446-70-HSZsoKKQlV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
    
    --- Comment #183 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133953
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133953&action=edit
    Bug 12446: Schema update Category.pm
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 18:22:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 16:22:04 +0000
    Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
    In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-12446-70-1MzpZjf5vb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
    
    --- Comment #184 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133954
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133954&action=edit
    Bug 12446: Limit available categories when using "Add guarantee" button
    
    Test plan:
    1) Have some patron categories that can and cannot be guarantee
    2) Visit a patron's account and click the "Add guarantee" button
    3) In the "category" dropdown, note that all categories are available
    4) Apply this patch
    5) Repeat step 2 and 3; the dropdown now only contains the categories
    for which "can be guarantee" is set to "Yes".
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 18:22:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 16:22:13 +0000
    Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
    In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-12446-70-KHGxE9Z0gp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
    
    --- Comment #185 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133955
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133955&action=edit
    Bug 12446: Add canbeguarantee value to patron categories sample data
    
    This patch changes sample data so patron categories of type 'C' or
    'P' can be guarantees by default.
    
    Signed-off-by: Salman Ali <salman.ali at inlibro.com>
    Signed-off-by: Salman Ali <salman.ali at inlibro.com>
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 18:22:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 16:22:23 +0000
    Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
    In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-12446-70-9WUuwOZWHR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
    
    --- Comment #186 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133956
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133956&action=edit
    Bug 12446: Any patron categories can have guarantors
    
    Rebase of previous patches
    This patch allows adult patrons to have guarantors. It adds the field
    "Can be guarantee" to patron categories, so it becomes possible for any
    category type to have a guarantor.
    NOTE: Attachment "Bug 12446: Adult can now have guarantors" created a sha1
    error. I marked it as obsolete and put
    it's content into a new commit.
    
    To test:
    1) Create an Adult AND Child category in Administration/Patron
    categories
    2) Create a child AND adult patron.
    3) Go in your child patron's page.
    4) Click on "Edit".
    5) Notice that you can add a guarantor with "Add guarantor" button.
    6) Go in your adult patron's page.
    7) Click on "Edit".
    8) Notice that there is no "Add guarantor" button. Therefore, you can't
    add a guarantor for this patron.
    9) Apply patch and run updatedatabase.pl
    10) Go in Administration/Patron categories and edit one of them.
    12) Notice that you can see the new "Can be guarantee" field.
    13) Set "Yes" gor the "Can be guarantee" field for your Child AND Adult
    category.
    14) Repeat steps 6 to 7.
    15) Notice that your adult patron can now add guarantors with the "Add
    guarantor" button.
    16) prove t/db_dependent/Patrons.t
        => All tests should still pass
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 18:22:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 16:22:33 +0000
    Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
    In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-12446-70-BECwWLF8eL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
    
    --- Comment #187 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133957
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133957&action=edit
    Bug 12446: Fixing QA tool's tests
    
    This patch fixes tests that fails by the QA test tool.
    I removed the debug variable, since it is not used.
    I also got a few spelling check errors when I ran the QA test tool. I corrected
    them too.
    
    To test:
    1) Create an Adult AND Child category in Administration/Patron
    categories
    2) Create a child AND adult patron.
    3) Go in your child patron's page.
    4) Click on "Edit".
    5) Notice that you can add a guarantor with "Add guarantor" button.
    6) Go in your adult patron's page.
    7) Click on "Edit".
    8) Notice that there is no "Add guarantor" button. Therefore, you can't
    add a guarantor for this patron.
    9) Apply patch and run updatedatabase.pl
    10) Go in Administration/Patron categories and edit one of them.
    12) Notice that you can see the new "Can be guarantee" field.
    13) Set "Yes" on the "Can be guarantee" field for your Child AND Adult
    category.
    14) Repeat steps 6 to 7.
    15) Notice that your adult patron can now add guarantors with the "Add
    guarantor" button.
    16) prove t/db_dependent/Patrons.t
        => All tests should still pass
    17) Run the QA test tool. All tests should say OK
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 18:23:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 16:23:21 +0000
    Subject: [Koha-bugs] [Bug 30612] Add accountlines method to Koha::Checkout
     and Koha::Old::Checkout
    In-Reply-To: <bug-30612-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30612-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30612-70-oMsmQDkKVm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30612
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |cbrannon at cdalibrary.org
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 18:33:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 16:33:32 +0000
    Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
     effective_name method to patrons
    In-Reply-To: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28633-70-AZE6cIBVkD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Patch doesn't apply         |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 18:33:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 16:33:36 +0000
    Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
     effective_name method to patrons
    In-Reply-To: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28633-70-0J8Eh6fyou@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133445|0                           |1
            is obsolete|                            |
    
    --- Comment #42 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133958
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133958&action=edit
    Bug 28633: DB update
    
    This adds the field to necessary tables and updates API and columns def
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 18:33:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 16:33:41 +0000
    Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
     effective_name method to patrons
    In-Reply-To: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28633-70-4L0apoXeJp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133446|0                           |1
            is obsolete|                            |
    
    --- Comment #43 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133959
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133959&action=edit
    Bug 28633: Add preferred name field to patrons
    
    This patch adds a new field 'preferred_name' to the patron record.
    
    Additionally it adds a method 'effective_name' to choose the preferred name if
    present
    and fall back to firstname
    
    The 'firstname' is displayed as 'First name' on the details page, with id/class
    patron_first_name to allow ajusting via JS/CSS if library wants to
    highlight/hide
    the non-preferred name
    
    PatronAutoComplete/ysearch is updated to use 'effective_name' method
    
    To test:
     1 - Apply patches
     2 - Update database and restart all, clear browser cache
     3 - Load a patron in staff module
     4 - Confirm you see and can add a preferred name
     5 - Confirm the preferred name and first name now displays on patron details
     6 - Remove first name from patron record and confirm it no longer shows
     7 - Edit sysprefs BorrowerMandatoryFields and BorrowerUnwantedFields to
    confirm you can make
         new field required or hidden
     8 - Sign in as patron to opac
     9 - Confirm preferred name shows
    10 - Edit account on opac and confirm field is present
    11 - Verify DefaultPatronSearchFields contains 'preferredname' if your pref had
    firstname
    12 - Perform checkout and patron search using preferred_name, confirm patron is
    found
    13 - Enable PatronAutoComplete system preference
    14 - Type patron's surname into Checkout or patron search but don't hit enter
    15 - Confirm patron is displayed with 'preferred_name' in the preview
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 18:33:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 16:33:45 +0000
    Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
     effective_name method to patrons
    In-Reply-To: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28633-70-vnI1cSLtgr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133447|0                           |1
            is obsolete|                            |
    
    --- Comment #44 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133960
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133960&action=edit
    Bug 28633: (follow-up) Account for bug 29695 changes
    
    During rebase of this patchset we drop the columns.def and
    borrowers.json changes introduced.
    
    We store this mapping in the module now, so this patch does
    that.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 18:33:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 16:33:50 +0000
    Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
     effective_name method to patrons
    In-Reply-To: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28633-70-5GCsrA8N3L@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133448|0                           |1
            is obsolete|                            |
    
    --- Comment #45 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133961
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133961&action=edit
    Bug 28633: (follow-up) Account for changes with bug 30063
    
    Bug 30063 removes the C4/Utils/DataTables/Members.pm module and instead
    uses the API and a patron-search include to define the default search
    fields. This follow-up adds preferred_name into the default fields in
    that include now the the module has been removed
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 18:33:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 16:33:55 +0000
    Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
     effective_name method to patrons
    In-Reply-To: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28633-70-BjP10ak0B5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133450|0                           |1
            is obsolete|                            |
    
    --- Comment #46 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133962
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133962&action=edit
    Bug 28633: (QA follow-up) Add preferred_name to ysearch
    
    This adds preferred_name to the search fields in the autocomplete search
    system.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 18:34:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 16:34:00 +0000
    Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
     effective_name method to patrons
    In-Reply-To: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28633-70-8l8suDeAOh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133451|0                           |1
            is obsolete|                            |
    
    --- Comment #47 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133963
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133963&action=edit
    Bug 28633: (follow-up) Display effective name in JS search
    
    Also I fix the other header  search, and ensure the 'Standard' option wil
    appear in dropdowns
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 18:34:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 16:34:04 +0000
    Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
     effective_name method to patrons
    In-Reply-To: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28633-70-HReUa446pC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133449|0                           |1
            is obsolete|                            |
    
    --- Comment #48 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133964
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133964&action=edit
    Bug 28633: DO NOT PUSH Schema Changes
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 18:34:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 16:34:12 +0000
    Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
     effective_name method to patrons
    In-Reply-To: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28633-70-23LjolauI7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633
    
    --- Comment #49 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 133965
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133965&action=edit
    Bug 28633: Fix ysearch sorting
    
    This adds an IF conditional to the sorting to sort by preferred name or
    firstname
    
    I add the colmns to data for main patron searhc, but I cannot solve sorting
    there
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 18:45:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 16:45:06 +0000
    Subject: [Koha-bugs] [Bug 30049] Add ability to download list as a
     spreadsheet.
    In-Reply-To: <bug-30049-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30049-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30049-70-D1OtfqKrf9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30049
    
    --- Comment #2 from Esther Melander <estherm at sodaspringsid.com> ---
    Katrin, my team looked at the option to create a CSV profile. From what we can
    tell this would allow us to create a CSV profile that will download a
    bibliographic record. Our intent is to download a list containing a title,
    author, and call number, in other words an item oriented list rather than a
    bibliographic list. I filed bug #30557 explaining the need for an item list. 
    In a multi-branch installation, individual libraries view and use lists as an
    item list even though they are not. 
    
    It would be nice to be able to either print or download an item list as a
    spreadsheet. For multi-branch installations it would be nice to limit the list
    to a specific library. It is possible to do this through a report but it would
    be nice if it is available in the list tool.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 18:59:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 16:59:19 +0000
    Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
    In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23838-70-diPFyt8yWZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 18:59:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 16:59:24 +0000
    Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
    In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23838-70-jUXiDxr28F@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133945|0                           |1
            is obsolete|                            |
     Attachment #133946|0                           |1
            is obsolete|                            |
    
    --- Comment #61 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133966
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133966&action=edit
    Bug 23838: Add renewals modal
    
    This patch adds the display of the renewals modal when appropriate. A
    "View" link is displayed next to renewals count where appropriate.
    Clicking the link opens the modal that displays the logged renewals.
    
    Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
    Signed-off-by: Ben Veasey <B.T.Veasey at lboro.ac.uk>
    
    Rescued-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    I rescued this patchset by squashing previous work and updating it to
    utilise the new renewals API routes introduced in bug 30275.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 18:59:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 16:59:30 +0000
    Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
    In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23838-70-3a6ZiC0Z2n@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
    
    --- Comment #62 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133967
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133967&action=edit
    Bug 23838: Use $datetime formater
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 18:59:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 16:59:35 +0000
    Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
    In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23838-70-GkPmnC5RKa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
    
    --- Comment #63 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133968
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133968&action=edit
    Bug 23838: (follow-up) Add missing template filter
    
    Quieting an issue highlighted by the QA tool.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 19:02:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 17:02:00 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-i9pKR6UY4N@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
       Patch complexity|---                         |Medium patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 19:02:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 17:02:05 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-FRVKC7ON7n@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133929|0                           |1
            is obsolete|                            |
     Attachment #133930|0                           |1
            is obsolete|                            |
     Attachment #133931|0                           |1
            is obsolete|                            |
     Attachment #133932|0                           |1
            is obsolete|                            |
     Attachment #133933|0                           |1
            is obsolete|                            |
     Attachment #133934|0                           |1
            is obsolete|                            |
     Attachment #133935|0                           |1
            is obsolete|                            |
     Attachment #133936|0                           |1
            is obsolete|                            |
     Attachment #133937|0                           |1
            is obsolete|                            |
     Attachment #133938|0                           |1
            is obsolete|                            |
     Attachment #133939|0                           |1
            is obsolete|                            |
     Attachment #133940|0                           |1
            is obsolete|                            |
     Attachment #133941|0                           |1
            is obsolete|                            |
     Attachment #133942|0                           |1
            is obsolete|                            |
     Attachment #133943|0                           |1
            is obsolete|                            |
     Attachment #133944|0                           |1
            is obsolete|                            |
    
    --- Comment #85 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133969
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133969&action=edit
    Bug 30275: Add checkout_renewals table
    
    This patch adds the new checkout_renewals table using an atomicupdate
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 19:02:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 17:02:10 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-zgYXgEFe9N@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #86 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133970
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133970&action=edit
    Bug 30275: Generated kohastructure.sql
    
    This kohastructure update was generated using `koha-dump --schema-only`
    in koha-testing-docker once the atomicupdate had been run against the
    previous atomicupdate patch.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 19:02:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 17:02:15 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-8bsRp25bZe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #87 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133971
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133971&action=edit
    Bug 30275: DBIC Schema Changes
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 19:02:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 17:02:20 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-ExJ8K8HLEx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #88 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133972
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133972&action=edit
    Bug 30275: Record renewals
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 19:02:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 17:02:25 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-A1GMjxbNJR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #89 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133973
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133973&action=edit
    Bug 30275: DBIC Schema Additions
    
    Add checkout and old_checkout relations to CheckoutRenewal schema and
    mark 'seen' as a boolean.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 19:02:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 17:02:30 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-Xun97sXhT4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #90 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133974
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133974&action=edit
    Bug 30275: Add Koha::Objects for Renewals
    
    Add Koha::Checkouts::Renewals|Renewal classes
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 19:02:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 17:02:35 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-D6K6iumrsD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #91 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133975
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133975&action=edit
    Bug 30275: Rename issues.renewals to issues.renewals_count
    
    Rename the issues.renewals field to renewals_count to prevent a method
    name collision with the new relation accessor introduced by this
    patchset.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 19:02:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 17:02:40 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-RmQcPKIxZB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #92 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133976
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133976&action=edit
    Bug 30275: renewals_count DBIC Update
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 19:02:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 17:02:45 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-svNSWF6gwS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #93 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133977
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133977&action=edit
    Bug 30275: Add 'renewals' relation to Issue Schema
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 19:02:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 17:02:50 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-IyYMYtAx96@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #94 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133978
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133978&action=edit
    Bug 30275: Add renewals relation to Koha::Checkout
    
    Add the new 'renewals' relation to Koha::Checkout to return a list of
    Koha::Checkouts::Renewal objects.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 19:02:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 17:02:55 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-IVKmi4dmci@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #95 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133979
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133979&action=edit
    Bug 30275: Add `/api/v1/checkouts/{checkout_id}/renewals`
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 19:03:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 17:03:00 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-MUIPWU2cgK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #96 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133980
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133980&action=edit
    Bug 30275: Add alias to create renewal in api routes
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 19:03:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 17:03:05 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-KJVVcuCyue@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #97 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133981
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133981&action=edit
    Bug 30275: Fix checkouts.t unit test
    
    We no longer require a mocked userenv for these tests to pass, we're
    setting the userenv in api auth now. The mock just serves to break tests
    for the renew method now that AddRenewal required a correctly set
    userenv for 'number'.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 19:03:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 17:03:10 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-CLxvvARkXn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #98 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133982
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133982&action=edit
    Bug 30275: Add basic unit test for fetching renewals
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 19:03:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 17:03:14 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-tyPsebZxOM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #99 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133983
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133983&action=edit
    Bug 30275: (follow-up) Rebase fixes
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 19:03:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 17:03:19 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-1Gw55m9CCc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #100 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133984
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133984&action=edit
    Bug 30275: Add renewals relation to Koha::Old::Checkout
    
    Add the new 'renewals' relation to Koha::Old::Checkout to return a
    list of Koha::Checkouts::Renewal objects.
    
    We also add the same relation to the OldIssue schema inline.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 19:14:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 17:14:33 +0000
    Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase
     suggestions (using an Ajax-request)
    In-Reply-To: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14242-70-PTy9y8E55p@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 19:14:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 17:14:39 +0000
    Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase
     suggestions (using an Ajax-request)
    In-Reply-To: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14242-70-ucn8e8JSfC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131219|0                           |1
            is obsolete|                            |
     Attachment #131220|0                           |1
            is obsolete|                            |
     Attachment #131221|0                           |1
            is obsolete|                            |
     Attachment #131222|0                           |1
            is obsolete|                            |
    
    --- Comment #140 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133985
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133985&action=edit
    Bug 14242: Use ISBN-field to automatically fill out purchase suggestions
    
    Add new jQuery plugin "autofill" which transforms selected element(s)
    into search fields for Google Books API and automatically fills
    requested fields with search result.
    
    Use in OPAC purchase suggestions to automatically fill out fields when
    entering ISBN-number.
    
    Test plan:
    1. Run updatedatabase.pl
    2. Enable system precference "OPACSuggestionAutoFill"
    3. Log into OPAC and go to purchase suggestions page
    4. Write a valid ISBN (such as 0-9690745-2-2 or 978-1-78416-110-1) into
       the ISBN field and click the 'search google books' button, or unfocus
       the field.
    5. Title, Author, Publisher, publication year and Item Type fields should now
    be filled
       automatically.
    6. Press "clear form" to undo - should restore all fields that the API pull
       filled to empty
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 19:14:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 17:14:46 +0000
    Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase
     suggestions (using an Ajax-request)
    In-Reply-To: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14242-70-O6m9o9u1JQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242
    
    --- Comment #141 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133986
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133986&action=edit
    Bug 14242: (follow-up) Format copyright date before plugged into form
    
    This patch formats the copyright date so that only the year shows before
    plugging the formatted version into the form.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 19:14:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 17:14:52 +0000
    Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase
     suggestions (using an Ajax-request)
    In-Reply-To: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14242-70-ZnMAHxiSSs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242
    
    --- Comment #142 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133987
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133987&action=edit
    Bug 14242: (follow-up) Hide autofil when syspref disabled, clear ISBN
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 19:14:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 17:14:59 +0000
    Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase
     suggestions (using an Ajax-request)
    In-Reply-To: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14242-70-bf2nkzf5SY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242
    
    --- Comment #143 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 133988
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133988&action=edit
    Bug 14242: (follow-up) Clear all text input fields
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 19:21:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 17:21:21 +0000
    Subject: [Koha-bugs] [Bug 30037] Set default profile when staging MARC
     records on import
    In-Reply-To: <bug-30037-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30037-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30037-70-W91AjKbODt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |florian.bontemps at biblibre.c
                       |ity.org                     |om
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 19:21:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 17:21:36 +0000
    Subject: [Koha-bugs] [Bug 30037] Set default profile when staging MARC
     records on import
    In-Reply-To: <bug-30037-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30037-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30037-70-CFebe61xtj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Patch doesn't apply
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 19:31:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 17:31:34 +0000
    Subject: [Koha-bugs] [Bug 30599] Allow archiving multiple suggestions
    In-Reply-To: <bug-30599-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30599-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30599-70-MzXFlTrsgP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30599
    
    Felicity Brown <felicity.brown at montgomerycountymd.gov> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |felicity.brown at montgomeryco
                       |                            |untymd.gov
    
    --- Comment #6 from Felicity Brown <felicity.brown at montgomerycountymd.gov> ---
    This would be great to get into the next release! Our acquisitions staff would
    be grateful!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 19:51:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 17:51:38 +0000
    Subject: [Koha-bugs] [Bug 30621] Author should be its own column on
     opac-readingrecord.tt
    In-Reply-To: <bug-30621-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30621-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30621-70-GFVNmv6QNS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30621
    
    Sarah Cornell <sbcornell at cityofportsmouth.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |sbcornell at cityofportsmouth.
                       |                            |com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 19:53:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 17:53:38 +0000
    Subject: [Koha-bugs] [Bug 30621] Author should be its own column on
     opac-readingrecord.tt
    In-Reply-To: <bug-30621-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30621-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30621-70-4eTdPDPMom@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30621
    
    --- Comment #1 from Sarah Cornell <sbcornell at cityofportsmouth.com> ---
    I've had two patrons ask for this in one day! It should be fairly
    straightforward, right?  The Checked Out tab on the summary table is already
    split into title and author.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 20:08:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 18:08:34 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-zqzhBxmNKJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    --- Comment #83 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133989
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133989&action=edit
    Bug 29924: Avoid leaking information on wrong credentials
    
    If the passed credentials are wrong, we shouldn't expose things like the
    password is expired.
    
    This patch takes care of that.
    
    To test:
    1. Have a known patron with password_expiration_date set so its
       password is expired. Can be done like:
       $ koha-mysql kohadev
       > UPDATE borrowers \
         SET password_expiration_date='2022-04-25' \
         WHERE borrowernumber=132;
       Note: change the borrowernumber
    2. Attempt to login to the OPAC with wrong credentials
    => SUCCESS: You are rejected, with a message telling credentials are
                wrong
    => FAIL: You are told the password is expired.
    3. Apply this patch and restart Plack
    4. Repeat 2
    => SUCCESS: You are rejected, credentials are wrong and no mention to
                password being expired.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 20:09:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 18:09:03 +0000
    Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron
     categories
    In-Reply-To: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29924-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29924-70-M2T5mQwxZG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 20:27:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 18:27:11 +0000
    Subject: [Koha-bugs] [Bug 30623] New: Copy permissions from one user to
     another
    Message-ID: <bug-30623-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30623
    
                Bug ID: 30623
               Summary: Copy permissions from one user to another
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: enhancement
              Priority: P5 - low
             Component: Staff Client
              Assignee: oleonard at myacpl.org
              Reporter: oleonard at myacpl.org
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com
    
    I would like to add a way to "copy" a user's permissions and "paste" them into
    another patron record. I can do this by reading the form state into
    localStorage and then parsing that to update the form state when editing
    another user's permissions.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 21:09:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 19:09:40 +0000
    Subject: [Koha-bugs] [Bug 30387] IndependentBranches allows users to change
     libraries when they should not be able to
    In-Reply-To: <bug-30387-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30387-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30387-70-DFFcUdI9HL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30387
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |andrew at bywatersolutions.com
                 Status|Needs Signoff               |Failed QA
    
    --- Comment #2 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Test plan failed on step 10. As a non-superlibrarian, I get the Set Desks page,
    but no content in the Desks dropdown.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 21:21:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 19:21:10 +0000
    Subject: [Koha-bugs] [Bug 30387] IndependentBranches allows users to change
     libraries when they should not be able to
    In-Reply-To: <bug-30387-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30387-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30387-70-VJAc5gY3kl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30387
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Needs Signoff
    
    --- Comment #3 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Nevermind, user error. Back to NSO.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 21:34:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 19:34:23 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-qeJwUzVWfU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 21:34:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 19:34:28 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-bqfyHstnVR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133184|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 21:34:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 19:34:31 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-BiXyBDPoLa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133185|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 21:34:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 19:34:35 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-Ce6CvhblsE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133186|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 21:34:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 19:34:39 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-chIj2gsPXs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133187|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 21:34:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 19:34:43 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-kpV2PS3TyM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133188|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 21:34:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 19:34:48 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-wmpFE43u2y@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133189|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 21:34:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 19:34:51 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-pWQG080x4F@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133190|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 21:34:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 19:34:55 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-MNNQ3aH6Lm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133205|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 21:34:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 19:34:59 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-VxdlXeD1wi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133183|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 21:35:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 19:35:08 +0000
    Subject: [Koha-bugs] [Bug 30387] IndependentBranches allows users to change
     libraries when they should not be able to
    In-Reply-To: <bug-30387-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30387-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30387-70-vSuhJyOsAc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30387
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 21:35:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 19:35:12 +0000
    Subject: [Koha-bugs] [Bug 30387] IndependentBranches allows users to change
     libraries when they should not be able to
    In-Reply-To: <bug-30387-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30387-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30387-70-mICjGJ3LUU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30387
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132352|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Created attachment 133990
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133990&action=edit
    Bug 30387: Only allow superlibrarians to set library with IndependentBranches
    enabled
    
    To test:
    1. Turn on IndependentBranches.
    2. Give a staff member editcatalogue permissions but not superlibrarian
    permissions.
    3. Once logged in as that staff member click on the name in the top right
    corner, notice that the 'Set library' button is there.
    4. Turn on the CircSidebar system preference and go to any page that includes
    the  CircSidebar. ( returns.tt, circulation,tt ). Notcie the Set library button
    is visibile.
    5. Go to '/cgi-bin/koha/circ/set-library.pl', notice you can set your library
    to something else.
    6. Apply patch
    7. Again with the staff member who has editcatalogue permissions but not
    superlibrarian permissions try steps 3-5. This time you should not see the 'Set
    library' links. On '/cgi-bin/koha/circ/set-library.pl' you should not be able
    to change your library.
    8. With a superlibrarian try steps 3-5, you should see the 'Set library' links 
    and on '/cgi-bin/koha/circ/set-library.pl' you should be able to set your
    library
    9. Turn on 'UseCirculationDesks'.
    10. When repeating 3-5 make sure you can see only the 'Set desk' links while
    logged in as the non-superlibrarian. On '/cgi-bin/koha/circ/set-library.pl' you
    should only be able to 'Set desk'.
    11. Now with a staff member who has neither superlibrarian permissions OR
    editcatalogue permissions do steps 3-5. You should NOT see the 'Set library
    links' but you should see the 'Set desk' links.
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 21:38:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 19:38:47 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-OfQQFQv29Q@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #35 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133991
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133991&action=edit
    Bug 29346: Refactor loop code into a subroutine
    
    The CreateQueue() method deletes the holds queue data, fetches some
    configuration (branches to use, transport cost matrix) and then loops
    through a list of biblionumbers, generating the tmp_holdsqueue and
    hold_fill_targets rows for the specified biblio.
    
    This patch simply moves that last bit that is run inside the biblios
    loop into a separate sub.
    
    The update_queue_for_biblio sub is designed so it does the exact same
    thing it did inside the loop, but also gets added the capability of
    querying those parameters if not passed, and it also gets a 'delete'
    parameter so it deletes the biblio-specific holds queue rows before
    starting to work.
    
    This way, it can be reused to write a background job for real-time holds
    queue update :-D
    
    To test:
    1. Run:
       $ kshell
      k$ prove t/db_dependent/HoldsQueue.t
    => SUCCESS: Tests pass!
    2. Apply this patch
    3. Repeat 1
    => SUCCESS: Tests still pass! Behavior is kept!
    4. Sign off :-D
    
    Sponsored-by: Montgomery County Public Libraries
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 21:38:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 19:38:52 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-Xf4nekVIvo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #36 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133992
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133992&action=edit
    Bug 29346: Add holds queue update background job
    
    This patch adds a background job that takes care of updating the holds
    queue rows for a given list of biblios.
    
    It is designed to be used for real-time batch updating the holds queue
    when required. Tasks would be added by the relevant methods under the
    right use cases.
    
    Sponsored-by: Montgomery County Public Libraries
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 21:38:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 19:38:58 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-GVjHDlLVhq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #37 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133993
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133993&action=edit
    Bug 29346: Hold actions triggers
    
    This patch makes several holds related actions schedule the background
    job for real-time update of the holds queue.
    
    This actions are:
    
    - place (C4::Reserves::AddReserve)
    - fill (Koha::Hold->fill)
    - cancel (Koha::Hold->cancel)
    - suspend (Koha::Hold->suspend)
    - resume (Koha::Hold->resume)
    
    The cancel() action is added a *skip_holds_queue* parameter to skip
    triggering the background job entirely. It targets cases like
    C4::Biblio::DelBiblio in which all biblio holds are cancelled in a loop.
    In that case, we just want to cancel them and let a single backgroung
    job take care of the holds queue, once the biblio is deleted.
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Hold.t \
               t/db_dependent/Reserves.t
    => SUCCESS: Tests pass! Triggers are triggered
    3. Sign off :-D
    
    Sponsored-by: Montgomery County Public Libraries
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 21:39:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 19:39:05 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-3fPDDO870P@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #38 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133994
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133994&action=edit
    Bug 29346: Circulation actions triggers
    
    This patch introduces triggers for real-time updating the holds queue at
    check out and check in.
    
    The following high-level methods are involved:
    
    - C4::Circulation::AddIssue
    - C4::Circulation::AddReturn
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Circulation_holdsqueue.t
    => SUCCESS: Tests pass! Triggers are triggered
    3. Sign off :-D
    
    Note: I put the tests on a separate file because the other one was too
    big already.
    
    Sponsored-by: Montgomery County Public Libraries
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 21:39:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 19:39:11 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-NfZ0k41RzA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #39 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133995
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133995&action=edit
    Bug 29346: Biblio actions triggers
    
    This patch adds the trigger for the holds queue update on teh following
    methods:
    
    - C4::Biblio::DelBiblio
    - C4::Biblio::ModBiblio
    
    The ModBiblio use case could be improved by checking if itemtype is one
    of the updated attributes... but it felt there was no way to do it
    without some overhead. So I leave it as-is.
    
    It also mocks the ->enqueue method in the tests that call DelBiblio and
    ModBiblio to avoid breakages [1]
    
    Tests are added to check the trigger is called.
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Biblio.t
    => SUCCESS: Tests pass! It means the trigger is triggered :-D
    3. Sign off :-D
    
    [1] This breakages could be avoided if we solve Koha/BackgrounJob.pm:101
    FIXME.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 21:39:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 19:39:17 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-TdlNhihzBG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #40 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133996
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133996&action=edit
    Bug 29346: Item action trigger
    
    This patch makes the following actions trigger a holds queue rebuild for
    the related biblio:
    
    - Adding an item
    - Updating an item
    - Deleting an item
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Item.t
    => SUCCESS: Tests pass! Background job scheduled
    3. Sign off :-D
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 21:39:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 19:39:23 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-LioLFJfTek@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #41 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133997
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133997&action=edit
    Bug 29346: (follow-up) Fix typo
    
    We set biblio_ids in enqueue then referred to biblio_id in process ;)
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 21:39:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 19:39:29 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-WfuaulC9va@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #42 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133998
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133998&action=edit
    Bug 29346: (follow-up) Fix import issue in HoldsQueue
    
    For some reason `t/db_dependent/HoldsQueue..t` starts failing for me
    without this patch.. using the full module path resolves the issue but
    I'd love to understand why/how this creeps in.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 21:39:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 19:39:34 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-6pLBduDAn9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #43 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 133999
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133999&action=edit
    Bug 29346: Highlight double enqueue
    
    This patch highlights a possible issue with the triggers.. though it may
    not actually matter in reality.
    
    I appear to already see test failures before this patch with a double
    enqueue of the rebuild for both AddIssue and AddReturn.. I couldn't spot
    what was causing that but whilst digging I did find another case where
    it could happen as highlighted here...
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 21:39:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 19:39:40 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-uCKAcZv4HR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #44 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134000
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134000&action=edit
    Bug 29346: Avoid duplicate actions tests
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 21:39:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 19:39:46 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-U2HD8RxBsE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #45 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134001
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134001&action=edit
    Bug 29346: Add more fine-grained control of holds queue updates
    
    This patch deals with the fact that high-level circualtion methods like
    `AddIssue`, `AddReturn` and `ModDateLastSeen` all eventually call
    lower-level methods like ModBiblio, Koha::Item->store of
    UpdateTotalIssues which are expected to trigger holds queue updates (for
    the object CRUD operations use cases). As the circulation methods need
    to trigger holds queue update as well, duplicate updates were being
    requested which is suboptimal, of course.
    
    In order to prevent this, and because circulation methdos could trigger
    holds queue updates several times, actually, I added a new parameter
    *skip_holds_queue* to the low-level methods, so when they are called
    from circulation, the trigger is skipped and we have greater control on
    when and how holds queue updates are scheduled.
    
    This patch introduces the `skip_holds_queue` parameter to the following
    methods:
    
    * C4::Biblio::ModBiblio
    * C4::Biblio::UpdateTotalIssues
    * Koha::Item->store
    
    Calls to those methods from the following methods will include the new
    parameter, and thus duplicated holds queue updates avoided:
    
    * C4::Circulation::AddIssue
    * C4::Circulation::AddReturn
    * C4::Items::ModDateLastSeen
    
    Tests are added, to verify that the (mocked) BatchUpdateBiblioHoldsQueue
    task is only scheduled once when they are called.
    
    To test:
    1. Apply up to the previous patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Biblio.t \
               t/db_dependent/Biblio_holdsqueue.t \
               t/db_dependent/Circulation_holdsqueue.t
    => FAIL: Tests fail!
    3. Apply this patch
    4. Repeat 2
    => SUCCESS: Tests pass!
    5. Sign off :-D
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 21:49:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 19:49:40 +0000
    Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
     too
    In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28269-70-CVAOUZkmkX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269
    
    --- Comment #10 from Slava Shishkin <slavashishkin at gmail.com> ---
    The first patch (133869) will not solve by itself 23919 - there is additional
    code logic required (and I now have some proof of concept working, so yes,
    23919 will be solved as well by me, but there will be another patch over
    133869),
    
    and the above patch (133869) is needed by both 28269 and 23919.
    So it can be here or there.
    
    Q1: so to which ticket is better to place the first patch, please advise,
    
    Q2: Can I put one ticket as dependant on another, and that will fit?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 22:01:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 20:01:44 +0000
    Subject: [Koha-bugs] [Bug 30623] Copy permissions from one user to another
    In-Reply-To: <bug-30623-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30623-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30623-70-1HywJMUyKh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30623
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lucas at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 22:11:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 20:11:35 +0000
    Subject: [Koha-bugs] [Bug 30387] IndependentBranches allows users to change
     libraries when they should not be able to
    In-Reply-To: <bug-30387-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30387-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30387-70-kC1La3q8yc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30387
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133990|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Created attachment 134002
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134002&action=edit
    Bug 30387: Only allow superlibrarians to set library with IndependentBranches
    enabled
    
    To test:
    1. Turn on IndependentBranches.
    2. Give a staff member editcatalogue permissions but not superlibrarian
    permissions.
    3. Once logged in as that staff member click on the name in the top right
    corner, notice that the 'Set library' button is there.
    4. Turn on the CircSidebar system preference and go to any page that includes
    the  CircSidebar. ( returns.tt, circulation,tt ). Notcie the Set library button
    is visibile.
    5. Go to '/cgi-bin/koha/circ/set-library.pl', notice you can set your library
    to something else.
    6. Apply patch
    7. Again with the staff member who has editcatalogue permissions but not
    superlibrarian permissions try steps 3-5. This time you should not see the 'Set
    library' links. On '/cgi-bin/koha/circ/set-library.pl' you should not be able
    to change your library.
    8. With a superlibrarian try steps 3-5, you should see the 'Set library' links 
    and on '/cgi-bin/koha/circ/set-library.pl' you should be able to set your
    library
    9. Turn on 'UseCirculationDesks'.
    10. When repeating 3-5 make sure you can see only the 'Set desk' links while
    logged in as the non-superlibrarian. On '/cgi-bin/koha/circ/set-library.pl' you
    should only be able to 'Set desk'.
    11. Now with a staff member who has neither superlibrarian permissions OR
    editcatalogue permissions do steps 3-5. You should NOT see the 'Set library
    links' but you should see the 'Set desk' links.
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 22:18:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 20:18:14 +0000
    Subject: [Koha-bugs] [Bug 30624] New: Remove
     IndependentBranchesLoggedInLibrary in favor of a permission
    Message-ID: <bug-30624-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624
    
                Bug ID: 30624
               Summary: Remove IndependentBranchesLoggedInLibrary in favor of
                        a permission
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Staff Client
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: lucas at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com
    
    Bug 29887 added the system preference IndependentBranchesLoggedInLibrary. This
    bug intends to remove that system preference and replace it with a permission:
    'select_loggedin_library'
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 22:18:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 20:18:27 +0000
    Subject: [Koha-bugs] [Bug 30624] Remove IndependentBranchesLoggedInLibrary
     in favor of a permission
    In-Reply-To: <bug-30624-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30624-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30624-70-6OuNdjpHGy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |29887
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887
    [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 22:18:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 20:18:27 +0000
    Subject: [Koha-bugs] [Bug 29887] Create system preference
     IndependentBranchesLoggedInLibrary
    In-Reply-To: <bug-29887-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29887-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29887-70-SpyzAnmLZe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30624
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624
    [Bug 30624] Remove IndependentBranchesLoggedInLibrary in favor of a permission
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 22:20:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 20:20:44 +0000
    Subject: [Koha-bugs] [Bug 30624] Remove IndependentBranchesLoggedInLibrary
     in favor of a permission
    In-Reply-To: <bug-30624-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30624-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30624-70-gog3qHDqtU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |andrew at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 22:35:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 20:35:23 +0000
    Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
     too
    In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28269-70-KM2WHvbuIG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133869|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 22:36:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 20:36:05 +0000
    Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
     too
    In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28269-70-b0CqwxpjcJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |23919
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919
    [Bug 23919] Make ISSN searchable with and without hyphen
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 22:36:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 20:36:05 +0000
    Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen
    In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23919-70-Wu0YPSznMz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |28269
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269
    [Bug 28269] Order search should be possible with ISSN too
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 22:36:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 20:36:53 +0000
    Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
     too
    In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28269-70-gR1AJvdwRM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269
    
    --- Comment #11 from Slava Shishkin <slavashishkin at gmail.com> ---
    Ok, I will move patch 133869 to 23919
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 22:49:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 20:49:36 +0000
    Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available
     items even if on shelf holds aren't allowed
    In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30556-70-ScC6wINvw2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556
    
    Shi Yao Wang <shi-yao.wang at inLibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
                     CC|                            |shi-yao.wang at inLibro.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Tue Apr 26 23:27:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 21:27:19 +0000
    Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
     too
    In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28269-70-Wz2YSCFvfx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |BLOCKED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 00:16:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 22:16:53 +0000
    Subject: [Koha-bugs] [Bug 30031] Add lists to table settings
    In-Reply-To: <bug-30031-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30031-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30031-70-CiCBlM7maN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031
    
    --- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> ---
    Cait,
    
    I purposefully left out the 'Columns' button from the configuration options. 
    For Test Plan Step 7 I meant hide them via Table Setting. 
    
    Do you think I should add the 'Columns' button to the top of the page? In that
    case should we also add the Export function? 
    
    
    I am happy to move lists to its own module in Table Settings!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 01:30:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 23:30:38 +0000
    Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to Patron Card Creator
     - Patron Search
    In-Reply-To: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28726-70-h0lFmUa316@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
    
    Michael Hafen <michael.hafen at washk12.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #122991|0                           |1
            is obsolete|                            |
     Attachment #129203|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Michael Hafen <michael.hafen at washk12.org> ---
    Created attachment 134003
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134003&action=edit
    Bug 28726 - Add sort1 and sort2 to patron card creator - patron search.
    
    Add sort1 and sort2 filters, checkboxes and select/clear all links, and a add
    selected button to the patron search (for the patron card creator).
    
    Rebase after change to how the patron search works.
    
    Test plan:
    
    1. start a new batch in the patron card creator (Tools -> Patron card creator
    -> New -> card batch)
    2. click the Add patron(s) button.  Observe that Category and Library are the
    only options.
    3. Close search for patron window.
    4. Apply patch.
    5. click the Add patron(s) button.  Observe that you can now search for patrons
    by their sort1 and sort2 values.
    6. perform a search and observe the 'Select all | Clear all | Add selected
    patrons' links and button.
    7. use the Select all link to select all the patrons found by the search.
    8. use the Add selected patrons button to add the selected patrons to the card
    batch's Add by borrowernumber(s) text input field.
    9. close the search for patron window.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 01:55:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Tue, 26 Apr 2022 23:55:11 +0000
    Subject: [Koha-bugs] [Bug 28864] The patron search results in the Patron
     card creator doesn't seem to use PatronsPerPage syspref
    In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28864-70-RKz9PNqnLL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864
    
    Michael Hafen <michael.hafen at washk12.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #124787|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Michael Hafen <michael.hafen at washk12.org> ---
    Created attachment 134004
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134004&action=edit
    Bug 28864: Have patron card creator use PatronsPerPage
    
    Rebase after update to how patron search works elsewhere.
    
    Add aLengthMenu, pageLength, and iDisplayLength to patroncards/edit-batch
    
    Test plan:
    1. Set the PatronsPerPage system preference to any integer other than 20.
    
    2. Go to Tools -> Patron card creator.
    3. Start a new Card Batch.
    4. Click the 'Add patron(s)' button to open the patron search window.
    5. Do a search.
    6. Add more than 20 patrons to the batch and close the search window.
    7. Observe that the per page drop down defaults to 20.
    8. If the PatronsPerPage was set to a value other than 10, 20, 50, or 100
          observe that that value is not in the per page drop down.
    
    9. Apply patch.
    10. Reload the Patron Card Batch
    11. Observe that the per page drop down includes the value of PatronsPerPage
         and that value is selected by default.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 02:19:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 00:19:10 +0000
    Subject: [Koha-bugs] [Bug 30072] Add more holds hooks
    In-Reply-To: <bug-30072-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30072-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30072-70-NUXU3TUElT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072
    
    --- Comment #30 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Created attachment 134005
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134005&action=edit
    Bug 30072: (followup) Fix random failure of Holds_hooks.t
    
    When building Koha::Holds object,
    do not let 'found' random otherwise it may take a valid value indicating
    hold is found.
    
    See other holds unit tests.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 02:20:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 00:20:00 +0000
    Subject: [Koha-bugs] [Bug 30072] Add more holds hooks
    In-Reply-To: <bug-30072-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30072-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30072-70-OYjzfkoso9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072
    
    --- Comment #31 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    > Bug 30072: (followup) Fix random failure of Holds_hooks.t 
    Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 03:04:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 01:04:07 +0000
    Subject: [Koha-bugs] [Bug 29077] Warns when searching blank index
    In-Reply-To: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29077-70-I0voBVLemY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29077
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 03:04:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 01:04:09 +0000
    Subject: [Koha-bugs] [Bug 29077] Warns when searching blank index
    In-Reply-To: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29077-70-wTjdgY1nRs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29077
    
    --- Comment #6 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 03:04:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 01:04:12 +0000
    Subject: [Koha-bugs] [Bug 30224] Wrong important field shown in cataloguing
     validation
    In-Reply-To: <bug-30224-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30224-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30224-70-fwWLDcdiG0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 03:04:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 01:04:15 +0000
    Subject: [Koha-bugs] [Bug 30224] Wrong important field shown in cataloguing
     validation
    In-Reply-To: <bug-30224-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30224-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30224-70-HDJD1w8Cfv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224
    
    --- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 03:04:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 01:04:18 +0000
    Subject: [Koha-bugs] [Bug 30482] Potential for bad string concatenation in
     cataloging validation error message
    In-Reply-To: <bug-30482-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30482-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30482-70-blEhCRgcmV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30482
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 03:04:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 01:04:21 +0000
    Subject: [Koha-bugs] [Bug 30482] Potential for bad string concatenation in
     cataloging validation error message
    In-Reply-To: <bug-30482-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30482-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30482-70-gNK7WATQSP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30482
    
    --- Comment #6 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 03:05:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 01:05:26 +0000
    Subject: [Koha-bugs] [Bug 29077] Warns when searching blank index
    In-Reply-To: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29077-70-QV4h3i4bmX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29077
    
    --- Comment #7 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Created attachment 134006
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134006&action=edit
    Bug 29077: (follow-up) Use another syntax
    
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 03:06:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 01:06:13 +0000
    Subject: [Koha-bugs] [Bug 29077] Warns when searching blank index
    In-Reply-To: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29077-70-IoQJJDuZTQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29077
    
    --- Comment #8 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    I use my Gauntlet of Power and snap the syntax ^^
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 03:09:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 01:09:49 +0000
    Subject: [Koha-bugs] [Bug 30600] Recalls sync problem between DBIx and
     kohastructure.sql
    In-Reply-To: <bug-30600-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30600-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30600-70-8GGPsx0yRt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30600
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |rel_22_05_candidate
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 03:18:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 01:18:03 +0000
    Subject: [Koha-bugs] [Bug 30600] Recalls sync problem between DBIx and
     kohastructure.sql
    In-Reply-To: <bug-30600-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30600-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30600-70-ZycOqVRzXZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30600
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |ASSIGNED
               Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz
                       |ity.org                     |
                     CC|                            |aleisha at catalyst.net.nz
    
    --- Comment #3 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Hi Fridolin, I will take a look at this asap.
    
    Aleisha
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 03:57:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 01:57:40 +0000
    Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck
     modules for Koha
    In-Reply-To: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30444-70-rGHaByS7Qd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444
    
    Alex Buckley <alexbuckley at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133616|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 03:58:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 01:58:00 +0000
    Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck
     modules for Koha
    In-Reply-To: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30444-70-xyw1gEES3y@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444
    
    --- Comment #9 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
    Created attachment 134007
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134007&action=edit
    Bug 30444: (follow-up) WIP:
    
    Don't re-direct infinite loop if SelfCheckoutByLogin not equal to 'shibboleth'
    
    Test plan:
    1. On a Koha setup to do Shibboleth set the following sysprefs:
    - OPACShibOnly = "Don't allow"
    - AutoSelfCheckAllowed = Allow
    - AutoSelfCheckID and AutoSelfCheckPass = The username and password of a
    patron with 'self_checkout_module' sub-permission enabled
    - SelfCheckoutByLogin = 'cardnumber'
    2. Visit the self checkout page, confirm it does not indefinitely loop
    3. Change SelfCheckoutbyLogin = 'username and password'
    4. Repeat step 2 and confirm the same results
    5. Change SelfCheckoutByLogin = 'shibboleth'
    6. Repeat step 2 and confirm the same results
    
    Sponsored-by: Catalyst IT
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 04:43:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 02:43:36 +0000
    Subject: [Koha-bugs] [Bug 30600] Recalls sync problem between DBIx and
     kohastructure.sql
    In-Reply-To: <bug-30600-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30600-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30600-70-qvlGatK8Xc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30600
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 04:43:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 02:43:40 +0000
    Subject: [Koha-bugs] [Bug 30600] Recalls sync problem between DBIx and
     kohastructure.sql
    In-Reply-To: <bug-30600-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30600-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30600-70-yXLyeWnlS7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30600
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133696|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Created attachment 134008
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134008&action=edit
    Bug 30600: Fix recall reasons for branch transfers
    
    When a recall triggers a branch transfer, the reason for the transfer is
    'Recall'.
    
    When a transfer is cancelled that was triggered by a recall, it still
    uses the default 'Manual' reason, so we don't need the 'CancelRecall'
    cancellation reason that was added by Bug 19532.
    
    This patch removes 'Recall' and 'CancelRecall' from
    branchtransfers.cancellation_reason, and removes 'CancelRecall' from
    branchtransfers.reason.
    
    Sponsored-by: Catalyst IT
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 06:08:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 04:08:13 +0000
    Subject: [Koha-bugs] [Bug 30623] Copy permissions from one user to another
    In-Reply-To: <bug-30623-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30623-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30623-70-dRM9rvjgzr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30623
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |david at davidnind.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 08:09:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 06:09:39 +0000
    Subject: [Koha-bugs] [Bug 30328] Add ability to generate barcode with branch
     specific prefix
    In-Reply-To: <bug-30328-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30328-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30328-70-OmbhGG2kK1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328
    
    Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132954|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
    Created attachment 134009
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134009&action=edit
    Bug 30328: Add ability to generate barcode with branch specific prefix
    
    We should add more flexibility to generating barcodes by letting libraries
    define branch specific prefix for their barcodes. This patch adds new option
    "preyyyymmincr" in systempreference "autoBarcode" and new systempreference
    "BarcodePrefix" to define branch specific prefix
    
    Test plan for adding item:
    
    1. Apply patch and update database
    2. Set syspref "autoBarcode" as
    3. Add some values to syspref "Barcodeprefix" e.g.:
            Default: DEF
            CPL: CPL
            FFL: FFL
    4. Now change your library to CPL (if needed) and add an item
    5. Click barcode input field
       => barcode should be CPL<current_year><current_month>00001
    6. Add another item and click barcode field
       => barcode should be CPL<current_year><current_month>00002
    7. Change your library to FFL and add an item
       => barcode should now be FFL<current_year><current_month>00001
    8. Change your library to e.g. FPL (or another as long as it doesn't have
    prefix value
    in "Barcodeprefix"), add an item and click barcode field
       => barcode should now be DEF<current_year><current_month>00001
    9. Try to add multiple items
       => barcodes incremental value should increase in order (no skipping values,
    no errors)
    
    Test plan for adding multiple aqcuisitions:
    
    1. Set syspref "AcqCreateItem" as "placing order".
    2. Create an order and add multiple items to it.
    3. Save the order.
    4. Navigate to that biblios detail page to which you added items.
       => ordered items barcodes incremental value should increase in order (no
    skipping
          values, no errors)
    
    Also prove t/db_dependent/Barcodes_ValueBuilder.t and
    t/Barcodes_preyyyymmincr.t
    
    Sponsored-by: Koha-Suomi Oy
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 08:11:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 06:11:23 +0000
    Subject: [Koha-bugs] [Bug 30328] Add ability to generate barcode with branch
     specific prefix
    In-Reply-To: <bug-30328-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30328-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30328-70-hBPvNk4WUj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328
    
    --- Comment #4 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
    Previous patch didn't have custom methods in C4/Barcodes/preyyyymmincr.pm so
    adding an order with multiple items produced error 500. Added methods and test
    plan for this scenario.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 08:50:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 06:50:24 +0000
    Subject: [Koha-bugs] [Bug 22279] Unify patron name display
    In-Reply-To: <bug-22279-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22279-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22279-70-30wrufIRhK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22279
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
                 Status|NEW                         |RESOLVED
             Resolution|---                         |DUPLICATE
    
    --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Oop, I didn't spot this before I created an OMNIBUS bug around this issue.
    
    *** This bug has been marked as a duplicate of bug 30617 ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 08:50:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 06:50:24 +0000
    Subject: [Koha-bugs] [Bug 30617] [OMNIBUS] We should consistently use
     includes for patron name display
    In-Reply-To: <bug-30617-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30617-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30617-70-ekNc5u3Lcx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30617
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |pasi.kallinen at koha-suomi.fi
    
    --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    *** Bug 22279 has been marked as a duplicate of this bug. ***
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 08:50:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 06:50:25 +0000
    Subject: [Koha-bugs] [Bug 7680] Create a PatronDefaultView preference to
     control whether patron links go to circ or patron details
    In-Reply-To: <bug-7680-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-7680-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-7680-70-7oNH3FtBeF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680
    Bug 7680 depends on bug 22279, which changed state.
    
    Bug 22279 Summary: Unify patron name display
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22279
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |RESOLVED
             Resolution|---                         |DUPLICATE
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 08:51:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 06:51:10 +0000
    Subject: [Koha-bugs] [Bug 30568] Make patron name fields more flexible
    In-Reply-To: <bug-30568-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30568-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30568-70-qLA650Ncwu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |7680
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680
    [Bug 7680] Create a PatronDefaultView preference to control whether patron
    links go to circ or patron details
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 08:51:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 06:51:10 +0000
    Subject: [Koha-bugs] [Bug 7680] Create a PatronDefaultView preference to
     control whether patron links go to circ or patron details
    In-Reply-To: <bug-7680-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-7680-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-7680-70-NwxxVtQGJG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30568
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568
    [Bug 30568] Make patron name fields more flexible
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 08:56:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 06:56:03 +0000
    Subject: [Koha-bugs] [Bug 24710] patron-title.inc should have seperate span
     classes for firstname, othername, surname
    In-Reply-To: <bug-24710-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24710-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24710-70-MD9PjOPGLz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |RESOLVED
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
             Resolution|---                         |DUPLICATE
    
    --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    
    
    *** This bug has been marked as a duplicate of bug 30568 ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 08:56:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 06:56:03 +0000
    Subject: [Koha-bugs] [Bug 30568] Make patron name fields more flexible
    In-Reply-To: <bug-30568-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30568-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30568-70-HazJHjx22i@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lucas at bywatersolutions.com
    
    --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    *** Bug 24710 has been marked as a duplicate of this bug. ***
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 08:59:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 06:59:04 +0000
    Subject: [Koha-bugs] [Bug 30568] Make patron name fields more flexible
    In-Reply-To: <bug-30568-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30568-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30568-70-EyM5Gv3GS5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568
    
    --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    There was a try at doing this by surrounding name fields by spans, bug 24710,
    in the template includes, but it became clear that wasn't an option as the
    no_html option on the includes, used for title elements, precludes us from
    using said spans.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 09:01:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 07:01:03 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-U6Kc6RpVaD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 09:01:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 07:01:08 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-hV7qxub9mQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #46 from David Nind <david at davidnind.com> ---
    Created attachment 134010
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134010&action=edit
    Bug 29077: (follow-up) Use another syntax
    
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 09:09:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 07:09:27 +0000
    Subject: [Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability
     to send notices based on request supplier updates
    In-Reply-To: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30484-70-J7BL3ZSf5J@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com, tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 09:41:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 07:41:26 +0000
    Subject: [Koha-bugs] [Bug 30031] Add lists to table settings
    In-Reply-To: <bug-30031-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30031-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30031-70-kqh0ur8Nb5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031
    
    --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Hi Lucas,
    
    this table doesn't look quite like our typical datatable, so I was not sure,
    how this was supposed to work. I am ok with the settings missing for now or to
    move it to a separate bug, depending on how much work it is for you.
    
    Moving the config to a separate section in a follow-up would be great.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 09:59:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 07:59:40 +0000
    Subject: [Koha-bugs] [Bug 5316] Limit Z39.50 targets to specific users
    In-Reply-To: <bug-5316-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-5316-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-5316-70-JS071ejs64@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5316
    
    Holly <hc at interleaf.ie> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |hc at interleaf.ie
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 10:23:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 08:23:12 +0000
    Subject: [Koha-bugs] [Bug 30623] Copy permissions from one user to another
    In-Reply-To: <bug-30623-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30623-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30623-70-wXccMMQtiS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30623
    
    Séverine Queune <severine.queune at bulac.fr> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |severine.queune at bulac.fr
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 10:29:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 08:29:20 +0000
    Subject: [Koha-bugs] [Bug 30535] Add "Tool plugins" to the main tools screen
    In-Reply-To: <bug-30535-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30535-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30535-70-B4ocvZoEOH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30535
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|REOPENED                    |NEW
    
    --- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    > If you don't have any plugins installed, the only way you can get to the plugin ...
    Oh, You can go to Administration >  Manage plugins
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 10:46:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 08:46:43 +0000
    Subject: [Koha-bugs] [Bug 30600] Recalls sync problem between DBIx and
     kohastructure.sql
    In-Reply-To: <bug-30600-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30600-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30600-70-rczFIkGsEO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30600
    
    --- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    (In reply to Aleisha Amohia from comment #3)
    > Hi Fridolin, I will take a look at this asap.
    > 
    > Aleisha
    
    Thanks a lot.
    
    The recalls feature is not yet in a release.
    May we fix directly its DBRev 21.12.00.018 ?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 10:57:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 08:57:40 +0000
    Subject: [Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on
     display
    In-Reply-To: <bug-27943-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27943-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27943-70-anfZG1Mdv3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943
    
    --- Comment #6 from George Veranis <gveranis at dataly.gr> ---
    Hi Katrin, thanks for the review of that bug I will try to do the changes that
    you proposed . I'm not sure about the unit tests but I will check it to be
    compatible with that.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 10:59:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 08:59:31 +0000
    Subject: [Koha-bugs] [Bug 30136] Add back to top button when scrolling
    In-Reply-To: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30136-70-HJYO1AxKRd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136
    
    --- Comment #17 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    (In reply to Séverine Queune from comment #16)
    > Thanks Frido !
    > I tested on both personal devbox and sandbox and the display of the button
    > is completely different from the one described and shown on screenshot.
    > The behaviour is also slightly different as the one described as the button
    > is stuck on the bottom of the page so I don't see it before I reach the end
    > of the page.
    > Is that expected ?
    > 
    > See sandbox : 
    > https://opac-bz30136.sandboxes.biblibre.eu/cgi-bin/koha/opac-search.
    > pl?idx=&q=a&weight_search=1
    
    I dont reproduce this on you sandbox, button appear as soon as I start
    scrolling down.
    Maybe clear the cache with Ctrl+F5
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 11:06:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 09:06:59 +0000
    Subject: [Koha-bugs] [Bug 30611] Add ability to send passwordreseturl in the
     Welcome email
    In-Reply-To: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30611-70-lskvOOyurh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611
    
    Sally <sally.healey at cheshiresharedservices.gov.uk> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |sally.healey at cheshireshared
                       |                            |services.gov.uk
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 11:13:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 09:13:02 +0000
    Subject: [Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display
    In-Reply-To: <bug-28371-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28371-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28371-70-IgPAOakQ2K@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371
    
    --- Comment #35 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    (In reply to Katrin Fischer from comment #34)
    > Thx to the tests! But at least it seems like it was hard to catch without
    > them, which makes me feel a little less guilty for missing it!
    
    Sure, that is the purpose of test suite.
    Go catch them all ;)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 11:16:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 09:16:53 +0000
    Subject: [Koha-bugs] [Bug 30136] Add back to top button when scrolling
    In-Reply-To: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30136-70-yhUst6fHOX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136
    
    Séverine Queune <severine.queune at bulac.fr> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 11:16:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 09:16:57 +0000
    Subject: [Koha-bugs] [Bug 30136] Add back to top button when scrolling
    In-Reply-To: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30136-70-OaFNcRHyY7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136
    
    Séverine Queune <severine.queune at bulac.fr> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133219|0                           |1
            is obsolete|                            |
    
    --- Comment #18 from Séverine Queune <severine.queune at bulac.fr> ---
    Created attachment 134011
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134011&action=edit
    Bug 30136: Add back to top button to OPAC
    
    Like in many websites, when scrolling down the page make a button appear to go
    back to top.
    This can be very useful specially in search results page.
    
    This patch adds to OPAC using Javascript a button with id "backtotop".
    Button appears when 300 pixels from top are hidden.
    This value may be adapted.
    
    Test plan
    1) Go to OPAC
    2) Perform a search with many results
    3) Scroll down
    => Back to top button appears
    4) Manually scroll back to top
    => Button disappears
    5) Scroll down and click on Back to top button
    => You get to top
    
    Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov>
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 11:17:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 09:17:03 +0000
    Subject: [Koha-bugs] [Bug 30136] Add back to top button when scrolling
    In-Reply-To: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30136-70-gVjEWWTMG1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136
    
    Séverine Queune <severine.queune at bulac.fr> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133737|0                           |1
            is obsolete|                            |
    
    --- Comment #19 from Séverine Queune <severine.queune at bulac.fr> ---
    Created attachment 134012
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134012&action=edit
    Bug 30136: (follow-up) CSS and accessibility update
    
    This patch adds the new CSS to the global CSS file. Rebuild the OPAC CSS
    to test.
    
    The patch also moves the JavaScript for the button from opac-bottom.inc
    into global.js and adds accessibility labels to the generated markup.
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 11:18:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 09:18:40 +0000
    Subject: [Koha-bugs] [Bug 30136] Add back to top button when scrolling
    In-Reply-To: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30136-70-LxSTLhZQ0C@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136
    
    --- Comment #20 from Séverine Queune <severine.queune at bulac.fr> ---
    (In reply to Fridolin Somers from comment #17)
    > (In reply to Séverine Queune from comment #16)
    > > Thanks Frido !
    > > I tested on both personal devbox and sandbox and the display of the button
    > > is completely different from the one described and shown on screenshot.
    > > The behaviour is also slightly different as the one described as the button
    > > is stuck on the bottom of the page so I don't see it before I reach the end
    > > of the page.
    > > Is that expected ?
    > > 
    > > See sandbox : 
    > > https://opac-bz30136.sandboxes.biblibre.eu/cgi-bin/koha/opac-search.
    > > pl?idx=&q=a&weight_search=1
    > 
    > I dont reproduce this on you sandbox, button appear as soon as I start
    > scrolling down.
    > Maybe clear the cache with Ctrl+F5
    
    Completely my fault, I always forgot to empty my cache and cookies when I test
    new CSS...
    
    Thanks Frido for this great feature !
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 11:40:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 09:40:15 +0000
    Subject: [Koha-bugs] [Bug 12133] Guarantor requirements when registering a
     patron
    In-Reply-To: <bug-12133-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-12133-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-12133-70-hToQvcW5Y5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133
    
    Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
      Attachment #94544|0                           |1
            is obsolete|                            |
    
    --- Comment #21 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
    Created attachment 134013
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134013&action=edit
    Bug 12133: Add requirements for guarantor and guarantee
    
    Add three requirements when registering a new patron:
    
    - A child patron must have a guarantor. This is controlled by
      a new syspref ChildNeedsGuarantor.
    - A guarantor has to be a patron. This is controlled by
      a new syspref GuarantorHasToBePatron.
    - A guarantor cannot be a guarantee.
    
    Test plan:
    -Add child patron without guarantor or child patron with guarantee
    as guarantor succesfully.
    - Apply this patch.
    - Add a child patron with a guarantee as guarantor. Error is raised.
    - Turn syspref "ChildNeedsGuarantor" ON.
    - Add a child patron without a guarantor and error "Child needs a
    guarantor" is raised.
    - Add guarantor. Guarantor can either be existing patron or added with
    "Contact" section. Save without errors.
    - Turn syspref "GuarantorNeedsToBePatron" ON.
    - Form fields for "Contact" section aren't displayed and only existing
    patron can be added as guarantor.
    
    Signed-off-by: Johanna Raisa <johanna.raisa at gmail.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 11:40:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 09:40:45 +0000
    Subject: [Koha-bugs] [Bug 12133] Guarantor requirements when registering a
     patron
    In-Reply-To: <bug-12133-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-12133-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-12133-70-ZhweHkKRTD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133
    
    Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #113099|0                           |1
            is obsolete|                            |
    
    --- Comment #22 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
    Created attachment 134014
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134014&action=edit
    Bug 12133: Fix issues with modifying child patron and adding guarantors
    
    Child patrons couldn't be modified when guarantor was
    patron due missing guarantor_id value. Also if multiple
    guarantors were added one could easily add child patron
    as a guarantor.
    
    This patch adds Instead of one guarantor id all new and
    existing guarantor ids are checked in case of child patron.
    
    To test:
    1. Add child patron with syspref ChildNeedsGuarantor and
    GuarantorNeedsToBePatron on.
    2. Add two guarantors for the patron, first one should be
    an adult patron and second a child.
    3. Save patron.
    => Error "A guarantor cannot be a guarantee." should be
    raised but isn't.
    4. Modify patron and save.
    => Error "Child needs guarantor" is raised even if (valid)
    guarantor exists.
    5. Apply patch.
    6. Repeat steps 1 to 4.
    => This time while saving a new patron error "A guarantor
    cannot be a guarantee." is raised but modifying is
    successful.
    
    Sponsored-by: Koha-Suomi Oy
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 11:41:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 09:41:17 +0000
    Subject: [Koha-bugs] [Bug 12133] Guarantor requirements when registering a
     patron
    In-Reply-To: <bug-12133-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-12133-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-12133-70-eNar4PeedP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133
    
    Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #113100|0                           |1
            is obsolete|                            |
    
    --- Comment #23 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
    Created attachment 134015
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134015&action=edit
    Bug 12133: Enforce guarantor restrictions on Koha::Patron->store()
    
    This patch adds checks for new guarantor requirements
    to Koha::Patron->store(). If requirements aren't met
    exception is raised.
    
    To test prove t/db_dependent/Koha/Patron.t
    
    Sponsored-by: Koha-Suomi Oy
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 11:48:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 09:48:05 +0000
    Subject: [Koha-bugs] [Bug 30625] New: Sandboxes do not come provisioned with
     any ILL backends.
    Message-ID: <bug-30625-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30625
    
                Bug ID: 30625
               Summary: Sandboxes do not come provisioned with any ILL
                        backends.
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: ILL
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: r.delahunty at arts.ac.uk
    
    I have been trying to sign off Bug 28634 by following the test plan, but when I
    try to add an ILL request after enabling the ILL module I receive an error that
    there are no backends installed. It appears that until someone with server
    access adds a backend to the provisioned sandbox (or until the sandboxes come
    with the option if having an ILL backend added at the provisioning stage) I
    will be unable to complete the test with a view to signing of the ILL bug.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:32:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:32:06 +0000
    Subject: [Koha-bugs] [Bug 30626] New: DT REST API wrapper not building the
     filter query correctly
    Message-ID: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
                Bug ID: 30626
               Summary: DT REST API wrapper not building the filter query
                        correctly
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: major
              Priority: P5 - low
             Component: Architecture, internals, and plumbing
              Assignee: jonathan.druart+koha at gmail.com
              Reporter: jonathan.druart+koha at gmail.com
            QA Contact: testopia at bugs.koha-community.org
    
    The general search query is not built correctly.
    
    Say you have a table with column filters, like the main patron search:
    General filter: henry
    Specific filter on the 'Name' column: h
    
    The generated query will be (= are actually LIKE):
    { Column1="henry" AND Column3="henry", ...} AND { Column2="h" }
    
    The first term does not contain the Column2 attribute.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:32:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:32:20 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-D5X9KaSwsD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |24561
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561
    [Bug 24561] Add a datatables API wrapper
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:32:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:32:20 +0000
    Subject: [Koha-bugs] [Bug 24561] Add a datatables API wrapper
    In-Reply-To: <bug-24561-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24561-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24561-70-dMyievSWhZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30626
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    [Bug 30626] DT REST API wrapper not building the filter query correctly
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:32:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:32:28 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-eNzg6AokCm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30063
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:32:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:32:28 +0000
    Subject: [Koha-bugs] [Bug 30063] Make the main patron search use the
     /patrons REST API route
    In-Reply-To: <bug-30063-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30063-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30063-70-xTciAAswlM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30626
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:34:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:34:54 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-jqvpurkjzx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:34:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:34:58 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-BcVrcfS04N@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134016
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134016&action=edit
    Bug 30626: DT REST API wrapper - Fix general search
    
    The general search query is not built correctly.
    
    Say you have a table with column filters, like the main patron search:
    General filter: henry
    Specific filter on the 'Name' column: h
    
    The generated query will be (= are actually LIKE):
    { Column1="henry" AND Column3="henry", ...} AND { Column2="h" }
    
    The first term does not contain the Column2 attribute.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:35:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:35:02 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-jT0v9e0tjf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134017
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134017&action=edit
    Bug 30626: Fix test
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:36:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:36:11 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-4xayNFdTZJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    We will certainly want to backport this fix. Skip the changes to the selenium
    tests if it does not apply.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:43:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:43:51 +0000
    Subject: [Koha-bugs] [Bug 30328] Add ability to generate barcode with branch
     specific prefix
    In-Reply-To: <bug-30328-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30328-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30328-70-Noa12pc6rs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Failed QA
    
    --- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
    I think the description of the BarcodePrefix preference should say that it is
    used in connection with the autoBarcode preference, and include a link to it
    (and vice versa). For example:
    
    "Define library specific barcode prefixes in YAML format. This defines the
    behavior of the <code><prefix>yyyymm0001</code> option of <a>autoBarcode</a>."
    
    And added to the autoBarcode description, "Define the behavior of the
    <code><prefix>yyyymm0001</code> option using <a>BarcodePrefix</a>."
    
    Should the BarcodePrefix preference provide an example for the syntax which is
    expected? Or perhaps a link to the wiki like OpacHiddenItems has?
    
    Otherwise everything was working well when tested in cataloging.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:47:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:47:44 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-pJ44X4SDL7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Patch doesn't apply         |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:47:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:47:51 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-bDn1a8lj29@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #129770|0                           |1
            is obsolete|                            |
     Attachment #129771|0                           |1
            is obsolete|                            |
     Attachment #129772|0                           |1
            is obsolete|                            |
     Attachment #129773|0                           |1
            is obsolete|                            |
     Attachment #129774|0                           |1
            is obsolete|                            |
     Attachment #129775|0                           |1
            is obsolete|                            |
     Attachment #129776|0                           |1
            is obsolete|                            |
     Attachment #129777|0                           |1
            is obsolete|                            |
     Attachment #129778|0                           |1
            is obsolete|                            |
     Attachment #129779|0                           |1
            is obsolete|                            |
     Attachment #133001|0                           |1
            is obsolete|                            |
     Attachment #133002|0                           |1
            is obsolete|                            |
     Attachment #133003|0                           |1
            is obsolete|                            |
     Attachment #133004|0                           |1
            is obsolete|                            |
     Attachment #133005|0                           |1
            is obsolete|                            |
     Attachment #133006|0                           |1
            is obsolete|                            |
     Attachment #133007|0                           |1
            is obsolete|                            |
     Attachment #133008|0                           |1
            is obsolete|                            |
     Attachment #133009|0                           |1
            is obsolete|                            |
     Attachment #133010|0                           |1
            is obsolete|                            |
     Attachment #133011|0                           |1
            is obsolete|                            |
     Attachment #133012|0                           |1
            is obsolete|                            |
     Attachment #133013|0                           |1
            is obsolete|                            |
     Attachment #133014|0                           |1
            is obsolete|                            |
     Attachment #133015|0                           |1
            is obsolete|                            |
     Attachment #133016|0                           |1
            is obsolete|                            |
     Attachment #133017|0                           |1
            is obsolete|                            |
     Attachment #133018|0                           |1
            is obsolete|                            |
     Attachment #133019|0                           |1
            is obsolete|                            |
     Attachment #133020|0                           |1
            is obsolete|                            |
     Attachment #133021|0                           |1
            is obsolete|                            |
     Attachment #133022|0                           |1
            is obsolete|                            |
     Attachment #133023|0                           |1
            is obsolete|                            |
     Attachment #133024|0                           |1
            is obsolete|                            |
     Attachment #133025|0                           |1
            is obsolete|                            |
     Attachment #133026|0                           |1
            is obsolete|                            |
     Attachment #133027|0                           |1
            is obsolete|                            |
    
    --- Comment #119 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134018
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134018&action=edit
    Bug 29648: Improve existing code
    
    We already have 2 tables that are configurable, on acqui/basket and
    reports/orders_by_budget.
    This patch is modifying a bit the existing code to transfer the
    responsability/logic to the KohaTable constructor instead of the
    template that is creating the object.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:47:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:47:58 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-fIRF3MOLVc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #120 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134019
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134019&action=edit
    Bug 29648: Move NumSavedReports to the table settings
    
    The syspref NumSavedReports can be moved to the table settings config
    Test plan:
    1. Set the syspref to a given value
    2. updatedatabase # execute the atomic update
    3. Go to the table settings page and confirm that the syspref's value
    has been retrieved
    4. Select a specific colonne for the default sort
    5. Go to the report list view and confirm that the "Show X entries" has
    the correct selected value and that the table is sorted as you expect.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:48:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:48:04 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-EWqEBrAw1z@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #121 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134020
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134020&action=edit
    Bug 29648: Add item - broken FIXME
    
    Why don't we have the columns visibility button?
    
    It looks like there is something broken here, why don't we have the
    show/hide columns buttons? The code expects it to be displayed.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:48:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:48:11 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-EeZPAmmO6O@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #122 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134021
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134021&action=edit
    Bug 29648: Duplicate orders view - no change
    
    No change expected here, only removing commented-out code.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:48:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:48:17 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-2AvqJqOHCP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #123 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134022
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134022&action=edit
    Bug 29648: Order search view - normal
    
    "normal" means that we are expecting the table to have the 2 options
    implemented and working.
    You can select "Default display length" and "Default sort order"
    in the "table settings" administration view, then go the the view
    and confirm that the table has the configured values pre-selected.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:48:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:48:23 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-okBMOlZNiv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #124 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134023
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134023&action=edit
    Bug 29648: Late orders view - normal
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:48:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:48:30 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-2xdASAY2j4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #125 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134024
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134024&action=edit
    Bug 29648: Authorised values view
    
    No change is expected on this view as the table is not part of the table
    settings.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:48:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:48:37 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-IqMyx1vf9x@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #126 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134025
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134025&action=edit
    Bug 29648: Libraries administration view - normale
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:48:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:48:43 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-mQJuekQyuL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #127 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134026
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134026&action=edit
    Bug 29648: Patron categories administration view - normal
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:48:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:48:50 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-vDTUN9VErV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #128 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134027
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134027&action=edit
    Bug 29648: Cities administration view - REST API
    
    Here we need to deal with the other DT config (in datatables.js, not
    columns_settings.inc).
    
    Test plan:
    Same as "normal"
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:48:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:48:57 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-aHoFw3dopr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #129 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134028
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134028&action=edit
    Bug 29648: Item types administration view
    
    Set noItemTypeImages and OpacNoItemTypeImages to "No" and confirm
    that the first column (the image) is not displayed. Otherwise test as
    "normal"
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:49:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:49:04 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-1baIYyv7hk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #130 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134029
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134029&action=edit
    Bug 29648: Allow tables_settings.default_display_length to be NULL
    
    We actually want this value to be NULL. If set to NULL and
    default_display_length is not in the yml, then the option will not be
    displayed.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:49:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:49:10 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-LWDA6NP6Nq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #131 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134030
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134030&action=edit
    Bug 29648: DBIC Schema changes
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:49:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:49:17 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-mQ7j2ExTvr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #132 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134031
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134031&action=edit
    Bug 29648: Catalogue detail - no default_display_length
    
    On the acquisition table the sort option is not available as we don't
    offer the ability to selection asc/desc and default to asc.
    We cannot offer default_display_length for those tables.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:49:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:49:23 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-Bk7xQOypVB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #133 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134032
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134032&action=edit
    Bug 29648: Checkout history - normal no sort
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:49:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:49:24 +0000
    Subject: [Koha-bugs] [Bug 30328] Add ability to generate barcode with branch
     specific prefix
    In-Reply-To: <bug-30328-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30328-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30328-70-JrBQvmmvgd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328
    
    --- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
    Also: The BarcodePrefix textarea should be a CodeMirror editor using
    "text/x-yaml" syntax. See OpacHiddenItems in opac.pref for example.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:49:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:49:30 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-hD44Kz7l0v@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #134 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134033
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134033&action=edit
    Bug 29648: Cataloguing Z3950 search - no pagination
    
    Pagination is done server-side
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:49:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:49:39 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-1qlNKul57i@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #135 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134034
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134034&action=edit
    Bug 29648: Overdue list - normal
    
    'stateSave' so need to test on the first try or delete the relevant local
    storage
    entry
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:49:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:49:46 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-BpubuRHUWt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #136 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134035
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134035&action=edit
    Bug 29648: Holds to pull - normal
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:49:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:49:47 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-i1nnc6fZdC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |rel_22_05_candidate
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:49:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:49:53 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-aXnq9VSVUj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #137 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134036
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134036&action=edit
    Bug 29648: Holds ratios - normal but no sort
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:50:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:50:00 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-ODlyPfzX4H@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #138 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134037
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134037&action=edit
    Bug 29648: Holds queue - only sort
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:50:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:50:08 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-6hdeVmZkim@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #139 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134038
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134038&action=edit
    Bug 29648: Course reserve detail - normal
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:50:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:50:13 +0000
    Subject: [Koha-bugs] [Bug 30063] Make the main patron search use the
     /patrons REST API route
    In-Reply-To: <bug-30063-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30063-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30063-70-DeF9BvARZu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|additional_work_needed      |
    
    --- Comment #75 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    (In reply to Martin Renvoize from comment #74)
    > patrons_search.t selenium test is failing and I'm not entirely sure why :(
    
    Fixed on bug 30626.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:50:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:50:15 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-DZIoWIGV5U@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #140 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134039
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134039&action=edit
    Bug 29648: Course reserve list - normal
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:50:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:50:21 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-WYYNzUmKuQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #141 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134040
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134040&action=edit
    Bug 29648: ILL - no change
    
    No change expected here for ILL
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:50:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:50:29 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-tRpMlAn2AN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #142 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134041
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134041&action=edit
    Bug 29648: Patron accounting page - no sort
    
    because of desc
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:50:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:50:30 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-EdzHk81hTu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |rel_22_05_candidate
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:50:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:50:35 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-YJ8TOB3Vy9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #143 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134042
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134042&action=edit
    Bug 29648: Patron page (PatronsPerPage) - no change
    
    PatronsPerPage should be done on a separate bug report, not trivial
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:50:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:50:42 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-kOZTDMNuHX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #144 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134043
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134043&action=edit
    Bug 29648: Payments - normal
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:50:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:50:49 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-si6GSt4SAB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #145 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134044
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134044&action=edit
    Bug 29648: Checkout history - no sort
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:50:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:50:55 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-1XkibjnNkn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #146 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134045
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134045&action=edit
    Bug 29648: patron list table - normal
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:51:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:51:02 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-Mw4HMiS08Q@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #147 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134046
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134046&action=edit
    Bug 29648: Item lost report - no change
    
    hum, there is no sort on this table, so it's displayed like it's coming
    from the controller, but perl code does not sort either.
    This could be improved and we could make it configurable easily
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:51:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:51:09 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-xJ5Sn9TTHf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #148 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134047
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134047&action=edit
    Bug 29648: Subscription detail - no change
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:51:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:51:16 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-wFvYOEjy5u@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #149 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134048
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134048&action=edit
    Bug 29648: Log viewer - no sort
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:51:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:51:22 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-3Zb6fwGask@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #150 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134049
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134049&action=edit
    Bug 29648: Holds history - no sort
    
    because of desc
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:51:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:51:29 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-ONtoQf4oLN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #151 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134050
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134050&action=edit
    Bug 29648: Notice template - only sort
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:51:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:51:37 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-NcAL1sLrzC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #152 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134051
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134051&action=edit
    Bug 29648: Remove default sort order for detail
    
    On the detail view the number of columns changed, we cannot use the
    default sort order here.
    It certainly can be done on a different way but I prefer to postpone it
    for now and see later.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:51:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:51:43 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-ODIPq7iMRd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #153 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134052
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134052&action=edit
    Bug 29648: Upload tool - no sort
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:51:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:51:50 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-Ldp7SnZ7gm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #154 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134053
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134053&action=edit
    Bug 29648: Returns - no change
    
    No change expected here, there is no sort and no paginate possible.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:51:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:51:58 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-JeZEE9zn57@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #155 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134054
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134054&action=edit
    Bug 29648: Fix occurrences of GetColumns
    
    We could add the configuration to these tables as well, but let go first
    but the others (read: feeling lazy right now).
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:55:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:55:50 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-Y9mLTtHfgo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134016|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134055
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134055&action=edit
    Bug 30626: DT REST API wrapper - Fix general search
    
    The general search query is not built correctly.
    
    Say you have a table with column filters, like the main patron search:
    General filter: henry
    Specific filter on the 'Name' column: h
    
    The generated query will be (= are actually LIKE):
    { Column1="henry" AND Column3="henry", ...} AND { Column2="h" }
    
    The first term does not contain the Column2 attribute.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:55:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:55:54 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-uOywSQMSbl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134017|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134056
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134056&action=edit
    Bug 30626: Fix test
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:55:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:55:58 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-6IecaNzydl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134057
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134057&action=edit
    Bug 30626: (QA follow-up) Fix test plan
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:56:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:56:35 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-QZVHiudK1P@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:57:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:57:34 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-rQK5clshhj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    All works well for me in testing (I tried both with the unit test and manually
    testing with relevant data).
    
    I can't entirely remember/work out why we had that line in there in the first
    place the way we did though.. :(.
    
    Signing off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 12:57:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 10:57:56 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-SHMKVVTfa8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |severine.queune at bulac.fr
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 13:06:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 11:06:49 +0000
    Subject: [Koha-bugs] [Bug 30627] New: koha-run-backups may delete the backup
     files after work done
    Message-ID: <bug-30627-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30627
    
                Bug ID: 30627
               Summary: koha-run-backups may delete the backup files after
                        work done
     Change sponsored?: ---
               Product: Koha
               Version: 20.11
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Command-line Utilities
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: mengu at devinim.com.tr
            QA Contact: testopia at bugs.koha-community.org
                    CC: robin at catalyst.net.nz
    
    I've a doubt about the koha-run-backups script that it deletes its backup files
    if the backup destination directory is empty.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 13:07:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 11:07:40 +0000
    Subject: [Koha-bugs] [Bug 30627] koha-run-backups may delete the backup
     files after work done
    In-Reply-To: <bug-30627-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30627-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30627-70-J7kzdzcvXC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30627
    
    Mengu Yazicioglu <mengu at devinim.com.tr> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Version|20.11                       |21.11
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 13:11:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 11:11:50 +0000
    Subject: [Koha-bugs] [Bug 30627] koha-run-backups delete the backup files
     after finished its job without caring days option
    In-Reply-To: <bug-30627-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30627-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30627-70-8OzGk2tT9M@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30627
    
    Mengu Yazicioglu <mengu at devinim.com.tr> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|koha-run-backups may delete |koha-run-backups delete the
                       |the backup files after work |backup files after finished
                       |done                        |its job without caring days
                       |                            |option
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 13:33:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 11:33:46 +0000
    Subject: [Koha-bugs] [Bug 30420] We don't need Koha::Patron::get_overdues
     AND ::overdues
    In-Reply-To: <bug-30420-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30420-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30420-70-PcYGodiy6o@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30420
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 13:33:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 11:33:53 +0000
    Subject: [Koha-bugs] [Bug 30420] We don't need Koha::Patron::get_overdues
     AND ::overdues
    In-Reply-To: <bug-30420-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30420-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30420-70-9aU1o45gJh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30420
    
    --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134058
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134058&action=edit
    Bug 30420: Rename Koha::Patron->get_overdues with ->overdues
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 13:34:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 11:34:53 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-9OKqiXAzZW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 13:34:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 11:34:58 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-gAL4k0pEsE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133684|0                           |1
            is obsolete|                            |
     Attachment #133685|0                           |1
            is obsolete|                            |
    
    --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134059
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134059&action=edit
    Bug 30576: Use DefaultPatronSearchFields in patron search
    
    This patch corrects the handling of the 'Standard' search field in
    patron searches such that it accurately reflects the contents of the
    DefaultPatronSearchFields system preference and falls back to a hard
    coded list instead of always using the hard coded list.
    
    To test:
    1) Empty the contents of DefaultPatronSearchFields systempreference
    2) Perform a patron search from the header search
    3) Inspect the patrons API request and note that we search on the
       default fallback fields of firstname, surname, othernames,
       cardnumber and userid (and some extended attributes which are
       historically hard coded).
    4) Navigate to the memebers-home by clicking the 'Patrons' button from
       the main page
    5) Perform another search using the filters on the left with 'Standard'
       selected.
    6) Note the same list of search fields used as above in the patrons API
       request.
    7) Update the DefaultPatronSearchFields systempreference adding one or
       more borrower fields in a comma delimited list.
    8) Repeat steps 2 -> 6 but this time upon inspecting the API request you
       should find that only the fields in your DefaultPatronSearchFields
       list are searched (along with the hard coded extended attributes
       list).
    9) Signoff
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 13:35:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 11:35:04 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-BBLkmUodtP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134060
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134060&action=edit
    Bug 30576: (follow-up) Corrections to behaviour to reflect unit tests
    
    The unit tests highlighted my original patch didn't cover the full
    preference description.
    
    We now replace the 'standard' option with the fields from the preference
    and we also add those fields as options to the field selection in
    advanced searches.
    
    This patch also adjusts the tests to test for that and reflects the
    expected changes to the number of options displayed in the select boxes.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 13:36:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 11:36:03 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-DDjqYGdCRB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30626
    
    --- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    (In reply to Martin Renvoize from comment #8)
    > Ho.. that last failure is also on master.. I'll fix it on master
    
    Fixed on bug 30626.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 13:36:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 11:36:03 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-mwFUWfEk1b@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30576
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 13:40:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 11:40:39 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-YTLl15YLIH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    (In reply to Martin Renvoize from comment #6)
    > Created attachment 134057 [details] [review]
    > Bug 30626: (QA follow-up) Fix test plan
    
    We won't need that on top of bug 30576.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 13:51:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 11:51:00 +0000
    Subject: [Koha-bugs] [Bug 30627] koha-run-backups delete the backup files
     after finished its job without caring days option
    In-Reply-To: <bug-30627-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30627-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30627-70-pVgCEQGo8s@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30627
    
    --- Comment #1 from Mengu Yazicioglu <mengu at devinim.com.tr> ---
    First findings:
    
    and a correction, if there are some other files in the backup destination
    directory, script also counts them and this makes the problem.
    
    In the remove part of script, sed "s:^$name ... part removes the instance name
    and expects only related backup files, but if somehow there are some other
    files, backups are being deleted
    
    It could be better to find older files with find command maybe.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 13:55:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 11:55:12 +0000
    Subject: [Koha-bugs] [Bug 30607] Enable 'Clear filter' option on DataTables
     Search for patron searches
    In-Reply-To: <bug-30607-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30607-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30607-70-2rB2J0UWJG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30607
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 13:55:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 11:55:17 +0000
    Subject: [Koha-bugs] [Bug 30607] Enable 'Clear filter' option on DataTables
     Search for patron searches
    In-Reply-To: <bug-30607-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30607-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30607-70-wE9IdYY8QE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30607
    
    --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134061
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134061&action=edit
    Bug 30607: Don't overload our default initComplete
    
    We want to keep the default initComplete call to add/remove the
    'disabled' class on the 'Clear filters' link.
    
    Test plan:
    Search for patrons, add something to the general DT search and confirm
    that the 'Clear filters' link can be clicked (ie. is not disabled) when
    the input field is not empty.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 13:55:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 11:55:39 +0000
    Subject: [Koha-bugs] [Bug 30607] Enable 'Clear filter' option on DataTables
     Search for patron searches
    In-Reply-To: <bug-30607-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30607-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30607-70-surCgwTPna@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30607
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                       |ity.org                     |com
               Keywords|                            |rel_22_05_candidate
    
    --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Is there a more elegant way?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 13:59:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 11:59:27 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-SwlBHgy20H@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |andrew at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 14:00:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 12:00:06 +0000
    Subject: [Koha-bugs] [Bug 23775] Claiming a serial issue doesn't create the
     next one
    In-Reply-To: <bug-23775-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23775-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23775-70-Upf2PCJHEu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775
    
    --- Comment #4 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> ---
    Thanks for the feedback, it works fine on my computer. I have changed the test
    plan to be clearer :
    
      > 3)Tick the checkbox of the row where the status is EXPECTED then
      > 4)Click 'Send notification'
      > 5)Notice the status of the row : it is now CLAIMED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 14:02:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 12:02:45 +0000
    Subject: [Koha-bugs] [Bug 22223] Item url double-encode when parameter is an
     encoded URL
    In-Reply-To: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22223-70-jR0LMjDz1b@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22223
    
    --- Comment #39 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    (In reply to Fridolin Somers from comment #38)
    > > This is just a POC
    > No push to master then ?
    
    It *was* a POC, if everybody is happy with the patch I guess you can push it.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 14:03:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 12:03:00 +0000
    Subject: [Koha-bugs] [Bug 23775] Claiming a serial issue doesn't create the
     next one
    In-Reply-To: <bug-23775-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23775-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23775-70-LqcZoEwHxf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133122|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> ---
    Created attachment 134062
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134062&action=edit
    Bug 23775: Claiming a serial issue doesn't create the next one
    
    Whenever we need to generate manually a new serial we go to page
    'serials-edit.pl'. With this patch it is possible to generate a new serial on
    page 'serials.pl'.
    
    Test Plan:
    -- Previously we need a serial which is in EXPECTED status & the Date received
    should not be later than today --
    1)On the intra. Make sure to have at least 1 subscription for a bibliographic
    record & 1 vendor linked
    2)Then Home > Serials > Claims > Claims for <your_vendor_name>
    3)Tick the checkbox of the row where the status is EXPECTED then
    4)Click 'Send notification'
    5)Notice the status of the row : it is now CLAIMED
    6)To verify: Home > Serials > Serial collection information for
    <your_record_name>
    7)Here the status is CLAIMED too but nothing happened around
    8)Apply patch
    9)Repeat from 2) to 6)
    10)The status is still CLAIMED & the new serial with status EXPECTED is freshly
    generated
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 14:03:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 12:03:55 +0000
    Subject: [Koha-bugs] [Bug 30617] [OMNIBUS] We should consistently use
     includes for patron name display
    In-Reply-To: <bug-30617-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30617-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30617-70-ettOWNNtMT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30617
    
    Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |marjorie.barry-vila at collect
                       |                            |o.ca
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 14:12:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 12:12:21 +0000
    Subject: [Koha-bugs] [Bug 30628] New: Batch borrower modifications only
     affect the current page
    Message-ID: <bug-30628-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628
    
                Bug ID: 30628
               Summary: Batch borrower modifications only affect the current
                        page
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: major
              Priority: P5 - low
             Component: Tools
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: nick at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
    
    To recreate:
    1 - Get a list of more than 20 cardnumbers:
        SELECT cardnumber FROM borrowers LIMIT 50
    2 - Enter those cardnumbers into 'Tools-> Batch patron modification' 
    3 - Add a circulation note 'THIS IS A TEST'
    4 - Save
    5 - Note results screen has only 20 entries
    6 - Confirm only 20 patrons affected
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 14:12:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 12:12:29 +0000
    Subject: [Koha-bugs] [Bug 30628] Batch borrower modifications only affect
     the current page
    In-Reply-To: <bug-30628-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30628-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30628-70-2a0O9xfytC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |28014
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28014
    [Bug 28014] Add table settings to batch patron modification
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 14:12:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 12:12:29 +0000
    Subject: [Koha-bugs] [Bug 28014] Add table settings to batch patron
     modification
    In-Reply-To: <bug-28014-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28014-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28014-70-SzYc5myjo7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28014
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30628
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628
    [Bug 30628] Batch borrower modifications only affect the current page
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 14:17:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 12:17:42 +0000
    Subject: [Koha-bugs] [Bug 30136] Add back to top button when scrolling
    In-Reply-To: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30136-70-MZtHoG8Opq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 14:17:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 12:17:47 +0000
    Subject: [Koha-bugs] [Bug 30136] Add back to top button when scrolling
    In-Reply-To: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30136-70-PcvMaqikdy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134011|0                           |1
            is obsolete|                            |
    
    --- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134063
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134063&action=edit
    Bug 30136: Add back to top button to OPAC
    
    Like in many websites, when scrolling down the page make a button appear to go
    back to top.
    This can be very useful specially in search results page.
    
    This patch adds to OPAC using Javascript a button with id "backtotop".
    Button appears when 300 pixels from top are hidden.
    This value may be adapted.
    
    Test plan
    1) Go to OPAC
    2) Perform a search with many results
    3) Scroll down
    => Back to top button appears
    4) Manually scroll back to top
    => Button disappears
    5) Scroll down and click on Back to top button
    => You get to top
    
    Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov>
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 14:17:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 12:17:53 +0000
    Subject: [Koha-bugs] [Bug 30136] Add back to top button when scrolling
    In-Reply-To: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30136-70-d5zepaROht@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134012|0                           |1
            is obsolete|                            |
    
    --- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134064
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134064&action=edit
    Bug 30136: (follow-up) CSS and accessibility update
    
    This patch adds the new CSS to the global CSS file. Rebuild the OPAC CSS
    to test.
    
    The patch also moves the JavaScript for the button from opac-bottom.inc
    into global.js and adds accessibility labels to the generated markup.
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 14:20:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 12:20:07 +0000
    Subject: [Koha-bugs] [Bug 27123] Add messages to batch patrons modification
    In-Reply-To: <bug-27123-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27123-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27123-70-DSRWPiaqIC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132923|0                           |1
            is obsolete|                            |
    
    --- Comment #11 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> ---
    Created attachment 134065
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134065&action=edit
    Bug 27123: Add messages to batch patrons modification
    
    With this patch you can write or delete circulation messages on the batch
    patrons modification form
    
    Test plan:
    1)Go to Home > Tools > Batch patron modification
    2)Write one or more card numbers to access the modification form
    3)Notice the input you can interact with
    4)Apply patch and repeat 1) & 2)
    5)Notice the new input 'Message:' which appeared down the form
    6)Write a message and choose a type (opac or intranet)
    7)Save & notice the new 'Message' column filled up with what you wrote before
    8)To delete: back on the modification form - check the checkbox beside the
    input - save again
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 14:26:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 12:26:58 +0000
    Subject: [Koha-bugs] [Bug 30628] Batch borrower modifications only affect
     the current page
    In-Reply-To: <bug-30628-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30628-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30628-70-ZkQt3SvrRD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628
    
    --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    It's noted on the reports page, that you only send to the batch tools what's
    currently visible - is that the issue you are seeing?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 14:34:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 12:34:09 +0000
    Subject: [Koha-bugs] [Bug 29734] [OMNIBUS] Recalls for Koha
    In-Reply-To: <bug-29734-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29734-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29734-70-XE5faGthEH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |david at davidnind.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 14:47:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 12:47:28 +0000
    Subject: [Koha-bugs] [Bug 25703] AllowItemsOnHoldCheckoutSCO behavior.
    In-Reply-To: <bug-25703-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25703-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25703-70-B3oECjK33w@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25703
    
    Didier Gautheron <didier.gautheron at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |didier.gautheron at biblibre.c
                       |                            |om
             Resolution|---                         |DUPLICATE
                 Status|NEW                         |RESOLVED
    
    --- Comment #1 from Didier Gautheron <didier.gautheron at biblibre.com> ---
    
    
    *** This bug has been marked as a duplicate of bug 23909 ***
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 14:47:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 12:47:28 +0000
    Subject: [Koha-bugs] [Bug 23909] SCO allows to check out items with Waiting
     state if AllowItemsOnHoldCheckoutSCO
    In-Reply-To: <bug-23909-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23909-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23909-70-TvtGVk8Dal@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23909
    
    Didier Gautheron <didier.gautheron at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |eveal at mckinneytexas.org
    
    --- Comment #7 from Didier Gautheron <didier.gautheron at biblibre.com> ---
    *** Bug 25703 has been marked as a duplicate of this bug. ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 14:47:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 12:47:34 +0000
    Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
     effective_name method to patrons
    In-Reply-To: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28633-70-iUxDcgHrYY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Failed QA
    
    --- Comment #50 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Sorting in the patron search results is a little off:
    
    I have:
    
    Katrin Fischer
    Katrina Fischer
    Cait Fischer (where Cait is preferred name)
    
    I think the last should be the first entry?
    
    Otherwise all fixes from last testing appear to be ok.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 14:49:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 12:49:05 +0000
    Subject: [Koha-bugs] [Bug 27123] Add messages to batch patrons modification
    In-Reply-To: <bug-27123-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27123-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27123-70-zWqvHfAWka@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123
    
    --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Hi Jérémy, is this ready for testing again? The sequence of patches doesn't
    appear to be right - or maybe some need to be obsoleted if you squashed?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 15:11:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 13:11:56 +0000
    Subject: [Koha-bugs] [Bug 30628] Batch borrower modifications only affect
     the current page
    In-Reply-To: <bug-30628-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30628-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30628-70-Koee9J2ICa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628
    
    --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
    No, the issue is happening in the batch modification itself
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 15:26:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 13:26:17 +0000
    Subject: [Koha-bugs] [Bug 22490] Some strings in JavaScript files are
     untranslatable
    In-Reply-To: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22490-70-hEdIxQpg1j@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22490
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 15:50:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 13:50:34 +0000
    Subject: [Koha-bugs] [Bug 5316] Limit Z39.50 targets to specific users
    In-Reply-To: <bug-5316-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-5316-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-5316-70-XCHybazMZL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5316
    
    George Williams (NEKLS) <george at nekls.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |george at nekls.org
    
    --- Comment #6 from George Williams (NEKLS) <george at nekls.org> ---
    +1  Great idea
    
    -- 
    You are receiving this mail because:
    You are the QA Contact for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 15:50:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 13:50:58 +0000
    Subject: [Koha-bugs] [Bug 30167] Return soonest renewal date when
     CanBookBeRenewed returns %too_soon
    In-Reply-To: <bug-30167-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30167-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30167-70-bm6DYdvxik@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30167
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |david at davidnind.com
                 Status|Needs Signoff               |Patch doesn't apply
    
    --- Comment #3 from David Nind <david at davidnind.com> ---
    Patch no longer applies 8-(..
    
    git bz apply 30167
    
    Bug 30167 - Return soonest renewal date when CanBookBeRenewed returns %too_soon
    
    131046 - Bug 30167: Return soonest renewal date when renewal is to soon
    131047 - Bug 30167: Use returned renewal date rather than fetching
    
    Apply? [(y)es, (n)o, (i)nteractive] y
    Applying: Bug 30167: Return soonest renewal date when renewal is to soon
    Using index info to reconstruct a base tree...
    M       C4/Circulation.pm
    M       t/db_dependent/Circulation.t
    Falling back to patching base and 3-way merge...
    Auto-merging t/db_dependent/Circulation.t
    CONFLICT (content): Merge conflict in t/db_dependent/Circulation.t
    Auto-merging C4/Circulation.pm
    error: Failed to merge in the changes.
    Patch failed at 0001 Bug 30167: Return soonest renewal date when renewal is to
    soon
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 15:54:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 13:54:24 +0000
    Subject: [Koha-bugs] [Bug 30607] Enable 'Clear filter' option on DataTables
     Search for patron searches
    In-Reply-To: <bug-30607-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30607-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30607-70-nZ06hroovn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30607
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |julian.maurice at biblibre.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 16:06:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 14:06:41 +0000
    Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
     $biblio->metadata->record
    In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29697-70-NhOOQh41aV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Patch doesn't apply         |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 16:06:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 14:06:47 +0000
    Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
     $biblio->metadata->record
    In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29697-70-1mixBszh1R@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131868|0                           |1
            is obsolete|                            |
     Attachment #131869|0                           |1
            is obsolete|                            |
     Attachment #131870|0                           |1
            is obsolete|                            |
     Attachment #131871|0                           |1
            is obsolete|                            |
     Attachment #131872|0                           |1
            is obsolete|                            |
     Attachment #131873|0                           |1
            is obsolete|                            |
    
    --- Comment #24 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134066
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134066&action=edit
    Bug 29697: Special case - opac not needed
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 16:06:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 14:06:54 +0000
    Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
     $biblio->metadata->record
    In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29697-70-WmZtQ5Ayue@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
    
    --- Comment #25 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134067
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134067&action=edit
    Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 16:07:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 14:07:00 +0000
    Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
     $biblio->metadata->record
    In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29697-70-GHM7ZTWzIH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
    
    --- Comment #26 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134068
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134068&action=edit
    Bug 29697: Remove GetHiddenItemnumbers
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 16:07:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 14:07:06 +0000
    Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
     $biblio->metadata->record
    In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29697-70-wsKTWlXIYd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
    
    --- Comment #27 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134069
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134069&action=edit
    Bug 29697: Use flag embed_items
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 16:07:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 14:07:12 +0000
    Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
     $biblio->metadata->record
    In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29697-70-7AfxVMVRdu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
    
    --- Comment #28 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134070
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134070&action=edit
    Bug 29697: Fix tests
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 16:07:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 14:07:18 +0000
    Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
     $biblio->metadata->record
    In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29697-70-tVBIiSaTP1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
    
    --- Comment #29 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134071
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134071&action=edit
    Bug 29697: Deal with the degraded view in detail.pl
    
    In detail.pl we must provide a degraded view with an error message about
    invalid MARC::Record.
    We are then forced to reproduce the GetMarcBiblio behaviour and call
    StripNonXmlChars on the MARC::XML
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 16:07:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 14:07:52 +0000
    Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
     $biblio->metadata->record
    In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29697-70-LW6cK7QZP9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 16:24:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 14:24:06 +0000
    Subject: [Koha-bugs] [Bug 22490] Some strings in JavaScript files are
     untranslatable
    In-Reply-To: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22490-70-CcueQwrKuJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22490
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133906|0                           |1
            is obsolete|                            |
    
    --- Comment #9 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> ---
    Created attachment 134072
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134072&action=edit
    Bug 22490: Some strings in JavaScript files are untranslatable
    
    This patch updates the translation functions of the strings in Javascript files
    
    Test Plan:
    1) Find a string in a popup or from a Javascript file who is still not
    translated
    or
    1) Home > Administration > Authority types
    2) Make sure to have at least one Authority type saved
    3) Click on Action > Import
    4) Import button without adding any file to trigger the popup
    5) The string inside the popup appears without translation
    6) Apply patch and repeat from 3) to 5) : now the string is translated
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 16:45:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 14:45:41 +0000
    Subject: [Koha-bugs] [Bug 30622] Search for cardnumber needs to go directly
     to patron record when placing a hold
    In-Reply-To: <bug-30622-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30622-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30622-70-Aypsn22U0y@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com
               Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                       |ity.org                     |com
               Keywords|                            |rel_22_05_candidate
                 Status|NEW                         |ASSIGNED
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 16:47:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 14:47:04 +0000
    Subject: [Koha-bugs] [Bug 30622] Search for cardnumber needs to go directly
     to patron record when placing a hold
    In-Reply-To: <bug-30622-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30622-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30622-70-OowyLc737j@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 16:47:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 14:47:08 +0000
    Subject: [Koha-bugs] [Bug 24001] Cannot edit card template
    In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24001-70-uX10t3zv29@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 16:47:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 14:47:09 +0000
    Subject: [Koha-bugs] [Bug 30622] Search for cardnumber needs to go directly
     to patron record when placing a hold
    In-Reply-To: <bug-30622-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30622-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30622-70-YlCvYbWy7N@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622
    
    --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134073
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134073&action=edit
    Bug 30622: Patron search when placing hold should redirect if cardnumber is
    entered
    
    When search a patron for placing a hold, if a cardnumber is entered we
    should pick the patron and use it, instead of display the table result.
    
    This was a regression caused by bug 30063.
    
    Test plan:
    - Place a hold on anything in staff
    - Search for 42 or any other existing cardnumber in your database
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 16:47:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 14:47:14 +0000
    Subject: [Koha-bugs] [Bug 24001] Cannot edit card template
    In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24001-70-1i9Yfpfw7a@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131494|0                           |1
            is obsolete|                            |
    
    --- Comment #48 from David Nind <david at davidnind.com> ---
    Created attachment 134074
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134074&action=edit
    Bug 24001: Fix patron card template edition
    
    Error when saving Patron card Template:
    Can't bless non-reference value at
    /home/vagrant/kohaclone/C4/Creators/Profile.pm line 89
    
    This is caused by the profile dropdown offering invalid choices and is
    fixed by adding a filter to limit options to creator = 'Patroncards'.
    The UI already handles the case where no valid profile is avaiable.
    
    Signed-off-by: Alexis Ripetti <alexis.ripetti at inLibro.com>
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 16:47:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 14:47:20 +0000
    Subject: [Koha-bugs] [Bug 24001] Cannot edit card template
    In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24001-70-WIIk0jS045@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131495|0                           |1
            is obsolete|                            |
    
    --- Comment #49 from David Nind <david at davidnind.com> ---
    Created attachment 134075
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134075&action=edit
    Bug 24001: Fix Card template/rpinter profile creation and edit
    
    This patch adjusts the template/profiles to use the default of '0'
    This should probably be NULL, and the columns foreign keys, this code
    could use a further rewrite, but this should fix a long standing bug
    
    To test:
     1 - Using the fresh install, with all the sample data.
     2 - Go to Home › Tools › Patron card creator › Templates
     3 - New > Card template
     4 - Save
     5 - Error: DBD::mysql::st execute failed: Incorrect integer value: '' for
    column 'profile_id' at row 1
     6 - Edit an existing template
     7 - Save
     8 - Error: Can't bless non-reference value at
    /kohadevbox/koha/C4/Creators/Profile.pm line 89
     9 - Create a new 'Printer profile'
    10 - Save
    11 - Error: DBD::mysql::st execute failed: Incorrect integer value: '' for
    column 'template_id' at row 1
    12 - Apply the attached patch.
    13 - Verify you can create a new 'Card template' and 'Printer profile' with no
    errors
    14 - Verify you can edit and save both of the newly created objects above
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 16:47:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 14:47:40 +0000
    Subject: [Koha-bugs] [Bug 30622] Search for cardnumber needs to go directly
     to patron record when placing a hold
    In-Reply-To: <bug-30622-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30622-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30622-70-OOBKgyFmOB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622
    
    --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Should this behaviour be applied to some other patron searches?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 16:47:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 14:47:54 +0000
    Subject: [Koha-bugs] [Bug 30622] Search for cardnumber needs to go directly
     to patron record when placing a hold
    In-Reply-To: <bug-30622-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30622-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30622-70-mQiq8GljUi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com, tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 16:49:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 14:49:40 +0000
    Subject: [Koha-bugs] [Bug 30622] Search for cardnumber needs to go directly
     to patron record when placing a hold
    In-Reply-To: <bug-30622-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30622-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30622-70-1fbKVaVrkr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622
    
    --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Can you give an example? I could test if it's a regression with 20.11 or so.
    
    But my first reaction would be yes. 
    
    An exact match on cardnumber or userid should open the patron record directly.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 16:50:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 14:50:02 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-up23iCEOQo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |additional_work_needed
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 16:54:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 14:54:23 +0000
    Subject: [Koha-bugs] [Bug 24001] Cannot edit card template
    In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24001-70-Le4F2PpNUm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
      Text to go in the|                            |This fixes errors that
          release notes|                            |caused creating and editing
                       |                            |patron card templates and
                       |                            |printer profiles to fail.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:04:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:04:53 +0000
    Subject: [Koha-bugs] [Bug 28446] Fix encoding of OverDrive content on Your
     summary, OverDrive Account
    In-Reply-To: <bug-28446-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28446-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28446-70-hzKvm7IQ46@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28446
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Patch doesn't apply
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:12:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:12:42 +0000
    Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through stage
     MARC record import
    In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22785-70-hiJWjEcnQl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    
    --- Comment #75 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    I still have some strange issues here running the QA script. (see comment #63)
    
    Could someone else please take over from here?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:13:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:13:25 +0000
    Subject: [Koha-bugs] [Bug 28555] Improve logging for overdue_notices.pl
    In-Reply-To: <bug-28555-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28555-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28555-70-PtuHiHLzMF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28555
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #121855|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
    Created attachment 134076
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134076&action=edit
    Bug 28555: Improve logging for overdue_notices.pl
    
    Currenlty the output with -v from overdue_notices is a bit overwhelming and
    hard to parse
    
    I do a few things here:
    1 - Only show SQL if verbose > 1
    2 - Add some separators to make it more readab;e
    3 - Remove some redundant messages with branchcode and borrowernumber
    
    To test:
    1: perl misc/cronjobs/overdue_notices.pl -v
    2: Notice you get a LOT of information all smushed together
    3: Apply patch
    4: perl misc/cronjobs/overdue_notices.pl -v
    5: Less info, and easier to read
    6: perl misc/cronjobs/overdue_notices.pl -v -v
    7: All the info, but nicer to read
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:13:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:13:54 +0000
    Subject: [Koha-bugs] [Bug 28555] Improve logging for overdue_notices.pl
    In-Reply-To: <bug-28555-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28555-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28555-70-wyhi55u8TL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28555
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lucas at bywatersolutions.com
    
    --- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> ---
    rebased for current master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:16:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:16:50 +0000
    Subject: [Koha-bugs] [Bug 28657] Expand branches.branchip to allow for
     multiple space separated ip ranges
    In-Reply-To: <bug-28657-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28657-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28657-70-zk2ATXKFSN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28657
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Patch doesn't apply
                     CC|                            |lucas at bywatersolutions.com
    
    --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
    Hi Micheal,
    
    This patchset no longer applies cleanly to current master. Can you rebase it? 
    
    Also, would it be possible to include a test plan?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:18:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:18:25 +0000
    Subject: [Koha-bugs] [Bug 30629] New: <span> in title of patron card creator
     template needs to be removed
    Message-ID: <bug-30629-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629
    
                Bug ID: 30629
               Summary: <span> in title of patron card creator template needs
                        to be removed
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Templates
              Assignee: oleonard at myacpl.org
              Reporter: katrin.fischer at bsz-bw.de
            QA Contact: testopia at bugs.koha-community.org
    
    <title> elements are not allowed to have <span> elements, they show as such in
    the browser tab.
    
    There is a wrong span in the template for:
    /cgi-bin/koha/patroncards/manage.pl?card_element=template
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:19:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:19:06 +0000
    Subject: [Koha-bugs] [Bug 28658] With SearchMyLibraryFirst if library isn't
     set for the opac, try to guess it by checking branchip
    In-Reply-To: <bug-28658-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28658-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28658-70-eFXCKtebFM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |BLOCKED
                     CC|                            |lucas at bywatersolutions.com
    
    --- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> ---
    Hi Micheal,
    
    The dependency for this bug, Bug 28657, no longer applies cleanly to master.
    Therefore I am going to set this one to blocked until 28657 is rebased.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:21:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:21:15 +0000
    Subject: [Koha-bugs] [Bug 28647] administration_tasks.t is failing randomly
    In-Reply-To: <bug-28647-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28647-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28647-70-5FuczYnRwS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28647
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Patch doesn't apply
                     CC|                            |lucas at bywatersolutions.com
    
    --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> ---
    Sadly this no longer applies to current master.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:21:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:21:44 +0000
    Subject: [Koha-bugs] [Bug 24001] Cannot edit card template
    In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24001-70-f8YUPu39by@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134074|0                           |1
            is obsolete|                            |
    
    --- Comment #50 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134077
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134077&action=edit
    Bug 24001: Fix patron card template edition
    
    Error when saving Patron card Template:
    Can't bless non-reference value at
    /home/vagrant/kohaclone/C4/Creators/Profile.pm line 89
    
    This is caused by the profile dropdown offering invalid choices and is
    fixed by adding a filter to limit options to creator = 'Patroncards'.
    The UI already handles the case where no valid profile is avaiable.
    
    Signed-off-by: Alexis Ripetti <alexis.ripetti at inLibro.com>
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:21:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:21:49 +0000
    Subject: [Koha-bugs] [Bug 24001] Cannot edit card template
    In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24001-70-JcyklLEiMw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134075|0                           |1
            is obsolete|                            |
    
    --- Comment #51 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134078
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134078&action=edit
    Bug 24001: Fix Card template/rpinter profile creation and edit
    
    This patch adjusts the template/profiles to use the default of '0'
    This should probably be NULL, and the columns foreign keys, this code
    could use a further rewrite, but this should fix a long standing bug
    
    To test:
     1 - Using the fresh install, with all the sample data.
     2 - Go to Home › Tools › Patron card creator › Templates
     3 - New > Card template
     4 - Save
     5 - Error: DBD::mysql::st execute failed: Incorrect integer value: '' for
    column 'profile_id' at row 1
     6 - Edit an existing template
     7 - Save
     8 - Error: Can't bless non-reference value at
    /kohadevbox/koha/C4/Creators/Profile.pm line 89
     9 - Create a new 'Printer profile'
    10 - Save
    11 - Error: DBD::mysql::st execute failed: Incorrect integer value: '' for
    column 'template_id' at row 1
    12 - Apply the attached patch.
    13 - Verify you can create a new 'Card template' and 'Printer profile' with no
    errors
    14 - Verify you can edit and save both of the newly created objects above
    
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:22:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:22:49 +0000
    Subject: [Koha-bugs] [Bug 24001] Cannot edit card template
    In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24001-70-aXj2gnCuLK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    --- Comment #52 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Looking good and fixes the issue.. no QA script highlights so Passing QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:23:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:23:23 +0000
    Subject: [Koha-bugs] [Bug 28642] Add IndependentBranches syspref to hide
     other items and libraries
    In-Reply-To: <bug-28642-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28642-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28642-70-MMig31lMi3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28642
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Patch doesn't apply
                     CC|                            |lucas at bywatersolutions.com
    
    --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> ---
    This patchset no longer applies cleanly to current master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:24:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:24:22 +0000
    Subject: [Koha-bugs] [Bug 30420] We don't need Koha::Patron::get_overdues
     AND ::overdues
    In-Reply-To: <bug-30420-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30420-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30420-70-tAGx1ezrxc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30420
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134058|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134079
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134079&action=edit
    Bug 30420: Rename Koha::Patron->get_overdues with ->overdues
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:24:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:24:48 +0000
    Subject: [Koha-bugs] [Bug 24001] Cannot edit card template
    In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24001-70-qCGOY6VYJB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134077|0                           |1
            is obsolete|                            |
    
    --- Comment #53 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134080
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134080&action=edit
    Bug 24001: Fix patron card template edition
    
    Error when saving Patron card Template:
    Can't bless non-reference value at
    /home/vagrant/kohaclone/C4/Creators/Profile.pm line 89
    
    This is caused by the profile dropdown offering invalid choices and is
    fixed by adding a filter to limit options to creator = 'Patroncards'.
    The UI already handles the case where no valid profile is avaiable.
    
    Signed-off-by: Alexis Ripetti <alexis.ripetti at inLibro.com>
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    https://bugs.koha-community.org/show_bug.cgi?id=30373
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:24:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:24:53 +0000
    Subject: [Koha-bugs] [Bug 30420] We don't need Koha::Patron::get_overdues
     AND ::overdues
    In-Reply-To: <bug-30420-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30420-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30420-70-pKhnx47hTp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30420
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Thanks for the quick move here.. straight QAing.. no regressions, all cases
    caught..
    
    Passing QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:24:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:24:55 +0000
    Subject: [Koha-bugs] [Bug 24001] Cannot edit card template
    In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24001-70-AhYuq2h8Ou@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134078|0                           |1
            is obsolete|                            |
    
    --- Comment #54 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134081
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134081&action=edit
    Bug 24001: Fix Card template/rpinter profile creation and edit
    
    This patch adjusts the template/profiles to use the default of '0'
    This should probably be NULL, and the columns foreign keys, this code
    could use a further rewrite, but this should fix a long standing bug
    
    To test:
     1 - Using the fresh install, with all the sample data.
     2 - Go to Home › Tools › Patron card creator › Templates
     3 - New > Card template
     4 - Save
     5 - Error: DBD::mysql::st execute failed: Incorrect integer value: '' for
    column 'profile_id' at row 1
     6 - Edit an existing template
     7 - Save
     8 - Error: Can't bless non-reference value at
    /kohadevbox/koha/C4/Creators/Profile.pm line 89
     9 - Create a new 'Printer profile'
    10 - Save
    11 - Error: DBD::mysql::st execute failed: Incorrect integer value: '' for
    column 'template_id' at row 1
    12 - Apply the attached patch.
    13 - Verify you can create a new 'Card template' and 'Printer profile' with no
    errors
    14 - Verify you can edit and save both of the newly created objects above
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    https://bugs.koha-community.org/show_bug.cgi?id=30373
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:24:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:24:59 +0000
    Subject: [Koha-bugs] [Bug 30420] We don't need Koha::Patron::get_overdues
     AND ::overdues
    In-Reply-To: <bug-30420-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30420-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30420-70-pavVkzbu87@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30420
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:25:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:25:05 +0000
    Subject: [Koha-bugs] [Bug 30420] We don't need Koha::Patron::get_overdues
     AND ::overdues
    In-Reply-To: <bug-30420-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30420-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30420-70-zEnjo4v6bz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30420
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:28:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:28:09 +0000
    Subject: [Koha-bugs] [Bug 30630] New: Checking in a waiting hold at another
     branch \ when
    Message-ID: <bug-30630-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630
    
                Bug ID: 30630
               Summary: Checking in a waiting hold at another branch \ when
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: major
              Priority: P5 - low
             Component: Hold requests
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: nick at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:28:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:28:23 +0000
    Subject: [Koha-bugs] [Bug 30622] Search for cardnumber needs to go directly
     to patron record when placing a hold
    In-Reply-To: <bug-30622-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30622-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30622-70-dhb6veYrko@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622
    
    --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    (In reply to Katrin Fischer from comment #3)
    > Can you give an example? I could test if it's a regression with 20.11 or so.
    > 
    > But my first reaction would be yes. 
    > 
    > An exact match on cardnumber or userid should open the patron record
    > directly.
    
    An example of what? Of another patron search?
    Could be guarantor, user for funds or suggestion, etc.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:29:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:29:23 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-QL10Aqyygs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30626
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    [Bug 30626] DT REST API wrapper not building the filter query correctly
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:29:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:29:23 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-gGppCaCdRc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30576
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    [Bug 30576] DefaultPatronSearchFields no longer takes effect
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:29:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:29:37 +0000
    Subject: [Koha-bugs] [Bug 30631] New: Show list of existing printer profiles
     when creating a new patron card template
    Message-ID: <bug-30631-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30631
    
                Bug ID: 30631
               Summary: Show list of existing printer profiles when creating a
                        new patron card template
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Label/patron card printing
              Assignee: cnighswonger at foundations.edu
              Reporter: katrin.fischer at bsz-bw.de
            QA Contact: testopia at bugs.koha-community.org
    
    This is linked to the discussion on bug 24001. 
    
    To test:
    - Go to tools > patron card creator
    - Create new card template
    - You'll see a link "define new printer profile"
    - Don't save, create a printer profile first
    - Try again - you will still see the link, but no pull down of existing
    profiles
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:29:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:29:49 +0000
    Subject: [Koha-bugs] [Bug 30631] Show list of existing printer profiles when
     creating a new patron card template
    In-Reply-To: <bug-30631-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30631-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30631-70-pftBJDRGyJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30631
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=24001
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:29:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:29:49 +0000
    Subject: [Koha-bugs] [Bug 24001] Cannot edit card template
    In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24001-70-QLZb78qcjz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30631
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:31:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:31:27 +0000
    Subject: [Koha-bugs] [Bug 30630] Checking in a waiting hold at another
     branch when HoldsAutoFill is enabled causes errors
    In-Reply-To: <bug-30630-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30630-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30630-70-hcrBV4JbNV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Checking in a waiting hold  |Checking in a waiting hold
                       |at another branch \ when    |at another branch when
                       |                            |HoldsAutoFill is enabled
                       |                            |causes errors
             Depends on|                            |23070
    
    --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
    To recreate:
    1 - Enable HoldsAutoFill
    2 - Place a title level hold
    3 - Check in an item and confirm hold
    4 - Switch to another branch
    5 - Checkin the item, get an error:
    Can't call method "biblionumber" on an undefined value at
    /kohadevbox/koha/C4/Reserves.pm line 1577.
     at /kohadevbox/koha/C4/Reserves.pm line 1576
    6- This causes lingering issues because the hold is now in-transit but has no
    itemnumber
    
    Root seems to be in circ/returns.pl:
    477         ModReserveAffect( $reserve->{itemnumber},
    $reserve->{borrowernumber}, $diffBranchSend, $reserve->{reserve_    id},
    $desk_id );
    
    
    RevertWaitingStatus has already removed the itemnumber from the hold, passing
    $itemnumber (from scanned item) should work, as it will reattach the hold to
    the item
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070
    [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:31:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:31:27 +0000
    Subject: [Koha-bugs] [Bug 23070] Use Koha::Hold in
     C4::Reserves::RevertWaitingStatus
    In-Reply-To: <bug-23070-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23070-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23070-70-H9yW9TFy3y@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30630
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630
    [Bug 30630] Checking in a waiting hold at another branch when HoldsAutoFill is
    enabled causes errors
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:32:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:32:37 +0000
    Subject: [Koha-bugs] [Bug 28995] Add --added_after to writeoff_debts.pl
    In-Reply-To: <bug-28995-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28995-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28995-70-iHKTEBCRMc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28995
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lucas at bywatersolutions.com
    
    --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
    Martin, this still applies cleanly and seems to work for me. Do you have a test
    plan so I can sign it off?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:34:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:34:47 +0000
    Subject: [Koha-bugs] [Bug 24001] Cannot edit card template
    In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24001-70-bN5IEOr6kx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
    
    --- Comment #55 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Agreeing with Martin, sorry, we overlapped!
    
    I filed 2 new bugs:
    
    Bug 30629 - <span> in title of patron card creator template needs to be removed
    Bug 30631 - Show list of existing printer profiles when creating a new patron
    card template
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:44:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:44:20 +0000
    Subject: [Koha-bugs] [Bug 30167] Return soonest renewal date when
     CanBookBeRenewed returns %too_soon
    In-Reply-To: <bug-30167-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30167-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30167-70-tfXq2uBmDt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30167
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Patch doesn't apply         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:44:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:44:24 +0000
    Subject: [Koha-bugs] [Bug 30167] Return soonest renewal date when
     CanBookBeRenewed returns %too_soon
    In-Reply-To: <bug-30167-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30167-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30167-70-ABsJPIisor@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30167
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131046|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134082
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134082&action=edit
    Bug 30167: Return soonest renewal date when renewal is to soon
    
    This patch adds an 'info' return param to CanBookBeRenewed and passes
    the soonest renewal date when returning too_soon errors
    
    To test:
    1 - prove -v t/db_dependent/Circulation.t
    
    Fix whitespace
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:44:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:44:28 +0000
    Subject: [Koha-bugs] [Bug 30167] Return soonest renewal date when
     CanBookBeRenewed returns %too_soon
    In-Reply-To: <bug-30167-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30167-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30167-70-cgFyvRH0bk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30167
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131047|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134083
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134083&action=edit
    Bug 30167: Use returned renewal date rather than fetching
    
    This patch updates the three scripts that fetched the soonest renewal date
    to use the return from CanBookBeRenewed
    
    To test:
    1 - Set a circulation rule with a 'no renewal before' set to 3, loan length set
    to 5
    2 - Check out an item to a patron that uses this rule
    3 - Verify the checkouts for the patron show the correct 'No renewal before'
    date
    4 - Sign in to the patron's opac account
    5 - Verify the item shows it cannot be renewed, and shows the correct date
    6 - Go to Circulation->Renew
    7 - Attempt to renew using barcode
    8 - Confirm error shows the soonest renewal date
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:46:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:46:04 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-AoLvXYlTXh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134059|0                           |1
            is obsolete|                            |
    
    --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134084
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134084&action=edit
    Bug 30576: Use DefaultPatronSearchFields in patron search
    
    This patch corrects the handling of the 'Standard' search field in
    patron searches such that it accurately reflects the contents of the
    DefaultPatronSearchFields system preference and falls back to a hard
    coded list instead of always using the hard coded list.
    
    To test:
    1) Empty the contents of DefaultPatronSearchFields systempreference
    2) Perform a patron search from the header search
    3) Inspect the patrons API request and note that we search on the
       default fallback fields of firstname, surname, othernames,
       cardnumber and userid (and some extended attributes which are
       historically hard coded).
    4) Navigate to the memebers-home by clicking the 'Patrons' button from
       the main page
    5) Perform another search using the filters on the left with 'Standard'
       selected.
    6) Note the same list of search fields used as above in the patrons API
       request.
    7) Update the DefaultPatronSearchFields systempreference adding one or
       more borrower fields in a comma delimited list.
    8) Repeat steps 2 -> 6 but this time upon inspecting the API request you
       should find that only the fields in your DefaultPatronSearchFields
       list are searched (along with the hard coded extended attributes
       list).
    9) Signoff
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:46:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:46:08 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-gzSPQYOydK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134060|0                           |1
            is obsolete|                            |
    
    --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134085
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134085&action=edit
    Bug 30576: (follow-up) Corrections to behaviour to reflect unit tests
    
    The unit tests highlighted my original patch didn't cover the full
    preference description.
    
    We now replace the 'standard' option with the fields from the preference
    and we also add those fields as options to the field selection in
    advanced searches.
    
    This patch also adjusts the tests to test for that and reflects the
    expected changes to the number of options displayed in the select boxes.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:46:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:46:41 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-RdjtZZvLsB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Tiny rebase after setting dependencies to make sure these two are pushed in
    order :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:50:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:50:43 +0000
    Subject: [Koha-bugs] [Bug 28995] Add --added_after to writeoff_debts.pl
    In-Reply-To: <bug-28995-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28995-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28995-70-EEmJl4WpZw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28995
    
    --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Hmm, I was hoping Magnus would SO as he asked for the feature.. 
    
    >From memory, it would be to add some debts to a patron record.. adapt the
    `date` (i.e when the charge was added) field of those charges to a date in the
    past and then run this script with the --added_after option with a date after
    the date you just set and check the lines remain unchanged.. then run again
    passing a date before the date you added above and this time the lines should
    have been written off.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 17:51:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 15:51:35 +0000
    Subject: [Koha-bugs] [Bug 30622] Search for cardnumber needs to go directly
     to patron record when placing a hold
    In-Reply-To: <bug-30622-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30622-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30622-70-orUu9pntM1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622
    
    --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Hi,
    
    I have done some testing on an older (20.11.x) version:
    
    Cardnumbers for testing:
    A
    A1
    A2
    
    1) Patron search: A
    A opens directly
    
    2) Acq > User to notify on receive
    A shows only one result
    
    Tried something else:
    AA
    AA2
    AA3
    
    AA = 1 result
    A = 3 results
    So it seems to limit when exact match. But then you need to click the single
    result.
    
    3) Place hold
    Searching for AA selects the user directly.
    
    So it seems the behavior was a little different between searches before, but it
    should certainly be fixed for place hold.
    
    
    Note: it only seems to work for cardnumber, not for userid. But I think this is
    ok, you are more likely to scan the card and expect a direct link than when
    searching for userid. Also userid might be more likely to be more uniqe. While
    sequential cardnumbers generated with autoMemberNum could lead to a long list
    of possible candidates quicky (especially if you started with 1).
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:08:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:08:08 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-yjFvoJ4GNq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134018|0                           |1
            is obsolete|                            |
    
    --- Comment #156 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134086
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134086&action=edit
    Bug 29648: Improve existing code
    
    We already have 2 tables that are configurable, on acqui/basket and
    reports/orders_by_budget.
    This patch is modifying a bit the existing code to transfer the
    responsability/logic to the KohaTable constructor instead of the
    template that is creating the object.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:08:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:08:15 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-vTzEgriJ32@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134019|0                           |1
            is obsolete|                            |
    
    --- Comment #157 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134087
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134087&action=edit
    Bug 29648: Move NumSavedReports to the table settings
    
    The syspref NumSavedReports can be moved to the table settings config
    Test plan:
    1. Set the syspref to a given value
    2. updatedatabase # execute the atomic update
    3. Go to the table settings page and confirm that the syspref's value
    has been retrieved
    4. Select a specific colonne for the default sort
    5. Go to the report list view and confirm that the "Show X entries" has
    the correct selected value and that the table is sorted as you expect.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:08:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:08:21 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-gO75jNbl8d@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134020|0                           |1
            is obsolete|                            |
    
    --- Comment #158 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134088
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134088&action=edit
    Bug 29648: Add item - broken FIXME
    
    Why don't we have the columns visibility button?
    
    It looks like there is something broken here, why don't we have the
    show/hide columns buttons? The code expects it to be displayed.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:08:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:08:27 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-KtD7gedmiG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134021|0                           |1
            is obsolete|                            |
    
    --- Comment #159 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134089
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134089&action=edit
    Bug 29648: Duplicate orders view - no change
    
    No change expected here, only removing commented-out code.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:08:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:08:34 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-RNu7tdrO6D@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134022|0                           |1
            is obsolete|                            |
    
    --- Comment #160 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134090
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134090&action=edit
    Bug 29648: Order search view - normal
    
    "normal" means that we are expecting the table to have the 2 options
    implemented and working.
    You can select "Default display length" and "Default sort order"
    in the "table settings" administration view, then go the the view
    and confirm that the table has the configured values pre-selected.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:08:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:08:40 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-pVsuzDELhg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134023|0                           |1
            is obsolete|                            |
    
    --- Comment #161 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134091
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134091&action=edit
    Bug 29648: Late orders view - normal
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:08:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:08:45 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-U9HV13DJRd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134024|0                           |1
            is obsolete|                            |
    
    --- Comment #162 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134092
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134092&action=edit
    Bug 29648: Authorised values view
    
    No change is expected on this view as the table is not part of the table
    settings.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:08:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:08:52 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-m6pApb92IE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134025|0                           |1
            is obsolete|                            |
    
    --- Comment #163 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134093
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134093&action=edit
    Bug 29648: Libraries administration view - normale
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:08:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:08:58 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-J4z2OHgfeM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134026|0                           |1
            is obsolete|                            |
    
    --- Comment #164 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134094
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134094&action=edit
    Bug 29648: Patron categories administration view - normal
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:09:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:09:05 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-E5iFO5vQ84@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134027|0                           |1
            is obsolete|                            |
    
    --- Comment #165 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134095
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134095&action=edit
    Bug 29648: Cities administration view - REST API
    
    Here we need to deal with the other DT config (in datatables.js, not
    columns_settings.inc).
    
    Test plan:
    Same as "normal"
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:09:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:09:12 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-tgnodhDmvz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134028|0                           |1
            is obsolete|                            |
    
    --- Comment #166 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134096
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134096&action=edit
    Bug 29648: Item types administration view
    
    Set noItemTypeImages and OpacNoItemTypeImages to "No" and confirm
    that the first column (the image) is not displayed. Otherwise test as
    "normal"
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:09:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:09:18 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-NZlf9hSugG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134029|0                           |1
            is obsolete|                            |
    
    --- Comment #167 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134097
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134097&action=edit
    Bug 29648: Allow tables_settings.default_display_length to be NULL
    
    We actually want this value to be NULL. If set to NULL and
    default_display_length is not in the yml, then the option will not be
    displayed.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:09:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:09:26 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-CPkSf5iD03@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134030|0                           |1
            is obsolete|                            |
    
    --- Comment #168 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134098
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134098&action=edit
    Bug 29648: DBIC Schema changes
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:09:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:09:32 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-jVjFBGeERU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134031|0                           |1
            is obsolete|                            |
    
    --- Comment #169 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134099
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134099&action=edit
    Bug 29648: Catalogue detail - no default_display_length
    
    On the acquisition table the sort option is not available as we don't
    offer the ability to selection asc/desc and default to asc.
    We cannot offer default_display_length for those tables.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:09:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:09:41 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-fZDNtgyHzq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134032|0                           |1
            is obsolete|                            |
    
    --- Comment #170 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134100
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134100&action=edit
    Bug 29648: Checkout history - normal no sort
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:09:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:09:48 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-1puHuuSArc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134033|0                           |1
            is obsolete|                            |
    
    --- Comment #171 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134101
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134101&action=edit
    Bug 29648: Cataloguing Z3950 search - no pagination
    
    Pagination is done server-side
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:09:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:09:54 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-GmJqUdpbTL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134034|0                           |1
            is obsolete|                            |
    
    --- Comment #172 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134102
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134102&action=edit
    Bug 29648: Overdue list - normal
    
    'stateSave' so need to test on the first try or delete the relevant local
    storage
    entry
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:10:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:10:01 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-1ETkTLly6L@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134035|0                           |1
            is obsolete|                            |
    
    --- Comment #173 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134103
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134103&action=edit
    Bug 29648: Holds to pull - normal
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:10:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:10:09 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-WjFxf5Ku5A@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134036|0                           |1
            is obsolete|                            |
    
    --- Comment #174 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134104
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134104&action=edit
    Bug 29648: Holds ratios - normal but no sort
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:10:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:10:16 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-gre607k3wH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134037|0                           |1
            is obsolete|                            |
    
    --- Comment #175 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134105
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134105&action=edit
    Bug 29648: Holds queue - only sort
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:10:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:10:23 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-Otrr3yiwix@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134038|0                           |1
            is obsolete|                            |
    
    --- Comment #176 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134106
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134106&action=edit
    Bug 29648: Course reserve detail - normal
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:10:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:10:30 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-lpWIff9bsP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134039|0                           |1
            is obsolete|                            |
    
    --- Comment #177 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134107
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134107&action=edit
    Bug 29648: Course reserve list - normal
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:10:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:10:36 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-UX5GQQL4VA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134040|0                           |1
            is obsolete|                            |
    
    --- Comment #178 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134108
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134108&action=edit
    Bug 29648: ILL - no change
    
    No change expected here for ILL
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:10:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:10:41 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-CBQqnXYHjD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134041|0                           |1
            is obsolete|                            |
    
    --- Comment #179 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134109
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134109&action=edit
    Bug 29648: Patron accounting page - no sort
    
    because of desc
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:10:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:10:48 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-DOKkefnBgo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134042|0                           |1
            is obsolete|                            |
    
    --- Comment #180 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134110
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134110&action=edit
    Bug 29648: Patron page (PatronsPerPage) - no change
    
    PatronsPerPage should be done on a separate bug report, not trivial
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:10:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:10:55 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-9x5kIgVCFc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134043|0                           |1
            is obsolete|                            |
    
    --- Comment #181 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134111
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134111&action=edit
    Bug 29648: Payments - normal
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:11:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:11:01 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-vOgUq40a2r@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134044|0                           |1
            is obsolete|                            |
    
    --- Comment #182 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134112
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134112&action=edit
    Bug 29648: Checkout history - no sort
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:11:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:11:08 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-sc6JUaIpJS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134045|0                           |1
            is obsolete|                            |
    
    --- Comment #183 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134113
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134113&action=edit
    Bug 29648: patron list table - normal
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:11:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:11:16 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-FbxspwrB4v@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134046|0                           |1
            is obsolete|                            |
    
    --- Comment #184 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134114
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134114&action=edit
    Bug 29648: Item lost report - no change
    
    hum, there is no sort on this table, so it's displayed like it's coming
    from the controller, but perl code does not sort either.
    This could be improved and we could make it configurable easily
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:11:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:11:24 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-42c2JNqW3r@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134047|0                           |1
            is obsolete|                            |
    
    --- Comment #185 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134115
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134115&action=edit
    Bug 29648: Subscription detail - no change
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:11:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:11:33 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-0J951vVWXv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134048|0                           |1
            is obsolete|                            |
    
    --- Comment #186 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134116
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134116&action=edit
    Bug 29648: Log viewer - no sort
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:11:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:11:39 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-VhSHrqb9RU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134049|0                           |1
            is obsolete|                            |
    
    --- Comment #187 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134117
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134117&action=edit
    Bug 29648: Holds history - no sort
    
    because of desc
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:11:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:11:46 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-nDpywqKljX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134050|0                           |1
            is obsolete|                            |
    
    --- Comment #188 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134118
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134118&action=edit
    Bug 29648: Notice template - only sort
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:11:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:11:53 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-d1kR8kSrNZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134051|0                           |1
            is obsolete|                            |
    
    --- Comment #189 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134119
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134119&action=edit
    Bug 29648: Remove default sort order for detail
    
    On the detail view the number of columns changed, we cannot use the
    default sort order here.
    It certainly can be done on a different way but I prefer to postpone it
    for now and see later.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:12:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:12:00 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-i603VHSG09@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134052|0                           |1
            is obsolete|                            |
    
    --- Comment #190 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134120
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134120&action=edit
    Bug 29648: Upload tool - no sort
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:12:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:12:06 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-kHw24PFEdT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134053|0                           |1
            is obsolete|                            |
    
    --- Comment #191 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134121
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134121&action=edit
    Bug 29648: Returns - no change
    
    No change expected here, there is no sort and no paginate possible.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:12:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:12:13 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-tfBtEN2n1W@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134054|0                           |1
            is obsolete|                            |
    
    --- Comment #192 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134122
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134122&action=edit
    Bug 29648: Fix occurrences of GetColumns
    
    We could add the configuration to these tables as well, but let go first
    but the others (read: feeling lazy right now).
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:12:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:12:19 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-prjRwLzj4j@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #193 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134123
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134123&action=edit
    Bug 29648: (QA follow-up) Minor POD fix
    
    This just adds a top level set of POD headings to make the QA script
    happy
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:14:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:14:33 +0000
    Subject: [Koha-bugs] [Bug 24001] Cannot edit card template
    In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24001-70-uKQO2CPO9K@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134080|0                           |1
            is obsolete|                            |
    
    --- Comment #56 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134124
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134124&action=edit
    Bug 24001: Fix patron card template edition
    
    Error when saving Patron card Template:
    Can't bless non-reference value at
    /home/vagrant/kohaclone/C4/Creators/Profile.pm line 89
    
    This is caused by the profile dropdown offering invalid choices and is
    fixed by adding a filter to limit options to creator = 'Patroncards'.
    The UI already handles the case where no valid profile is avaiable.
    
    Signed-off-by: Alexis Ripetti <alexis.ripetti at inLibro.com>
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:14:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:14:38 +0000
    Subject: [Koha-bugs] [Bug 24001] Cannot edit card template
    In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24001-70-rLqvIQkKHP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134081|0                           |1
            is obsolete|                            |
    
    --- Comment #57 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134125
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134125&action=edit
    Bug 24001: Fix Card template/rpinter profile creation and edit
    
    This patch adjusts the template/profiles to use the default of '0'
    This should probably be NULL, and the columns foreign keys, this code
    could use a further rewrite, but this should fix a long standing bug
    
    To test:
     1 - Using the fresh install, with all the sample data.
     2 - Go to Home › Tools › Patron card creator › Templates
     3 - New > Card template
     4 - Save
     5 - Error: DBD::mysql::st execute failed: Incorrect integer value: '' for
    column 'profile_id' at row 1
     6 - Edit an existing template
     7 - Save
     8 - Error: Can't bless non-reference value at
    /kohadevbox/koha/C4/Creators/Profile.pm line 89
     9 - Create a new 'Printer profile'
    10 - Save
    11 - Error: DBD::mysql::st execute failed: Incorrect integer value: '' for
    column 'template_id' at row 1
    12 - Apply the attached patch.
    13 - Verify you can create a new 'Card template' and 'Printer profile' with no
    errors
    14 - Verify you can edit and save both of the newly created objects above
    
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:15:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:15:50 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-24kFHj0Sco@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    --- Comment #194 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Looks great to me. Added a small follow-up to keep the QA script happy.
    
    Katrin and I overlapped again so I've uploaded my SO and will leave her to set
    the final PQA :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:17:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:17:25 +0000
    Subject: [Koha-bugs] [Bug 28657] Expand branches.branchip to allow for
     multiple space separated ip ranges
    In-Reply-To: <bug-28657-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28657-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28657-70-gCizTbwckN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28657
    
    Michael Hafen <michael.hafen at washk12.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #122572|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Michael Hafen <michael.hafen at washk12.org> ---
    Created attachment 134126
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134126&action=edit
    Bug 28657: expand branches.branchip to allow for multiple ip  ranges.
    
    change branches.branchip to a mediumtext, and remove '*' from existing
     branchip settings.
    Change C4/Auth.pm from a regexp to using in_iprange() to check client 
     address against branchip.  (in_iprange() doesn't work with '*' in branchip.)
    Change in_iprange() to default to false (which is what the POD says it 
     should do).  Also, have it trim '*' in case someone adds some back later.
    Change note in admin/branches.tt under branchip field to reflect changes to 
     branchip handling.
    
    Test plan:
    
    1. Turn on AutoLocation system preference
    2. Change a branches branchip to multiple ip ranges seperated by a space,
       making sure one of the ranges includes your computers address.
    3. Log out and try logging in.  The location check will fail.
    4. Apply patch.  Restart plack if necessary.
    5. Try logging in again.  The location check will succeed.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:17:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:17:36 +0000
    Subject: [Koha-bugs] [Bug 28657] Expand branches.branchip to allow for
     multiple space separated ip ranges
    In-Reply-To: <bug-28657-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28657-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28657-70-ycr3CF1Xgm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28657
    
    Michael Hafen <michael.hafen at washk12.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Patch doesn't apply         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:20:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:20:02 +0000
    Subject: [Koha-bugs] [Bug 29664] Do not show voided payments in
     cash_register_stats.pl
    In-Reply-To: <bug-29664-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29664-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29664-70-VKx2F7yME9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664
    
    Brittanie Maccarone <brittanie.maccarone at williamsoncounty-tn.gov> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |brittanie.maccarone at william
                       |                            |soncounty-tn.gov
    
    --- Comment #1 from Brittanie Maccarone <brittanie.maccarone at williamsoncounty-tn.gov> ---
    We actively have a ticket for this issue, from Nov 2021.  Duplicates being
    shown in our reports is affecting the information that is available to show the
    county that controls our funds.  At the moment we are simply not using the
    function, and making notes elsewhere.  But with multiple branches there is
    always the risk it gets used and shows our money as incorrect.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:22:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:22:07 +0000
    Subject: [Koha-bugs] [Bug 22659] Add 'save and continue' functionality to
     news and HTML customizations
    In-Reply-To: <bug-22659-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22659-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22659-70-LtrN0MIWhG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22659
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:28:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:28:21 +0000
    Subject: [Koha-bugs] [Bug 30632] New: Fix report author display in list of
     saved reports
    Message-ID: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632
    
                Bug ID: 30632
               Summary: Fix report author display in list of saved reports
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Templates
              Assignee: oleonard at myacpl.org
              Reporter: katrin.fischer at bsz-bw.de
            QA Contact: testopia at bugs.koha-community.org
                Blocks: 30617
    
    The author of a report shows as:
    
    Fischer , Katrin (51) 
    
    The additional space before comma should be removed.
    
    I assume it should be switched over to using one of the standardized ways to
    show patron names, see bug 30617
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30617
    [Bug 30617] [OMNIBUS] We should consistently use includes for patron name
    display
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:28:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:28:21 +0000
    Subject: [Koha-bugs] [Bug 30617] [OMNIBUS] We should consistently use
     includes for patron name display
    In-Reply-To: <bug-30617-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30617-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30617-70-7eJ3tr2B8I@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30617
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30632
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632
    [Bug 30632] Fix report author display in list of saved reports
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:28:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:28:37 +0000
    Subject: [Koha-bugs] [Bug 30632] Fix report author display in list of saved
     reports
    In-Reply-To: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30632-70-wkAowltJTw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Severity|enhancement                 |minor
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:32:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:32:19 +0000
    Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through stage
     MARC record import
    In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22785-70-OGTf7lKaIK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133947|0                           |1
            is obsolete|                            |
    
    --- Comment #76 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134127
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134127&action=edit
    Bug 22785: Allow option to choose which record match is applied during import
    
    This patchset adds the display of all matches found during import to the import
    management screen
    
    A staff member with the permission to manage batches will be able to select for
    any individual record which match, or none, should be used during import
    
    To test:
    1 - Import a batch of records or export existing records from your catalog
    2 - Import the file (again) and select a matching rule that will find matches
    3 - Note that you now have radio buttons allowing you to select a record, or
    none
    4 - Test scenarios:
        I - When 'Action if matching record found' is 'Ignore'
            a - Imported record ignored if match is selected
            b - 'Action if no match found' followed if no match is selected (Ignore
    matches)
        II - When 'Action if matching record found' is 'Replace'
            a - The chosen record is the one overlayed (you can edit the chosen
    record before importing to confirm)
            b - 'Action if no match found' followed if no match is selected (Ignore
    matches)
        III - When 'Action if matching record found' is 'Add incoming record'
            a - Record is added regardless of matches
    5 - Confirm 'Diff' 'View' links work as expected
    6 - Confirm that after records are imported the radio buttons to choose are
    disabled
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    Bug 22785: API files
    
    Signed-off-by: Ben Daeuber <bdaeuber at cityoffargo.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:32:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:32:26 +0000
    Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through stage
     MARC record import
    In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22785-70-Tb0cAYdi7C@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133948|0                           |1
            is obsolete|                            |
    
    --- Comment #77 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134128
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134128&action=edit
    Bug 22785: DO NOT PUSH Schema Updates
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:32:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:32:33 +0000
    Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through stage
     MARC record import
    In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22785-70-GeXmQ0TI6f@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133949|0                           |1
            is obsolete|                            |
    
    --- Comment #78 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134129
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134129&action=edit
    Bug 22785: Update Schema for boolean
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Ben Daeuber <bdaeuber at cityoffargo.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:32:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:32:39 +0000
    Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through stage
     MARC record import
    In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22785-70-ADn9dNpoE1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133950|0                           |1
            is obsolete|                            |
    
    --- Comment #79 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134130
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134130&action=edit
    Bug 22785: (follow-up) Don't sort by chosen and fix selection of matches
    
    Previously the sorting took 'chosen' into account and would move a selected
    match to the
    top on next load - it is better to preserve the same sorting every time
    
    When loading matches the 'cehcked' variable was not being cleared, so multiple
    matches were
    being marked 'checked="checked"'. Fixing this ensures the correct record
    displays as chosen
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Ben Daeuber <bdaeuber at cityoffargo.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:32:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:32:45 +0000
    Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through stage
     MARC record import
    In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22785-70-NG78fplf8N@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133951|0                           |1
            is obsolete|                            |
    
    --- Comment #80 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134131
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134131&action=edit
    Bug 22785: (follow-up) Fix translatability
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:32:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:32:51 +0000
    Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through stage
     MARC record import
    In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22785-70-TOHHRHAkQJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    
    --- Comment #81 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134132
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134132&action=edit
    Bug 22785: (QA follow-up) Remove superflous spec files
    
    We don't need these any more.. I think they crept back in during
    rebases
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:35:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:35:27 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-rDCXRu44Tn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #195 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    I'd say it was teamwork on this one, providing another follow-up. 
    I like to see this getting more flexible and hope we can implement the options
    for a lot more tables.
    
    At some point I'd love to see a primary and secondary sort. For example we get
    a lot of requests for the OPAC item table to sort by different criteria. One
    could imagine something like: homebranch, itemtype.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:36:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:36:25 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-kkK4lxm4h5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:36:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:36:34 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-GI7H52hzcx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134086|0                           |1
            is obsolete|                            |
    
    --- Comment #196 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134133
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134133&action=edit
    Bug 29648: Improve existing code
    
    We already have 2 tables that are configurable, on acqui/basket and
    reports/orders_by_budget.
    This patch is modifying a bit the existing code to transfer the
    responsability/logic to the KohaTable constructor instead of the
    template that is creating the object.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:36:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:36:41 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-0xPtMZ2Yfy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134087|0                           |1
            is obsolete|                            |
    
    --- Comment #197 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134134
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134134&action=edit
    Bug 29648: Move NumSavedReports to the table settings
    
    The syspref NumSavedReports can be moved to the table settings config
    Test plan:
    1. Set the syspref to a given value
    2. updatedatabase # execute the atomic update
    3. Go to the table settings page and confirm that the syspref's value
    has been retrieved
    4. Select a specific colonne for the default sort
    5. Go to the report list view and confirm that the "Show X entries" has
    the correct selected value and that the table is sorted as you expect.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:36:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:36:49 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-XDKJ4WZS82@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134088|0                           |1
            is obsolete|                            |
    
    --- Comment #198 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134135
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134135&action=edit
    Bug 29648: Add item - broken FIXME
    
    Why don't we have the columns visibility button?
    
    It looks like there is something broken here, why don't we have the
    show/hide columns buttons? The code expects it to be displayed.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:36:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:36:56 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-4befztDn9z@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134089|0                           |1
            is obsolete|                            |
    
    --- Comment #199 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134136
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134136&action=edit
    Bug 29648: Duplicate orders view - no change
    
    No change expected here, only removing commented-out code.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:37:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:37:03 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-h4JVncye1Q@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134090|0                           |1
            is obsolete|                            |
    
    --- Comment #200 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134137
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134137&action=edit
    Bug 29648: Order search view - normal
    
    "normal" means that we are expecting the table to have the 2 options
    implemented and working.
    You can select "Default display length" and "Default sort order"
    in the "table settings" administration view, then go the the view
    and confirm that the table has the configured values pre-selected.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:37:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:37:10 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-5Mr0okZDlM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134091|0                           |1
            is obsolete|                            |
    
    --- Comment #201 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134138
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134138&action=edit
    Bug 29648: Late orders view - normal
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:37:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:37:17 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-4UfQ797ZTH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134092|0                           |1
            is obsolete|                            |
    
    --- Comment #202 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134139
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134139&action=edit
    Bug 29648: Authorised values view
    
    No change is expected on this view as the table is not part of the table
    settings.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:37:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:37:24 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-MYved429VS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134093|0                           |1
            is obsolete|                            |
    
    --- Comment #203 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134140
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134140&action=edit
    Bug 29648: Libraries administration view - normale
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:37:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:37:31 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-u9QbfVRo22@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134094|0                           |1
            is obsolete|                            |
    
    --- Comment #204 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134141
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134141&action=edit
    Bug 29648: Patron categories administration view - normal
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:37:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:37:39 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-zWD303T8oc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134095|0                           |1
            is obsolete|                            |
    
    --- Comment #205 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134142
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134142&action=edit
    Bug 29648: Cities administration view - REST API
    
    Here we need to deal with the other DT config (in datatables.js, not
    columns_settings.inc).
    
    Test plan:
    Same as "normal"
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:37:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:37:47 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-OpzDfpkr7E@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134096|0                           |1
            is obsolete|                            |
    
    --- Comment #206 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134143
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134143&action=edit
    Bug 29648: Item types administration view
    
    Set noItemTypeImages and OpacNoItemTypeImages to "No" and confirm
    that the first column (the image) is not displayed. Otherwise test as
    "normal"
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:37:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:37:54 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-1bH4Y98PzW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134097|0                           |1
            is obsolete|                            |
    
    --- Comment #207 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134144
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134144&action=edit
    Bug 29648: Allow tables_settings.default_display_length to be NULL
    
    We actually want this value to be NULL. If set to NULL and
    default_display_length is not in the yml, then the option will not be
    displayed.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:38:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:38:02 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-adarNfOUq8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134098|0                           |1
            is obsolete|                            |
    
    --- Comment #208 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134145
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134145&action=edit
    Bug 29648: DBIC Schema changes
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:38:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:38:10 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-iB9wVuBzUV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134099|0                           |1
            is obsolete|                            |
    
    --- Comment #209 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134146
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134146&action=edit
    Bug 29648: Catalogue detail - no default_display_length
    
    On the acquisition table the sort option is not available as we don't
    offer the ability to selection asc/desc and default to asc.
    We cannot offer default_display_length for those tables.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:38:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:38:18 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-cxY9v6GDUF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134100|0                           |1
            is obsolete|                            |
    
    --- Comment #210 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134147
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134147&action=edit
    Bug 29648: Checkout history - normal no sort
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:38:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:38:26 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-c9pAVWjNDj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134101|0                           |1
            is obsolete|                            |
    
    --- Comment #211 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134148
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134148&action=edit
    Bug 29648: Cataloguing Z3950 search - no pagination
    
    Pagination is done server-side
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:38:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:38:33 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-m4gFgRAysM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134102|0                           |1
            is obsolete|                            |
    
    --- Comment #212 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134149
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134149&action=edit
    Bug 29648: Overdue list - normal
    
    'stateSave' so need to test on the first try or delete the relevant local
    storage
    entry
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:38:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:38:41 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-UohQYAnz88@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134103|0                           |1
            is obsolete|                            |
    
    --- Comment #213 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134150
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134150&action=edit
    Bug 29648: Holds to pull - normal
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:38:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:38:49 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-9cs5Alpjal@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134104|0                           |1
            is obsolete|                            |
    
    --- Comment #214 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134151
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134151&action=edit
    Bug 29648: Holds ratios - normal but no sort
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:38:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:38:57 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-RcTp2KgIsP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134105|0                           |1
            is obsolete|                            |
    
    --- Comment #215 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134152
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134152&action=edit
    Bug 29648: Holds queue - only sort
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:39:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:39:05 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-Tdmg8ESwC3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134106|0                           |1
            is obsolete|                            |
    
    --- Comment #216 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134153
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134153&action=edit
    Bug 29648: Course reserve detail - normal
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:39:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:39:12 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-lFUTwa6qiK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134107|0                           |1
            is obsolete|                            |
    
    --- Comment #217 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134154
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134154&action=edit
    Bug 29648: Course reserve list - normal
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:39:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:39:19 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-TKuzJEs1fW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134108|0                           |1
            is obsolete|                            |
    
    --- Comment #218 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134155
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134155&action=edit
    Bug 29648: ILL - no change
    
    No change expected here for ILL
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:39:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:39:26 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-Kxd0PTIMQh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134109|0                           |1
            is obsolete|                            |
    
    --- Comment #219 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134156
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134156&action=edit
    Bug 29648: Patron accounting page - no sort
    
    because of desc
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:39:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:39:34 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-KZaxBmGJ9W@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134110|0                           |1
            is obsolete|                            |
    
    --- Comment #220 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134157
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134157&action=edit
    Bug 29648: Patron page (PatronsPerPage) - no change
    
    PatronsPerPage should be done on a separate bug report, not trivial
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:39:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:39:43 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-pWJi0wyX6i@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134111|0                           |1
            is obsolete|                            |
    
    --- Comment #221 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134158
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134158&action=edit
    Bug 29648: Payments - normal
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:39:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:39:51 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-oCuXRPJOz7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134112|0                           |1
            is obsolete|                            |
    
    --- Comment #222 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134159
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134159&action=edit
    Bug 29648: Checkout history - no sort
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:39:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:39:58 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-ZhTs4tyfPA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134113|0                           |1
            is obsolete|                            |
    
    --- Comment #223 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134160
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134160&action=edit
    Bug 29648: patron list table - normal
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:40:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:40:07 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-Zwy7P0Q4Ro@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134114|0                           |1
            is obsolete|                            |
    
    --- Comment #224 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134161
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134161&action=edit
    Bug 29648: Item lost report - no change
    
    hum, there is no sort on this table, so it's displayed like it's coming
    from the controller, but perl code does not sort either.
    This could be improved and we could make it configurable easily
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:40:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:40:15 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-Bo3ZmmtPiX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134115|0                           |1
            is obsolete|                            |
    
    --- Comment #225 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134162
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134162&action=edit
    Bug 29648: Subscription detail - no change
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:40:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:40:24 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-I01wlB1VZu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134116|0                           |1
            is obsolete|                            |
    
    --- Comment #226 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134163
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134163&action=edit
    Bug 29648: Log viewer - no sort
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:40:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:40:31 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-dOoYEpxUtt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134117|0                           |1
            is obsolete|                            |
    
    --- Comment #227 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134164
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134164&action=edit
    Bug 29648: Holds history - no sort
    
    because of desc
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:40:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:40:39 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-XWuCCGrHOY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134118|0                           |1
            is obsolete|                            |
    
    --- Comment #228 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134165
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134165&action=edit
    Bug 29648: Notice template - only sort
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:40:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:40:47 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-df4iSu9409@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134119|0                           |1
            is obsolete|                            |
    
    --- Comment #229 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134166
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134166&action=edit
    Bug 29648: Remove default sort order for detail
    
    On the detail view the number of columns changed, we cannot use the
    default sort order here.
    It certainly can be done on a different way but I prefer to postpone it
    for now and see later.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:40:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:40:54 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-eWcytqKOLN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134120|0                           |1
            is obsolete|                            |
    
    --- Comment #230 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134167
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134167&action=edit
    Bug 29648: Upload tool - no sort
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:41:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:41:01 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-IgiFb3ZJvC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134121|0                           |1
            is obsolete|                            |
    
    --- Comment #231 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134168
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134168&action=edit
    Bug 29648: Returns - no change
    
    No change expected here, there is no sort and no paginate possible.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:41:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:41:10 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-1yomtwswTB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134122|0                           |1
            is obsolete|                            |
    
    --- Comment #232 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134169
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134169&action=edit
    Bug 29648: Fix occurrences of GetColumns
    
    We could add the configuration to these tables as well, but let go first
    but the others (read: feeling lazy right now).
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:41:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:41:18 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-xpPJ4nBqIM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134123|0                           |1
            is obsolete|                            |
    
    --- Comment #233 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134170
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134170&action=edit
    Bug 29648: (QA follow-up) Minor POD fix
    
    This just adds a top level set of POD headings to make the QA script
    happy
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:41:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:41:29 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-xQ1PjM5Xr0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #234 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134171
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134171&action=edit
    Bug 29648: (QA follow-up) Remove NumSavedReports from .pref file
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:44:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:44:53 +0000
    Subject: [Koha-bugs] [Bug 30633] New: Move OPACHoldingsDefaultSortField to
     table settings configuration
    Message-ID: <bug-30633-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633
    
                Bug ID: 30633
               Summary: Move OPACHoldingsDefaultSortField to table settings
                        configuration
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: OPAC
              Assignee: oleonard at myacpl.org
              Reporter: katrin.fischer at bsz-bw.de
            QA Contact: testopia at bugs.koha-community.org
            Depends on: 29648
    
    Now that the sorting of a table can be defined in administration > table
    settings, we should move OPACHoldingsDefaultSortField there and remove the
    pref.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    [Bug 29648] Make KohaTable tables 'default length' and 'default sort'
    configurable
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:44:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:44:53 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-QapvGCPNZv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30633
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633
    [Bug 30633] Move OPACHoldingsDefaultSortField to table settings configuration
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:46:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:46:59 +0000
    Subject: [Koha-bugs] [Bug 30633] Move OPACHoldingsDefaultSortField to table
     settings configuration
    In-Reply-To: <bug-30633-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30633-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30633-70-XGE8mqH6aw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30634
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30634
    [Bug 30634] Allow to define primary and secondary sorting criteria for item
    table in OPAC
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:46:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:46:59 +0000
    Subject: [Koha-bugs] [Bug 30634] New: Allow to define primary and secondary
     sorting criteria for item table in OPAC
    Message-ID: <bug-30634-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30634
    
                Bug ID: 30634
               Summary: Allow to define primary and secondary sorting criteria
                        for item table in OPAC
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: OPAC
              Assignee: oleonard at myacpl.org
              Reporter: katrin.fischer at bsz-bw.de
            QA Contact: testopia at bugs.koha-community.org
            Depends on: 30633
    
    It would be great if we could sort by not only one column, but 2 columns in
    some cases. A good example would be the items table in staff and OPAC.
    
    Something like homebranch, itemtype or homebranch, itemcallnumber would be
    nice, especially for libraries that use different callnumber schemes at
    different branches.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633
    [Bug 30633] Move OPACHoldingsDefaultSortField to table settings configuration
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 18:55:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 16:55:13 +0000
    Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available
     items even if on shelf holds aren't allowed
    In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30556-70-OVBwAXA47R@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556
    
    Shi Yao Wang <shi-yao.wang at inLibro.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133608|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
    Created attachment 134172
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134172&action=edit
    Bug 30556: Place hold button doesn't show when not allowed
    
    When On shelf holds allowed is on "If all unavailable", the Place hold button
    is not shown.
    
    To test:
    
    1. Create a circulation rule with on shelf holds set to "If all unavailable"
    2. Create or modify a record to match the items itype to the circulation rule
    3. Use a patron matching the circ rule category to log into the opac
    4. Look for the record
    5. Notice that the Place hold button is there, even thought it's not allowed
    6. Apply the patch.
    7. The button is not there.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 19:23:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 17:23:14 +0000
    Subject: [Koha-bugs] [Bug 28657] Expand branches.branchip to allow for
     multiple space separated ip ranges
    In-Reply-To: <bug-28657-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28657-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28657-70-wVO9GFz7wJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28657
    
    Michael Hafen <michael.hafen at washk12.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134126|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Michael Hafen <michael.hafen at washk12.org> ---
    Created attachment 134173
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134173&action=edit
    Bug 28657: expand branches.branchip to allow for multiple ip ranges.
    
    Rebased on Current (2022-04-27) master
    
    change branches.branchip to a mediumtext, and remove '*' from existing branchip
    settings.
    Change C4/Auth.pm from a regexp to using in_iprange() to check client address
    against branchip.  (in_iprange() doesn't work with '*' in branchip.)
    Change in_iprange() to default to false (which is what the POD says it should
    do).  Also, have it trim '*' in case someone adds some back later.
    Change note in admin/branches.tt under branchip field to reflect changes to
    branchip handling.
    
    
    Test plan:
    
    1. Turn on AutoLocation system preference
    2. Change a branches branchip to multiple ip ranges seperated by a space,
       making sure one of the ranges includes your computers address.
    3. Log out and try logging in.  The location check will fail.
    4. Apply patch.  Restart plack if necessary.
    5. Try logging in again.  The location check will succeed.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 19:27:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 17:27:05 +0000
    Subject: [Koha-bugs] [Bug 28658] With SearchMyLibraryFirst if library isn't
     set for the opac, try to guess it by checking branchip
    In-Reply-To: <bug-28658-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28658-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28658-70-e0sgBlC1cw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658
    
    Michael Hafen <michael.hafen at washk12.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|BLOCKED                     |Needs Signoff
    
    --- Comment #4 from Michael Hafen <michael.hafen at washk12.org> ---
    Bug 28657 has been rebased.
    
    Test plan:
    
    1. Turn on SearchMyLibraryFirst system preference.
    2. Make sure your computers ip address is covered by a branch's branchip.
    3. Go to opac.
    4. Observe that the branch isn't set.
    5. Apply patch.  Restart things if necessary
    6. Reload opac.
    7. Observe that the branch is set.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 19:27:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 17:27:10 +0000
    Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through stage
     MARC record import
    In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22785-70-CFwcuowTwG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    --- Comment #82 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    All appears to be working well, QA scripts are happy too.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 19:31:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 17:31:15 +0000
    Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through stage
     MARC record import
    In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22785-70-1cHosDQki9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Failed QA
    
    --- Comment #83 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Scratch that.. I forgot to test an action and now found a bug.
    
    If you select to 'Ignore' then change your mind and select a match again.. the
    API request fails with: 
    
    [
      {
        "message": "Expected application/json - got
    application/x-www-form-urlencoded; charset=UTF-8.",
        "path": "/body"
      }
    ]
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 19:32:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 17:32:20 +0000
    Subject: [Koha-bugs] [Bug 28642] Add IndependentBranches syspref to hide
     other items and libraries
    In-Reply-To: <bug-28642-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28642-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28642-70-adfytZlV7S@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28642
    
    Michael Hafen <michael.hafen at washk12.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #124786|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Michael Hafen <michael.hafen at washk12.org> ---
    Created attachment 134174
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134174&action=edit
    Bug 28642: Expand IndependentBranches to hide others items  and libraries
    
    Rebased on 2022-04-27
    
    Adds a system preference: IndependentBranchesHideOtherBranchesItems.
    When on:
      All library select's will be limited to just the users library.
      Item lists in search results, title details, item details, holds, and exports
        will only show items at the users library.
    
    Test Plan:
    
    Apply patch and run koha-upgrade-schema or manually create
    IndependentBranchesHideOtherBranchesItems system preference.
    Login with an account that is not Super Librarian.
    Set the IndependentBranchesHideOtherBranchesItems system preference to yes.
    On the Item Search page observe that only your library shows in the home and
    current library fields.
    On the Advanced Search page observe that only your library shows in the
    location -> individual libraries field.
    Search the catalog for a title with an item at your library and also at another
    library.
    Observe that you only see your library listed in the facets panel (Refine your
    search -> Home Libraries section)
    Observe that you only see the item at your library in the search results, title
    details, MARC details, Items, Checkout history, and Edit Items pages.
    On the title details page Save the title as a text format, for example MARCXML,
    and observe that only item(s) at your library are in the export.
    On the Place hold page, search for a patron and observe that only patrons at
    your library are found.
    After selecting a patron observe that only items at your library are displaed.
    In the Circulation -> Overdues page observe that you only see items at your
    library.
    In the Check out quick search search for patrons.  Observe that only patrons at
    your school are found unless you search by cardnumber.
    On the Patrons page observe that only your library shows in the library field
    of the search form.
    In the Search Patrons tab of the quick search click the '+' to open the other
    fields.  Observe that only your library shows in the Library field.
    On the Modify Patron page (edit patron) observe that only your library shows in
    the library field in the library management section.
    In Serials start a new subscription and observe that only your library shows in
    the library field.
    In Serials -> Check expiration observe that only your library show in the
    library field.
    In Reports observe that only your library shows in the following reports:
    Acquis
    itions statistics, Patrons statistics, Catalog statistics, Circulation
    statistics, Serials statistics, Cash register statistics, Holds statistics,
    Patrons with the most checkouts, Most-circulated items, Items with no
    checkouts, Items lost, Catalog by item type, Average loan time.
    In Suggestions observe that only your library shows in the library field on the
    Suggestion management and New purchase suggestion pages.
    In Tools -> Patron Lists when adding patrons to a list observe that only
    patrons at your library are found by name.
    In Patron Clubs observe that the library field only shows your library in the
    Club Template and Club edit pages.
    In Comments observe that only comments at your library are shown.
    In Import Patrons observe that the library field in the defaults section only
    shows your library.
    In Batch patron modification observe that your library is the only library in
    the library field.
    In Batch item modification observe that your library is the only library in the
    Home and Current library fields.
    In Export data observe that only your library shows in the 'With items owned by
    the following libraries' field and it is selected.
    In Inventory observe that only your library shows in the library field.
    In News observe that only your library shows in the library field in the Filter
    on the home page and the Edit entry page.
    Open the Opac and log in.
    On the Advanced search page observe that your library is the only library in
    the Location field.
    Search for a title with items at multiple libraries.  Observe that only your
    library shows in the libraries facets (refine your search).
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 19:32:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 17:32:31 +0000
    Subject: [Koha-bugs] [Bug 28642] Add IndependentBranches syspref to hide
     other items and libraries
    In-Reply-To: <bug-28642-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28642-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28642-70-Ps6F62OfRz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28642
    
    Michael Hafen <michael.hafen at washk12.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Patch doesn't apply         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 19:33:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 17:33:56 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-qIYxP5qxqh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Severity|normal                      |major
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 19:36:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 17:36:09 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-b82epSVer7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Could you provide a test plan for this one?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 19:42:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 17:42:14 +0000
    Subject: [Koha-bugs] [Bug 30623] Copy permissions from one user to another
    In-Reply-To: <bug-30623-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30623-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30623-70-mrH49hLuIf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30623
    
    Lisette Scheer <lisetteslatah at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lisetteslatah at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 19:43:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 17:43:40 +0000
    Subject: [Koha-bugs] [Bug 30387] IndependentBranches allows users to change
     libraries when they should not be able to
    In-Reply-To: <bug-30387-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30387-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30387-70-Rlmj1WaJjE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30387
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Hmm, wasn't there actually a reason cataloguers needed to be able to change
    library?  I have a feeling this was a feature rather than a bug as I've asked
    this question before.. ccing people to help dredge the hive mind.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 19:44:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 17:44:00 +0000
    Subject: [Koha-bugs] [Bug 30387] IndependentBranches allows users to change
     libraries when they should not be able to
    In-Reply-To: <bug-30387-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30387-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30387-70-8jIl4vgJrW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30387
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com,
                       |                            |katrin.fischer at bsz-bw.de
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 20:01:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 18:01:20 +0000
    Subject: [Koha-bugs] [Bug 29129] The printclearscreen icon on circulation.tt
     should be configuarable to print either ISSUESLIP or ISSUEQSLIP
    In-Reply-To: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29129-70-25n7JxSKLs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 20:01:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 18:01:24 +0000
    Subject: [Koha-bugs] [Bug 29129] The printclearscreen icon on circulation.tt
     should be configuarable to print either ISSUESLIP or ISSUEQSLIP
    In-Reply-To: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29129-70-RUpP5BIzjJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129
    
    --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
    Created attachment 134175
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134175&action=edit
    Bug 29129: Update DisplayClearScreenButton to allow for a choice between
    issueslip and issueqslip
    
    To Test:
    1. Apply patch, updatedatabase, and restart_all
    2. A small change the global scss file means you should regenerate the CSS as
    well. (
    https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface
    )
    3. Set DisplayClearScreenButton to "don't show"
    4. Go to the patron checkout screen and see that no button should show to clear
    the screen and print
    5. Set DisplayClearScreenButton to 'ISSUESLIP' and make sure the button now
    appears and the ISSUESLIP prints
    6. Set DisplayClearScreenButton to 'ISSUEQSLIP' and make sure the button now
    appears and the ISSUEQSLIP prints
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 20:08:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 18:08:44 +0000
    Subject: [Koha-bugs] [Bug 29129] The printclearscreen icon on circulation.tt
     should be configuarable to print either ISSUESLIP or ISSUEQSLIP
    In-Reply-To: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29129-70-7pM1FgN1Nb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
               Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                       |ity.org                     |
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 20:56:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 18:56:46 +0000
    Subject: [Koha-bugs] [Bug 29129] The printclearscreen icon on circulation.tt
     should be configuarable to print either ISSUESLIP or ISSUEQSLIP
    In-Reply-To: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29129-70-bhkByrg6hV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 20:56:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 18:56:50 +0000
    Subject: [Koha-bugs] [Bug 29129] The printclearscreen icon on circulation.tt
     should be configuarable to print either ISSUESLIP or ISSUEQSLIP
    In-Reply-To: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29129-70-dtkeUVeKNX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129
    
    Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134175|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
    Created attachment 134176
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134176&action=edit
    Bug 29129: Update DisplayClearScreenButton to allow for a choice between
    issueslip and issueqslip
    
    To Test:
    1. Apply patch, updatedatabase, and restart_all
    2. A small change the global scss file means you should regenerate the CSS as
    well. (
    https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface
    )
    3. Set DisplayClearScreenButton to "don't show"
    4. Go to the patron checkout screen and see that no button should show to clear
    the screen and print
    5. Set DisplayClearScreenButton to 'ISSUESLIP' and make sure the button now
    appears and the ISSUESLIP prints
    6. Set DisplayClearScreenButton to 'ISSUEQSLIP' and make sure the button now
    appears and the ISSUEQSLIP prints
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 21:03:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 19:03:53 +0000
    Subject: [Koha-bugs] [Bug 30635] New: Add API route to create/update
     borrower_relationships, guarantors/guarantees
    Message-ID: <bug-30635-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30635
    
                Bug ID: 30635
               Summary: Add API route to create/update borrower_relationships,
                        guarantors/guarantees
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: REST API
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: andrew at bywatersolutions.com
                    CC: tomascohen at gmail.com
    
    We should have a way to deal with guarantors and guarantees via the API.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 21:08:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 19:08:57 +0000
    Subject: [Koha-bugs] [Bug 30629] <span> in title of patron card creator
     template needs to be removed
    In-Reply-To: <bug-30629-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30629-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30629-70-ulkse5cwHD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |29602
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    [Bug 29602] We must be nicer with translators
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 21:08:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 19:08:57 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-Wu1HTmxiI6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30629
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629
    [Bug 30629] <span> in title of patron card creator template needs to be removed
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 21:41:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 19:41:45 +0000
    Subject: [Koha-bugs] [Bug 30629] <span> in title of patron card creator
     template needs to be removed
    In-Reply-To: <bug-30629-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30629-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30629-70-dq5ITdcvr2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |david at davidnind.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 21:42:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 19:42:16 +0000
    Subject: [Koha-bugs] [Bug 30631] Show list of existing printer profiles when
     creating a new patron card template
    In-Reply-To: <bug-30631-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30631-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30631-70-73tROooiPi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30631
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |david at davidnind.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 21:44:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 19:44:04 +0000
    Subject: [Koha-bugs] [Bug 22223] Item url double-encode when parameter is an
     encoded URL
    In-Reply-To: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22223-70-d74bIbrZiK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22223
    
    --- Comment #40 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    That code looks very strange to me.
    Naming a TT filter 'Filter'.
    
    I would prefer to see syntax : [% var | $NoDoubleEncode %]
    Like TT plugin Price.
    
    Class is using :
    Base qw( Template::Plugin::Filter )
    But does not implement a 'filter' method.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 21:49:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 19:49:44 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-m5sPnxxu1h@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|additional_work_needed      |
    
    --- Comment #57 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Follow-ups pushed to master (commit message fixed) :
    
    286a800704 Bug 30373: (follow-up) Add BNF z3950 server
    880103371b Bug 30373: (follow-up) Enable 'qualif' authorised_value
    5edafaff11 Bug 30373: (follow-up) Optional SUGGEST auth values
    20ae18e5ee Bug 30373: (follow-up) UNIMARC relator codes auth values
    d4fa096001 Bug 30373: (follow-up) Language codes auth values
    4bdaaed17b Bug 30373: (follow-up) Country codes auth values
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:11:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:11:42 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-UTOQfXeKxf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:11:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:11:50 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-sJrn4h9LyV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133984|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:12:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:12:01 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-b7aLttDN41@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133969|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:12:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:12:10 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-DNzdgvLtHe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133970|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:12:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:12:15 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-4N8nvJhcOa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133971|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:12:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:12:20 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-yCxiv0tV7e@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133972|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:12:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:12:25 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-69trmYUPtA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133973|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:12:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:12:30 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-aRZ6WZ5g5y@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133974|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:12:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:12:30 +0000
    Subject: [Koha-bugs] [Bug 30629] <span> in title of patron card creator
     template needs to be removed
    In-Reply-To: <bug-30629-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30629-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30629-70-nI2xUGjMum@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
    
    --- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Maybe keep the span in PROCESS and remove them in <title> creation.
    I've tryed but could not use filters on a PROCESS.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:12:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:12:36 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-SI7VP9GFT6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133975|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:12:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:12:41 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-CqOudclqbo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133976|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:12:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:12:46 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-T4D6qvoRBl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133977|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:12:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:12:51 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-XeYne8of3J@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133978|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:12:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:12:57 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-NVIl75tTuE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133979|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:13:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:13:02 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-8lXfaCA0gn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133980|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:13:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:13:07 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-C2Rya2ECGd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133981|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:13:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:13:12 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-W1lMi4cTuS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133982|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:13:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:13:17 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-Jz7DISOgAK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133983|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:13:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:13:50 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-p2tFBBifvX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #101 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134177
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134177&action=edit
    Bug 30275: Add checkout_renewals table
    
    This patch adds the new checkout_renewals table using an atomicupdate
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:13:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:13:56 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-6ItqytcWtq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #102 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134178
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134178&action=edit
    Bug 30275: Generated kohastructure.sql
    
    This kohastructure update was generated using `koha-dump --schema-only`
    in koha-testing-docker once the atomicupdate had been run against the
    previous atomicupdate patch.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:14:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:14:04 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-akudZsN0k2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #103 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134179
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134179&action=edit
    Bug 30275: DBIC Schema Changes
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:14:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:14:12 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-g4d2en0gmO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #104 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134180
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134180&action=edit
    Bug 30275: Record renewals
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:14:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:14:20 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-tWDhmi7whe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #105 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134181
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134181&action=edit
    Bug 30275: DBIC Schema Additions
    
    Add checkout and old_checkout relations to CheckoutRenewal schema and
    mark 'seen' as a boolean.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:14:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:14:29 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-LU4tKkXexX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #106 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134182
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134182&action=edit
    Bug 30275: Add Koha::Objects for Renewals
    
    Add Koha::Checkouts::Renewals|Renewal classes
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:14:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:14:39 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-VU040vinqr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #107 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134183
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134183&action=edit
    Bug 30275: Rename issues.renewals to issues.renewals_count
    
    Rename the issues.renewals field to renewals_count to prevent a method
    name collision with the new relation accessor introduced by this
    patchset.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:14:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:14:56 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-5CmsabOa9w@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #108 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134184
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134184&action=edit
    Bug 30275: renewals_count DBIC Update
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:15:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:15:07 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-7dSUtPiBni@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #109 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134185
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134185&action=edit
    Bug 30275: Add 'renewals' relation to Issue Schema
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:15:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:15:17 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-vE5QyQB2Of@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #110 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134186
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134186&action=edit
    Bug 30275: Add renewals relation to Koha::Checkout
    
    Add the new 'renewals' relation to Koha::Checkout to return a list of
    Koha::Checkouts::Renewal objects.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:15:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:15:28 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-djspvwsl8j@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #111 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134187
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134187&action=edit
    Bug 30275: Add `/api/v1/checkouts/{checkout_id}/renewals`
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:15:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:15:36 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-r3sgDGD3xt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #112 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134188
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134188&action=edit
    Bug 30275: Add alias to create renewal in api routes
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:15:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:15:44 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-jXG5XGVK4O@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #113 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134189
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134189&action=edit
    Bug 30275: Fix checkouts.t unit test
    
    We no longer require a mocked userenv for these tests to pass, we're
    setting the userenv in api auth now. The mock just serves to break tests
    for the renew method now that AddRenewal required a correctly set
    userenv for 'number'.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:15:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:15:52 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-SCSdjogoX9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #114 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134190
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134190&action=edit
    Bug 30275: Add basic unit test for fetching renewals
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:16:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:16:00 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-3p7Xn9sfe9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #115 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134191
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134191&action=edit
    Bug 30275: (follow-up) Rebase fixes
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:16:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:16:09 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-tCWmlUKkFG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #116 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134192
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134192&action=edit
    Bug 30275: Add renewals relation to Koha::Old::Checkout
    
    Add the new 'renewals' relation to Koha::Old::Checkout to return a
    list of Koha::Checkouts::Renewal objects.
    
    We also add the same relation to the OldIssue schema inline.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:16:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:16:17 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-DWJPglEsIy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #117 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134193
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134193&action=edit
    Bug 30275: (QA follow-up) Rename columns to match API
    
    This patch performs the following column renames:
    
    * id => renewal_id
    * issue_id => checkout_id
    
    The idea is that no translation is needed for the API, and also, being a
    new table, we can educate the users into the 'to be' terminology we are
    leaning towards, instead of having them learn one naming to create
    reports and then need to translate them once we normalize things in a
    future.
    
    That said, this is simple to review.
    
    Apply this patch and repeat the test plan.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:19:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:19:20 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-fYrMXMaEeB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                       |y.org                       |
    
    --- Comment #118 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    I'll finish my review tomorrow.
    
    Overall, this is what I wanted to see on bug 23838, so I'm happy for this,
    Martin. Great!
    
    It is lacking (at least) tests for the new Koha::Checkouts::Renewal->store
    method. I can add it, but got late today to do it.
    
    I would like to see some higher-level method, like Koha::Checkout->renew and
    start removing old code but we can do that in a follow-up, this is solid as it
    stands.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:34:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:34:55 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-KqlQqtiB7j@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #235 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Created attachment 134194
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134194&action=edit
    Bug 29648: (follow-up) Add missing raw filter
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:45:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:45:38 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-Cn5tS14buo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #236 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Great enhancement.
    I push it asap to avoid more rebase.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:48:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:48:24 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-aHOhPk3XXU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #237 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Ah we should remove "actions" from default sort order.
    My 2c
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:52:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:52:21 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-2w7uSztIOR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #238 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    (In reply to Fridolin Somers from comment #237)
    > Ah we should remove "actions" from default sort order.
    > My 2c
    
    And also "selection".
    
    Using them does not break the table, ouf ;)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 22:53:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 20:53:19 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-RWN4fGhFZQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #239 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    I've added to DBRev a print when preference was enabled :
      "NumSavedReports value '20' moved to table settings"
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 23:22:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 21:22:30 +0000
    Subject: [Koha-bugs] [Bug 29092] Table settings for account_fines table is
     missing Updated on column and hides the wrong things
    In-Reply-To: <bug-29092-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29092-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29092-70-46SuPXNnG6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29092
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 23:22:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 21:22:33 +0000
    Subject: [Koha-bugs] [Bug 29092] Table settings for account_fines table is
     missing Updated on column and hides the wrong things
    In-Reply-To: <bug-29092-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29092-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29092-70-MunyialNbY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29092
    
    --- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 23:22:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 21:22:35 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-f4BaXr0TSA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 23:22:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 21:22:38 +0000
    Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and
     'default sort' configurable
    In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29648-70-f93yWBQsO8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648
    
    --- Comment #240 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 23:22:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 21:22:41 +0000
    Subject: [Koha-bugs] [Bug 30136] Add back to top button when scrolling
    In-Reply-To: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30136-70-7qlAYhzDaP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 23:22:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 21:22:44 +0000
    Subject: [Koha-bugs] [Bug 30136] Add back to top button when scrolling
    In-Reply-To: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30136-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30136-70-ukmsLDJ9mx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136
    
    --- Comment #23 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Wed Apr 27 23:27:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 21:27:41 +0000
    Subject: [Koha-bugs] [Bug 28575] Add ability to choose if lost fee is
     refunded based on when lost fee was paid off
    In-Reply-To: <bug-28575-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28575-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28575-70-zuzljNl92x@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575
    
    Lisette Scheer <lisetteslatah at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lisetteslatah at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 00:56:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 22:56:44 +0000
    Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
     characters from input fields when cataloguing
    In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30358-70-NfJJY1U1T9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358
    
    --- Comment #15 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Created attachment 134195
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134195&action=edit
    Bug 30358: (follow-up) Consider field has multiple subfields of same key
    
    To test:
    
    1) Click the clone subfield button to make multiple subfields with the
    same key, i.e. 500$a$a$a
    2) Save the record and confirm that the fields contain the correct data
    after whitespaces are stripped.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 01:17:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 23:17:59 +0000
    Subject: [Koha-bugs] [Bug 22223] Item url double-encode when parameter is an
     encoded URL
    In-Reply-To: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22223-70-lrCPLxxolw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22223
    
    --- Comment #41 from David Cook <dcook at prosentient.com.au> ---
    (In reply to Fridolin Somers from comment #40)
    > That code looks very strange to me.
    > Naming a TT filter 'Filter'.
    > 
    > I would prefer to see syntax : [% var | $NoDoubleEncode %]
    > Like TT plugin Price.
    > 
    > Class is using :
    > Base qw( Template::Plugin::Filter )
    > But does not implement a 'filter' method.
    
    I think a good alternative would be what I suggest at
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22223#c7 as well.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 01:40:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 23:40:11 +0000
    Subject: [Koha-bugs] [Bug 29755] SIP2 code does not correctly handle
     NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees
    In-Reply-To: <bug-29755-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29755-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29755-70-G6zewwFFBW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 01:40:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 23:40:16 +0000
    Subject: [Koha-bugs] [Bug 29755] SIP2 code does not correctly handle
     NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees
    In-Reply-To: <bug-29755-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29755-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29755-70-1ZesYmqLhj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #130449|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from David Nind <david at davidnind.com> ---
    Created attachment 134196
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134196&action=edit
    Bug 29755: Check each NoIssuesCharge separately
    
    This patch updates SIP patron code to use account methods to calculate balances
    over the patronflags returns. It also checks if patron should be blocked for
    each
    'No Issues charge' preference
    
    Tests are added for NoIssuesChargeGuarantees
    
    To test:
     1 - Set noissuescharge preference to 5
     2 - Add a $10 charge to a patron
     3 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l
    CPL -m patron_information --patron BARCODE
     4 - Note the 64 message starts with Y's that mean patron is blocked
     5 - Set noissuescharge to 11
     6 - Repeat 3, patron is no longer blocked
     7 - Set NoIssuesChargeGuarantees to 8
     8 - Repeat 3, patron is blocked
     9 - Pay $3 on patron so they owe 7
    10 - Repeat 3, patron is not blocked
    11 - Add a child account with patron as guarantor
    12 - Repeat 3, patron is not blocked
    13 - Add a $4 charge to child
    14 - Repeat 3, patron is blocked
    15 - Repeat 3, but with child barcode, child is not blocked
    16 - Set NoIssuesChargeGuarantorsWithGuarantees to 11
    17 - Repeat 3, patron is blocked
    18 - Repeat 3 with child barcode, child is blocked
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 01:47:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 23:47:52 +0000
    Subject: [Koha-bugs] [Bug 29755] SIP2 code does not correctly handle
     NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees
    In-Reply-To: <bug-29755-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29755-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29755-70-zE4hAfhKha@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Failed QA
                     CC|                            |david at davidnind.com
    
    --- Comment #3 from David Nind <david at davidnind.com> ---
    After signing off, I ran the tests and they failed:
    
    prove t/db_dependent/SIP/Patron.t 
    t/db_dependent/SIP/Patron.t .. 8/10 
        #   Failed test 'Guarantee only fines correctly counted'
        #   at t/db_dependent/SIP/Patron.t line 318.
        #          got: '11.11'
        #     expected: '0.11'
    
        #   Failed test 'Guarantee not blocked by guarantor fines'
        #   at t/db_dependent/SIP/Patron.t line 319.
        # Looks like you failed 2 tests of 4.
    t/db_dependent/SIP/Patron.t .. 9/10 
    #   Failed test 'NoIssuesChargeGuarantees tests'
    #   at t/db_dependent/SIP/Patron.t line 322.
    t/db_dependent/SIP/Patron.t .. 10/10 # Looks like you failed 1 test of 10.
    t/db_dependent/SIP/Patron.t .. Dubious, test returned 1 (wstat 256, 0x100)
    Failed 1/10 subtests 
    
    Test Summary Report
    -------------------
    t/db_dependent/SIP/Patron.t (Wstat: 256 Tests: 10 Failed: 1)
      Failed test:  9
      Non-zero exit status: 1
    Files=1, Tests=10,  9 wallclock secs ( 0.04 usr  0.01 sys +  7.56 cusr  1.12
    csys =  8.73 CPU)
    Result: FAIL
    
    Also, for steps 16-18 of the test plan, I think step 16 needs changing to "16 -
    Set NoIssuesChargeGuarantorsWithGuarantees to 10", rather than 11. 
    - If 11 is used, the patrons and the child are not blocked.
    - The wording for the system preference is "Prevent a patron from checking out
    if the patron has guarantors and those guarantor's guarantees owing in total
    more than X USD in fines."
    - The key part is "MORE THAN X USD". In the test, the total is 11.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 01:57:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 23:57:06 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-ItnmeRlDK0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |dcook at prosentient.com.au
    
    --- Comment #119 from David Cook <dcook at prosentient.com.au> ---
    (In reply to Tomás Cohen Arazi from comment #118)
    > I would like to see some higher-level method, like Koha::Checkout->renew and
    > start removing old code but we can do that in a follow-up
    
    +1
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 01:58:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Wed, 27 Apr 2022 23:58:51 +0000
    Subject: [Koha-bugs] [Bug 29755] SIP2 code does not correctly handle
     NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees
    In-Reply-To: <bug-29755-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29755-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29755-70-OV6OXt0h06@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
      Text to go in the|                            |This fixes SIP2 so that it
          release notes|                            |correctly determines if
                       |                            |issues should be blocked
                       |                            |for patrons when the
                       |                            |NoIssuesChargeGuarantees
                       |                            |and
                       |                            |NoIssuesChargeGuarantorsWit
                       |                            |hGuarantees system
                       |                            |preferences are set.
                       |                            |Currently, it only checks
                       |                            |the noissuescharge system
                       |                            |preference as the limit for
                       |                            |charges, and not the other
                       |                            |'No Issues charge' system
                       |                            |preferences.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 02:15:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 00:15:00 +0000
    Subject: [Koha-bugs] [Bug 30167] Return soonest renewal date when
     CanBookBeRenewed returns %too_soon
    In-Reply-To: <bug-30167-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30167-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30167-70-RU2ZIbEvC6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30167
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 02:15:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 00:15:06 +0000
    Subject: [Koha-bugs] [Bug 30167] Return soonest renewal date when
     CanBookBeRenewed returns %too_soon
    In-Reply-To: <bug-30167-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30167-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30167-70-Wn6ti7cvg6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30167
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134082|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from David Nind <david at davidnind.com> ---
    Created attachment 134197
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134197&action=edit
    Bug 30167: Return soonest renewal date when renewal is to soon
    
    This patch adds an 'info' return param to CanBookBeRenewed and passes
    the soonest renewal date when returning too_soon errors
    
    To test:
    1 - prove -v t/db_dependent/Circulation.t
    
    Fix whitespace
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 02:15:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 00:15:11 +0000
    Subject: [Koha-bugs] [Bug 30167] Return soonest renewal date when
     CanBookBeRenewed returns %too_soon
    In-Reply-To: <bug-30167-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30167-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30167-70-WZkr1fwAoi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30167
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134083|0                           |1
            is obsolete|                            |
    
    --- Comment #7 from David Nind <david at davidnind.com> ---
    Created attachment 134198
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134198&action=edit
    Bug 30167: Use returned renewal date rather than fetching
    
    This patch updates the three scripts that fetched the soonest renewal date
    to use the return from CanBookBeRenewed
    
    To test:
    1 - Set a circulation rule with a 'no renewal before' set to 3, loan length set
    to 5
    2 - Check out an item to a patron that uses this rule
    3 - Verify the checkouts for the patron show the correct 'No renewal before'
    date
    4 - Sign in to the patron's opac account
    5 - Verify the item shows it cannot be renewed, and shows the correct date
    6 - Go to Circulation->Renew
    7 - Attempt to renew using barcode
    8 - Confirm error shows the soonest renewal date
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 02:24:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 00:24:05 +0000
    Subject: [Koha-bugs] [Bug 30167] Return soonest renewal date when
     CanBookBeRenewed returns %too_soon
    In-Reply-To: <bug-30167-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30167-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30167-70-yJc62HKvlr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30167
    
    --- Comment #8 from David Nind <david at davidnind.com> ---
    Testing notes (koha-testing-docker):
    
    - Tested on 04/28/2022 (American date format) with 
      . 'no renewal before' set to 3
      . 'loan period' set to 5
    - Checked out on date is 04/28/2022 00:09 
    - For the patron from the checkouts: No renewal before 04/30/2022
    - When trying to renew, the message is: "Cannot renew:
        Programming Perl / ( 39999000011418 ) cannot be renewed before 04/30/2022.
    "
    - Date is calculated correctly including the current day (3 days - 28th, 29th +
    30th)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 03:42:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 01:42:47 +0000
    Subject: [Koha-bugs] [Bug 30636] New: ILS-DI shows incorrect availability
     when Notforloan by Itemtype
    Message-ID: <bug-30636-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30636
    
                Bug ID: 30636
               Summary: ILS-DI shows incorrect availability when Notforloan by
                        Itemtype
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Web services
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: dcook at prosentient.com.au
            QA Contact: testopia at bugs.koha-community.org
    
    If you've marked an item type as "Not for loan" in Koha, it'll show a "Status"
    of "Not for loan" in the catalogue, but the ILS-DI GetAvailability service will
    advertise it as still available.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 03:44:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 01:44:27 +0000
    Subject: [Koha-bugs] [Bug 30636] ILS-DI shows incorrect availability when
     Notforloan by Itemtype
    In-Reply-To: <bug-30636-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30636-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30636-70-XxcyZp7iqR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30636
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au
                       |ity.org                     |
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 04:53:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 02:53:35 +0000
    Subject: [Koha-bugs] [Bug 22204] Leading spaces in barcode should not
     allowed in cataloguing
    In-Reply-To: <bug-22204-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22204-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22204-70-RznPYwYb2w@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22204
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |DUPLICATE
                 Status|Patch doesn't apply         |RESOLVED
    
    --- Comment #15 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    
    
    *** This bug has been marked as a duplicate of bug 30409 ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 04:53:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 02:53:35 +0000
    Subject: [Koha-bugs] [Bug 30409] barcodedecode() should always trim barcode
    In-Reply-To: <bug-30409-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30409-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30409-70-3SE88lymy6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409
    
    --- Comment #7 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    *** Bug 22204 has been marked as a duplicate of this bug. ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 05:02:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 03:02:52 +0000
    Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck
     modules for Koha
    In-Reply-To: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30444-70-yYSqLf9xGu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444
    
    Alex Buckley <alexbuckley at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134007|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 05:04:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 03:04:02 +0000
    Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck
     modules for Koha
    In-Reply-To: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30444-70-RwiTuIguuO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444
    
    --- Comment #10 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
    Created attachment 134199
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134199&action=edit
    Bug 30444: (follow-up) Ensure Self checkout by cardnumber and username/password
    works
    
    Test plan:
    1. On a Koha setup to do Shibboleth set the following sysprefs:
    - OPACShibOnly = "Don't allow"
    - AutoSelfCheckAllowed = Allow
    - AutoSelfCheckID and AutoSelfCheckPass = The username and password of a
    patron with 'self_checkout_module' sub-permission enabled
    - SelfCheckoutByLogin = 'cardnumber'
    2. Visit the self checkout page. Confirm a 'cardnumber' input page is
    loaded
    3. Enter a cardnumber and confirm the self checkout page loads
    4. Change SelfCheckoutbyLogin = 'username and password'
    5. Repeat step 2 and confirm a username and password input page loads.
    6. Enter a username and password and confirm the self checkout page
    loads
    7. Change SelfCheckoutByLogin = 'shibboleth'
    8. Repeat step 2 and confirm you're logged straight into the self
    checkout
    
    Sponsored-by: Catalyst IT
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 06:40:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 04:40:16 +0000
    Subject: [Koha-bugs] [Bug 30636] ILS-DI shows incorrect availability when
     Notforloan by Itemtype
    In-Reply-To: <bug-30636-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30636-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30636-70-a7g0yGBzJT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30636
    
    --- Comment #1 from David Cook <dcook at prosentient.com.au> ---
    Unfortunately, detail.tt uses item.notforloan_per_itemtype which is a column
    alias from a custom SQL query in C4/Items.pm. 
    
    In theory, we could just add a Koha::Item->notforloan_per_itemtype method, but
    then it seems like Koha::Item->notforloan is often used as a boolean to
    determine if an item is not for loan... and sometimes Koha::Item->notforloan is
    used for its particular "Not for loan" description. 
    
    It seems to me that we might be better off creating a new method like
    Koha::Item->is_not_for_loan() which returns a boolean response based on the
    "notforloan" value and whether it's "Not for loan" based on its item type.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 07:50:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 05:50:31 +0000
    Subject: [Koha-bugs] [Bug 30636] ILS-DI shows incorrect availability when
     Notforloan by Itemtype
    In-Reply-To: <bug-30636-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30636-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30636-70-SwZvs2S77R@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30636
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 07:50:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 05:50:35 +0000
    Subject: [Koha-bugs] [Bug 30636] ILS-DI shows incorrect availability when
     Notforloan by Itemtype
    In-Reply-To: <bug-30636-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30636-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30636-70-6VS2Xa59q0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30636
    
    --- Comment #2 from David Cook <dcook at prosentient.com.au> ---
    Created attachment 134200
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134200&action=edit
    Bug 30636: Show notforloan availability correctly in ILS-DI
    
    This patch adds the Koha::Item->is_notforloan() method which checks
    the item status of "notforloan" and it checks the effective item type
    to see if it's marked as "notforloan". This change brings ILS-DI in line
    with the catalogue which displays "Not for loan" for both those scenarios.
    
    0. Don't apply patch yet
    1. Enable ILS-DI system preference
    http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=ILS-DI
    2. Change Item types to "Not for Loan" for Books
    http://localhost:8081/cgi-bin/koha/admin/itemtypes.pl?op=add_form&itemtype=BK
    3. Note that book is listed as "Not for loan" in catalogue
    http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29&searchid=scs_1651115075364
    4. Note that book is listed as "available" via ILS-DI
    http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=29&id_type=bib
    
    5. Apply patch and restart starman (ie koha-plack --restart kohadev)
    
    6. Note that book is listed as "not available" and "Not for loan" via ILS-DI
    http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=29&id_type=bib
    
    --
    
    7. prove t/db_dependent/Koha/Item.t
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 07:51:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 05:51:28 +0000
    Subject: [Koha-bugs] [Bug 30636] ILS-DI shows incorrect availability when
     Notforloan by Itemtype
    In-Reply-To: <bug-30636-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30636-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30636-70-mGu8RwsJ9M@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30636
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134200|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from David Cook <dcook at prosentient.com.au> ---
    Created attachment 134201
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134201&action=edit
    Bug 30636: Show notforloan availability correctly in ILS-DI
    
    This patch adds the Koha::Item->is_notforloan() method which checks
    the item status of "notforloan" and it checks the effective item type
    to see if it's marked as "notforloan". This change brings ILS-DI in line
    with the catalogue which displays "Not for loan" for both those scenarios.
    
    0. Don't apply patch yet
    1. Enable ILS-DI system preference
    http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=ILS-DI
    2. Change Item types to "Not for Loan" for Books
    http://localhost:8081/cgi-bin/koha/admin/itemtypes.pl?op=add_form&itemtype=BK
    3. Note that book is listed as "Not for loan" in catalogue
    http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29&searchid=scs_1651115075364
    4. Note that book is listed as "available" via ILS-DI
    http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=29&id_type=bib
    
    5. Apply patch and restart starman (ie koha-plack --restart kohadev)
    
    6. Note that book is listed as "not available" and "Not for loan" via ILS-DI
    http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=29&id_type=bib
    
    --
    
    7. prove t/db_dependent/Koha/Item.t
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 08:25:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 06:25:34 +0000
    Subject: [Koha-bugs] [Bug 30328] Add ability to generate barcode with branch
     specific prefix
    In-Reply-To: <bug-30328-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30328-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30328-70-zycCPr0oRx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328
    
    Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134009|0                           |1
            is obsolete|                            |
    
    --- Comment #7 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
    Created attachment 134202
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134202&action=edit
    Bug 30328: Add ability to generate barcode with branch specific prefix
    
    We should add more flexibility to generating barcodes by letting libraries
    define branch specific prefix for their barcodes. This patch adds new option
    "preyyyymmincr" in systempreference "autoBarcode" and new systempreference
    "BarcodePrefix" to define branch specific prefix
    
    Test plan for adding item:
    
    1. Apply patch and update database
    2. Set syspref "autoBarcode" as
    3. Add some values to syspref "Barcodeprefix" e.g.:
            Default: DEF
            CPL: CPL
            FFL: FFL
    4. Now change your library to CPL (if needed) and add an item
    5. Click barcode input field
       => barcode should be CPL<current_year><current_month>00001
    6. Add another item and click barcode field
       => barcode should be CPL<current_year><current_month>00002
    7. Change your library to FFL and add an item
       => barcode should now be FFL<current_year><current_month>00001
    8. Change your library to e.g. FPL (or another as long as it doesn't have
    prefix value
    in "Barcodeprefix"), add an item and click barcode field
       => barcode should now be DEF<current_year><current_month>00001
    9. Try to add multiple items
       => barcodes incremental value should increase in order (no skipping values,
    no errors)
    
    Test plan for adding multiple aqcuisitions:
    
    1. Set syspref "AcqCreateItem" as "placing order".
    2. Create an order and add multiple items to it.
    3. Save the order.
    4. Navigate to that biblios detail page to which you added items.
       => ordered items barcodes incremental value should increase in order (no
    skipping
          values, no errors)
    
    Also prove t/db_dependent/Barcodes_ValueBuilder.t and
    t/Barcodes_preyyyymmincr.t
    
    Sponsored-by: Koha-Suomi Oy
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 08:34:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 06:34:58 +0000
    Subject: [Koha-bugs] [Bug 2244] RFID Cataloguing - Programming RFID tags
     from Koha
    In-Reply-To: <bug-2244-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-2244-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-2244-70-JhzmfqtM6i@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2244
    
    Michal Denar <black23 at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |black23 at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 08:49:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 06:49:33 +0000
    Subject: [Koha-bugs] [Bug 30328] Add ability to generate barcode with branch
     specific prefix
    In-Reply-To: <bug-30328-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30328-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30328-70-WF1YkYOuuo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328
    
    --- Comment #8 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
    (In reply to Owen Leonard from comment #5)
    > I think the description of the BarcodePrefix preference should say that it
    > is used in connection with the autoBarcode preference, and include a link to
    > it (and vice versa). For example:
    > 
    > "Define library specific barcode prefixes in YAML format. This defines the
    > behavior of the <code><prefix>yyyymm0001</code> option of
    > <a>autoBarcode</a>."
    > 
    > And added to the autoBarcode description, "Define the behavior of the
    > <code><prefix>yyyymm0001</code> option using <a>BarcodePrefix</a>."
    > 
    Added links to descriptions and also changed BarcodePrefix as CodeMirror
    editor.
    
    > Should the BarcodePrefix preference provide an example for the syntax which
    > is expected? Or perhaps a link to the wiki like OpacHiddenItems has?
    > 
    
    Oh, I didn't notice this one. But I guess it would be more convenient to
    provide example on the sysprefs description rather than external wiki page.
    Something like 
    "Syntax for barcodes is e.g. <code>DEF2022040001</code>".
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 09:08:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 07:08:20 +0000
    Subject: [Koha-bugs] [Bug 22223] Item url double-encode when parameter is an
     encoded URL
    In-Reply-To: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22223-70-rCLlhq4Rng@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22223
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|jonathan.druart+koha at gmail. |oleonard at myacpl.org
                       |com                         |
                 Status|Passed QA                   |In Discussion
    
    --- Comment #42 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    (In reply to Fridolin Somers from comment #40)
    > That code looks very strange to me.
    > Naming a TT filter 'Filter'.
    > 
    > I would prefer to see syntax : [% var | $NoDoubleEncode %]
    > Like TT plugin Price.
    > 
    > Class is using :
    > Base qw( Template::Plugin::Filter )
    > But does not implement a 'filter' method.
    
    The idea was to have a module that would deal with other encode/decode, or
    replacements functions.
    I still think it is a good idea.
    
    I don't have more time to dedicate to this patch unfortunately.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 09:23:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 07:23:37 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-DuT04xWwya@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    (In reply to Katrin Fischer from comment #9)
    > Could you provide a test plan for this one?
    
    Go to /cgi-bin/koha/members/members-home.pl
    Click search without providing any terms
    Search "henry" in the global DT search and "h" in the "Name" column filter
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 09:26:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 07:26:35 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-o4M1NSNHLY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #120 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Awesome, thanks for the review Tomas. I'm happy to work on tests today,
    revisiting it yesterday my intention was to add some more tests as I also found
    them to be lacking. I got held up as it appears Circulation.t is failing
    already due to the constraint added here.. but I can't for the life of me work
    out why as the data does appear to be present and correct in k-t-d where I was
    testing.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 09:35:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 07:35:48 +0000
    Subject: [Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers
     is inefficient
    In-Reply-To: <bug-28709-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28709-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28709-70-IPnLnpOSpX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709
    
    Josef Moravec <josef.moravec at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |josef.moravec at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 09:40:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 07:40:40 +0000
    Subject: [Koha-bugs] [Bug 30630] Checking in a waiting hold at another
     branch when HoldsAutoFill is enabled causes errors
    In-Reply-To: <bug-30630-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30630-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30630-70-KCyh2vMf6A@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com
    
    --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    yes, *should* :)
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 09:45:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 07:45:25 +0000
    Subject: [Koha-bugs] [Bug 7709] Cover Images Template plugin
    In-Reply-To: <bug-7709-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-7709-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-7709-70-MlMzcZQd89@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7709
    
    Michal Denar <black23 at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |black23 at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 09:46:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 07:46:39 +0000
    Subject: [Koha-bugs] [Bug 30630] Checking in a waiting hold at another
     branch when HoldsAutoFill is enabled causes errors
    In-Reply-To: <bug-30630-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30630-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30630-70-wNxdFjr1j2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 09:46:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 07:46:44 +0000
    Subject: [Koha-bugs] [Bug 30630] Checking in a waiting hold at another
     branch when HoldsAutoFill is enabled causes errors
    In-Reply-To: <bug-30630-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30630-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30630-70-M6kYEKWCYI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630
    
    --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134203
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134203&action=edit
    Bug 30630: Prevent crash on check-in if HoldsAutoFill is ON
    
    RevertWaitingStatus has already removed the itemnumber from the hold, passing
    $itemnumber (from scanned item) should work, as it will reattach the hold to
    the item
    
    Test plan:
    1 - Enable HoldsAutoFill
    2 - Place a title level hold
    3 - Check in an item and confirm hold
    4 - Switch to another branch
    5 - Checkin the item
    Without this patch you got
    Can't call method "biblionumber" on an undefined value at
    /kohadevbox/koha/C4/Reserves.pm line 1577.
     at /kohadevbox/koha/C4/Reserves.pm line 1576
    With this patch applied the operation succeeds
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 09:46:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 07:46:55 +0000
    Subject: [Koha-bugs] [Bug 30630] Checking in a waiting hold at another
     branch when HoldsAutoFill is enabled causes errors
    In-Reply-To: <bug-30630-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30630-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30630-70-YE5oIcxFhe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                       |ity.org                     |com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 09:50:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 07:50:04 +0000
    Subject: [Koha-bugs] [Bug 22490] Some strings in JavaScript files are
     untranslatable
    In-Reply-To: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22490-70-QXclGYHbWX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22490
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134072|0                           |1
            is obsolete|                            |
    
    --- Comment #10 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> ---
    Created attachment 134204
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134204&action=edit
    Bug 22490: Some strings in JavaScript files are untranslatable
    
    This patch updates the translation functions of the strings in Javascript files
    
    Test Plan:
    1) Find a string in a popup or from a Javascript file who is still not
    translated
    or
    1) Home > Administration > Authority types
    2) Make sure to have at least one Authority type saved
    3) Click on Action > Import
    4) Import button without adding any file to trigger the popup
    5) The string inside the popup appears without translation
    6) Apply patch and repeat from 3) to 5) : now the string is translated
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 09:53:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 07:53:45 +0000
    Subject: [Koha-bugs] [Bug 30387] IndependentBranches allows users to change
     libraries when they should not be able to
    In-Reply-To: <bug-30387-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30387-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30387-70-3NobAO876x@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30387
    
    --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    (In reply to Martin Renvoize from comment #6)
    > Hmm, wasn't there actually a reason cataloguers needed to be able to change
    > library?  I have a feeling this was a feature rather than a bug as I've
    > asked this question before.. ccing people to help dredge the hive mind.
    
    It's the purpose of bug 29887 if I understand correctly.
    
    This patch should provide a change at the controller level (and not only hide
    the link in the template).
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 10:16:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 08:16:45 +0000
    Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen
    In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23919-70-FjsDkXPTIq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919
    
    Andrew Nugged <nugged at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |nugged at gmail.com
                 Status|NEW                         |ASSIGNED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 10:18:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 08:18:04 +0000
    Subject: [Koha-bugs] [Bug 30637] New: Add Koha::Checkout->renew method
    Message-ID: <bug-30637-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30637
    
                Bug ID: 30637
               Summary: Add Koha::Checkout->renew method
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Architecture, internals, and plumbing
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: martin.renvoize at ptfs-europe.com
            QA Contact: testopia at bugs.koha-community.org
    
    We should introduce a `renew` method in the Koha::Checkout object and start to
    migrate calls from C4::Circulation to it.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 10:19:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 08:19:17 +0000
    Subject: [Koha-bugs] [Bug 30637] Add Koha::Checkout->renew method
    In-Reply-To: <bug-30637-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30637-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30637-70-3X6AHE57GZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30637
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30275
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    [Bug 30275] Checkout renewals should be stored in their own table
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 10:19:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 08:19:17 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-DUxtwRuROz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30637
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30637
    [Bug 30637] Add Koha::Checkout->renew method
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 10:35:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 08:35:19 +0000
    Subject: [Koha-bugs] [Bug 30628] Batch borrower modifications only affect
     the current page
    In-Reply-To: <bug-30628-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30628-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30628-70-x2QK1IVNsr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 10:35:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 08:35:24 +0000
    Subject: [Koha-bugs] [Bug 30628] Batch borrower modifications only affect
     the current page
    In-Reply-To: <bug-30628-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30628-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30628-70-Onow6FmNkT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628
    
    --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134205
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134205&action=edit
    Bug 30628: Fix patron selection in batch patron modification tool
    
    bug 28014 added Datatables to this view, but the form is submitted with
    only the checkboxes from the first page.
    
    Solution adapted from
    https://stackoverflow.com/questions/33240409/how-to-submit-checkboxes-from-all-pages-with-jquery-datatables
    
    Test plan:
    Have more than 20 cardnumbers, use the batch patron modification tool
    Select (not all) patrons from the first page and second page
    Submit the form
    Notice that the patrons you have selected appear on the confirmation
    page.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 10:36:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 08:36:05 +0000
    Subject: [Koha-bugs] [Bug 30628] Batch borrower modifications only affect
     the current page
    In-Reply-To: <bug-30628-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30628-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30628-70-9ShJYba49d@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                       |ity.org                     |com
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 10:36:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 08:36:16 +0000
    Subject: [Koha-bugs] [Bug 30628] Batch borrower modifications only affect
     the current page
    In-Reply-To: <bug-30628-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30628-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30628-70-rCzk2z7spR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |rel_21_05_candidate,
                       |                            |rel_21_11_candidate
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 10:38:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 08:38:40 +0000
    Subject: [Koha-bugs] [Bug 30620] Add a warning close to /*!VERSION lines in
     kohastructure.sql
    In-Reply-To: <bug-30620-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30620-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30620-70-vm04bAxVRH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30620
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com
    
    --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Not a good idea, kohastructure.sql will be regenerated at the next major
    release.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 10:45:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 08:45:11 +0000
    Subject: [Koha-bugs] [Bug 26947] kohastructure.sql should be updated for
     each release
    In-Reply-To: <bug-26947-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26947-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26947-70-VB7blWcpAj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947
    
    --- Comment #65 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    (In reply to Marcel de Rooy from comment #63)
    > And in line with the former comments, the following commit made lots of
    > useless changes in kohastructure:
    
    
    > Could you remove them, Jonathan ?
    
    As said on another bug report, this kohastructure.sql will be auto generated
    when 22.05.00 will be released. We should not add manual changes to it (apart
    from the usual changes). If you want to modify it you should adjust mysqldump's
    output (which was already not trivial if you read the previous comments). Or
    sed it and modify koha-dump.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:01:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:01:57 +0000
    Subject: [Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today
     when storing an item
    In-Reply-To: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29958-70-ZD3VHugTeR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Dateaccessioned is set to   |Missing dateaccessioned is
                       |todays date if missing when |set to today when storing
                       |storing an item.            |an item
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:02:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:02:31 +0000
    Subject: [Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today
     when storing an item
    In-Reply-To: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29958-70-gL4XGyHtqv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958
    
    --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Did you see:
    
    29815   Koha    Serials alexbuckley at catalyst.net.nz     Push    ---    
    Pre-populate 'Date acquired' field when adding/editing items
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:03:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:03:57 +0000
    Subject: [Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today
     when storing an item
    In-Reply-To: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29958-70-gJSU7x8Jka@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Version|20.05                       |master
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:06:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:06:53 +0000
    Subject: [Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today
     when storing an item
    In-Reply-To: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29958-70-AWpIcVs5jD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958
    
    --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Hm, as Koha always forced dateaccessioned itself, I wonder if this is not
    actually a data problem :(
    
    The field cannot be null, unless you explicitly forced it to be. When migrating
    data using the import tools, the date is also set.
    
    The only way to end up with empty is by migrating with SQL, I think.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:08:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:08:08 +0000
    Subject: [Koha-bugs] [Bug 30328] Add ability to generate barcode with branch
     specific prefix
    In-Reply-To: <bug-30328-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30328-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30328-70-ecZygNUSkS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328
    
    Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134202|0                           |1
            is obsolete|                            |
    
    --- Comment #9 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
    Created attachment 134206
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134206&action=edit
    Bug 30328: Add ability to generate barcode with branch specific prefix
    
    We should add more flexibility to generating barcodes by letting libraries
    define branch specific prefix for their barcodes. This patch adds new option
    "preyyyymmincr" in systempreference "autoBarcode" and new systempreference
    "BarcodePrefix" to define branch specific prefix
    
    Test plan for adding item:
    
    1. Apply patch and update database
    2. Set syspref "autoBarcode" as
    3. Add some values to syspref "Barcodeprefix" e.g.:
            Default: DEF
            CPL: CPL
            FFL: FFL
    4. Now change your library to CPL (if needed) and add an item
    5. Click barcode input field
       => barcode should be CPL<current_year><current_month>00001
    6. Add another item and click barcode field
       => barcode should be CPL<current_year><current_month>00002
    7. Change your library to FFL and add an item
       => barcode should now be FFL<current_year><current_month>00001
    8. Change your library to e.g. FPL (or another as long as it doesn't have
    prefix value
    in "Barcodeprefix"), add an item and click barcode field
       => barcode should now be DEF<current_year><current_month>00001
    9. Try to add multiple items
       => barcodes incremental value should increase in order (no skipping values,
    no errors)
    
    Test plan for adding multiple aqcuisitions:
    
    1. Set syspref "AcqCreateItem" as "placing order".
    2. Create an order and add multiple items to it.
    3. Save the order.
    4. Navigate to that biblios detail page to which you added items.
       => ordered items barcodes incremental value should increase in order (no
    skipping
          values, no errors)
    
    Also prove t/db_dependent/Barcodes_ValueBuilder.t and
    t/Barcodes_preyyyymmincr.t
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:08:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:08:18 +0000
    Subject: [Koha-bugs] [Bug 30328] Add ability to generate barcode with branch
     specific prefix
    In-Reply-To: <bug-30328-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30328-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30328-70-UcoImn9vct@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328
    
    Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:16:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:16:45 +0000
    Subject: [Koha-bugs] [Bug 22490] Some strings in JavaScript files are
     untranslatable
    In-Reply-To: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22490-70-IAnl8txhET@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22490
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134204|0                           |1
            is obsolete|                            |
    
    --- Comment #11 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> ---
    Created attachment 134207
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134207&action=edit
    Bug 22490: Some strings in JavaScript files are untranslatable
    
    This patch updates the translation functions of the strings in Javascript files
    
    Test Plan:
    1) Find a string in a popup or from a Javascript file who is still not
    translated
    or
    1) Home > Administration > Authority types
    2) Make sure to have at least one Authority type saved
    3) Click on Action > Import
    4) Import button without adding any file to trigger the popup
    5) The string inside the popup appears without translation
    6) Apply patch and repeat from 3) to 5) : now the string is translated
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:16:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:16:49 +0000
    Subject: [Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today
     when storing an item
    In-Reply-To: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29958-70-ESmQahqyxB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958
    
    --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    If we would remove the second $self->dateaccessioned($today) that is after the
    modify branch in store, we still have the effect that opening an item that has
    a NULL date in dateaccessioned will be populated with today due to 29815 (the
    value builder will put today in that field now).
    
    Does it make more sense to choose some arbitrary date for all unknown acquired
    dates and run a SQL update to replace the NULLs? And even the 0000-00-00 values
    that I still discovered in my table too?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:18:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:18:28 +0000
    Subject: [Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today
     when storing an item
    In-Reply-To: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29958-70-udcGsVryYs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958
    
    --- Comment #5 from Andreas Jonsson <andreas.jonsson at kreablo.se> ---
    Indeed, missing dateaccessioned fields stems from data migration.  And
    sometimes there is not meaningful date in the source data, so it makes sense to
    allow it to be empty to indicate that the date is unknown.
    
    As it stands we have to use a garbage date such as 1901-01-01 to indicate that
    the date is unknown.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:18:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:18:51 +0000
    Subject: [Koha-bugs] [Bug 27768] Saving an item with an invalid
     dateaccessioned or replacementpricedate throws no helpful error
    In-Reply-To: <bug-27768-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27768-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27768-70-ArKkgVNgJO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27768
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com
    
    --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Current master as of today:
    
    Trying to save 24.99 does no longer work.
    Trying to save free text like 'test' does not work.
    
    An empty field results in date of today in record (no problem).
    
    But unfortunately I can still get 0000-00-00 into my records by entering
    0000-00-00 into the date field. It is displayed by the date picker as
    00-1-11-30 (meaning: November 30 of year -1 ??) but gets stored as 0000-00-00.
    
    Also note: I can also save 0000-01-01. Or 0001-01-01, 0002-02-01, etc. Years
    like 0001 are displayed in the date picker as 1901 ?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:20:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:20:39 +0000
    Subject: [Koha-bugs] [Bug 27768] Saving an item with an invalid
     dateaccessioned or replacementpricedate throws no helpful error
    In-Reply-To: <bug-27768-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27768-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27768-70-CqEdI0APPW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27768
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=29815
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:20:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:20:39 +0000
    Subject: [Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when
     adding/editing items
    In-Reply-To: <bug-29815-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29815-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29815-70-smpFSkIGyj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=27768
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:21:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:21:04 +0000
    Subject: [Koha-bugs] [Bug 29915] Anonymous session generates 1 new session
     ID per hit
    In-Reply-To: <bug-29915-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29915-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29915-70-oSsiN6R1Qk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29915
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                 Status|Pushed to master            |RESOLVED
    
    --- Comment #129 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    (In reply to Andrew Fuerste-Henry from comment #128)
    > I've been unable to get this to apply to 21.05. Please rebase for backport.
    > Thanks!
    
    Fortunately this bug has been caused by bug 29914 and is not affecting 21.05.x!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:21:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:21:05 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-3qhNjUEXeg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    Bug 28786 depends on bug 29915, which changed state.
    
    Bug 29915 Summary: Anonymous session generates 1 new session ID per hit
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29915
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:21:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:21:05 +0000
    Subject: [Koha-bugs] [Bug 29954] Fix C4::Context->unset_userenv and rename
     _new too
    In-Reply-To: <bug-29954-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29954-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29954-70-rj60AE1kRQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29954
    Bug 29954 depends on bug 29915, which changed state.
    
    Bug 29915 Summary: Anonymous session generates 1 new session ID per hit
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29915
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:21:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:21:15 +0000
    Subject: [Koha-bugs] [Bug 30630] Checking in a waiting hold at another
     branch when HoldsAutoFill is enabled causes errors
    In-Reply-To: <bug-30630-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30630-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30630-70-fbUSP7qfUz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:21:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:21:19 +0000
    Subject: [Koha-bugs] [Bug 30630] Checking in a waiting hold at another
     branch when HoldsAutoFill is enabled causes errors
    In-Reply-To: <bug-30630-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30630-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30630-70-MnZ5qYb1yd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134203|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from David Nind <david at davidnind.com> ---
    Created attachment 134208
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134208&action=edit
    Bug 30630: Prevent crash on check-in if HoldsAutoFill is ON
    
    RevertWaitingStatus has already removed the itemnumber from the hold, passing
    $itemnumber (from scanned item) should work, as it will reattach the hold to
    the item
    
    Test plan:
    1 - Enable HoldsAutoFill
    2 - Place a title level hold
    3 - Check in an item and confirm hold
    4 - Switch to another branch
    5 - Checkin the item
    Without this patch you got
    Can't call method "biblionumber" on an undefined value at
    /kohadevbox/koha/C4/Reserves.pm line 1577.
     at /kohadevbox/koha/C4/Reserves.pm line 1576
    With this patch applied the operation succeeds
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:21:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:21:26 +0000
    Subject: [Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today
     when storing an item
    In-Reply-To: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29958-70-ushSIQ1j1p@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958
    
    --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Adding see also to bug 27768. Strange values like 0000-00-00, 0001-01-01 etc.
    Date picker does not like them either.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:21:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:21:27 +0000
    Subject: [Koha-bugs] [Bug 29915] Anonymous session generates 1 new session
     ID per hit
    In-Reply-To: <bug-29915-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29915-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29915-70-qNXwr4eXfV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29915
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|additional_work_needed      |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:21:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:21:44 +0000
    Subject: [Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today
     when storing an item
    In-Reply-To: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29958-70-a44ursAO3n@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=27768
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:21:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:21:44 +0000
    Subject: [Koha-bugs] [Bug 27768] Saving an item with an invalid
     dateaccessioned or replacementpricedate throws no helpful error
    In-Reply-To: <bug-27768-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27768-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27768-70-hFqKAaDYGH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27768
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=29958
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:22:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:22:40 +0000
    Subject: [Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today
     when storing an item
    In-Reply-To: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29958-70-5g1h8lsWKj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |alexbuckley at catalyst.net.nz
                       |                            |,
                       |                            |jonathan.druart+koha at gmail.
                       |                            |com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:23:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:23:04 +0000
    Subject: [Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today
     when storing an item
    In-Reply-To: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29958-70-f9RLLHoKsa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=29815
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:23:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:23:04 +0000
    Subject: [Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when
     adding/editing items
    In-Reply-To: <bug-29815-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29815-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29815-70-N81bJSr7kM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=29958
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:23:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:23:37 +0000
    Subject: [Koha-bugs] [Bug 27768] Saving an item with an invalid
     dateaccessioned or replacementpricedate throws no helpful error
    In-Reply-To: <bug-27768-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27768-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27768-70-exj3nVwt1V@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27768
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|https://bugs.koha-community |
                       |.org/bugzilla3/show_bug.cgi |
                       |?id=29815                   |
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:23:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:23:37 +0000
    Subject: [Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when
     adding/editing items
    In-Reply-To: <bug-29815-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29815-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29815-70-kEyrOzynkY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|https://bugs.koha-community |
                       |.org/bugzilla3/show_bug.cgi |
                       |?id=27768                   |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:28:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:28:37 +0000
    Subject: [Koha-bugs] [Bug 29623] Cache circulation rules
    In-Reply-To: <bug-29623-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29623-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29623-70-hFBapWb9QQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Patch doesn't apply         |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:28:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:28:41 +0000
    Subject: [Koha-bugs] [Bug 29623] Cache circulation rules
    In-Reply-To: <bug-29623-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29623-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29623-70-TD7JsR5Oc7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #128576|0                           |1
            is obsolete|                            |
    
    --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134209
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134209&action=edit
    Bug 29623: Cache circulation rules
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:31:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:31:49 +0000
    Subject: [Koha-bugs] [Bug 29623] Cache circulation rules
    In-Reply-To: <bug-29623-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29623-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29623-70-S5qoE8xPpO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
    
    --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    (In reply to Katrin Fischer from comment #5)
    > Could I get a test plan for this please?
    
    Confirm that the rule is taken into account where get_effective_rules is used
    (hardduedate for instance). And that a new value is used when modified in the
    circ matrix (ie. the cache is flushed when a rule is updated).
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:46:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:46:38 +0000
    Subject: [Koha-bugs] [Bug 27768] Saving an item with an invalid
     dateaccessioned or replacementpricedate throws no helpful error
    In-Reply-To: <bug-27768-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27768-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27768-70-LbUwWkgJj6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27768
    
    --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Marcel de Rooy from comment #2)
    > Current master as of today:
    > 
    > Trying to save 24.99 does no longer work.
    > Trying to save free text like 'test' does not work.
    > 
    > An empty field results in date of today in record (no problem).
    > 
    > But unfortunately I can still get 0000-00-00 into my records by entering
    > 0000-00-00 into the date field. It is displayed by the date picker as
    > 00-1-11-30 (meaning: November 30 of year -1 ??) but gets stored as
    > 0000-00-00.
    > 
    > Also note: I can also save 0000-01-01. Or 0001-01-01, 0002-02-01, etc. Years
    > like 0001 are displayed in the date picker as 1901 ?
    
    https://github.com/flatpickr/flatpickr/issues/1524
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:52:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:52:01 +0000
    Subject: [Koha-bugs] [Bug 27123] Add messages to batch patrons modification
    In-Reply-To: <bug-27123-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27123-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27123-70-7qORPtNs8K@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123
    
    Julian Maurice <julian.maurice at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |julian.maurice at biblibre.com
     Attachment #132925|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:53:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:53:27 +0000
    Subject: [Koha-bugs] [Bug 27123] Add messages to batch patrons modification
    In-Reply-To: <bug-27123-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27123-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27123-70-1ncl3zLkro@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132926|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:53:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:53:38 +0000
    Subject: [Koha-bugs] [Bug 27123] Add messages to batch patrons modification
    In-Reply-To: <bug-27123-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27123-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27123-70-dzHoAMyFrV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132927|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:58:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:58:31 +0000
    Subject: [Koha-bugs] [Bug 30638] New: Odd number of elements in anonymous
     hash at C4/Letters.pm line 827
    Message-ID: <bug-30638-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30638
    
                Bug ID: 30638
               Summary: Odd number of elements in anonymous hash at
                        C4/Letters.pm line 827
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Architecture, internals, and plumbing
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: m.de.rooy at rijksmuseum.nl
            QA Contact: testopia at bugs.koha-community.org
    
    Originating from 20.11 warnings: Odd number of elements in anonymous hash at
    C4/Letters.pm line 878
    
    output_pref({ dt => dt_from_string( $replacedby ), dateonly => $dateonly });
    
    This is line 827 on current master.
    
    If dt_from_string returns undef in list context, we get the odd number warn.
    
    Also note the following lines:
    
    if ( $letter->{ $letter_field } ) {
        $letter->{ $letter_field } =~
    s/\Q<<$table.$field$filter_string_used>>\E/$replacedby_date/g;
        $letter->{ $letter_field } =~
    s/\Q<<$field$filter_string_used>>\E/$replacedby_date/g;
    
    If output_pref should correctly return undef on a NULL from dt_from_string, the
    undefined result triggers two warnings in the regexes.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:59:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:59:08 +0000
    Subject: [Koha-bugs] [Bug 30638] Odd number of elements in anonymous hash at
     C4/Letters.pm line 827
    In-Reply-To: <bug-30638-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30638-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30638-70-TmUOLRWOo0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30638
    
    --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Probably related to 0000-00-00 in dateaccessioned. See 27768.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:59:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:59:10 +0000
    Subject: [Koha-bugs] [Bug 30623] Copy permissions from one user to another
    In-Reply-To: <bug-30623-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30623-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30623-70-dGq8jZ1wGe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30623
    
    Michal Denar <black23 at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |black23 at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 11:59:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 09:59:28 +0000
    Subject: [Koha-bugs] [Bug 30623] Copy permissions from one user to another
    In-Reply-To: <bug-30623-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30623-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30623-70-nz2uZAwfCr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30623
    
    --- Comment #1 from Michal Denar <black23 at gmail.com> ---
    +1
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:01:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:01:53 +0000
    Subject: [Koha-bugs] [Bug 27768] Saving an item with an invalid
     dateaccessioned or replacementpricedate throws no helpful error
    In-Reply-To: <bug-27768-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27768-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27768-70-e203Mmt3el@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27768
    
    --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    (In reply to Marcel de Rooy from comment #2)
    > But unfortunately I can still get 0000-00-00 into my records by entering
    > 0000-00-00 into the date field. It is displayed by the date picker as
    > 00-1-11-30 (meaning: November 30 of year -1 ??) but gets stored as
    > 0000-00-00.
    
    I don't recreate that, I am getting a 500 with
    
    Invalid value passed, dateaccessioned=00-1-11-30 expected type is date at
    /usr/share/perl5/Exception/Class/Base.pm line 88
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:02:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:02:53 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-yubQ3vzpKK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #121 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134210
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134210&action=edit
    Bug 30275: (follow-up) Drop renewer_id constraint
    
    This patch fixes some unit tests by ensureing we set a valid userid for
    mock userenv setting so that the foreign key constraint doesn't fail and
    it also removes the exception class and check for renewer_id from the
    store method as, for example with autorenewals, the renewal may not have
    been triggered by a actual user.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:04:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:04:20 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-l1h4M7myyz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:04:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:04:24 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-f3jnkSPUW7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134084|0                           |1
            is obsolete|                            |
     Attachment #134085|0                           |1
            is obsolete|                            |
    
    --- Comment #15 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134211
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134211&action=edit
    Bug 30576: Use DefaultPatronSearchFields in patron search
    
    This patch corrects the handling of the 'Standard' search field in
    patron searches such that it accurately reflects the contents of the
    DefaultPatronSearchFields system preference and falls back to a hard
    coded list instead of always using the hard coded list.
    
    To test:
    1) Empty the contents of DefaultPatronSearchFields systempreference
    2) Perform a patron search from the header search
    3) Inspect the patrons API request and note that we search on the
       default fallback fields of firstname, surname, othernames,
       cardnumber and userid (and some extended attributes which are
       historically hard coded).
    4) Navigate to the memebers-home by clicking the 'Patrons' button from
       the main page
    5) Perform another search using the filters on the left with 'Standard'
       selected.
    6) Note the same list of search fields used as above in the patrons API
       request.
    7) Update the DefaultPatronSearchFields systempreference adding one or
       more borrower fields in a comma delimited list.
    8) Repeat steps 2 -> 6 but this time upon inspecting the API request you
       should find that only the fields in your DefaultPatronSearchFields
       list are searched (along with the hard coded extended attributes
       list).
    9) Signoff
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:04:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:04:29 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-HcVQqIdbN3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    --- Comment #16 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134212
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134212&action=edit
    Bug 30576: (follow-up) Corrections to behaviour to reflect unit tests
    
    The unit tests highlighted my original patch didn't cover the full
    preference description.
    
    We now replace the 'standard' option with the fields from the preference
    and we also add those fields as options to the field selection in
    advanced searches.
    
    This patch also adjusts the tests to test for that and reflects the
    expected changes to the number of options displayed in the select boxes.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:04:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:04:43 +0000
    Subject: [Koha-bugs] [Bug 27619] Remove fr-FR installer data
    In-Reply-To: <bug-27619-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27619-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27619-70-3la4m4rmMM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #121625|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134213
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134213&action=edit
    Bug 27619: Add custom for fr-FR
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:05:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:05:03 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-jgkQDpiDRM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:05:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:05:08 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-GJK7NPGcSY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134055|0                           |1
            is obsolete|                            |
     Attachment #134056|0                           |1
            is obsolete|                            |
     Attachment #134057|0                           |1
            is obsolete|                            |
    
    --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134214
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134214&action=edit
    Bug 30626: DT REST API wrapper - Fix general search
    
    The general search query is not built correctly.
    
    Say you have a table with column filters, like the main patron search:
    General filter: henry
    Specific filter on the 'Name' column: h
    
    The generated query will be (= are actually LIKE):
    { Column1="henry" AND Column3="henry", ...} AND { Column2="h" }
    
    The first term does not contain the Column2 attribute.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:05:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:05:12 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-ta2D5PLJi9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    --- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134215
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134215&action=edit
    Bug 30626: Fix test
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:05:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:05:17 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-hvHsKt94RW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    --- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134216
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134216&action=edit
    Bug 30626: (QA follow-up) Fix test plan
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:05:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:05:57 +0000
    Subject: [Koha-bugs] [Bug 27619] Remove fr-FR installer data
    In-Reply-To: <bug-27619-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27619-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27619-70-aSPTvVmQh3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
                 Status|ASSIGNED                    |Needs Signoff
    
    --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Patches pushed to https://gitlab.com/joubu/Koha/-/commits/bug_27619
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:06:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:06:40 +0000
    Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal
    In-Reply-To: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25790-70-NahAm28MuU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30638
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30638
    [Bug 30638] Odd number of elements in anonymous hash at C4/Letters.pm line 827
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:06:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:06:40 +0000
    Subject: [Koha-bugs] [Bug 30638] Odd number of elements in anonymous hash at
     C4/Letters.pm line 827
    In-Reply-To: <bug-30638-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30638-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30638-70-PjFqous4Zq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30638
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |25790
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790
    [Bug 25790] [OMNIBUS] warnings removal
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:06:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:06:56 +0000
    Subject: [Koha-bugs] [Bug 30638] Odd number of elements in anonymous hash at
     C4/Letters.pm line 827
    In-Reply-To: <bug-30638-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30638-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30638-70-zuMAI7NiVz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30638
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                       |ity.org                     |
               Severity|enhancement                 |minor
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:07:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:07:09 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-BWjSpNixuC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|rel_22_05_candidate         |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:07:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:07:44 +0000
    Subject: [Koha-bugs] [Bug 30638] Odd number of elements in anonymous hash at
     C4/Letters.pm line 827
    In-Reply-To: <bug-30638-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30638-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30638-70-binemuscNO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30638
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
       Patch complexity|---                         |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:07:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:07:48 +0000
    Subject: [Koha-bugs] [Bug 30638] Odd number of elements in anonymous hash at
     C4/Letters.pm line 827
    In-Reply-To: <bug-30638-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30638-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30638-70-HNXOqxlp1Y@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30638
    
    --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 134217
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134217&action=edit
    Bug 30638: Resolve odd number in hash warn in Letters
    
    Odd number of elements in anonymous hash at C4/Letters.pm line 827.
    
    Trivial fix. Adding undefined check on result to prevent warns
    on that one.
    
    No test plan. Read the patch.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:08:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:08:12 +0000
    Subject: [Koha-bugs] [Bug 30638] Odd number of elements in anonymous hash at
     C4/Letters.pm line 827
    In-Reply-To: <bug-30638-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30638-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30638-70-le5JiXAUHU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30638
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Trivial: self SO
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:09:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:09:37 +0000
    Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
    In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23838-70-vDkEmhL9mj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
    
    --- Comment #64 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Note to self, must add 'Sponsored-by: Loughborough University' line back into
    patches
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:12:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:12:58 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-OWAWNUKsXr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    --- Comment #56 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Not to self, add in 'Sponsored-by: Cheshire Libraries' line.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:14:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:14:51 +0000
    Subject: [Koha-bugs] [Bug 30630] Checking in a waiting hold at another
     branch when HoldsAutoFill is enabled causes errors
    In-Reply-To: <bug-30630-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30630-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30630-70-Lr1Tk3zk7r@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:14:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:14:54 +0000
    Subject: [Koha-bugs] [Bug 30630] Checking in a waiting hold at another
     branch when HoldsAutoFill is enabled causes errors
    In-Reply-To: <bug-30630-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30630-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30630-70-bcwMFEuw2U@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134208|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134218
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134218&action=edit
    Bug 30630: Prevent crash on check-in if HoldsAutoFill is ON
    
    RevertWaitingStatus has already removed the itemnumber from the hold, passing
    $itemnumber (from scanned item) should work, as it will reattach the hold to
    the item
    
    Test plan:
    1 - Enable HoldsAutoFill
    2 - Place a title level hold
    3 - Check in an item and confirm hold
    4 - Switch to another branch
    5 - Checkin the item
    Without this patch you got
    Can't call method "biblionumber" on an undefined value at
    /kohadevbox/koha/C4/Reserves.pm line 1577.
     at /kohadevbox/koha/C4/Reserves.pm line 1576
    With this patch applied the operation succeeds
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:29:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:29:45 +0000
    Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through stage
     MARC record import
    In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22785-70-fZcJcyWsu2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:29:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:29:50 +0000
    Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through stage
     MARC record import
    In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22785-70-kdGR4oYUx8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    
    --- Comment #84 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134219
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134219&action=edit
    Bug 22785: (follow-up) Update contentType in request
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:45:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:45:22 +0000
    Subject: [Koha-bugs] [Bug 30628] Batch borrower modifications only affect
     the current page
    In-Reply-To: <bug-30628-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30628-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30628-70-o9uAxPW6dj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:45:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:45:26 +0000
    Subject: [Koha-bugs] [Bug 30628] Batch borrower modifications only affect
     the current page
    In-Reply-To: <bug-30628-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30628-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30628-70-sIvuGYolJ2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134205|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134220
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134220&action=edit
    Bug 30628: Fix patron selection in batch patron modification tool
    
    bug 28014 added Datatables to this view, but the form is submitted with
    only the checkboxes from the first page.
    
    Solution adapted from
    https://stackoverflow.com/questions/33240409/how-to-submit-checkboxes-from-all-pages-with-jquery-datatables
    
    Test plan:
    Have more than 20 cardnumbers, use the batch patron modification tool
    Select (not all) patrons from the first page and second page
    Submit the form
    Notice that the patrons you have selected appear on the confirmation
    page.
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:50:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:50:16 +0000
    Subject: [Koha-bugs] [Bug 30639] New: Patron search does not find patrons if
     passed first and last name
    Message-ID: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639
    
                Bug ID: 30639
               Summary: Patron search does not find patrons if passed first
                        and last name
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: major
              Priority: P5 - low
             Component: Architecture, internals, and plumbing
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: nick at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
    
    Search for: "edna acosta" OR "henry acevedo" OR you favorite default patron
    No results!
    
    The query is search for both terms in each field:
    i.e. firstname LIKE 'edna acosta'
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:50:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:50:46 +0000
    Subject: [Koha-bugs] [Bug 30639] Patron search does not find patrons if
     passed first and last name
    In-Reply-To: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30639-70-cGxJdyPTy6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30063
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
    [Bug 30063] Make the main patron search use the /patrons REST API route
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 12:50:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 10:50:46 +0000
    Subject: [Koha-bugs] [Bug 30063] Make the main patron search use the
     /patrons REST API route
    In-Reply-To: <bug-30063-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30063-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30063-70-pbceG5TVaV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30639
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639
    [Bug 30639] Patron search does not find patrons if passed first and last name
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 13:09:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 11:09:35 +0000
    Subject: [Koha-bugs] [Bug 29755] SIP2 code does not correctly handle
     NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees
    In-Reply-To: <bug-29755-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29755-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29755-70-XpnrZ0RtpJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 13:09:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 11:09:38 +0000
    Subject: [Koha-bugs] [Bug 29755] SIP2 code does not correctly handle
     NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees
    In-Reply-To: <bug-29755-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29755-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29755-70-VlNITD5AaF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134196|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134221
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134221&action=edit
    Bug 29755: Check each NoIssuesCharge separately
    
    This patch updates SIP patron code to use account methods to calculate balances
    over the patronflags returns. It also checks if patron should be blocked for
    each
    'No Issues charge' preference
    
    Tests are added for NoIssuesChargeGuarantees
    
    To test:
     1 - Set noissuescharge preference to 5
     2 - Add a $10 charge to a patron
     3 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l
    CPL -m patron_information --patron BARCODE
     4 - Note the 64 message starts with Y's that mean patron is blocked
     5 - Set noissuescharge to 11
     6 - Repeat 3, patron is no longer blocked
     7 - Set NoIssuesChargeGuarantees to 8
     8 - Repeat 3, patron is blocked
     9 - Pay $3 on patron so they owe 7
    10 - Repeat 3, patron is not blocked
    11 - Add a child account with patron as guarantor
    12 - Repeat 3, patron is not blocked
    13 - Add a $4 charge to child
    14 - Repeat 3, patron is blocked
    15 - Repeat 3, but with child barcode, child is not blocked
    16 - Set NoIssuesChargeGuarantorsWithGuarantees to 10
    17 - Repeat 3, patron is blocked
    18 - Repeat 3 with child barcode, child is blocked
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 13:09:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 11:09:42 +0000
    Subject: [Koha-bugs] [Bug 29755] SIP2 code does not correctly handle
     NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees
    In-Reply-To: <bug-29755-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29755-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29755-70-lZBMlhMfPf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755
    
    --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134222
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134222&action=edit
    Bug 29755: (follow-up) Mock NoIssuesChargeGuarantorsWithGuarantees in test
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 13:24:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 11:24:45 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-AqY4hc2dab@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134010|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 13:36:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 11:36:16 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-IS30XeQ5Gk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Now Nick beat me to it :) Nick++
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 13:39:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 11:39:43 +0000
    Subject: [Koha-bugs] [Bug 29983] Display the pretend claim column in
     overdue.tt
    In-Reply-To: <bug-29983-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29983-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29983-70-p1rMVXJdAs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #130240|0                           |1
            is obsolete|                            |
    
    --- Comment #11 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> ---
    Created attachment 134223
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134223&action=edit
    Bug 29983: Display the pretend claim column in overdue.tt
    
    This patch displays the column "Return claims" from the page "moremember.pl" to
    the page "overdues.pl". Rebase on master.
    
    Test plan:
    1) Use a patron with at least 1 item who should be checked out soon
    2) Home > Patron > Patron details for [name]
    3) Click on the 'Checkout' button down the page to show the full table and
    notice the "Return Claims" column
    4) Now go to Home > Circulation > Overdues
    5) Find the patron who has to check out and have a look at the table
    6) Apply patch and repeat 4) and 5) -> the "Return Claim" column is now
    displayed on the table
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 13:41:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 11:41:06 +0000
    Subject: [Koha-bugs] [Bug 27077] Searching for patrons with guarantor_id
     criteria results in 500 error
    In-Reply-To: <bug-27077-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27077-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27077-70-bltzjR5NMo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27077
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |DUPLICATE
                     CC|                            |tomascohen at gmail.com
                 Status|NEW                         |RESOLVED
    
    --- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    
    
    *** This bug has been marked as a duplicate of bug 30534 ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 13:41:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 11:41:06 +0000
    Subject: [Koha-bugs] [Bug 30534] borrowers.guarantorid not present on
     database
    In-Reply-To: <bug-30534-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30534-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30534-70-HXedArn19Q@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30534
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |arthur.suzuki at biblibre.com
    
    --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    *** Bug 27077 has been marked as a duplicate of this bug. ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 13:41:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 11:41:29 +0000
    Subject: [Koha-bugs] [Bug 29983] Display the pretend claim column in
     overdue.tt
    In-Reply-To: <bug-29983-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29983-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29983-70-W9O7vVst7v@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983
    
    Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 13:50:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 11:50:44 +0000
    Subject: [Koha-bugs] [Bug 20615] Add the link of number of times the
     authority are used in edit mode
    In-Reply-To: <bug-20615-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20615-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20615-70-xylHXdWHGe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615
    
    --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    (In reply to Aleisha Amohia from comment #10)
    > Looks like this was signed off so adjusting bug status.
    
    Thanks, Aleisha!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 13:55:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 11:55:57 +0000
    Subject: [Koha-bugs] [Bug 30640] New: Focus does not always move to correct
     search header form field
    Message-ID: <bug-30640-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30640
    
                Bug ID: 30640
               Summary: Focus does not always move to correct search header
                        form field
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: minor
              Priority: P5 - low
             Component: Templates
              Assignee: oleonard at myacpl.org
              Reporter: oleonard at myacpl.org
            QA Contact: testopia at bugs.koha-community.org
            Depends on: 29155
    
    The jQuery upgrade has introduced a bug with how the header search form is
    supposed to handle focus. This can be seen in any page where the "Check out"
    tab is present in the header search but not the pre-selected tab, e.g. the
    patron detail tab.
    
    On the patron details page the "Search patrons" tab is selected by default, and
    the cursor focus is automatically put on the form field. Switch to the "Check
    out" tab and you'll find that the focus doesn't move to the form field. The
    other tabs don't have this problem.
    
    I think this is the explanation: https://github.com/jquery/jquery/issues/4950
    
    To fix we'll need to remove the "focus" class on form fields which might be
    hidden by default and update the tabs behavior to make sure the right field is
    focused on load.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    [Bug 29155] Upgrade jquery version to 3.6.0
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 13:55:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 11:55:57 +0000
    Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version to 3.6.0
    In-Reply-To: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29155-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29155-70-O12LFxc38K@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30640
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30640
    [Bug 30640] Focus does not always move to correct search header form field
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:00:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:00:28 +0000
    Subject: [Koha-bugs] [Bug 27768] Saving an item with an invalid
     dateaccessioned or replacementpricedate throws no helpful error
    In-Reply-To: <bug-27768-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27768-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27768-70-3o9tqkQRNo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27768
    
    --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Jonathan Druart from comment #4)
    > I don't recreate that, I am getting a 500 with
    > 
    > Invalid value passed, dateaccessioned=00-1-11-30 expected type is date at
    > /usr/share/perl5/Exception/Class/Base.pm line 88
    
    Set sql mode to 0. Assuming that this still is the case for a regular install.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:06:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:06:09 +0000
    Subject: [Koha-bugs] [Bug 30641] New: Authority detail page shows wrong
     number of records using the authority
    Message-ID: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30641
    
                Bug ID: 30641
               Summary: Authority detail page shows wrong number of records
                        using the authority
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Cataloging
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: katrin.fischer at bsz-bw.de
            QA Contact: testopia at bugs.koha-community.org
                    CC: m.de.rooy at rijksmuseum.nl
    
    You can see the wrong behaviour in a clean sample database with
    http://localhost:8081/cgi-bin/koha/authorities/detail.pl?authid=133
    
    To test:
    * Test plan assumes you are using the ktd sample data
    * Staff interface > authorities
    * Search for agile
    * Verfiy the result list shows used by 2 records and this is correct (authority
    is linked to both of them)
    * Switch to authority detail page
    * Verify it shows 3 records use this authority
    * Verify this is incorrect (the second record is not linked to the authority)
    
    I suspect that the detail page doesn't do an exact/phrase search opposed to the
    other pages, finding also records with similar authority numbers?
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:11:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:11:21 +0000
    Subject: [Koha-bugs] [Bug 30640] Focus does not always move to correct
     search header form field
    In-Reply-To: <bug-30640-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30640-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30640-70-iQnmIL7mhI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30640
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:11:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:11:25 +0000
    Subject: [Koha-bugs] [Bug 30640] Focus does not always move to correct
     search header form field
    In-Reply-To: <bug-30640-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30640-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30640-70-Qb0GrCy2wC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30640
    
    --- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 134224
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134224&action=edit
    Bug 30640: Focus does not always move to correct search header form field
    
    This patch updates the staff interface's global JavaScript to
    accommodate changes in the way focus is being handled after the jQuery
    upgrade (see: https://github.com/jquery/jquery/issues/4950).
    
    The "focus" class is removed from search header include files so that
    there isn't a contradiction between which form field has the focus class
    and which form field is displayed in the active tab.
    
    To test, apply the patch and view various pages in the staff interface.
    
    - On pages where focus is not being directed to a form field within the
      main content of the page, the form field in the active search header
      tab should have focus on page load:
    
      - Patron details
      - System preferences
      - Cities and towns
    
      Also test pages where a tab other than the first one is preselected:
    
      - Bibliographic details page
      - Patron lists
    
      On these pages, focus should move to the active tab's form field when
      you switch tabs.
    
    - On pages where focus is being sent to another form field, it should
      work correctly:
    
      - Patrons home page
      - Check in
      - Acquisitions home page
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:12:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:12:47 +0000
    Subject: [Koha-bugs] [Bug 20615] Add the link of number of times the
     authority are used in edit mode
    In-Reply-To: <bug-20615-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20615-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20615-70-2ajTZaXGo4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Failed QA
    
    --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    I've changed the patch author for 
    root <root at vmi538303.contaboserver.net>
    to 
    George Veranis <gveranis at dataly.gr>
    and reattached the patch.
    
    The problem here is bug 30641 which I think makes this require another
    follow-up.
    
    The code was taken from the detail page, which shows the wrong number of linked
    authorities.
    
    I wonder if Koha::Authorities->find($authid); doesn't do an exact search?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:13:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:13:22 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-NXo80A3xFJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #47 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134225
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134225&action=edit
    Bug 29346: (QA follow-up) Rebuild queue when adjusting priorities of holds
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:13:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:13:25 +0000
    Subject: [Koha-bugs] [Bug 20615] Add the link of number of times the
     authority are used in edit mode
    In-Reply-To: <bug-20615-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20615-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20615-70-M9IbqRfgNu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131171|0                           |1
            is obsolete|                            |
    
    --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134226
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134226&action=edit
    Bug 20615: Add the link of number of times the authority are used in edit mode
    
    Currently when show an authority record you can see the count of records linked
    with that authority, but when edit that authority record the that detail is
    dissapeared.
    Applying this patch will have that information also on edit mode of authority.
    
    Test plan:
    1) Search for an authority that is already connected with at least one record
    2) On detail view of an authority you can check that authority is linked with
       x records.
    3) Edit that authority and the information about in how many records that
       authority is linked is missing.
    4) Apply this patch
    5) Edit again that authrity and you can find now the count in how many records
       is used that authority
    
    Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:13:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:13:27 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-g0pptKJc9m@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #48 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134227
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134227&action=edit
    Bug 29346: (follow-up) Fix typo 'availabe'
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:15:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:15:19 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-4QoGVGZY9K@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Failed QA
    
    --- Comment #49 from Nick Clemens <nick at bywatersolutions.com> ---
    The queue works, test pass, but when I go to the background jobs page:
    173     Started         0 / 1   Unknown job type
    'update_holds_queue_for_biblios'       04/28/2022 12:08        04/28/2022 12:08
           04/28/2022 12:08
    
    And if I click view:
    Template process failed: file error -
    background_jobs/update_holds_queue_for_biblios.inc: not found at
    /kohadevbox/koha/C4/Templates.pm line 127
    
    Also, we should update the queue when we 'Revert waiting status' on a hold
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:18:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:18:41 +0000
    Subject: [Koha-bugs] [Bug 20615] Add the link of number of times the
     authority are used in edit mode
    In-Reply-To: <bug-20615-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20615-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20615-70-ROM9UxjRkr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615
    
    --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    
    > I wonder if Koha::Authorities->find($authid); doesn't do an exact search?
    That's wrong. It's using:
    
    get_usage_count
    
    So we'd need to look there.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:19:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:19:04 +0000
    Subject: [Koha-bugs] [Bug 20615] Add the link of number of times the
     authority are used in edit mode
    In-Reply-To: <bug-20615-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20615-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20615-70-oKxhIjvMu9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30641
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30641
    [Bug 30641] Authority detail page shows wrong number of records using the
    authority
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:19:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:19:04 +0000
    Subject: [Koha-bugs] [Bug 30641] Authority detail page shows wrong number of
     records using the authority
    In-Reply-To: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30641-70-4YZmUB3Fn4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30641
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |20615
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615
    [Bug 20615] Add the link of number of times the authority are used in edit mode
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:21:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:21:01 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-36PWQJCBmY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134177|0                           |1
            is obsolete|                            |
    
    --- Comment #122 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134228
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134228&action=edit
    Bug 30275: Add checkout_renewals table
    
    This patch adds the new checkout_renewals table using an atomicupdate
    
    Sponsored-by: Loughborough University
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:21:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:21:07 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-Slnb2sjb0x@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134178|0                           |1
            is obsolete|                            |
    
    --- Comment #123 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134229
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134229&action=edit
    Bug 30275: Generated kohastructure.sql
    
    This kohastructure update was generated using `koha-dump --schema-only`
    in koha-testing-docker once the atomicupdate had been run against the
    previous atomicupdate patch.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:21:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:21:12 +0000
    Subject: [Koha-bugs] [Bug 30641] Authority detail page shows wrong number of
     records using the authority
    In-Reply-To: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30641-70-5chFID3EW8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30641
    
    --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Ok, getting closer:
    
    The number on results and detail page match and are correct if
    AutoQueryTruncate is deactivated.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:21:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:21:13 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-UQa6U1NVVw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134179|0                           |1
            is obsolete|                            |
    
    --- Comment #124 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134230
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134230&action=edit
    Bug 30275: DBIC Schema Changes
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:21:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:21:19 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-uRr9p9yUXj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134180|0                           |1
            is obsolete|                            |
    
    --- Comment #125 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134231
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134231&action=edit
    Bug 30275: Record renewals
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:21:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:21:25 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-01Yxzn7O5m@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134181|0                           |1
            is obsolete|                            |
    
    --- Comment #126 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134232
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134232&action=edit
    Bug 30275: DBIC Schema Additions
    
    Add checkout and old_checkout relations to CheckoutRenewal schema and
    mark 'seen' as a boolean.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:21:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:21:31 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-z7cBJazddy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134182|0                           |1
            is obsolete|                            |
    
    --- Comment #127 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134233
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134233&action=edit
    Bug 30275: Add Koha::Objects for Renewals
    
    Add Koha::Checkouts::Renewals|Renewal classes
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:21:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:21:36 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-dzvazw5waX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134183|0                           |1
            is obsolete|                            |
    
    --- Comment #128 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134234
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134234&action=edit
    Bug 30275: Rename issues.renewals to issues.renewals_count
    
    Rename the issues.renewals field to renewals_count to prevent a method
    name collision with the new relation accessor introduced by this
    patchset.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:21:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:21:42 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-Khw1Iprj51@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134184|0                           |1
            is obsolete|                            |
    
    --- Comment #129 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134235
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134235&action=edit
    Bug 30275: renewals_count DBIC Update
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:21:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:21:49 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-hWSwvnoiX5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134185|0                           |1
            is obsolete|                            |
    
    --- Comment #130 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134236
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134236&action=edit
    Bug 30275: Add 'renewals' relation to Issue Schema
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:21:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:21:55 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-mM4ZpayqRd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134186|0                           |1
            is obsolete|                            |
    
    --- Comment #131 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134237
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134237&action=edit
    Bug 30275: Add renewals relation to Koha::Checkout
    
    Add the new 'renewals' relation to Koha::Checkout to return a list of
    Koha::Checkouts::Renewal objects.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:22:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:22:01 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-BiPBxTFApM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134187|0                           |1
            is obsolete|                            |
    
    --- Comment #132 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134238
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134238&action=edit
    Bug 30275: Add `/api/v1/checkouts/{checkout_id}/renewals`
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:22:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:22:08 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-qbP1Zh7eyo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134188|0                           |1
            is obsolete|                            |
    
    --- Comment #133 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134239
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134239&action=edit
    Bug 30275: Add alias to create renewal in api routes
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:22:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:22:14 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-VL7P21AyYI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134189|0                           |1
            is obsolete|                            |
    
    --- Comment #134 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134240
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134240&action=edit
    Bug 30275: Fix checkouts.t unit test
    
    We no longer require a mocked userenv for these tests to pass, we're
    setting the userenv in api auth now. The mock just serves to break tests
    for the renew method now that AddRenewal required a correctly set
    userenv for 'number'.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:22:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:22:17 +0000
    Subject: [Koha-bugs] [Bug 30641] Authority detail page shows wrong number of
     records using the authority
    In-Reply-To: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30641-70-1vhnXT7iE3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30641
    
    --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    And Elasticsearch is used.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:22:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:22:24 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-3y3gkQxWUq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134190|0                           |1
            is obsolete|                            |
    
    --- Comment #135 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134241
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134241&action=edit
    Bug 30275: Add basic unit test for fetching renewals
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:22:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:22:30 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-Jt3eY1qoeT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134191|0                           |1
            is obsolete|                            |
    
    --- Comment #136 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134242
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134242&action=edit
    Bug 30275: (follow-up) Rebase fixes
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:22:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:22:36 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-FxB24RkhEd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134192|0                           |1
            is obsolete|                            |
    
    --- Comment #137 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134243
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134243&action=edit
    Bug 30275: Add renewals relation to Koha::Old::Checkout
    
    Add the new 'renewals' relation to Koha::Old::Checkout to return a
    list of Koha::Checkouts::Renewal objects.
    
    We also add the same relation to the OldIssue schema inline.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:22:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:22:42 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-w8hqhwUwwy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134193|0                           |1
            is obsolete|                            |
    
    --- Comment #138 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134244
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134244&action=edit
    Bug 30275: (QA follow-up) Rename columns to match API
    
    This patch performs the following column renames:
    
    * id => renewal_id
    * issue_id => checkout_id
    
    The idea is that no translation is needed for the API, and also, being a
    new table, we can educate the users into the 'to be' terminology we are
    leaning towards, instead of having them learn one naming to create
    reports and then need to translate them once we normalize things in a
    future.
    
    That said, this is simple to review.
    
    Apply this patch and repeat the test plan.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:22:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:22:48 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-d3DQPb7N89@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134210|0                           |1
            is obsolete|                            |
    
    --- Comment #139 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134245
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134245&action=edit
    Bug 30275: (follow-up) Drop renewer_id constraint
    
    This patch fixes some unit tests by ensureing we set a valid userid for
    mock userenv setting so that the foreign key constraint doesn't fail and
    it also removes the exception class and check for renewer_id from the
    store method as, for example with autorenewals, the renewal may not have
    been triggered by a actual user.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:22:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:22:57 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-NpdIpgofeH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #140 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134246
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134246&action=edit
    Bug 30275: Add unit tests for AddRenewal addition
    
    This patch adds a test for the AddRenewal addition that creates Renewal
    lines.
    
    Test plan
    1) Run the unit tests and confirm it passes
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:23:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:23:04 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-fxE4tWyzL5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #141 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134247
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134247&action=edit
    Bug 30275: Add Unit test for renewals relation
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:23:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:23:10 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-nlm7POi7hI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #142 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134248
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134248&action=edit
    Bug 30275: Unit Tests for Checkouts::Renewal
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:23:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:23:46 +0000
    Subject: [Koha-bugs] [Bug 30642] New: We should record the renewal type
     (Automatic/Manual)
    Message-ID: <bug-30642-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30642
    
                Bug ID: 30642
               Summary: We should record the renewal type (Automatic/Manual)
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Architecture, internals, and plumbing
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: martin.renvoize at ptfs-europe.com
            QA Contact: testopia at bugs.koha-community.org
            Depends on: 30275
    
    With bug 30275 we introduce more logging of renewals.. but we don't
    differentiate between automatic renewals and renewals by other means.. it could
    be helpful to do so.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    [Bug 30275] Checkout renewals should be stored in their own table
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:23:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:23:46 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-Bfc5sOyZAu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30642
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30642
    [Bug 30642] We should record the renewal type (Automatic/Manual)
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:24:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:24:26 +0000
    Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
     own table
    In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30275-70-AYBUHGWu4e@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
    
    --- Comment #143 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Lots of unit tests.. all praise the unit tests :)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:25:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:25:52 +0000
    Subject: [Koha-bugs] [Bug 30641] Authority detail page shows wrong number of
     records using the authority
    In-Reply-To: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30641-70-s1StJ8HyZp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30641
    
    --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Cant directly reproduce this under Zebra.
    I am inclined to think that it is related to Elastic search engine module.
    Please confirm. Did you work under Elastic?
    
    Would be nice if we just used ->get_usage_count doing something like
    simple_search_compat( 'an:' . $authid, 0, 0 )
    The other call goes (under Zebra) via SearchAuthorities.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:26:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:26:41 +0000
    Subject: [Koha-bugs] [Bug 30641] Authority detail page shows wrong number of
     records using the authority
    In-Reply-To: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30641-70-9VWzu1ELoh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30641
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
              Component|Cataloging                  |Searching - Elasticsearch
             QA Contact|testopia at bugs.koha-communit |
                       |y.org                       |
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:31:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:31:50 +0000
    Subject: [Koha-bugs] [Bug 20615] Add the link of number of times the
     authority are used in edit mode
    In-Reply-To: <bug-20615-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20615-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20615-70-kKMCXupwC6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615
    
    --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Ok, I have investigated a bit more. The wrong count is due to how we handle
    things in get_usage_count and it only happens when Elasticsearch is used in
    combination with QueryAutoTruncate = ON. We will need to fix get_usage_count,
    but we should do this separately.
    
    Willing to pass this as is.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:32:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:32:44 +0000
    Subject: [Koha-bugs] [Bug 20615] Add the link of number of times the
     authority are used in edit mode
    In-Reply-To: <bug-20615-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20615-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20615-70-AbWRnkK2sq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:32:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:32:49 +0000
    Subject: [Koha-bugs] [Bug 20615] Add the link of number of times the
     authority are used in edit mode
    In-Reply-To: <bug-20615-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20615-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20615-70-WicL5Goam6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134226|0                           |1
            is obsolete|                            |
    
    --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134249
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134249&action=edit
    Bug 20615: Add the link of number of times the authority are used in edit mode
    
    Currently when show an authority record you can see the count of records linked
    with that authority, but when edit that authority record the that detail is
    dissapeared.
    Applying this patch will have that information also on edit mode of authority.
    
    Test plan:
    1) Search for an authority that is already connected with at least one record
    2) On detail view of an authority you can check that authority is linked with
       x records.
    3) Edit that authority and the information about in how many records that
       authority is linked is missing.
    4) Apply this patch
    5) Edit again that authrity and you can find now the count in how many records
       is used that authority
    
    Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:33:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:33:20 +0000
    Subject: [Koha-bugs] [Bug 20615] Add the link of number of times the
     authority are used in edit mode
    In-Reply-To: <bug-20615-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20615-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20615-70-KlPOtGkgoN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30641
             Depends on|30641                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30641
    [Bug 30641] Authority detail page shows wrong number of records using the
    authority
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:33:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:33:20 +0000
    Subject: [Koha-bugs] [Bug 30641] Authority detail page shows wrong number of
     records using the authority
    In-Reply-To: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30641-70-Dh2SZ4c6dI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30641
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|20615                       |
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=20615
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615
    [Bug 20615] Add the link of number of times the authority are used in edit mode
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:33:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:33:53 +0000
    Subject: [Koha-bugs] [Bug 30639] Patron search does not split search terms
    In-Reply-To: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30639-70-0t3pJTQk39@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Patron search does not find |Patron search does not
                       |patrons if passed first and |split search terms
                       |last name                   |
                 Status|NEW                         |ASSIGNED
               Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                       |ity.org                     |com
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:35:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:35:08 +0000
    Subject: [Koha-bugs] [Bug 30643] New: Useless query part generated by DT
     REST API wrapper
    Message-ID: <bug-30643-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30643
    
                Bug ID: 30643
               Summary: Useless query part generated by DT REST API wrapper
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: normal
              Priority: P5 - low
             Component: Architecture, internals, and plumbing
              Assignee: jonathan.druart+koha at gmail.com
              Reporter: jonathan.druart+koha at gmail.com
            QA Contact: testopia at bugs.koha-community.org
    
    There is a OR part with "attr1 like %%", etc.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:35:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:35:49 +0000
    Subject: [Koha-bugs] [Bug 30639] Patron search does not split search terms
    In-Reply-To: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30639-70-Xjz8lzqWqe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30626, 30643
               Keywords|                            |rel_22_05_candidate
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    [Bug 30626] DT REST API wrapper not building the filter query correctly
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30643
    [Bug 30643] Useless query part generated by DT REST API wrapper
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:35:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:35:49 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-ALTvSS8ci1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30639
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639
    [Bug 30639] Patron search does not split search terms
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:35:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:35:49 +0000
    Subject: [Koha-bugs] [Bug 30643] Useless query part generated by DT REST API
     wrapper
    In-Reply-To: <bug-30643-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30643-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30643-70-9ulBfyfxoE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30643
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30639
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639
    [Bug 30639] Patron search does not split search terms
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:37:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:37:46 +0000
    Subject: [Koha-bugs] [Bug 30641] Authority detail page shows wrong number of
     records using the authority
    In-Reply-To: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30641-70-B4rIPDi7lx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30641
    
    --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Hi Marcel, our investigation overlapped. The key factors are:
    
    Searchengine Elasticsearch
    AutoQueryTruncate ON (automatic truncation)
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:38:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:38:15 +0000
    Subject: [Koha-bugs] [Bug 30643] Useless query part generated by DT REST API
     wrapper
    In-Reply-To: <bug-30643-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30643-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30643-70-VV2AT2rzGo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30643
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:38:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:38:19 +0000
    Subject: [Koha-bugs] [Bug 30643] Useless query part generated by DT REST API
     wrapper
    In-Reply-To: <bug-30643-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30643-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30643-70-Tp12mWOMJr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30643
    
    --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134250
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134250&action=edit
    Bug 30643: Remove useless OR part from query generated by DT REST API wrapper
    
    To test:
    Don't apply this patch
    Search for patrons on the main patron search
    Notice the {"me.firstname":{"like":"%%"}}, etc.
    Apply this patch and confirm that the query is now correctly formed
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:39:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:39:13 +0000
    Subject: [Koha-bugs] [Bug 30641] Authority detail page shows wrong number of
     records using the authority
    In-Reply-To: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30641-70-ZIrWto7rXW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30641
    
    --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    The problematic one is get_usage_count - I found this while testing bug 20615
    that uses it and shows the wrong number. Not sure what the result page does
    different... but it probably should all end up using the same and working code.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:41:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:41:48 +0000
    Subject: [Koha-bugs] [Bug 30643] Useless query part generated by DT REST API
     wrapper
    In-Reply-To: <bug-30643-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30643-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30643-70-MitocV0bR1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30643
    
    --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Is this really useless?
    
    Patron attributes should be searched by default in the standard search to have
    no regression.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:44:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:44:16 +0000
    Subject: [Koha-bugs] [Bug 30644] New: Cannot delete items
    Message-ID: <bug-30644-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30644
    
                Bug ID: 30644
               Summary: Cannot delete items
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: major
              Priority: P5 - low
             Component: Cataloging
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: nick at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: m.de.rooy at rijksmuseum.nl
    
    The method Koha::Item->messages is not covered by tests!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:44:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:44:18 +0000
    Subject: [Koha-bugs] [Bug 30639] Patron search does not split search terms
    In-Reply-To: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30639-70-dSzyrP4i7f@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:44:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:44:24 +0000
    Subject: [Koha-bugs] [Bug 30639] Patron search does not split search terms
    In-Reply-To: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30639-70-boTX6boQSj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639
    
    --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134251
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134251&action=edit
    Bug 30639: Split search terms for patron search
    
    If several terms are passed we should split them.
    
    Test plan:
    Search for "edna acosta" (without quotes) in the filters from the left
    side of the main patron search
    Do some regression tests
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:45:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:45:27 +0000
    Subject: [Koha-bugs] [Bug 30639] Patron search does not split search terms
    In-Reply-To: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30639-70-dUrE3D6k5X@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639
    
    --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    This is still not perfect for patron attributes.
    If you have:
      attribute 1 = xxx
      attribute 2 = yyy
    
    and you search for "xxx yyy", the patron won't be returned.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:48:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:48:18 +0000
    Subject: [Koha-bugs] [Bug 30644] Cannot delete items
    In-Reply-To: <bug-30644-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30644-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30644-70-ESz0YcJwJw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30644
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Severity|major                       |blocker
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:52:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:52:34 +0000
    Subject: [Koha-bugs] [Bug 29543] Self-checkout allows returning everybody's
     loans
    In-Reply-To: <bug-29543-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29543-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29543-70-bGfDF3ZgWk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29543
    
    Magnus Enger <magnus at libriotech.no> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |magnus at libriotech.no
    
    --- Comment #58 from Magnus Enger <magnus at libriotech.no> ---
    *** Bug 26857 has been marked as a duplicate of this bug. ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:56:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:56:30 +0000
    Subject: [Koha-bugs] [Bug 30639] Patron search does not split search terms
    In-Reply-To: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30639-70-1ca8qUqXTn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|30626, 30643                |30576
                 Status|Needs Signoff               |ASSIGNED
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    [Bug 30576] DefaultPatronSearchFields no longer takes effect
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    [Bug 30626] DT REST API wrapper not building the filter query correctly
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30643
    [Bug 30643] Useless query part generated by DT REST API wrapper
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:56:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:56:30 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-ybMNtYIFCp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30639
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639
    [Bug 30639] Patron search does not split search terms
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:56:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:56:30 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-nhFmoHyRbm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|30639                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639
    [Bug 30639] Patron search does not split search terms
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:56:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:56:30 +0000
    Subject: [Koha-bugs] [Bug 30643] Useless query part generated by DT REST API
     wrapper
    In-Reply-To: <bug-30643-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30643-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30643-70-TMZgxunobp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30643
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|30639                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639
    [Bug 30639] Patron search does not split search terms
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:57:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:57:46 +0000
    Subject: [Koha-bugs] [Bug 30639] Patron search does not split search terms
    In-Reply-To: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30639-70-1XQHX3EFYf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30643
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30643
    [Bug 30643] Useless query part generated by DT REST API wrapper
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 14:57:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 12:57:46 +0000
    Subject: [Koha-bugs] [Bug 30643] Useless query part generated by DT REST API
     wrapper
    In-Reply-To: <bug-30643-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30643-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30643-70-7wNnLiTRIl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30643
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30639
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639
    [Bug 30639] Patron search does not split search terms
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:01:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:01:03 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-DHmFVw2nuJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    --- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134252
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134252&action=edit
    Bug 30626: Don't generate the query if no term passed
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:02:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:02:23 +0000
    Subject: [Koha-bugs] [Bug 30643] Useless query part generated by DT REST API
     wrapper
    In-Reply-To: <bug-30643-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30643-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30643-70-ly5HBMSvWx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30643
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |DUPLICATE
                 Status|Needs Signoff               |RESOLVED
    
    --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    This has actually been introduced by bug 30626 that is not pushed yet.
    Fixed on a follow-up there: 
      Bug 30626: Don't generate the query if no term passed
    
    *** This bug has been marked as a duplicate of bug 30626 ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:02:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:02:23 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-O1Qr6hyHFB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    --- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    *** Bug 30643 has been marked as a duplicate of this bug. ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:02:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:02:24 +0000
    Subject: [Koha-bugs] [Bug 30639] Patron search does not split search terms
    In-Reply-To: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30639-70-6CaYZBVU8D@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639
    Bug 30639 depends on bug 30643, which changed state.
    
    Bug 30643 Summary: Useless query part generated by DT REST API wrapper
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30643
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |RESOLVED
             Resolution|---                         |DUPLICATE
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:02:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:02:39 +0000
    Subject: [Koha-bugs] [Bug 30643] Useless query part generated by DT REST API
     wrapper
    In-Reply-To: <bug-30643-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30643-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30643-70-4959M4gN3Z@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30643
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|30639                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639
    [Bug 30639] Patron search does not split search terms
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:02:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:02:39 +0000
    Subject: [Koha-bugs] [Bug 30639] Patron search does not split search terms
    In-Reply-To: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30639-70-0WOmQLCyCS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|30643                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30643
    [Bug 30643] Useless query part generated by DT REST API wrapper
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:07:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:07:24 +0000
    Subject: [Koha-bugs] [Bug 30639] Patron search does not split search terms
    In-Reply-To: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30639-70-ijVu7jyjLb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:09:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:09:39 +0000
    Subject: [Koha-bugs] [Bug 27619] Remove fr-FR installer data
    In-Reply-To: <bug-27619-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27619-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27619-70-f9O33nJUPP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619
    
    --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
    (In reply to Jonathan Druart from comment #5)
    > Created attachment 134213 [details] [review]
    > Bug 27619: Add custom for fr-FR
    
    Hi Jonathan, may be a "DELETE FROM `z3950servers`;" is needed before inserting
    the BNF server, just in case the sample z3950 servers were selected at install
    time; or just an "INSERT IGNORE", the BNF server is now present in that
    archive.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:13:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:13:33 +0000
    Subject: [Koha-bugs] [Bug 30645] New: Patron search not building the query
     correctly for extended attributes if several terms passed
    Message-ID: <bug-30645-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30645
    
                Bug ID: 30645
               Summary: Patron search not building the query correctly for
                        extended attributes if several terms passed
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Patrons
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: jonathan.druart+koha at gmail.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
            Depends on: 30639
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639
    [Bug 30639] Patron search does not split search terms
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:13:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:13:33 +0000
    Subject: [Koha-bugs] [Bug 30639] Patron search does not split search terms
    In-Reply-To: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30639-70-grqJa7yjvJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30645
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30645
    [Bug 30645] Patron search not building the query correctly for extended
    attributes if several terms passed
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:14:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:14:05 +0000
    Subject: [Koha-bugs] [Bug 30645] Patron search not building the query
     correctly for extended attributes if several terms passed
    In-Reply-To: <bug-30645-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30645-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30645-70-PYxdkyZmdv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30645
    
    --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134253
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134253&action=edit
    Bug 30645: Add tests
    
    to highlight the problem
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:14:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:14:20 +0000
    Subject: [Koha-bugs] [Bug 30639] Patron search does not split search terms
    In-Reply-To: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30639-70-7qiflIvrxa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639
    
    --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    (In reply to Jonathan Druart from comment #2)
    > This is still not perfect for patron attributes.
    > If you have:
    >   attribute 1 = xxx
    >   attribute 2 = yyy
    > 
    > and you search for "xxx yyy", the patron won't be returned.
    
    Reported on bug 30645.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:20:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:20:29 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-5CzuwUdKxj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133752|0                           |1
            is obsolete|                            |
    
    --- Comment #57 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134254
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134254&action=edit
    Bug 21978: Add middle_name field to the database
    
    This patch adds a new field, middle_name, to the borrowers,
    deletedborrowers and borrower_modifications tables.
    
    It also updates the DefaultPatronSearchFields preference to include the
    new field if the preference is still set to it's default settings from
    install.
    
    Sponsored-by: Cheshire Libraries
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:20:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:20:36 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-bkDArD91s6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133753|0                           |1
            is obsolete|                            |
    
    --- Comment #58 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134255
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134255&action=edit
    Bug 21978: Add middle_name to api specification
    
    This patch adds middle_name to the accaeptable fields in API requests
    and responses.
    
    Test plan
    1) Search for a user using the API
    2) Confirm the API responds with a 200
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:20:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:20:41 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-voHR3ncsJF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133754|0                           |1
            is obsolete|                            |
    
    --- Comment #59 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134256
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134256&action=edit
    Bug 21978: Add support for middle name
    
    This patch adds the new 'Middle name' field to the patron record.
    
    To test:
    1) Apply patches
    2) Update database, restart all and clear the browser cache
    3) Load a patron in the staff module
    4) Confirm you can see and edit the new 'Middle name' field
    5) Confirm the new middle name data displays on patron details
    6) Confirm the new middle name data displays on patron search results
    7) Confirm the new middle name data displays everywhere patron names are
       displayed.
    8) Confirm the new middle name data displays on the OPAC
    9) Confirm the 'Middle name' field appears in the OPAC borrower
       modification screens
    10) Edit sysprefs `BorrowerMandatoryFields`, `BorrowerUnwantedFields`,
        `SelfModificationBorrowerUnwantedField`,
    `PatronSelfModificationMandatoryField`,
        `PatronSelfRegistrationBorrowerMandatoryField` and
        `PatronSelfRegistrationBorrowerUnwantedField` to confirm you can make
        the new field required or hidden.
    11) Verify that DefaultPatronSearchFields contains the new field if you
        already had 'firstname' in the field list
    12) Enable PatronAutoComplete system preference
    13) Type patrons surname into checkout or patron search but don't hit
        return
    14) Confirm the patrons middle name is displayed in the preview
    15) Go to tools > patron lists and attempt to add a patron to a list
    16) Patrons middle name should appear in the autocomplete here too
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:20:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:20:47 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-aaLaemslJo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133755|0                           |1
            is obsolete|                            |
    
    --- Comment #60 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134257
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134257&action=edit
    Bug 21978: Schema Update
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:20:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:20:53 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-tcHXNVKuds@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133756|0                           |1
            is obsolete|                            |
    
    --- Comment #61 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134258
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134258&action=edit
    Bug 21978: Add middle_name into hold request autocomplete
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:20:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:20:59 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-uZBhyDsnn6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133757|0                           |1
            is obsolete|                            |
    
    --- Comment #62 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134259
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134259&action=edit
    Bug 21978: Use patron-title.inc in request.tt
    
    This patch updates all manual accurences of the patron title display
    to use the patron-title.inc include (so we get middlename handling)
    in request.tt.
    
    We also add the option to hide the cardnumber from the include and set
    the link_to to 'members_pay' to retain the current display format on
    this page.
    
    Test plan
    You'll need to trigger the following cases to test all cases:
    1) Too many holds
    2) Account expired
    3) Has restrictions
    4) Outstanding fines
    5) Already has hold on item
    6) No holds allowed
    7) Too many holds for this record
    8) Already in possession
    9) Already has a hold
    10) Already has a recall
    11) Pickup library doesn't many patron home library
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:21:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:21:34 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-tb00GmPDXm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    --- Comment #63 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Rebased and added the sponsorship line
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:21:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:21:44 +0000
    Subject: [Koha-bugs] [Bug 27619] Remove fr-FR installer data
    In-Reply-To: <bug-27619-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27619-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27619-70-jrhrBlQgOl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134213|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:22:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:22:11 +0000
    Subject: [Koha-bugs] [Bug 27619] Remove fr-FR installer data
    In-Reply-To: <bug-27619-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27619-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27619-70-AdXFu9exr7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619
    
    --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    (In reply to Bernardo Gonzalez Kriegel from comment #7)
    > (In reply to Jonathan Druart from comment #5)
    > > Created attachment 134213 [details] [review] [review]
    > > Bug 27619: Add custom for fr-FR
    > 
    > Hi Jonathan, may be a "DELETE FROM `z3950servers`;" is needed before
    > inserting the BNF server, just in case the sample z3950 servers were
    > selected at install time; or just an "INSERT IGNORE", the BNF server is now
    > present in that archive.
    
    Indeed, thanks!
    I adjusted the remote branch.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:25:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:25:34 +0000
    Subject: [Koha-bugs] [Bug 30641] Authority detail page shows wrong number of
     records using the authority
    In-Reply-To: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30641-70-Fzg98vs130@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30641
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:25:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:25:39 +0000
    Subject: [Koha-bugs] [Bug 30641] Authority detail page shows wrong number of
     records using the authority
    In-Reply-To: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30641-70-TDa1JBpE6k@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30641
    
    --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134260
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134260&action=edit
    Bug 30641: Quote authority id search
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:31:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:31:43 +0000
    Subject: [Koha-bugs] [Bug 30641] Authority detail page shows wrong number of
     records using the authority
    In-Reply-To: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30641-70-tRodEfKukx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30641
    
    --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Nick Clemens from comment #6)
    > Created attachment 134260 [details] [review]
    > Bug 30641: Quote authority id search
    
    Not sure if you should solve it here. Elastic ?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:32:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:32:08 +0000
    Subject: [Koha-bugs] [Bug 30641] Authority detail page shows wrong number of
     records using the authority
    In-Reply-To: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30641-70-qohyvTVoKp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30641
    
    --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Katrin Fischer from comment #5)
    > The problematic one is get_usage_count - I found this while testing bug
    > 20615 that uses it and shows the wrong number. Not sure what the result page
    > does different... but it probably should all end up using the same and
    > working code.
    
    No, it is just a wrapper to SearchEngine code.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:35:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:35:57 +0000
    Subject: [Koha-bugs] [Bug 30641] Authority detail page shows wrong number of
     records using the authority
    In-Reply-To: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30641-70-9l8yKiqcWA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30641
    
    --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Marcel, can you explain the issue?
    
    We don't want to disable auto-truncate in general, so using "" like I think we
    have done in other places already makes sense to me.
    
    Nick, there is another query in Authorities.pm with an an-based search, maybe
    we should also fix that one?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:38:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:38:10 +0000
    Subject: [Koha-bugs] [Bug 30641] Authority detail page shows wrong number of
     records using the authority
    In-Reply-To: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30641-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30641-70-fGEMr4xFxn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30641
    
    --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    ... and we'll probably need a unit test
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:38:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:38:35 +0000
    Subject: [Koha-bugs] [Bug 30644] Cannot delete items
    In-Reply-To: <bug-30644-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30644-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30644-70-4TgETmsVzs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30644
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |rel_22_05_candidate
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:38:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:38:45 +0000
    Subject: [Koha-bugs] [Bug 30644] Cannot delete items
    In-Reply-To: <bug-30644-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30644-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30644-70-tlYv1j8u4c@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30644
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |29788
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788
    [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean
    object
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:38:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:38:45 +0000
    Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a
     Koha::Result::Boolean object
    In-Reply-To: <bug-29788-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29788-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29788-70-LZqCGIr1hi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30644
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30644
    [Bug 30644] Cannot delete items
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:40:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:40:40 +0000
    Subject: [Koha-bugs] [Bug 29608] Editing numbering patterns does require
     full serials permission
    In-Reply-To: <bug-29608-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29608-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29608-70-Yz1MjqfIJy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29608
    
    pierre.genty at biblibre.com changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |pierre.genty at biblibre.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:41:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:41:17 +0000
    Subject: [Koha-bugs] [Bug 30609] Reindent serial claims template
    In-Reply-To: <bug-30609-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30609-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30609-70-xy5xsr6ff2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30609
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:41:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:41:21 +0000
    Subject: [Koha-bugs] [Bug 30609] Reindent serial claims template
    In-Reply-To: <bug-30609-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30609-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30609-70-3lYrivGgM1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30609
    
    --- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 134261
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134261&action=edit
    Bug 30609: Reindent serial claims template
    
    This patch updates the serial claims template so that the indentation
    is consistent. Tabs are replaced with spaces.
    
    To test you must have at least one subscription with late issues.
    
    - Apply the patch and go to Serials -> Claims and select the vendor
      responsible for your late issue.
    - On the "Missing issues" page, confirm that everything looks correct.
    - All functionality should be the same: Filters, table sorting, CSV
      export, and claim notification.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:41:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:41:26 +0000
    Subject: [Koha-bugs] [Bug 30609] Reindent serial claims template
    In-Reply-To: <bug-30609-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30609-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30609-70-ToElbvcxHk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30609
    
    --- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 134262
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134262&action=edit
    Bug 30609: (follow-up) Add markup comments
    
    This patch adds comments to the template to highlight the markup
    structure.
    
    This patch should have no effect on the page's appearance or
    functionality.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:43:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:43:36 +0000
    Subject: [Koha-bugs] [Bug 30639] Patron search does not split search terms
    In-Reply-To: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30639-70-CaDyMwLFwq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:43:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:43:40 +0000
    Subject: [Koha-bugs] [Bug 30639] Patron search does not split search terms
    In-Reply-To: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30639-70-jwFDLxjlk3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134251|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134263
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134263&action=edit
    Bug 30639: Split search terms for patron search
    
    If several terms are passed we should split them.
    
    Test plan:
    Search for "edna acosta" (without quotes) in the filters from the left
    side of the main patron search
    Do some regression tests
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:44:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:44:12 +0000
    Subject: [Koha-bugs] [Bug 30644] Cannot delete items
    In-Reply-To: <bug-30644-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30644-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30644-70-kwo3GFNIYv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30644
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |ASSIGNED
               Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                       |ity.org                     |com
    
    --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Shame on me
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:45:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:45:33 +0000
    Subject: [Koha-bugs] [Bug 30644] Cannot delete items
    In-Reply-To: <bug-30644-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30644-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30644-70-edIzpcjKeq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30644
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:45:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:45:38 +0000
    Subject: [Koha-bugs] [Bug 30644] Cannot delete items
    In-Reply-To: <bug-30644-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30644-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30644-70-KME2X9W25H@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30644
    
    --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Created attachment 134264
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134264&action=edit
    Bug 30644: (bug 29788 follow-up) Make Koha::Item->safe_to_delete use
    Koha::Result::Boolean
    
    Fix item deletion
    
    Wrong if/else!
    
    Test plan:
    Delete an item
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:54:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:54:52 +0000
    Subject: [Koha-bugs] [Bug 30644] Cannot delete items
    In-Reply-To: <bug-30644-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30644-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30644-70-KhgJaNG8dC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30644
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:54:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:54:56 +0000
    Subject: [Koha-bugs] [Bug 30644] Cannot delete items
    In-Reply-To: <bug-30644-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30644-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30644-70-haufOy5Vsq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30644
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134264|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134265
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134265&action=edit
    Bug 30644: (bug 29788 follow-up) Make Koha::Item->safe_to_delete use
    Koha::Result::Boolean
    
    Fix item deletion
    
    Wrong if/else!
    
    Test plan:
    Delete an item
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 15:56:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 13:56:02 +0000
    Subject: [Koha-bugs] [Bug 30644] Cannot delete items
    In-Reply-To: <bug-30644-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30644-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30644-70-4eREcr20Ps@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30644
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
    Good catch :-) passing QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:03:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:03:03 +0000
    Subject: [Koha-bugs] [Bug 13412] Allow configuration of auto-created
     authorities
    In-Reply-To: <bug-13412-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-13412-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-13412-70-5gtkCFInMY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13412
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:03:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:03:02 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-ryc5Nze4EM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:03:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:03:07 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-ywIiK3etir@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134225|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:03:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:03:09 +0000
    Subject: [Koha-bugs] [Bug 13412] Allow configuration of auto-created
     authorities
    In-Reply-To: <bug-13412-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-13412-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-13412-70-2OFBu7kqLr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13412
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133607|0                           |1
            is obsolete|                            |
    
    --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134266
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134266&action=edit
    Bug 13412: Allow configuration of auto-created authorities
    
    This patch add 2 new system preferences:
    - GenerateAuthorityField667
    - GenerateAuthorityField670
    
    When Koha creates authority records from biblios, use these preferences instead
    of the hard-coded "Machine generated authority record." and "Work cat." values.
    
    Test plan:
        1. Make sure AutoCreateAuthorities and BiblioAddsAuthorities are enabled in
    the system preferences
        2. Go to Home › Cataloging › Add MARC record and add a new record
        3. Fill in the required fields and add a name in the 100$a field. Note the
    name, and add the new record.
        4. run rebuild_zebra.pl -a
        5. Go to Home › Authorities and search for the name you entered in 100$a
        6. Select details and look at the 667 and 670 fields. They should default
    to the hard-coded values.
        7. Apply patch, run update database
        8. Edit the new GenerateAuthorityField667 and GenerateAuthorityField670
    system preferences
        9. Do 2-6 . Now the 667 and 670 fields should be what you entered in the
    system preferences.
    
    Thanks for testing
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Works well, no errors
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:03:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:03:12 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-MzRBg1KwHE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133991|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:03:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:03:14 +0000
    Subject: [Koha-bugs] [Bug 13412] Allow configuration of auto-created
     authorities
    In-Reply-To: <bug-13412-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-13412-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-13412-70-137LhO9TQ0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13412
    
    --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134267
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134267&action=edit
    Bug 13412: (QA follow-up) Fix alphabetic order in sysprefs.sql
    
    TaxRates was not moved when renamed from gist, just moving it down
    so things are tidy again.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:03:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:03:17 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-vtEFy2Q7Ub@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133992|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:03:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:03:20 +0000
    Subject: [Koha-bugs] [Bug 13412] Allow configuration of auto-created
     authorities
    In-Reply-To: <bug-13412-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-13412-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-13412-70-jgSjr8zCDB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13412
    
    --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134268
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134268&action=edit
    Bug 13412: (QA follow-up) Rephrase and link system preference descriptions
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:03:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:03:21 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-q9hghqGrvG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133993|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:03:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:03:26 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-6ndQIraARm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133994|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:03:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:03:26 +0000
    Subject: [Koha-bugs] [Bug 13412] Allow configuration of auto-created
     authorities
    In-Reply-To: <bug-13412-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-13412-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-13412-70-7LCMdqNaCL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13412
    
    --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134269
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134269&action=edit
    Bug 13142: (QA follow-up) Convert database update to current format
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:03:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:03:30 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-oqxjUsadao@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133995|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:03:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:03:36 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-xQsA5yidOO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133996|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:03:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:03:40 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-oUUhfFhWni@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133997|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:03:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:03:44 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-BbKVLmZ5XT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133998|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:03:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:03:49 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-WezLIpzFMG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133999|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:03:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:03:54 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-GdmiiqtuXH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134000|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:03:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:03:58 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-NgYPkPRfOh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134001|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:04:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:04:04 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-713oZrRlra@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134227|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:19:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:19:46 +0000
    Subject: [Koha-bugs] [Bug 30646] New: Add option to send ACCTDETAILS notice
     for new patrons added at first login via LDAP/Shibboleth
    Message-ID: <bug-30646-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30646
    
                Bug ID: 30646
               Summary: Add option to send ACCTDETAILS notice for new patrons
                        added at first login via LDAP/Shibboleth
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Patrons
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: martin.renvoize at ptfs-europe.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
            Depends on: 29005
    
    It would be helpful to add automatic email to users on patron creation when
    that creation has been triggered by LDAP or Shibboleth creations.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005
    [Bug 29005] Add option to send ACCTDETAILS notice for new patrons added via
    patron imports
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:19:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:19:46 +0000
    Subject: [Koha-bugs] [Bug 29005] Add option to send ACCTDETAILS notice for
     new patrons added via patron imports
    In-Reply-To: <bug-29005-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29005-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29005-70-ECev8BbSGF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30646
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30646
    [Bug 30646] Add option to send ACCTDETAILS notice for new patrons added at
    first login via LDAP/Shibboleth
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:19:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:19:59 +0000
    Subject: [Koha-bugs] [Bug 30579] When placing item level hold,
     some options that are not used are not disabled
    In-Reply-To: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30579-70-Ob8Cm6E3ls@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579
    
    --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134270
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134270&action=edit
    Screenshot of place hold page with patch applied
    
    I am sorry, but I think this doesn't look quite right yet.
    
    I am not sure using the label here is the right element for grouping. I think
    it would be a completely new pattern and it might be much nicer to stick with
    something we already use. - Although I have a hard time to come up with
    something other than having tabs for item specific and next available right
    now.
    
    Also: for languages other than English that have longer translations this label
    will get really "high", I think some CSS change is at least in order.
    
    In general I think it would be nice to make the label part of the page broader
    here as a lot of labels already have longer descriptions and break on multiple
    lines (unrelated... but wouldn't mind having it here)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:21:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:21:00 +0000
    Subject: [Koha-bugs] [Bug 30646] Add option to send ACCTDETAILS notice for
     new patrons added at first login via LDAP/Shibboleth
    In-Reply-To: <bug-30646-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30646-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30646-70-ACMo0jZ2m4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30646
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                       |ity.org                     |.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:22:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:22:46 +0000
    Subject: [Koha-bugs] [Bug 30647] New: Add note to affected system
     preferences for temporarily disabling CSS and Javascript
    Message-ID: <bug-30647-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30647
    
                Bug ID: 30647
               Summary: Add note to affected system preferences for
                        temporarily disabling CSS and Javascript
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: System Administration
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: barbara.johnson at bedfordtx.gov
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com
    
    Bug #14004 added the ability to temporarily disable CSS and Javascript in the
    OPAC and staff client so that you can test your code.  However, I can never
    remember the string I'm supposed to add to the end of the url - which means I
    have to go look for it or don't bother because it takes me too much time.  I
    was thinking it might be handy to add a note to each of the sys prefs (see
    below) that this can be used with. 
    
    /cgi-bin/koha/opac-main.pl?DISABLE_SYSPREF_OPACUserCSS=1
    /cgi-bin/koha/opac-main.pl?DISABLE_SYSPREF_OPACUserJS=1
    /cgi-bin/koha/mainpage.pl?DISABLE_SYSPREF_IntranetUserCSS=1
    /cgi-bin/koha/mainpage.pl?DISABLE_SYSPREF_IntranetUserJS=1
    /cgi-bin/koha/opac-main.pl?DISABLE_SYSPREF_OpacAdditionalStylesheet=1
    /cgi-bin/koha/opac-main.pl?DISABLE_SYSPREF_opaclayoutstylesheet=1
    /cgi-bin/koha/mainpage.pl?DISABLE_SYSPREF_intranetcolorstylesheet=1
    /cgi-bin/koha/mainpage.pl?DISABLE_SYSPREF_intranetstylesheet=1
    
    I added a screenshot of what might work.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:24:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:24:00 +0000
    Subject: [Koha-bugs] [Bug 30647] Add note to affected system preferences for
     temporarily disabling CSS and Javascript
    In-Reply-To: <bug-30647-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30647-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30647-70-GmKJNuoi6Z@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30647
    
    --- Comment #1 from Barbara Johnson <barbara.johnson at bedfordtx.gov> ---
    Created attachment 134271
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134271&action=edit
    Note for disabling CSS
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:25:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:25:33 +0000
    Subject: [Koha-bugs] [Bug 30647] Add note to affected system preferences for
     temporarily disabling CSS and Javascript
    In-Reply-To: <bug-30647-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30647-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30647-70-91IP8IKMC6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30647
    
    --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    I like the idea - maybe using the *BaseURL parameters we could even provide a
    direct/example link?
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:26:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:26:05 +0000
    Subject: [Koha-bugs] [Bug 30646] Add option to send ACCTDETAILS notice for
     new patrons added at first login via LDAP/Shibboleth
    In-Reply-To: <bug-30646-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30646-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30646-70-2REcQglQRr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30646
    
    Jonathan Field <jonathan.field at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |jonathan.field at ptfs-europe.
                       |                            |com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:26:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:26:59 +0000
    Subject: [Koha-bugs] [Bug 30579] When placing item level hold,
     some options that are not used are not disabled
    In-Reply-To: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30579-70-lytUyLdbwT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Failed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:31:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:31:14 +0000
    Subject: [Koha-bugs] [Bug 30647] Add note to affected system preferences for
     temporarily disabling CSS and Javascript
    In-Reply-To: <bug-30647-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30647-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30647-70-dJpdpE5HdX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30647
    
    --- Comment #3 from Barbara Johnson <barbara.johnson at bedfordtx.gov> ---
    Great idea!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:48:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:48:02 +0000
    Subject: [Koha-bugs] [Bug 9717] Local use recorded for holds/transfers
    In-Reply-To: <bug-9717-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-9717-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-9717-70-T6utaT0Wpk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9717
    
    pierre.genty at biblibre.com changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |pierre.genty at biblibre.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 16:59:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 14:59:50 +0000
    Subject: [Koha-bugs] [Bug 30648] New: Title is lost in Holds History when
     biblio is deleted
    Message-ID: <bug-30648-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648
    
                Bug ID: 30648
               Summary: Title is lost in Holds History when biblio is deleted
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Patrons
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: andrew at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
    
    The patron hold history page shows "No title" for old holds on records that
    have since been deleted. We should get the title from deletedbibios if
    possible.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 17:02:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 15:02:28 +0000
    Subject: [Koha-bugs] [Bug 30646] Add option to send ACCTDETAILS notice for
     new patrons added at first login via LDAP/Shibboleth
    In-Reply-To: <bug-30646-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30646-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30646-70-WAdgwIeqex@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30646
    
    --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134272
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134272&action=edit
    Bug 30646: Add welcome email support to LDAP
    
    This patch adds the ability to enable the welcome email notice for new
    users added via the LDAP replicate option.
    
    Test plan
    1) Configure LDAP for authentication
    2) Enable the welcome email by adding '<welcome>1</welcome>' to your
       ldap config block
    3) Confirm you have replicate enabled for your LDAP config
    4) Attempt to login with an entirely new user to Koha using the LDAP
       connection (with a user who has a valid email address mapped to Koha
       borrower fields)
    5) Confirm the email is sent by looking at the notices for the new user.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 17:02:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 15:02:45 +0000
    Subject: [Koha-bugs] [Bug 30646] Add option to send ACCTDETAILS notice for
     new patrons added at first login via LDAP/Shibboleth
    In-Reply-To: <bug-30646-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30646-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30646-70-SKSxB2oErm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30646
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 17:06:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 15:06:41 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-KRUZ2eF5Dl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |rel_22_05_candidate
               Severity|enhancement                 |major
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 17:10:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 15:10:01 +0000
    Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase
     suggestions (using an Ajax-request)
    In-Reply-To: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14242-70-QKWhZeaFEO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 17:10:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 15:10:12 +0000
    Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase
     suggestions (using an Ajax-request)
    In-Reply-To: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14242-70-cqdPb6zXtX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133985|0                           |1
            is obsolete|                            |
    
    --- Comment #144 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134273
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134273&action=edit
    Bug 14242: Use ISBN-field to automatically fill out purchase suggestions
    
    Add new jQuery plugin "autofill" which transforms selected element(s)
    into search fields for Google Books API and automatically fills
    requested fields with search result.
    
    Use in OPAC purchase suggestions to automatically fill out fields when
    entering ISBN-number.
    
    Test plan:
    1. Run updatedatabase.pl
    2. Enable system precference "OPACSuggestionAutoFill"
    3. Log into OPAC and go to purchase suggestions page
    4. Write a valid ISBN (such as 0-9690745-2-2 or 978-1-78416-110-1) into
       the ISBN field and click the 'search google books' button, or unfocus
       the field.
    5. Title, Author, Publisher, publication year and Item Type fields should now
    be filled
       automatically.
    6. Press "clear form" to undo - should restore all fields that the API pull
       filled to empty
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 17:10:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 15:10:21 +0000
    Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase
     suggestions (using an Ajax-request)
    In-Reply-To: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14242-70-SGWqdNWsaL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133986|0                           |1
            is obsolete|                            |
    
    --- Comment #145 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134274
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134274&action=edit
    Bug 14242: (follow-up) Format copyright date before plugged into form
    
    This patch formats the copyright date so that only the year shows before
    plugging the formatted version into the form.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 17:10:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 15:10:29 +0000
    Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase
     suggestions (using an Ajax-request)
    In-Reply-To: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14242-70-5q4An0gPfq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133987|0                           |1
            is obsolete|                            |
    
    --- Comment #146 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134275
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134275&action=edit
    Bug 14242: (follow-up) Hide autofil when syspref disabled, clear ISBN
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 17:10:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 15:10:37 +0000
    Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase
     suggestions (using an Ajax-request)
    In-Reply-To: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14242-70-38gpu3TPS8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133988|0                           |1
            is obsolete|                            |
    
    --- Comment #147 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134276
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134276&action=edit
    Bug 14242: (follow-up) Clear all text input fields
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 17:10:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 15:10:45 +0000
    Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase
     suggestions (using an Ajax-request)
    In-Reply-To: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14242-70-eGPXtDurWS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242
    
    --- Comment #148 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134277
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134277&action=edit
    Bug 14242: (QA follow-up) Fix alphatic order of sysprefs.sql
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 17:10:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 15:10:53 +0000
    Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase
     suggestions (using an Ajax-request)
    In-Reply-To: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14242-70-4RhZGwXZK2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242
    
    --- Comment #149 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134278
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134278&action=edit
    Bug 14242: (QA follow-up) Update hint on suggestion form: 2016 > 2022
    
    First patches were written in 2015 - so I think we can safely
    move the hint closer to the present.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 17:11:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 15:11:39 +0000
    Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase
     suggestions using Google Books API
    In-Reply-To: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14242-70-bNBdrOCWQZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Use ISBN-field to fill out  |Use ISBN-field to fill out
                       |purchase suggestions (using |purchase suggestions using
                       |an Ajax-request)            |Google Books API
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 17:13:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 15:13:57 +0000
    Subject: [Koha-bugs] [Bug 29129] The printclearscreen icon on circulation.tt
     should be configuarable to print either ISSUESLIP or ISSUEQSLIP
    In-Reply-To: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29129-70-GMVTl8NH5u@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129
    
    --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Please remember to run QA test tools:
     OK     circ/circulation.pl
     FAIL   installer/data/mysql/atomicupdate/bug29129.pl
       FAIL   file permissions
                    File must have the exec flag
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 17:14:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 15:14:50 +0000
    Subject: [Koha-bugs] [Bug 30646] Add option to send ACCTDETAILS notice for
     new patrons added at first login via LDAP/Shibboleth
    In-Reply-To: <bug-30646-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30646-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30646-70-WaBrDnQAdr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30646
    
    --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134279
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134279&action=edit
    Bug 30646: Add welcome email support to SAML2
    
    This patch adds the ability to enable the welcome email notice for new
    users added via the Shibboleth autocreate option.
    
    Test plan
    1) Configure Shibboleth for authentication
    2) Enable the welcome email by adding '<welcome>1</welcome>' to your
       shibboleth config block
    3) Confirm you have autocreate enabled for your Shibboleth config
    4) Attempt to login with an entirely new user to Koha using the shibboleth
       connection (with a user who has a valid email address mapped to Koha
       borrower fields)
    5) Confirm the email is sent by looking at the notices for the new user.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 17:15:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 15:15:27 +0000
    Subject: [Koha-bugs] [Bug 30646] Add option to send ACCTDETAILS notice for
     new patrons added at first login via LDAP/Shibboleth
    In-Reply-To: <bug-30646-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30646-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30646-70-aRdpZewOW3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30646
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |matthias.meusburger at biblibr
                       |                            |e.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 17:15:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 15:15:46 +0000
    Subject: [Koha-bugs] [Bug 30646] Add option to send ACCTDETAILS notice for
     new patrons added at first login via LDAP/Shibboleth
    In-Reply-To: <bug-30646-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30646-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30646-70-hR48BffZTF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30646
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |alexbuckley at catalyst.net.nz
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 17:18:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 15:18:46 +0000
    Subject: [Koha-bugs] [Bug 30037] Set default profile when staging MARC
     records on import
    In-Reply-To: <bug-30037-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30037-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30037-70-L3ntHOXd2K@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037
    
    Florian <florian.bontemps at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Patch doesn't apply         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 17:18:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 15:18:52 +0000
    Subject: [Koha-bugs] [Bug 30037] Set default profile when staging MARC
     records on import
    In-Reply-To: <bug-30037-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30037-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30037-70-N1yLNZ5IxV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037
    
    Florian <florian.bontemps at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131329|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from Florian <florian.bontemps at biblibre.com> ---
    Created attachment 134280
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134280&action=edit
    [PATCH] Bug 30037: Select profile when staging records
    
    This is a second draft for making the profile selection process easier.
    Currently, if you have multiple profiles set up when staging Records on import,
    the defaut selection will always be "Do not use profile".
    With this patch, if at least one profile is already set up, the first one in
    the list (in alphabetical order) will be selected by default.
    
    To test:
    1) You will need a Marc record to stage.
    2) If you don't have any, create multiple profiles for staging Marc records for
    import (in the Tools section); two should be enough, they should have different
    settings.
    3) See that "Do not use profile" is always preselected.
    4) Apply patch.
    5) Reload the page : Now, the first profile of your list should be preselected.
    6) Confirm that manually picking a different profile still loads different
    settings
    7) Sign off.
    
    Now rebased.
    
    Thanks-to: Didier Gautheron <didier.gautheron at biblibre.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 17:19:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 15:19:07 +0000
    Subject: [Koha-bugs] [Bug 30646] Add option to send ACCTDETAILS notice for
     new patrons added at first login via LDAP/SAML
    In-Reply-To: <bug-30646-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30646-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30646-70-3hUFgKL6DH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30646
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Add option to send          |Add option to send
                       |ACCTDETAILS notice for new  |ACCTDETAILS notice for new
                       |patrons added at first      |patrons added at first
                       |login via LDAP/Shibboleth   |login via LDAP/SAML
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 17:21:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 15:21:36 +0000
    Subject: [Koha-bugs] [Bug 30632] Fix report author display in list of saved
     reports
    In-Reply-To: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30632-70-90Qp24dItx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |ASSIGNED
             Depends on|                            |30491
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30491
    [Bug 30491] Convert saved reports tabs to Bootstrap
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 17:21:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 15:21:36 +0000
    Subject: [Koha-bugs] [Bug 30491] Convert saved reports tabs to Bootstrap
    In-Reply-To: <bug-30491-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30491-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30491-70-rOXKzS9XRz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30491
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30632
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632
    [Bug 30632] Fix report author display in list of saved reports
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 17:22:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 15:22:08 +0000
    Subject: [Koha-bugs] [Bug 30632] Fix report author display in list of saved
     reports
    In-Reply-To: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30632-70-hTTxmSXqft@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
       Patch complexity|---                         |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 17:22:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 15:22:12 +0000
    Subject: [Koha-bugs] [Bug 30632] Fix report author display in list of saved
     reports
    In-Reply-To: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30632-70-FjdxBuQBJR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632
    
    --- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
    Created attachment 134281
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134281&action=edit
    Bug 30632: Fix report author display in list of saved reports
    
    This patch removes whitespace in the template around the markup of
    report author first name and surname. This prevents unwanted spaces in
    the output.
    
    To test, apply the patch and go to Reports -> Use saved.
    
    The display of report author should be like this:
    
    Leonard, Owen (123456)
    
    Instead of Leonard , Owen (20375)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 17:28:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 15:28:04 +0000
    Subject: [Koha-bugs] [Bug 30632] Fix report author display in list of saved
     reports
    In-Reply-To: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30632-70-wZjATNtLhl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632
    
    --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    With all the patches for preferred name/middle name and such I was wondering if
    we could use patron-title.inc here. Is there a reason not to?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 17:36:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 15:36:03 +0000
    Subject: [Koha-bugs] [Bug 30632] Fix report author display in list of saved
     reports
    In-Reply-To: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30632-70-iUUyg7crP7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632
    
    --- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
    I made this quick template fix because fixing it to use the patron-title
    include would require more complex updates to the way reports are queried. I
    certainly do not object if someone wants to take that route instead.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 17:44:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 15:44:53 +0000
    Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred
     patrons when issuing rules 'fine days = 0'
    In-Reply-To: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14784-70-PEtXqlwIKU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
    
    Florian <florian.bontemps at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |florian.bontemps at biblibre.c
                       |                            |om
    
    --- Comment #62 from Florian <florian.bontemps at biblibre.com> ---
    I concur with The Minh Luong, if I run the test plan without patching I don't
    have any issues, but after patching, step 5 (running prove -l
    t/db_dependent/Circulation.t) gets me not one, but 31 failed tests.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 17:46:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 15:46:29 +0000
    Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred
     patrons when issuing rules 'fine days = 0'
    In-Reply-To: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14784-70-otl3Z3Dcqm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|FIXED                       |WORKSFORME
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 17:46:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 15:46:48 +0000
    Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred
     patrons when issuing rules 'fine days = 0'
    In-Reply-To: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-14784-70-jMNKOKWL9d@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
    
    --- Comment #63 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Changing status to indicate more clearly that these patches haven't been
    pushed.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 18:17:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 16:17:57 +0000
    Subject: [Koha-bugs] [Bug 29129] The clear screen and print icons in
     circulation should be configuarable to print either ISSUESLIP or ISSUEQSLIP
    In-Reply-To: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29129-70-SKBjMYlfcB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|The printclearscreen icon   |The clear screen and print
                       |on circulation.tt should be |icons in circulation should
                       |configuarable to print      |be configuarable to print
                       |either ISSUESLIP or         |either ISSUESLIP or
                       |ISSUEQSLIP                  |ISSUEQSLIP
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 18:18:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 16:18:20 +0000
    Subject: [Koha-bugs] [Bug 29129] The clear screen and print icons in
     circulation should be configuarable to print either ISSUESLIP or ISSUEQSLIP
    In-Reply-To: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29129-70-9Rdf8kBiYw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |release-notes-needed
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 18:18:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 16:18:46 +0000
    Subject: [Koha-bugs] [Bug 29129] The clear screen and print icons in
     circulation should be configuarable to print either ISSUESLIP or ISSUEQSLIP
    In-Reply-To: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29129-70-l1CKOK5oQb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 18:18:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 16:18:51 +0000
    Subject: [Koha-bugs] [Bug 29129] The clear screen and print icons in
     circulation should be configuarable to print either ISSUESLIP or ISSUEQSLIP
    In-Reply-To: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29129-70-R7DR5PrkAu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134176|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134282
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134282&action=edit
    Bug 29129: Update DisplayClearScreenButton to allow for a choice between
    issueslip and issueqslip
    
    To Test:
    1. Apply patch, updatedatabase, and restart_all
    2. A small change the global scss file means you should regenerate the CSS as
    well. (
    https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface
    )
    3. Set DisplayClearScreenButton to "don't show"
    4. Go to the patron checkout screen and see that no button should show to clear
    the screen and print
    5. Set DisplayClearScreenButton to 'ISSUESLIP' and make sure the button now
    appears and the ISSUESLIP prints
    6. Set DisplayClearScreenButton to 'ISSUEQSLIP' and make sure the button now
    appears and the ISSUEQSLIP prints
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 18:18:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 16:18:56 +0000
    Subject: [Koha-bugs] [Bug 29129] The clear screen and print icons in
     circulation should be configuarable to print either ISSUESLIP or ISSUEQSLIP
    In-Reply-To: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29129-70-4FHnS1WrHm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129
    
    --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134283
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134283&action=edit
    Bug 29129: (QA follow-up) Add +x to atomicupdate permissions
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 18:19:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 16:19:01 +0000
    Subject: [Koha-bugs] [Bug 29129] The clear screen and print icons in
     circulation should be configuarable to print either ISSUESLIP or ISSUEQSLIP
    In-Reply-To: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29129-70-R6ECTVMzEO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129
    
    --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134284
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134284&action=edit
    Bug 29129: (QA follow-up): Fix tiny typo in system preference description
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 18:19:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 16:19:07 +0000
    Subject: [Koha-bugs] [Bug 29129] The clear screen and print icons in
     circulation should be configuarable to print either ISSUESLIP or ISSUEQSLIP
    In-Reply-To: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29129-70-HakgGEwyr3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129
    
    --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134285
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134285&action=edit
    Bug 29129: (QA follow-up) Rephrasing DisplayClearScreenButton preference
    
    Trying to make it clearer that's either none or 2 buttons.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 18:19:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 16:19:50 +0000
    Subject: [Koha-bugs] [Bug 29129] The clear screen and print icons in
     circulation should be configuarable to print either ISSUESLIP or ISSUEQSLIP
    In-Reply-To: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29129-70-4GNIb4dJp7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129
    
    --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Hi Lucas, maybe you can have a look at my last follow-up and let me know if
    that works for you?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 18:34:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 16:34:47 +0000
    Subject: [Koha-bugs] [Bug 30037] Set default profile when staging MARC
     records on import
    In-Reply-To: <bug-30037-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30037-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30037-70-M7xa6Kqza0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Failed QA
    
    --- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
    I think this change goes against the way we generally do things. In fact, we've
    been patching similar fields elsewhere because it was too easy for the user to
    accept a possibly incorrect default.
    
    I think if we want to define a default profile we should have it be an
    additional setting in the profile.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 18:38:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 16:38:53 +0000
    Subject: [Koha-bugs] [Bug 30326] Cronjob that checks biblios for MARC errors
    In-Reply-To: <bug-30326-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30326-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30326-70-z60YlyXyNZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30326
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Failed QA
    
    --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Hi Aleisha,
    
    this works, but some questions:
    
    1) Could we not use staffClientBaseURL instead of or as a default/fallback for
    the --intranet option? This way it would work for multiple instances without
    having differentiate the crontab entries.
    
    2) The HTML output is a little hard to read. 2 suggestions:
    
    a) Add a header row
    b) Add <br> instead of line breaks. The output on the command line is something
    like:
    
    <td>100: Indicator 1 must be 0, 1 or 3 but it's " "
    245: Indicator 1 must be 0 or 1 but it's " "
    245: Indicator 2 must be 0 thru 9 but it's " "
    245: Must end with . (period).
    245: Non-filing indicator is non-numeric
    245: First word, clouded, does not appear to be an article, check 2nd indicator
    ( ).</td>
    
    But then the lines all get "mushed together" into a long block of text without
    any separators making it hard to read/take apart:
    
    100: Indicator 1 must be 0, 1 or 3 but it's " " 245: Indicator 1 must be 0 or 1
    but it's " " 245: Indicator 2 must be 0 thru 9 but it's " " 245: Must end with
    . (period). 245: Non-filing indicator is non-numeric 245: First word, clouded,
    does not appear to be an article, check 2nd indicator ( ).
    
    
    Could you take a look and give me some feedback? Thx!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 18:43:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 16:43:00 +0000
    Subject: [Koha-bugs] [Bug 30037] Set default profile when staging MARC
     records on import
    In-Reply-To: <bug-30037-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30037-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30037-70-mNLxG58rq7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037
    
    --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    (In reply to Owen Leonard from comment #7)
    > I think this change goes against the way we generally do things. In fact,
    > we've been patching similar fields elsewhere because it was too easy for the
    > user to accept a possibly incorrect default.
    > 
    > I think if we want to define a default profile we should have it be an
    > additional setting in the profile.
    
    +1 
    
    I agree with Owen here, this was making me feel uneasy and I think the
    suggested solution would be a much better fit.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 18:46:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 16:46:53 +0000
    Subject: [Koha-bugs] [Bug 30628] Batch borrower modifications only affect
     the current page
    In-Reply-To: <bug-30628-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30628-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30628-70-qU21sZVdth@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 18:46:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 16:46:57 +0000
    Subject: [Koha-bugs] [Bug 30628] Batch borrower modifications only affect
     the current page
    In-Reply-To: <bug-30628-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30628-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30628-70-KDKrBuQnZZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134220|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134286
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134286&action=edit
    Bug 30628: Fix patron selection in batch patron modification tool
    
    bug 28014 added Datatables to this view, but the form is submitted with
    only the checkboxes from the first page.
    
    Solution adapted from
    https://stackoverflow.com/questions/33240409/how-to-submit-checkboxes-from-all-pages-with-jquery-datatables
    
    Test plan:
    Have more than 20 cardnumbers, use the batch patron modification tool
    Select (not all) patrons from the first page and second page
    Submit the form
    Notice that the patrons you have selected appear on the confirmation
    page.
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 18:50:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 16:50:34 +0000
    Subject: [Koha-bugs] [Bug 29887] Create system preference
     IndependentBranchesLoggedInLibrary
    In-Reply-To: <bug-29887-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29887-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29887-70-ASwOydMTfv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|BLOCKED                     |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 18:52:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 16:52:30 +0000
    Subject: [Koha-bugs] [Bug 30387] IndependentBranches allows users to change
     libraries when they should not be able to
    In-Reply-To: <bug-30387-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30387-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30387-70-QtpGw64utL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30387
    
    --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    I think Joubu is right about that the change needs to be not only in the
    templates, but secured server side as well.
    
    I think we'd definitely need to push this together with 29887 to make sure we
    don't break someones use case by closing this loop-holes.
    
    Would it make sense to test both patches together?
    
    As this is now SO I have moved bug 29887 back into the QA queue.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 19:54:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 17:54:45 +0000
    Subject: [Koha-bugs] [Bug 30553] Add a count to the Files tab in the patron
     account
    In-Reply-To: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30553-70-1UzdQxZKe2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30553
    
    --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
    Created attachment 134287
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134287&action=edit
    Bug 30553: Unit tests
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 19:55:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 17:55:55 +0000
    Subject: [Koha-bugs] [Bug 30553] Add a count to the Files tab in the patron
     account
    In-Reply-To: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30553-70-mB3Yd11YKU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30553
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 20:23:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 18:23:06 +0000
    Subject: [Koha-bugs] [Bug 28950] serialsUpdate cron does not mark an issue
     late until the next issue is expected
    In-Reply-To: <bug-28950-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28950-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28950-70-I6swfaZ2y9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28950
    
    Patrick Robitaille <patrick.robitaille at collecto.ca> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |patrick.robitaille at collecto
                       |                            |.ca
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 20:27:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 18:27:00 +0000
    Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
    In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24857-70-poq1JPU8nH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #131449|0                           |1
            is obsolete|                            |
     Attachment #131450|0                           |1
            is obsolete|                            |
     Attachment #131451|0                           |1
            is obsolete|                            |
     Attachment #131452|0                           |1
            is obsolete|                            |
     Attachment #131453|0                           |1
            is obsolete|                            |
     Attachment #131454|0                           |1
            is obsolete|                            |
     Attachment #131455|0                           |1
            is obsolete|                            |
     Attachment #131456|0                           |1
            is obsolete|                            |
    
    --- Comment #472 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134288
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134288&action=edit
    Bug 24857: Database updates
    
    This adds the new tables, syspref, and a new permission
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 20:27:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 18:27:22 +0000
    Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
    In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24857-70-eAb5RLQG6Q@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857
    
    --- Comment #473 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134289
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134289&action=edit
    Bug 24857: Add Koha Objects
    
    To test:
    1 - prove t/db_dependent/Koha/Biblio/ItemGroups.t
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 20:27:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 18:27:33 +0000
    Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
    In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24857-70-g8sIX4jHQt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857
    
    --- Comment #474 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134290
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134290&action=edit
    Bug 24857: API spec
    
    To test:
    1 - prove t/db_dependent/api/v1/item_groups.t
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 20:27:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 18:27:42 +0000
    Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
    In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24857-70-yMqRJHqE2L@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857
    
    --- Comment #475 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134291
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134291&action=edit
    Bug 24857: Add Object Methods
    
    To test:
    1 - prove t/db_dependent/Koha/Biblio.t
    2 - prove t/db_dependent/Koha/Item.t
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 20:27:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 18:27:51 +0000
    Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
    In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24857-70-Qbf8bqvelY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857
    
    --- Comment #476 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134292
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134292&action=edit
    Bug 24857: Add item group management to detail.pl
    
    Test Plan:
    1) Apply the patches for this bug
    2) Run updatedatabase.pl
    3) Restart all the things!
    4) Enable the new syspref EnableItemGroups
    5) Browse to detail.pl for a record with items
    6) Note the new Item Groups tab
    7) Test creating, editing and deleting groups
    8) On the Holdings tab, select one or more items using the checkboxes
    8) Note new selection options for setting an item group for items,
       and for clearing an item group for items.
    9) Test adding and clearing the item group for items
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 20:28:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 18:28:01 +0000
    Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
    In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24857-70-h0vOESEPue@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857
    
    --- Comment #477 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134293
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134293&action=edit
    Bug 24857: Add ability to set item group when adding a new item
    
    During cataloging a user may wish to add an item to a group when
    creating a new item
    
    This patch also copies the group description to the enumchron field
    
    To test:
    1 - Browse to details page for a record
    2 - Create or ensure the record has item group(s)
    3 - Click New->New item
    4 - Note the bottom of the page has a form to attach to existing group, or
    create new
    5 - Note when a group is selected the enumchron field is populated
    6 - Confirm item is saved to group when saved
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 20:28:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 18:28:11 +0000
    Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
    In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24857-70-GC1MYgzuUG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857
    
    --- Comment #478 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134294
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134294&action=edit
    Bug 24857: Delete item group when last item is deleted
    
    To test:
    1 - Find a record with an item gorup, or add a group
    2 - Add an item to this group, ensure it is the only item in the group
    3 - Delete the item
    4 - Confirm the gorup was also deleted
    5 - prove t/db_dependent/Koha/Biblio/ItemGroups.t
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 20:28:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 18:28:20 +0000
    Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
    In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24857-70-Vao5wR5wFn@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857
    
    --- Comment #479 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134295
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134295&action=edit
    Bug 24857: DO NOT PUSH: Schema changes
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 20:28:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 18:28:30 +0000
    Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
    In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24857-70-bvQEcDogE0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857
    
    --- Comment #480 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134296
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134296&action=edit
    Bug 24857: Add object classes to Schema
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 20:28:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 18:28:54 +0000
    Subject: [Koha-bugs] [Bug 30649] New: Add ability to encrypt data in Koha,
     use for EDI vendor accounts
    Message-ID: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649
    
                Bug ID: 30649
               Summary: Add ability to encrypt data in Koha, use for EDI
                        vendor accounts
     Change sponsored?: ---
               Product: Koha
               Version: 21.05
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Architecture, internals, and plumbing
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: kyle at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
    
    Right now, we store passwords for external services in plain text in the
    database. It would be good to have the option to encrypt those passwords.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 20:29:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 18:29:00 +0000
    Subject: [Koha-bugs] [Bug 30649] Add ability to encrypt data in Koha,
     use for EDI vendor accounts
    In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30649-70-S2WHgGFOCZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                       |ity.org                     |
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 20:31:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 18:31:47 +0000
    Subject: [Koha-bugs] [Bug 29755] SIP2 code does not correctly handle
     NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees
    In-Reply-To: <bug-29755-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29755-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29755-70-qKJcEU9mth@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 20:31:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 18:31:50 +0000
    Subject: [Koha-bugs] [Bug 30649] Add ability to encrypt data in Koha,
     use for EDI vendor accounts
    In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30649-70-wFpyWVboDJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 20:31:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 18:31:53 +0000
    Subject: [Koha-bugs] [Bug 29755] SIP2 code does not correctly handle
     NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees
    In-Reply-To: <bug-29755-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29755-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29755-70-fgxlHfTpc6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134221|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from David Nind <david at davidnind.com> ---
    Created attachment 134297
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134297&action=edit
    Bug 29755: Check each NoIssuesCharge separately
    
    This patch updates SIP patron code to use account methods to calculate balances
    over the patronflags returns. It also checks if patron should be blocked for
    each
    'No Issues charge' preference
    
    Tests are added for NoIssuesChargeGuarantees
    
    To test:
     1 - Set noissuescharge preference to 5
     2 - Add a $10 charge to a patron
     3 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l
    CPL -m patron_information --patron BARCODE
     4 - Note the 64 message starts with Y's that mean patron is blocked
     5 - Set noissuescharge to 11
     6 - Repeat 3, patron is no longer blocked
     7 - Set NoIssuesChargeGuarantees to 8
     8 - Repeat 3, patron is blocked
     9 - Pay $3 on patron so they owe 7
    10 - Repeat 3, patron is not blocked
    11 - Add a child account with patron as guarantor
    12 - Repeat 3, patron is not blocked
    13 - Add a $4 charge to child
    14 - Repeat 3, patron is blocked
    15 - Repeat 3, but with child barcode, child is not blocked
    16 - Set NoIssuesChargeGuarantorsWithGuarantees to 10
    17 - Repeat 3, patron is blocked
    18 - Repeat 3 with child barcode, child is blocked
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 20:31:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 18:31:54 +0000
    Subject: [Koha-bugs] [Bug 30649] Add ability to encrypt data in Koha,
     use for EDI vendor accounts
    In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30649-70-eZUMSb5x21@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649
    
    --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Created attachment 134298
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134298&action=edit
    Bug 30649 - Add ability to encrypt data in Koha, use for EDI vendor accounts
    
    Right now, we store passwords for external services in plain text in the
    database. It would be good to have the option to encrypt those passwords.
    
    Test Plan:
    1) prove t/Crypt.t
    2) Create a new vendor edi account
    3) Note the password is encrypted
    4) Update the password for an existing EDI vendor account
    5) Note the password is now encrypted in the database
    6) Stretch goal, set up an FTP server, send an EDI order to the FTP
       server where the vendor password is encrypted.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 20:31:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 18:31:58 +0000
    Subject: [Koha-bugs] [Bug 29755] SIP2 code does not correctly handle
     NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees
    In-Reply-To: <bug-29755-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29755-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29755-70-F9aSe9VSQx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134222|0                           |1
            is obsolete|                            |
    
    --- Comment #7 from David Nind <david at davidnind.com> ---
    Created attachment 134299
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134299&action=edit
    Bug 29755: (follow-up) Mock NoIssuesChargeGuarantorsWithGuarantees in test
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 20:33:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 18:33:52 +0000
    Subject: [Koha-bugs] [Bug 30649] Add ability to encrypt data in Koha,
     use for EDI vendor accounts
    In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30649-70-PrESoK2MIo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134298|0                           |1
            is obsolete|                            |
    
    --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Created attachment 134300
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134300&action=edit
    Bug 30649 - Add ability to encrypt data in Koha, use for EDI vendor accounts
    
    Right now, we store passwords for external services in plain text in the
    database. It would be good to have the option to encrypt those passwords.
    
    Test Plan:
    1) prove t/Crypt.t
    2) Create a new vendor edi account
    3) Note the password is encrypted
    4) Update the password for an existing EDI vendor account
    5) Note the password is now encrypted in the database
    6) Stretch goal, set up an FTP server, send an EDI order to the FTP
       server where the vendor password is encrypted.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 20:36:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 18:36:46 +0000
    Subject: [Koha-bugs] [Bug 30649] Add ability to encrypt data in Koha,
     use for EDI vendor accounts
    In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30649-70-CFDPyQ3BQu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134300|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Created attachment 134301
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134301&action=edit
    Bug 30649 - Add ability to encrypt data in Koha, use for EDI vendor accounts
    
    Right now, we store passwords for external services in plain text in the
    database. It would be good to have the option to encrypt those passwords.
    
    Test Plan:
    1) prove t/Crypt.t
    2) Create a new vendor edi account
    3) Note the password is encrypted
    4) Update the password for an existing EDI vendor account
    5) Note the password is now encrypted in the database
    6) Stretch goal, set up an FTP server, send an EDI order to the FTP
       server where the vendor password is encrypted.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 20:47:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 18:47:07 +0000
    Subject: [Koha-bugs] [Bug 30649] Add ability to encrypt data in Koha,
     use for EDI vendor accounts
    In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30649-70-f3Ye1fARUc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134301|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Created attachment 134302
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134302&action=edit
    Bug 30649 - Add ability to encrypt data in Koha, use for EDI vendor accounts
    
    Right now, we store passwords for external services in plain text in the
    database. It would be good to have the option to encrypt those passwords.
    
    Test Plan:
    1) prove t/Crypt.t
    2) Create a new vendor edi account
    3) Note the password is encrypted
    4) Update the password for an existing EDI vendor account
    5) Note the password is now encrypted in the database
    6) Stretch goal, set up an FTP server, send an EDI order to the FTP
       server where the vendor password is encrypted.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 20:48:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 18:48:37 +0000
    Subject: [Koha-bugs] [Bug 23781] Recalls notices and messaging preferences
    In-Reply-To: <bug-23781-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23781-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23781-70-AAlmJstgHd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Patch doesn't apply
    
    --- Comment #9 from David Nind <david at davidnind.com> ---
    Patch no longer applies 8-(.. apologies for not getting back on to this one
    sooner.
    
    Applying: Bug 23781: SMS notices and messaging preferences for recalls
    Using index info to reconstruct a base tree...
    M       Koha/Recall.pm
    M       Koha/Recalls.pm
    M       installer/data/mysql/en/mandatory/sample_notices.yml
    M       installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql
    M       koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc
    Falling back to patching base and 3-way merge...
    Auto-merging
    koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc
    CONFLICT (content): Merge conflict in
    koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc
    Auto-merging installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql
    Auto-merging installer/data/mysql/en/mandatory/sample_notices.yml
    Auto-merging Koha/Recalls.pm
    Auto-merging Koha/Recall.pm
    error: Failed to merge in the changes.
    Patch failed at 0001 Bug 23781: SMS notices and messaging preferences for
    recalls
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 21:06:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 19:06:21 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-ME7laUQrCb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #50 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Sorry, it seems I didn't confirm the upload on my desktop computer. Will do
    once I get back home.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 21:22:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 19:22:13 +0000
    Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
    In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24857-70-S4PHIijiyf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857
    
    --- Comment #481 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    I don't understand enough this feature and its links with other features.
    So I've chosen to pass it to next Release Manager.
    Great work ByWaters.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 22:25:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 20:25:23 +0000
    Subject: [Koha-bugs] [Bug 30628] Batch borrower modifications only affect
     the current page
    In-Reply-To: <bug-30628-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30628-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30628-70-o4G7gTsPKp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |david at davidnind.com
      Text to go in the|                            |This fixes the batch patron
          release notes|                            |modification (Tools >
                       |                            |Patrons and circulation >
                       |                            |Batch patron modification)
                       |                            |so that the changes for all
                       |                            |selected patrons are
                       |                            |modified. Before this, only
                       |                            |the patrons listed on the
                       |                            |current page were modified.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 22:26:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 20:26:02 +0000
    Subject: [Koha-bugs] [Bug 30628] Batch borrower modifications only affect
     the current page
    In-Reply-To: <bug-30628-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30628-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30628-70-A6NZD9KfgJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
      Text to go in the|This fixes the batch patron |This fixes the batch patron
          release notes|modification (Tools >       |modification tool (Tools >
                       |Patrons and circulation >   |Patrons and circulation >
                       |Batch patron modification)  |Batch patron modification)
                       |so that the changes for all |so that the changes for all
                       |selected patrons are        |selected patrons are
                       |modified. Before this, only |modified. Before this, only
                       |the patrons listed on the   |the patrons listed on the
                       |current page were modified. |current page were modified.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 22:50:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 20:50:30 +0000
    Subject: [Koha-bugs] [Bug 30632] Fix report author display in list of saved
     reports
    In-Reply-To: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30632-70-Yx7ofHYKM4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 22:50:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 20:50:35 +0000
    Subject: [Koha-bugs] [Bug 30632] Fix report author display in list of saved
     reports
    In-Reply-To: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30632-70-RJbbE4GQyf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134281|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from David Nind <david at davidnind.com> ---
    Created attachment 134303
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134303&action=edit
    Bug 30632: Fix report author display in list of saved reports
    
    This patch removes whitespace in the template around the markup of
    report author first name and surname. This prevents unwanted spaces in
    the output.
    
    To test, apply the patch and go to Reports -> Use saved.
    
    The display of report author should be like this:
    
    Leonard, Owen (123456)
    
    Instead of Leonard , Owen (20375)
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 22:50:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 20:50:37 +0000
    Subject: [Koha-bugs] [Bug 24001] Cannot edit card template
    In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24001-70-Ioh9fgyevL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 22:50:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 20:50:45 +0000
    Subject: [Koha-bugs] [Bug 24001] Cannot edit card template
    In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24001-70-0kD2EjGc0n@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
    
    --- Comment #58 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 22:50:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 20:50:49 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-WA9JeEDzIR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 22:50:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 20:50:52 +0000
    Subject: [Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes
     effect
    In-Reply-To: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30576-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30576-70-gg9dDKqdgg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576
    
    --- Comment #17 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 22:50:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 20:50:55 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-WmjgJgC953@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 22:51:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 20:51:00 +0000
    Subject: [Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter
     query correctly
    In-Reply-To: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30626-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30626-70-MzMPsZmoTY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626
    
    --- Comment #17 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 22:51:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 20:51:03 +0000
    Subject: [Koha-bugs] [Bug 30630] Checking in a waiting hold at another
     branch when HoldsAutoFill is enabled causes errors
    In-Reply-To: <bug-30630-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30630-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30630-70-5ERitmXRID@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to master
             Version(s)|                            |22.05.00
            released in|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 22:51:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 20:51:07 +0000
    Subject: [Koha-bugs] [Bug 30630] Checking in a waiting hold at another
     branch when HoldsAutoFill is enabled causes errors
    In-Reply-To: <bug-30630-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30630-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30630-70-qKdhIl6K1G@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630
    
    --- Comment #6 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 22:51:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 20:51:11 +0000
    Subject: [Koha-bugs] [Bug 30644] Cannot delete items
    In-Reply-To: <bug-30644-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30644-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30644-70-ar329iyeH2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30644
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|                            |22.05.00
            released in|                            |
                 Status|Passed QA                   |Pushed to master
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 22:51:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 20:51:15 +0000
    Subject: [Koha-bugs] [Bug 30644] Cannot delete items
    In-Reply-To: <bug-30644-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30644-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30644-70-Op4eeQfFu7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30644
    
    --- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Pushed to master for 22.05, thanks to everybody involved 🦄
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Thu Apr 28 22:54:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 20:54:53 +0000
    Subject: [Koha-bugs] [Bug 30632] Fix report author display in list of saved
     reports
    In-Reply-To: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30632-70-znpdwFKfFb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
      Text to go in the|                            |This fixes the display of
          release notes|                            |report authors in the list
                       |                            |of saved reports to remove
                       |                            |the extra space before the
                       |                            |comma (Lastname, Firstname
                       |                            |was displaying as Lastname
                       |                            |, Firstname).
                     CC|                            |david at davidnind.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 00:13:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 22:13:29 +0000
    Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
     contents into notices tool
    In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-3150-70-KoxFy3D8EQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 00:13:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 22:13:36 +0000
    Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
     contents into notices tool
    In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-3150-70-kDx49zy8C8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #130150|0                           |1
            is obsolete|                            |
    
    --- Comment #83 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Created attachment 134304
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134304&action=edit
    Bug 3150: Move emails for sending cart and list contents to notices
    
    This patch creates notices using Template Toolkit syntax for sending
    emails containing cart and list contents.
    
    To test:
    1. Apply Bug 27266
    2. Run update database and restart services
    3. In the staff client, add multiple items to your cart and to a list
    4. Go to your cart and click Send to email the contents
    5. Add an email and a comment and click Send
    6. Confirm the information shown in the success message is correct
    7. In your terminal, log into the database. View the message queue ( i.e.
    select * from message_queue; ). Confirm that your email has been queued and the
    content is all correct. Confirm the cart contents has been included as an
    attachment.
    8. Go to your list and click Send list to email the contents
    9. Repeat steps 5-7
    10. Log into the OPAC
    11. Add multiple items to your cart and to a list
    12. Repeat steps 4-9
    13. By the end, you should have four emails in your message queue. All
    of the data about the items should be correct, they should all have
    attachments, and be addressed to the correct email address.
    
    Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ)
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 00:13:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 22:13:43 +0000
    Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
     contents into notices tool
    In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-3150-70-cn9CUbMmbw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #130151|0                           |1
            is obsolete|                            |
    
    --- Comment #84 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Created attachment 134305
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134305&action=edit
    Bug 3150: (follow-up) HTML filtering TT notices and removing old files
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 00:13:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 22:13:49 +0000
    Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
     contents into notices tool
    In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-3150-70-GfLEcsMCSa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #130152|0                           |1
            is obsolete|                            |
    
    --- Comment #85 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Created attachment 134306
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134306&action=edit
    Bug 3150: (follow-up) Reformat notices, don't send if no sender email
    
    This patch reformats the notices so that the is_html flag is disabled
    and the notices display better
    
    It also throws an error if trying to send an email but the logged in
    borrower has no valid email address.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 00:13:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 22:13:56 +0000
    Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
     contents into notices tool
    In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-3150-70-OenkJQ1qQT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #130153|0                           |1
            is obsolete|                            |
    
    --- Comment #86 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Created attachment 134307
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134307&action=edit
    Bug 3150: (follow-up) Add missing bracket
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 00:14:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 22:14:02 +0000
    Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
     contents into notices tool
    In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-3150-70-E4X2GQTE1W@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150
    
    --- Comment #87 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Created attachment 134308
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134308&action=edit
    Bug 3150: (follow-up) Fixing errors and notices
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 00:55:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 22:55:08 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-aLFP92BEhA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #51 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134309
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134309&action=edit
    Bug 29346: Refactor loop code into a subroutine
    
    The CreateQueue() method deletes the holds queue data, fetches some
    configuration (branches to use, transport cost matrix) and then loops
    through a list of biblionumbers, generating the tmp_holdsqueue and
    hold_fill_targets rows for the specified biblio.
    
    This patch simply moves that last bit that is run inside the biblios
    loop into a separate sub.
    
    The update_queue_for_biblio sub is designed so it does the exact same
    thing it did inside the loop, but also gets added the capability of
    querying those parameters if not passed, and it also gets a 'delete'
    parameter so it deletes the biblio-specific holds queue rows before
    starting to work.
    
    This way, it can be reused to write a background job for real-time holds
    queue update :-D
    
    To test:
    1. Run:
       $ kshell
      k$ prove t/db_dependent/HoldsQueue.t
    => SUCCESS: Tests pass!
    2. Apply this patch
    3. Repeat 1
    => SUCCESS: Tests still pass! Behavior is kept!
    4. Sign off :-D
    
    Sponsored-by: Montgomery County Public Libraries
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 00:55:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 22:55:16 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-HQJD9AcPPo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #52 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134310
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134310&action=edit
    Bug 29346: Add holds queue update background job
    
    This patch adds a background job that takes care of updating the holds
    queue rows for a given list of biblios.
    
    It is designed to be used for real-time batch updating the holds queue
    when required. Tasks would be added by the relevant methods under the
    right use cases.
    
    Sponsored-by: Montgomery County Public Libraries
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 00:55:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 22:55:25 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-XGxf3jSFZW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #53 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134311
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134311&action=edit
    Bug 29346: Hold actions triggers
    
    This patch makes several holds related actions schedule the background
    job for real-time update of the holds queue.
    
    This actions are:
    
    - place (C4::Reserves::AddReserve)
    - fill (Koha::Hold->fill)
    - cancel (Koha::Hold->cancel)
    - suspend (Koha::Hold->suspend)
    - resume (Koha::Hold->resume)
    
    The cancel() action is added a *skip_holds_queue* parameter to skip
    triggering the background job entirely. It targets cases like
    C4::Biblio::DelBiblio in which all biblio holds are cancelled in a loop.
    In that case, we just want to cancel them and let a single backgroung
    job take care of the holds queue, once the biblio is deleted.
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Hold.t \
               t/db_dependent/Reserves.t
    => SUCCESS: Tests pass! Triggers are triggered
    3. Sign off :-D
    
    Sponsored-by: Montgomery County Public Libraries
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 00:55:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 22:55:35 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-V22Ij7KhUA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #54 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134312
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134312&action=edit
    Bug 29346: Circulation actions triggers
    
    This patch introduces triggers for real-time updating the holds queue at
    check out and check in.
    
    The following high-level methods are involved:
    
    - C4::Circulation::AddIssue
    - C4::Circulation::AddReturn
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Circulation_holdsqueue.t
    => SUCCESS: Tests pass! Triggers are triggered
    3. Sign off :-D
    
    Note: I put the tests on a separate file because the other one was too
    big already.
    
    Sponsored-by: Montgomery County Public Libraries
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 00:55:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 22:55:45 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-ilGCgOraKX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #55 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134313
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134313&action=edit
    Bug 29346: Biblio actions triggers
    
    This patch adds the trigger for the holds queue update on teh following
    methods:
    
    - C4::Biblio::DelBiblio
    - C4::Biblio::ModBiblio
    
    The ModBiblio use case could be improved by checking if itemtype is one
    of the updated attributes... but it felt there was no way to do it
    without some overhead. So I leave it as-is.
    
    It also mocks the ->enqueue method in the tests that call DelBiblio and
    ModBiblio to avoid breakages [1]
    
    Tests are added to check the trigger is called.
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Biblio.t
    => SUCCESS: Tests pass! It means the trigger is triggered :-D
    3. Sign off :-D
    
    [1] This breakages could be avoided if we solve Koha/BackgrounJob.pm:101
    FIXME.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 00:55:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 22:55:56 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-cpAfukDlak@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #56 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134314
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134314&action=edit
    Bug 29346: Item action trigger
    
    This patch makes the following actions trigger a holds queue rebuild for
    the related biblio:
    
    - Adding an item
    - Updating an item
    - Deleting an item
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Item.t
    => SUCCESS: Tests pass! Background job scheduled
    3. Sign off :-D
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 00:56:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 22:56:07 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-cBXSn8knB1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #57 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134315
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134315&action=edit
    Bug 29346: (follow-up) Fix typo
    
    We set biblio_ids in enqueue then referred to biblio_id in process ;)
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 00:56:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 22:56:26 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-g4i1sxq0C3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #58 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134316
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134316&action=edit
    Bug 29346: Highlight double enqueue
    
    This patch highlights a possible issue with the triggers.. though it may
    not actually matter in reality.
    
    I appear to already see test failures before this patch with a double
    enqueue of the rebuild for both AddIssue and AddReturn.. I couldn't spot
    what was causing that but whilst digging I did find another case where
    it could happen as highlighted here...
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 00:56:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 22:56:41 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-wA8S1q4agY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #59 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134317
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134317&action=edit
    Bug 29346: Avoid duplicate actions tests
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 00:56:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 22:56:50 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-eb8GXp2eHh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #60 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134318
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134318&action=edit
    Bug 29346: Add more fine-grained control of holds queue updates
    
    This patch deals with the fact that high-level circualtion methods like
    `AddIssue`, `AddReturn` and `ModDateLastSeen` all eventually call
    lower-level methods like ModBiblio, Koha::Item->store of
    UpdateTotalIssues which are expected to trigger holds queue updates (for
    the object CRUD operations use cases). As the circulation methods need
    to trigger holds queue update as well, duplicate updates were being
    requested which is suboptimal, of course.
    
    In order to prevent this, and because circulation methdos could trigger
    holds queue updates several times, actually, I added a new parameter
    *skip_holds_queue* to the low-level methods, so when they are called
    from circulation, the trigger is skipped and we have greater control on
    when and how holds queue updates are scheduled.
    
    This patch introduces the `skip_holds_queue` parameter to the following
    methods:
    
    * C4::Biblio::ModBiblio
    * C4::Biblio::UpdateTotalIssues
    * Koha::Item->store
    
    Calls to those methods from the following methods will include the new
    parameter, and thus duplicated holds queue updates avoided:
    
    * C4::Circulation::AddIssue
    * C4::Circulation::AddReturn
    * C4::Items::ModDateLastSeen
    
    Tests are added, to verify that the (mocked) BatchUpdateBiblioHoldsQueue
    task is only scheduled once when they are called.
    
    To test:
    1. Apply up to the previous patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Biblio.t \
               t/db_dependent/Biblio_holdsqueue.t \
               t/db_dependent/Circulation_holdsqueue.t
    => FAIL: Tests fail!
    3. Apply this patch
    4. Repeat 2
    => SUCCESS: Tests pass!
    5. Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 00:57:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 22:57:02 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-Qr6uraqbl2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #61 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134319
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134319&action=edit
    Bug 29346: (QA follow-up) Rebuild queue when adjusting priorities of holds
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 00:57:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 22:57:13 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-9UblI3QrJP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #62 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134320
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134320&action=edit
    Bug 29346: (follow-up) Fix typo 'availabe'
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 00:57:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 22:57:24 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-YV0fLMEfJ7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #63 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134321
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134321&action=edit
    Bug 29346: Add better reporting
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 00:57:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 22:57:35 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-BVByGLG7tG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #64 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134322
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134322&action=edit
    Bug 29346: Remove unused circular dependency on C4::Search
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 01:34:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 23:34:45 +0000
    Subject: [Koha-bugs] [Bug 30649] Add ability to encrypt data in Koha,
     use for EDI vendor accounts
    In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30649-70-ZfsFgGcwWu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |dcook at prosentient.com.au
    
    --- Comment #5 from David Cook <dcook at prosentient.com.au> ---
    I think Jonathan has already almost gotten an encryption module into Koha with
    Bug 28998, so this would arguably be a duplicate?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 01:34:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 23:34:55 +0000
    Subject: [Koha-bugs] [Bug 30649] Add ability to encrypt data in Koha,
     use for EDI vendor accounts
    In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30649-70-XqBImx7cHG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=28998
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 01:34:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 23:34:55 +0000
    Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
    In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28998-70-0nlMu74xzt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30649
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 01:38:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 23:38:56 +0000
    Subject: [Koha-bugs] [Bug 30326] Cronjob that checks biblios for MARC errors
    In-Reply-To: <bug-30326-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30326-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30326-70-qvZ8Tj39Iw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30326
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |dcook at prosentient.com.au
    
    --- Comment #10 from David Cook <dcook at prosentient.com.au> ---
    (In reply to Katrin Fischer from comment #9)
    > But then the lines all get "mushed together" into a long block of text
    > without any separators making it hard to read/take apart:
    
    Perhaps wrap it in "<pre></pre>" tags that preserve the original formatting
    from MARC::Lint?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 01:44:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Thu, 28 Apr 2022 23:44:40 +0000
    Subject: [Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today
     when storing an item
    In-Reply-To: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29958-70-00eGjJkfN7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958
    
    David Cook <dcook at prosentient.com.au> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |dcook at prosentient.com.au
    
    --- Comment #7 from David Cook <dcook at prosentient.com.au> ---
    (In reply to Marcel de Rooy from comment #4)
    > Does it make more sense to choose some arbitrary date for all unknown
    > acquired dates and run a SQL update to replace the NULLs? And even the
    > 0000-00-00 values that I still discovered in my table too?
    
    +1
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 02:44:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 00:44:11 +0000
    Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account
     opening and closing hours
    In-Reply-To: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-6796-70-l7pcCLHta8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796
    
    Hayley Pelham <hayleypelham at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Patch doesn't apply         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are the QA Contact for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 02:44:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 00:44:15 +0000
    Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account
     opening and closing hours
    In-Reply-To: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-6796-70-sU3EXXo8VB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796
    
    --- Comment #9 from Hayley Pelham <hayleypelham at catalyst.net.nz> ---
    Created attachment 134323
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134323&action=edit
    Bug 6796: Add branch_hours table and set opening hours for library
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the QA Contact for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 02:46:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 00:46:00 +0000
    Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account
     opening and closing hours
    In-Reply-To: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-6796-70-oF3pSW9ATs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796
    
    Hayley Pelham <hayleypelham at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #124669|0                           |1
            is obsolete|                            |
     Attachment #124670|0                           |1
            is obsolete|                            |
     Attachment #124671|0                           |1
            is obsolete|                            |
     Attachment #124672|0                           |1
            is obsolete|                            |
    
    --- Comment #10 from Hayley Pelham <hayleypelham at catalyst.net.nz> ---
    Created attachment 134324
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134324&action=edit
    Bug 6796: Updated schema files
    
    -- 
    You are receiving this mail because:
    You are the QA Contact for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 02:46:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 00:46:57 +0000
    Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account
     opening and closing hours
    In-Reply-To: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-6796-70-2a3W0QJOFC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796
    
    --- Comment #11 from Hayley Pelham <hayleypelham at catalyst.net.nz> ---
    Created attachment 134325
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134325&action=edit
    Bug 6796: ConsiderLibraryHoursWhenIssuing system preference
    
    -- 
    You are receiving this mail because:
    You are the QA Contact for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 02:47:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 00:47:29 +0000
    Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account
     opening and closing hours
    In-Reply-To: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-6796-70-ADrAF9cMuK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796
    
    --- Comment #12 from Hayley Pelham <hayleypelham at catalyst.net.nz> ---
    Created attachment 134326
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134326&action=edit
    Bug 6796: Consider library hours when calculating due date + tests
    
    This feature adds the ability to set opening and closing hours for your
    library and for these hours to be considered when calculating due dates
    for hourly loans. If the due date for an hourly loan falls after the
    library closes, the library can choose for the due date to be shortened
    to meet the close time, or extended to meet the open time the next day.
    This feature adds a new table 'branch_hours' for storing the open and
    close times per day for each library, and a new system preference
    'ConsiderLibraryHoursWhenIssuing' to choose which behaviour should be
    followed when calculating due dates.
    
    To test:
    1. Apply patches and update database. Upgrade schema if not applying
    patch with schema changes. Restart services.
    2. Go to Administration -> Libraries. Edit a library and scroll to the
    bottom to find the 'opening hours' section. Test adding and removing
    open and close times on various days. Confirm saving works as expected.
    3. Add a new library and test adding open and close times works as
    expected.
    4. Edit your default library and save open and close times for each day.
    5. Go to Administration -> Circulation and fine rules. Edit a rule, set
    the unit to 'hours' and set the loan period to a number that would cause
    a checkout to be due after the close time you just set, i.e. if you set
    your close time to be 5pm and your system time is currently 1pm, set the
    loan period to be 5 (5 hours) so the calculated due date would be 6pm.
    6. Go to Administration -> system preferences. Search for
    ConsiderLibraryHoursWhenIssuing. It should be under 'Checkout policy' in
    the Circulation system preferences. Confirm the pre-selected option is
    'ignore'. Keep this tab open.
    6. In a new tab, get the barcode for an item that has an itemtype
    matching the circulation rule you just set.
    7. Go to the checkouts for a patron that has a categorycode matching the
    circulation rule you just set.
    8. Check out your item. Confirm that the checkout is due at the end of
    the loan period, not taking closing hours into consideration. Return the
    item.
    9. Back in your other tab, set ConsiderLibraryHoursWhenIssuing to
    'close', so the due date should be shortened to meet the close time.
    10. Check out your item. Confirm the checkout is due when the library
    closes. Return the item.
    11. Back in your other tab, set ConsiderLibraryHoursWhenIssuing to
    'open', so the due date should be extended to meet the opening time.
    12. Check out your item. Confirm the checkout is due the next day when
    the library opens.
    13. Confirm tests pass t/db_dependent/Circulation/CalcDateDue.t
    
    Sponsored-by: Catalyst IT
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the QA Contact for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 02:47:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 00:47:55 +0000
    Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account
     opening and closing hours
    In-Reply-To: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-6796-70-s9pNrd7Q8s@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796
    
    --- Comment #13 from Hayley Pelham <hayleypelham at catalyst.net.nz> ---
    Created attachment 134327
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134327&action=edit
    Bug 6796: (follow-up) Fix logic for calculating following day's open hours
    
    Since days for branch hours are stored as 0-6 in the database, when it's
    a Saturday (6) incrementing the date leads to an error when issuing an
    hourly loan because no opening hours are found for the non-existent day
    (7).
    
    This patch fixes this by calculating the tomorrow day and setting it to
    0 if it's greater than 6.
    
    This patch also corrects the mappings for days, where local_day_of_week
    caluclates the date with Sunday first, which put it out of sync with the
    database opening hours days.
    
    Sponsored-by: Auckland University of Technology
    Sponsored-by: Catalyst IT
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the QA Contact for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 03:02:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 01:02:31 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-AvmC1fKKUt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 03:02:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 01:02:36 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-zO30bojCYp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134309|0                           |1
            is obsolete|                            |
     Attachment #134310|0                           |1
            is obsolete|                            |
     Attachment #134311|0                           |1
            is obsolete|                            |
     Attachment #134312|0                           |1
            is obsolete|                            |
     Attachment #134313|0                           |1
            is obsolete|                            |
     Attachment #134314|0                           |1
            is obsolete|                            |
     Attachment #134315|0                           |1
            is obsolete|                            |
     Attachment #134316|0                           |1
            is obsolete|                            |
     Attachment #134317|0                           |1
            is obsolete|                            |
     Attachment #134318|0                           |1
            is obsolete|                            |
     Attachment #134319|0                           |1
            is obsolete|                            |
     Attachment #134320|0                           |1
            is obsolete|                            |
     Attachment #134321|0                           |1
            is obsolete|                            |
     Attachment #134322|0                           |1
            is obsolete|                            |
    
    --- Comment #65 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134328
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134328&action=edit
    Bug 29346: Refactor loop code into a subroutine
    
    The CreateQueue() method deletes the holds queue data, fetches some
    configuration (branches to use, transport cost matrix) and then loops
    through a list of biblionumbers, generating the tmp_holdsqueue and
    hold_fill_targets rows for the specified biblio.
    
    This patch simply moves that last bit that is run inside the biblios
    loop into a separate sub.
    
    The update_queue_for_biblio sub is designed so it does the exact same
    thing it did inside the loop, but also gets added the capability of
    querying those parameters if not passed, and it also gets a 'delete'
    parameter so it deletes the biblio-specific holds queue rows before
    starting to work.
    
    This way, it can be reused to write a background job for real-time holds
    queue update :-D
    
    To test:
    1. Run:
       $ kshell
      k$ prove t/db_dependent/HoldsQueue.t
    => SUCCESS: Tests pass!
    2. Apply this patch
    3. Repeat 1
    => SUCCESS: Tests still pass! Behavior is kept!
    4. Sign off :-D
    
    Sponsored-by: Montgomery County Public Libraries
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 03:02:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 01:02:41 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-0CBhgkiplF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #66 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134329
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134329&action=edit
    Bug 29346: Add holds queue update background job
    
    This patch adds a background job that takes care of updating the holds
    queue rows for a given list of biblios.
    
    It is designed to be used for real-time batch updating the holds queue
    when required. Tasks would be added by the relevant methods under the
    right use cases.
    
    Sponsored-by: Montgomery County Public Libraries
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 03:02:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 01:02:46 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-YNO79QYF9D@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #67 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134330
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134330&action=edit
    Bug 29346: Hold actions triggers
    
    This patch makes several holds related actions schedule the background
    job for real-time update of the holds queue.
    
    This actions are:
    
    - place (C4::Reserves::AddReserve)
    - fill (Koha::Hold->fill)
    - cancel (Koha::Hold->cancel)
    - suspend (Koha::Hold->suspend)
    - resume (Koha::Hold->resume)
    
    The cancel() action is added a *skip_holds_queue* parameter to skip
    triggering the background job entirely. It targets cases like
    C4::Biblio::DelBiblio in which all biblio holds are cancelled in a loop.
    In that case, we just want to cancel them and let a single backgroung
    job take care of the holds queue, once the biblio is deleted.
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Hold.t \
               t/db_dependent/Reserves.t
    => SUCCESS: Tests pass! Triggers are triggered
    3. Sign off :-D
    
    Sponsored-by: Montgomery County Public Libraries
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 03:02:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 01:02:51 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-WC7yIcM2CV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #68 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134331
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134331&action=edit
    Bug 29346: Circulation actions triggers
    
    This patch introduces triggers for real-time updating the holds queue at
    check out and check in.
    
    The following high-level methods are involved:
    
    - C4::Circulation::AddIssue
    - C4::Circulation::AddReturn
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Circulation_holdsqueue.t
    => SUCCESS: Tests pass! Triggers are triggered
    3. Sign off :-D
    
    Note: I put the tests on a separate file because the other one was too
    big already.
    
    Sponsored-by: Montgomery County Public Libraries
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 03:02:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 01:02:56 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-iMQiPEO4aR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #69 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134332
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134332&action=edit
    Bug 29346: Biblio actions triggers
    
    This patch adds the trigger for the holds queue update on teh following
    methods:
    
    - C4::Biblio::DelBiblio
    - C4::Biblio::ModBiblio
    
    The ModBiblio use case could be improved by checking if itemtype is one
    of the updated attributes... but it felt there was no way to do it
    without some overhead. So I leave it as-is.
    
    It also mocks the ->enqueue method in the tests that call DelBiblio and
    ModBiblio to avoid breakages [1]
    
    Tests are added to check the trigger is called.
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Biblio.t
    => SUCCESS: Tests pass! It means the trigger is triggered :-D
    3. Sign off :-D
    
    [1] This breakages could be avoided if we solve Koha/BackgrounJob.pm:101
    FIXME.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 03:03:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 01:03:01 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-JNPWocwubX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #70 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134333
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134333&action=edit
    Bug 29346: Item action trigger
    
    This patch makes the following actions trigger a holds queue rebuild for
    the related biblio:
    
    - Adding an item
    - Updating an item
    - Deleting an item
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Item.t
    => SUCCESS: Tests pass! Background job scheduled
    3. Sign off :-D
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 03:03:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 01:03:06 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-qoTn6yVZVE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #71 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134334
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134334&action=edit
    Bug 29346: (follow-up) Fix typo
    
    We set biblio_ids in enqueue then referred to biblio_id in process ;)
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 03:03:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 01:03:11 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-TKH77IVMdr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #72 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134335
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134335&action=edit
    Bug 29346: Highlight double enqueue
    
    This patch highlights a possible issue with the triggers.. though it may
    not actually matter in reality.
    
    I appear to already see test failures before this patch with a double
    enqueue of the rebuild for both AddIssue and AddReturn.. I couldn't spot
    what was causing that but whilst digging I did find another case where
    it could happen as highlighted here...
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 03:03:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 01:03:15 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-DClZvXDIVo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #73 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134336
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134336&action=edit
    Bug 29346: Avoid duplicate actions tests
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 03:03:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 01:03:20 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-vyPhzxuzER@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #74 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134337
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134337&action=edit
    Bug 29346: Add more fine-grained control of holds queue updates
    
    This patch deals with the fact that high-level circualtion methods like
    `AddIssue`, `AddReturn` and `ModDateLastSeen` all eventually call
    lower-level methods like ModBiblio, Koha::Item->store of
    UpdateTotalIssues which are expected to trigger holds queue updates (for
    the object CRUD operations use cases). As the circulation methods need
    to trigger holds queue update as well, duplicate updates were being
    requested which is suboptimal, of course.
    
    In order to prevent this, and because circulation methdos could trigger
    holds queue updates several times, actually, I added a new parameter
    *skip_holds_queue* to the low-level methods, so when they are called
    from circulation, the trigger is skipped and we have greater control on
    when and how holds queue updates are scheduled.
    
    This patch introduces the `skip_holds_queue` parameter to the following
    methods:
    
    * C4::Biblio::ModBiblio
    * C4::Biblio::UpdateTotalIssues
    * Koha::Item->store
    
    Calls to those methods from the following methods will include the new
    parameter, and thus duplicated holds queue updates avoided:
    
    * C4::Circulation::AddIssue
    * C4::Circulation::AddReturn
    * C4::Items::ModDateLastSeen
    
    Tests are added, to verify that the (mocked) BatchUpdateBiblioHoldsQueue
    task is only scheduled once when they are called.
    
    To test:
    1. Apply up to the previous patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Biblio.t \
               t/db_dependent/Biblio_holdsqueue.t \
               t/db_dependent/Circulation_holdsqueue.t
    => FAIL: Tests fail!
    3. Apply this patch
    4. Repeat 2
    => SUCCESS: Tests pass!
    5. Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 03:03:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 01:03:25 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-6IsGmnHgW0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #75 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134338
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134338&action=edit
    Bug 29346: (QA follow-up) Rebuild queue when adjusting priorities of holds
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 03:03:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 01:03:30 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-bcHKmAyHAZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #76 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134339
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134339&action=edit
    Bug 29346: (follow-up) Fix typo 'availabe'
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 03:03:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 01:03:35 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-P7DyZr1kin@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #77 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134340
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134340&action=edit
    Bug 29346: Add better reporting
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 03:03:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 01:03:40 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-82ktRgExxB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #78 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134341
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134341&action=edit
    Bug 29346: Remove unused circular dependency on C4::Search
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 03:03:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 01:03:45 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-BKS6UGiiG3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #79 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134342
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134342&action=edit
    Bug 29346: Use fully qualified names for C4:Circulation routines in
    C4::HoldsQueue
    
    I suppose this is similar to circular dependency on other patch
    
    HoldsQueue uses Circulation uses BatchUpdateBiblioHoldsQueueuse HoldsQueue
    
    Without this the background job builds the queue, but reports failure:
    Holds queue for biblio The Jacobite clans of the Great Glen, 1650-1784 /. An
    error occurred (Undefined subroutine &C4::HoldsQueue::GetTransfers called at
    /kohadevbox/koha/C4/HoldsQueue.pm line 351. )
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 03:03:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 01:03:50 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-FbHOlOab7V@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    --- Comment #80 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134343
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134343&action=edit
    Bug 29346: (follow-up) Build holds queue when AlterPriority or
    RevertWaitingStatus is called
    
    To test:
    1 - Place 3 holds on a bib with a single item
    2 - Confirm bib shows in holds queue
    3 - Check in item and cnofirm hold
    4 - Bib is no longer in queue
    5 - Revert the waiting status
    6 - The hold is in the queue again
    7 - Move top hold to bottom
    8 - Confirm queue selects hold for new top priorty patron
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 04:06:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 02:06:46 +0000
    Subject: [Koha-bugs] [Bug 30600] Recalls sync problem between DBIx and
     kohastructure.sql
    In-Reply-To: <bug-30600-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30600-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30600-70-rjkk1XaaRI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30600
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134008|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Created attachment 134344
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134344&action=edit
    Bug 30600: Fix recall reasons for branch transfers
    
    When a recall triggers a branch transfer, the reason for the transfer is
    'Recall'.
    
    When a transfer is cancelled that was triggered by a recall, depending
    on where it is cancelled, will use the 'Manual' or 'CancelRecall'
    cancellation reasons.
    
    This patch ensures branchtransfers.cancellation_reason adds 'CancelRecall',
    and branchtransfers.reason adds 'Recall' as options.
    
    Sponsored-by: Catalyst IT
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 05:01:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 03:01:43 +0000
    Subject: [Koha-bugs] [Bug 30326] Cronjob that checks biblios for MARC errors
    In-Reply-To: <bug-30326-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30326-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30326-70-JjyQCNtJUF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30326
    
    Aleisha Amohia <aleisha at catalyst.net.nz> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 05:01:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 03:01:48 +0000
    Subject: [Koha-bugs] [Bug 30326] Cronjob that checks biblios for MARC errors
    In-Reply-To: <bug-30326-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30326-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30326-70-UZn901SFSx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30326
    
    --- Comment #11 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
    Created attachment 134345
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134345&action=edit
    Bug 30326: (follow-up) Tidy up output and use staffClientBaseURL
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 08:25:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 06:25:48 +0000
    Subject: [Koha-bugs] [Bug 24001] Cannot edit card template
    In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24001-70-Pqra9POREg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
    
    --- Comment #59 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Created attachment 134346
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134346&action=edit
    Bug 24001: (follow-up) Fix t_Profile.t
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 08:28:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 06:28:51 +0000
    Subject: [Koha-bugs] [Bug 24001] Cannot edit card template
    In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24001-70-rtMm770zx8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
    
    --- Comment #60 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Test suite was failing, like :
    https://jenkins.koha-community.org/view/master/job/Koha_Master_D10/624/testReport/
    
    Fixed by changing expected values.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 08:32:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 06:32:45 +0000
    Subject: [Koha-bugs] [Bug 30511] Don't lock entire database when dumping
     Koha instance
    In-Reply-To: <bug-30511-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30511-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30511-70-eSBSeFxi9m@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30511
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|Trivial patch               |Small patch
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 08:32:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 06:32:50 +0000
    Subject: [Koha-bugs] [Bug 30511] Don't lock entire database when dumping
     Koha instance
    In-Reply-To: <bug-30511-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30511-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30511-70-HH0GklfrRX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30511
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133204|0                           |1
            is obsolete|                            |
    
    --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 134347
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134347&action=edit
    Bug 30511: Don't lock up entire database while running koha-dump
    
    Test plan:
    1. Apply the patch
    2. Restart services
    3. Run koha-dump
    4. Confirm the .sql.gz and .tar.gz files are generated successfully
    
    Sponsored-by: Catalyst IT
    
    Signed-off-by: David Cook <dcook at prosentient.com.au>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 08:34:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 06:34:04 +0000
    Subject: [Koha-bugs] [Bug 30511] Don't lock entire database when dumping
     Koha instance
    In-Reply-To: <bug-30511-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30511-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30511-70-KdYZoJZKEc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30511
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |m.de.rooy at rijksmuseum.nl
    
    --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    We could do so since we do no longer have a mix of InnoDB and MyISAM tables.
    This produces a coherent dump for InnoDB tables.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 08:34:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 06:34:24 +0000
    Subject: [Koha-bugs] [Bug 30511] Don't lock entire database when dumping
     Koha instance
    In-Reply-To: <bug-30511-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30511-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30511-70-RG6wWi0yb2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30511
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                       |y.org                       |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 08:35:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 06:35:54 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-2aFRERiE4p@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |BLOCKED
             QA Contact|                            |m.de.rooy at rijksmuseum.nl
                     CC|                            |m.de.rooy at rijksmuseum.nl
    
    --- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    QAing
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 09:18:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 07:18:57 +0000
    Subject: [Koha-bugs] [Bug 30611] Add ability to send passwordreseturl from
     the staff client
    In-Reply-To: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30611-70-gOJnzYn2ng@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Add ability to send         |Add ability to send
                       |passwordreseturl in the     |passwordreseturl from the
                       |Welcome email               |staff client
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 09:19:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 07:19:17 +0000
    Subject: [Koha-bugs] [Bug 30611] Add ability to send passwordreseturl from
     the staff client
    In-Reply-To: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30611-70-tHJ6xM44iW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|9097                        |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097
    [Bug 9097] Add option to trigger 'Welcome mail' manually
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 09:19:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 07:19:17 +0000
    Subject: [Koha-bugs] [Bug 9097] Add option to trigger 'Welcome mail' manually
    In-Reply-To: <bug-9097-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-9097-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-9097-70-D41AVFOG55@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|30611                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611
    [Bug 30611] Add ability to send passwordreseturl from the staff client
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 09:20:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 07:20:40 +0000
    Subject: [Koha-bugs] [Bug 30172] Background jobs failing due to race
     condition
    In-Reply-To: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30172-70-9C4TdTdA7t@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172
    
    Magnus Enger <magnus at libriotech.no> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |magnus at libriotech.no
    
    --- Comment #42 from Magnus Enger <magnus at libriotech.no> ---
    Is there a quick way to "kickstart" those jobs that are stuck at "New" in the
    list of background jobs?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 09:32:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 07:32:00 +0000
    Subject: [Koha-bugs] [Bug 30650] New: Convert the Curbside Pickup plugin to
     Koha core
    Message-ID: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650
    
                Bug ID: 30650
               Summary: Convert the Curbside Pickup plugin to Koha core
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: ASSIGNED
              Severity: new feature
              Priority: P5 - low
             Component: Circulation
              Assignee: jonathan.druart+koha at gmail.com
              Reporter: jonathan.druart+koha at gmail.com
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
    
    The plugin is great and people would like to see it part of Koha.
    
    https://github.com/bywatersolutions/koha-plugin-curbside-pickup
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 09:32:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 07:32:09 +0000
    Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
     core
    In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30650-70-KZfwjEwZ6c@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
      Change sponsored?|---                         |Sponsored
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 09:33:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 07:33:10 +0000
    Subject: [Koha-bugs] [Bug 25698] Curbside Pickup
    In-Reply-To: <bug-25698-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25698-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25698-70-TP7pdBV6h9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25698
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30650
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com
    
    --- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Hi, I have been sponsored to integrate this plugin to Koha core, see bug 30650.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 09:33:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 07:33:10 +0000
    Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
     core
    In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30650-70-zYNC7No5pW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=25698
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 09:33:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 07:33:37 +0000
    Subject: [Koha-bugs] [Bug 30527] Limits are not correctly parsed when query
     contains CCL
    In-Reply-To: <bug-30527-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30527-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30527-70-JeHahexS8e@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30527
    
    Magnus Enger <magnus at libriotech.no> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |DUPLICATE
                 Status|NEW                         |RESOLVED
                     CC|                            |magnus at libriotech.no
    
    --- Comment #1 from Magnus Enger <magnus at libriotech.no> ---
    
    
    *** This bug has been marked as a duplicate of bug 30528 ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 09:33:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 07:33:37 +0000
    Subject: [Koha-bugs] [Bug 30528] Limits are not correctly parsed when query
     contains CCL
    In-Reply-To: <bug-30528-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30528-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30528-70-iwDqiVdMdI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30528
    
    --- Comment #3 from Magnus Enger <magnus at libriotech.no> ---
    *** Bug 30527 has been marked as a duplicate of this bug. ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 09:34:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 07:34:46 +0000
    Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
     core
    In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30650-70-On1cCuC7Co@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650
    
    --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    If you are using the plugin, let me know if you have any questions or
    enhancement requests.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 09:35:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 07:35:30 +0000
    Subject: [Koha-bugs] [Bug 30037] Set default profile when staging MARC
     records on import
    In-Reply-To: <bug-30037-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30037-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30037-70-rJDwmeLOv8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037
    
    --- Comment #9 from Florian <florian.bontemps at biblibre.com> ---
    Oh I fully agree, my proposition was just a first step toward making this form
    more user-friendly.
    
    Owen, do you have exemples of these similar fields? Just to check the proper
    format we've been aiming for.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 09:38:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 07:38:48 +0000
    Subject: [Koha-bugs] [Bug 30528] Limits are not correctly parsed when query
     contains CCL
    In-Reply-To: <bug-30528-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30528-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30528-70-m5X0guEyym@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30528
    
    Magnus Enger <magnus at libriotech.no> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |magnus at libriotech.no
    
    --- Comment #4 from Magnus Enger <magnus at libriotech.no> ---
    I'm seeing this on 21.11.04, when looking at a detail view in the intranet: 
    
    ==> /var/log/koha/hig/plack-error.log <==
    CCL parsing error (10014) Unknown qualifier ZOOM for query:
    Host-item=(Psychology and law =) at /usr/share/koha/lib/C4/Search.pm line 242.
    Warning from simple_search_compat: 'CCL parsing error (10014) Unknown qualifier
    ZOOM' at /usr/share/koha/lib/Koha/Biblio.pm line 540.
    
    In the staff client, this message is displayed above the title of the record:
    
    "There was an error searching for analytic records, please see the logs for
    details."
    
    Not sure if this is related.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 09:42:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 07:42:29 +0000
    Subject: [Koha-bugs] [Bug 30536] Embeds should be defined in a single place
    In-Reply-To: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30536-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30536-70-T8uBNubfOE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|BLOCKED                     |Failed QA
    
    --- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    QA Comment:
    
    [1] I would recommend to add a little bit more text on this POD:
     =head3 stash_embed
    
    -    $c->stash_embed(
    $c->match->endpoint->pattern->defaults->{'openapi.op_spec'} );
    +    $c->stash_embed( );
    
     =cut
    
    [2] api/v1/swagger/paths/acquisitions_baskets.yaml
    Here you do not specify collectionFormat: csv while you do at
    acquisitions_funds.yaml.
    And again you dont in suggestions.yaml.
    Note that as I understand that it is the default array format, we should not
    need them. But this looks inconsistent.
    
    [3] Please fix t/Koha/REST/Plugin/Query.t
    It fails now.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 09:43:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 07:43:53 +0000
    Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
     core
    In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30650-70-rQbgSuILMo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650
    
    Hugo Agud <hagud at orex.es> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |hagud at orex.es
    
    --- Comment #2 from Hugo Agud <hagud at orex.es> ---
    Great idea!!!
    
    suggestions:
    
    a) Some libraries has not continues attention, for example in lunch time has
    not desktop service? now you can set up opening and closing time, good idea add
    the change for adding closes period
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 09:45:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 07:45:11 +0000
    Subject: [Koha-bugs] [Bug 29537] Simplify auto-renewal code in
     CanBookBeRenewed
    In-Reply-To: <bug-29537-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29537-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29537-70-XCfd0IO6UT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |BLOCKED
                     CC|                            |m.de.rooy at rijksmuseum.nl
    
    --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    QAing
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 09:45:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 07:45:33 +0000
    Subject: [Koha-bugs] [Bug 29537] Simplify auto-renewal code in
     CanBookBeRenewed
    In-Reply-To: <bug-29537-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29537-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29537-70-ekqKdNEob5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                       |y.org                       |
               Assignee|joonas.kylmala at iki.fi       |nick at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 10:15:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 08:15:08 +0000
    Subject: [Koha-bugs] [Bug 30279] Log when personal data is displayed in
     staff client
    In-Reply-To: <bug-30279-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30279-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30279-70-3mNzOnvVmx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30279
    
    Magnus Enger <magnus at libriotech.no> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |magnus at libriotech.no
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 10:32:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 08:32:36 +0000
    Subject: [Koha-bugs] [Bug 29537] Simplify auto-renewal code in
     CanBookBeRenewed
    In-Reply-To: <bug-29537-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29537-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29537-70-n97wQ78pvq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|BLOCKED                     |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 10:32:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 08:32:41 +0000
    Subject: [Koha-bugs] [Bug 29537] Simplify auto-renewal code in
     CanBookBeRenewed
    In-Reply-To: <bug-29537-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29537-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29537-70-hxVxtvW5pk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133505|0                           |1
            is obsolete|                            |
    
    --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 134348
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134348&action=edit
    Bug 29537: Remove unnecessary if-else checks for soonest renew date
    
    GetSoonestRenewDate() calculates the renewal due date now also
    correctly for auto-renewals after the fixes from bug 29476 so we don't
    have to add any if-else checks because of it being buggy anymore.
    
    To test:
     1) prove t/db_dependent/Circulation.t
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 10:33:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 08:33:49 +0000
    Subject: [Koha-bugs] [Bug 29537] Simplify auto-renewal code in
     CanBookBeRenewed
    In-Reply-To: <bug-29537-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29537-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29537-70-GMwIo6FvJy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537
    
    --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Subtest: GetSoonestRenewDate tests passes, altough currently the whole
    Circulation.t fails (also without this patch)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 10:34:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 08:34:04 +0000
    Subject: [Koha-bugs] [Bug 29537] Simplify auto-renewal code in
     CanBookBeRenewed
    In-Reply-To: <bug-29537-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29537-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29537-70-W5w3LVChSb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Severity|trivial                     |normal
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 10:44:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 08:44:48 +0000
    Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
     core
    In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30650-70-ozTnxJ8pJo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650
    
    Nicolas Legrand <nicolas.legrand at bulac.fr> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |nicolas.legrand at bulac.fr,
                       |                            |severine.queune at bulac.fr
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 10:53:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 08:53:21 +0000
    Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
     core
    In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30650-70-pn7VAsHgqW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650
    
    Michal Denar <black23 at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |black23 at gmail.com
    
    --- Comment #3 from Michal Denar <black23 at gmail.com> ---
    Great idea,
    bBut there are some bugs or suggestions for extensions that would be great to
    incorporate into the final functionality. Like
    https://github.com/bywatersolutions/koha-plugin-curbside-pickup/issues/27.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 10:53:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 08:53:23 +0000
    Subject: [Koha-bugs] [Bug 21903] koha-dump be able to include koha-upload
    In-Reply-To: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21903-70-LXeamffA9R@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21903
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |m.de.rooy at rijksmuseum.nl
    
    --- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Katrin Fischer from comment #20)
    > 1) POD (not blocker)
    > 
    > +    --uploaded_files      Include uploaded files.
    > +    --uploaded_temp_files Include temporary uploaded files.
    > 
    > Does this mean that --uploaded_files includes or excludes the temporary
    > uploaded files?
    > 
    > Taking a closer look it looks like temporary and other uploaded files go to
    > different directories, so the first would be excluding temporary files. Just
    > wondering if someone setting this up would be aware - might still be worth
    > adding a little note. 
    
    I think that it is clear enough. If you dont know what they are, you wont be
    specifying these options for koha-dump either.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 10:54:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 08:54:21 +0000
    Subject: [Koha-bugs] [Bug 21903] koha-dump be able to include koha-upload
    In-Reply-To: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21903-70-w8Gu3sjVMg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21903
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 10:54:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 08:54:26 +0000
    Subject: [Koha-bugs] [Bug 21903] koha-dump be able to include koha-upload
    In-Reply-To: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21903-70-ee0OG9vR8e@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21903
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #126835|0                           |1
            is obsolete|                            |
    
    --- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 134349
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134349&action=edit
    Bug 21903: koha-dump can export uploaded and temporary uploaded files
    
    Sponsored-by: Orex
    
    Test plan:
     - Apply the patch
     - Try using koha-dump without any option
     - Try using koha-dump with --uploaded_files
     - Try using koha-dump with --uploaded_temp_files
     - Try using koha-dump with both of the options above
    
    Expected results: the .tar.gz dump will include uploaded and/or temporary
    uploaded files if requested.
    
    Signed-off-by: Hugo Agud <hagud at orex.es>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 10:54:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 08:54:31 +0000
    Subject: [Koha-bugs] [Bug 21903] koha-dump be able to include koha-upload
    In-Reply-To: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21903-70-Ggj1HUfpyN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21903
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #126908|0                           |1
            is obsolete|                            |
    
    --- Comment #24 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 134350
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134350&action=edit
    Bug 21903: (follow-up) koha-dump can export uploaded and temporary uploaded
    files
    
    Minor improvment on display.
    Solve the error message if the folder for uploaded temp files
    doesn't exist.
    
    Sponsored-by: Orex
    
    Test plan:
    - Apply the patch
    - Try using koha-dump without any option
    - Try using koha-dump with --uploaded_files
    - Try using koha-dump with --uploaded_temp_files
    - Try using koha-dump with both of the options above
    
    Expected results: the .tar.gz dump will include uploaded and/or temporary
    uploaded files if requested.
    Change message and solve the error message if no temporary folder
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 10:54:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 08:54:36 +0000
    Subject: [Koha-bugs] [Bug 21903] koha-dump be able to include koha-upload
    In-Reply-To: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21903-70-4KOb7Q3Rnv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21903
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #128732|0                           |1
            is obsolete|                            |
    
    --- Comment #25 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 134351
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134351&action=edit
    Bug 21903: (follow-up) update documentation
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 10:54:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 08:54:51 +0000
    Subject: [Koha-bugs] [Bug 21903] koha-dump be able to include koha-upload
    In-Reply-To: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21903-70-uqHRr9rxdd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21903
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|tomascohen at gmail.com        |m.de.rooy at rijksmuseum.nl
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 10:58:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 08:58:26 +0000
    Subject: [Koha-bugs] [Bug 30143] OAI-PMH provider may end up in an eternal
     loop due to missing sort
    In-Reply-To: <bug-30143-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30143-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30143-70-ii3P43TBfy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30143
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 10:58:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 08:58:30 +0000
    Subject: [Koha-bugs] [Bug 30143] OAI-PMH provider may end up in an eternal
     loop due to missing sort
    In-Reply-To: <bug-30143-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30143-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30143-70-j60qnP884o@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30143
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133703|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 134352
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134352&action=edit
    Bug 30143: OAI-PMH: Fix SQL query used to fetch deleted records
    
    The query was missing the "ORDER BY" and "LIMIT" clauses, which could make
    retrieve a wrong set of records.
    
    Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 10:58:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 08:58:40 +0000
    Subject: [Koha-bugs] [Bug 30143] OAI-PMH provider may end up in an eternal
     loop due to missing sort
    In-Reply-To: <bug-30143-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30143-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30143-70-9OswUyS0ZS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30143
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |m.de.rooy at rijksmuseum.nl
             QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                       |y.org                       |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 10:58:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 08:58:53 +0000
    Subject: [Koha-bugs] [Bug 30326] Cronjob that checks biblios for MARC errors
    In-Reply-To: <bug-30326-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30326-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30326-70-2ufKkh1o1E@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30326
    
    --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    I'll be happy to treat the changes as a QA follow-up (no new sign-off
    required), but could you update POD for the changed intranet option behaviour?
    Thx!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 11:00:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 09:00:37 +0000
    Subject: [Koha-bugs] [Bug 28111] Add file grouping and granular permissions
     to the 'Access files' tool
    In-Reply-To: <bug-28111-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28111-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28111-70-r37VnQDZvw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28111
    
    Magnus Enger <magnus at libriotech.no> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |magnus at libriotech.no
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 11:02:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 09:02:04 +0000
    Subject: [Koha-bugs] [Bug 28111] Add file grouping and granular permissions
     to the 'Access files' tool
    In-Reply-To: <bug-28111-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28111-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28111-70-uVDrKHj1ro@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28111
    
    Magnus Enger <magnus at libriotech.no> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=24074
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 11:02:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 09:02:04 +0000
    Subject: [Koha-bugs] [Bug 24074] Access directory UX improvements
    In-Reply-To: <bug-24074-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-24074-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-24074-70-DbzAvj4wVS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24074
    
    Magnus Enger <magnus at libriotech.no> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=28111
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 11:20:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 09:20:49 +0000
    Subject: [Koha-bugs] [Bug 10517] koha-restore fails to create
     mysqluser@mysql_hostname so zebra update fails
    In-Reply-To: <bug-10517-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-10517-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-10517-70-iHsMq40h7I@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 11:20:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 09:20:53 +0000
    Subject: [Koha-bugs] [Bug 10517] koha-restore fails to create
     mysqluser@mysql_hostname so zebra update fails
    In-Reply-To: <bug-10517-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-10517-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-10517-70-OIq4SS8rja@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133758|0                           |1
            is obsolete|                            |
    
    --- Comment #44 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 134353
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134353&action=edit
    Bug 10517: Use `DROP USER IF EXISTS` and remove ` || true`.
    
    When restoring a Koha instance, and the database user does not exist, an error
    is shown,
    although it is prevented from stopping the script by ` || true`. This patch
    removes the
    ` || true` guard, and rather uses `DROP USER IF EXISTS` which does exactly what
    one
    would expect, without confusing error messages, whether the user existed or
    not.
    
    To test:
    1) Assume your Koha instance is called `asdf`.
    1) Export the Koha instance using `koha-dump`.
    2) Remove the instance completely using `koha-remove`.
    3) Import it again using `koha-restore`.
    4) No error should be shown, and the import should work. There was NO user to
    drop, therefore `DROP USER IF EXISTS` did nothing.
    5) A database user called `koha_asdf` should exist, and have all privileges on
    the database of the same name.
    6) Remove the instance again using `koha-remove`.
    7) Now create a database user in MySQL called `koha_instance` where instance is
    the name of your dumped koha instance.
    8) Import your koha instance again using `koha-restore`.
    9) Again, no error should be shown, and the import should work. There WAS a
    user to drop, therefore `DROP USER IF EXISTS` dropped the user before creating
    a new one.
    10) Again, a database user called `koha_asdf` should exist, and have all
    privileges on the database of the same name.
    
    Sponsored-by: Reformational Study Centre
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 11:20:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 09:20:58 +0000
    Subject: [Koha-bugs] [Bug 10517] koha-restore fails to create
     mysqluser@mysql_hostname so zebra update fails
    In-Reply-To: <bug-10517-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-10517-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-10517-70-1CPBLSPZ7n@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517
    
    --- Comment #45 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 134354
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134354&action=edit
    Bug 10517: (QA follow-up) No need to remove second true
    
    This is just theoretical, but by removing the second true you
    could end the script on another error.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 11:21:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 09:21:36 +0000
    Subject: [Koha-bugs] [Bug 10517] koha-restore fails to create
     mysqluser@mysql_hostname so zebra update fails
    In-Reply-To: <bug-10517-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-10517-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-10517-70-6lANB7Z8IH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
              Component|Packaging                   |Command-line Utilities
                     CC|                            |m.de.rooy at rijksmuseum.nl
             QA Contact|                            |m.de.rooy at rijksmuseum.nl
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 11:46:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 09:46:29 +0000
    Subject: [Koha-bugs] [Bug 30167] Return soonest renewal date when
     CanBookBeRenewed returns %too_soon
    In-Reply-To: <bug-30167-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30167-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30167-70-Y4gMgIAhnC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30167
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |m.de.rooy at rijksmuseum.nl
    
    --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    +  ($ok,$error,$info) = &CanBookBeRenewed($borrowernumber, $itemnumber[,
    $override_limit]);
    
     Find out whether a borrowed item may be renewed.
    
    +    $info will contain the soonest renewal date if the error is 'too soon'
    
    I would suggest to let $info either be a hash containing a key for soonest
    renewal date (among others, room for extension) in order to honor its name or
    rename it to soonestrenewaldate. This is somewhat obsure.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 11:51:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 09:51:09 +0000
    Subject: [Koha-bugs] [Bug 30632] Fix report author display in list of saved
     reports
    In-Reply-To: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30632-70-XFNkPPBicb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 11:51:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 09:51:15 +0000
    Subject: [Koha-bugs] [Bug 30632] Fix report author display in list of saved
     reports
    In-Reply-To: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30632-70-nVS6Wd0kJC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134303|0                           |1
            is obsolete|                            |
    
    --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    Created attachment 134355
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134355&action=edit
    Bug 30632: Fix report author display in list of saved reports
    
    This patch removes whitespace in the template around the markup of
    report author first name and surname. This prevents unwanted spaces in
    the output.
    
    To test, apply the patch and go to Reports -> Use saved.
    
    The display of report author should be like this:
    
    Leonard, Owen (123456)
    
    Instead of Leonard , Owen (20375)
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 11:51:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 09:51:31 +0000
    Subject: [Koha-bugs] [Bug 30632] Fix report author display in list of saved
     reports
    In-Reply-To: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30632-70-8gEzjeJdoY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                       |y.org                       |
                     CC|                            |m.de.rooy at rijksmuseum.nl
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 11:57:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 09:57:39 +0000
    Subject: [Koha-bugs] [Bug 30553] Add a count to the Files tab in the patron
     account
    In-Reply-To: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30553-70-BQqQfGNmtp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30553
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Hmm, my initial thought here is what are we grabbing so much data for just a
    count?
    
    I see Koha::Patron::Files isn't a modern Koha::Object based class, more of a
    half way between C4 module and an object.. so it's not as simple as it
    initially looks.
    
    However, maybe it's worth going half way and introducing a 'GetFileCount'
    method in the underlying Koha::Patron::Files class which does the simpler
    'SELECT COUNT(*) FROM borrower_files WHERE borrowernumber = ?' instead?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 12:39:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 10:39:01 +0000
    Subject: [Koha-bugs] [Bug 30553] Add a count to the Files tab in the patron
     account
    In-Reply-To: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30553-70-mBMHMJ7BcI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30553
    
    --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Hm, but no SQL in Koha namespace, I think. The DBIX equivalent?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 12:57:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 10:57:22 +0000
    Subject: [Koha-bugs] [Bug 30600] Recalls sync problem between DBIx and
     kohastructure.sql
    In-Reply-To: <bug-30600-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30600-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30600-70-aSkJ0ByYuK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30600
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 12:57:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 10:57:26 +0000
    Subject: [Koha-bugs] [Bug 30600] Recalls sync problem between DBIx and
     kohastructure.sql
    In-Reply-To: <bug-30600-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30600-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30600-70-8XJRPW88XZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30600
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134344|0                           |1
            is obsolete|                            |
    
    --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Created attachment 134356
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134356&action=edit
    Bug 30600: Fix recall reasons for branch transfers
    
    When a recall triggers a branch transfer, the reason for the transfer is
    'Recall'.
    
    When a transfer is cancelled that was triggered by a recall, depending
    on where it is cancelled, will use the 'Manual' or 'CancelRecall'
    cancellation reasons.
    
    This patch ensures branchtransfers.cancellation_reason adds 'CancelRecall',
    and branchtransfers.reason adds 'Recall' as options.
    
    Sponsored-by: Catalyst IT
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 12:58:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 10:58:42 +0000
    Subject: [Koha-bugs] [Bug 30553] Add a count to the Files tab in the patron
     account
    In-Reply-To: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30553-70-X4x0Rq8YSX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30553
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Failed QA
    
    --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    FQA = Feedback for QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:00:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:00:47 +0000
    Subject: [Koha-bugs] [Bug 30167] Return soonest renewal date when
     CanBookBeRenewed returns %too_soon
    In-Reply-To: <bug-30167-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30167-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30167-70-BGDaLv0A0t@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30167
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Failed QA
    
    --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    Changing status to get some feedback on Marcel's last comment.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:02:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:02:57 +0000
    Subject: [Koha-bugs] [Bug 30632] Fix report author display in list of saved
     reports
    In-Reply-To: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30632-70-AGapMe88zI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|30491                       |
    
    --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    I am ok with the simple fix. I am filing a new one to "switch" to the include.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30491
    [Bug 30491] Convert saved reports tabs to Bootstrap
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:02:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:02:57 +0000
    Subject: [Koha-bugs] [Bug 30491] Convert saved reports tabs to Bootstrap
    In-Reply-To: <bug-30491-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30491-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30491-70-pL1sDFMIMa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30491
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|30632                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632
    [Bug 30632] Fix report author display in list of saved reports
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:04:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:04:42 +0000
    Subject: [Koha-bugs] [Bug 30632] Fix report author display in list of saved
     reports
    In-Reply-To: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30632-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30632-70-1RseyUgFKH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30491
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30491
    [Bug 30491] Convert saved reports tabs to Bootstrap
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:04:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:04:42 +0000
    Subject: [Koha-bugs] [Bug 30491] Convert saved reports tabs to Bootstrap
    In-Reply-To: <bug-30491-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30491-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30491-70-1x3a9vSVGA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30491
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30632
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632
    [Bug 30632] Fix report author display in list of saved reports
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:11:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:11:15 +0000
    Subject: [Koha-bugs] [Bug 30651] New: Switch report author in saved sql list
     to include
    Message-ID: <bug-30651-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30651
    
                Bug ID: 30651
               Summary: Switch report author in saved sql list to include
     Change sponsored?: ---
               Product: Koha
               Version: unspecified
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Templates
              Assignee: oleonard at myacpl.org
              Reporter: katrin.fischer at bsz-bw.de
            QA Contact: testopia at bugs.koha-community.org
    
    In order to have a more unified display of patron names, we should use includes
    to generate the displayed names everywhere. 
    
    One place we should do that is the report author name in the list of saved SQL
    reports.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:11:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:11:36 +0000
    Subject: [Koha-bugs] [Bug 30651] Switch report author in saved sql list to
     include
    In-Reply-To: <bug-30651-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30651-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30651-70-4peQPJwwEa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30651
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30617
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30617
    [Bug 30617] [OMNIBUS] We should consistently use includes for patron name
    display
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:11:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:11:36 +0000
    Subject: [Koha-bugs] [Bug 30617] [OMNIBUS] We should consistently use
     includes for patron name display
    In-Reply-To: <bug-30617-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30617-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30617-70-8dug4ux1dX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30617
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |30651
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30651
    [Bug 30651] Switch report author in saved sql list to include
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:11:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:11:47 +0000
    Subject: [Koha-bugs] [Bug 30651] Switch report author in saved SQL reports
     list to include
    In-Reply-To: <bug-30651-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30651-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30651-70-8qjHcYp0e1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30651
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Switch report author in     |Switch report author in
                       |saved sql list to include   |saved SQL reports list to
                       |                            |include
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:19:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:19:14 +0000
    Subject: [Koha-bugs] [Bug 30611] Add ability to send passwordreseturl from
     the staff client
    In-Reply-To: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30611-70-ArHrjOfxnB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611
    
    --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134357
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134357&action=edit
    Bug 30611: Add STAFF_PASSWORD_RESET notice
    
    This patch adds a new STAFF_PASSWORD_RESET notice template for password
    recoveries initiated via the staff client as aposed for those initiated
    by the end user.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:19:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:19:18 +0000
    Subject: [Koha-bugs] [Bug 30611] Add ability to send passwordreseturl from
     the staff client
    In-Reply-To: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30611-70-9effWDugrL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611
    
    --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134358
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134358&action=edit
    Bug 30611: Add ability for staff to send password reset emails
    
    This patch adds the ability for staff with the edit_borrowers permission
    to send password reset emails to users.
    
    The staff initiated password reset has it's own notice,
    STAFF_PASSWORD_RESET, and the reset link produced has an extended
    timeout of 5 days, as apposed to the usual 2 day limit.
    
    Test plan
    1) Apply patch and run the database update
    2) Login to the staff client with a user who has the 'edit_borrowers'
       permission.
    3) Note that a new, 'Send password reset' option appears under the
       'More' menu on the patron details page.
    4) Clicking the button will queue the STAFF_PASSWORD_RESET notice and
       redirect the user to the Notices tab.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:21:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:21:00 +0000
    Subject: [Koha-bugs] [Bug 30611] Add ability to send passwordreseturl from
     the staff client
    In-Reply-To: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30611-70-gGnqPQLjJI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:22:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:22:52 +0000
    Subject: [Koha-bugs] [Bug 30611] Add ability to send passwordreseturl from
     the staff client
    In-Reply-To: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30611-70-07vhNK62Ql@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=27812
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:22:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:22:52 +0000
    Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's
     plain text password over email
    In-Reply-To: <bug-27812-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27812-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27812-70-1hcYvvoKPw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30611
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:23:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:23:08 +0000
    Subject: [Koha-bugs] [Bug 30611] Add ability to send passwordreseturl from
     the staff client
    In-Reply-To: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30611-70-IozXEn6i7K@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=29925
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:23:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:23:08 +0000
    Subject: [Koha-bugs] [Bug 29925] Add a 'set new password' page for patron's
     with expired passwords
    In-Reply-To: <bug-29925-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29925-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29925-70-s6Ca0mw8P1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29925
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30611
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:23:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:23:16 +0000
    Subject: [Koha-bugs] [Bug 30611] Add ability to send passwordreseturl from
     the staff client
    In-Reply-To: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30611-70-cM0iYXx4EL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=9097
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:23:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:23:16 +0000
    Subject: [Koha-bugs] [Bug 9097] Add option to trigger 'Welcome mail' manually
    In-Reply-To: <bug-9097-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-9097-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-9097-70-xWDq1o2MkA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30611
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:27:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:27:21 +0000
    Subject: [Koha-bugs] [Bug 30611] Add ability to send passwordreseturl from
     the staff client
    In-Reply-To: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30611-70-vp7ZB9ioK8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611
    
    --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    I think this should perhaps target 22.05 as it adds back in an alternative to
    the functionality lost with bug 27812.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:32:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:32:25 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-Qw7d16YbWb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
                     CC|                            |tomascohen at gmail.com
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:32:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:32:29 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-fa2FpNJANf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132384|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:32:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:32:32 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-N3URSl1hmF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132385|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:32:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:32:35 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-3eNdO4MEx0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132386|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:32:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:32:38 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-9cHg69SyYw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132379|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:32:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:32:41 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-TZNu0v4dN7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132380|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:32:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:32:44 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-9DL3doIMVP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132381|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:32:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:32:47 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-E7CAcjhXp3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132382|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:32:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:32:49 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-9UYHCQeCia@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132383|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:33:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:33:16 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-S2u830tXwh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    --- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134359
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134359&action=edit
    Bug 30291: Database changes to recalls table
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:33:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:33:22 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-LHCmFf028c@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    --- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134360
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134360&action=edit
    Bug 30291: Update boolean flags in Recall schema file
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:33:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:33:27 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-MNZEzmyyPI@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    --- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134361
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134361&action=edit
    Bug 30291: Changes to tests
    
    t/db_dependent/Circulation.t
    t/db_dependent/Circulation/CalcFine.t
    t/db_dependent/Circulation/transferbook.t
    t/db_dependent/Holds.t
    t/db_dependent/Koha/Biblio.t
    t/db_dependent/Koha/Item.t
    t/db_dependent/Koha/Patron.t
    t/db_dependent/Koha/Recall.t
    t/db_dependent/Koha/Recalls.t
    t/db_dependent/XSLT.t
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:33:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:33:33 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-6Uwq21qVdd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    --- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134362
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134362&action=edit
    Bug 30291: Changes to controller scripts
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:33:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:33:40 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-y7kOBXNaBa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    --- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134363
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134363&action=edit
    Bug 30291: Changes to staff client files
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:33:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:33:45 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-uAs5qBiU1w@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    --- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134364
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134364&action=edit
    Bug 30291: Changes to OPAC files
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:33:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:33:50 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-geUeLesUTo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    --- Comment #18 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134365
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134365&action=edit
    Bug 30291: Fix permissions
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:33:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:33:55 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-Z3KtsMddBR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    --- Comment #19 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134366
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134366&action=edit
    Bug 30291: (QA follow-up) Keep recall_id column name
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:34:01 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:34:01 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-u23C2Tk6FB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    --- Comment #20 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134367
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134367&action=edit
    Bug 30291: Updated schema files [DO NOT PUSH]
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:37:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:37:10 +0000
    Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through stage
     MARC record import
    In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22785-70-9NVfZA8ncW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134127|0                           |1
            is obsolete|                            |
    
    --- Comment #85 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134368
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134368&action=edit
    Bug 22785: Allow option to choose which record match is applied during import
    
    This patchset adds the display of all matches found during import to the import
    management screen
    
    A staff member with the permission to manage batches will be able to select for
    any individual record which match, or none, should be used during import
    
    To test:
    1 - Import a batch of records or export existing records from your catalog
    2 - Import the file (again) and select a matching rule that will find matches
    3 - Note that you now have radio buttons allowing you to select a record, or
    none
    4 - Test scenarios:
        I - When 'Action if matching record found' is 'Ignore'
            a - Imported record ignored if match is selected
            b - 'Action if no match found' followed if no match is selected (Ignore
    matches)
        II - When 'Action if matching record found' is 'Replace'
            a - The chosen record is the one overlayed (you can edit the chosen
    record before importing to confirm)
            b - 'Action if no match found' followed if no match is selected (Ignore
    matches)
        III - When 'Action if matching record found' is 'Add incoming record'
            a - Record is added regardless of matches
    5 - Confirm 'Diff' 'View' links work as expected
    6 - Confirm that after records are imported the radio buttons to choose are
    disabled
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    Bug 22785: API files
    
    Signed-off-by: Ben Daeuber <bdaeuber at cityoffargo.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:37:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:37:16 +0000
    Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through stage
     MARC record import
    In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22785-70-C5RSMYw3un@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134128|0                           |1
            is obsolete|                            |
    
    --- Comment #86 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134369
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134369&action=edit
    Bug 22785: DO NOT PUSH Schema Updates
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:37:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:37:22 +0000
    Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through stage
     MARC record import
    In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22785-70-i0eBl6PXfu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134129|0                           |1
            is obsolete|                            |
    
    --- Comment #87 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134370
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134370&action=edit
    Bug 22785: Update Schema for boolean
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Ben Daeuber <bdaeuber at cityoffargo.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:37:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:37:28 +0000
    Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through stage
     MARC record import
    In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22785-70-3EZPUEQBvJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134130|0                           |1
            is obsolete|                            |
    
    --- Comment #88 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134371
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134371&action=edit
    Bug 22785: (follow-up) Don't sort by chosen and fix selection of matches
    
    Previously the sorting took 'chosen' into account and would move a selected
    match to the
    top on next load - it is better to preserve the same sorting every time
    
    When loading matches the 'cehcked' variable was not being cleared, so multiple
    matches were
    being marked 'checked="checked"'. Fixing this ensures the correct record
    displays as chosen
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Ben Daeuber <bdaeuber at cityoffargo.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:37:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:37:33 +0000
    Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through stage
     MARC record import
    In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22785-70-itu8KLX0tw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134131|0                           |1
            is obsolete|                            |
    
    --- Comment #89 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134372
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134372&action=edit
    Bug 22785: (follow-up) Fix translatability
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:37:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:37:39 +0000
    Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through stage
     MARC record import
    In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22785-70-3uNfLJDyJp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134132|0                           |1
            is obsolete|                            |
    
    --- Comment #90 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134373
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134373&action=edit
    Bug 22785: (QA follow-up) Remove superflous spec files
    
    We don't need these any more.. I think they crept back in during
    rebases
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:37:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:37:45 +0000
    Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through stage
     MARC record import
    In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22785-70-kmZd7C8f4m@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134219|0                           |1
            is obsolete|                            |
    
    --- Comment #91 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134374
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134374&action=edit
    Bug 22785: (follow-up) Update contentType in request
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:48:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:48:05 +0000
    Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search
     creates UX inconsistency
    In-Reply-To: <bug-26247-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26247-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26247-70-TSiooyLT7L@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247
    
    Mark Alexander <marka at pobox.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |marka at pobox.com
    
    --- Comment #25 from Mark Alexander <marka at pobox.com> ---
    (In reply to Fridolin Somers from comment #24)
    > As a quickfix, I propose this JavaScript that sets empty when entering the
    > input :
    > 
    > $(document).ready(function() {
    >   $("#header_search #catalog_search input[name='q']").focusin(function() {
    >     $(this).val("");
    >   });
    > });
    
    I've tried adding this to IntranetUserJS but the search term is not erased. 
    This is in Koha 20.05.18.  I've tried both Brave Browser and Firefox.  The
    Firefox inspector shows that the code for the event is attached to the entry
    field, but for some reason the code doesn't seem to be running.
    
    My librarian is pretty upset about this problem.  It interferes with our
    workflow for checking the status of a stack of books.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:52:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:52:57 +0000
    Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through stage
     MARC record import
    In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22785-70-cUWF9z222d@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    --- Comment #92 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    All working now :)  PQA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:55:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:55:30 +0000
    Subject: [Koha-bugs] [Bug 30652] New: RPC style action endpoint for choosing
     matches
    Message-ID: <bug-30652-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30652
    
                Bug ID: 30652
               Summary: RPC style action endpoint for choosing matches
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: REST API
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: martin.renvoize at ptfs-europe.com
                    CC: tomascohen at gmail.com
            Depends on: 22785
    
    In bug 22785 we added endpoint for selecting which match of a record is used at
    import.
    
    I wasn't sure about the API structure as it didn't feel RESTful.. you are
    changing the state of more than the single resource you are pointing to.
    
    I propose the following as an alternative.
    
    POST
    /import/{import_batch_id}/records/{import_record_id}/matches/{record_match_id}/choose
    POST 
    /import/{import_batch_id}/records/{import_record_id}/matches/{record_match_id}/unchoose
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    [Bug 22785] Manage matches when importing through stage MARC record import
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 13:55:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 11:55:30 +0000
    Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through stage
     MARC record import
    In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22785-70-F3GMaZRzbe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30652
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30652
    [Bug 30652] RPC style action endpoint for choosing matches
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 14:04:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 12:04:31 +0000
    Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search
     creates UX inconsistency
    In-Reply-To: <bug-26247-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26247-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26247-70-kcbkuNlCeP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247
    
    --- Comment #26 from Mark Alexander <marka at pobox.com> ---
    Adding to above comment: I found that if I use the tab key to move focus away
    from the search box, then move the focus back to the search box by clicking in
    it, the entry is cleared.  So the "focusin" event code is running, but not at
    the right time.  I'm not familiar with jquery so any help with fixing this
    would be greatly appreciated.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 14:05:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 12:05:13 +0000
    Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
     home library or library group
    In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20256-70-34ofKt1ze0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
    
    --- Comment #345 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Created attachment 134375
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134375&action=edit
    Bug 20256: (QA follow-up) hide Edit chooice in Actions on items editor if item
    cannot be edited
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 14:05:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 12:05:45 +0000
    Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
     home library or library group
    In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20256-70-CDeGyHIJM3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
    
    --- Comment #346 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Created attachment 134376
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134376&action=edit
    Bug 20256: (QA follow-up) Allow removal of course reserves for items that
    cannot be edited
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 14:05:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 12:05:53 +0000
    Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
     home library or library group
    In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20256-70-yvPc32qKWM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
    
    --- Comment #347 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Created attachment 134377
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134377&action=edit
    Bug 20256: (QA follow-up) Fix explosion for items batch edit
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 14:26:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 12:26:08 +0000
    Subject: [Koha-bugs] [Bug 30611] Add ability to send passwordreseturl from
     the staff client
    In-Reply-To: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30611-70-7QerPg7qrK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611
    
    sandboxes at biblibre.com <sandboxes at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134357|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
    Created attachment 134378
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134378&action=edit
    Bug 30611: Add STAFF_PASSWORD_RESET notice
    
    This patch adds a new STAFF_PASSWORD_RESET notice template for password
    recoveries initiated via the staff client as aposed for those initiated
    by the end user.
    
    Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 14:26:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 12:26:12 +0000
    Subject: [Koha-bugs] [Bug 30611] Add ability to send passwordreseturl from
     the staff client
    In-Reply-To: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30611-70-RbWFl29upd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611
    
    sandboxes at biblibre.com <sandboxes at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134358|0                           |1
            is obsolete|                            |
    
    --- Comment #7 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
    Created attachment 134379
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134379&action=edit
    Bug 30611: Add ability for staff to send password reset emails
    
    This patch adds the ability for staff with the edit_borrowers permission
    to send password reset emails to users.
    
    The staff initiated password reset has it's own notice,
    STAFF_PASSWORD_RESET, and the reset link produced has an extended
    timeout of 5 days, as apposed to the usual 2 day limit.
    
    Test plan
    1) Apply patch and run the database update
    2) Login to the staff client with a user who has the 'edit_borrowers'
       permission.
    3) Note that a new, 'Send password reset' option appears under the
       'More' menu on the patron details page.
    4) Clicking the button will queue the STAFF_PASSWORD_RESET notice and
       redirect the user to the Notices tab.
    
    Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 14:29:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 12:29:04 +0000
    Subject: [Koha-bugs] [Bug 30611] Add ability to send passwordreseturl from
     the staff client
    In-Reply-To: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30611-70-bLmoX19y3b@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611
    
    Sally <sally.healey at cheshiresharedservices.gov.uk> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    --- Comment #8 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
    Works brilliantly, thanks Martin.  This is a great feature - saves me from
    having to load the OPAC repeatedly throughout the day.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 14:31:14 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 12:31:14 +0000
    Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
     home library or library group
    In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20256-70-FXg7JSKzqE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Signed Off
    
    --- Comment #348 from Kyle M Hall <kyle at bywatersolutions.com> ---
    > Summary:
    > ==> The new edit_any_items overwrites the Indybranches pref. In consequence
    > it appears it no longer has any effect. Correct?
    
    IndependentBranches is built into this feature. If IndependentBranches is
    enabled, only a superlibrarian can edit all items, and non-superlibrarians can
    only edit items from his or her home library.
    
    > 3) NOT OK - item edit page
    >    The Edit link in the Actions menu always shows, but redirects to detail
    > page, if no permission.
    >    It shoudl only show if editing is possible. (blocker)
    
    Fixed!
    
    > 5) NOT OK - Course reserves
    >    a) Use a barcode to add a reserve to a course from another branch, don't
    > change home branch
    > 
    >    The edit link is removed, but something with the table structure is
    > broken because of it and causes breakage of the datatable:
    >    Uncaught TypeError: Cannot set property '_DT_CellIndex' of undefined.
    > (blocker)
    
    Fixed!
    
    > 7) NOT OK - tools - items batch edit   
    >    - Added barcodes of one editable and a non-editable item. Exlosion
    > (blocker)
    >    Can't locate object method "params" via package
    > "Koha::UI::Table::Builder::Items" at
    > /kohadevbox/koha/Koha/UI/Table/Builder/Items.pm line 75
    
    Fixed!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 14:36:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 12:36:50 +0000
    Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
     home library or library group
    In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20256-70-DjBfCujsHl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
    
    --- Comment #349 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
    (In reply to Kyle M Hall from comment #348)
    > > Summary:
    > > ==> The new edit_any_items overwrites the Indybranches pref. In consequence
    > > it appears it no longer has any effect. Correct?
    > 
    > IndependentBranches is built into this feature. If IndependentBranches is
    > enabled, only a superlibrarian can edit all items, and non-superlibrarians
    > can only edit items from his or her home library.
    
    I think that's not the case, I tried all the combinations.  It depends on the
    edit_any_items preference with this patch set. I was testing with a
    non-superlibrarian user:
    
    "Test case 4:
    * edit_items = yes
    * edit_any_items = yes
    * Independentbranches = YES
    * No library groups defined
    
    All items can be edited. Same as with Indybranches off."
    
    Can you please test yourself and take a look at my summary?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 14:37:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 12:37:03 +0000
    Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
     home library or library group
    In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20256-70-Fa7epxMRTD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
    
    Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Failed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 14:37:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 12:37:26 +0000
    Subject: [Koha-bugs] [Bug 30653] New: "Check out" search with one result
     does not redirect to checkout
    Message-ID: <bug-30653-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30653
    
                Bug ID: 30653
               Summary: "Check out" search with one result does not redirect
                        to checkout
     Change sponsored?: ---
               Product: Koha
               Version: 21.11
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: Circulation
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: magnus at libriotech.no
            QA Contact: testopia at bugs.koha-community.org
                    CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
    
    I am seeing this on 21.11.04. I go to the front page of the intranet. The
    "Check out" tab of the header search is active as default. I type my name into
    the search box and press enter. This takes me to this page: 
    
    /cgi-bin/koha/members/member.pl?quicksearch=1&circsearch=1&searchmember=magnus%20enger
    
    This page shows one result, and the "Card" column links to:
    
    /cgi-bin/koha/circ/circulation.pl?borrowernumber=1
    
    while the "Name" column links to:
    
    /cgi-bin/koha/members/moremember.pl?borrowernumber=1
    
    If I choose my name in the typeahead/dropdown that appears below the search
    box, I am taken to this page:
    
    /cgi-bin/koha/circ/circulation.pl?borrowernumber=1
    
    Then I do the same thing in 21.05.05: Type my name in the "Check out" box and
    press Enter. There I am taken directly to:
    
    /cgi-bin/koha/circ/circulation.pl
    
    (This is a POST, so borrowernumber=1 is not visible in the URL). 
    
    
    Looking more closely at the source of
    /cgi-bin/koha/members/member.pl?quicksearch=1&circsearch=1&searchmember=magnus%20enger
    in 21.11.04 I do see this: 
    
                        $.ajax({
                            'dataType': 'json',
                            'type': 'POST',
                            'url': sSource,
                            'data': aoData,
                            'success': function(json){
                                // redirect if there is only 1 result.
                                if ( json.aaData.length == 1 &&
    aoData.iDisplayStart == 0 ) {
                                    var borrowernumber =
    json.aaData[0].borrowernumber;
                                    /* Overwrite history state of firstletter
    search since only one result was returned; This prevents a loop upon clicking
    back */
                                    history.replaceState( {}, null,
    window.location.href.split("?" )[0]);
                                   
    document.location.href="/cgi-bin/koha/circ/circulation.pl?borrowernumber="+borrowernumber;
                                    return false;
                                }
                                fnCallback(json);
                            }
                        });
    
    This seems to incorporate the fix from bug 29411, but it does not seem to be
    working. There is nothing in the console.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 14:38:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 12:38:31 +0000
    Subject: [Koha-bugs] [Bug 30653] "Check out" search with one result does not
     redirect to checkout
    In-Reply-To: <bug-30653-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30653-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30653-70-HoPJGxlOXX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30653
    
    Magnus Enger <magnus at libriotech.no> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=29618,
                       |                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=29411
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 14:38:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 12:38:31 +0000
    Subject: [Koha-bugs] [Bug 29618] Typing a Patron Name into the checkout bar
     goes moremember.pl instead of circulation.pl
    In-Reply-To: <bug-29618-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29618-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29618-70-qYRkdhPyvt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29618
    
    Magnus Enger <magnus at libriotech.no> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30653
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 14:38:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 12:38:31 +0000
    Subject: [Koha-bugs] [Bug 29411] Single result for checkout search by name
     should redirect to check out tab
    In-Reply-To: <bug-29411-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29411-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29411-70-PekBnI14mR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411
    
    Magnus Enger <magnus at libriotech.no> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30653
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 14:42:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 12:42:40 +0000
    Subject: [Koha-bugs] [Bug 30553] Add a count to the Files tab in the patron
     account
    In-Reply-To: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30553-70-0HY1uwHeNZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30553
    
    --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    (In reply to Katrin Fischer from comment #9)
    > Hm, but no SQL in Koha namespace, I think. The DBIX equivalent?
    
    I would suggest allowing the SQL in Koha::Patron::Files and using the method
    from Koha::Patron.. and then having a follow-up bug to convert
    Koha::Patron::Files to proper Koha::Object based classes as a modernisation
    effort.
    
    To me, that's the most pragmatic route to goal for this simple enhancement.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:01:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:01:31 +0000
    Subject: [Koha-bugs] [Bug 30167] Return soonest renewal date when
     CanBookBeRenewed returns %too_soon
    In-Reply-To: <bug-30167-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30167-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30167-70-iEj0zEshXv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30167
    
    Nick Clemens <nick at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:01:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:01:35 +0000
    Subject: [Koha-bugs] [Bug 30167] Return soonest renewal date when
     CanBookBeRenewed returns %too_soon
    In-Reply-To: <bug-30167-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30167-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30167-70-bHIlcSjIq0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30167
    
    --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
    Created attachment 134380
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134380&action=edit
    Bug 30167: (follow-up) Return a hash with soonest_renew_date
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:04:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:04:22 +0000
    Subject: [Koha-bugs] [Bug 30387] IndependentBranches allows users to change
     libraries when they should not be able to
    In-Reply-To: <bug-30387-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30387-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30387-70-b63bd8Oizh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30387
    
    --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    So I dug through the history.. it was indeed a deliberate feature introduced in
    bug 6841.. though the bug is sparse of details.. the commit is a little
    clearer:
    https://git.koha-community.org/Koha-community/Koha/commit/c2015c710355a0ab81306515a70af29e6aef3504
    
    Honestly, I'm not close enough IndependantBranches to really wrap my head
    around the objectives as a whole.. but it sounds like a reasonable change to me
    generally.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:23:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:23:13 +0000
    Subject: [Koha-bugs] [Bug 30611] Add ability to send passwordreseturl from
     the staff client
    In-Reply-To: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30611-70-7dWKXwvtUk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |27812
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812
    [Bug 27812] Remove the ability to transmit a patron's plain text password over
    email
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:23:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:23:13 +0000
    Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's
     plain text password over email
    In-Reply-To: <bug-27812-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27812-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27812-70-wOENFkibVZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30611
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611
    [Bug 30611] Add ability to send passwordreseturl from the staff client
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:28:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:28:07 +0000
    Subject: [Koha-bugs] [Bug 30172] Background jobs failing due to race
     condition
    In-Reply-To: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30172-70-yW8wQ7OEGG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to oldoldstable      |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:28:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:28:08 +0000
    Subject: [Koha-bugs] [Bug 30345] Koha::BackgroundJob->enqueue should set
     borrowernumber=undef if no userenv
    In-Reply-To: <bug-30345-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30345-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30345-70-XjOc0NyPoK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345
    Bug 30345 depends on bug 30172, which changed state.
    
    Bug 30172 Summary: Background jobs failing due to race condition
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to oldoldstable      |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:28:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:28:08 +0000
    Subject: [Koha-bugs] [Bug 30350] Do not hardcode job types
    In-Reply-To: <bug-30350-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30350-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30350-70-InV51uzrVo@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30350
    Bug 30350 depends on bug 30172, which changed state.
    
    Bug 30172 Summary: Background jobs failing due to race condition
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to oldoldstable      |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:28:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:28:16 +0000
    Subject: [Koha-bugs] [Bug 30345] Koha::BackgroundJob->enqueue should set
     borrowernumber=undef if no userenv
    In-Reply-To: <bug-30345-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30345-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30345-70-akJV8xiu8c@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:28:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:28:16 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-BAA2OT0uSM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    Bug 27783 depends on bug 30345, which changed state.
    
    Bug 30345 Summary: Koha::BackgroundJob->enqueue should set borrowernumber=undef if no userenv
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:31:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:31:47 +0000
    Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen
    In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23919-70-gGnX4h8G4R@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|ASSIGNED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:31:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:31:52 +0000
    Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen
    In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23919-70-JNk0rOxqn8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919
    
    --- Comment #1 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 134381
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134381&action=edit
    Bug 23919: Add new system preference SearchWithISSNVariations
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:31:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:31:56 +0000
    Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen
    In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23919-70-mh3lgRGS5k@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919
    
    --- Comment #2 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 134382
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134382&action=edit
    Bug 23919: Zebra search by ISSN variations
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:32:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:32:00 +0000
    Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen
    In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23919-70-ceuo5wBQr8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919
    
    --- Comment #3 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 134383
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134383&action=edit
    Bug 23919: Add tests for biblioItems search by ISBN and ISSN with variations
    (sysprefs SearchWithISBNVariations/SearchWithISSNVariations)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:32:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:32:04 +0000
    Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen
    In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23919-70-IamQSlz38O@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919
    
    --- Comment #4 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 134384
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134384&action=edit
    Bug 23919: Items search by ISBN variations and ISSN variations
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:32:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:32:09 +0000
    Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen
    In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23919-70-oyDOnMRPKB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919
    
    --- Comment #5 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 134385
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134385&action=edit
    Bug 23919: Add tests for Items search by ISBN and ISSN with variations
    (sysprefs SearchWithISBNVariations/SearchWithISSNVariations)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:33:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:33:25 +0000
    Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
     too
    In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28269-70-JNGDvsx3Jf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|BLOCKED                     |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:33:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:33:30 +0000
    Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
     too
    In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28269-70-1In71bPIbX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133870|0                           |1
            is obsolete|                            |
     Attachment #133871|0                           |1
            is obsolete|                            |
    
    --- Comment #12 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 134386
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134386&action=edit
    Bug 28269: Add feature to search Acquisitions Orders by ISSN
    
    - add search form field for ISSN number
    - add search logic including ISSN variations search
      if SearchWithISSNVariations preference is set
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:33:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:33:34 +0000
    Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
     too
    In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28269-70-6I2qWJxnqL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269
    
    --- Comment #13 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 134387
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134387&action=edit
    Bug 28269: Add tests for Acquisitions Orders search by ISSN also with
    SearchWithISSNVariations on and off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:35:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:35:50 +0000
    Subject: [Koha-bugs] [Bug 30649] Add ability to encrypt data in Koha,
     use for EDI vendor accounts
    In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30649-70-UHtVpPJKFO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649
    
    --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
    (In reply to David Cook from comment #5)
    > I think Jonathan has already almost gotten an encryption module into Koha
    > with Bug 28998, so this would arguably be a duplicate?
    
    I was not aware of that bug! Once that's pushed, I'll rework this bug to use
    that instead of making it's own module.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:38:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:38:02 +0000
    Subject: [Koha-bugs] [Bug 30172] Background jobs failing due to race
     condition
    In-Reply-To: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30172-70-am6vgbYTWx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172
    
    --- Comment #43 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    With Rabbit there is no way to do it right now as far as I'm aware...
    
    You might be able to kill the worker, then kill rabbit, then start the
    worker... from memory it will fail to connect to rabbit and fall back to db
    polling.. that first db polling should find all the new tasks and work through
    them.
    
    Once you've confirmed all your tasks have run you can start rabbit and then
    restart your worker again to get it to use rabbit instead.
    
    We really aught to improve that.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:40:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:40:35 +0000
    Subject: [Koha-bugs] [Bug 30654] New: Even with RabbitMQ enabled,
     we should poll the database for jobs at worker startup
    Message-ID: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30654
    
                Bug ID: 30654
               Summary: Even with RabbitMQ enabled, we should poll the
                        database for jobs at worker startup
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Architecture, internals, and plumbing
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: martin.renvoize at ptfs-europe.com
            QA Contact: testopia at bugs.koha-community.org
            Depends on: 27344
    
    Our worker currently starts up and immediately tries to listen for jobs being
    passed via STOMP.  However, if rabbitMQ wasn't running when the tasks were
    enqueue, then the worker will never know about them.
    
    We should work through the outstanding queue before listening for new jobs.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    [Bug 27344] Implement Elastic's update_index_background using
    Koha::BackgroundJob
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:40:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:40:35 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27344-70-0qJ1F5iwCl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30654
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30654
    [Bug 30654] Even with RabbitMQ enabled, we should poll the database for jobs at
    worker startup
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:40:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:40:47 +0000
    Subject: [Koha-bugs] [Bug 30654] Even with RabbitMQ enabled,
     we should poll the database for jobs at worker startup
    In-Reply-To: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30654-70-O4hQNxbpKX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30654
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|27344                       |30172
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    [Bug 27344] Implement Elastic's update_index_background using
    Koha::BackgroundJob
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172
    [Bug 30172] Background jobs failing due to race condition
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:40:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:40:47 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27344-70-wEaSdfhzPK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|30654                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30654
    [Bug 30654] Even with RabbitMQ enabled, we should poll the database for jobs at
    worker startup
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:40:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:40:47 +0000
    Subject: [Koha-bugs] [Bug 30172] Background jobs failing due to race
     condition
    In-Reply-To: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30172-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30172-70-2dP0WuAeZ6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30654
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30654
    [Bug 30654] Even with RabbitMQ enabled, we should poll the database for jobs at
    worker startup
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:41:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:41:31 +0000
    Subject: [Koha-bugs] [Bug 21978] Add middle name field
    In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-21978-70-TEZqrxdtkw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
    
    Sally <sally.healey at cheshiresharedservices.gov.uk> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Failed QA
    
    --- Comment #64 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
    Hi Martin,
    
    The bulk of it is perfect.
    
    I noticed that when you use PatronAutoComplete, first names and surnames will
    partially match, but middle names won't.
    
    e.g.
    
    - Set up two users:  Henry James Johns and Henry Jameston Johnson
    - Do a search for 'Hen' - note that both are returned (Henry and Henry)
    - Do a search for 'John' - note that both are returned (Johns and Johnson)
    - Do a search for 'James' - note that only Henry James Johns is returned, and
    Henry Jameston Johnson isn't.
    
    I also noticed a few places where the middle name didn't display; to replicate:
    
    1)
    - Load patron account
    - Press search to hold
    - Perform a search which brings back 2+ items (e.g. 'street')
    - Note that on the search results it says:  Place hold for 'Firstname Surname'
    
    2)
    - Load patron account
    - Press search to hold
    - Perform a search
    - Open a record
    - Press the Place hold button
    - Note that the drop down for 'Place hold for patron' doesn't include middle
    name
    
    3)
    - Load patron account
    - Accounting
    - Make a payment (when patron owes no charges)
    - Note that it says 'Firstname Surname has no outstanding fines'
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:50:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:50:29 +0000
    Subject: [Koha-bugs] [Bug 30655] New: There was an error searching for
     analytic records
    Message-ID: <bug-30655-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30655
    
                Bug ID: 30655
               Summary: There was an error searching for analytic records
     Change sponsored?: ---
               Product: Koha
               Version: 21.11
              Hardware: All
                    OS: All
                Status: NEW
              Severity: normal
              Priority: P5 - low
             Component: MARC Bibliographic data support
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: magnus at libriotech.no
            QA Contact: testopia at bugs.koha-community.org
    
    After upgrading to 21.11.04, this is displayed on some (but not all) records in
    the intranet, just above the title: 
    
    "There was an error searching for analytic records, please see the logs for
    details."
    
    This message is not shown in the OPAC. 
    
    Logs:
    
    ==> /var/log/koha/hig/plack-error.log <==
    CCL parsing error (10014) Unknown qualifier ZOOM for query:
    Host-item=(Psychology and law =) at /usr/share/koha/lib/C4/Search.pm line 242.
    Warning from simple_search_compat: 'CCL parsing error (10014) Unknown qualifier
    ZOOM' at /usr/share/koha/lib/Koha/Biblio.pm line 540.
    
    ShowComponentRecords = no
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:54:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:54:02 +0000
    Subject: [Koha-bugs] [Bug 30655] There was an error searching for analytic
     records
    In-Reply-To: <bug-30655-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30655-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30655-70-NDEK03WNsp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30655
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |DUPLICATE
                 Status|NEW                         |RESOLVED
    
    --- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
    
    
    *** This bug has been marked as a duplicate of bug 29418 ***
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:54:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:54:02 +0000
    Subject: [Koha-bugs] [Bug 29418] Zebra clean_search_term does not clean
     search and so results in error
    In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29418-70-ytHL4ZbG5d@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418
    
    Owen Leonard <oleonard at myacpl.org> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |magnus at libriotech.no
    
    --- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
    *** Bug 30655 has been marked as a duplicate of this bug. ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:54:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:54:24 +0000
    Subject: [Koha-bugs] [Bug 30654] Even with RabbitMQ enabled,
     we should poll the database for jobs at worker startup
    In-Reply-To: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30654-70-hbhAMUnmQv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30654
    
    --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134388
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134388&action=edit
    Bug 30654: Processing outstanding jobs on startup
    
    This patch ensures jobs queued up in the database prior to worker
    startup are processed regardless as to whether you are using RabbitMQ or
    Database polling.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:54:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:54:56 +0000
    Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
     home library or library group
    In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20256-70-SUsrsFQPRw@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
    
    --- Comment #350 from Kyle M Hall <kyle at bywatersolutions.com> ---
    > "Test case 4:
    > * edit_items = yes
    > * edit_any_items = yes
    > * Independentbranches = YES
    > * No library groups defined
    > 
    > All items can be edited. Same as with Indybranches off."
    > 
    > Can you please test yourself and take a look at my summary?
    
    As far as I can tell, it's working as expected. Can you take a look at this
    video and let me know if I'm missing anything?
    
    https://www.youtube.com/watch?v=kkwd-qCoM50
    
    Thanks!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:54:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:54:58 +0000
    Subject: [Koha-bugs] [Bug 30654] Even with RabbitMQ enabled,
     we should poll the database for jobs at worker startup
    In-Reply-To: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30654-70-vT0CNaKfgF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30654
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|NEW                         |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:55:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:55:05 +0000
    Subject: [Koha-bugs] [Bug 30654] Even with RabbitMQ enabled,
     we should poll the database for jobs at worker startup
    In-Reply-To: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30654-70-MFTtGAJ8ch@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30654
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Severity|enhancement                 |major
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 15:55:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 13:55:31 +0000
    Subject: [Koha-bugs] [Bug 30654] Even with RabbitMQ enabled,
     we should poll the database for jobs at worker startup
    In-Reply-To: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30654-70-tbGJasnKUt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30654
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com,
                       |                            |nick at bywatersolutions.com,
                       |                            |tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 16:05:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 14:05:08 +0000
    Subject: [Koha-bugs] [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and
     staff interface
    In-Reply-To: <bug-30011-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30011-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30011-70-rz22SwJNa4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com
               Keywords|                            |additional_work_needed
    
    --- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    dateformat_string has been removed from calendar.inc but it still used from
    calendar.js
    There is a warning in the console: ReferenceError: dateformat_string is not
    defined
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 16:07:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 14:07:10 +0000
    Subject: [Koha-bugs] [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and
     staff interface
    In-Reply-To: <bug-30011-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30011-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30011-70-Sp4SO7h9Mx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011
    
    --- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    Maybe we need to apply this change.
    
    diff --git a/koha-tmpl/intranet-tmpl/prog/js/calendar.js
    b/koha-tmpl/intranet-tmpl/prog/js/calendar.js
    index 7a4a5083e8a..6ee428feaa2 100644
    --- a/koha-tmpl/intranet-tmpl/prog/js/calendar.js
    +++ b/koha-tmpl/intranet-tmpl/prog/js/calendar.js
    @@ -8,7 +8,7 @@ if (debug > 1) {
     function is_valid_date(date) {
         // An empty string is considered as a valid date for convenient reasons.
         if (date === '') return 1;
    -    var dateformat = dateformat_string;
    +    var dateformat = dateformat_pref;
         if (dateformat == 'us') {
             if (date.search(/^\d{2}\/\d{2}\/\d{4}($|\s)/) == -1) return 0;
             dateformat = 'mm/dd/yy';
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 16:08:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 14:08:16 +0000
    Subject: [Koha-bugs] [Bug 30514] Error in date format check following
     datepicker removal
    In-Reply-To: <bug-30514-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30514-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30514-70-Mu2x58Pxg7@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30514
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |jonathan.druart+koha at gmail.
                       |                            |com
               Keywords|                            |rel_22_05_candidate
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 16:09:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 14:09:06 +0000
    Subject: [Koha-bugs] [Bug 30654] Even with RabbitMQ enabled,
     we should poll the database for jobs at worker startup
    In-Reply-To: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30654-70-SvxtgrStZD@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30654
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |magnus at libriotech.no,
                       |                            |martin.renvoize at ptfs-europe
                       |                            |.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 16:09:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 14:09:11 +0000
    Subject: [Koha-bugs] [Bug 30654] Even with RabbitMQ enabled,
     we should poll the database for jobs at worker startup
    In-Reply-To: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30654-70-RsJHfRu9Ep@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30654
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                       |ity.org                     |.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 16:11:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 14:11:15 +0000
    Subject: [Koha-bugs] [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and
     staff interface
    In-Reply-To: <bug-30011-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30011-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30011-70-rNvIuimNY5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011
    
    Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|additional_work_needed      |
    
    --- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
    It has been reported on bug 30514 already.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 16:13:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 14:13:16 +0000
    Subject: [Koha-bugs] [Bug 30350] Do not hardcode job types
    In-Reply-To: <bug-30350-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30350-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30350-70-4zcfB3D3vS@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30350
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
             Resolution|---                         |DUPLICATE
                 Status|ASSIGNED                    |RESOLVED
    
    --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    We opted for Queues in bug 27783.. marking as Resolved Fixed
    
    *** This bug has been marked as a duplicate of bug 27783 ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 16:13:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 14:13:16 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-StnJzI8OK8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    --- Comment #59 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    *** Bug 30350 has been marked as a duplicate of this bug. ***
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 16:14:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 14:14:25 +0000
    Subject: [Koha-bugs] [Bug 27756] background_jobs_worker.pl is memory
     inefficient
    In-Reply-To: <bug-27756-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27756-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27756-70-ha3SAicLTd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27756
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 16:14:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 14:14:26 +0000
    Subject: [Koha-bugs] [Bug 28413] background job worker is running with all
     the modules in RAM
    In-Reply-To: <bug-28413-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28413-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28413-70-uTFc1IvjsB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28413
    Bug 28413 depends on bug 27756, which changed state.
    
    Bug 27756 Summary: background_jobs_worker.pl is memory inefficient
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27756
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 16:14:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 14:14:51 +0000
    Subject: [Koha-bugs] [Bug 28413] background job worker is running with all
     the modules in RAM
    In-Reply-To: <bug-28413-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28413-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28413-70-NpC8cIIfWs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28413
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|22417                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417
    [Bug 22417] Add a task queue
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 16:14:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 14:14:51 +0000
    Subject: [Koha-bugs] [Bug 22417] Add a task queue
    In-Reply-To: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22417-70-lACbZTBDjU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|28413                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28413
    [Bug 28413] background job worker is running with all the modules in RAM
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 16:15:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 14:15:28 +0000
    Subject: [Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create
    In-Reply-To: <bug-25674-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25674-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25674-70-hDJEMkNMNC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|22417                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417
    [Bug 22417] Add a task queue
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 16:15:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 14:15:28 +0000
    Subject: [Koha-bugs] [Bug 22417] Add a task queue
    In-Reply-To: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-22417-70-PevwcPIBRJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|25674                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674
    [Bug 25674] Add RabbitMQ options to koha-create
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 16:22:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 14:22:15 +0000
    Subject: [Koha-bugs] [Bug 30656] New: Introduce worker_manager daemon
    Message-ID: <bug-30656-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30656
    
                Bug ID: 30656
               Summary: Introduce worker_manager daemon
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Architecture, internals, and plumbing
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: martin.renvoize at ptfs-europe.com
            QA Contact: testopia at bugs.koha-community.org
            Depends on: 27783
    
    We have a simple worker script and we now start up two workers working through
    two distinct queues.
    
    However, as noted in bug 27783, it would be greatly beneficial to have a worker
    manager that could spawn parallel workers and use a config to define the number
    of workers and what those workers can work upon.
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    [Bug 27783] Introduce background job queues
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 16:22:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 14:22:15 +0000
    Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
    In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27783-70-h6n31lvqLx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30656
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30656
    [Bug 30656] Introduce worker_manager daemon
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 16:24:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 14:24:35 +0000
    Subject: [Koha-bugs] [Bug 30656] Introduce worker_manager daemon
    In-Reply-To: <bug-30656-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30656-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30656-70-uuZ2bIXJsl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30656
    
    --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    See discussion in bug 27783 for more details and considerations.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 16:59:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 14:59:42 +0000
    Subject: [Koha-bugs] [Bug 30649] Add ability to encrypt data in Koha,
     use for EDI vendor accounts
    In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30649-70-BDMu3ooQ2k@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |m.de.rooy at rijksmuseum.nl
                 Status|Needs Signoff               |BLOCKED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 16:59:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 14:59:56 +0000
    Subject: [Koha-bugs] [Bug 30649] Add ability to encrypt data in Koha,
     use for EDI vendor accounts
    In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30649-70-B0WgrIg6JE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649
    
    --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Kyle M Hall from comment #6)
    > (In reply to David Cook from comment #5)
    > > I think Jonathan has already almost gotten an encryption module into Koha
    > > with Bug 28998, so this would arguably be a duplicate?
    > 
    > I was not aware of that bug! Once that's pushed, I'll rework this bug to use
    > that instead of making it's own module.
    
    Changing status
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 17:05:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 15:05:30 +0000
    Subject: [Koha-bugs] [Bug 30553] Add a count to the Files tab in the patron
     account
    In-Reply-To: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30553-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30553-70-eEPm8ZnVIt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30553
    
    Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |m.de.rooy at rijksmuseum.nl
    
    --- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    (In reply to Martin Renvoize from comment #11)
    > (In reply to Katrin Fischer from comment #9)
    > > Hm, but no SQL in Koha namespace, I think. The DBIX equivalent?
    > 
    > I would suggest allowing the SQL in Koha::Patron::Files and using the method
    > from Koha::Patron.. and then having a follow-up bug to convert
    > Koha::Patron::Files to proper Koha::Object based classes as a modernisation
    > effort.
    > 
    > To me, that's the most pragmatic route to goal for this simple enhancement.
    
    With the risk that we push this arguable code and the follow=up is delayed ;)
    Since it is a very simple development, it could probably be done here?
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 17:08:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 15:08:11 +0000
    Subject: [Koha-bugs] [Bug 30657] New: Make patron attributes available via
     Template Toolkit in overdues
    Message-ID: <bug-30657-70@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657
    
                Bug ID: 30657
               Summary: Make patron attributes available via Template Toolkit
                        in overdues
     Change sponsored?: ---
               Product: Koha
               Version: master
              Hardware: All
                    OS: All
                Status: NEW
              Severity: enhancement
              Priority: P5 - low
             Component: Notices
              Assignee: koha-bugs at lists.koha-community.org
              Reporter: andrew at bywatersolutions.com
            QA Contact: testopia at bugs.koha-community.org
    
    When using Template Toolkit to fetch patron values, one should be able to fetch
    patron attribute values. This would be useful both for printing those values
    into the notice content and for using those values in logic to vary the notices
    per patron.
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 17:09:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 15:09:41 +0000
    Subject: [Koha-bugs] [Bug 30657] Make patron attributes available via
     Template Toolkit in overdues
    In-Reply-To: <bug-30657-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30657-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30657-70-EnH4kVXeT5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657
    
    Lucas Gass <lucas at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |lucas at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 17:13:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 15:13:22 +0000
    Subject: [Koha-bugs] [Bug 30488] Error when placing a recall in the OPAC
    In-Reply-To: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30488-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30488-70-xivUYJxpjZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                 Status|Pushed to master            |RESOLVED
                     CC|                            |kyle at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 17:16:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 15:16:58 +0000
    Subject: [Koha-bugs] [Bug 30518] StockRotationItems crossing DST boundary
     throw invalid local time exception
    In-Reply-To: <bug-30518-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30518-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30518-70-7dNvLZW9rx@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30518
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |Pushed to stable
                     CC|                            |kyle at bywatersolutions.com
             Version(s)|22.05.00                    |22.05.00,21.11.06
            released in|                            |
    
    --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.06
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 17:34:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 15:34:24 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-z5cnHxFyh5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134359|0                           |1
            is obsolete|                            |
    
    --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134389
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134389&action=edit
    Bug 30291: Database changes to recalls table
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 17:34:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 15:34:28 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-ARkMsg1pJY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134360|0                           |1
            is obsolete|                            |
    
    --- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134390
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134390&action=edit
    Bug 30291: Update boolean flags in Recall schema file
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 17:34:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 15:34:33 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-aKJrxclQBK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134361|0                           |1
            is obsolete|                            |
    
    --- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134391
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134391&action=edit
    Bug 30291: Changes to tests
    
    t/db_dependent/Circulation.t
    t/db_dependent/Circulation/CalcFine.t
    t/db_dependent/Circulation/transferbook.t
    t/db_dependent/Holds.t
    t/db_dependent/Koha/Biblio.t
    t/db_dependent/Koha/Item.t
    t/db_dependent/Koha/Patron.t
    t/db_dependent/Koha/Recall.t
    t/db_dependent/Koha/Recalls.t
    t/db_dependent/XSLT.t
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 17:34:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 15:34:38 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-YgT4f9lhfz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134362|0                           |1
            is obsolete|                            |
    
    --- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134392
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134392&action=edit
    Bug 30291: Changes to controller scripts
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 17:34:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 15:34:42 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-iaEh28X5te@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134363|0                           |1
            is obsolete|                            |
    
    --- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134393
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134393&action=edit
    Bug 30291: Changes to staff client files
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 17:34:47 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 15:34:47 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-lknpZNW8B8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134364|0                           |1
            is obsolete|                            |
    
    --- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134394
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134394&action=edit
    Bug 30291: Changes to OPAC files
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 17:34:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 15:34:51 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-QtEG8b0Cs0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134365|0                           |1
            is obsolete|                            |
    
    --- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134395
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134395&action=edit
    Bug 30291: Fix permissions
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 17:34:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 15:34:56 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-pNEwQYCESa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134366|0                           |1
            is obsolete|                            |
    
    --- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134396
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134396&action=edit
    Bug 30291: (QA follow-up) Keep recall_id column name
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 17:35:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 15:35:00 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-RhMBEHao7B@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134367|0                           |1
            is obsolete|                            |
    
    --- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    Created attachment 134397
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134397&action=edit
    Bug 30291: Updated schema files [DO NOT PUSH]
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 17:36:38 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 15:36:38 +0000
    Subject: [Koha-bugs] [Bug 30291] Rename recalls.* column names
    In-Reply-To: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30291-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30291-70-ycFvZ0GZws@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |martin.renvoize at ptfs-europe
                       |                            |.com
                 Status|Signed Off                  |Passed QA
    
    --- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
    The QA script is happy and this all appears to still be working as expected...
    so Passing QA.
    
    However, building the DBIC Schema appears to spit out lots of overloaded method
    name errors (at the top as you run the QA script).. I think they're harmless in
    this case but it's a little disturbing to see.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 18:48:02 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 16:48:02 +0000
    Subject: [Koha-bugs] [Bug 30435] Remove unused MACLES cataloging plugin
    In-Reply-To: <bug-30435-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30435-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30435-70-fAjypi8872@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30435
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 18:49:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 16:49:03 +0000
    Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
    In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29602-70-u0CjodoMHO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
                     CC|                            |kyle at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 18:49:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 16:49:04 +0000
    Subject: [Koha-bugs] [Bug 30629] <span> in title of patron card creator
     template needs to be removed
    In-Reply-To: <bug-30629-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30629-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30629-70-dHkcNqreLk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629
    Bug 30629 depends on bug 29602, which changed state.
    
    Bug 29602 Summary: We must be nicer with translators
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 18:50:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 16:50:37 +0000
    Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor
     performance for records with many items
    In-Reply-To: <bug-29483-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29483-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29483-70-RKqkqZzXSE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
             Resolution|---                         |FIXED
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 18:53:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 16:53:43 +0000
    Subject: [Koha-bugs] [Bug 30540] Double processing invalid dates can lead to
     ISE
    In-Reply-To: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30540-70-wFx4jaavy2@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30540
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
                     CC|                            |kyle at bywatersolutions.com
             Resolution|---                         |FIXED
    
    --- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Please rebase and ping me if needed in 21.11, I tried but get an error on the
    unit test.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 18:55:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 16:55:35 +0000
    Subject: [Koha-bugs] [Bug 30540] Double processing invalid dates can lead to
     ISE
    In-Reply-To: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30540-70-W1OhwkUsql@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30540
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|FIXED                       |---
                 Status|RESOLVED                    |REOPENED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 18:55:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 16:55:43 +0000
    Subject: [Koha-bugs] [Bug 30540] Double processing invalid dates can lead to
     ISE
    In-Reply-To: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30540-70-3brdZdzBkC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30540
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|REOPENED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 18:55:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 16:55:50 +0000
    Subject: [Koha-bugs] [Bug 30540] Double processing invalid dates can lead to
     ISE
    In-Reply-To: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30540-70-JPxsUb9j38@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30540
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 18:55:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 16:55:58 +0000
    Subject: [Koha-bugs] [Bug 30540] Double processing invalid dates can lead to
     ISE
    In-Reply-To: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30540-70-hS5aNgCcTR@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30540
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 18:56:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 16:56:09 +0000
    Subject: [Koha-bugs] [Bug 30540] Double processing invalid dates can lead to
     ISE
    In-Reply-To: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30540-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30540-70-Fc3ze0JZHm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30540
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|22.05.00                    |22.05.00,21.11.06
            released in|                            |
                 Status|Passed QA                   |Pushed to stable
    
    --- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.06
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 18:57:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 16:57:41 +0000
    Subject: [Koha-bugs] [Bug 30509] Accordion on letter.tt is broken
    In-Reply-To: <bug-30509-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30509-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30509-70-UicPlrIyMl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30509
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|22.05.00                    |22.05.00,21.11.06
            released in|                            |
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |Pushed to stable
    
    --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.06
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 18:58:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 16:58:10 +0000
    Subject: [Koha-bugs] [Bug 30223] Move book cover image upload JS to a
     separate file
    In-Reply-To: <bug-30223-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30223-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30223-70-7erfp3Y8rj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30223
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 18:58:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 16:58:31 +0000
    Subject: [Koha-bugs] [Bug 25815] SIP Checkout: add more information on why
     the patron is blocked
    In-Reply-To: <bug-25815-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25815-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25815-70-FZ9D4J7I31@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
                     CC|                            |kyle at bywatersolutions.com
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 18:59:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 16:59:07 +0000
    Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface - <h1> on
     each page is Logo but should be page description/title
    In-Reply-To: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27631-70-fLMxiPdme3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 18:59:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 16:59:07 +0000
    Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings
     should have correct tags and hierarchy
    In-Reply-To: <bug-27741-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27741-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27741-70-D6RBYUnJJm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741
    Bug 27741 depends on bug 27631, which changed state.
    
    Bug 27631 Summary: Accessibility: Staff interface - <h1> on each page is Logo but should be page description/title
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 18:59:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 16:59:08 +0000
    Subject: [Koha-bugs] [Bug 27877] Accessibility: Staff Client - Reduce
     heading redundancy
    In-Reply-To: <bug-27877-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27877-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27877-70-iOs911Py2o@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27877
    Bug 27877 depends on bug 27631, which changed state.
    
    Bug 27631 Summary: Accessibility: Staff interface - <h1> on each page is Logo but should be page description/title
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 18:59:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 16:59:08 +0000
    Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions
     to tables
    In-Reply-To: <bug-28243-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28243-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28243-70-VyIzndi6h8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243
    Bug 28243 depends on bug 27631, which changed state.
    
    Bug 27631 Summary: Accessibility: Staff interface - <h1> on each page is Logo but should be page description/title
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 18:59:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 16:59:08 +0000
    Subject: [Koha-bugs] [Bug 28532] Accessibility: Staff Client - add legends
     to forms
    In-Reply-To: <bug-28532-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28532-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28532-70-mm431Hu8Hr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28532
    Bug 28532 depends on bug 27631, which changed state.
    
    Bug 27631 Summary: Accessibility: Staff interface - <h1> on each page is Logo but should be page description/title
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 18:59:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 16:59:29 +0000
    Subject: [Koha-bugs] [Bug 29420] HTTP status code incorrect when calling
     error pages directly under Plack/PSGI
    In-Reply-To: <bug-29420-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29420-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29420-70-W76MJwmhOy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 18:59:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 16:59:30 +0000
    Subject: [Koha-bugs] [Bug 29744] Harmonize psgi/plack detection methods
    In-Reply-To: <bug-29744-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29744-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29744-70-16Yxu36tVG@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744
    Bug 29744 depends on bug 29420, which changed state.
    
    Bug 29420 Summary: HTTP status code incorrect when calling error pages directly under Plack/PSGI
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:01:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:01:49 +0000
    Subject: [Koha-bugs] [Bug 29005] Add option to send ACCTDETAILS notice for
     new patrons added via patron imports
    In-Reply-To: <bug-29005-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29005-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29005-70-Qz8sqSNb22@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:01:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:01:50 +0000
    Subject: [Koha-bugs] [Bug 30237] Rename/rephrase
     AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use
    In-Reply-To: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30237-70-uExKQA2kX1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237
    Bug 30237 depends on bug 29005, which changed state.
    
    Bug 29005 Summary: Add option to send ACCTDETAILS notice for new patrons added via patron imports
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:01:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:01:51 +0000
    Subject: [Koha-bugs] [Bug 30646] Add option to send ACCTDETAILS notice for
     new patrons added at first login via LDAP/SAML
    In-Reply-To: <bug-30646-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30646-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30646-70-Mn9TwZzQ3f@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30646
    Bug 30646 depends on bug 29005, which changed state.
    
    Bug 29005 Summary: Add option to send ACCTDETAILS notice for new patrons added via patron imports
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:02:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:02:25 +0000
    Subject: [Koha-bugs] [Bug 30237] Rename/rephrase
     AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use
    In-Reply-To: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30237-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30237-70-Y5HWXPni88@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:02:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:02:26 +0000
    Subject: [Koha-bugs] [Bug 9097] Add option to trigger 'Welcome mail' manually
    In-Reply-To: <bug-9097-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-9097-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-9097-70-yxPPqei7Kk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097
    Bug 9097 depends on bug 30237, which changed state.
    
    Bug 30237 Summary: Rename/rephrase AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:12:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:12:09 +0000
    Subject: [Koha-bugs] [Bug 9097] Add option to trigger 'Welcome mail' manually
    In-Reply-To: <bug-9097-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-9097-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-9097-70-Q5kHQo9fvk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
             Resolution|---                         |FIXED
                 Status|Pushed to master            |CLOSED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:12:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:12:52 +0000
    Subject: [Koha-bugs] [Bug 30467] BatchDeleteItem task does not deal with
     indexation correctly
    In-Reply-To: <bug-30467-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30467-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30467-70-Gi4LU937dH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30467
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:12:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:12:55 +0000
    Subject: [Koha-bugs] [Bug 30467] BatchDeleteItem task does not deal with
     indexation correctly
    In-Reply-To: <bug-30467-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30467-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30467-70-tZgxLsVZv4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30467
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132992|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:13:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:13:08 +0000
    Subject: [Koha-bugs] [Bug 26370] Add ability to disable demagnetizing items
     via SIP2 for arbitrary patron categories
    In-Reply-To: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26370-70-Wy0kxh54zl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:13:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:13:17 +0000
    Subject: [Koha-bugs] [Bug 30467] BatchDeleteItem task does not deal with
     indexation correctly
    In-Reply-To: <bug-30467-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30467-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30467-70-2G7KtXcmWl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30467
    
    --- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134398
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134398&action=edit
    Bug 30467: Don't send the delete request for each item
    
    We are sending the request when all the items have been deleted.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:13:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:13:39 +0000
    Subject: [Koha-bugs] [Bug 30544] Add font awesome version to licenses page
    In-Reply-To: <bug-30544-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30544-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30544-70-2AVEiuIvWj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30544
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:13:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:13:53 +0000
    Subject: [Koha-bugs] [Bug 30459] BatchDeleteAuthority task does not deal
     with indexation correctly
    In-Reply-To: <bug-30459-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30459-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30459-70-llvCXPMdYb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30459
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
                     CC|                            |tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:13:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:13:56 +0000
    Subject: [Koha-bugs] [Bug 30459] BatchDeleteAuthority task does not deal
     with indexation correctly
    In-Reply-To: <bug-30459-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30459-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30459-70-TCuWJ5OC3H@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30459
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132991|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:14:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:14:42 +0000
    Subject: [Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when
     adding/editing items
    In-Reply-To: <bug-29815-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29815-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29815-70-cK22mojCPb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:15:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:15:05 +0000
    Subject: [Koha-bugs] [Bug 30226] Add system preference to disable auto-renew
     checkbox at checkout
    In-Reply-To: <bug-30226-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30226-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30226-70-bcvoGfwaqi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:15:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:15:06 +0000
    Subject: [Koha-bugs] [Bug 30459] BatchDeleteAuthority task does not deal
     with indexation correctly
    In-Reply-To: <bug-30459-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30459-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30459-70-aqmdsfSfgm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30459
    
    --- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134399
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134399&action=edit
    Bug 30459: Make BatchDeleteAuthority update the index in one request
    
    Same as bug 30460 for authorities
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:16:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:16:03 +0000
    Subject: [Koha-bugs] [Bug 30464] BatchUpdateAuthority task does not deal
     with indexation correctly
    In-Reply-To: <bug-30464-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30464-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30464-70-TPv5ySgyvl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30464
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:16:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:16:08 +0000
    Subject: [Koha-bugs] [Bug 30464] BatchUpdateAuthority task does not deal
     with indexation correctly
    In-Reply-To: <bug-30464-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30464-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30464-70-IOSYG68jt6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30464
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132990|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:17:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:17:07 +0000
    Subject: [Koha-bugs] [Bug 30288] Provide links to OPACUserJS and OPACUserCSS
     from News/HTML customizations
    In-Reply-To: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30288-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30288-70-igrfdOmZ0Y@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:17:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:17:24 +0000
    Subject: [Koha-bugs] [Bug 30464] BatchUpdateAuthority task does not deal
     with indexation correctly
    In-Reply-To: <bug-30464-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30464-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30464-70-Pv7YgdcVIb@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30464
    
    --- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134400
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134400&action=edit
    Bug 30464: Make BatchUpdateAuthority update the index in one request
    
    Same as bug 30465 for authorities
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:17:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:17:26 +0000
    Subject: [Koha-bugs] [Bug 18392] Allow exporting circulation conditions as
     CSV or spreadsheet
    In-Reply-To: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18392-70-FprtOW6CXf@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|---                         |FIXED
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:17:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:17:26 +0000
    Subject: [Koha-bugs] [Bug 30589] Allow importing circulation conditions as
     CSV or spreadsheet
    In-Reply-To: <bug-30589-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30589-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30589-70-KirC6QDBvv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30589
    Bug 30589 depends on bug 18392, which changed state.
    
    Bug 18392 Summary: Allow exporting circulation conditions as CSV or spreadsheet
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:17:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:17:29 +0000
    Subject: [Koha-bugs] [Bug 30464] BatchUpdateAuthority task does not deal
     with indexation correctly
    In-Reply-To: <bug-30464-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30464-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30464-70-yclazFdwuN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30464
    
    --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134401
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134401&action=edit
    Bug 30464: (QA follow-up) Enqueue indexing
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:18:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:18:06 +0000
    Subject: [Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap
     (amount) results in data loss and extra fines
    In-Reply-To: <bug-30346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30346-70-K0cnautVBs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |Pushed to stable
             Version(s)|22.05.00                    |22.05.00,21.11.06
            released in|                            |
                     CC|                            |kyle at bywatersolutions.com
    
    --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.06
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:18:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:18:16 +0000
    Subject: [Koha-bugs] [Bug 30460] BatchDeleteBiblio task does not deal with
     indexation correctly
    In-Reply-To: <bug-30460-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30460-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30460-70-sKLTpWDWvj@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30460
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:18:20 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:18:20 +0000
    Subject: [Koha-bugs] [Bug 30460] BatchDeleteBiblio task does not deal with
     indexation correctly
    In-Reply-To: <bug-30460-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30460-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30460-70-bAxFactKJg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30460
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132989|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:18:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:18:43 +0000
    Subject: [Koha-bugs] [Bug 30460] BatchDeleteBiblio task does not deal with
     indexation correctly
    In-Reply-To: <bug-30460-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30460-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30460-70-QhZ9eFWxtu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30460
    
    --- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134402
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134402&action=edit
    Bug 30460: Make BatchDeleteBiblio update the index in one request
    
    No need to send 1 indexation request per item + 1 per biblio.
    
    Test plan:
    Confirm that the batch biblio deletion tool still works correctly
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:19:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:19:21 +0000
    Subject: [Koha-bugs] [Bug 30465] BatchUpdateBiblio task does not deal with
     indexation correctly
    In-Reply-To: <bug-30465-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30465-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30465-70-5nlFApCzZV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30465
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:19:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:19:22 +0000
    Subject: [Koha-bugs] [Bug 30205] Add biblio.subtitle to the
     subscription-detail.pl page
    In-Reply-To: <bug-30205-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30205-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30205-70-SwlzVaNsOg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Version(s)|22.05.00                    |22.05.00,21.11.06
            released in|                            |
                 Status|Pushed to master            |Pushed to stable
                     CC|                            |kyle at bywatersolutions.com
    
    --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.06
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:19:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:19:23 +0000
    Subject: [Koha-bugs] [Bug 30465] BatchUpdateBiblio task does not deal with
     indexation correctly
    In-Reply-To: <bug-30465-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30465-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30465-70-UjyGAgxaET@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30465
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133058|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:19:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:19:54 +0000
    Subject: [Koha-bugs] [Bug 30465] BatchUpdateBiblio task does not deal with
     indexation correctly
    In-Reply-To: <bug-30465-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30465-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30465-70-OgMP1xaTDr@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30465
    
    --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134403
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134403&action=edit
    Bug 30465: Make BatchUpdateBiblio update the index in one request
    
    When using the batch record modification tool to modify several
    bibliographic records, we don't want to send one index request per
    biblio, we want to index them all on the fly after the records have been
    modified.
    Otherwise we will end up with one task per record, and records will be
    indexed in background.
    
    Test plan:
    Use the batch mod tool to modify bibliographic records and confirm the
    behaviour is correct.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:19:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:19:59 +0000
    Subject: [Koha-bugs] [Bug 30465] BatchUpdateBiblio task does not deal with
     indexation correctly
    In-Reply-To: <bug-30465-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30465-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30465-70-CGHVAglmhV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30465
    
    --- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134404
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134404&action=edit
    Bug 30465: (QA follow-up) Enqueue indexing
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:20:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:20:06 +0000
    Subject: [Koha-bugs] [Bug 30465] BatchUpdateBiblio task does not deal with
     indexation correctly
    In-Reply-To: <bug-30465-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30465-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30465-70-H6RJvOx441@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30465
    
    --- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134405
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134405&action=edit
    Bug 30465: (QA follow-up) POD fixes
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:21:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:21:08 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27344-70-IWzBoajP2u@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:21:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:21:29 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27344-70-ojVlNdfqCs@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132994|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:21:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:21:43 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27344-70-HfKQxjRT0i@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132995|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:21:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:21:44 +0000
    Subject: [Koha-bugs] [Bug 30204] Add subtitle to serial subscription search
    In-Reply-To: <bug-30204-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30204-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30204-70-FspYjI4BWW@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
             Resolution|---                         |FIXED
                 Status|Pushed to master            |RESOLVED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:21:44 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:21:44 +0000
    Subject: [Koha-bugs] [Bug 30302] Include subtitle in fields searched by
     Title in serials
    In-Reply-To: <bug-30302-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30302-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30302-70-MdPz0bUx3q@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30302
    Bug 30302 depends on bug 30204, which changed state.
    
    Bug 30204 Summary: Add subtitle to serial subscription search
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:21:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:21:45 +0000
    Subject: [Koha-bugs] [Bug 30466] Convert serials pages tabs to Bootstrap
    In-Reply-To: <bug-30466-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30466-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30466-70-UFWpCsMiiV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466
    Bug 30466 depends on bug 30204, which changed state.
    
    Bug 30204 Summary: Add subtitle to serial subscription search
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:21:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:21:51 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27344-70-xummgxxVqZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132969|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:21:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:21:57 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27344-70-t6oYS3muEg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132970|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:22:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:22:06 +0000
    Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
     - TOTP
    In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28786-70-WanWXfmxzN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
                     CC|                            |kyle at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:22:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:22:07 +0000
    Subject: [Koha-bugs] [Bug 20476] Two factor authentication for the staff
     client - omnibus
    In-Reply-To: <bug-20476-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-20476-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-20476-70-Jwvz5j5QW6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20476
    Bug 20476 depends on bug 28786, which changed state.
    
    Bug 28786 Summary: Two-factor authentication for staff client - TOTP
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:22:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:22:07 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27344-70-AOWH12xJoN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132843|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:22:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:22:08 +0000
    Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
    In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28787-70-wOggu0xh1T@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787
    Bug 28787 depends on bug 28786, which changed state.
    
    Bug 28786 Summary: Two-factor authentication for staff client - TOTP
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:22:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:22:08 +0000
    Subject: [Koha-bugs] [Bug 29835] 2FA - ask for the users password when they
     choose to disable 2FA
    In-Reply-To: <bug-29835-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29835-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29835-70-KoAK56t9lO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29835
    Bug 29835 depends on bug 28786, which changed state.
    
    Bug 28786 Summary: Two-factor authentication for staff client - TOTP
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:22:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:22:08 +0000
    Subject: [Koha-bugs] [Bug 29836] 2FA - provide a REST API challenge route
    In-Reply-To: <bug-29836-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29836-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29836-70-T2ObE7kpBv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29836
    Bug 29836 depends on bug 28786, which changed state.
    
    Bug 28786 Summary: Two-factor authentication for staff client - TOTP
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:22:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:22:09 +0000
    Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing
     secret via HTTP GET
    In-Reply-To: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29873-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29873-70-sEQcJPPBq0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873
    Bug 29873 depends on bug 28786, which changed state.
    
    Bug 28786 Summary: Two-factor authentication for staff client - TOTP
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:22:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:22:09 +0000
    Subject: [Koha-bugs] [Bug 30586] The fallback option when enabling MFA for
     login doesn't work
    In-Reply-To: <bug-30586-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30586-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30586-70-PSDjlj5pfV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30586
    Bug 30586 depends on bug 28786, which changed state.
    
    Bug 28786 Summary: Two-factor authentication for staff client - TOTP
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:22:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:22:10 +0000
    Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on
     first login
    In-Reply-To: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30588-70-pqeJOZSENg@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588
    Bug 30588 depends on bug 28786, which changed state.
    
    Bug 28786 Summary: Two-factor authentication for staff client - TOTP
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:22:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:22:17 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27344-70-YacdDUW0Eh@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132844|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:22:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:22:29 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27344-70-TqfIgPNQwJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132845|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:22:33 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:22:33 +0000
    Subject: [Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
    In-Reply-To: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30373-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30373-70-7LQlAnwP31@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
                     CC|                            |kyle at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:22:34 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:22:34 +0000
    Subject: [Koha-bugs] [Bug 27619] Remove fr-FR installer data
    In-Reply-To: <bug-27619-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27619-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27619-70-r3WTuL6aCA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619
    Bug 27619 depends on bug 30373, which changed state.
    
    Bug 30373 Summary: Rewrite UNIMARC installer data to YAML
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:22:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:22:35 +0000
    Subject: [Koha-bugs] [Bug 30477] Add new UNIMARC installer translation files
    In-Reply-To: <bug-30477-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30477-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30477-70-x1J3yFt0hq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30477
    Bug 30477 depends on bug 30373, which changed state.
    
    Bug 30373 Summary: Rewrite UNIMARC installer data to YAML
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:22:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:22:36 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27344-70-Kbim82GXE5@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133033|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:23:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:23:07 +0000
    Subject: [Koha-bugs] [Bug 30477] Add new UNIMARC installer translation files
    In-Reply-To: <bug-30477-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30477-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30477-70-b6Cdie2dio@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30477
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
                     CC|                            |kyle at bywatersolutions.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:23:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:23:12 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27344-70-2VShcLCXZJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    --- Comment #58 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134406
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134406&action=edit
    Bug 27344: Implement Elastic's update_index_background using
    Koha::BackgroundJob
    
    This patch adds a background job submodule, UpdateElasticIndex, to deal
    with async ES index update (not the deletion).
    
    Using NYTProf (on a checkin):
    Without
    618ms, executing 35676 statements and 26355 subroutine calls in 266 source
    files and 83 string evals.
    
    With
    521ms, executing 13282 statements and 7979 subroutine calls in 195 source files
    and 26 string evals.
    
    However there are some problems with this patch:
    1. We don't want *all* the index update to be in the background_jobs
    tabtle (we could add a filter on the list view)
    2. We don't track the "progress" of the job as we are sending all the
    records to Elastic. It is okish in my opinion but it must be noted.
    
    Signed-off-by: Arthur Suzuki <arthur.suzuki at biblibre.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:23:22 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:23:22 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27344-70-konIM9PQ6S@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    --- Comment #59 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134407
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134407&action=edit
    Bug 27344: Add missing include file
    
    Signed-off-by: Arthur Suzuki <arthur.suzuki at biblibre.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:23:31 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:23:31 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27344-70-8vEcaA4PBq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    --- Comment #60 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134408
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134408&action=edit
    Bug 27344: Adapt to bug 30181 changes
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:23:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:23:41 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27344-70-lgyK3nX768@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    --- Comment #61 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134409
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134409&action=edit
    Bug 27344: Add missing imports
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:23:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:23:59 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27344-70-7RRiq1OdHy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    --- Comment #63 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134411
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134411&action=edit
    Bug 27344: Fix tests
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:24:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:24:07 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27344-70-2bMOw87ayk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    --- Comment #64 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134412
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134412&action=edit
    Bug 27344: Fix call to update_index with invalid ids
    
    Can't use an undefined value as an ARRAY reference at
    /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Indexer.pm line 121.
    
    Caught that when working on follow-up bug reports.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:23:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:23:50 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27344-70-ciV3g5SP0f@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    --- Comment #62 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134410
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134410&action=edit
    Bug 27344: Warn the error in the log
    
    Otherwise info about the failure is hidden in DB
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:24:15 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:24:15 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27344-70-EO3GTxe1IN@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    --- Comment #65 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134413
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134413&action=edit
    Bug 27344: Add error detail if something wrong happened
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:24:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:24:55 +0000
    Subject: [Koha-bugs] [Bug 30463] Authority records are indexed on the fly
    In-Reply-To: <bug-30463-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30463-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30463-70-7UlTbdqhmQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30463
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |tomascohen at gmail.com
                 Blocks|30464                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30464
    [Bug 30464] BatchUpdateAuthority task does not deal with indexation correctly
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:24:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:24:55 +0000
    Subject: [Koha-bugs] [Bug 30464] BatchUpdateAuthority task does not deal
     with indexation correctly
    In-Reply-To: <bug-30464-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30464-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30464-70-i8wlmZBK68@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30464
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|30463                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30463
    [Bug 30463] Authority records are indexed on the fly
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:25:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:25:10 +0000
    Subject: [Koha-bugs] [Bug 30464] BatchUpdateAuthority task does not deal
     with indexation correctly
    In-Reply-To: <bug-30464-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30464-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30464-70-RQvbhd8YNt@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30464
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|                            |27344
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    [Bug 27344] Implement Elastic's update_index_background using
    Koha::BackgroundJob
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:25:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:25:10 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27344-70-NdgPQDLmPP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|                            |30464
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30464
    [Bug 30464] BatchUpdateAuthority task does not deal with indexation correctly
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:25:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:25:26 +0000
    Subject: [Koha-bugs] [Bug 30512] Staff interface search results template
     error
    In-Reply-To: <bug-30512-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30512-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30512-70-cEfMLsnWJk@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
    
    --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Not applying to 21.11.x, please rebase if you think this should be backported!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:29:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:29:50 +0000
    Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on
     fresh install, but can be null with upgrade
    In-Reply-To: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27253-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27253-70-GL2RTHI1F8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Pushed to master            |Pushed to stable
             Version(s)|22.05.00                    |22.05.00,21.11.06
            released in|                            |
    
    --- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.06
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:31:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:31:26 +0000
    Subject: [Koha-bugs] [Bug 18392] Allow exporting circulation conditions as
     CSV or spreadsheet
    In-Reply-To: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18392-70-E9RSzn82D9@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Resolution|FIXED                       |---
                 Status|RESOLVED                    |REOPENED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:31:27 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:31:27 +0000
    Subject: [Koha-bugs] [Bug 30589] Allow importing circulation conditions as
     CSV or spreadsheet
    In-Reply-To: <bug-30589-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30589-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30589-70-AOItJiH33B@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30589
    Bug 30589 depends on bug 18392, which changed state.
    
    Bug 18392 Summary: Allow exporting circulation conditions as CSV or spreadsheet
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|RESOLVED                    |REOPENED
             Resolution|FIXED                       |---
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:31:37 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:31:37 +0000
    Subject: [Koha-bugs] [Bug 18392] Allow exporting circulation conditions as
     CSV or spreadsheet
    In-Reply-To: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18392-70-CK9Pfp8AVq@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|REOPENED                    |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:31:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:31:45 +0000
    Subject: [Koha-bugs] [Bug 18392] Allow exporting circulation conditions as
     CSV or spreadsheet
    In-Reply-To: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18392-70-I6WY5YaGs6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:31:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:31:58 +0000
    Subject: [Koha-bugs] [Bug 18392] Allow exporting circulation conditions as
     CSV or spreadsheet
    In-Reply-To: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18392-70-vJn0lZ1K5Z@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Passed QA
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:32:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:32:30 +0000
    Subject: [Koha-bugs] [Bug 18392] Allow exporting circulation conditions as
     CSV or spreadsheet
    In-Reply-To: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18392-70-QTbjR8Q4H8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Passed QA                   |Pushed to stable
             Version(s)|22.05.00                    |22.05.00,21.11.06
            released in|                            |
    
    --- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.06
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:32:45 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:32:45 +0000
    Subject: [Koha-bugs] [Bug 18392] Allow exporting circulation conditions as
     CSV or spreadsheet
    In-Reply-To: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-18392-70-TABw7BKlom@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392
    
    --- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Backported by request!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:33:06 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:33:06 +0000
    Subject: [Koha-bugs] [Bug 30446] Add a test for GetTagsLabels
    In-Reply-To: <bug-30446-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30446-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30446-70-2b3MqGmi8t@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30446
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
                 Status|Pushed to master            |RESOLVED
             Resolution|---                         |FIXED
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:33:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:33:56 +0000
    Subject: [Koha-bugs] [Bug 30595] update_child_to_adult.t is failing randomly
    In-Reply-To: <bug-30595-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30595-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30595-70-usXtUr0Gz8@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30595
    
    Kyle M Hall <kyle at bywatersolutions.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |kyle at bywatersolutions.com
             Version(s)|22.05.00                    |22.05.00,21.11.06
            released in|                            |
                 Status|Pushed to master            |Pushed to stable
    
    --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
    Pushed to 21.11.x for 21.11.06
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:45:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:45:55 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27344-70-GcfGFhPaBV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Keywords|                            |rel_22_05_candidate
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:50:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:50:58 +0000
    Subject: [Koha-bugs] [Bug 30360] Add helper methods to Koha::BackgroundJobs
    In-Reply-To: <bug-30360-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30360-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30360-70-XOZ2t3ng1m@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
             Depends on|29346                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    [Bug 29346] Add real-time holds queue update option
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:50:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:50:58 +0000
    Subject: [Koha-bugs] [Bug 29346] Add real-time holds queue update option
    In-Reply-To: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29346-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29346-70-Yu9VcZfjnJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Blocks|30360                       |
    
    
    Referenced Bugs:
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360
    [Bug 30360] Add helper methods to Koha::BackgroundJobs
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:58:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:58:48 +0000
    Subject: [Koha-bugs] [Bug 30360] Add helper methods to Koha::BackgroundJobs
    In-Reply-To: <bug-30360-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30360-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30360-70-ow0cAuGghY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |tomascohen at gmail.com
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:58:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:58:51 +0000
    Subject: [Koha-bugs] [Bug 30360] Add helper methods to Koha::BackgroundJobs
    In-Reply-To: <bug-30360-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30360-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30360-70-e7AHZyV93L@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132952|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:58:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:58:55 +0000
    Subject: [Koha-bugs] [Bug 30360] Add helper methods to Koha::BackgroundJobs
    In-Reply-To: <bug-30360-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30360-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30360-70-e3OL06LIzE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132953|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:59:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:59:00 +0000
    Subject: [Koha-bugs] [Bug 30360] Add helper methods to Koha::BackgroundJobs
    In-Reply-To: <bug-30360-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30360-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30360-70-gfAghteXzT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360
    
    Tomás Cohen Arazi <tomascohen at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132247|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:59:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:59:36 +0000
    Subject: [Koha-bugs] [Bug 30360] Add helper methods to Koha::BackgroundJobs
    In-Reply-To: <bug-30360-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30360-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30360-70-ttF4CcMhwQ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360
    
    --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134414
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134414&action=edit
    Bug 30360: Add helper methods to Koha::BackgroundJobs
    
    This patch adds some helper methods to ease writing background jobs, and
    also making it more consistent/solid.
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/BackgroundJob.t
    => SUCCESS: Tests pass. The methods have the expected behaviour.
    3. Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:59:41 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:59:41 +0000
    Subject: [Koha-bugs] [Bug 30360] Add helper methods to Koha::BackgroundJobs
    In-Reply-To: <bug-30360-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30360-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30360-70-aoSt8LXcsm@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360
    
    --- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134415
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134415&action=edit
    Bug 30360: Add methods for dealing with the JSON payload
    
    This patch adds high-level methods to handle the JSON payload
    (de)serialization as needed. This allows devs implementing background
    jobs to abstract themselves from the internals of the jobs handling.
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/BackgroundJob.t
    => SUCCESS: Tests pass!
    3. Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 19:59:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 17:59:46 +0000
    Subject: [Koha-bugs] [Bug 30360] Add helper methods to Koha::BackgroundJobs
    In-Reply-To: <bug-30360-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30360-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30360-70-YQiNGszfRp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360
    
    --- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
    Created attachment 134416
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134416&action=edit
    Bug 30360: Make UpdateElasticIndex use the helper methods
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 20:05:53 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 18:05:53 +0000
    Subject: [Koha-bugs] [Bug 30360] Add helper methods to Koha::BackgroundJobs
    In-Reply-To: <bug-30360-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30360-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30360-70-ukWxsmQD44@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 20:05:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 18:05:58 +0000
    Subject: [Koha-bugs] [Bug 30360] Add helper methods to Koha::BackgroundJobs
    In-Reply-To: <bug-30360-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30360-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30360-70-VoRxBN0kPH@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134414|0                           |1
            is obsolete|                            |
    
    --- Comment #10 from David Nind <david at davidnind.com> ---
    Created attachment 134417
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134417&action=edit
    Bug 30360: Add helper methods to Koha::BackgroundJobs
    
    This patch adds some helper methods to ease writing background jobs, and
    also making it more consistent/solid.
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/BackgroundJob.t
    => SUCCESS: Tests pass. The methods have the expected behaviour.
    3. Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 20:06:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 18:06:04 +0000
    Subject: [Koha-bugs] [Bug 30360] Add helper methods to Koha::BackgroundJobs
    In-Reply-To: <bug-30360-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30360-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30360-70-UUNUqkOpcl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134415|0                           |1
            is obsolete|                            |
    
    --- Comment #11 from David Nind <david at davidnind.com> ---
    Created attachment 134418
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134418&action=edit
    Bug 30360: Add methods for dealing with the JSON payload
    
    This patch adds high-level methods to handle the JSON payload
    (de)serialization as needed. This allows devs implementing background
    jobs to abstract themselves from the internals of the jobs handling.
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/BackgroundJob.t
    => SUCCESS: Tests pass!
    3. Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 20:06:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 18:06:10 +0000
    Subject: [Koha-bugs] [Bug 30360] Add helper methods to Koha::BackgroundJobs
    In-Reply-To: <bug-30360-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30360-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30360-70-fIDNtNHJ5x@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134416|0                           |1
            is obsolete|                            |
    
    --- Comment #12 from David Nind <david at davidnind.com> ---
    Created attachment 134419
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134419&action=edit
    Bug 30360: Make UpdateElasticIndex use the helper methods
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 21:18:25 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 19:18:25 +0000
    Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available
     items even if on shelf holds aren't allowed
    In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30556-70-A3Nlma2I51@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556
    
    --- Comment #4 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
    Created attachment 134420
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134420&action=edit
    Bug 30556: Fix CanBookBeReserved to return early if no borrowernumber
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 22:03:16 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 20:03:16 +0000
    Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available
     items even if on shelf holds aren't allowed
    In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30556-70-mwY7LFwwYd@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556
    
    --- Comment #5 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
    Created attachment 134421
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134421&action=edit
    Bug 30556: Fix IsAvailableForItemLevelRequest to return early
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 22:06:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 20:06:54 +0000
    Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen
    In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23919-70-fDrYOALSzc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134381|0                           |1
            is obsolete|                            |
     Attachment #134382|0                           |1
            is obsolete|                            |
     Attachment #134383|0                           |1
            is obsolete|                            |
     Attachment #134384|0                           |1
            is obsolete|                            |
     Attachment #134385|0                           |1
            is obsolete|                            |
    
    --- Comment #6 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 134422
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134422&action=edit
    Bug 23919: Add new system preference SearchWithISSNVariations
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 22:06:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 20:06:59 +0000
    Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen
    In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23919-70-XNBrlWfY6B@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919
    
    --- Comment #7 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 134423
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134423&action=edit
    Bug 23919: Zebra search by ISSN variations
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 22:07:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 20:07:03 +0000
    Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen
    In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23919-70-vvdviq1nNl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919
    
    --- Comment #8 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 134424
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134424&action=edit
    Bug 23919: Add tests for biblioItems search by ISBN and ISSN with
    
    variations (sysprefs SearchWithISBNVariations/SearchWithISSNVariations)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 22:07:08 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 20:07:08 +0000
    Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen
    In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23919-70-2zCDbsGU92@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919
    
    --- Comment #9 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 134425
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134425&action=edit
    Bug 23919: Items search by ISBN variations and ISSN variations
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 22:07:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 20:07:13 +0000
    Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen
    In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23919-70-6qfMmeFLaL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919
    
    --- Comment #10 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 134426
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134426&action=edit
    Bug 23919: Add tests for Items search by ISBN and ISSN with variations
    
    (sysprefs SearchWithISBNVariations/SearchWithISSNVariations)
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 22:08:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 20:08:05 +0000
    Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
     too
    In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28269-70-DzS0gIAtxL@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269
    
    Slava Shishkin <slavashishkin at gmail.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134386|0                           |1
            is obsolete|                            |
     Attachment #134387|0                           |1
            is obsolete|                            |
    
    --- Comment #14 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 134427
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134427&action=edit
    Bug 28269: Add feature to search Acquisitions Orders by ISSN
    
    - add search form field for ISSN number
    - add search logic including ISSN variations search
      if SearchWithISSNVariations preference is set
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 22:08:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 20:08:10 +0000
    Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
     too
    In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-28269-70-XIWClXpOoK@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269
    
    --- Comment #15 from Slava Shishkin <slavashishkin at gmail.com> ---
    Created attachment 134428
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134428&action=edit
    Bug 28269: Add tests for Acquisitions Orders search by ISSN
    
    also with SearchWithISSNVariations on and off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 22:38:11 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 20:38:11 +0000
    Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available
     items even if on shelf holds aren't allowed
    In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30556-70-QhpDbajNUE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556
    
    --- Comment #6 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
    The last 2 patches are not directly related to this bug but they should have
    been there in the first place to not cause any errors when borrowernumber or
    patron are undefined.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Fri Apr 29 23:51:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 21:51:24 +0000
    Subject: [Koha-bugs] [Bug 26370] Add ability to disable demagnetizing items
     via SIP2 based on patron categories
    In-Reply-To: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26370-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26370-70-YzCV3ceqPV@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370
    
    Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                Summary|Add ability to disable      |Add ability to disable
                       |demagnetizing items via     |demagnetizing items via
                       |SIP2 for arbitrary patron   |SIP2 based on patron
                       |categories                  |categories
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 01:26:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Fri, 29 Apr 2022 23:26:07 +0000
    Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
     contents into notices tool
    In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-3150-70-sJSUGd4vpX@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Failed QA
    
    --- Comment #88 from David Nind <david at davidnind.com> ---
    Hi Aleisha.
    
    The same as Christian in comment #81, nothing is showing up for me in the
    message_queue table (using koha-testing-docker) as per step 7.
    
    Email address set for the account used (koha in this case) and I also added a
    valid email address for KohaAdminEmailAddress.
    
    I also tested with the sending of emails enabled,* and nothing came through
    (they did come through before applying the patch).
    
    * To enable basic email sending by adding this to koha-conf.xml (user_name =
    gmail address, password = app password set up for your account):
    
    <smtp_server>
        <host>smtp.gmail.com</host>
        <port>587</port>
        <timeout>5</timeout>
        <ssl_mode>STARTTLS</ssl_mode>
        <user_name>youraddress at gmail.com</user_name>
        <password>yourpassword</password>
        <debug>1</debug>
     </smtp_server>
    
    David
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 02:59:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 00:59:07 +0000
    Subject: [Koha-bugs] [Bug 30504] Value builder for UNIMARC field 181
    In-Reply-To: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30504-70-nQmqqt33C6@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30504
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 02:59:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 00:59:12 +0000
    Subject: [Koha-bugs] [Bug 30504] Value builder for UNIMARC field 181
    In-Reply-To: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30504-70-RPwYha4SRY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30504
    
    --- Comment #2 from David Nind <david at davidnind.com> ---
    Created attachment 134429
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134429&action=edit
    MT 35334: Value builder for field 181
    
    This patch provides values builders for the subfields $a, $b, $c and $2. Those
    are unimarc official codes who help to identify the kind of items
    
    Test plan:
    1)Go to Home > Cataloging > New record
    2)Section 1 - field 181 : it contains subfields $a, $b, $c & $2
    3)Inputs are writable but notice that no plugins are suggested
    4)Apply patch and repeat 1) to 3)
    5)Values builders plugins are available for $a, $b, $c and $2
    
    https://bugs.koha-community.org/show_bug.cgi?id=30504
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 03:09:29 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 01:09:29 +0000
    Subject: [Koha-bugs] [Bug 30504] Value builder for UNIMARC field 181
    In-Reply-To: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30504-70-vBf9lr6dIl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30504
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |david at davidnind.com
    
    --- Comment #3 from David Nind <david at davidnind.com> ---
    Testing notes (using koha-testing-docker on master):
    
    - Click field 181's title to display subfields $b and $2 (their visibility is
    set to collapsed for the default framework)
    
    - Noted that $c has an authorised value list by default: I assume that
    libraries will remove this link if they want to use the value builder plugin
    (the authorised value list seems to take priority if it and value builder
    plugin are both selected)
    
    - I didn't try editing or creating a record a I am not familiar with UNIMARC
    and there seems to be a lot of required fields!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 03:15:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 01:15:36 +0000
    Subject: [Koha-bugs] [Bug 30504] Value builder for UNIMARC field 181
    In-Reply-To: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30504-70-MRY7waVOv4@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30504
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
      Text to go in the|                            |This enhancement for
          release notes|                            |UNIMARC field 181 adds
                       |                            |value builders for
                       |                            |subfields $a, $b, $c, and
                       |                            |$2. These are based on the
                       |                            |official UNIMARC codes.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 03:25:49 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 01:25:49 +0000
    Subject: [Koha-bugs] [Bug 30506] Value builder for UNIMARC field 182
    In-Reply-To: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30506-70-FexWsy1yJv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 03:25:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 01:25:54 +0000
    Subject: [Koha-bugs] [Bug 30506] Value builder for UNIMARC field 182
    In-Reply-To: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30506-70-GZ2PtQn5dA@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506
    
    --- Comment #2 from David Nind <david at davidnind.com> ---
    Created attachment 134430
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134430&action=edit
    MT 35336: Value builder for field 182
    
    This patch provides values builders for the subfields $a, $c and $2. Those are
    unimarc official codes who help to
    identify the kind of items
    Test plan:
    1)Go to Home > Cataloging > New record
    2)Section 1 - field 182 : it contains subfields $a, $c & $2
    3)Inputs are writable but notice that no plugins are suggested
    4)Apply patch and repeat 1) to 3)
    5)Values builders plugins are available for $a, $c and $2
    
    https://bugs.koha-community.org/show_bug.cgi?id=30506
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 03:30:09 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 01:30:09 +0000
    Subject: [Koha-bugs] [Bug 30506] Value builder for UNIMARC field 182
    In-Reply-To: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30506-70-7e60uliUhP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |david at davidnind.com
    
    --- Comment #3 from David Nind <david at davidnind.com> ---
    Testing notes (using koha-testing-docker on master):
    
    - Click field 182's title to display subfield $2 (their visibility is set to
    collapsed for the default framework)
    
    - Noted that subfields $a and $c have an authorised value list by default which
    need unlinking for the new value builders to work: I assume that libraries will
    remove these links if they want to use the value builder plugins (the
    authorised value list takes priority if both the authorised value list and the
    value builder plugin are both selected)
    
    - I didn't try editing or creating a record as I am not familiar with UNIMARC
    and there seems to be a lot of required fields!
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 03:31:10 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 01:31:10 +0000
    Subject: [Koha-bugs] [Bug 30506] Value builder for UNIMARC field 182
    In-Reply-To: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30506-70-J1lvLFfzGp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
      Text to go in the|                            |This enhancement for
          release notes|                            |UNIMARC field 182 adds
                       |                            |value builders for
                       |                            |subfields $a, $c, and $2.
                       |                            |These are based on the
                       |                            |official UNIMARC codes.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 04:07:36 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 02:07:36 +0000
    Subject: [Koha-bugs] [Bug 30504] Value builder for UNIMARC field 181
    In-Reply-To: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30504-70-xjKUejwGiB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30504
    
    --- Comment #4 from David Nind <david at davidnind.com> ---
    I am not sure what happened when I signed off the patch. 
    
    The original patch is listed and there is a new patch starting with MT 35334...
    
    I did my normal:
    - git so 1
    - git bz attach -e 30504 HEAD
    
    I'm not sure how to fix this - I'm assuming it has something to do with how the
    patch is formatted.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 04:08:17 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 02:08:17 +0000
    Subject: [Koha-bugs] [Bug 30506] Value builder for UNIMARC field 182
    In-Reply-To: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30506-70-JehjsJ3oAz@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506
    
    --- Comment #4 from David Nind <david at davidnind.com> ---
    I am not sure what happened when I signed off the patch. 
    
    The original patch is listed and there is a new patch starting with MT 35336...
    
    I did my normal:
    - git so 1
    - git bz attach -e 30506 HEAD
    
    I'm not sure how to fix this - I'm assuming it has something to do with how the
    patch is formatted.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 04:11:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 02:11:48 +0000
    Subject: [Koha-bugs] [Bug 30507] Value builder for UNIMARC field 183
    In-Reply-To: <bug-30507-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30507-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30507-70-EJyxYVy47t@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30507
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |david at davidnind.com
                 Status|Needs Signoff               |Failed QA
    
    --- Comment #2 from David Nind <david at davidnind.com> ---
    Hi Jérémy.
    
    There is no value builder shown when editing the subfield for $2 -
    unimarc_field_183-2.pl.
    
    Also, it looks like the patch (looking at the diff) also includes the changes
    for field 182.
    
    With the value builder for the $a subfield, when I select a value it also
    populates the $2 subfield with a value 'RDAcarrier'.
    
    David
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 04:48:24 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 02:48:24 +0000
    Subject: [Koha-bugs] [Bug 30127] By default show pending suggestions tab
    In-Reply-To: <bug-30127-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30127-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30127-70-rE8rDyVHni@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Failed QA                   |Needs Signoff
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 04:48:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 02:48:28 +0000
    Subject: [Koha-bugs] [Bug 30127] By default show pending suggestions tab
    In-Reply-To: <bug-30127-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30127-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30127-70-9LguoIWNDZ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #130808|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Created attachment 134431
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134431&action=edit
    Bug 30127: By default show pending suggestions tab
    
    Pending suggestions are the most important ones in links pointing to
    suggestions.
    This tab should be the default one, like did Bug 7875
    
    Changing order in perl code seems really difficult because it is a
    generic code using GetDistinctValues()
    
    Test plan :
    1) Create some suggetions, accept some of them
    2) In staff interface, click on 'More > Suggestions'
    => You see pending tab selected
    3) In left menu, click on 'Suggestions' under 'Late orders'
    => You see pending tab selected
    4) In left menu, use a filter, then click on '[clear]'
    => You see pending tab selected
    5) Create a suggestion, click on 'cancel'
    => You see pending tab selected
    6) Create a suggestion, click on 'Suggestions' in breadcrumbs
    => You see pending tab selected
    7) Edit an existing suggestion, click on '<< Back to suggestions'
    => You see pending tab selected
    8) Create a suggestion, click on 'Submit your suggestion'
    => You see pending tab selected
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 04:51:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 02:51:21 +0000
    Subject: [Koha-bugs] [Bug 30127] By default show pending suggestions tab
    In-Reply-To: <bug-30127-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30127-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30127-70-OG9KppwC9r@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127
    
    --- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    I've changed how I do the fix, changing directly the perl so that pending is
    always the first tab.
    
    And added step 8 to test plan
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 05:00:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 03:00:59 +0000
    Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search
     creates UX inconsistency
    In-Reply-To: <bug-26247-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26247-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26247-70-kmd3uGppwa@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Severity|minor                       |major
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 05:15:23 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 03:15:23 +0000
    Subject: [Koha-bugs] [Bug 29434] In UNIMARC instances,
     the authority finder uses MARC21 relationship codes
    In-Reply-To: <bug-29434-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29434-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29434-70-UfyCY6RuDi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |david at davidnind.com
    
    --- Comment #6 from David Nind <david at davidnind.com> ---
    Hi Andreas.
    
    I'm not familiar with UNIMARC, but I would like to test this bug.
    
    For step 1, how do I set things up so I can "launch
    authorities/auth_finder.pl"? 
    - Are there any fields that have the tag editor already enabled?
    - Do I need to edit the authority structure (Administration > Catalog >
    Authority types)?
    - Where does the 'Special relationship:' dropdown menu appear?
    - I assume I need to enable the AuthDisplayHierarchy system preference.
    
    I'm using koha-testing-docker and have a UNIMARC instance with the default
    sample data. Is there an existing authority record that you know of in the
    sample data with this already setup?
    
    Apologies for such a basic question!
    
    David
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 05:17:58 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 03:17:58 +0000
    Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search
     creates UX inconsistency
    In-Reply-To: <bug-26247-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-26247-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-26247-70-RGBltaplAO@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247
    
    --- Comment #27 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    Hi,
    
    You can try empying directly after page loaded :
    
    $(document).ready(function() {
      $("#header_search #catalog_search input[name='q']").val("");
    });
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 06:09:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 04:09:30 +0000
    Subject: [Koha-bugs] [Bug 29980] Validate ISBN when cataloguing
     bibliographic records
    In-Reply-To: <bug-29980-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29980-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29980-70-RG2dVP9n9u@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29980
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 06:09:35 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 04:09:35 +0000
    Subject: [Koha-bugs] [Bug 29980] Validate ISBN when cataloguing
     bibliographic records
    In-Reply-To: <bug-29980-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29980-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29980-70-ajFrt9ar7z@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29980
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #129984|0                           |1
            is obsolete|                            |
    
    --- Comment #11 from David Nind <david at davidnind.com> ---
    Created attachment 134432
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134432&action=edit
    Bug 29980: Add ValidateISBN system preference
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 06:09:40 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 04:09:40 +0000
    Subject: [Koha-bugs] [Bug 29980] Validate ISBN when cataloguing
     bibliographic records
    In-Reply-To: <bug-29980-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29980-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29980-70-RF8eyqDxUu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29980
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #129985|0                           |1
            is obsolete|                            |
    
    --- Comment #12 from David Nind <david at davidnind.com> ---
    Created attachment 134433
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134433&action=edit
    Bug 29980: Validate ISBNs when saving biblio records
    
    This enhancement adds a new system preference ValidateISBN. When
    enabled, Koha will apply a valid checksum algorithm to ISBN fields
    (020$a for MARC21 and 010$a for UNIMARC) to validate the ISBN when
    cataloguing bibliographic records. The user will be prompted to fix
    their invalid ISBN, or have the option to bypass the ISBN check and
    save anyway. This will work for both 10-digit and 13-digit ISBNs.
    
    This patch also cleans up some bad indentation in
    cataloguing/addbiblio.pl.
    
    To test:
    1) Apply patch, update database.
    2) Go to Koha administration -> global system preferences -> cataloguing
    tab -> Record structure heading. Note the new ValidateISBN system
    preference. It should be disabled by default. Leave it disabled.
    3) Set marcflavour system preference to MARC21.
    4) In a new tab, go to add a new biblio record, or edit an existing one.
    5) Find the 020$a field and input an incorrect ISBN. Save the record and
    confirm the ISBN is not validated and does not block saving the record.
    6) Go back to your system preferences tab. Set the ValidateISBN tab to
    "Validate" to enable it.
    7) Go back to your cataloguing tab. Edit the record. Save the record
    without making any changes.
    8) Confirm an Invalid ISBN error pops up, blocking you from saving.
    Click Continue to bypass the ISBN check and save the record with the
    invalid ISBN.
    9) Edit the record again. Save the record without making any changes.
    10) When the Invalid ISBN error pops up, this time fix the invalid ISBN,
    then save the record again. Confirm you are able to save the record.
    11) Go back to the system preferences tab and change the marcflavour
    system preference to UNIMARC. Repeat the above steps, but this time use
    the 010$a field instead of 020$a for ISBN.
    
    Sponsored-by: Education Services Australia SCIS
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 06:32:21 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 04:32:21 +0000
    Subject: [Koha-bugs] [Bug 29980] Validate ISBN when cataloguing
     bibliographic records
    In-Reply-To: <bug-29980-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29980-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29980-70-Mshru9sCdl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29980
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |david at davidnind.com
    
    --- Comment #13 from David Nind <david at davidnind.com> ---
    Created attachment 134434
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134434&action=edit
    Screenshot - placement of error messages when other errors
    
    Testing notes (using koha-testing-docker):
    
    - I have tested in both MARC21 and UNIMARC environments.
    
    - When using koha-testing-docker you can't just change the MARC flavour. Before
    starting it up you need to change KOHA_MARC_FLAVOUR=marc21 in your .env file to
    KOHA_MARC_FLAVOUR=unimarc ; to change back to a MARC21 environment shut
    everything down (CTRL-C and then kd), and change it back to marc21. It is also
    possible to get a UNIMARC installation using the sandboxes - change the MARC
    flavour when you create the sandbox (see
    https://wiki.koha-community.org/wiki/Sandboxes). Basically, I found that I had
    to test in a MARC21 environment, then set up fresh in a UNIMARC one.
    
    - One thing I noted is that if there are other errors, they display ABOVE the
    title - see the screenshot. It may pay to check with Owen about this. To me the
    errors should be below the title, like happens with the invalid ISBN error
    message. So I don't think that is an issue for this bug.
    
    - The other thing I noted was that if a record is saved with an invalid ISBN
    and you then 1) edit it again 2) introduce other errors (such as deleting the
    942$c Koha item type) 3) save, the invalid ISBN error doesn't display until
    after the other errors are resolved.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 06:34:04 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 04:34:04 +0000
    Subject: [Koha-bugs] [Bug 29711] Release date not passed as ISO to about.tt
    In-Reply-To: <bug-29711-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29711-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29711-70-oAFmIiCo0q@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29711
    
    Fridolin Somers <fridolin.somers at biblibre.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Failed QA
                     CC|                            |fridolin.somers at biblibre.co
                       |                            |m
    
    --- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
    (In reply to David Nind from comment #4)
    > I can't replicate this on master and using KTD.
    Same for me.
    And I dont see where this date is used.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 10:27:00 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 08:27:00 +0000
    Subject: [Koha-bugs] [Bug 30127] By default show pending suggestions tab
    In-Reply-To: <bug-30127-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30127-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30127-70-lxaZFojSjy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Failed QA
                     CC|                            |david at davidnind.com
    
    --- Comment #5 from David Nind <david at davidnind.com> ---
    For me, after applying the patch and adding some suggestions, I no longer get
    any tabs displaying for suggestions by status (tried in Firefox and Google
    Chrome).
    
    I can post a screenshot if that doesn't make senses.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 18:16:12 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 16:16:12 +0000
    Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths
    In-Reply-To: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-19318-70-OEx5cJNIMu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Large patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 18:17:55 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 16:17:55 +0000
    Subject: [Koha-bugs] [Bug 29623] Cache circulation rules
    In-Reply-To: <bug-29623-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29623-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29623-70-xk5npQ6F4K@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 18:28:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 16:28:48 +0000
    Subject: [Koha-bugs] [Bug 30639] Patron search does not split search terms
    In-Reply-To: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30639-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30639-70-H6seWH5gOT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 18:29:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 16:29:50 +0000
    Subject: [Koha-bugs] [Bug 29755] SIP2 code does not correctly handle
     NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees
    In-Reply-To: <bug-29755-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29755-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29755-70-eE7i0lE6SP@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 18:30:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 16:30:52 +0000
    Subject: [Koha-bugs] [Bug 30167] Return soonest renewal date when
     CanBookBeRenewed returns %too_soon
    In-Reply-To: <bug-30167-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30167-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30167-70-dzaVk2Qg6m@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30167
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Medium patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 18:34:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 16:34:52 +0000
    Subject: [Koha-bugs] [Bug 30387] IndependentBranches allows users to change
     libraries when they should not be able to
    In-Reply-To: <bug-30387-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30387-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30387-70-3Os2qaBGKF@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30387
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 18:36:28 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 16:36:28 +0000
    Subject: [Koha-bugs] [Bug 30611] Add ability to send passwordreseturl from
     the staff client
    In-Reply-To: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30611-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30611-70-e7QbjLJAof@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 19:05:19 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 17:05:19 +0000
    Subject: [Koha-bugs] [Bug 30467] BatchDeleteItem task does not deal with
     indexation correctly
    In-Reply-To: <bug-30467-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30467-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30467-70-fuaEpawIwy@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30467
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Trivial patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 19:06:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 17:06:07 +0000
    Subject: [Koha-bugs] [Bug 30459] BatchDeleteAuthority task does not deal
     with indexation correctly
    In-Reply-To: <bug-30459-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30459-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30459-70-fmhxO8a5NM@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30459
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 19:06:39 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 17:06:39 +0000
    Subject: [Koha-bugs] [Bug 30460] BatchDeleteBiblio task does not deal with
     indexation correctly
    In-Reply-To: <bug-30460-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30460-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30460-70-LNrNTXOt4O@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30460
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 19:07:32 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 17:07:32 +0000
    Subject: [Koha-bugs] [Bug 30465] BatchUpdateBiblio task does not deal with
     indexation correctly
    In-Reply-To: <bug-30465-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30465-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30465-70-4eJndUyvuB@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30465
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 19:08:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 17:08:18 +0000
    Subject: [Koha-bugs] [Bug 30464] BatchUpdateAuthority task does not deal
     with indexation correctly
    In-Reply-To: <bug-30464-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30464-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30464-70-kDNdSUxYF1@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30464
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 19:09:26 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 17:09:26 +0000
    Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background
     using Koha::BackgroundJob
    In-Reply-To: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-27344-70-COKBRPJNIi@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Medium patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 19:11:13 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 17:11:13 +0000
    Subject: [Koha-bugs] [Bug 30504] Value builder for UNIMARC field 181
    In-Reply-To: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30504-70-EYpC6RzoQe@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30504
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Large patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 19:16:42 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 17:16:42 +0000
    Subject: [Koha-bugs] [Bug 30504] Value builder for UNIMARC field 181
    In-Reply-To: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30504-70-9gBfPgiRlY@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30504
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |victor at tuxayo.net
     Attachment #133150|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 19:19:05 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 17:19:05 +0000
    Subject: [Koha-bugs] [Bug 30504] Value builder for UNIMARC field 181
    In-Reply-To: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30504-70-DeqmoETfLu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30504
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Failed QA
    
    --- Comment #5 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Jérémy: On your attachment on comment 1 when clicking on details, we can see in
    the patch content that the commit has the wrong ticket number. Even if in
    bugzilla the attachment has the right title.
    
    You need to do git commit --amend to change the commit message to have the
    right ticket number. (you need to apply the patch from here to have David's
    version to keep their signoff line)
    
    I marked as obsolete the oldest attachment here so only the one signed off by
    David remains.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 19:21:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 17:21:59 +0000
    Subject: [Koha-bugs] [Bug 30506] Value builder for UNIMARC field 182
    In-Reply-To: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30506-70-Hlq39DD67J@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30504
       Patch complexity|---                         |Medium patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 19:21:59 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 17:21:59 +0000
    Subject: [Koha-bugs] [Bug 30504] Value builder for UNIMARC field 181
    In-Reply-To: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30504-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30504-70-n2s0JZhPT0@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30504
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               See Also|                            |https://bugs.koha-community
                       |                            |.org/bugzilla3/show_bug.cgi
                       |                            |?id=30506
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 19:22:50 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 17:22:50 +0000
    Subject: [Koha-bugs] [Bug 30506] Value builder for UNIMARC field 182
    In-Reply-To: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30506-70-Cz3yzM3PXC@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Signed Off                  |Failed QA
                     CC|                            |victor at tuxayo.net
    
    --- Comment #5 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    Same issue with the commit name as in bug 30504 comment 5
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 19:23:07 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 17:23:07 +0000
    Subject: [Koha-bugs] [Bug 30506] Value builder for UNIMARC field 182
    In-Reply-To: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30506-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30506-70-nqSs4ZIm0T@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #133151|0                           |1
            is obsolete|                            |
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 19:26:54 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 17:26:54 +0000
    Subject: [Koha-bugs] [Bug 29980] Validate ISBN when cataloguing
     bibliographic records
    In-Reply-To: <bug-29980-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-29980-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-29980-70-IWUzOdtJmv@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29980
    
    Victor Grousset/tuxayo <victor at tuxayo.net> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
       Patch complexity|---                         |Small patch
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 20:23:43 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 18:23:43 +0000
    Subject: [Koha-bugs] [Bug 23014] Searching In Acquisitions
    In-Reply-To: <bug-23014-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-23014-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-23014-70-orLPaSxQbE@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23014
    
    sushant <sushant at mail.jnu.ac.in> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
               Priority|P5 - low                    |P1 - high
                     CC|                            |sushant at mail.jnu.ac.in
    
    --- Comment #1 from sushant <sushant at mail.jnu.ac.in> ---
    In Koha version 18.05 the following error appears while adding, searching a
    vendor in acquisition module
    
    can't use an undefined value as an ARRAY reference at
    > > /usr/lib/x86_64-linux-gnu/perl5/5.22/DBI.pm line 2083.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 22:35:30 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 20:35:30 +0000
    Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying
     types in put mapping requests is deprecated (incompatible with 7)
    In-Reply-To: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-25669-70-TypMz2DDmp@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669
    
    --- Comment #30 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
    For the sake of simplicity and unblocking this, is there any objection going
    the way of supporting just ES 6 and ES 7 without a version check?
    And if someone needs support for the completely non-libre ES 8 they would
    continue with the more complex solution to have a wide version support. IMHO ES
    8 has much less priority so no need to be proactive if it gets us to stall.
    
    I lost track about the patches, is the right one (assuming going with above
    proposal) this one?: "Bug 25669: [alternate] Use include_type_name parameter in
    ES calls"
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 23:05:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 21:05:46 +0000
    Subject: [Koha-bugs] [Bug 30354] AUTO_RENEWALS_DGST notices are not
     generated if patron set to receive notice via SMS and no SMS notice defined
    In-Reply-To: <bug-30354-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30354-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30354-70-UExOBgJ9Go@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30354
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 23:05:51 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 21:05:51 +0000
    Subject: [Koha-bugs] [Bug 30354] AUTO_RENEWALS_DGST notices are not
     generated if patron set to receive notice via SMS and no SMS notice defined
    In-Reply-To: <bug-30354-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30354-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30354-70-VMgzsfFtqu@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30354
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #132180|0                           |1
            is obsolete|                            |
    
    --- Comment #3 from David Nind <david at davidnind.com> ---
    Created attachment 134435
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134435&action=edit
    Bug 30354: Don't assign warn as letter
    
    TO test:
    1 - Check out an item marked for autop renewal to a patron and make it overdue
    2 - Set system preference AutoRenewalNotices to follow messaging prefs
    3 - set that borrower to receive both email and SMS AUTO_RENEWALS_DGST
    4 - confirm your AUTO_RENEWALS_DGST does not have SMS content but does have
    email
    5 - run the auto_renew cron
    6 - item is renewed, but error from cron, and cron dies:
    
    No circulation AUTO_RENEWALS_DGST letter transported by sms at
    /kohadevbox/koha/C4/Letters.pm line 583.
    no letter of type 'AUTO_RENEWALS_DGST' found for borrowernumber 5. Please see
    sample_notices.sql at misc/cronjobs/automatic_renewals.pl line 305.
    Can't use string ("1") as a HASH ref while "strict refs" in use at
    /kohadevbox/koha/C4/Letters.pm line 898.
    
    7 - Apply patch
    8 - Make item eligible for auto renewal agian (or checkin/checkout)
    9 - Run the cron
    10 - There is still 2 warn, but cron does not die:
    
    No circulation AUTO_RENEWALS_DGST letter transported by sms at
    /kohadevbox/koha/C4/Letters.pm line 583.
    no letter of type 'AUTO_RENEWALS_DGST' found for borrowernumber 5. Please see
    sample_notices.sql at misc/cronjobs/    automatic_renewals.pl line 305.
    
    11 - Patron receives email and item is renewed
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 23:25:56 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 21:25:56 +0000
    Subject: [Koha-bugs] [Bug 30354] AUTO_RENEWALS_DGST notices are not
     generated if patron set to receive notice via SMS and no SMS notice defined
    In-Reply-To: <bug-30354-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30354-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30354-70-wr3F7Ut0iT@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30354
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |david at davidnind.com
    
    --- Comment #4 from David Nind <david at davidnind.com> ---
    Testing notes (using koha-testing-docker):
    
    - To set things up:
      . Changed the circulation rule so that for All All, Automatic renewal is set
    to yes
      . Added an email address to the patron used to check items out to
    (someone at example.com) (not sure that this is required for this to work)
      . To get the SMS column to appear under patron messaging preferences, set the
     SMSSendDriver system preference to Email (otherwise the error message isn't
    generated when the cron script is run)
    
    - To run the cron job: cd misc/cronjobs, perl automatic_renewals.pl -c -d -v
    
    - To check whether a message is "sent" or not, check under the notices section
    for the patron: before the patch is applied there should be no notice listed,
    even though the item is renewed; after the patch is applied the item is renewed
    and there is a pending notice
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 23:39:46 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 21:39:46 +0000
    Subject: [Koha-bugs] [Bug 30354] AUTO_RENEWALS_DGST notices are not
     generated if patron set to receive notice via SMS and no SMS notice defined
    In-Reply-To: <bug-30354-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30354-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30354-70-K0imVW3ZWl@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30354
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
      Text to go in the|                            |If an SMS notice is not
          release notes|                            |defined for
                       |                            |AUTO_RENEWALS_DGST and a
                       |                            |patron has selected to
                       |                            |receive a digest
                       |                            |notification by SMS when
                       |                            |items are automatically
                       |                            |renewed, it doesn't
                       |                            |generate a notice (even
                       |                            |though the item(s) is
                       |                            |renewed). This fixes the
                       |                            |issue so that an email
                       |                            |message is generated.
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 23:51:48 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 21:51:48 +0000
    Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available
     items even if on shelf holds aren't allowed
    In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30556-70-DH8EAIb7Yc@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                 Status|Needs Signoff               |Signed Off
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 23:51:52 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 21:51:52 +0000
    Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available
     items even if on shelf holds aren't allowed
    In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30556-70-YRDs2pepdJ@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134172|0                           |1
            is obsolete|                            |
    
    --- Comment #7 from David Nind <david at davidnind.com> ---
    Created attachment 134436
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134436&action=edit
    Bug 30556: Place hold button doesn't show when not allowed
    
    When On shelf holds allowed is on "If all unavailable", the Place hold button
    is not shown.
    
    To test:
    
    1. Create a circulation rule with on shelf holds set to "If all unavailable"
    2. Create or modify a record to match the items itype to the circulation rule
    3. Use a patron matching the circ rule category to log into the opac
    4. Look for the record
    5. Notice that the Place hold button is there, even thought it's not allowed
    6. Apply the patch.
    7. The button is not there.
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are watching all bug changes.
    You are the assignee for the bug.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 23:51:57 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 21:51:57 +0000
    Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available
     items even if on shelf holds aren't allowed
    In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30556-70-7vQbW0X1h3@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134420|0                           |1
            is obsolete|                            |
    
    --- Comment #8 from David Nind <david at davidnind.com> ---
    Created attachment 134437
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134437&action=edit
    Bug 30556: Fix CanBookBeReserved to return early if no borrowernumber
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 23:52:03 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 21:52:03 +0000
    Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available
     items even if on shelf holds aren't allowed
    In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30556-70-scGtgJuCcU@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
     Attachment #134421|0                           |1
            is obsolete|                            |
    
    --- Comment #9 from David Nind <david at davidnind.com> ---
    Created attachment 134438
      -->
    https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134438&action=edit
    Bug 30556: Fix IsAvailableForItemLevelRequest to return early
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.
    
    From bugzilla-daemon at bugs.koha-community.org  Sat Apr 30 23:58:18 2022
    From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
    Date: Sat, 30 Apr 2022 21:58:18 +0000
    Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available
     items even if on shelf holds aren't allowed
    In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
    References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
    Message-ID: <bug-30556-70-hBdKQwci5m@https.bugs.koha-community.org/bugzilla3/>
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556
    
    David Nind <david at davidnind.com> changed:
    
               What    |Removed                     |Added
    ----------------------------------------------------------------------------
                     CC|                            |david at davidnind.com
      Text to go in the|                            |This fixes the OPAC details
          release notes|                            |page for a record so that
                       |                            |the "Place hold" button is
                       |                            |not shown when on shelf
                       |                            |holds are not allowed (when
                       |                            |the "On shelf holds
                       |                            |allowed" circulation and
                       |                            |fines rule is set to either
                       |                            |"If any unavailable" or "If
                       |                            |all unavailable").
    
    -- 
    You are receiving this mail because:
    You are the assignee for the bug.
    You are watching all bug changes.