[Koha-bugs] [Bug 30391] Bad JS in IntranetUserJS can break the staff client

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sat Apr 2 13:32:31 CEST 2022


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30391

Adam Styles <mrfawn at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrfawn at gmail.com

--- Comment #1 from Adam Styles <mrfawn at gmail.com> ---
Hi Magnus,

The intranet JS logic is injected into all Staff intranet pages on page load.
This means that any JS added to the Intranet JS text area can possibly disrupt
existing Koha JS and related core functionality.

>From my experience, using Intranet JS to inject some hot fixed for Koha
Intranet staff UI can be useful if used sparingly. I generally run regression
tests for my JS added source via a local vanilla test version of Koha, to test
for any potential functionality friction, before apply to live/PROD.

A possible long term fix for this potentially disruptive experience, could be
to add micro regression tests to run on save of Intranet JS data input field.
This would offer the very core testing for the possible logic blocks to things
like JQUERY, which is used to power many of the koha UI front end behaviors.

IMHO.

Thoughts?

Adam.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list