[Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=23681

--- Comment #39 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Emmi, 

thanks for the rebase, starting to dig a little deeper into this now:

1) DelDebarmentsAfterPayment 

According to coding guidelines the methods in Koha namespace should always be
snake case.

2) Terminology

debarment --> restriction

In general, and that possibly applies to above as well, we should use the term
"restrictions". See: bug 5268 for an explanation.

borrower --> patron

I know you can't change all spots as the table is called borrowers_debarments,
but I think it would be good to change where possible.

Example:
Lift these debarments after Borrower has paid their charges >
Lift these restrictions after a patron has paid their charges

See also: https://wiki.koha-community.org/wiki/Terminology

3) Functionality

I recently reviewed bug

-- 
You are receiving this mail because:
You are watching all bug changes.