[Koha-bugs] [Bug 30225] Rewrite cities admin view in Vue

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30225

--- Comment #13 from David Cook <dcook at prosentient.com.au> ---
My test plan:
1. yarn install
2. yarn build_js
3. http://localhost:8081/cgi-bin/koha/admin/cities.pl

UI Feedback:
1. Overall, the UI is looking pretty good!
2. On http://localhost:8081/cgi-bin/koha/admin/cities.pl, the "Loading..." word
should probably be in the centre, so that it's a smoother transition to "There
are no cities defined"
3. Adding a new city, the HTML could be styled more nicely (shorter input
boxes, input boxes next to labels - so they're not as disjointed, maybe leaving
off "City" from all the placeholders), but it works. 
4. The datatable on http://localhost:8081/cgi-bin/koha/admin/cities.pl looks
pretty good and the filters work
5. However, the "City created" message hangs around too long. It still shows
while I'm interacting with the data table, and that feels awkward.
6. When I click on "Edit", the template momentarily says "New city" before
switching to "Edit city", which is jarring. I don't know what's happening in
the code, but an easy workaround would be to hide the form with CSS until after
it's fully rendered.
7. Delete city works, although it could also be styled more nicely.

In summary, I think the functionality is all there, but it just needs some
aesthetic polishing I think.

Code Feedback:
1. I'm not familiar with Vue 3, so I think I'll need to study it more. 
2. I think we could probably remove more of cities.tt if I understand correctly
since I don't think it's used anymore. 
3. This would be a good candidate for Bug 30289 I think. Could use the WRAPPER
to create the bulk of the page, and then have the Vue app in the main
section...
4. I like the idea of changing from
http://localhost:8081/cgi-bin/koha/admin/cities.pl to something like
http://localhost:8081/cgi-bin/koha/admin#cities and then using a router 
5. While I don't know Vue 3, I keep thinking we should be able to create more
generic CRUD templates. I think one of the great downsides of Koha at the
moment is having too many different CRUD forms. This looks interesting:
https://vuejsdevelopers.com/2017/06/11/vue-js-extending-components/

In summary, I think this is on the right track, but I think it needs more
polishing as well. 

I could have a crack at making some more generic components... although I'm not
sure when...

-- 
You are receiving this mail because:
You are watching all bug changes.