[Koha-bugs] [Bug 30536] New: Embeds should be defined in a single place

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Apr 13 22:27:06 CEST 2022


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536

            Bug ID: 30536
           Summary: Embeds should be defined in a single place
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
                CC: tomascohen at gmail.com

Right now, our specs need two places:

(1) path top level x-koha-embed entry
(2) path header parameters definition for x-koha-embed as an enum

The first one was the right one in the first place, but JSON::Validator didn't
manage that correctly (reliably I'd say). So we used it as in (1).

Bug 29810 added (2), which is great and correct, but our 'stash_embed' helper
[1] called from Koha/REST/V1/Auth.pm is relying on (1) to build the allow-list
for embeds.

So we need to have both, and we should fix it.

[1] Koha/REST/Plugin/Query.pm:237

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list