[Koha-bugs] [Bug 28998] Encrypt borrowers.secret

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #36 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This all makes a lot of sense to me.. I can see a case in the future for a
distinct table, but I'm not aware of an allow-list on reports yet so that can
come later in my opinion.

I wonder slightly about the accessor names in Koha::Patron.. we could just
silently encrypt/descrypt and continue to rely on 'secret' as our accessor
name.. but that's not a big issue.  I also wonder if the field in general
should be clearer.. this secret us specific to this form of on time password
for 2FA.. calling is 'secret' is very generic.. but again.. that's from the
earlier bug.

As is it.. PQA

-- 
You are receiving this mail because:
You are watching all bug changes.