[Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret, send register notice

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894

--- Comment #30 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #29)
> (In reply to Martin Renvoize from comment #28)
> > My one caveat is something doesn't feel quite right about the introduction
> > of 'send_confirm_notice' as a method in Koha::Auth::TwoFactorAuth, but I can
> > see why you do it so it's testable.. I'll leave that query to QA
> 
> That's something I noticed as well, it feels misplaced.

Yeah. This was kind of expected. Will try to find another home for him.

-- 
You are receiving this mail because:
You are watching all bug changes.