[Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret, send register notice

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894

--- Comment #32 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Martin Renvoize from comment #28)
> All works well so signing off.. I added a follow-up to use what I feel are
> clearer terms in the notices.
> 
> My one caveat is something doesn't feel quite right about the introduction
> of 'send_confirm_notice' as a method in Koha::Auth::TwoFactorAuth, but I can
> see why you do it so it's testable.. I'll leave that query to QA

Thanks, Martin. Addressed the misplaced method now. Joubu, go ahead!

-- 
You are receiving this mail because:
You are watching all bug changes.