[Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #58 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
1) Capitalization

It's all good, but in the database update statement:

Canceled Hold Available for Different Patron', '0', 'Canceled Hold Available
for Different Patron', 'The patron picking up <<biblio.title>>
(<<items.barcode>>) has changed to <<borrowers.firstname>>
<<borrowers.surname>> (<<borrowers.cardnumber

2) Spelling

Should this be reply-to address?

+            - . If no address is defined here, the email will be sent to the
library's reply to address.


2) Tests are failing :(

prove t/db_dependent/Holds/ExpireReservesAutoFill.t
t/db_dependent/Holds/ExpireReservesAutoFill.t .. 1/3     # No tests run!
t/db_dependent/Holds/ExpireReservesAutoFill.t .. 2/3 
#   Failed test 'No tests run for subtest "Test automatically canceled expired
waiting holds to fill the next hold, without a transfer"'
#   at t/db_dependent/Holds/ExpireReservesAutoFill.t line 131.
Undefined subroutine &main::CancelExpiredReserves called at
t/db_dependent/Holds/ExpireReservesAutoFill.t line 101.
# Looks like your test exited with 11 just after 2.
t/db_dependent/Holds/ExpireReservesAutoFill.t .. Dubious, test returned 11
(wstat 2816, 0xb00)
Failed 2/3 subtests 

Test Summary Report
-------------------
t/db_dependent/Holds/ExpireReservesAutoFill.t (Wstat: 2816 Tests: 2 Failed: 1)
  Failed test:  2
  Non-zero exit status: 11
  Parse errors: Bad plan.  You planned 3 tests but ran 2.
Files=1, Tests=2,  3 wallclock secs ( 0.03 usr  0.00 sys +  2.66 cusr  0.30
csys =  2.99 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.