[Koha-bugs] [Bug 28657] Expand branches.branchip to allow for multiple space separated ip ranges

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28657

Michael Hafen <michael.hafen at washk12.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122572|0                           |1
        is obsolete|                            |

--- Comment #3 from Michael Hafen <michael.hafen at washk12.org> ---
Created attachment 134126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134126&action=edit
Bug 28657: expand branches.branchip to allow for multiple ip  ranges.

change branches.branchip to a mediumtext, and remove '*' from existing
 branchip settings.
Change C4/Auth.pm from a regexp to using in_iprange() to check client 
 address against branchip.  (in_iprange() doesn't work with '*' in branchip.)
Change in_iprange() to default to false (which is what the POD says it 
 should do).  Also, have it trim '*' in case someone adds some back later.
Change note in admin/branches.tt under branchip field to reflect changes to 
 branchip handling.

Test plan:

1. Turn on AutoLocation system preference
2. Change a branches branchip to multiple ip ranges seperated by a space,
   making sure one of the ranges includes your computers address.
3. Log out and try logging in.  The location check will fail.
4. Apply patch.  Restart plack if necessary.
5. Try logging in again.  The location check will succeed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.