[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Apr 27 22:19:20 CEST 2022


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

--- Comment #118 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I'll finish my review tomorrow.

Overall, this is what I wanted to see on bug 23838, so I'm happy for this,
Martin. Great!

It is lacking (at least) tests for the new Koha::Checkouts::Renewal->store
method. I can add it, but got late today to do it.

I would like to see some higher-level method, like Koha::Checkout->renew and
start removing old code but we can do that in a follow-up, this is solid as it
stands.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list