[Koha-bugs] [Bug 29755] SIP2 code does not correctly handle NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
After signing off, I ran the tests and they failed:

prove t/db_dependent/SIP/Patron.t 
t/db_dependent/SIP/Patron.t .. 8/10 
    #   Failed test 'Guarantee only fines correctly counted'
    #   at t/db_dependent/SIP/Patron.t line 318.
    #          got: '11.11'
    #     expected: '0.11'

    #   Failed test 'Guarantee not blocked by guarantor fines'
    #   at t/db_dependent/SIP/Patron.t line 319.
    # Looks like you failed 2 tests of 4.
t/db_dependent/SIP/Patron.t .. 9/10 
#   Failed test 'NoIssuesChargeGuarantees tests'
#   at t/db_dependent/SIP/Patron.t line 322.
t/db_dependent/SIP/Patron.t .. 10/10 # Looks like you failed 1 test of 10.
t/db_dependent/SIP/Patron.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/10 subtests 

Test Summary Report
-------------------
t/db_dependent/SIP/Patron.t (Wstat: 256 Tests: 10 Failed: 1)
  Failed test:  9
  Non-zero exit status: 1
Files=1, Tests=10,  9 wallclock secs ( 0.04 usr  0.01 sys +  7.56 cusr  1.12
csys =  8.73 CPU)
Result: FAIL

Also, for steps 16-18 of the test plan, I think step 16 needs changing to "16 -
Set NoIssuesChargeGuarantorsWithGuarantees to 10", rather than 11. 
- If 11 is used, the patrons and the child are not blocked.
- The wording for the system preference is "Prevent a patron from checking out
if the patron has guarantors and those guarantor's guarantees owing in total
more than X USD in fines."
- The key part is "MORE THAN X USD". In the test, the total is 11.

-- 
You are receiving this mail because:
You are watching all bug changes.