[Koha-bugs] [Bug 30638] New: Odd number of elements in anonymous hash at C4/Letters.pm line 827

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30638

            Bug ID: 30638
           Summary: Odd number of elements in anonymous hash at
                    C4/Letters.pm line 827
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

Originating from 20.11 warnings: Odd number of elements in anonymous hash at
C4/Letters.pm line 878

output_pref({ dt => dt_from_string( $replacedby ), dateonly => $dateonly });

This is line 827 on current master.

If dt_from_string returns undef in list context, we get the odd number warn.

Also note the following lines:

if ( $letter->{ $letter_field } ) {
    $letter->{ $letter_field } =~
s/\Q<<$table.$field$filter_string_used>>\E/$replacedby_date/g;
    $letter->{ $letter_field } =~
s/\Q<<$field$filter_string_used>>\E/$replacedby_date/g;

If output_pref should correctly return undef on a NULL from dt_from_string, the
undefined result triggers two warnings in the regexes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.