[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Failed QA

--- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:

[1] I would recommend to add a little bit more text on this POD:
 =head3 stash_embed

-    $c->stash_embed(
$c->match->endpoint->pattern->defaults->{'openapi.op_spec'} );
+    $c->stash_embed( );

 =cut

[2] api/v1/swagger/paths/acquisitions_baskets.yaml
Here you do not specify collectionFormat: csv while you do at
acquisitions_funds.yaml.
And again you dont in suggestions.yaml.
Note that as I understand that it is the default array format, we should not
need them. But this looks inconsistent.

[3] Please fix t/Koha/REST/Plugin/Query.t
It fails now.

-- 
You are receiving this mail because:
You are watching all bug changes.