From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 01:09:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2022 23:09:36 +0000 Subject: [Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 --- Comment #26 from Victor Grousset/tuxayo --- (tests still pass) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 00:53:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2022 22:53:43 +0000 Subject: [Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 --- Comment #24 from Victor Grousset/tuxayo --- Created attachment 138424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138424&action=edit [DO NOT PUSH] Bug 18745: DBIC schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 07:01:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 05:01:17 +0000 Subject: [Koha-bugs] [Bug 28806] Labels exported as PDF create zero sized PDF files. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 --- Comment #7 from Dietrich --- Note: For me this is the case for single and multiple lables so the bug #29994 is different -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 09:47:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 07:47:30 +0000 Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in memberentry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 --- Comment #13 from Jonathan Druart --- Created attachment 138445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138445&action=edit Bug 30874: 2 more - need more investigation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 10:51:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 08:51:09 +0000 Subject: [Koha-bugs] [Bug 31269] DataTables error when managing staged MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31269 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138400|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 138451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138451&action=edit Bug 31269: Define sDefaultContent for DataTables 1. Stage a MARC record for import 2. Once you have one click on 'Manage staged records' 3. You will see an alert that says "Something went wrong when loading the table." 4. If you dismiss that you should see the following error: DataTables warning: table id=records-table - Requested unknown parameter '' for row 0, column 4. For more information about this error, please see http://datatables.net/tn/4 5. Appy patch 6. Try ssteps 1 & 2 again 7. No DataTable errors Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 08:00:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 06:00:43 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138253|0 |1 is obsolete| | --- Comment #66 from Jonathan Druart --- Created attachment 138426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138426&action=edit Bug 29897: Fix linkage Signed-off-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 10:12:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 08:12:02 +0000 Subject: [Koha-bugs] [Bug 27849] Koha::Token may access undefined C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27849 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 08:01:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 06:01:10 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138258|0 |1 is obsolete| | --- Comment #71 from Jonathan Druart --- Created attachment 138431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138431&action=edit Bug 29897: Move the identifier list to an include file Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 00:55:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2022 22:55:58 +0000 Subject: [Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87103|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 10:51:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 08:51:05 +0000 Subject: [Koha-bugs] [Bug 31269] DataTables error when managing staged MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31269 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 08:01:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 06:01:00 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138256|0 |1 is obsolete| | --- Comment #69 from Jonathan Druart --- Created attachment 138429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138429&action=edit Bug 29897: Improve syspref's description Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 08:16:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 06:16:34 +0000 Subject: [Koha-bugs] [Bug 31158] Can't filter suggestions by date ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31158 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 10:55:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 08:55:21 +0000 Subject: [Koha-bugs] [Bug 31259] Downloading patron card PDF hangs the server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31259 --- Comment #2 from Jake Deery --- Hi Chris, This is the URL: https://support-staff.koha-ptfs.co.uk/cgi-bin/koha/patroncards/create-pdf.pl?batch_id=2&template_id=8&layout_id=9&layout_back_id=9&start_card=1 Many thanks, Jake -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:31:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:31:26 +0000 Subject: [Koha-bugs] [Bug 30984] Action logs should log the cronjob script name that generated the given log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30984 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 10:26:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 08:26:46 +0000 Subject: [Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display local cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207 --- Comment #15 from Jonathan Druart --- Hi Andreas, The test is failing for me: kohadev-koha at kohadevbox:/kohadevbox/koha$ prove t/db_dependent/selenium/opacshelfbrowser.t t/db_dependent/selenium/opacshelfbrowser.t .. # No tests run! t/db_dependent/selenium/opacshelfbrowser.t .. 1/3 # Failed test 'No tests run for subtest "OPAC Shelf browser - Check display of local cover images (OpacSeparateHoldings set to "Don't separate")"' # at t/db_dependent/selenium/opacshelfbrowser.t line 137. upload_file: no such file: ./opacshelfbrowser-test-image1.jpg at t/db_dependent/selenium/opacshelfbrowser.t line 120. Also: + # test image by Kourosh Qaffari on Unsplash (https://unsplash.com/photos/RrhhzitYizg) The Unspash license does not seem GPLv3 compatible: https://unsplash.com/license To avoid an unnecessary discussion about the license (which is not at all the goal here :D), and to prevent a 50kb to be added to the git repo, shouldn't we go with 1px images? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:07:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:07:43 +0000 Subject: [Koha-bugs] [Bug 30468] koha-mysql does not honor Koha's timezone setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30468 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 08:16:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 06:16:53 +0000 Subject: [Koha-bugs] [Bug 31158] Can't filter suggestions by date ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31158 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 13:02:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 11:02:55 +0000 Subject: [Koha-bugs] [Bug 31050] Standardize session setup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31050 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|Signed Off |Failed QA --- Comment #6 from Jonathan Druart --- New method, new tests, please. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 15:19:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 13:19:52 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions using Google Books API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31274 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31274 [Bug 31274] OPACSuggestionAutoFill must be 1 or 0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:11:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:11:13 +0000 Subject: [Koha-bugs] [Bug 30965] Add patron autocomplete search to curbside pickups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 --- Comment #12 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 01:08:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2022 23:08:16 +0000 Subject: [Koha-bugs] [Bug 31264] CalendarFirstDayOfWeek not taken into account when configuring curbside pickups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31264 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 13:30:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 11:30:02 +0000 Subject: [Koha-bugs] [Bug 28702] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28702 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122785|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:32:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:32:21 +0000 Subject: [Koha-bugs] [Bug 31275] AdditionalContents.search_for_display returns branch block and All block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31275 --- Comment #1 from Jonathan Druart --- That could be a feature... :) However I've created a OpacNavRight for all and CPL, and only the one from all is displayed. And this is definitely a bug. Which block did you try? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 08:01:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 06:01:20 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138260|0 |1 is obsolete| | --- Comment #73 from Jonathan Druart --- Created attachment 138433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138433&action=edit Bug 29897: Fix tab display -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 11:07:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 09:07:24 +0000 Subject: [Koha-bugs] [Bug 28707] Translate RECEIPT notice (fr-CA) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28707 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 15:17:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 13:17:55 +0000 Subject: [Koha-bugs] [Bug 28702] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28702 --- Comment #8 from Jonathan Druart --- Created attachment 138468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138468&action=edit Bug 28702: Improve readability But removing the repetition Also prevent useless GetReserveStatus and GetTransfers (in a non-elegant way...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 12:50:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 10:50:51 +0000 Subject: [Koha-bugs] [Bug 30468] koha-mysql does not honor Koha's timezone setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30468 --- Comment #9 from Jonathan Druart --- What about this patch? Set to PQA if you agree with it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:53:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:53:00 +0000 Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #32 from Tomás Cohen Arazi --- No mention of Elasticsearch in the test plan? Does this already work on Elasticsearch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 08:01:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 06:01:30 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138372|0 |1 is obsolete| | --- Comment #75 from Jonathan Druart --- Created attachment 138435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138435&action=edit Bug 29897: Adjust syspref description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:49:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:49:17 +0000 Subject: [Koha-bugs] [Bug 29579] Show saved SQL report ID in database query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:11:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:11:22 +0000 Subject: [Koha-bugs] [Bug 31251] "Clear" patron attribute link does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31251 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:41:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:41:46 +0000 Subject: [Koha-bugs] [Bug 31235] UseDaysMode is used for calculating the expiration date for waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31235 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24159 CC| |jonathan.druart+koha at gmail. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 [Bug 24159] Allow daysMode for calculating due and renewal dates to be set at the circulation rules level -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 10:12:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 08:12:05 +0000 Subject: [Koha-bugs] [Bug 27849] Koha::Token may access undefined C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27849 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137802|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 138448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138448&action=edit Bug 27849: Koha::Token may access undefined C4::Context->userenv The _add_default_csrf_params internal function accesses C4::Context->userenv without checking that it has been defined. I think not all of the potential callers of it declare that they require a defined userenv, so we should test and provide defaults for required values if it is not defined, to avoid some "Can't use an undefined value as a HASH reference" HTTP 500 Internal Server Errors. To test: Do anything that requires a form with CSRF token, such as editing your details. Behaviour should be unchanged. To test the failure case, you would need some customised code that indirectly generates a CSRF token before setting the userenv up and I am not sure there is any in released Koha yet. Signed-off-by: Paul Derscheid Looks good to me. Working as expected. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 18:24:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 16:24:32 +0000 Subject: [Koha-bugs] [Bug 31277] New: The LinkerOptions system preference should supply a list of available options Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31277 Bug ID: 31277 Summary: The LinkerOptions system preference should supply a list of available options Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Reading the code, it seems only 'broader_headings' is implemented. Are there other options? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:11:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:11:11 +0000 Subject: [Koha-bugs] [Bug 30965] Add patron autocomplete search to curbside pickups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 10:44:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 08:44:14 +0000 Subject: [Koha-bugs] [Bug 30658] (Bug 29496 follow-up) CheckMandatorySubfields don't work properly with select field in serials-edit.tt for Supplemental issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30658 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136332|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 138450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138450&action=edit Bug 30658: (bug 29496 follow-up) CheckMandatorySubfields don't work properly with select field in serials-edit.tt for Supplemental issue CheckMandatorySubfields use the class "input_marceditor" but in file serials-edit.tt this class is not set for select input in Supplemental issue form. In consequence if a select field is set as mandatory, it is detected as missing even if it is filed and so you can't submit the form and receive the new supplemantal issue. Test plan: 1- Create (or find) a subscription for a biblio record and select the option "Create an item record when receiving this serial" 2- Be sure to have at least one mandatory subfield that is filed with a select input in the framework used by the biblio record. (ex: 952$a, 952$b or 952$c). 3- From the subscription-detail page click on "Receive" 4- In the lower part--Supplemental issue--fill the suppelemant details, change the status to "Arrived" and fill the item form that appears. 5- Click on "Save" 6- Check that an error box appear with the message " Form not submitted because of the following problem(s) 1 mandatory fields empty (highlighted)" (the number can be different according to the number of concerned subfields) 7- Apply the patch 8- Repeat step 3 to 5 9- Check that no error appear and that your item has been created Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:00:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:00:26 +0000 Subject: [Koha-bugs] [Bug 29983] Display the return claims column in the circulation overdues page (overdue.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 --- Comment #18 from Jonathan Druart --- Created attachment 138471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138471&action=edit Bug 29983: Format dates in templates using KohaDates (and display the time part) The time part is displayed on the checkout list Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 12:44:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 10:44:24 +0000 Subject: [Koha-bugs] [Bug 30468] koha-mysql does not honor Koha's timezone setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30468 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #7 from Jonathan Druart --- Kyle, do we really want to keep the echos? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 08:17:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 06:17:10 +0000 Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #64 from Jonathan Druart --- This change shouldn't be backported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:31:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:31:13 +0000 Subject: [Koha-bugs] [Bug 30468] koha-mysql does not honor Koha's timezone setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30468 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:17:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:17:22 +0000 Subject: [Koha-bugs] [Bug 31254] Add additional fields for accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31254 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 17:10:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 15:10:43 +0000 Subject: [Koha-bugs] [Bug 27448] Update ElasticsearchCrossFields description to explain consequences of setting in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27448 --- Comment #2 from Nick Clemens --- In Koha, a 'keyword' search does not search a cpombined 'keyword' field, but rather searches your term across all the fields marked as 'searchable' in the current interface. Cross fields is used to determine whether you want to only return values where all entered terms are included in a single search field, or whether you wish to find a record with all terms, but allowing the terms to be in any combination of fields. e.g. "king grass" without cross fields will return: The Island of the Grass King by Nancy Willard (grass in title/king in title) with cross fields will return: The Island of the Grass King by Nancy Willard (grass in title/king in title) In the tall grass by Stephen King (grass in title/king in author) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 08:16:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 06:16:37 +0000 Subject: [Koha-bugs] [Bug 31158] Can't filter suggestions by date ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31158 --- Comment #2 from Jonathan Druart --- Created attachment 138436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138436&action=edit Bug 31158: (bug 23991 follow-up) Fix suggestion search by dates Search suggestions by date is broken, we don't remove the '_from' CGI params for the DBIC query DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'suggesteddate_from' in 'where clause' at /kohadevbox/koha/Koha/Objects.pm line 394 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 Test plan: Create some suggestions, search for them using date range (suggested date, managed date and accepted date) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 12:13:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 10:13:24 +0000 Subject: [Koha-bugs] [Bug 29579] Show saved SQL report ID in database query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Jonathan Druart --- You need to adjust t/db_dependent/Koha/Reports.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 04:07:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 02:07:24 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #418 from David Cook --- (In reply to Victor Grousset/tuxayo from comment #417) > I would gladly give another try if someone know what to do about the two > above points. Hopefully Aleisha can provide some insight. In theory, I'll look at this again one day, but I don't know when. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:13:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:13:14 +0000 Subject: [Koha-bugs] [Bug 31275] New: AdditionalContents.search_for_display returns branch block and All block Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31275 Bug ID: 31275 Summary: AdditionalContents.search_for_display returns branch block and All block Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org If there is a branch specific block, you normally dont want the All block to appear too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 15:44:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 13:44:27 +0000 Subject: [Koha-bugs] [Bug 30327] Sort component parts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30327 --- Comment #45 from Lucas Gass --- (In reply to Katrin Fischer from comment #44) > (In reply to Lucas Gass from comment #43) > > Backported to 22.05.x for 22.05.04 > > I am not sure about this one, if the sorting currently was by biblionumber > that might have been the expected sorting - and it won't work now as long as > we don't have bug 30879 in. Cait, Do you think I should revert this patchset? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:08:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:08:23 +0000 Subject: [Koha-bugs] [Bug 28702] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28702 --- Comment #12 from Jonathan Druart --- Also removing items_rs is a step backward compared to bug 28299. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:50:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:50:05 +0000 Subject: [Koha-bugs] [Bug 29579] Show saved SQL report ID in database query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement shows a |This enhancement shows a release notes|saved SQL report's ID in |saved SQL report's ID in |the database process list |the database process list |(from example, "-- |(from example, "/* |saved_sql.id=123"). This |saved_sql.id: 123 */). This |can help when |can help when |troubleshooting reports |troubleshooting reports |that are causing issues, |that are causing issues, |such as taking too long to |such as taking too long to |run or taking up too many |run or taking up too many |system resources. |system resources. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:12:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:12:15 +0000 Subject: [Koha-bugs] [Bug 30650] Add a curbside pickup module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | Status|Pushed to master |Needs documenting --- Comment #165 from Tomás Cohen Arazi --- Follow-up pushed to master. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 08:01:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 06:01:05 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138257|0 |1 is obsolete| | --- Comment #70 from Jonathan Druart --- Created attachment 138430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138430&action=edit Bug 29897: Add VIAF Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 10:51:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 08:51:18 +0000 Subject: [Koha-bugs] [Bug 31138] DataTables is not raising error to the end user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31138 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31269 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31269 [Bug 31269] DataTables error when managing staged MARC records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 11:31:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 09:31:08 +0000 Subject: [Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a basket as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257 --- Comment #2 from Aleisha Amohia --- Created attachment 138454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138454&action=edit Bug 31257: Add a new English 1 page layout to export basketgroup This patch adds a new English 1 page layout to be used when exporting a basketgroup as PDF. This has been modelled after an example PDF from another library system. To test: 1) Go to Koha Administration -> Libraries. Ensure Library A has an address, phone and fax. 2) Go to Koha Administration -> System preferences. Search for OrderPdfFormat. Set this to the new English 1-page layout option. 3) Go to Acquisitions. Use an existing vendor or create a new one. Ensure the vendor has a postal address, phone, fax and accout number. 4) Create a basket for this vendor. Add a few orders to the basket. 5) Close the basket and add it to a basket group of the same name. 6) Edit the basket group. Add an address in the delivery place, and a delivery comment. Check the box to close the basket group and Save. 7) Click the button to Export as PDF. 8) View the exported PDF. Confirm all of the information displayed is correct. 9) Reopen the basketgroup. Edit the details and remove the delivery place text. Re-close the basketgroup. 10) Repeat steps 7 and 8. Sponsored-by: Pymble Ladies' College -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 04:00:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 02:00:04 +0000 Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 --- Comment #113 from David Cook --- Julian for RM next time and a move to Mojolicious? ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 13:30:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 11:30:15 +0000 Subject: [Koha-bugs] [Bug 28702] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28702 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137940|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 04:00:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 02:00:42 +0000 Subject: [Koha-bugs] [Bug 20630] An attempt at multitenancy with Mojolicious In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20630 --- Comment #9 from David Cook --- This would still be interesting to explore, although I think we'd need to make more progress running Koha as a Mojolicious app before it would be worthwhile? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 15:21:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 13:21:20 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #94 from Kyle M Hall --- Created attachment 138469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138469&action=edit Bug 26282: (QA follow-up) Remove invalid test A cancellation reason is not required, making this test invalid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:18:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:18:33 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #5 from Marcel de Rooy --- Still work in progress -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 09:12:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 07:12:32 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138308|0 |1 is obsolete| | --- Comment #85 from Jonathan Druart --- Created attachment 138440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138440&action=edit Bug 27272: Call search_ordered when GetItemsInfo was called before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 08:00:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 06:00:48 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138254|0 |1 is obsolete| | --- Comment #67 from Jonathan Druart --- Created attachment 138427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138427&action=edit Bug 29897: Don't use $6 for linkage but build the link instead See comment 26: $6 is a very specialized field that will never contain a URL. Linkage here means 'linking MARC fields within the record'. For example it is used to link an original script tag with the corresponding tag in transliteration. See: https://www.loc.gov/marc/authority/ecadcntf.html Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:51:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:51:50 +0000 Subject: [Koha-bugs] [Bug 31276] Report results are limited to 999, 999 no matter the actual number of results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31276 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 09:47:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 07:47:34 +0000 Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in memberentry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 --- Comment #14 from Jonathan Druart --- Created attachment 138446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138446&action=edit Bug 30874: Simplify categories loop construction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 19:57:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 17:57:31 +0000 Subject: [Koha-bugs] [Bug 30543] Decouple DumpSearchQueryTemplate from other template dump preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30543 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133310|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 138485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138485&action=edit Bug 30543: Decouple DumpSearchQueryTemplate from other tempalte dump preferences To test: 1 - Enable DumpSearchQueryTemplate 2 - Confirm you can find the search query in the HTML as a comment 3 - Enable other template dump preference 4 - Confirm they work as before 5 - Confirm new description of preference makes sense Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 20:41:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 18:41:29 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #79 from Katrin Fischer --- Created attachment 138487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138487&action=edit Bug 29897: (QA follow-up) Add valid $2 codes to pref description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:43:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:43:14 +0000 Subject: [Koha-bugs] [Bug 31274] OPACSuggestionAutoFill must be 1 or 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31274 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 138476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138476&action=edit Bug 31274: Make sure OPACSuggestionAutoFill is handled as a boolean everywhere The YAML preference definition defines it as a string ('yes' or 'no' the possible values). And the opac-suggestions.tt template has one occurence of the variable being compared to a string. This patch does: - fix the template - fixes opac.pref for 0|1 - adds an atomicupdate that takes care of moving 'yes' and 'no' to their respective boolean values. To test: 1. Change the syspref value to enable/disable 2. Check on the DB that the value is wrong: $ koha-mysql kohadev > SELECT value FROM systempreferences WHERE variable='OPACSuggestionAutoFill'; => FAIL: It is either 'yes' or 'no' depending on what you choose. 3. Apply this patch 4. Run: $ updatedatabase 5. Repeat 2 => SUCCESS: Values are now 0 or 1 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:39:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:39:46 +0000 Subject: [Koha-bugs] [Bug 30779] Do not need to remove items from import biblios marc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 15:03:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 13:03:02 +0000 Subject: [Koha-bugs] [Bug 30964] Add information about overdues and restrictions on the curbside pickup list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30964 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 11:07:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 09:07:30 +0000 Subject: [Koha-bugs] [Bug 28707] Translate RECEIPT notice (fr-CA) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28707 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137798|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 138452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138452&action=edit Bug 28707: Translate RECEIPT notice There is a badly crafted regex used when extracting strings in multiline fields in yaml files The regex is my own, introduced in Bug 24262, sorry. This patch correct it a little. Better eyes are welcome. To test: 1) go to misc translator, update some language ./translate update fr-CA 2) check missing strings egrep "Total out|Operator ID|August 31" po/fr-CA-installer.po first two are from sample notices, third from sample creator data 3) apply the patch, repeat 1) 4) repeat 2), verify the strings are present in the translation file 5) translate some of the new strings, install the language, verify strings are present in the translated files ./translate install fr-CA check fr-CA/optional/sample_creator_data.yml and fr-CA/mandatory/sample_notices.yml There are some 60+ new strings. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 11:17:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 09:17:01 +0000 Subject: [Koha-bugs] [Bug 30028] Patron message delete confirmation untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30028 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 09:47:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 07:47:21 +0000 Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in memberentry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135524|0 |1 is obsolete| | Attachment #135525|0 |1 is obsolete| | Attachment #135526|0 |1 is obsolete| | Attachment #135528|0 |1 is obsolete| | Attachment #135529|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 138443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138443&action=edit Bug 30874: Replace categoryname -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 12:52:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 10:52:07 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:17:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:17:55 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #4 from Marcel de Rooy --- Created attachment 138474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138474&action=edit Bug 29144: Add OpacBranchInfo as HTML option, show it on opac Test plan: Add a few OpacBranchInfo for libraries. Verify that opac-library shows the correct info per library. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 00:56:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2022 22:56:00 +0000 Subject: [Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87104|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:31:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:31:22 +0000 Subject: [Koha-bugs] [Bug 30984] Action logs should log the cronjob script name that generated the given log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30984 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:39:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:39:17 +0000 Subject: [Koha-bugs] [Bug 30779] Do not need to remove items from import biblios marc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135051|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 138475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138475&action=edit Bug 30779: Do not update import marc after importing items We are stripping the marc item tags at import - we save them when not importing items, but strip when importing items I think we can save on writes by leaving them in the record. This also allows comparison to what was staged versus items created To test: 1 - Stage a marc record with items, but do not look for items 2 - Confirm the item tags remain in staged marc 3 - Import the record 4 - Confirm items are nto in imported marc record 5 - Stage the record again, but look for items 6 - Confirm the item tags are stipped from imported record 7 - Import and confirm imported record has no item tags 8 - Apply patch and repeat 1-5 9 - Confirm item tags remain in record 10 - Import and confirm item tags not in imported marc Signed-off-by: Andrew -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 01:05:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2022 23:05:02 +0000 Subject: [Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #25 from Victor Grousset/tuxayo --- Happy birthday, here is a rebase 🎁 ^o^ I compared the old and new patch files to double check that I didn't change anything unknowingly. There was some mess in the ticket. Some old patches weren't obsoleted and this was the actual reason the patch didn't apply at first. Fixed missing comma in kohastructure.sql Removed DBIC schema changes, regenerated then and put then in their own commit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 12:05:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 10:05:43 +0000 Subject: [Koha-bugs] [Bug 29971] Remember selections across patron search pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136534|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 138455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138455&action=edit Bug 29971: Remember selections across patron search pages This patch modifies the patron search results page to enable checkbox selections to be remembered in the browser's localStorage. This allows checkbox selections to persist while navigating through multiple pages of search results or even across multiple different searches. Once selected, these values can be added to a patron list or submitted for merging. Selections can be cleared manually and will be automatically be removed upon logout. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - In the staff interface perform a patron search in the Patrons module which will return multiple pages of results.. - Check checkboxes next to several patrons. - After one checkbox is checked the "Add to patron list" button should be enabled. - After more than one checkbox is checked the "Merge selected patrons" button should be enabled. - A box should appear in the toolbar above the search results, "Patrons selected: X" - Navigate to another page of results. Check more checkboxes. The "Patrons selected" information should be updated. - Return to the first page of results. Your original selections should still be checked. - Test that the correct set of patrons is used when clicking "Merge selected patrons" or when using "Add to patron list." - Click the "Clear" button in the selections information box. Checkboxes should be cleared on every page of results you previously checked. - The "Add to patron list" and "Merge selected patrons" buttons should become disabled. - After making several selections, log out of the staff interface and log back in, returning to the same patron search. Your selections should have been forgotten. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:10:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:10:53 +0000 Subject: [Koha-bugs] [Bug 28707] Translate RECEIPT notice (fr-CA) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28707 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 11:31:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 09:31:03 +0000 Subject: [Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a basket as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 15:31:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 13:31:09 +0000 Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #104 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #102) > I am sorry, but I get this error when trying to return an item with a hold > on it: > > Can't call method "id" on an undefined value at > /kohadevbox/koha/circ/returns.pl line 351 > > 349: # is there a waiting hold for the item, for which cancellation > 350: # has been requested? > 351: my $waiting_holds_to_be_cancelled = > 352: Koha::Holds->waiting->search( { itemnumber => $item->id } ) > 353: ->filter_by_has_cancellation_requests; > 354: while ( my $hold = $waiting_holds_to_be_cancelled->next ) { Sorry, I cannot reproduce. I tried with: - 3 item-level holds, for different patrons, on same item - 1 biblio-level hold - Doing a check-in for a not having item-level hold item on the biblio => SUCCESS: biblio-level hold trapped, offered to confirm. tried both confirming and discarding. The fact it breaks on $item->id is pointing me to something else: it means the item hasn't been found using the barcode. So... it must be something else on your branch that wasn't correctly rebased after this one got pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:11:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:11:02 +0000 Subject: [Koha-bugs] [Bug 30499] Keyboard shortcuts broken on several pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 12:10:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 10:10:24 +0000 Subject: [Koha-bugs] [Bug 30612] Add accountlines method to Koha::Checkout and Koha::Old::Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30612 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #8 from Jonathan Druart --- Shouldn't be named account_lines instead of accountlines? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 02:16:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 00:16:11 +0000 Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 12:05:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 10:05:47 +0000 Subject: [Koha-bugs] [Bug 29971] Remember selections across patron search pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 --- Comment #12 from Jonathan Druart --- Created attachment 138456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138456&action=edit Bug 29971: Add selenium tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 04:08:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 02:08:51 +0000 Subject: [Koha-bugs] [Bug 30951] Duplicate entry 'ar' for key 'PRIMARY' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30951 --- Comment #6 from David Cook --- (In reply to Katrin Fischer from comment #5) > Could we fix the old database update and implement the proposed fix as a new > one to catch all? Makes sense to me. I'm just not sure how we do that as a process. Do we do a patch against master for the database update (for the past), and then stable branches backport it? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:49:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:49:22 +0000 Subject: [Koha-bugs] [Bug 29579] Show saved SQL report ID in database query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138068|0 |1 is obsolete| | Attachment #138460|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 138466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138466&action=edit Bug 29579: Show saved SQL report ID in database query When trying to figure out which saved SQL report caused too much load, it's useful to have the report id show in the mysql process list. This patch adds the saved SQL ID number as a comment line in front of the SQL before passing it to the database. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Create a long running query like: SELECT * FROM borrowers a, borrowers b, borrowers c, borrowers d 4) Connect to the database using koha-mysql 5) Execute "show processlist;" 6) Note the Info column looks something like: SELECT * FROM borrowers a, borrowers b, borrowers c, borrowers d /* saved_sql.id: 1 */ Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:17:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:17:59 +0000 Subject: [Koha-bugs] [Bug 28702] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28702 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 03:00:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 01:00:00 +0000 Subject: [Koha-bugs] [Bug 31259] Downloading patron card PDF hangs the server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31259 --- Comment #6 from Chris Nighswonger --- (In reply to David Cook from comment #3) > I had the same problem years ago but fixed it with bug 22429 so must be > something else causing the problem now. > > The infinite loop is probably in the "while(1)" block, and it probably > relates to whatever data you're feeding in. This while block is problematic (says the one who coded this mess): it has no out in the case that the main conditional never evaluates true. There may be some fringe cases where the regexp does not match... ever. Hard to tell without data which causes the infinite looping. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 19:31:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 17:31:55 +0000 Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138232|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 17:14:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 15:14:27 +0000 Subject: [Koha-bugs] [Bug 25295] Allow customization of staff client based on login location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25295 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:52:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:52:49 +0000 Subject: [Koha-bugs] [Bug 29971] Remember selections across patron search pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Keywords| |rel_22_11_candidate Status|Passed QA |Failed QA --- Comment #13 from Tomás Cohen Arazi --- Hi! The added tests are failing for me. Can you review it ASAP? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 15:48:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 13:48:57 +0000 Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting Keywords|additional_work_needed |Manual --- Comment #105 from Tomás Cohen Arazi --- I'm marking this one as resolved now. Any further stuff related to it should be filed on a separate follow-up bug from now on. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 19:11:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 17:11:17 +0000 Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search function for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 --- Comment #26 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 20:00:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 18:00:50 +0000 Subject: [Koha-bugs] [Bug 31278] ISBN and ISSN searching should quote the query terms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31278 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23919 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 [Bug 23919] Make ISSN searchable with and without hyphen -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:31:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:31:10 +0000 Subject: [Koha-bugs] [Bug 30468] koha-mysql does not honor Koha's timezone setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30468 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 09:47:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 07:47:50 +0000 Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in memberentry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #16 from Jonathan Druart --- Test plan: Create a new patron in a given category => Form show the dropdown with the selected category Edit again => Value is kept Edit a category to give it specific values for: messaging prefs, password strength/length, can be guarantee Edit the patron, change the category, and confirm that the different limitation are correctly applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 17:40:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 15:40:05 +0000 Subject: [Koha-bugs] [Bug 28702] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28702 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #13 from Nick Clemens --- (In reply to Jonathan Druart from comment #11) > I don't understand. > In C4::Search we are building @hiddenitems to pass to XSLTParse4Display. > > Either you are right and we don't need that code, or you removed too much > code. We don't need it here, but you are corretc, we need it from opac-shelves (In reply to Jonathan Druart from comment #12) > Also removing items_rs is a step backward compared to bug 28299. I think I was not aware of that when I initially wrote this, so those changes may not be reflected It comes back to the fact that translating authorised values to descriptions is where we spend time, that's why i tried to move it all to one place - I could reduce this to the changes for getreservestatus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 10:26:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 08:26:42 +0000 Subject: [Koha-bugs] [Bug 24616] Cannot copy notice to another branch if it already exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 --- Comment #5 from Emmi Takkinen --- (In reply to Christopher Brannon from comment #4) > It works, but I don't think this is a complete solution. It needs to warn > you that you are overwriting an existing notice or slip and give you the > option to proceed or cancel. This is too dangerous as is. That's a good point. I'll take a look at this again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 15:03:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 13:03:00 +0000 Subject: [Koha-bugs] [Bug 30612] Add account_lines method to Koha::[Old::]Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30612 --- Comment #14 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 09:22:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 07:22:52 +0000 Subject: [Koha-bugs] [Bug 30963] Automatically refresh the curbside pickups list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30963 --- Comment #2 from Katrin Fischer --- Maybe providing JS if possible is a good idea to get more feedback - I am not sure actually if it would be a good feature or not. I an ideal setting we should probably trigger a refresh when another pickup was scheduled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 15:23:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 13:23:21 +0000 Subject: [Koha-bugs] [Bug 28702] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28702 --- Comment #9 from Jonathan Druart --- > But removing the repetition By* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:11:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:11:06 +0000 Subject: [Koha-bugs] [Bug 30499] Keyboard shortcuts broken on several pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 15:59:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 13:59:08 +0000 Subject: [Koha-bugs] [Bug 30879] Add option to sort components by biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #31 from Nick Clemens --- (In reply to Katrin Fischer from comment #30) > No reply from Nick yet, I think we still need the release notes note, but > dropping the other requirement from my side. I believe this is worth having. I think I drafted and never posted We need to solve the problem of differing settings in a larger way - if we are letting people define their own mappings we really can't update them without feedback - bug 30836 is the place to figure that out -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 09:12:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 07:12:43 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #87 from Jonathan Druart --- Created attachment 138442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138442&action=edit Bug 27272: Fix library display on routing slip - to squash -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 09:12:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 07:12:16 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138305|0 |1 is obsolete| | --- Comment #82 from Jonathan Druart --- Created attachment 138437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138437&action=edit Bug 27272: Add search_ordered sub to order items with extra conditions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 08:00:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 06:00:54 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138255|0 |1 is obsolete| | --- Comment #68 from Jonathan Druart --- Created attachment 138428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138428&action=edit Bug 29897: Add and fix POD Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 02:42:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 00:42:55 +0000 Subject: [Koha-bugs] [Bug 29994] Single label PDF export not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29994 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 08:01:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 06:01:25 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138371|0 |1 is obsolete| | --- Comment #74 from Jonathan Druart --- Created attachment 138434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138434&action=edit Bug 29897: Remove 'linkage' leftover -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 15:37:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 13:37:51 +0000 Subject: [Koha-bugs] [Bug 29983] Display the return claims column in the circulation overdues page (overdue.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #14 from Jonathan Druart --- Why do we display the column if the feature is disabled? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 17:09:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 15:09:06 +0000 Subject: [Koha-bugs] [Bug 30612] Add account_lines method to Koha::[Old::]Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30612 --- Comment #15 from Tomás Cohen Arazi --- Just a note, it might be more handy to have ->debits and ->credits. But I will let devs decide later how they're gonna use this! Code will tell. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:32:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:32:30 +0000 Subject: [Koha-bugs] [Bug 30951] Duplicate entry 'ar' for key 'PRIMARY' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30951 --- Comment #7 from Katrin Fischer --- (In reply to David Cook from comment #6) > (In reply to Katrin Fischer from comment #5) > > Could we fix the old database update and implement the proposed fix as a new > > one to catch all? > > Makes sense to me. I'm just not sure how we do that as a process. Do we do a > patch against master for the database update (for the past), and then stable > branches backport it? I'd say so. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:05:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:05:40 +0000 Subject: [Koha-bugs] [Bug 28299] OpacHiddenItems not working in OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28702 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 19:32:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 17:32:25 +0000 Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 138481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138481&action=edit bug 30392: DB changes Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 07:01:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 05:01:15 +0000 Subject: [Koha-bugs] [Bug 31274] OPACSuggestionAutoFill must be 1 or 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31274 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138488|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 138492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138492&action=edit Bug 31274: Make sure OPACSuggestionAutoFill is handled as a boolean everywhere The YAML preference definition defines it as a string ('yes' or 'no' the possible values). And the opac-suggestions.tt template has one occurence of the variable being compared to a string. This patch does: - fix the template - fixes opac.pref for 0|1 - adds an atomicupdate that takes care of moving 'yes' and 'no' to their respective boolean values. To test: 1. Change the syspref value to enable/disable 2. Check on the DB that the value is wrong: $ koha-mysql kohadev > SELECT value FROM systempreferences WHERE variable='OPACSuggestionAutoFill'; => FAIL: It is either 'yes' or 'no' depending on what you choose. 3. Apply this patch 4. Run: $ updatedatabase 5. Repeat 2 => SUCCESS: Values are now 0 or 1 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Aleisha Amohia Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 09:15:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 07:15:05 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #88 from Jonathan Druart --- (In reply to Joonas Kylmälä from comment #81) Thanks, Joonas! > Did some testing, no code review yet but noticed the following problems: > > 1. Going to a serial biblio's detail page fails on opac, e.g. page > http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=29 on KTD. > > > DBIx::Class::ResultSource::_resolve_join(): No such relationship serial on Item at /kohadevbox/koha/Koha/Objects.pm line 421 > > Same error on the detail.pl on the staff side. My tests were wrong but passing! It's fixed now. > 2. Go to any biblio's OPAC detail page, checkout an item for that biblio and > notice the Status column is not updated and it still shows "Available". > Before applying these patches the status was "Checked out" Should be fixed, but this area is a mess. Hard to keep things clean, the idea here is to not get worse. We should focus on that once this bug is pushed. > 3. serials/routing-preview.pl doesn't display the branch name anymore. > > Will continue testing after this, there are still some things I want to test > on the biblio detail pages that I cannot due to the internal server errors. Oops, fixed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 20:00:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 18:00:39 +0000 Subject: [Koha-bugs] [Bug 31278] New: ISBN and ISSN searching should quote the query terms Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31278 Bug ID: 31278 Summary: ISBN and ISSN searching should quote the query terms Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org It doesn't. To reproduce: 1. Open your logs: $ restart_all ; tail -f /var/log/koha/kohadev/*.log 2. Open the advanced search page 3. Search on ISBN and/or ISSN, for the term 123:456=789 => FAIL: The logs =~ m/ [WARN] WARNING: query problem with nb=(rk=(123:456=789)) ZOOM error 10014 "CCL parsing error" (addinfo: "Unknown qualifier") from diag-set 'ZOOM' at /kohadevbox/koha/C4/Search.pm line 350. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 06:58:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 04:58:14 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #52 from Aleisha Amohia --- Created attachment 138491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138491&action=edit Bug 15348: (follow-up) Fix filtering results on estimated delivery date Adding another clause to the SQL so that the specified estimated delivery date is used for filtering first, and the calculated delivery date is used if there is no specified estimated delivery date. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:49:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:49:00 +0000 Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 --- Comment #114 from Kyle M Hall --- (In reply to David Cook from comment #113) > Julian for RM next time and a move to Mojolicious? ;) I'll vote for that! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 00:53:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2022 22:53:38 +0000 Subject: [Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124951|0 |1 is obsolete| | --- Comment #23 from Victor Grousset/tuxayo --- Created attachment 138423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138423&action=edit Bug 18745: Serial claims: save supplier info on serial-level This allows to change the subscription's supplier while keeping the info of supplier for previous serials, which allows to claim late/missing serials to the right supplier Test plan: 1. Create 2 suppliers, S1 and S2 2. Create a new subscription with S1 3. Generate some late/missing serials 4. Change supplier to S2 5. Generate some more late/missing serials 6. Go to /cgi-bin/koha/serials/claims.pl and see you have late/missing issues for both suppliers 7. Check that you have the expected issues for each supplier 8. prove t/db_dependent/Serials/Claims.t Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:51:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:51:53 +0000 Subject: [Koha-bugs] [Bug 31276] Report results are limited to 999, 999 no matter the actual number of results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31276 --- Comment #1 from Kyle M Hall --- Created attachment 138477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138477&action=edit Bug 31276: Report results are limited to 999,999 no matter the actual number of results In Koha, any report that uses C4::Reports::Guided will be limited to 999,999 rows. This is causing problems for larger libraries where some reports may have over a million results. Test Plan: 1) Create a report "SELECT * FROM borrowers" and run it, note the number of results 2) Apply this patch 3) Add the line `3` within the block of your koha-conf.xml 4) Restart all the things! 5) Run the report, download the results as a CSV 6) Note your CSV only has 4 lines, the header and 3 patrons -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 02:15:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 00:15:54 +0000 Subject: [Koha-bugs] [Bug 28806] Labels exported as PDF create zero sized PDF files. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 --- Comment #11 from David Cook --- I raised the importance since this seems to be an increasingly large problem. Since it doesn't affect my prod systems, I'm not going to fix this urgently. But when it does start to affect my prod systems, then I'll likely look into it urgently. I'm curious if/when it'll affect other vendors... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:08:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:08:55 +0000 Subject: [Koha-bugs] [Bug 30468] koha-mysql does not honor Koha's timezone setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30468 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138457|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 138458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138458&action=edit Bug 30468: Restore 'set -e' and remove echos Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:31:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:31:33 +0000 Subject: [Koha-bugs] [Bug 31269] DataTables error when managing staged MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31269 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 12:30:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 10:30:12 +0000 Subject: [Koha-bugs] [Bug 28806] Labels exported as PDF create zero sized PDF files. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 --- Comment #9 from Chris Nighswonger --- (In reply to Dietrich from comment #7) > Note: For me this is the case for single and multiple lables so the bug > #29994 is different There have been many bug reports for labels/cards of late. I suspect a common regression may be behind them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 11:17:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 09:17:05 +0000 Subject: [Koha-bugs] [Bug 30028] Patron message delete confirmation untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30028 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137597|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Created attachment 138453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138453&action=edit Bug 30028: Fix patron message delete confirmation to be translatable Make the message deletion confirmation popup translatable. Test plan uses fr-CA translations. Test plan: 1) Switch language to french (fr-CA) If you do not have the translations, go to misc/translator then do ./translate install fr-CA After it is done, go to administration > global system preference > l18N/L10N then select Français (fr-CA) under language preference. Refresh then you should be able to switch languages. 2) Add a message to a patron account from your own branch (or make sure AllowAllMessageDeletion is on) 3) Click "Delete" next to the message --> a confirmation message appears "Are you sure you want to delete this message? This cannot be undone." with options "Cancel" and "OK". 4) Apply the patch 5) Write a translation in misc/translator/po/fr-CA-messages-js.po : msgid "Are you sure you want to delete this message? This cannot be undone." msgstr "Êtes-vous sûr de vouloir supprimer ce message? Cette opération est irréversible." 6) Refresh the translations by going to misc/translator and execute ./translate install fr-CA 7) Refresh and click "Delete" again --> now the confirmation message is "Êtes-vous sûr de vouloir supprimer ce message? Cette opération est irréversible." with options "Cancel" and "OK" Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 09:47:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 07:47:39 +0000 Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in memberentry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 --- Comment #15 from Jonathan Druart --- Created attachment 138447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138447&action=edit Bug 30874: Remove category_type In which case do we pass category_type to this script? Am I missing something? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:45:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:45:39 +0000 Subject: [Koha-bugs] [Bug 30612] Add accountlines method to Koha::Checkout and Koha::Old::Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30612 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135827|0 |1 is obsolete| | Attachment #135829|0 |1 is obsolete| | Attachment #138461|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 138462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138462&action=edit Bug 30612: Add accountlines method to Koha::Checkout and Koha::Old::Checkout It would be very useful to have an accountlines method on checkouts objects. In particular it would make fees related to a checkout available from the checkout objects in overdue notices. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Account/Line.t 3) prove t/db_dependent/Koha/Checkouts.t Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 02:08:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 00:08:37 +0000 Subject: [Koha-bugs] [Bug 30836] Elasticsearch mappings.yaml is out of sync with upgraded databases In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30836 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:34:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:34:31 +0000 Subject: [Koha-bugs] [Bug 30612] Add accountlines method to Koha::Checkout and Koha::Old::Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30612 --- Comment #9 from Kyle M Hall --- Created attachment 138461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138461&action=edit Bug 30612: (QA follow-up) Rename accountlines method to account_lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 09:12:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 07:12:27 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138307|0 |1 is obsolete| | --- Comment #84 from Jonathan Druart --- Created attachment 138439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138439&action=edit Bug 27272: Add tests for search_ordered -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 12:05:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 10:05:38 +0000 Subject: [Koha-bugs] [Bug 29971] Remember selections across patron search pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 08:24:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 06:24:38 +0000 Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136084|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 09:37:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 07:37:25 +0000 Subject: [Koha-bugs] [Bug 30836] Elasticsearch mappings.yaml is out of sync with upgraded databases In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30836 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stefan.berndtsson at ub.gu.se --- Comment #7 from Stefan Berndtsson --- Isn't this what Bug 19707 is supposed to handle? I know it has failed QA for now though, so some fixing would be necessary, but if I remember correctly it adds sync/reset options for mappings. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 09:28:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 07:28:21 +0000 Subject: [Koha-bugs] [Bug 31280] New: Allow OPACHoldsIfAvailableAtPickup to be set on library level Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31280 Bug ID: 31280 Summary: Allow OPACHoldsIfAvailableAtPickup to be set on library level Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In a multi-branch installation, sometimes some libraries will fetch items from the shelf for their users, while others might not. We do have the on-shelf setting in circulation rules, but if you set this to "only when all items are checked out" (no), you will no longer be able to request a delivery to another branch. - So in order to keep that working, we need to allow on-shelf holds. It would be nice to have OPACHoldsIfAvailableAtPickup not only on global level, but also as a per library setting. Possibly with OPACHoldsIfAvailableAtPickupExceptions moved as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:29:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:29:09 +0000 Subject: [Koha-bugs] [Bug 29579] Show saved SQL report ID in database query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579 --- Comment #17 from Kyle M Hall --- Created attachment 138460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138460&action=edit Bug 29579: (QA follow-up) Fix up t/db_dependent/Koha/Reports.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 12:28:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 10:28:20 +0000 Subject: [Koha-bugs] [Bug 28806] Labels exported as PDF create zero sized PDF files. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 --- Comment #8 from Chris Nighswonger --- (In reply to Manos PETRIDIS from comment #4) > Further testing has shown that > * when trying to print in a Layout of Print type BAR, a PDF is created. It > doesn't contain the full batch, but at least id does contain a barcode. > * when trying however to print in Layouts of Print type either ALT or > BARBIB, that is when trying to include in the labels something more than > just the barcode, the same batch creates a zero-sized PDF file. > > Any ideas? Please post a PDF from your BAR type batch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 15:02:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 13:02:49 +0000 Subject: [Koha-bugs] [Bug 28864] The patron search results in the patron card creator doesn't seem to use PatronsPerPage syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 06:57:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 04:57:53 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #81 from Jonathan Druart --- (In reply to Katrin Fischer from comment #78) > I am sorry, I found another small issue. I tried to fix, but miss the right > idea now: > > [% FOR identifier IN author.identifiers %] >
  • > [% PROCESS "authority-identifiers.inc" identifier => identifier %] >
    • > [% END %] > > This will create empty li elements, when $2 is not in the list of valid > codes. > > I am providing a follow-up with some more information for the pref > description. Done. I don't think it was a good idea to modify the original request and remove the flexibility to have different source. We will see what is the feedback once it's pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 20:00:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 18:00:50 +0000 Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31278 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31278 [Bug 31278] ISBN and ISSN searching should quote the query terms -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:10:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:10:49 +0000 Subject: [Koha-bugs] [Bug 28707] Translate RECEIPT notice (fr-CA) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28707 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 08:02:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 06:02:14 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #76 from Jonathan Druart --- (In reply to Katrin Fischer from comment #64) > Hi Joubu, it almost works perfectly now, but: > The author identifiers don't only show on their own tab, but on all tabs on > the OPAC detail page. Oops, good catch. I have messed up the conflict with bug 30570. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:45:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:45:47 +0000 Subject: [Koha-bugs] [Bug 30612] Add accountlines method to Koha::Checkout and Koha::Old::Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30612 --- Comment #12 from Jonathan Druart --- Created attachment 138464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138464&action=edit Bug 30612: (QA follow-up) Rename accountlines method to account_lines Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 10:12:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 08:12:09 +0000 Subject: [Koha-bugs] [Bug 27849] Koha::Token may access undefined C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27849 --- Comment #7 from Marcel de Rooy --- Created attachment 138449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138449&action=edit Bug 27849: (follow-up) Add test Compacting the code a bit too. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 04:21:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 02:21:18 +0000 Subject: [Koha-bugs] [Bug 31273] New: Add "Required by" or "Expected by" column for orders Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31273 Bug ID: 31273 Summary: Add "Required by" or "Expected by" column for orders Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Some systems have a "Required by" or "Expected by" column in acquisitions so that you know if you've ordered items and not received them within your expected timeframe. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 09:47:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 07:47:26 +0000 Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in memberentry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 --- Comment #12 from Jonathan Druart --- Created attachment 138444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138444&action=edit Bug 30874: Reduce number of category fetches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 19:49:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 17:49:18 +0000 Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search function for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 --- Comment #27 from Tomás Cohen Arazi --- Created attachment 138484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138484&action=edit Bug 30077: (QA follow-up) Avoid warning Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 15:42:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 13:42:38 +0000 Subject: [Koha-bugs] [Bug 29983] Display the return claims column in the circulation overdues page (overdue.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 --- Comment #15 from Jonathan Druart --- And why do we hide the column by default? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:00:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:00:22 +0000 Subject: [Koha-bugs] [Bug 29983] Display the return claims column in the circulation overdues page (overdue.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136334|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart --- Created attachment 138470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138470&action=edit Bug 29983: Display the pretend claim column in overdue.tt This patch displays the column "Return claims" from the page "moremember.pl" to the page "overdues.pl". Rebase on master. Test plan: 1) Use a patron with at least 1 item who should be checked out soon 2) Home > Patron > Patron details for [name] 3) Click on the 'Checkout' button down the page to show the full table and notice the "Return Claims" column 4) Now go to Home > Circulation > Overdues 5) Find the patron who has to check out and have a look at the table 6) Apply patch and repeat 4) and 5) -> the "Return Claim" column is now displayed on the table Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:31:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:31:20 +0000 Subject: [Koha-bugs] [Bug 30658] (Bug 29496 follow-up) CheckMandatorySubfields don't work properly with select field in serials-edit.tt for Supplemental issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30658 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 15:02:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 13:02:44 +0000 Subject: [Koha-bugs] [Bug 27849] Koha::Token may access undefined C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27849 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 08:00:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 06:00:37 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138252|0 |1 is obsolete| | --- Comment #65 from Jonathan Druart --- Created attachment 138425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138425&action=edit Bug 29897: Display author's identifiers This new enhancement add the capability to list the different identifiers of authors. It is helpful for research publications for instance. This patch will add a new "Author identifiers" tab on the detail page (OPAC) of a bibliographic record, with the list of the authors and their identifiers. On the detail page of the authority record, the same identifier list will be displayed. Test plan: Create some authority with 024 $a source $2 number $6 link to the source With the pref turned ON you will be able to see the new information. Sponsored-by: Orex Digital Signed-off-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 20:01:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 18:01:07 +0000 Subject: [Koha-bugs] [Bug 31278] ISBN and ISSN searching should quote the query terms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31278 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | CC| |katrin.fischer at bsz-bw.de, | |nick at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 08:24:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 06:24:49 +0000 Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136083|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 08:26:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 06:26:43 +0000 Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #63 from Alex Buckley --- Created attachment 138494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138494&action=edit Bug 25560: Database changes Sponsored-by: Waikato Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:44:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:44:54 +0000 Subject: [Koha-bugs] [Bug 31274] OPACSuggestionAutoFill must be 1 or 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31274 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cjf at wmu.se, | |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 19:32:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 17:32:35 +0000 Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392 --- Comment #21 from Tomás Cohen Arazi --- Created attachment 138483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138483&action=edit Bug 30392: (QA follow-up) Correct COMMENT Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 12:59:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 10:59:46 +0000 Subject: [Koha-bugs] [Bug 28702] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28702 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #5 from Jonathan Druart --- Hum, this didn't apply last month. error: sha1 information is lacking or useless (C4/Search.pm). and code is different in C4::XSLT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:11:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:11:16 +0000 Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:49:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:49:27 +0000 Subject: [Koha-bugs] [Bug 29579] Show saved SQL report ID in database query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579 --- Comment #19 from Jonathan Druart --- Created attachment 138467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138467&action=edit Bug 29579: (QA follow-up) Fix up t/db_dependent/Koha/Reports.t Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:06:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:06:53 +0000 Subject: [Koha-bugs] [Bug 28702] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28702 --- Comment #11 from Jonathan Druart --- I don't understand. In C4::Search we are building @hiddenitems to pass to XSLTParse4Display. Either you are right and we don't need that code, or you removed too much code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:13:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:13:35 +0000 Subject: [Koha-bugs] [Bug 31275] AdditionalContents.search_for_display returns branch block and All block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31275 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 08:27:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 06:27:51 +0000 Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #66 from Alex Buckley --- Created attachment 138497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138497&action=edit Bug 25560: Unit tests Test plan: 1. Run tests sudo koha-shell prove xt prove t/db_dependent/Circulation/issue.t Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 12:50:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 10:50:57 +0000 Subject: [Koha-bugs] [Bug 31281] Overdue notices reply-to email address of a branch not respected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 --- Comment #1 from Katrin Fischer --- I recenlty tested this similarly on master and there the correct reply-to was used (but I was missing Sender/return-path). How are you running the overdue notices script? (parameters) How are your overdue notice triggers set up? (do you use a default one or only branch specific?) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 15:09:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 13:09:07 +0000 Subject: [Koha-bugs] [Bug 28702] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28702 --- Comment #7 from Jonathan Druart --- What about hidden_items? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 09:09:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 07:09:09 +0000 Subject: [Koha-bugs] [Bug 31275] AdditionalContents.search_for_display returns branch block and All block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31275 --- Comment #2 from Katrin Fischer --- I don't think that assumption is correct in general. Often you have contents that are relevant for all branches and branch specific. The current behavior sounds correct to me. "All libraries" has never acted as a fallback for library specific. If this is about translations: default and specific language should not both show together. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 10:41:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 08:41:07 +0000 Subject: [Koha-bugs] [Bug 26440] Not renewable Supersedes On Hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26440 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen at koha-suomi.fi --- Comment #10 from Emmi Takkinen --- Patch no longer applies. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 18:24:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 16:24:40 +0000 Subject: [Koha-bugs] [Bug 31277] The LinkerOptions system preference should supply a list of available options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31277 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 15:21:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 13:21:18 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions using Google Books API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #153 from Jonathan Druart --- Please fix bug 31274 ASAP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 17:49:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 15:49:56 +0000 Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120353|0 |1 is obsolete| | Attachment #120354|0 |1 is obsolete| | Attachment #120355|0 |1 is obsolete| | Attachment #120356|0 |1 is obsolete| | Attachment #120357|0 |1 is obsolete| | Attachment #120358|0 |1 is obsolete| | Attachment #120359|0 |1 is obsolete| | Attachment #120360|0 |1 is obsolete| | Attachment #137310|0 |1 is obsolete| | --- Comment #45 from Nick Clemens --- Created attachment 138478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138478&action=edit Bug 26247: [ALTERNATE] Adding 2 Sysprefs for Search Terms This patch adds two system preferences options : 'RetainCatalogSearchTerms' and 'RetainPatronsSearchTerms'. If enabled, search terms will be retained between searches made from, respectively, the Search Catalog header and the Checkout or Search Patrons headers. If disabled, the searchbars will clear out between page loads. Attention, this is an alternate solution from the previous patches, ONLY apply this patch when testing and not the previous ones.Changed the syspref wording as well. To test: 1 - From the staff client, search some terms using the Check out header search bar. 2 - Confirm search terms are retained. 3 - Do Step 1-2 twice again, this time using the Search patrons and Search the catalog. 4 - Apply patch (again, only this one), update database. 5 - In the system preferences, look for RetainCatalogSearchTerms and set it to 'don't retain'. 6 - Use the checkout head search bar again, confirm that search terms aren't retained after page load. 7 - Do Step 5-6 once again, this time with the RetainPatronsSearchTerms and the Search Patrons and Search the catalog headers. 8 - Search boxes should be cleared. Thanks-to: Fridolin Somers and Nick Clemens for the bases I built on. Signed-off-by: Florian Bontemps Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 06:55:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 04:55:51 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #80 from Jonathan Druart --- Created attachment 138490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138490&action=edit Bug 29897: Don't display empty li It's ugly to move the li to the include file, but it's the easiest for now... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 08:25:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 06:25:30 +0000 Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136080|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:50:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:50:40 +0000 Subject: [Koha-bugs] [Bug 31271] "Edit search" always resets search options to keyword In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271 --- Comment #2 from Jonathan Druart --- (In reply to Jonathan Druart from comment #1) > Is it a regression? Hum, guess no. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:57:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:57:17 +0000 Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #33 from Katrin Fischer --- It's a search expansion, not an indexing change - searching for different variations. The search engine should not matter :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 09:29:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 07:29:40 +0000 Subject: [Koha-bugs] [Bug 30836] Elasticsearch mappings.yaml is out of sync with upgraded databases In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30836 --- Comment #6 from David Cook --- (In reply to Ere Maijala from comment #5) > I'm not sure if I can come up with a good solution. Automatically updating > current mappings can create problems when the defaults have been customized. This reminds me that we have this problem in other parts of Koha as well, and we've never found a good solution. For example, MARC Bibliographic Frameworks. Also, "Koha to MARC mapping". (In reply to Ere Maijala from comment #5) > What we might be able to do is to check, field by field, if the mappings > have been customized, and apply any changes only on top of old defaults. I'm > not sure if that's feasible in real life, but worth a thought. At least it > should be possible to check that any mappings required by Koha are available > regardless of their configuration, and add any that are missing completely. > Perhaps a warning about updated mappings during upgrade would be useful as > well. Actually... I think that this is probably the way to go. I'm not familiar with the Elasticsearch mappings setup, but in theory couldn't you compare default values against user-generated values? And then update everything but those? And then maybe have some way of telling users which values are default and which values aren't in a visual way? I imagine that might be easier for Elasticsearch mappings than it would for say "MARC Bibliographic Frameworks". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 17:52:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 15:52:59 +0000 Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #62 from Nick Clemens --- (In reply to Alex Buckley from comment #61) > Just to note I have a working patchset that can use YAML defined in the > UpdateNotForLoanStatusOnCheckin syspref like so: > > BK: > -1: 0 > > CR: > -2: 0 > > I am currently working on how to handle existing values in the syspref so > they still apply for all itemtypes for upgrading libraries. > Any suggestions would be much appreciated on this point. Maybe add an _ALL_ option - and then existing rules can be placed under that? Similar to UpdateItemLocationOnCheckin - but probably not make _ALL_ override the other rules as it does on that pref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 19:31:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 17:31:58 +0000 Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138233|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:29:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:29:17 +0000 Subject: [Koha-bugs] [Bug 31274] OPACSuggestionAutoFill must be 1 or 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31274 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 04:02:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 02:02:42 +0000 Subject: [Koha-bugs] [Bug 28806] Labels exported as PDF create zero sized PDF files. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 --- Comment #13 from David Cook --- (In reply to Chris Nighswonger from comment #12) > Furthermore, I am suspecting corrupted underlying data at least in some > cases. The may explain why your instance does not reproduce the bug. > > I'm going to keep poking around at it. Much appreciate you looking into it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:11:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:11:19 +0000 Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 --- Comment #24 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 02:40:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 00:40:56 +0000 Subject: [Koha-bugs] [Bug 31259] Downloading patron card PDF hangs the server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31259 --- Comment #4 from Chris Nighswonger --- (In reply to Jake Deery from comment #2) > Hi Chris, > > This is the URL: > https://support-staff.koha-ptfs.co.uk/cgi-bin/koha/patroncards/create-pdf. > pl?batch_id=2&template_id=8&layout_id=9&layout_back_id=9&start_card=1 > Could you post the results of the following query: SELECT * FROM creator_batches WHERE batch_id=2; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 07:23:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 05:23:03 +0000 Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 --- Comment #10 from Emmi Takkinen --- (In reply to Katrin Fischer from comment #9) > I can no longer replicate the problem with the test plan that worked before > :( Hmm, how about if you save authorised value for 952$8? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:11:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:11:25 +0000 Subject: [Koha-bugs] [Bug 31251] "Clear" patron attribute link does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31251 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 01:52:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 23:52:33 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #51 from David Cook --- *** Bug 31273 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:31:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:31:16 +0000 Subject: [Koha-bugs] [Bug 30658] (Bug 29496 follow-up) CheckMandatorySubfields don't work properly with select field in serials-edit.tt for Supplemental issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30658 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 13:13:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 11:13:24 +0000 Subject: [Koha-bugs] [Bug 31275] AdditionalContents.search_for_display returns branch block and All block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31275 --- Comment #6 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #2) > I don't think that assumption is correct in general. Often you have contents > that are relevant for all branches and branch specific. The current behavior > sounds correct to me. "All libraries" has never acted as a fallback for > library specific. This sounds counterintuitive. If you have a specific block, I would understand it to override the All branches stuff. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 19:11:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 17:11:11 +0000 Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #35 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:53:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:53:10 +0000 Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:45:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:45:34 +0000 Subject: [Koha-bugs] [Bug 30612] Add accountlines method to Koha::Checkout and Koha::Old::Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30612 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 10:51:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 08:51:18 +0000 Subject: [Koha-bugs] [Bug 31269] DataTables error when managing staged MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31269 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31138 CC| |jonathan.druart+koha at gmail. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31138 [Bug 31138] DataTables is not raising error to the end user -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:00:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:00:31 +0000 Subject: [Koha-bugs] [Bug 29983] Display the return claims column in the circulation overdues page (overdue.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 --- Comment #19 from Jonathan Druart --- Created attachment 138472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138472&action=edit Bug 29983: Show the column by default but hide if the feature is disabled Prior to this patch there was a blink, the column was displayed then hidden if the column was hidden. Also we could display the column even if the feature was disabled. Now the column is shown by default, and hidden if the feature is disabled. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 20:39:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 18:39:59 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #78 from Katrin Fischer --- I am sorry, I found another small issue. I tried to fix, but miss the right idea now: [% FOR identifier IN author.identifiers %]
  • [% PROCESS "authority-identifiers.inc" identifier => identifier %]
    • [% END %] This will create empty li elements, when $2 is not in the list of valid codes. I am providing a follow-up with some more information for the pref description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:45:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:45:43 +0000 Subject: [Koha-bugs] [Bug 30612] Add accountlines method to Koha::Checkout and Koha::Old::Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30612 --- Comment #11 from Jonathan Druart --- Created attachment 138463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138463&action=edit Bug 30612: Update schema files Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 12:52:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 10:52:53 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #82 from Katrin Fischer --- (In reply to Jonathan Druart from comment #81) > (In reply to Katrin Fischer from comment #78) > > I am sorry, I found another small issue. I tried to fix, but miss the right > > idea now: > > > > [% FOR identifier IN author.identifiers %] > >
  • > > [% PROCESS "authority-identifiers.inc" identifier => identifier %] > >
    • > > [% END %] > > > > This will create empty li elements, when $2 is not in the list of valid > > codes. > > > > I am providing a follow-up with some more information for the pref > > description. > > Done. > > I don't think it was a good idea to modify the original request and remove > the flexibility to have different source. We will see what is the feedback > once it's pushed. Have you seen the list of valid codes in the MARC documentation? :) The problem is that the user won't understand them and we need to build the URLs to make it useful. If we don't limit on $2, then we'd need some kind of configuration page. I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 09:12:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 07:12:37 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #86 from Jonathan Druart --- Created attachment 138441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138441&action=edit Bug 27272: Fix availability - OPAC Has to move some code to a method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 14:24:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 12:24:34 +0000 Subject: [Koha-bugs] [Bug 31278] ISBN and ISSN searching should quote the query terms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31278 --- Comment #1 from Katrin Fischer --- Quoting works nicely where we construct the searches from data int he records, but not sure about auto-quoting manual inputs because I believe this disables truncation with * in Zebra and possibly in Elasticsearch has a similar effect? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 15:28:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 13:28:02 +0000 Subject: [Koha-bugs] [Bug 28702] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28702 --- Comment #10 from Nick Clemens --- (In reply to Jonathan Druart from comment #7) > What about hidden_items? We already skip pushing them into the items array, so they do not need to be passed forward -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 01:52:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 23:52:32 +0000 Subject: [Koha-bugs] [Bug 31273] Add "Required by" or "Expected by" column for orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31273 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from David Cook --- (In reply to Katrin Fischer from comment #1) > We are working on the "expected by" with Bug 15348 - Change/Edit estimated > delivery date per order line :) Nice! I think that perfectly meets this goal. *** This bug has been marked as a duplicate of bug 15348 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:10:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:10:56 +0000 Subject: [Koha-bugs] [Bug 30028] Patron message delete confirmation untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30028 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 09:12:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 07:12:21 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138306|0 |1 is obsolete| | --- Comment #83 from Jonathan Druart --- Created attachment 138438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138438&action=edit Bug 27272: Allow to pass params and attributes to search_ordered -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 10:44:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 08:44:10 +0000 Subject: [Koha-bugs] [Bug 30658] (Bug 29496 follow-up) CheckMandatorySubfields don't work properly with select field in serials-edit.tt for Supplemental issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30658 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 19:38:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 17:38:11 +0000 Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392 --- Comment #22 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:41:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:41:46 +0000 Subject: [Koha-bugs] [Bug 24159] Allow daysMode for calculating due and renewal dates to be set at the circulation rules level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31235 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31235 [Bug 31235] UseDaysMode is used for calculating the expiration date for waiting holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 14:43:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 12:43:52 +0000 Subject: [Koha-bugs] [Bug 31274] OPACSuggestionAutoFill must be 1 or 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31274 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 10:08:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 08:08:50 +0000 Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16786 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 20:37:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 18:37:41 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138435|0 |1 is obsolete| | --- Comment #77 from Katrin Fischer --- Created attachment 138486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138486&action=edit Bug 29897: Adjust syspref description Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 19:11:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 17:11:14 +0000 Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search function for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:02:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:02:58 +0000 Subject: [Koha-bugs] [Bug 31274] OPACSuggestionAutoFill must be 1 or 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31274 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Invalid check fo |OPACSuggestionAutoFill must |OPACSuggestionAutoFill on |be 1 or 0 |opac-suggestions.tt | --- Comment #1 from Jonathan Druart --- The pref must be 0 or 1 in DB. We need to adjust the pref file, sysprefs.sql and update the existing value We shouldn't adjust the controllers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:16:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:16:13 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make branches.opac_info |Move branches.opac_info to |suitable for multi language |AdditionalContents allowing |use |multi language -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 18:56:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 16:56:54 +0000 Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #34 from Tomás Cohen Arazi --- Created attachment 138480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138480&action=edit Bug 23919: (QA follow-up) Tidy query build code This is really opinionated, but I found this to be much cleaner to read and thought it was worth pusing as well. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:34:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:34:14 +0000 Subject: [Koha-bugs] [Bug 31276] New: Report results are limited to 999, 999 no matter the actual number of results Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31276 Bug ID: 31276 Summary: Report results are limited to 999,999 no matter the actual number of results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org In Koha, any report that uses C4::Reports::Guided will be limited to 999,999 rows. This is causing problems for larger libraries where some reports may have over a million results. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 08:25:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 06:25:06 +0000 Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136082|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 15:02:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 13:02:53 +0000 Subject: [Koha-bugs] [Bug 28864] The patron search results in the patron card creator doesn't seem to use PatronsPerPage syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864 --- Comment #25 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 15:02:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 13:02:56 +0000 Subject: [Koha-bugs] [Bug 30612] Add account_lines method to Koha::[Old::]Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30612 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 08:01:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 06:01:15 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138259|0 |1 is obsolete| | --- Comment #72 from Jonathan Druart --- Created attachment 138432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138432&action=edit Bug 29897: Don't display identifier if not in the list Requested by QA, see comment 26. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 15:45:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 13:45:55 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137808|0 |1 is obsolete| | Attachment #137809|0 |1 is obsolete| | Attachment #137810|0 |1 is obsolete| | Attachment #137811|0 |1 is obsolete| | Attachment #137812|0 |1 is obsolete| | Attachment #137813|0 |1 is obsolete| | Attachment #137814|0 |1 is obsolete| | Attachment #137815|0 |1 is obsolete| | Attachment #137816|0 |1 is obsolete| | Attachment #137817|0 |1 is obsolete| | --- Comment #44 from Nick Clemens --- Created attachment 138505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138505&action=edit Bug 17170: DB Updates This patch adds the new table, permission, and a syspref to enable the feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 03:29:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 01:29:14 +0000 Subject: [Koha-bugs] [Bug 29994] Single label PDF export not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29994 --- Comment #14 from Chris Nighswonger --- (In reply to Caroline Cyr La Rose from comment #3) > The problem occurs when clicking the "Export" button in the table of items, This is important. There are two separate JS functions which are attached to these export "options." The Export button triggers one[1] while the 'Export selected items' triggers another[2]. In the former, batch_id is passed in via a TT variable; in the latter it is extracted from the data value of the element. I wonder if the latter is munged up somehow... If so, this could explain the discrepancy I mentioned in comment #12. So what we need to see is the resulting URL generated by each of these functions. Perhaps someone with the issue can grab these from the network tab in the browser debug console and post them here? [1] https://github.com/Koha-Community/Koha/blob/cdf34ce15603edfee5453ce7b232d2ceb0aa61e7/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt#L353 [2] https://github.com/Koha-Community/Koha/blob/cdf34ce15603edfee5453ce7b232d2ceb0aa61e7/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt#L364 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:10:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:10:59 +0000 Subject: [Koha-bugs] [Bug 30028] Patron message delete confirmation untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30028 --- Comment #26 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 07:01:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 05:01:10 +0000 Subject: [Koha-bugs] [Bug 31274] OPACSuggestionAutoFill must be 1 or 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31274 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 17:05:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 15:05:22 +0000 Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 Rachael changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rachael.laritz at inlibro.com Status|Needs Signoff |Failed QA --- Comment #11 from Rachael --- No 500 error is produced. Instead, it says "The job has been enqueued! It will be processed as soon as possible." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 15:03:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 13:03:05 +0000 Subject: [Koha-bugs] [Bug 30964] Add information about overdues and restrictions on the curbside pickup list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30964 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 13:30:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 11:30:46 +0000 Subject: [Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 15:00:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 13:00:14 +0000 Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 --- Comment #115 from Michal Denar --- I think this is a logical step forward. It would be great information on how the change behaves in production, but I believe it is applicable. +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 12:50:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 10:50:13 +0000 Subject: [Koha-bugs] [Bug 30468] koha-mysql does not honor Koha's timezone setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30468 --- Comment #8 from Jonathan Druart --- Created attachment 138457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138457&action=edit Bug 30468: Restore 'set -e' and remove echos -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 07:01:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 05:01:56 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138489|0 |1 is obsolete| | --- Comment #165 from Aleisha Amohia --- Created attachment 138493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138493&action=edit Bug 15326: (follow-up) Hide RSS feed if no news items If there are pages but no news items showing on the OPAC, the RSS feed container should not show. Sponsored-by: Horowhenua Libraries Trust -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 14:28:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 12:28:19 +0000 Subject: [Koha-bugs] [Bug 31282] Broken characters in patron_emailer.pl verbose mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31282 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 04:34:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 02:34:06 +0000 Subject: [Koha-bugs] [Bug 31279] New: Getting error 500 while doing a search in koha catalogue Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31279 Bug ID: 31279 Summary: Getting error 500 while doing a search in koha catalogue Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: nayema at mes.ac.in QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl I am facing an error in the cataloguing section in my koha 21.11.05 server. I did not receive any errors till saturday. However, this morning I started receiving an "error 500" while doing a catalog search on the staff page and even Web OPAC is throwing the same error. Even cataloguing of new items and records is also throwing same error. I have two instances and the other instance is working fine, there is no error. I dont have any issue with patron search and check in, check out. But while doing catalogue search it gives error. also I would like to mention that in the morning, the koha page was not appearing..it was showing internal server error...when I reboot my system the page appeared bt while doing search in catalogue it gives error 500. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 19:57:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 17:57:57 +0000 Subject: [Koha-bugs] [Bug 30543] Decouple DumpSearchQueryTemplate from other template dump preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30543 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 15:54:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 13:54:43 +0000 Subject: [Koha-bugs] [Bug 31284] New: Add a calendar log Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31284 Bug ID: 31284 Summary: Add a calendar log Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Changes to the calendar can affect various things in Koha, including due dates, fine calculation and sending of overdue notices. Sometimes a strange behavior can only be explained by holidays having been added or removed. In order to "debug" these issues, it would be great if changes to the calendar were logged. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 19:38:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 17:38:03 +0000 Subject: [Koha-bugs] [Bug 29579] Show saved SQL report ID in database query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 13:54:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 11:54:22 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 10:08:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 08:08:50 +0000 Subject: [Koha-bugs] [Bug 16786] Cannot add multiple emails addresses in an email field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12802 --- Comment #10 from Jonathan Druart --- See also bug 12802. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:29:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:29:04 +0000 Subject: [Koha-bugs] [Bug 29579] Show saved SQL report ID in database query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 08:25:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 06:25:18 +0000 Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136081|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 02:41:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 00:41:34 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #164 from Aleisha Amohia --- Created attachment 138489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138489&action=edit Bug 15326: (follow-up) Hide RSS feed if no news items If there are pages but no news items showing on the OPAC, the RSS feed container should not show. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 19:32:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 17:32:30 +0000 Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 138482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138482&action=edit Bug 30392: Set deleted_on when an item is (marked as) deleted We could like to track down when an item has been moved to the deleteditems table. Test plan: Created a new item, delete it Not that the deleteditems.deleted_on value is set correctly Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 19:32:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 17:32:01 +0000 Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138115|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 14:24:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 12:24:54 +0000 Subject: [Koha-bugs] [Bug 24616] Cannot copy notice to another branch if it already exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138242|0 |1 is obsolete| | --- Comment #6 from Emmi Takkinen --- Created attachment 138503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138503&action=edit Bug 24616: Allow copying notice to a branch even if it exists in that branch If you try to copy notice or slip to a branch which already has that notice or slip Koha won't let you save it. Instead pop-up saying branch already has that notice is displayed. This patch allows users to copy and override already existing notice or slip. To test: 1. Find notice which exists e.g. in all branches and branch A. 2. Copy that notice, add notice screen is displayed. 3. Press save. => Pop-up informing that notice already exists in branch A is displayed. 4. Apply this patch. 5. Repeat steps 2. and 3. 6. Pop-up to confirm overwrite of notice is displayed. => Confirm that if you press OK, notice is saved succesfully. => Otherwise, changes to notice should not be saved. Also try to save the notice you tested with as a new (same code) to branch A. Confirm that pop-up is displayed as it should be. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 10:27:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 08:27:15 +0000 Subject: [Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display local cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Jonathan Druart --- I would also create a "data" directory, not at the same level of the other .t files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 15:47:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 13:47:23 +0000 Subject: [Koha-bugs] [Bug 29983] Display the return claims column in the circulation overdues page (overdue.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 --- Comment #16 from Jonathan Druart --- I am about to submit patches here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 14:17:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 12:17:56 +0000 Subject: [Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 --- Comment #5 from Katrin Fischer --- I just ran into a case where the library has barcodes with trailing spaces from a batch of faulty barcode labels. Could it be an option to add the ItemBarcodeInputFilter into the item edit form too? (just wondering if you have an opinion about this, totally a separate bug) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:45:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:45:51 +0000 Subject: [Koha-bugs] [Bug 30612] Add accountlines method to Koha::Checkout and Koha::Old::Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30612 --- Comment #13 from Jonathan Druart --- Created attachment 138465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138465&action=edit Bug 30612: Rename other occurrences Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 15:55:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 13:55:44 +0000 Subject: [Koha-bugs] [Bug 21330] Add XSLT for authority normal view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #10 from Jérémy Breuillard --- (In reply to David Nind from comment #8) Trailing whitespaces are removed ! thanks :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 14:43:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 12:43:45 +0000 Subject: [Koha-bugs] [Bug 30879] Add option to sort components by biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 15:21:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 13:21:15 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 19:51:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 17:51:47 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 --- Comment #74 from Rhonda Kuiper --- +1 This would be a fantastic feature to have. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:48:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:48:50 +0000 Subject: [Koha-bugs] [Bug 31271] "Edit search" always resets search options to keyword In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- Is it a regression? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:31:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:31:47 +0000 Subject: [Koha-bugs] [Bug 31273] Add "Required by" or "Expected by" column for orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31273 --- Comment #1 from Katrin Fischer --- We are working on the "expected by" with Bug 15348 - Change/Edit estimated delivery date per order line :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 15:19:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 13:19:52 +0000 Subject: [Koha-bugs] [Bug 31274] New: OPACSuggestionAutoFill must be 1 or 0 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31274 Bug ID: 31274 Summary: OPACSuggestionAutoFill must be 1 or 0 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 14242 It's "yes" or "no". Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 [Bug 14242] Use ISBN-field to fill out purchase suggestions using Google Books API -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 05:57:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 03:57:01 +0000 Subject: [Koha-bugs] [Bug 31279] Getting error 500 while doing a search in koha catalogue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31279 --- Comment #1 from NAYEMA NASRIN --- Following error has been found: tail -f /var/log/koha/library/*.log ==> /var/log/koha/library/api-error.log <== ==> /var/log/koha/library/indexer-error.log <== ==> /var/log/koha/library/indexer-output.log <== ==> /var/log/koha/library/intranet-error.log <== [Tue Aug 02 09:14:36.841011 2022] [cgi:error] [pid 238347] [client 192.168.0.52:54524] AH01215: Use of uninitialized value $tag in hash element at /usr/share/perl5/MARC/Record.pm line 202.: /usr/share/koha/intranet/cgi-bin/catalogue/search.pl, referer: http://192.168.0.6:9001/index.html [Tue Aug 02 09:14:36.841141 2022] [cgi:error] [pid 238347] [client 192.168.0.52:54524] AH01215: Use of uninitialized value $tag in regexp compilation at /usr/share/perl5/MARC/Record.pm line 206.: /usr/share/koha/intranet/cgi-bin/catalogue/search.pl, referer: http://192.168.0.6:9001/index.html [Tue Aug 02 09:14:36.841262 2022] [cgi:error] [pid 238347] [client 192.168.0.52:54524] AH01215: Use of uninitialized value $tag in hash element at /usr/share/perl5/MARC/Record.pm line 207.: /usr/share/koha/intranet/cgi-bin/catalogue/search.pl, referer: http://192.168.0.6:9001/index.html [Tue Aug 02 09:14:36.841385 2022] [cgi:error] [pid 238347] [client 192.168.0.52:54524] AH01215: Can't call method "data" on an undefined value at /usr/share/koha/lib/C4/Search.pm line 1713.: /usr/share/koha/intranet/cgi-bin/catalogue/search.pl, referer: http://192.168.0.6:9001/index.html [Tue Aug 02 09:14:36.905102 2022] [cgi:error] [pid 238347] [client 192.168.0.52:54524] End of script output before headers: search.pl, referer: http://192.168.0.6:9001/index.html [Tue Aug 02 09:14:38.976898 2022] [cgi:error] [pid 238345] [client 192.168.0.1:49451] AH01215: Use of uninitialized value in string eq at /usr/share/koha/lib/C4/Context.pm line 784.: /usr/share/koha/intranet/cgi-bin/members/patronimage.pl, referer: http://192.168.0.6:9001/cgi-bin/koha/members/paycollect.pl?borrowernumber=84081&change_given= [Tue Aug 02 09:14:39.367292 2022] [cgi:error] [pid 238347] [client 192.168.0.52:54524] AH01215: Use of uninitialized value in string eq at /usr/share/koha/lib/C4/Context.pm line 784.: /usr/share/koha/intranet/cgi-bin/errors/500.pl, referer: http://192.168.0.6:9001/index.html [Tue Aug 02 09:14:52.871362 2022] [cgi:error] [pid 238425] [client 192.168.0.1:49453] AH01215: Use of uninitialized value in string eq at /usr/share/koha/lib/C4/Context.pm line 784.: /usr/share/koha/intranet/cgi-bin/members/paycollect.pl, referer: http://192.168.0.6:9001/cgi-bin/koha/members/paycollect.pl?borrowernumber=84081&change_given= [Tue Aug 02 09:14:55.993091 2022] [cgi:error] [pid 238447] [client 192.168.0.1:49455] AH01215: Use of uninitialized value in string eq at /usr/share/koha/lib/C4/Context.pm line 784.: /usr/share/koha/intranet/cgi-bin/members/boraccount.pl, referer: http://192.168.0.6:9001/cgi-bin/koha/members/paycollect.pl?borrowernumber=84081&change_given= [Tue Aug 02 09:14:58.992187 2022] [cgi:error] [pid 238447] [client 192.168.0.1:49455] AH01215: Use of uninitialized value in string eq at /usr/share/koha/lib/C4/Context.pm line 784.: /usr/share/koha/intranet/cgi-bin/members/patronimage.pl, referer: http://192.168.0.6:9001/cgi-bin/koha/members/boraccount.pl?borrowernumber=84081&payment_id=252196&change_given= ==> /var/log/koha/library/opac-error.log <== [Tue Aug 02 09:16:05.659083 2022] [cgi:error] [pid 238744] [client 185.191.171.34:32608] AH01215: Use of uninitialized value in substitution (s///) at /usr/share/koha/opac/cgi-bin/opac/opac-ISBDdetail.pl line 203.: /usr/share/koha/opac/cgi-bin/opac/opac-ISBDdetail.pl [Tue Aug 02 09:16:07.212881 2022] [cgi:error] [pid 238746] [client 40.77.167.15:12032] AH01215: C4::Context->userenv not defined! at /usr/share/koha/lib/C4/Items.pm line 767.: /usr/share/koha/opac/cgi-bin/opac/opac-detail.pl [Tue Aug 02 09:16:07.236357 2022] [cgi:error] [pid 238746] [client 40.77.167.15:12032] AH01215: No biblionumber tag for framework "BKS" at /usr/share/koha/lib/C4/Biblio.pm line 2659.: /usr/share/koha/opac/cgi-bin/opac/opac-detail.pl [Tue Aug 02 09:16:07.300138 2022] [cgi:error] [pid 238746] [client 40.77.167.15:12032] End of script output before headers: opac-detail.pl [Tue Aug 02 09:16:11.010817 2022] [cgi:error] [pid 238759] [client 185.191.171.4:55352] AH01215: C4::Context->userenv not defined! at /usr/share/koha/lib/C4/Items.pm line 767.: /usr/share/koha/opac/cgi-bin/opac/opac-detail.pl [Tue Aug 02 09:16:11.027934 2022] [cgi:error] [pid 238759] [client 185.191.171.4:55352] AH01215: No biblionumber tag for framework "" at /usr/share/koha/lib/C4/Biblio.pm line 2659.: /usr/share/koha/opac/cgi-bin/opac/opac-detail.pl [Tue Aug 02 09:16:11.092130 2022] [cgi:error] [pid 238759] [client 185.191.171.4:55352] End of script output before headers: opac-detail.pl [Tue Aug 02 09:16:19.371284 2022] [cgi:error] [pid 238782] [client 185.191.171.6:56588] AH01215: C4::Context->userenv not defined! at /usr/share/koha/lib/C4/Items.pm line 767.: /usr/share/koha/opac/cgi-bin/opac/opac-detail.pl [Tue Aug 02 09:16:19.392850 2022] [cgi:error] [pid 238782] [client 185.191.171.6:56588] AH01215: No biblionumber tag for framework "BKS" at /usr/share/koha/lib/C4/Biblio.pm line 2659.: /usr/share/koha/opac/cgi-bin/opac/opac-detail.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 17:55:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 15:55:28 +0000 Subject: [Koha-bugs] [Bug 31220] Error when attempting to export selected labels as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220 --- Comment #5 from Nick Clemens --- Created attachment 138479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138479&action=edit Bug 31220: (follow-up) Remove debug statements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 08:27:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 06:27:29 +0000 Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #65 from Alex Buckley --- Created attachment 138496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138496&action=edit Bug 25560: Define item-type specific rules in UpdateNotForLoanStatusOnCheckin This enhancement respects the 'item-level_itypes' syspref, so will look at the authoritative item type when determining to update the notforloan status. Test plan: 1. Set -1 to 'Ordered', and 1 to 'Not for Loan' in Administration > Authorised values > NOT_LOAN 2. Make sure the 'item-level_itypes' syspref is set to 'specific item' 3. Add the following rules in UpdateNotForLoanStatusOnCheckin system preference: -1: 0 4. Apply patch & update database cd installer/data/mysql sudo koha-shell ./updatedatabase.pl 5. Restart plack 6. Observe the UpdateNotForLoanStatusOnCheckin syspref values have updated to the following format: : -1: 0 : -1: 0 etc. Each item type setup in Koha has the existing rule(s) listed under it 7. Check in an 'Ordered' item of any item type and confirm it is changed to 'Available for loan' 8. Reset the UpdateNotForLoanStatusOnCheckin syspref to: BK: -1: 0 CD: 1: 0 9. Check-in an 'ordered' BK item (item level itype='BK') and observe the item's notforloan status updates 10. Check-in a 'Not for Loan' CD item (item level itype='CD') and observe the item's notforloan status updates 11. Check-in an 'ordered' DVD item (item level itype='DVD') and observe the items notforloan status does not change 12. Change 'item-level_itypes' syspref to 'bibliographic record' 13. Check-in an 'ordered' item (with biblio-level itemtype='BK' & item-level itype='DVD') and observe the item's notforloan status updates 14. Check-in an 'ordered' item (with biblio-level itemtype='DVD' & item-level itype='BK') and observe the item's notforloan status does not change Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:17:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:17:52 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #3 from Marcel de Rooy --- Created attachment 138473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138473&action=edit Bug 29144: First sort the HTML options Test plan: Check result while adding a new HTML customization entry. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 20:53:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 18:53:51 +0000 Subject: [Koha-bugs] [Bug 31250] Don't remove advanced/basic cataloging editor cookie on logout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31250 --- Comment #7 from Liz Rea --- knowing it *can* be fixed is a huge thing - I agree it's interesting for a backport. :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 13:33:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 11:33:01 +0000 Subject: [Koha-bugs] [Bug 31275] AdditionalContents.search_for_display returns branch block and All block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31275 --- Comment #7 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #3) > > However I've created a OpacNavRight for all and CPL, and only the one from > > all is displayed. And this is definitely a bug. > > Were you logged in? Branch specific only show to logged in users. I entered one for All and CPL. I am logged into CPL. And I see both OpacNav blocks. And I really wonder if that should be the case.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 17:49:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 15:49:50 +0000 Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 09:50:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 07:50:45 +0000 Subject: [Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual, | |release-notes-needed Summary|Exclude itemtypes from |Define itemtype specific |UpdateNotForLoanStatusOnChe |rules in the |ckin |UpdateNotForLoanStatusOnChe | |ckin system preference Text to go in the|Add boolean flag |The release notes|itemtypes.updatenotforloan, |UpdateNotForLoanStatusOnChe |enabled by default. |ckin system preference is | |now more flexible: you can |When |define rules to be applied |this item type flag is |to specific item types upon |disabled items of that type |check-in. |will not be updated on | |check-in. |Adding the item | |type code followed by a | |colon, and then in separate | |lines below each value pair | |rules with leading spaces. | |Example: | | | |BK | | -1: 0 | | | |If an | |item type is not defined in | |UpdateNotForLoanStatusOnChe | |ckin then items of that | |type will not have their | |notforloan status change on | |check-in, irrespective of | |their current notforloan | |value. --- Comment #67 from Alex Buckley --- (In reply to Nick Clemens from comment #62) > (In reply to Alex Buckley from comment #61) > > Just to note I have a working patchset that can use YAML defined in the > > UpdateNotForLoanStatusOnCheckin syspref like so: > > > > BK: > > -1: 0 > > > > CR: > > -2: 0 > > > > I am currently working on how to handle existing values in the syspref so > > they still apply for all itemtypes for upgrading libraries. > > Any suggestions would be much appreciated on this point. > > Maybe add an _ALL_ option - and then existing rules can be placed under > that? Similar to UpdateItemLocationOnCheckin - but probably not make _ALL_ > override the other rules as it does on that pref Thanks for that Nick. Am certainly happy to make that change if you would like. You will see in the attached patchset I have just added, that I'm listing the existing rules under each item type, like so: BK: -1: 0 CR: -1: 0 etc. The reason for this is I had a chat with Chris and we wondered whether having an _ALL_ option could create user confusion in which rule is overridden in a situation of conflicting rules, like: _ALL_: -1: 0 BK: -1: 2 By explicitly defining every item type and all rules that could apply for it, as I have in my attached patchset, it clarifies any potential confusion around rules overriding. It does, however, mean librarians will need to write a rule under every item type option for it to be applied to all items. I'm not sure if this should be 'Need signoff' so will leave it with the current setting for now. Happy to hear your thoughts though? :) Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 02:44:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 00:44:41 +0000 Subject: [Koha-bugs] [Bug 31259] Downloading patron card PDF hangs the server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31259 --- Comment #5 from Chris Nighswonger --- (In reply to Jake Deery from comment #2) > Hi Chris, > > This is the URL: > https://support-staff.koha-ptfs.co.uk/cgi-bin/koha/patroncards/create-pdf. > pl?batch_id=2&template_id=8&layout_id=9&layout_back_id=9&start_card=1 In addition, try this URL and see if it tight-loops: https://support-staff.koha-ptfs.co.uk/cgi-bin/koha/patroncards/create-pdf.pl?batch_id=2&template_id=8&layout_id=9&start_card=1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 15:46:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 13:46:21 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #50 from Nick Clemens --- Created attachment 138511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138511&action=edit Bug 17170: Add admin page for filters and ability to edit/save existing filters This patchset adds a new ability to save searches on the staff client, and display them in the results page on staff or opac as a new filter. New filters can be added from the resuilts page after a search, and there is an admin page for updating deleting and renaming filters There is a new permission to control management of these filters New filters can be added that are not displayed along with facets, this allows for building custom links using these filters to keep URLs shorter Due to bug 30528 testing in ES is recommended To test: 1 - Apply patches and update database and restart all 2 - Enable new system preference 'SavedSearchFilters' 3 - As superlibrarian perform a search in staff client, something broad like 'a' 4 - Note new 'Save search as filter' link on results page 5 - Click it, save search as new filter, check 'Staff client' visibility 6 - Perform another search 7 - Note the filter now appears above facets 8 - Click to it filter results 9 - Note results are limited by the new filter, and it is checked in the facets 10 - Confirm click the [x] removes the filter 11 - Go to administration->search filters 12 - Confirm the filter appears 13 - Edit and mark as OPAC visible 14 - Test OPAC to ensure it shows and can be applied/removed 15 - Copy URL with filter applied 16 - In adminsitration mark filter as not visible on staff or opac 17 - Confirm link above still works 18 - Create a new staff with catalogue and search filters permission 19 - Ensure they can access/save filters 20 - Remove filter permission and ensure they cannot 21 - Disable system preference 22 - Confirm links to search filters page are removed from admin home and admin sidebar 23 - Confirm filters do not appear on results and cannot be created 24 - Enable pref 25 - Create a filter 26 - From search filters page, click 'Edit search' 27 - Confirm you are taken to advanced search page letting you know which filter you are editing 28 - Confirm you can change searhc options and save 29 - Confirm you can perform the search from this page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:18:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:18:03 +0000 Subject: [Koha-bugs] [Bug 28702] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28702 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122785|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 138459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138459&action=edit Bug 28702: Make buildKohaItemsNamespace take an array If we fetch some of the authorised values and before hand we can reduce the amount of work needed in this routine. We stil require queries for pending holds and transfers, but these are lighter than fetching the items To test: 1 - Perform a search on the OPAC 2 - Add the results to a list 3 - Load the list several times and use developer tools (F12) to view the time to load in the network tab 4 - Repeat a search several times and use developer tools (F12) to view the time to load in the network tab 5 - Record the times noted above 6 - Apply patch 7 - Repeat the search and list view and compare to before the patch 8 - prove -v t/db_dependent/XSLT.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:31:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:31:30 +0000 Subject: [Koha-bugs] [Bug 31269] DataTables error when managing staged MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31269 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 19:45:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 17:45:49 +0000 Subject: [Koha-bugs] [Bug 29994] Single label PDF export not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29994 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE --- Comment #16 from Lucas Gass --- *** This bug has been marked as a duplicate of bug 31220 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:43:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:43:03 +0000 Subject: [Koha-bugs] [Bug 31274] OPACSuggestionAutoFill must be 1 or 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31274 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 14:59:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 12:59:03 +0000 Subject: [Koha-bugs] [Bug 30612] Add account_lines method to Koha::[Old::]Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30612 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Summary|Add accountlines method to |Add account_lines method to |Koha::Checkout and |Koha::[Old::]Checkout |Koha::Old::Checkout | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 20:13:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 18:13:05 +0000 Subject: [Koha-bugs] [Bug 30121] Cannot hide non-patron guarantor relationship via BorrowerUnwantedFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30121 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Andrew Fuerste-Henry --- (In reply to Lucas Gass from comment #5) > (In reply to Anneli Österman from comment #4) > > Relationship option appears in PatronQuickAddFields but unchecking it > > doesn't work when adding kid or juvenile via Quick add new patron. The > > Relationship field is still mandatory (required) under the surname field. > > > > The relationship filed disappears if I emtpy borrowerRelationship but that > > is not a good option because then the relationship field disappers from the > > Patron guarantor also. > > > > (Sorry, I didn't know what to choose to the Status) > > Yes, that is a good catch. The field is not called relationship in the quick > add field, instead it is called new_guarantor_relationship. > > So when we check relationship we get two fields new_guarantor_relationship > and relationship. > > I think in this case we want to exclude relation ship for the > PatronQuickAddFields pref. I'm still seeing this issue with the follow-up patch applied. "Relationship" shows in the Quick Add fields and is required even though it's not in BorrowerMandatory or PatronQuickAdd system preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 02:41:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 00:41:27 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 19:31:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 17:31:52 +0000 Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 12:42:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 10:42:57 +0000 Subject: [Koha-bugs] [Bug 31281] New: Overdue notices reply-to email address of a branch not respected Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 Bug ID: 31281 Summary: Overdue notices reply-to email address of a branch not respected Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: nason.bimbe at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The overdue notification email is sent from the correct email address as set up for the branch, however the reply-to email address though set for the branch is not the one used. The email has reply-to address of a different branch and not even the default one as set up in system preferences. Below is set up (however I have renamed the branches and email addresses for the purpose of this bug report). So what happened is the overdue notification was sent using LibraryB email address however the reply-to email address on the notification is the reply-to email address of LibraryA instead of LibraryB one. This is on Koha 21.11.05.000 LibraryA settings Email: librarya at mlibary.whatever Reply-To: librarya at mlibrary.whatever Return-Path: librarya at mlibrary.whatever LibraryA settings Email: libraryb at mlibary.whatever Reply-To: libraryb at mlibrary.whatever Return-Path: libraryb at mlibrary.whatever LibraryC settings Email: libraryc at mlibary.whatever Reply-To: libraryc at mlibrary.whatever Return-Path: libraryc at mlibrary.whatever SysPref setting: KohaAdminEmailAddress: library at library.whatever ReplytoDefault: library at library.whatever -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 19:38:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 17:38:06 +0000 Subject: [Koha-bugs] [Bug 29579] Show saved SQL report ID in database query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579 --- Comment #20 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 15:46:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 13:46:33 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #53 from Nick Clemens --- Created attachment 138514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138514&action=edit Bug 17170: Add the ability to create 'saved searches' for use as filters when searching the catalog This patch alters the code in the ES QueryBuilder. Reflecting how things are handled in build_query_compat we clean the query, but not the limits. In Zebra we simply recursivly call buildQuery, but the ES query structure This patchset adds a new ability to save searches on the staff client, and display them in the results page on staff or opac as a new filter. New filters can be added from the results page after a search, and there is an admin page for updating deleting and renaming filters There is a new permission to control management of these filters New filters can be added that are not displayed along with facets, this allows for building custom links using these filters to keep URLs shorter Due to bug 30528 testing in ES is recommended To test: 1 - Apply patches and update database and restart all 2 - Enable new system preference 'SavedSearchFilters' 3 - As superlibrarian perform a search in staff client, something broad like 'a' 4 - Note new 'Save search as filter' link on results page 5 - Click it, save search as new filter, check 'Staff client' visibility 6 - Perform another search 7 - Note the filter now appears above facets 8 - Click to it filter results 9 - Note results are limited by the new filter, and it is checked in the facets 10 - Confirm click the [x] removes the filter 11 - Go to administration->search filters 12 - Confirm the filter appears 13 - Edit and mark as OPAC visible 14 - Test OPAC to ensure it shows and can be applied/removed 15 - Copy URL with filter applied 16 - In adminsitration mark filter as not visible on staff or opac 17 - Confirm link above still works 18 - Create a new staff with catalogue and search filters permission 19 - Ensure they can access/save filters 20 - Remove filter permission and ensure they cannot 21 - Disable system preference 22 - Confirm links to search filters page are removed from admin home and admin sidebar 23 - Confirm filters do not appear on results and cannot be created 24 - Enable pref 25 - Create a filter 26 - From search filters page, click 'Edit search' 27 - Confirm you are taken to advanced search page letting you know which filter you are editing 28 - Confirm you can change searhc options and save 29 - Confirm you can perform the search from this page Signed-off-by: Michal Urban -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 10:16:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 08:16:33 +0000 Subject: [Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #69 from Alex Buckley --- Created attachment 138499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138499&action=edit Bug 25560: Unit tests Test plan: 1. Run tests sudo koha-shell prove xt prove t/db_dependent/Circulation/issue.t Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 15:02:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 13:02:41 +0000 Subject: [Koha-bugs] [Bug 27849] Koha::Token may access undefined C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27849 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 00:48:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 22:48:30 +0000 Subject: [Koha-bugs] [Bug 31274] OPACSuggestionAutoFill must be 1 or 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31274 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138476|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia --- Created attachment 138488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138488&action=edit Bug 31274: Make sure OPACSuggestionAutoFill is handled as a boolean everywhere The YAML preference definition defines it as a string ('yes' or 'no' the possible values). And the opac-suggestions.tt template has one occurence of the variable being compared to a string. This patch does: - fix the template - fixes opac.pref for 0|1 - adds an atomicupdate that takes care of moving 'yes' and 'no' to their respective boolean values. To test: 1. Change the syspref value to enable/disable 2. Check on the DB that the value is wrong: $ koha-mysql kohadev > SELECT value FROM systempreferences WHERE variable='OPACSuggestionAutoFill'; => FAIL: It is either 'yes' or 'no' depending on what you choose. 3. Apply this patch 4. Run: $ updatedatabase 5. Repeat 2 => SUCCESS: Values are now 0 or 1 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:05:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:05:40 +0000 Subject: [Koha-bugs] [Bug 28702] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28702 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28299 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:45:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:45:54 +0000 Subject: [Koha-bugs] [Bug 31235] UseDaysMode is used for calculating the expiration date for waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31235 --- Comment #2 from Jonathan Druart --- Koha::Calendar need a days_mode to be instantiated correctly. > and just use calendar or not. What does it mean? That we need the different days_mode option for ExcludeHolidaysFromMaxPickUpDelay? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 19:52:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 17:52:29 +0000 Subject: [Koha-bugs] [Bug 29994] Single label PDF export not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29994 --- Comment #17 from Chris Nighswonger --- Good catch. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 06:58:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 04:58:09 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 15:37:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 13:37:16 +0000 Subject: [Koha-bugs] [Bug 31274] Invalid check fo OPACSuggestionAutoFill on opac-suggestions.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31274 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Summary|OPACSuggestionAutoFill must |Invalid check fo |be 1 or 0 |OPACSuggestionAutoFill on | |opac-suggestions.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:00:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:00:49 +0000 Subject: [Koha-bugs] [Bug 29983] Display the return claims column in the circulation overdues page (overdue.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 --- Comment #20 from Jonathan Druart --- Jérémy, can you confirm that you agree with the 2 follow-ups please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 16:11:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 14:11:16 +0000 Subject: [Koha-bugs] [Bug 31274] OPACSuggestionAutoFill must be 1 or 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31274 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 19:38:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 17:38:08 +0000 Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 14:23:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 12:23:46 +0000 Subject: [Koha-bugs] [Bug 31282] Broken characters in patron_emailer.pl verbose mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31282 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 138502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138502&action=edit Screenshot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 20:42:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 18:42:03 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 13:53:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 11:53:43 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138490|0 |1 is obsolete| | --- Comment #85 from Jonathan Druart --- Created attachment 138501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138501&action=edit Bug 29897: Don't display empty li It's ugly to move the li to the include file, but it's the easiest for now... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 04:32:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 02:32:14 +0000 Subject: [Koha-bugs] [Bug 30818] REST API: Why does a wrong column name still cause a general 500 while validating exhaustively? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30818 NAYEMA NASRIN changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nayema at mes.ac.in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 17:16:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 15:16:11 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface - `h1` on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #136 from Jonathan Druart --- In virtualshelves/shelves.tt - Create a new list +

    Create a new list

     This is wrong, h1 is too big for a fieldset's legend. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 11:54:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 09:54:32 +0000 Subject: [Koha-bugs] [Bug 30327] Sort component parts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30327 --- Comment #47 from Johanna Räisä --- (In reply to Katrin Fischer from comment #46) > I am not sure really, it might be best to get feedback from Johanna and > others using this feature. The follow-up with bug 30879 requires > re-indexing, which makes it unsuitable for backporting. We use 21.11 but I added my first patch on top of it so we are fine for now. Updating for us is not a problem since we bring the features to our version separately. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 01:08:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 23:08:41 +0000 Subject: [Koha-bugs] [Bug 28008] Patron Clubs Bulk Enrollment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28008 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.hafen at washk12.org --- Comment #2 from Michael Hafen --- I was recently looking at the Patron Clubs and Patron Lists features. I would have prefered to use the Clubs feature, but lack of bulk enrollment forced me to use the Lists feature instead. I found the way Patron Lists handles adding multiple patrons to a list to be excellent, and suggest using that as a model for adding bulk enrollment to the Clubs feature. It allows searching for a patron from the List details, and can present a text box for entering either patron cardnumbers or patron id's, which would then be added. This would fulfill most of the requested functionality. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 14:22:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 12:22:07 +0000 Subject: [Koha-bugs] [Bug 31282] New: Broken characters in patron_emailer.pl verbose mode Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31282 Bug ID: 31282 Summary: Broken characters in patron_emailer.pl verbose mode Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz If you have non-ASCII characters in the printed notice, and run it with --verbose or without --commit, you will get broken characters. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 14:28:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 12:28:25 +0000 Subject: [Koha-bugs] [Bug 31282] Broken characters in patron_emailer.pl verbose mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31282 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 138504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138504&action=edit Bug 31282: Fix broken characters in patron_emailer.pl verbose mode To test: 1. Have a report containing: SELECT tomascohen at theke.io; 2. Have a members notice containing ¡ and other non-ASCII characters. 3. Run (changing the report number and notice code accordingly): $ kshell k$ perl misc/cronjobs/patron_emailer.pl --report 4 \ --notice BIRTHDAY --from tomascohen at theke.io --module members => FAIL: non-ASCII characters are broken 4. Apply this patch 5. Repeat 3 => SUCCESS: Things print correctly! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 21:13:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 19:13:16 +0000 Subject: [Koha-bugs] [Bug 28203] Add Match-heading search field and UNIMARC mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28203 --- Comment #4 from Fridolin Somers --- Looks like is is missing 245 for auth type NAME_COL -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 00:48:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 22:48:26 +0000 Subject: [Koha-bugs] [Bug 31274] OPACSuggestionAutoFill must be 1 or 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31274 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 12:54:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 10:54:19 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #84 from Katrin Fischer --- Patch is missing the changes to the include file! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 02:32:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 00:32:48 +0000 Subject: [Koha-bugs] [Bug 28806] Labels exported as PDF create zero sized PDF files. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 --- Comment #12 from Chris Nighswonger --- (In reply to David Cook from comment #10) > (In reply to Chris Nighswonger from comment #9) > > There have been many bug reports for labels/cards of late. I suspect a > > common regression may be behind them. > > Agreed although since no one touches the label creator it makes you wonder > what it could be... > Furthermore, I am suspecting corrupted underlying data at least in some cases. The may explain why your instance does not reproduce the bug. I'm going to keep poking around at it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 15:46:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 13:46:09 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #47 from Nick Clemens --- Created attachment 138508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138508&action=edit Bug 17170: Add API route for SearchFilters This adds the API routes and tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 1 19:11:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Aug 2022 17:11:08 +0000 Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 10:16:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 08:16:12 +0000 Subject: [Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #68 from Alex Buckley --- Created attachment 138498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138498&action=edit Bug 25560: Define item-type specific rules in UpdateNotForLoanStatusOnCheckin This enhancement respects the 'item-level_itypes' syspref, so will look at the authoritative item type when determining to update the notforloan status. Test plan: 1. Set -1 to 'Ordered', and 1 to 'Not for Loan' in Administration > Authorised values > NOT_LOAN 2. Make sure the 'item-level_itypes' syspref is set to 'specific item' 3. Add the following rules in UpdateNotForLoanStatusOnCheckin system preference: -1: 0 4. Apply patch & update database cd installer/data/mysql sudo koha-shell ./updatedatabase.pl 5. Restart plack 6. Observe the UpdateNotForLoanStatusOnCheckin syspref values have updated to the following format: : -1: 0 : -1: 0 etc. Each item type setup in Koha has the existing rule(s) listed under it 7. Check in an 'Ordered' item of any item type and confirm it is changed to 'Available for loan' 8. Reset the UpdateNotForLoanStatusOnCheckin syspref to: BK: -1: 0 CD: 1: 0 9. Check-in an 'ordered' BK item (item level itype='BK') and observe the item's notforloan status updates 10. Check-in a 'Not for Loan' CD item (item level itype='CD') and observe the item's notforloan status updates 11. Check-in an 'ordered' DVD item (item level itype='DVD') and observe the items notforloan status does not change Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 04:55:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 02:55:11 +0000 Subject: [Koha-bugs] [Bug 30962] REST API: Add endpoint /patrons/:patron_id/check_password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30962 --- Comment #10 from David Cook --- I was thinking about this again, and really it's very similar to an LDAP lookup. It requires staff-level authorization, and with the account lockout functionality, it wouldn't be any different from someone trying to brute force the OPAC login. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 15:46:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 13:46:17 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #49 from Nick Clemens --- Created attachment 138510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138510&action=edit Bug 17170: Handle search filters in query builders This patch updates the query building code to expand filters when searching and pass them back as part of the cgi and descriptive search strings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 03:30:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 01:30:49 +0000 Subject: [Koha-bugs] [Bug 29994] Single label PDF export not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29994 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 18:06:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 16:06:23 +0000 Subject: [Koha-bugs] [Bug 28553] Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 Rachael changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rachael.laritz at inlibro.com Status|Needs Signoff |Failed QA --- Comment #2 from Rachael --- Under NOTICES, nothing shows that an SMS was sent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 02:15:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 00:15:06 +0000 Subject: [Koha-bugs] [Bug 28806] Labels exported as PDF create zero sized PDF files. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |critical --- Comment #10 from David Cook --- (In reply to Chris Nighswonger from comment #9) > There have been many bug reports for labels/cards of late. I suspect a > common regression may be behind them. Agreed although since no one touches the label creator it makes you wonder what it could be... I notice the version says "21.11" but this bug report was raised before 21.11 was actually released... I run a modified 21.11.03 and I don't have label problems... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 10:19:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 08:19:59 +0000 Subject: [Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #70 from Alex Buckley --- Sorry I realised this patchset no longer checks what the item-level_itypes syspref is set to. I've removed that, as it is not checked on master, so I re-added the last two patches to reflect that. Ready for testing/review again :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 11:14:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 09:14:41 +0000 Subject: [Koha-bugs] [Bug 30327] Sort component parts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30327 --- Comment #46 from Katrin Fischer --- I am not sure really, it might be best to get feedback from Johanna and others using this feature. The follow-up with bug 30879 requires re-indexing, which makes it unsuitable for backporting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 14:25:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 12:25:06 +0000 Subject: [Koha-bugs] [Bug 24616] Cannot copy notice to another branch if it already exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 13:12:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 11:12:00 +0000 Subject: [Koha-bugs] [Bug 31275] AdditionalContents.search_for_display returns branch block and All block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31275 --- Comment #5 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #1) > That could be a feature... :) > > However I've created a OpacNavRight for all and CPL, and only the one from > all is displayed. And this is definitely a bug. > > Which block did you try? I encountered this behavior while testing bug 29144 which creates a OpacBranchInfo block to replace branches.opac_info. I somehow assumed the All branches to be a fallback for not having a branch specific one.. When i let the kohanews process directive display the return of AdditionalContents.get in the template, it shows both. Note that other templates perhaps show one result, but since the sort order is number, it will be a bit random which one appears? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 15:40:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 13:40:00 +0000 Subject: [Koha-bugs] [Bug 31283] New: Add timestamp to special_holidays and repeatable_holidays tables Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31283 Bug ID: 31283 Summary: Add timestamp to special_holidays and repeatable_holidays tables Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Holidays Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Sometimes libraries add holidays too late and we see strange things with due dates or fines. It would be great if the tables had a timestamp, so we can see when the holiday was added to the calendar to be able to explain what's going on. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 15:46:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 13:46:00 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #45 from Nick Clemens --- Created attachment 138506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138506&action=edit Bug 17170: DO NOT PUSH - Schema Updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 20:06:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 18:06:34 +0000 Subject: [Koha-bugs] [Bug 31220] Error when attempting to export selected labels as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 138516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138516&action=edit Bug 31220: Pass label batch and ids to label-create-pdf This patch fixes a malformed link to print selected labels and fix error: Can't locate object method "get_attr" via package "-2" (perhaps you forgot to load "-2"?) at /usr/share/koha/intranet/cgi-bin/labels/label-create-pdf.pl line 126. To test: 1 - Create a new label batch with some items 2 - Select 1 or more 3 - Export selected labels 4 - Download as PDF 5 - It works! Signed-off-by: Sally Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 10:15:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 08:15:45 +0000 Subject: [Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138496|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 19:52:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 17:52:47 +0000 Subject: [Koha-bugs] [Bug 31220] Error when attempting to export selected labels as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger at foundations.ed | |u -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 15:46:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 13:46:25 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #51 from Nick Clemens --- Created attachment 138512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138512&action=edit Bug 17170: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 14:43:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 12:43:50 +0000 Subject: [Koha-bugs] [Bug 31274] OPACSuggestionAutoFill must be 1 or 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31274 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 10:15:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 08:15:35 +0000 Subject: [Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138497|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 23:40:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 21:40:25 +0000 Subject: [Koha-bugs] [Bug 31279] Getting error 500 while doing a search in koha catalogue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31279 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- Hi Nayema, this looks like a configuration issue: Have you made any changes to the frameworks Koha installs with? This is the hint: No biblionumber tag for framework "BKS" You don't want to change the 999 tag as it holds the biblionumber/biblioitemnumber. If it's changed you might end up with records without biblionumber that cannot be indexed and therefore not searched. First thing you need to do is to reinstate correct frameworks, then you can try to fix the records. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 23:34:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 21:34:05 +0000 Subject: [Koha-bugs] [Bug 21173] Run auto item modifications by age every hour and set the item age unit to hours In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #18 from Alex Buckley --- Working on reviving this patchset. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 15:54:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 13:54:18 +0000 Subject: [Koha-bugs] [Bug 21330] Add XSLT for authority normal view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130276|0 |1 is obsolete| | --- Comment #9 from Jérémy Breuillard --- Created attachment 138515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138515&action=edit Bug 21330: Add xslt for authority normal view in OPAC This patch provides a xslt stylesheet on authority normal view in OPAC. Have a look on opac-authoritiesdetail.pl Test plan: 1)You need the file 'UNIMARCauthResults.xsl' -> get it in the patch from Bug 11083 2)For testing make sure to have at least one or more authorities defined 3)OPAC: Home > Authority search(Submit) > Authority search results 4)Click details on a result and notice the view 5)Apply patch 6)INTRA: Home > Administration > System preferences ->find "AuthorityXSLTOpacDetailsDisplay" 7)Write the path where your file is, ex: '/home/koha/src/UNIMARCauthResults.xsl' 8)Save changes 9)Repeat 3) and 4) and notice the display This is a similar bug: Bug 30036 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 09:00:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 07:00:54 +0000 Subject: [Koha-bugs] [Bug 30836] Elasticsearch mappings.yaml is out of sync with upgraded databases In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30836 --- Comment #5 from Ere Maijala --- I'm not sure if I can come up with a good solution. Automatically updating current mappings can create problems when the defaults have been customized. What we might be able to do is to check, field by field, if the mappings have been customized, and apply any changes only on top of old defaults. I'm not sure if that's feasible in real life, but worth a thought. At least it should be possible to check that any mappings required by Koha are available regardless of their configuration, and add any that are missing completely. Perhaps a warning about updated mappings during upgrade would be useful as well. I think that in many cases requiring resetting to defaults would be too destructive. Having to redo all customizations could be pretty a lot of work unless you manage them in a customized mappings.yaml or something. It would be useful to have a tool that would show the differences between current and default mappings. This would make it easier to determine any manual changes needed or useful. All in all, I'm not sure I like having the database part of the configuration. Sure, the UI makes it easier to start changing the mappings, but if you need to do more, it's cumbersome. Also changing the settings can have consequences that you need to be aware of, and sometimes I feel it should not be that easy to change them. Regardless of how the mappings update is managed, any changes will need to trigger a prominent notification that reindexing is required. Sorry for this being a collection of random thoughts... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 12:53:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 10:53:32 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #83 from Katrin Fischer --- I mean I stand with the decision, but it will be good to get more feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 22:38:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 20:38:27 +0000 Subject: [Koha-bugs] [Bug 31285] New: Regression: item.datelastseen does not update on duplicating item Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31285 Bug ID: 31285 Summary: Regression: item.datelastseen does not update on duplicating item Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Previous to 21.11, when you would duplicate an item record, the date last seen would be automatically updated. This no longer happens - the date last seen is retained from the original item. To replicate: >From a bib record with an item attached, select Edit - Edit items >From the actions tab, select duplicate Update the date accessioned and click save >From the Normal tab, note that the new item has an updated date accessioned, but the date last seen has not been updated. This behavior is now different from when adding a new item - when a new item is added, the date last seen is automatically set to the current date. This is the expected behavior when adding an item. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 20:31:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 18:31:59 +0000 Subject: [Koha-bugs] [Bug 31220] Error when attempting to export selected labels as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220 Daniel Gaghan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.gaghan at pueblolibrary | |.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 13:45:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 11:45:40 +0000 Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392 --- Comment #23 from Tomás Cohen Arazi --- Created attachment 138500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138500&action=edit Bug 30392: (QA follow-up) Remove deleted_on from the API response Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 20:56:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 18:56:41 +0000 Subject: [Koha-bugs] [Bug 29191] Linking biblio headings to authorities doesn't work with subdivisions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29191 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28203 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 13:58:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 11:58:44 +0000 Subject: [Koha-bugs] [Bug 31275] AdditionalContents.search_for_display returns branch block and All block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31275 --- Comment #8 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #7) > (In reply to Katrin Fischer from comment #3) > > > However I've created a OpacNavRight for all and CPL, and only the one from > > > all is displayed. And this is definitely a bug. > > > > Were you logged in? Branch specific only show to logged in users. > > I entered one for All and CPL. I am logged into CPL. And I see both OpacNav > blocks. And I really wonder if that should be the case.. We have inherited this from the news module. I think changing it now could be quite disruptive to libraries as the OPAC behaviour would change. I think if we want a fallback, maybe we could have an additional checkbox or so? "Use only if no library specific content was generated" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 13:19:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 11:19:19 +0000 Subject: [Koha-bugs] [Bug 28806] Labels exported as PDF create zero sized PDF files. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 --- Comment #15 from Chris Nighswonger --- (In reply to Dietrich from comment #14) > I'd try to help/fix this - however I know neither pearl nor php (though I > know quite some other programming languages). How would I debug the issue... > it is always easier to debug if there is some kind of error. But I can't > find any. But maybe I'm just looking at the wrong places. If you could help > me getting started that would be great. Please post a PDF from your BAR type batch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 15:46:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 13:46:05 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #46 from Nick Clemens --- Created attachment 138507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138507&action=edit Bug 17170: Update schema for boolean -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 21:03:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 19:03:15 +0000 Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the staff interface with separate system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 22:13:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 20:13:47 +0000 Subject: [Koha-bugs] [Bug 31158] Can't filter suggestions by date ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31158 Rachael changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 14:43:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 12:43:47 +0000 Subject: [Koha-bugs] [Bug 30879] Add option to sort components by biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #32 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 20:04:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 18:04:43 +0000 Subject: [Koha-bugs] [Bug 31220] Error when attempting to export selected labels as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138012|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 20:56:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 18:56:41 +0000 Subject: [Koha-bugs] [Bug 28203] Add Match-heading search field and UNIMARC mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28203 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29191 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 19:45:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 17:45:49 +0000 Subject: [Koha-bugs] [Bug 31220] Error when attempting to export selected labels as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |isabel.pineda at ds.edu.sv --- Comment #6 from Lucas Gass --- *** Bug 29994 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 20:50:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 18:50:43 +0000 Subject: [Koha-bugs] [Bug 31185] Link authorities automatically doesn't detect duplicate authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Rachael changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 22:13:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 20:13:51 +0000 Subject: [Koha-bugs] [Bug 31158] Can't filter suggestions by date ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31158 --- Comment #3 from Rachael --- Created attachment 138519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138519&action=edit Bug 30879: DBRev 22.06.00.031 Signed-off-by: Tomas Cohen Arazi Signed-off-by: Rachael Laritz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 18:50:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 16:50:59 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu --- Comment #73 from Michaela Sieber --- +1 and voted :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 20:21:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 18:21:55 +0000 Subject: [Koha-bugs] [Bug 31222] DBIC queries for batch mod can be very large In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31222 Rachael changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |rachael.laritz at inlibro.com --- Comment #2 from Rachael --- Batch modifications changes each item. Ex. Modifying the Source of classification or shelving scheme to Dewey Decimal Classification gets applied. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 08:27:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 06:27:07 +0000 Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #64 from Alex Buckley --- Created attachment 138495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138495&action=edit Bug 25560: Template changes Sponsored-by: Waikato Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 20:06:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 18:06:40 +0000 Subject: [Koha-bugs] [Bug 31220] Error when attempting to export selected labels as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 138517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138517&action=edit Bug 31220: (QA follow-up) Add missing filter Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 15:46:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 13:46:13 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #48 from Nick Clemens --- Created attachment 138509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138509&action=edit Bug 17170: Add search filters to staff and opac interfaces This patch displays the filters on the results pages with the facets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 03:34:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 01:34:12 +0000 Subject: [Koha-bugs] [Bug 29994] Single label PDF export not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29994 --- Comment #15 from Chris Nighswonger --- Former and latter should be swapped in comment #14... where's the edit comment options when you need it? ;-P -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 20:50:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 18:50:47 +0000 Subject: [Koha-bugs] [Bug 31185] Link authorities automatically doesn't detect duplicate authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 --- Comment #3 from Rachael --- Created attachment 138518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138518&action=edit Bug 31185 - Link authorities automatically doesn't detect duplicate authorities Signed-off-by: Rachael Laritz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 03:31:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 01:31:43 +0000 Subject: [Koha-bugs] [Bug 29994] Single label PDF export not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29994 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 06:51:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 04:51:14 +0000 Subject: [Koha-bugs] [Bug 28806] Labels exported as PDF create zero sized PDF files. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 --- Comment #14 from Dietrich --- I'd try to help/fix this - however I know neither pearl nor php (though I know quite some other programming languages). How would I debug the issue... it is always easier to debug if there is some kind of error. But I can't find any. But maybe I'm just looking at the wrong places. If you could help me getting started that would be great. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 09:43:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 07:43:09 +0000 Subject: [Koha-bugs] [Bug 31275] AdditionalContents.search_for_display returns branch block and All block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31275 --- Comment #4 from Jonathan Druart --- (In reply to Katrin Fischer from comment #3) > > However I've created a OpacNavRight for all and CPL, and only the one from > > all is displayed. And this is definitely a bug. > > Were you logged in? Branch specific only show to logged in users. Ha, that might be it! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 03:29:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 01:29:24 +0000 Subject: [Koha-bugs] [Bug 31276] Report results are limited to 999, 999 no matter the actual number of results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31276 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 02:42:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 00:42:02 +0000 Subject: [Koha-bugs] [Bug 29994] Single label PDF export not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29994 --- Comment #13 from Chris Nighswonger --- If one of the folks experiencing this issue could post both the label-edit-batch.pl URL and the label-create-pdf.pl URL for your failure case, please. Also, please post the output from the following query limited by the batch_id of your failure case: SELECT * FROM creator_batches WHERE batch_id=; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 16:20:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 14:20:20 +0000 Subject: [Koha-bugs] [Bug 27494] Expand OpacItemLocation for Unimarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27494 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jeremy.breuillard at biblibre. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 13:30:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 11:30:36 +0000 Subject: [Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #4 from Katrin Fischer --- I did some more research and it looks like we already use the filter like that in a lot of places. If there is an issue with libsuite8 we should probably move it to a separate bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 02:30:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 00:30:49 +0000 Subject: [Koha-bugs] [Bug 31259] Downloading patron card PDF hangs the server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31259 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- I had the same problem years ago but fixed it with bug 22429 so must be something else causing the problem now. The infinite loop is probably in the "while(1)" block, and it probably relates to whatever data you're feeding in. Are you able to replicate this problem using koha-testing-docker? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 19:06:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 17:06:58 +0000 Subject: [Koha-bugs] [Bug 31276] Report results are limited to 999, 999 no matter the actual number of results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31276 Rachael changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rachael.laritz at inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 20:04:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 18:04:40 +0000 Subject: [Koha-bugs] [Bug 31220] Error when attempting to export selected labels as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 09:09:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 07:09:46 +0000 Subject: [Koha-bugs] [Bug 31275] AdditionalContents.search_for_display returns branch block and All block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31275 --- Comment #3 from Katrin Fischer --- > However I've created a OpacNavRight for all and CPL, and only the one from > all is displayed. And this is definitely a bug. Were you logged in? Branch specific only show to logged in users. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 08:25:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 06:25:40 +0000 Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136079|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 15:46:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 13:46:29 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #52 from Nick Clemens --- Created attachment 138513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138513&action=edit Bug 17170: (follow-up) Display search filters admin links when apprropriate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 2 20:04:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 18:04:47 +0000 Subject: [Koha-bugs] [Bug 31220] Error when attempting to export selected labels as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138479|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 00:28:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 22:28:35 +0000 Subject: [Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #27 from Victor Grousset/tuxayo --- It seems there is an issue (but I'm not sure I'm using serials right) > 3. Generate some late/missing serials So I click "Receive" and replace "expected" by "late" or "missing" and then "save" In my case I did one late and one missing. Then changed the sub vendor to S2. And did one late and one missing. Now on claims for S1 I have one late, one missing, **one late** I had already changed to S2! For S2 I have one missing, one expected. **But not one late** Tried again and same result. So the 1st after the transition (editing the sub to change vendor) is on the wrong vendor. ==== The tests pass. the first "# 3 is late" looks like it should say "# 2 is late", should it? Why the does the test expects 2 late issues for bookseller1 and 1 late issue for bookseller2 Shouldn't it be 1 and 2? Or maybe I don't get how late serial work and the test is correct and the behavior of my manual testing is correct? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 01:04:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 23:04:50 +0000 Subject: [Koha-bugs] [Bug 31220] Error when attempting to export selected labels as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 01:36:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Aug 2022 23:36:40 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED --- Comment #419 from Aleisha Amohia --- Thanks all, I'm taking a look now and will pass on anything I'm not sure about! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 03:10:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 01:10:36 +0000 Subject: [Koha-bugs] [Bug 31259] Downloading patron card PDF hangs the server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31259 --- Comment #7 from Chris Nighswonger --- (In reply to Jake Deery from comment #0) > Hi, > > One of our customers is having an issue with their patron card creator, that > we have been able to replicate on our support server. Both installations are > Debian package installations, and both installations run atop Debian 10. > > When one goes to create a 'patron card' using the build-in patron card Are you using your customer's data? Would it be possible to get a copy of the exact text that is to be put on the card? You can send it directly via email to avoid posting here if needed. Otherwise if it's sample data, I'll look there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 03:16:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 01:16:57 +0000 Subject: [Koha-bugs] [Bug 31286] New: Embed see-from headings into bibliographic records export Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31286 Bug ID: 31286 Summary: Embed see-from headings into bibliographic records export Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz In misc/export_records.pl add an option to add see-from headings (from authorities 4xx) into bibliographic records export. Like it is done during record indexing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 03:17:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 01:17:02 +0000 Subject: [Koha-bugs] [Bug 31286] Embed see-from headings into bibliographic records export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31286 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17385 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 03:17:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 01:17:02 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31286 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 03:17:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 01:17:09 +0000 Subject: [Koha-bugs] [Bug 31286] Embed see-from headings into bibliographic records export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31286 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28639 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 03:17:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 01:17:09 +0000 Subject: [Koha-bugs] [Bug 28639] Embed see-from headings (from authorities) into bibliographic records at OAI repository level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31286 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 03:31:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 01:31:55 +0000 Subject: [Koha-bugs] [Bug 31286] Embed see-from headings into bibliographic records export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31286 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 03:31:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 01:31:59 +0000 Subject: [Koha-bugs] [Bug 31286] Embed see-from headings into bibliographic records export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31286 --- Comment #1 from Fridolin Somers --- Created attachment 138520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138520&action=edit Bug 31286: Embed see-from headings into bibliographic records export In misc/export_records.pl add an option to add see-from headings (from authorities 4xx) into bibliographic records export. Like it is done during record indexing. Test plan : 1) Choose a biblio record having a field (for example 650) linked to an authority with a see-form. 2) Export this record without see-from headings : misc/export_records.pl --starting_biblionumber=X --ending_biblionumber=X --filename /tmp/record_without.xml --format xml 3) Export this record with see-from headings : misc/export_records.pl --starting_biblionumber=X --ending_biblionumber=X --filename /tmp/record_with.xml --format xml --embed_see_from_headings 4) Compare /tmp/record_without.xml and /tmp/record_with.xml => you should see two 650, one with main heading and one with see-from heading -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 07:42:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 05:42:02 +0000 Subject: [Koha-bugs] [Bug 28806] Labels exported as PDF create zero sized PDF files. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 --- Comment #16 from Manos PETRIDIS --- Created attachment 138521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138521&action=edit barcode-only PDF export (A4 size) Note that all 9 selected items appear on print. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 07:43:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 05:43:31 +0000 Subject: [Koha-bugs] [Bug 28806] Labels exported as PDF create zero sized PDF files. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 --- Comment #17 from Manos PETRIDIS --- Created attachment 138522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138522&action=edit barcode-only PDF export (roll size) Note that only 3 of 9 selected items appear on print. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 07:53:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 05:53:14 +0000 Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck modules for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444 --- Comment #15 from Alex Buckley --- Hi David, Thank you for your questions and my apologies for my late reply. The exact workflow we are wanting to follow with this patchset is: 1. A patron logs into the OPAC via SSO shibboleth 2. They visit the self-checkout page 3. As Koha is configured with AutoSelfCheckAllowed = allowed, and AutoSelfCheckId and AutoSelfCheckPass set to a patron with 'circulate' permissions that patron is used to automatically authenticate to the self-checkout page 4. Instead of displaying a form asking for the identity (username/password or cardnumber) of the patron we want to check out to, our patch skips that form by identifying the person logged into the OPAC as the patron to check out to So in short, the only difference in behaviour our patchset should have is skipping the form asking for the identity of the patron we want to checkout too. Does this help clarify the intent? Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 08:01:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 06:01:20 +0000 Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck modules for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444 --- Comment #16 from David Cook --- (In reply to Alex Buckley from comment #15) > Hi David, > > Thank you for your questions and my apologies for my late reply. > > The exact workflow we are wanting to follow with this patchset is: > > 1. A patron logs into the OPAC via SSO shibboleth > > 2. They visit the self-checkout page > > 3. As Koha is configured with AutoSelfCheckAllowed = allowed, and > AutoSelfCheckId and AutoSelfCheckPass set to a patron with 'circulate' > permissions that patron is used to automatically authenticate to the > self-checkout page > > 4. Instead of displaying a form asking for the identity (username/password > or cardnumber) of the patron we want to check out to, our patch skips that > form by identifying the person logged into the OPAC as the patron to check > out to > > So in short, the only difference in behaviour our patchset should have is > skipping the form asking for the identity of the patron we want to checkout > too. > > Does this help clarify the intent? Thanks, Alex. That does clarify things a bit. What happens after the user clicks "Finish" and "End session" in the self-checkout? Since they're still logged into the Shibboleth IdP, won't they get stuck in an infinite loop? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 08:01:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 06:01:59 +0000 Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck modules for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444 --- Comment #17 from David Cook --- (In reply to David Cook from comment #16) > What happens after the user clicks "Finish" and "End session" in the > self-checkout? Since they're still logged into the Shibboleth IdP, won't > they get stuck in an infinite loop? Well, not an infinite loop. But a loop until they log out of the Shibboleth IdP or that session expires. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 08:11:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 06:11:10 +0000 Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck modules for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444 --- Comment #18 from Alex Buckley --- (In reply to David Cook from comment #16) > (In reply to Alex Buckley from comment #15) > > Hi David, > > > > Thank you for your questions and my apologies for my late reply. > > > > The exact workflow we are wanting to follow with this patchset is: > > > > 1. A patron logs into the OPAC via SSO shibboleth > > > > 2. They visit the self-checkout page > > > > 3. As Koha is configured with AutoSelfCheckAllowed = allowed, and > > AutoSelfCheckId and AutoSelfCheckPass set to a patron with 'circulate' > > permissions that patron is used to automatically authenticate to the > > self-checkout page > > > > 4. Instead of displaying a form asking for the identity (username/password > > or cardnumber) of the patron we want to check out to, our patch skips that > > form by identifying the person logged into the OPAC as the patron to check > > out to > > > > So in short, the only difference in behaviour our patchset should have is > > skipping the form asking for the identity of the patron we want to checkout > > too. > > > > Does this help clarify the intent? > > Thanks, Alex. That does clarify things a bit. > > What happens after the user clicks "Finish" and "End session" in the > self-checkout? Since they're still logged into the Shibboleth IdP, won't > they get stuck in an infinite loop? Thanks David. Ideally, they should be redirected back to the OPAC home page. I see on stock 22.05 that if you hit 'Finish' you're redirected to the form for entering cardnumber or username/password. Checking a test site I have this patchset running on if I hit 'Finish' the self-checkout page re-loads and I am still logged in - see attached screenshot. I had a discussion with Chris and we thought it would be a good idea if I move some of the patchset logic I have in C4/Auth->checkauth() and sco-main.pl into a new subroutine in C4/Auth_with_shibboleth.pm. What are your thoughts on this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 08:11:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 06:11:48 +0000 Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck modules for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444 --- Comment #19 from Alex Buckley --- Created attachment 138523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138523&action=edit Still logged into self checkout page after selecting Finish -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 08:58:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 06:58:33 +0000 Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck modules for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444 --- Comment #20 from David Cook --- (In reply to Alex Buckley from comment #18) > Ideally, they should be redirected back to the OPAC home page. I see on > stock 22.05 that if you hit 'Finish' you're redirected to the form for > entering cardnumber or username/password. Yeah, out of the box, it redirects back to sco-main.pl, which makes sense for physical self-checkout kiosks. It could be interesting to have a "SelfCheckoutRedirect" system preference that specifies where the user gets redirected to. Or even an additional parameter for sco-main.pl like "mode=online" which causes "Finish" to return to opac-main.pl instead of sco-main.pl. > Checking a test site I have this patchset running on if I hit 'Finish' the > self-checkout page re-loads and I am still logged in - see attached > screenshot. That's what I was expecting as well. I suppose in your scenario you wouldn't want the user to be logged out from the IdP, because they might still have other OPAC work that they want to do. > I had a discussion with Chris and we thought it would be a good idea if I > move some of the patchset logic I have in C4/Auth->checkauth() and > sco-main.pl into a new subroutine in C4/Auth_with_shibboleth.pm. What are > your thoughts on this? I'd need to double-check C4/Auth->checkauth() and C4/Auth_with_shibboleth.pm, but I agree about moving much of the code out of sco-main.pl and putting it into C4/Auth_with_shibboleth.pm for sure. -- I'm waiting on some client requirements for SAML SSO in SCO, and when I get those I should be able to provide more useful feedback/assistance as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 09:08:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 07:08:58 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #67 from Katrin Fischer --- We just updated to 20.11.19 and Address::Email is missing/hasn't been installed it looks like. Is this a local glitch or could it be a real issue? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 10:11:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 08:11:34 +0000 Subject: [Koha-bugs] [Bug 30952] New interface for staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 12:15:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 10:15:16 +0000 Subject: [Koha-bugs] [Bug 31222] DBIC queries for batch mod can be very large In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31222 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Nick Clemens --- (In reply to Rachael from comment #2) > Batch modifications changes each item. Ex. Modifying the Source of > classification or shelving scheme to Dewey Decimal Classification gets > applied. Hi Rachel, I am not sure what you mean here? Batch modification should update each item, is it updating more fields than intended? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 12:39:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 10:39:26 +0000 Subject: [Koha-bugs] [Bug 31287] New: D-Tech kiosk can't connect to LMS (Koha) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31287 Bug ID: 31287 Summary: D-Tech kiosk can't connect to LMS (Koha) Change sponsored?: --- Product: Koha Version: unspecified Hardware: PC OS: Windows Status: NEW Severity: blocker Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: simon.rowe at student.lst.ac.uk QA Contact: testopia at bugs.koha-community.org We are London School of Theology and use Koha as our LMS. We use a D-Tech Check-in/Check-out Kiosk and as of 08:30 am (UK time) this morning (03-Aug-22), the Kiosk cannot connect to the LMS (our D-Tech support say it is using SIP2). We cannot identify a network issue at our end, so D-Tech have asked us to check with you whether there is any problem at your end. This is urgent as it is impacting our users. If needed, you can call me on +44 (0)7806 477763. Once you let us know whether or not there is an issue at your end, we can liaise with D-Tech accordingly. Many thanks Simon Rowe (Assistant Librarian - London School of Theology) on behalf of Keith Lang, Librarian -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 12:55:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 10:55:21 +0000 Subject: [Koha-bugs] [Bug 31287] D-Tech kiosk can't connect to LMS (Koha) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31287 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Katrin Fischer --- Hi Simon, are you self-hosting or do you work with a support provider? Bugzilla is used to report bugs and enhancements to the Koha Community. This sounds like something needs to be checked out on your server, for example the SIP server might need restarting. But you should/need to raise the issue with someone who can get on your server. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 13:14:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 11:14:56 +0000 Subject: [Koha-bugs] [Bug 27920] Add ability to update patron expiration dates when importing patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 13:14:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 11:14:59 +0000 Subject: [Koha-bugs] [Bug 27920] Add ability to update patron expiration dates when importing patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121886|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 138524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138524&action=edit Bug 27920: Add ability to update patron expiration dates when importing patrons Some libraries need to recalculate a patron's expiration date any time they are updated via a patron import from file. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Patrons/Import.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 13:16:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 11:16:33 +0000 Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and public lists at patron deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933 --- Comment #38 from Marcel de Rooy --- - my $userenv = C4::Context->userenv; - return $userenv->{'number'} if $userenv; Replaced by: + $new_owner = C4::Context->userenv->{number}; Will open a new bug. Saw this already: perl t/db_dependent/Koha/AdditionalContents.t 1..5 # Subtest: ->author 1..3 ok 1 - Koha::AdditionalContent->author returns a Koha::Patron object # Looks like you planned 3 tests but ran 1. not ok 4 - ->author # Failed test '->author' # at t/db_dependent/Koha/AdditionalContents.t line 156. {UNKNOWN}: Can't use an undefined value as a HASH reference at /usr/share/koha/Koha/Virtualshelves.pm line 59. at /usr/share/koha/Koha/Virtualshelves.pm line 73 # Looks like your test exited with 255 just after 4. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 13:17:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 11:17:32 +0000 Subject: [Koha-bugs] [Bug 31288] New: Check userenv in ->disown_or_delete Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31288 Bug ID: 31288 Summary: Check userenv in ->disown_or_delete Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org See bug 30933 comment38. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 13:29:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 11:29:18 +0000 Subject: [Koha-bugs] [Bug 31288] Check userenv in ->disown_or_delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31288 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 13:29:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 11:29:21 +0000 Subject: [Koha-bugs] [Bug 31288] Check userenv in ->disown_or_delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31288 --- Comment #1 from Marcel de Rooy --- Created attachment 138525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138525&action=edit Bug 31288: (QA follow-up) Check userenv in disown_or_delete Test plan: Run t/db_dependent/Koha/Virtualshelves.t Set ListOwnershipUponPatronDeletion to change and leave pref ListOwnerDesignated empty. Run t/db_dependent/Koha/AdditionalContents.t * Without this patch, the test would fail in this context. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 13:30:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 11:30:04 +0000 Subject: [Koha-bugs] [Bug 31288] Check userenv in ->disown_or_delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31288 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Depends on| |30933 Status|Needs Signoff |Signed Off --- Comment #2 from Marcel de Rooy --- This patch can be viewed as a late QA follow-up for the RM follow-up ;) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933 [Bug 30933] Add a designated owner for shared and public lists at patron deletion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 13:30:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 11:30:04 +0000 Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and public lists at patron deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31288 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31288 [Bug 31288] Check userenv in ->disown_or_delete -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 13:30:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 11:30:12 +0000 Subject: [Koha-bugs] [Bug 31288] Check userenv in ->disown_or_delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31288 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 13:30:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 11:30:31 +0000 Subject: [Koha-bugs] [Bug 31288] Check userenv in ->disown_or_delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31288 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 13:30:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 11:30:39 +0000 Subject: [Koha-bugs] [Bug 31288] Check userenv in ->disown_or_delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31288 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 13:32:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 11:32:49 +0000 Subject: [Koha-bugs] [Bug 31288] Check userenv in ->disown_or_delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31288 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 13:34:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 11:34:07 +0000 Subject: [Koha-bugs] [Bug 31288] Check userenv in ->disown_or_delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31288 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 13:34:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 11:34:10 +0000 Subject: [Koha-bugs] [Bug 31288] Check userenv in ->disown_or_delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31288 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138525|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 138526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138526&action=edit Bug 31288: (QA follow-up) Check userenv in disown_or_delete Test plan: Run t/db_dependent/Koha/Virtualshelves.t Set ListOwnershipUponPatronDeletion to change and leave pref ListOwnerDesignated empty. Run t/db_dependent/Koha/AdditionalContents.t * Without this patch, the test would fail in this context. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 13:37:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 11:37:23 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #6 from Marcel de Rooy --- Created attachment 138527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138527&action=edit Bug 29144: (follow-up) Terminology: rename to OpacLibraryInfo git grep -l OpacBranchInfo | xargs sed -i -e's/OpacBranchInfo/OpacLibraryInfo/g' Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 13:37:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 11:37:26 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #7 from Marcel de Rooy --- Created attachment 138528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138528&action=edit Bug 29144: Add $contents->find_best_match, $library->opac_info Test plan: Run t/db_dependent/Koha/AdditionalContents.t Run t/db_dependent/Koha/Library.t Note: You may need to set ListOwnershipUponPatronDeletion to delete to fix a pending issue in patron->delete with lists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 13:40:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 11:40:36 +0000 Subject: [Koha-bugs] [Bug 31275] AdditionalContents.search_for_display returns branch block and All block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31275 --- Comment #9 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #8) > We have inherited this from the news module. I think changing it now could > be quite disruptive to libraries as the OPAC behaviour would change. Not sure about that. But no worry, we can add a new method where another behavior is definitely wanted. Have a look at bug 29144, patch Add $contents->find_best_match, $library->opac_info. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 13:42:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 11:42:25 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31275 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 13:42:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 11:42:25 +0000 Subject: [Koha-bugs] [Bug 31275] AdditionalContents.search_for_display returns branch block and All block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31275 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29144 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 14:21:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 12:21:01 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136560|0 |1 is obsolete| | --- Comment #53 from sandboxes at biblibre.com --- Created attachment 138529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138529&action=edit Bug 15348: Add estimated delivery date field to individual orders This patch allows you to specify an estimated delivery date per order. The specified estimated delivery date is also considered when searching for late orders and exporting late orders. You can also edit the estimated delivery date from the late orders page. Test plan: 1. Update database, rebuild schema, restart services 2. Go to Acquisitions, search for a vendor, and create a new basket 3. Add an order to the basket. When filling in the accounting details, notice the new 'estimated delivery date' field, but don't add a date. Save the order. 4. Confirm no date shows in the estimated delivery date column in the orders table. 5. Modify the order. Add a date in the estimated delivery date field and save the order. 6. Confirm the date now shows in the orders table. 7. Close the basket. 8. Go to the Late Orders page. 9. Put estimated delivery date from and to parameters in the search filters on the left. Ensure the from and to dates encapsulate the date you entered in the estimated delivery date field for the order. 10. Click Filter and ensure the order shows. 11. Select the checkbox next to the order. Click the Export as CSV button. 12. Open the CSV and confirm the estimated delivery date that you entered shows as expected in the file. 13. Click Edit under the estimated delivery date. Confirm the estimated delivery date modal pops up with the correct order line number in the modal header. 14. Remove the estimated delivery date and click Save. 15. Confirm that the estimated delivery date calculated by Koha now shows in the late orders table. 16. Select the checkbox next to the order. Click the Export as CSV button. 17. Open the CSV and confirm the calculated estimated delivery date shows in the CSV. 18. Confirm tests pass: t/db_dependent/Koha/Acquisition/Order.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: Christian Stelzenmüller Signed-off-by: Martin Renvoize Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 14:21:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 12:21:06 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136561|0 |1 is obsolete| | --- Comment #54 from sandboxes at biblibre.com --- Created attachment 138530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138530&action=edit Bug 15348: (QA follow-up) Remove superflous filters The QA script highlighted the addition of some unneeded extra TT filters. Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 14:21:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 12:21:11 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136562|0 |1 is obsolete| | --- Comment #55 from sandboxes at biblibre.com --- Created attachment 138531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138531&action=edit Bug 15348: trivial code simplification Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 14:21:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 12:21:16 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136563|0 |1 is obsolete| | --- Comment #56 from sandboxes at biblibre.com --- Created attachment 138532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138532&action=edit Bug 15348: (follow-up) Fix breadcrumbs, title, JS error, permissions Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 14:21:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 12:21:21 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137057|0 |1 is obsolete| | --- Comment #57 from sandboxes at biblibre.com --- Created attachment 138533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138533&action=edit Bug 15348: (follow-up) Fix TT filters from html to uri Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 14:21:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 12:21:26 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137058|0 |1 is obsolete| | --- Comment #58 from sandboxes at biblibre.com --- Created attachment 138534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138534&action=edit Bug 15348: (follow-up) Fix export of dt_from_string FAIL acqui/addorder.pl FAIL valid " dt_from_string " is not exported by the Koha::DateUtils module Can't continue after import errors Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 14:21:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 12:21:32 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137098|0 |1 is obsolete| | --- Comment #59 from sandboxes at biblibre.com --- Created attachment 138535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138535&action=edit Bug 15348: (follow-up) Fix imports in moddeliverydate.pl Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 14:21:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 12:21:37 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137099|0 |1 is obsolete| | --- Comment #60 from sandboxes at biblibre.com --- Created attachment 138536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138536&action=edit Bug 15348: (follow-up) Update calendar widget to flatpickr Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 14:21:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 12:21:42 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137742|0 |1 is obsolete| | --- Comment #61 from sandboxes at biblibre.com --- Created attachment 138537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138537&action=edit Bug 15348: (follow-up) Fix calendar widget, translateability, etc Also add functionality to edit the estimated delivery date from a closed basket. Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 14:21:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 12:21:47 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137743|0 |1 is obsolete| | --- Comment #62 from sandboxes at biblibre.com --- Created attachment 138538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138538&action=edit Bug 15348: DBIC changes DO NOT PUSH For testing purposes Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 14:21:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 12:21:52 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138110|0 |1 is obsolete| | --- Comment #63 from sandboxes at biblibre.com --- Created attachment 138539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138539&action=edit Bug 15348: (follow-up) Fix modal to edit delivery date This allows you to empty the delivery date and ensures the current date shows Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 14:21:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 12:21:56 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138491|0 |1 is obsolete| | --- Comment #64 from sandboxes at biblibre.com --- Created attachment 138540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138540&action=edit Bug 15348: (follow-up) Fix filtering results on estimated delivery date Adding another clause to the SQL so that the specified estimated delivery date is used for filtering first, and the calculated delivery date is used if there is no specified estimated delivery date. Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 14:47:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 12:47:08 +0000 Subject: [Koha-bugs] [Bug 31222] DBIC queries for batch mod can be very large In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31222 --- Comment #4 from Rachael --- (In reply to Nick Clemens from comment #3) > (In reply to Rachael from comment #2) > > Batch modifications changes each item. Ex. Modifying the Source of > > classification or shelving scheme to Dewey Decimal Classification gets > > applied. > > Hi Rachel, I am not sure what you mean here? Batch modification should > update each item, is it updating more fields than intended? Hi Nick, No, nothing else changes, just the fields that I specified. Should I sign it off then? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 15:42:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 13:42:50 +0000 Subject: [Koha-bugs] [Bug 31289] New: Hide Article requests column in circulation rules when ArticleRequests syspref is disabled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Bug ID: 31289 Summary: Hide Article requests column in circulation rules when ArticleRequests syspref is disabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Hi! Some rules are hidden when a syspref is disabled (like the rules for recalls, and the article request fee and limit of open article requests), but even if the ArticleRequests system preference is disabled, there is still an "Article requests" column in the big circulation rules matrix. Like the recalls rules and the other article requests rules, this column should be hidden if the system preference is disabled. To reproduce: 1) With ArticleRequests disabled, go to Administration > Circulation and fines rules 2) Scroll right in the first table --> There should be an article requests yes/no column (this should be hidden) 3) Scroll down to see the other tables in the page --> There are no other article requests tables (this is ok) 4) Enable ArticleRequests in Administration > System preferences 5) Go back to the Circulation and fines rules and refresh the page 6) 2) Scroll right in the first table --> There should be an article requests yes/no column (this is ok) 7) Scroll down to see the other tables in the page --> There are other article requests tables, Default open article requests limit and Default article request fees (this is ok) At step 2, users don't need to see the Article request column since the system preference is disabled. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 15:58:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 13:58:57 +0000 Subject: [Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 15:59:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 13:59:00 +0000 Subject: [Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 138541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138541&action=edit Bug 31289: Hide Article requests column in circulation rules when ArticleRequests syspref is disabled This patch hides the Article requests column in the large circulation rules table when the ArticleRequests system preference is disabled. To test: 0) Apply patch 1) With ArticleRequests disabled, go to Administration > Circulation and fines rules 2) Scroll right in the first table --> There isn't any mention of article requests in the table 3) Scroll down to see the other tables in the page --> There are no other article requests tables 4) Enable ArticleRequests in Administration > System preferences 5) Go back to the Circulation and fines rules and refresh the page 6) Scroll right in the first table --> There should be an article requests yes/no column 7) Scroll down to see the other tables in the page --> There are other article requests tables, Default open article requests limit and Default article request fees -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 16:00:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 14:00:28 +0000 Subject: [Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 --- Comment #2 from Caroline Cyr La Rose --- I did some copy-pasting from the UseRecalls mentions in smart-rules.tt... I hope it's ok -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 16:10:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 14:10:58 +0000 Subject: [Koha-bugs] [Bug 31220] Error when attempting to export selected labels as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 16:15:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 14:15:05 +0000 Subject: [Koha-bugs] [Bug 31288] Check userenv in ->disown_or_delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31288 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy at rijksmuseum.nl |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 16:32:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 14:32:09 +0000 Subject: [Koha-bugs] [Bug 18714] tracklinks.pl redirects failing under https In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18714 --- Comment #2 from Nick Clemens --- This wa related to a proxy rule to forward all http to https, we just needed to limit it to koha urls. We changed: http-response replace-value Location ^http://(.*) https://\1 if { ssl_fc } To: http-response replace-value Location ^http://(.*)/cgi-bin/koha/(.*) https://\1/cgi-bin/koha/\2 if { ssl_fc } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 16:44:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 14:44:38 +0000 Subject: [Koha-bugs] [Bug 31288] Check userenv in ->disown_or_delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31288 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138526|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 16:45:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 14:45:02 +0000 Subject: [Koha-bugs] [Bug 31288] Check userenv in ->disown_or_delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31288 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 138542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138542&action=edit Bug 31288: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 16:45:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 14:45:07 +0000 Subject: [Koha-bugs] [Bug 31288] Check userenv in ->disown_or_delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31288 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 138543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138543&action=edit Bug 31288: (QA follow-up) Check userenv in disown_or_delete Test plan: 1. Apply the regression tests 2. Run: $ kshell k$ t/db_dependent/Koha/Virtualshelves.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 16:50:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 14:50:23 +0000 Subject: [Koha-bugs] [Bug 31220] Error when attempting to export selected labels as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 16:50:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 14:50:26 +0000 Subject: [Koha-bugs] [Bug 31220] Error when attempting to export selected labels as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 16:50:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 14:50:29 +0000 Subject: [Koha-bugs] [Bug 31288] Check userenv in ->disown_or_delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31288 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 16:50:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 14:50:32 +0000 Subject: [Koha-bugs] [Bug 31288] Check userenv in ->disown_or_delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31288 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 16:50:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 14:50:56 +0000 Subject: [Koha-bugs] [Bug 31288] Check userenv in ->disown_or_delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31288 --- Comment #7 from Tomás Cohen Arazi --- Good catch, Marcel. Thanks for the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 17:29:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 15:29:11 +0000 Subject: [Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 17:29:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 15:29:15 +0000 Subject: [Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138541|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 138544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138544&action=edit Bug 31289: Hide Article requests column in circulation rules when ArticleRequests syspref is disabled This patch hides the Article requests column in the large circulation rules table when the ArticleRequests system preference is disabled. To test: 0) Apply patch 1) With ArticleRequests disabled, go to Administration > Circulation and fines rules 2) Scroll right in the first table --> There isn't any mention of article requests in the table 3) Scroll down to see the other tables in the page --> There are no other article requests tables 4) Enable ArticleRequests in Administration > System preferences 5) Go back to the Circulation and fines rules and refresh the page 6) Scroll right in the first table --> There should be an article requests yes/no column 7) Scroll down to see the other tables in the page --> There are other article requests tables, Default open article requests limit and Default article request fees Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 17:41:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 15:41:01 +0000 Subject: [Koha-bugs] [Bug 28806] Labels exported as PDF create zero sized PDF files. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 --- Comment #18 from Chris Nighswonger --- (In reply to Manos PETRIDIS from comment #17) > Created attachment 138522 [details] > barcode-only PDF export (roll size) > > Note that only 3 of 9 selected items appear on print. I note that these three labels are the three left-to-right, top-to-bottom diagonal labels in the A4 size PDF. ie. Labels 1, 5, 9 of the A4 appear in the roll size PDF. Yet neither are zero sized PDFs. So there may be two different issues here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 18:28:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 16:28:22 +0000 Subject: [Koha-bugs] [Bug 28806] Labels exported as PDF create zero sized PDF files. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 --- Comment #19 from Manos PETRIDIS --- Allow me to refer you Chris to my message of May 1st: Further testing has shown that * when trying to print in a Layout of Print type BAR, a PDF is created. It doesn't contain the full batch, but at least id does contain a barcode. * when trying however to print in Layouts of Print type either ALT or BARBIB, that is when trying to include in the labels something more than just the barcode, the same batch creates a zero-sized PDF file. I can't upload a zero-sized example, as bugzilla will not accept such files, but the resultant in the latter case files are empty and a reported by the OS as having a size of 0. You are correct in stating that there are two issues here: a. Empty PDF files when printing ALT or BARBIB labels. b. Not all BAR labels are printed in the roll format output. This I only realised today, while prepering the latest examples. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 19:03:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 17:03:05 +0000 Subject: [Koha-bugs] [Bug 31284] Add a calendar log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31284 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #1 from Lucas Gass --- Great idea. +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 19:15:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 17:15:03 +0000 Subject: [Koha-bugs] [Bug 30213] Hide Delete (aka Priority) column when user only has place_hold permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 19:19:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 17:19:25 +0000 Subject: [Koha-bugs] [Bug 28806] Labels exported as PDF create zero sized PDF files. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 --- Comment #20 from Chris Nighswonger --- If you can, re-create both of those PDFs with the following line commented out. https://github.com/Koha-Community/Koha/blob/master/labels/label-create-pdf.pl#L102 You can uncomment it afterwards. That line instructs the distiller to compress the resulting PDF. A compressed PDF is not really useful for debugging. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 19:20:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 17:20:05 +0000 Subject: [Koha-bugs] [Bug 28806] Labels exported as PDF create zero sized PDF files. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 --- Comment #21 from Chris Nighswonger --- Some random thoughts in no particular order: ALT is a combination of BIB and BAR. We would expect to see at least the BAR labels in an ALT PDF, but we do not. So what is wrong? Maybe bad data. We also do not have any errors/warnings in the log per an earlier post. This seems odd as well and may point to bad data. I notice that the CSV and XML do not play well with the Greek. I use Greek fonts extensively in my work. Notepad++ displays the Greek in both files fine. Vim does not. LibreCalc does not. Perhaps there is an underlying encoding issue here as well. It may or may not be a cause of the topic issue of this bug. The fact that we have only two systems affected seems to point to an underlying data problem as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 19:29:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 17:29:01 +0000 Subject: [Koha-bugs] [Bug 26102] Javascript injection in intranet search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26102 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldoldoldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 19:29:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 17:29:01 +0000 Subject: [Koha-bugs] [Bug 30044] Z39.50/SRU search button broken by update to 19.11.25 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30044 Bug 30044 depends on bug 26102, which changed state. Bug 26102 Summary: Javascript injection in intranet search https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26102 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 19:36:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 17:36:11 +0000 Subject: [Koha-bugs] [Bug 30512] Staff interface search results template error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 19:39:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 17:39:53 +0000 Subject: [Koha-bugs] [Bug 30761] Typo: PLease In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30761 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 19:42:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 17:42:00 +0000 Subject: [Koha-bugs] [Bug 30384] Reindent template for ordering from a MARC file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30384 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 19:42:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 17:42:02 +0000 Subject: [Koha-bugs] [Bug 30388] Fix some errors in the template for ordering from a MARC file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30388 Bug 30388 depends on bug 30384, which changed state. Bug 30384 Summary: Reindent template for ordering from a MARC file https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30384 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 19:42:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 17:42:57 +0000 Subject: [Koha-bugs] [Bug 30388] Fix some errors in the template for ordering from a MARC file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30388 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 19:42:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 17:42:58 +0000 Subject: [Koha-bugs] [Bug 30389] Switch to Bootstrap tabs on the page for adding orders from MARC file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 Bug 30389 depends on bug 30388, which changed state. Bug 30388 Summary: Fix some errors in the template for ordering from a MARC file https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30388 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 19:43:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 17:43:44 +0000 Subject: [Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 20:22:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 18:22:52 +0000 Subject: [Koha-bugs] [Bug 31253] Item search in staff interface should call barcodedecode if the search index is a barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31253 --- Comment #2 from Owen Leonard --- Is this specific to the search engine? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 20:59:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 18:59:43 +0000 Subject: [Koha-bugs] [Bug 27497] Display Koha version in staff interface home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 --- Comment #56 from Owen Leonard --- I think the patch we have should be accepted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 21:15:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 19:15:44 +0000 Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in memberentry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138443|0 |1 is obsolete| | --- Comment #17 from Victor Grousset/tuxayo --- Created attachment 138545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138545&action=edit Bug 30874: Replace categoryname == Test plan == 1. Apply all patches 2. Create a new patron in a given category => Form show the dropdown with the selected category 3. Edit again => Value is kept 4. Edit a category to give it specific values for: messaging prefs, password strength/length, can be guarantee 5. Edit the patron, change the category, and confirm that the different limitation are correctly applied. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 21:15:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 19:15:53 +0000 Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in memberentry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138444|0 |1 is obsolete| | --- Comment #18 from Victor Grousset/tuxayo --- Created attachment 138546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138546&action=edit Bug 30874: Reduce number of category fetches Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 21:16:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 19:16:07 +0000 Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in memberentry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138445|0 |1 is obsolete| | --- Comment #19 from Victor Grousset/tuxayo --- Created attachment 138547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138547&action=edit Bug 30874: 2 more - need more investigation Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 21:16:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 19:16:15 +0000 Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in memberentry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138446|0 |1 is obsolete| | --- Comment #20 from Victor Grousset/tuxayo --- Created attachment 138548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138548&action=edit Bug 30874: Simplify categories loop construction Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 21:16:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 19:16:25 +0000 Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in memberentry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138447|0 |1 is obsolete| | --- Comment #21 from Victor Grousset/tuxayo --- Created attachment 138549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138549&action=edit Bug 30874: Remove category_type In which case do we pass category_type to this script? Am I missing something? Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 21:17:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 19:17:13 +0000 Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in memberentry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |victor at tuxayo.net --- Comment #22 from Victor Grousset/tuxayo --- It works :) Added test plan to 1st patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 21:24:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 19:24:00 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #68 from Victor Grousset/tuxayo --- So Koha doesn't start due to a missing dep? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 21:37:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 19:37:13 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #69 from Victor Grousset/tuxayo --- Address::Email isn't in the cpanfile nor the cpanfile of the subsequent Koha releases. grepping Address::Email yield nothing in the code of 20.11.x Do you mean Email::Address? It's in the cpanfile so it should be in our repo. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 21:38:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 19:38:57 +0000 Subject: [Koha-bugs] [Bug 31253] Item search in staff interface should call barcodedecode if the search index is a barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31253 --- Comment #3 from Rachael --- Searching for MY TEST returns no results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 21:57:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 19:57:29 +0000 Subject: [Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179 Michael Spagnuolo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspagnuolo at nrhtx.com --- Comment #10 from Michael Spagnuolo --- Any chance this can be backported to 21.11. We just upgraded to 21.11 and have started to notice this duplicate item behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 22:00:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 20:00:15 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 AspenCat Team changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam at clicweb.org --- Comment #271 from AspenCat Team --- After discussing this a bit with Christopher I have to agree that I think this would make life a lot easier for libraries. Periodically we have accidental patron deletes, and it is not easy getting the toothpaste back in the tube once things move to the deleted items table. This seems like a far easier approach to managing this data I would be very interested in this moving forward. - Bob Bennhoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 22:32:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 20:32:09 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #65 from Aleisha Amohia --- Changing status to reflect signoffs from Christian -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 22:54:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 20:54:12 +0000 Subject: [Koha-bugs] [Bug 31245] Job detail view for batch mod explode if job not started In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31245 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org --- Comment #9 from Andrew Fuerste-Henry --- Without these patches, I'm getting this same error on master when trying to view a job that's currently underway (status='started'). I'm on a sandbox, so I don't have a way to stop the koha-workers for testing. Here's how I've been testing: 1 - write a report, SELECT itemnumber FROM items. With the default dev data, that's 961 items. 2 - use your report to send all of those to batch mod. The page will take a while to load 3 - while your batch mod page is loading, open background_jobs.pl in another tab and have it ready to go 4 - modify something in all 961 records -- add a public note or something -- once you submit this job it will take about 45 seconds to complete 5 - BEFORE THE JOB IS DONE - reload background_jobs.pl, see your job is listed and shows status=started. try to view details of your job, get an error 6 - once the job has finished, click View again and see your job details successfully With these patches, I do not get an error. When I try to see the details for a job that's underway, the details page loads fine. It shows the status (started) and progress (122/961) correctly. However, it says "No items modified." This is inaccurate. If we can't load and list the items that have already been successfully modified, I'd rather the message say something like "This job is not yet complete." All that said, these patches do what they say and correct a messy error, so I'm signing off. Maybe that message can get changed in a followup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 22:54:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 20:54:48 +0000 Subject: [Koha-bugs] [Bug 31245] Job detail view for batch mod explode if job not started In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31245 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138169|0 |1 is obsolete| | --- Comment #10 from ByWater Sandboxes --- Created attachment 138550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138550&action=edit Bug 31245: Do not try to report results if task not started Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Andrew -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 22:54:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 20:54:51 +0000 Subject: [Koha-bugs] [Bug 31245] Job detail view for batch mod explode if job not started In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31245 --- Comment #11 from ByWater Sandboxes --- Created attachment 138551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138551&action=edit Bug 31245: Do not call report for job detail view if job not started We should not generate the report if the job hasn't started yet Test plan: Stop the koha-worker processes, modify a new item using the batch mod tool, then see the detail page of the job Without this patch an error is generated: Can't use an undefined value as an ARRAY reference at /kohadevbox/koha/Koha/BackgroundJob/BatchUpdateItem.pm line 175 Signed-off-by: Andrew -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 3 22:55:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 20:55:20 +0000 Subject: [Koha-bugs] [Bug 31245] Job detail view for batch mod explode if job not started In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31245 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 00:11:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 22:11:34 +0000 Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137854|0 |1 is obsolete| | --- Comment #15 from Michael Hafen --- Created attachment 138552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138552&action=edit Bug 28726: Add sort1 and sort2 to patron card creator - patron search. Re-upload (2022-08-03). Don't know how the previous one was uploaded as just the commit message. Test plan: 1. start a new batch in the patron card creator (Tools -> Patron card creator -> New -> card batch) 2. click the Add patron(s) button. Observe that Category and Library are the only options. 3. Close search for patron window. 4. Apply patch. 5. click the Add patron(s) button. Observe that you can now search for patrons by their sort1 and sort2 values. 6. perform a search and observe the 'Select all | Clear all | Add selected patrons' links and button. 7. use the Select all link to select all the patrons found by the search. 8. use the Add selected patrons button to add the selected patrons to the card batch's Add by borrowernumber(s) text input field. 9. close the search for patron window. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 00:12:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 22:12:02 +0000 Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 01:38:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 23:38:04 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137966|0 |1 is obsolete| | --- Comment #89 from Victor Grousset/tuxayo --- Created attachment 138553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138553&action=edit Bug 27272: Remove type= from detail.pl This is not related to anything known.. was it "itype" at some point? `git log -p` will tell you that it's there for a looong time already -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 01:38:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 23:38:29 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137967|0 |1 is obsolete| | --- Comment #90 from Victor Grousset/tuxayo --- Created attachment 138554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138554&action=edit Bug 27272: Remove GetItemsInfo from basket/basket -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 01:38:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 23:38:50 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137968|0 |1 is obsolete| | --- Comment #91 from Victor Grousset/tuxayo --- Created attachment 138555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138555&action=edit Bug 27272: Remove GetItemsInfo from basket/sendbasket Why are we display with $raw? Why are we display the location code instead of the AV's lib? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 01:39:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 23:39:08 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137969|0 |1 is obsolete| | --- Comment #92 from Victor Grousset/tuxayo --- Created attachment 138556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138556&action=edit Bug 27272: Remove GetItemsInfo from catalogue/imageviewer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 01:39:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 23:39:32 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137970|0 |1 is obsolete| | --- Comment #93 from Victor Grousset/tuxayo --- Created attachment 138557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138557&action=edit Bug 27272: Remove GetItemsInfo labels/label-item-search It was commented anyway -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 01:39:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 23:39:51 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137971|0 |1 is obsolete| | --- Comment #94 from Victor Grousset/tuxayo --- Created attachment 138558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138558&action=edit Bug 27272: Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl Hum... Item2Marc ok here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 01:40:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 23:40:19 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137972|0 |1 is obsolete| | --- Comment #95 from Victor Grousset/tuxayo --- Created attachment 138559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138559&action=edit Bug 27272: Remove GetItemsInfo from opac-detail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 01:40:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 23:40:41 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137973|0 |1 is obsolete| | --- Comment #96 from Victor Grousset/tuxayo --- Created attachment 138560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138560&action=edit Bug 27272: Remove 'already_reserved' flag from opac-reserve.pl It was never set (was set before 14695) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 01:41:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 23:41:05 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137974|0 |1 is obsolete| | --- Comment #97 from Victor Grousset/tuxayo --- Created attachment 138561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138561&action=edit Bug 27272: Remove GetHostItemsInfo and GetItemsInfo from opac-reserve -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 01:41:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 23:41:29 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137975|0 |1 is obsolete| | --- Comment #98 from Victor Grousset/tuxayo --- Created attachment 138562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138562&action=edit Bug 27272: Remove GetHostItemsInfo and GetItemsInfo from moredetail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 01:41:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 23:41:53 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137976|0 |1 is obsolete| | --- Comment #99 from Victor Grousset/tuxayo --- Created attachment 138563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138563&action=edit Bug 27272: Remove GetItemsInfo from opac-sendbasket -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 01:42:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 23:42:14 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137977|0 |1 is obsolete| | --- Comment #100 from Victor Grousset/tuxayo --- Created attachment 138564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138564&action=edit Bug 27272: Remove GetItemsInfo import from opac-tags -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 01:42:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 23:42:38 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137978|0 |1 is obsolete| | --- Comment #101 from Victor Grousset/tuxayo --- Created attachment 138565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138565&action=edit Bug 27272: Remove GetItemsInfo from serials/routing-preview -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 01:42:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 23:42:59 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137979|0 |1 is obsolete| | --- Comment #102 from Victor Grousset/tuxayo --- Created attachment 138566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138566&action=edit Bug 27272: Remove GetItemsInfo from tags/list.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 01:43:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 23:43:28 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137980|0 |1 is obsolete| | --- Comment #103 from Victor Grousset/tuxayo --- Created attachment 138567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138567&action=edit Bug 27272: Remove GetItemsInfo from virtualshelves/sendshelf.pl And GetItemsLocationInfo from shelves.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 01:43:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 23:43:54 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138303|0 |1 is obsolete| | --- Comment #104 from Victor Grousset/tuxayo --- Created attachment 138568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138568&action=edit Bug 27272: Remove GetItemsInfo from catalogue/detail.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 01:44:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 23:44:20 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138304|0 |1 is obsolete| | --- Comment #105 from Victor Grousset/tuxayo --- Created attachment 138569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138569&action=edit Bug 27272: Remove GetItemsInfo, GetItemsLocationInfo and GetHostItemsInfo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 01:44:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 23:44:41 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138437|0 |1 is obsolete| | --- Comment #106 from Victor Grousset/tuxayo --- Created attachment 138570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138570&action=edit Bug 27272: Add search_ordered sub to order items with extra conditions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 01:45:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 23:45:01 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138438|0 |1 is obsolete| | --- Comment #107 from Victor Grousset/tuxayo --- Created attachment 138571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138571&action=edit Bug 27272: Allow to pass params and attributes to search_ordered -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 01:45:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 23:45:27 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138439|0 |1 is obsolete| | --- Comment #108 from Victor Grousset/tuxayo --- Created attachment 138572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138572&action=edit Bug 27272: Add tests for search_ordered -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 01:45:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 23:45:54 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138440|0 |1 is obsolete| | --- Comment #109 from Victor Grousset/tuxayo --- Created attachment 138573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138573&action=edit Bug 27272: Call search_ordered when GetItemsInfo was called before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 01:46:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 23:46:15 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138441|0 |1 is obsolete| | --- Comment #110 from Victor Grousset/tuxayo --- Created attachment 138574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138574&action=edit Bug 27272: Fix availability - OPAC Has to move some code to a method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 01:46:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 23:46:40 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138442|0 |1 is obsolete| | --- Comment #111 from Victor Grousset/tuxayo --- Created attachment 138575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138575&action=edit Bug 27272: Fix library display on routing slip - to squash -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 01:49:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Aug 2022 23:49:14 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #112 from Victor Grousset/tuxayo --- Rebased. It was tough, one patch blew up with the infamous: error: sha1 information is lacking or useless (opac/opac-detail.pl). error: could not build fake ancestor Patch failed at 0001 Bug 27272: Remove GetItemsInfo from opac-detail But thankfully it was possible to use your repo https://gitlab.com/joubu/Koha/-/commits/bug_27272/ The latest patches aren't there so it wasn't possible to it directly (and I wasn't certain the existing commits were at their latest version). But! Getting just the problematic commit and applying it worked :D And the rest applied without issue on top of master. Comparing the diffs of the previous "Remove GetItemsInfo from opac-detail" from this ticket and the rebased on showed no difference in the changed lines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 02:46:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 00:46:07 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #42 from Victor Grousset/tuxayo --- To have the CI still be meaningful for Ubuntu 18.04 (until 2023-04-26) for Koha 22.05 and in the future 22.11, should these patch be reverted until then? (assuming it's possible to revert) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 03:31:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 01:31:54 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #43 from Tomás Cohen Arazi --- (In reply to Victor Grousset/tuxayo from comment #42) > To have the CI still be meaningful for Ubuntu 18.04 (until 2023-04-26) for > Koha 22.05 and in the future 22.11, should these patch be reverted until > then? (assuming it's possible to revert) We need to backport a newer DateTime library for 18.04. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 03:56:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 01:56:40 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 03:56:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 01:56:50 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128285|0 |1 is obsolete| | --- Comment #420 from Aleisha Amohia --- Created attachment 138576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138576&action=edit Bug 15516: Database and installer updates Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 03:57:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 01:57:00 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128286|0 |1 is obsolete| | --- Comment #421 from Aleisha Amohia --- Created attachment 138577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138577&action=edit Bug 15516: Relevant controller changes and tests Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 03:57:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 01:57:09 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128287|0 |1 is obsolete| | --- Comment #422 from Aleisha Amohia --- Created attachment 138578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138578&action=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library has the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This feature only applies to the staff client. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Search for a patron 3. Check the 'Treat as hold group' checkbox 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a hold group)' in Details column. 6. Click on the "hold group" link. A modal window should appear with the content of the hold group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "hold group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Note: A hold group is counted as only one hold Sponsored-by: Catalyst IT Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 03:57:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 01:57:17 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128289|0 |1 is obsolete| | --- Comment #423 from Aleisha Amohia --- Created attachment 138579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138579&action=edit Bug 15516: (follow-up) Add hold group message to holds queue A hold that is part of a hold group will be indicated as such in the holds queue. Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 03:57:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 01:57:26 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128290|0 |1 is obsolete| | --- Comment #424 from Aleisha Amohia --- Created attachment 138580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138580&action=edit Bug 15516: (follow-up) Remove other holds in hold_group from holds_queue When one hold is fulfilled or set waiting Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 03:57:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 01:57:35 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128291|0 |1 is obsolete| | --- Comment #425 from Aleisha Amohia --- Created attachment 138581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138581&action=edit Bug 15516: (follow-up) Fixes for qa tools Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 03:57:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 01:57:44 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128292|0 |1 is obsolete| | --- Comment #426 from Aleisha Amohia --- Created attachment 138582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138582&action=edit Bug 15516: (follow-up) Fixing file permissions and title elements order Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 03:57:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 01:57:55 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128293|0 |1 is obsolete| | --- Comment #427 from Aleisha Amohia --- Created attachment 138583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138583&action=edit Bug 15516: Fix shebang in hold-group.pl Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 03:58:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 01:58:04 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128294|0 |1 is obsolete| | --- Comment #428 from Aleisha Amohia --- Created attachment 138584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138584&action=edit Bug 15516: (follow-up) Count group holds always Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 03:58:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 01:58:13 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128295|0 |1 is obsolete| | --- Comment #429 from Aleisha Amohia --- Created attachment 138585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138585&action=edit Bug 15516: Fix hold groups for multi items for one bib Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 03:58:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 01:58:24 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128296|0 |1 is obsolete| | --- Comment #430 from Aleisha Amohia --- Created attachment 138586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138586&action=edit Bug 15516: Add ability to create hold groups from OPAC This patch adds a "Treat as hold group" to opac-reserve.pl, which lets OPAC users create a hold group which can include 1+ bibs and either bib-level holds, or item-level holds, or both. Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 03:58:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 01:58:33 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128297|0 |1 is obsolete| | --- Comment #431 from Aleisha Amohia --- Created attachment 138587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138587&action=edit Bug 15516: Show user's hold groups to user via OPAC This patch shows the item-level and bib-level holds in a hold group for the user's holds in the OPAC. This includes both the opac-user.pl page and the self-checkout hold display. Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 03:58:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 01:58:43 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128298|0 |1 is obsolete| | --- Comment #432 from Aleisha Amohia --- Created attachment 138588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138588&action=edit Bug 15516: (follow-up) Prevent cancelling unintended holds And a fix for consistent TT code Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 03:58:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 01:58:51 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128299|0 |1 is obsolete| | --- Comment #433 from Aleisha Amohia --- Created attachment 138589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138589&action=edit Bug 15516: (follow-up) Fix hold group details not showing Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 04:05:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 02:05:57 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #434 from Aleisha Amohia --- (In reply to Victor Grousset/tuxayo from comment #417) > Hi :) I tried to rebase because why not, but hit a wall on the changes on > ModReserveFill which was moved (and changed a lot) to Hold::fill(). I don't > know where is a right place to put the new code: > > # if this hold was part of a group, cancel other holds in the group > my @holds = Koha::Holds->search({ hold_group_id => $hold->hold_group_id > }); > foreach my $h ( @holds ) { > $h->cancel unless $h->reserve_id == $hold->reserve_id; > } > > > Also, maybe these lines are also needed in Hold::cancel() > Not sure at all. > > I would gladly give another try if someone know what to do about the two > above points. Have rebased the patches in case someone can come along and sign them off - but will now work on putting this code in the right place and squashing some of these patches. Welcome to test in the meantime. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 05:04:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 03:04:48 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #44 from Mason James --- (In reply to Tomás Cohen Arazi from comment #43) > (In reply to Victor Grousset/tuxayo from comment #42) > > To have the CI still be meaningful for Ubuntu 18.04 (until 2023-04-26) for > > Koha 22.05 and in the future 22.11, should these patch be reverted until > > then? (assuming it's possible to revert) > > We need to backport a newer DateTime library for 18.04. i have had some success with updating just the 'libdatetime-timezone-perl' pkg, for u18 my theory is that a newer olsen database is needed for u18 - its been upgraded from 2018d to 2022a (ps: i cant explain why u20 works with only a 2019c database??) http://ftp.iana.org/tz/releases/ i did the update some days ago, which fixed the broken tests for master and stable https://jenkins.koha-community.org/view/master/job/Koha_Master_U18/1510/ https://jenkins.koha-community.org/view/22.05/job/Koha_22.05_U18/44/ i'll aim to update the prod repo soon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 05:08:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 03:08:37 +0000 Subject: [Koha-bugs] [Bug 30030] Test t/db_dependent/Koha/Patrons.t is_going_to_expire fails on U18 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #9 from Mason James --- (In reply to Victor Grousset/tuxayo from comment #8) > To have the CI still be meaningful for Ubuntu 18.04 (until 2023-04-26) for > 22.05 and in the future 22.11, should 29718 be reverted until then? > (assuming it's possible) i've updated possible fix here... https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718#c44 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 05:19:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 03:19:16 +0000 Subject: [Koha-bugs] [Bug 28806] Labels exported as PDF create zero sized PDF files. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 --- Comment #22 from Manos PETRIDIS --- If "bad data" is the only issue, why does the problem manifest itself only in batch label creation? Spine labels are created just fine (attachment 20220804_Spine labels_Tools_Koha.pdf). Apparently batch label creation has different rules in defining what "bad data" is. Furthermore, search (as in /cgi-bin/koha/catalogue/itemsearch.pl for example), has no problem showing greek characters on screen or exporting them as CSV (attachments 20220804_on_screen_results.PNG and 20220804_export_to_CSV.PNG). It could very well be a matter of mis-configuration that needs to be checked, and to this end I've opened a separate bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31180 I wonder however where could the guidelines to proper non-latin-tolerant-encoding be that I could consult, so that I may amend my system's ways. NB. My installation uses a db that was first created back in 2012 by the then current koha version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 05:21:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 03:21:08 +0000 Subject: [Koha-bugs] [Bug 28806] Labels exported as PDF create zero sized PDF files. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 --- Comment #23 from Manos PETRIDIS --- Created attachment 138590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138590&action=edit Spine label PDF, showing greek characters correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 05:22:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 03:22:45 +0000 Subject: [Koha-bugs] [Bug 28806] Labels exported as PDF create zero sized PDF files. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 --- Comment #24 from Manos PETRIDIS --- Created attachment 138591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138591&action=edit Search results on screen, displaying greek characters correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 05:23:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 03:23:42 +0000 Subject: [Koha-bugs] [Bug 28806] Labels exported as PDF create zero sized PDF files. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 --- Comment #25 from Manos PETRIDIS --- Created attachment 138592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138592&action=edit Search results exported as CSV, displaying greek characters correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 06:47:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 04:47:33 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128288|0 |1 is obsolete| | Attachment #138576|0 |1 is obsolete| | Attachment #138579|0 |1 is obsolete| | Attachment #138580|0 |1 is obsolete| | Attachment #138581|0 |1 is obsolete| | Attachment #138582|0 |1 is obsolete| | Attachment #138583|0 |1 is obsolete| | Attachment #138584|0 |1 is obsolete| | Attachment #138585|0 |1 is obsolete| | Attachment #138586|0 |1 is obsolete| | Attachment #138587|0 |1 is obsolete| | Attachment #138588|0 |1 is obsolete| | Attachment #138589|0 |1 is obsolete| | --- Comment #435 from Aleisha Amohia --- Created attachment 138593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138593&action=edit Bug 15516: Database and installer updates Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 06:47:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 04:47:44 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138577|0 |1 is obsolete| | --- Comment #436 from Aleisha Amohia --- Created attachment 138594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138594&action=edit Bug 15516: Relevant controller changes and tests Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 06:47:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 04:47:53 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138578|0 |1 is obsolete| | --- Comment #437 from Aleisha Amohia --- Created attachment 138595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138595&action=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library has the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Search for a patron 3. Check the 'Treat as hold group' checkbox 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a hold group)' in Details column. 6. Click on the "hold group" link. A modal window should appear with the content of the hold group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. The other holds will also be removed from the holds queue. 9. Confirm tests pass - t/db_dependent/Koha/Holds.t - t/db_dependent/Reserves/HoldGroup.t Note: the "hold group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl - circ/view_holdsqueue.pl Note: A hold group is counted as only one hold Sponsored-by: Catalyst IT Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 06:48:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 04:48:02 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #438 from Aleisha Amohia --- Created attachment 138596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138596&action=edit Bug 15516: Add ability to create and view hold groups from OPAC This patch adds a "Treat as hold group" to opac-reserve.pl, which lets OPAC users create a hold group which can include 1+ bibs and either bib-level holds, or item-level holds, or both. This patch shows the item-level and bib-level holds in a hold group for the user's holds in the OPAC. This includes both the opac-user.pl page and the self-checkout hold display. Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 06:48:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 04:48:12 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #439 from Aleisha Amohia --- Created attachment 138597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138597&action=edit Bug 15516: Schema updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 08:04:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 06:04:44 +0000 Subject: [Koha-bugs] [Bug 31290] New: Getting error in batch modification Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31290 Bug ID: 31290 Summary: Getting error in batch modification Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: nayema at mes.ac.in QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 138598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138598&action=edit /usr/share/koha/bin/background_jobs_worker.pl line 57 I am getting following error while trying to do any batch modification or batch delete in KOHA. "Cannot enqueue this job. (The error was: Job has not been enqueued, see the Koha log file for more information)." I have checked the error log file and found following error: ==> /var/log/koha/library/worker-output.log <== malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "You must log in usin...") at /usr/share/koha/bin/background_jobs_worker.pl line 57. I have attached the screen short of /usr/share/koha/bin/background_jobs_worker.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 09:11:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 07:11:02 +0000 Subject: [Koha-bugs] [Bug 31008] Long Term Support (LTS) version of Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31008 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 09:48:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 07:48:09 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #68 from Fridolin Somers --- Buuuuuuuut, we also need this change in UNIMARC XSLT files right ? And what about custom files ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 09:56:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 07:56:55 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24630 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 09:56:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 07:56:55 +0000 Subject: [Koha-bugs] [Bug 24630] UNIMARC XSLT Update for bug 7611 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26302 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 09:59:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 07:59:18 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #69 from Marcel de Rooy --- (In reply to Fridolin Somers from comment #68) > Buuuuuuuut, we also need this change in UNIMARC XSLT files right ? > And what about custom files ? They have been following different paths for long time already. Custom files obviously are not in scope here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 10:26:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 08:26:31 +0000 Subject: [Koha-bugs] [Bug 19707] Add new operations for synchronizing Elasticsearch mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19707 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala at helsinki.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 10:28:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 08:28:25 +0000 Subject: [Koha-bugs] [Bug 30836] Elasticsearch mappings.yaml is out of sync with upgraded databases In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30836 --- Comment #8 from Ere Maijala --- Looks like Bug 19707 would indeed provide a lot of the functionality. What remains would be automatic updating of non-customized fields and prominent message during upgrade that prompts to merge any changes manually. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 13:58:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 11:58:05 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 13:58:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 11:58:08 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138473|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 138599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138599&action=edit Bug 29144: First sort the HTML options Test plan: Check result while adding a new HTML customization entry. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 13:58:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 11:58:12 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138474|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 138600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138600&action=edit Bug 29144: Add OpacBranchInfo as HTML option, show it on opac Test plan: Add a few OpacBranchInfo for libraries. Verify that opac-library shows the correct info per library. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 13:58:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 11:58:16 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138527|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy --- Created attachment 138601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138601&action=edit Bug 29144: (follow-up) Terminology: rename to OpacLibraryInfo git grep -l OpacBranchInfo | xargs sed -i -e's/OpacBranchInfo/OpacLibraryInfo/g' Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 13:58:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 11:58:19 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138528|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy --- Created attachment 138602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138602&action=edit Bug 29144: Add $contents->find_best_match, $library->opac_info Test plan: Run t/db_dependent/Koha/AdditionalContents.t Run t/db_dependent/Koha/Library.t Note: You may need to set ListOwnershipUponPatronDeletion to delete to fix a pending issue in patron->delete with lists. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 13:58:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 11:58:23 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #12 from Marcel de Rooy --- Created attachment 138603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138603&action=edit Bug 29144: Use ->opac_info in opac-library template The opac_info call uses find_best_match which does not result in the All libaries plus specific library response of AdditionalContents.get. Test plan: Revisit individual library page on OPAC. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 13:58:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 11:58:26 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #13 from Marcel de Rooy --- Created attachment 138604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138604&action=edit Bug 29144: Remove opac_info from GetItemsInfo Test plan: Run t/db_dependent/Items.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 13:58:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 11:58:30 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #14 from Marcel de Rooy --- Created attachment 138605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138605&action=edit Bug 29144: Show html opac_info on opac-detail page Note: This patch disables the API call (which is not really needed), and still needs attention in a following patch. Test plan: Add opac_info for two libraries and a branchurl for one of the two. Select a biblio with an item having these two libraries as either home or holding branch. Toggle OpacLocationBranchToDisplay and check items table on opac detail. Click on the library name. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 13:58:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 11:58:33 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #15 from Marcel de Rooy --- Created attachment 138606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138606&action=edit Bug 29144: Adjust libraries form Test plan: [1] Go to Administration / libraries. [2] Check list view. [3] Check view on individual library with/without opac info. [4] Edit individual library with/without opac info. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 13:58:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 11:58:36 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #16 from Marcel de Rooy --- Created attachment 138607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138607&action=edit Bug 29144: Remove opac_info from a few tests Test plan: Run t/db_dependent/Circulation/GetHardDueDate.t Run t/db_dependent/Circulation/OfflineOperation.t Run t/db_dependent/RotatingCollections.t Run t/db_dependent/api/v1/libraries.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 13:58:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 11:58:40 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #17 from Marcel de Rooy --- Created attachment 138608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138608&action=edit Bug 29144: Copy and remove branches.opac_info (dbrev) Test plan: Run dbrev. Check api URL: /api/v1/public/libraries (with/without suffix /[branch_code]. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 13:58:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 11:58:44 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #18 from Marcel de Rooy --- Created attachment 138609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138609&action=edit Bug 29144: (DBIx schema) Drop branches.opac_info No test plan. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 14:01:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 12:01:16 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This reports moves the release notes| |contents of column | |branches.opac_info to a | |HTML block under Additional | |contents, identified by the | |new location | |OpacLibraryInfo. | |This | |allows translation of this | |block too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 14:13:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 12:13:27 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 14:21:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 12:21:35 +0000 Subject: [Koha-bugs] [Bug 31158] Can't filter suggestions by date ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31158 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #4 from Jonathan Druart --- Rachael, were you signed off on purpose? The process you followed is not correct, please read https://wiki.koha-community.org/wiki/Sign_off_on_patches You didn't attach the correct patch to the bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 14:21:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 12:21:46 +0000 Subject: [Koha-bugs] [Bug 31158] Can't filter suggestions by date ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31158 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138519|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 14:51:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 12:51:06 +0000 Subject: [Koha-bugs] [Bug 30650] Add a curbside pickup module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #166 from Tomás Cohen Arazi --- Created attachment 138610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138610&action=edit Bug 30650: (QA follow-up) Fix TINYINT fields discrepancy on upgrade Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 14:57:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 12:57:49 +0000 Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 138611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138611&action=edit Bug 29632: (QA follow-up) Fix COMMENT discrepancy on upgrade Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 16:50:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 14:50:43 +0000 Subject: [Koha-bugs] [Bug 28806] Labels exported as PDF create zero sized PDF files. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 --- Comment #26 from Chris Nighswonger --- (In reply to Manos PETRIDIS from comment #22) > If "bad data" is the only issue, why does the problem manifest itself only > in batch label creation? Spine labels are created just fine (attachment > 20220804_Spine labels_Tools_Koha.pdf). Apparently batch label creation has > different rules in defining what "bad data" is. > I am not stating nor am I sure that "bad data" is the or the only issue or an issue at all. It could be. And I have chased label "bugs" before which were, indeed due to bad data. Data which broke very specific use cases. But I acknowledge that this may not be the case here. > Furthermore, search (as in /cgi-bin/koha/catalogue/itemsearch.pl for > example), has no problem showing greek characters on screen or exporting > them as CSV (attachments 20220804_on_screen_results.PNG and > 20220804_export_to_CSV.PNG). The CSV posted originally does have the issues I noted earlier for me. We are working on different environments and what shows properly in one may not in the other. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 17:37:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 15:37:20 +0000 Subject: [Koha-bugs] [Bug 31281] Overdue notices reply-to email address of a branch not respected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 --- Comment #2 from Nason Bimbe --- The cron job is as follows $KOHA_CRON_PATH/automatic_renewals.pl -c --send-notices The Triggers are branch specific. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 17:45:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 15:45:52 +0000 Subject: [Koha-bugs] [Bug 27973] Limit to currently available items should have an option to filter out notforloan statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27973 Benjamin Daeuber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber at cityoffargo.com --- Comment #1 from Benjamin Daeuber --- I just want to give this bug a bump, since this in no way matches staff or patron expectations at the moment. I also like the idea of a system preference, because it's possible libraries may want local, non circulating collections to appear in "available items". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 17:50:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 15:50:05 +0000 Subject: [Koha-bugs] [Bug 30049] Add ability to download a list as a list of items as spreasheet/CSV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30049 Benjamin Daeuber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber at cityoffargo.com --- Comment #4 from Benjamin Daeuber --- We looked into this as a development a few years ago, but ultimately decided against it since it sounded like it would take a ground up rewrite of the "list" functionality. That said, we are definitely interested in pursuing it if anyone has any ideas. The way I see this is almost like making "lists" an extension of the search function. You could use facets to limit the list, then print or export the items that remain. Staff use lists to identify materials for displays or projects and extending them so you could at least see the items attached would be helpful. Open to any ideas on this point. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 18:17:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 16:17:55 +0000 Subject: [Koha-bugs] [Bug 27595] Place holds for patrons on accepted purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 18:29:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 16:29:57 +0000 Subject: [Koha-bugs] [Bug 31291] New: Batch import of records from ISBN list Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31291 Bug ID: 31291 Summary: Batch import of records from ISBN list Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Many libraries are moving away from the big vendors (and their bulk record files for import) and are looking for a way to import batches of records. For instance, if I order 20 items from Amazon, etc, I have to import each record one by one. It would be helpful to have a tool where I could enter a list of ISBNs, select one of my z39.50 targets, and import the records that are found. The function would need to have some sort of matching rules that could be applied, and have the results in a grouped set like it is with staged record batches. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 19:51:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 17:51:25 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #272 from Victor Grousset/tuxayo --- At this point the best hope would be for a few user libraries to pool funding together and contract a support company to revive this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 19:55:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 17:55:09 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #45 from Victor Grousset/tuxayo --- Congratulation Mason :D Even if there is still mystery we will be able to close bug 30030 when it hit the prod repo, right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 20:33:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 18:33:14 +0000 Subject: [Koha-bugs] [Bug 31281] Overdue notices reply-to email address of a branch not respected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 --- Comment #3 from Nason Bimbe --- Here is the complete set of Cron jobs as set up (Auto renew, fine, overdue notice) $KOHA_CRON_PATH/automatic_renewals.pl -c --send-notices; $KOHA_CRON_PATH/fines.pl; $KOHA_CRON_PATH/overdue_notices.pl -t --frombranch item-homebranch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 21:02:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 19:02:26 +0000 Subject: [Koha-bugs] [Bug 28707] Missing strings in translation of sample data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28707 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Translate RECEIPT notice |Missing strings in |(fr-CA) |translation of sample data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 21:13:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 19:13:42 +0000 Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with other endpoints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 21:20:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 19:20:23 +0000 Subject: [Koha-bugs] [Bug 31292] New: Untranslatable string in sample_notices.yaml Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31292 Bug ID: 31292 Summary: Untranslatable string in sample_notices.yaml Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr I'm trying to find the following sentence in the po files "[% IF article_request.format == 'PHOTOCOPY' %]You may pick up your article at [% branch.branchname %].[% ELSIF article_request.format == 'SCAN' %]You can download the scanned materials via the following url(s): [% article_request.urls %].[% END %]" It is in installer/data/mysql/en/mandatory/sample_notices.yml in the AR_COMPLETED notice. Bug 28707 corrected a problem for some strings, but this sentence does not appear in the po even after that. This sentence goes back to 22.05 (bug 20472). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 21:20:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 19:20:40 +0000 Subject: [Koha-bugs] [Bug 31292] Untranslatable string in sample_notices.yaml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31292 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28707 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 21:20:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 19:20:40 +0000 Subject: [Koha-bugs] [Bug 28707] Missing strings in translation of sample data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28707 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31292 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 21:56:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 19:56:17 +0000 Subject: [Koha-bugs] [Bug 31291] Batch import of records from ISBN list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31291 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #1 from Barbara Johnson --- +1 This would be awesome functionality! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 21:56:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 19:56:42 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #70 from Katrin Fischer --- (In reply to Victor Grousset/tuxayo from comment #69) > Address::Email isn't in the cpanfile nor the cpanfile of the subsequent Koha > releases. > grepping Address::Email yield nothing in the code of 20.11.x > Do you mean Email::Address? > > It's in the cpanfile so it should be in our repo. Yes, it didn't start and gave compilation errors. Also Email::Address of course :) We build our own packages, maybe that could have something to do with it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 21:59:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 19:59:36 +0000 Subject: [Koha-bugs] [Bug 31284] Add a calendar log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31284 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #2 from Barbara Johnson --- This is a great idea - we have definitely encountered the strange behavior caused by adding/removing holidays. A calendar log would make tracking down these issues much quicker. +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 22:26:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 20:26:49 +0000 Subject: [Koha-bugs] [Bug 26632] BatchStageMarcRecords passes a random number to AddBiblioToBatch / AddAuthToBatch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26632 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135047|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes --- Created attachment 138612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138612&action=edit Bug 26632: (Bug 22532 follow-up) Remove random variables AddBiblioToBatch and AddAuthToBatch were btoh passing a random number for the parameter $update_counts This simply removes that value as should have been done on 22532 To test: 1 - Stage a marc file 2 - Confirm it works befor and after patch Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 22:26:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 20:26:52 +0000 Subject: [Koha-bugs] [Bug 26632] BatchStageMarcRecords passes a random number to AddBiblioToBatch / AddAuthToBatch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26632 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135048|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes --- Created attachment 138613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138613&action=edit Bug 26632: Remove two more occurrences Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 22:27:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 20:27:34 +0000 Subject: [Koha-bugs] [Bug 26632] BatchStageMarcRecords passes a random number to AddBiblioToBatch / AddAuthToBatch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26632 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 22:42:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 20:42:06 +0000 Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose at inlibr | |o.com Keywords| |Manual-updated Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/579 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 4 23:14:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Aug 2022 21:14:47 +0000 Subject: [Koha-bugs] [Bug 30923] OAuth2 implementation is not experimental In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30923 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/581 Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose at inlibr | |o.com Keywords|Manual |Manual-updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 03:58:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 01:58:10 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #113 from Victor Grousset/tuxayo --- The test suite passes. --- Here is the only complain from the QA script: FAIL C4/Items.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 Is it legit? --- Tell me (Jonathan or a QAer that looks into this) if there is particular stuff to test manually. For lack of clues I just reread all the patches in case there where something obviously suspicious. I haven't done development with those functions and in all the places they are used so I can't tell if the replacement of GetItemsInfo & co is correct. Let's move on and see what QA has to say. These kind of patches with nothing clear to test can easily get stuck forever waiting for SO because testers don't know what to do. I would happily come back if there is precise stuff to test manually. Thanks Jonathan for the big refactoring! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 04:13:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 02:13:16 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138553|0 |1 is obsolete| | --- Comment #114 from Victor Grousset/tuxayo --- Created attachment 138614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138614&action=edit Bug 27272: Remove type= from detail.pl This is not related to anything known.. was it "itype" at some point? `git log -p` will tell you that it's there for a looong time already Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 04:13:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 02:13:21 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138554|0 |1 is obsolete| | --- Comment #115 from Victor Grousset/tuxayo --- Created attachment 138615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138615&action=edit Bug 27272: Remove GetItemsInfo from basket/basket Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 04:13:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 02:13:26 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138555|0 |1 is obsolete| | --- Comment #116 from Victor Grousset/tuxayo --- Created attachment 138616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138616&action=edit Bug 27272: Remove GetItemsInfo from basket/sendbasket Why are we display with $raw? Why are we display the location code instead of the AV's lib? Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 04:13:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 02:13:32 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138556|0 |1 is obsolete| | --- Comment #117 from Victor Grousset/tuxayo --- Created attachment 138617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138617&action=edit Bug 27272: Remove GetItemsInfo from catalogue/imageviewer Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 04:13:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 02:13:38 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138557|0 |1 is obsolete| | --- Comment #118 from Victor Grousset/tuxayo --- Created attachment 138618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138618&action=edit Bug 27272: Remove GetItemsInfo labels/label-item-search It was commented anyway Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 04:13:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 02:13:44 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138558|0 |1 is obsolete| | --- Comment #119 from Victor Grousset/tuxayo --- Created attachment 138619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138619&action=edit Bug 27272: Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl Hum... Item2Marc ok here? Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 04:13:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 02:13:50 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138559|0 |1 is obsolete| | --- Comment #120 from Victor Grousset/tuxayo --- Created attachment 138620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138620&action=edit Bug 27272: Remove GetItemsInfo from opac-detail Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 04:13:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 02:13:57 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138560|0 |1 is obsolete| | --- Comment #121 from Victor Grousset/tuxayo --- Created attachment 138621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138621&action=edit Bug 27272: Remove 'already_reserved' flag from opac-reserve.pl It was never set (was set before 14695) Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 04:14:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 02:14:02 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138561|0 |1 is obsolete| | --- Comment #122 from Victor Grousset/tuxayo --- Created attachment 138622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138622&action=edit Bug 27272: Remove GetHostItemsInfo and GetItemsInfo from opac-reserve Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 04:14:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 02:14:08 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138562|0 |1 is obsolete| | --- Comment #123 from Victor Grousset/tuxayo --- Created attachment 138623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138623&action=edit Bug 27272: Remove GetHostItemsInfo and GetItemsInfo from moredetail Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 04:14:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 02:14:14 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138563|0 |1 is obsolete| | --- Comment #124 from Victor Grousset/tuxayo --- Created attachment 138624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138624&action=edit Bug 27272: Remove GetItemsInfo from opac-sendbasket Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 04:14:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 02:14:19 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138564|0 |1 is obsolete| | --- Comment #125 from Victor Grousset/tuxayo --- Created attachment 138625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138625&action=edit Bug 27272: Remove GetItemsInfo import from opac-tags Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 04:14:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 02:14:26 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138565|0 |1 is obsolete| | --- Comment #126 from Victor Grousset/tuxayo --- Created attachment 138626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138626&action=edit Bug 27272: Remove GetItemsInfo from serials/routing-preview Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 04:14:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 02:14:32 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138566|0 |1 is obsolete| | --- Comment #127 from Victor Grousset/tuxayo --- Created attachment 138627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138627&action=edit Bug 27272: Remove GetItemsInfo from tags/list.pl Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 04:14:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 02:14:38 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138567|0 |1 is obsolete| | --- Comment #128 from Victor Grousset/tuxayo --- Created attachment 138628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138628&action=edit Bug 27272: Remove GetItemsInfo from virtualshelves/sendshelf.pl And GetItemsLocationInfo from shelves.pl Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 04:14:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 02:14:44 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138568|0 |1 is obsolete| | --- Comment #129 from Victor Grousset/tuxayo --- Created attachment 138629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138629&action=edit Bug 27272: Remove GetItemsInfo from catalogue/detail.pl Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 04:14:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 02:14:51 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138569|0 |1 is obsolete| | --- Comment #130 from Victor Grousset/tuxayo --- Created attachment 138630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138630&action=edit Bug 27272: Remove GetItemsInfo, GetItemsLocationInfo and GetHostItemsInfo Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 04:14:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 02:14:56 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138570|0 |1 is obsolete| | --- Comment #131 from Victor Grousset/tuxayo --- Created attachment 138631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138631&action=edit Bug 27272: Add search_ordered sub to order items with extra conditions Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 04:15:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 02:15:03 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138571|0 |1 is obsolete| | --- Comment #132 from Victor Grousset/tuxayo --- Created attachment 138632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138632&action=edit Bug 27272: Allow to pass params and attributes to search_ordered Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 04:15:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 02:15:10 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138572|0 |1 is obsolete| | --- Comment #133 from Victor Grousset/tuxayo --- Created attachment 138633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138633&action=edit Bug 27272: Add tests for search_ordered Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 04:15:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 02:15:16 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138573|0 |1 is obsolete| | --- Comment #134 from Victor Grousset/tuxayo --- Created attachment 138634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138634&action=edit Bug 27272: Call search_ordered when GetItemsInfo was called before Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 04:15:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 02:15:23 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138574|0 |1 is obsolete| | --- Comment #135 from Victor Grousset/tuxayo --- Created attachment 138635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138635&action=edit Bug 27272: Fix availability - OPAC Has to move some code to a method Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 04:15:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 02:15:29 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138575|0 |1 is obsolete| | --- Comment #136 from Victor Grousset/tuxayo --- Created attachment 138636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138636&action=edit Bug 27272: Fix library display on routing slip - to squash Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 04:17:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 02:17:09 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #137 from Victor Grousset/tuxayo --- (the only thing found when reviewing was a minor typo on a FIXME comment. It was fixed by amending the commit. holding_branc => holding_branch) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 04:32:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 02:32:50 +0000 Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Needs Signoff |Patch doesn't apply --- Comment #24 from Victor Grousset/tuxayo --- Patch doesn't apply and doesn't even make conflicts, just fails. Why does applying patches regularly does this? Applying: Bug 30847: Don't get biblio/item info when placing holds error: sha1 information is lacking or useless (opac/opac-reserve.pl). error: could not build fake ancestor Patch failed at 0001 Bug 30847: Don't get biblio/item info when placing holds note: dependency bug 27272 is applied patch -p1 < /tmp/Bug-30847-Dont-get-biblioitem-info-when-placing-ho-giEvEm.patch patching file opac/opac-reserve.pl Hunk #1 FAILED at 130. 1 out of 5 hunks FAILED -- saving rejects to file opac/opac-reserve.pl.rej I never did this but it seems theoretically possible to manually apply(copy paste lines!!!) the failed hunk but it would be quite tedious and unreliable. Jonathan: if you don't have time to rebase I can do it, just push your local version to a branch so I can use that and get conflict instead of this terrible error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 04:35:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 02:35:06 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Needs Signoff |Patch doesn't apply --- Comment #26 from Victor Grousset/tuxayo --- Conflicts, if you don't have time, I can give a try before Monday. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 04:36:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 02:36:04 +0000 Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |victor at tuxayo.net --- Comment #36 from Victor Grousset/tuxayo --- Conflicts, if you don't have time, I can give a try before Monday. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 07:57:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 05:57:38 +0000 Subject: [Koha-bugs] [Bug 31293] New: Add HTML Customization to self-registration to allow libraries to provide terms and conditions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31293 Bug ID: 31293 Summary: Add HTML Customization to self-registration to allow libraries to provide terms and conditions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org A lot of libraries like to add "terms and conditions" to their self-registration pages. I typically add this using Javascript, but it would be a lot nicer and easier to use a HTML Customization so that libraries could write this themselves. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 07:59:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 05:59:39 +0000 Subject: [Koha-bugs] [Bug 23625] ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23625 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #12 from David Cook --- Hmm I don't know if this is working in newer versions... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 08:14:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 06:14:02 +0000 Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in memberentry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Status|Signed Off |BLOCKED --- Comment #23 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 08:51:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 06:51:19 +0000 Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in memberentry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 08:51:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 06:51:22 +0000 Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in memberentry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138545|0 |1 is obsolete| | --- Comment #24 from Marcel de Rooy --- Created attachment 138637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138637&action=edit Bug 30874: Replace categoryname == Test plan == 1. Apply all patches 2. Create a new patron in a given category => Form show the dropdown with the selected category 3. Edit again => Value is kept 4. Edit a category to give it specific values for: messaging prefs, password strength/length, can be guarantee 5. Edit the patron, change the category, and confirm that the different limitation are correctly applied. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 08:51:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 06:51:27 +0000 Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in memberentry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138546|0 |1 is obsolete| | --- Comment #25 from Marcel de Rooy --- Created attachment 138638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138638&action=edit Bug 30874: Reduce number of category fetches Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 08:51:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 06:51:31 +0000 Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in memberentry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138547|0 |1 is obsolete| | --- Comment #26 from Marcel de Rooy --- Created attachment 138639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138639&action=edit Bug 30874: 2 more - need more investigation Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 08:51:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 06:51:35 +0000 Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in memberentry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138548|0 |1 is obsolete| | --- Comment #27 from Marcel de Rooy --- Created attachment 138640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138640&action=edit Bug 30874: Simplify categories loop construction Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 08:51:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 06:51:39 +0000 Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in memberentry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138549|0 |1 is obsolete| | --- Comment #28 from Marcel de Rooy --- Created attachment 138641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138641&action=edit Bug 30874: Remove category_type In which case do we pass category_type to this script? Am I missing something? Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:06:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:06:34 +0000 Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 --- Comment #37 from Marcel de Rooy --- I fixed the first conflict Looking at this one: Applying: Bug 27421: Use Background job for staging MARC records for import Applying: Bug 27421: Commit and revert error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/stage_marc_for_import.inc). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:15:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:15:00 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #138 from Jonathan Druart --- There is a test plan in comment 35. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:15:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:15:57 +0000 Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 --- Comment #38 from Marcel de Rooy --- Created attachment 138642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138642&action=edit Bug 27421: Use Background job for staging MARC records for import -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:16:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:16:01 +0000 Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136339|0 |1 is obsolete| | --- Comment #39 from Marcel de Rooy --- Created attachment 138643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138643&action=edit Bug 27421: Commit and revert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:16:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:16:32 +0000 Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136339|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:16:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:16:40 +0000 Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:17:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:17:57 +0000 Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |BLOCKED --- Comment #40 from Marcel de Rooy --- Manual patching the diffs: patching file Koha/BackgroundJob.pm patching file Koha/BackgroundJob/MARCImportCommitBatch.pm patching file Koha/BackgroundJob/MARCImportRevertBatch.pm patching file debian/templates/apache-shared-intranet-plack.conf patching file koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/marc_import_commit_batch.inc patching file koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/marc_import_revert_batch.inc patching file koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/stage_marc_for_import.inc patching file koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt patching file koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt patching file tools/manage-marc-import.pl Hunk #6 NOT MERGED at 275-283. I do not trust the last script. Somehow we ended up touching a considerable lower number of lines.. Will have a look -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:22:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:22:17 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:22:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:22:22 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137707|0 |1 is obsolete| | Attachment #137715|0 |1 is obsolete| | Attachment #137803|0 |1 is obsolete| | Attachment #137804|0 |1 is obsolete| | Attachment #137805|0 |1 is obsolete| | Attachment #137806|0 |1 is obsolete| | Attachment #137807|0 |1 is obsolete| | Attachment #137868|0 |1 is obsolete| | Attachment #137869|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart --- Created attachment 138644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138644&action=edit Bug 30718: Use flatpickr's altInput The idea rely on the KohaDates TT plugin for the date formatting. We should not have any output_pref calls in pl or pm (there are some exceptions, for ILSDI for instance). Also flatpickr will deal with the places where dates are inputed. We will pass the raw SQL value (what we call 'iso' in Koha::DateUtils), and the controller will receive the same value, no need to additional conversion. Note that DBIC has the capability to auto-deflate DateTime objects, which makes things way easier. We can either pass the value we receive from the controller, or pass a DT object to our methods. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:22:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:22:26 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #28 from Jonathan Druart --- Created attachment 138645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138645&action=edit Bug 30718: Pass DT to filter_by_lates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:22:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:22:31 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #29 from Jonathan Druart --- Created attachment 138646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138646&action=edit Bug 30718: Fix today's date on overdue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:22:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:22:35 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #30 from Jonathan Druart --- Created attachment 138647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138647&action=edit Bug 30718: Fix serials/showpredictionpattern.pl Can't locate object method "ymd" via package "2022-02-01" (perhaps you forgot to load "2022-02-01"?) at /kohadevbox/koha/serials/showpredictionpattern.pl line 100 eval {...} at /kohadevbox/koha/serials/showpredictionpattern.pl line 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:22:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:22:40 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #31 from Jonathan Druart --- Created attachment 138648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138648&action=edit Bug 30718: Add missing USE KohaDates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:22:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:22:45 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #32 from Jonathan Druart --- Created attachment 138649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138649&action=edit Bug 30718: Fix holidays Template process failed: undef error - The given date (07/18/2022) does not match the date format (iso) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:22:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:22:49 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #33 from Jonathan Druart --- Created attachment 138650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138650&action=edit Bug 30718: Fix scheduler -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:22:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:22:54 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #34 from Jonathan Druart --- Created attachment 138651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138651&action=edit Bug 30718: Fix time display Especifically when timeformat=12h -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:22:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:22:58 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #35 from Jonathan Druart --- Created attachment 138652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138652&action=edit Bug 30718: Prevent 'reset' icon to appear twice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:23:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:23:53 +0000 Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 --- Comment #41 from Marcel de Rooy --- The diff in the original 35K patch gives me on tools/manage-marc-import.pl: 1 file changed, 47 insertions(+), 22 deletions(-) But there are definitely 210 changes in that patch file. (found with sed) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:24:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:24:10 +0000 Subject: [Koha-bugs] [Bug 30926] Remove unnecessary use statements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30926 --- Comment #8 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #7) > Tomas: Is this something that you would be willing to push quickly? > In that case I might have a look soon,, yes... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:28:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:28:22 +0000 Subject: [Koha-bugs] [Bug 30926] Remove unnecessary use statements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30926 --- Comment #9 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #8) > (In reply to Marcel de Rooy from comment #7) > > Tomas: Is this something that you would be willing to push quickly? > > In that case I might have a look soon,, > > yes... Tomas never responded -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:28:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:28:23 +0000 Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 --- Comment #16 from sandboxes at biblibre.com --- Created attachment 138653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138653&action=edit Bug 28726: Add sort1 and sort2 to patron card creator - patron search. Also adds a select all / clear all and checkboxes. Test plan: 1. start a new batch in the patron card creator (Tools -> Patron card creator -> New -> card batch) 2. click the Add patron(s) button. Observe that Category and Library are the only options. 3. Close search for patron window. 4. Apply patch. 5. click the Add patron(s) button. Observe that you can now search for patrons by their sort1 and sort2 values. 6. perform a search and observe the 'Select all | Clear all | Add selected patrons' links and button. 7. use the Select all link to select all the patrons found by the search. 8. use the Add selected patrons button to add the selected patrons to the card batch's Add by borrowernumber(s) text input field. 9. close the search for patron window. Signed-off-by: Emmanuel Bétemps -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:29:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:29:01 +0000 Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Emmanuel Bétemps changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:30:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:30:42 +0000 Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137674|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Created attachment 138654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138654&action=edit Bug 30847: Don't get biblio/item info when placing holds The only bit we get form the hash is the rank and title We can si9mply fetch the biblio once to calculate no need to fetch all the info as we don't display or use it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:30:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:30:47 +0000 Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137675|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart --- Created attachment 138655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138655&action=edit Bug 30847: Consolidate code to check if patron can place holds and exit if they cannot This wil save us fetching more info if we are denying the holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:30:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:30:58 +0000 Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:32:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:32:53 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #36 from Marcel de Rooy --- Having a look here right now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:39:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:39:28 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #37 from Marcel de Rooy --- testing 9 commit(s) (applied to e544ff4 '45 Bug 29632: (QA follow-up) Fix COMM') Processing files before patches |========================>| 118 / 118 (100.00%) Processing files after patches |========================>| 118 / 118 (100.00%) No failures from qa tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:40:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:40:17 +0000 Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:40:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:40:22 +0000 Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136338|0 |1 is obsolete| | Attachment #136339|0 |1 is obsolete| | Attachment #138642|0 |1 is obsolete| | Attachment #138643|0 |1 is obsolete| | --- Comment #42 from Jonathan Druart --- Created attachment 138656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138656&action=edit Bug 27421: Use Background job for staging MARC records for import -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 09:40:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 07:40:27 +0000 Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 --- Comment #43 from Jonathan Druart --- Created attachment 138657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138657&action=edit Bug 27421: Commit and revert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 10:32:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 08:32:44 +0000 Subject: [Koha-bugs] [Bug 29971] Remember selections across patron search pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|Failed QA |Passed QA --- Comment #14 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #13) > Hi! The added tests are failing for me. Can you review it ASAP? Which one? The one that is failing on master? Yes that's expected, you are supposed to revert it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 10:36:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 08:36:00 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #38 from Marcel de Rooy --- Minor code observations: Koha/Hold.pm + $date &&= dt_from_string($date)->truncate( to => 'day' )->datetime; Obsure code clubs/clubs-add-modify.pl +my $date_start = $cgi->param('date_start') || undef; Does this || undef really serve any purpose here? Not the only occurrence btw. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 10:40:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 08:40:34 +0000 Subject: [Koha-bugs] [Bug 27497] Display Koha version in staff interface home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #57 from Jonathan Druart --- Letting Tomas decide then now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 10:42:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 08:42:41 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #273 from Jonathan Druart --- The best hope is to find people to focus on it at the same time. Having someone to rebase it is not enough, I have rebased it and adjusted it dozens of times already. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 10:42:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 08:42:48 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #39 from Marcel de Rooy --- Editing items: Should $w Price effective from be controlled by flatpickr ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 10:46:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 08:46:31 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #40 from Marcel de Rooy --- Hmm. I am just globally testing a bit. But this does not provide confidence: Adding a expiration date for a new hold. The date does not get saved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 10:48:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 08:48:24 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #41 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #38) > Minor code observations: > > Koha/Hold.pm > + $date &&= dt_from_string($date)->truncate( to => 'day' )->datetime; > Obsure code Obscure? It's using a basic perl operator... Prefer the verbose if version if ( $date ) { $date = dt_from_string($date)->truncate( to => 'day' )->datetime; } or the ugly ternary? $date = $date ? dt_from_string($date)->truncate( to => 'day' )->datetime : undef I don't. > clubs/clubs-add-modify.pl > +my $date_start = $cgi->param('date_start') || undef; > Does this || undef really serve any purpose here? > Not the only occurrence btw. I don't know, but trying to prevent regressions by keeping the exact same behaviours. (In reply to Marcel de Rooy from comment #39) > Editing items: Should $w Price effective from be controlled by flatpickr ? Isn't it already? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 10:50:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 08:50:08 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #42 from Marcel de Rooy --- Allowing future hold dates: | 77 | 51 | 0000-00-00 | 1 | CPL | NULL | NULL | NULL | NULL | NULL | | 1 | NULL | 2022-08-05 08:48:48 | NULL | NULL | 0000-00-00 | 0000-00-00 | 0 | 0 | NULL | NULL | 0 | 0 | I am getting 0000-00-00 dates in now. Three in a row . Hmm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 10:52:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 08:52:18 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #43 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #40) > Hmm. I am just globally testing a bit. But this does not provide confidence: > > Adding a expiration date for a new hold. > The date does not get saved. It does for me, can you provide more detail maybe? /cgi-bin/koha/reserve/request.pl?biblionumber=117 search edna select a date in "Hold expires on date:" place hold => Date is in the expiration column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 10:53:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 08:53:10 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #44 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #43) > (In reply to Marcel de Rooy from comment #40) > > Hmm. I am just globally testing a bit. But this does not provide confidence: > > > > Adding a expiration date for a new hold. > > The date does not get saved. > > It does for me, can you provide more detail maybe? > > /cgi-bin/koha/reserve/request.pl?biblionumber=117 > search edna > select a date in "Hold expires on date:" > place hold > => Date is in the expiration column I am testing now under dd/mm/yy. Could that be the cause ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 10:54:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 08:54:41 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #45 from Marcel de Rooy --- No with mm/dd/yy I still have a new hold without two dates (hold start and end date entered). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 10:57:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 08:57:11 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #46 from Marcel de Rooy --- Hey. When I switch to yy-mm-dd only THEN the hold dates are saved ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 10:57:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 08:57:31 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #47 from Marcel de Rooy --- | 79 | 51 | 2022-08-08 | 1 | CPL | NULL | NULL | NULL | NULL | NULL | | 1 | NULL | 2022-08-05 08:56:43 | NULL | NULL | 2022-08-15 | 2022-08-15 | 0 | 0 | NULL | NULL | 0 | 0 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 11:01:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 09:01:34 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #48 from Marcel de Rooy --- Well I give up. Code looks good, nice improvement. But it does not work for me on holds. That is not providing confidence. Have some more people test it. Try adding a hold with start and end date in various dateformat settings. Will not set FQA but would be inclined to.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 11:11:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 09:11:00 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #49 from Jonathan Druart --- Created attachment 138658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138658&action=edit Bug 30718: Apply flatpickr changes to OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 11:11:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 09:11:59 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #46 from Mason James --- > my theory is that a newer olsen database is needed for u18 - its been > upgraded from 2018d to 2022a > (ps: i cant explain why u20 works with only a 2019c database??) > aah, the 2019b database has fixes for Brazil http://changelogs.ubuntu.com/changelogs/pool/universe/libd/libdatetime-timezone-perl/libdatetime-timezone-perl_2.38-1+2019c/changelog ------------------------------------------------------ libdatetime-timezone-perl (1:2.36-1+2019b) unstable; urgency=medium * Import upstream version 2.36. This release is based on version 2019b of the Olson database. It includes contemporary changes for Brazil and Palestine. <<< ------------------------------------------------------ updating u18 to libdatetime-timezone-perl_2.23-1+2022a_all.deb fixes the following errors 'Invalid local time for date in time zone: America/Campo_Grande' 'Invalid local time for date in time zone: America/Cuiaba' 'Invalid local time for date in time zone: America/Sao_Paulo' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 11:14:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 09:14:04 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #50 from Jonathan Druart --- Created attachment 138659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138659&action=edit Bug 30718: Fix dates display at the OPAC Found dateofbirth so far, do we have others? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 11:15:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 09:15:43 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #51 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #48) > Well I give up. Code looks good, nice improvement. But it does not work for > me on holds. That is not providing confidence. > Have some more people test it. > Try adding a hold with start and end date in various dateformat settings. > > Will not set FQA but would be inclined to.. The flatpick's options hadn't been updated at the OPAC. Please try with the last two patches applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 11:16:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 09:16:35 +0000 Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 --- Comment #44 from Marcel de Rooy --- Great it applies now. New module added. What I am missing here completely, is tests ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 11:18:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 09:18:04 +0000 Subject: [Koha-bugs] [Bug 29983] Display the return claims column in the circulation overdues page (overdue.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 --- Comment #21 from Jérémy Breuillard --- (In reply to Jonathan Druart from comment #20) > Jérémy, can you confirm that you agree with the 2 follow-ups please? It is better, I agree with that -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 11:20:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 09:20:22 +0000 Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 --- Comment #45 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #44) > Great it applies now. > New module added. > What I am missing here completely, is tests ! How could this be tested easily? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 11:25:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 09:25:16 +0000 Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 --- Comment #46 from Jonathan Druart --- (In reply to Jonathan Druart from comment #45) > (In reply to Marcel de Rooy from comment #44) > > Great it applies now. > > New module added. > > What I am missing here completely, is tests ! > > How could this be tested easily? I mean, I am not going to write UI tests, neither a full coverage of the import process. And enqueuing jobs is already tested by t/db_dependent/BackgroundJob.t I could make you happy by making `git grep MARCImportCommitBatch t` returns a couple of occurrences, but I don't know how to have a test that would be useful and that won't require too much time to write. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 11:31:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 09:31:18 +0000 Subject: [Koha-bugs] [Bug 29983] Display the return claims column in the circulation overdues page (overdue.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 11:31:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 09:31:53 +0000 Subject: [Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC user/pass information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 11:34:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 09:34:23 +0000 Subject: [Koha-bugs] [Bug 31293] Add HTML Customization to self-registration to allow libraries to provide terms and conditions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31293 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- There is PatronSelfRegistrationAdditionalInstructions and Bug 19838 - Add system preference for adding text to self registration form :) *** This bug has been marked as a duplicate of bug 19838 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 11:34:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 09:34:23 +0000 Subject: [Koha-bugs] [Bug 19838] Add system preference for adding text to self registration form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #14 from Katrin Fischer --- *** Bug 31293 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 11:40:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 09:40:59 +0000 Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 --- Comment #47 from Marcel de Rooy --- | 9 | finished | 1 | 0 | 51 | marc_import_commit_batch The job size for this job does not get updated? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 11:41:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 09:41:28 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23079 Status|RESOLVED |REOPENED --- Comment #47 from Mason James --- reopened, until confirmed fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 11:41:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 09:41:29 +0000 Subject: [Koha-bugs] [Bug 30030] Test t/db_dependent/Koha/Patrons.t is_going_to_expire fails on U18 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 Bug 30030 depends on bug 29718, which changed state. Bug 29718 Summary: DateTime - our 'iso' is not ISO 8601 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 11:41:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 09:41:29 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed more data than expected for the format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Bug 29403 depends on bug 29718, which changed state. Bug 29718 Summary: DateTime - our 'iso' is not ISO 8601 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 11:41:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 09:41:28 +0000 Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29718 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 11:46:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 09:46:45 +0000 Subject: [Koha-bugs] [Bug 31294] New: Article requests: Mandatory subfields in OPAC don't show they are required Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31294 Bug ID: 31294 Summary: Article requests: Mandatory subfields in OPAC don't show they are required Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org There are 3 system preference to mark fields mandatory in the article request form for different use cases: ArticleRequestsMandatory* If you set fields to mandatory, they will trigger a message on saving, but they are missing the visible markup so you can tell right away that they are mandatory. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 11:47:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 09:47:21 +0000 Subject: [Koha-bugs] [Bug 23625] ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23625 --- Comment #13 from Katrin Fischer --- (In reply to David Cook from comment #12) > Hmm I don't know if this is working in newer versions... I've filed a new bug report after testing this in master: Bug 31294 - Article requests: Mandatory subfields in OPAC don't show they are required The visual is missing, bit it complains when saving. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 11:50:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 09:50:16 +0000 Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 --- Comment #48 from Jonathan Druart --- Created attachment 138660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138660&action=edit Bug 27421: Fix job's size for import -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 12:16:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 10:16:05 +0000 Subject: [Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- I think with the subsequent work on bug 23838 and friends this is probably fully covered.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 12:16:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 10:16:25 +0000 Subject: [Koha-bugs] [Bug 30321] Order receive page dies if quantity received is more than 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30321 --- Comment #8 from Emmi Takkinen --- Still seeing this on 21.11. To test: 1. Find order with one item and with quantity received as 1. 2. Navigate to receive this order from parcel.pl. 3. Click "Receive". OR 4. Use direct link to the order: /cgi-bin/koha/acqui/orderreceive.pl?ordernumber=&invoiceid= => error 500 is raised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 12:51:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 10:51:57 +0000 Subject: [Koha-bugs] [Bug 30992] Hard to translate single word strings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138393|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 138661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138661&action=edit Bug 30992: Improve translatability for Waiting at|On hold Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 12:52:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 10:52:01 +0000 Subject: [Koha-bugs] [Bug 30992] Hard to translate single word strings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138394|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 138662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138662&action=edit Bug 30992: Improve translatability for 'for' Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 12:52:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 10:52:10 +0000 Subject: [Koha-bugs] [Bug 30992] Hard to translate single word strings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 12:52:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 10:52:16 +0000 Subject: [Koha-bugs] [Bug 30992] Hard to translate single word strings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 12:52:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 10:52:30 +0000 Subject: [Koha-bugs] [Bug 30992] Hard to translate single word strings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from Martin Renvoize --- A clear improvement, no regressions. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 12:54:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 10:54:38 +0000 Subject: [Koha-bugs] [Bug 31264] CalendarFirstDayOfWeek not taken into account when configuring curbside pickups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31264 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138422|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 138663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138663&action=edit Bug 31264: Curbside pickups - Take CalendarFirstDayOfWeek into account We need to take the pref CalendarFirstDayOfWeek into account to display the days on the curbside pickups admin page. Test plan: Turn on the CurbsidePickup pref Set CalendarFirstDayOfWeek to Sunday Go to the curbside pickups admin page, add new slots, and confirm that Sunday is displayed first. Try again with CalendarFirstDayOfWeek set to Monday and Saturday. Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 12:55:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 10:55:01 +0000 Subject: [Koha-bugs] [Bug 31264] CalendarFirstDayOfWeek not taken into account when configuring curbside pickups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31264 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- No regressions and a solid improvement.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 12:55:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 10:55:08 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 12:55:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 10:55:13 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138249|0 |1 is obsolete| | --- Comment #86 from Katrin Fischer --- Created attachment 138664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138664&action=edit Bug 29897: Rename get_marc_authors with get_marc_contributors get_marc_authors actually return authors from 700..712, not the first author from 200 Sponsored-by: Orex Digital Signed-off-by: Orex Digital Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 12:55:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 10:55:17 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138250|0 |1 is obsolete| | --- Comment #87 from Katrin Fischer --- Created attachment 138665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138665&action=edit Bug 29897: Move code to private method for reusability Sponsored-by: Orex Digital Signed-off-by: Orex Digital Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 12:55:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 10:55:22 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138251|0 |1 is obsolete| | --- Comment #88 from Katrin Fischer --- Created attachment 138666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138666&action=edit Bug 29897: Add new pref OPACAuthorIdentifiers Sponsored-by: Orex Digital Signed-off-by: Orex Digital Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 12:55:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 10:55:26 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138425|0 |1 is obsolete| | --- Comment #89 from Katrin Fischer --- Created attachment 138667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138667&action=edit Bug 29897: Display author's identifiers This new enhancement add the capability to list the different identifiers of authors. It is helpful for research publications for instance. This patch will add a new "Author identifiers" tab on the detail page (OPAC) of a bibliographic record, with the list of the authors and their identifiers. On the detail page of the authority record, the same identifier list will be displayed. Test plan: Create some authority with 024 $a source $2 number $6 link to the source With the pref turned ON you will be able to see the new information. Sponsored-by: Orex Digital Signed-off-by: Orex Digital Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 12:55:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 10:55:31 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138426|0 |1 is obsolete| | --- Comment #90 from Katrin Fischer --- Created attachment 138668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138668&action=edit Bug 29897: Fix linkage Signed-off-by: Orex Digital Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 12:55:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 10:55:36 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138427|0 |1 is obsolete| | --- Comment #91 from Katrin Fischer --- Created attachment 138669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138669&action=edit Bug 29897: Don't use $6 for linkage but build the link instead See comment 26: $6 is a very specialized field that will never contain a URL. Linkage here means 'linking MARC fields within the record'. For example it is used to link an original script tag with the corresponding tag in transliteration. See: https://www.loc.gov/marc/authority/ecadcntf.html Sponsored-by: Orex Digital Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 12:55:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 10:55:41 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138428|0 |1 is obsolete| | --- Comment #92 from Katrin Fischer --- Created attachment 138670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138670&action=edit Bug 29897: Add and fix POD Sponsored-by: Orex Digital Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 12:55:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 10:55:46 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138429|0 |1 is obsolete| | --- Comment #93 from Katrin Fischer --- Created attachment 138671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138671&action=edit Bug 29897: Improve syspref's description Sponsored-by: Orex Digital Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 12:55:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 10:55:50 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138430|0 |1 is obsolete| | --- Comment #94 from Katrin Fischer --- Created attachment 138672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138672&action=edit Bug 29897: Add VIAF Sponsored-by: Orex Digital Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 12:55:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 10:55:55 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138431|0 |1 is obsolete| | --- Comment #95 from Katrin Fischer --- Created attachment 138673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138673&action=edit Bug 29897: Move the identifier list to an include file Sponsored-by: Orex Digital Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 12:56:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 10:56:00 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138432|0 |1 is obsolete| | --- Comment #96 from Katrin Fischer --- Created attachment 138674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138674&action=edit Bug 29897: Don't display identifier if not in the list Requested by QA, see comment 26. Sponsored-by: Orex Digital Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 12:56:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 10:56:05 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138433|0 |1 is obsolete| | --- Comment #97 from Katrin Fischer --- Created attachment 138675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138675&action=edit Bug 29897: Fix tab display Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 12:56:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 10:56:10 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138434|0 |1 is obsolete| | --- Comment #98 from Katrin Fischer --- Created attachment 138676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138676&action=edit Bug 29897: Remove 'linkage' leftover Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 12:56:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 10:56:14 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138486|0 |1 is obsolete| | --- Comment #99 from Katrin Fischer --- Created attachment 138677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138677&action=edit Bug 29897: Adjust syspref description Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 12:56:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 10:56:19 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138487|0 |1 is obsolete| | --- Comment #100 from Katrin Fischer --- Created attachment 138678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138678&action=edit Bug 29897: (QA follow-up) Add valid $2 codes to pref description Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 12:56:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 10:56:23 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138501|0 |1 is obsolete| | --- Comment #101 from Katrin Fischer --- Created attachment 138679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138679&action=edit Bug 29897: Don't display empty li It's ugly to move the li to the include file, but it's the easiest for now... Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 12:58:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 10:58:03 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #12 from Martin Renvoize --- Thanks guys, its great to have feedback. I've been away for a couple of weeks but should be able to get back onto this soon now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:01:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:01:44 +0000 Subject: [Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138399|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 138680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138680&action=edit Bug 31272: Use TT plugins for pickup library and due date in opac-reserve.pl Before this patch the date formatting for the due date was done in the .pl instead of the template and the branchcode would show instead of the library's name in the list of items when placing an item level hold in the OPAC. To test: * Find or create a record with mulitple items * Check out one of the items * Place a record level hold * Return an item to set to waiting * Place an item level hold * Go to the OPAC and start placing an item level hold * Verify the messages in the item table show the branchcode * Apply patch * Only visible change should be the library name replacing the branchcode Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:01:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:01:54 +0000 Subject: [Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:02:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:02:35 +0000 Subject: [Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Nice one Katrin, this is a great little improvement. Going straight for QA on this, it's clear and simple and achieves exactly what's on the tin. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:02:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:02:40 +0000 Subject: [Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:02:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:02:42 +0000 Subject: [Koha-bugs] [Bug 31276] Report results are limited to 999, 999 no matter the actual number of results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31276 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | --- Comment #2 from Katrin Fischer --- Please don't forget to set Assignee! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:03:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:03:07 +0000 Subject: [Koha-bugs] [Bug 31185] Link authorities automatically doesn't detect duplicate authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137860|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:03:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:03:20 +0000 Subject: [Koha-bugs] [Bug 31185] Link authorities automatically doesn't detect duplicate authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |adolfo.rodriguez at xercode.es |ity.org | --- Comment #4 from Katrin Fischer --- Please don't forget to set Assignee! :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:03:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:03:36 +0000 Subject: [Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:03:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:03:46 +0000 Subject: [Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 --- Comment #4 from Katrin Fischer --- Please don't forget to set Assignee! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:04:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:04:03 +0000 Subject: [Koha-bugs] [Bug 26632] BatchStageMarcRecords passes a random number to AddBiblioToBatch / AddAuthToBatch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26632 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138612|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:04:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:04:23 +0000 Subject: [Koha-bugs] [Bug 26632] BatchStageMarcRecords passes a random number to AddBiblioToBatch / AddAuthToBatch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26632 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | --- Comment #6 from Katrin Fischer --- Please don't forget to set Assignee! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:05:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:05:35 +0000 Subject: [Koha-bugs] [Bug 20511] Seasonal prediction just in the staff language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:12:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:12:36 +0000 Subject: [Koha-bugs] [Bug 31296] New: Add ability to disable demagnetizing items via SIP2 based on itemtypes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31296 Bug ID: 31296 Summary: Add ability to disable demagnetizing items via SIP2 based on itemtypes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Some libraries have certain item types that can only do in house checkouts via SIP self check machines. In these cases, the items should not be demagnetized since the items cannot leave the library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:12:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:12:43 +0000 Subject: [Koha-bugs] [Bug 31296] Add ability to disable demagnetizing items via SIP2 based on itemtypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31296 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:15:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:15:15 +0000 Subject: [Koha-bugs] [Bug 31296] Add ability to disable demagnetizing items via SIP2 based on itemtypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31296 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:15:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:15:19 +0000 Subject: [Koha-bugs] [Bug 31296] Add ability to disable demagnetizing items via SIP2 based on itemtypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31296 --- Comment #1 from Kyle M Hall --- Created attachment 138681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138681&action=edit Bug 31296: Add ability to disable demagnetizing items via SIP2 based on itemtypes Some libraries have certain item types that can only do in house checkouts via SIP self check machines. In these cases, the items should not be demagnetized since the items cannot leave the library. Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Message.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:15:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:15:31 +0000 Subject: [Koha-bugs] [Bug 31296] Add ability to disable demagnetizing items via SIP2 based on itemtypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31296 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26370 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370 [Bug 26370] Add ability to disable demagnetizing items via SIP2 based on patron categories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:15:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:15:31 +0000 Subject: [Koha-bugs] [Bug 26370] Add ability to disable demagnetizing items via SIP2 based on patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31296 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31296 [Bug 31296] Add ability to disable demagnetizing items via SIP2 based on itemtypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:17:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:17:55 +0000 Subject: [Koha-bugs] [Bug 20511] Seasonal prediction just in the staff language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #22 from Katrin Fischer --- Could you please rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:22:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:22:44 +0000 Subject: [Koha-bugs] [Bug 31249] update_patrons_category.pl cron does not log to action_logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31249 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:22:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:22:58 +0000 Subject: [Koha-bugs] [Bug 30926] Remove unnecessary use statements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30926 --- Comment #10 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #9) > (In reply to Jonathan Druart from comment #8) > > (In reply to Marcel de Rooy from comment #7) > > > Tomas: Is this something that you would be willing to push quickly? > > > In that case I might have a look soon,, > > > > yes... > > Tomas never responded There are too many things to look after, all the time. I've been pushing as fast as possible this kind of patch sets. If you are willing to work in this a bit more, I'm all in. Just DM me when ready so I add it to my priorities. Best regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:25:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:25:50 +0000 Subject: [Koha-bugs] [Bug 31203] Cronjobs should log completion as well as logging begin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #7 from Katrin Fischer --- Nick, should this be NSO? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:29:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:29:11 +0000 Subject: [Koha-bugs] [Bug 31249] update_patrons_category.pl cron does not log to action_logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31249 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:29:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:29:14 +0000 Subject: [Koha-bugs] [Bug 31249] update_patrons_category.pl cron does not log to action_logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31249 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138206|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 138682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138682&action=edit Bug 31249: Use cronlogaction on update_patrons_category.pl This patch does what the title says. To test: 1. Run the script 2. Check the action logs => FAIL: Boo, no record of the running cronjob 3. Apply this patch 4. Repeat 1-2 => SUCCESS: Yay! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:29:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:29:58 +0000 Subject: [Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:31:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:31:45 +0000 Subject: [Koha-bugs] [Bug 30030] Test t/db_dependent/Koha/Patrons.t is_going_to_expire fails on U18 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:31:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:31:49 +0000 Subject: [Koha-bugs] [Bug 30030] Test t/db_dependent/Koha/Patrons.t is_going_to_expire fails on U18 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 --- Comment #10 from Mason James --- Created attachment 138683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138683&action=edit Bug 30030: add 'invalid expiry date' tests, for every timezone this patch aims to add 'invalid expiry date' tests, for every timezone to test... 1/ apply patch 2/ run test root at kohadevbox:/kohadevbox/koha# prove -v t/db_dependent/Koha/Patrons.t ... 1..368 ... ok 32 - On invalid "is going to expire" date, the method should not crash: America/Argentina/Buenos_Aires ok 33 - On invalid "is going to expire" date, the method should not crash: America/Argentina/Catamarca ok 34 - On invalid "is going to expire" date, the method should not crash: America/Argentina/Cordoba ok 35 - On invalid "is going to expire" date, the method should not crash: America/Argentina/Jujuy ok 36 - On invalid "is going to expire" date, the method should not crash: America/Argentina/La_Rioja ok 37 - On invalid "is going to expire" date, the method should not crash: America/Argentina/Mendoza ok 38 - On invalid "is going to expire" date, the method should not crash: America/Argentina/Rio_Gallegos ok 39 - On invalid "is going to expire" date, the method should not crash: America/Argentina/Salta ok 40 - On invalid "is going to expire" date, the method should not crash: America/Argentina/San_Juan ok 41 - On invalid "is going to expire" date, the method should not crash: America/Argentina/San_Luis ok 42 - On invalid "is going to expire" date, the method should not crash: America/Argentina/Tucuman ok 43 - On invalid "is going to expire" date, the method should not crash: America/Argentina/Ushuaia ... All tests successful. Files=1, Tests=44, 84 wallclock secs ( 0.17 usr 0.07 sys + 58.19 cusr 24.35 csys = 82.78 CPU) Result: PASS 3/ confirm all 'invalid expiry date' tests pass OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:33:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:33:31 +0000 Subject: [Koha-bugs] [Bug 30030] Test t/db_dependent/Koha/Patrons.t is_going_to_expire fails on U18 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:37:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:37:03 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #48 from Mason James --- (In reply to Victor Grousset/tuxayo from comment #45) > Congratulation Mason :D > > Even if there is still mystery we will be able to close bug 30030 when it > hit the prod repo, right? yes, correct :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:40:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:40:24 +0000 Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #26 from Mason James --- (In reply to Jose Ricardo Quaglio from comment #25) > Katrin Fischer, > > We use version 18.11.03.000 and have a homologation server with version > 19.05.04.000. > > We are doing this to work around the problem. > > This year the government did not apply "summer time". > > I noticed that in version 19.05.04 this bug was adjusted, but I think it was > not thought in case the government did not implement this time. > > Tks, a very late update, but this seems to be a problem with ubuntu-bionic perhaps try upgrading to a newer ubuntu version -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:45:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:45:37 +0000 Subject: [Koha-bugs] [Bug 20511] Seasonal prediction just in the staff language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:45:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:45:43 +0000 Subject: [Koha-bugs] [Bug 20511] Seasonal prediction just in the staff language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135776|0 |1 is obsolete| | Attachment #135777|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart --- Created attachment 138684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138684&action=edit Bug 20511: Make seasons translatable in prediction pattern The season is stored in the DB in English and but not translated when displayed on the interface. This patch will translate the different seasons and their short form ('Spr' for 'Spring'). Test plan: Update the PO of the language you like Edit po/xx-XX-messages.po and translate the season names Setup a new language and use it for the staff interface Create a new subscription using the "Seasonal" subscription pattern Generate new serial items and confirm that the seasons are correctly translated when displayed Sponsored-by: Orex Digital Signed-off-by: Florian Bontemps -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 13:45:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 11:45:49 +0000 Subject: [Koha-bugs] [Bug 20511] Seasonal prediction just in the staff language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 --- Comment #24 from Jonathan Druart --- Created attachment 138685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138685&action=edit Bug 20511: Remove translation support for short version of season Everything get messy when we translate "Sum", then "Summer" as it's a substring. Signed-off-by: Florian Bontemps -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 14:11:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 12:11:30 +0000 Subject: [Koha-bugs] [Bug 31265] Curbside pickups - improve slots selection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 14:11:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 12:11:33 +0000 Subject: [Koha-bugs] [Bug 31265] Curbside pickups - improve slots selection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138405|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 138686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138686&action=edit Bug 31265: Update style of time selection controls This patch updates the style of the time selection controls so that it is clearer that they are elements which the user can interact with. The times are now styled as buttons, and a check-mark icon is added when a time is selected. Also changed: Pickup date and notes fields are hidden until a library has been selected. The count of existing appointments has been removed in favor of showing the count of available appointments. A tooltip has been added: "Appointments available: X" I also changed the way the date selection event is fired. I found that jQuery's "change" event on the input itself was not reliable for some reason. I implemented instead an "onClose" event using the flatpickr instance. Note: The patch contains some indentation changes. To test, apply the patch and enable and configure curbside pickups if necessary. You should have at least two libraries with curbside hours defined. - Log in to the OPAC and go to "your curbside pickups." - Under the "Schedule a pickup" tab you should see only the option to select a library. - When you select a library the "Pickup date" field should appear. - When you select a date the time-selection buttons and the notes field should appear. - Hovering over a time should trigger the "Appointments available" tooltip. - Clicking a time should cause the "button" to turn green with a check-mark icon. - Submit a pickup request and confirm that it is saved correctly. - Return to the "Schedule a pickup" form and confirm that selecting the same library again triggers a message, "You already have a pickup scheduled for this library." - Select another library and another date. - Switch your library selection to the library you already have a request for. The date, time, and notes fields should be hidden again and the same message triggered about already having a pickup scheduled. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 14:22:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 12:22:11 +0000 Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 14:25:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 12:25:42 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #13 from Martin Renvoize --- Created attachment 138687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138687&action=edit Bug 31162: Remove toolbar This patch removes the existing toolbar with 'New record' and 'New from Z39.50/SRU' and replaces the functionality with simple buttons on the page. We lose the ability to select the Framework or Z39.50/SRU server at this stage but one can still select these options from the resulting dialogues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 14:35:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 12:35:40 +0000 Subject: [Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 14:35:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 12:35:44 +0000 Subject: [Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138544|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 138688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138688&action=edit Bug 31289: Hide Article requests column in circulation rules when ArticleRequests syspref is disabled This patch hides the Article requests column in the large circulation rules table when the ArticleRequests system preference is disabled. To test: 0) Apply patch 1) With ArticleRequests disabled, go to Administration > Circulation and fines rules 2) Scroll right in the first table --> There isn't any mention of article requests in the table 3) Scroll down to see the other tables in the page --> There are no other article requests tables 4) Enable ArticleRequests in Administration > System preferences 5) Go back to the Circulation and fines rules and refresh the page 6) Scroll right in the first table --> There should be an article requests yes/no column 7) Scroll down to see the other tables in the page --> There are other article requests tables, Default open article requests limit and Default article request fees Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 14:36:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 12:36:21 +0000 Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #66 from Kyle M Hall --- Created attachment 138689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138689&action=edit Bug 28787: (QA follow-up) Remove unused variable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 14:37:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 12:37:44 +0000 Subject: [Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 --- Comment #6 from Katrin Fischer --- This makes things more consistent and simplifies for those not using Article requests, so I am going to pass it. There might be some discussion to be had if it makes sense to be able to configure a feature without having it exposed to users immediately. But that's complicated and should probably be a general decision (maybe something like having 3 options for the prefs? (Enable config|Enable feature|Disable) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 14:41:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 12:41:21 +0000 Subject: [Koha-bugs] [Bug 26632] BatchStageMarcRecords passes a random number to AddBiblioToBatch / AddAuthToBatch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26632 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138612|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 14:48:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 12:48:07 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #14 from Martin Renvoize --- We lose a tiny bit of functionality with that follow-up... one can no longer select the framework as part of the action.. but it's actually the same number of clicks in the end. i.e Before 1. Click the down arrow on the toolbar button 2. Click the framework 3. Start cataloguing After 1. Click the button 2. Start cataloguing in the default framework 3. Click the settings button to select framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 14:48:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 12:48:19 +0000 Subject: [Koha-bugs] [Bug 30500] Add option to allow user to change the pickup location while a hold is in transit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30500 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 14:48:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 12:48:23 +0000 Subject: [Koha-bugs] [Bug 30500] Add option to allow user to change the pickup location while a hold is in transit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30500 --- Comment #7 from Peter Vashchuk --- Created attachment 138690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138690&action=edit Bug 30500: (QA follow-up) Separate code execution streams for obviously independent parameters When $new_pickup_location gets passed as parameter it doesn't make any sense to also check is_cancelable_from_opac. Also this makes code more clearer as it seemed like it was possible for item to get cancelled at the same time as request to change pickup location. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 14:49:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 12:49:28 +0000 Subject: [Koha-bugs] [Bug 31296] Add ability to disable demagnetizing items via SIP2 based on itemtypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31296 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138681|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 138691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138691&action=edit Bug 31296: Add ability to disable demagnetizing items via SIP2 based on itemtypes Some libraries have certain item types that can only do in house checkouts via SIP self check machines. In these cases, the items should not be demagnetized since the items cannot leave the library. Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Message.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 14:53:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 12:53:40 +0000 Subject: [Koha-bugs] [Bug 31296] Add ability to disable demagnetizing items via SIP2 based on itemtypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31296 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138691|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 138692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138692&action=edit Bug 31296: Add ability to disable demagnetizing items via SIP2 based on itemtypes Some libraries have certain item types that can only do in house checkouts via SIP self check machines. In these cases, the items should not be demagnetized since the items cannot leave the library. Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Message.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 14:53:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 12:53:45 +0000 Subject: [Koha-bugs] [Bug 31296] Add ability to disable demagnetizing items via SIP2 based on itemtypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31296 --- Comment #4 from Martin Renvoize --- Created attachment 138693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138693&action=edit Bug 31296: (QA follow-up) Add to debian templates Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 14:53:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 12:53:55 +0000 Subject: [Koha-bugs] [Bug 31296] Add ability to disable demagnetizing items via SIP2 based on itemtypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31296 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 14:54:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 12:54:56 +0000 Subject: [Koha-bugs] [Bug 31296] Add ability to disable demagnetizing items via SIP2 based on itemtypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31296 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Martin Renvoize --- Going straight for QA on this one. Works as expected and is covered by tests.. example configs also updated. Passing QA. Please also add it to the wiki page detailing all the SIP options ;P I'd love to eventually see some of this stuff move to UI side configurations, but didn't want to hold this one up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 14:55:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 12:55:02 +0000 Subject: [Koha-bugs] [Bug 31296] Add ability to disable demagnetizing items via SIP2 based on itemtypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31296 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 15:03:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 13:03:58 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #15 from Emmanuel Bétemps --- There's one thing which doesn't apply : the Z39.50 button in Cataloging page - in the old fashioned way (after a search and not with the new Cataloging interface), a popup is displayed and the import button is useful - in this new page, clicking it doesn't open a pop-up AND, in a second time, the Import button has no effet The patch does not disable the Z39.50 search nor its importation feature : it's only the button in the new Cataloging page which doens't go well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 15:13:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 13:13:20 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138687|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize --- Created attachment 138694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138694&action=edit Bug 31162: Remove toolbar This patch removes the existing toolbar with 'New record' and 'New from Z39.50/SRU' and replaces the functionality with simple buttons on the page. We lose the ability to select the Framework or Z39.50/SRU server at this stage but one can still select these options from the resulting dialogues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 15:15:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 13:15:06 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #17 from Martin Renvoize --- Oop, I managed to drop some JS I shouldn't have.. it's restored now, so the Z39.50 options should trigger a popup again and trigger all the associated functionality there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 15:16:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 13:16:46 +0000 Subject: [Koha-bugs] [Bug 31297] New: Cannot add new subscription patterns from edit subscription page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31297 Bug ID: 31297 Summary: Cannot add new subscription patterns from edit subscription page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When adding a new subscription pattern from the edit subscription page, nothing happens when clicking on the bug. But we can see the following error from the API request: XHRGEThttp://localhost:8081/cgi-bin/koha/serials/create-numberpattern.pl?patternname=Test season with month&numberingmethod={X} {Y} {Z}&label1=Season&label2=Year&label3=Month&add1=1&add2=1&add3=1&every1=1&every2=4&every3=4&setto1=0&setto2=1&setto3=0&numbering1=season&numbering3=monthname&whenmorethan1=3&whenmorethan2=99999&whenmorethan3=11&locale=spa [HTTP/1.1 500 Internal Server Error 27ms] C4::Serials::Numberpattern::AddSubscriptionNumberpattern(): DBI Exception: DBD::mysql::st execute failed: Field 'description' doesn't have a default value at /kohadevbox/koha/serials/create-numberpattern.pl line 58 description is a field in the database, that can only be filled from the administration page for numbering patterns, but not from this screen. This has always been the case. Could this by a strict SQL error? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 15:27:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 13:27:50 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #18 from Emmanuel Bétemps --- It's ok for me : all buttons seem effective But I can't sign these patces, although they deserve it ^^ koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/cataloging-home.tt: needs merge WARNING: git-filter-branch has a glut of gotchas generating mangled history rewrites. Hit Ctrl-C before proceeding to abort, then use an alternative filtering tool such as 'git filter-repo' (https://github.com/newren/git-filter-repo/) instead. See the filter-branch manual page for more details; to squelch this warning, set FILTER_BRANCH_SQUELCH_WARNING=1. Proceeding with filter-branch... koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/cataloging-home.tt: needs merge Cannot rewrite branches: You have unstaged changes. Additionally, your index contains uncommitted changes. No stash entries found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 16:13:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 14:13:43 +0000 Subject: [Koha-bugs] [Bug 31203] Cronjobs should log completion as well as logging begin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 16:13:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 14:13:46 +0000 Subject: [Koha-bugs] [Bug 31203] Cronjobs should log completion as well as logging begin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #8 from Nick Clemens --- Created attachment 138695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138695&action=edit Bug 31203: Alter other cronjobs that currenlty use cronlogaction Added command line ooption logging and completion logging where cronlogaction was already imported. We should probably standardize all cronjobs, but this is a start One cron didn't log on confirm, likely we need to update all crons to log if confirm, and possibly not log if running in test mode? Another bug as well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 16:14:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 14:14:20 +0000 Subject: [Koha-bugs] [Bug 31203] Cronjobs should log completion as well as logging begin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #9 from Nick Clemens --- (In reply to Katrin Fischer from comment #7) > Nick, should this be NSO? Added patch to adjust other crons, NSO now ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 16:24:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 14:24:20 +0000 Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138149|0 |1 is obsolete| | Attachment #138150|0 |1 is obsolete| | Attachment #138151|0 |1 is obsolete| | Attachment #138152|0 |1 is obsolete| | Attachment #138153|0 |1 is obsolete| | Attachment #138154|0 |1 is obsolete| | Attachment #138155|0 |1 is obsolete| | Attachment #138156|0 |1 is obsolete| | Attachment #138157|0 |1 is obsolete| | Attachment #138158|0 |1 is obsolete| | Attachment #138159|0 |1 is obsolete| | Attachment #138689|0 |1 is obsolete| | --- Comment #67 from Kyle M Hall --- Created attachment 138696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138696&action=edit Bug 28787: Send a notice with the TOTP token Bug 28786 let librarians enable a Two-factor authentication but force them to use an application to generate the TOTP token. This new enhancement add the ability to send an email containing the token to the patron once it's authenticaed The new notice template has the code '2FA_OTP_TOKEN' Test plan: - Setup the two-factor authentication (you need the config entry and the syspref ON) - Enable it for your logged in patron - Logout - Login and notice the new link "Send the code by email" - Click on it and confirm that you received an email with the code - Use the code to be fully logged in QA question: Is 400 the correct error code to tell the email has not been sent? Signed-off-by: Marcel de Rooy Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 16:24:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 14:24:38 +0000 Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #68 from Kyle M Hall --- Created attachment 138697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138697&action=edit Bug 28787: (follow-up) Changes in API auth, moved otp out of Letters Signed-off-by: Marcel de Rooy Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 16:24:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 14:24:42 +0000 Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #69 from Kyle M Hall --- Created attachment 138698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138698&action=edit Bug 28787: Typo authenticaction Signed-off-by: Marcel de Rooy Signed-off-by: Marcel de Rooy Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 16:24:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 14:24:46 +0000 Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #70 from Kyle M Hall --- Created attachment 138699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138699&action=edit Bug 28787: Fix t/db_dependent/api/v1/two_factor_auth.t Changing flags to 20 to include the required Staff access for intranet login. This changes the http status. The API raises an exception now. Test plan: Run t/db_dependent/api/v1/two_factor_auth.t Signed-off-by: Marcel de Rooy Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 16:24:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 14:24:50 +0000 Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #71 from Kyle M Hall --- Created attachment 138700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138700&action=edit Bug 28787: Rename the REST API route to /auth/otp/token_delivery Signed-off-by: Marcel de Rooy Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 16:24:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 14:24:55 +0000 Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #72 from Kyle M Hall --- Created attachment 138701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138701&action=edit Bug 28787: Don't send the notice if we are not waiting for 2FA If we are fully logged-in or haven't pass the password phase, don't send the notice! Signed-off-by: Marcel de Rooy Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 16:24:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 14:24:58 +0000 Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #73 from Kyle M Hall --- Created attachment 138702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138702&action=edit Bug 28787: Don't request a token if no email address defined Signed-off-by: Marcel de Rooy Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 16:25:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 14:25:03 +0000 Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #74 from Kyle M Hall --- Created attachment 138703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138703&action=edit Bug 28787: Mock send_or_die To make the tests pass even if no SMTP server is defined. Signed-off-by: Marcel de Rooy Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 16:25:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 14:25:09 +0000 Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #75 from Kyle M Hall --- Created attachment 138704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138704&action=edit Bug 28787: Comment selenium test that will fail if no SMTP server is defined This is a deadlock I think. Any ideas how we could continue to test that in any conditions? Signed-off-by: Marcel de Rooy Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 16:25:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 14:25:13 +0000 Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #76 from Kyle M Hall --- Created attachment 138705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138705&action=edit Bug 28787: (follow-up) Typo and additional test Adding a test for a 403 status when lowering authorization. The Auth mock for check_cookie_auth is not needed here. Reading back the session after flush either. Signed-off-by: Marcel de Rooy Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 16:25:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 14:25:17 +0000 Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #77 from Kyle M Hall --- Created attachment 138706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138706&action=edit Bug 28787: Fix misleading tests in two_factor_auth.t We were having a "Patron is not authenticated yet" comment, but it was not correct, we set 'number' and 'id' in session, and waiting-for-2FA was not set => the patron is fully authenticated. The test returned 401 because we fully authenticated user cannot request an otp token when not waiting for the second auth step. This situation is already covered (last test of the subtest). Test plan: prove t/db_dependent/api/v1/two_factor_auth.t must return green Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 16:25:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 14:25:21 +0000 Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #78 from Kyle M Hall --- Created attachment 138707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138707&action=edit Bug 28787: (QA follow-up) Remove unused variable Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 16:27:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 14:27:03 +0000 Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 16:49:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 14:49:37 +0000 Subject: [Koha-bugs] [Bug 30646] Add option to send WELCOME notice for new patrons added at first login via LDAP/SAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30646 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 16:49:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 14:49:40 +0000 Subject: [Koha-bugs] [Bug 30646] Add option to send WELCOME notice for new patrons added at first login via LDAP/SAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30646 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136171|0 |1 is obsolete| | Attachment #136172|0 |1 is obsolete| | Attachment #136173|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 138708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138708&action=edit Bug 30646: Add welcome email support to LDAP This patch adds the ability to enable the welcome email notice for new users added via the LDAP replicate option. Test plan 1) Configure LDAP for authentication 2) Enable the welcome email by adding '1' to your ldap config block 3) Confirm you have replicate enabled for your LDAP config 4) Attempt to login with an entirely new user to Koha using the LDAP connection (with a user who has a valid email address mapped to Koha borrower fields) 5) Confirm the email is sent by looking at the notices for the new user. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 16:50:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 14:50:17 +0000 Subject: [Koha-bugs] [Bug 30646] Add option to send WELCOME notice for new patrons added at first login via LDAP/SAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30646 --- Comment #7 from Kyle M Hall --- Created attachment 138709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138709&action=edit Bug 30646: Add welcome email support to SAML2 This patch adds the ability to enable the welcome email notice for new users added via the Shibboleth autocreate option. Test plan 1) Configure Shibboleth for authentication 2) Enable the welcome email by adding '1' to your shibboleth config block 3) Confirm you have autocreate enabled for your Shibboleth config 4) Attempt to login with an entirely new user to Koha using the shibboleth connection (with a user who has a valid email address mapped to Koha borrower fields) 5) Confirm the email is sent by looking at the notices for the new user. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 16:50:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 14:50:21 +0000 Subject: [Koha-bugs] [Bug 30646] Add option to send WELCOME notice for new patrons added at first login via LDAP/SAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30646 --- Comment #8 from Kyle M Hall --- Created attachment 138710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138710&action=edit Bug 30646: (follow-up) Set to send immediately Other welcome notices send immediately rather than waiting on the queue to be processed.. these one's should too. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 16:58:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 14:58:37 +0000 Subject: [Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |tomascohen at gmail.com --- Comment #7 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #6) > This makes things more consistent and simplifies for those not using Article > requests, so I am going to pass it. > > There might be some discussion to be had if it makes sense to be able to > configure a feature without having it exposed to users immediately. But > that's complicated and should probably be a general decision (maybe > something like having 3 options for the prefs? (Enable config|Enable > feature|Disable) With the new table (circulation_rules) and the granularity it provides, I think we should move article requests-specific rules to their own section, and probably collapse them by default if the feature is disabled, but editable. For the same reasons you mentioned. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 17:05:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 15:05:26 +0000 Subject: [Koha-bugs] [Bug 27497] Display Koha version in staff interface home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 17:05:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 15:05:29 +0000 Subject: [Koha-bugs] [Bug 27497] Display Koha version in staff interface home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 --- Comment #58 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 17:05:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 15:05:32 +0000 Subject: [Koha-bugs] [Bug 30500] Add option to allow user to change the pickup location while a hold is in transit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30500 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 17:05:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 15:05:34 +0000 Subject: [Koha-bugs] [Bug 30500] Add option to allow user to change the pickup location while a hold is in transit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30500 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 17:05:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 15:05:37 +0000 Subject: [Koha-bugs] [Bug 30992] Hard to translate single word strings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 17:05:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 15:05:39 +0000 Subject: [Koha-bugs] [Bug 30992] Hard to translate single word strings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992 --- Comment #15 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 17:05:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 15:05:42 +0000 Subject: [Koha-bugs] [Bug 31249] update_patrons_category.pl cron does not log to action_logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31249 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 17:05:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 15:05:44 +0000 Subject: [Koha-bugs] [Bug 31249] update_patrons_category.pl cron does not log to action_logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31249 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 17:05:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 15:05:47 +0000 Subject: [Koha-bugs] [Bug 31264] CalendarFirstDayOfWeek not taken into account when configuring curbside pickups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31264 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 17:05:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 15:05:49 +0000 Subject: [Koha-bugs] [Bug 31264] CalendarFirstDayOfWeek not taken into account when configuring curbside pickups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31264 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 17:05:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 15:05:52 +0000 Subject: [Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 17:05:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 15:05:54 +0000 Subject: [Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 17:08:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 15:08:48 +0000 Subject: [Koha-bugs] [Bug 20511] Seasonal prediction just in the staff language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #25 from Katrin Fischer --- Hm, I think think this doesn't fix what was reported as the bug initially: comment#1 The seasonal (season, day and month) prediction it doesn't change according the locale defined in the patterns, the pattern uses always the language of the staff user interface. I believe that the expectation here is that it should work like months/day of week do. You should be able to use the Locale setting of the subscription to determine the language used for the generated strings, so that it matches with what is printed on the issue. These are not meant to be multi-lingual, but to match the 'original' printed version. What this patch does is actually the bug: It makes the description switch depending on the GUI language used. Before this patch (tested in 20.11): Staff interface: German Locale: German Preview pattern: German Serial collection: German Edit serials: English OPAC: English Database: English With this patch set: Staff interface: *English* Locale: Spanish Preview pattern: English Serial collection: English Edit serials: English OPAC: English Database: English Update translations, switch interface to German: Staff interface: *German* Locale: Spanish Preview pattern: German Subscription detail view: German Serial collection German Edit serials: English (!) (input fields) Database: English Staff detail view: German Late issues/claims: German OPAC detail page - Subscription: English OPAC brief history: English Full history: English Conclusion: 1) This makes the display more consistent in the staff interface. OPAC has been missed and should work the same as staff. 2) Locale setting is ignored for seasons. This makes seasons work different to the other formatted strings. This doesn't sit well with me, because it's also an inconsistency, but I am not sure there is a fix as I believe the library used for other strings just doesn't support seasons. :( If we agree on the different behavior we should document it. Suggestion: Extend the hint below the Locale pull down by: "Not used for seasons." 3) Removing the limited support for abbreviated seasons is a little issue. We can hardly remove the setting if libraries have used it, but is it really useful if it works only for English? A compromise could be to add a hint to the entry in the formatting pull down: "Name of season (abbreviated, English)" What could help here in the future would be a feature to define your own "formatted strings" as a list of authorised values (thought I had filed that... but can't find it). Codes would be numerical, AV would be the string used and we could use them to extend the list of available formats. I had requests for Roman numbering and we could also imagine someone wanting to do Japanese numbering or similar. This could help solve that issue. (I'll file later if people like it :) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 17:14:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 15:14:55 +0000 Subject: [Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #8 from Katrin Fischer --- Article request is only one column - so I think we should not start the discussion here. Having separate for all suspension/fine, holds, recalls etc. would certainly make sense, but this is a small enhancement that fits the current pattern well. The other is reopening the discussion on a new editor for circulation rules, which is needed, but out of scope. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 17:34:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 15:34:08 +0000 Subject: [Koha-bugs] [Bug 16002] MULTI choices in report dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16002 hebah at bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah at bywatersolutions.com --- Comment #5 from hebah at bywatersolutions.com --- This would be a great addition to reporting and a request I've been seeing a lot of recently in reports. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 17:56:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 15:56:53 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #71 from Victor Grousset/tuxayo --- when doing apt search libemail-address-perl, do you have results? And is it installed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 17:59:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 15:59:04 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #139 from Victor Grousset/tuxayo --- oh I missed it, thanks, I'll apply it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 18:03:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 16:03:23 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #140 from Nick Clemens --- patch needs minor rebase opac-details: Template process failed: undef error - The method Koha::Item->transfertwhen is not covered by tests! --from item-status-schema-org Itemtype icons no longer displaying in staff interface That's all I can touch right now. If you do not object to this becoming an omnibus and breaking it apart I will work through it in sections. I am happy to create the new bugs to help. This is fairly large in current state - I have some slight concerns about increased db fetches with this change and would like to be bale to focus on smaller bits -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 18:04:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 16:04:36 +0000 Subject: [Koha-bugs] [Bug 31292] Untranslatable string in sample_notices.yaml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31292 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 138711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138711&action=edit Bug 31292 - Untranslatable string in sample_notices.yaml This patch removes a regex that discard lines in multiline YAML values On close inspection, there is no need for it. To test: 1) go to misc translator, update some language ./translate update fr-CA 2) check missing string egrep "You may pick up your article" po/fr-CA-installer.po from sample_notices.yaml 3) apply the patch, repeat 1) 4) repeat 2), verify the string is present in the translation file 5) translate the new string, install the language, verify string is present in the translated file ./translate install fr-CA check fr-CA/mandatory/sample_notices.yml There are three new strings msgid "%sDear %s %s,%s" msgid "%s%s%sTitle: %s" msgid "%sYou may pick up your article at %s.%sYou can download the scanned materials via the following url(s): %s.%s" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 18:06:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 16:06:06 +0000 Subject: [Koha-bugs] [Bug 31292] Untranslatable string in sample_notices.yaml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31292 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | Status|NEW |Needs Signoff Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 18:19:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 16:19:55 +0000 Subject: [Koha-bugs] [Bug 30321] Order receive page dies if quantity received is more than 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30321 --- Comment #9 from Nick Clemens --- (In reply to Emmi Takkinen from comment #8) > Still seeing this on 21.11. > > To test: > 1. Find order with one item and with quantity received as 1. > 2. Navigate to receive this order from parcel.pl. > 3. Click "Receive". > OR > 4. Use direct link to the order: > /cgi-bin/koha/acqui/orderreceive. > pl?ordernumber=&invoiceid= > => error 500 is raised Can you describe the basket settings? When are items being created? I could use a full walkthrough from basket creation to error as I am not overly familiar with acquisitions workflows -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 18:30:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 16:30:21 +0000 Subject: [Koha-bugs] [Bug 31298] New: Framework defaults don't work when adding records to basket from external source Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31298 Bug ID: 31298 Summary: Framework defaults don't work when adding records to basket from external source Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: sbrown at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org In 21.11.05, it appears that framework defaults aren't working properly when adding records to a basket from an external source. To test: 1) Set the following framework/942$c defaults: ACQ/NEW, Default/BOOK, SR/MAG 2) Set UseACQFrameworkForBiblioRecords to "Use the framework 'ACQ' for bibliographic records fields" 3) Create a basket, and add to it 'From an external source' 4) Select the SR framework prior to searching via z39.50 5) Bring in your record, and view the bib - note that 942$c is blank 6) Repeat steps 3-5 with Default and ACQ frameworks selected - the result is the same. The same thing happens when steps 3-6 are repeated with UseACQFrameworkForBiblioRecords set to "Don't use". At least as recently as 20.05, selecting a specific framework in step 4 above would override the ACQ framework when UseACQFrameworkForBiblioRecords was set to "use". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 18:32:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 16:32:35 +0000 Subject: [Koha-bugs] [Bug 31298] Framework defaults don't work when adding records to basket from external source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31298 Sara Brown changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19372 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 18:32:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 16:32:35 +0000 Subject: [Koha-bugs] [Bug 19372] Selecting MARC framework doesn't work when adding to basket from an external source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 Sara Brown changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31298 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 19:07:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 17:07:59 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #274 from Christopher Brannon --- What would it mean to have many people focus on it? Previously you asked for more eyes and feedback. I'm not setup to get into the development side of things, but if there is anything several non-programmers can do to help and give feedback, I'm sure we can generate interest and people to do what they can. Can you be more specific on what is needed? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 19:16:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 17:16:41 +0000 Subject: [Koha-bugs] [Bug 16002] MULTI choices in report dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16002 --- Comment #6 from Christopher Brannon --- (In reply to Katrin Fischer from comment #1) > Hi Christopher, I think the problem is in how to make this work with the SQL > query. <> is usually used with =, multi could be used with 'in > (....)', but not sure how how to make an 'all' work in a good way. It seems like if you could do something like: homebranch IN (<>) If Koha could detect the parameter was in an IN statement, maybe it could use a dropdown that allows multiple selections. And if the all selection is made, all the selections would be in the IN statement. There would just need to be some logic to handle what to do if ALL was one of the multiple selections so it doesn't create strange results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 19:31:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 17:31:53 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #72 from Katrin Fischer --- (In reply to Victor Grousset/tuxayo from comment #71) > when doing apt search libemail-address-perl, do you have results? And is it > installed? Already fixed now by installing it, so I assume it wasn't. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 19:32:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 17:32:58 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Sara Brown changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbrown at bywatersolutions.com --- Comment #3 from Sara Brown --- Agreed - this would be useful for a lot of libraries! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 19:46:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 17:46:57 +0000 Subject: [Koha-bugs] [Bug 29983] Display the return claims column in the circulation overdues page (overdue.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #22 from Tomás Cohen Arazi --- There's a false-positive error detected by QA tools: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt FAIL valid_template modal-claims-js: not found noting here only for documentation purposes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 19:53:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 17:53:58 +0000 Subject: [Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 19:54:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 17:54:02 +0000 Subject: [Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131434|0 |1 is obsolete| | --- Comment #13 from Andrew Fuerste-Henry --- Created attachment 138712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138712&action=edit Bug 27265: Enable message queue cron to accept multiple codes and types It would be nice to be able to combine several types in a single run, but exclude others, without having to have multiple cron lines Test Plan: 1) Apply this patch 2) Run process_message_queue.pl with a single -c parameter 3) Note behavior is unchanged 4) Run process_message_queue.pl with multiple -c parameters 5) Note all the codes specified are processed 6) Repeat 2-5 with -t for type limits -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 19:54:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 17:54:56 +0000 Subject: [Koha-bugs] [Bug 29971] Remember selections across patron search pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 19:54:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 17:54:59 +0000 Subject: [Koha-bugs] [Bug 29971] Remember selections across patron search pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 --- Comment #15 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 19:55:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 17:55:01 +0000 Subject: [Koha-bugs] [Bug 29983] Display the return claims column in the circulation overdues page (overdue.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 19:55:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 17:55:04 +0000 Subject: [Koha-bugs] [Bug 29983] Display the return claims column in the circulation overdues page (overdue.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 --- Comment #23 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 19:55:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 17:55:07 +0000 Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in memberentry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 19:55:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 17:55:10 +0000 Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in memberentry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 --- Comment #29 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 19:55:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 17:55:13 +0000 Subject: [Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 19:55:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 17:55:16 +0000 Subject: [Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 20:22:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 18:22:30 +0000 Subject: [Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179 Sara Brown changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbrown at bywatersolutions.com --- Comment #11 from Sara Brown --- +1 - backporting would be helpful! Libraries might not notice the internal duplication until after the fact, which may make cleanup difficult. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 20:31:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 18:31:27 +0000 Subject: [Koha-bugs] [Bug 31239] search_for_data_inconsistencies.pl fails for Koha to MARC mapping using biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31239 --- Comment #2 from Fridolin Somers --- (In reply to Katrin Fischer from comment #1) > Which mapping caused the error? biblio.medium on 200$b UNIMARC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 20:33:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 18:33:43 +0000 Subject: [Koha-bugs] [Bug 31299] New: Duplicate output in search_for_data_inconsistencies.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31299 Bug ID: 31299 Summary: Duplicate output in search_for_data_inconsistencies.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz In search_for_data_inconsistencies.pl when there are several inconsistencies on same framework, the second output of items contains the first one. Looks like it is since Bug 21466 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 20:33:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 18:33:49 +0000 Subject: [Koha-bugs] [Bug 31299] Duplicate output in search_for_data_inconsistencies.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31299 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31239 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 20:33:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 18:33:49 +0000 Subject: [Koha-bugs] [Bug 31239] search_for_data_inconsistencies.pl fails for Koha to MARC mapping using biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31239 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31299 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 20:33:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 18:33:58 +0000 Subject: [Koha-bugs] [Bug 31299] Duplicate output in search_for_data_inconsistencies.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31299 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 20:35:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 18:35:53 +0000 Subject: [Koha-bugs] [Bug 31299] Duplicate output in search_for_data_inconsistencies.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31299 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21466 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 [Bug 21466] Data inconsistencies - koha fields linked to AV cat values must have a corresponding authorised value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 20:35:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 18:35:53 +0000 Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked to AV cat values must have a corresponding authorised value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31299 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31299 [Bug 31299] Duplicate output in search_for_data_inconsistencies.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 20:41:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 18:41:54 +0000 Subject: [Koha-bugs] [Bug 31299] Duplicate output in search_for_data_inconsistencies.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31299 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 20:41:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 18:41:57 +0000 Subject: [Koha-bugs] [Bug 31299] Duplicate output in search_for_data_inconsistencies.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31299 --- Comment #1 from Fridolin Somers --- Created attachment 138713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138713&action=edit Bug 31299: Fix duplicate output in search_for_data_inconsistencies.pl In search_for_data_inconsistencies.pl when there are several inconsistencies on same framework, the second output of items contains the first one. Looks like it is since Bug 21466 Test plan using koha-testing-docker : 1) Create 2 inconsistencies on the same item via SQL : update items set itemlost = 9 where itemnumber=900; update items set notforloan = 8 where itemnumber=900; 2) Without patch 3) Run ./misc/maintenance/search_for_data_inconsistencies.pl => You see duplicate output : == Wrong values linked to authorised values == * The Framework *BKS* is using the authorised value's category *NOT_LOAN*, but the following items.notforloan do not have a value defined ({itemnumber => value }): {900 => 8} * The Framework *BKS* is using the authorised value's category *LOST*, but the following items.itemlost do not have a value defined ({itemnumber => value }): {900 => 8} {900 => 9} 4) Apply patch 5) Run ./misc/maintenance/search_for_data_inconsistencies.pl => Fixed :D == Wrong values linked to authorised values == * The Framework *BKS* is using the authorised value's category *LOST*, but the following items.itemlost do not have a value defined ({itemnumber => value }): {900 => 9} * The Framework *BKS* is using the authorised value's category *NOT_LOAN*, but the following items.notforloan do not have a value defined ({itemnumber => value }): {900 => 8} -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 20:42:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 18:42:34 +0000 Subject: [Koha-bugs] [Bug 31299] Duplicate output in search_for_data_inconsistencies.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31299 --- Comment #2 from Fridolin Somers --- This can generate some huge outputs ^^ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 20:58:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 18:58:37 +0000 Subject: [Koha-bugs] [Bug 31300] New: Regression parcel.pl no longer totals Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31300 Bug ID: 31300 Summary: Regression parcel.pl no longer totals Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org Prior to 21.11 parcel.pl would show the total for an order Total tax excl 10.00 Tax 1.00 Total tax incl 11.00 In 21.11 you get Total tax excl 10.00 Tax 1.00 Total tax incl 10.00 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 21:37:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 19:37:03 +0000 Subject: [Koha-bugs] [Bug 30650] Add a curbside pickup module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Benjamin Daeuber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber at cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 21:59:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 19:59:47 +0000 Subject: [Koha-bugs] [Bug 30499] Keyboard shortcuts broken on several pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 --- Comment #10 from Tim McMahon --- Will this be added to 21.11? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 22:06:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 20:06:40 +0000 Subject: [Koha-bugs] [Bug 31222] DBIC queries for batch mod can be very large In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31222 --- Comment #5 from Nick Clemens --- (In reply to Rachael from comment #4) > (In reply to Nick Clemens from comment #3) > > (In reply to Rachael from comment #2) > > > Batch modifications changes each item. Ex. Modifying the Source of > > > classification or shelving scheme to Dewey Decimal Classification gets > > > applied. > > > > Hi Rachel, I am not sure what you mean here? Batch modification should > > update each item, is it updating more fields than intended? > > Hi Nick, > No, nothing else changes, just the fields that I specified. Should I sign it > off then? If everything works as expected with the patch, yes, please :-) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 22:13:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 20:13:16 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138614|0 |1 is obsolete| | --- Comment #141 from Victor Grousset/tuxayo --- Created attachment 138714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138714&action=edit Bug 27272: Remove type= from detail.pl This is not related to anything known.. was it "itype" at some point? `git log -p` will tell you that it's there for a looong time already -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 22:13:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 20:13:24 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138615|0 |1 is obsolete| | --- Comment #142 from Victor Grousset/tuxayo --- Created attachment 138715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138715&action=edit Bug 27272: Remove GetItemsInfo from basket/basket -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 22:13:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 20:13:32 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138616|0 |1 is obsolete| | --- Comment #143 from Victor Grousset/tuxayo --- Created attachment 138716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138716&action=edit Bug 27272: Remove GetItemsInfo from basket/sendbasket Why are we display with $raw? Why are we display the location code instead of the AV's lib? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 22:13:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 20:13:39 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138617|0 |1 is obsolete| | --- Comment #144 from Victor Grousset/tuxayo --- Created attachment 138717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138717&action=edit Bug 27272: Remove GetItemsInfo from catalogue/imageviewer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 22:13:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 20:13:47 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138618|0 |1 is obsolete| | --- Comment #145 from Victor Grousset/tuxayo --- Created attachment 138718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138718&action=edit Bug 27272: Remove GetItemsInfo labels/label-item-search It was commented anyway -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 22:13:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 20:13:54 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138619|0 |1 is obsolete| | --- Comment #146 from Victor Grousset/tuxayo --- Created attachment 138719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138719&action=edit Bug 27272: Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl Hum... Item2Marc ok here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 22:14:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 20:14:01 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138620|0 |1 is obsolete| | --- Comment #147 from Victor Grousset/tuxayo --- Created attachment 138720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138720&action=edit Bug 27272: Remove GetItemsInfo from opac-detail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 22:14:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 20:14:08 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138621|0 |1 is obsolete| | --- Comment #148 from Victor Grousset/tuxayo --- Created attachment 138721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138721&action=edit Bug 27272: Remove 'already_reserved' flag from opac-reserve.pl It was never set (was set before 14695) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 22:14:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 20:14:15 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138622|0 |1 is obsolete| | --- Comment #149 from Victor Grousset/tuxayo --- Created attachment 138722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138722&action=edit Bug 27272: Remove GetHostItemsInfo and GetItemsInfo from opac-reserve -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 22:14:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 20:14:24 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138623|0 |1 is obsolete| | --- Comment #150 from Victor Grousset/tuxayo --- Created attachment 138723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138723&action=edit Bug 27272: Remove GetHostItemsInfo and GetItemsInfo from moredetail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 22:14:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 20:14:31 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138624|0 |1 is obsolete| | --- Comment #151 from Victor Grousset/tuxayo --- Created attachment 138724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138724&action=edit Bug 27272: Remove GetItemsInfo from opac-sendbasket -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 22:14:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 20:14:38 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138625|0 |1 is obsolete| | --- Comment #152 from Victor Grousset/tuxayo --- Created attachment 138725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138725&action=edit Bug 27272: Remove GetItemsInfo import from opac-tags -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 22:14:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 20:14:50 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138626|0 |1 is obsolete| | --- Comment #153 from Victor Grousset/tuxayo --- Created attachment 138726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138726&action=edit Bug 27272: Remove GetItemsInfo from serials/routing-preview -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 22:14:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 20:14:57 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138627|0 |1 is obsolete| | --- Comment #154 from Victor Grousset/tuxayo --- Created attachment 138727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138727&action=edit Bug 27272: Remove GetItemsInfo from tags/list.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 22:15:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 20:15:05 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138628|0 |1 is obsolete| | --- Comment #155 from Victor Grousset/tuxayo --- Created attachment 138728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138728&action=edit Bug 27272: Remove GetItemsInfo from virtualshelves/sendshelf.pl And GetItemsLocationInfo from shelves.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 22:15:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 20:15:13 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138629|0 |1 is obsolete| | --- Comment #156 from Victor Grousset/tuxayo --- Created attachment 138729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138729&action=edit Bug 27272: Remove GetItemsInfo from catalogue/detail.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 22:15:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 20:15:24 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138630|0 |1 is obsolete| | --- Comment #157 from Victor Grousset/tuxayo --- Created attachment 138730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138730&action=edit Bug 27272: Remove GetItemsInfo, GetItemsLocationInfo and GetHostItemsInfo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 22:15:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 20:15:34 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138631|0 |1 is obsolete| | --- Comment #158 from Victor Grousset/tuxayo --- Created attachment 138731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138731&action=edit Bug 27272: Add search_ordered sub to order items with extra conditions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 22:15:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 20:15:41 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138632|0 |1 is obsolete| | --- Comment #159 from Victor Grousset/tuxayo --- Created attachment 138732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138732&action=edit Bug 27272: Allow to pass params and attributes to search_ordered -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 22:15:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 20:15:49 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138633|0 |1 is obsolete| | --- Comment #160 from Victor Grousset/tuxayo --- Created attachment 138733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138733&action=edit Bug 27272: Add tests for search_ordered -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 22:15:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 20:15:58 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138634|0 |1 is obsolete| | --- Comment #161 from Victor Grousset/tuxayo --- Created attachment 138734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138734&action=edit Bug 27272: Call search_ordered when GetItemsInfo was called before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 22:16:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 20:16:06 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138635|0 |1 is obsolete| | --- Comment #162 from Victor Grousset/tuxayo --- Created attachment 138735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138735&action=edit Bug 27272: Fix availability - OPAC Has to move some code to a method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 22:16:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 20:16:13 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138636|0 |1 is obsolete| | --- Comment #163 from Victor Grousset/tuxayo --- Created attachment 138736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138736&action=edit Bug 27272: Fix library display on routing slip - to squash -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 22:20:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 20:20:13 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #73 from Victor Grousset/tuxayo --- > We build our own packages, maybe that could have something to do with it? Maybe somehow it's not in the dependencies. Otherwise it would have been installed. VS the official package that indeed installs it, since when using ktd it is installed by default. So something up when making the list of deps. You also build the perl deps I suppose? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 22:43:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 20:43:39 +0000 Subject: [Koha-bugs] [Bug 31222] DBIC queries for batch mod can be very large In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31222 Rachael changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 22:43:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 20:43:42 +0000 Subject: [Koha-bugs] [Bug 31222] DBIC queries for batch mod can be very large In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31222 Rachael changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138038|0 |1 is obsolete| | --- Comment #6 from Rachael --- Created attachment 138737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138737&action=edit Bug 31222: Reduce query size for batchMod The object search is currently: Koha::Items->search({ barcode => \@contentlist } Which generate code like: barcode = 1 OR barcode = 2 OR barcode = 3 .... This can get quite large We can reduce the query size by using -in: Koha::Items->search({ barcode => { -in => \@contentlist } } Which generates code like: barcode in ( 1, 2, 3 ) To test: 1 - Apply patch 2 - Perform batch modifications 3 - Confirm nothing has changed Signed-off-by: Rachael Laritz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 5 22:49:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Aug 2022 20:49:37 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #164 from Victor Grousset/tuxayo --- (In reply to Nick Clemens from comment #140) > patch needs minor rebase Here it is, hope that helps ^^ (Bug 31272 caused a bit of trouble with date stuff but it was solvable reliably :) ) > That's all I can touch right now. If you do not object to this becoming an > omnibus and breaking it apart I will work through it in sections. I am happy > to create the new bugs to help. I'm not Jonathan but to help: how could this be split? Like having a 1st ticket with the common work. And including a minor "Remove GetItemsInfo from XXX" And then having several tickets each with a large "Remove GetItemsInfo from XXX" And the minor ones grouped into a ticket. Would that work well? To have less ticket management overhead and simplify the maintenance during the review (the many rebases!), would it work well to keep everything here and have multiple people review it? Like you could focus on only some of the "Remove GetItemsInfo from XXX" patches. The signed-off lines would keep track on the which patches are QAed and which aren't. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 6 02:10:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Aug 2022 00:10:19 +0000 Subject: [Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 6 02:29:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Aug 2022 00:29:16 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #275 from Victor Grousset/tuxayo --- If I recall correctly testing was most of what this patch needed. To check if stuff was broken in many parts of Koha. At the time, it was possible to test it (except crons) using the sandboxes, so non-programmers could have helped a lot without much being limited. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 6 10:19:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Aug 2022 08:19:48 +0000 Subject: [Koha-bugs] [Bug 31301] New: Upgrade to 21.11.05.004 [13:28:59]: ERROR: {UNKNOWN}: Can't use an undefined value as a subroutine reference at /usr/share/koha/lib/C4/Installer.pm line 737. at /usr/share/koha/lib/C4/Installer.pm line 739 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31301 Bug ID: 31301 Summary: Upgrade to 21.11.05.004 [13:28:59]: ERROR: {UNKNOWN}: Can't use an undefined value as a subroutine reference at /usr/share/koha/lib/C4/Installer.pm line 737. at /usr/share/koha/lib/C4/Installer.pm line 739 Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: syamsivanmail at gmail.com QA Contact: testopia at bugs.koha-community.org there is a bug during the up gradation time Upgrade to 21.11.05.004 [13:28:59]: ERROR: {UNKNOWN}: Can't use an undefined value as a subroutine reference at /usr/share/koha/lib/C4/Installer.pm line 737. at /usr/share/koha/lib/C4/Installer.pm line 739 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 6 21:11:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Aug 2022 19:11:47 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 6 21:11:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Aug 2022 19:11:54 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138593|0 |1 is obsolete| | Attachment #138594|0 |1 is obsolete| | Attachment #138595|0 |1 is obsolete| | Attachment #138596|0 |1 is obsolete| | Attachment #138597|0 |1 is obsolete| | --- Comment #440 from Michal Denar --- Created attachment 138738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138738&action=edit Bug 15516: Database and installer updates Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 6 21:12:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Aug 2022 19:12:04 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #441 from Michal Denar --- Created attachment 138739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138739&action=edit Bug 15516: Relevant controller changes and tests Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 6 21:12:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Aug 2022 19:12:14 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #442 from Michal Denar --- Created attachment 138740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138740&action=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library has the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Search for a patron 3. Check the 'Treat as hold group' checkbox 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a hold group)' in Details column. 6. Click on the "hold group" link. A modal window should appear with the content of the hold group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. The other holds will also be removed from the holds queue. 9. Confirm tests pass - t/db_dependent/Koha/Holds.t - t/db_dependent/Reserves/HoldGroup.t Note: the "hold group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl - circ/view_holdsqueue.pl Note: A hold group is counted as only one hold Sponsored-by: Catalyst IT Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 6 21:12:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Aug 2022 19:12:23 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #443 from Michal Denar --- Created attachment 138741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138741&action=edit Bug 15516: Add ability to create and view hold groups from OPAC This patch adds a "Treat as hold group" to opac-reserve.pl, which lets OPAC users create a hold group which can include 1+ bibs and either bib-level holds, or item-level holds, or both. This patch shows the item-level and bib-level holds in a hold group for the user's holds in the OPAC. This includes both the opac-user.pl page and the self-checkout hold display. Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 6 21:12:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Aug 2022 19:12:38 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #444 from Michal Denar --- Created attachment 138742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138742&action=edit Bug 15516: Schema updates Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 01:25:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Aug 2022 23:25:34 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #165 from Victor Grousset/tuxayo --- Issue found: 1. Apply the patches (with or without bug 30847) 2. Go to the OPAC 3. Go to any record details page 4. it blows up Template process failed: undef error - The method Koha::Item->transfertwhen is not covered by tests! Another issue found: 1. after from test plan: step 14 - Receive/find an issue with an item, view in opac 2. go to the staff detail page of the record 3. it blows up Template process failed: undef error - The method Koha::Serial::Item->publisheddate is not covered by tests! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 01:28:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Aug 2022 23:28:37 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 04:32:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 02:32:40 +0000 Subject: [Koha-bugs] [Bug 30779] Do not need to remove items from import biblios marc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 04:44:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 02:44:30 +0000 Subject: [Koha-bugs] [Bug 30543] Decouple DumpSearchQueryTemplate from other template dump preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30543 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 04:45:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 02:45:17 +0000 Subject: [Koha-bugs] [Bug 27920] Add ability to update patron expiration dates when importing patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 04:47:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 02:47:49 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 04:48:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 02:48:19 +0000 Subject: [Koha-bugs] [Bug 31245] Job detail view for batch mod explode if job not started In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31245 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 04:49:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 02:49:07 +0000 Subject: [Koha-bugs] [Bug 31276] Report results are limited to 999, 999 no matter the actual number of results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31276 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 04:49:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 02:49:39 +0000 Subject: [Koha-bugs] [Bug 31185] Link authorities automatically doesn't detect duplicate authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 13:39:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 11:39:54 +0000 Subject: [Koha-bugs] [Bug 31214] Regression: subfield code editable in MARC framework editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31214 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |joonas.kylmala at iki.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 13:44:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 11:44:13 +0000 Subject: [Koha-bugs] [Bug 31214] Regression: subfield code editable in MARC framework editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31214 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 13:44:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 11:44:17 +0000 Subject: [Koha-bugs] [Bug 31214] Regression: subfield code editable in MARC framework editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31214 --- Comment #3 from Joonas Kylmälä --- Created attachment 138743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138743&action=edit Bug 31214: Make subfield code non-editable in MARC framework editor The subfield code field became editable in framework editor due to a regression that happened during the switch from a previous template framework koha used to the new Template toolkit framework currently in use: Bug 5917 : Swapping templates over (5884fb100071e973daf671a4ada6b32724376768) The regression happened due to the template syntax not being updated to the new one in this particular case. Note: The subfield code field doesn't align with the other fields anymore after this patch. However, this alignment issue is in every other Koha form in intranet and should be fixed in the global CSS rules. 1) Apply patch 2) Browse to /cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=995&frameworkcode=AR 3) Notice the subfield code is non-editable 4) Notice the subfield code is still editable in the New tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 13:45:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 11:45:00 +0000 Subject: [Koha-bugs] [Bug 31214] Regression: subfield code editable in MARC framework editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31214 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 13:59:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 11:59:16 +0000 Subject: [Koha-bugs] [Bug 31214] Regression: subfield code editable in MARC framework editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31214 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 13:59:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 11:59:20 +0000 Subject: [Koha-bugs] [Bug 31214] Regression: subfield code editable in MARC framework editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31214 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138743|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 138744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138744&action=edit Bug 31214: Make subfield code non-editable in MARC framework editor The subfield code field became editable in framework editor due to a regression that happened during the switch from a previous template framework koha used to the new Template toolkit framework currently in use: Bug 5917 : Swapping templates over (5884fb100071e973daf671a4ada6b32724376768) The regression happened due to the template syntax not being updated to the new one in this particular case. Note: The subfield code field doesn't align with the other fields anymore after this patch. However, this alignment issue is in every other Koha form in intranet and should be fixed in the global CSS rules. 1) Apply patch 2) Browse to /cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=995&frameworkcode=AR 3) Notice the subfield code is non-editable 4) Notice the subfield code is still editable in the New tab. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 14:06:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 12:06:41 +0000 Subject: [Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592 --- Comment #13 from Katrin Fischer --- Not sure, should we work on this together with bug 30250 or abandon this one in favor of the other bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 14:09:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 12:09:06 +0000 Subject: [Koha-bugs] [Bug 31298] Framework defaults don't work when adding records to basket from external source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31298 --- Comment #1 from Katrin Fischer --- Hi Sarah, I believe this might have been intentional as we didn't want to alter existing records automatically as it could overwrite information you didn't mean to overwrite in the first place. But there is a bug now for making this behavior configurable: Bug 30250 - Configure when to apply framework defaults when cataloguing That could maybe be a solution here too or maybe be a logical enhancement of it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 14:09:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 12:09:14 +0000 Subject: [Koha-bugs] [Bug 31298] Framework defaults don't work when adding records to basket from external source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31298 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30250 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 [Bug 30250] Configure when to apply framework defaults when cataloguing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 14:09:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 12:09:14 +0000 Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31298 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31298 [Bug 31298] Framework defaults don't work when adding records to basket from external source -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 14:10:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 12:10:06 +0000 Subject: [Koha-bugs] [Bug 31298] Framework defaults don't work when adding records to basket from external source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31298 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 14:12:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 12:12:12 +0000 Subject: [Koha-bugs] [Bug 30321] Order receive page dies if quantity received is more than 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30321 --- Comment #10 from Katrin Fischer --- (In reply to Emmi Takkinen from comment #8) > Still seeing this on 21.11. > > To test: > 1. Find order with one item and with quantity received as 1. Wondering about this line - did you mean quantity ordered or indeed quantity received? If the item has been "fully" received, it should not show int he list of toe receive order lines. Could this be a data issue? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 15:12:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 13:12:19 +0000 Subject: [Koha-bugs] [Bug 31302] New: Spelling: You can download the scanned materials via the following url(s): Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31302 Bug ID: 31302 Summary: Spelling: You can download the scanned materials via the following url(s): Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org installer/data/mysql/en/mandatory/sample_notices.yml: - "[% IF article_request.format == 'PHOTOCOPY' %]You may pick up your article at [% branch.branchname %].[% ELSIF article_request.format == 'SCAN' %]You can download the scanned materials via the following url(s): [% article_request.urls %].[% END %]" The url(s) should be URL(s) :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 15:17:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 13:17:26 +0000 Subject: [Koha-bugs] [Bug 31292] Untranslatable string in sample_notices.yaml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31292 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 15:17:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 13:17:30 +0000 Subject: [Koha-bugs] [Bug 31292] Untranslatable string in sample_notices.yaml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31292 --- Comment #2 from Katrin Fischer --- Created attachment 138745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138745&action=edit Bug 31292: Untranslatable string in sample_notices.yaml This patch removes a regex that discard lines in multiline YAML values On close inspection, there is no need for it. To test: 1) go to misc translator, update some language ./translate update fr-CA 2) check missing string egrep "You may pick up your article" po/fr-CA-installer.po from sample_notices.yaml 3) apply the patch, repeat 1) 4) repeat 2), verify the string is present in the translation file 5) translate the new string, install the language, verify string is present in the translated file ./translate install fr-CA check fr-CA/mandatory/sample_notices.yml There are three new strings msgid "%sDear %s %s,%s" msgid "%s%s%sTitle: %s" msgid "%sYou may pick up your article at %s.%sYou can download the scanned materials via the following url(s): %s.%s" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 15:19:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 13:19:03 +0000 Subject: [Koha-bugs] [Bug 31292] Untranslatable string in sample_notices.yaml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31292 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138745|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 138746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138746&action=edit Bug 31292: Untranslatable string in sample_notices.yaml This patch removes a regex that discard lines in multiline YAML values On close inspection, there is no need for it. To test: 1) go to misc translator, update some language ./translate update fr-CA 2) check missing string egrep "You may pick up your article" po/fr-CA-installer.po from sample_notices.yaml 3) apply the patch, repeat 1) 4) repeat 2), verify the string is present in the translation file 5) translate the new string, install the language, verify string is present in the translated file ./translate install fr-CA check fr-CA/mandatory/sample_notices.yml There are three new strings msgid "%sDear %s %s,%s" msgid "%s%s%sTitle: %s" msgid "%sYou may pick up your article at %s.%sYou can download the scanned materials via the following url(s): %s.%s" Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 15:20:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 13:20:08 +0000 Subject: [Koha-bugs] [Bug 31292] Untranslatable string in sample_notices.yaml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31292 --- Comment #4 from Katrin Fischer --- Hi Caroline, if you still want to sign-off, we could count mine for QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 15:33:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 13:33:24 +0000 Subject: [Koha-bugs] [Bug 31265] Curbside pickups - improve slots selection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 --- Comment #5 from Katrin Fischer --- This looks great, thx! Could we think of something similar for the staff interface? (almost feeling greedy :)) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 15:34:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 13:34:08 +0000 Subject: [Koha-bugs] [Bug 31265] Curbside pickups - improve slots selection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 15:34:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 13:34:12 +0000 Subject: [Koha-bugs] [Bug 31265] Curbside pickups - improve slots selection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138686|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 138747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138747&action=edit Bug 31265: Update style of time selection controls This patch updates the style of the time selection controls so that it is clearer that they are elements which the user can interact with. The times are now styled as buttons, and a check-mark icon is added when a time is selected. Also changed: Pickup date and notes fields are hidden until a library has been selected. The count of existing appointments has been removed in favor of showing the count of available appointments. A tooltip has been added: "Appointments available: X" I also changed the way the date selection event is fired. I found that jQuery's "change" event on the input itself was not reliable for some reason. I implemented instead an "onClose" event using the flatpickr instance. Note: The patch contains some indentation changes. To test, apply the patch and enable and configure curbside pickups if necessary. You should have at least two libraries with curbside hours defined. - Log in to the OPAC and go to "your curbside pickups." - Under the "Schedule a pickup" tab you should see only the option to select a library. - When you select a library the "Pickup date" field should appear. - When you select a date the time-selection buttons and the notes field should appear. - Hovering over a time should trigger the "Appointments available" tooltip. - Clicking a time should cause the "button" to turn green with a check-mark icon. - Submit a pickup request and confirm that it is saved correctly. - Return to the "Schedule a pickup" form and confirm that selecting the same library again triggers a message, "You already have a pickup scheduled for this library." - Select another library and another date. - Switch your library selection to the library you already have a request for. The date, time, and notes fields should be hidden again and the same message triggered about already having a pickup scheduled. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 15:40:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 13:40:29 +0000 Subject: [Koha-bugs] [Bug 31292] Untranslatable string in sample_notices.yaml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31292 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138711|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 15:58:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 13:58:11 +0000 Subject: [Koha-bugs] [Bug 31281] Overdue notices reply-to email address of a branch not respected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 --- Comment #4 from Katrin Fischer --- I think I've found it. overdue notices uses EnqueueLetter to write the letter to the message_queue: C4::Letters::EnqueueLetter( { letter => $letter, borrowernumber => $borrowernumber, message_transport_type => $effective_mtt, from_address => $admin_email_address, to_address => join(',', @emails_to_use), } Reading the POD for EnqueueLetter this stands out: * reply_address - optional; The reply address for the notice, defaults to patron->library->reply_to So as we are not supplying the address, it would use the reply-to address of the patron's homebranch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 16:00:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 14:00:33 +0000 Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 16:01:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 14:01:59 +0000 Subject: [Koha-bugs] [Bug 30646] Add option to send WELCOME notice for new patrons added at first login via LDAP/SAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30646 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 16:04:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 14:04:51 +0000 Subject: [Koha-bugs] [Bug 31222] DBIC queries for batch mod can be very large In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31222 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 16:21:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 14:21:35 +0000 Subject: [Koha-bugs] [Bug 31281] Overdue notices reply-to email address of a branch not respected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 17:07:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 15:07:09 +0000 Subject: [Koha-bugs] [Bug 30992] Hard to translate single word strings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #16 from Victor Grousset/tuxayo --- There is a typo here https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138661&action=diff#a/opac/opac-reserve.pl_sec1 $itemLoopIter->{reservedate} = $first_hold->reservedate, $itemLoopIter->{ExpectedAtLibrary} = $first_hold->branchcode; 1st line ends with a comma instead of a semicolon. Shouldn't this not compile and have blown up during testing? And even the CI should blow up when checking syntax validity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 17:10:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 15:10:33 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138644|0 |1 is obsolete| | --- Comment #52 from Victor Grousset/tuxayo --- Created attachment 138748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138748&action=edit Bug 30718: Use flatpickr's altInput The idea rely on the KohaDates TT plugin for the date formatting. We should not have any output_pref calls in pl or pm (there are some exceptions, for ILSDI for instance). Also flatpickr will deal with the places where dates are inputed. We will pass the raw SQL value (what we call 'iso' in Koha::DateUtils), and the controller will receive the same value, no need to additional conversion. Note that DBIC has the capability to auto-deflate DateTime objects, which makes things way easier. We can either pass the value we receive from the controller, or pass a DT object to our methods. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 17:10:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 15:10:47 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138645|0 |1 is obsolete| | --- Comment #53 from Victor Grousset/tuxayo --- Created attachment 138749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138749&action=edit Bug 30718: Pass DT to filter_by_lates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 17:11:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 15:11:13 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138646|0 |1 is obsolete| | --- Comment #54 from Victor Grousset/tuxayo --- Created attachment 138750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138750&action=edit Bug 30718: Fix today's date on overdue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 17:11:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 15:11:26 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138647|0 |1 is obsolete| | --- Comment #55 from Victor Grousset/tuxayo --- Created attachment 138751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138751&action=edit Bug 30718: Fix serials/showpredictionpattern.pl Can't locate object method "ymd" via package "2022-02-01" (perhaps you forgot to load "2022-02-01"?) at /kohadevbox/koha/serials/showpredictionpattern.pl line 100 eval {...} at /kohadevbox/koha/serials/showpredictionpattern.pl line 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 17:11:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 15:11:40 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138648|0 |1 is obsolete| | --- Comment #56 from Victor Grousset/tuxayo --- Created attachment 138752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138752&action=edit Bug 30718: Add missing USE KohaDates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 17:11:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 15:11:52 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138649|0 |1 is obsolete| | --- Comment #57 from Victor Grousset/tuxayo --- Created attachment 138753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138753&action=edit Bug 30718: Fix holidays Template process failed: undef error - The given date (07/18/2022) does not match the date format (iso) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 17:12:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 15:12:10 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138650|0 |1 is obsolete| | --- Comment #58 from Victor Grousset/tuxayo --- Created attachment 138754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138754&action=edit Bug 30718: Fix scheduler -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 17:12:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 15:12:23 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138651|0 |1 is obsolete| | --- Comment #59 from Victor Grousset/tuxayo --- Created attachment 138755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138755&action=edit Bug 30718: Fix time display Especifically when timeformat=12h -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 17:12:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 15:12:35 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138652|0 |1 is obsolete| | --- Comment #60 from Victor Grousset/tuxayo --- Created attachment 138756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138756&action=edit Bug 30718: Prevent 'reset' icon to appear twice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 17:12:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 15:12:55 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138658|0 |1 is obsolete| | --- Comment #61 from Victor Grousset/tuxayo --- Created attachment 138757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138757&action=edit Bug 30718: Apply flatpickr changes to OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 17:13:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 15:13:11 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138659|0 |1 is obsolete| | --- Comment #62 from Victor Grousset/tuxayo --- Created attachment 138758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138758&action=edit Bug 30718: Fix dates display at the OPAC Found dateofbirth so far, do we have others? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 17:15:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 15:15:27 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #63 from Victor Grousset/tuxayo --- Another rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 17:15:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 15:15:54 +0000 Subject: [Koha-bugs] [Bug 30992] Hard to translate single word strings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992 --- Comment #17 from Katrin Fischer --- Strange, it didn't explode when I tested or wrote my follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 18:23:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 16:23:29 +0000 Subject: [Koha-bugs] [Bug 31265] Curbside pickups - improve slots selection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 18:23:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 16:23:34 +0000 Subject: [Koha-bugs] [Bug 31265] Curbside pickups - improve slots selection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 --- Comment #7 from Katrin Fischer --- Created attachment 138759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138759&action=edit Bug 31265: Use correct reply-to email when sending overdue mails Overdue emails are either sent from the issuing or the home library of an item. We never use the patron's home library, so the reply-to address must explicitly be set in EnqueueLetter. To test: - Set up 2 branches (A and B) with different email addresses. - Set up an SMTP server for each to use - Set up an overdue notice trigger for the patron category you'll use First letter: 1 day delay, any notice - Check out an item with home branch B to a patron from A - Run the the script with: overdue_notices.pl -t --frombranch item-homebranch overdue_notices.pl -t --frombranch item-issuebranch - Confirm for each setting that the correct email headers have been used. You can see the reply-to address and to-address in the message queue: SELECT * FROM message_queue; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 18:24:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 16:24:20 +0000 Subject: [Koha-bugs] [Bug 31281] Overdue notices reply-to email address of a branch not respected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 18:24:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 16:24:24 +0000 Subject: [Koha-bugs] [Bug 31281] Overdue notices reply-to email address of a branch not respected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 --- Comment #5 from Katrin Fischer --- Created attachment 138760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138760&action=edit Bug 31281: Use correct reply-to email when sending overdue mails Overdue emails are either sent from the issuing or the home library of an item. We never use the patron's home library, so the reply-to address must explicitly be set in EnqueueLetter. To test: - Set up 2 branches (A and B) with different email addresses. - Set up an SMTP server for each to use - Set up an overdue notice trigger for the patron category you'll use First letter: 1 day delay, any notice - Check out an item with home branch B to a patron from A - Run the the script with: overdue_notices.pl -t --frombranch item-homebranch overdue_notices.pl -t --frombranch item-issuebranch - Confirm for each setting that the correct email headers have been used. You can see the reply-to address and to-address in the message queue: SELECT * FROM message_queue; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 18:24:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 16:24:39 +0000 Subject: [Koha-bugs] [Bug 31265] Curbside pickups - improve slots selection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138759|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 18:42:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 16:42:21 +0000 Subject: [Koha-bugs] [Bug 31290] Getting error in batch modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31290 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31223, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31245 --- Comment #1 from Katrin Fischer --- Hi Nayema, bug 31223 and bug 31245 could be related to this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 18:42:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 16:42:21 +0000 Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31290 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 18:42:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 16:42:21 +0000 Subject: [Koha-bugs] [Bug 31245] Job detail view for batch mod explode if job not started In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31245 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31290 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 18:42:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 16:42:58 +0000 Subject: [Koha-bugs] [Bug 30213] Hide Delete (aka Priority) column when user only has place_hold permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 7 18:43:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Aug 2022 16:43:02 +0000 Subject: [Koha-bugs] [Bug 30213] Hide Delete (aka Priority) column when user only has place_hold permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131336|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 138761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138761&action=edit Bug 30213: Hide Delete (aka Priority) column when user only has place_hold permission This patch changes the way the priority column displays when viewing a list of holds as a user who doesn't have permission to change hold priority. To test: - Apply the patch and log into the staff interface as a user with at least "place_hold" permission. - Locate a record which can be put on hold and place multiple holds. - View the list of holds. - As a user with both "place_hold" and "modify_holds_priority" permission, you should see a "Priority" column with But we also have a few hidden ones. First verified that cleanborrowers did not work anymore with expirydate. Fixed it with passing iso dateformat to resolve. intranet-tmpl/prog/en/modules/acqui/parcels.tt: intranet-tmpl/prog/en/modules/serials/subscription-add.tt: intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt: intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt: intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt: intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt: intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt: Test plan: Try cleanborrowers with expiry date. cd koha-tmpl; git grep " -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 11:45:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 09:45:18 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #108 from Marcel de Rooy --- Created attachment 139468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139468&action=edit Bug 30718: (QA follow-up) Remove double use KohaDates Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 11:47:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 09:47:51 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #109 from Marcel de Rooy --- Ok Tomas, go ahead and push it. We will find the remaining things. Victor did a great job in testing too. Thx Jonathan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 11:51:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 09:51:11 +0000 Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870 Paul Derscheid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139452|0 |1 is obsolete| | --- Comment #23 from Paul Derscheid --- Created attachment 139469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139469&action=edit Bug 25870 - (follow-up) Removed Data::Dumper + call I refactored the controller code but unfortunately still haven't figured out why Koha::Biblios->search doesn't work properly. For the time being I still use Koha::Biblios->find. That aside I think it has become much cleaner now. To test: 1) Apply the patch 2) Pick an endpoint tester of your choice, e.g. Insomnia or the ThunderClient if you use VSCode or derivatives. 3) Run a query while using Zebra. 4) Observe the marc-in-json response and check for validity. 5) Run a query while using Elasticsearch. 6) Again, observe the marc-in-json response and check for validity. 7) Not ready for sign-off but please leave a comment or help me on the Koha::Biblios->search thing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 11:53:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 09:53:03 +0000 Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 11:53:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 09:53:07 +0000 Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123698|0 |1 is obsolete| | Attachment #123699|0 |1 is obsolete| | --- Comment #12 from Nick Clemens --- Created attachment 139470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139470&action=edit Bug 26626: Add 'Ignore' option to confirmed holds modal This patch adds 'Ignore' to the 'Hold already waiting' modal To test: To recreate: 1 - Place a hold for pickup at library A 2 - Checkin the item at Library A 3 - Note the modal has 'Ignore' option 4 - Click it, nothing happens 5 - Check in the item again, same modal 6 - Click 'Confirm' 7 - Check in the item again 8 - Now 'Ignore' is replaced by 'Cancel' 9 - Click 'Confirm' to dismiss modal 10 - Apply patch 11 - Check the item in again 12 - Note 'Ignore' button before 'Cancel' button with '-' icon 13 - Go to biblio holds page 14 - Revert waiting status 15 - Check item in again 16 - Note ignore now has '-' (minus) icon Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 11:53:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 09:53:11 +0000 Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 --- Comment #13 from Nick Clemens --- Created attachment 139471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139471&action=edit Bug 26626: (follow-up) Update icon selection This patch changes the "Ignore" button to use an X icon and the "Cancel" button to use a "Trash" icon. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 11:53:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 09:53:33 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #110 from Katrin Fischer --- Does this touch any of the coding guidelines or should we have a new one for how we want things to be done? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 11:59:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 09:59:44 +0000 Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 --- Comment #14 from Nick Clemens --- Created attachment 139472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139472&action=edit Bug 26626: (follow-up) Be consistent with icon and accesskeys -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 12:04:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 10:04:26 +0000 Subject: [Koha-bugs] [Bug 31419] New: Add accesskeys to recall modal Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31419 Bug ID: 31419 Summary: Add accesskeys to recall modal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com We have added accesskeys for the buttons on hold modals, we should have the same functionality on recalls -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 12:04:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 10:04:50 +0000 Subject: [Koha-bugs] [Bug 31419] Add accesskeys to recall modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31419 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20688, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26626 Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 12:04:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 10:04:50 +0000 Subject: [Koha-bugs] [Bug 20688] Add accesskeys for hold confirmation boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31419 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 12:04:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 10:04:50 +0000 Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31419 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 12:07:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 10:07:37 +0000 Subject: [Koha-bugs] [Bug 31419] Add accesskeys to recall modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31419 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 12:07:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 10:07:40 +0000 Subject: [Koha-bugs] [Bug 31419] Add accesskeys to recall modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31419 --- Comment #1 from Nick Clemens --- Created attachment 139473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139473&action=edit Bug 31419: Add accesskeys for modals This patch simply adds accesskey elements to the buttons, and changes an icon to be consistent with bug 26626 For tips on how to access the accesskeys: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey To test: 1 - Generate a recall 2 - Fill it/check in 3 - Note modal now has hints "Confirm (Y)" 4 - Test with Y,P,I keys (may need to recreate recalls) 5 - Confirm the recall and test waiting recall modal too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 12:08:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 10:08:00 +0000 Subject: [Koha-bugs] [Bug 31419] Add accesskeys to recall modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31419 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 12:32:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 10:32:40 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #22 from Martin Renvoize --- So.. where do we go from here.. * Should I remove the corresponding lines from the tools home page or do we think they should appear in both places. * Should we update the various pages now added to the 'cataloging' homepage such that their breadcrumbs now read `Home > Cataloging > Page` as apposed to `Home > Tools > Page` and similar * I'm working on bug 31417 to reinstate the cat-menu sidebar... same question as above about links appearing in both menus or just the new/reinstated cat-menu.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:01:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:01:46 +0000 Subject: [Koha-bugs] [Bug 30504] Value builder for UNIMARC field 181 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30504 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:01:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:01:50 +0000 Subject: [Koha-bugs] [Bug 30504] Value builder for UNIMARC field 181 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30504 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135163|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 139474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139474&action=edit Bug 30504: Value builder for field 181 This patch provides values builders for the subfields $a, $b, $c and $2. Those are unimarc official codes who help to identify the kind of items Test plan: 1)Go to Home > Cataloging > New record 2)Section 1 - field 181 : it contains subfields $a, $b, $c & $2 3)Inputs are writable but notice that no plugins are suggested 4)Apply patch and repeat 1) to 3) 5)Values builders plugins are available for $a, $b, $c and $2 Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:02:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:02:44 +0000 Subject: [Koha-bugs] [Bug 30506] Value builder for UNIMARC field 182 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:02:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:02:50 +0000 Subject: [Koha-bugs] [Bug 30506] Value builder for UNIMARC field 182 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135164|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 139475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139475&action=edit Bug 30506: Value builder for field 182 This patch provides values builders for the subfields $a, $c and $2. Those are unimarc official codes who help to identify the kind of items Test plan: 1)Go to Home > Cataloging > New record 2)Section 1 - field 182 : it contains subfields $a, $c & $2 3)Inputs are writable but notice that no plugins are suggested 4)Apply patch and repeat 1) to 3) 5)Values builders plugins are available for $a, $c and $2 Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:03:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:03:42 +0000 Subject: [Koha-bugs] [Bug 30507] Value builder for UNIMARC field 183 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30507 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:03:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:03:45 +0000 Subject: [Koha-bugs] [Bug 30507] Value builder for UNIMARC field 183 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30507 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135198|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 139476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139476&action=edit Bug 30507: Value builder for field 183 This patch provides values builders for the subfields $a and $2. Those are unimarc official codes who help to identify the kind of items Test plan: 1)Go to Home > Cataloging > New record 2)Section 1 - field 183 : it contains subfields $a & $2 3)Inputs are writable but notice that no plugins are suggested 4)Apply patch and repeat 1) to 3) 5)Values builders plugins are available for $a and $2 Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:20:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:20:26 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #187 from Nick Clemens --- Hi Aleisha, This looks great, but I found a few issues: 1 - Needs a minor rebase on top of article request rules 2 - The changes to iTiva outbound should be rebased on 31356 - essentially they aren't needed as we should use the already calculated expiration date 3 - I think the atomic update can simply be dropped - if the rule is not defined, it won't be used, no need to set it as blank 4 - When saving a more specific rule it is saved as blank, this still makes it the effective rule i.e. - Set a default rule with "Holds pickup period" as 25 - Set syspref ReservesMaxPickUpDelay to 1 - Set an branch specific all/all rule leaving "Holds pickup period" blank - Place two holds - one for pickup at branch with specific rule, one at another - Sign in as the correct libraries and check in items and confirm holds - Branch with specific rule - hold gets 1 day delay - Other branch - hold gets 25 day delay -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:20:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:20:42 +0000 Subject: [Koha-bugs] [Bug 31417] Re-instate the cataloguing sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31417 --- Comment #1 from Martin Renvoize --- Created attachment 139477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139477&action=edit Bug 31417: Update and reference cat-menu.inc This patch reinstates the cat-menu.inc include and references it from the various 'tools' that are closely tied to cataloging. We use the new cataloging home page submission as a reference for which options should appear in the menu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:21:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:21:08 +0000 Subject: [Koha-bugs] [Bug 31417] Re-instate the cataloguing sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31417 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:24:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:24:40 +0000 Subject: [Koha-bugs] [Bug 31416] Improve OPAC "Browse by hierarchy" and "Subject cloud" features In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31416 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org --- Comment #1 from Owen Leonard --- > NB. This enhancement suggestion/request is contrary to views described in > Bug 20417 - Remove OpacCloud (and OpacBrowser) system preference and feature These features have been long-neglected and without a commitment from someone to spend time and money on it the removal plan is much more likely to move forward. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:26:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:26:21 +0000 Subject: [Koha-bugs] [Bug 30941] Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:26:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:26:25 +0000 Subject: [Koha-bugs] [Bug 30941] Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136000|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 139478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139478&action=edit Bug 30941: (QA follow-up) Add exec flag to scripts Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:27:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:27:25 +0000 Subject: [Koha-bugs] [Bug 30231] Don't display (rejected) forms of series entry in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30231 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:27:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:27:57 +0000 Subject: [Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:40:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:40:22 +0000 Subject: [Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:40:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:40:26 +0000 Subject: [Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136535|0 |1 is obsolete| | Attachment #136536|0 |1 is obsolete| | Attachment #136537|0 |1 is obsolete| | --- Comment #57 from Kyle M Hall --- Created attachment 139479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139479&action=edit Bug 28327: Add unit tests Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:42:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:42:35 +0000 Subject: [Koha-bugs] [Bug 30880] Expand OPACResultsUnavailableGroupingBy to have a 'branch only' option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30880 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:43:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:43:56 +0000 Subject: [Koha-bugs] [Bug 30880] Expand OPACResultsUnavailableGroupingBy to have a 'branch only' option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30880 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:43:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:43:59 +0000 Subject: [Koha-bugs] [Bug 30880] Expand OPACResultsUnavailableGroupingBy to have a 'branch only' option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30880 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137324|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 139480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139480&action=edit Bug 30880: Add 'branchonly' to OPACResultsUnavailableGroupingBy This patch adds a third option 'branch only' to the OPACResultsUnavailableGroupBy system preference. This option will group unavailable items by branch in the OPAC search results and NOT show individual callnumbers or substatuses. Note: This assumes OPACXSLTResultsDisplay is set to default. To test: 1. Create a biblio record with 3 items with the following home branches: Item A: Branch A Item B: Branch A Item C: Branch B 2. Check out Item A to yourself 3. Edit Item B to have a lost status 4. Go to Administration -> global system preferences. Search for OPACResultsUnavailableGroupingBy. 5. By default, this preference will be set to 'branch'. 6. Open the OPAC in another tab, and search for your record. 7. Confirm the search results shows an Availability line with "Not available: Branch A: Checked out (1). Branch A: Lost (1)." i.e. showing both branch and substatus. 8. In your staff client tab, set OPACResultsUnavailableGroupingBy to 'substatus'. 9. Go back to your OPAC tab and search for your record. Confirm the search results shows an Availability line with "Not available: Checked out (1). Lost (1)." i.e. showing substatus only. 10. Apply patch, update database, restart services. 11. In your staff client tab, refresh the page. Confirm the options for OPACResultsUnavailableGroupingBy have now changed to: - branch and substatus - substatus only - branch only 12. Set OPACResultsUnavailableGroupingBy to 'branch only'. 13. Go back to your OPAC tab and search for your record. Confirm the search results shows an Availability line with "Not available: Branch A (2)." i.e. showing branch only. 14. Confirm the other two options still work as expected. Sponsored-by: Chartered Accountants Australia and New Zealand Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:44:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:44:02 +0000 Subject: [Koha-bugs] [Bug 30880] Expand OPACResultsUnavailableGroupingBy to have a 'branch only' option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30880 --- Comment #4 from Nick Clemens --- Created attachment 139481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139481&action=edit Bug 30880: (QA follow-up) Add exec flag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:45:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:45:08 +0000 Subject: [Koha-bugs] [Bug 30880] Expand OPACResultsUnavailableGroupingBy to have a 'branch only' option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30880 --- Comment #5 from Nick Clemens --- I almost think we should change 'branch' option in DB to 'branch_substatus' but also don't want to touch existing values, so leaving for RM -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:48:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:48:48 +0000 Subject: [Koha-bugs] [Bug 30231] Don't display (rejected) forms of series entry in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30231 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:48:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:48:51 +0000 Subject: [Koha-bugs] [Bug 30231] Don't display (rejected) forms of series entry in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30231 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136556|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 139482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139482&action=edit Bug 30231: (bug 5927 follow-up) See (rejected) forms of series entry visible in search result (OPAC and intra) When using zebra with IncludeSeeFromInSearches on, with traced series, the rejected forms (4XX) of series entries are visible in result lists, both in OPAC and intra interfaces. Test plan: ========= 1. Have a MARC 21 installation with zebra, and with IncludeSeeFromInSearches on. Have an authority records for series (130, or 100/110/111 with title) with rejected forms (4XX fields). So the auth record should contain at least: 130 _0 $a Series title 430 _0 $a Some other title under which the series in known Use (each) authority record in at least two biblio records (in appropriate fields, i.e. 800/810/811/830 or even deprecated 440, if it makes use of UNIF_TITLE). Don't forget to properly input also 490 (for 8XX). So the biblio record shold contain at least: 245 nn $a Work title. 490 1_ $a Series title 830 _0 $a Series entry $9 Reindex. 2. Perform a simple biblio search (in OPAC and in intra) with the title from auth record. 3. You shold get a list of results. See the Series information--you shold see not only the accepted entry from 1XX in auth but also the rejected forms from 4XX. 4. Apply the patch. 5. Repeat 3. You shold see only the entry form of series now. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:52:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:52:27 +0000 Subject: [Koha-bugs] [Bug 30941] Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139478|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 139483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139483&action=edit Bug 30941: Add cataloguing plugins for 146$bcdef (UNIMARC) Test plan: 1. Configure the default MARC framework to use those value builders: - unimarc_field_146b for 146$b - unimarc_field_146c for 146$c - unimarc_field_146d for 146$d - unimarc_field_146e for 146$e - unimarc_field_146f for 146$f 2. Verify that they all work correctly according to https://www.ifla.org/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u-b_146.pdf Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:52:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:52:36 +0000 Subject: [Koha-bugs] [Bug 30941] Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 --- Comment #6 from Kyle M Hall --- Created attachment 139484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139484&action=edit Bug 30941: (QA follow-up) Add exec flag to scripts Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:52:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:52:38 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #17 from Nick Clemens --- After applying my console has an error: Uncaught TypeError: t is undefined ... dayjs.min_22.0600035.js:1:6455 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:52:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:52:54 +0000 Subject: [Koha-bugs] [Bug 31282] Broken characters in patron_emailer.pl verbose mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31282 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:53:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:53:35 +0000 Subject: [Koha-bugs] [Bug 31395] Checking in non-existent barcodes makes Koha explode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31395 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:53:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:53:50 +0000 Subject: [Koha-bugs] [Bug 30504] Value builder for UNIMARC field 181 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30504 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:53:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:53:54 +0000 Subject: [Koha-bugs] [Bug 30504] Value builder for UNIMARC field 181 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30504 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:53:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:53:56 +0000 Subject: [Koha-bugs] [Bug 30506] Value builder for UNIMARC field 182 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:53:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:53:59 +0000 Subject: [Koha-bugs] [Bug 30506] Value builder for UNIMARC field 182 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:54:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:54:02 +0000 Subject: [Koha-bugs] [Bug 30507] Value builder for UNIMARC field 183 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30507 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:54:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:54:05 +0000 Subject: [Koha-bugs] [Bug 30507] Value builder for UNIMARC field 183 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30507 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:54:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:54:07 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:54:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:54:11 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #111 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:56:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:56:42 +0000 Subject: [Koha-bugs] [Bug 31395] Checking in non-existent barcodes makes Koha explode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31395 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 13:56:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 11:56:46 +0000 Subject: [Koha-bugs] [Bug 31395] Checking in non-existent barcodes makes Koha explode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31395 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139417|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 139485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139485&action=edit Bug 31395: Only try to cancel holds if item found This patch makes the code dealing with waiting holds with cancellation requests be dependent on the fact an item has been found. The returns.pl controller is a bit messy as the real return takes place outside the main `if ($item)` block. This should be refactored and probably run inside a transaction... In the meantime this patch will make the job. To test: 1. Try to return an invalid barcode (e.g. ASDQWE) => FAIL: Things explode 2. Apply this patch 3. Repeat 1 => SUCCESS: Doesn't explode! 4. Verify that returning an item with a waiting hold with cancellation requests still cancells the hold. => SUCCESS: It does! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 14:09:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 12:09:01 +0000 Subject: [Koha-bugs] [Bug 30952] New interface for staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #150 from Owen Leonard --- Thanks Michal. That's the one I prefer too. At first I was concerned about it being confusing for users accustomed to the static tabs (always in the same place no matter which form is selected) but now I think it might be useful to have the visual clue of the position of the form to help the user orient themselves. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 14:14:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 12:14:05 +0000 Subject: [Koha-bugs] [Bug 31282] Broken characters in patron_emailer.pl verbose mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31282 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 14:14:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 12:14:08 +0000 Subject: [Koha-bugs] [Bug 31282] Broken characters in patron_emailer.pl verbose mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31282 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139439|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 139486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139486&action=edit Bug 31282: Fix broken characters in patron_emailer.pl verbose mode To test: 1. Have a report containing: SELECT tomascohen at theke.io; 2. Have a members notice containing ¡ and other non-ASCII characters. 3. Run (changing the report number and notice code accordingly): $ kshell k$ perl misc/cronjobs/patron_emailer.pl --report 4 \ --notice BIRTHDAY --from tomascohen at theke.io --module members => FAIL: non-ASCII characters are broken 4. Apply this patch 5. Repeat 3 => SUCCESS: Things print correctly! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 14:23:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 12:23:11 +0000 Subject: [Koha-bugs] [Bug 29955] Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 14:23:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 12:23:15 +0000 Subject: [Koha-bugs] [Bug 29955] Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137797|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 139487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139487&action=edit Bug 29955: Move populate_order_with_prices to Koha namespace and split the subroutine into 2 smaller subroutines (one for ordering, the other for receiving) Test plan: 1. Create a vendor and an acquisition basket 2. In this basket, create new orders using all the different methods (from an existing record, from a suggestion, from a new record, ...) then close the basket and receive these orders. Make sure it works the same with and without the patch 3. Run tests in t/Prices.t, t/db_dependent/Acquisition/populate_order_with_prices.t, and t/db_dependent/Budgets.t Signed-off-by: Joonas Kylmälä Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 14:24:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 12:24:03 +0000 Subject: [Koha-bugs] [Bug 29955] Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 14:54:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 12:54:29 +0000 Subject: [Koha-bugs] [Bug 30941] Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 139488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139488&action=edit Bug 30941: (QA follow-up) Import methods explicitly By explicitly importing the Koha::I18N methods, I get rid of this error: kohadev-koha at kohadevbox:/kohadevbox/koha$ qa -c 2 --run-tests testing 2 commit(s) (applied to 9b2bf04 '09 Bug 30507: Value builder for field') Processing files before patches |========================>| 12 / 12 (100.00%) An error occurred : Inconsistent hierarchy during C3 merge of class 'Koha::I18N': current merge results [ Koha::I18N, ] merging failed on 'Exporter' at /kohadevbox/qa-test-tools/koha-qa.pl line 112. This happens because the Koha::I18N library is exporting all its methods explicitly and, by design, the __ methods used in value builders cannot determine which of the imported methods to use i.e. if Koha::I118N::__ or Koha::CodeList::Unimarc::MediumOfPerformance:__ Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 14:58:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 12:58:03 +0000 Subject: [Koha-bugs] [Bug 30941] Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 14:58:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 12:58:06 +0000 Subject: [Koha-bugs] [Bug 30941] Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 14:58:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 12:58:08 +0000 Subject: [Koha-bugs] [Bug 31282] Broken characters in patron_emailer.pl verbose mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31282 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 14:58:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 12:58:11 +0000 Subject: [Koha-bugs] [Bug 31282] Broken characters in patron_emailer.pl verbose mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31282 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 14:58:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 12:58:14 +0000 Subject: [Koha-bugs] [Bug 31395] Checking in non-existent barcodes makes Koha explode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31395 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 14:58:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 12:58:16 +0000 Subject: [Koha-bugs] [Bug 31395] Checking in non-existent barcodes makes Koha explode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31395 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 15:03:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 13:03:07 +0000 Subject: [Koha-bugs] [Bug 30218] Add subfield g to 150 heading_fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30218 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 15:10:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 13:10:30 +0000 Subject: [Koha-bugs] [Bug 30218] Add subfield g to 150 heading_fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30218 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 15:10:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 13:10:34 +0000 Subject: [Koha-bugs] [Bug 30218] Add subfield g to 150 heading_fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30218 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137795|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 139489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139489&action=edit Bug 30218: Add subfield g to field 150 in C4::Heading::MARC21 mappings When creating authorities via SRU or linking exising authorities (via cgi-bin/koha/authorities/auth_finder.pl) the search results are generated using the hardcoded mappings $bib_heading_fields / $auth_heading_field from C4::Heading::MARC21. For TOPIC_TERM / field 150 these mappings currently include the subfield `abvxyz68`. But: We are using the GND provided by Deutsche Nationalbibliothek. We imported some authorities from there, for example: http://d-nb.info/gnd/4114171-4 "Kind <0-3 Jahre>" (kid 0-3 years) http://d-nb.info/gnd/4196417-2 "Kind <0-4 Jahre>" (kid 0-4 years) When searching for these terms, Koha only displays "Kind", which is not very helpful, as there are a lot of different authorities for different age bands. GND stores "Kind" in 150a, and "0-3 Jahre" in 150g. But in the hardcoded mappings used by Koha, subfield g is not included. This patch adds subfield g to these mappings, thus making it possible to easily select the correct authority. Test plan: * Create an authority (or edit an existing one) and set 150g to "foo" * Create a new biblio (or edit an existing one), go to field 650 and click on the search-icon on the right. * A popup should open, where you can search for "Authority type: TOPIC_TERM", enter the name of the authority (150a!) in the search box * In the resulting list, you will only see the value of 150a. * Apply the patch * Search again, now you should see "foo" in the result list Sponsored-by: Steiermärkische Landesbibliothek Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 15:11:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 13:11:21 +0000 Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 15:12:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 13:12:44 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #112 from Tomás Cohen Arazi --- Created attachment 139490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139490&action=edit Bug 30718: Fix imports Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 15:14:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 13:14:09 +0000 Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870 Paul Derscheid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139469|0 |1 is obsolete| | --- Comment #24 from Paul Derscheid --- Created attachment 139491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139491&action=edit Bug 25870 - (follow-up) Raw MARC-XML records from Zebra now get appropriate treatment To test: 1) Apply the patch 2) Pick an endpoint tester of your choice, e.g. Insomnia or the ThunderClient if you use VSCode or derivatives. 3) Run a query while using Zebra. 4) Observe the marc-in-json response and check for validity. 5) Run a query while using Elasticsearch. 6) Again, observe the marc-in-json response and check for validity. 7) Not ready for sign-off but please leave a comment or help me on the Koha::Biblios->search thing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 15:39:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 13:39:35 +0000 Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|kyle at bywatersolutions.com |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 15:43:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 13:43:06 +0000 Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137856|0 |1 is obsolete| | Attachment #137857|0 |1 is obsolete| | Attachment #137858|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 139492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139492&action=edit Bug 31112: Remove unnecessary if-clause To test: 1) Please check manually that the logic stays the same, use git's -w command line parameter to ignore whitespace changes in the diff output. 2) prove t/db_dependent/Circulation.t Signed-off-by: Sally Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 15:43:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 13:43:09 +0000 Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #9 from Nick Clemens --- Created attachment 139493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139493&action=edit Bug 31112: CanBookBeRenewed: take into account patrons with more than 1 hold to a biblio If a single patron had more than 1 hold to a biblio and there was only one available item we allowed incorrectly renewing the checkout when AllowRenewalIfOtherItemsAvailable was set to "Allow". This changes CanBookBeRenewed so that it makes sure all the holds are filled and not just one per patron. To test: 1) prove t/db_dependent/Circulation.t 2) (Optional, as unit test is provided) - Set AllowRenewalIfOtherItemsAvailable = Allow - Create biblio with three items - Checkout one item to patron A - Add two biblio-level holds for patron B - Try to renew patron A's checkout with and without this patch. - Notice that without this patch the renewal succeeds even though we one unfilled hold left. After applying the patch the renewal should fail. Signed-off-by: Sally Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 15:43:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 13:43:13 +0000 Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #10 from Nick Clemens --- Created attachment 139494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139494&action=edit Bug 31112: (QA follow-up) Restore check to avoid extra processing We now count all holds for all patrons, we can still eject if we have more holds than we do items Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 15:43:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 13:43:16 +0000 Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #11 from Nick Clemens --- Created attachment 139495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139495&action=edit Bug 31112: (QA follow-up) Fetch patrons with reserves Previously we fetched all in a single call using biblionumbers Fetching each individually could be a performance hit on systems with large numbers of holds Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 15:45:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 13:45:00 +0000 Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #12 from Nick Clemens --- I reinstated the test for early exit - this is still a valid performance boost - we can't fill all holds if we don't have enough items Also added a prefetch to avoid single calls for each borrower Kyle is going to followup after me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 15:50:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 13:50:38 +0000 Subject: [Koha-bugs] [Bug 31105] Holds to pull counts items from other branches when independentbranches is active In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 15:58:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 13:58:00 +0000 Subject: [Koha-bugs] [Bug 31105] Holds to pull counts items from other branches when independentbranches is active In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 15:58:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 13:58:05 +0000 Subject: [Koha-bugs] [Bug 31105] Holds to pull counts items from other branches when independentbranches is active In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137859|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 139496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139496&action=edit Bug 31105: Holds to pull counts items from other branches when independentbranches is active Holds to pull should not show items from other branches that shares a record when IndependentBranches is active. Except for superlibrarians. Test plan: 1- Have IndependentBranches set to Yes 2- Have a record with an item from the current branch and another item from a different branch. We will call them branch A and branch B respectively 3- Have a patron from branch A place a hold on that record 4- Have a staff account on branch A and B with the following permissions: - circulate (all) - catalogue 5- Go to circulation > holds to pull 6- Notice under "Libraries" it displays branch A and B. Also, it shows 2 under "Items available" 7- Checkout the item from branch A to another patron 8- Go back to circulation > holds to pull 9- Notice under "Libraries" it displays branch B even though we are in branch A 10- Apply the patch 11- Return the checked out item from step 7 12- Redo step 5 to 9 with superlibrarian privileges and notice nothing changed 13- Redo step 11-12 but using accounts from step 4 and notice Holds to pull only shows information relevant to their branch Signed-off-by: Sally Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 16:09:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 14:09:50 +0000 Subject: [Koha-bugs] [Bug 30941] Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 139497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139497&action=edit Bug 30941: (QA follow-up) Only export what is needed Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 16:11:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 14:11:42 +0000 Subject: [Koha-bugs] [Bug 16640] Move actions on acquisitions receipt summary page into menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16640 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|ASSIGNED |RESOLVED --- Comment #8 from Owen Leonard --- I'm closing this, since any work I may do in the future will take a different approach. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 16:19:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 14:19:19 +0000 Subject: [Koha-bugs] [Bug 6698] Detail page for organisations should show only valid fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6698 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |FIXED --- Comment #12 from Owen Leonard --- This looks like it has since been fixed. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 16:19:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 14:19:41 +0000 Subject: [Koha-bugs] [Bug 22352] Items location not shown correctly in email sent lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22352 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |kyle at bywatersolutions.com Status|Signed Off |RESOLVED --- Comment #18 from Kyle M Hall --- *** This bug has been marked as a duplicate of bug 31320 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 16:19:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 14:19:41 +0000 Subject: [Koha-bugs] [Bug 31320] Remove GetItemsInfo from virtualshelves/sendshelf.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31320 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexandre.breton at ccsr.qc.ca --- Comment #5 from Kyle M Hall --- *** Bug 22352 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 16:20:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 14:20:11 +0000 Subject: [Koha-bugs] [Bug 22352] Items location not shown correctly in email sent lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22352 --- Comment #19 from Kyle M Hall --- Duplicates work pushed to master from bug 21230 and also bug 31316. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 16:30:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 14:30:39 +0000 Subject: [Koha-bugs] [Bug 28634] ILL partner request notices are attached to the request creator rather than the partner recipient In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28634 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 16:30:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 14:30:43 +0000 Subject: [Koha-bugs] [Bug 28634] ILL partner request notices are attached to the request creator rather than the partner recipient In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28634 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138867|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 139498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139498&action=edit Bug 28634: Fix notice borrowernumber This commit fixes the bug described in this bug. - When a partner is selected, pass their borrowernumber rather than email to the receiving script - Iterate all selected partners, send a notice to each, using the recipient's borrowernumber in the notice, the recipient's email is derived from their patron object TEST PLAN: 1. DO NOT apply the patch. 2. Follow the following setup: *** Setup start *** - Create a report using the following SQL in order to verify that notices are being generated: SELECT borrowernumber, subject, content, message_transport_type, to_address, from_address FROM message_queue WHERE letter_code LIKE 'ILL%' ORDER BY message_id DESC - Create two "partners". These are patrons that belong to a patron category that has a code that matches the value in your koha-conf.xml (default is ILLLIBS). Patrons in this category must have a primary email defined. Patrons defined in this way are offered as request partners within the ILL interface. - Go to "Koha administration", search for "ILLModule" syspref, ensure it is set to "Enable" - Go to "Koha administration", search for "IllLog" syspref, ensure it is set to "Log" BRANCH CONFIG - Go to "Koha administration" > "Libraries" - Choose a library and "Edit" it - Ensure the "Email" field for the library is populated SENDING REQUEST TO PARTNERS - Go to the "Manage ILL request" screen for a request, create a request if one does not exist - Choose "Place request with partners" - Select both partners that were defined earlier, then click "Send email" - Run the report created earlier => TEST: Observe that a notice was created and the borrowernumber is that of the request creator, not the recipient *** Setup end *** 3. Apply the patch a. Go to the "Manage ILL request" screen for a request, create a request if one does not exist b. Choose "Place request with partners" c. Select both partners that were defined earlier, then click "Send email" d. Run the report created earlier => TEST: Observe that once notice per partner is created, the borrowernumber column for each notice contains the borrower number of the recipient, not the request creator Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 16:39:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 14:39:28 +0000 Subject: [Koha-bugs] [Bug 31343] DataTables error on waitingreserves.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139053|0 |1 is obsolete| | --- Comment #9 from Tomás Cohen Arazi --- Created attachment 139499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139499&action=edit Bug 31343: (bug 31138 follow-up) Don't hide error Some errors are not passing settings and so the error is hidden Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 16:39:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 14:39:44 +0000 Subject: [Koha-bugs] [Bug 31343] DataTables error on waitingreserves.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139054|0 |1 is obsolete| | --- Comment #10 from Tomás Cohen Arazi --- Created attachment 139500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139500&action=edit Bug 31343: Prevent two nodes #holdscr on waiting reserves Two nodes with id="holdscr" existed on this patch. I guess the table was not initiated properly before 31138 neither. Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 16:40:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 14:40:30 +0000 Subject: [Koha-bugs] [Bug 31343] DataTables error on waitingreserves.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 16:44:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 14:44:39 +0000 Subject: [Koha-bugs] [Bug 31420] New: Managing funds: Labels of statistic fields overlap with pull downs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31420 Bug ID: 31420 Summary: Managing funds: Labels of statistic fields overlap with pull downs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org In the English templates some labels overlap with the input fields on the fund entry/edit form. These are: * Statistic 1 done on: * Statistic 2 done on: In general we see a lot of these issues in translated templates as well. Could we standardize on a wider area for labels or make it more flexible? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 16:44:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 14:44:54 +0000 Subject: [Koha-bugs] [Bug 31420] Managing funds: Labels of statistic fields overlap with pull downs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31420 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 17:02:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 15:02:47 +0000 Subject: [Koha-bugs] [Bug 31421] New: Library limitation on patron category breaks patron search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 Bug ID: 31421 Summary: Library limitation on patron category breaks patron search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To test: * Log in under library A (Fairfield) * Limit one patron category (Patrons PT) to library B (Centerville) * Search for all patrons (empty search) * No results and there is an error in the console: Uncaught TypeError: categories_map[data] is undefined -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 17:05:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 15:05:32 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 17:05:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 15:05:36 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137822|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 139501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139501&action=edit Bug 6419: Add custom HTML areas to intranet home pages This patch adds customisable HTML text areas to acqui/acqui-home.pl, authorities/authorities-home.pl, cataloguing/addbooks.pl, virtualshelves/shelves.pl, members/members-home.pl, pos/pay.pl and serials/serials-home.pl pages To test: 1) Apply patch 2) Run updatedatabase.pl 3) Add some html to the new prefs IntranetAcquisitionsHomeHTML, IntranetAuthoritiesHomeHTML, IntranetCatalogingHomeHTML, IntranetListsHomeHTML, IntranetPatronsHomeHTML, IntranetPOSHomeHTML and IntranetSerialsHomeHTML 4) View the Acquisition, Authorities, Cataloging, Lists, Patrons, Point of Sale, and Serials homepages and confirm that your changes show. Note that this should display in exactly the same way as it does in the already extant IntranetCirculationHomeHTML and IntranetReportsHomeHTML system preferences. Signed-off-by: Brandon J Signed-off-by: Daniel Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 17:11:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 15:11:27 +0000 Subject: [Koha-bugs] [Bug 31422] New: Library limitations might cause data loss Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Bug ID: 31422 Summary: Library limitations might cause data loss Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, michaela.sieber at kit.edu The library limitations are used to limit down the selection in pull downs in several spots. If you are editing data from library B while logged in at library A, doing so might result in data loss as the value stored in the modified object might be missing from the drop downs your user sees. Example 1: Item values Itemtype: BK Books - limited to Centerville AV LOC: FIC Fiction - limited to Centerville Your user: logged in for Centerville * Edit an item and make sure it uses the itemtype Books and location Fiction. * Switch library to any but Centerville. * Edit item: Both item type and location drow downs will be empty. * Saving now will empty out itemtype (if not set mandatory) and location resulting in data loss. Example 2: Patron data Patron category: Patron PT - limited to Centerville Your user: logged in for Centerville * Find a patron with the limited patron category * Edit patron: Verify the patron category shows in pull down * Switch library to any but Centerville * Edit patron: the category pull down will show the first entry of the pull down visible for this library. Saving now, you will change the patron category unknowingly resulting in data loss. Additional bug: If you search for "all patrons", you will have an error in the console no patrons will display: Uncaught TypeError: categories_map[data] is undefined. Filed as bug 31421. I think we need to make sure that the pull downs show what the library can use, but also what the current setting of the object is in order to prevent data loss. IIRC the funds pull down on the receive page uses a mechanism for this. Otherwise library limitations are very dangerous to use and can only be recommended if we can make sure that objects from other libraries cannot be edited at all where library limitations have been applied. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 17:11:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 15:11:27 +0000 Subject: [Koha-bugs] [Bug 31421] Library limitation on patron category breaks patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31422 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 17:18:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 15:18:55 +0000 Subject: [Koha-bugs] [Bug 30619] Add the option to email receipts as an alternative to printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 17:18:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 15:18:59 +0000 Subject: [Koha-bugs] [Bug 30619] Add the option to email receipts as an alternative to printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137131|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 139502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139502&action=edit Bug 30619: Add email receipt to POS This patch adds the ability to use email receipts with the point of sale module. To test: 1) Configure your Koha to enable the point of sale system. 2) Add an email template to the 'Point of sale > RECEIPT' notice. 3) Add some charges on point of sale and pay for them. 3a) You should now see a new 'Email receipt' button next to the 'Print receipt' option. 3b) Clicking the button will display a modal to enter the anonymous users email address 3c) Enter an email address and confirm to send the email Sponsored-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 17:19:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 15:19:10 +0000 Subject: [Koha-bugs] [Bug 30619] Add the option to email receipts as an alternative to printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137132|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 139503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139503&action=edit Bug 30619: Add sample email notice This patch adds a default same email type notice for the point of sale receipt. Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 17:21:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 15:21:16 +0000 Subject: [Koha-bugs] [Bug 30619] Add the option to email receipts as an alternative to printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619 --- Comment #10 from Kyle M Hall --- Created attachment 139504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139504&action=edit Bug 30619: (QA follow-up) Add exec flag to bug_30619.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 17:36:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 15:36:47 +0000 Subject: [Koha-bugs] [Bug 31315] Remove GetItemsInfo from moredetail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31315 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 17:52:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 15:52:12 +0000 Subject: [Koha-bugs] [Bug 30533] Add exact search option for patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30533 Agnes Rivers-Moore changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 17:56:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 15:56:28 +0000 Subject: [Koha-bugs] [Bug 30025] BiblioAddsAuthorities is poorly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 --- Comment #20 from Andrew Fuerste-Henry --- > > If I try to catalog something, the authority fields are not locked even > > though RequireChoosingExistingAuthority is set to "require". I am able to > > write whatever in the fields (I used 100$a) and save the record. > > I do not recreate, try restarting all after the update to make sure the > values are not cached? I wasn't able to recreate this, either. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 17:56:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 15:56:35 +0000 Subject: [Koha-bugs] [Bug 31423] New: Add a detail view for order lines Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31423 Bug ID: 31423 Summary: Add a detail view for order lines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: michaela.sieber at kit.edu In the past, it was possible to access the 'edit order line' page even if the basket was already closed by direct link. This loophole has been closed, because you shouldn't be allowed to edit your order lines in closed baskets. But now there is no longer a way to see all information or link directly to an order line. We can only link to the basket summary page, that is missing some information like the statistics fields and is also harder to read. We should add a detail view/read only version of the entry page. Existing examples for a detail view in Koha exist for suggestions and libraries (bug 30937). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 17:56:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 15:56:35 +0000 Subject: [Koha-bugs] [Bug 30937] Add a detail view for libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30937 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31423 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 17:56:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 15:56:52 +0000 Subject: [Koha-bugs] [Bug 30025] BiblioAddsAuthorities is poorly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 --- Comment #21 from Andrew Fuerste-Henry --- To test: 1 -Apply patches 2 - Update database 3 - Confirm old setting is transferred to new option 4 - Confirm you can ENTER VALUES IN AUTH-CONTROLLED BIB FIELDS manually if REQUIRECHOOSINGEXISTINGAUTHORITY is set to DON'T REQUIRE 5 - Confirm you cannot ENTER VALUES IN AUTH-CONTROLLED BIB FIELDS manually if REQUIRECHOOSINGEXISTINGAUTHORITY is set to REQUIRE 6 - Confirm a new bib is linked when AutoLinkBiblios is enabled (set REQUIRECHOOSINGEXISTINGAUTHORITY to add unlinked heading) 7 - Confirm new bib notlinked when AutoLinkBiblios is disabled 8 - Confim new bib not linked when AutoLinkBiblios is enabled, but heading doesn't match an authority and AutoCreateAuthorities is disabled 9 - Confim new bib linked to new authority when AutoLinkBiblios is enabled, but heading doesn't match an authority and AutoCreateAuthorities is enabled Updated test plan to reflect syspref names. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 17:58:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 15:58:08 +0000 Subject: [Koha-bugs] [Bug 30025] BiblioAddsAuthorities is poorly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 17:58:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 15:58:11 +0000 Subject: [Koha-bugs] [Bug 30025] BiblioAddsAuthorities is poorly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139176|0 |1 is obsolete| | --- Comment #22 from Andrew Fuerste-Henry --- Created attachment 139505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139505&action=edit Bug 30025: DB update Signed-off-by: AFHDubCoLib -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 17:58:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 15:58:15 +0000 Subject: [Koha-bugs] [Bug 30025] BiblioAddsAuthorities is poorly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139177|0 |1 is obsolete| | --- Comment #23 from Andrew Fuerste-Henry --- Created attachment 139506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139506&action=edit Bug 30025: Split BiblioAddsAuthorities into two sysprefs This patch adds two new sysprefs: AutoLinkBiblios AllowManualAuthorityEditing Both inherit the setting from BiblioAddsAuhtorities which is removed To test: 1 -Apply patches 2 - Update database 3 - Confirm old setting is transferred to new option 4 - Confirm you can edit authoriteis manually if AllowManualAuthorityEditing set to allow 5 - Confirm you cannot edit authorities manually if AllowManualAuthorityEditing set to don't allow 6 - Confirm a new bib is linked when AutoLinkBiblios is enabled (set AllowManualAuthorityEditing to add unlinked heading) 7 - Confirm new bib notlinked when AutoLinkBiblios is disabled 8 - Confim new bib not linked when AutoLinkBiblios is enabled, but heading doesn't match an authority and AutoCreateAuthorities is disabled 9 - Confim new bib linked to new authority when AutoLinkBiblios is enabled, but heading doesn't match an authority and AutoCreateAuthorities is enabled Signed-off-by: AFHDubCoLib -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 17:58:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 15:58:19 +0000 Subject: [Koha-bugs] [Bug 30025] BiblioAddsAuthorities is poorly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139399|0 |1 is obsolete| | --- Comment #24 from Andrew Fuerste-Henry --- Created attachment 139507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139507&action=edit Bug 30025: Replace AllowManualAuthorityEditing with RequireChoosingExistingAuthority This flips the pref from an allowance to a requirement, hopefully this makes the logic here clearer Test as before, but the values for the renamed pref flipped Signed-off-by: AFHDubCoLib -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 18:22:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 16:22:16 +0000 Subject: [Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 18:22:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 16:22:20 +0000 Subject: [Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 --- Comment #5 from Lucas Gass --- Created attachment 139508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139508&action=edit Bug 31374: Update Suggestion.pm To test: 1. Apply patch and restart services 2. Go to Acquistions -> Suggestions -> New Purchase suggestion 3. Notice the new 'Non-public notes:' textarea 4. Make sure you 'Set a patron' so we can later look at the suggestion from the OPAC 5. Make a new suggestion and make sure you add some Non-public notes 6. Back on the 'Suggestions management' page you should see a new column for 'Non-public note' 7. Go to table settings and make sure you can properly hide the column 8. Change the status and make sure it shows up on the table with all statuses (pending, accepted, rejected, etc ) 9. Check the API by going to (/api/v1/suggestions). Your suggestion should show up and 'privatenote' should include your non-public note. 10. Log in to the OPAC as the patron we set the suggestion to earlier. You should not see anything related to the non-public note displaying from the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 18:37:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 16:37:26 +0000 Subject: [Koha-bugs] [Bug 14964] Email notices will be queued for patrons with no email address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14964 Agnes Rivers-Moore changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 19:08:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 17:08:59 +0000 Subject: [Koha-bugs] [Bug 31424] New: Prompt to change patron messaging if email/SMS absent or changed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31424 Bug ID: 31424 Summary: Prompt to change patron messaging if email/SMS absent or changed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: arm at hanover.ca QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Suggesting a prompt to staff or patron to update the messaging preferences if a new member is registered with no email/SMS number and the messaging prefs default to 'on', or if an existing user account is edited and the SMS or email contact info is changed. The lack of this reminder leaves many accounts with failed/unsent messages or pending 'print' messages. Also when an email address is added, notices are not sent because staff/patron may not turn on messaging preferences. There are a couple of old bugs about SMS / failed email. This might help with those. Related: 14964 23497 14590 14872 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 19:12:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 17:12:07 +0000 Subject: [Koha-bugs] [Bug 31424] Prompt to change patron messaging if email/SMS absent or changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31424 Agnes Rivers-Moore changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 19:51:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 17:51:05 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #315 from Tomás Cohen Arazi --- Created attachment 139509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139509&action=edit Bug 23681: (QA follow-up) debarment_types => restriction_types The code moved from *debarments* to *restrictions* but the table didn't. This patch just renames things accordingly. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 19:55:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 17:55:57 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 19:56:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 17:56:00 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #4 from Lucas Gass --- Created attachment 139510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139510&action=edit Bug 31212: Add Database update -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 19:56:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 17:56:57 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |michalurban177 at gmail.com |ity.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 19:58:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 17:58:25 +0000 Subject: [Koha-bugs] [Bug 31425] New: Minor correction to patron categories admin title Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31425 Bug ID: 31425 Summary: Minor correction to patron categories admin title Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The logic in the template for showing the patron category administration page's title tag leaves an extra "&rsaquo" at the beginning if you're looking at the main view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 20:08:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 18:08:01 +0000 Subject: [Koha-bugs] [Bug 31425] Minor correction to patron categories admin title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31425 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 20:08:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 18:08:05 +0000 Subject: [Koha-bugs] [Bug 31425] Minor correction to patron categories admin title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31425 --- Comment #1 from Owen Leonard --- Created attachment 139511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139511&action=edit Bug 31425: Minor correction to patron categories admin title This patch corrects the patron categories administration template so that an extra angle bracket isn't included in the page title on the main view. To test, apply the patch and go to Administration -> Patron categories. The page title should read: Patron categories › Administration › Koha ...with no extra "›" at the beginning. Check that other views (new, edit, delete) are unaffected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 20:10:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 18:10:23 +0000 Subject: [Koha-bugs] [Bug 28903] Tab key and drop-down menu in item module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28903 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124170|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 20:10:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 18:10:34 +0000 Subject: [Koha-bugs] [Bug 28903] Tab key and drop-down menu in item module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28903 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 20:10:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 18:10:41 +0000 Subject: [Koha-bugs] [Bug 28903] Tab key and drop-down menu in item module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28903 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 20:10:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 18:10:59 +0000 Subject: [Koha-bugs] [Bug 28903] Tab key and drop-down menu in item module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28903 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124170|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 20:12:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 18:12:16 +0000 Subject: [Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 20:17:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 18:17:45 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #316 from Tomás Cohen Arazi --- Created attachment 139512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139512&action=edit Bug 23681: (QA follow-up) New schema files Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 20:35:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 18:35:09 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #317 from Tomás Cohen Arazi --- Ok, this is almost done. I added some required follow-ups. But the remaining things are too much for me to take care right now, so failing it and adding my (not so big) list: - The test files should be moved to Koha/RestrictionType*.t [MINOR] - The tests do not cover all the things. They are also mixed. The RestrictionType.t file tests Koha::RestrictionTypes->keyed_on_code - Koha::RestrictionTypes->keyed_on_code is not really required... and is very different than our normal return values... The fact we need to delete everything in order to test it points to some design issue (i.e. it is not a method that acts on $self as a resultset, but works in the whole table. - keyed_on_code should be replaced by something along the lines of: { map { $_->{code} => $_ } $self->as_list } - Koha::RestrictionType->make_default looks great :-D - Koha::RestrictionType->delete has problems. We *could* accept it using plain SQL, but the logic is wrong. If the type is a system one, and exception should be thrown. The same if it is the default ;-) (i.e. it is setting itself as default (again) and then deleting itself). As you can see, we are close to pushing this. Please hurry so no rebases are needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 20:38:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 18:38:53 +0000 Subject: [Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139479|0 |1 is obsolete| | --- Comment #58 from Kyle M Hall --- Created attachment 139513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139513&action=edit Bug 28327: Add unit tests Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 20:40:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 18:40:10 +0000 Subject: [Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139513|0 |1 is obsolete| | --- Comment #59 from Kyle M Hall --- Created attachment 139514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139514&action=edit Bug 28327: Add unit tests Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 20:40:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 18:40:28 +0000 Subject: [Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 --- Comment #60 from Kyle M Hall --- Created attachment 139515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139515&action=edit Bug 28327: Unify CSV delimiter special behavior for tabulation System preference 'CSVdelimiter' has a special case for tabulation. Preference value contains string 'tabulation' but string '\t' must be used in CSV file. This is OK in many places, for exemple Bug 17590. This patch adds C4::Context->csv_delimiter to add a uniq metod dealing with this behavior. Also create Koha::Template::Plugin::Koha->CSVDelimiter for calls from Toolkit Templates. Test plan : 1) Set system preference 'CSVdelimiter' = 'tabs'. 2) Create CSV export in impacted pages 3) Check columns are separated by tabulation character and not string 'tabulation' 4) Check with another delimiter Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 20:40:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 18:40:33 +0000 Subject: [Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 --- Comment #61 from Kyle M Hall --- Created attachment 139516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139516&action=edit Bug 28327: (follow-up) Comma as default CSV delimiter Looks like most of existing code wants comma as default value. Also impact installer/data/mysql/mandatory/sysprefs.sql. Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 20:42:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 18:42:34 +0000 Subject: [Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from Owen Leonard --- (In reply to Barbara Johnson from comment #7) > On basket.pl ... is also incorrectly including series data from the 490|a and > 490|v. basket.pl and invoice.pl have code to deliberately add the series information to the title variable: if ( $line{'title'} ) { my $volume = $order->{'volume'}; my $seriestitle = $order->{'seriestitle'}; $line{'title'} .= " / $seriestitle" if $seriestitle; $line{'title'} .= " / $volume" if $volume; } parcel.pl appears to be showing 245$b correctly for me in the "Already received" table, which is the only place this patch changes anything. The display of title information in the "Pending orders" table is not affected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 20:42:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 18:42:59 +0000 Subject: [Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126323|0 |1 is obsolete| | --- Comment #13 from Owen Leonard --- Created attachment 139517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139517&action=edit Bug 27817: Use biblio-title include in some acquisitions pages This patch adds the use of the biblio-title include in acquisitions templates which get the right data from their corresponding scripts. To test, apply the patch and test these Acquisitions pages to confirm that titles with 245$b, 245$h, etc, show all the correct information. - Acquisitions -> Vendor -> Basket - Acquisitions -> Vendor -> Uncertain prices - Acquisitions -> Invoices -> Invoice - Acquisitions -> Invoices -> Invoice -> View an invoice which has an already-received bibliographic record. - Go to receipt page -> Already received. -- The "Pending orders" table is unmodified because I wasn't sure how to use the biblio-title include in an AJAX DataTable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 20:47:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 18:47:16 +0000 Subject: [Koha-bugs] [Bug 30875] Move price columns calculation to Koha::Acquisition::Order->store In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30875 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|ASSIGNED |RESOLVED --- Comment #1 from Tomás Cohen Arazi --- *** This bug has been marked as a duplicate of bug 29955 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 20:47:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 18:47:16 +0000 Subject: [Koha-bugs] [Bug 29955] Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #6 from Tomás Cohen Arazi --- *** Bug 30875 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 20:51:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 18:51:49 +0000 Subject: [Koha-bugs] [Bug 29955] Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 139518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139518&action=edit Bug 29955: (QA follow-up) Tidy code block Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:01:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:01:14 +0000 Subject: [Koha-bugs] [Bug 31426] New: Calendar picker in reports sometimes chooses wrong month when back button used Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31426 Bug ID: 31426 Summary: Calendar picker in reports sometimes chooses wrong month when back button used Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: Create a report like: SELECT <> AND <> Run it and select dates a few months past Hit the back button Select a new date - calendar states previously selected month, but shows current month Was able to recreate in 21.11 with Chrome, reported on Edge After a few times it began working correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:04:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:04:46 +0000 Subject: [Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136414|0 |1 is obsolete| | Attachment #136415|0 |1 is obsolete| | --- Comment #30 from Blou --- Created attachment 139519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139519&action=edit Bug 17983: Add minutes loan to DiscreteCalendar This is an additional feature to our new Discrete Calendar. Theses patches add the possibility to choose the loan unit as minutes in circulations rules. Test plan: - Apply patch of Bugzilla 17015 - Apply this patch. - Run test t/db_dependent/minutes_loan.t - Create new item type for the new rule. - Create circulation rule and fill the fields, make sure the unit is set to : minutes, choose the item type of the one created above.- - Checkout an item that follow the circulation rule and set due date in the past. - Run fines.pl. - Check if the correct amount was calculated. - Note: make sure to factor in the fine grace period if set and the system preference FinesIncludeGracePeriod.fixed patch tests and minor adjustments -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:04:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:04:48 +0000 Subject: [Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:04:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:04:51 +0000 Subject: [Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 --- Comment #62 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:04:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:04:56 +0000 Subject: [Koha-bugs] [Bug 29955] Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:04:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:04:59 +0000 Subject: [Koha-bugs] [Bug 29955] Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:05:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:05:03 +0000 Subject: [Koha-bugs] [Bug 30218] Add subfield g to 150 heading_fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30218 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:05:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:05:06 +0000 Subject: [Koha-bugs] [Bug 30218] Add subfield g to 150 heading_fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30218 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:05:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:05:10 +0000 Subject: [Koha-bugs] [Bug 31343] DataTables error on waitingreserves.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:05:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:05:14 +0000 Subject: [Koha-bugs] [Bug 31343] DataTables error on waitingreserves.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:05:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:05:17 +0000 Subject: [Koha-bugs] [Bug 31385] Additional contents: Allow searching a CMS page by code in multilanguage env In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31385 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:05:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:05:21 +0000 Subject: [Koha-bugs] [Bug 31385] Additional contents: Allow searching a CMS page by code in multilanguage env In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31385 --- Comment #22 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:14:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:14:05 +0000 Subject: [Koha-bugs] [Bug 31017] Add type field for vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #33 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #31) > (In reply to Jonathan Druart from comment #30) > > Letting author and RM decide. This could be done separately (but before > > 21.11 ideally). > > Ha, apparently we are (already!) working for 22.11.. :D LOL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:17:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:17:25 +0000 Subject: [Koha-bugs] [Bug 31220] Error when attempting to export selected labels as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #11 from Lucas Gass --- Backported to 22.05.x for 22.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:19:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:19:05 +0000 Subject: [Koha-bugs] [Bug 30619] Add the option to email receipts as an alternative to printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds an release notes| |email receipt option to the | |Point of Sale module, along | |with a sample notice | |(RECEIPT). When completing | |a transaction, there is now | |an 'Email receipt' button | |next to 'Print receipt' | |button - the email address | |is entered in a pop-up | |window if the email receipt | |option is selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:27:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:27:56 +0000 Subject: [Koha-bugs] [Bug 31076] Bug 22605 breaks date of publication range search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31076 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:28:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:28:03 +0000 Subject: [Koha-bugs] [Bug 31076] Bug 22605 breaks date of publication range search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31076 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139437|0 |1 is obsolete| | --- Comment #6 from Fridolin Somers --- Created attachment 139520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139520&action=edit Bug 31076: Handle year limits with equal sign or colon To test: 1 - Enable ES and index 2 - Set expandedSearchOption to 'show' 3 - Advanced search on staff and opac using Year field on staff and Publication date range on OPAC for: 2005 2005- -2005 <2005 >2005 2005-2010 4 - Confirm ranges don't work on staff side, but do on opac 5 - Apply patch 6 - Repeat searches - they work on both staff and opac 7 - prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Signed-off-by: David Nind Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:29:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:29:15 +0000 Subject: [Koha-bugs] [Bug 31076] Bug 22605 breaks date of publication range search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31076 --- Comment #7 from Fridolin Somers --- Go Elastic-team go :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:31:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:31:36 +0000 Subject: [Koha-bugs] [Bug 31017] Add type field for vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:31:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:31:39 +0000 Subject: [Koha-bugs] [Bug 31017] Add type field for vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 --- Comment #34 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:31:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:31:43 +0000 Subject: [Koha-bugs] [Bug 31076] Bug 22605 breaks date of publication range search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31076 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:31:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:31:46 +0000 Subject: [Koha-bugs] [Bug 31076] Bug 22605 breaks date of publication range search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31076 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:34:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:34:05 +0000 Subject: [Koha-bugs] [Bug 31425] Minor correction to patron categories admin title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31425 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:34:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:34:08 +0000 Subject: [Koha-bugs] [Bug 31425] Minor correction to patron categories admin title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31425 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139511|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 139521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139521&action=edit Bug 31425: Minor correction to patron categories admin title This patch corrects the patron categories administration template so that an extra angle bracket isn't included in the page title on the main view. To test, apply the patch and go to Administration -> Patron categories. The page title should read: Patron categories › Administration › Koha ...with no extra "›" at the beginning. Check that other views (new, edit, delete) are unaffected. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:34:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:34:41 +0000 Subject: [Koha-bugs] [Bug 30952] New interface for staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #151 from Fridolin Somers --- (In reply to Michal Denar from comment #149) > I like "Horizontal search header form with forms inline with each button" > alternative. Good work. Same for me. This change is quite complex, we may want to separate it on another bug report so that this one may go faster. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:37:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:37:39 +0000 Subject: [Koha-bugs] [Bug 30952] New interface for staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #152 from Katrin Fischer --- (In reply to Fridolin Somers from comment #151) > (In reply to Michal Denar from comment #149) > > I like "Horizontal search header form with forms inline with each button" > > alternative. Good work. > > Same for me. > > This change is quite complex, we may want to separate it on another bug > report so that this one may go faster. Not sure if this is ready to be pushed with our without the changes to search bar, but not sure if we should rush things. The search bar is probably the most important bit to get right. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:40:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:40:08 +0000 Subject: [Koha-bugs] [Bug 30952] New interface for staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #153 from Katrin Fischer --- I like the second option better too. Would love to see a mock-up that includes IntranetAddMastheadLibraryPulldown and IntranetCatalogSearchPulldown. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:46:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:46:13 +0000 Subject: [Koha-bugs] [Bug 31076] Bug 22605 breaks date of publication range search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31076 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes publication |This fixes the date of release notes|range searching in the |publication range searching |staff interface when using |in the staff interface when |Elasticsearch. Range search |using Elasticsearch. It was |was working in the OPAC, |working in the OPAC, but |but not the staff interface |not the staff interface - |- caused by a regression |caused by a regression from |from Bug 22605 introduced |Bug 22605 introduced in |in Koha 22.05. For example: |Koha 22.05. For example: a |a year search for 2005-2010 |search for 2005-2010 in the |in the staff interface |staff interface advanced |advanced search will now |search will now display the |display the same number of |same results as the OPAC. |results as the OPAC. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:54:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:54:08 +0000 Subject: [Koha-bugs] [Bug 27172] Allow to configure fields not to be copied when using "Edit as new (duplicate)" in authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27172 Heather changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:54:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:54:18 +0000 Subject: [Koha-bugs] [Bug 31427] New: Automatic renewal too_many error is confusing in notices Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427 Bug ID: 31427 Summary: Automatic renewal too_many error is confusing in notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org I am not sure if this error, too_many, should be removed or just handled differently. It is confusing for patrons, here is why: Day 1, a patron gets an email telling them an item has been successfully renewed. It is auto renewal 5/5, the item will no longer renew. Day 2: The next a patron receives a new auto renewal message telling them the same item, from yesterday, cannot be renewed. Patrons are confused. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:58:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:58:36 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #109 from Fridolin Somers --- (In reply to Henri-Damien LAURENT from comment #108) > Created attachment 131573 [details] [review] > Bug 15261: Trying to fix after rebase > > https://bugs.koha-community.org/show_bug.cgi?id=1526 Careful you added warns (for debug I bet) : if ( C4::Context->preference("PreventCheckoutOnSameReservePeriod") ) { + warn $date_due; + warn "Inside"; unless ($date_due) { -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:59:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:59:29 +0000 Subject: [Koha-bugs] [Bug 31428] New: Shorten new button text "Configure this table" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31428 Bug ID: 31428 Summary: Shorten new button text "Configure this table" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Depends on: 29723 The new button on datatables reads "Configure this table". This will be quite long, especially in translation (to German). I'd like to at least remove the 'this': Configure table But as all buttons are about the table, maybe just "Configure" would be enough? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 [Bug 29723] Add a "Configure table" button for KohaTable tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 21:59:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 19:59:29 +0000 Subject: [Koha-bugs] [Bug 29723] Add a "Configure table" button for KohaTable tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31428 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31428 [Bug 31428] Shorten new button text "Configure this table" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 22:05:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 20:05:15 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #110 from Fridolin Somers --- Ouch, koha-tmpl/intranet-tmpl/prog/en/modules/reserve/placerequest.tt is using obsolete YUI :
    -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 22:06:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 20:06:58 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #111 from Fridolin Somers --- (In reply to Henri-Damien LAURENT from comment #108) > Created attachment 131573 [details] [review] > Bug 15261: Trying to fix after rebase > > https://bugs.koha-community.org/show_bug.cgi?id=1526 Also missing in opac/opac-reserve.pl : if ( $canreserve && C4::Context->preference("PreventReservesOnSamePeriod") ) { - if ( ReservesOnSamePeriod($biblioNum, $itemNum, $startdate, $expiration_date) ) { + if ( C4::Reserves::ReservesOnSamePeriod($biblioNum, $itemNum, $startdate, $expiration_date) ) { $canreserve = 0; $failed_holds++; } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 22:23:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 20:23:16 +0000 Subject: [Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #16 from Victor Grousset/tuxayo --- Missing dependencies for 21.05.x, it shouldn't be affected, no backport. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 22:26:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 20:26:14 +0000 Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #29 from Victor Grousset/tuxayo --- Missing dependencies for 21.05.x, it shouldn't be affected, no backport. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 22:31:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 20:31:39 +0000 Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #13 from Joonas Kylmälä --- Thanks for the review Nick! :) (In reply to Nick Clemens from comment #12) > I reinstated the test for early exit - this is still a valid performance > boost - we can't fill all holds if we don't have enough items OK, works for me. I didn't know it was for performance reasons and seems to make the logic not work correctly. I could open another bug report to fix this as I feel like we need some better way to make it more performant while still keeping the check correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 22:35:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 20:35:15 +0000 Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff accepts non-integer values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #30 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 22:40:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 20:40:13 +0000 Subject: [Koha-bugs] [Bug 30903] CSV import of quotes broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|22.11.00, 22.05.04 |22.11.00, 22.05.04, released in| |21.11.11 CC| |victor at tuxayo.net --- Comment #31 from Victor Grousset/tuxayo --- note: was backported to 21.11.x for 21.11.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 22:40:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 20:40:59 +0000 Subject: [Koha-bugs] [Bug 30903] CSV import of quotes broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #32 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 22:40:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 20:40:59 +0000 Subject: [Koha-bugs] [Bug 31012] Quote import tool should send the user back to quotes pages after importing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31012 Bug 31012 depends on bug 30903, which changed state. Bug 30903 Summary: CSV import of quotes broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 22:41:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 20:41:00 +0000 Subject: [Koha-bugs] [Bug 31014] Minor UI problems in QOTD editor tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31014 Bug 31014 depends on bug 30903, which changed state. Bug 30903 Summary: CSV import of quotes broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 22:41:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 20:41:00 +0000 Subject: [Koha-bugs] [Bug 31063] [OMNIBUS] QOTD tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31063 Bug 31063 depends on bug 30903, which changed state. Bug 30903 Summary: CSV import of quotes broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 22:41:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 20:41:29 +0000 Subject: [Koha-bugs] [Bug 30976] Cover images for biblio should be displayed first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30976 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 22:42:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 20:42:57 +0000 Subject: [Koha-bugs] [Bug 31001] "CGI::param called in list context" warning in basket.pl flooding error log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31001 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 22:42:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 20:42:58 +0000 Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Bug 25790 depends on bug 31001, which changed state. Bug 31001 Summary: "CGI::param called in list context" warning in basket.pl flooding error log https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31001 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 22:44:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 20:44:49 +0000 Subject: [Koha-bugs] [Bug 31067] Sub-tools permission not applying on intranet-main.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31067 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #7 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 22:53:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 20:53:27 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #23 from David Nind --- (In reply to Martin Renvoize from comment #22) > So.. where do we go from here.. > > * Should I remove the corresponding lines from the tools home page or do we > think they should appear in both places. I've always found it slightly confusing with having things split up for various modules - from an information architecture perspective, grouping related things together seems to be the way to go where this is possible and logical. For example, all the cataloguing things should be together, rather than split across cataloging, tools, administration. The same could apply to the other main modules such as circulation and patrons. This would probably require wider input from the Koha Community before all were changed though. I think we should have them in just one place - Cataloguing. > * Should we update the various pages now added to the 'cataloging' homepage > such that their breadcrumbs now read `Home > Cataloging > Page` as apposed > to `Home > Tools > Page` and similar To me, it makes more sense for the breadcrumbs `Home > Cataloging > Page`, and have things in just one place. > * I'm working on bug 31417 to reinstate the cat-menu sidebar... same > question as above about links appearing in both menus or just the > new/reinstated cat-menu.inc As above, just in one place (Cataloguing). Some other feedback: - Z3950 search: it seems like there are some challenges to add this to the sidebar menu, but that is the only thing when testing that doesn't appear (I enabled the advanced editor and stock rotation and they appeared - Four columns or three? I think I would prefer three columns (similar to Circulation), with 'Automations' appearing under the third column. At present I think it looks a bit too crowded with everything crunched up, with three columns there would be more space around and between the headings for all the different options. - Automations section: I think this heading should be singular, that is 'Automation'. I tried to think of some alternative wording, but the only thing I could come up with was 'Automatic rules' or 'Automatic processes'. The intention here (I think) is for things that can be set up and that will run automatically. I think this is a great improvement! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 22:54:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 20:54:45 +0000 Subject: [Koha-bugs] [Bug 31417] Re-instate the cataloguing sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31417 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 22:54:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 20:54:49 +0000 Subject: [Koha-bugs] [Bug 31417] Re-instate the cataloguing sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31417 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139477|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 139522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139522&action=edit Bug 31417: Update and reference cat-menu.inc This patch reinstates the cat-menu.inc include and references it from the various 'tools' that are closely tied to cataloging. We use the new cataloging home page submission as a reference for which options should appear in the menu. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 22:56:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 20:56:35 +0000 Subject: [Koha-bugs] [Bug 31417] Re-instate the cataloguing sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31417 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- I've signed off as is, but happy to do again once any changes (if required) from decisions for bug 31162 are incorporated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 22:58:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 20:58:21 +0000 Subject: [Koha-bugs] [Bug 31321] Remove GetItemsInfo from catalogue/detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31321 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 22:58:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 20:58:25 +0000 Subject: [Koha-bugs] [Bug 31321] Remove GetItemsInfo from catalogue/detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31321 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138913|0 |1 is obsolete| | Attachment #139115|0 |1 is obsolete| | Attachment #139116|0 |1 is obsolete| | --- Comment #7 from Joonas Kylmälä --- Created attachment 139523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139523&action=edit Bug 31321: Remove GetItemsInfo from catalogue/detail.pl Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered. Here we are going to deal with catalogue/detail Test plan: List items on the modified view and confirm that all the info is displayed correctly Signed-off-by: Owen Leonard JK: Amend follow-up fixes from Joubu to this patch Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 23:03:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 21:03:23 +0000 Subject: [Koha-bugs] [Bug 31425] Minor correction to patron categories admin title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31425 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 23:03:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 21:03:28 +0000 Subject: [Koha-bugs] [Bug 31425] Minor correction to patron categories admin title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31425 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139521|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 139524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139524&action=edit Bug 31425: Minor correction to patron categories admin title This patch corrects the patron categories administration template so that an extra angle bracket isn't included in the page title on the main view. To test, apply the patch and go to Administration -> Patron categories. The page title should read: Patron categories › Administration › Koha ...with no extra "›" at the beginning. Check that other views (new, edit, delete) are unaffected. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 19 23:04:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 21:04:22 +0000 Subject: [Koha-bugs] [Bug 30903] CSV import of quotes broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This fixes the import of release notes| |quotes from a CSV file for | |the Quote of the Day | |feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 00:30:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 22:30:04 +0000 Subject: [Koha-bugs] [Bug 31122] Terminology: Replace & with and for Notices & slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31122 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net --- Comment #7 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 00:45:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 22:45:47 +0000 Subject: [Koha-bugs] [Bug 29050] Add punctuation in Unseen Renewals message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net --- Comment #9 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 00:46:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 22:46:35 +0000 Subject: [Koha-bugs] [Bug 31038] Amounts in cashup summary modal no longer properly formatted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31038 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #9 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 00:46:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 22:46:36 +0000 Subject: [Koha-bugs] [Bug 31039] Rebase issues lead to duplicate JS for cash summary modal printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Bug 31039 depends on bug 31038, which changed state. Bug 31038 Summary: Amounts in cashup summary modal no longer properly formatted https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31038 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 00:47:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 22:47:26 +0000 Subject: [Koha-bugs] [Bug 30773] Standardize spelling i-tive / Itiva In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30773 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |Needs documenting --- Comment #12 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 00:47:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 22:47:55 +0000 Subject: [Koha-bugs] [Bug 30764] Terminology: Cancelled reserve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30764 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |victor at tuxayo.net --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 00:49:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 22:49:01 +0000 Subject: [Koha-bugs] [Bug 30770] Terminology: Lost reserve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |Needs documenting --- Comment #9 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 00:53:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 22:53:42 +0000 Subject: [Koha-bugs] [Bug 30763] Typo: Barcode proceeds bibliographic data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30763 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #9 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 00:54:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 22:54:26 +0000 Subject: [Koha-bugs] [Bug 30766] Typo: Cannot cancel receipt. Possible reasons : In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30766 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 00:55:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 22:55:36 +0000 Subject: [Koha-bugs] [Bug 30767] Terminology: Do not forget that the issue has not been checked in yet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30767 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |Needs documenting --- Comment #9 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 00:57:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 22:57:28 +0000 Subject: [Koha-bugs] [Bug 27996] Format of "Due date" on Circulation > Overdues page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27996 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #9 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 00:57:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 22:57:29 +0000 Subject: [Koha-bugs] [Bug 31167] Only mark due dates in the past red on overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31167 Bug 31167 depends on bug 27996, which changed state. Bug 27996 Summary: Format of "Due date" on Circulation > Overdues page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27996 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 01:12:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 23:12:54 +0000 Subject: [Koha-bugs] [Bug 31117] Cloning standard circulation rules for all libraries show up as from '*' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31117 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net --- Comment #9 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 01:14:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 23:14:45 +0000 Subject: [Koha-bugs] [Bug 29951] Cannot add splitting rule to classification sources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29951 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #10 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 01:16:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 23:16:46 +0000 Subject: [Koha-bugs] [Bug 30911] Datatables error on course-details.pl after adding a bib-level course reserve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #10 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 01:22:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 23:22:07 +0000 Subject: [Koha-bugs] [Bug 31071] Regression: date due removed from staff search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #14 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 01:47:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 23:47:56 +0000 Subject: [Koha-bugs] [Bug 31348] Plack stop should be graceful In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31348 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 01:48:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Aug 2022 23:48:00 +0000 Subject: [Koha-bugs] [Bug 31348] Plack stop should be graceful In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31348 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139036|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 139525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139525&action=edit Bug 31348: Make koha-plack stop gracefully 0. Apply patch 1. cp /usr/sbin/koha-plack /usr/sbin/koha-plack.bak 2. cp debian/scripts/koha-plack /usr/sbin/koha-plack 3. Now at roughly the same time do the following two actions: 3a. Go to http://localhost:8081/cgi-bin/koha/about.pl 3b. koha-plack --stop kohadev 4. Note that the HTTP request completes 5. Click on "Home" 6. Note that the error is "Service Unavailable" rather than "Proxy Error", which would've occurred with an interrupted HTTP request/response Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 02:00:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 00:00:08 +0000 Subject: [Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 02:00:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 00:00:13 +0000 Subject: [Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139212|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 139526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139526&action=edit Bug 31374: Database/Schema update Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 02:00:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 00:00:18 +0000 Subject: [Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139213|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 139527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139527&action=edit Bug 31374: Add non-public note to template Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 02:00:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 00:00:23 +0000 Subject: [Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139214|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 139528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139528&action=edit Bug 31374: Add privatenote column to table settings Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 02:00:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 00:00:28 +0000 Subject: [Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139216|0 |1 is obsolete| | --- Comment #9 from David Nind --- Created attachment 139529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139529&action=edit Bug 31374: Update API spec Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 02:00:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 00:00:33 +0000 Subject: [Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139508|0 |1 is obsolete| | --- Comment #10 from David Nind --- Created attachment 139530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139530&action=edit Bug 31374: Update Suggestion.pm To test: 1. Apply patch and restart services 2. Go to Acquistions -> Suggestions -> New Purchase suggestion 3. Notice the new 'Non-public notes:' textarea 4. Make sure you 'Set a patron' so we can later look at the suggestion from the OPAC 5. Make a new suggestion and make sure you add some Non-public notes 6. Back on the 'Suggestions management' page you should see a new column for 'Non-public note' 7. Go to table settings and make sure you can properly hide the column 8. Change the status and make sure it shows up on the table with all statuses (pending, accepted, rejected, etc ) 9. Check the API by going to (/api/v1/suggestions). Your suggestion should show up and 'privatenote' should include your non-public note. 10. Log in to the OPAC as the patron we set the suggestion to earlier. You should not see anything related to the non-public note displaying from the OPAC Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 02:08:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 00:08:19 +0000 Subject: [Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This enhancement adds a release notes| |non-public notes field to | |the suggestions tables in | |the staff interface. It is | |displayed by default in the | |suggestion management | |tables, and is configurable | |using the table settings. --- Comment #11 from David Nind --- Testing notes (using koha-testing-docker): - For step 1 in the test plan, run the updatedatabase command as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 03:50:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 01:50:58 +0000 Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669 --- Comment #51 from Victor Grousset/tuxayo --- Created attachment 139531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139531&action=edit Bug 25669: [21.11.x] Use include_type_name parameter in ES calls This patch includes the parameter: include_type_name on our ES calls It removes the deprecation warning we are seeing, and should allow using ES7 with no other chnages. For ES8 we will need to remove the hardcoded type, I would suggest a second patch, with a new syspref "ElasticsearchLegacyType" set to 'True' by default. Description can explain that this must be set to false, and data reindexed after upgrading to ES7 and before upgrading to ES8 - then we can drop this pref when we drop ES7 support When we drop ES6 support the pref can be set default true for upgrades, default 'false' for new installs Signed-off-by: Julian Maurice Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 150a4b03f337f6a58869c67d3681caa64441d53a) Signed-off-by: Lucas Gass (cherry picked from commit 99757c2d975d224ea191622116e6eb839fff70c1) Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 03:51:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 01:51:07 +0000 Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669 --- Comment #52 from Victor Grousset/tuxayo --- Created attachment 139532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139532&action=edit Bug 25669: [21.11.x] (follow-up) Minor fixes Bulk doesn't support include_type_name, update requirement to Search::Elasticseach at 6.80, and remove data type name from tests. Signed-off-by: Julian Maurice Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi (cherry picked from commit e926de5e8f359acf6b8beff541fe13ce2a5ac49e) Signed-off-by: Lucas Gass (cherry picked from commit 22c9ea9737d614a26b06092cda9708e27013e494) Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 03:55:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 01:55:19 +0000 Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669 --- Comment #53 from Victor Grousset/tuxayo --- (In reply to Arthur Suzuki from comment #50) > doesn't apply cleanly on 21.11.x. please provide backport if needed. Here it is, so we can be sure to have it for next release. (Which should therefore finally support ES 7!) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 09:37:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 07:37:32 +0000 Subject: [Koha-bugs] [Bug 31390] Remove noisy warns in C4::Templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31390 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 09:37:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 07:37:36 +0000 Subject: [Koha-bugs] [Bug 31390] Remove noisy warns in C4::Templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31390 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139397|0 |1 is obsolete| | --- Comment #3 from Fridolin Somers --- Created attachment 139533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139533&action=edit Bug 31390: Remove noisy warns in C4::Templates This patch removes two noisy warnings from C4::Templates 0) Apply patch and koha-plack --restart kohadev 1) Go to http://localhost:8081/ 2) Note no warnings in /var/log/koha/kohadev/plack-intranet-error.log 3) Go to http://localhost:8080/ 3) Note no warnings in /var/log/koha/kohadev/plack-opac-error.log Signed-off-by: Kyle M Hall Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 09:43:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 07:43:29 +0000 Subject: [Koha-bugs] [Bug 31387] Marking othernames as required via PatronSelfRegistrationBorrowerMandatoryField does not display required label In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31387 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 09:43:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 07:43:33 +0000 Subject: [Koha-bugs] [Bug 31387] Marking othernames as required via PatronSelfRegistrationBorrowerMandatoryField does not display required label In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31387 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139306|0 |1 is obsolete| | --- Comment #3 from Fridolin Somers --- Created attachment 139534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139534&action=edit Bug 31387: Fix othernames required label 1. Mark othernames as required via PatronSelfRegistrationBorrowerMandatoryField 2. Go to the self-reg form, the field is required but the span that makes it look required stays hidden. (
    Required
    ) 3. Mark initials as required via PatronSelfRegistrationBorrowerMandatoryField. 4. Now the label_required field appears for othernames in the self ref form 5. Apply patch 6. Try again, the label should now properly show when othernames is marked as required Signed-off-by: David Nind Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 09:53:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 07:53:40 +0000 Subject: [Koha-bugs] [Bug 31351] Worker dies on reindex job when operator last name/first name/branch name contains non-ASCII chars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #3 from Fridolin Somers --- Hi, my $context = decode_json encode_utf8 $self->context; I think we prefer the syntax with parenthesis : my $context = decode_json(encode_utf8($self->context)); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 10:32:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 08:32:33 +0000 Subject: [Koha-bugs] [Bug 30911] Datatables error on course-details.pl after adding a bib-level course reserve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911 --- Comment #11 from Katrin Fischer --- (In reply to Victor Grousset/tuxayo from comment #10) > Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. > > Nothing to document, marking resolved. Dependency is not in 21.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 10:40:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 08:40:54 +0000 Subject: [Koha-bugs] [Bug 31379] Change results per page text for default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31379 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 10:40:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 08:40:58 +0000 Subject: [Koha-bugs] [Bug 31379] Change results per page text for default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31379 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139276|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 139535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139535&action=edit Bug 31379: Change results per page text for default Since Bug 14715, one can change number of results per page. The actual text in combobox for default value is : "Library default: 20" This text is hard to translate correctly. For example french translation use "site par défaut" wrongly meaning "default library". I propose to simply use "20 (defaut)". Test plan : 1) Go to system preferences and set both 'numSearchResultsDropdown' and 'OPACnumSearchResultsDropdown' to 'Show' 2) Do a catalogue search in the intranet using a search term that will bring lots of results 3) Look at restults per page combobox 4) Same for OPAC Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 10:43:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 08:43:24 +0000 Subject: [Koha-bugs] [Bug 31352] Terminology: Borrower name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31352 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 10:43:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 08:43:28 +0000 Subject: [Koha-bugs] [Bug 31352] Terminology: Borrower name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31352 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139307|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 139536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139536&action=edit Bug 31352: Change 'Borrower name' to 'Patron name' Test plan: 1. Go to Tools > Patron card creator > New > Card batch 2. Enter a borrowernumber and click 'Add patron(s)' 3. Observe a table with the leftmost column name 'Borrower name' loads 4. Apply patch 5. Refresh page 6. Observe the leftmost column name is 'Patron name' Sponsored-by: Catalyst IT, New Zealand Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 10:43:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 08:43:35 +0000 Subject: [Koha-bugs] [Bug 31352] Terminology: Borrower name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31352 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 11:01:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 09:01:55 +0000 Subject: [Koha-bugs] [Bug 31429] New: Select2 don't get focus anymore when selected Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31429 Bug ID: 31429 Summary: Select2 don't get focus anymore when selected Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: regression Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org In 20.11 when you activate a Select2 pull down by tab+enter or clicking on it, the cursor is in the input field and you can type to select one of the entries. In master, I need to extra click in the search field. Tab+enter don't get you into the search form, I haven't found a way to do it with just keys yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 11:02:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 09:02:08 +0000 Subject: [Koha-bugs] [Bug 31429] Select2 don't get focus anymore when selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31429 --- Comment #1 from Katrin Fischer --- Tested on the edit item form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 11:03:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 09:03:13 +0000 Subject: [Koha-bugs] [Bug 31388] Add select2 to fund selection in new order form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31388 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 11:03:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 09:03:17 +0000 Subject: [Koha-bugs] [Bug 31388] Add select2 to fund selection in new order form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31388 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139383|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 139537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139537&action=edit Bug 31388: Add select2 to fund selection in new order form In new order form, when you have a lot of funds, would be useful to have autocompletion in funds combobox. Test plan : 1) Create an activ and an inactiv budget with at least one fund 2) Create a new order 'From a new (empty) record' 3) Check you see autocompletion in 'Fund' combobox 4) Click on 'Show inactive' 5) Check you see inactiv funds in combobox Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 11:07:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 09:07:37 +0000 Subject: [Koha-bugs] [Bug 31377] Add internal note column to tables on vendor search result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31377 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add internal note column to |Add internal note column to |tables on booksellers.pl |tables on vendor search | |result list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 11:07:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 09:07:42 +0000 Subject: [Koha-bugs] [Bug 31377] Add internal note column to tables on vendor search result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31377 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 11:17:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 09:17:27 +0000 Subject: [Koha-bugs] [Bug 31430] New: Add column configuration to tables in vendor search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31430 Bug ID: 31430 Summary: Add column configuration to tables in vendor search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org It would be nice if we could select which columns to display in the tables shown in vendor search. It might also be nice to have the option to filter and export, but as they would take up some space, it might be discussable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 11:18:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 09:18:31 +0000 Subject: [Koha-bugs] [Bug 31377] Add basket's internal note to tables on vendor search result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31377 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add internal note column to |Add basket's internal note |tables on vendor search |to tables on vendor search |result list |result list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 11:20:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 09:20:47 +0000 Subject: [Koha-bugs] [Bug 31377] Add basket's internal note to tables on vendor search result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31377 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 11:20:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 09:20:51 +0000 Subject: [Koha-bugs] [Bug 31377] Add basket's internal note to tables on vendor search result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31377 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139415|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 139538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139538&action=edit Bug 31377: Add internal note column to booksellers.tt To test: -Apply patch -Add some vendors and give them an internal note -Go to /cgi-bin/koha/acqui/booksellers.pl -Notice that there is a column which includes the internal note Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 11:21:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 09:21:40 +0000 Subject: [Koha-bugs] [Bug 31430] Add column configuration to tables in vendor search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31430 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31377 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 11:21:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 09:21:40 +0000 Subject: [Koha-bugs] [Bug 31377] Add basket's internal note to tables on vendor search result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31377 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31430 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 11:41:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 09:41:10 +0000 Subject: [Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | Status|Signed Off |Failed QA --- Comment #12 from Katrin Fischer --- Hi Lucas, could we discuss renaming the database column? It's now: privatenote We don't use private as a term in any of the other tables or the GUI so I am hesitating to use completely new terminology here. What about: staff_note? If I see correctly we already have some of those in kohastructure.sql git grep note *.sql The second thing is me wondering if we should keep the status as the last column of the table, moving the new column forward by one. ... happy to hear your thoughts about that one! Otherwise this works really well! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 11:42:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 09:42:32 +0000 Subject: [Koha-bugs] [Bug 31355] Specific item holds table on OPAC only showing 10 items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31355 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | --- Comment #3 from Katrin Fischer --- Please don't forget to assign the bugs as you work on them! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 11:45:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 09:45:51 +0000 Subject: [Koha-bugs] [Bug 31355] Specific item holds table on OPAC only showing 10 items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31355 --- Comment #4 from Katrin Fischer --- Great catch and would be really good if we could have it in the next stable 22.05.x still! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 11:47:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 09:47:06 +0000 Subject: [Koha-bugs] [Bug 31355] Specific item holds table on OPAC only showing 10 items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31355 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 11:47:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 09:47:10 +0000 Subject: [Koha-bugs] [Bug 31355] Specific item holds table on OPAC only showing 10 items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31355 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139435|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 139539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139539&action=edit Bug 31355: Add paging = false to items table on opac-reserve Moving to an ajax datatable and paging would be a future fix, this restores lost functionality To test: 1 - Find or create a title with 20 items 2 - Place a hold in opac 3 - Attempt to select a specific item 4 - Note only 10 show 5 - Apply patch 6 - All items show Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 11:50:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 09:50:07 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #39 from Katrin Fischer --- Can you please rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 15:18:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 13:18:43 +0000 Subject: [Koha-bugs] [Bug 31315] Remove GetItemsInfo from moredetail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31315 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi Status|Signed Off |Failed QA --- Comment #3 from Joonas Kylmälä --- Item type field shows after this patch only the itemtype code, not the description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 22:32:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 20:32:41 +0000 Subject: [Koha-bugs] [Bug 31358] Offline circulation broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31358 --- Comment #2 from Victor Grousset/tuxayo --- Ouch, thanks for tracking that down. Does it look hard to replace? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 22:36:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 20:36:42 +0000 Subject: [Koha-bugs] [Bug 30567] Create manual invoice with FR currency format show the incorrect format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.04, |22.11.00, 22.05.04, released in|21.11.11 |21.11.11, 21.05.18 --- Comment #14 from Victor Grousset/tuxayo --- Backported: Pushed to 21.05.x branch for 21.05.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 20 22:40:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Aug 2022 20:40:34 +0000 Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 --- Comment #65 from Victor Grousset/tuxayo --- (In reply to Nick Clemens from comment #52) > [...] > > This is so much faster though, and when it works, it works as it did > previously Out of curiosity about how BackgroundJob works, how does it makes the process faster? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 10:35:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 08:35:19 +0000 Subject: [Koha-bugs] [Bug 29768] hidepatronname hides guarantor name on borrower edit screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #19 from Joonas Kylmälä --- The hyperlink is not shown in the latest patch version, the hide_patron_infos_if_needed check was reintroduced in this version of the patch, it was the one you removed earlier. Also, I'm thinking whether introducing a "no_link" variable or equivalent in addition to the "no_html" would be a good idea? Reading your last patch and patron-title.inc in more detail the patron's title (Mr, Dr, etc.) seems to be enclosed in a span, which would be valid inside hyperlink, however a hyperlink wouldn't be valid inside a hyperlink. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 10:44:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 08:44:42 +0000 Subject: [Koha-bugs] [Bug 30667] Holds reminder cronjob (holds_reminder.pl) never uses default letter template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30667 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00, 21.11.11 released in| | --- Comment #9 from Arthur Suzuki --- pushed to 21.11.x for 21.11.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 10:46:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 08:46:55 +0000 Subject: [Koha-bugs] [Bug 31220] Error when attempting to export selected labels as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|22.11.00, 22.05.04 |22.11.00, 22.05.04, released in| |21.11.11 CC| |arthur.suzuki at biblibre.com --- Comment #12 from Arthur Suzuki --- pushed to 21.11.x for 21.11.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 11:08:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 09:08:53 +0000 Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi Status|Signed Off |Patch doesn't apply --- Comment #35 from Joonas Kylmälä --- Needs a rebase due to the changes introduced in the dependency bug 31314 after these patches were made. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 12:35:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 10:35:12 +0000 Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 12:35:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 10:35:48 +0000 Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 12:35:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 10:35:52 +0000 Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139470|0 |1 is obsolete| | Attachment #139471|0 |1 is obsolete| | Attachment #139472|0 |1 is obsolete| | --- Comment #15 from Joonas Kylmälä --- Created attachment 139540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139540&action=edit Bug 26626: Add 'Ignore' option to confirmed holds modal This patch adds 'Ignore' to the 'Hold already waiting' modal To test: To recreate: 1 - Place a hold for pickup at library A 2 - Checkin the item at Library A 3 - Note the modal has 'Ignore' option 4 - Click it, nothing happens 5 - Check in the item again, same modal 6 - Click 'Confirm' 7 - Check in the item again 8 - Now 'Ignore' is replaced by 'Cancel' 9 - Click 'Confirm' to dismiss modal 10 - Apply patch 11 - Check the item in again 12 - Note 'Ignore' button before 'Cancel' button with '-' icon 13 - Go to biblio holds page 14 - Revert waiting status 15 - Check item in again 16 - Note ignore now has '-' (minus) icon Signed-off-by: Barbara Johnson Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 12:35:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 10:35:54 +0000 Subject: [Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 12:35:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 10:35:58 +0000 Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 --- Comment #16 from Joonas Kylmälä --- Created attachment 139541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139541&action=edit Bug 26626: (follow-up) Update icon selection This patch changes the "Ignore" button to use an X icon and the "Cancel" button to use a "Trash" icon. Signed-off-by: Barbara Johnson Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 12:36:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 10:36:02 +0000 Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 --- Comment #17 from Joonas Kylmälä --- Created attachment 139542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139542&action=edit Bug 26626: (follow-up) Be consistent with icon and accesskeys Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 12:53:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 10:53:09 +0000 Subject: [Koha-bugs] [Bug 31431] New: Cannot change one's own userid if logged in as staff Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31431 Bug ID: 31431 Summary: Cannot change one's own userid if logged in as staff Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: joonas.kylmala at iki.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com I cannot change the userid for my own account in the staff interface, if I do that I get the following error on any subsequent page I try to access: > Can't use string ("Koha::Patron") as a HASH ref while "strict refs" in use at /kohadevbox/koha/Koha/Object.pm line 830 Could the user session be tied into a specific userid, and if that changes things break? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 12:54:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 10:54:55 +0000 Subject: [Koha-bugs] [Bug 31431] Cannot change one's own userid if logged in as staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31431 --- Comment #1 from Katrin Fischer --- Hm I think this used to work, but after changing I usually needed to log in again being logged out. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 13:17:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 11:17:41 +0000 Subject: [Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 13:17:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 11:17:48 +0000 Subject: [Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134555|0 |1 is obsolete| | Attachment #136006|0 |1 is obsolete| | Attachment #136007|0 |1 is obsolete| | --- Comment #42 from Katrin Fischer --- Created attachment 139543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139543&action=edit Bug 20262: Add ability to refund lost item fees without creating credits Some libraries handle refunding of paid lost fees at a financial office and not within Koha. To facilitate this, it would be good for Koha to have the option to not generate lost returned credits by skipping fully paid lost items, and only refunding the outstanding balance on partially paid lost fees. Test Plan: 1) Apply this patch 2) Set your lost item refund on return policies to 'Only if unpaid' 3) Mark an item lost, charging the lost fee 4) Return the item, a full refund should occur 5) Mark another item lost, charging the lost fee 6) Make a partial payment on this lost fee 7) Return the item 8) The remaining balance of that fee should be 0, but the patron should not recieve a credit for the already paid balance 8) Mark another item lost, charging the lost fee 9) Fully pay the lost fee 10) Return the item. The paid lost fee should be unaffected. 11) Run tests in t/db_dependent/Circulation.t Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 13:17:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 11:17:56 +0000 Subject: [Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 --- Comment #43 from Katrin Fischer --- Created attachment 139544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139544&action=edit Bug 20262: (QA follow-up) Fix spelling errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 13:18:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 11:18:02 +0000 Subject: [Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 --- Comment #44 from Katrin Fischer --- Created attachment 139545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139545&action=edit Bug 20262: (QA follow-up) Update unit tests for changes to payin_amount Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 13:22:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 11:22:40 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #22 from Katrin Fischer --- Hi Thibaud, can you please take a look at Kyle's question in comment#21? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 13:30:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 11:30:19 +0000 Subject: [Koha-bugs] [Bug 29930] Auth with LDAP: Update tag leads to unwanted updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29930 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #2 from Katrin Fischer --- I am sorry, but it looks like this hasn't been signed off yet. Moving back into the SO queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 13:52:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 11:52:21 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #113 from Katrin Fischer --- *ping* (In reply to Katrin Fischer from comment #110) > Does this touch any of the coding guidelines or should we have a new one for > how we want things to be done? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 14:28:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 12:28:41 +0000 Subject: [Koha-bugs] [Bug 31351] Worker dies on reindex job when operator last name/first name/branch name contains non-ASCII chars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi --- Comment #4 from Joonas Kylmälä --- I'm wondering whether the fix is correct, and whether the other encode_utf8 calls in the same file are the right way to deal with encoding. Shouldn't we already decode the data as Perl's internal string when we read the data? In this particular case it would mean that C4::Context->userenv should be made so that it contains unicode strings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 15:54:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 13:54:31 +0000 Subject: [Koha-bugs] [Bug 31313] Remove GetItemsInfo from opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi --- Comment #16 from Joonas Kylmälä --- regression found: the item transfer status is not shown anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 16:07:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 14:07:56 +0000 Subject: [Koha-bugs] [Bug 31313] Remove GetItemsInfo from opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 --- Comment #17 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #16) > regression found: the item transfer status is not shown anymore. Seems like few other fields could be missing too, in addition I found item.waiting to be missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 16:52:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 14:52:15 +0000 Subject: [Koha-bugs] [Bug 31351] Worker dies on reindex job when operator last name/first name/branch name contains non-ASCII chars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 21:27:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 19:27:01 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130430|0 |1 is obsolete| | Attachment #130431|0 |1 is obsolete| | Attachment #130432|0 |1 is obsolete| | Attachment #130433|0 |1 is obsolete| | Attachment #130434|0 |1 is obsolete| | Attachment #130435|0 |1 is obsolete| | Attachment #130436|0 |1 is obsolete| | Attachment #130437|0 |1 is obsolete| | Attachment #130438|0 |1 is obsolete| | Attachment #130439|0 |1 is obsolete| | Attachment #130440|0 |1 is obsolete| | Attachment #130441|0 |1 is obsolete| | Attachment #130442|0 |1 is obsolete| | --- Comment #71 from Joonas Kylmälä --- Created attachment 139546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139546&action=edit Bug 24295: Remove GetTransfer from Z3950Responder Replace the GetTrasfer call in Z3950Responder/Session.pm with a call to the Koha::Item method 'get_transfer'. Test plan 1/ Configure your system to use the Z3950 responder 2/ Trigger an item transfer for an item 3/ Search for the item via Z3950 and varify the transfer status is set 4/ Apply the patch 5/ Repeat step 3 Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 21:27:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 19:27:06 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #72 from Joonas Kylmälä --- Created attachment 139547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139547&action=edit Bug 24295: Remove GetTransfers from opac-reserve.pl This patch replaces the call to GetTransfers in opac-reserve with the get_transfer method available from the Koha::Item object Test plan 1/ Place a reserve on an item at a different branch 2/ Trigger the transfer of the item 3/ Check the opac-reserves page for the display of the current transfer status 4/ Apply patch 5/ Repeat step 3 Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 21:27:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 19:27:10 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #73 from Joonas Kylmälä --- Created attachment 139548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139548&action=edit Bug 24295: Remove GetTransfers from opac-detail.pl This patch replaces the call to GetTransfers in opac-detail with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the opac-detail page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 JK: Remove unneeded string formatting for transfertwhen as it's done on the template toolkit side already with $KohaDates Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 21:27:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 19:27:15 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #74 from Joonas Kylmälä --- Created attachment 139549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139549&action=edit Bug 24295: Remove GetTransfers from opac-basket.pl This patch replaces the call to GetTransfers in opac-basket with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the opac-basket page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 JK: Remove unneeded string formatting for transfertwhen as it's done on the template toolkit side already with $KohaDates. Add missing Koha::Items module import. Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 21:27:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 19:27:20 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #75 from Joonas Kylmälä --- Created attachment 139550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139550&action=edit Bug 24295: Remove GetTransfers from request.pl This patch replaces the call to GetTransfers in reserve.pl with the get_transfer method available from the Koha::Item object Test plan 1/ Place a reserve on an item at a different branch 2/ Trigger the transfer of the item 3/ Check the reserves page for the display of the current transfer status 4/ Apply patch 5/ Repeat step 3 Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 21:27:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 19:27:24 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #76 from Joonas Kylmälä --- Created attachment 139551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139551&action=edit Bug 24295: Remove GetTransfers from detail.pl This patch replaces the call to GetTransfers in detail.pl with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the detail page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 JK: Remove unneeded string formatting for transfertwhen as it's done on the template toolkit side already with $KohaDates Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 21:27:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 19:27:29 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #77 from Joonas Kylmälä --- Created attachment 139552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139552&action=edit Bug 24295: Remove GetTransfers from svc/holds This patch replaces the call to C4::GetTransfers in svc/holds with a call to the get_transfer method in the Koha::Item object. Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 21:27:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 19:27:33 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #78 from Joonas Kylmälä --- Created attachment 139553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139553&action=edit Bug 24295: Replace mock in t/db_dependent/Search.t Replace the mock of GetTransfers in this test with a mock of transfers data Test plan 1/ Run t/db_dependent/Search.t 2/ Confirm it passes 3/ Apply patch 4/ Repeat steps 1-2 Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 21:27:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 19:27:38 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #79 from Joonas Kylmälä --- Created attachment 139554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139554&action=edit Bug 24295: Replace mock in t/db_dependent/Circulation/transferbook.t Replace the call to GetTransfers with the get_transfer method in Koha::Item in transferbook.t Test plan 1/ Run t/db_dependent/Circulation/transferbook.t 2/ Confirm it passes 3/ Apply patch 4/ Repeat steps 1-2 Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 21:27:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 19:27:42 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #80 from Joonas Kylmälä --- Created attachment 139555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139555&action=edit Bug 24295: Remove GetTransfers call from C4/HoldsQueue.pm This patch removes the GetTransfers call from GetItemsAvailableToFillHoldRequestsForBib instead replacing it with an inline JOIN in the initial query. Test plan 1/ Run the holds queue 2/ Check the results 3/ Put one of the items in the holds queue into transit 4/ Run the holds queue again 5/ Check that the results do not contain the item that is in transit 6/ Apply the patch 7/ Run the holds queue again 8/ Check that the results still do not contain the item that is in transit Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 21:27:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 19:27:48 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #81 from Joonas Kylmälä --- Created attachment 139556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139556&action=edit Bug 24295: Remove GetTransfers from C4/Search.pm This patch removes the final use of GetTransfers from C4::Search. Test plan 1/ Perform a search that will include results for some items that have transfers of various states assigned to them 2/ Check the results match expectations (before and after applying the patch should look the same) 3/ Signoff Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 21:27:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 19:27:54 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #82 from Joonas Kylmälä --- Created attachment 139557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139557&action=edit Bug 24295: Remove GetTransfers from circ/transferstoreceive.pl Just drop the import of GetTransfers from circ/transferstoreceive.pl is it's never actually used. Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 21:27:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 19:27:59 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #83 from Joonas Kylmälä --- Created attachment 139558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139558&action=edit Bug 24295: Finally remove GetTransfers from C4/Circulation This patch handles the final removal of GetTransfers from C4::Circulation. Test plan 1/ Check that there is no mention of the GetTransfers method codebase wide now 2/ Run the circulation and transfers tests and check nothing fails.. perhaps even run the full test suit in k-t-d 3/ Signoff Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 21:39:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 19:39:19 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #84 from Joonas Kylmälä --- Rebased the patches. In addition to the rebase I amended a couple minor fixes (left a comment on those patches): I noticed you had added output_pref() function call in some places but I didn't see it as needed as output_pref() is already called on the Template side via the $KohaDates filter, in fact some of the patches now were conflicting due to output_pref() calls being removed in the scripts in origin/master. So I removed the output_pref calls. Then there was a missing Koha::Items module import which I added. Signing off. Note to other testers: currently there is a regression in opac-detail.pl caused by bug 31313, see comment 16 there. This makes it harder to test the code change here as you would have to modify the item-status.inc code to fix the regression in order to be able to see the transfer status this patch touches on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 22:02:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 20:02:53 +0000 Subject: [Koha-bugs] [Bug 30580] GetItemsAvailableToFillHoldRequestsForBib should get transfers during initial query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30580 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED CC| |joonas.kylmala at iki.fi --- Comment #7 from Joonas Kylmälä --- This appears to be duplicate of bug 24295. Nick, could you attach the unit test you made here to bug 24295 as it doesn't have it? A QA round would be nice as well, so we could get the patches pushed on the same go :) *** This bug has been marked as a duplicate of bug 24295 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 22:02:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 20:02:53 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #85 from Joonas Kylmälä --- *** Bug 30580 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 23:04:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 21:04:05 +0000 Subject: [Koha-bugs] [Bug 31416] Improve OPAC "Browse by hierarchy" and "Subject cloud" features In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31416 --- Comment #2 from Katrin Fischer --- I personally would like to see the browse classification revived. This would make a nice omnibus bug with separate bugs filed for the issues, some of which would need more specification. But as Owen said, this has not been in focus of development for a long time and without funding there will probably be no progress. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 23:07:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 21:07:13 +0000 Subject: [Koha-bugs] [Bug 25652] Holds daily is not looking at item type when not allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25652 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master Summary|Holds Daily is not looking |Holds daily is not looking |at Item Type when Not |at item type when not |Allowing Holds |allowing holds --- Comment #4 from Katrin Fischer --- I think it might not be easy to implement or maybe only with a fallback to the record level itemtype. When a hold is placed without being limited to an item type, it's not easy to determine which itemtype should apply if there are multiple items that could fill the hold with different itemtypes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 23:08:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 21:08:12 +0000 Subject: [Koha-bugs] [Bug 25652] Holds daily is not looking at item type when not allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25652 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15486 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 [Bug 15486] Restrict number of holds placed by day -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 23:08:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 21:08:12 +0000 Subject: [Koha-bugs] [Bug 15486] Restrict number of holds placed by day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25652 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25652 [Bug 25652] Holds daily is not looking at item type when not allowing holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 23:21:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 21:21:45 +0000 Subject: [Koha-bugs] [Bug 29939] Replace opac-ratings-ajax.pl with a new REST API route In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29939 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 23:21:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 21:21:50 +0000 Subject: [Koha-bugs] [Bug 29939] Replace opac-ratings-ajax.pl with a new REST API route In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29939 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139412|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 139559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139559&action=edit Bug 29939: Use the REST API for ratings This patch replaces opac-ratings-ajax.pl with a new REST API route POST /public/biblios/42/ratings Note that we could go further and refactor the 'start_rating' select code. Test plan: Test the "star ratings" feature at the OPAC, on the different page where it's displayed. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 23:24:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 21:24:29 +0000 Subject: [Koha-bugs] [Bug 31370] Additional contents: Preview of default content only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31370 --- Comment #2 from Katrin Fischer --- I think it would be nice if we could see all languages and maybe 'page' through the preview. It would help with checking that all translations have been added and appear correctly and save some time when looking for mistakes etc. compared to checking in the OPAC. But enhancement is probably right here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 23:35:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 21:35:31 +0000 Subject: [Koha-bugs] [Bug 28708] fr-CA localization file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28708 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 23:35:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 21:35:35 +0000 Subject: [Koha-bugs] [Bug 28708] fr-CA localization file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28708 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139215|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 139560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139560&action=edit Bug 28708: fr-CA localization file Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 23:37:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 21:37:33 +0000 Subject: [Koha-bugs] [Bug 31394] background hold cancellation causing confusion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31394 --- Comment #1 from Katrin Fischer --- I can see how this would cause confusion and might also be seen as a regression to the previous behaviour :( -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 23:38:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 21:38:07 +0000 Subject: [Koha-bugs] [Bug 31394] background hold cancellation causing confusion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31394 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23678 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 [Bug 23678] Cancel holds in bulk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 23:38:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 21:38:07 +0000 Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31394 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31394 [Bug 31394] background hold cancellation causing confusion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 23:42:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 21:42:52 +0000 Subject: [Koha-bugs] [Bug 27081] Notes missing from lost items report column configuration when CSV export is active In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27081 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 23:42:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 21:42:56 +0000 Subject: [Koha-bugs] [Bug 27081] Notes missing from lost items report column configuration when CSV export is active In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27081 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139001|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 139561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139561&action=edit Bug 27081: Handle first column (checkboxes) in column settings for lost items report We are adding one column (the one with the checkboxes) at the beginning of each row if it's possible to export the report to CSV. However the column settings were not modified. We need to append one object representing this column. Test plan: To test: * Create a CSV profile of type SQL for exporting lost items * Make sure you have some lost items * Run Reports > Items lost => You can hide the notes (last column) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 23:45:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 21:45:53 +0000 Subject: [Koha-bugs] [Bug 31419] Add accesskeys to recall modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31419 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734 [Bug 29734] [OMNIBUS] Recalls for Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 23:45:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 21:45:53 +0000 Subject: [Koha-bugs] [Bug 29734] [OMNIBUS] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31419 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31419 [Bug 31419] Add accesskeys to recall modal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 23:52:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 21:52:19 +0000 Subject: [Koha-bugs] [Bug 31419] Add accesskeys to recall modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31419 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 21 23:52:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 21:52:23 +0000 Subject: [Koha-bugs] [Bug 31419] Add accesskeys to recall modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31419 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139473|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 139562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139562&action=edit Bug 31419: Add accesskeys for modals This patch simply adds accesskey elements to the buttons, and changes an icon to be consistent with bug 26626 For tips on how to access the accesskeys: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey To test: 1 - Generate a recall 2 - Fill it/check in 3 - Note modal now has hints "Confirm (Y)" 4 - Test with Y,P,I keys (may need to recreate recalls) 5 - Confirm the recall and test waiting recall modal too Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 00:01:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 22:01:33 +0000 Subject: [Koha-bugs] [Bug 6936] Allow to limit on multiple itemtypes when exporting bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6936 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 00:01:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 22:01:38 +0000 Subject: [Koha-bugs] [Bug 6936] Allow to limit on multiple itemtypes when exporting bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6936 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139411|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 139563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139563&action=edit Bug 6936: Allow multiple itemtypes for bib record export This patch allows multiple item types to be chosen when exporting bib records from the Tools module. Test plan: 0. Apply patch and koha-plack --restart kohadev 1. Go to http://localhost:8081/cgi-bin/koha/tools/export.pl 2. Select "All" for "Item type" and note 435 bibs are exported 3. Select "Books" and note 360 bibs are exported 4. Select "Books" and "Visual Materials" and note 380 bibs are exported Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 00:03:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 22:03:17 +0000 Subject: [Koha-bugs] [Bug 6936] Allow to limit on multiple itemtypes when exporting bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6936 --- Comment #11 from Katrin Fischer --- Always amazing to see one of those old 4 digit bugs resolved! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 00:05:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 22:05:34 +0000 Subject: [Koha-bugs] [Bug 31332] Claims return alert does not clear on check in screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31332 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Claims Return Alert Does |Claims return alert does |not Clear on Check in |not clear on check in |screen |screen Version|21.11 |master --- Comment #1 from Katrin Fischer --- This appears to work in master - not sure if this might be an issue only in older versions. I notice that the warn shows in the background but is overlaid by the modal. Maybe some issue there? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 00:05:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 22:05:42 +0000 Subject: [Koha-bugs] [Bug 31332] Claims return alert does not clear on check in screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31332 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |21.11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 00:09:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 22:09:46 +0000 Subject: [Koha-bugs] [Bug 31234] SubfieldsToAllowForRestrictedEditing : data from drop-down menu not stored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31234 --- Comment #6 from Katrin Fischer --- (In reply to Fridolin Somers from comment #5) > BTW : > The system preference 'SubfieldsToAllowForRestrictedEditing' edition is > quite strange, why enter itemsfield 952/995 when it is obvious. > Could be simply subfields separated with a comma : a,b,c In theory someone could have changed the item subfield and used something else... we'd never recommend to do that, but I guess it might be the case or was thought to be an option when the preference was added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 00:11:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 22:11:47 +0000 Subject: [Koha-bugs] [Bug 31253] Item search in staff interface should call barcodedecode if the search index is a barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31253 --- Comment #4 from Katrin Fischer --- (In reply to Owen Leonard from comment #2) > Is this specific to the search engine? It should not be. It changes the search term that is used. Also item search is SQL based. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 00:13:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 22:13:57 +0000 Subject: [Koha-bugs] [Bug 27817] Enhance display of title informatoin throughout acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Enhance display of 245 |Enhance display of title |fields throughout |informatoin throughout |Acquisitions |acquisitions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 00:14:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 22:14:05 +0000 Subject: [Koha-bugs] [Bug 27817] Enhance display of title information throughout acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Enhance display of title |Enhance display of title |informatoin throughout |information throughout |acquisitions |acquisitions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 00:16:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 22:16:59 +0000 Subject: [Koha-bugs] [Bug 27817] Enhance display of title information throughout acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #14 from Katrin Fischer --- (In reply to Owen Leonard from comment #12) > (In reply to Barbara Johnson from comment #7) > > > On basket.pl ... is also incorrectly including series data from the 490|a and > > 490|v. > > basket.pl and invoice.pl have code to deliberately add the series > information to the title variable: > > if ( $line{'title'} ) { > my $volume = $order->{'volume'}; > my $seriestitle = $order->{'seriestitle'}; > $line{'title'} .= " / $seriestitle" if $seriestitle; > $line{'title'} .= " / $volume" if $volume; > } > > > parcel.pl appears to be showing 245$b correctly for me in the "Already > received" table, which is the only place this patch changes anything. The > display of title information in the "Pending orders" table is not affected. Maybe we could move the series information display to a separate bug. I can see that the code doesn't affect it - neither adding nor removing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 00:19:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 22:19:18 +0000 Subject: [Koha-bugs] [Bug 31432] New: Make 245 n and p subfields visible in editor by default Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31432 Bug ID: 31432 Summary: Make 245 n and p subfields visible in editor by default Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org As we now have nice mappings for these in the tables, we should make also sure hat they are visible in the cataloguing editor by default in new installations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 00:26:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 22:26:30 +0000 Subject: [Koha-bugs] [Bug 31433] New: Improve display of title information when ordering from an existing records Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31433 Bug ID: 31433 Summary: Improve display of title information when ordering from an existing records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When ordering from an existing record only the title (245$a for MARC21) is shown in the form. It would be nice if we showed 245abnp instead. See bug 27817 as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 00:26:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 22:26:30 +0000 Subject: [Koha-bugs] [Bug 27817] Enhance display of title information throughout acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31433 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 00:32:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 22:32:51 +0000 Subject: [Koha-bugs] [Bug 31434] New: mprove display of title information when receiving orders Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31434 Bug ID: 31434 Summary: mprove display of title information when receiving orders Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When receiving orders, it's especially important to have enough information about the orders to make sure you select the right entries. At the moment only title (245$a for MARC21) is shown in the list. If you are ordering a volume of a specific series, that information is missing (245np). We should show 245abhnp to complete the work done in bug 27817. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 00:32:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 22:32:51 +0000 Subject: [Koha-bugs] [Bug 27817] Enhance display of title information throughout acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31434 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 00:34:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 22:34:48 +0000 Subject: [Koha-bugs] [Bug 27817] Enhance display of title information throughout acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 00:34:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 22:34:53 +0000 Subject: [Koha-bugs] [Bug 27817] Enhance display of title information throughout acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139517|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 139564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139564&action=edit Bug 27817: Use biblio-title include in some acquisitions pages This patch adds the use of the biblio-title include in acquisitions templates which get the right data from their corresponding scripts. To test, apply the patch and test these Acquisitions pages to confirm that titles with 245$b, 245$h, etc, show all the correct information. - Acquisitions -> Vendor -> Basket - Acquisitions -> Vendor -> Uncertain prices - Acquisitions -> Invoices -> Invoice - Acquisitions -> Invoices -> Invoice -> View an invoice which has an already-received bibliographic record. - Go to receipt page -> Already received. -- The "Pending orders" table is unmodified because I wasn't sure how to use the biblio-title include in an AJAX DataTable. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 00:36:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 22:36:39 +0000 Subject: [Koha-bugs] [Bug 27817] Enhance display of title information throughout acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #16 from Katrin Fischer --- I filed bug 31433 (order from existing) and bug 31434 (order receive) to complete the work here. This is already a huge improvement and important to libraries dealing with a lot of multi-part records and series that can only be differentiated by part number or part name. @Barbara: if you wanted to give this another try we could count my sign-off towards QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 01:23:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 23:23:21 +0000 Subject: [Koha-bugs] [Bug 11501] Add Zebra index for "Local-Subjects" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11501 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |LATER -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 01:44:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 23:44:33 +0000 Subject: [Koha-bugs] [Bug 459] No uninstall script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=459 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #7 from David Cook --- (In reply to Kyle M Hall from comment #6) > (In reply to Liz Rea from comment #5) > > Why would we not use koha-remove and then apt uninstall > > koha-common then apt autoremove? > > > > I'm not sure this bug needs a fix anymore? A developer is going to be using > > either a devbox or a koha-testing-docker; an average user hopefully will be > > using Debian packages as advised in our documentation, and certainly, > > support vendors will be using the packages as well. > > I tend to agree, but isn't installation from tarball still supported? I'm with Liz on this one. While people can install Koha from a tarball, I can't think of any Linux software that has a uninstall script when installed from source tarball... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 01:47:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Aug 2022 23:47:02 +0000 Subject: [Koha-bugs] [Bug 1918] Minify JavaScript and CSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1918 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Patch doesn't apply |RESOLVED CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 02:34:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 00:34:48 +0000 Subject: [Koha-bugs] [Bug 1937] Scan barcode with webcam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1937 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #5 from David Cook --- We did a demo with this for the Koha self checkout so that people in remote libraries could self-checkout using their phones. My first version used https://github.com/zxing-js/library but we found results varied heavily between different devices. I got quite good at doing it with my web camera and my phone camera, but sometimes it wouldn't work that well, and a lot of test users struggled to get the phone camera to focus on the barcode well enough for the Javascript to capture and interpret the barcode. We later integrated with a commercial product called Scandit which was very effective, but it has a pay per use agreement. I think it leveraged server-side processing as well. (At some point, it looks like browsers may have native barcode reading support: https://developer.mozilla.org/en-US/docs/Web/API/Barcode_Detection_API) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 02:37:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 00:37:00 +0000 Subject: [Koha-bugs] [Bug 1937] Scan barcode with webcam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1937 --- Comment #6 from David Cook --- If you're interested in this Martin, I'd be happy to share code and lessons learned. The library using the Scandit integration does about 60 uses per month. I can't remember the terms of the agreement but I think it's where you purchase X uses per month for Y amount, and then pay Z amount if you go over X usage. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 02:51:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 00:51:18 +0000 Subject: [Koha-bugs] [Bug 2244] RFID Cataloguing - Programming RFID tags from Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2244 --- Comment #7 from David Cook --- I can't find those Perl modules on CPAN anymore. Otherwise, I was going to say this could make for an interesting Koha plugin. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 02:57:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 00:57:49 +0000 Subject: [Koha-bugs] [Bug 6511] Server-side paging of SQL queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6511 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- I think the move to DataTables using server-side processing resolves this one -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:08:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:08:41 +0000 Subject: [Koha-bugs] [Bug 7365] Koha should support PostgreSQL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:09:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:09:17 +0000 Subject: [Koha-bugs] [Bug 7423] Export MARC records based on barcode file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7423 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:16:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:16:17 +0000 Subject: [Koha-bugs] [Bug 14448] Hypnotoad and Nginx config for REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14448 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9316, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9100, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11952 CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:16:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:16:17 +0000 Subject: [Koha-bugs] [Bug 9316] Add Nginx install options with plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14448 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:16:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:16:17 +0000 Subject: [Koha-bugs] [Bug 9100] Sample configurations should be included for nginx+Plack/Starman In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9100 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14448 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:16:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:16:17 +0000 Subject: [Koha-bugs] [Bug 11952] utility scripts hard-coded to expect apache, breaks when koha is installed under nginx In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11952 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14448 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:17:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:17:58 +0000 Subject: [Koha-bugs] [Bug 11952] utility scripts hard-coded to expect apache, breaks when koha is installed under nginx In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11952 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- *** This bug has been marked as a duplicate of bug 9316 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:17:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:17:58 +0000 Subject: [Koha-bugs] [Bug 9316] Add Nginx install options with plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |desmith at gmail.com --- Comment #57 from David Cook --- *** Bug 11952 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:18:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:18:23 +0000 Subject: [Koha-bugs] [Bug 9316] Add Nginx install options with plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 --- Comment #58 from David Cook --- These patches are super outdated now, and I don't think there are any serious plans to add support for Nginx with koha-common, although I think that BibLibre use Nginx at some level in front of Koha. If someone wants to seriously add Nginx support, they can either re-open this bug, or create a new one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:18:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:18:54 +0000 Subject: [Koha-bugs] [Bug 9316] Add Nginx install options with plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au Resolution|--- |WONTFIX Status|In Discussion |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:19:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:19:04 +0000 Subject: [Koha-bugs] [Bug 9316] Add Nginx install options with plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WONTFIX |WISHLIST -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:23:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:23:00 +0000 Subject: [Koha-bugs] [Bug 5523] Display list of items which are to be cataloged in the cataloguing home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5523 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #10 from David Cook --- (In reply to Martin Renvoize from comment #9) > I reckon we could rethink this after bug 31162 now. I think that Liz is right at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9373#c5 when she says folk should just use Javascript to display it. And yeah that's something to explore more after bug 31162 I think... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:23:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:23:48 +0000 Subject: [Koha-bugs] [Bug 9373] show FA (fast add) bibs on the main cataloging page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9373 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |dcook at prosentient.com.au Status|In Discussion |RESOLVED --- Comment #9 from David Cook --- I reckon this is a duplicate of bug 5523 and that Liz is right that the approach should be to use Javascript and a SQL report. *** This bug has been marked as a duplicate of bug 5523 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:23:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:23:48 +0000 Subject: [Koha-bugs] [Bug 5523] Display list of items which are to be cataloged in the cataloguing home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5523 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #11 from David Cook --- *** Bug 9373 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:24:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:24:54 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #24 from David Cook --- Btw I'm liking that screenshot! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:29:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:29:43 +0000 Subject: [Koha-bugs] [Bug 9232] It should be possible to limit on multiple years or date ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9232 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |dcook at prosentient.com.au Resolution|--- |WORKSFORME --- Comment #1 from David Cook --- Pretty sure this has been fixed... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:29:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:29:44 +0000 Subject: [Koha-bugs] [Bug 9234] Koha's search code needs to be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9234 Bug 9234 depends on bug 9232, which changed state. Bug 9232 Summary: It should be possible to limit on multiple years or date ranges https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9232 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:31:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:31:16 +0000 Subject: [Koha-bugs] [Bug 9125] Syck parser error caused by uploading Koha Offline Circulation file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9125 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22824 CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:31:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:31:16 +0000 Subject: [Koha-bugs] [Bug 22824] Replace YAML::Syck with YAML::XS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9125 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:32:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:32:02 +0000 Subject: [Koha-bugs] [Bug 9125] Syck parser error caused by uploading Koha Offline Circulation file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9125 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #2 from David Cook --- Since we've moved away from YAML::Syck, this one is invalid I think. Probably not an issue these days anymore anyway. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:33:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:33:48 +0000 Subject: [Koha-bugs] [Bug 8785] Basic authentication troubleshootings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8785 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- (In reply to Martin Renvoize from comment #1) > Is anyone using http basic auth with koha in the wild I wonder? > > I'm trying to go through old auth bugs and work out if they're still > relevant... Matthias, any comments regarding the current state of this? I'm also curious about this. Do people really use this anymore? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:34:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:34:33 +0000 Subject: [Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |victor at tuxayo.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:34:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:34:46 +0000 Subject: [Koha-bugs] [Bug 8634] Style should be user-selectable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8634 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- (In reply to Katrin Fischer from comment #1) > Maintaining multiple themes has been proven nearly impossible. You can still > add your own, but not sure if you'd want patrons to use more than yours in > that case. > > Maybe another approach: instead of a theme have multiple CSS files to choose > from? Normal, high contrast, simplified... I feel like someone was talking about that recently. I think even that would be difficult to maintain, unfortunately. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:36:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:36:57 +0000 Subject: [Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:37:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:37:22 +0000 Subject: [Koha-bugs] [Bug 8589] Advanced Search for itemtype and location produces some results that are not useful In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8589 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- Is this still an issue? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:38:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:38:22 +0000 Subject: [Koha-bugs] [Bug 9262] Patch complexity field user interface is awkward to use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9262 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:38:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:38:27 +0000 Subject: [Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:43:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:43:57 +0000 Subject: [Koha-bugs] [Bug 21366] Add Plack reload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:51:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:51:00 +0000 Subject: [Koha-bugs] [Bug 21366] Add Plack reload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139035|0 |1 is obsolete| | --- Comment #21 from Victor Grousset/tuxayo --- Created attachment 139565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139565&action=edit Bug 21366: Add --reload option to koha-plack help/manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:53:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:53:13 +0000 Subject: [Koha-bugs] [Bug 21366] Add Plack reload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #22 from Victor Grousset/tuxayo --- Last patch amended to explain what reloading means. Reload the Plack daemon for the desired Koha instances. ↓↓↓ Reload the Plack daemon for the desired Koha instances, letting the busy workers finish processing their requests before restarting them. Tell me if the phrasing can be improved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:54:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:54:42 +0000 Subject: [Koha-bugs] [Bug 8494] use js_beautify.pl to format javascript/jquery code in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8494 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- If this hasn't been added in 10 years, I'm not sure if we need it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:56:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:56:16 +0000 Subject: [Koha-bugs] [Bug 31356] Itiva outbound script doesn't respect calendar when calculating expiration date for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31356 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 03:57:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 01:57:23 +0000 Subject: [Koha-bugs] [Bug 31333] Allow the ability to make purchase suggestions to be set by borrower type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 04:00:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 02:00:04 +0000 Subject: [Koha-bugs] [Bug 2878] cloud-kw.pl: should use HTML template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2878 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- I'm curious if anyone actually uses this cronjob... It's methods of operation seem pretty at odds with how things are done in Koha these days... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 04:02:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 02:02:03 +0000 Subject: [Koha-bugs] [Bug 2442] add babelfish links to the bug display page header or footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2442 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #2 from David Cook --- (In reply to Katrin Fischer from comment #1) > Is this still something we intend to do? Machine translation is better than > it used to be, but when your text is 'librarianese' and sprinkled with Koha > terms it might be less than useful. I get the feeling that the change wasn't for Koha but was rather for Bugzilla itself. Probably not necessary these days since I think we mandate English, plus Google Translate has a lot of options for dealing with other languages in browsers anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 04:16:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 02:16:47 +0000 Subject: [Koha-bugs] [Bug 7050] Error in French web installer - sample_labels.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7050 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- Is this still a problem? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 04:17:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 02:17:33 +0000 Subject: [Koha-bugs] [Bug 7244] C4::Members::GetMemberIssuesAndFines() reports all charges, not just fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7244 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- This function doesn't exist anymore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 04:20:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 02:20:44 +0000 Subject: [Koha-bugs] [Bug 9936] SIP2 should work with LDAP and CAS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9936 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- Is this still valid? Looking at "C4/SIP/ILS/Patron.pm" and it looks like it uses "checkpw()" which looks like it will check LDAP. I'm not familiar with CAS but it looks like its more SSO rather than directory lookup like LDAP so don't know that it would ever work in this context. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 04:26:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 02:26:15 +0000 Subject: [Koha-bugs] [Bug 9855] Add OpenGraph (Facebook preview) tags to pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9855 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- This would actually be pretty handy for public libraries I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 04:28:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 02:28:24 +0000 Subject: [Koha-bugs] [Bug 17937] Adding item description to Twitter Summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17937 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #7 from David Cook --- (In reply to Owen Leonard from comment #6) > This looks like it's working, although it's hard to test from a development > environment which isn't open to the internet. > > I think this would be a useful improvement, but shouldn't we use Open Graph > data instead? Facebook will parse that, and Twitter allows it as a fallback > for their own proprietary markup. I like the sound of that. Bug 9855 makes it look quite simple. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 04:34:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 02:34:24 +0000 Subject: [Koha-bugs] [Bug 9537] Add a list of the patches that have been applied to a koha installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9537 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- I can't see this really being practical. I think that it would require every bug patch set to include a database update of some kind, and its only utility would really be for debugging, which should mostly be done in koha-testing-docker anyway where you have easy access to the source code and database. I reckon this issue could probably be closed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 04:36:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 02:36:31 +0000 Subject: [Koha-bugs] [Bug 9354] Add ability to validate MARC records before import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9354 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- This would be interesting to add now that we're moving the MARC record import to background tasks... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 04:36:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 02:36:59 +0000 Subject: [Koha-bugs] [Bug 9354] Add ability to validate MARC records before import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9354 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27421 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 04:36:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 02:36:59 +0000 Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9354 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 04:48:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 02:48:32 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WISHLIST Status|In Discussion |RESOLVED --- Comment #48 from David Cook --- Mirko disappeared from Koha a long time ago, so I don't think he's going to revisit these patches. It's a really interesting idea, but realistically I don't think that it would ever be used in production. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 04:49:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 02:49:08 +0000 Subject: [Koha-bugs] [Bug 15540] Debian package option to set up an .onion address (Tor hidden service) for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15540 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WISHLIST Status|Patch doesn't apply |RESOLVED --- Comment #7 from David Cook --- Mirko disappeared from Koha a long time ago, so I don't think he's going to revisit these patches. It's a really interesting idea, but realistically I don't think that it would ever be used in production. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 04:50:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 02:50:11 +0000 Subject: [Koha-bugs] [Bug 7709] Cover Images Template plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7709 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from David Cook --- *** This bug has been marked as a duplicate of bug 28180 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 04:50:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 02:50:11 +0000 Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.sekjal at gmail.com --- Comment #97 from David Cook --- *** Bug 7709 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 04:50:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 02:50:51 +0000 Subject: [Koha-bugs] [Bug 7705] IE postdata issue - expiring sessions when back button is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7705 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX CC| |dcook at prosentient.com.au Status|NEW |RESOLVED --- Comment #3 from David Cook --- IE isn't supported anymore by the Koha community (or Microsoft) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 04:53:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 02:53:22 +0000 Subject: [Koha-bugs] [Bug 23962] We should drop support for Debian 8 Jessie and Debian 9 Stretch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23962 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au Summary|We should drop support for |We should drop support for |Debian Jessie during 20.05 |Debian 8 Jessie and Debian |cycle. |9 Stretch --- Comment #1 from David Cook --- "Debian LTS support for Debian 9 "Stretch" ended on June 30, 2022" The following should both be updated I reckon: https://wiki.koha-community.org/wiki/System_requirements_and_recommendations https://dashboard.koha-community.org/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 04:58:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 02:58:49 +0000 Subject: [Koha-bugs] [Bug 9965] Improve integration of report plugins with existing reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9965 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #4 from David Cook --- Since we're already doing this for Tools, it would be nice to do it for Reports too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:03:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:03:32 +0000 Subject: [Koha-bugs] [Bug 4439] two acq webservices should use C4::Service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4439 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #6 from David Cook --- This should use the REST API instead of legacy C4::Service -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:04:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:04:06 +0000 Subject: [Koha-bugs] [Bug 9412] add optional_params to C4::Service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9412 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au Resolution|--- |WONTFIX Status|Failed QA |RESOLVED --- Comment #7 from David Cook --- This is a legacy module and the linked bug doesn't need C4::Service either -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:04:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:04:07 +0000 Subject: [Koha-bugs] [Bug 4439] two acq webservices should use C4::Service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4439 Bug 4439 depends on bug 9412, which changed state. Bug 9412 Summary: add optional_params to C4::Service https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9412 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:07:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:07:21 +0000 Subject: [Koha-bugs] [Bug 8013] During installation setup KOHA_CONF and PERL5LIB path in sip_run.sh In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8013 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au Status|ASSIGNED |RESOLVED Resolution|--- |INVALID --- Comment #2 from David Cook --- I don't think hard-coding those values into a shell script would make sense. Typically, one should use the Debian packages. If not using the Debian packages, then creating a service file where hard-coded values could be added might make sense (unless it's systemd which has nice template options) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:08:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:08:09 +0000 Subject: [Koha-bugs] [Bug 7916] Events module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7916 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |dcook at prosentient.com.au Resolution|--- |WONTFIX --- Comment #1 from David Cook --- Description is vague and hasn't been updated for over 10 years -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:14:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:14:06 +0000 Subject: [Koha-bugs] [Bug 7854] preferences.pl: cannot have choice options of yes and no In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7854 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED CC| |dcook at prosentient.com.au Resolution|--- |INVALID --- Comment #4 from David Cook --- It's been over 10 years, we're not using YAML::Syck anymore, I'm not sure I understand this one anyway. I think the HTML forms are based off the .pref files rather than the database, although I could be wrong. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:15:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:15:05 +0000 Subject: [Koha-bugs] [Bug 9991] De-duplicate "no cover image available" (currently in lieu of prioritizing cover image sources) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9991 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from David Cook --- *** This bug has been marked as a duplicate of bug 26933 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:15:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:15:05 +0000 Subject: [Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933 --- Comment #3 from David Cook --- *** Bug 9991 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:19:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:19:55 +0000 Subject: [Koha-bugs] [Bug 1091] Do a second search with shorter terms if there are no results found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1091 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22605 Resolution|--- |WONTFIX CC| |dcook at prosentient.com.au --- Comment #4 from David Cook --- This is a very old enhancement request, and I can't see it working well in practice. Instead, I think an Edit Search like in Bug 22605 is a much more usable path forward. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:19:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:19:55 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=1091 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:23:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:23:11 +0000 Subject: [Koha-bugs] [Bug 8366] Meaning of "All" in issuing rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8366 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #15 from David Cook --- (In reply to Katrin Fischer from comment #13) > I am sorry, but I don't understand the difference for itemtypes. > We've had no issues with the terms here so far. Currently Koha uses "All". Yeah I don't understand the difference either. While the circulation rules can be confusing, I don't think it's because of the term "All"? I think people just struggle with the concept of rules matching on a 1st rule found basis rather than all rules applying always. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:25:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:25:27 +0000 Subject: [Koha-bugs] [Bug 8123] Cronjob to pre-populate/update patrons using LDAP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8123 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WISHLIST Status|Patch doesn't apply |RESOLVED CC| |dcook at prosentient.com.au --- Comment #5 from David Cook --- It's an interesting idea but it's been over 10 years with no movement, and I don't know that a cronjob would make sense. Perhaps a migration script... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:26:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:26:54 +0000 Subject: [Koha-bugs] [Bug 8067] HTML blocks in sysprefs should be definable for multiple languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8067 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #6 from David Cook --- *** This bug has been marked as a duplicate of bug 22318 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:26:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:26:54 +0000 Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ruth at hiruthie.me --- Comment #38 from David Cook --- *** Bug 8067 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:27:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:27:36 +0000 Subject: [Koha-bugs] [Bug 8075] Add XSLT script to remove NSB and NSE characters from Z39.50 downloads In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8075 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |dcook at prosentient.com.au Resolution|--- |DUPLICATE --- Comment #2 from David Cook --- I think that bug 6536 really is the solution to this one *** This bug has been marked as a duplicate of bug 6536 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:27:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:27:36 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #114 from David Cook --- *** Bug 8075 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:28:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:28:51 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #189 from David Cook --- For documentation team, might want to look at Bug 7840 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:30:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:30:19 +0000 Subject: [Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML & CSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #14 from David Cook --- *** This bug has been marked as a duplicate of bug 26933 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:30:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:30:19 +0000 Subject: [Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ssammons at npelem.com --- Comment #4 from David Cook --- *** Bug 7669 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:32:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:32:10 +0000 Subject: [Koha-bugs] [Bug 7512] Dev mode install should use Zebra configs from kohaclone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7512 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WISHLIST CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- This would be cool but I don't think it's likely to ever be done, especially as we're on the road to Elasticsearch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:33:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:33:44 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #54 from David Cook --- *** This bug has been marked as a duplicate of bug 28180 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:33:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:33:44 +0000 Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kmkale at anantcorp.com --- Comment #98 from David Cook --- *** Bug 7187 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:34:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:34:53 +0000 Subject: [Koha-bugs] [Bug 7290] New permission for receiving all (independent of library) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WISHLIST Status|Failed QA |RESOLVED CC| |dcook at prosentient.com.au --- Comment #61 from David Cook --- No movement for years and no response to Katrin's question from several years ago, so moving to "WISHLIST". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:34:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:34:54 +0000 Subject: [Koha-bugs] [Bug 7163] BibLibre acquisitions omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7163 Bug 7163 depends on bug 7290, which changed state. Bug 7290 Summary: New permission for receiving all (independent of library) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WISHLIST -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:34:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:34:54 +0000 Subject: [Koha-bugs] [Bug 8667] Add budget and branch columns in histsearch.pl results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8667 Bug 8667 depends on bug 7290, which changed state. Bug 7290 Summary: New permission for receiving all (independent of library) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WISHLIST -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:35:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:35:15 +0000 Subject: [Koha-bugs] [Bug 7163] BibLibre acquisitions omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7163 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WISHLIST Status|ASSIGNED |RESOLVED CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- No movement for years and no response to Katrin's question from several years ago, so moving to "WISHLIST". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:35:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:35:51 +0000 Subject: [Koha-bugs] [Bug 7292] new permission for claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au Resolution|--- |WISHLIST Status|Patch doesn't apply |RESOLVED --- Comment #48 from David Cook --- No movement for years and no response to Katrin's question from several years ago (on bug 7290 or bug 7163), so moving to "WISHLIST". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:35:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:35:52 +0000 Subject: [Koha-bugs] [Bug 7163] BibLibre acquisitions omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7163 Bug 7163 depends on bug 7292, which changed state. Bug 7292 Summary: new permission for claims https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WISHLIST -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:39:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:39:20 +0000 Subject: [Koha-bugs] [Bug 5145] Show call number for available item in XSLT availability information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5145 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- I think that syspref OpacItemLocation takes care of all of this now -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 05:47:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 03:47:44 +0000 Subject: [Koha-bugs] [Bug 4855] Tools/Export does not tell browser file size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4855 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- Yeah, this is a tough one. As Andreas suggests, it's impossible to output the Content-Length unless it fetches the entire data dump first, and then sends it out. For a large database, you're not going to be able to do that in RAM, so you're going to need to use a temporary file. The tools/export.pl is actually problematic in general (see Bug 26791). If we wanted to use a temporary file instead of streaming out the response record by record, then we'd be best off using a BackgroundJob to prepare the file (although then you have potential issues with disk space for large data dumps). (For a large file it would be more efficient to have Apache httpd serve it as a static file than for Starman, but then you wouldn't have authentication and authorization protecting the file if you serve it using Apache httpd. So we'd probably still use Starman, but we'd need to make sure it was using either a CGI script or a Mojolicious controller and not Plack since CGI::Emulate::PSGI buffers the entire HTTP response before sending it out) But it's something on my mind 😅 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 07:31:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 05:31:06 +0000 Subject: [Koha-bugs] [Bug 6936] Allow to limit on multiple itemtypes when exporting bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6936 --- Comment #12 from David Cook --- (In reply to Katrin Fischer from comment #11) > Always amazing to see one of those old 4 digit bugs resolved! Agreed! I did a bit of bug wrangling this morning, and it looks like we have about 500 open bugs with 3-4 digit IDs. (I was surprised that there are still 6 bugs with 3 digit IDs!) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 07:39:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 05:39:47 +0000 Subject: [Koha-bugs] [Bug 4330] Copyright statements out of date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4330 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #48 from David Cook --- (In reply to Owen Leonard from comment #47) > Should this bug remain open and assigned? I notice we still have a copyright line in https://wiki.koha-community.org/wiki/Coding_Guidelines#Licence but I don't think that we're actually adding it anymore... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 07:41:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 05:41:48 +0000 Subject: [Koha-bugs] [Bug 4283] Merge bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4283 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Patch doesn't apply |RESOLVED --- Comment #7 from David Cook --- Unless someone can correct me, I'm marking this as duplicate of bug 8064 since we can merge bib records in Koha... *** This bug has been marked as a duplicate of bug 8064 *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 07:41:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 05:41:48 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwagner at ptfs.com --- Comment #90 from David Cook --- *** Bug 4283 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 07:48:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 05:48:50 +0000 Subject: [Koha-bugs] [Bug 4042] Public OPAC search can fall prey to web crawlers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4042 --- Comment #13 from David Cook --- (In reply to Katrin Fischer from comment #4) > Should we include a default/sample robots.txt with Koha? It is tempting to add a robots.txt file to the koha-common package. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 07:50:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 05:50:27 +0000 Subject: [Koha-bugs] [Bug 3831] Fast Add Framework Should not be Deletable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3831 --- Comment #11 from David Cook --- (In reply to Kyle M Hall from comment #8) > I'm not entirely sure this is a good idea. Can anyone demonstrate an actual > error caused by not having the fast cataloging framework? I've found if I > delete it, and check out a nonexistant barcode, the fast cataloging link > will take me to the marc editor with a blank page, where I can choose a > different framework. > > Would it not be better to handle the case where there is no FA framework > installed instead? That's a good point. Maybe it is best to just warn that the framework is missing. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 07:53:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 05:53:19 +0000 Subject: [Koha-bugs] [Bug 3296] replace sessionlog with Perl4Log implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3296 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- It looks like /tmp/sessionlog isn't used anymore, and Log4Perl has slowly been gaining traction over the past few years. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 07:54:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 05:54:54 +0000 Subject: [Koha-bugs] [Bug 3194] Hide records in the OPAC if all items are lost and "hidelostitems" is on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3194 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |dcook at prosentient.com.au Resolution|--- |WONTFIX --- Comment #3 from David Cook --- I think Katrin's comment satisfies the enhancement request. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 07:57:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 05:57:38 +0000 Subject: [Koha-bugs] [Bug 10112] add test for ./debian/control file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #14 from David Cook --- Is this something you still want to do, Mason, or should we close this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 08:02:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 06:02:05 +0000 Subject: [Koha-bugs] [Bug 1091] Do a second search with shorter terms if there are no results found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1091 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31213 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 08:02:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 06:02:05 +0000 Subject: [Koha-bugs] [Bug 31213] When performing a basic search with no results, repeat the search with term quoted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=1091 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 08:10:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 06:10:29 +0000 Subject: [Koha-bugs] [Bug 8619] Remove hidelostitems syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8619 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #5 from David Cook --- It turns out there's another feature called "hidelostitems" that is defined per category code (in a bizarre way), which makes it harder to unpick the syspref "hidelostitems". In Koha/SearchEngine/Zebra/QueryBuilder.pm, it looks like "hidelostitems" used to be used with Zebra, but now I think it works outside of Zebra, and in Koha/Items.pm, "hidelostitems" is calculated in the "filter_by_visible_in_opac" function right after OpacHiddenItems anyway... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 08:13:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 06:13:25 +0000 Subject: [Koha-bugs] [Bug 8460] Improve error messages in OPAC with more information to be sent to the administrator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8460 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- This could be an interesting feature for logged in users (especially in the staff interface). I wouldn't want to do it for public users though, as I could imagine bots sending all kinds of fun messages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 08:15:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 06:15:55 +0000 Subject: [Koha-bugs] [Bug 7163] BibLibre acquisitions omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7163 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WISHLIST |FIXED --- Comment #3 from Katrin Fischer --- The remaining bugs in the graph are very general, I think we can close. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 08:17:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 06:17:23 +0000 Subject: [Koha-bugs] [Bug 7292] new permission for claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WISHLIST |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 08:17:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 06:17:23 +0000 Subject: [Koha-bugs] [Bug 7163] BibLibre acquisitions omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7163 Bug 7163 depends on bug 7292, which changed state. Bug 7292 Summary: new permission for claims https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WISHLIST |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 08:17:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 06:17:30 +0000 Subject: [Koha-bugs] [Bug 7292] new permission for claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 08:17:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 06:17:57 +0000 Subject: [Koha-bugs] [Bug 7292] new permission for claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 --- Comment #49 from Katrin Fischer --- I'd still like to have this - but resetting to new as we probably need to start fresh. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 08:20:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 06:20:26 +0000 Subject: [Koha-bugs] [Bug 8881] Tool to purge action logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8881 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- "misc/cronjobs/cleanup_database.pl" can already do this. However, it could be interesting to have a BackgroundJob in the staff interface that lets a library admin delete old action logs. Seems like it's more of a job for a lower level sysadmin though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 08:22:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 06:22:46 +0000 Subject: [Koha-bugs] [Bug 8589] Advanced Search for itemtype and location produces some results that are not useful In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8589 --- Comment #4 from Katrin Fischer --- (In reply to David Cook from comment #3) > Is this still an issue? Yes, because items are not treated individually in search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 08:27:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 06:27:30 +0000 Subject: [Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31378 CC| |dcook at prosentient.com.au --- Comment #71 from David Cook --- (In reply to Katrin Fischer from comment #70) > Supporting multiple LDAP just came up here recently in a discussion about > features that would be useful - maybe we should leave this open - even if > the code is not ready for integration, it's still an enhancement request. We > could reset it to 'NEW' maybe? Hopefully bug 31378 could pave a path to making it easier to add multiple LDAP providers. I don't think I have any Koha clients using LDAP but it's not particularly complicated. With LDAP you get back a directory record, with OIDC you get a list of claims, with SAML you get a list of attributes. They're all amenable to the same type of mapping mechanism. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 08:27:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 06:27:30 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8993 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 08:27:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 06:27:55 +0000 Subject: [Koha-bugs] [Bug 9936] SIP2 should work with LDAP and CAS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9936 --- Comment #4 from Katrin Fischer --- (In reply to David Cook from comment #3) > Is this still valid? > > Looking at "C4/SIP/ILS/Patron.pm" and it looks like it uses "checkpw()" > which looks like it will check LDAP. > > I'm not familiar with CAS but it looks like its more SSO rather than > directory lookup like LDAP so don't know that it would ever work in this > context. CAS is for authentication, like LDAP or Shibboleth. Some libraries ask for the password at the self checks to avoid abuse of lost cards. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 08:32:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 06:32:57 +0000 Subject: [Koha-bugs] [Bug 8618] Don't copy CCL queries into Z39.50 search form when using button from search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8618 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #3 from David Cook --- It's really not that big of a deal, so I'm going to close this one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 08:34:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 06:34:35 +0000 Subject: [Koha-bugs] [Bug 8305] Add an icon for iOS home screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8305 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #5 from David Cook --- (In reply to Marcel de Rooy from comment #4) > Looks like this is still actual. Safari gets a 404 on favicon. It does not > look at our regular link rel icon line. > Couldnt we just add a link rel apple touch line and point them to our > regular favicons ? Or is that too simple ? As I was reading through the comments, I was thinking that makes sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 08:37:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 06:37:38 +0000 Subject: [Koha-bugs] [Bug 9936] SIP2 should work with LDAP and CAS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9936 --- Comment #5 from David Cook --- (In reply to Katrin Fischer from comment #4) > (In reply to David Cook from comment #3) > > Is this still valid? > > > > Looking at "C4/SIP/ILS/Patron.pm" and it looks like it uses "checkpw()" > > which looks like it will check LDAP. > > > > I'm not familiar with CAS but it looks like its more SSO rather than > > directory lookup like LDAP so don't know that it would ever work in this > > context. > > CAS is for authentication, like LDAP or Shibboleth. Some libraries ask for > the password at the self checks to avoid abuse of lost cards. LDAP and Shibboleth/SAML are totally different though. I'm not familiar with CAS, but I imagine it probably works similar to SAML and OIDC in that it requires browser redirection, which needs to happen client-side. LDAP, on the other hand, happens all server-side. So LDAP is easy to do on a SIP server, but you couldn't do SAML/OIDC (and maybe CAS) on the SIP server. Alex and I have been talking about SAML for the self checkout at bug 30444. It gets complicated... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 08:38:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 06:38:51 +0000 Subject: [Koha-bugs] [Bug 9936] SIP2 should work with LDAP and CAS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9936 --- Comment #6 from David Cook --- Looking at this spring implementation of CAS, it looks like it works similar to SAML and OIDC as I said in regard to the browser redirection: https://docs.spring.io/spring-security/site/docs/3.1.4.RELEASE/reference/cas.html -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 08:39:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 06:39:45 +0000 Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 --- Comment #66 from Marcel de Rooy --- (In reply to Victor Grousset/tuxayo from comment #65) > (In reply to Nick Clemens from comment #52) > > [...] > > > > This is so much faster though, and when it works, it works as it did > > previously > > Out of curiosity about how BackgroundJob works, how does it makes the > process faster? Just an educated guess: using Plack now ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 08:39:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 06:39:49 +0000 Subject: [Koha-bugs] [Bug 9936] SIP2 should work with LDAP and CAS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9936 --- Comment #7 from David Cook --- (In reply to David Cook from comment #6) > Looking at this spring implementation of CAS, it looks like it works similar > to SAML and OIDC as I said in regard to the browser redirection: > https://docs.spring.io/spring-security/site/docs/3.1.4.RELEASE/reference/cas. > html So technically I think it's impossible for the SIP server to use CAS. But adding CAS auth to self-checkout interface could be interesting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 08:40:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 06:40:22 +0000 Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 --- Comment #67 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #66) > (In reply to Victor Grousset/tuxayo from comment #65) > > (In reply to Nick Clemens from comment #52) > > > [...] > > > > > > This is so much faster though, and when it works, it works as it did > > > previously > > > > Out of curiosity about how BackgroundJob works, how does it makes the > > process faster? > > Just an educated guess: using Plack now ? And worker still in memory? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 08:41:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 06:41:22 +0000 Subject: [Koha-bugs] [Bug 31213] When performing a basic search with no results, repeat the search with term quoted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #9 from David Cook --- This sounds so hacky but if it works... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 08:44:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 06:44:31 +0000 Subject: [Koha-bugs] [Bug 8589] Advanced Search for itemtype and location produces some results that are not useful In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8589 --- Comment #5 from David Cook --- (In reply to Katrin Fischer from comment #4) > (In reply to David Cook from comment #3) > > Is this still an issue? > > Yes, because items are not treated individually in search. What I should've said is that I don't understand the problem. Although as I write that out... I think that I understand now. The problem is that one item fulfils one criterium of the search query and a different item fulfils another criterium of the search query, so overall the search query gets the hit, but the hit doesn't include an item that fulfils all the criteria. Yeah that's interesting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 08:45:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 06:45:46 +0000 Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 --- Comment #68 from David Cook --- I suppose the lack of polling would also make it a faster experience overall. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 09:06:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 07:06:31 +0000 Subject: [Koha-bugs] [Bug 31348] Plack stop should be graceful In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31348 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 09:06:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 07:06:34 +0000 Subject: [Koha-bugs] [Bug 31348] Plack stop should be graceful In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31348 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139525|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 139566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139566&action=edit Bug 31348: Make koha-plack stop gracefully 0. Apply patch 1. cp /usr/sbin/koha-plack /usr/sbin/koha-plack.bak 2. cp debian/scripts/koha-plack /usr/sbin/koha-plack 3. Now at roughly the same time do the following two actions: 3a. Go to http://localhost:8081/cgi-bin/koha/about.pl 3b. koha-plack --stop kohadev 4. Note that the HTTP request completes 5. Click on "Home" 6. Note that the error is "Service Unavailable" rather than "Proxy Error", which would've occurred with an interrupted HTTP request/response Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 09:09:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 07:09:13 +0000 Subject: [Koha-bugs] [Bug 31348] Plack stop should be graceful In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31348 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl, | |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #6 from Marcel de Rooy --- Why did you wait so long with this patch, David ? :) I would be tempted to classify it as a bug btw. And backport? Tomas: What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 09:13:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 07:13:42 +0000 Subject: [Koha-bugs] [Bug 31435] New: "Configure this table" appears for non-configurable tables Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Bug ID: 31435 Summary: "Configure this table" appears for non-configurable tables Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: katrin.fischer at bsz-bw.de, oleonard at myacpl.org, testopia at bugs.koha-community.org Depends on: 29723, 31428 I missed something during QA of bug 29723. It appears that the button will appear regardless of whether table_settings is passed into the KohaTable/kohaTable instantiator. This is a bug and the button leads to a server error. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 [Bug 29723] Add a "Configure table" button for KohaTable tables https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31428 [Bug 31428] Shorten new button text "Configure this table" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 09:13:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 07:13:42 +0000 Subject: [Koha-bugs] [Bug 29723] Add a "Configure table" button for KohaTable tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31435 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 [Bug 31435] "Configure this table" appears for non-configurable tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 09:13:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 07:13:42 +0000 Subject: [Koha-bugs] [Bug 31428] Shorten new button text "Configure this table" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31428 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31435 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 [Bug 31435] "Configure this table" appears for non-configurable tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 09:13:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 07:13:55 +0000 Subject: [Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|31428 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31428 [Bug 31428] Shorten new button text "Configure this table" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 09:13:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 07:13:55 +0000 Subject: [Koha-bugs] [Bug 31428] Shorten new button text "Configure this table" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31428 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31435 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 [Bug 31435] "Configure this table" appears for non-configurable tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 09:14:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 07:14:36 +0000 Subject: [Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 --- Comment #1 from Martin Renvoize --- Spotted by Owen when testing bug 31028 * I get an error in the browser console when I click "Configure" on the datatable on the catalog concerns page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 09:17:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 07:17:23 +0000 Subject: [Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 --- Comment #2 from Martin Renvoize --- Created attachment 139567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139567&action=edit Bug 31435: Tie 'Configure' to table_settings This patch adds a check for table_settings to prevent the display of 'Configure this table' when table settings are not passed to the datatable wrapper. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 09:17:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 07:17:34 +0000 Subject: [Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 09:17:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 07:17:41 +0000 Subject: [Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 09:18:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 07:18:03 +0000 Subject: [Koha-bugs] [Bug 31428] Shorten new button text "Configure this table" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31428 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |martin.renvoize at ptfs-europe | |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 09:18:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 07:18:50 +0000 Subject: [Koha-bugs] [Bug 31254] Add additional fields for accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31254 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Julian Maurice --- (In reply to Emmanuel Bétemps from comment #2) > Created attachment 138370 [details] > Make a payment > > Steps 1 to 5 are ok (I see the credits / debits fileds I created) > > At step 6, I don't see any Credit fields as I saw them at steps 4-5 > Maybe I don't look at the right place ? (screenshot taken) Sorry, it wasn't very clear. Additional fields are not supposed to be on this page. You need to click "Pay" or "Write off" to see them -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 09:19:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 07:19:31 +0000 Subject: [Koha-bugs] [Bug 31428] Shorten new button text "Configure this table" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31428 --- Comment #1 from Martin Renvoize --- Created attachment 139568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139568&action=edit Bug 31428: 'Configure this table' -> 'Configure' I agree, the shorter wording should be used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 09:21:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 07:21:47 +0000 Subject: [Koha-bugs] [Bug 31428] Shorten new button text "Configure this table" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31428 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139568|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 139569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139569&action=edit Bug 31428: 'Configure this table' -> 'Configure' I agree, the shorter wording should be used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 09:22:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 07:22:10 +0000 Subject: [Koha-bugs] [Bug 31428] Shorten new button text "Configure this table" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31428 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 09:23:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 07:23:51 +0000 Subject: [Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139567|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 139570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139570&action=edit Bug 31435: Tie 'Configure' to table_settings This patch adds a check for table_settings to prevent the display of 'Configure this table' when table settings are not passed to the datatable wrapper. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 09:40:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 07:40:57 +0000 Subject: [Koha-bugs] [Bug 9936] SIP2 should work with LDAP and CAS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9936 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #8 from Katrin Fischer --- You have a good point, it does require redirection. So for libraries using CAS at the moment it won't be possible to require login at the self check, unless the self check provider implements this in their software. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 09:43:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 07:43:40 +0000 Subject: [Koha-bugs] [Bug 8589] Advanced Search for itemtype and location produces some results that are not useful In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8589 --- Comment #6 from Katrin Fischer --- (In reply to David Cook from comment #5) > (In reply to Katrin Fischer from comment #4) > > (In reply to David Cook from comment #3) > > > Is this still an issue? > > > > Yes, because items are not treated individually in search. > > What I should've said is that I don't understand the problem. > > Although as I write that out... I think that I understand now. The problem > is that one item fulfils one criterium of the search query and a different > item fulfils another criterium of the search query, so overall the search > query gets the hit, but the hit doesn't include an item that fulfils all the > criteria. > > Yeah that's interesting. Yep, that's it :) I've often struggled to explain why that is to users as well. The item search is exact, but for the catalog search (doesn't matter if Zebra or Elastic) this is an unresolved issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 09:45:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 07:45:58 +0000 Subject: [Koha-bugs] [Bug 31213] When performing a basic search with no results, repeat the search with term quoted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213 --- Comment #10 from Katrin Fischer --- (In reply to David Cook from comment #9) > This sounds so hacky but if it works... We often have libraries with callnumbers containing special characters (most of our libraries use custom classifications) like ( ) [] etc. that make an unquoted search return nothing. So I think this will prove helpful. Quoting right away would take the ability to truncate etc. away, but as a second step it makes sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 09:46:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 07:46:19 +0000 Subject: [Koha-bugs] [Bug 21366] Add Plack reload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #23 from Marcel de Rooy --- Reading this on CPAN: Sending HUP signal to the master process will restart all the workers gracefully (meaning the currently running requests will shut down once the request is complete), and by default, the workers will pick up the code changes you make by reloading the application. If you enable --preload-app option, however, the code will be only loaded in the startup process and will not pick up the code changes you made. If you want to preload the app and do graceful restarts by reloading the code changes, you're recommended to use Server::Starter, configured to send QUIT signal when superdaemon received HUP ... [End of quote] While testing with about and inserting a small code change, I notice that while I started the about web request before the plack reload, the code change already is visible in the web request. I think that this is not what we want here ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 10:25:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 08:25:39 +0000 Subject: [Koha-bugs] [Bug 31250] Don't remove advanced/basic cataloging editor cookie on logout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31250 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139389|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy --- Created attachment 139571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139571&action=edit Bug 31250: (QA follow-up) The future will be easier As requested by Jonathan, we need more flexibility ;) Here it comes. Test plan: Run t/CookieManager.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 12:13:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 10:13:12 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139222|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize --- Created attachment 139572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139572&action=edit Bug 31028: Add catalog_concerns table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 12:13:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 10:13:16 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139223|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize --- Created attachment 139573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139573&action=edit Bug 31028: DBIC Schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 12:13:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 10:13:19 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139224|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize --- Created attachment 139574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139574&action=edit Bug 31028: Add `CatalogConcerns` and `OpacCatalogConcerns` preferences This patch adds the `CatalogConcerns` and `OpacCatalogeConcerns` system preferences to enable/disable the catalog concerns feature on the OPAC and Staff client interfaces. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 12:13:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 10:13:23 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139225|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize --- Created attachment 139575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139575&action=edit Bug 31028: Add catalog concerns endpoints This patch adds the staff accessible REST API endpoints for catalog concerns. New endpoints available: * POST /catalog/concerns * GET /catalog/concerns * GET /catalog/concerns/{concern_id} * PUT /catalog/concerns/{concern_id} * DELETE /catalog/concenrs/{concern_id} -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 12:13:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 10:13:27 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139226|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize --- Created attachment 139576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139576&action=edit Bug 31028: Add relations to Catalog::Concern This patch adds the reporter, resolver and biblio relations to the Catalog::Concern class and exposes them to the API as appropriate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 12:13:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 10:13:32 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139227|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize --- Created attachment 139577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139577&action=edit Bug 31028: Add Public API endpoint -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 12:13:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 10:13:35 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139228|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize --- Created attachment 139578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139578&action=edit Bug 31028: Add 'Report a concern' to OPAC details This patch adds a new 'Report a concern' option to the right sidebar on the opac detail page. On clicking the link, a modal will display allowing the user to enter a short message regarding their concerns and then submission will record said message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 12:13:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 10:13:39 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139229|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize --- Created attachment 139579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139579&action=edit Bug 31028: Trigger login modal when not logged in This isn't perfect, we detect if there is a logged in user on the OPAC and replace the concern report modal with the login modal if we don't find a valid session. Unfortunelty, we can't then trigger a redirect back to the record details as that's not how our get_template_and_user authentication system works.. instead we end up back at opac-user.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 12:13:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 10:13:44 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139230|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize --- Created attachment 139580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139580&action=edit Bug 31028: Tie OPAC display to logged in state This is an alternative to th previous patch.. we can't easily redirect back to the right location after login from our modal. It would be preferable to display the button and prompt a login if we don't have a valid session.. but that's not trivial using the API's and our login flows at the moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 12:13:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 10:13:48 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139231|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize --- Created attachment 139581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139581&action=edit Bug 31028: Add a catalog concerns management page This patch adds a new cataloguing concerns page to the staff client for managing reported catalog concerns. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 12:13:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 10:13:52 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139232|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize --- Created attachment 139582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139582&action=edit Bug 31028: Add 'special:undefined' to handle passing 'null' We can't pass 'null' to the column.search as it gets stringified. This patch adds a special string 'special:undefined' to denote that we want to search on undef for the field in question. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 12:13:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 10:13:56 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139233|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize --- Created attachment 139583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139583&action=edit Bug 31028: Add filters to concerns management -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 12:14:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 10:14:00 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139234|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize --- Created attachment 139584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139584&action=edit Bug 31028: Add resolution endpoint This patch adds a /resolve endpoint to the catalog concerns endpoints. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 12:14:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 10:14:04 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139235|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize --- Created attachment 139585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139585&action=edit Bug 31028: Add resolve action This patch adds a resolution workflow to the catalog concerns management page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 12:14:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 10:14:08 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139236|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize --- Created attachment 139586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139586&action=edit Bug 31028: Add 'Add catalog concern' to cataloguing toolbar This patch moves the add concern modal js and template markup into their own files and then references them to add the 'Add concern' option to the cataloguing toolbar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 12:14:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 10:14:12 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139237|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize --- Created attachment 139587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139587&action=edit Bug 31028: Add notice trigger for catalog concerns This patch adds a new system prefernce, `CatalogerEmails`. If set with a valid email address adding a new catalog concern should produce a notification email sent to that address. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 12:14:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 10:14:16 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139238|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize --- Created attachment 139588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139588&action=edit Bug 31028: Add trigger and notice to resolve This patch adds a sample notice and sets up the trigger to notify the concern reporter when a concern is marked as resolved. The notification itself is optional at resolve time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 12:14:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 10:14:21 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #40 from Martin Renvoize --- Created attachment 139589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139589&action=edit Bug 31028: (QA follow-up) This is a 'tool' At the moment, this feature is accessible under tools only rather than cataloging. Whilst we await the new cataloging homepage and sidebar this path replaces the breadcrumb with 'Tools' and removes the 'cat-menu' include. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 12:14:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 10:14:25 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #41 from Martin Renvoize --- Created attachment 139590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139590&action=edit Bug 31028: (QA follow-up) Table configuration This patch properly adds the table configuration options to the catalog concerns table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 12:14:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 10:14:28 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #42 from Martin Renvoize --- Created attachment 139591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139591&action=edit Bug 31028: Use additional_contents for help block This patch updates the modal to use the additional_contents system for the modals help block -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 12:15:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 10:15:17 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 12:23:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 10:23:52 +0000 Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 --- Comment #69 from Nick Clemens --- (In reply to Marcel de Rooy from comment #66) > (In reply to Victor Grousset/tuxayo from comment #65) > > (In reply to Nick Clemens from comment #52) > > > [...] > > > > > > This is so much faster though, and when it works, it works as it did > > > previously > > > > Out of curiosity about how BackgroundJob works, how does it makes the > > process faster? > > Just an educated guess: using Plack now ? +1, that's what i guessed made it better -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 12:45:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 10:45:44 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #43 from Martin Renvoize --- Thanks for testing Owen.. I think that should deal with all but one of your pieces of feedback.. the final one as noted I think should be on it's own bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 13:19:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 11:19:24 +0000 Subject: [Koha-bugs] [Bug 31436] New: AllowRenewalIfOtherItemsAvailable should not take frozen holds into account Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31436 Bug ID: 31436 Summary: AllowRenewalIfOtherItemsAvailable should not take frozen holds into account Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If AllowRenewalIfOtherItemsAvailable is enabled, Koha checks to make sure all other holds are fillable before renewing. It doesn't make sense to look at frozen holds for this reason, as they are by definition, unfillable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 13:19:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 11:19:39 +0000 Subject: [Koha-bugs] [Bug 31436] AllowRenewalIfOtherItemsAvailable should not take frozen holds into account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31436 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31112 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 13:19:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 11:19:39 +0000 Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31436 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31436 [Bug 31436] AllowRenewalIfOtherItemsAvailable should not take frozen holds into account -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 13:20:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 11:20:25 +0000 Subject: [Koha-bugs] [Bug 31436] AllowRenewalIfOtherItemsAvailable should not take suspended holds into account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31436 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|AllowRenewalIfOtherItemsAva |AllowRenewalIfOtherItemsAva |ilable should not take |ilable should not take |frozen holds into account |suspended holds into | |account -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 13:22:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 11:22:24 +0000 Subject: [Koha-bugs] [Bug 31436] AllowRenewalIfOtherItemsAvailable should not take suspended holds into account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31436 --- Comment #1 from Kyle M Hall --- Created attachment 139592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139592&action=edit Bug 31436: AllowRenewalIfOtherItemsAvailable should not take suspended holds into account If AllowRenewalIfOtherItemsAvailable is enabled, Koha checks to make sure all other holds are fillable before renewing. It doesn't make sense to look at suspended holds for this reason, as they are by definition, unfillable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 13:22:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 11:22:36 +0000 Subject: [Koha-bugs] [Bug 31436] AllowRenewalIfOtherItemsAvailable should not take suspended holds into account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31436 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 14:41:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 12:41:40 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #25 from Martin Renvoize --- Created attachment 139593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139593&action=edit Bug 31162: Remove duplicates from tools-home This patch removes cataloging tools from the tools-home page where they are now listed on the cataloging home page. This leaves just two options in the 'Cataloging' section of the tools home page, 'Rotating collections' and 'Upload local cover images'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 14:43:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 12:43:18 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #26 from Martin Renvoize --- As suggested by David, I've now removed the duplicate items from the tools-home page. It leaves use with two tools still under the 'Cataloging' heading in the tools-home. I'm not sure where 'Rotating collections' should live, 'Circulation' under tools perhaps.. or part of the new 'Cataloging' home page? I think we can probably move 'Upload local cover images' to the new 'Cataloging' home page though.. do you agree? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 14:44:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 12:44:03 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138797|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize --- Created attachment 139594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139594&action=edit Bug 31162: Add a cataloging module home page This patch adds a new cataloging-home template and controller and replaces most cases of links to addbooks. This servers to provide a new cataloging home page for the cataloging module and keeps it distinct from the current addbooks page it partially replaces as a stating point for cataloging. Signed-off-by: KIT Signed-off-by: Emmanuel Bétemps -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 14:44:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 12:44:07 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138798|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize --- Created attachment 139595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139595&action=edit Bug 31162: Remove toolbar This patch removes the existing toolbar with 'New record' and 'New from Z39.50/SRU' and replaces the functionality with simple buttons on the page. We lose the ability to select the Framework or Z39.50/SRU server at this stage but one can still select these options from the resulting dialogues. Signed-off-by: Emmanuel Bétemps -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 14:44:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 12:44:12 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #29 from Martin Renvoize --- Created attachment 139596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139596&action=edit Bug 31162: (follow-up) 3 Column layout This patch converts to a 3 column layout as suggested by David. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 14:44:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 12:44:16 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139593|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize --- Created attachment 139597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139597&action=edit Bug 31162: Remove duplicates from tools-home This patch removes cataloging tools from the tools-home page where they are now listed on the cataloging home page. This leaves just two options in the 'Cataloging' section of the tools home page, 'Rotating collections' and 'Upload local cover images'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 14:46:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 12:46:20 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138799|Screenshot |Screenshot - 4 Column description| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 14:46:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 12:46:47 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #31 from Martin Renvoize --- Created attachment 139598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139598&action=edit Screenshot - 3 Column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 15:36:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 13:36:02 +0000 Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #14 from Kyle M Hall --- prove t/db_dependent/Holds.t t/db_dependent/Holds.t .. 69/75 # Failed test 'Can renew' # at t/db_dependent/Holds.t line 1528. # Failed test 'Item is on non priority hold' # at t/db_dependent/Holds.t line 1529. # got: 'on_reserve' # expected: undef # Looks like you failed 2 tests of 6. t/db_dependent/Holds.t .. 71/75 # Failed test 'non priority holds' # at t/db_dependent/Holds.t line 1556. t/db_dependent/Holds.t .. 75/75 # Looks like you failed 1 test of 75. t/db_dependent/Holds.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/75 subtests Test Summary Report ------------------- t/db_dependent/Holds.t (Wstat: 256 Tests: 75 Failed: 1) Failed test: 71 Non-zero exit status: 1 Files=1, Tests=75, 7 wallclock secs ( 0.03 usr 0.01 sys + 5.04 cusr 0.68 csys = 5.76 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 15:36:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 13:36:43 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139378|0 |1 is obsolete| | --- Comment #301 from Shi Yao Wang --- Created attachment 139599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139599&action=edit Bug 17015: Performance comparison (images) Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 15:36:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 13:36:52 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139379|0 |1 is obsolete| | --- Comment #302 from Shi Yao Wang --- Created attachment 139600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139600&action=edit Bug 17015: Install scripts for DiscreteCalendar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 15:37:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 13:37:00 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139380|0 |1 is obsolete| | --- Comment #303 from Shi Yao Wang --- Created attachment 139601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139601&action=edit Bug 17015: Schema file for new discrete_calendar table Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 15:37:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 13:37:09 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139381|0 |1 is obsolete| | --- Comment #304 from Shi Yao Wang --- Created attachment 139602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139602&action=edit Bug 17015: DiscreteCalendar UI, Back-End and necessary scripts Signed-off-by: Michal Denar Bug 17015: When using book drop mode, set check in time as closing hours Signed-off-by: Michal Denar Bug 17015: Automatically update calendar when creating or deleting a branch Signed-off-by: Michal Denar Bug 17015: Rebase and tests for discrete calendar This patch is a rebase of all the previous patches in order to show the discrete calendar. TEST PLAN: 1- Apply the patch 2- Run installer/data/mysql/updatedatabase.pl 3- Run misc/cronjobs/add_days_discrete_calendar.pl 4- Check that the max date is today + 1 day 5- Run t/db_dependent/DiscreteCalendar.t (All tests should pass) Signed-off-by: Michal Denar Bug 17015: DiscreteCalendar->new() method is now in a HASH This patch adds missing curly brackets in all new() calls. All tests in t/ should pass too (The one that don't pass are not passing before the patch) TEST PLAN: 1- Apply the patch 2- Run installer/data/mysql/updatedatabase.pl 3- Run misc/cronjobs/add_days_discrete_calendar.pl 4- Check that the max date is today + 1 day 5- Attempt a checkout ~ The error "Can't use string ("branchcode") as a HASH ref while "strict refs" in use at /kohadevbox/koha/Koha/DiscreteCalendar.pm line 79" is no longer here 5- Run t/db_dependent/DiscreteCalendar.t (prove -l t/db_dependent/DiscreteCalendar.t) 6- Run all koha test in t/ (prove t). All tests should pass 7- Use Discrete Calendar in Tools->Calendar USING THE DISCRETE CALENDAR: 1- New UI a) Calendar on the left b) Holidays list on the right 2- New color system for holiday types: a) Working day : white b) Unique holiday: red c) Holiday repeating weekly: yellow d) Holiday repeating yearly: orange e) Floating holiday: green f) Need validation: blue 3- When clicking on a date in the calendar, opening, closing hours and holiday type are displayed. 4- All the fields are editable 5- New radio button to Edit selected dates or Copy to different dates 6- Option to copy the calendar to another branch Bug 17015: Fixing QA tools failures This patch fixes tests that fails with the QA tool. To test, run the QA tool All tests should say OK except 2 that fails. Bug 17015: Check out with the useDaysMode preference When checking out with useDaysMode preference set to "Use the calendar to push the due date to the next open day", an error 500 appears. This patch fixes this error. To test: 1. Go in Administration->useDaysMode 2. Set this preference t0 "Use the calendar to push the due date to the next open day" 3. Make sure you have a patron and a item (note the patron's category and the item's type) 4. Make sure you have a circulation rule with the patron's category and the item type in step 3 5. Attempt a checkout 6. An error 500 appears 7. Apply the patch 8. The error is no longer there -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 15:37:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 13:37:20 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139382|0 |1 is obsolete| | --- Comment #305 from Shi Yao Wang --- Created attachment 139603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139603&action=edit Bug 17015: Tests for DiscreteCalendar Signed-off-by: Michal Denar Bug 17015: Rebase and tests for discrete calendar This patch is a rebase of all the previous patches in order to show the discrete calendar. TEST PLAN: 1- Apply the patch 2- Run installer/data/mysql/updatedatabase.pl 3- Run misc/cronjobs/add_days_discrete_calendar.pl 4- Check that the max date is today + 1 day 5- Run t/db_dependent/DiscreteCalendar.t (All tests should pass) Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 16:03:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 14:03:12 +0000 Subject: [Koha-bugs] [Bug 28208] ModItemTransfer no longer updates item.datelastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28208 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 16:15:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 14:15:25 +0000 Subject: [Koha-bugs] [Bug 31254] Add additional fields for accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31254 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138207|0 |1 is obsolete| | --- Comment #4 from sandboxes at biblibre.com --- Created attachment 139604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139604&action=edit Bug 31254: Add additional fields for accountlines Test plan: 1. Go to Admin » Additional fields There are two new categories: "Account lines (credit)" and "Account lines (debit)" 2. Create fields for both categories, with and without an authorized value category 3. Go to a user's accounting page 4. Create a manual invoice. Verify that all "debit" fields are there, put a value in them and save 5. Create a manual credit. Verify that all "credit" fields are there, put a value in them and save 6. Make a payment. Verify that all "credit" fields are there, put a value in them and save 7. Go to the transactions tab, click on the "Details" button for the lines you just created and verify that the additional fields are there Signed-off-by: Emmanuel Bétemps -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 16:17:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 14:17:07 +0000 Subject: [Koha-bugs] [Bug 31254] Add additional fields for accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31254 Emmanuel Bétemps changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Emmanuel Bétemps --- thanks, I understood and did as you said it works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 16:20:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 14:20:22 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #114 from Tomás Cohen Arazi --- Created attachment 139605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139605&action=edit Bug 30718: (follow-up) index_records is called more times than we thought Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 16:25:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 14:25:34 +0000 Subject: [Koha-bugs] [Bug 31437] New: ModItemTransfer triggers indexing twice Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31437 Bug ID: 31437 Summary: ModItemTransfer triggers indexing twice Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org After 30718 ModItemTransfer leads to two calls on index_records. I bisected it down to 48bf9b1d91dbbc336f859ac1a83d7d25b0e6a3c1 but couldn't figure how that change is relevant. My gut feeling is that we were somehow hidding an error and the change to DateTime 'fixed' it. The code clearly yields to two calls to index_records as ->transit calls ModDateLastSeen without passing the skip_record_index flag. I added a follow-up on bug 30718 to fix the tests and expect we make a decision here. This bug could be replaced by bug 25754 as this needs a final refactoring removing it IMHO. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 16:26:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 14:26:41 +0000 Subject: [Koha-bugs] [Bug 31437] ModItemTransfer triggers indexing twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31437 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30718, 24446 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25754 CC| |jonathan.druart+koha at gmail. | |com, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 [Bug 30718] Use flatpickr's altInput option everywhere -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 16:26:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 14:26:41 +0000 Subject: [Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31437 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31437 [Bug 31437] ModItemTransfer triggers indexing twice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 16:26:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 14:26:41 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31437 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31437 [Bug 31437] ModItemTransfer triggers indexing twice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 16:26:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 14:26:41 +0000 Subject: [Koha-bugs] [Bug 25754] Deprecate C4::Items::ModItemTransfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25754 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31437 -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 16:46:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 14:46:14 +0000 Subject: [Koha-bugs] [Bug 29939] Replace opac-ratings-ajax.pl with a new REST API route In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29939 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 16:46:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 14:46:17 +0000 Subject: [Koha-bugs] [Bug 29939] Replace opac-ratings-ajax.pl with a new REST API route In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29939 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 16:46:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 14:46:21 +0000 Subject: [Koha-bugs] [Bug 31352] Terminology: Borrower name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31352 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 16:46:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 14:46:23 +0000 Subject: [Koha-bugs] [Bug 31352] Terminology: Borrower name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31352 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 16:46:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 14:46:27 +0000 Subject: [Koha-bugs] [Bug 31355] Specific item holds table on OPAC only showing 10 items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31355 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 16:46:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 14:46:30 +0000 Subject: [Koha-bugs] [Bug 31355] Specific item holds table on OPAC only showing 10 items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31355 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 16:46:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 14:46:34 +0000 Subject: [Koha-bugs] [Bug 31425] Minor correction to patron categories admin title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31425 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 16:46:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 14:46:39 +0000 Subject: [Koha-bugs] [Bug 31425] Minor correction to patron categories admin title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31425 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 16:53:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 14:53:28 +0000 Subject: [Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 --- Comment #13 from Lucas Gass --- Cait, Thanks for looking at this one. I was unsure when I named the DB column privatenote, I am happy to change it to 'staff_note'. As for the order of where the column lives, I sort of arbitrarily put it where I put it. I will move it to be right before 'Status'? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 16:58:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 14:58:41 +0000 Subject: [Koha-bugs] [Bug 31438] New: Currency can't have "spaces" in currency name Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31438 Bug ID: 31438 Summary: Currency can't have "spaces" in currency name Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: verolencinas at yahoo.com.ar QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When using different currencies with similar names, Koha should advert that you can't add currency names with spaces in them. This result in later not being able to add orders. For example, defining currencies like "PESO ARG", "PESO BOL", "PESO CHILE", etc. result in the mentioned problem to not be able to add orders in the acquisition module. Koha should advert that currency names should be entered without spaces. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 17:30:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 15:30:50 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136058|0 |1 is obsolete| | --- Comment #40 from Lucas Gass --- Created attachment 139606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139606&action=edit Bug 10950: Database update Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 17:30:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 15:30:56 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136059|0 |1 is obsolete| | --- Comment #41 from Lucas Gass --- Created attachment 139607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139607&action=edit Bug 10950: Schema update Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 17:31:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 15:31:01 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136060|0 |1 is obsolete| | --- Comment #42 from Lucas Gass --- Created attachment 139608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139608&action=edit Bug 10950: Add intranet/OPAC form fields Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 17:31:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 15:31:06 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136061|0 |1 is obsolete| | --- Comment #43 from Lucas Gass --- Created attachment 139609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139609&action=edit Bug 10950: Display pronouns field Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 17:31:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 15:31:10 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136062|0 |1 is obsolete| | --- Comment #44 from Lucas Gass --- Created attachment 139610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139610&action=edit Bug 10950: API spec update Test plan: 1. Apply patch, restart_all, and updatedatabase 2. In the staff client go to a patron record or create a new patron. 3. Notice the pronouns field, make sure you add a value to it. 4. Now notice that the value should display in parentheses in places where the patron name is displayed. 5. Go to the details page and you should see the value display in quotes. ( next to othernames ) 6. Check to make sure you can hide the pronouns field via BorrowerUnwantedField. 7. Check to make sure you can make the field required with BorrowerMandatoryField 8. Go to the OPAC to self register. The pronouns field should appear in the form. 9. Make sure you can make it required ( PatronSelfRegistrationBorrowerMandatoryField ) and that you can hide it ( PatronSelfRegistrationBorrowerUnwantedField ). 10. Once registered check 'your personal details'. Check that the field can be required (PatronSelfModificationMandatoryField) or hidden ( PatronSelfModificationBorrowerUnwantedField ). 11. Try some notices like ISSUESLIP. You should be able to add either <> or [% borrower.pronoun %] to the notice and have it display when you generate the notice. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 17:31:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 15:31:15 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136063|0 |1 is obsolete| | --- Comment #45 from Lucas Gass --- Created attachment 139611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139611&action=edit Bug 10950: (follow-up) fix typo in kohastructure.sql Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 17:31:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 15:31:20 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136064|0 |1 is obsolete| | --- Comment #46 from Lucas Gass --- Created attachment 139612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139612&action=edit Bug 10950: (QA follow-up) Exec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 17:32:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 15:32:00 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 17:32:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 15:32:55 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 --- Comment #47 from Lucas Gass --- rebased for current master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 17:54:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 15:54:44 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #48 from Andrew Fuerste-Henry --- I was successful with everything in this test plan except generating a notice. Calling <> worked fine. Using [% borrower.pronoun %] gave me a big angry error: "ERROR PROCESSING TEMPLATE: undef error - The method Koha::Patron->pronoun is not covered by tests!" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 18:12:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 16:12:12 +0000 Subject: [Koha-bugs] [Bug 31439] New: Item count bullet (• ) should be easier to style/remove Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31439 Bug ID: 31439 Summary: Item count bullet (•) should be easier to style/remove Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The staff results page included a bullet (•) that is hard to target. It should be either wrapped in a class or a CSS psuedo element to make it easier to style of remove. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 18:14:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 16:14:45 +0000 Subject: [Koha-bugs] [Bug 29955] Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 139613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139613&action=edit Bug 29955: Fix method import issues This patch fixes this: $ prove t/db_dependent/Utils/Datatables_Virtualshelves.t t/db_dependent/Utils/Datatables_Virtualshelves.t .. 2/13 Use of inherited AUTOLOAD for non-method Koha::Virtualshelf::haspermission() is no longer allowed at /kohadevbox/koha/Koha/Virtualshelf.pm line 248. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 18:19:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 16:19:04 +0000 Subject: [Koha-bugs] [Bug 31321] Remove GetItemsInfo from catalogue/detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31321 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 18:19:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 16:19:06 +0000 Subject: [Koha-bugs] [Bug 31321] Remove GetItemsInfo from catalogue/detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31321 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 18:19:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 16:19:09 +0000 Subject: [Koha-bugs] [Bug 31377] Add basket's internal note to tables on vendor search result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31377 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 18:19:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 16:19:12 +0000 Subject: [Koha-bugs] [Bug 31377] Add basket's internal note to tables on vendor search result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31377 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 18:41:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 16:41:57 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply Depends on| |29955 CC| |tomascohen at gmail.com --- Comment #103 from Tomás Cohen Arazi --- Hi, please rebase. Bug 29955 made a small change that makes the first patch fail to apply. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955 [Bug 29955] Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 18:41:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 16:41:57 +0000 Subject: [Koha-bugs] [Bug 29955] Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15348 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 [Bug 15348] Change/Edit estimated delivery date per order line -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 18:43:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 16:43:09 +0000 Subject: [Koha-bugs] [Bug 6936] Allow to limit on multiple itemtypes when exporting bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6936 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 18:43:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 16:43:12 +0000 Subject: [Koha-bugs] [Bug 6936] Allow to limit on multiple itemtypes when exporting bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6936 --- Comment #13 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 18:43:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 16:43:14 +0000 Subject: [Koha-bugs] [Bug 31348] Plack stop should be graceful In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31348 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 18:43:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 16:43:17 +0000 Subject: [Koha-bugs] [Bug 31348] Plack stop should be graceful In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31348 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 18:43:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 16:43:20 +0000 Subject: [Koha-bugs] [Bug 31387] Marking othernames as required via PatronSelfRegistrationBorrowerMandatoryField does not display required label In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31387 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 18:43:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 16:43:22 +0000 Subject: [Koha-bugs] [Bug 31387] Marking othernames as required via PatronSelfRegistrationBorrowerMandatoryField does not display required label In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31387 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 18:43:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 16:43:25 +0000 Subject: [Koha-bugs] [Bug 31388] Add select2 to fund selection in new order form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31388 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 18:43:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 16:43:27 +0000 Subject: [Koha-bugs] [Bug 31388] Add select2 to fund selection in new order form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31388 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 18:43:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 16:43:29 +0000 Subject: [Koha-bugs] [Bug 31390] Remove noisy warns in C4::Templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31390 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 18:43:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 16:43:32 +0000 Subject: [Koha-bugs] [Bug 31390] Remove noisy warns in C4::Templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31390 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 18:44:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 16:44:28 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #108 from Biblioteca de Asociación Médica --- Greetings to all Koha´s developers: We wanted to ask you how´s everything going out there? Is there a date for this new version to be ready? Also we want to thank you for all your attention that you have given us by mail, you are so efficient and friendly. Congrats!!! Sincerely, Medical Association Library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 18:48:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 16:48:12 +0000 Subject: [Koha-bugs] [Bug 31427] Automatic renewal too_many error is confusing in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427 Jason Robb changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb at sekls.org --- Comment #1 from Jason Robb --- Agree that this is confusing and misleading to the patron. We're seeing a consistent duplication of messages whenever something auto renews, both with digests and one-off messaging thanks to the odd too_many behavior. The too_many error is also getting sent while a title has renewals available. For example, we had a scenario where Book A and Book B both had one renew available. Checkout period was 14 days. No renewal before was set to 0 so that the auto-renew happened on the day the item came due. Book A was due 7/1. Book B was due 7/7. The digested messaging went like this: 7/1 - Book A was renewed, Book B was not renewed (too_many error) 7/2 - Both titles were not renewed (too_many error) 7/7 - Book B was renewed, Book A was not renewed (too_many error) 7/8 - Both titles were not renewed (too_many error) The messages on 7/1 and 7/2 gave Book B the too_many error so it appears like no renewals were available, proven untrue when the title auto-renewed on its due date of 7/7. Ideally the 'too_many' error would only pop when all renewals have been exhausted. Titles that have renewals available but aren't getting renewed yet because they aren't due yet should be handled separately so they can be explained/ignored in the templates. The goal for digested messaging in the above scenario would be something like: 7/1 - Book A was renewed, Book B is not yet eligible for auto renewal 7/7 - Book B was renewed, Book A is no longer eligible for auto renewal (too_many) 7/15 - Book A and Book B are no longer eligible for auto renewal (too_many) 7/21 - Book A and Book B are no longer eligible for auto renewal (too_many) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 18:54:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 16:54:16 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 --- Comment #49 from Lucas Gass --- (In reply to Andrew Fuerste-Henry from comment #48) > I was successful with everything in this test plan except generating a > notice. > Calling <> worked fine. > Using [% borrower.pronoun %] gave me a big angry error: > > "ERROR PROCESSING TEMPLATE: undef error - The method Koha::Patron->pronoun > is not covered by tests!" Andrew, this is my fault. The test plan for step 11 should be: 11. Try some notices like ISSUESLIP. You should be able to add either <> or [% borrower.pronouns %] to the notice and have it display when you generate the notice. It is [% borrower.pronouns %] not [% borrower.pronoun %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 19:05:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 17:05:30 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha::Patron::Debarment |Move |should be updated to follow |Koha::Patron::Debarment |current Koha:: style |into Koha::Object based | |classes CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 19:08:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 17:08:51 +0000 Subject: [Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 19:09:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 17:09:05 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 139614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139614&action=edit Bug 31095: Add Koha::Patron::Restriction(s) Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 19:12:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 17:12:40 +0000 Subject: [Koha-bugs] [Bug 31389] Calculate user permissions in separate function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31389 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 19:13:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 17:13:41 +0000 Subject: [Koha-bugs] [Bug 31373] Notice template validation is missing INCLUDE_PATH In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31373 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 19:14:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 17:14:37 +0000 Subject: [Koha-bugs] [Bug 30016] Remove GetOpenIssue subroutine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30016 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 19:16:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 17:16:31 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139606|0 |1 is obsolete| | --- Comment #50 from ByWater Sandboxes --- Created attachment 139615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139615&action=edit Bug 10950: Database update Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 19:16:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 17:16:35 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139607|0 |1 is obsolete| | --- Comment #51 from ByWater Sandboxes --- Created attachment 139616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139616&action=edit Bug 10950: Schema update Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 19:16:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 17:16:39 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139608|0 |1 is obsolete| | --- Comment #52 from ByWater Sandboxes --- Created attachment 139617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139617&action=edit Bug 10950: Add intranet/OPAC form fields Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 19:16:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 17:16:43 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139609|0 |1 is obsolete| | --- Comment #53 from ByWater Sandboxes --- Created attachment 139618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139618&action=edit Bug 10950: Display pronouns field Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 19:16:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 17:16:47 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139610|0 |1 is obsolete| | --- Comment #54 from ByWater Sandboxes --- Created attachment 139619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139619&action=edit Bug 10950: API spec update Test plan: 1. Apply patch, restart_all, and updatedatabase 2. In the staff client go to a patron record or create a new patron. 3. Notice the pronouns field, make sure you add a value to it. 4. Now notice that the value should display in parentheses in places where the patron name is displayed. 5. Go to the details page and you should see the value display in quotes. ( next to othernames ) 6. Check to make sure you can hide the pronouns field via BorrowerUnwantedField. 7. Check to make sure you can make the field required with BorrowerMandatoryField 8. Go to the OPAC to self register. The pronouns field should appear in the form. 9. Make sure you can make it required ( PatronSelfRegistrationBorrowerMandatoryField ) and that you can hide it ( PatronSelfRegistrationBorrowerUnwantedField ). 10. Once registered check 'your personal details'. Check that the field can be required (PatronSelfModificationMandatoryField) or hidden ( PatronSelfModificationBorrowerUnwantedField ). 11. Try some notices like ISSUESLIP. You should be able to add either <> or [% borrower.pronoun %] to the notice and have it display when you generate the notice. Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 19:16:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 17:16:51 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139611|0 |1 is obsolete| | --- Comment #55 from ByWater Sandboxes --- Created attachment 139620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139620&action=edit Bug 10950: (follow-up) fix typo in kohastructure.sql Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 19:16:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 17:16:55 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139612|0 |1 is obsolete| | --- Comment #56 from ByWater Sandboxes --- Created attachment 139621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139621&action=edit Bug 10950: (QA follow-up) Exec Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 19:18:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 17:18:45 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #57 from Andrew Fuerste-Henry --- Test plan successful once I fixed my notice! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 19:24:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 17:24:36 +0000 Subject: [Koha-bugs] [Bug 31427] Automatic renewal too_many error is confusing in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427 Azucena Aguayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |azucena.aguayo at uvu.edu --- Comment #2 from Azucena Aguayo --- Our library has the same problem. Our patrons get confused with the back to back emails for the same item telling them the item was renewed / not renewed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 19:31:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 17:31:42 +0000 Subject: [Koha-bugs] [Bug 31351] Worker dies on reindex job when operator last name/first name/branch name contains non-ASCII chars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 19:33:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 17:33:20 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 19:35:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 17:35:26 +0000 Subject: [Koha-bugs] [Bug 31254] Add additional fields for accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31254 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 19:36:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 17:36:11 +0000 Subject: [Koha-bugs] [Bug 31417] Re-instate the cataloguing sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31417 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 20:11:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 18:11:05 +0000 Subject: [Koha-bugs] [Bug 23674] Allowing editable notes on all entries in patron Transactions table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Jason Robb changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb at sekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 21:08:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 19:08:56 +0000 Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #15 from Joonas Kylmälä --- Created attachment 139622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139622&action=edit Bug 31112: (follow-up) Bring back the check for non-priority holds Before the changes from bug 31112 when CheckReserves returned a non-priority hold we didn't return "on_reserve" status but checked in addition to that whether there are any priority holds and if there were, only then we returned the "on_reserve" error. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 21:09:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 19:09:00 +0000 Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #16 from Joonas Kylmälä --- Created attachment 139623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139623&action=edit Bug 31112: (follow-up) Don't return "on_reserve" when there are 0 possible holds It's possible that there could be 0 possible reserves, for example when the hold has already been filled, thus the check would fail as the item count can never be less than 0. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 21:10:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 19:10:44 +0000 Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #99 from Shi Yao Wang --- Created attachment 139624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139624&action=edit Bug 27113: (follow-up) replace removed GetMarcBiblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 21:12:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 19:12:17 +0000 Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #17 from Joonas Kylmälä --- Thanks Kyle for spotting the failing test. I fixed the issue by restoring the previous check that I had accidentally removed (btw, the check looks somewhat buggy actually but that's for another bug report). There was also a small issue with the follow-up patch from Nick, added a fix for that too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 21:34:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 19:34:23 +0000 Subject: [Koha-bugs] [Bug 31394] background hold cancellation causing confusion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31394 Cheryl changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman at fargolibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 21:34:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 19:34:32 +0000 Subject: [Koha-bugs] [Bug 27428] Show the number of records in the bibliographic record detail page with ElasticSearch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132068|0 |1 is obsolete| | --- Comment #21 from Shi Yao Wang --- Created attachment 139625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139625&action=edit Bug 27428: Show the number of records in the bibliographic record detail page with ElasticSearch. Tests: 1. Apply this patch; 2. In the Preference system - OPACDisplayRecordCount -> Show; 3. We can see the number of records next to search links in the bibliographic record detail page in the OPAC. Signed-off-by: Stina Hallin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 21:46:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 19:46:25 +0000 Subject: [Koha-bugs] [Bug 27428] Show the number of records in the bibliographic record detail page with ElasticSearch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139625|0 |1 is obsolete| | --- Comment #22 from Shi Yao Wang --- Created attachment 139626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139626&action=edit Bug 27428: Show the number of records in the bibliographic record detail page with ElasticSearch. Tests: 1. Apply this patch; 2. In the Preference system - OPACDisplayRecordCount -> Show; 3. We can see the number of records next to search links in the bibliographic record detail page in the OPAC. Signed-off-by: Stina Hallin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 22:14:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 20:14:39 +0000 Subject: [Koha-bugs] [Bug 31434] Improve display of title information when receiving orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31434 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|mprove display of title |Improve display of title |information when receiving |information when receiving |orders |orders -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 23:13:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 21:13:45 +0000 Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 --- Comment #70 from Victor Grousset/tuxayo --- Thanks all ^^ Oh right, that was one of the few (the only?) things not using Plack. Surprising that this has a big effect on tasks that are long where the time loading Perl and the modules should be a small fraction. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 23:15:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 21:15:00 +0000 Subject: [Koha-bugs] [Bug 27817] Enhance display of title information throughout acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #17 from Barbara Johnson --- In my latest test, I can confirm that I am able to view the 245abhnp on basket.pl, orderreceive.pl and invoice.pl. Only the 245a info is displayed on parcel.pl and I believe bug 31434 is supposed to address that. Also, only the 245a is displayed on ordered.pl - it would be helpful to see the additional info here as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 22 23:16:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 21:16:29 +0000 Subject: [Koha-bugs] [Bug 31434] Improve display of title information when receiving orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31434 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #1 from Barbara Johnson --- +1 Being able to see the additional info about a title that is on order will increase staff efficiency and reduce mistakes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 00:22:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 22:22:16 +0000 Subject: [Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 00:22:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 22:22:19 +0000 Subject: [Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 --- Comment #14 from Lucas Gass --- Created attachment 139627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139627&action=edit Bug 31374: (follow-up) change private note to staff_note and reorder columns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 00:33:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 22:33:21 +0000 Subject: [Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #4 from Lucas Gass --- Is there a test plan? Maybe a list of tables we should check? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 01:26:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 23:26:39 +0000 Subject: [Koha-bugs] [Bug 21366] Add Plack reload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #24 from Victor Grousset/tuxayo --- (In reply to Marcel de Rooy from comment #23) > If you enable --preload-app option, however, the code will be only loaded in the startup process and will not pick up the code changes you made. If you want to preload the app and do graceful restarts by reloading the code changes, you're recommended to use Server::Starter, configured to send QUIT signal when superdaemon received HUP ... > [End of quote] > While testing with about and inserting a small code change, I notice that > while I started the about web request before the plack reload, the code > change already is visible in the web request. > I think that this is not what we want here ? What do you mean? The patch doesn't use --preload-app. I tested changing something in about.pl: once over the ~10 tries the change was reflected only by reloading the page. Otherwise I had to run `pkill starman --signal SIGHUP` to get the change. Your plack_max_requests isn't 1 is it? That would be an explanation of what you observed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 01:31:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 23:31:18 +0000 Subject: [Koha-bugs] [Bug 21366] Add Plack reload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #25 from David Cook --- (In reply to Marcel de Rooy from comment #23) > If you enable --preload-app option, however, the code will be only loaded in > the startup process and will not pick up the code changes you made. If you > want to preload the app and do graceful restarts by reloading the code > changes, you're recommended to use Server::Starter, configured to send QUIT > signal when superdaemon received HUP ... > [End of quote] We don't use --preload-app, so we don't need to worry about it. Even if we did use --preload-app, I think some of the text is misleading. While code changes to code that is preloaded wouldn't come through, changes to code that is lazy loaded after forking the children would still come through. I use mod_perl for a different Perl app where I preload the core Catalyst application into the httpd master process so that slow setup like the ORM just takes place 1 time, and then all the lazy loads for function specific things happen within the child processes. > While testing with about and inserting a small code change, I notice that > while I started the about web request before the plack reload, the code > change already is visible in the web request. > I think that this is not what we want here ? If you want to test a small code change, you'd need to first make sure that all Starman workers have already cached the about.pl page in their CGI to PSGI cache. Once they're cached, then you can make your code change, confirm that the change isn't visible, do the reload, and then note that the change is visible. I chose the about.pl test somewhat arbitrarily because koha-testing-docker is such a small database. In production, where you really see this being useful is in search.pl and opac-search.pl where a search might take 5+ seconds. Using koha-plack --reload will wait for that long search request to complete, and then it will restart that worker. -- Does that answer your questions? I will be online a bit tonight (ie European morning) so might be able to answer more on IRC :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 01:34:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 23:34:43 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #109 from Victor Grousset/tuxayo --- Hi :) There is a new version of Koha every 6 months. On November and May https://koha-community.org/about/release-schedule/ The last 3 major versions are still maintained and get monthly releases. So it's possible that 22.05, 21.11 and 21.05 will get this enhancement. Stay tuned to this ticket to know if that will be the case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 01:38:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 23:38:58 +0000 Subject: [Koha-bugs] [Bug 31213] When performing a basic search with no results, repeat the search with term quoted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213 --- Comment #11 from David Cook --- (In reply to Katrin Fischer from comment #10) > (In reply to David Cook from comment #9) > > This sounds so hacky but if it works... > > We often have libraries with callnumbers containing special characters (most > of our libraries use custom classifications) like ( ) [] etc. that make an > unquoted search return nothing. So I think this will prove helpful. > > Quoting right away would take the ability to truncate etc. away, but as a > second step it makes sense. I'm happy to agree to disagree when it comes to search :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 01:58:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 23:58:45 +0000 Subject: [Koha-bugs] [Bug 30667] Holds reminder cronjob (holds_reminder.pl) never uses default letter template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30667 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to stable |RESOLVED --- Comment #10 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 01:58:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Aug 2022 23:58:46 +0000 Subject: [Koha-bugs] [Bug 30666] Holds reminder cronjob (holds_reminder.pl) uses DateTime::subtract wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30666 Bug 30666 depends on bug 30667, which changed state. Bug 30667 Summary: Holds reminder cronjob (holds_reminder.pl) never uses default letter template https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30667 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 02:00:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 00:00:07 +0000 Subject: [Koha-bugs] [Bug 31220] Error when attempting to export selected labels as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #13 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 02:17:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 00:17:43 +0000 Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138934|0 |1 is obsolete| | --- Comment #36 from Victor Grousset/tuxayo --- Created attachment 139628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139628&action=edit Bug 30847: Cleanup calculation of holds and rank Currently we loop over all the holds on the record to get a count of the reserves not waiting and a rank for the upcoming hold We can simply count the number of nont waiting holds and add 1 Note: Before this patch the count of holds included the new hold we were going to place which meant rank and count were the same. I believe countaing existing holds and our upcoming rank is the correct behavior To test: 1 - Set OPACShowHoldQueueDetails system preference to 'Show holds and their priorty level' 2 - Place a few holds on a bib on the staff side 3 - Mark 1 waiting 4 - Attempt to place hold on the bib on the opac 5 - Note 'Your priority' and 'Number of holds' are the same number 6 - Place another hold, confirm both increase 7 - Set another hold waiting, confirm both decrease 8 - Apply patch 9 - Confirm 'Your priority' is now 1 greater than Number of holds 10 - Place a hold, set a hold waiting, confirm numbers adjust as appropriate Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 02:17:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 00:17:48 +0000 Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138935|0 |1 is obsolete| | --- Comment #37 from Victor Grousset/tuxayo --- Created attachment 139629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139629&action=edit Bug 30847: Remove unused noreserve parameter This is defined but never used To test: 1 - git grep noreserve 2 - only one ocurrence 3 - Apply patch 4 - repeat, no ocurrence 5 - Note the plural has a few uses Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 02:17:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 00:17:54 +0000 Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138936|0 |1 is obsolete| | --- Comment #38 from Victor Grousset/tuxayo --- Created attachment 139630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139630&action=edit Bug 30847: Remove unused OPACShowHoldQueueDetails Search for the variables, they aren't used! Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 02:17:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 00:17:58 +0000 Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138937|0 |1 is obsolete| | --- Comment #39 from Victor Grousset/tuxayo --- Created attachment 139631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139631&action=edit Bug 30847: Don't fetch patron twice Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 02:18:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 00:18:05 +0000 Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138938|0 |1 is obsolete| | --- Comment #40 from Victor Grousset/tuxayo --- Created attachment 139632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139632&action=edit Bug 30847: Avoid fetching biblio object Here the items biblionumber is either equal to the biblionumber passed in or it is not and should be - we can just assign directly from the item in all cases Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 02:18:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 00:18:12 +0000 Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138939|0 |1 is obsolete| | --- Comment #41 from Victor Grousset/tuxayo --- Created attachment 139633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139633&action=edit Bug 30847: Don't declare undef variable for assignment New holds have found set to undef - we can do this directly Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 02:18:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 00:18:18 +0000 Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138940|0 |1 is obsolete| | --- Comment #42 from Victor Grousset/tuxayo --- Created attachment 139634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139634&action=edit Bug 30847: Don't get biblio/item info when placing holds The only bit we get form the hash is the rank and title We can simply fetch the biblio once to calculate no need to fetch all the info as we don't display or use it Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 02:18:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 00:18:25 +0000 Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138941|0 |1 is obsolete| | --- Comment #43 from Victor Grousset/tuxayo --- Created attachment 139635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139635&action=edit Bug 30847: Consolidate code to check if patron can place holds and exit if they cannot This will save us fetching more info if we are denying the holds Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 02:25:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 00:25:35 +0000 Subject: [Koha-bugs] [Bug 8589] Advanced Search for itemtype and location produces some results that are not useful In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8589 --- Comment #7 from David Cook --- (In reply to Katrin Fischer from comment #6) > Yep, that's it :) I've often struggled to explain why that is to users as > well. The item search is exact, but for the catalog search (doesn't matter > if Zebra or Elastic) this is an unresolved issue. I'm not familiar with Koha's integration with Elastic, but I think it is solvable with Elastic, since it allows different data types and nested data structures. We use Elastic for other projects, and we've got it so that you can do an "AND" across different values in that deeper nested structure. We're going to be looking more at Koha's Elastic integration at some stage, so probably will be commenting more in the future... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 02:25:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 00:25:41 +0000 Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #44 from Victor Grousset/tuxayo --- Here is a rebase. Placing hold from staff and OPAC still works. Changing priorities and marking as waiting still works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 02:31:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 00:31:13 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136670|0 |1 is obsolete| | --- Comment #21 from Victor Grousset/tuxayo --- Created attachment 139636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139636&action=edit Bug 30982: REST API specs Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 02:31:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 00:31:18 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136671|0 |1 is obsolete| | --- Comment #22 from Victor Grousset/tuxayo --- Created attachment 139637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139637&action=edit Bug 30982: Use the REST API for background job list view Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 02:31:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 00:31:23 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136672|0 |1 is obsolete| | --- Comment #23 from Victor Grousset/tuxayo --- Created attachment 139638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139638&action=edit Bug 30982: (QA follow-up) Double quoting and console.log This patch fixes the issues highlighted by the QA script; We use double quotes for translatable strings in JS and remove an errant console.log call. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 02:31:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 00:31:27 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136707|0 |1 is obsolete| | --- Comment #24 from Victor Grousset/tuxayo --- Created attachment 139639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139639&action=edit Bug 30982: Add tests and implement GET /background_jobs/$id -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 02:31:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 00:31:33 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136715|0 |1 is obsolete| | --- Comment #25 from Victor Grousset/tuxayo --- Created attachment 139640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139640&action=edit Bug 30982: Make code more re-usable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 02:31:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 00:31:38 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138114|0 |1 is obsolete| | --- Comment #26 from Victor Grousset/tuxayo --- Created attachment 139641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139641&action=edit Bug 30982: Add 'context' to the REST API specs context has been added by bug 30889 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 02:33:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 00:33:42 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #27 from Victor Grousset/tuxayo --- Rebased to fix conflict. Tests still pass. (t/db_dependent/api/v1/background_jobs.t) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 02:48:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 00:48:26 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 --- Comment #28 from Victor Grousset/tuxayo --- (In reply to Katrin Fischer from comment #19) > Applied the patches, restart_all: > > * The page loads ok, table is empty in my installation > * I check the "Only include jobs started in the last hour" checkbox: > Error: Something went wrong when loading the table. > 500: Internal Server Error > > In my background_jobs table I have several entries, one for > batch_item_record_modification and several update_elastic_index. All are > finished. I don't get the issue. Tested with empty db table and after checking in an item of a record on hold I get a Holds queue update and Update Elasticsearch index entry. (why is there an ES entry update?) The change here since your test doesn't look like to be able to fix that. And there were no changes on bug 30462. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 03:38:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 01:38:20 +0000 Subject: [Koha-bugs] [Bug 31391] Staff-side recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 03:38:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 01:38:24 +0000 Subject: [Koha-bugs] [Bug 31391] Staff-side recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139442|0 |1 is obsolete| | Attachment #139443|0 |1 is obsolete| | Attachment #139446|0 |1 is obsolete| | --- Comment #6 from Aleisha Amohia --- Created attachment 139642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139642&action=edit Bug 31391: RecallsInterface system preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 03:38:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 01:38:28 +0000 Subject: [Koha-bugs] [Bug 31391] Staff-side recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #7 from Aleisha Amohia --- Created attachment 139643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139643&action=edit Bug 31391: Recalled authorised value for hold cancellation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 03:38:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 01:38:33 +0000 Subject: [Koha-bugs] [Bug 31391] Staff-side recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #8 from Aleisha Amohia --- Created attachment 139644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139644&action=edit Bug 31391: Implement RecallsInterface on OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 03:38:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 01:38:37 +0000 Subject: [Koha-bugs] [Bug 31391] Staff-side recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #9 from Aleisha Amohia --- Created attachment 139645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139645&action=edit Bug 31391: Request recalls and convert reserves on staff interface This enhancement adds the ability to place recalls via the staff interface by introducing a system preference, RecallsInterface, to configure where recalls can be placed. Recalls can either be placed via the OPAC, or the staff interface, or both. This is set to OPAC by default to be consistent with current behaviour. This enhancement also adds the ability to convert existing reserves to recalls easily via the staff interface. The reserve will be cancelled and a recall placed using the reserve's information. To test: 1) Update database and restart services 2) Enable UseRecalls and set the relevant recalls circulation rules 3) View the new RecallsInterface system preference. Confirm it is set to OPAC only by default 4) Check out Item A to Patron B. 5) Log into the OPAC as Patron A. Confirm you can place, view and cancel recalls as normal. 6) In the staff interface, set RecallsInterface to Staff interface only. 7) In the OPAC, confirm you can still view and cancel recalls, but can no longer place recalls. 8) In the staff interface, search for Item A and go to the Reserves tab. Place a reserve for Patron C. 9) Under the Priority column, select the dropdown and choose the recall option next to your reserve. 10) Click Update holds. Confirm when the page refreshes that your reserve has disappeared. 11) Go to the recalls tab. Confirm your reserve has been converted to a recall, and details like the patron, expiration, and pickup location have carried across to the recall. 12) On this recalls page, use the patron search to find Patron D. Test placing a record-level recall by keeping the 'recall next available item' checkbox. 13) When the page refreshes, confirm the recall was successfully placed with the correct details stored. 14) Repeat steps 12 and 13 with Patron E, this time place an item-level recall by choosing an item in the 'place a recall on a specific item' table. When selecting one of these items, the 'recall next available item' checkbox should de-select. 15) Set RecallsInterface back to OPAC only. Go back to the record and view the Recalls tab. 16) Confirm you cannot search for a patron to place a recall, but can still view and cancel recalls. Confirm you also cannot convert reserves to recalls. 17) Set RecallsInterface to both staff interface and OPAC. Confirm you can place recalls on both interfaces. 18) On the staff interface, test placing recalls that your circulation rules do not allow. For example, if 'recalls per record' is 1, ensure you're blocked from placing a second recall on a record for a patron. 19) Place a reserve for one of the patron's that already has a recall. Once complete, try to convert this reserve into a recall. Confirm you are blocked and shown a message that the hold cannot be converted to a recall. 20) Ensure tests pass t/db_dependent/Holds.t Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 03:39:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 01:39:26 +0000 Subject: [Koha-bugs] [Bug 31391] Staff-side recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds the release notes| |ability to place recalls | |via the staff interface by | |introducing a system | |preference, | |RecallsInterface, to | |configure where recalls can | |be placed. Recalls can | |either be placed via the | |OPAC, or the staff | |interface, or both. This is | |set to OPAC by default to | |be consistent with current | |behaviour. | | | |This | |enhancement also adds the | |ability to convert existing | |reserves to recalls easily | |via the staff interface. | |The reserve will be | |cancelled and a recall | |placed using the reserve's | |information. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 04:01:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 02:01:59 +0000 Subject: [Koha-bugs] [Bug 31415] Script to automate converting reserves to recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|19532 |31391 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 [Bug 19532] Recalls for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 [Bug 31391] Staff-side recalls -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 04:01:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 02:01:59 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31415 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 [Bug 31415] Script to automate converting reserves to recalls -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 04:01:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 02:01:59 +0000 Subject: [Koha-bugs] [Bug 31391] Staff-side recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31415 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 [Bug 31415] Script to automate converting reserves to recalls -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 04:02:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 02:02:06 +0000 Subject: [Koha-bugs] [Bug 31415] Script to automate converting reserves to recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139440|0 |1 is obsolete| | Attachment #139441|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia --- Created attachment 139646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139646&action=edit Bug 31415: Script to automate converting reserves to recalls This is a work in progress and not ready for testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 08:22:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 06:22:18 +0000 Subject: [Koha-bugs] [Bug 31339] Add Template::Toolkit WRAPPER for Koha Tool Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31339 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | Summary|Use Template::Toolkit |Add Template::Toolkit |WRAPPER for Koha Plugins |WRAPPER for Koha Tool | |Plugins -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 08:35:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 06:35:39 +0000 Subject: [Koha-bugs] [Bug 31339] Add Template::Toolkit WRAPPER for Koha Tool Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31339 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 08:35:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 06:35:43 +0000 Subject: [Koha-bugs] [Bug 31339] Add Template::Toolkit WRAPPER for Koha Tool Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31339 --- Comment #5 from David Cook --- Created attachment 139647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139647&action=edit Bug 31339: Add staff wrapper template include for tool plugins This change adds a template include which can be used as a WRAPPER for tool plugins, which makes it easy to pages in tool templates without having to copy and maintain a lot of template boilerplate. Test plan: 0. Apply patch and koha-plack --restart kohadev 1. Upload koha-plugin-test-wrapper 2. Enable the plugin 3. Click "Actions" and click "Run tool" 4. Note how the plugin page looks like a perfect Koha Tools page 5. Note that the plugin only contains 6 lines of template code to achieve this effect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 08:36:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 06:36:30 +0000 Subject: [Koha-bugs] [Bug 31339] Add Template::Toolkit WRAPPER for Koha Tool Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31339 --- Comment #6 from David Cook --- Created attachment 139648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139648&action=edit test plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 08:37:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 06:37:16 +0000 Subject: [Koha-bugs] [Bug 31339] Add Template::Toolkit WRAPPER for Koha Tool Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31339 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 08:37:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 06:37:49 +0000 Subject: [Koha-bugs] [Bug 31339] Add Template::Toolkit WRAPPER for Koha Tool Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31339 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 08:46:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 06:46:35 +0000 Subject: [Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31339 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 08:46:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 06:46:35 +0000 Subject: [Koha-bugs] [Bug 31339] Add Template::Toolkit WRAPPER for Koha Tool Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31339 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31380 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 08:53:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 06:53:03 +0000 Subject: [Koha-bugs] [Bug 21366] Add Plack reload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #26 from Marcel de Rooy --- (In reply to Victor Grousset/tuxayo from comment #24) > (In reply to Marcel de Rooy from comment #23) > What do you mean? The patch doesn't use --preload-app. I did not say that. Please read the comment. It is a quote. > I tested changing something in about.pl: once over the ~10 tries the change > was reflected only by reloading the page. Otherwise I had to run `pkill > starman --signal SIGHUP` to get the change. I had the change reflected all tries. The comment of David explains it, I guess. > Your plack_max_requests isn't 1 is it? That would be an explanation of what > you observed. No it is not :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 08:59:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 06:59:14 +0000 Subject: [Koha-bugs] [Bug 21366] Add Plack reload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #27 from Marcel de Rooy --- (In reply to David Cook from comment #25) > We don't use --preload-app, so we don't need to worry about it. I know that. Quoting etc. > Even if we did use --preload-app, I think some of the text is misleading. > While code changes to code that is preloaded wouldn't come through, changes > to code that is lazy loaded after forking the children would still come > through. This explains my testing. Lazy brain :) All workers need to cache the old code first obviously. I just got the wrong worker a few times. Inspired by Victor, I will set the number of workers as low as possible and test again.. > I chose the about.pl test somewhat arbitrarily because koha-testing-docker > is such a small database. In production, where you really see this being > useful is in search.pl and opac-search.pl where a search might take 5+ > seconds. Using koha-plack --reload will wait for that long search request to > complete, and then it will restart that worker. I do not use k-t-d, but your point is clear. Resuming QA scheduled for this afternoon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 09:11:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 07:11:24 +0000 Subject: [Koha-bugs] [Bug 21366] Add Plack reload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #28 from David Cook --- (In reply to Marcel de Rooy from comment #27) > > I chose the about.pl test somewhat arbitrarily because koha-testing-docker > > is such a small database. In production, where you really see this being > > useful is in search.pl and opac-search.pl where a search might take 5+ > > seconds. Using koha-plack --reload will wait for that long search request to > > complete, and then it will restart that worker. > I do not use k-t-d, but your point is clear. > > Resuming QA scheduled for this afternoon. I'll be around on and off for the next 5-7 hours, so shoot me any questions you might have. For what it's worth, I have a "reload_koha.sh" script I use in production all the time, especially when updating plugins, and it's wonderful hehe. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 09:20:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 07:20:29 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 --- Comment #29 from Katrin Fischer --- Maybe another patch/bug changed things? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 09:38:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 07:38:58 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #32 from Katrin Fischer --- > > I'm not sure where 'Rotating collections' should live, 'Circulation' under > tools perhaps.. or part of the new 'Cataloging' home page? > > I think we can probably move 'Upload local cover images' to the new > 'Cataloging' home page though.. do you agree? Both suggestions make sense to me! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 09:51:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 07:51:50 +0000 Subject: [Koha-bugs] [Bug 31440] New: Add select2 to fund selection in addorderiso2709.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31440 Bug ID: 31440 Summary: Add select2 to fund selection in addorderiso2709.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Same as 31388 in addorderiso2709.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 09:51:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 07:51:55 +0000 Subject: [Koha-bugs] [Bug 31440] Add select2 to fund selection in addorderiso2709.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31440 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31388 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31388 [Bug 31388] Add select2 to fund selection in new order form -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 09:51:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 07:51:55 +0000 Subject: [Koha-bugs] [Bug 31388] Add select2 to fund selection in new order form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31388 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31440 [Bug 31440] Add select2 to fund selection in addorderiso2709.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 09:52:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 07:52:59 +0000 Subject: [Koha-bugs] [Bug 31388] Add select2 to fund selection in new order form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31388 --- Comment #6 from Fridolin Somers --- Great thanks. I've opened Bug 31440. Feel free to assign. Maybe there are other places where we could use select2 ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 10:19:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 08:19:47 +0000 Subject: [Koha-bugs] [Bug 27817] Enhance display of title information throughout acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #18 from Katrin Fischer --- Thx Barbara. Do you want to sign-off with the sandboxes? Otherwise I can try to add your sign-off line later. (In reply to Barbara Johnson from comment #17) > In my latest test, I can confirm that I am able to view the 245abhnp on > basket.pl, orderreceive.pl and invoice.pl. > > Only the 245a info is displayed on parcel.pl and I believe bug 31434 is > supposed to address that. It does show, but only after you received something for the received oders, in the second table below the first. Bug 31434 is for the 'unreceiveds' table. > Also, only the 245a is displayed on ordered.pl - it would be helpful to see > the additional info here as well. Could you file that as a separate one? We'd probably want it for the spent too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 10:27:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 08:27:07 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #318 from Martin Renvoize --- Created attachment 139649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139649&action=edit Bug 23681: Move to ::Patron::Restriction::Type(s) This patch moves the new classes under ::Patron::Restriction:: and enhances the Unit tests for those classes. NOTE: We should drop keyed_on_code as part of bug 31095 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 10:28:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 08:28:58 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 10:31:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 08:31:07 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #319 from Martin Renvoize --- OK, that last patch handles most issues outlined above with the exception of touching keyed_on_code. I found that I'd need to write a fair bit of code to work around that implimentation and I felt it more pertinant to help quickly follow this bug by working on a cleanup in bug 31095 where I intend to drop GetDebarmentTypes and therefore the need for keyed_on_code entirely.. it'll end up much more like the Accounts code using relations properly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 11:09:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 09:09:17 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #33 from Martin Renvoize --- Created attachment 139650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139650&action=edit Bug 31162: More conditionals for sections This adds missing conditionals to the section headings in the new cataloging homepage. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 11:09:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 09:09:22 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #34 from Martin Renvoize --- Created attachment 139651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139651&action=edit Bug 31162: Move Rotating Collections and Upload Covers This patch moves the 'Rotating Collections' link from 'Cataloging' to 'Circulation' on the 'Tools' home page and moves the 'Upload local cover image' link to the 'Cataloging' home page. This removes the 'Cataloging' tools section entirely and as such the template is adapted to a two column layout to compensate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 11:10:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 09:10:47 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #35 from Martin Renvoize --- OK.. as agreed I've moved the last few things from the tools home that relate to cataloging now.. please check that both the tools home and cataloging home pages make sense with the full set of patches as they now stand :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 12:00:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 10:00:40 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139651|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize --- Created attachment 139652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139652&action=edit Bug 31162: Move Rotating Collections and Upload Covers This patch moves the 'Rotating Collections' link from 'Cataloging' to 'Circulation' on the 'Tools' home page and moves the 'Upload local cover image' link to the 'Cataloging' home page. This removes the 'Cataloging' tools section entirely and as such the template is adapted to a two column layout to compensate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 12:12:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 10:12:46 +0000 Subject: [Koha-bugs] [Bug 31417] Re-instate the cataloguing sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31417 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139522|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 139653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139653&action=edit Bug 31417: Update and reference cat-menu.inc This patch reinstates the cat-menu.inc include and references it from the various 'tools' that are closely tied to cataloging. We use the new cataloging home page submission as a reference for which options should appear in the menu. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 12:13:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 10:13:08 +0000 Subject: [Koha-bugs] [Bug 31417] Re-instate the cataloguing sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31417 --- Comment #5 from Martin Renvoize --- Minor rebase to keep up with bug 31162 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 12:20:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 10:20:10 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #37 from Emmanuel Bétemps --- Created attachment 139654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139654&action=edit left menu of the Tools module Hi, I noticed things but I don't know if you didn't modify the structure and "only" moved shortcuts on purpose Some buttons (the ones under Import, Export, Batch editing, and the "Upload local cover image" button) which appear in the Cataloging page actually lead to the Tools section They aren't displayed in the Home > Tools page but once clicked, the links lead to https:[...]/koha/tools/***.pl and we still see these options on the left menu (of the Tools module) Idem with Label creator, Quick spine... and Barcode image generator, which lead to the Label menu I realise I'm not very clear so I made this attachment : Home-Tools-etc.pdf Also, "Fast cataloging" is in the Circulation menu. Is it ok ? Emmanuel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 12:39:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 10:39:18 +0000 Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck modules for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444 maalej at effective-webwork.de changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maalej at effective-webwork.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 12:54:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 10:54:36 +0000 Subject: [Koha-bugs] [Bug 30335] Add ability to hide/disable manual invoices and manual credits in patron accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30335 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from Martin Renvoize --- Awesome, thanks Katrin. Setting to PQA now :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 13:15:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 11:15:05 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #115 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #114) > Created attachment 139605 [details] [review] > Bug 30718: (follow-up) index_records is called more times than we thought > > Signed-off-by: Tomas Cohen Arazi Is there any connection with this report ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 13:22:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 11:22:51 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139546|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize --- Created attachment 139655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139655&action=edit Bug 24295: Remove GetTransfer from Z3950Responder Replace the GetTrasfer call in Z3950Responder/Session.pm with a call to the Koha::Item method 'get_transfer'. Test plan 1/ Configure your system to use the Z3950 responder 2/ Trigger an item transfer for an item 3/ Search for the item via Z3950 and varify the transfer status is set 4/ Apply the patch 5/ Repeat step 3 Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 13:22:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 11:22:56 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139547|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize --- Created attachment 139656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139656&action=edit Bug 24295: Remove GetTransfers from opac-reserve.pl This patch replaces the call to GetTransfers in opac-reserve with the get_transfer method available from the Koha::Item object Test plan 1/ Place a reserve on an item at a different branch 2/ Trigger the transfer of the item 3/ Check the opac-reserves page for the display of the current transfer status 4/ Apply patch 5/ Repeat step 3 Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 13:23:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 11:23:01 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139548|0 |1 is obsolete| | --- Comment #88 from Martin Renvoize --- Created attachment 139657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139657&action=edit Bug 24295: Remove GetTransfers from opac-detail.pl This patch replaces the call to GetTransfers in opac-detail with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the opac-detail page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 JK: Remove unneeded string formatting for transfertwhen as it's done on the template toolkit side already with $KohaDates Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 13:23:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 11:23:06 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139549|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize --- Created attachment 139658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139658&action=edit Bug 24295: Remove GetTransfers from opac-basket.pl This patch replaces the call to GetTransfers in opac-basket with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the opac-basket page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 JK: Remove unneeded string formatting for transfertwhen as it's done on the template toolkit side already with $KohaDates. Add missing Koha::Items module import. Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 13:23:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 11:23:10 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139550|0 |1 is obsolete| | --- Comment #90 from Martin Renvoize --- Created attachment 139659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139659&action=edit Bug 24295: Remove GetTransfers from request.pl This patch replaces the call to GetTransfers in reserve.pl with the get_transfer method available from the Koha::Item object Test plan 1/ Place a reserve on an item at a different branch 2/ Trigger the transfer of the item 3/ Check the reserves page for the display of the current transfer status 4/ Apply patch 5/ Repeat step 3 Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 13:23:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 11:23:15 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139551|0 |1 is obsolete| | --- Comment #91 from Martin Renvoize --- Created attachment 139660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139660&action=edit Bug 24295: Remove GetTransfers from detail.pl This patch replaces the call to GetTransfers in detail.pl with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the detail page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 JK: Remove unneeded string formatting for transfertwhen as it's done on the template toolkit side already with $KohaDates Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 13:23:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 11:23:20 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139552|0 |1 is obsolete| | --- Comment #92 from Martin Renvoize --- Created attachment 139661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139661&action=edit Bug 24295: Remove GetTransfers from svc/holds This patch replaces the call to C4::GetTransfers in svc/holds with a call to the get_transfer method in the Koha::Item object. Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 13:23:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 11:23:26 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139553|0 |1 is obsolete| | --- Comment #93 from Martin Renvoize --- Created attachment 139662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139662&action=edit Bug 24295: Replace mock in t/db_dependent/Search.t Replace the mock of GetTransfers in this test with a mock of transfers data Test plan 1/ Run t/db_dependent/Search.t 2/ Confirm it passes 3/ Apply patch 4/ Repeat steps 1-2 Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 13:23:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 11:23:30 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139554|0 |1 is obsolete| | --- Comment #94 from Martin Renvoize --- Created attachment 139663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139663&action=edit Bug 24295: Replace mock in t/db_dependent/Circulation/transferbook.t Replace the call to GetTransfers with the get_transfer method in Koha::Item in transferbook.t Test plan 1/ Run t/db_dependent/Circulation/transferbook.t 2/ Confirm it passes 3/ Apply patch 4/ Repeat steps 1-2 Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 13:23:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 11:23:35 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139555|0 |1 is obsolete| | --- Comment #95 from Martin Renvoize --- Created attachment 139664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139664&action=edit Bug 24295: Remove GetTransfers call from C4/HoldsQueue.pm This patch removes the GetTransfers call from GetItemsAvailableToFillHoldRequestsForBib instead replacing it with an inline JOIN in the initial query. Test plan 1/ Run the holds queue 2/ Check the results 3/ Put one of the items in the holds queue into transit 4/ Run the holds queue again 5/ Check that the results do not contain the item that is in transit 6/ Apply the patch 7/ Run the holds queue again 8/ Check that the results still do not contain the item that is in transit Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 13:23:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 11:23:39 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139556|0 |1 is obsolete| | --- Comment #96 from Martin Renvoize --- Created attachment 139665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139665&action=edit Bug 24295: Remove GetTransfers from C4/Search.pm This patch removes the final use of GetTransfers from C4::Search. Test plan 1/ Perform a search that will include results for some items that have transfers of various states assigned to them 2/ Check the results match expectations (before and after applying the patch should look the same) 3/ Signoff Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 13:23:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 11:23:44 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139557|0 |1 is obsolete| | --- Comment #97 from Martin Renvoize --- Created attachment 139666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139666&action=edit Bug 24295: Remove GetTransfers from circ/transferstoreceive.pl Just drop the import of GetTransfers from circ/transferstoreceive.pl is it's never actually used. Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 13:23:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 11:23:51 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139558|0 |1 is obsolete| | --- Comment #98 from Martin Renvoize --- Created attachment 139667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139667&action=edit Bug 24295: Finally remove GetTransfers from C4/Circulation This patch handles the final removal of GetTransfers from C4::Circulation. Test plan 1/ Check that there is no mention of the GetTransfers method codebase wide now 2/ Run the circulation and transfers tests and check nothing fails.. perhaps even run the full test suit in k-t-d 3/ Signoff Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 13:25:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 11:25:03 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #116 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #115) > (In reply to Tomás Cohen Arazi from comment #114) > > Created attachment 139605 [details] [review] [review] > > Bug 30718: (follow-up) index_records is called more times than we thought > > > > Signed-off-by: Tomas Cohen Arazi > > Is there any connection with this report ? I couldn't find the reason, but git bisect Matthews this bug as responsible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 13:25:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 11:25:19 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #99 from Martin Renvoize --- Thanks for the rebase Joonas.. just confirming I'm happy with your updates and my testing shows it's all good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 13:42:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 11:42:30 +0000 Subject: [Koha-bugs] [Bug 21366] Add Plack reload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #29 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #27) > > seconds. Using koha-plack --reload will wait for that long search request to > > complete, and then it will restart that worker. koha-plack does not wait for the request to complete but it does the job as expected: The current request gave me back the old contents, but Starman closed the old worker afterwards since a new request gives me the new contents. Excellent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 13:43:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 11:43:55 +0000 Subject: [Koha-bugs] [Bug 21366] Add Plack reload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 13:43:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 11:43:59 +0000 Subject: [Koha-bugs] [Bug 21366] Add Plack reload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139015|0 |1 is obsolete| | --- Comment #30 from Marcel de Rooy --- Created attachment 139668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139668&action=edit Bug 21366: Add koha-plack --reload to gracefully restart Plack/Starman This patch adds a "--reload" option to koha-plack, which allows a sysadmin to gracefully restart Koha. This is very useful when installing Koha plugins or deploying a hot fix where you need to change code but don't want to interrupt anyone's usage of Koha. 0. Apply patch 1. cp /usr/sbin/koha-plack /usr/sbin/koha-plack.bak 2. cp debian/scripts/koha-plack /usr/sbin/koha-plack 3. ps -efww | grep "starman" 4. Now at roughly the same time do the following two actions: 4a. Go to http://localhost:8081/cgi-bin/koha/about.pl 4b. koha-plack --reload kohadev 5. Note that the web request completes successfully 6. ps -efww | grep "starman" 7. Note that the "starman master" process stays alive, but the "starman worker" processes have been restarted Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 13:44:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 11:44:03 +0000 Subject: [Koha-bugs] [Bug 21366] Add Plack reload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139565|0 |1 is obsolete| | --- Comment #31 from Marcel de Rooy --- Created attachment 139669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139669&action=edit Bug 21366: Add --reload option to koha-plack help/manual Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 13:56:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 11:56:58 +0000 Subject: [Koha-bugs] [Bug 23415] Notify patron fines when renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119300|0 |1 is obsolete| | --- Comment #41 from Emmi Takkinen --- Created attachment 139670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139670&action=edit Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman Signed-off-by: Kelly McElligott Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 13:57:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 11:57:32 +0000 Subject: [Koha-bugs] [Bug 23415] Notify patron fines when renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119301|0 |1 is obsolete| | --- Comment #42 from Emmi Takkinen --- Created attachment 139671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139671&action=edit Bug 23415: Add missing filters Signed-off-by: Kelly McElligott Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 13:58:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 11:58:02 +0000 Subject: [Koha-bugs] [Bug 23415] Notify patron fines when renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119302|0 |1 is obsolete| | --- Comment #43 from Emmi Takkinen --- Created attachment 139672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139672&action=edit Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 13:58:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 11:58:37 +0000 Subject: [Koha-bugs] [Bug 23415] Notify patron fines when renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119303|0 |1 is obsolete| | --- Comment #44 from Emmi Takkinen --- Created attachment 139673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139673&action=edit Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy Signed-off-by: Stina Hallin Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 13:59:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 11:59:08 +0000 Subject: [Koha-bugs] [Bug 23415] Notify patron fines when renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121472|0 |1 is obsolete| | --- Comment #45 from Emmi Takkinen --- Created attachment 139674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139674&action=edit Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 13:59:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 11:59:36 +0000 Subject: [Koha-bugs] [Bug 23415] Notify patron fines when renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 14:07:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 12:07:25 +0000 Subject: [Koha-bugs] [Bug 30490] Should deleting a parent itemtype be CASCADING? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30490 --- Comment #2 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #1) > My feeling would be that if you delete a parent itemtype, it should set the > field to NULL in the 'child itemtypes'. Does that make sense? Yes. That is the same as RESTRICT. > IIUC quietly deleting the 'children' seems a dangerous move, although it > should hopefully not be possible while items exist for them. Looking closer, the items table has no FK on itype. So you could delete itemtypes but the items will not be deleted. But note that the interface will not allow you to delete the itemtype. But you could in a script or via sql etc, ending up with items that have not existing itemtype. But that is outside the narrower scope of this report. And probably already reported somewhere else.. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 14:12:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 12:12:26 +0000 Subject: [Koha-bugs] [Bug 30403] Update notforloan status also on check out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132536|0 |1 is obsolete| | --- Comment #5 from Emmi Takkinen --- Created attachment 139675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139675&action=edit Bug 30403: Add syspref UpdateNotForLoanStatusOnCheckout We currently have syspref UpdateNotForLoanStatusOnCheckin which updates notforloan status when item is checked in. We should also have same kind of syspref for check outs. This would be usefull if for example library has item in exhibition with status "In exhibition, available for loan". When patron check outs the item notforloan status can be reseted back to 0, informing staff that the item is back on circulation. This patch adds new syspref Add syspref UpdateNotForLoanStatusOnCheckout. To test: 1. Set items notforloan status as e.g -1. 2. Check out item for a patron. => Note that items status doesn't change. 3. Apply patch and update database if needed. 4. Add "-1: 0" to syspref UpdateNotForLoanStatusOnCheckout. 5. Check item in and out again for a patron. => Note that items status is changed as 0. Also prove t/db_dependent/Circulation/issue.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 14:12:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 12:12:48 +0000 Subject: [Koha-bugs] [Bug 30403] Update notforloan status also on check out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 14:21:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 12:21:47 +0000 Subject: [Koha-bugs] [Bug 31441] New: Koha::Item::as_marc_field ignores subfields where kohafield is an empty string Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31441 Bug ID: 31441 Summary: Koha::Item::as_marc_field ignores subfields where kohafield is an empty string Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org marc_subfield_structure.kohafield can be NULL, but it can also be an empty string. But in that case, Koha::Item::as_marc_field ignores them, which means the resulting MARC::Field object has missing data. This can produce a bug in OPAC ISBD view (and probably other places where this method is used) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 14:23:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 12:23:32 +0000 Subject: [Koha-bugs] [Bug 31441] Koha::Item::as_marc_field ignores subfields where kohafield is an empty string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31441 --- Comment #1 from Julian Maurice --- Created attachment 139676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139676&action=edit Bug 31441: Fix Koha::Item::as_marc_field when kohafield = '' marc_subfield_structure.kohafield can be NULL, but it can also be an empty string. But in that case, Koha::Item::as_marc_field ignores them, which means the resulting MARC::Field object has missing data. This can produce a bug in OPAC ISBD view (and probably other places where this method is used) Test plan: 1. Edit the default biblio MARC framework for the item field: find or create a subfield that is not linked to a DB column. Save even if you made no changes to make sure that marc_subfield_structure.kohafield is set to an empty string. I'll use 995$Z as an example for the following steps. 2. Add the following to syspref OPACISBD: #995|
    Item:|{995Z}| 3. Create a biblio with an item and put a value into 995$Z 4. Go to the ISBD detail page for this record at OPAC. Confirm that the value you entered in 995$Z is not visible 5. Apply patch and restart koha 6. Refresh the ISBD detail page. Confirm that the 995$Z is now visible. 7. Run `prove t/db_dependent/Koha/Item.t` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 14:24:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 12:24:28 +0000 Subject: [Koha-bugs] [Bug 31441] Koha::Item::as_marc_field ignores subfields where kohafield is an empty string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31441 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 14:42:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 12:42:52 +0000 Subject: [Koha-bugs] [Bug 31442] New: Node.js v12 is EOL Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31442 Bug ID: 31442 Summary: Node.js v12 is EOL Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org The currently maintained LTS release is v16. We could start using v18 which will be the new LTS in october and would be current until 2025. https://nodejs.org/en/about/releases/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 14:43:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 12:43:02 +0000 Subject: [Koha-bugs] [Bug 31442] Node.js v12 is EOL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31442 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 14:53:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 12:53:00 +0000 Subject: [Koha-bugs] [Bug 31348] Plack stop should be graceful In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31348 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #8 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #6) > Why did you wait so long with this patch, David ? :) > I would be tempted to classify it as a bug btw. And backport? > > Tomas: What do you think? Lets do it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 15:14:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 13:14:03 +0000 Subject: [Koha-bugs] [Bug 30490] Should deleting a parent itemtype be CASCADING? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30490 --- Comment #3 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #2) > (In reply to Katrin Fischer from comment #1) > > My feeling would be that if you delete a parent itemtype, it should set the > > field to NULL in the 'child itemtypes'. Does that make sense? > > Yes. That is the same as RESTRICT. Actually no :) You describe SET NULL but I opt for RESTRICT. You cannot delete the parent type if there still is a child itemtype. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 15:25:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 13:25:14 +0000 Subject: [Koha-bugs] [Bug 31373] Notice template validation is missing INCLUDE_PATH In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31373 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139406|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 139677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139677&action=edit Bug 31373: DRY - Use try/catch around _process_tt This patch reduces the repetition in the tools/letter.pl controller replaceing it with a try/catch block wrapping a call to C4::Letters::_process_tt instead. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 15:25:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 13:25:29 +0000 Subject: [Koha-bugs] [Bug 30490] Should deleting a parent itemtype be CASCADING? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30490 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 15:25:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 13:25:33 +0000 Subject: [Koha-bugs] [Bug 30490] Should deleting a parent itemtype be CASCADING? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30490 --- Comment #4 from Marcel de Rooy --- Created attachment 139678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139678&action=edit Bug 30490: Adjust constraint itemtypes.itemtypes_ibfk_1 Change from CASCADE to restrict. In harmony with dbrev 20.06.00.022. Test plan: Run the dbrev. Bonus: update itemtypes set parent_type='VM' where itemtype='CF'; delete from itemtypes where itemtype='VM'; => ERROR 1451 (23000): Cannot delete or update a parent row: a foreign key constraint fails (`koha_myclone`.`itemtypes`, CONSTRAINT `itemtypes_ibfk_1` FOREIGN KEY (`parent_type`) REFERENCES `itemtypes` (`itemtype`)) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 15:25:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 13:25:44 +0000 Subject: [Koha-bugs] [Bug 30490] Should deleting a parent itemtype be CASCADING? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30490 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 15:25:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 13:25:57 +0000 Subject: [Koha-bugs] [Bug 30490] Should deleting a parent itemtype be CASCADING? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30490 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Marcel de Rooy --- Self signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 15:27:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 13:27:08 +0000 Subject: [Koha-bugs] [Bug 30490] Adjust foreign key for parent item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30490 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Should deleting a parent |Adjust foreign key for |itemtype be CASCADING? |parent item type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 15:37:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 13:37:34 +0000 Subject: [Koha-bugs] [Bug 30490] Adjust foreign key for parent item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30490 --- Comment #6 from Marcel de Rooy --- RM: Dont forget DBIx update please, not included here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 15:47:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 13:47:58 +0000 Subject: [Koha-bugs] [Bug 27817] Enhance display of title information throughout acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139564|0 |1 is obsolete| | --- Comment #19 from ByWater Sandboxes --- Created attachment 139679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139679&action=edit Bug 27817: Use biblio-title include in some acquisitions pages This patch adds the use of the biblio-title include in acquisitions templates which get the right data from their corresponding scripts. To test, apply the patch and test these Acquisitions pages to confirm that titles with 245$b, 245$h, etc, show all the correct information. - Acquisitions -> Vendor -> Basket - Acquisitions -> Vendor -> Uncertain prices - Acquisitions -> Invoices -> Invoice - Acquisitions -> Invoices -> Invoice -> View an invoice which has an already-received bibliographic record. - Go to receipt page -> Already received. -- The "Pending orders" table is unmodified because I wasn't sure how to use the biblio-title include in an AJAX DataTable. Signed-off-by: Katrin Fischer Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 15:59:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 13:59:17 +0000 Subject: [Koha-bugs] [Bug 30490] Adjust foreign key for parent item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30490 --- Comment #7 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #3) > (In reply to Marcel de Rooy from comment #2) > > (In reply to Katrin Fischer from comment #1) > > > My feeling would be that if you delete a parent itemtype, it should set the > > > field to NULL in the 'child itemtypes'. Does that make sense? > > > > Yes. That is the same as RESTRICT. > > Actually no :) You describe SET NULL but I opt for RESTRICT. You cannot > delete the parent type if there still is a child itemtype. Hm, I not sure about this one. You might just add a parent itemtype for testing, the only purpose right now is the max checkouts, later decide to remove it... It's not a required/mandatory field, so I'd day NULL would be ok, maybe with a confirmation warning in the GUI. This way you need to remove it in all itemtypes first, more clicks, but I can live it, just think the other is nicer :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 16:02:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 14:02:04 +0000 Subject: [Koha-bugs] [Bug 30490] Adjust foreign key for parent item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30490 --- Comment #8 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #7) > (In reply to Marcel de Rooy from comment #3) > > (In reply to Marcel de Rooy from comment #2) > > > (In reply to Katrin Fischer from comment #1) > > > > My feeling would be that if you delete a parent itemtype, it should set the > > > > field to NULL in the 'child itemtypes'. Does that make sense? > > > > > > Yes. That is the same as RESTRICT. > > > > Actually no :) You describe SET NULL but I opt for RESTRICT. You cannot > > delete the parent type if there still is a child itemtype. > > Hm, I not sure about this one. > > You might just add a parent itemtype for testing, the only purpose right now > is the max checkouts, later decide to remove it... It's not a > required/mandatory field, so I'd day NULL would be ok, maybe with a > confirmation warning in the GUI. > > This way you need to remove it in all itemtypes first, more clicks, but I > can live it, just think the other is nicer :) This would be an enhancment actually. Now I restore the sync gap between dbrev and structure. You are invited to open a new report? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 16:11:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 14:11:48 +0000 Subject: [Koha-bugs] [Bug 30497] Constraint old_reserves_ibfk_4 should be SET NULL instead of CASCADE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30497 --- Comment #2 from Marcel de Rooy --- QAing my own patch, DROP CONSTRAINT is bad, should be DROP FOREIGN KEY -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 16:18:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 14:18:26 +0000 Subject: [Koha-bugs] [Bug 30497] Constraint old_reserves_ibfk_4 should be SET NULL instead of CASCADE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30497 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133106|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 139680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139680&action=edit Bug 30497: Recreate old_reserves_ibfk_4 when it cascades Test plan: Drop old_reserves_ibfk_4. Add back with: alter table old_reserves ADD CONSTRAINT `old_reserves_ibfk_4` FOREIGN KEY (`itemtype`) REFERENCES `itemtypes` (`itemtype`) ON DELETE CASCADE ON UPDATE CASCADE; Run dbrev. Check that constraint has been replaced by SET NULL. Run dbrev again. No changes. Signed-off-by: Marcel de Rooy [EDIT 23-08-22 Replaced DROP CONSTRAINT] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 16:19:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 14:19:45 +0000 Subject: [Koha-bugs] [Bug 30497] Constraint old_reserves_ibfk_4 should be SET NULL instead of CASCADE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30497 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Needs Signoff |Signed Off --- Comment #4 from Marcel de Rooy --- Taking this one also to the next level. Architectural, close to trivial. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 16:23:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 14:23:17 +0000 Subject: [Koha-bugs] [Bug 27428] Show the number of records in the bibliographic record detail page with ElasticSearch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139626|0 |1 is obsolete| | --- Comment #23 from Shi Yao Wang --- Created attachment 139681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139681&action=edit Bug 27428: Show the number of records in the bibliographic record detail page with ElasticSearch. Tests: 1. Apply this patch; 2. In the Preference system - OPACDisplayRecordCount -> Show; 3. We can see the number of records next to search links in the bibliographic record detail page in the OPAC. Signed-off-by: Stina Hallin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 16:43:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 14:43:58 +0000 Subject: [Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 --- Comment #5 from Marcel de Rooy --- Note from a discussion on IRC: We do not anonymize active issues. So no problem there. And if we mark an item as lost but not returned, the issue should still have an itemnumber and a borrowernumber. So no problem too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 16:48:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 14:48:37 +0000 Subject: [Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133079|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 139682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139682&action=edit Bug 30483: Make issues.borrowernumber and itemnumber NOT NULL Note: This change does NOT apply to old_issues, where constraints may result in nullifying these columns. Test plan: Run dbrev. Try checkout, checkin. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 16:48:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 14:48:40 +0000 Subject: [Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139195|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 139683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139683&action=edit Bug 30483: (DBIx schema) Changes to Issue.pm Compare with results of update_dbix_class_files.pl. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 16:49:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 14:49:04 +0000 Subject: [Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- Makes sense to me.. Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 16:55:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 14:55:15 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 16:55:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 14:55:44 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #100 from Marcel de Rooy --- Please QA this one or otherwise I will do it ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:03:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:03:11 +0000 Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137655|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize --- Created attachment 139684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139684&action=edit Bug 12225: Fix SIP message templates If a renewal via SIP would produce an error due to being on reserve, or exceeding maximum renewals, Koha's SIP2 implementation will refuse to renew the item even if the "no block" flag is set to Y. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:03:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:03:16 +0000 Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137656|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize --- Created attachment 139685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139685&action=edit Bug 12225: Re-implement no block flag for checkouts Test Plan ( assuming Koha Testing Docker or kohadevbox ): 1) Check out master 2) Start the SIP server ( edit the SIP config koha instutution to be "CPL" instead of "kohalibrary" ) 3) Telnet to 6001 4) Send 9300CNkoha|COkoha|CPCPL| 5) Send 11YY20220711 16350220250711 163502AOCPL|AA23529000035676|AB39999000001396|ACkoha|BON|BIN| 6) Note the due date for the checkout in Koha is not in the year 2025: Henry Acevedo (23529000035676) checked out Philippics. by Cicero, Marcus Tullius. 39999000001396 7) Apply this patch set 8) Restart all the things! 9) Check in the checkout 10) Repeat steps 3 through 5 11) Note the due date is now in 2025! Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:03:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:03:20 +0000 Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137713|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize --- Created attachment 139686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139686&action=edit Bug 12225: Use ProcessOfflineIssue Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:04:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:04:51 +0000 Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #24 from Martin Renvoize --- OK, this took a while to wrap my head around fully but I do agree with the changes now I have. QA scripts are happy and existing tests are still passing.. however.. I think we should be covering this change with new tests, please. Failing QA for lack of tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:04:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:04:57 +0000 Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:06:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:06:38 +0000 Subject: [Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139020|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 139687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139687&action=edit Bug 31033: Explicitly define max child processes for SIP server By default, the SIP server appears to only use 1 child process for responding to SIP connections. This change makes this explicit in the configuration, which should make it so that people who need more than 1 simultaneous SIP connection can know to just increase the value for the "max_servers" parameter in the SIPconfig.xml file. Test plan: 1. Add "max_servers='1'" to your SIP configuration file 2. koha-sip --restart kohadev 3. Open 3 terminals 4. Run "telnet localhost 6001" on 2 terminals 5. On the 3rd terminal, run the following: ss -l -n -t ps -efww | grep "sip" 6. Note that there are 2 processes called kohadev-koha-sip: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml One of these processes is the parent of the other 7. The Recv-Q in the "ss" output should show 1 (This means that 1 of your telnet connections is in the server's TCP backlog) 8. Celebrate as the configuration works as expected Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:07:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:07:00 +0000 Subject: [Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #9 from Martin Renvoize --- Trivial improvement, works.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:07:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:07:06 +0000 Subject: [Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:10:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:10:47 +0000 Subject: [Koha-bugs] [Bug 25816] Add OPAC messages in SIP display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25816 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106060|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 139688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139688&action=edit Bug 25816: Add opac messages in SIP display. Test plan: - Add one or more opac messages to a patron (patron detail -> add message -> Add a message for: OPAC) - Check that the messages will be displayed, with correctly formatted dates. You can use src/C4/SIP/interactive_patron_dump.pl for easier testing. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:11:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:11:50 +0000 Subject: [Koha-bugs] [Bug 25816] Add OPAC messages in SIP display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25816 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Works as expected.. signing off. QA comment.. we should probably have Unit Tests for this. Also, my brain fails me right now; but are there any characters we should be escaping/filtering from messages here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:12:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:12:11 +0000 Subject: [Koha-bugs] [Bug 25816] Add OPAC messages in SIP display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25816 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:14:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:14:51 +0000 Subject: [Koha-bugs] [Bug 31236] Add ability to send custom item fields via SIP using Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31236 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138104|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 139689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139689&action=edit Bug 31236: Add ability to send custom item fields via SIP using Template Toolkit Koha has been able to send arbitrary item fields via the "item_field" parameter in the config. We have partners that need the ability to created custom item fields from templates, as the item_fields feature cannot accomplish what they need. We need to add a templated custom field feature for items, similar to what we have for patrons. Test Plan: 1) Apply this patch 2) Choose a SIP login to use, edit that account and add the following *inside* the login section: 3) Restart SIP 4) Run an item information query 5) Note the itemnumber is sent in the IN field! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:16:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:16:45 +0000 Subject: [Koha-bugs] [Bug 31236] Add ability to send custom item fields via SIP using Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31236 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:17:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:17:17 +0000 Subject: [Koha-bugs] [Bug 31236] Add ability to send custom item fields via SIP using Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31236 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- All works as described, no regressions and it contains unit tests! Going for a straight QA.. Passed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:17:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:17:23 +0000 Subject: [Koha-bugs] [Bug 31236] Add ability to send custom item fields via SIP using Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31236 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:21:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:21:37 +0000 Subject: [Koha-bugs] [Bug 29051] Seen renewal methods incorrectly blocked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | --- Comment #14 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:23:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:23:00 +0000 Subject: [Koha-bugs] [Bug 25812] Display overdue fines for the item on SIP checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106340|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 139690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139690&action=edit Bug 25812: Display overdue fines for the item on SIP checkin. Test plan: - Using SIP, checkin an item that has one or several overdue fines. - Check that the following message is displayed (AF field): "You owe {correctly formatted price} for this item." Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:23:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:23:22 +0000 Subject: [Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |lucas at bywatersolutions.com --- Comment #25 from Lucas Gass --- Enhancement will not be backported 22.05.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:24:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:24:25 +0000 Subject: [Koha-bugs] [Bug 25812] Display overdue fines for the item on SIP checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Looks good and works as designed.. I wonder if other outstanding charges associated with the patron and item combination should be taken into account.. i.e. issueing charges? Signing off, but form a QA perspective I'd love to see a Unit test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:29:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:29:42 +0000 Subject: [Koha-bugs] [Bug 24550] Books renewals triggers item loan policies to revert to branch renewing item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24550 Jason Robb changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb at sekls.org --- Comment #5 from Jason Robb --- We're experiencing similar in 21.11. My sysprefs are: - CircControl: at the library you are logged in at - HomeOrHoldingBranch: the item's holding library (holdingbranch) The two sysprefs seem to conflict where renewals are involved. The logged in librarian's rules are always used to dictate renewals rather than the item holding branch's rules. To replicate: - Set CircControl and HomeOrHoldingBranch as noted above - Check out an item while logged in as Library A where the circ/renew period is set to 7 days - Switch to Library B where the circ/renew period is 14 days - Renew the item while logged in as Library B, the new due date is 14 days later A few savvy users have figured out that they can call a library with a longer loan period for renewal to get a bigger extension on their checkouts. It would be nice if renewal behavior could be explicitly defined to follow the rules of the library of the initial checkout to close that loophole. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:32:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:32:44 +0000 Subject: [Koha-bugs] [Bug 29333] Importing UNIMARC authorities in MARCXML UTF-8 breaks the encoding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29333 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #18 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:33:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:33:24 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #546 from Lucas Gass --- No backport for 22.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:33:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:33:25 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Bug 24860 depends on bug 24857, which changed state. Bug 24857 Summary: Add ability to group items for records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:33:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:33:26 +0000 Subject: [Koha-bugs] [Bug 26275] Deleting item should not automatically delete group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26275 Bug 26275 depends on bug 24857, which changed state. Bug 24857 Summary: Add ability to group items for records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:33:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:33:26 +0000 Subject: [Koha-bugs] [Bug 26276] When merging biblios with volumes, preserve all groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26276 Bug 26276 depends on bug 24857, which changed state. Bug 24857 Summary: Add ability to group items for records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:33:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:33:26 +0000 Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133 Bug 31133 depends on bug 24857, which changed state. Bug 24857 Summary: Add ability to group items for records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:33:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:33:27 +0000 Subject: [Koha-bugs] [Bug 31140] TestBuilder.t is failing on item groups modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31140 Bug 31140 depends on bug 24857, which changed state. Bug 24857 Summary: Add ability to group items for records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:33:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:33:27 +0000 Subject: [Koha-bugs] [Bug 26931] Groups tab should show all groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26931 Bug 26931 depends on bug 24857, which changed state. Bug 24857 Summary: Add ability to group items for records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:37:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:37:25 +0000 Subject: [Koha-bugs] [Bug 31039] Rebase issues lead to duplicate JS for cash summary modal printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | --- Comment #20 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:49:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:49:15 +0000 Subject: [Koha-bugs] [Bug 31116] Article requests doesn't respect the 'CircSidebar' preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #8 from Lucas Gass --- Doesn't apply clean to 22.05.x, no backport. If needed please rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:51:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:51:49 +0000 Subject: [Koha-bugs] [Bug 31054] Manual importing for EDIFACT invoices fails with a 500 error page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31054 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | --- Comment #5 from Lucas Gass --- Backported to 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:54:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:54:22 +0000 Subject: [Koha-bugs] [Bug 31140] TestBuilder.t is failing on item groups modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31140 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:55:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:55:39 +0000 Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:56:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:56:04 +0000 Subject: [Koha-bugs] [Bug 25816] Add OPAC messages in SIP display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25816 --- Comment #4 from Kyle M Hall --- (In reply to Martin Renvoize from comment #3) > Works as expected.. signing off. > > QA comment.. we should probably have Unit Tests for this. Also, my brain > fails me right now; but are there any characters we should be > escaping/filtering from messages here? Agreed with the unit test. Also, I wonder if this should be controlled by yet another sip account level switch in the sip config. Characters should already get escaped automatically. However, it's not working for me atm: CLI: ./misc/sip_cli_emulator.pl -a 127.0.0.1 -su koha -sp koha -l MPL --patron 23529000035676 -m patron_information Attempting socket connection to 127.0.0.1:6001...connected! Use of uninitialized value $hold_mode in string eq at ./misc/sip_cli_emulator.pl line 120. SEND: 9300CNkoha|COkoha|CPMPL| READ: 941 Trying 'patron_information' SEND: 6300120220823 155418 AOMPL|AA23529000035676|ACkoha| Use of uninitialized value $data in concatenation (.) or string at ./misc/sip_cli_emulator.pl line 352, chunk 1. READ: Logs: [2022/08/23 15:55:51] [26838] [DEBUG] [undef]@[undef]: Configuration::find_service: Trying 6001/tcp C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (223) [2022/08/23 15:55:51] [26838] [DEBUG] [undef]@[undef]: Configuration::find_service: Trying *:6001/tcp C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (223) [2022/08/23 15:55:51] [26838] [DEBUG] [undef]@[undef]: Configuration::find_service: Trying 127.0.0.1:6001/tcp C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (223) [2022/08/23 15:55:51] [26838] [DEBUG] [undef]@[undef]: raw_transport: timeout is 60 C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (223) [2022/08/23 15:55:51] [26838] [DEBUG] [undef]@[undef]: read_request trimmed 1 character(s) C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (223) [2022/08/23 15:55:51] [26838] [INFO] [undef]@[undef]: INPUT MSG: '9300CNkoha|COkoha|CPMPL' C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (223) [2022/08/23 15:55:51] [26838] [DEBUG] [undef]@[undef]: Sip::MsgType::new('C4::SIP::Sip::MsgType', '9300CNkoha...', '93'): seq.no '0', protocol 2 C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (223) [2022/08/23 15:55:51] [26838] [DEBUG] [undef]@[undef]: Sip::MsgType::_initialize('Login', '00CNkoha|COkoha|CPMPL', 'A1A1', '2', ...) C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (223) [2022/08/23 15:55:52] [26838] [INFO] [undef]@[undef]: Successful login/auth for 'koha' of 'kohalibrary' C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (223) [2022/08/23 15:55:52] [26838] [DEBUG] [undef]@[undef]: login_core: $VAR1 = 'ILS'; C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (223) [2022/08/23 15:55:52] [26838] [DEBUG] [undef]@[undef]: new ILS 'kohalibrary' C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (223) [2022/08/23 15:55:52] [26838] [INFO] [undef]@[undef]: OUTPUT MSG: '941' C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (223) [2022/08/23 15:55:52] [26838] [DEBUG] koha at 127.0.0.1: raw_transport: uname/inst: 'koha/kohalibrary' C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (223) [2022/08/23 15:55:52] [26838] [DEBUG] koha at 127.0.0.1: read_request trimmed 2 character(s) C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (223) [2022/08/23 15:55:52] [26838] [INFO] koha at 127.0.0.1: INPUT MSG: '6300120220823 155551 AOMPL|AA23529000035676|ACkoha' C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (223) [2022/08/23 15:55:52] [26838] [DEBUG] koha at 127.0.0.1: Sip::MsgType::new('C4::SIP::Sip::MsgType', '6300120220...', '63'): seq.no '0', protocol 2 C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (223) [2022/08/23 15:55:52] [26838] [DEBUG] koha at 127.0.0.1: Sip::MsgType::_initialize('Patron Info', '00120220823 155551 AOMPL|AA23529000035676|ACkoha', 'A3A18A10', '31', ...) C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (223) [2022/08/23 15:55:52] [26838] [INFO] koha at 127.0.0.1: raw_transport: shutting down C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (223) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:56:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:56:49 +0000 Subject: [Koha-bugs] [Bug 25816] Add OPAC messages in SIP display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25816 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:58:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:58:30 +0000 Subject: [Koha-bugs] [Bug 31141] We can remove 'select_column' from waiting_holds.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31141 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #9 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 17:59:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 15:59:10 +0000 Subject: [Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |shi-yao.wang at inLibro.com |ity.org | --- Comment #5 from Blou --- no interest? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 18:00:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 16:00:58 +0000 Subject: [Koha-bugs] [Bug 31145] Add some defaults for acquisitions in TestBuilder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #8 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 18:01:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 16:01:39 +0000 Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas at bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 18:01:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 16:01:41 +0000 Subject: [Koha-bugs] [Bug 25503] Add option to export items bundle contents in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503 Bug 25503 depends on bug 28854, which changed state. Bug 28854 Summary: Add ability to create bundles of items for circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 18:01:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 16:01:41 +0000 Subject: [Koha-bugs] [Bug 29099] Add support for item bundles in the inventory tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Bug 29099 depends on bug 28854, which changed state. Bug 28854 Summary: Add ability to create bundles of items for circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 18:01:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 16:01:41 +0000 Subject: [Koha-bugs] [Bug 29560] Add option to create MARC links when adding items to bundles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29560 Bug 29560 depends on bug 28854, which changed state. Bug 28854 Summary: Add ability to create bundles of items for circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 18:01:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 16:01:42 +0000 Subject: [Koha-bugs] [Bug 29566] Convert bundle contents modal to a notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 Bug 29566 depends on bug 28854, which changed state. Bug 28854 Summary: Add ability to create bundles of items for circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 18:01:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 16:01:42 +0000 Subject: [Koha-bugs] [Bug 31078] Lost status different to 1 don't show with description in bundle detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31078 Bug 31078 depends on bug 28854, which changed state. Bug 28854 Summary: Add ability to create bundles of items for circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 18:01:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 16:01:42 +0000 Subject: [Koha-bugs] [Bug 31080] Block adding the bundle item to its own bundle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080 Bug 31080 depends on bug 28854, which changed state. Bug 28854 Summary: Add ability to create bundles of items for circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 18:01:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 16:01:42 +0000 Subject: [Koha-bugs] [Bug 31079] Entering an empty line on checking of an item bundle, gives "Unexpected:" error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31079 Bug 31079 depends on bug 28854, which changed state. Bug 28854 Summary: Add ability to create bundles of items for circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 18:01:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 16:01:42 +0000 Subject: [Koha-bugs] [Bug 31081] Improve display of 'Manage bundle' button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31081 Bug 31081 depends on bug 28854, which changed state. Bug 28854 Summary: Add ability to create bundles of items for circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 18:01:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 16:01:43 +0000 Subject: [Koha-bugs] [Bug 31082] Add tooltip to buttons when item bundles cannot be changed while checked out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31082 Bug 31082 depends on bug 28854, which changed state. Bug 28854 Summary: Add ability to create bundles of items for circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 18:01:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 16:01:43 +0000 Subject: [Koha-bugs] [Bug 31083] Part name (245$p) breaks item bundle detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31083 Bug 31083 depends on bug 28854, which changed state. Bug 28854 Summary: Add ability to create bundles of items for circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 18:01:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 16:01:43 +0000 Subject: [Koha-bugs] [Bug 31084] Display item type in bundle management table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31084 Bug 31084 depends on bug 28854, which changed state. Bug 28854 Summary: Add ability to create bundles of items for circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 18:01:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 16:01:43 +0000 Subject: [Koha-bugs] [Bug 31130] Display collection code in bundle management table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31130 Bug 31130 depends on bug 28854, which changed state. Bug 28854 Summary: Add ability to create bundles of items for circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 18:01:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 16:01:43 +0000 Subject: [Koha-bugs] [Bug 31192] Checking in an unkown barcode causes error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31192 Bug 31192 depends on bug 28854, which changed state. Bug 28854 Summary: Add ability to create bundles of items for circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 18:06:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 16:06:02 +0000 Subject: [Koha-bugs] [Bug 31139] basic_workflow.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31139 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #8 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 18:06:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 16:06:57 +0000 Subject: [Koha-bugs] [Bug 25449] Make itemtype mandatory by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25449 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |Needs documenting --- Comment #19 from Lucas Gass --- Enhancement will not be backported to 22.05.x series unless requested -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 18:09:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 16:09:43 +0000 Subject: [Koha-bugs] [Bug 31129] Number of restrictions is always "0" on the "Check out" tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31129 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | --- Comment #6 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 18:12:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 16:12:24 +0000 Subject: [Koha-bugs] [Bug 31134] t/Ediorder.t tests failing on 22.05.02 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | --- Comment #9 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 18:13:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 16:13:00 +0000 Subject: [Koha-bugs] [Bug 31443] New: Improve display of title information when viewing titles on order from a specific fund Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31443 Bug ID: 31443 Summary: Improve display of title information when viewing titles on order from a specific fund Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: barbara.johnson at bedfordtx.gov QA Contact: testopia at bugs.koha-community.org When viewing a list of titles that are on order from a specific fund (ordered.pl), only the title (245$a for MARC21) is shown in the list. It would be helpful to show all of the 245 fields (subfields abhnp) in order to complete the work done in bug 27817. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 18:14:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 16:14:28 +0000 Subject: [Koha-bugs] [Bug 31444] New: Improve display of title information when viewing titles that have been ordered and received from a specific fund Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31444 Bug ID: 31444 Summary: Improve display of title information when viewing titles that have been ordered and received from a specific fund Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: barbara.johnson at bedfordtx.gov QA Contact: testopia at bugs.koha-community.org When viewing a list of titles that have been ordered and received from a specific fund (spent.pl), only the title (245$a for MARC21) is shown in the list. It would be helpful to show all of the 245 fields (subfields abhnp) in order to complete the work done in bug 27817. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 18:15:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 16:15:38 +0000 Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 18:15:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 16:15:43 +0000 Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 --- Comment #25 from Kyle M Hall --- Created attachment 139691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139691&action=edit Bug 12225: Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 18:18:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 16:18:03 +0000 Subject: [Koha-bugs] [Bug 31146] Minor UI problem in recalls history in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | --- Comment #10 from Lucas Gass --- Bakported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 18:18:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 16:18:14 +0000 Subject: [Koha-bugs] [Bug 27817] Enhance display of title information throughout acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #20 from Barbara Johnson --- I've signed off on this bug - this functionality will be so helpful. Also, I filed bug 31443 (for viewing titles from ordered.pl) and bug 31444 (for viewing titles on spent.pl) to complete the work already done here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 18:52:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 16:52:55 +0000 Subject: [Koha-bugs] [Bug 31137] Error editing label template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31137 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | --- Comment #8 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 19:14:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 17:14:19 +0000 Subject: [Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a patron can hold the given item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | --- Comment #8 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 19:19:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 17:19:33 +0000 Subject: [Koha-bugs] [Bug 31069] Did you mean? in the OPAC - links have tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | --- Comment #14 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 19:21:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 17:21:36 +0000 Subject: [Koha-bugs] [Bug 31036] Cash management doesn't take SIP00 (Cash via SIP2) transactions into account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31036 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com --- Comment #13 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 19:22:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 17:22:19 +0000 Subject: [Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |lucas at bywatersolutions.com --- Comment #34 from Lucas Gass --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 19:23:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 17:23:20 +0000 Subject: [Koha-bugs] [Bug 31083] Part name (245$p) breaks item bundle detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31083 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 19:25:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 17:25:37 +0000 Subject: [Koha-bugs] [Bug 14680] When creating orders from a staged file discounts supplied in the form are added In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | --- Comment #14 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 19:33:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 17:33:23 +0000 Subject: [Koha-bugs] [Bug 30555] Add more sample notice for sms messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30555 --- Comment #5 from Shi Yao Wang --- Created attachment 139692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139692&action=edit Bug 30555: Add more sample notice for sms messages Adds sms sample notice for due, hold, checkin and checkout Test plan: 1. Check that there are no SMS messages for these notices (Tools > Notices & slips): . CHECKIN - Item check-in (digest) . CHECKOUT - Item check-out (digest) . DUE - Item due reminder . DUEDGST - Item due reminder (digest) . PREDUE - Advance notice of item due . PREDUEDGST - Advance notice of item due (digest) . HOLD - Hold available for pickup 2. Apply the patch. 3. Update the database (./installer/data/mysql/updatedatabase.pl) 4. Refresh page 5. Check that there are now SMS notices for the notices listed in step 1. 6. Sign-off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 19:34:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 17:34:13 +0000 Subject: [Koha-bugs] [Bug 30555] Add more sample notice for sms messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30555 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133360|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 19:34:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 17:34:21 +0000 Subject: [Koha-bugs] [Bug 31153] Search bar not visible on recalls history page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #11 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 19:36:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 17:36:36 +0000 Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com --- Comment #16 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 19:38:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 17:38:39 +0000 Subject: [Koha-bugs] [Bug 30882] Add max_result_window to index config In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30882 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #16 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 20:02:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 18:02:41 +0000 Subject: [Koha-bugs] [Bug 30412] Shelving location column in holdings table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30412 Teresa Van Doren changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tvandoren at blackgold.org --- Comment #3 from Teresa Van Doren --- Can the developers make a column for Shelving location in the Holdings view, so the shelving location doesn’t display under Home library? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:20:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:20:29 +0000 Subject: [Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items responses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #19 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:22:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:22:17 +0000 Subject: [Koha-bugs] [Bug 31068] Context for translation: Print (verb) vs. Print (noun) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31068 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #7 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:23:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:23:55 +0000 Subject: [Koha-bugs] [Bug 31144] When modifying an order we should not load the vendor default discount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31144 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | --- Comment #6 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:25:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:25:49 +0000 Subject: [Koha-bugs] [Bug 20439] SMS provider sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20439 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | --- Comment #11 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:28:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:28:20 +0000 Subject: [Koha-bugs] [Bug 27667] Display the number of non-indexed records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27667 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #14 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:30:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:30:06 +0000 Subject: [Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | --- Comment #28 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:31:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:31:49 +0000 Subject: [Koha-bugs] [Bug 31163] Sort cashup history so that newest entries are first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31163 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | --- Comment #6 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:34:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:34:10 +0000 Subject: [Koha-bugs] [Bug 29922] Group of libraries are now displayed in alphabetical order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #25 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:36:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:36:06 +0000 Subject: [Koha-bugs] [Bug 30447] pendingreserves.pl is checking too many transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30447 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com --- Comment #18 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:40:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:40:15 +0000 Subject: [Koha-bugs] [Bug 27683] Bind results of GetAnalyticsCount to the EasyAnalyticalRecords pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | --- Comment #17 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:40:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:40:47 +0000 Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/585 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:42:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:42:02 +0000 Subject: [Koha-bugs] [Bug 20439] SMS provider sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20439 --- Comment #12 from George Williams (NEKLS) --- If this could be backported to 21.11, that would be awesome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:42:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:42:49 +0000 Subject: [Koha-bugs] [Bug 30935] Holds to pull shows wrong first patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30935 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #9 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:43:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:43:14 +0000 Subject: [Koha-bugs] [Bug 31313] Remove GetItemsInfo from opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 --- Comment #18 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #17) > (In reply to Joonas Kylmälä from comment #16) > > regression found: the item transfer status is not shown anymore. > > Seems like few other fields could be missing too, in addition I found > item.waiting to be missing. Working on the fixes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:45:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:45:23 +0000 Subject: [Koha-bugs] [Bug 30905] Show waiting recalls in patron account on checkouts tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30905 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:46:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:46:20 +0000 Subject: [Koha-bugs] [Bug 11889] Option to keep public or shared lists when deleting patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #102 from Lucas Gass --- Enhancement will not be backported to the 22.05.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:46:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:46:21 +0000 Subject: [Koha-bugs] [Bug 25498] Allow to change owner of public or shared list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Bug 25498 depends on bug 11889, which changed state. Bug 11889 Summary: Option to keep public or shared lists when deleting patron https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:47:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:47:09 +0000 Subject: [Koha-bugs] [Bug 25498] Allow to change owner of public or shared list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #64 from Lucas Gass --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:47:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:47:11 +0000 Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and public lists at patron deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933 Bug 30933 depends on bug 25498, which changed state. Bug 25498 Summary: Allow to change owner of public or shared list https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:47:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:47:20 +0000 Subject: [Koha-bugs] [Bug 25498] Allow to change owner of public or shared list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |Needs documenting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:47:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:47:21 +0000 Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and public lists at patron deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933 Bug 30933 depends on bug 25498, which changed state. Bug 25498 Summary: Allow to change owner of public or shared list https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:48:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:48:10 +0000 Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and public lists at patron deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #39 from Lucas Gass --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:48:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:48:10 +0000 Subject: [Koha-bugs] [Bug 31288] Check userenv in ->disown_or_delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31288 Bug 31288 depends on bug 30933, which changed state. Bug 30933 Summary: Add a designated owner for shared and public lists at patron deletion https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:49:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:49:01 +0000 Subject: [Koha-bugs] [Bug 31313] Remove GetItemsInfo from opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 --- Comment #19 from Tomás Cohen Arazi --- (In reply to Joonas Kylmälä from comment #18) > (In reply to Joonas Kylmälä from comment #17) > > (In reply to Joonas Kylmälä from comment #16) > > > regression found: the item transfer status is not shown anymore. > > > > Seems like few other fields could be missing too, in addition I found > > item.waiting to be missing. > > Working on the fixes. Thank you! I've been trapped by other devs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:49:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:49:56 +0000 Subject: [Koha-bugs] [Bug 30909] Regression, Permanent shelving location is always updated when editing location VIA ADDITEM.PL if both are mapped to MARC fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |lucas at bywatersolutions.com --- Comment #18 from Lucas Gass --- Missing dependencies for 22.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:49:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:49:57 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 Bug 31187 depends on bug 30909, which changed state. Bug 30909 Summary: Regression, Permanent shelving location is always updated when editing location VIA ADDITEM.PL if both are mapped to MARC fields https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:50:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:50:47 +0000 Subject: [Koha-bugs] [Bug 27546] Add option to search within results on the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27546 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED --- Comment #28 from Lucas Gass --- Enhancement will not be backported to 22.05.x series unless requested -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:52:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:52:43 +0000 Subject: [Koha-bugs] [Bug 31020] PassItemMarcToXSLT only applies on results pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | --- Comment #6 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:55:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:55:15 +0000 Subject: [Koha-bugs] [Bug 26377] Clearly label parts of subscription-add.pl that relate to optional item records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | CC| |lucas at bywatersolutions.com --- Comment #19 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 21:57:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 19:57:16 +0000 Subject: [Koha-bugs] [Bug 30039] Add publication date column to serial claims table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30039 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #12 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 22:03:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 20:03:37 +0000 Subject: [Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #18 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 22:06:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 20:06:04 +0000 Subject: [Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set when creating a child patron from the adult In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com --- Comment #18 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 22:07:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 20:07:13 +0000 Subject: [Koha-bugs] [Bug 30333] Move view actions on acquisitions receipt summary page into menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30333 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #5 from Lucas Gass --- Enhancement will not be backported to 22.05.x series unless requested -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 22:07:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 20:07:13 +0000 Subject: [Koha-bugs] [Bug 16640] Move actions on acquisitions receipt summary page into menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16640 Bug 16640 depends on bug 30333, which changed state. Bug 30333 Summary: Move view actions on acquisitions receipt summary page into menu https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30333 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 22:08:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 20:08:36 +0000 Subject: [Koha-bugs] [Bug 30268] When creating an order from a staged file, mandatory item subfields that are empty do not block form submission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30268 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 22:09:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 20:09:28 +0000 Subject: [Koha-bugs] [Bug 31192] Checking in an unkown barcode causes error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31192 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #6 from Lucas Gass --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 22:12:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 20:12:19 +0000 Subject: [Koha-bugs] [Bug 27045] Exports using CSV profiles with tab as separator don't work correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | --- Comment #23 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 22:13:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 20:13:57 +0000 Subject: [Koha-bugs] [Bug 31186] Search result numbering in OPAC got suppressed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31186 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | --- Comment #6 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 22:14:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 20:14:34 +0000 Subject: [Koha-bugs] [Bug 31313] Remove GetItemsInfo from opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 --- Comment #20 from Joonas Kylmälä --- Created attachment 139693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139693&action=edit Bug 31313: (QA follow-up) Show status "On hold" correctly if there are waiting holds The patch "Bug 31313: Fix availability - OPAC opac-detail" (70cb4e22c07) cause the OPAC detail page only show "Available" status even when there were waiting holds. The onhold item field is removed at the same go as it was confusing and unused since "Bug 2655: Fixes availabilty counts if items are on hold shelf. Patch (2/2)" (a37545eb1) Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 22:14:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 20:14:38 +0000 Subject: [Koha-bugs] [Bug 31313] Remove GetItemsInfo from opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 --- Comment #21 from Joonas Kylmälä --- Created attachment 139694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139694&action=edit Bug 31313: (QA follow-up) Show transfer status correctly if item in transit The patch "Bug 31313: Fix availability - OPAC opac-detail" (70cb4e22c07) caused the OPAC detail page only show "Available" status even when the item was in transit. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 22:14:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 20:14:42 +0000 Subject: [Koha-bugs] [Bug 31313] Remove GetItemsInfo from opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 --- Comment #22 from Joonas Kylmälä --- Created attachment 139695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139695&action=edit Bug 31313: (QA follow-up) Remove unused bundle_host field from item_info The patch "Bug 31313: Fix availability - OPAC opac-detail" (70cb4e22c07) lead to koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc use the bundle_host method directly through the passed Koha::Item object, thus the bundle_host field added by this script is unused. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 22:21:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 20:21:55 +0000 Subject: [Koha-bugs] [Bug 31313] Remove GetItemsInfo from opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 --- Comment #23 from Joonas Kylmälä --- Tomás, I attached a few important fixes here that fix the availability status shown in the opac-detail.pl page, could you push them directly from here to master after reviewing and making sure they look alright? However, there is one more bug that needs to be solved: item.on_order. The order info is not shown yet, and it has a quite complex implementation in opac-detail.pl and I'm afraid if it was to be implemented on the template side it will cause unneeded SQL queries to be made and slow down the opac-detail.pl page load time. I don't have time to work on it today, could someone else look into this? I went through item-status.inc file and the missing ordering info should be the only thing left to fix (after applying my patches attached to this bug report). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 22:29:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 20:29:28 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #101 from Joonas Kylmälä --- FYI, patch "Bug 24295: Remove GetTransfers from opac-detail.pl" might become obsolete if bug 31313 follow-ups get pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 22:49:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 20:49:30 +0000 Subject: [Koha-bugs] [Bug 30412] Separate shelving location column in holdings table in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30412 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Summary|Shelving location column in |Separate shelving location |holdings table |column in holdings table in | |staff interface --- Comment #4 from Katrin Fischer --- (In reply to Teresa Van Doren from comment #3) > Can the developers make a column for Shelving location in the Holdings view, > so the shelving location doesn’t display under Home library? It already works for the staff interface, take a look at OpacLocationDetail and Administration > Table configuration. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 22:53:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 20:53:52 +0000 Subject: [Koha-bugs] [Bug 27546] Add option to search within results on the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27546 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |Needs documenting --- Comment #29 from Katrin Fischer --- Don't forget Needs dcocumenting :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 22:56:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 20:56:19 +0000 Subject: [Koha-bugs] [Bug 27546] Add option to search within results on the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27546 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add option to search within |Add option to search within |results on the staff client |results on the staff | |interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 22:58:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 20:58:59 +0000 Subject: [Koha-bugs] [Bug 30333] Move view actions on acquisitions receipt summary page into menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30333 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |Needs documenting --- Comment #6 from Katrin Fischer --- Might require an updated screenshot. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 22:58:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 20:58:59 +0000 Subject: [Koha-bugs] [Bug 16640] Move actions on acquisitions receipt summary page into menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16640 Bug 16640 depends on bug 30333, which changed state. Bug 30333 Summary: Move view actions on acquisitions receipt summary page into menu https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30333 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 23 23:09:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 21:09:45 +0000 Subject: [Koha-bugs] [Bug 31445] New: Add biblio isbn to batch item modification Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31445 Bug ID: 31445 Summary: Add biblio isbn to batch item modification Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org It has been suggested that it would be helpful to have the ISBN display in a column next to the title in the batch item modification/deletion tools. This could help libraries with verification of info without having to open the bib record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 01:25:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Aug 2022 23:25:31 +0000 Subject: [Koha-bugs] [Bug 31442] Node.js v12 is EOL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31442 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 03:06:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 01:06:26 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #3 from Alex Buckley --- Created attachment 139696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139696&action=edit Bug 30418: Database changes Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 03:06:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 01:06:47 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #4 from Alex Buckley --- Created attachment 139697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139697&action=edit Bug 30418: Updated schema file Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 03:07:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 01:07:07 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #5 from Alex Buckley --- Created attachment 139698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139698&action=edit Bug 30418: Template and JavaScript changes Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 03:07:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 01:07:54 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #6 from Alex Buckley --- Created attachment 139699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139699&action=edit Bug 30418: Add ability for permitted staff to edit list contents Public lists with 'Allow changes to contents from' = 'Permitted staff only' can have their contents managed by Koha patrons with either of the permissions below: - superlibrarian permission - catalogue permission + 'edit_public_list_contents' sub-permission Test plan: 1. Apply patches, update database, restart services 2. In the staff client go to: Lists > New List 3. Create a list, choose 'Allow changes to contents from' => 'Permitted staff only' 4. Log into the OPAC as a patron with no permissions. 5. Confirm you CANNOT add a biblio to the list from the OPAC search result page and OPAC biblio detail pages 6. Log into the OPAC as a patron with only the 'catalogue' permissions enabled 7. Confirm you CANNOT add a biblio to the list from OPAC search result or biblio detail pages 8. Log into the OPAC as a patron with the 'catalogue' and 'edit_public_list_contents' permissions enabled 9. Confirm you CAN add/remove biblios from the OPAC search result and biblio detail pages 10. Log into the OPAC as a patron with superlibrarian permissions 11. Confirm you CAN add a biblio to the list from the OPAC search result page and OPAC biblio detail pages 12. Log into the staff client as a patron with only the 'catalogue' permission and confirm you CANNOT add/remove records from the list 13. Log into the staff client as a patron with the 'catalogue' and 'edit_public_list_contents' sub-permission (found under 'Lists' parent permission) 14. Confirm you CAN add/remove records from the list 15. Login into thestaff client as a patron with 'superlibrarian' permissions and confirm you CAN add/remove records from the list Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 03:08:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 01:08:15 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #7 from Alex Buckley --- Created attachment 139700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139700&action=edit Bug 30418: Unit tests Test plan: 1. Run unit tests sudo koha-shell prove t/db_dependent/Koha/Patron.t prove t/db_dependent/Virtualshelves.t Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 03:08:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 01:08:35 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #8 from Alex Buckley --- Created attachment 139701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139701&action=edit Bug 30418: Re-order options of who can edit list contents The 'Allow changes to contents from' dropdown when creating/edit lists should be most locked down to least locked down: 1. Nobody 2. Owner only 3. Permitted staff only 4. Staff only 5. Anyone seeing this list Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 03:32:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 01:32:16 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Add a new 'Permitted staff release notes| |only' option to public | |lists, allowing only | |permitted staff users to | |manage the list contents | |from the staff client and | |OPAC. | | | |The 'Permitted staff | |only' option differs from | |the 'Staff only' option | |because permitted staff are | |Koha patrons with the | |'catalogue' permission | |enabled and the new | |'edit_public_list_contents' | |sub-permission enabled. Change sponsored?|--- |Sponsored Status|ASSIGNED |Needs Signoff --- Comment #9 from Alex Buckley --- This is now ready to test. I have named the new 'Allow changes to contents from' dropdown option 'Permitted staff only'. I'm happy to change this naming to 'Staff with permissions' or other variations if you think it might clarify what it does. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 05:02:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 03:02:09 +0000 Subject: [Koha-bugs] [Bug 31442] Node.js v12 is EOL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31442 --- Comment #1 from Tomás Cohen Arazi --- node-sass doesn't seem to support Node v18 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 05:24:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 03:24:20 +0000 Subject: [Koha-bugs] [Bug 31446] New: Optionally hide lightbox_descriptions from OPAC lightbox gallery Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31446 Bug ID: 31446 Summary: Optionally hide lightbox_descriptions from OPAC lightbox gallery Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Since bug 28180 lightbox descriptions have displayed under cover images in the OPAC lightbox gallery. For example: 'Coce image from Amazon.com'. These descriptions are useful if there are multiple cover images in the lightbox gallery. But if there is only one image (for example the library only uses coce images, and not local cover images or other sources) then it would be useful to be able to optionally hide these descriptions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 05:24:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 03:24:40 +0000 Subject: [Koha-bugs] [Bug 31446] Optionally hide lightbox_descriptions from OPAC lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31446 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |alexbuckley at catalyst.net.nz Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 05:25:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 03:25:10 +0000 Subject: [Koha-bugs] [Bug 31446] Optionally hide lightbox_descriptions from OPAC lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31446 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |28180 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 05:25:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 03:25:10 +0000 Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31446 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31446 [Bug 31446] Optionally hide lightbox_descriptions from OPAC lightbox gallery -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 08:15:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 06:15:13 +0000 Subject: [Koha-bugs] [Bug 31447] New: "Please confirm checkout" notice uses patrons home library not holds pick up library Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447 Bug ID: 31447 Summary: "Please confirm checkout" notice uses patrons home library not holds pick up library Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: emmi.takkinen at koha-suomi.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When one tries to check out item which has hold in it, "Please confirm checkout" notice uses patrons home library instead of holds pick up library. It would be more logical to use latter here. To test: 1. Find record with holds. 2. For first priority hold, change it's pick up library to differ from patrons homebranch if needed. 3. Check out records item for a different patron. => Note that notice reads: "Item ... has been on hold for ... at [patrons homebranch] since ...". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 08:24:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 06:24:05 +0000 Subject: [Koha-bugs] [Bug 31427] Automatic renewal too_many error is confusing in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427 Spyros Pierros changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |spyros.pierros at gmail.com --- Comment #3 from Spyros Pierros --- In our case the loan period can't be shorten for any reason. The renewal routine seems that it examines every checkout of a patron and then the notice Auto renewals (Digest) reports that some items didn't renew, which is true, but this occurs because there is not any reason to be renewed or returned (they have been renewed yesterday for example), and this is so confusing. It should skip these items and to report only 1) the items that they have been renewed, and 2) the items that they haven't been renewed for a specific reason provided by the library rules. Furthermore, the selection of digest should stop the RENEWAL notice -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 08:36:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 06:36:21 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 Spyros Pierros changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |spyros.pierros at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 09:00:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 07:00:49 +0000 Subject: [Koha-bugs] [Bug 31448] New: Add option to re-send email receipt when UseEmailReceipts is enabled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31448 Bug ID: 31448 Summary: Add option to re-send email receipt when UseEmailReceipts is enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org We already have a 'Print' option in the actions available on transactions in the borrower accounts page. It would be nice to re-trigger the email receipt if UseEmailReceipts is enabled too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 09:30:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 07:30:49 +0000 Subject: [Koha-bugs] [Bug 31448] Add option to re-send email receipt when UseEmailReceipts is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31448 --- Comment #1 from Martin Renvoize --- Created attachment 139702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139702&action=edit Bug 31448: Replace 'Print' with 'Receipt' dropdown This patch replaces the 'Print' button with a 'Receipt' menu dropdown exposing 'Print' and 'Email' options when `UseEmailReceipts` is enabled Test plan 1. Enable `UseEmailReceipts` 2. Navigate to a patron with paid charges 3. Note the new dropdown 'Receipt' menu 4. Confirm 'Print' works as expected 5. Confirm 'Email' works as expected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 09:31:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 07:31:04 +0000 Subject: [Koha-bugs] [Bug 31448] Add option to re-send email receipt when UseEmailReceipts is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31448 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 09:33:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 07:33:19 +0000 Subject: [Koha-bugs] [Bug 31448] Add option to re-send email receipt when UseEmailReceipts is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31448 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Martin Renvoize --- I quickly threw this together as a counterpart to bug 30619 which adds the option to email from the UI for the Point Of Sale screen. Untested; I'll try to return to it soon, but wanted to leave it hear in case anyone wanted to continue in my absence. The 'fa-receipt' font icon doesn't work for some reason.. not sure why yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 09:34:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 07:34:15 +0000 Subject: [Koha-bugs] [Bug 31448] Add option to re-send email receipt when UseEmailReceipts is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31448 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30619 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 09:34:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 07:34:15 +0000 Subject: [Koha-bugs] [Bug 30619] Add the option to email receipts as an alternative to printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31448 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 09:34:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 07:34:43 +0000 Subject: [Koha-bugs] [Bug 30619] Add the option to email receipts as an alternative to printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 10:16:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 08:16:07 +0000 Subject: [Koha-bugs] [Bug 31371] Value builder for UNIMARC field 283 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31371 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 10:16:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 08:16:12 +0000 Subject: [Koha-bugs] [Bug 31372] Value builder for UNIMARC field 325 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31372 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 10:52:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 08:52:54 +0000 Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" notice uses patrons home library not holds pick up library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447 --- Comment #1 from Katrin Fischer --- Hi Emmi, I am not aware of a "Please confirm checkout" notice - which letter code would that be? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 10:55:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 08:55:45 +0000 Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" notice uses patrons home library not holds pick up library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447 --- Comment #2 from Emmi Takkinen --- (In reply to Katrin Fischer from comment #1) > Hi Emmi, I am not aware of a "Please confirm checkout" notice - which letter > code would that be? Sorry, I guess pop-up or dialog would have been better term. It's the yellow box that is displayed when on tries to check out item with a hold for another patron. The one with options to continue check out or cancel it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 11:20:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 09:20:31 +0000 Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses patron's home library not holds pick up library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"Please confirm checkout" |"Please confirm checkout" |notice uses patrons home |message uses patron's home |library not holds pick up |library not holds pick up |library |library --- Comment #3 from Katrin Fischer --- (In reply to Emmi Takkinen from comment #2) > (In reply to Katrin Fischer from comment #1) > > Hi Emmi, I am not aware of a "Please confirm checkout" notice - which letter > > code would that be? > > Sorry, I guess pop-up or dialog would have been better term. It's the yellow > box that is displayed when on tries to check out item with a hold for > another patron. The one with options to continue check out or cancel it. Ah! Yes, that makes sense, thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 11:56:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 09:56:49 +0000 Subject: [Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Emmanuel Bétemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Emmanuel Bétemps --- Hi, I just testried on a sandbox and it doesn't work step 11 displays the same results as in steps 8 & 9 : All/All rule is modified when I edit the All/Books rule -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 12:08:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 10:08:17 +0000 Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #11 from Martin Renvoize --- Created attachment 139703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139703&action=edit Bug 29987: Display credit without offsets in transactions This patch adds a row to the transactions table for credits without corresponding offsets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 12:10:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 10:10:22 +0000 Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from Martin Renvoize --- This is a somewhat horrible work around for how rowGroup works in datatables.. I'm considering some other approaches as part of converting the table to an ajax driven datatable... perhaps dropping rowGroup and instead triggering Ajax calls to populate the detailed breakdown rows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 12:25:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 10:25:06 +0000 Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #13 from Martin Renvoize --- Created attachment 139704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139704&action=edit Bug 29987: (follow-up) Fix missing payment type The payment type include has changed since the patch was first written, we now require a 'type' is passed to properly set the field name. This should fix the 'bankable' issue raised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 12:25:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 10:25:10 +0000 Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139703|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 139705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139705&action=edit Bug 29987: Display credit without offsets in transactions This patch adds a row to the transactions table for credits without corresponding offsets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 12:32:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 10:32:13 +0000 Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #15 from Martin Renvoize --- (In reply to David Nind from comment #8) > After testing this, signing off, and adding a draft release note, I noticed > that: > > 1. In the cash summary for the library, the amounts are now included in the > income (cash) total (good!). Correct, I believe this is as expected > 2. However, they are not included in the bankable column (bad?). Payment type was not being recorded correctly.. that is now fixed in the first follow-up. 'Cash' type transactions should be 'bankable' (I think I have a bug somewhere to make the types included in bankable configurable but for now it's cash only) > 3. In the details for the cash register, for transactions there is a total, > but it says "No data available in table" (and the same for the older > transactions). This is the second follow up patch.. though I've only implimented it for current transactions so far.. we can copy the logic to old transactions if we're happy it makes sense. > 4. If you do a cashup, these transactions are not included (if there are no > other cash transactions, then do a cashup the message is "Please confirm > that you have removed 0.00 from the cash register and left a float of > 0.00."). I think this should be fixed by the first follow-up above. > My query: If you receive cash (say, paying charges in advance) and create a > manual credit, then should it be included in items 2-4? > > I think it should, as when you go to do the banking you want it included in > that total so that everything reconciles. > > However, other manual credits, for example if you write off charges, > shouldn't be as you have neither added to or taken anything out of the cash > register. You are correct.. any process by which money actually changes hands at the register should be reported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 12:32:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 10:32:26 +0000 Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 12:34:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 10:34:56 +0000 Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139691|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize --- Created attachment 139706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139706&action=edit Bug 12225: Add unit tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 12:48:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 10:48:08 +0000 Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #27 from Martin Renvoize --- Nice one.. PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 12:55:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 10:55:26 +0000 Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139684|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize --- Created attachment 139707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139707&action=edit Bug 12225: Fix SIP message templates If a renewal via SIP would produce an error due to being on reserve, or exceeding maximum renewals, Koha's SIP2 implementation will refuse to renew the item even if the "no block" flag is set to Y. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 12:55:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 10:55:30 +0000 Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139685|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize --- Created attachment 139708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139708&action=edit Bug 12225: Re-implement no block flag for checkouts Test Plan ( assuming Koha Testing Docker or kohadevbox ): 1) Check out master 2) Start the SIP server ( edit the SIP config koha instutution to be "CPL" instead of "kohalibrary" ) 3) Telnet to 6001 4) Send 9300CNkoha|COkoha|CPCPL| 5) Send 11YY20220711 16350220250711 163502AOCPL|AA23529000035676|AB39999000001396|ACkoha|BON|BIN| 6) Note the due date for the checkout in Koha is not in the year 2025: Henry Acevedo (23529000035676) checked out Philippics. by Cicero, Marcus Tullius. 39999000001396 7) Apply this patch set 8) Restart all the things! 9) Check in the checkout 10) Repeat steps 3 through 5 11) Note the due date is now in 2025! Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 12:55:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 10:55:34 +0000 Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139686|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize --- Created attachment 139709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139709&action=edit Bug 12225: Use ProcessOfflineIssue Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 12:55:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 10:55:39 +0000 Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139706|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize --- Created attachment 139710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139710&action=edit Bug 12225: Add unit tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 13:08:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 11:08:48 +0000 Subject: [Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #7 from Katrin Fischer --- Did you install the translations before or after the patch was applied? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 13:09:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 11:09:02 +0000 Subject: [Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 13:40:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 11:40:46 +0000 Subject: [Koha-bugs] [Bug 30472] Field borrower_relationships.guarantor_id should be marked as NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30472 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 13:40:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 11:40:50 +0000 Subject: [Koha-bugs] [Bug 30472] Field borrower_relationships.guarantor_id should be marked as NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30472 --- Comment #1 from Marcel de Rooy --- Created attachment 139711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139711&action=edit Bug 30472: Make borrower_relationships.guarantor_id not null In harmony with dbrev 19.06.00.022. Test plan: Run dbrev. Run t/db_dependent/Patron/Relationships.t Run t/db_dependent/Koha/Patrons.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 13:41:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 11:41:37 +0000 Subject: [Koha-bugs] [Bug 30472] Field borrower_relationships.guarantor_id should be marked as NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30472 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #2 from Marcel de Rooy --- Trivial, architectural (db admin). Self signoff. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 13:42:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 11:42:01 +0000 Subject: [Koha-bugs] [Bug 30472] Field borrower_relationships.guarantor_id should be marked as NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30472 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 13:42:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 11:42:11 +0000 Subject: [Koha-bugs] [Bug 30472] Field borrower_relationships.guarantor_id should be marked as NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30472 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 13:42:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 11:42:44 +0000 Subject: [Koha-bugs] [Bug 30472] Field borrower_relationships.guarantor_id should be marked as NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30472 --- Comment #3 from Marcel de Rooy --- RM: Take care of DBIx please. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 14:04:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 12:04:25 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: which fields should be NOT NULL ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|30486 | --- Comment #3 from Marcel de Rooy --- Here is the first kohastructure.sql from our git repo for z3950servers: DROP TABLE IF EXISTS `z3950servers`; CREATE TABLE `z3950servers` ( `host` varchar(255) default NULL, `port` int(11) default NULL, `db` varchar(255) default NULL, `userid` varchar(255) default NULL, `password` varchar(255) default NULL, `name` mediumtext, `id` int(11) NOT NULL auto_increment, `checked` smallint(6) default NULL, `rank` int(11) default NULL, `syntax` varchar(80) default NULL, `icon` text, `position` enum('primary','secondary','') NOT NULL default 'primary', `type` enum('zed','opensearch') NOT NULL default 'zed', `description` text NOT NULL, PRIMARY KEY (`id`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8; Encoding was added later: $DBversion = "3.00.00.049"; $dbh->do("ALTER TABLE `z3950servers` ADD `encoding` text default NULL AFTER type "); Conclusion: I must have changed these fields myself somehow. Although it seems the right thing, it is NOT a sync problem. Removing the omnibus reference. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486 [Bug 30486] [OMNIBUS] Synchronize database schema with (older) database revisions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 14:04:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 12:04:25 +0000 Subject: [Koha-bugs] [Bug 30486] [OMNIBUS] Synchronize database schema with (older) database revisions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|30571 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 [Bug 30571] Table z3950servers: which fields should be NOT NULL ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 14:33:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 12:33:22 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: which fields should be NOT NULL ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |trivial Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 14:33:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 12:33:54 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: Make host, syntax and encoding NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Table z3950servers: which |Table z3950servers: Make |fields should be NOT NULL ? |host, syntax and encoding | |NOT NULL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 14:34:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 12:34:03 +0000 Subject: [Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #8 from Emmanuel Bétemps --- (In reply to Katrin Fischer from comment #7) > Did you install the translations before or after the patch was applied? I just followed the test plan : translation (french) installed before applying the patch. I can try applying the patch before installing the language. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 15:00:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 13:00:38 +0000 Subject: [Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112110|0 |1 is obsolete| | --- Comment #8 from Shi Yao Wang --- Created attachment 139712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139712&action=edit Bug 26598: Display guarantee's fines on guarantor's details page A new tab is added to the details page of a patron to show, in a table, the fines of the patron's guarantees. A warning appears in the "Guarantees" section of the patron to make it obvious that fines exists. To test: 1) Apply patch 2) Choose a patron that has guarantees and navigate to the patron's details page 3) If the guarantees don't have any fines, the display should be unchanged 4) Add fines to the guarantee 5) Go back to the guarantor's details page => A warning should appear in the "Guarantees" section with the total due 6) Clicking on the link accompanying the warning focuses on the new "Guarantees' fines" tab containing a table of all guarantee's and their fines. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 15:01:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 13:01:58 +0000 Subject: [Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |shi-yao.wang at inLibro.com Assignee|maryse.simard at inlibro.com |shi-yao.wang at inLibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 15:21:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 13:21:58 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 15:22:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 13:22:42 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #102 from Martin Renvoize --- Discussed with Tomas and he's happy for it to go PQA given it's had both Joonas's and my eyes on it. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 15:35:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 13:35:22 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #103 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #100) > Please QA this one or otherwise I will do it ;) Miracles happen :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 15:57:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 13:57:09 +0000 Subject: [Koha-bugs] [Bug 31449] New: Self checkout: Wrong password reloads page without any feedback Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31449 Bug ID: 31449 Summary: Self checkout: Wrong password reloads page without any feedback Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When the user enters a wrong Login/password combination on the self checkout page, the page reloads and there is no feedback. It would be better if this was more like the OPAC login, asking the user to "try again, because something was wrong". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 15:57:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 13:57:27 +0000 Subject: [Koha-bugs] [Bug 31449] Self checkout: Wrong password reloads page without feedback In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31449 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Self checkout: Wrong |Self checkout: Wrong |password reloads page |password reloads page |without any feedback |without feedback -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 15:59:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 13:59:08 +0000 Subject: [Koha-bugs] [Bug 30658] (Bug 29496 follow-up) CheckMandatorySubfields don't work properly with select field in serials-edit.tt for Supplemental issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30658 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 16:21:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 14:21:47 +0000 Subject: [Koha-bugs] [Bug 31450] New: HTML customizations and News will not display on OPAC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450 Bug ID: 31450 Summary: HTML customizations and News will not display on OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: -Create some HTML Customizations and some News item that are set to display on the OPAC. -Go to the OPAC and notice none of these display. Possibly from Bug 15326? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 16:24:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 14:24:03 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: Make host, syntax and encoding NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 16:24:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 14:24:06 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: Make host, syntax and encoding NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 --- Comment #4 from Marcel de Rooy --- Created attachment 139713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139713&action=edit Bug 30571: Table z3950servers: Make host, syntax and encoding NOT NULL This is not a sync issue between structure and db revs. It just seems a logical move. Note that the interface for long does not allow these fields to be empty. Test plan: Run dbrev. Add a new Z3950/SRU server. Verify if it works as expected. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 16:24:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 14:24:09 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: Make host, syntax and encoding NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 --- Comment #5 from Marcel de Rooy --- Created attachment 139714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139714&action=edit Bug 30571: (DBIx schema) Update for Z3950server.pm No test plan. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 16:24:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 14:24:13 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: Make host, syntax and encoding NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 --- Comment #6 from Marcel de Rooy --- Created attachment 139715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139715&action=edit Bug 30571: Z3950Servers.t - Create subtest for existing tests No real changes, just moving code and indentation. Ground work for following patch. Test plan: To let the test pass, disable strict_mode in koha-conf. Run perl t/db_dependent/Koha/Z3950Servers.t. Should pass now. However, in strict mode or with prove, it should fail. Run prove t/db_dependent/Koha/Z3950Servers.t. Failed? Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 16:24:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 14:24:17 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: Make host, syntax and encoding NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 --- Comment #7 from Marcel de Rooy --- Created attachment 139716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139716&action=edit Bug 30571: Z3950Servers.t - Add another subtest Subtest for testing nullability of host, syntax and encoding. Test plan: Run prove t/db_dependent/Koha/Z3950Servers.t. (Note: you need strict mode to pass this test.) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 16:26:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 14:26:07 +0000 Subject: [Koha-bugs] [Bug 31342] process_message_queue can run over the top of itself causing double-up emails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31342 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #5 from Liz Rea --- As someone who has experienced both conditions, from the point of view of libraries I've had experience with, they'd rather get no mails than two. Double mails says to library patrons "the library doesn't know what they are doing and their system sucks" - no mail says "the internet is glitchy," which is true. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 16:31:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 14:31:53 +0000 Subject: [Koha-bugs] [Bug 31342] process_message_queue can run over the top of itself causing double-up emails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31342 --- Comment #6 from Liz Rea --- More succinctly: double mail is a PR problem, no mail is less so. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 16:33:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 14:33:56 +0000 Subject: [Koha-bugs] [Bug 23757] Able to delete patron expiration date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23757 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org --- Comment #3 from Andrew Fuerste-Henry --- +1, yes please, we would like Koha to auto-calculate new expiration dates when clearing existing dates via batch patron modification. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 16:36:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 14:36:08 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: Make host, syntax and encoding NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 16:36:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 14:36:41 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: Make host, syntax and encoding NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 --- Comment #8 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #3) > Removing the omnibus reference. And moved to enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 16:57:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 14:57:51 +0000 Subject: [Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #9 from Emmanuel Bétemps --- I tested applying the patch and, after, installing the language. Patch works better but some things bother me 1.I click on "Circulation and fines rules" 2.I click on the Edit button to modify "All / Books" 3. I save my changes -> I really modify "All / Books" -> the bottom line (i.e the one where we write our changes) resets But sometimes, if I don't want to save my changes, I click on another line to edit (Koha asks me then if I am sure) but it doesn't change the bottom line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 16:58:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 14:58:21 +0000 Subject: [Koha-bugs] [Bug 30242] Allow changing Mojolicious log level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30242 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #4 from Marcel de Rooy --- Revisiting this one. koha-plack if [ "$DEV_INSTALL" = "1" ]; then # Maybe we should switch off debug_mode if DEV_INSTALL is not set? environment="development" fi if [ "$debug_mode" = "yes" ]; then environment="development" koha-conf 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 17:23:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 15:23:12 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139649|0 |1 is obsolete| | --- Comment #320 from Martin Renvoize --- Created attachment 139717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139717&action=edit Bug 23681: Move to ::Patron::Restriction::Type(s) This patch moves the new classes under ::Patron::Restriction:: and enhances the Unit tests for those classes. NOTE: We should drop keyed_on_code as part of bug 31095 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 17:23:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 15:23:20 +0000 Subject: [Koha-bugs] [Bug 31259] Downloading patron card PDF hangs the server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31259 Michael Adamyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madamyk at ckls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 17:23:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 15:23:37 +0000 Subject: [Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133404|0 |1 is obsolete| | --- Comment #10 from Shi Yao Wang --- Created attachment 139718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139718&action=edit Bug 30517: Translation breaks editing parent type circulation rule fix Test plan: 1. Install another language in the staff interface 1. in commandline: `cd misc/translator/; ./translate install xx-XX` 2. Check the box of the language in the 'language' system preference and save 3. Refresh and you should be able to choose languages 2. Create an item type with a parent 1. Go to Administration > Item types 2. Create a new item type or modify an existing one, assigning a parent type (I created a 'Children's books' type and assigned 'Books' as its parent) 3. Create a circulation rule for the parent type (I created All/Books, with 10 checkouts allowed) 4. Create a circulation rule for All/All (I created All/All with 30 checkouts allowed) 5. In English, click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row (the modifiable row) is changed to 'Books (All)' 6. Modify the number of checkouts allowed (e.g. 99) --> The All/Books rule is modified 7. Switch the interface to the other language 8. Click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row stays on 'All' 9. Modify the number of checkouts allowed (e.g. 88) --> The All/All rule is modified 10. Apply the patch, translate again and refresh the page 11. Do step 8-9 again and notice it now behaves as it should -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 17:24:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 15:24:27 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139614|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 139719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139719&action=edit Bug 31095: Add Koha::Patron::Restriction(s) Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 17:24:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 15:24:31 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #3 from Martin Renvoize --- Created attachment 139720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139720&action=edit Bug 31095: Add restrictions accessor to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 17:24:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 15:24:34 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #4 from Martin Renvoize --- Created attachment 139721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139721&action=edit Bug 31095: Add type relation accessor to Koha::Patron::Restriction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 17:24:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 15:24:38 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #5 from Martin Renvoize --- Created attachment 139722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139722&action=edit Bug 31095: Remove GetDebarments from circ/circulation.pl This patch remove the use of GetDebarments from circ/circulation.pl, replacing it with a reference to patron.restrictions in the template and includes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 17:24:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 15:24:41 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #6 from Martin Renvoize --- Created attachment 139723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139723&action=edit Bug 31095: Remove GetDebarments from members/moremember.pl This patch removes the use of GetDebarments from members/moremember.pl and replaces template references with patrons.restrictions and the new includes introduced in the prior patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 17:24:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 15:24:44 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #7 from Martin Renvoize --- Created attachment 139724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139724&action=edit Bug 31095: Remove GetDebarments from members/memberentry.pl This patch removes the use of GetDebarments from members/memberentry.pl and replaces the references in the templates with patron.restrictions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 17:24:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 15:24:48 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #8 from Martin Renvoize --- Created attachment 139725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139725&action=edit Bug 31095: Remove borrower_debarments and patron_restrictions includes This patch removes the aforementioned includes and drops the last remaining reference to them. We have replaces these includes with patron-restrictions-tab.inc and restriction-types.inc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 17:24:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 15:24:52 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #9 from Martin Renvoize --- Created attachment 139726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139726&action=edit Bug 31095: Remove keyed_on_code We no longer require keyed_on_code from Koha::Patron::Restrictoin::Types as we have relation accessors for the relevent use cases and no longer reference the method anywhere in the codebase! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 17:30:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 15:30:03 +0000 Subject: [Koha-bugs] [Bug 31451] New: Can the display order be applied incrementally for item groups Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31451 Bug ID: 31451 Summary: Can the display order be applied incrementally for item groups Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When creating an item group, we can assign the display order. When assigning the display order, could Koha add the display order incrementally? If a library has Item Group A, Display order 1, Item Group B, Display order 2. When the library creates a new group, Koha will incrementally add display 3 automatically would be nice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 17:31:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 15:31:20 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #10 from Martin Renvoize --- Created attachment 139727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139727&action=edit Bug 31095: Remove GetDebarments from tools/modborrowers.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 17:35:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 15:35:11 +0000 Subject: [Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #11 from Shi Yao Wang --- Updated the test plan to make it a bit more clear. (In reply to Emmanuel Bétemps from comment #9) > I tested applying the patch and, after, installing the language. > > Patch works better but some things bother me > > > 1.I click on "Circulation and fines rules" > 2.I click on the Edit button to modify "All / Books" > 3. I save my changes > -> I really modify "All / Books" > -> the bottom line (i.e the one where we write our changes) resets > > But sometimes, if I don't want to save my changes, I click on another line > to edit (Koha asks me then if I am sure) but it doesn't change the bottom > line. I do not seem to have this problem. What I did after the test plan: 1- Go to Administration -> Circulation and fines rules 2- Click edit button for "All / Books" 3- Modify "Checkouts allowed" to a different number 4- Click on edit button for "All / All" without saving 5- Click ok on the confirmation popup 6- Bottom line's information change to "All / All" circulation rule values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 17:48:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 15:48:27 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #11 from Martin Renvoize --- Created attachment 139728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139728&action=edit Bug 31095: Remove GetDebarments from Circulation.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 17:49:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 15:49:08 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #12 from Martin Renvoize --- Needs a thorough test plan.. I'm considering breaking the removal up.. one method at a time as this bug is already growing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 17:49:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 15:49:26 +0000 Subject: [Koha-bugs] [Bug 31349] Add option to not update items.permanent_location when editing items.location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31349 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add option to not update |Add option to not update |items.permenent_location |items.permanent_location |when editing items.location |when editing items.location -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 17:52:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 15:52:08 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #13 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #12) > Needs a thorough test plan.. I'm considering breaking the removal up.. one > method at a time as this bug is already growing. Go for it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 17:56:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 15:56:26 +0000 Subject: [Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #12 from Katrin Fischer --- (In reply to Emmanuel Bétemps from comment #9) > I tested applying the patch and, after, installing the language. > > Patch works better but some things bother me > > > 1.I click on "Circulation and fines rules" > 2.I click on the Edit button to modify "All / Books" > 3. I save my changes > -> I really modify "All / Books" > -> the bottom line (i.e the one where we write our changes) resets > > But sometimes, if I don't want to save my changes, I click on another line > to edit (Koha asks me then if I am sure) but it doesn't change the bottom > line. When you install a language it copies the templates and files. So if you install the patch first, you'll look at unchanged/old templates that don't have the patch. You probably also need to make sure that "all" has been translated to something else in that language. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 17:58:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 15:58:31 +0000 Subject: [Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #13 from Katrin Fischer --- > > When you install a language it copies the templates and files. So if you > install the patch first, you'll look at unchanged/old templates that don't > have the patch. > You probably also need to make sure that "all" has been translated to > something else in that language. That should have read...: so if you install the language first... because installing the patch will then only update the English files and not trigger updating the translated files as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 18:44:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 16:44:43 +0000 Subject: [Koha-bugs] [Bug 31452] New: Attach item process allows for deleting of bib with holds with no warning Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31452 Bug ID: 31452 Summary: Attach item process allows for deleting of bib with holds with no warning Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Record A has one item on it, and a bib level hold. Using the Attach Item process, move the item from A to Record B. You are given the message that Record A has no items attached and offers the option to delete the bib. If you click Delete, there is no warning that there are holds on the bib you are about to delete, and you are allowed to delete the bib. Typical behavior in Koha is to warn/stop the deletion if there are holds on the bib, it would be great to add that consistency to this process. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 19:13:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 17:13:27 +0000 Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 19:13:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 17:13:31 +0000 Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139492|0 |1 is obsolete| | Attachment #139493|0 |1 is obsolete| | Attachment #139494|0 |1 is obsolete| | Attachment #139495|0 |1 is obsolete| | Attachment #139622|0 |1 is obsolete| | Attachment #139623|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 139729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139729&action=edit Bug 31112: Remove unnecessary if-clause To test: 1) Please check manually that the logic stays the same, use git's -w command line parameter to ignore whitespace changes in the diff output. 2) prove t/db_dependent/Circulation.t Signed-off-by: Sally Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 19:13:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 17:13:58 +0000 Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #19 from Kyle M Hall --- Created attachment 139730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139730&action=edit Bug 31112: CanBookBeRenewed: take into account patrons with more than 1 hold to a biblio If a single patron had more than 1 hold to a biblio and there was only one available item we allowed incorrectly renewing the checkout when AllowRenewalIfOtherItemsAvailable was set to "Allow". This changes CanBookBeRenewed so that it makes sure all the holds are filled and not just one per patron. To test: 1) prove t/db_dependent/Circulation.t 2) (Optional, as unit test is provided) - Set AllowRenewalIfOtherItemsAvailable = Allow - Create biblio with three items - Checkout one item to patron A - Add two biblio-level holds for patron B - Try to renew patron A's checkout with and without this patch. - Notice that without this patch the renewal succeeds even though we one unfilled hold left. After applying the patch the renewal should fail. Signed-off-by: Sally Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 19:14:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 17:14:02 +0000 Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #20 from Kyle M Hall --- Created attachment 139731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139731&action=edit Bug 31112: (QA follow-up) Restore check to avoid extra processing We now count all holds for all patrons, we can still eject if we have more holds than we do items Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 19:14:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 17:14:05 +0000 Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #21 from Kyle M Hall --- Created attachment 139732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139732&action=edit Bug 31112: (QA follow-up) Fetch patrons with reserves Previously we fetched all in a single call using biblionumbers Fetching each individually could be a performance hit on systems with large numbers of holds Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 19:14:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 17:14:08 +0000 Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #22 from Kyle M Hall --- Created attachment 139733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139733&action=edit Bug 31112: (follow-up) Bring back the check for non-priority holds Before the changes from bug 31112 when CheckReserves returned a non-priority hold we didn't return "on_reserve" status but checked in addition to that whether there are any priority holds and if there were, only then we returned the "on_reserve" error. Signed-off-by: Joonas Kylmälä Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 19:14:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 17:14:12 +0000 Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #23 from Kyle M Hall --- Created attachment 139734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139734&action=edit Bug 31112: (follow-up) Don't return "on_reserve" when there are 0 possible holds It's possible that there could be 0 possible reserves, for example when the hold has already been filled, thus the check would fail as the item count can never be less than 0. Signed-off-by: Joonas Kylmälä Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 19:14:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 17:14:15 +0000 Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #24 from Kyle M Hall --- Created attachment 139735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139735&action=edit Bug 31112: (QA follow-up) Reduce database queries Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 19:54:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 17:54:35 +0000 Subject: [Koha-bugs] [Bug 31453] New: Add ability to skip processing messages in message queue based on message contents Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31453 Bug ID: 31453 Summary: Add ability to skip processing messages in message queue based on message contents Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz It would be very useful to be able to tell process_message_queue.pl to skip processing some messages. This is particularly useful where a plugin handles sending some message using the before_send_messages hook, but while that plugin is processing, more messages meant for the plugin might be queued. At that point, control moves back to the script and SendQueuedMessages is called, and those messages end up being processed there instead of by the plugin. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 19:54:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 17:54:41 +0000 Subject: [Koha-bugs] [Bug 31453] Add ability to skip processing messages in message queue based on message contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31453 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 20:18:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 18:18:53 +0000 Subject: [Koha-bugs] [Bug 10374] Clean up and unify CircControl related code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10374 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 20:33:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 18:33:04 +0000 Subject: [Koha-bugs] [Bug 30254] New overdue fine applied to incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30254 Sara Brown changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbrown at bywatersolutions.com --- Comment #2 from Sara Brown --- This remains an issue in 21.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 20:35:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 18:35:50 +0000 Subject: [Koha-bugs] [Bug 31453] Add ability to skip processing messages in message queue based on message contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31453 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 20:35:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 18:35:53 +0000 Subject: [Koha-bugs] [Bug 31453] Add ability to skip processing messages in message queue based on message contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31453 --- Comment #1 from Kyle M Hall --- Created attachment 139736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139736&action=edit Bug 31453: Add ability to skip processing messages in message queue based on message contents It would be very useful to be able to tell process_message_queue.pl to skip processing some messages. This is particularly useful where a plugin handles sending some message using the before_send_messages hook, but while that plugin is processing, more messages meant for the plugin might be queued. At that point, control moves back to the script and SendQueuedMessages is called, and those messages end up being processed there instead of by the plugin. Test Plan: 1) Apply this patch 2) Queue two messages, each with a unique word 3) Run process_message_queue --content-not-like "WORD" where WORD is a unique word in one of the two message 4) Note the message containing "WORD" was not processed 5) prove t/db_dependent/Letters.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 20:41:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 18:41:03 +0000 Subject: [Koha-bugs] [Bug 30412] Separate shelving location column in holdings table in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30412 --- Comment #5 from Sara Brown --- Table settings don't allow for a separate 'Shelving location' column in the staff interface - there isn't an option to select that as its own column. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 20:44:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 18:44:00 +0000 Subject: [Koha-bugs] [Bug 31436] AllowRenewalIfOtherItemsAvailable should not take suspended holds into account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31436 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 20:59:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 18:59:22 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 21:02:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 19:02:45 +0000 Subject: [Koha-bugs] [Bug 31454] New: Ability to update multiple subscriptions at once Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31454 Bug ID: 31454 Summary: Ability to update multiple subscriptions at once Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: sbrown at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It would be useful to be able to batch renew and/or batch update details for multiple subscriptions for the same serials title. Libraries with subscriptions to the same title for multiple branches/locations currently have to repeat the renewal/editing/any steps to account for irregularities (bug 17656) many times over, which introduces room for error and can quickly get time-consuming. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 21:03:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 19:03:09 +0000 Subject: [Koha-bugs] [Bug 31454] Ability to update multiple subscriptions at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31454 Sara Brown changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17656 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 21:03:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 19:03:09 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Sara Brown changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31454 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 21:40:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 19:40:02 +0000 Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 Amanda Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acampbell at hmcpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 22:26:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 20:26:21 +0000 Subject: [Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|HTML customizations and |HTML customizations and |News will not display on |News will not display on |OPAC |OPAC without Publication | |date -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 22:27:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 20:27:38 +0000 Subject: [Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450 --- Comment #1 from Lucas Gass --- I see that this only happens when I do not set a "Publication date:". That makes sense for News, but HTML customizations should not required a Publication date or an Expiration date -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 22:46:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 20:46:36 +0000 Subject: [Koha-bugs] [Bug 31454] Ability to update multiple subscriptions at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31454 --- Comment #1 from Katrin Fischer --- Hi Sarah, it's possible to renew multiple subscriptions at once: * Serials * Check expiration * Search for the title * Select all - renew selected subscriptions There is also a batch edit feature: * Serials * Search subscriptions * Check the ones you want to edit * Click 'edit selected serials' I have filed bug 31230 a while ago to add more fields to it. The irregularities problem should hopefully be resolved by 17656. Does this help or more: what is missing from the current functionality? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 22:49:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 20:49:42 +0000 Subject: [Koha-bugs] [Bug 30412] Separate shelving location column in holdings table in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30412 --- Comment #6 from Katrin Fischer --- Yes, I changed the bug title to make clear this is about the staff interface. I left the note just in case. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 23:07:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 21:07:34 +0000 Subject: [Koha-bugs] [Bug 19684] Colon char in MARC data breaks facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19684 --- Comment #9 from Fridolin Somers --- Arf limit may contain serveral blocks. Maybe we should move this replacement in : foreach my $this_limit (@limits) { -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 23:32:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 21:32:24 +0000 Subject: [Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073 --- Comment #31 from Thomas Dukleth --- Using Debian 8 for database migration from Postgres to MySQL avoids warnings and errors from pg_restore which is better than having some potential unidentified problem. The MySQL wiki dump is copied from Debian 8 to Debian 10 or 11. Debian 10 has been tested for wiki upgrade using the MySQL wiki dump from and should work with Debian 11. A test run of the Canasta MediaWiki Docker image for fairly fulsome use of MediaWiki pending. If the test run with Canasta works, we should upgrade for production the next available day. Code and configuration files to test migrating the MediaWiki database and upgrading the wiki are currently available at the same location, git://test01.agogme.com/koha-migrate-mwiki-db-and-upgrade-test.git . Files excluded as inappropriate for version control are currently available at the same location, https://test01.agogme.com/koha-migrate-mwiki-db-and-upgrade-test.tgz . Anyone interested in testing the code would need to separately obtain a full dump of the Koha Wiki to avoid publicly compromising Koha Wiki usernames and passwords which are not contained in the published archive. The issue of resetting wgSecretKey in LocalSettings.php could be avoided by obtaining a copy of the Koha Wiki LocalSettings.php . I have prepared a special nonpublic tar archive for Koha developers interested in testing. Please note as before that newly reinstalled MediaWiki instances take time for indexing etc. to catch up over multiple days and indexing requires actual use to weight the result set properly. They may frequently go down or become slow when: regenerated for code testing; or excess RAM or CPU use running some memory intensive processes unrelated to Koha on the VPS. Non-Koha use of the VPS starting too many processes still occasionally leads the OOM killer to stop mysqld for which I should add a monitoring and restart service for when I forget to check after such excess RAM usage. Reinstalled test instance of the Koha Wiki using Postgres on Debian 8 with Nginx at https://koha-mw-pg-test02.agogme.com/ . Koha test wiki migrated to MySQL on Debian 8 with Nginx at https://koha-mw-my-test02.agogme.com/ . Koha MySQL test wiki upgraded to MediaWiki 1.35 LTS on Debian 10 with Nginx at https://koha-mw-my-test00-upgr.agogme.com/ . We will likely continue to use Apache in production until or unless we have the resolution for wiki full image page working in Ngnix which currently returns a 404 error for such pages. For any deficiency of Nginx, try Apache by adding port 9443 to any page such as https://koha-mw-my-test00-upgr.agogme.com:9443/wiki/Some_Page . MediaWiki configuration will force the port back to the port back to the configured HTTPS port 443 and does not support running the same wiki instance simultaneously for different webservers on different ports. Please note that some adjustment of the upgraded wiki, such as the superseded language change template at the bottom of the home page, may be outside the ordinary scope of an automated upgrade process and require manual correction. The job queue may be full for an extended period after reinstalling or upgrading a test wiki instance because reindexing is necessary. Ordering of search query result set improves with actual use but may be partly ordered by page creation initially after reindexing rather than page modification or other potentially more useful relevancy ranking which develops over time as the wiki instance is used. Postgres based queries to which we may be accustomed do automatic word stemming and index page titles. MySQL based MediaWiki allows support for many options including Apache Lucene indexing via Elastic Search or Open Search. Dynamic archiving to exclude obsolete pages using "-[[Category:Obsolete]]" requires all pages to have at least one category which is generally necessary in any case even if there is insufficient time to select an appropriate category assigning a placeholder category for category unselected such as [[Category:Empty]] would be helpful which can later be replaced with an appropriate choice. >From the current changelog. In /etc examples ---------------- Moved example files in the /etc directory to os-variants directory for Debian version specific use. In README.txt ------------- Added apt instruction for packages libconfig-simple-perl rsync gnupg postgresql-contrib libdbd-pg-perl python python-psycopg2 python-mysqldb python3 . Added additional package installation for several php and other packages which had been configured manually in advance of previous testing where they had been selected from packages filing requirements for the Debian distribution mediawiki package. Correction for Debian 10 and later substitute libnode-dev for nodejs-dev . Added os-variants. Added tested operating system version divided use where database migration from Postgres to MySQL is done in Debian 8 to avoid warnings and errors from using pg_restore for restoring the Postgres production database starting point. Wiki upgrade is then done on Debian 10 which has been tested using the MySQL databse dumped from Debian 8. Upgrade could also be done on Debian 11 untested. Clarified language and instruction variously. In koha_migrate_mwiki_db_and_upgrade.ini --------------------------------------- Added human readable postupgrade MySQL dump path. In koha-migrate-mwiki-db-and-upgrade-startup.sh ----------------------------------------------- Added support for additional necessary automatic package installation for libconfig-simple-perl . Added option for using database dump from old operating system version. Added upgrade option now used for automated upgrade. In koha-migrate-mwiki-db-and-upgrade.pl --------------------------------------- Changed use of underscore to hyphen for automatically created Apache Casandra apt repository list file. Added support for additional necessary automatic package installation for rsync gnupg libdbd-pg-perl python-psycopg2 python-mysqldb. Corrected misspelling with extra dash in automated installation of packages php5.6-mysql php5.6-pgsql php7.4-mysql php7.4-pgsql . Added support for additional necessary automatic package installation for several php and other packages which had been configured manually in advance of previous testing where they had been selected from packages filing requirements for the Debian distribution mediawiki package. Correction for Debian 10 and later substitute libnode-dev for nodejs-dev . Corrected for some instances missing apt-get -y option to ensure package installation works non-interactively. Corrected automated Apache configuration for Debian 8 using php-fpm. Commented out call to koha-mediawiki-mysql-alter-col-for-migration-from-postgres.sql . Added os-variants directory for installation use. Added option for using database dump from old operating system version. Added upgrade option now used for automated upgrade. Added additional postupgrade MySQL dumps. In koha-mediawiki-pgsqltomysql.py --------------------------------- Corrected for file exists error when creating a directory which already exists for log files. Activated additional file truncation code to avoid need to increase any column sizes as the Perl script call to koha-mediawiki-mysql-alter-col-for-migration-from-postgres.sql is now commented out. In koha-mwiki-instances-postinstall.sh -------------------------------------- Added prospective --server argument to update.php calls to avoid possible "PHP Notice: Undefined index: SERVER_NAME". In LocalSettings.php -------------------- Added !isset condition for REMOTE_ADDR to update.php reporting "PHP Notice: Undefined index: REMOTE_ADDR". Moved LocalSettings.php files to os-variants directory. In koha-migrate-mwiki-db_and-upgrade-forexport.sh ------------------------------------------------- Added path variables for files in os-variants directory. ------------------------------------------ Pending Bug Fixes. Full View of Saved Files Not Displaying. The full view of image files in the form of /wiki/File:some_file are not displaying. The suggested Nginx fix requires more attention. The easy workaround is to revert to Apache. Maintenance Job Control. I added some support for running MediaWiki maintenance/runJobs.php to the post install shell script for MediaWiki test instances but I need to add control for maintenance/runJobs.php as an additional separate recurring process which is actually fairly trivial. Using the Canasta Docker image for MediaWiki provides some convenient default configuration for some things such as job control. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 23:39:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 21:39:35 +0000 Subject: [Koha-bugs] [Bug 31455] New: Batch modification tool orders found items by itemnumber Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31455 Bug ID: 31455 Summary: Batch modification tool orders found items by itemnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When using the batch mod tools and entering in a set of barcodes the table of found items is ordered by itemnumber instead of by the order in which the barcodes were scanned. This is a problem for librarians who scan a batch of books and then get a table ordered completely different. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 23:40:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 21:40:14 +0000 Subject: [Koha-bugs] [Bug 31455] Batch modification tool orders found items by itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31455 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28445 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 [Bug 28445] Use the task queue for the batch delete and update items tool -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 24 23:40:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 21:40:14 +0000 Subject: [Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31455 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31455 [Bug 31455] Batch modification tool orders found items by itemnumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 01:27:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Aug 2022 23:27:50 +0000 Subject: [Koha-bugs] [Bug 19684] Colon char in MARC data breaks facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19684 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 02:45:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 00:45:53 +0000 Subject: [Koha-bugs] [Bug 31376] Input type email in system preferences prevents multiple addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31376 --- Comment #2 from David Cook --- This isn't something I'm likely to work on, but I was looking at the "email" input type today for other reasons, and I did notice that you can provide a "multiple" attribute to provide a list of comma separated email addresses: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/email#multiple Although if you do that, then the "required" attribute doesn't work anymore. That would be OK for system preferences like NoticeBcc but not for other fields (like self-registration or borrower modification). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 04:59:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 02:59:23 +0000 Subject: [Koha-bugs] [Bug 31415] Script to automate converting reserves to recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 04:59:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 02:59:27 +0000 Subject: [Koha-bugs] [Bug 31415] Script to automate converting reserves to recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139646|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia --- Created attachment 139737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139737&action=edit Bug 31415: Script to automate converting reserves to recalls This patch adds a script which can be used to automatically convert the oldest reserve on a record to a recall, if there are a specified minimum number of reserves on the record. To test: 1) Enable UseRecalls and configure circulation rules relevant to recalls. Keep the 'on shelf recalls allowed' setting to 'any' for the sake of testing ('all' would require all items to be checked out for the reserve to be converted to a recall) 2) Check out items from multiple records (at least 2 different records) to Patron A. 3) Place multiple reserves on each record (at least 2 reserves). 4) Place multiple reserves on another record which has no items checked out. 5) We now have multiple records where the oldest reserve is eligible for recall, plus a record where the oldest reserve is NOT eligible for recall (because no items are checked out). 6) In your terminal, get into the shell and run the script. -v means verbose and will print the reserves that are converted into recalls. --min 1 means there must be more than 1 reserve on the record to be considered. sudo koha-shell INSTANCE perl misc/cronjobs/recalls/convert_reserves_to_recalls.pl -v --min 1 7) Confirm that, for the records where items are checked out and there are multiple reserves, the oldest reserve was converted into a recall 8) Confirm that, for the record where no items are checked out, the reserves all remain and not converted into a recall. 9) Confirm documentation for the script looks good perldoc misc/cronjobs/recalls/convert_reserves_to_recalls.pl Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 04:59:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 02:59:51 +0000 Subject: [Koha-bugs] [Bug 31415] Script to automate converting reserves to recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds a script release notes| |which can be used to | |automatically convert the | |oldest reserve on a record | |to a recall, if there are a | |specified minimum number of | |reserves on the record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 05:39:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 03:39:29 +0000 Subject: [Koha-bugs] [Bug 31446] Optionally hide lightbox_descriptions from OPAC lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31446 --- Comment #1 from Alex Buckley --- Created attachment 139738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139738&action=edit Bug 31446: Add new OpacLightboxImageDescriptions system preference Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 05:39:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 03:39:50 +0000 Subject: [Koha-bugs] [Bug 31446] Optionally hide lightbox_descriptions from OPAC lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31446 --- Comment #2 from Alex Buckley --- Created attachment 139739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139739&action=edit Bug 31446: Optionally hide the Opac lightbox image description Test plan: 1. Apply patches, update database and restart services 2. Observe the new system preference OpacLightboxImageDescriptions is set to 'Show' 3. Enable OpacAmazonCoverImages, GoogleJackets, Coce (CoceHost = 'https://coce.mykoha.co.nz', CoceProviders = select all, OpacCoce = 'Enable) 4. In the OPAC visit the item detail page of a record displaying multiple cover images in a gallery - (If such an item does not exist in your catalogue add the ISBN (020$a) of '9780080969572' to a biblio) 5. Observe descriptions are displayed under each image in the gallery indicating where the items are from - e.g. 'Coce image from Amazon.com' 6. Change the OpacLightboxImageDescriptions syspref to "Don't show" 7. Confirm all the image descriptions are hidden in the OPAC item detail page. However, the dots to skip between the different cover images should still be visible. 8. Disable OpacAmazonCoverImages and Googlejackets sysprefs. Confirm with only Coce images enabled the image descriptions are still hidden. Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 05:43:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 03:43:12 +0000 Subject: [Koha-bugs] [Bug 31446] Optionally hide lightbox_descriptions from OPAC lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31446 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Optionally enable libraries release notes| |to hide image descriptions | |from the lightbox galleries | |on OPAC item detail pages. Status|ASSIGNED |Needs Signoff --- Comment #3 from Alex Buckley --- Ready for testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 05:46:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 03:46:44 +0000 Subject: [Koha-bugs] [Bug 31456] New: Optionally hide lightbox_descriptions from intranet lightbox gallery Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31456 Bug ID: 31456 Summary: Optionally hide lightbox_descriptions from intranet lightbox gallery Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Like in bug 31446 libraries should have the option to hide the descriptions displaying under items in the lightbox galleries on the intranet item detail pages. This is particularly useful for libraries that only have one source of images enabled - e.g. Coce - in which case displaying where the item is from when it is the only image displaying on an item detail page, is not always useful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 05:47:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 03:47:22 +0000 Subject: [Koha-bugs] [Bug 31456] Optionally hide lightbox_descriptions from intranet lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31456 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31446 Assignee|koha-bugs at lists.koha-commun |alexbuckley at catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored Text to go in the| |Optionally enable libraries release notes| |to hide image descriptions | |from the lightbox galleries | |on intranet item detail | |pages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 05:47:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 03:47:22 +0000 Subject: [Koha-bugs] [Bug 31446] Optionally hide lightbox_descriptions from OPAC lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31446 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31456 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 06:29:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 04:29:26 +0000 Subject: [Koha-bugs] [Bug 26692] Add barcode image generator service for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #30 from David Cook --- Created attachment 139740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139740&action=edit Proposed mobile view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 06:29:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 04:29:43 +0000 Subject: [Koha-bugs] [Bug 26692] Add barcode image generator service for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #31 from David Cook --- Created attachment 139741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139741&action=edit Proposed desktop view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 06:33:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 04:33:54 +0000 Subject: [Koha-bugs] [Bug 26692] Add barcode image generator service for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #32 from David Cook --- I've put together a Koha plugin that provides the barcode as seen on "Proposed mobile view" and "Proposed desktop view". Right now, it's just a proof of concept, and I'm gathering feedback from one of my librarians. Technically, the plugin just provides the Mojolicious REST API route. Those images are made using hand-made OPACUserJS separate from the plugin. (I figured that was easiest for testing, plus it provides maximum flexibility for libraries.) I'm sure there are optimizations to make but it's an early draft that I threw together pretty quickly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:12:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:12:38 +0000 Subject: [Koha-bugs] [Bug 30242] Allow changing Mojolicious log level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30242 --- Comment #5 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #3) > (In reply to Julian Maurice from comment #2) > > > Default Mojo log level is trace > > Only if the "mode" is development. It is 'info' otherwise > > (https://docs.mojolicious.org/Mojolicious#log). Not sure where MOJO_MODE > > should be set (in systemd unit perhaps ?) > > The koha-plack script sets either 'deployment' or 'development' depending on > the environment (if --debug was passed, or dev install detected). I would like to keep the configuration option too since my production is using dev_install too ;) But when there is no config entry, I add a fallback to trace or info depending on dev_install. > > Is it possible to redirect the logs to what is configured in log4perl.conf > > for the API ? > > $c->log should be initialized with Koha::Logger, right? Should be doable. Probably, but I need to dive deep down into Mojolicious plugins like Mojolicious::Plugin::Log::Any etc. to do so. That is imo quite outside the scope of this bug. Just noting that this was not implemented in the current REST API. I am seeing these kind of calls: my $logger = Koha::Logger->get({ interface => 'api' }); $logger->error("Warning: Could not load REST API spec bundle: " . $_); Please open another bug for moving the logs and use a logger plugin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:31:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:31:23 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139719|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 139742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139742&action=edit Bug 31095: Add Koha::Patron::Restriction(s) Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:31:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:31:27 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139720|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize --- Created attachment 139743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139743&action=edit Bug 31095: Add restrictions accessor to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:31:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:31:30 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139721|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize --- Created attachment 139744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139744&action=edit Bug 31095: Add type relation accessor to Koha::Patron::Restriction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:31:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:31:35 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139722|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize --- Created attachment 139745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139745&action=edit Bug 31095: Remove GetDebarments from circ/circulation.pl This patch remove the use of GetDebarments from circ/circulation.pl, replacing it with a reference to patron.restrictions in the template and includes. Test plan 1. Confirm that the 'Restrictions (x)' tab still appears on the checkout page for a user. 2. Confirm that the 'Restrictions (x)' tab count is correct 3. Confirm that the 'Restrictions (x)' tab table functions 4. Confirm that the 'Restrictions (x)' tab 'Add manual restriction' form works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:31:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:31:39 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139723|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 139746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139746&action=edit Bug 31095: Remove GetDebarments from members/moremember.pl This patch removes the use of GetDebarments from members/moremember.pl and replaces template references with patrons.restrictions and the new includes introduced in the prior patch Test plan 1. Confirm that the 'Restrictions (x)' tab still appears on the patron details page. 2. Confirm that the 'Restrictions (x)' tab count is correct 3. Confirm that the 'Restrictions (x)' tab table functions 4. Confirm that the 'Restrictions (x)' tab 'Add manual restriction' form works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:31:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:31:43 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139724|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize --- Created attachment 139747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139747&action=edit Bug 31095: Remove GetDebarments from members/memberentry.pl This patch removes the use of GetDebarments from members/memberentry.pl and replaces the references in the templates with patron.restrictions. Test plan 1. Add a new user and confirm that the patron restrictions section does not appear on the form 2. Edit the user and confirm the patron restrictions section now appears 3. Add a manual restriction using the patron edit form 4. Confirm the restriction appears on the patron edit form 5. Confirm you can remove the restriction usine the patron edit form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:31:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:31:46 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139725|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize --- Created attachment 139748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139748&action=edit Bug 31095: Remove borrower_debarments and patron_restrictions includes This patch removes the aforementioned includes and drops the last remaining reference to them. We have replaces these includes with patron-restrictions-tab.inc and restriction-types.inc. Test plan 1. Confirm the includes are no longer referenced anywhere in the codebase. 'git grep borrower_debarments.inc', 'git grep patron_restrictions.inc' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:31:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:31:50 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139726|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize --- Created attachment 139749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139749&action=edit Bug 31095: Remove keyed_on_code We no longer require keyed_on_code from Koha::Patron::Restrictoin::Types as we have relation accessors for the relevent use cases and no longer reference the method anywhere in the codebase! Test plan 1. Confirm 'keyed_on_code' is no longer referenced anywhere in the codebase. `git grep keyed_on_code` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:31:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:31:54 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139727|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize --- Created attachment 139750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139750&action=edit Bug 31095: Remove GetDebarments from tools/modborrowers.pl This patch removes GetDebarments from the modborrowers tool controller and replaces it with $patron->restrictions as appropriate. Test plan 1. Confirm that the 'Batch patron modification' tool pages still load and perform as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:31:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:31:58 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139728|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize --- Created attachment 139751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139751&action=edit Bug 31095: Remove GetDebarments from Circulation.pm This patch removes GetDebarments from Circulation.pm replacing them with calls to $patron->restrictions and filtering using a chained search call. Test plan 1. Confirm that t/db_dependant/Circulation.t continues to pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:32:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:32:02 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #24 from Martin Renvoize --- Created attachment 139752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139752&action=edit Bug 31095: Remove GetDebarments from Circulation.t Replace GetDebarments with $patron->restrictions. Test plan 1. Run test prior to patch - all should pass 2. Run test after patch - all should pass 3. Confirm no tests were removed as part of the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:32:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:32:07 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #25 from Martin Renvoize --- Created attachment 139753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139753&action=edit Bug 31095: Remove GetDebarments from Patron::Import This patch replaced GetDebarments with $patron->restrictions->search in Koha::Patron::Import. Test plan 1. Confirm that importing patrons with debarred and debarredcomment fields in the import still works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:32:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:32:11 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #26 from Martin Renvoize --- Created attachment 139754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139754&action=edit Bug 31095: Remove GetDebarments from maxsuspensiondays.t This patch replaces GetDebarments in maxsuspensiondays.t with calls to the restrictions accessor. Test plan 1. Confirm t/db_dependent/Circulation/maxsuspensiondays.t passes prior to this patch 2. Confirm t/db_dependent/Circulation/maxsuspensiondays.t passes after this patch 3. Confirm no tests have been removed in this patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:32:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:32:15 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #27 from Martin Renvoize --- Created attachment 139755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139755&action=edit Bug 31095: Remove GetDebarments from MarkIssueReturned.t This patch removes GetDebarments from Ciculation/MarkIssueReturned.t Test plan 1. Confirm t/db_dependent/Circulation/MarkIssueReturned.t passes prior to the patch 2. Confirm t/db_dependent/Circulation/MarkIssueReturned.t passes after the patch 3. Confirm no tests have been removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:32:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:32:19 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #28 from Martin Renvoize --- Created attachment 139756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139756&action=edit Bug 31095: Remove GetDebarments from Restriction/Type.t This patch replaces GetDebarments with $patron->restrictions in t/db_dependent/Koha/Patron/Restriction/Type.t Test plan 1. Confirm t/db_dependent/Koha/Patron/Restriction/Type.t passes prior to the patch 2. Confirm t/db_dependent/Koha/Patron/Restriction/Type.t passes after the patch 3. Confirm no tests were removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:32:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:32:23 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #29 from Martin Renvoize --- Created attachment 139757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139757&action=edit Bug 31095: Remove GetDebarments from Borrower_Debarments.t This patch replaces calls to GetDebarments with teh $patron->restritions->search() equivilents. Test plan 1. Run the test prior to the patch and confirm it passes 2. Run the test after the patch and confirm it passes 3. Confirm no tests were removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:32:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:32:27 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #30 from Martin Renvoize --- Created attachment 139758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139758&action=edit Bug 31095: Remove GetDebarments from Koha::Patron::Debarments This patch finally removes GetDebarments from the codebase. Test plan 1. Confirm GetDebarments is no longer mentioned in the codebase. `git grep GetDebarments` 2. Confirm t/db_dependent/Patron/Borrower_Debarments.t continues to pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:35:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:35:53 +0000 Subject: [Koha-bugs] [Bug 31457] New: Move Koha::Patron::Debarment into Koha::Object based classes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31457 Bug ID: 31457 Summary: Move Koha::Patron::Debarment into Koha::Object based classes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Collector bug for removing the Koha::Patron::Debarment which is written in C4 style and replacing it with the new Koha::Object based class pair, Koha::Patron::Restriction(s). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:36:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:36:05 +0000 Subject: [Koha-bugs] [Bug 31457] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31457 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31095 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:36:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:36:05 +0000 Subject: [Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31457 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31457 [Bug 31457] Move Koha::Patron::Debarment into Koha::Object based classes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:37:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:37:11 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move |Remove |Koha::Patron::Debarment |Koha::Patron::Debarment::Ge |into Koha::Object based |tDebarments and use |classes |$patron->restrictions in | |preference Blocks|31457 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31457 [Bug 31457] Move Koha::Patron::Debarment into Koha::Object based classes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:37:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:37:11 +0000 Subject: [Koha-bugs] [Bug 31457] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31457 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|31095 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:37:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:37:27 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31457 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31457 [Bug 31457] Move Koha::Patron::Debarment into Koha::Object based classes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:37:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:37:27 +0000 Subject: [Koha-bugs] [Bug 31457] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31457 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31095 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:38:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:38:58 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:39:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:39:47 +0000 Subject: [Koha-bugs] [Bug 30108] Allow making hold dates required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 --- Comment #19 from Katrin Fischer --- (In reply to Fridolin Somers from comment #18) > Pushed to master for 22.05, thanks to everybody involved 🦄 We are missing the update to the wiki here, but I am not seeing/finding the information about duration etc. right now: https://wiki.koha-community.org/wiki/Use_of_Cookies This documentation is important for libraries dealing with GDPR. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:40:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:40:12 +0000 Subject: [Koha-bugs] [Bug 30108] Allow making hold dates required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 --- Comment #20 from Katrin Fischer --- Wrong bug... too many tabs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:40:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:40:22 +0000 Subject: [Koha-bugs] [Bug 29058] Add option to not load existing holds table automatically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29058 --- Comment #18 from Katrin Fischer --- We are missing the update to the wiki here, but I am not seeing/finding the information about duration etc. right now: https://wiki.koha-community.org/wiki/Use_of_Cookies This documentation is important for libraries dealing with GDPR. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:40:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:40:38 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #31 from Martin Renvoize --- So I opted to break this into a series of smaller bugs rather than attack it all at once after realising how involved it was becoming. Each patch here should be simple to read and simple to test in the hopes we can move quickly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:40:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:40:54 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:42:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:42:01 +0000 Subject: [Koha-bugs] [Bug 30242] Allow changing Mojolicious log level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30242 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:42:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:42:05 +0000 Subject: [Koha-bugs] [Bug 30242] Allow changing Mojolicious log level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30242 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131433|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 139759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139759&action=edit Bug 30242: Allow changing Mojolicious log level Add an optional config variable to koha-conf and set log level in sub startup. Test plan: Check last line of plack-error.log. Hit the REST API. When you have a dev_install, you should see new log line(s). For a regular install, there may be no new log lines. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:42:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:42:08 +0000 Subject: [Koha-bugs] [Bug 30242] Allow changing Mojolicious log level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30242 --- Comment #7 from Marcel de Rooy --- Created attachment 139760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139760&action=edit Bug 30242: Add test Test plan: Run t/db_dependent/Koha/REST/V1.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:43:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:43:27 +0000 Subject: [Koha-bugs] [Bug 30242] REST API: Allow configuring log level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30242 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow changing Mojolicious |REST API: Allow configuring |log level |log level -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:44:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:44:17 +0000 Subject: [Koha-bugs] [Bug 30242] REST API: Allow configuring log level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30242 --- Comment #8 from Marcel de Rooy --- Please test. This comes from March already ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:44:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:44:28 +0000 Subject: [Koha-bugs] [Bug 31458] New: Remove Koha::Patron::Debarment::AddDebarment and use $patron->add_restriction in preference Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31458 Bug ID: 31458 Summary: Remove Koha::Patron::Debarment::AddDebarment and use $patron->add_restriction in preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org This bug serves to add a new add_restriction method to the Koha::Patron class and then replace all occurences of AddDebarment with said method before finally removing the AddDebarment method from Koha::Patron::Debarment. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:44:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:44:40 +0000 Subject: [Koha-bugs] [Bug 31458] Remove Koha::Patron::Debarment::AddDebarment and use $patron->add_restriction in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31458 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31457 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31457 [Bug 31457] Move Koha::Patron::Debarment into Koha::Object based classes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:44:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:44:40 +0000 Subject: [Koha-bugs] [Bug 31457] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31457 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31458 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31458 [Bug 31458] Remove Koha::Patron::Debarment::AddDebarment and use $patron->add_restriction in preference -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:45:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:45:01 +0000 Subject: [Koha-bugs] [Bug 31458] Remove Koha::Patron::Debarment::AddDebarment and use $patron->add_restriction in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31458 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31095 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:45:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:45:01 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31458 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31458 [Bug 31458] Remove Koha::Patron::Debarment::AddDebarment and use $patron->add_restriction in preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 11:46:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 09:46:49 +0000 Subject: [Koha-bugs] [Bug 30242] REST API: Allow configuring log level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30242 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |REST API |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 12:03:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 10:03:39 +0000 Subject: [Koha-bugs] [Bug 27035] Shows the number of results in a facet after facet selection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Shows the number of results |Shows the number of results |in a facets after facet |in a facet after facet |selection |selection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 12:07:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 10:07:02 +0000 Subject: [Koha-bugs] [Bug 31313] Remove GetItemsInfo from opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139693|0 |1 is obsolete| | --- Comment #24 from Nick Clemens --- Created attachment 139761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139761&action=edit Bug 31313: (QA follow-up) Show status "On hold" correctly if there are waiting holds The patch "Bug 31313: Fix availability - OPAC opac-detail" (70cb4e22c07) cause the OPAC detail page only show "Available" status even when there were waiting holds. The onhold item field is removed at the same go as it was confusing and unused since "Bug 2655: Fixes availabilty counts if items are on hold shelf. Patch (2/2)" (a37545eb1) Signed-off-by: Joonas Kylmälä Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 12:07:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 10:07:06 +0000 Subject: [Koha-bugs] [Bug 31313] Remove GetItemsInfo from opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139694|0 |1 is obsolete| | --- Comment #25 from Nick Clemens --- Created attachment 139762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139762&action=edit Bug 31313: (QA follow-up) Show transfer status correctly if item in transit The patch "Bug 31313: Fix availability - OPAC opac-detail" (70cb4e22c07) caused the OPAC detail page only show "Available" status even when the item was in transit. Signed-off-by: Joonas Kylmälä Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 12:07:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 10:07:09 +0000 Subject: [Koha-bugs] [Bug 31313] Remove GetItemsInfo from opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139695|0 |1 is obsolete| | --- Comment #26 from Nick Clemens --- Created attachment 139763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139763&action=edit Bug 31313: (QA follow-up) Remove unused bundle_host field from item_info The patch "Bug 31313: Fix availability - OPAC opac-detail" (70cb4e22c07) lead to koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc use the bundle_host method directly through the passed Koha::Item object, thus the bundle_host field added by this script is unused. Signed-off-by: Joonas Kylmälä Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 12:09:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 10:09:13 +0000 Subject: [Koha-bugs] [Bug 31203] Cronjobs should log completion as well as logging begin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #10 from Martin Renvoize --- OK... playing devils advocate here.. Do we really need/want this in the action_logs at all? I suppose cronlogaction has precedent.. but whose actually interested in this output? One could just set the cron daemon to log level 2 and then use rsyslog to track cron start and finish times? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 12:15:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 10:15:12 +0000 Subject: [Koha-bugs] [Bug 31203] Cronjobs should log completion as well as logging begin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #11 from Nick Clemens --- (In reply to Martin Renvoize from comment #10) > OK... playing devils advocate here.. > > Do we really need/want this in the action_logs at all? I suppose > cronlogaction has precedent.. but whose actually interested in this output? > > One could just set the cron daemon to log level 2 and then use rsyslog to > track cron start and finish times? We already log the running, this puts information about the completion into the hands of the the librarians, and not the system administrators. If a patron doesn't get an email, or a fine doesn't get charged, knowing the job completed helps the librarian determine whether it might be Koha settings or a cron issue Extending the completion log to include optional verbosity - how many emails sent, how may items renewed, transfers scheduled, etc. is a next step after this - to provide useful feedback for librarians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:09:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:09:45 +0000 Subject: [Koha-bugs] [Bug 31404] Update circulation sidebar to match circulation start page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31404 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Assignee|oleonard at myacpl.org |isobel.graham09 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:10:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:10:21 +0000 Subject: [Koha-bugs] [Bug 31403] Activate circulation sidebar (CircSidebar system preference) on default in new installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31403 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |isobel.graham09 at gmail.com |ity.org | CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:14:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:14:11 +0000 Subject: [Koha-bugs] [Bug 31458] Remove Koha::Patron::Debarment::AddDebarment and use $patron->add_restriction in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31458 --- Comment #1 from Martin Renvoize --- Created attachment 139764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139764&action=edit Bug 31458: Add add_restriction to Koha::Patron This patch adds the beggnings of an add_restriction method to Koha::Patron. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:14:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:14:56 +0000 Subject: [Koha-bugs] [Bug 31457] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31457 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|31095 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:14:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:14:56 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31457 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31457 [Bug 31457] Move Koha::Patron::Debarment into Koha::Object based classes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:20:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:20:09 +0000 Subject: [Koha-bugs] [Bug 30359] GetBudgetHierarchy is slow on order receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30359 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:20:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:20:13 +0000 Subject: [Koha-bugs] [Bug 30359] GetBudgetHierarchy is slow on order receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30359 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132283|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 139765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139765&action=edit Bug 30359: GetBudgetHierarchy is slow on order receive page This patch adds skiptotals parameter to GetBudgetHierarchy so calculating totals can be skipped from some pages. Test plan: 1) Open browser's Inspect -> Network 2) Go to receive orders 3) Check the timings for page load 4) Apply the patch 5) Refresh the page 6) Check the timings again 7) prove t/db_dependent/Budgets.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:20:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:20:17 +0000 Subject: [Koha-bugs] [Bug 30359] GetBudgetHierarchy is slow on order receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30359 --- Comment #5 from Nick Clemens --- Created attachment 139766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139766&action=edit Bug 30359: Unit tests Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:21:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:21:50 +0000 Subject: [Koha-bugs] [Bug 31313] Remove GetItemsInfo from opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 --- Comment #27 from Tomás Cohen Arazi --- Follow-ups pushed to master. Thanks! Any other follow-up please make it its own bug (set) ot avoid confusion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:27:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:27:41 +0000 Subject: [Koha-bugs] [Bug 31459] New: Order receive page is slow on systems with many budgets Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 Bug ID: 31459 Summary: Order receive page is slow on systems with many budgets Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 30359 reduces the amount of work by removing the calculation of spent/ordered totals. We can go one step further here and obtain the entire list in one call, rather than manually calling for each budget -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:32:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:32:38 +0000 Subject: [Koha-bugs] [Bug 31460] New: Merging Item Groups Loses Groups Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31460 Bug ID: 31460 Summary: Merging Item Groups Loses Groups Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl With the new feature of Item Groups, if a library merges two records together, both having Items with Item Groups attached, the merge will only retain the Item Group on the Kept Record. It would be beneficial to libraries that all item information including groups is retained in a merge. Test: 1. Have a record (A) with 3 items. 2. Create an item group with 2 of these items. 3. Have a second record (B) with 4 items 4. Create an item group with 2 of these items. 5. Merge the two records together keeping record A 6. Results will show that all items are moved over to record A, but the item group from record B, is not there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:32:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:32:49 +0000 Subject: [Koha-bugs] [Bug 31459] Order receive page is slow on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Depends on| |30359 Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30359 [Bug 30359] GetBudgetHierarchy is slow on order receive page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:32:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:32:49 +0000 Subject: [Koha-bugs] [Bug 30359] GetBudgetHierarchy is slow on order receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30359 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31459 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 [Bug 31459] Order receive page is slow on systems with many budgets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:32:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:32:53 +0000 Subject: [Koha-bugs] [Bug 31459] Order receive page is slow on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 --- Comment #1 from Nick Clemens --- Created attachment 139767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139767&action=edit Bug 31459: Use the same dropdown as when adding orders to a basket Current order receive code loops over each budget period and gets the hierarchy, this is slow when systems have many budgets. Additionally, the list includes inactive items by default We can switch to a single call, and add consistency by adopting the same dropdown as used when placing an order To test: 1 - Add some budgets with funds - ensure you have at least one inactive budget and fund 2 - Place an order, observe the fund selection menu 3 - Close basket, receive order, observe the fund menu 4 - Apply patch 5 - Cancel receipt 6 - Receive again 7 - Observe fund menu, confirm it matches the order placing menu 8 - Confirm inactive are not displayed by default, but are when button is checked -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:33:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:33:05 +0000 Subject: [Koha-bugs] [Bug 31459] Order receive page is slow on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:33:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:33:33 +0000 Subject: [Koha-bugs] [Bug 30359] GetBudgetHierarchy is slow on order receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30359 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:33:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:33:44 +0000 Subject: [Koha-bugs] [Bug 30242] REST API: Allow configuring log level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30242 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |INVALID --- Comment #9 from Marcel de Rooy --- On second thought, I am removing these patches. They actually just serve as a workaround until we implement logging properly in REST API. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:34:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:34:24 +0000 Subject: [Koha-bugs] [Bug 30242] REST API: Allow configuring log level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30242 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:34:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:34:26 +0000 Subject: [Koha-bugs] [Bug 30242] REST API: Allow configuring log level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30242 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139760|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:34:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:34:28 +0000 Subject: [Koha-bugs] [Bug 30242] REST API: Allow configuring log level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30242 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139759|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:36:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:36:24 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139250|0 |1 is obsolete| | --- Comment #321 from Martin Renvoize --- Created attachment 139768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139768&action=edit Bug 23681: Add PatronRestrictionTypes syspref This patch adds the new syspref "PatronRestrictionTypes" Sponsored-by: Loughborough University Signed-off-by: Benjamin Veasey Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:36:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:36:31 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139251|0 |1 is obsolete| | --- Comment #322 from Martin Renvoize --- Created attachment 139769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139769&action=edit Bug 23681: Add debarment_types table This patch adds the table debarment_types and changes borrower_debarments.type to be a foreign key to it Sponsored-by: Loughborough University Signed-off-by: Benjamin Veasey Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:36:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:36:38 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139252|0 |1 is obsolete| | --- Comment #323 from Martin Renvoize --- Created attachment 139770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139770&action=edit Bug 23681: Add modify_patron_restrictions permission This patch adds a new "modify_patron_restrictions" permission Sponsored-by: Loughborough University Signed-off-by: Benjamin Veasey Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:36:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:36:46 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139253|0 |1 is obsolete| | --- Comment #324 from Martin Renvoize --- Created attachment 139771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139771&action=edit Bug 23681: Add Koha Classes This patch adds the following objects: Koha::RestrictionType Koha::RestrictionTypes Sponsored-by: Loughborough University Signed-off-by: Benjamin Veasey Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:36:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:36:54 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139254|0 |1 is obsolete| | --- Comment #325 from Martin Renvoize --- Created attachment 139772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139772&action=edit Bug 23681: Add Management UI This patch adds UI to allow CRUD operations on restriction types Sponsored-by: Loughborough University Signed-off-by: Benjamin Veasey Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:37:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:37:01 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139255|0 |1 is obsolete| | --- Comment #326 from Martin Renvoize --- Created attachment 139773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139773&action=edit Bug 23681: Allow for changes to debarments The structure of debarments has changes slightly in that the displayed text is now a product of a call to Koha::RestrictionTypes rather than just the debarment's code. This patch allows for that Sponsored-by: Loughborough University Signed-off-by: Benjamin Veasey Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:37:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:37:10 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139256|0 |1 is obsolete| | --- Comment #327 from Martin Renvoize --- Created attachment 139774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139774&action=edit Bug 23681: Allow for selection of restriction type This patch displays a restriction type select box (when appropriate) when adding manual patron restrictions Sponsored-by: Loughborough University Signed-off-by: Benjamin Veasey Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:37:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:37:18 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139257|0 |1 is obsolete| | --- Comment #328 from Martin Renvoize --- Created attachment 139775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139775&action=edit Bug 23681: Clean up on delete When a patron restriction type is deleted, any debarments that use that type need to revert to the default type, this patch implements this behaviour Sponsored-by: Loughborough University Signed-off-by: Benjamin Veasey Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:37:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:37:26 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139258|0 |1 is obsolete| | --- Comment #329 from Martin Renvoize --- Created attachment 139776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139776&action=edit Bug 23681: Add unit tests Sponsored-by: Loughborough University Signed-off-by: Benjamin Veasey Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:37:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:37:33 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139259|0 |1 is obsolete| | --- Comment #330 from Martin Renvoize --- Created attachment 139777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139777&action=edit Bug 23681: (QA follow-up) Allow for translations This patch allows for existing translations to follow through if debarment type descriptions are left unaltered for the default types. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:37:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:37:41 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139260|0 |1 is obsolete| | --- Comment #331 from Martin Renvoize --- Created attachment 139778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139778&action=edit Bug 23681: Updates for bug 26703 This patch fixes the title ordering and also replaces the breadcrumbs with the modern nav block equivilent Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:37:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:37:52 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139261|0 |1 is obsolete| | --- Comment #332 from Martin Renvoize --- Created attachment 139779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139779&action=edit Bug 23681: (QA follow-up) Fix license, perlcritic & executable This patch fixes the simple issues mentioned by the QA script. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:37:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:37:59 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139262|0 |1 is obsolete| | --- Comment #333 from Martin Renvoize --- Created attachment 139780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139780&action=edit Bug 23681: (QA follow-up) Fix preferences Add the missing `.` and switch from `yes/no` to `1/0`. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:38:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:38:07 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139263|0 |1 is obsolete| | --- Comment #334 from Martin Renvoize --- Created attachment 139781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139781&action=edit Bug 23681: (QA follow-up) Rename columns Renames ronly to readonly and dflt to is_system. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:38:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:38:15 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139264|0 |1 is obsolete| | --- Comment #335 from Martin Renvoize --- Created attachment 139782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139782&action=edit Bug 23681: Fix QA issues This patch fixes following QA issues: - convert intaller files as .yml - change column name readonly as is_system - change column name is_system as default_value - add column can_be_added_manually (testplan for this below) - move syspref "PatronRestrictionTypes" to "Accounting > Features" tab - tweak page title - tweak tests to apply these changes Also atomicupdate files have been updated. Issues with delete and tests is fixed with adding additional schema change file. To test: 1) Add new restriction type and make it manual. 2) Navigate to patron details page. 3) Add new restriction to patron. => Only selectable restriction should be the one you just created. Also prove t/db_dependent/RestrictionTypes.t. Sponsored-by: Koha-Suomi Oy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:38:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:38:23 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139265|0 |1 is obsolete| | --- Comment #336 from Martin Renvoize --- Created attachment 139783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139783&action=edit Bug 23681: DBIC Schema To be able to delete and pass tests we need to declare koha_object[s]_class to DebarmentType.pm. Otherwise following error is raised: "Can't locate object method "_new_from_dbic" via package "Koha::DebarmentType" (perhaps you forgot to load "Koha::DebarmentType"?) at /kohadevbox/koha/Koha/Object.pm line 237" Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:38:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:38:32 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139266|0 |1 is obsolete| | --- Comment #337 from Martin Renvoize --- Created attachment 139784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139784&action=edit Bug 23681: (QA follow-up) Move preference again This patch removes the new PatronRestrictionTypes preference from the accounting area in preference to creating a new group for 'Patron restriction' related preferences in the circulation preferences tab. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:38:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:38:40 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139267|0 |1 is obsolete| | --- Comment #338 from Martin Renvoize --- Created attachment 139785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139785&action=edit Bug 23681: (QA follow-up) Restore customisablity of description This patch restores the customisability of description for system restriction types. Translatability is not affected as you can translate the defaults via template translation and assuming the end users leave their descriptions at the default, the translations will be picked. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:38:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:38:47 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139268|0 |1 is obsolete| | --- Comment #339 from Martin Renvoize --- Created attachment 139786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139786&action=edit Bug 23681: (QA follow-up) Merge update files This patch merges the three atomic update files into one and also adds a check for foreing key existance to make the update idempotent. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:38:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:38:59 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139269|0 |1 is obsolete| | --- Comment #340 from Martin Renvoize --- Created attachment 139787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139787&action=edit Bug 23681: (QA follow-up) Proper handling of default option This patch removes the 'can_be_added_manually' flag. Only non-system restriction types can be added manually, so we exclude is_system instead of having two flags. (And we set the 'Manual' that's added at install time to default but not system). We then add proper handling for setting the default manual restriction type in the management page and set the dropdown list to use that value by default. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:39:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:39:05 +0000 Subject: [Koha-bugs] [Bug 30242] REST API: Allow configuring log level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30242 --- Comment #10 from Marcel de Rooy --- See bug 18205 and bug 22678 requesting implementation of Koha::Logger into REST API. One in discussion ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:39:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:39:08 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139270|0 |1 is obsolete| | --- Comment #341 from Martin Renvoize --- Created attachment 139788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139788&action=edit Bug 23681: (follow-up) Mark fields at booleans Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:39:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:39:15 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139271|0 |1 is obsolete| | --- Comment #342 from Martin Renvoize --- Created attachment 139789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139789&action=edit Bug 23681: (QA follow-up) Add patron restrictions to admin menu This patch adds the patron restrictions page to the admin menu that appears to the left on all administration pages. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:39:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:39:23 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139272|0 |1 is obsolete| | --- Comment #343 from Martin Renvoize --- Created attachment 139790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139790&action=edit Bug 23681: (QA follow-up) Remove spacing and add question mark This patch removes the superflous whitespace around the restriction descriptions and also adds the missing question mark into the delete question. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:39:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:39:30 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139273|0 |1 is obsolete| | --- Comment #344 from Martin Renvoize --- Created attachment 139791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139791&action=edit Bug 23681: (QA follow-up) Fix memberentry page display We were missing some changes to the restriction types dropdown handling in the memberentry template. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:39:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:39:37 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139509|0 |1 is obsolete| | --- Comment #345 from Martin Renvoize --- Created attachment 139792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139792&action=edit Bug 23681: (QA follow-up) debarment_types => restriction_types The code moved from *debarments* to *restrictions* but the table didn't. This patch just renames things accordingly. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:39:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:39:45 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139512|0 |1 is obsolete| | --- Comment #346 from Martin Renvoize --- Created attachment 139793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139793&action=edit Bug 23681: (QA follow-up) New schema files Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:39:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:39:54 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139717|0 |1 is obsolete| | --- Comment #347 from Martin Renvoize --- Created attachment 139794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139794&action=edit Bug 23681: Move to ::Patron::Restriction::Type(s) This patch moves the new classes under ::Patron::Restriction:: and enhances the Unit tests for those classes. NOTE: We should drop keyed_on_code as part of bug 31095 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:47:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:47:01 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #348 from Martin Renvoize --- Created attachment 139795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139795&action=edit Bug 23681: (follow-up) Re-fix ::Patron::Restriction::Type(s) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:50:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:50:42 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #1 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #0) > Bug 18205 tries to do allot of things in one bug.. this is an alternate > implementation limited down to just replacing the default Mojo::Log logger > in the Mojolicious app with a Koha::Logger instead. "This is" ? Any news, Martin? What changes are needed to Koha::Logger to get it to work within Mojo? Only doing $app->log(Koha::Logger->get) seems to be insufficient.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:53:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:53:42 +0000 Subject: [Koha-bugs] [Bug 18205] API interface to Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:54:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:54:08 +0000 Subject: [Koha-bugs] [Bug 18205] API interface to Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22678 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:54:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:54:08 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18205 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:54:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:54:53 +0000 Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:54:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:54:56 +0000 Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 --- Comment #32 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:55:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:55:00 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:55:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:55:04 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #349 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:55:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:55:08 +0000 Subject: [Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:55:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:55:10 +0000 Subject: [Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:58:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:58:19 +0000 Subject: [Koha-bugs] [Bug 18205] API interface to Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 --- Comment #28 from Marcel de Rooy --- Agree with Martin here that getting Koha::Logger in here as compact as possible would be preferrable. But now we are three years later ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 13:59:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 11:59:02 +0000 Subject: [Koha-bugs] [Bug 18205] API interface to Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 --- Comment #29 from Marcel de Rooy --- Did someone look at Mojolicious::Plugin::Log::Any - Use other loggers in a Mojolicious application ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 14:01:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 12:01:46 +0000 Subject: [Koha-bugs] [Bug 31168] Temporary Item Locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31168 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 14:10:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 12:10:40 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 maalej at effective-webwork.de changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maalej at effective-webwork.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 14:15:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 12:15:57 +0000 Subject: [Koha-bugs] [Bug 31461] New: add a document to course reserve from catalogue/detail.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31461 Bug ID: 31461 Summary: add a document to course reserve from catalogue/detail.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: mathsabypro at gmail.com QA Contact: testopia at bugs.koha-community.org There should be a way to add a document to a course reserve from catalogue/detail.pl, in the same way of adding it to a list or a cart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 14:22:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 12:22:14 +0000 Subject: [Koha-bugs] [Bug 31462] New: add a way to batch edit items without displaying all the items in a table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31462 Bug ID: 31462 Summary: add a way to batch edit items without displaying all the items in a table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: mathsabypro at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When you are batch editing a lot of items, the second screen of batchMod.pl can take a long time to display the list of all items. Sometimes it raises an HTTP error. It should be possible to choose to not display this list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 14:23:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 12:23:48 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Theodoros Theodoropoulos changed: What |Removed |Added ---------------------------------------------------------------------------- CC|theod at lib.auth.gr | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 15:08:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 13:08:06 +0000 Subject: [Koha-bugs] [Bug 31459] Order receive page is slow on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 Carolyn Hughesman changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chughesman at cclsny.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 15:12:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 13:12:32 +0000 Subject: [Koha-bugs] [Bug 31463] New: (Bug 31313 follow-up) Show item order status on opac-detail Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31463 Bug ID: 31463 Summary: (Bug 31313 follow-up) Show item order status on opac-detail Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 15:17:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 13:17:10 +0000 Subject: [Koha-bugs] [Bug 31463] (Bug 31313 follow-up) Show item order status on opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31463 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Depends on| |31313 Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 [Bug 31313] Remove GetItemsInfo from opac-detail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 15:17:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 13:17:10 +0000 Subject: [Koha-bugs] [Bug 31313] Remove GetItemsInfo from opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31463 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31463 [Bug 31463] (Bug 31313 follow-up) Show item order status on opac-detail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 15:17:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 13:17:14 +0000 Subject: [Koha-bugs] [Bug 31463] (Bug 31313 follow-up) Show item order status on opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31463 --- Comment #1 from Nick Clemens --- Created attachment 139796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139796&action=edit Bug 31463: Add order status to opac-detail.pl This adds a check for the preference OPACAcquisitionDetails and fetches the active orders for the item if necessary Additionally, we simply the check for biblio orders to use object methods and remove code that stored order information in the item_info To test: 1 - Enable preference: OPACAcquisitionDetails 2 - Create a basket with items created on order, add an order for a biblio, close the basket 3 - Create a second basket as above, add an order with multiple copies, leave basket open 4 - View biblio on opac 5 - You should see 1 item marked on order, and "1 items on order" below items table 6 - Close second basket 7 - Reload opac view, now 3 on order and in message 8 - Reopen first basket 9 - Reload opac view, now 2 on order and in message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 15:18:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 13:18:24 +0000 Subject: [Koha-bugs] [Bug 31463] (Bug 31313 follow-up) Show item order status on opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31463 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |nick at bywatersolutions.com CC| |joonas.kylmala at iki.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 15:35:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 13:35:13 +0000 Subject: [Koha-bugs] [Bug 25426] Allow return policy to be selected via syspref and not just home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25426 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Return policy always |Allow return policy to be |follows item home library, |selected via syspref and |does not follow branch |not just home library |indicated by CircControl | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 15:37:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 13:37:14 +0000 Subject: [Koha-bugs] [Bug 31454] Ability to update multiple subscriptions at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31454 --- Comment #2 from Sara Brown --- Hi Katrin, Apologies; I should have been much more specific with the original bug! The library I spoke with that led to this bug specifically wants to be able to renew a subscription and have its prediction pattern repeated (covered in bug 17656) or, until that's possible, be able to batch-edit the renewed subscriptions' prediction pattern to select months that won't be published for all 10, 20 etc. subscriptions/locations at once. I'm not sure if that's implied in 31230, but I had not found that one before, so thank you for noting it in any case! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 15:59:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 13:59:00 +0000 Subject: [Koha-bugs] [Bug 30952] New interface for staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com | |, | |kelly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 16:38:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 14:38:12 +0000 Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139450|0 |1 is obsolete| | --- Comment #71 from Marcel de Rooy --- Created attachment 139797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139797&action=edit Bug 27421: (QA follow-up) WIP: Adjusting progress and size Might still need a bit of polishing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 16:55:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 14:55:49 +0000 Subject: [Koha-bugs] [Bug 31464] New: Coce images don't always load in Firefox Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31464 Bug ID: 31464 Summary: Coce images don't always load in Firefox Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org TO recreate: 1. Set a CoceHost. You can use ( https://coce.bywatersolutions.com ) 2. Set some CoceProviders. 3. Turn OpacCoce on, but no other image services. 4. Find a record that should have cover image and go to it's OPAC detail page. 5. In Firefox the image will not load for me. 6. Try in Chrome, the image loads just fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 17:02:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 15:02:59 +0000 Subject: [Koha-bugs] [Bug 25426] Allow return policy to be selected via syspref and not just home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25426 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 17:03:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 15:03:02 +0000 Subject: [Koha-bugs] [Bug 25426] Allow return policy to be selected via syspref and not just home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25426 --- Comment #5 from Kyle M Hall --- Created attachment 139798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139798&action=edit Bug 25426: Allow return policy to be selected via syspref and not just home library 1) Apply this patch 2) Run updatedatabase.pl 3) Verify CircControlReturnsBranch is set to home library by default 4) Set a Return policy for Branch A to "Item returns home" ( homebranch ) 5) Set a Return polity for Branch B to "Item returns to issuing library" ( holdingbranch ) 6) Set a Return polity for Branch C to "Item floats" ( noreturn ) 7) Create an item with homebranch of Branch A, holding branch of branch B 8) Log in as Branch C 9) Set CircControlReturnsBranch to "the library the item is currently held by" 10) Check the item in, note it should be returned to the holding library 11) Set CircControlReturnsBranch to "the library the item is owned by" 12) Check the item in, note it should be returned to the home library 13) Set CircControlReturnsBranch to "the library you are logged in at" 14) Check the item in, note it should float -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 17:04:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 15:04:18 +0000 Subject: [Koha-bugs] [Bug 25426] Allow return policy to be selected via syspref and not just home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25426 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 17:30:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 15:30:09 +0000 Subject: [Koha-bugs] [Bug 31458] Remove Koha::Patron::Debarment::AddDebarment and use $patron->add_restriction in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31458 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139764|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 139799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139799&action=edit Bug 31458: Add add_restriction to Koha::Patron This patch adds the beggnings of an add_restriction method to Koha::Patron. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 17:30:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 15:30:13 +0000 Subject: [Koha-bugs] [Bug 31458] Remove Koha::Patron::Debarment::AddDebarment and use $patron->add_restriction in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31458 --- Comment #3 from Martin Renvoize --- Created attachment 139800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139800&action=edit Add _update_patron_restriction_fields This still needs some work.. picking which of the two constructs for ordering works and removing new lines from the debarredcomment field. Do we even need the local debarredcomment field any more... and should the debarred field just become a boolean.. or should we just drop the fields from the borrowers table entirely and rely on relations. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 17:31:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 15:31:02 +0000 Subject: [Koha-bugs] [Bug 31458] Remove Koha::Patron::Debarment::AddDebarment and use $patron->add_restriction in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31458 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 18:27:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 16:27:12 +0000 Subject: [Koha-bugs] [Bug 26440] Not renewable Supersedes On Hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26440 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28435 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 18:27:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 16:27:12 +0000 Subject: [Koha-bugs] [Bug 28435] CanBookBeRenewed returns only a single status and falsely indicates renewal can be overridden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28435 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26440 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 19:11:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 17:11:51 +0000 Subject: [Koha-bugs] [Bug 28512] Quick spine label creator: Add CSS class with logged in library's branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 --- Comment #7 from Lucas Gass --- #spinelabel(In reply to Katrin Fischer from comment #5) > Would you be ok with it being in another element instead of the body tag? > > Adding to all staff pages is quite a huge task and I think a quick fix here > would be nice for libraries.
    Maybe on this element? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 19:18:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 17:18:00 +0000 Subject: [Koha-bugs] [Bug 28512] Quick spine label creator: Add CSS class with logged in library's branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 19:18:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 17:18:03 +0000 Subject: [Koha-bugs] [Bug 28512] Quick spine label creator: Add CSS class with logged in library's branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 --- Comment #8 from Lucas Gass --- Created attachment 139801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139801&action=edit Bug 28512: Add branchcode as class to spinelabel element To test: -Apply patch and generate a quick spine label. -Inscept the page and notice that the #spinelabel element should contain a new class which corresponds with that the of the logged in branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 19:18:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 17:18:39 +0000 Subject: [Koha-bugs] [Bug 28512] Quick spine label creator: Add CSS class with logged in library's branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133762|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 20:23:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 18:23:05 +0000 Subject: [Koha-bugs] [Bug 25426] Allow return policy to be selected via syspref and not just home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25426 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 20:23:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 18:23:09 +0000 Subject: [Koha-bugs] [Bug 25426] Allow return policy to be selected via syspref and not just home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25426 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139798|0 |1 is obsolete| | --- Comment #6 from Andrew Fuerste-Henry --- Created attachment 139802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139802&action=edit Bug 25426: Allow return policy to be selected via syspref and not just home library 1) Apply this patch 2) Run updatedatabase.pl 3) Verify CircControlReturnsBranch is set to home library by default 4) Set a Return policy for Branch A to "Item returns home" ( homebranch ) 5) Set a Return polity for Branch B to "Item returns to issuing library" ( holdingbranch ) 6) Set a Return polity for Branch C to "Item floats" ( noreturn ) 7) Create an item with homebranch of Branch A, holding branch of branch B 8) Log in as Branch C 9) Set CircControlReturnsBranch to "the library the item is currently held by" 10) Check the item in, note it should be returned to the holding library 11) Set CircControlReturnsBranch to "the library the item is owned by" 12) Check the item in, note it should be returned to the home library 13) Set CircControlReturnsBranch to "the library you are logged in at" 14) Check the item in, note it should float -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 20:25:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 18:25:48 +0000 Subject: [Koha-bugs] [Bug 25426] Allow return policy to be selected via syspref and not just home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25426 --- Comment #7 from Andrew Fuerste-Henry --- (In reply to Andrew Fuerste-Henry from comment #6) > Created attachment 139802 [details] [review] > Bug 25426: Allow return policy to be selected via syspref and not just home > library > > 1) Apply this patch > 2) Run updatedatabase.pl > 3) Verify CircControlReturnsBranch is set to home library by default > 4) Set a Return policy for Branch A to "Item returns home" ( homebranch ) > 5) Set a Return polity for Branch B to "Item returns to issuing library" ( > holdingbranch ) > 6) Set a Return polity for Branch C to "Item floats" ( noreturn ) > 7) Create an item with homebranch of Branch A, holding branch of branch B > 8) Log in as Branch C > 9) Set CircControlReturnsBranch to "the library the item is currently held > by" > 10) Check the item in, note it should be returned to the holding library > 11) Set CircControlReturnsBranch to "the library the item is owned by" > 12) Check the item in, note it should be returned to the home library > 13) Set CircControlReturnsBranch to "the library you are logged in at" > 14) Check the item in, note it should float I'm not sure why this didn't get a signed off note from Koha Testing Docker. This is signed off by me! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 21:47:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 19:47:22 +0000 Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #29 from Blou --- Bug 20511 doesn't help. Since this patch won't get any support, but we need it, we'll rebase it for our own needs. Including a squash for simplicity sake. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 21:51:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 19:51:11 +0000 Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100331|0 |1 is obsolete| | --- Comment #30 from Blou --- Created attachment 139803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139803&action=edit Bug 24172: Allow translation of seasons in serials-edit.tt and subscription-detail.tt Seasons are not handled by locales. Those generated are stored in English in the database, and the display in serials-collection.tt is translating them. But once you click on "Edit serials" or if you go straight to the subscription's display, those are displayed as in the database: in English. This patch reproduces the same trick as in serial-collection.tt and allow for the display to be translated. NOTE: this patch's testing require knowledge of translation tools. Reproducing Caroline's test: 0- Make sure you have at least one language other than English installed 1- With staff interface in English, create a subscription with a seasonal numbering pattern and frequency, with locale in your other language 2- Check the prediction pattern, note that the season names are in English not the locale language 3- Change the staff interface to other language, redo the prediction pattern test with locale in other language, note that the season names are in other language 4- Save the subscription 5- Receive an issue, note that the season name in the "Numbered" column on serials-edit.pl is in English 6- Save your issue 7- Switch interface in other language 8- Note that the season name on serials-collection is in other language 9- If you check the database, you will see the season name is in English, even though the subscription.locale is something else 10- validate the different pages: - serials-collection.pl: display is translated - serials-edit.pl: name pulled directly from db - subscription-detail.pl: name pulled directly from db - detail.pl: name pulled directly from db - opac-detail.pl: name pulled directly from db 11- APPLY THE PATCH 12- translate the string a) ./translate update b) find the strings, translate them c) ./translate install 13- restart Plack ? 14- validate the pages again. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 21:51:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 19:51:24 +0000 Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100332|0 |1 is obsolete| | --- Comment #31 from Blou --- Created attachment 139804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139804&action=edit Bug 24172: Allow translation of seasons in details.tt and opac-details.tt Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 21:53:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 19:53:27 +0000 Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #32 from Katrin Fischer --- I can try to look into this one, as I've also tested bug 20511, but since I'll be on vacation next week, it won't be quick. Please switch to needs signoff or signed off (depending on the nature of the rebase) when you think this is ready for testing again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 21:54:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 19:54:50 +0000 Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #33 from Katrin Fischer --- (In reply to Katrin Fischer from comment #18) > Blou can you please double check and come back to us? I am not sure about > storing 'translated' values in the db if this wasn't done before. Looking back, we need to store the translated value in some cases. Maybe what I was thinking about was the transition - how to handle existing subscriptions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 22:09:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 20:09:47 +0000 Subject: [Koha-bugs] [Bug 31456] Optionally hide lightbox_descriptions from intranet lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31456 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 22:15:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 20:15:51 +0000 Subject: [Koha-bugs] [Bug 31456] Optionally hide lightbox_descriptions from intranet lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31456 --- Comment #1 from Katrin Fischer --- Some cover services might have the link as a condition to using the service. I wonder if we should investigate this first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 22:23:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 20:23:07 +0000 Subject: [Koha-bugs] [Bug 31460] Merging item groups loses groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31460 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Merging Item Groups Loses |Merging item groups loses |Groups |groups Depends on| |24857 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 [Bug 24857] Add ability to group items for records -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 22:23:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 20:23:07 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31460 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31460 [Bug 31460] Merging item groups loses groups -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 22:25:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 20:25:15 +0000 Subject: [Koha-bugs] [Bug 31462] Add a way to batch edit items without displaying all the items in a table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31462 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME Summary|add a way to batch edit |Add a way to batch edit |items without displaying |items without displaying |all the items in a table |all the items in a table --- Comment #1 from Katrin Fischer --- Hi Mathieu, I think this is a solved issue. Have a look at the MaxItemsToDisplayForBatch* system preferences and lower the number. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 22:26:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 20:26:37 +0000 Subject: [Koha-bugs] [Bug 31464] Coce images don't always load in Firefox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31464 --- Comment #1 from Katrin Fischer --- Just noting that I have seen this behaviour trying to test another cover related patch. Results show the cover, detail does not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 22:56:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 20:56:02 +0000 Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100888|0 |1 is obsolete| | --- Comment #34 from Shi Yao Wang --- Created attachment 139805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139805&action=edit Bug 24172: Move duplicated code to an include file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 22:58:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 20:58:07 +0000 Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139805|0 |1 is obsolete| | --- Comment #35 from Shi Yao Wang --- Created attachment 139806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139806&action=edit Bug 24172: Move duplicated code to an include file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 22:58:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 20:58:39 +0000 Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139804|0 |1 is obsolete| | --- Comment #36 from Shi Yao Wang --- Created attachment 139807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139807&action=edit Bug 24172: Allow translation of seasons in details.tt and opac-details.tt Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 22:58:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 20:58:44 +0000 Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139806|0 |1 is obsolete| | --- Comment #37 from Shi Yao Wang --- Created attachment 139808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139808&action=edit Bug 24172: Move duplicated code to an include file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 23:04:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 21:04:40 +0000 Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139803|0 |1 is obsolete| | --- Comment #38 from Shi Yao Wang --- Created attachment 139809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139809&action=edit Bug 24172: Allow translation of seasons in serials-edit.tt and subscription-detail.tt Seasons are not handled by locales. Those generated are stored in English in the database, and the display in serials-collection.tt is translating them. But once you click on "Edit serials" or if you go straight to the subscription's display, those are displayed as in the database: in English. This patch reproduces the same trick as in serial-collection.tt and allow for the display to be translated. NOTE: this patch's testing require knowledge of translation tools. Reproducing Caroline's test: 0- Make sure you have at least one language other than English installed 1- With staff interface in English, create a subscription with a seasonal numbering pattern and frequency, with locale in your other language 2- Check the prediction pattern, note that the season names are in English not the locale language 3- Change the staff interface to other language, redo the prediction pattern test with locale in other language, note that the season names are in other language 4- Save the subscription 5- Receive an issue, note that the season name in the "Numbered" column on serials-edit.pl is in English 6- Save your issue 7- Switch interface in other language 8- Note that the season name on serials-collection is in other language 9- If you check the database, you will see the season name is in English, even though the subscription.locale is something else 10- validate the different pages: - serials-collection.pl: display is translated - serials-edit.pl: name pulled directly from db - subscription-detail.pl: name pulled directly from db - detail.pl: name pulled directly from db - opac-detail.pl: name pulled directly from db 11- APPLY THE PATCH 12- translate the string a) ./translate update b) find the strings, translate them c) ./translate install 13- restart Plack ? 14- validate the pages again. Signed-off-by: Martin Renvoize Bug 24172: Allow translation of seasons in details.tt and opac-details.tt Signed-off-by: Martin Renvoize Bug 24172: Move duplicated code to an include file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 23:04:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 21:04:59 +0000 Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shi-yao.wang at inLibro.com Attachment #139808|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 23:05:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 21:05:18 +0000 Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139807|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 23:08:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 21:08:37 +0000 Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 25 23:41:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 21:41:15 +0000 Subject: [Koha-bugs] [Bug 31465] New: 21.11 manual says it is 20.05 manual Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31465 Bug ID: 31465 Summary: 21.11 manual says it is 20.05 manual Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Go to a link like this one: https://koha-community.org/manual/21.11/en/html/systempreferences.html Notice in the top left corner it has 20.05, but the link it is for 21.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 01:01:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 23:01:23 +0000 Subject: [Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz --- Comment #14 from Aleisha Amohia --- Was this tested with an actual atomic update in the directory? I had an atomic update in there named bug_X_-_add_syspref.pl and it caused the test to fail $ prove t/00-check-atomic-updates.t t/00-check-atomic-updates.t .. 1/? # Failed test 'check for unhandled atomic updates: bug_30880_-_add_option_OPACResultsUnavailableGroupingBy_syspref.pl' # at t/00-check-atomic-updates.t line 34. # 'bug_30880_-_add_option_OPACResultsUnavailableGroupingBy_syspref.pl' # matches '(?^u:.*pl$)' # Looks like you failed 1 test of 7. t/00-check-atomic-updates.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/7 subtests Test Summary Report ------------------- t/00-check-atomic-updates.t (Wstat: 256 Tests: 7 Failed: 1) Failed test: 5 Non-zero exit status: 1 Files=1, Tests=7, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.06 cusr 0.00 csys = 0.08 CPU) Result: FAIL Can anyone advise? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 01:10:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 23:10:00 +0000 Subject: [Koha-bugs] [Bug 31466] New: t/00-check-atomic-updates.t always fails if atomic update exists Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31466 Bug ID: 31466 Summary: t/00-check-atomic-updates.t always fails if atomic update exists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Bug 31108 fixed the test to make it run, but now it fails if there is ever a file in the atomic updates directory. The test is unlike( $f, qr/.*pl$/, "check for unhandled atomic updates: $f" ); Which means the test passes if the atomic update filename DOES NOT MATCH the format something.pl. However atomic update files always match that format, so the test always fails and blocks packages from building. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 01:10:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 23:10:14 +0000 Subject: [Koha-bugs] [Bug 31466] t/00-check-atomic-updates.t always fails if atomic update exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31466 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |aleisha at catalyst.net.nz Change sponsored?|--- |Sponsored Depends on| |31108 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 01:10:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 23:10:14 +0000 Subject: [Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31466 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31466 [Bug 31466] t/00-check-atomic-updates.t always fails if atomic update exists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 01:20:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 23:20:10 +0000 Subject: [Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 --- Comment #15 from Aleisha Amohia --- I've opened Bug 31466 to handle this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 01:30:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 23:30:46 +0000 Subject: [Koha-bugs] [Bug 31466] t/00-check-atomic-updates.t always fails if atomic update exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31466 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 01:30:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 23:30:50 +0000 Subject: [Koha-bugs] [Bug 31466] t/00-check-atomic-updates.t always fails if atomic update exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31466 --- Comment #1 from Aleisha Amohia --- Created attachment 139810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139810&action=edit Bug 31466: Fix t/00-check-atomic-updates.t to pass if atomic updates The way the test was previously written, it would fail if atomic updates matched the format /.*pl$/ . This is incorrect because atomic update names should match the format /.*pl/. To test: 1) Run t/00-check-atomic-updates.t. Confirm test passes 2) Add an atomic update. Use the example from https://wiki.koha-community.org/wiki/Database_updates#How_to_write_an_atomicupdate_file 3) Run t/00-check-atomic-updates.t. Confirm test fails 4) Apply patch and run t/00-check-atomic-updates.t. Test should pass! Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 01:33:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 23:33:07 +0000 Subject: [Koha-bugs] [Bug 31467] New: Holds to pull page does not return the 'first patron' with the top priority hold Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31467 Bug ID: 31467 Summary: Holds to pull page does not return the 'first patron' with the top priority hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The functionality in bug 24488 of showing the correct 'first patron' details no longer always works. --- Here is an example of the current 'Holds to pull' page behaviour on master where one biblio has two biblio-level holds on it: +------------+--------------+------------+----------------+----------+---------+-------------+---------------------+ | reserve_id | biblionumber | itemnumber | borrowernumber | priority | suspend | reservedate | timestamp | +------------+--------------+------------+----------------+----------+---------+-------------+---------------------+ | 17704 | 26454 | NULL | 8450 | 1 | 0 | 2022-08-25 | 2022-08-25 15:16:34 | | 17705 | 26454 | NULL | 6998 | 2 | 0 | 2022-08-25 | 2022-08-25 15:17:22 | +------------+--------------+------------+----------------+----------+---------+-------------+---------------------+ The 'Holds to pull' page should display borrower 8450 as the 'First patron', as they have a priority of 1. But it incorrectly displays borrower 6998, instead. The 'Holds to pull' page should display the 'First patron' based on who has the top priority hold. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 01:33:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 23:33:19 +0000 Subject: [Koha-bugs] [Bug 31467] Holds to pull page does not return the 'first patron' with the top priority hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31467 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alexbuckley at catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 01:34:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 23:34:40 +0000 Subject: [Koha-bugs] [Bug 31466] t/00-check-atomic-updates.t always fails if atomic update exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31466 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Needs Signoff |RESOLVED --- Comment #2 from Aleisha Amohia --- Never mind it has been explained to me that the test is correct and those of us doing custom packages will need to change how we handle atomic updates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 01:34:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 23:34:58 +0000 Subject: [Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 --- Comment #16 from Aleisha Amohia --- Never mind it has been explained to me that the test is correct and those of us doing custom packages will need to change how we handle atomic updates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 01:36:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 23:36:30 +0000 Subject: [Koha-bugs] [Bug 31467] Holds to pull page does not return the 'first patron' with the top priority hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31467 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Alex Buckley --- *** This bug has been marked as a duplicate of bug 30935 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 01:36:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 23:36:30 +0000 Subject: [Koha-bugs] [Bug 30935] Holds to pull shows wrong first patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30935 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley at catalyst.net.nz --- Comment #10 from Alex Buckley --- *** Bug 31467 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 01:46:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 23:46:53 +0000 Subject: [Koha-bugs] [Bug 18205] API interface to Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #30 from David Cook --- Some of this will be obsolete due to bug 16357. So $c->app->log uses Mojo::Log, which outputs to STDERR. It uses log level "trace" in dev or "info" in prod, or the env var MOJO_LOG_LEVEL (https://docs.mojolicious.org/Mojolicious#log) We're already catching STDERR and putting it through log4perl, so I think the only issue right now would be the discrepancy between the log level of the Mojo::Log object and the log level defined in the log4perl configuration. (That is, log4perl might say only output "WARN" and above, whereas currently a $c->log->debug('debug') would still be printed out to the log4perl log. (In reply to Martin Renvoize from comment #25) > Why not simply do $app->log(Koha::Logger->get) and use the config and setup > afforded to us by the existing work within Koha::Logger.. So I'd say Martin's suggestion is the correct solution. In Koha/REST/V1.pm, we'd just need to do $self->log( Koha::Logger->get({ interface => 'api' }) ) in the startup() function. Easy peasy lemon squeezy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 01:58:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Aug 2022 23:58:49 +0000 Subject: [Koha-bugs] [Bug 18205] API interface to Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 --- Comment #31 from David Cook --- (In reply to David Cook from comment #30) > Easy peasy lemon squeezy. Ok it was slightly different. Koha/REST/V1.pm: sub startup { my $self = shift; + my $logger = Koha::Logger->get({ interface => 'api' }); + $self->log($logger); + Koha/REST/V1/Libraries.pm: sub list { my $c = shift->openapi->valid_input or return; + $c->app->log->debug('DEBUG'); + $c->app->log->warn('WARN'); -- Since /etc/koha/sites/kohadev/log4perl.conf has "api" set to "WARN", only the WARN gets printed out in /var/log/koha/kohadev/api-error.log: [2022/08/25 23:55:01] [WARN] WARN Koha::REST::V1::Libraries::list /kohadevbox/koha/Koha/REST/V1/Libraries.pm (46) [2022/08/25 23:55:41] [WARN] WARN Koha::REST::V1::Libraries::list /kohadevbox/koha/Koha/REST/V1/Libraries.pm (46) [2022/08/25 23:55:43] [WARN] WARN Koha::REST::V1::Libraries::list /kohadevbox/koha/Koha/REST/V1/Libraries.pm (46) I'll submit a patch momentarily... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 02:04:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 00:04:09 +0000 Subject: [Koha-bugs] [Bug 18205] API interface to Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 --- Comment #32 from David Cook --- Created attachment 139811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139811&action=edit Bug 18205: [ALTERNATE] Use Koha::Logger for Mojolicious API logger This patch adds Koha::Logger as the Mojolicious logging object for the API Mojolicious app. Test plan: 0. Apply the patch and koha-plack --restart kohadev 1. Add $c->app->log->debug('DEBUG') and $c->app->log->warn('WARN') to a API controller like Koha::REST::V1::Libraries 2. koha-plack --restart kohadev 3. Go to the API route tied to that API controller method 4. Look at /var/log/koha/kohadev/api-error.log 5. Note that 'WARN' appears but 'DEBUG' does not -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 02:14:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 00:14:11 +0000 Subject: [Koha-bugs] [Bug 18205] API interface to Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 --- Comment #33 from David Cook --- (In reply to David Cook from comment #30) > Easy peasy lemon squeezy. It really was that easy. Good call, Martin from several years ago. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 02:23:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 00:23:41 +0000 Subject: [Koha-bugs] [Bug 18205] API interface to Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 --- Comment #34 from David Cook --- That said, Log::Log4perl doesn't have the exact same api as Mojo::Log. In the case of Mojolicious::Plugin::OpenAPI, it's not a drama, because it only uses $c->app->log->$log_level(), which is supported by Log::Log4perl. Bug 31378 is going to use Mojolicious::Plugin::OAuth2, but it just uses $app->log->error() and $app->log->debug(). When running as a synchronous app, everything seems to work. I wonder what might happen with an asynchronous app though. Not that we're anywhere near that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 02:35:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 00:35:09 +0000 Subject: [Koha-bugs] [Bug 18205] API interface to Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 --- Comment #35 from David Cook --- (In reply to David Cook from comment #34) > That said, Log::Log4perl doesn't have the exact same api as Mojo::Log. > > In the case of Mojolicious::Plugin::OpenAPI, it's not a drama, because it > only uses $c->app->log->$log_level(), which is supported by Log::Log4perl. > > Bug 31378 is going to use Mojolicious::Plugin::OAuth2, but it just uses > $app->log->error() and $app->log->debug(). > > When running as a synchronous app, everything seems to work. I wonder what > might happen with an asynchronous app though. Not that we're anywhere near > that. The *claimed* benefit of MojoX::Log::Log4perl is that you get support for all the Mojo::Log methods (https://metacpan.org/pod/MojoX::Log::Log4perl#DESCRIPTION:) So using Koha::Logger works but I suppose it would come with some risk if we use a plugin which uses a Mojo::Log method that Koha::Logger doesn't support. In reality, MojoX::Log::Log4perl doesn't actually support all of Mojo::Log's methods either, but it subclasses Mojo::EventEmitter which means it could be used in asynchronous code. -- MojoX::Log::Log4perl is only 143 lines of code. We could always do our own version if we cared. -- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 02:43:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 00:43:51 +0000 Subject: [Koha-bugs] [Bug 18205] Use Koha::Logger/Log4Perl using Mojolicious app log method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|API interface to |Use Koha::Logger/Log4Perl |Koha::Logger |using Mojolicious app log | |method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 05:03:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 03:03:29 +0000 Subject: [Koha-bugs] [Bug 31456] Optionally hide lightbox_descriptions from intranet lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31456 --- Comment #2 from Alex Buckley --- Created attachment 139812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139812&action=edit Description hint under image in lightbox gallery on intranet item detail page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 05:03:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 03:03:53 +0000 Subject: [Koha-bugs] [Bug 31456] Optionally hide lightbox_descriptions from intranet lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31456 --- Comment #3 from Alex Buckley --- (In reply to Katrin Fischer from comment #1) > Some cover services might have the link as a condition to using the service. > I wonder if we should investigate this first. Hi Katrin, Could you please let me know when you refer to the 'link' do you mean the description hint displayed under each image - highlighted yellow in the attached screenshot? Hiding that description hint, rather than the link to the image is the purpose of this bug report. Basically, I'm just trying to check if we're talking about the same thing :) Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 05:09:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 03:09:45 +0000 Subject: [Koha-bugs] [Bug 31465] 21.11 manual says it is 20.05 manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31465 AspenCat Team changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam at clicweb.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 08:11:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 06:11:23 +0000 Subject: [Koha-bugs] [Bug 18205] Use Koha::Logger/Log4Perl using Mojolicious app log method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139811|0 |1 is obsolete| | --- Comment #36 from Marcel de Rooy --- Comment on attachment 139811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139811 Bug 18205: [ALTERNATE] Use Koha::Logger for Mojolicious API logger Moving it to 22678 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 08:14:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 06:14:02 +0000 Subject: [Koha-bugs] [Bug 18205] Use Koha::Logger/Log4Perl using Mojolicious app log method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 --- Comment #37 from Marcel de Rooy --- (In reply to David Cook from comment #33) > (In reply to David Cook from comment #30) > > Easy peasy lemon squeezy. > > It really was that easy. Good call, Martin from several years ago. Hmm. Too easy to be true? I tried the same yesterday. And got things like: The application raised the following error: Can't call method "error" on an undefined value at /usr/share/perl5/Mojolicious/Plugin/DefaultHelpers.pm line 94. and the StackTrace middleware couldn't catch its stack trace, possibly because your application overrides $SIG{__DIE__} by itself, preventing the middleware from working correctly. Remove the offending code or module that does it: known examples are CGI::Carp and Carp::Always. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 08:16:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 06:16:46 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 --- Comment #2 from Marcel de Rooy --- Created attachment 139813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139813&action=edit Bug 22678: Use Koha::Logger for Mojolicious API logger This patch adds Koha::Logger as the Mojolicious logging object for the API Mojolicious app. Test plan: 0. Apply the patch and koha-plack --restart kohadev 1. Add $c->app->log->debug('DEBUG') and $c->app->log->warn('WARN') to a API controller like Koha::REST::V1::Libraries 2. koha-plack --restart kohadev 3. Go to the API route tied to that API controller method 4. Look at /var/log/koha/kohadev/api-error.log 5. Note that 'WARN' appears but 'DEBUG' does not -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 08:18:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 06:18:06 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | QA Contact| |m.de.rooy at rijksmuseum.nl Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 08:23:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 06:23:07 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 --- Comment #3 from Marcel de Rooy --- Testing this small piece of code: diff --git a/Koha/REST/V1/Patrons.pm b/Koha/REST/V1/Patrons.pm index 576e4f8f2c..fad1359fc3 100644 --- a/Koha/REST/V1/Patrons.pm +++ b/Koha/REST/V1/Patrons.pm @@ -44,6 +44,7 @@ Controller function that handles listing Koha::Patron objects sub list { my $c = shift->openapi->valid_input or return; +$c->app->log->debug('L47'); return try { my $query = {}; Now hit /api/v1/patrons and see what happens: The application raised the following error: Can't call method "error" on an undefined value at /usr/share/perl5/Mojolicious/Plugin/DefaultHelpers.pm line 94. and the StackTrace middleware couldn't catch its stack trace, possibly because your application overrides $SIG{__DIE__} by itself, preventing the middleware from working correctly. Remove the offending code or module that does it: known examples are CGI::Carp and Carp::Always. Easy peasy lemon squeezy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 08:24:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 06:24:56 +0000 Subject: [Koha-bugs] [Bug 18205] Use Koha::Logger/Log4Perl using Mojolicious app log method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #38 from Marcel de Rooy --- I am ending the discussion here now. Lets try to get 22678 working. Moving this to FQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 08:28:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 06:28:17 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 --- Comment #4 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #3) > Can't call method "error" on an undefined value at > /usr/share/perl5/Mojolicious/Plugin/DefaultHelpers.pm line 94. $c->helpers->log->error(($e = _is_e($e) ? $e : Mojo::Exception->new($e))->inspect) if $page eq 'exception'; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 08:52:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 06:52:08 +0000 Subject: [Koha-bugs] [Bug 29882] remove unrequired package definitions in list-deps script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 08:52:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 06:52:12 +0000 Subject: [Koha-bugs] [Bug 29882] remove unrequired package definitions in list-deps script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129462|0 |1 is obsolete| | --- Comment #2 from Magnus Enger --- Created attachment 139814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139814&action=edit Bug 29882 - remove unrequired package definitions in list-deps script to test... - apply patch, rebuild new package - install new koha-common pkg successfully Signed-off-by: Magnus Enger I did not build packages, just grep'ed the source to check that these modules are no longer used. Please set back to "Needs signoff" if this is not considered good enough. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 09:30:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 07:30:08 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 --- Comment #5 from David Cook --- This is when I fess up that I was being cheeky and did my testing in a 22.11 koha-testing-docker (Mojolicious 8.12) and not a master koha-testing-docker (Mojolicious 9.22). According to https://metacpan.org/dist/MojoX-Log-Log4perl/source/lib/MojoX/Log/Log4perl.pm#L31 Mojolicous 8.23 added a "context" method, which Mojolicious will die on if it's missing from the logger. That's the risk I mentioned in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205#c35 That's where that Koha::Logger::Mojo could come in handy to act as a shim... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 09:34:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 07:34:52 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 --- Comment #6 from Marcel de Rooy --- (In reply to David Cook from comment #5) > This is when I fess up that I was being cheeky and did my testing in a 22.11 > koha-testing-docker (Mojolicious 8.12) and not a master koha-testing-docker > (Mojolicious 9.22). 21.11 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 09:35:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 07:35:47 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 --- Comment #7 from Marcel de Rooy --- (In reply to David Cook from comment #5) > According to > https://metacpan.org/dist/MojoX-Log-Log4perl/source/lib/MojoX/Log/Log4perl. > pm#L31 Mojolicous 8.23 added a "context" method, which Mojolicious will die > on if it's missing from the logger. > > That's the risk I mentioned in > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205#c35 > > That's where that Koha::Logger::Mojo could come in handy to act as a shim... Tested my example with Koha::Logger->context added and it works. Will be testing a bit more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 09:38:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 07:38:30 +0000 Subject: [Koha-bugs] [Bug 30262] opac/tracklinks.pl inconsistent with GetMarcUrls for whitespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30262 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131534|0 |1 is obsolete| | --- Comment #2 from David Cook --- Created attachment 139815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139815&action=edit Bug 30262: Trim whitespace off tracklinks.pl URLs This patch trims whitespace off tracklinks.pl URLs so that the URL is in the same format as the URLs returned by C4::Biblio::GetMarcUrls, which is used by tracklinks.pl internally. Test plan: 0. Apply patch and koha-plack --restart kohadev 1. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=29 2. Add a 856 with $u of 'https://koha-community.org ' (note the space at the end0 3. Save record 4. Change 'TrackClicks' syspref to 'Track' 5. Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=29 6. Click on the online resource (eg http://localhost:8080/cgi-bin/koha/tracklinks.pl?uri=https%3A%2F%2Fkoha-community.org%20&biblionumber=29 ) 7. Note you are redirected to https://koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 09:40:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 07:40:31 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139813|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 139816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139816&action=edit Bug 22678: Use Koha::Logger for Mojolicious API logger This patch adds Koha::Logger as the Mojolicious logging object for the API Mojolicious app. Test plan: 0. Apply the patch and koha-plack --restart kohadev 1. Add $c->app->log->debug('DEBUG') and $c->app->log->warn('WARN') to a API controller like Koha::REST::V1::Libraries 2. koha-plack --restart kohadev 3. Go to the API route tied to that API controller method 4. Look at /var/log/koha/kohadev/api-error.log 5. Note that 'WARN' appears but 'DEBUG' does not Signed-off-by: Marcel de Rooy [EDIT] Adding a context sub to Koha::Logger to get it working. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 09:41:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 07:41:34 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 09:44:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 07:44:49 +0000 Subject: [Koha-bugs] [Bug 30262] opac/tracklinks.pl inconsistent with GetMarcUrls for whitespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30262 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 09:44:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 07:44:53 +0000 Subject: [Koha-bugs] [Bug 30262] opac/tracklinks.pl inconsistent with GetMarcUrls for whitespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30262 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139815|0 |1 is obsolete| | --- Comment #3 from Magnus Enger --- Created attachment 139817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139817&action=edit Bug 30262: Trim whitespace off tracklinks.pl URLs This patch trims whitespace off tracklinks.pl URLs so that the URL is in the same format as the URLs returned by C4::Biblio::GetMarcUrls, which is used by tracklinks.pl internally. Test plan: 0. Apply patch and koha-plack --restart kohadev 1. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=29 2. Add a 856 with $u of 'https://koha-community.org ' (note the space at the end0 3. Save record 4. Change 'TrackClicks' syspref to 'Track' 5. Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=29 6. Click on the online resource (eg http://localhost:8080/cgi-bin/koha/tracklinks.pl?uri=https%3A%2F%2Fkoha-community.org%20&biblionumber=29 ) 7. Note you are redirected to https://koha-community.org Signed-off-by: Magnus Enger Added the link with a space at the end. Verified that without the patch, clickin on "Click here to access online" gives a 404. After applying the patch the redirect works as expected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 09:46:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 07:46:20 +0000 Subject: [Koha-bugs] [Bug 29051] Seen renewal methods incorrectly blocked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 CC| |arthur.suzuki at biblibre.com Status|Pushed to stable |Pushed to oldstable --- Comment #15 from Arthur Suzuki --- pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 09:47:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 07:47:21 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 --- Comment #9 from David Cook --- (In reply to Marcel de Rooy from comment #6) > (In reply to David Cook from comment #5) > > This is when I fess up that I was being cheeky and did my testing in a 22.11 > > koha-testing-docker (Mojolicious 8.12) and not a master koha-testing-docker > > (Mojolicious 9.22). > > 21.11 ? I'm not a time traveller at all >_> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 09:49:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 07:49:51 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 --- Comment #10 from Marcel de Rooy --- A look in my logfile would have been helpful too ;) [2022/08/25 11:42:15] [WARN] ERROR: Unsupported method context at /usr/share/koha/Koha/Logger.pm line 135. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 09:50:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 07:50:23 +0000 Subject: [Koha-bugs] [Bug 30641] Authority detail page shows wrong number of records using the authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30641 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #12 from Magnus Enger --- (In reply to Katrin Fischer from comment #10) > ... and we'll probably need a unit test Should this be "Failed QA" then? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 10:04:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 08:04:05 +0000 Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|22.11.00, 22.05.04 |22.11.00, 22.05.04, released in| |21.11.12 --- Comment #54 from Arthur Suzuki --- pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 10:19:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 08:19:47 +0000 Subject: [Koha-bugs] [Bug 31134] t/Ediorder.t tests failing on 22.05.02 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |arthur.suzuki at biblibre.com Resolution|--- |FIXED --- Comment #10 from Arthur Suzuki --- depends on 30135 not released in 21.11.x. won't backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 10:21:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 08:21:24 +0000 Subject: [Koha-bugs] [Bug 31146] Minor UI problem in recalls history in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #11 from Arthur Suzuki --- Recalls feature not present in 21.11.x. this bug is not relevant to backport in 21.11.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 10:27:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 08:27:24 +0000 Subject: [Koha-bugs] [Bug 21978] Add middle name field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Documentation| |Martin Renvoize contact| | Resolution|--- |FIXED --- Comment #131 from Martin Renvoize --- I think, beyond screenshot updates, there's nothing really to change here for documentation.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 10:27:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 08:27:26 +0000 Subject: [Koha-bugs] [Bug 30617] [OMNIBUS] We should consistently use includes for patron name display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30617 Bug 30617 depends on bug 21978, which changed state. Bug 21978 Summary: Add middle name field https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 10:31:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 08:31:19 +0000 Subject: [Koha-bugs] [Bug 31462] Add a way to batch edit items without displaying all the items in a table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31462 --- Comment #2 from mathieu saby --- Oh thank you, you are right, I missed this syspref! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 11:07:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 09:07:56 +0000 Subject: [Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 Paul Derscheid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139394|0 |1 is obsolete| | --- Comment #25 from Paul Derscheid --- Created attachment 139818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139818&action=edit Bug 31380: Allow Koha Plugins to run using Mojolicious controllers This patch adds a new mount point in plack.psgi, which makes Koha able to run Mojolicious controllers. For example: http://localhost:8081/cgi-bin/koha/staff/plugins/run 0a) Apply patch 0b) cp debian/templates/plack.psgi /etc/koha/sites/kohadev/plack.psgi 0c) koha-plack --restart 1) Upload Koha Plugin koha-plugin-mojolicious.kpz 2) koha-plack --restart 3) Go to http://localhost:8081/cgi-bin/koha/plugins/plugins-home.pl 4) Next to "Mojolicious Test", click "Actions", then click "Run tool" 5) Note that the web page looks perfect 6) Note that the URL is a bit different to normal: http://localhost:8081/cgi-bin/koha/staff/plugins/run?class=Koha%3A%3APlugin%3A%3AProsentient%3A%3AMojolicious&method=tool instead of: http://localhost:8081/cgi-bin/koha/plugins/run.pl?class=Koha%3A%3APlugin%3A%3AProsentient%3A%3AMojolicious&method=tool Note: The test Koha plugin will only work with a Mojolicious controller, but it could be easily made to work with both Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 11:08:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 09:08:00 +0000 Subject: [Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 Paul Derscheid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139395|0 |1 is obsolete| | --- Comment #26 from Paul Derscheid --- Created attachment 139819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139819&action=edit Bug 31380: Add plugin hook for choosing Mojolicious or CGI script controller This change checks for a "use_mojolicious" method in the plugin in order to determine whether it should use a Mojolicious controller or a CGI script controller. Note that the check is for the existence of the method, so it is backwards compatible with all existing Koha Plugins. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 11:08:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 09:08:05 +0000 Subject: [Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 Paul Derscheid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139396|0 |1 is obsolete| | --- Comment #27 from Paul Derscheid --- Created attachment 139820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139820&action=edit Bug 31380: Add unit tests Signed-off-by: Kyle M Hall Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 11:09:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 09:09:19 +0000 Subject: [Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 Paul Derscheid changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid at lmscloud.de --- Comment #28 from Paul Derscheid --- Ha, meant to sign-off on all three but Kyle already did, so. Just tested it out and I love this. Great work! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 11:25:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 09:25:28 +0000 Subject: [Koha-bugs] [Bug 31468] New: Koha::Logger should prefix interface with 'plack' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Bug ID: 31468 Summary: Koha::Logger should prefix interface with 'plack' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Koha::Logger->get( interface => 'opac' ) should write to plack-opac under plack. We still need a few tiny tweaks in Context and Logger. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 11:25:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 09:25:37 +0000 Subject: [Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 11:25:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 09:25:44 +0000 Subject: [Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 11:34:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 09:34:03 +0000 Subject: [Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 --- Comment #1 from Marcel de Rooy --- Created attachment 139821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139821&action=edit Bug 31468: Changes to C4::Context::is_psgi_or_plack When running API, we need to look for $ENV{PLACK_ENV}, but the underscore is not included in the Context sub. Test plan: Run t/Context.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 11:35:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 09:35:20 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Paul Derscheid changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- CC| |paul.derscheid at lmscloud.de Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 11:35:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 09:35:22 +0000 Subject: [Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Bug 24631 depends on bug 23975, which changed state. Bug 23975 Summary: Add ability to search and install plugins from GitHub https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 11:35:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 09:35:22 +0000 Subject: [Koha-bugs] [Bug 24632] Plugins should support simple signing for security/verifiability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24632 Bug 24632 depends on bug 23975, which changed state. Bug 23975 Summary: Add ability to search and install plugins from GitHub https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 11:35:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 09:35:22 +0000 Subject: [Koha-bugs] [Bug 24634] Support display of changelog files for plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24634 Bug 24634 depends on bug 23975, which changed state. Bug 23975 Summary: Add ability to search and install plugins from GitHub https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 11:35:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 09:35:23 +0000 Subject: [Koha-bugs] [Bug 24635] Support display of readme files for plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24635 Bug 24635 depends on bug 23975, which changed state. Bug 23975 Summary: Add ability to search and install plugins from GitHub https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 11:35:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 09:35:23 +0000 Subject: [Koha-bugs] [Bug 25952] Github search for plugin throwing errors due to API rate limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25952 Bug 25952 depends on bug 23975, which changed state. Bug 23975 Summary: Add ability to search and install plugins from GitHub https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 11:35:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 09:35:23 +0000 Subject: [Koha-bugs] [Bug 26751] Fatal exception if only one repo defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26751 Bug 26751 depends on bug 23975, which changed state. Bug 23975 Summary: Add ability to search and install plugins from GitHub https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 11:35:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 09:35:23 +0000 Subject: [Koha-bugs] [Bug 24633] Add support for gitlab searching of plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24633 Bug 24633 depends on bug 23975, which changed state. Bug 23975 Summary: Add ability to search and install plugins from GitHub https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 11:36:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 09:36:11 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #45 from Paul Derscheid --- The patches don't apply on the current master branch anymore. Lots of merge conflicts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 11:42:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 09:42:20 +0000 Subject: [Koha-bugs] [Bug 31469] New: plack logfiles need %n in conversionpattern Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31469 Bug ID: 31469 Summary: plack logfiles need %n in conversionpattern Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 11:43:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 09:43:31 +0000 Subject: [Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 --- Comment #2 from Marcel de Rooy --- Created attachment 139822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139822&action=edit Bug 31468: Change interface in Koha::Logger Test plan: Add a line in mainpage.pl: require Koha::Logger; Koha::Logger->get->warn("intranet L51"); Restart. Hit intranet mainpage. Verify that line is in plack=intranet. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 11:44:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 09:44:33 +0000 Subject: [Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from Marcel de Rooy --- This is trivial and architectural. Going to SO rightaway. Need this for 22678 too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 11:44:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 09:44:42 +0000 Subject: [Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 11:45:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 09:45:22 +0000 Subject: [Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 11:45:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 09:45:49 +0000 Subject: [Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22678 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 11:45:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 09:45:49 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31468 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 [Bug 31468] Koha::Logger should prefix interface with 'plack' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 11:50:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 09:50:07 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 --- Comment #11 from Marcel de Rooy --- What we still needed, was bug 31468 even. To get the line in the right file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 12:03:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 10:03:07 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 --- Comment #12 from Marcel de Rooy --- And even bug 31469 to add some newlines with %n -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 12:04:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 10:04:18 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 --- Comment #13 from Marcel de Rooy --- Plugin/Exceptions.pm:use Koha::Logger; Plugin/Exceptions.pm: my $logger = Koha::Logger->get({ interface => 'api' }); Plugin/PluginRoutes.pm:use Koha::Logger; Plugin/PluginRoutes.pm: my $logger = Koha::Logger->get({ interface => 'api' }); V1.pm:use Koha::Logger; V1.pm: my $logger = Koha::Logger->get({ interface => 'api' }); V1.pm: my $logger = Koha::Logger->get({ interface => 'api' }); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 12:45:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 10:45:50 +0000 Subject: [Koha-bugs] [Bug 31456] Optionally hide lightbox_descriptions from intranet lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31456 --- Comment #4 from Katrin Fischer --- Yes, I mean that text/link below the picture. I know of at least one German provider where a link behind the image was not enough and there was supposed to be text as well (again, this might have changed). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 12:50:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 10:50:56 +0000 Subject: [Koha-bugs] [Bug 31456] Optionally hide lightbox_descriptions from intranet lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31456 --- Comment #5 from Katrin Fischer --- I've quickly looked around a bit: Open Library Covers API (optional?) https://openlibrary.org/dev/docs/api/covers 3) A courtesy link back to Open Library is appreciated, whether it be on each individual book's page (where you can link back to the book's page on Open Library, for example, using the same ISBN https://openlibrary.org/isbn/9780385533225), or on your About page or in your footer. Amazon Cover API https://developers.google.com/books/branding ? Google must be given attribution, using the appropriate text or brand elements, whenever you display Google results, previews, or other content made available through the API. You must maintain prominent links to Google Books pages and features. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 13:48:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 11:48:32 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #46 from Tomás Cohen Arazi --- (In reply to Paul Derscheid from comment #45) > The patches don't apply on the current master branch anymore. Lots of merge > conflicts. This is already in the codebase since 2020. Best regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 13:48:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 11:48:33 +0000 Subject: [Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Bug 24631 depends on bug 23975, which changed state. Bug 23975 Summary: Add ability to search and install plugins from GitHub https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 13:48:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 11:48:34 +0000 Subject: [Koha-bugs] [Bug 24632] Plugins should support simple signing for security/verifiability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24632 Bug 24632 depends on bug 23975, which changed state. Bug 23975 Summary: Add ability to search and install plugins from GitHub https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 13:48:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 11:48:34 +0000 Subject: [Koha-bugs] [Bug 24634] Support display of changelog files for plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24634 Bug 24634 depends on bug 23975, which changed state. Bug 23975 Summary: Add ability to search and install plugins from GitHub https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 13:48:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 11:48:34 +0000 Subject: [Koha-bugs] [Bug 24635] Support display of readme files for plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24635 Bug 24635 depends on bug 23975, which changed state. Bug 23975 Summary: Add ability to search and install plugins from GitHub https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 13:48:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 11:48:34 +0000 Subject: [Koha-bugs] [Bug 25952] Github search for plugin throwing errors due to API rate limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25952 Bug 25952 depends on bug 23975, which changed state. Bug 23975 Summary: Add ability to search and install plugins from GitHub https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 13:48:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 11:48:35 +0000 Subject: [Koha-bugs] [Bug 26751] Fatal exception if only one repo defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26751 Bug 26751 depends on bug 23975, which changed state. Bug 23975 Summary: Add ability to search and install plugins from GitHub https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 13:48:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 11:48:34 +0000 Subject: [Koha-bugs] [Bug 24633] Add support for gitlab searching of plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24633 Bug 24633 depends on bug 23975, which changed state. Bug 23975 Summary: Add ability to search and install plugins from GitHub https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 13:50:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 11:50:23 +0000 Subject: [Koha-bugs] [Bug 26573] Limit patron attribute types to more than one patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26573 --- Comment #4 from Julian Maurice --- Created attachment 139823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139823&action=edit Bug 26573: Limit patron attribute types to more than one patron category Test plan: 1. Create patron attribute types, some with a category limit, some without 2. Apply patch 3. Run installer/data/mysql/updatedatabase.pl 4. Run misc/devel/update_dbix_class_files.pl --koha-conf 5. Restart koha 6. Verify that existing category limits were kept 7. Create a new patron attribute type and select multiple category limits. Verify that they have been saved correctly. 8. Edit this patron attribute type and modify category limits. Verify that the changes have been saved correctly 9. Go to the patron creation form, and verify that patron attributes are shown/hidden accordingly when categorycode is changed. 10. Go to patron batch modification tool, enter a cardnumber (or a borrowernumber) and submit the form to go to the next step. Now select a patron attribute type that has category limits and verify that the message shown to the right is correct -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 13:50:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 11:50:36 +0000 Subject: [Koha-bugs] [Bug 26573] Limit patron attribute types to more than one patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26573 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 13:50:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 11:50:46 +0000 Subject: [Koha-bugs] [Bug 26573] Limit patron attribute types to more than one patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26573 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 13:58:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 11:58:30 +0000 Subject: [Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a patron can hold the given item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |arthur.suzuki at biblibre.com --- Comment #9 from Arthur Suzuki --- Patch applies with conflicts + tests failing. Please provide a patch for 21.11 if needed. " # Failed test 'do_hold' # at t/db_dependent/SIP/Transaction.t line 272. DBIx::Class::ResultSource::_minimal_valueset_satisfying_constraint(): Unable to satisfy requested constraint 'primary', missing values for column(s): 'itemnumber' at /kohadevbox/koha/Koha/Objects.pm line 96 # Looks like your test exited with 11 just after 7. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 6/12 subtests " -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 14:08:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 12:08:03 +0000 Subject: [Koha-bugs] [Bug 31069] Did you mean? in the OPAC - links have tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |arthur.suzuki at biblibre.com Status|Pushed to stable |RESOLVED --- Comment #15 from Arthur Suzuki --- Can't reproduce the bug on 21.11. feel free to ask if backport needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 14:14:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 12:14:34 +0000 Subject: [Koha-bugs] [Bug 31153] Search bar not visible on recalls history page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #12 from Arthur Suzuki --- Recalls feature not present in 21.11. won't backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 14:14:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 12:14:34 +0000 Subject: [Koha-bugs] [Bug 29734] [OMNIBUS] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734 Bug 29734 depends on bug 31153, which changed state. Bug 31153 Summary: Search bar not visible on recalls history page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 14:30:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 12:30:05 +0000 Subject: [Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450 Paul Derscheid changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 14:30:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 12:30:08 +0000 Subject: [Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450 --- Comment #2 from Paul Derscheid --- Created attachment 139824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139824&action=edit Bug 31450 - HTML customizations and News will not display on OPAC without Publication date To test: 1) Create some HTML Customizations and some News items that are set to display on the OPAC. Create one of each: [ 'With publication date today', 'With publication date in the future', 'Without publication date' ] 2) Note that news with publication date 'today' will display; with publication date 'in the future' will not display; with publication date unset will not display. 3) Note that html_customizations with date 'today' will display; with publication date 'in the future' will not display; with publication date unset will display. 4) Sign-Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 14:32:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 12:32:45 +0000 Subject: [Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450 Paul Derscheid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139824|0 |1 is obsolete| | --- Comment #3 from Paul Derscheid --- Created attachment 139825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139825&action=edit Bug 31450 - HTML customizations and News will not display on OPAC without Publication date To test: 1) Create some HTML Customizations and some News items that are set to display on the OPAC. Create one of each: [ 'With publication date today', 'With publication date in the future', 'Without publication date' ] 2) Note that news with publication date 'today' will display; with publication date 'in the future' will not display; with publication date unset will not display. 3) Note that html_customizations with date 'today' will display; with publication date 'in the future' will not display; with publication date unset will display. 4) Sign-Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 14:37:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 12:37:30 +0000 Subject: [Koha-bugs] [Bug 31470] New: Incorrect selector for relationship dropdown used in members.js Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Bug ID: 31470 Summary: Incorrect selector for relationship dropdown used in members.js Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: emmi.takkinen at koha-suomi.fi QA Contact: testopia at bugs.koha-community.org In members.js line 112 variable guarantor_relationship is selected with id "relationship". Correct selector should however be class "relationship" since id "relationship" is used in auth-finder-search.inc, not in memberentry.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 14:44:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 12:44:13 +0000 Subject: [Koha-bugs] [Bug 31470] Incorrect selector for relationship dropdown used in members.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |emmi.takkinen at koha-suomi.fi --- Comment #1 from Emmi Takkinen --- Created attachment 139826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139826&action=edit Use class "relationship" instead of id "relationship" in members.js In members.js line 112 variable guarantor_relationship is selected with id "relationship". Correct selector should however be class "relationship" since id "relationship" is used in auth-finder-search.inc, not in memberentry.pl. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 14:45:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 12:45:31 +0000 Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |arthur.suzuki at biblibre.com Status|Pushed to stable |RESOLVED --- Comment #17 from Arthur Suzuki --- conflicts in templates when trying to apply on 21.11. Provide a backport if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 14:51:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 12:51:56 +0000 Subject: [Koha-bugs] [Bug 31068] Context for translation: Print (verb) vs. Print (noun) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31068 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #8 from Arthur Suzuki --- enhancement, lots of changes (and conflicts on templates) thus not backporting to 21.11. Ask or provide a backport if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 15:02:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 13:02:36 +0000 Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632 --- Comment #18 from Nick Clemens --- Created attachment 139827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139827&action=edit Bug 29632: [21.11.X] Don't sort cn-sort numerically When defining our sort fields in we defined all as 'numeric' For other string containing numbers this is likely correct, however, for callnumbers it is not. e.g. E45 should sort before E7 This patch adds a new 'callnumber' type and deifnes this for cn-sort and adds to the field maping a sort without numeric set To test: 0 - Be using ES with Koha 1 - On records with single item, add callnumbers: VA65 E7 R63 1984 VA65 E7 T35 1990 VA65 E45 R67 1985 2 - Add public note 'shrimp' or something to make them easily searchable as a group 3 - Search for 'shrimp', sort by callnumber 4 - Note E45 comes last, it should come first 5 - Apply patch 6 - Reset ES mappings 7 - Reindex ES 8 - Repeat search 9 - Sorting should be correct when set to callnumber Signed-off-by: David Nind Signed-off-by: Michal Urban Signed-off-by: Martin Renvoize Bug 29632: Unit tests This patch adds unit tests, as well as changing existing test to use a mock and read the data as passed in tests, rather than relying on what exists in the DB Signed-off-by: Martin Renvoize Bug 29632: (QA follow-up) Add ENUM value to kohastructure.sql :-D Signed-off-by: Tomas Cohen Arazi Bug 29632: (QA follow-up) Fix COMMENT discrepancy on upgrade Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 15:02:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 13:02:46 +0000 Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 15:02:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 13:02:53 +0000 Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 15:02:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 13:02:59 +0000 Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 15:03:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 13:03:04 +0000 Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 15:03:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 13:03:12 +0000 Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 15:03:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 13:03:28 +0000 Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632 --- Comment #19 from Nick Clemens --- (In reply to Arthur Suzuki from comment #17) > conflicts in templates when trying to apply on 21.11. > Provide a backport if needed. Patch supplied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 15:12:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 13:12:43 +0000 Subject: [Koha-bugs] [Bug 30905] Show waiting recalls in patron account on checkouts tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30905 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |arthur.suzuki at biblibre.com Status|Pushed to stable |RESOLVED --- Comment #7 from Arthur Suzuki --- depends on recalls, feature not available in 21.11. Won't backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 15:19:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 13:19:19 +0000 Subject: [Koha-bugs] [Bug 26377] Clearly label parts of subscription-add.pl that relate to optional item records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #20 from Arthur Suzuki --- not feeling very confident while trying to fix the conflicts after applying on 21.11. Please provide backport if needed. Best, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 15:27:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 13:27:55 +0000 Subject: [Koha-bugs] [Bug 31453] Add ability to skip processing messages in message queue based on message contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31453 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139736|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 139828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139828&action=edit Bug 31453: Add ability to skip processing messages in message queue based on message contents It would be very useful to be able to tell process_message_queue.pl to skip processing some messages. This is particularly useful where a plugin handles sending some message using the before_send_messages hook, but while that plugin is processing, more messages meant for the plugin might be queued. At that point, control moves back to the script and SendQueuedMessages is called, and those messages end up being processed there instead of by the plugin. Test Plan: 1) Apply this patch 2) Queue two messages, each with a unique word 3) Run process_message_queue --content-not-like "WORD" where WORD is a unique word in one of the two message 4) Note the message containing "WORD" was not processed 5) prove t/db_dependent/Letters.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 15:37:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 13:37:49 +0000 Subject: [Koha-bugs] [Bug 31367] Display of sub-funds does not include totals of sub-sub-funds on acquisitions home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31367 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 15:37:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 13:37:52 +0000 Subject: [Koha-bugs] [Bug 31367] Display of sub-funds does not include totals of sub-sub-funds on acquisitions home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31367 --- Comment #1 from Nick Clemens --- Created attachment 139829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139829&action=edit Bug 31367: Add subtotals if budget has children On bug 29287 we added child funds if a fund had no parent id It turns out funds can have a parent, and still have children (sub-sub-funds) This patch simply checks for children, rather than checking for lack of parent. Totals are already calculated correctly in GetBudgetHierarchy To test: 1 - Add a fund "Fund" to a budget - assign 1000 dollars 2 - Add a sub-fund "SubFund" - assign 100 dollars 3 - Add a sub-sub-fund "SubSubFund" - assign 10 dollars 4 - Add to a basket $5 order from SubSubFund 5 - Add to a basket $50 order from SubFund 6 - Add to a basket $500 order form Fun 7 - View acqui home - note 'SubFund' does not include total from 'SubSubFund' 8 - Apply patch 9 - Confirm all sub-sub-funds totaled in sub-funds and that fund total correctly adds sub and sub-sub funds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 15:38:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 13:38:05 +0000 Subject: [Koha-bugs] [Bug 31367] Display of sub-funds does not include totals of sub-sub-funds on acquisitions home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31367 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 15:47:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 13:47:45 +0000 Subject: [Koha-bugs] [Bug 30039] Add publication date column to serial claims table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30039 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #13 from Arthur Suzuki --- lots of conflicts on templates. Can you provide a backport patch for 21.11 if needed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 15:49:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 13:49:29 +0000 Subject: [Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #19 from Arthur Suzuki --- enhancement, lots of conflicts... won't apply unless backport patch provided for 21.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 15:49:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 13:49:30 +0000 Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 Bug 29226 depends on bug 30570, which changed state. Bug 30570 Summary: Replace the use of jQueryUI tabs in OPAC templates https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 15:49:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 13:49:30 +0000 Subject: [Koha-bugs] [Bug 31248] Fix responsive table style in the OPAC after switch to Bootstrap tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31248 Bug 31248 depends on bug 30570, which changed state. Bug 30570 Summary: Replace the use of jQueryUI tabs in OPAC templates https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 15:52:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 13:52:50 +0000 Subject: [Koha-bugs] [Bug 30039] Add publication date column to serial claims table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30039 --- Comment #14 from Lucas Gass --- (In reply to Arthur Suzuki from comment #13) > lots of conflicts on templates. > Can you provide a backport patch for 21.11 if needed? We don't need this one to be backported to 21.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 15:54:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 13:54:19 +0000 Subject: [Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 15:57:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 13:57:59 +0000 Subject: [Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 --- Comment #15 from Lucas Gass --- Since I only changed the column names I am keeping David's sign-off and setting this one to 'Signed-off'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 16:53:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 14:53:45 +0000 Subject: [Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a patron can hold the given item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094 --- Comment #10 from Kyle M Hall --- Created attachment 139830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139830&action=edit Bug 29094: Adding hold via SIP should check if patron can hold item first [21.11.x] When placing holds via SIP2, there is no holdability check. This seems very incorrect. Test Plan: 1) Apply this patch 2) prove -r t/db_dependent/SIP Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 17:57:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 15:57:10 +0000 Subject: [Koha-bugs] [Bug 31471] New: Duplicate check in cataloguing doesn't work with Elasticsearch Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31471 Bug ID: 31471 Summary: Duplicate check in cataloguing doesn't work with Elasticsearch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de CC: michaela.sieber at kit.edu The duplicate check in cataloguing doesn't work with Elasticsearch. To test: * With Zebra: Download a record via Z39.50 and save. * Make sure the record is found in the catalog. * Download the same record via Z39.50 again and try to save - duplicate confirm message pops up. * Switch to Zebra * Again, make sure that the record can be found in the catalog. * Download the record again via Z39.50 and try to save - no duplicate warning, the record is saved. If an example is needed we could provide a taget and sample. Note: As I understand FindDuplicate it checks for ISSN and after that a combination of title and author. Is there a thing we might be missing here? Tested in different installations with master and 21.11. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 18:03:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 16:03:48 +0000 Subject: [Koha-bugs] [Bug 31472] New: Extend FindDuplicate to use 001 + 003 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31472 Bug ID: 31472 Summary: Extend FindDuplicate to use 001 + 003 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl, michaela.sieber at kit.edu It would be nice if the duplicate check used in cataloging and some other places could also take into account the 001 + 003 fields. When working with a union catalog this would be the best check to perform to make sure any real duplicates are found. Not sure if this needs to be optional. Bug 15248 asked about making the checks configurable, but I am not sure what a good syntax here could look like. Having several preconfigured options in a (multi-)select preference might be easier. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 18:03:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 16:03:48 +0000 Subject: [Koha-bugs] [Bug 8994] Make FindDuplicateAuthority behaviour customizable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8994 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31472 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 18:03:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 16:03:48 +0000 Subject: [Koha-bugs] [Bug 15248] Make it possible to configure duplicate check on bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15248 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31472 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 18:31:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 16:31:01 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 18:31:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 16:31:06 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139351|0 |1 is obsolete| | --- Comment #104 from Katrin Fischer --- Created attachment 139831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139831&action=edit Bug 15348: Add estimated delivery date field to individual orders This patch allows you to specify an estimated delivery date per order. The specified estimated delivery date is also considered when searching for late orders and exporting late orders. You can also edit the estimated delivery date from the late orders page. Test plan: 1. Update database, rebuild schema, restart services 2. Go to Acquisitions, search for a vendor, and create a new basket 3. Add an order to the basket. When filling in the accounting details, notice the new 'estimated delivery date' field, but don't add a date. Save the order. 4. Confirm no date shows in the estimated delivery date column in the orders table. 5. Modify the order. Add a date in the estimated delivery date field and save the order. 6. Confirm the date now shows in the orders table. 7. Close the basket. 8. Go to the Late Orders page. 9. Put estimated delivery date from and to parameters in the search filters on the left. Ensure the from and to dates encapsulate the date you entered in the estimated delivery date field for the order. 10. Click Filter and ensure the order shows. 11. Select the checkbox next to the order. Click the Export as CSV button. 12. Open the CSV and confirm the estimated delivery date that you entered shows as expected in the file. 13. Click Edit under the estimated delivery date. Confirm the estimated delivery date modal pops up with the correct order line number in the modal header. 14. Remove the estimated delivery date and click Save. 15. Confirm that the estimated delivery date calculated by Koha now shows in the late orders table. 16. Select the checkbox next to the order. Click the Export as CSV button. 17. Open the CSV and confirm the calculated estimated delivery date shows in the CSV. 18. Confirm tests pass: t/db_dependent/Koha/Acquisition/Order.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: Christian Stelzenmüller Signed-off-by: Martin Renvoize Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 18:31:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 16:31:12 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139352|0 |1 is obsolete| | --- Comment #105 from Katrin Fischer --- Created attachment 139832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139832&action=edit Bug 15348: (QA follow-up) Remove superflous filters The QA script highlighted the addition of some unneeded extra TT filters. Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 18:31:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 16:31:18 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139353|0 |1 is obsolete| | --- Comment #106 from Katrin Fischer --- Created attachment 139833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139833&action=edit Bug 15348: trivial code simplification Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 18:31:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 16:31:23 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139354|0 |1 is obsolete| | --- Comment #107 from Katrin Fischer --- Created attachment 139834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139834&action=edit Bug 15348: (follow-up) Fix breadcrumbs, title, JS error, permissions Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 18:31:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 16:31:29 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139355|0 |1 is obsolete| | --- Comment #108 from Katrin Fischer --- Created attachment 139835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139835&action=edit Bug 15348: (follow-up) Fix TT filters from html to uri Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 18:31:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 16:31:34 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139356|0 |1 is obsolete| | --- Comment #109 from Katrin Fischer --- Created attachment 139836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139836&action=edit Bug 15348: (follow-up) Fix export of dt_from_string FAIL acqui/addorder.pl FAIL valid " dt_from_string " is not exported by the Koha::DateUtils module Can't continue after import errors Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 18:31:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 16:31:39 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139357|0 |1 is obsolete| | --- Comment #110 from Katrin Fischer --- Created attachment 139837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139837&action=edit Bug 15348: (follow-up) Fix imports in moddeliverydate.pl Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 18:31:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 16:31:46 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139358|0 |1 is obsolete| | --- Comment #111 from Katrin Fischer --- Created attachment 139838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139838&action=edit Bug 15348: (follow-up) Update calendar widget to flatpickr Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 18:31:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 16:31:52 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139359|0 |1 is obsolete| | --- Comment #112 from Katrin Fischer --- Created attachment 139839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139839&action=edit Bug 15348: (follow-up) Fix calendar widget, translateability, etc Also add functionality to edit the estimated delivery date from a closed basket. Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 18:31:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 16:31:58 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139360|0 |1 is obsolete| | --- Comment #113 from Katrin Fischer --- Created attachment 139840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139840&action=edit Bug 15348: DBIC changes DO NOT PUSH For testing purposes Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 18:32:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 16:32:03 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139361|0 |1 is obsolete| | --- Comment #114 from Katrin Fischer --- Created attachment 139841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139841&action=edit Bug 15348: (follow-up) Fix modal to edit delivery date This allows you to empty the delivery date and ensures the current date shows Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 18:32:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 16:32:08 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139362|0 |1 is obsolete| | --- Comment #115 from Katrin Fischer --- Created attachment 139842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139842&action=edit Bug 15348: (follow-up) Fix filtering results on estimated delivery date Adding another clause to the SQL so that the specified estimated delivery date is used for filtering first, and the calculated delivery date is used if there is no specified estimated delivery date. Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 18:32:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 16:32:13 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139363|0 |1 is obsolete| | --- Comment #116 from Katrin Fischer --- Created attachment 139843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139843&action=edit Bug 15348: (follow-up) Move estimated delivery date before supplier report and fix column settings On the basket summary page the estimated delivery date column was moved before the supplier report column, that is only visible when EDIFACT has been activated. It also adds the new column to the table configuration. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 18:32:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 16:32:18 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139364|0 |1 is obsolete| | --- Comment #117 from Katrin Fischer --- Created attachment 139844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139844&action=edit Bug 15348: (follow-up) Fix sorting of estimated delivery date on basket summary page Also removes some unneded variables from the table footers that are used to display amount totals. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 18:32:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 16:32:23 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139365|0 |1 is obsolete| | --- Comment #118 from Katrin Fischer --- Created attachment 139845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139845&action=edit Bug 15348: (follow-up) Fix pre-selected date when editing from late orders page When editing the estimated delivery date from the late orders page, with multiple late orders, the selected date in the edit form would always be the same, not matching the edited date. With this page, the edited date will match what is shown in the form. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 18:33:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 16:33:21 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #119 from Katrin Fischer --- Rebased, tests pass and retested functionality on addorder.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 18:58:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 16:58:28 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139168|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer --- Created attachment 139846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139846&action=edit Bug 16522: Adding 773 to cart and list displays and emails This patch adds a new subroutine get_marc_host in the Koha::Biblio module which retrieves any 773 fields from the biblio record. The subroutine is used to show a host item entry and a link to the record in the following places: - staff client list - staff client cart - staff client send list email - staff client send cart email - staff client search results - staff client detail page - opac list - opac cart - opac send list email email - opac send cart email - opac search results - opac detail page To test: 1. apply patch, restart services 2. log into the staff client and enable the syspref EasyAnalyticalRecords 3. find a record with an item. take note of the barcode. 4. go to another record (biblio 2). click Edit -> Link to host record 5. enter the barcode in the input and submit. 6. click the MARC tab and confirm the host record has been linked under MARC field 773. 7. add biblio 2 to your cart, and to a list. 8. go to your cart. confirm you see the 'host item entry' link. 9. click on 'more details' and confirm you see the 'host item entries' link. 10. click 'send' to email the cart. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 11. go to the list you added the record to. confirm you see the 'source' link for the host item entry. 12. click 'send list' to email the list. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 13. log into the OPAC. repeat steps 7 to 12 on the OPAC and confirm they all pass as expected. 14. Confirm host item info also shows correctly on the OPAC and staff client search results, and the OPAC and staff client detail pages (where XSLT is used) 15. Delete the 773$w and confirm host item info still shows correctly but no longer links to biblio 16. confirm tests pass t/db_dependent/Koha/Biblio/host_record.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 18:58:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 16:58:34 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139169|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer --- Created attachment 139847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139847&action=edit Bug 16522: (follow-up) MARC display templates and get_marc_host fixes Also: - Show related parts 773$g - Normalise using 'Host item entry' as title - Remove 'foreach' because non-xslt views only return first - If no $w, use $atg, and related tests in t/db_dependent/Koha/Biblio/host_record.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 18:58:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 16:58:39 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #26 from Katrin Fischer --- Created attachment 139848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139848&action=edit Bug 16522: (follow-up) Add missing TT filters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 19:02:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 17:02:41 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #27 from Katrin Fischer --- Rebased and provided a follow-up to make the QA test tools pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 19:06:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 17:06:07 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #28 from Katrin Fischer --- (In reply to Katrin Fischer from comment #27) > Rebased and provided a follow-up to make the QA test tools pass. Conflict was limited to sendbasket.pl and the change to this line: $dat->{ITEM_RESULTS} = $biblio->items->search_ordered; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 19:08:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 17:08:19 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #105 from Katrin Fischer --- Patches currently don't apply and the conflicts looked a bit too intimidating for me: Applying: Bug 3150: Move emails for sending cart and list contents to notices Using index info to reconstruct a base tree... M basket/sendbasket.pl M installer/data/mysql/en/mandatory/sample_notices.yml M opac/opac-sendbasket.pl M opac/opac-sendshelf.pl M virtualshelves/sendshelf.pl Falling back to patching base and 3-way merge... Auto-merging virtualshelves/sendshelf.pl CONFLICT (content): Merge conflict in virtualshelves/sendshelf.pl Auto-merging opac/opac-sendshelf.pl CONFLICT (content): Merge conflict in opac/opac-sendshelf.pl Auto-merging opac/opac-sendbasket.pl CONFLICT (content): Merge conflict in opac/opac-sendbasket.pl Auto-merging installer/data/mysql/en/mandatory/sample_notices.yml Auto-merging basket/sendbasket.pl CONFLICT (content): Merge conflict in basket/sendbasket.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 3150: Move emails for sending cart and list contents to notices hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-3150-Move-emails-for-sending-cart-and-list-con-Oc2KWz.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 19:08:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 17:08:22 +0000 Subject: [Koha-bugs] [Bug 30328] Add ability to generate barcode with branch specific prefix In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328 --- Comment #14 from Nick Clemens --- (In reply to Emmi Takkinen from comment #13) > Fixed adding multiple items. Still thinking if we really can use items home > library to determine barcode prefix. There are plugin hooks for barcodes now: https://github.com/bywatersolutions/dev-koha-plugin-kitchen-sink/commit/0ee1ea69bf01b47e63c1406e4f2a0831ebec906b And we have a plugin for prefixing barcodes with library prefixes: https://github.com/bywatersolutions/koha-plugin-barcode-prefixer Just mentioning as that may work for this case -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 19:08:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 17:08:49 +0000 Subject: [Koha-bugs] [Bug 31381] [Intranet/REST-API] Searching patrons by letter broken when using non-mandatory extended attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31381 --- Comment #10 from Nick Clemens --- (In reply to Jonathan Druart from comment #9) > Yes, Oliver, I think it's the way to go. > > Asking for more opinions, Nick what do you think? Asking Tomas :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 20:45:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 18:45:07 +0000 Subject: [Koha-bugs] [Bug 29882] Remove unrequired package definitions in list-deps script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|remove unrequired package |Remove unrequired package |definitions in list-deps |definitions in list-deps |script |script -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 21:05:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 19:05:01 +0000 Subject: [Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 21:05:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 19:05:05 +0000 Subject: [Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 --- Comment #45 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 21:05:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 19:05:10 +0000 Subject: [Koha-bugs] [Bug 21366] Add Plack reload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 21:05:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 19:05:13 +0000 Subject: [Koha-bugs] [Bug 21366] Add Plack reload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #32 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 21:05:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 19:05:16 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 21:05:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 19:05:19 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #104 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 21:05:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 19:05:21 +0000 Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 21:05:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 19:05:25 +0000 Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #25 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 21:39:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 19:39:16 +0000 Subject: [Koha-bugs] [Bug 31473] New: Test about bad OpacHiddenItems conf fragile Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Bug ID: 31473 Summary: Test about bad OpacHiddenItems conf fragile Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org It tests for data truncation (when a two-letter string is passed for a tinyint(1) field) but there's been some behavior change in the way expressions are processed that makes the test fail: # Failed test at t/db_dependent/Koha/Items.t line 1754. # got: 'Truncated incorrect DECIMAL value: 'AB'' # expected: 'Truncated incorrect DOUBLE value: 'AB'' The fact the expression was tested as a DECIMAL or a DOUBLE first is not really relevant here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 21:40:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 19:40:02 +0000 Subject: [Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | CC| |arthur.suzuki at biblibre.com, | |lucas at bywatersolutions.com, | |victor at tuxayo.net Depends on| |28125 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 [Bug 28125] All OPAC holds blocked when OPACHiddenItems contains incorrect values -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 21:40:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 19:40:02 +0000 Subject: [Koha-bugs] [Bug 28125] All OPAC holds blocked when OPACHiddenItems contains incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31473 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 [Bug 31473] Test about bad OpacHiddenItems conf fragile -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 21:53:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 19:53:51 +0000 Subject: [Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 139849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139849&action=edit Bug 31473: Fix fragile test about bad OpacHiddenItems conf There's been a behavior change in recent MariaDB that made some cases deal with truncated data in DOUBLE context instead of DECIMAL. Probably this: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-27380 This made the affected test fail consistently on those versions. This trick for checking OpacHiddenItems is correct (as introduced on bug 28125 doesn't really make use of the warning, just prints it in about.pl) so one option was to just check for a warning. I decided to keep the test, but add the optional DECIMAL|DOUBLE check on the qr. This way other eventual changes will make it fail and serve as a warning in case something more relevant changes. To test: 1. Apply this patch 2. Run: $ kshell k$ t/db_dependent/Koha/Items.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 21:54:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 19:54:09 +0000 Subject: [Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 21:54:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 19:54:30 +0000 Subject: [Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate, | |rel_21_11_candidate, | |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 21:56:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 19:56:34 +0000 Subject: [Koha-bugs] [Bug 31379] Change results per page text for default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31379 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 21:56:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 19:56:37 +0000 Subject: [Koha-bugs] [Bug 31379] Change results per page text for default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31379 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 21:56:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 19:56:40 +0000 Subject: [Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 21:56:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 19:56:42 +0000 Subject: [Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 --- Comment #2 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 22:20:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 20:20:55 +0000 Subject: [Koha-bugs] [Bug 31367] Display of sub-funds does not include totals of sub-sub-funds on acquisitions home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31367 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139829|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 139850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139850&action=edit Bug 31367: Add subtotals if budget has children On bug 29287 we added child funds if a fund had no parent id It turns out funds can have a parent, and still have children (sub-sub-funds) This patch simply checks for children, rather than checking for lack of parent. Totals are already calculated correctly in GetBudgetHierarchy To test: 1 - Add a fund "Fund" to a budget - assign 1000 dollars 2 - Add a sub-fund "SubFund" - assign 100 dollars 3 - Add a sub-sub-fund "SubSubFund" - assign 10 dollars 4 - Add to a basket $5 order from SubSubFund 5 - Add to a basket $50 order from SubFund 6 - Add to a basket $500 order form Fun 7 - View acqui home - note 'SubFund' does not include total from 'SubSubFund' 8 - Apply patch 9 - Confirm all sub-sub-funds totaled in sub-funds and that fund total correctly adds sub and sub-sub funds Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 22:21:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 20:21:23 +0000 Subject: [Koha-bugs] [Bug 31367] Display of sub-funds does not include totals of sub-sub-funds on acquisitions home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31367 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 22:29:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 20:29:26 +0000 Subject: [Koha-bugs] [Bug 31463] (Bug 31313 follow-up) Show item order status on opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31463 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |andrewfh at dubcolib.org --- Comment #2 from Andrew Fuerste-Henry --- Looks like this didn't apply correctly? When I try to view opac-detail for any bib I get: Could not compile /kohadevbox/koha/opac/opac-detail.pl: Version control conflict marker at /kohadevbox/koha/opac/opac-detail.pl line 723, near "<<<<<<<" Version control conflict marker at /kohadevbox/koha/opac/opac-detail.pl line 727, near "=======" Version control conflict marker at /kohadevbox/koha/opac/opac-detail.pl line 739, near ">>>>>>>" BEGIN not safe after errors--compilation aborted at /kohadevbox/koha/opac/opac-detail.pl line 1261. at /usr/share/perl5/CGI/Compile.pm line 144 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 22:34:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 20:34:25 +0000 Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting Version(s)|22.11.00, 22.05.04, |22.11.00, 22.05.04, released in|21.11.12 |21.05.18 --- Comment #55 from Victor Grousset/tuxayo --- Backported: Pushed to 21.05.x branch for 21.05.18 About ES 7 support, I asked for the next meeting if we can start advertising it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 26 23:30:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Aug 2022 21:30:35 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #306 from Shi Yao Wang --- Created attachment 139851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139851&action=edit Bug 17015: DatePicker/TimePicker to Flatpickr Changed all datepicker/timepicker to flatpickr + some small fixes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 14:11:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 12:11:13 +0000 Subject: [Koha-bugs] [Bug 29100] Add checkouts data loop to predue notices script ( advance_notices.pl ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer --- I fully support having an TT based option besides items.content for these notices. It's about time! But I am still a bit confused about this patch :( What information can I get from issue or issues? (which tables?) We'll definitely need to document. As it has the title in your example, I assume it's not just a line from the issues table, but more than that. https://wiki.koha-community.org/wiki/Notices_with_Template_Toolkit#Variables_available_in_each_notice Terminology: We really should be using checkout instead of issue. If we use checkout(s), will it be the same as the one available in other notices? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 15:05:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 13:05:26 +0000 Subject: [Koha-bugs] [Bug 15048] Genre/Form (655) searches fail on searches with $x 'General subdivision' subfield values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 --- Comment #24 from Katrin Fischer --- > bug 30836 needs to address this as a larger issue, but I don't think this > should be held up by that Agreed. So looking for another set of QA eyes or another sign-off here! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 15:06:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 13:06:25 +0000 Subject: [Koha-bugs] [Bug 31023] Cannot create new GENRE/FORM authorities when QueryRegexEscapeOptions set to 'Unescape escaped' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31023 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 15:06:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 13:06:29 +0000 Subject: [Koha-bugs] [Bug 31023] Cannot create new GENRE/FORM authorities when QueryRegexEscapeOptions set to 'Unescape escaped' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31023 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137662|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 139852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139852&action=edit Bug 31023: Unit tests Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 15:06:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 13:06:33 +0000 Subject: [Koha-bugs] [Bug 31023] Cannot create new GENRE/FORM authorities when QueryRegexEscapeOptions set to 'Unescape escaped' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31023 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137663|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 139853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139853&action=edit Bug 31023: Quote authtypecode in FindDuplicateAuthorities To test: 0 - Have Koha using Elasticsearch 1 - Set QueryRegexEscapeOptions to 'unescape escaped' 2 - Attempt to add a new 'GENRE/FORM' authority record 3 - On save you get a 500 error Unable to understand your search query, please rephrase and try again. at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Search.pm line 102 4 - Apply patch, restart all 5 - Attempt to add a new 'GENRE/FORM' authority record 6 - Success! Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 15:27:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 13:27:30 +0000 Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority records with common subject headings from different thesaurus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 15:27:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 13:27:41 +0000 Subject: [Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha does not currently |Support authority records |support authority records |with common subject |with common subject |headings from different |headings from different |thesaurus |thesaurus | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 15:46:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 13:46:51 +0000 Subject: [Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137900|0 |1 is obsolete| | --- Comment #38 from Katrin Fischer --- Created attachment 139854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139854&action=edit Bug 30280: Elasticsearch - Add 040f to Subject-heading-thesaurus-conventions (new) authority mapping index field (MARC21) This patch adds 040 $f to a new field Subject-heading-thesaurus-conventions authority index mapping. To test: 1) Apply patch 2) Reindex using rebuild_elasticsearch.pl -r If you don't have access to a terminal (in a sandbox for example) 2a) Go to Administration > Search engine configuration, click "Reset mappings" and confirm 2b) Then reindex Sponsored-by: Lund University Library, Sweden Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 15:46:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 13:46:57 +0000 Subject: [Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137901|0 |1 is obsolete| | --- Comment #39 from Katrin Fischer --- Created attachment 139855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139855&action=edit 30280: Add support for subject headings from different thesaurus when using Elasticsearch This patch allows subject headings from different thesaurus to co-exist in Koha. Test plan: 1. Enable Elasticsearch as the search engine (SearchEngine system preference = Elasticsearch) and reindex (koha-elasticsearch --rebuild -d -b -a kohadev). 2. Load sample authority records attached to the bug (in this case the authorities.mrc file was saved in the koha directory - adjust file location as appropriate): misc/migration_tools/bulkmarcimport.pl -v -a -file authorities.mrc -insert -c=MARC21 3. Load the sample bibliographic record attached to the bug: misc/migration_tools/bulkmarcimport.pl -v -b -file biblios.mrc -insert -c=MARC21 4. Search for ISBN 0704328623 and verify that the subject terms are not linked to any authority records (if you hover over the link terms, all links should look like ../cgi-bin/koha/catalogue/search.pl?q=su:"subjectterm" - none should have any ?q=an:XXX (where XXX = authority record ids) in the link). 5. Apply the patches. 6. Reset the Elasticsearch mappings (Administration > Catalog > Search engine configuration (Elasticsearch)). 7. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev 8. Link bibliographic records to authority records: misc/link_bibs_to_authorities.pl -v -l 9. Repeat the search in step 4 (or refresh the record details page) and verify that the first three Feminism headings[1] are linked to an authority record (should have ?q=an:XXX (where XXX = different authority record IDs for the various feminism authority records linked to a specific thesaurus)). 10. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev [1] Links for subject terms for step 9 in order are (the authority ids may be different depending on how ou are testing): Subject(s:) Feminism | feminism | Feminism | Feminism | Idéhistoria | Litteratur http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1709 http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1710 http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1708 http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Feminism" http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Idéhistoria" http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Litteratur" MARC info: 650 #7 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Feminism 0 Authority record control number or standard number https://id.kb.se/term/sao/Feminism 2 Source of heading or term sao 650 #7 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element feminism 2 Source of heading or term bnb 650 #0 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Feminism 650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Feminism 650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Idéhistoria 650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Litteratur Note: The fourth Feminism term has second indicator 4 which means "Source not specified". So this term is only a local term and does not belong to any specific thesaurus and thus not linked. To specify a source of a term, the second indicator must be set as 7. The source of heading is then specified in subfield 2. Sponsored-by: Lund University Library, Sweden Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 15:47:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 13:47:03 +0000 Subject: [Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137902|0 |1 is obsolete| | --- Comment #40 from Katrin Fischer --- Created attachment 139856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139856&action=edit Bug 30280: (follow-up) Removing tab character in Heading.pm Sponsored-by: Lund University Library, Sweden Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 15:48:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 13:48:59 +0000 Subject: [Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #41 from Katrin Fischer --- Thx for the great work on the test plan and sample data, this makes it much easier to test :) I am happy to add another sign-off, but for this to go through QA, we will also need unit tests to cover the changes in the .pm files. Please let us know if we can help with that! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 15:49:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 13:49:41 +0000 Subject: [Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 --- Comment #42 from Katrin Fischer --- You can switch back to signed off directly once the unit tests are done! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 16:13:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 14:13:35 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #54 from Katrin Fischer --- Sorry for being too late again :( Can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 17170: DB Updates Applying: Bug 17170: DO NOT PUSH - Schema Updates Applying: Bug 17170: Update schema for boolean Applying: Bug 17170: Add API route for SearchFilters Applying: Bug 17170: Add search filters to staff and opac interfaces Applying: Bug 17170: Handle search filters in query builders error: sha1 information is lacking or useless (C4/Search.pm). error: could not build fake ancestor Patch failed at 0001 Bug 17170: Handle search filters in query builders -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 16:16:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 14:16:35 +0000 Subject: [Koha-bugs] [Bug 31185] Link authorities automatically doesn't detect duplicate authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 16:35:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 14:35:14 +0000 Subject: [Koha-bugs] [Bug 31185] Link authorities automatically doesn't detect duplicate authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 --- Comment #5 from Katrin Fischer --- Created attachment 139857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139857&action=edit Bug 31185: Link authorities automatically doesn't detect duplicate authorities This patch fixes LinkBibHeadingsToAuthorities so it detects duplicate authorities using "Link authorities automatically" To test 1 Make sure the system preference AutoCreateAuthorities is turned to don't generate 2 Create a duplicate authority and check that search in Authorities module returns both. For example, two Personal Name (Smith, John) 3 Create a new record and fill the entry point with the same text of the authorities you just created. For example 100$a Smith, John 4 Click "Link authorities automatically" and you will obtain the following message "No matching authority found." 5 Apply patch, restart services 6 Click "Link authorities automatically" and you will obtain the following message "More than one local match found. Possibly a duplicate authority!" Signed-off-by: Rachael Laritz Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 16:35:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 14:35:43 +0000 Subject: [Koha-bugs] [Bug 31185] Link authorities automatically doesn't detect duplicate authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138518|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 16:36:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 14:36:47 +0000 Subject: [Koha-bugs] [Bug 31185] Link authorities automatically doesn't detect duplicate authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer --- I have added the bug description and test plan to the commit message according to our guidelines. Also happy to sign off on this, but we'll need a unit test covering this change for it to pass QA. Please let us know if we can help with that! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 16:51:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 14:51:33 +0000 Subject: [Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 16:51:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 14:51:38 +0000 Subject: [Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139526|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 139858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139858&action=edit Bug 31374: Database/Schema update Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 16:51:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 14:51:42 +0000 Subject: [Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139527|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 139859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139859&action=edit Bug 31374: Add non-public note to template Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 16:51:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 14:51:47 +0000 Subject: [Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139528|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer --- Created attachment 139860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139860&action=edit Bug 31374: Add privatenote column to table settings Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 16:51:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 14:51:52 +0000 Subject: [Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139529|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer --- Created attachment 139861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139861&action=edit Bug 31374: Update API spec Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 16:51:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 14:51:56 +0000 Subject: [Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139530|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer --- Created attachment 139862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139862&action=edit Bug 31374: Update Suggestion.pm To test: 1. Apply patch and restart services 2. Go to Acquistions -> Suggestions -> New Purchase suggestion 3. Notice the new 'Non-public notes:' textarea 4. Make sure you 'Set a patron' so we can later look at the suggestion from the OPAC 5. Make a new suggestion and make sure you add some Non-public notes 6. Back on the 'Suggestions management' page you should see a new column for 'Non-public note' 7. Go to table settings and make sure you can properly hide the column 8. Change the status and make sure it shows up on the table with all statuses (pending, accepted, rejected, etc ) 9. Check the API by going to (/api/v1/suggestions). Your suggestion should show up and 'privatenote' should include your non-public note. 10. Log in to the OPAC as the patron we set the suggestion to earlier. You should not see anything related to the non-public note displaying from the OPAC Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 16:52:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 14:52:00 +0000 Subject: [Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139627|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer --- Created attachment 139863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139863&action=edit Bug 31374: (follow-up) change private note to staff_note and reorder columns Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 16:52:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 14:52:06 +0000 Subject: [Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 --- Comment #22 from Katrin Fischer --- Created attachment 139864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139864&action=edit Bug 31374: (QA follow-up) Fix typo collumn in database update Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 16:55:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 14:55:58 +0000 Subject: [Koha-bugs] [Bug 27195] Set focus for cursor to city input box when creating new cities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|ellawipatene at gmail.com |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 18:08:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 16:08:27 +0000 Subject: [Koha-bugs] [Bug 30025] Split BiblioAddsAuthorities into 2 preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|BiblioAddsAuthorities is |Split BiblioAddsAuthorities |poorly named |into 2 preferences Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 18:27:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 16:27:29 +0000 Subject: [Koha-bugs] [Bug 31474] New: Patron category system preferences cannot be unselected completely Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31474 Bug ID: 31474 Summary: Patron category system preferences cannot be unselected completely Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, oleonard at myacpl.org Initially found by Rhonda on bug 31333, the problem seems to affect all system preferences using the patron category multi-select feature: To test: * Search for the OPACHoldsIfAvailableAtPickupExceptions system preference * Check some patron categories and save * Uncheck all patron categories and save - it says 'nothing to save' * Reload the page or search for OPACHoldsIfAvailableAtPickupExceptions again * The selected values remain and cannot all be removed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 18:28:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 16:28:02 +0000 Subject: [Koha-bugs] [Bug 31333] Add the ability to limit purchase suggestions by patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31474 QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | Summary|Allow the ability to make |Add the ability to limit |purchase suggestions to be |purchase suggestions by |set by borrower type |patron category --- Comment #19 from Katrin Fischer --- I am starting QA here, also filed bug 31474 for the general bug Rhonda found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 27 18:28:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 16:28:02 +0000 Subject: [Koha-bugs] [Bug 31474] Patron category system preferences cannot be unselected completely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31474 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31333 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:07:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:07:11 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #652 from Andrew Nugged --- I am now doing intermediate rebase, this one will go on tag v22.04.05 (commit hash 75372f012b4ecc321a0658f22ae4f3700502f018). Intermediate, because in the next step after below pre-rebase (pre- because not yet on current master), I plan to squash and re-factor TOO BIG to debug and do future rebasings code, and this will help us to rebase & sign off much cleaner code later. And also, it will include 7 more (!) bug fixes patches over the current state of the things above. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:17:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:17:19 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131458|0 |1 is obsolete| | Attachment #131459|0 |1 is obsolete| | Attachment #131460|0 |1 is obsolete| | Attachment #131461|0 |1 is obsolete| | Attachment #131462|0 |1 is obsolete| | Attachment #131463|0 |1 is obsolete| | Attachment #131464|0 |1 is obsolete| | Attachment #131465|0 |1 is obsolete| | Attachment #131466|0 |1 is obsolete| | Attachment #131467|0 |1 is obsolete| | Attachment #131468|0 |1 is obsolete| | Attachment #131469|0 |1 is obsolete| | Attachment #131470|0 |1 is obsolete| | Attachment #131471|0 |1 is obsolete| | Attachment #131472|0 |1 is obsolete| | Attachment #131473|0 |1 is obsolete| | Attachment #131474|0 |1 is obsolete| | Attachment #131475|0 |1 is obsolete| | Attachment #131476|0 |1 is obsolete| | Attachment #131477|0 |1 is obsolete| | Attachment #131478|0 |1 is obsolete| | Attachment #131479|0 |1 is obsolete| | Attachment #131480|0 |1 is obsolete| | Attachment #131481|0 |1 is obsolete| | Attachment #131482|0 |1 is obsolete| | --- Comment #653 from Andrew Nugged --- Created attachment 139865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139865&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Sponsored-by: The National Library of Finland Co-authored-by: Joonas Kylmälä Co-authored-by: Andrew Nugged Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:17:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:17:30 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #654 from Andrew Nugged --- Created attachment 139866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139866&action=edit Bug 20447: Add holding_id to REST API item definition Allows items to be properly returned, including the holding_id field. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:17:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:17:40 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #655 from Andrew Nugged --- Created attachment 139867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139867&action=edit Bug 20447: Add a batch rebuild script for holdings table This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:17:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:17:49 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #656 from Andrew Nugged --- Created attachment 139868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139868&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:17:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:17:59 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #657 from Andrew Nugged --- Created attachment 139869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139869&action=edit Bug 20447: (QA follow-up) Update for bug 26703 Reverse the title element content as per updated guidelines. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:18:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:18:10 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #658 from Andrew Nugged --- Created attachment 139870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139870&action=edit Bug 20447: Fixes for bug 17600 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:18:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:18:20 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #659 from Andrew Nugged --- Created attachment 139871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139871&action=edit Bug 20447: DBIX schema changes Rebased-by: Andrew Nugged Rebased-by: Joonas Kylmälä Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:18:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:18:30 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #660 from Andrew Nugged --- Created attachment 139872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139872&action=edit Bug 20447: (QA follow-up) SummaryHoldings preferences should be 1/0 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:18:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:18:40 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #661 from Andrew Nugged --- Created attachment 139873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139873&action=edit Bug 20447: (QA follow-up) Remove warning when frameworkcode is undef Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:18:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:18:50 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #662 from Andrew Nugged --- Created attachment 139874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139874&action=edit Bug 20447: (QA follow-up) Fix framework switching bug Form's parameter never used because $record was always defined, with new or with existing holding, but always. Fixed by adding incoming $holding_id presence check. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:19:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:19:00 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #663 from Andrew Nugged --- Created attachment 139875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139875&action=edit Bug 20447: (QA follow-up) Fix full-path call for xml_escape Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:19:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:19:10 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #664 from Andrew Nugged --- Created attachment 139876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139876&action=edit Bug 20447: (QA follow-up) Remove undef warnings and add UX note Use of uninitialized value in concatenation (.) or string at /usr/share/koha/lib/Koha/UI/Form/Builder/Item.pm line 255. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:19:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:19:20 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #665 from Andrew Nugged --- Created attachment 139877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139877&action=edit Bug 20447: (QA follow-up) include Koha::Holdings where needed (and remove uses where don't) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:19:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:19:32 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #666 from Andrew Nugged --- Created attachment 139878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139878&action=edit Bug 20447: (QA follow-up) undefined $mode warning remove When POST /intranet/cataloguing/addholding.pl happens from any /cgi-bin/koha/cataloguing/addholding.pl?op=edit&biblionumber=XXX&holding_id=YYY it has "$mode" undefined but comes to code "$mode ne 'popup'" hence the warning. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:19:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:19:41 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #667 from Andrew Nugged --- Created attachment 139879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139879&action=edit Bug 20447: (QA follow-up) typo, framework= should be frameworkcode= we don't have 'framework' param parsed in addholding.pl Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:19:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:19:56 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #668 from Andrew Nugged --- Created attachment 139880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139880&action=edit Bug 20447: (QA follow-up) bugfix: holding_id not sent down from params and was not taken into account Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:20:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:20:13 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #669 from Andrew Nugged --- Created attachment 139881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139881&action=edit Bug 20447: (QA follow-up) bugfix: itemcallnumber pref wasn't taken into account Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:20:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:20:24 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #670 from Andrew Nugged --- Created attachment 139882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139882&action=edit Bug 20447: (QA follow-up) UX improvement: merge point of values should be invisible. This is requested by customers, i.e. no pipe separate char between (librarians said they using it also for copy-pasting, and it confuses patrons because they read roman numbers with this | wrongly) Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:20:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:20:33 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #671 from Andrew Nugged --- Created attachment 139883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139883&action=edit Bug 20447: (QA follow-up) Warning suppression tab might be undefined (sidenote: probably tags->subfields->tabs structures should be defined more) Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:20:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:20:43 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #672 from Andrew Nugged --- Created attachment 139884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139884&action=edit Bug 20447: (QA follow-up) bugfix: undefined holding_id in code on store After saving to DB code didn't get back "last inserted ID" so wasn't able to allow for interface to go back to newly created holding ID Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:20:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:20:52 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #673 from Andrew Nugged --- Created attachment 139885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139885&action=edit Bug 20447: (QA follow-up) Warning removal: undef param 'sep' expected to be string in further processing Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:21:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:21:03 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #674 from Andrew Nugged --- Created attachment 139886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139886&action=edit Bug 20447: (QA follow-up) Bugfix: Do not force first item for acqorder from biblionumber, but use framework. Note / bigger bug: this happened only for first added item, all next other items in same basket were added without sending biblionumber as in original Koha code: so, this is very suspicious change without any person to explain why. This rolled-back code looks like unfinished feature or mistake. So I will leave this comment especially for future checks, if extension or this feature development will be needed. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:21:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:21:12 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #675 from Andrew Nugged --- Created attachment 139887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139887&action=edit Bug 20447: (follow-up) Get frameworks as list Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:21:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:21:23 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #676 from Andrew Nugged --- Created attachment 139888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139888&action=edit Bug 20447: (QA follow-up) Fix compatibility to 22.05 Fix to conform with 22.05 Koha::Object's 'search' wantarray removal ( https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:21:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:21:35 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #677 from Andrew Nugged --- Created attachment 139889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139889&action=edit Bug 20447: (QA follow-up) Fix atomic update to be more idempotent Fix atomic update not to add bad ACQ 952k row into marc_subfield_structure when no ACQ present at all -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:21:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:21:45 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #678 from Andrew Nugged --- Created attachment 139890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139890&action=edit Bug 20447: (QA follow-up) Whitespaces in .css file fixes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:21:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:21:55 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #679 from Andrew Nugged --- Created attachment 139891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139891&action=edit Bug 20447: (QA follow-up) .css file alignment as in addbiblio.css -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:22:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:22:05 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #680 from Andrew Nugged --- Created attachment 139892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139892&action=edit Bug 20447: (QA follow-up) detail.tt rebase cimpatibility fixes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:22:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:22:14 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #681 from Andrew Nugged --- Created attachment 139893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139893&action=edit Bug 20447: (QA follow-up) addholding.tt rebase compatibility fixes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 00:22:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 22:22:24 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #682 from Andrew Nugged --- Created attachment 139894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139894&action=edit Bug 20447: (QA follow-up) Show blocking full-screen error if biblio record removed elsewhere (biblio id not found). Rebased-by: Andrew Nugged -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 01:40:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Aug 2022 23:40:26 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #683 from Andrew Nugged --- Now I will combine changes into less scattered code and a smaller number of patches (also because I am now co-authoring this task for a while). Because so many patches patch other patches :) and evolutionary old master branch compatibility changes should be just in 1st commit, so this burden is mostly impossible to rebase over the current master (but we need to). This should help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 02:06:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 00:06:59 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139865|0 |1 is obsolete| | Attachment #139866|0 |1 is obsolete| | Attachment #139867|0 |1 is obsolete| | Attachment #139868|0 |1 is obsolete| | Attachment #139869|0 |1 is obsolete| | Attachment #139870|0 |1 is obsolete| | Attachment #139871|0 |1 is obsolete| | Attachment #139872|0 |1 is obsolete| | Attachment #139873|0 |1 is obsolete| | Attachment #139874|0 |1 is obsolete| | Attachment #139875|0 |1 is obsolete| | Attachment #139876|0 |1 is obsolete| | Attachment #139877|0 |1 is obsolete| | Attachment #139878|0 |1 is obsolete| | Attachment #139879|0 |1 is obsolete| | Attachment #139880|0 |1 is obsolete| | Attachment #139881|0 |1 is obsolete| | Attachment #139882|0 |1 is obsolete| | Attachment #139883|0 |1 is obsolete| | Attachment #139884|0 |1 is obsolete| | Attachment #139885|0 |1 is obsolete| | Attachment #139886|0 |1 is obsolete| | Attachment #139887|0 |1 is obsolete| | Attachment #139888|0 |1 is obsolete| | Attachment #139889|0 |1 is obsolete| | Attachment #139890|0 |1 is obsolete| | Attachment #139891|0 |1 is obsolete| | Attachment #139892|0 |1 is obsolete| | Attachment #139893|0 |1 is obsolete| | Attachment #139894|0 |1 is obsolete| | --- Comment #684 from Andrew Nugged --- Created attachment 139895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139895&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Smaller notes to task parts (batch rebuild script): --- Includes misc/batchRebuildHoldingsTables.pl: a batch rebuild script for holdings table which can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. --- End of smaller notes Sponsored-by: The National Library of Finland Co-authored-by: Joonas Kylmälä Co-authored-by: Andrew Nugged Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 02:07:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 00:07:10 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #685 from Andrew Nugged --- Created attachment 139896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139896&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 02:10:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 00:10:44 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #686 from Andrew Nugged --- All intermediate patches were obsoleted and merged into the final solution, as explained in comment #683 (this is for history to note how it was before): 139865 - Bug 20447: MARC Holdings support 139866 - Bug 20447: Add holding_id to REST API item definition 139867 - Bug 20447: Add a batch rebuild script for holdings table 139868 - Bug 20447: Add import/export support for holdings 139869 - Bug 20447: (QA follow-up) Update for bug 26703 139870 - Bug 20447: Fixes for bug 17600 139871 - Bug 20447: DBIX schema changes 139872 - Bug 20447: (QA follow-up) SummaryHoldings preferences should be 1/0 139873 - Bug 20447: (QA follow-up) Remove warning when frameworkcode is undef 139874 - Bug 20447: (QA follow-up) Fix framework switching bug 139875 - Bug 20447: (QA follow-up) Fix full-path call for xml_escape 139876 - Bug 20447: (QA follow-up) Remove undef warnings and add UX note 139877 - Bug 20447: (QA follow-up) include Koha::Holdings where needed (and remove uses where don't) 139878 - Bug 20447: (QA follow-up) undefined $mode warning remove 139879 - Bug 20447: (QA follow-up) typo, framework= should be frameworkcode= 139880 - Bug 20447: (QA follow-up) bugfix: holding_id not sent down from params 139881 - Bug 20447: (QA follow-up) bugfix: itemcallnumber pref wasn't taken into account 139882 - Bug 20447: (QA follow-up) UX improvement: merge point of values should be invisible. 139883 - Bug 20447: (QA follow-up) Warning suppression 139884 - Bug 20447: (QA follow-up) bugfix: undefined holding_id in code on store 139885 - Bug 20447: (QA follow-up) Warning removal: undef 139886 - Bug 20447: (QA follow-up) Bugfix: Do not force first item for acqorder from biblionumber, but use framework. 139887 - Bug 20447: (follow-up) Get frameworks as list 139888 - Bug 20447: (QA follow-up) Fix compatibility to 22.05 139889 - Bug 20447: (QA follow-up) Fix atomic update to be more idempotent 139890 - Bug 20447: (QA follow-up) Whitespaces in .css file fixes 139891 - Bug 20447: (QA follow-up) .css file alignment as in addbiblio.css 139892 - Bug 20447: (QA follow-up) detail.tt rebase cimpatibility fixes 139893 - Bug 20447: (QA follow-up) addholding.tt rebase compatibility fixes 139894 - Bug 20447: (QA follow-up) Show blocking full-screen error if biblio record removed elsewhere (biblio id not found). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 02:14:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 00:14:44 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #687 from Andrew Nugged --- The above is still based on tag v22.04.05 (commit hash 75372f012b4ecc321a0658f22ae4f3700502f018). Now I am doing rebase to the latest master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 03:01:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 01:01:53 +0000 Subject: [Koha-bugs] [Bug 31069] Did you mean? in the OPAC - links have tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 --- Comment #16 from Victor Grousset/tuxayo --- To spare testing time you can check the "Depends on:" field of the ticket. Here it links to bug 30733 which isn't in 21.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 03:12:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 01:12:23 +0000 Subject: [Koha-bugs] [Bug 21366] Add Plack reload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #33 from Victor Grousset/tuxayo --- (In reply to Marcel de Rooy from comment #26) > (In reply to Victor Grousset/tuxayo from comment #24) > > (In reply to Marcel de Rooy from comment #23) > > What do you mean? The patch doesn't use --preload-app. > I did not say that. Please read the comment. It is a quote. That confusion was after reading it several time before writing the message because I wasn't sure what you meant by this quote. And the best I could come up with is that we were using --preload-app So still confused but glad it got sorted out in this end ^o^ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 10:36:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 08:36:34 +0000 Subject: [Koha-bugs] [Bug 29882] Remove unrequired package definitions in list-deps script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 10:37:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 08:37:34 +0000 Subject: [Koha-bugs] [Bug 30262] opac/tracklinks.pl inconsistent with GetMarcUrls for whitespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30262 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 10:50:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 08:50:50 +0000 Subject: [Koha-bugs] [Bug 31475] New: Group system preferences for suggestions on OPAC tab under new heading Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31475 Bug ID: 31475 Summary: Group system preferences for suggestions on OPAC tab under new heading Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com There are quite a few of suggestion related preferences under different headings on the OPAC tab. It would be nice if they appeared as a group under one heading. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 11:16:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 09:16:25 +0000 Subject: [Koha-bugs] [Bug 31333] Add the ability to limit purchase suggestions by patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 --- Comment #20 from Katrin Fischer --- Created attachment 139897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139897&action=edit Bug 31333: (QA follow-up) Combine and rephrase system preferences Combines suggestion and suggestionPatronCategoryExceptions so they can be easily set together and rephrases slightly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 11:16:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 09:16:30 +0000 Subject: [Koha-bugs] [Bug 31333] Add the ability to limit purchase suggestions by patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 --- Comment #21 from Katrin Fischer --- Created attachment 139898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139898&action=edit Bug 31333: (QA follow-up) Add the new check to OPAC result list When no result is found and at the bottom of the result list the option to make a purchase suggestion is displayed. This also needs to use the new check. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 11:19:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 09:19:04 +0000 Subject: [Koha-bugs] [Bug 31333] Add the ability to limit purchase suggestions by patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #22 from Katrin Fischer --- Hi Alex, I provided 2 follow-ups, but then I got stuck: The new check doesn't take AnonSuggestions into account. When you click on the link in OPAC navigation now, you get a 404 if logged in and Can't call method "category" on an undefined value at /kohadevbox/koha/opac/opac-suggestions.pl line 97 if you are logged out. I believe if AnonSuggestions is set, we need to always allow suggestions independent of the other settings (should not matter if logged in or logged out). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 11:27:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 09:27:08 +0000 Subject: [Koha-bugs] [Bug 30016] Remove GetOpenIssue subroutine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30016 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 11:27:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 09:27:12 +0000 Subject: [Koha-bugs] [Bug 30016] Remove GetOpenIssue subroutine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30016 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139451|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 139899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139899&action=edit Bug 30016: Remove GetOpenIssue subroutine This patch adjusts the code that uses GetOpenIssue to use/find a Koha::Checkout object instead To test: 1 - Add a course to course reserves 2 - Create an item with barcode TESTKOC 3 - Add the item to a course 4 - Checkout the item 5 - View course details on stff and opac and confirm item shows as checked out and due date displays 6 - prove t/db_dependent/Circulation/issue.t t/db_dependent/Circulation.t t/db_dependent/CourseReserves.t 7 - Browse to Circulation->Upload offline circulation 8 - Upload a file to return the item: https://wiki.koha-community.org/wiki/Koha_offline_circulation_file_format 9 - Confirm item is returned Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 11:27:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 09:27:27 +0000 Subject: [Koha-bugs] [Bug 30016] Remove GetOpenIssue subroutine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30016 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|jonathan.druart+koha at gmail. |katrin.fischer at bsz-bw.de |com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 11:30:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 09:30:20 +0000 Subject: [Koha-bugs] [Bug 29882] Remove unrequired package definitions in list-deps script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 --- Comment #3 from Katrin Fischer --- Had a look, but cannot build a package to try and removing Mojolicious and Swagger appears a little counter-intuitive. Leaving to another QA person! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 11:37:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 09:37:05 +0000 Subject: [Koha-bugs] [Bug 31148] Add link to MARC import tools from Cataloging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31148 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #6 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 31162 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 11:37:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 09:37:05 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #38 from Katrin Fischer --- *** Bug 31148 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 11:47:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 09:47:17 +0000 Subject: [Koha-bugs] [Bug 31476] New: Add tool tips to the buttons on the circulation start page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31476 Bug ID: 31476 Summary: Add tool tips to the buttons on the circulation start page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Depends on: 31162 With the move from the tools page to the circulation start page we lost the short explanations that appeared under each tool. I think it would be nice to bring them back as tool tips like we do for some (sadly not all) buttons on the circulation start page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 [Bug 31162] Add a clear cataloguing module home page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 11:47:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 09:47:17 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31476 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31476 [Bug 31476] Add tool tips to the buttons on the circulation start page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 12:31:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 10:31:59 +0000 Subject: [Koha-bugs] [Bug 31477] New: Switch icon for inventory Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31477 Bug ID: 31477 Summary: Switch icon for inventory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Depends on: 31162 The 'chart' icon doesn's quite capture inventory for me. I think list-check or ballot-check would capture the tool's purpose better. You are working through your items and check what's there or missing... https://fontawesome.com/icons/clipboard-check?s=solid Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 [Bug 31162] Add a clear cataloguing module home page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 12:31:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 10:31:59 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31477 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31477 [Bug 31477] Switch icon for inventory -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 12:35:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 10:35:41 +0000 Subject: [Koha-bugs] [Bug 31478] New: Standardize upload/download icons Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31478 Bug ID: 31478 Summary: Standardize upload/download icons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Depends on: 31162 The new cataloging start page uses the upload/download icons for: * stage records for import (down) * export catalog (up) * upload local cover images (up) I feel like the icons for the first 2 should be switched. Export is a 'download' while staging is an 'upload'. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 [Bug 31162] Add a clear cataloguing module home page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 12:35:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 10:35:41 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31478 [Bug 31478] Standardize upload/download icons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 12:41:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 10:41:48 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139594|0 |1 is obsolete| | --- Comment #39 from Katrin Fischer --- Created attachment 139900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139900&action=edit Bug 31162: Add a cataloging module home page This patch adds a new cataloging-home template and controller and replaces most cases of links to addbooks. This servers to provide a new cataloging home page for the cataloging module and keeps it distinct from the current addbooks page it partially replaces as a stating point for cataloging. Signed-off-by: KIT Signed-off-by: Emmanuel Bétemps Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 12:41:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 10:41:53 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139595|0 |1 is obsolete| | --- Comment #40 from Katrin Fischer --- Created attachment 139901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139901&action=edit Bug 31162: Remove toolbar This patch removes the existing toolbar with 'New record' and 'New from Z39.50/SRU' and replaces the functionality with simple buttons on the page. We lose the ability to select the Framework or Z39.50/SRU server at this stage but one can still select these options from the resulting dialogues. Signed-off-by: Emmanuel Bétemps Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 12:42:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 10:42:00 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139596|0 |1 is obsolete| | --- Comment #41 from Katrin Fischer --- Created attachment 139902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139902&action=edit Bug 31162: (follow-up) 3 Column layout This patch converts to a 3 column layout as suggested by David. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 12:42:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 10:42:07 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139597|0 |1 is obsolete| | --- Comment #42 from Katrin Fischer --- Created attachment 139903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139903&action=edit Bug 31162: Remove duplicates from tools-home This patch removes cataloging tools from the tools-home page where they are now listed on the cataloging home page. This leaves just two options in the 'Cataloging' section of the tools home page, 'Rotating collections' and 'Upload local cover images'. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 12:42:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 10:42:14 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139650|0 |1 is obsolete| | --- Comment #43 from Katrin Fischer --- Created attachment 139904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139904&action=edit Bug 31162: More conditionals for sections This adds missing conditionals to the section headings in the new cataloging homepage. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 12:42:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 10:42:22 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139652|0 |1 is obsolete| | --- Comment #44 from Katrin Fischer --- Created attachment 139905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139905&action=edit Bug 31162: Move Rotating Collections and Upload Covers This patch moves the 'Rotating Collections' link from 'Cataloging' to 'Circulation' on the 'Tools' home page and moves the 'Upload local cover image' link to the 'Cataloging' home page. This removes the 'Cataloging' tools section entirely and as such the template is adapted to a two column layout to compensate. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 12:42:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 10:42:30 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #45 from Katrin Fischer --- Created attachment 139906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139906&action=edit Bug 31162: Fix help link on catalouging start page Now the link goes to the cataloguing chapter start page of the manual instead of the less specific manual start page. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 12:42:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 10:42:35 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #46 from Katrin Fischer --- Created attachment 139907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139907&action=edit Bug 31162: (QA follow-up) Change Automations to Automation This was suggested by David Nind in testing and I agree that it sounds a litle nicer. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 12:57:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 10:57:19 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA Keywords| |release-notes-needed --- Comment #47 from Katrin Fischer --- I like the concept of having a cataloguing start page to get our modules closer in terms of a standard UI. I think the problem I see here is that we need to put in more work to fix the discrepancies caused by moving tools to cataloguing (where they rightly belong). At the moment if you click on those links the breadcrumbs, URL and sidebar switch to tools. Also: the permissions are in tools. I feel like we should do more steps in moving these tools. * Sidebar will be fixed by bug 31417. * Breadcrumbs could be fixed after. * URLs - I am not completely sure about moving the files thb. but something to think about. I have created 2 follow-ups for you to check and a couple of linked bugs with suggestions. And I have one more thing I'd like to see "fixed" before we push this as a first step in restructuring: The extra click for catalogers. At the moment, using the split button you an get right into the framework you want. We remove this option. And I think that will make people grumpy. * Default takes a while to load compared with the smaller frameworks. * It's an extra click to switch. * Switching frameworks when using default values can be problmatic. A default once added to a field, doesn't update when switching frameworks (say s for serials in LDR was added). Being able to choose the framework right away is important I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 13:41:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 11:41:17 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 --- Comment #58 from Katrin Fischer --- Created attachment 139908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139908&action=edit Bug 10950: (QA follow-up) Fix typo in hidden check in OPAC patron form definded => defined -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 13:47:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 11:47:45 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #59 from Katrin Fischer --- Hi Lucas, 1) Changes to patron name display in general I am a bit hesitant about the changes to koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc. To me the pronouns don't feel like a part of the name and therefore I'd prefer to keep them separate from the common name include. My suggestion would be to show them separately but prominently in the brief patron information on the left side of patron account in the staff interface instead. At the moment we create a very long display string, even with 'short' name parts. But this is certainly something we could argue about and feel free to ask others for their opinions please! To give some examples: Headings in the patron account: Mr Floyd Middle (Other_name) Delgado(he/him) (23529000809559) Staff detail: Checked out to Mr Floyd Middle (Other_name) Delgado(he/him) (23529000809559) : due 09/02/2022 Accounting tab: Mr Floyd Middle (Other_name) Delgado(he/him) (23529000809559) has no outstanding fines. Notices tab, h1: Sent notices for Mr Floyd Middle (Other_name) Delgado(he/him) (23529000809559) .. if you insist, there are 2 things in the include: 1) Do we need pronouns for organisations? :) type = I is organisations often used for libraries or schools. I think pronouns would not be required here: [%- IF data.category_type == 'I' -%] - [%- data.surname | html %] [% IF data.othernames %] ([% data.othernames | html %])[% END -%] + [%- data.surname | html %] [% IF data.othernames %] ([% data.othernames | html %])[% END -%] [% IF data.pronouns %]([% data.pronouns | html %])[% END %] 2) Missing space We are also missing a space: Floyd Middle (Other_name) Delgado(he/him) 3) Details tab in staff And unrelated: currently pronouns show up under "contact information", but that doesn't feel quite right for placement and I don't like the quotes for some reason: Contact information “she/her” 6661 Library Rd. Springfield, MA 44224 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 13:48:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 11:48:40 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 --- Comment #60 from Katrin Fischer --- Please note the follow-up for the typo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 14:12:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 12:12:32 +0000 Subject: [Koha-bugs] [Bug 30262] opac/tracklinks.pl inconsistent with GetMarcUrls for whitespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30262 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 14:14:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 12:14:29 +0000 Subject: [Koha-bugs] [Bug 30262] opac/tracklinks.pl inconsistent with GetMarcUrls for whitespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30262 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 14:14:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 12:14:33 +0000 Subject: [Koha-bugs] [Bug 30262] opac/tracklinks.pl inconsistent with GetMarcUrls for whitespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30262 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139817|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 139909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139909&action=edit Bug 30262: Trim whitespace off tracklinks.pl URLs This patch trims whitespace off tracklinks.pl URLs so that the URL is in the same format as the URLs returned by C4::Biblio::GetMarcUrls, which is used by tracklinks.pl internally. Test plan: 0. Apply patch and koha-plack --restart kohadev 1. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=29 2. Add a 856 with $u of 'https://koha-community.org ' (note the space at the end0 3. Save record 4. Change 'TrackClicks' syspref to 'Track' 5. Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=29 6. Click on the online resource (eg http://localhost:8080/cgi-bin/koha/tracklinks.pl?uri=https%3A%2F%2Fkoha-community.org%20&biblionumber=29 ) 7. Note you are redirected to https://koha-community.org Signed-off-by: Magnus Enger Added the link with a space at the end. Verified that without the patch, clickin on "Click here to access online" gives a 404. After applying the patch the redirect works as expected. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 14:16:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 12:16:31 +0000 Subject: [Koha-bugs] [Bug 31254] Add additional fields for accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31254 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 14:38:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 12:38:12 +0000 Subject: [Koha-bugs] [Bug 31254] Add additional fields for accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31254 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 14:38:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 12:38:17 +0000 Subject: [Koha-bugs] [Bug 31254] Add additional fields for accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31254 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139604|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 139910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139910&action=edit Bug 31254: Add additional fields for accountlines Test plan: 1. Go to Admin » Additional fields There are two new categories: "Account lines (credit)" and "Account lines (debit)" 2. Create fields for both categories, with and without an authorized value category 3. Go to a user's accounting page 4. Create a manual invoice. Verify that all "debit" fields are there, put a value in them and save 5. Create a manual credit. Verify that all "credit" fields are there, put a value in them and save 6. Make a payment. Verify that all "credit" fields are there, put a value in them and save 7. Go to the transactions tab, click on the "Details" button for the lines you just created and verify that the additional fields are there Signed-off-by: Emmanuel Bétemps Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 14:40:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 12:40:06 +0000 Subject: [Koha-bugs] [Bug 31254] Add additional fields for accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31254 --- Comment #7 from Katrin Fischer --- This works as described and I think it will be a nice addition to the additional field system. I'd be interested in use cases for this - Julian, maybe you can share what triggered this development? Also, any plans to revive Bug 11844 - Additional fields for order lines? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 15:02:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 13:02:22 +0000 Subject: [Koha-bugs] [Bug 31364] Saving preferences with a dropdown with check boxes doesn't save in the case where all the checks are removed. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31364 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 15:03:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 13:03:18 +0000 Subject: [Koha-bugs] [Bug 31474] Patron category system preferences cannot be unselected completely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31474 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 31364 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 15:03:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 13:03:18 +0000 Subject: [Koha-bugs] [Bug 31364] Saving preferences with a dropdown with check boxes doesn't save in the case where all the checks are removed. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31364 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- *** Bug 31474 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 15:04:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 13:04:29 +0000 Subject: [Koha-bugs] [Bug 31333] Add the ability to limit purchase suggestions by patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community |https://bugs.koha-community |.org/bugzilla3/show_bug.cgi |.org/bugzilla3/show_bug.cgi |?id=31474 |?id=31364 --- Comment #23 from Katrin Fischer --- (In reply to Katrin Fischer from comment #19) > I am starting QA here, also filed bug 31474 for the general bug Rhonda found. Missed that Rhonda had already filed it: bug 31364 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 15:04:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 13:04:29 +0000 Subject: [Koha-bugs] [Bug 31364] Saving preferences with a dropdown with check boxes doesn't save in the case where all the checks are removed. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31364 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31333 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 15:04:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 13:04:29 +0000 Subject: [Koha-bugs] [Bug 31474] Patron category system preferences cannot be unselected completely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31474 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31333 | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 15:18:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 13:18:57 +0000 Subject: [Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139408|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer --- Created attachment 139911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139911&action=edit Bug 31051: Add OPACShowSavings system preference Signed-off-by: Marie-Luce Signed-off-by: Axelle Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 15:19:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 13:19:02 +0000 Subject: [Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139409|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer --- Created attachment 139912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139912&action=edit Bug 31051: Show patron savings on the OPAC This new feature shows a patron how much they have saved by using the library rather than purchasing items. Savings are calculated based on item replacement prices. The system preference allows you to choose where to display the savings - the user page, the summary box on the OPAC homepage, or the checkout history page. To test: 1. Update database and restart services 2. Confirm the new OPACShowSavings system preference is found in the OPAC tab of Administration -> global system preferences. There should be no options selected. 3. Find a patron with a checkout history, or check out a few items to a patron. 4. Test with different values of OPACShowSavings and confirm that savings are shown in the expected places. Sponsored-by: Horowhenua Libraries Trust Signed-off-by: Marie-Luce Signed-off-by: Axelle Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 15:19:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 13:19:08 +0000 Subject: [Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139410|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer --- Created attachment 139913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139913&action=edit Bug 31051: (follow-up) Simplify savings wording for OPAC Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 15:19:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 13:19:13 +0000 Subject: [Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 --- Comment #26 from Katrin Fischer --- Created attachment 139914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139914&action=edit Bug 31051: (QA follow-up) Simplify savings wording for reading history Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 15:24:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 13:24:25 +0000 Subject: [Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #27 from Katrin Fischer --- This works nicely and I quite like the idea! Only one real blocker and some notes/suggestions: 1) +=head3 get_savings (blocker) We need some unit tests here. 2) issues + old_issues (not blocker) A lot of libraries nowadays choose to anonymize the checkout history rather fast. So as we look at issues and old_issues here, the amount saved will go up and down quite a bit. I wonder if it could make sense to add a note to the pref so libraries have this in mind when activating the feature. 3) Wording (follow-up patch added) I have provided another follow-up for the reading history page following Owen's suggestion as this will also ease translation (combined constructs like x catalog are always a little hard) 4) id (not blocker) It could be nice to have a specific id on the message in the summary page and reading history in case libraries want to do some formatting or rephrasing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 15:27:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 13:27:48 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 15:28:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 13:28:54 +0000 Subject: [Koha-bugs] [Bug 23849] Update the list of sysprefs to share with Hea In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23849 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 16:23:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 14:23:18 +0000 Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 16:24:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 14:24:35 +0000 Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 16:24:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 14:24:39 +0000 Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139628|0 |1 is obsolete| | Attachment #139629|0 |1 is obsolete| | Attachment #139630|0 |1 is obsolete| | Attachment #139631|0 |1 is obsolete| | Attachment #139632|0 |1 is obsolete| | Attachment #139633|0 |1 is obsolete| | Attachment #139634|0 |1 is obsolete| | Attachment #139635|0 |1 is obsolete| | --- Comment #45 from Joonas Kylmälä --- Created attachment 139915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139915&action=edit Bug 30847: Cleanup calculation of holds and rank Currently we loop over all the holds on the record to get a count of the reserves not waiting and a rank for the upcoming hold We can simply count the number of nont waiting holds and add 1 Note: Before this patch the count of holds included the new hold we were going to place which meant rank and count were the same. I believe countaing existing holds and our upcoming rank is the correct behavior To test: 1 - Set OPACShowHoldQueueDetails system preference to 'Show holds and their priorty level' 2 - Place a few holds on a bib on the staff side 3 - Mark 1 waiting 4 - Attempt to place hold on the bib on the opac 5 - Note 'Your priority' and 'Number of holds' are the same number 6 - Place another hold, confirm both increase 7 - Set another hold waiting, confirm both decrease 8 - Apply patch 9 - Confirm 'Your priority' is now 1 greater than Number of holds 10 - Place a hold, set a hold waiting, confirm numbers adjust as appropriate Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 16:24:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 14:24:44 +0000 Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #46 from Joonas Kylmälä --- Created attachment 139916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139916&action=edit Bug 30847: Remove unused noreserve parameter This is defined but never used To test: 1 - git grep noreserve 2 - only one ocurrence 3 - Apply patch 4 - repeat, no ocurrence 5 - Note the plural has a few uses Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 16:24:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 14:24:48 +0000 Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #47 from Joonas Kylmälä --- Created attachment 139917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139917&action=edit Bug 30847: Remove unused OPACShowHoldQueueDetails Search for the variables, they aren't used! Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 16:24:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 14:24:52 +0000 Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #48 from Joonas Kylmälä --- Created attachment 139918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139918&action=edit Bug 30847: Don't fetch patron twice Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 16:24:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 14:24:57 +0000 Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #49 from Joonas Kylmälä --- Created attachment 139919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139919&action=edit Bug 30847: Avoid fetching biblio object Here the items biblionumber is either equal to the biblionumber passed in or it is not and should be - we can just assign directly from the item in all cases Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 16:25:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 14:25:02 +0000 Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #50 from Joonas Kylmälä --- Created attachment 139920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139920&action=edit Bug 30847: Don't declare undef variable for assignment New holds have found set to undef - we can do this directly Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 16:25:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 14:25:07 +0000 Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #51 from Joonas Kylmälä --- Created attachment 139921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139921&action=edit Bug 30847: Don't get biblio/item info when placing holds The only bit we get form the hash is the rank and title We can simply fetch the biblio once to calculate no need to fetch all the info as we don't display or use it Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 16:25:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 14:25:12 +0000 Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #52 from Joonas Kylmälä --- Created attachment 139922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139922&action=edit Bug 30847: Consolidate code to check if patron can place holds and exit if they cannot This will save us fetching more info if we are denying the holds Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 16:25:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 14:25:17 +0000 Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #53 from Joonas Kylmälä --- Created attachment 139923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139923&action=edit Bug 30847: Remove unused variable Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 16:26:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 14:26:06 +0000 Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #54 from Joonas Kylmälä --- Passing QA. Added one more patch, the last one, to remove an unused variable in the opac-reserve.pl file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 16:47:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 14:47:35 +0000 Subject: [Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 16:49:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 14:49:38 +0000 Subject: [Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 16:49:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 14:49:42 +0000 Subject: [Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139682|0 |1 is obsolete| | Attachment #139683|0 |1 is obsolete| | --- Comment #9 from Joonas Kylmälä --- Created attachment 139924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139924&action=edit Bug 30483: Make issues.borrowernumber and itemnumber NOT NULL Note: This change does NOT apply to old_issues, where constraints may result in nullifying these columns. Test plan: Run dbrev. Try checkout, checkin. Signed-off-by: Martin Renvoize Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 16:49:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 14:49:46 +0000 Subject: [Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 --- Comment #10 from Joonas Kylmälä --- Created attachment 139925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139925&action=edit Bug 30483: (DBIx schema) Changes to Issue.pm Compare with results of update_dbix_class_files.pl. Signed-off-by: Martin Renvoize Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 17:05:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 15:05:08 +0000 Subject: [Koha-bugs] [Bug 31436] AllowRenewalIfOtherItemsAvailable should not take suspended holds into account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31436 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi Resolution|--- |FIXED Status|Needs Signoff |RESOLVED --- Comment #2 from Joonas Kylmälä --- The bug 31112, dependency for this bug already fixed this issue. Closing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 17:18:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 15:18:02 +0000 Subject: [Koha-bugs] [Bug 31470] Incorrect selector for relationship dropdown used in members.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 --- Comment #2 from Katrin Fischer --- Hi Emmi, could you please add a test plan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 17:19:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 15:19:28 +0000 Subject: [Koha-bugs] [Bug 30641] Authority detail page shows wrong number of records using the authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30641 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Katrin Fischer --- (In reply to Magnus Enger from comment #12) > (In reply to Katrin Fischer from comment #10) > > ... and we'll probably need a unit test > > Should this be "Failed QA" then? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 17:30:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 15:30:40 +0000 Subject: [Koha-bugs] [Bug 31315] Remove GetItemsInfo from moredetail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31315 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 17:30:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 15:30:45 +0000 Subject: [Koha-bugs] [Bug 31315] Remove GetItemsInfo from moredetail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31315 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138897|0 |1 is obsolete| | --- Comment #4 from Joonas Kylmälä --- Created attachment 139926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139926&action=edit Bug 31315: Remove GetHostItemsInfo and GetItemsInfo from moredetail Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search. Here we are going to deal with catalogue/moredetail Test plan: List items on the modified view and confirm that all the info is displayed correctly Signed-off-by: Owen Leonard Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 17:30:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 15:30:50 +0000 Subject: [Koha-bugs] [Bug 31315] Remove GetItemsInfo from moredetail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31315 --- Comment #5 from Joonas Kylmälä --- Created attachment 139927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139927&action=edit Bug 31315: (QA follow-up) Show itemtype description instead of database code This restores the previous definition for itype that displayed the description instead of itemtype. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 17:31:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 15:31:01 +0000 Subject: [Koha-bugs] [Bug 31465] 21.11 manual says it is 20.05 manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31465 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Katrin Fischer --- The versions of the different branches look correct in git. I wonder if there is something wrong with building the manuals? https://gitlab.com/koha-community/koha-manual/-/blob/master/source/index.rst https://gitlab.com/koha-community/koha-manual/-/blob/manual21.11.x/source/conf.py -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 17:30:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 15:30:14 +0000 Subject: [Koha-bugs] [Bug 31315] Remove GetItemsInfo from moredetail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31315 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|kyle at bywatersolutions.com |joonas.kylmala at iki.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 17:47:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 15:47:14 +0000 Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com --- Comment #133 from Andrew Nugged --- Some remnants in the master branch (I am trying to combine (oh that's the challenge!) these changes with Bug 20447, that's why giving some parallel feedback): I see this left: C4/Biblio.pm: 56: EmbedItemsInMarcBiblio I think that line is the only one that we have across all codebase, so just the remnants. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 18:21:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 16:21:28 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 18:24:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 16:24:45 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 18:24:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 16:24:49 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138832|0 |1 is obsolete| | --- Comment #198 from Joonas Kylmälä --- Created attachment 139928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139928&action=edit Bug 27272: Remove GetItemsInfo, GetItemsLocationInfo and GetHostItemsInfo With the different bug reports we removed the calls for those 3 subroutines. We can remove them now. Test plan: git grep their names and you should not find any occurrences in the code base Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 18:25:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 16:25:28 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #199 from Joonas Kylmälä --- Trivial removal of unused subroutines, fast forwarding directly to PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 19:01:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 17:01:09 +0000 Subject: [Koha-bugs] [Bug 31356] Itiva outbound script doesn't respect calendar when calculating expiration date for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31356 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi |y.org | CC| |joonas.kylmala at iki.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 19:01:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 17:01:56 +0000 Subject: [Koha-bugs] [Bug 31356] Itiva outbound script doesn't respect calendar when calculating expiration date for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31356 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 19:02:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 17:02:00 +0000 Subject: [Koha-bugs] [Bug 31356] Itiva outbound script doesn't respect calendar when calculating expiration date for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31356 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139072|0 |1 is obsolete| | --- Comment #4 from Joonas Kylmälä --- Created attachment 139929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139929&action=edit Bug 31356: Use hold expiration date instead of adding days to the waiting date The Talking Tech outbound script currently just adds the ReservesMaxPickUpDelay to the waiting date to calculate the "expiration date", but it should use the actual hold expiration date which may differ from this naive calculation based on various system preference values. Test Plan: 1) Create a holiday for tomorrow 2) Set ReservesMaxPickUpDelay to 5 3) Set "Days mode" to "Same week day" 4) Enable ExcludeHolidaysFromMaxPickUpDelay 5) Enable TalkingTechItivaPhoneNotification 6) Create a hold and fill the hold so it is waiting 7) Enable "Hold filled" phone notices for that patron 8) Create a 'phone' version of the HOLD notice 9) Run ./misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl --type RESERVE -w 0 10) Note the output has the expiration date ( 15th colume ) 5 days from now which is *not* the hold's expiration date 11) Apply this patch 12) Repeat the command from step 9 13) Note the expiration date column now matches the holds actual expiration date! Signed-off-by: Kyle Hall Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 19:22:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 17:22:19 +0000 Subject: [Koha-bugs] [Bug 29658] Crash on cancelling cancelled order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 19:22:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 17:22:23 +0000 Subject: [Koha-bugs] [Bug 29658] Crash on cancelling cancelled order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139126|0 |1 is obsolete| | --- Comment #12 from Joonas Kylmälä --- Created attachment 139930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139930&action=edit Bug 29658: Fix crash on cancelling cancelled order Found this crash in our 20.11 logs: Cannot insert order: Mandatory parameter biblionumber is missing at /usr/share/koha/acqui/cancelorder.pl line 60. at /usr/share/perl/5.28/Carp.pm line 289 Carp::croak('Cannot insert order: Mandatory parameter biblionumber is missing') called at /usr/share/koha/Koha/Acquisition/Order.pm line 79 Koha::Acquisition::Order::store('Koha::Acquisition::Order=HASH(0x55f3760e2860)') called at /usr/share/koha/Koha/Acquisition/Order.pm line 189 Koha::Acquisition::Order::cancel('Koha::Acquisition::Order=HASH(0x55f3760e2860)', 'HASH(0x55f375a17ec0)') called at /usr/share/koha/acqui/cancelorder.pl line 60 Not sure how to reproduce this one as it happened. But might be related to repeated clicking, backspacing etc. Test plan: Create a new basket and order. Open this same basket in two browser tabs. Cancel the order line (delete catalog record) in tab 1. Go to second tab, try again. Without this patch, it will crash. With this patch, an error message. Signed-off-by: Marcel de Rooy Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 19:25:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 17:25:36 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |joonas.kylmala at iki.fi --- Comment #120 from Joonas Kylmälä --- Lari, will you continue working on this? Currently the patches don't apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 19:33:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 17:33:35 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi Status|Needs Signoff |Patch doesn't apply --- Comment #85 from Joonas Kylmälä --- (In reply to Martin Renvoize from comment #84) > Ready for testing.. Martin, I assume the patches attached to this bug report from you are the latest. They don't apply anymore. Could you do a rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 19:50:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 17:50:59 +0000 Subject: [Koha-bugs] [Bug 29409] Update for bug 25333 can fail due to bad data or constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29409 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 19:51:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 17:51:03 +0000 Subject: [Koha-bugs] [Bug 29409] Update for bug 25333 can fail due to bad data or constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29409 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127275|0 |1 is obsolete| | Attachment #127276|0 |1 is obsolete| | --- Comment #3 from Joonas Kylmälä --- Created attachment 139931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139931&action=edit Bug 29409: Check for existence of constraint before deletion https://bugs.koha-community.org/show_bug.cgi?id=29049 Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 19:51:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 17:51:06 +0000 Subject: [Koha-bugs] [Bug 29409] Update for bug 25333 can fail due to bad data or constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29409 --- Comment #4 from Joonas Kylmälä --- Created attachment 139932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139932&action=edit Bug 29409: Check for data that violates a constraint to avoid update problems https://bugs.koha-community.org/show_bug.cgi?id=29049 Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 20:12:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 18:12:33 +0000 Subject: [Koha-bugs] [Bug 31177] Misplaced import in C4::ILSDI::Services In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31177 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 20:13:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 18:13:58 +0000 Subject: [Koha-bugs] [Bug 31177] Misplaced import in C4::ILSDI::Services In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31177 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 20:14:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 18:14:02 +0000 Subject: [Koha-bugs] [Bug 31177] Misplaced import in C4::ILSDI::Services In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31177 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137825|0 |1 is obsolete| | --- Comment #2 from Joonas Kylmälä --- Created attachment 139933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139933&action=edit Bug 31177: Fix misplaced import in C4::ILSDI::Services Signed-off-by: Tomas Cohen Arazi Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 20:14:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 18:14:31 +0000 Subject: [Koha-bugs] [Bug 31177] Misplaced import in C4::ILSDI::Services In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31177 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Joonas Kylmälä --- Trivial fix, straight to PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 28 23:36:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 21:36:26 +0000 Subject: [Koha-bugs] [Bug 31333] Add the ability to limit purchase suggestions by patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #24 from Alex Buckley --- (In reply to Katrin Fischer from comment #22) > Hi Alex, > > I provided 2 follow-ups, but then I got stuck: The new check doesn't take > AnonSuggestions into account. When you click on the link in OPAC navigation > now, you get a 404 if logged in and Can't call method "category" on an > undefined value at /kohadevbox/koha/opac/opac-suggestions.pl line 97 if you > are logged out. > > I believe if AnonSuggestions is set, we need to always allow suggestions > independent of the other settings (should not matter if logged in or logged > out). Hi Katrin, Thanks for QA, I will work on a fix for this. Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 00:21:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 22:21:43 +0000 Subject: [Koha-bugs] [Bug 31479] New: Provide an option to skip the test for atomic updates Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Bug ID: 31479 Summary: Provide an option to skip the test for atomic updates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Since t/00-check-atomic-updates.t was fixed in Bug 31108, if there are any atomic updates left when building a package manually, the test and build will fail. Koha providers like Catalyst may keep atomic updates when building packages for customisations. Sometimes these are just temporary, while we wait for custom work to get upstreamed (in which case we can remove the atomic updates), but sometimes these are necessary customisations which must be kept for the library. So an option to skip this test when building a custom package would be useful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 00:21:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 22:21:57 +0000 Subject: [Koha-bugs] [Bug 31479] Provide an option to skip the test for atomic updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31108 Assignee|chris at bigballofwax.co.nz |aleisha at catalyst.net.nz Change sponsored?|--- |Sponsored Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 00:21:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 22:21:57 +0000 Subject: [Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31479 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 [Bug 31479] Provide an option to skip the test for atomic updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 01:04:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 23:04:50 +0000 Subject: [Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 01:12:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 23:12:06 +0000 Subject: [Koha-bugs] [Bug 31479] Provide an option to skip the test for atomic updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 01:12:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 23:12:10 +0000 Subject: [Koha-bugs] [Bug 31479] Provide an option to skip the test for atomic updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 --- Comment #1 from Aleisha Amohia --- Created attachment 139934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139934&action=edit Bug 31479: Option to skip t/00-check-atomic-updates.t when building custom packages This enhancement adds an option to skip the check for leftover atomic updates when building custom packages. This is particularly useful for Koha providers or anyone else building Koha packages manually. In practice, this could be run like: sudo CUSTOM_PACKAGE=1 ./debian/build-git-snapshot -r ~/debian -v 21.11.01git -d This test plan should all take place within the shell. 0. sudo koha-shell kohadev 1. Run prove t/00-check-atomic-updates.t and confirm the test passes 2. Add a fake atomic update to installer/data/mysql/atomicupdate/ . You can use the example from https://wiki.koha-community.org/wiki/Database_updates#How_to_write_an_atomicupdate_file 3. Run prove t/00-check-atomic-updates.t and notice the test fails 4. Set the CUSTOM_PACKAGE environment variable so we can test this. You can either set on the commandline (using export) or in /etc/environment (remember to run source /etc/environment so the changes are accessed) 5. Run prove t/00-check-atomic-updates.t and the test should now pass. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 01:12:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 23:12:42 +0000 Subject: [Koha-bugs] [Bug 31479] Provide an option to skip the test for atomic updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds an release notes| |option to skip the check | |for leftover atomic updates | |when building custom | |packages. This is | |particularly useful for | |Koha providers or anyone | |else building Koha packages | |manually. | | | |In practice, | |this could be run like: | |sudo CUSTOM_PACKAGE=1 | |./debian/build-git-snapshot | |-r ~/debian -v 21.11.01git | |-d -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 01:12:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Aug 2022 23:12:58 +0000 Subject: [Koha-bugs] [Bug 31479] Provide an option to skip the test for atomic updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds an |This enhancement adds an release notes|option to skip the check |option to skip the check |for leftover atomic updates |for leftover atomic updates |when building custom |when building custom |packages. This is |packages. This is |particularly useful for |particularly useful for |Koha providers or anyone |Koha providers or anyone |else building Koha packages |else building Koha packages |manually. |manually. | | |In practice, |In practice, |this could be run like: |this could be run like: |sudo CUSTOM_PACKAGE=1 |sudo CUSTOM_PACKAGE=1 |./debian/build-git-snapshot |./debian/build-git-snapshot |-r ~/debian -v 21.11.01git |-r ~/debian -v 21.11.01git |-d |-d -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 02:25:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 00:25:50 +0000 Subject: [Koha-bugs] [Bug 31480] New: OAI-PMH Identify response missing "Repository identifier" and "Sample identifier" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31480 Bug ID: 31480 Summary: OAI-PMH Identify response missing "Repository identifier" and "Sample identifier" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org If you go to /cgi-bin/koha/oai.pl?verb=Identify, you'll see that "Repository identifier" and "Sample identifier" are blank. The ./koha-tmpl/opac-tmpl/xslt/OAI.xslt makes it seem that they should be at oai:description/oai_id:oai-identifier/oai_id:repositoryIdentifier/text() and oai:description/oai_id:oai-identifier/oai_id:sampleIdentifier/text() but there is no oai:description in the XML response. I imagine that someone must've written that XSLT with purpose once upon a time but that data has been lost to the ages... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 03:39:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 01:39:12 +0000 Subject: [Koha-bugs] [Bug 26692] Add barcode image generator service for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #33 from David Cook --- (In reply to Kyle M Hall from comment #0) > Some libraries would like to add a scannable barcode to the patron self > service area of the opac for patrons who do not have their library cards > with them. While developing the plugin, I've realized that many libraries might be using laser barcode scanners which are unlikely to work when scanning barcodes on a mobile phone screen... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 03:43:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 01:43:51 +0000 Subject: [Koha-bugs] [Bug 29882] Remove unrequired package definitions in list-deps script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #4 from David Cook --- I take it that this is due to these deps being picked up out of the cpanfile? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 03:58:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 01:58:59 +0000 Subject: [Koha-bugs] [Bug 31333] Add the ability to limit purchase suggestions by patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 --- Comment #25 from Alex Buckley --- Created attachment 139935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139935&action=edit Bug 31333: (follow-up) Handle anonymous patrons making suggestions Test plan: 1. Enable AnonSuggestions syspref and set AnonymousPatron = 1 2. Visit the OPAC without logging in 3. Confirm you can successfully create a suggestion from: - Item detail page - Search result page - Masthead under the 'Library catalogue' search box 4. Disable the AnonSuggestions syspref 5. Confirm you cannot see links to make purchase suggestions on the following pages: - Item detail page - Search result page - Masthead under the 'Library catalogue' search box 6. Confirm if you try visiting /cgi-bin/koha/opac-suggestions.pl page you are re-directed to a login page Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 05:16:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 03:16:25 +0000 Subject: [Koha-bugs] [Bug 31333] Add the ability to limit purchase suggestions by patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139935|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 05:16:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 03:16:50 +0000 Subject: [Koha-bugs] [Bug 31333] Add the ability to limit purchase suggestions by patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 --- Comment #26 from Alex Buckley --- Created attachment 139936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139936&action=edit Bug 31333: (follow-up) Handle anonymous patrons making suggestions Test plan: 1. Enable suggestion & AnonSuggestions sysprefs and set AnonymousPatron = 1 2. Visit the OPAC without logging in 3. Confirm you can successfully create a suggestion from: - Item detail page - Search result page - Masthead under the 'Library catalogue' search box 4. Disable the AnonSuggestions syspref 5. Confirm you cannot see links to make purchase suggestions on the following pages: - Item detail page - Search result page - Masthead under the 'Library catalogue' search box 6. Confirm if you try visiting /cgi-bin/koha/opac-suggestions.pl page you are re-directed to a login page 7. Select the category of your user in the suggestionPatronCategoryExceptions syspref 8. Log into the OPAC 9. Confirm you cannot see links to make purchase suggestions on the following pages: - Item detail page - Search result page - Masthead under the 'Library catalogue' search box - opac-user.pl ('Your summary') page 10. Confirm if you try visiting /cgi-bin/koha/opac-suggestions.pl page you are re-directed to a 404 error page 11. Enable AnonSuggestions syspref 12. Confirm you can successfully create a suggestion from: - Item detail page - Search result page - Masthead under the 'Library catalogue' search box - opac-user.pl ('Your summary') page 13. Disable AnonSuggestions syspref and un-check your category from suggestionPatronCategoryExeptions syspref 14. Confirm you can create a suggestion from: - Item detail page - Search result page - Masthead under the 'Library catalogue' search box - opac-user.pl ('Your summary') page Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 05:32:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 03:32:23 +0000 Subject: [Koha-bugs] [Bug 31333] Add the ability to limit purchase suggestions by patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #27 from Alex Buckley --- (In reply to Katrin Fischer from comment #22) > Hi Alex, > > I provided 2 follow-ups, but then I got stuck: The new check doesn't take > AnonSuggestions into account. When you click on the link in OPAC navigation > now, you get a 404 if logged in and Can't call method "category" on an > undefined value at /kohadevbox/koha/opac/opac-suggestions.pl line 97 if you > are logged out. > > I believe if AnonSuggestions is set, we need to always allow suggestions > independent of the other settings (should not matter if logged in or logged > out). Hi Katrin, I have attached a follow-up patch that should, hopefully, resolve the problems you raised. Now regardless of any other setting if the AnonSuggestions & suggestion syspref is enabled then a patron can create an OPAC suggestion. I tested on master and found if you have AnonSuggestions enabled, but suggestion disabled, then opac-suggestions.pl re-directs to the 404 page. You'll notice I also tweaked C4::Auth->get_template_and_user() so it now checks whether AnonSuggestions is enabled before passing the suggestion variable to the template. As I've added that I have tweaked your check on opac-results.tt, I hope that is alright. Ready for testing again. Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 06:32:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 04:32:03 +0000 Subject: [Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 06:32:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 04:32:07 +0000 Subject: [Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 --- Comment #28 from Aleisha Amohia --- Created attachment 139937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139937&action=edit Bug 31051: (follow-up) Tests for get_savings and more - Added tests in t/db_dependent/Koha/Patron.t - Added wording to OPACShowSavings syspref about anonymised checkout history - Added IDs to the savings messages on the OPAC Sponsored-by: Horowhenua Libraries Trust -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 07:58:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 05:58:56 +0000 Subject: [Koha-bugs] [Bug 29658] Crash on cancelling cancelled order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658 --- Comment #13 from Marcel de Rooy --- (In reply to Joonas Kylmälä from comment #12) > Signed-off-by: Joonas Kylmälä Thx Joonas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 08:07:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 06:07:33 +0000 Subject: [Koha-bugs] [Bug 31481] New: Pass message_id to SMS drivers Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31481 Bug ID: 31481 Summary: Pass message_id to SMS drivers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: johanna.raisa at koha-suomi.fi QA Contact: testopia at bugs.koha-community.org Most of the SMS Gateways support REST API and it is common that the operator sends their report back to the service. Now it is impossible to catch reports if sms was succesfully sent or it failed since we can't pass the message_id to our report url when sending the message to the gateway. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 08:39:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 06:39:24 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Christian Stelzenmüller changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #29 from Christian Stelzenmüller --- On step 10 in the test plan. "Template process failed: file error - biblio_a_href: not found at /kohadevbox/koha/C4/Templates.pm line 127 in C4::Templates::output at /kohadevbox/koha/C4/Templates.pm line 127 124: 125: my $data; 126: binmode( STDOUT, ":encoding(UTF-8)" ); 127: $template->process( $self->filename, $vars, \$data ) 128: || die "Template process failed: ", $template->error(); 129: return $data; 130: } Show function arguments in (eval) at /kohadevbox/koha/basket/sendbasket.pl line 105 102: ); 103: 104: # Getting template result 105: my $template_res = $template2->output(); 106: my $body; 107: 108: my $subject; ..." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 08:43:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 06:43:41 +0000 Subject: [Koha-bugs] [Bug 30931] Handling of items.dateaccessioned in the item editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 --- Comment #18 from Alex Buckley --- Hi Heather, Benjamin, and Martiin, Thanks very much for your replies Heather and Benjamin! Thank you for testing and offering to sign off Benjamin. Martin: Do you have a preference on which patch is upstreamed? I am happy with either patch :) Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 08:55:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 06:55:41 +0000 Subject: [Koha-bugs] [Bug 23930] No permissions SSO login to staff client should redirect to a custom URL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23930 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|ASSIGNED |RESOLVED --- Comment #5 from Alex Buckley --- Hi David(In reply to David Cook from comment #4) > I'm not sure that I understand this one. > > What SSO are you targeting and what scenario? > > From the OPAC side, I have a OpenID Connect client for Koha (which one of > these days I'll find time to upstream). If I already have a session with the > Identity Provider and I click on a Koha link, it'll prompt me to log in, > I'll choose my Identity Provider from the login options for Koha, it'll > bounce me to the IdP, then bounce me back. If I don't have > authorization/permission, I'd expect to see my original Koha page saying > that I'm not authorized. > > I could see it being an issue if it re-directed me to a login page though, > as I'd already be authenticated just not authorized... > > ...which is where I'm getting lost with your description. > > You're saying the patron has been authenticated but they're not authorized > to be in the staff client, so they're being re-directed to the Koha login > page instead of whatever page they were trying to access? > > I take it that you want to redirect the patron back to the page they were on > before they navigated to Koha? > > What kind of SSO is this? I'm guessing the redirection to the IdP must be > automatic and not require the user to click on something on the Koha staff > client login side? Hi David, We were using Mod_mellon and SAML, and yes once the user had been authenticated they were automatically re-directed to the Koha login page instead of whatever page they were trying to access. However, we've since shifted to using Shibboleth for implementing SSO so I think we can now close this bug report, as it is no longer redundant. Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 09:03:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 07:03:59 +0000 Subject: [Koha-bugs] [Bug 31456] Optionally hide lightbox_descriptions from intranet lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31456 --- Comment #6 from Alex Buckley --- (In reply to Katrin Fischer from comment #5) > I've quickly looked around a bit: > > Open Library Covers API (optional?) > https://openlibrary.org/dev/docs/api/covers > > 3) A courtesy link back to Open Library is appreciated, whether it be on > each individual book's page (where you can link back to the book's page on > Open Library, for example, using the same ISBN > https://openlibrary.org/isbn/9780385533225), or on your About page or in > your footer. > > > Amazon Cover API > https://developers.google.com/books/branding ? > > Google must be given attribution, using the appropriate text or brand > elements, whenever you display Google results, previews, or other content > made available through the API. > You must maintain prominent links to Google Books pages and features. Hi Katrin, Thank you for noting this. I think you're right it could be difficult to upstream this change - because of the mandatory attribution requirements of Google. Although, this change is really only giving libraries the option to revert to pre Koha 21.11 behaviour - not displaying text attribution of where an image is from. If libraries want they can hide the text using JavaScript. We think the optimal fix might be to add an ID to the parent div, if one doesn't already exist (i.e. https://github.com/Koha-Community/Koha/blob/master/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt#L66 and https://github.com/Koha-Community/Koha/blob/master/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt#L105 ) to make it easier to hide the hint with JavaScript if necessary. What do you think of that as a solution? Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 09:39:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 07:39:28 +0000 Subject: [Koha-bugs] [Bug 31481] Pass message_id to SMS drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31481 Johanna Räisä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |johanna.raisa at koha-suomi.fi |ity.org | --- Comment #1 from Johanna Räisä --- Created attachment 139938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139938&action=edit Bug 31481: pass message_id to SMS drivers This patch adds message_id to _send_message_by_sms and sms_send so the driver could be build to catch SMS gateways delivery report. Test plan: 1) Apply the patch 2) prove t/SMS.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 09:39:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 07:39:53 +0000 Subject: [Koha-bugs] [Bug 31481] Pass message_id to SMS drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31481 Johanna Räisä changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 10:04:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 08:04:32 +0000 Subject: [Koha-bugs] [Bug 31470] Incorrect selector for relationship dropdown used in members.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139826|0 |1 is obsolete| | --- Comment #3 from Emmi Takkinen --- Created attachment 139939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139939&action=edit Bug 31470: Use class "relationship" instead of id "relationship" in members.js In members.js line 112 variable guarantor_relationship is selected with id "relationship". Correct selector should however be class "relationship" since id "relationship" is used in auth-finder-search.inc, not in memberentry.pl. One way to see what kind of effect incorrect selector has (and how I originally stumbled into this), is to add into "IntranetUserJS" a line which changes non-patron guarantors relationship default selected value as other than empty. We use script to change "relationship" instead of "new_guarantor_relationship" because selector input for patron guarantors relationship actually uses default selected value from non-patron guarantors relationship. To test: 1. Make sure you have some value(s) in syspref "borrowerRelationship" e.g. "guarantor". 2. Add following line to "IntranetUseJS": $('.relationship option:eq(1)').attr('selected', 'selected'); 3. Add guarantee patron and note that non-patron guarantors relationship is now "guarantor". 4. Add patron guarantor and note that relationship value is empty. 5. Apply this patch and refresh page. 6. Repeat step 4. => Note that now relationship value is "guarantor". Sponsored-by: Koha-Suomi O -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 10:42:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 08:42:29 +0000 Subject: [Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com --- Comment #4 from Marcel de Rooy --- Could you have a look, Martin ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 11:23:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 09:23:36 +0000 Subject: [Koha-bugs] [Bug 31464] Coce images don't always load in Firefox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31464 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley at catalyst.net.nz --- Comment #2 from Alex Buckley --- Hi Katrin, Was it my patch on bug 31446 ( https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217#c12 ) that you found this on? It sounds like that when you were testing you were finding the cover was not showing on the details page, with and without the patch. I've tested lots of refreshes in Firefox, before and after the patch on 31446, and for me, the cover image does not always display on the detail page. Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 12:01:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 10:01:52 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 --- Comment #14 from Marcel de Rooy --- Created attachment 139940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139940&action=edit Bug 22678: Replace a few unneeded Koha::Logger calls We have Koha::Logger via the Mojo app now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 12:16:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 10:16:09 +0000 Subject: [Koha-bugs] [Bug 30660] Add cancellation reason to holds delete endpoint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30660 Johanna Räisä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |johanna.raisa at koha-suomi.fi |ity.org | --- Comment #1 from Johanna Räisä --- Created attachment 139941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139941&action=edit Bug 30660: Add cancellation reason to holds delete endpoint This patch adds cancellation reason to holds delete endpoint. Test plan: 1) prove t/db_dependent/api/v1/holds.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 12:16:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 10:16:17 +0000 Subject: [Koha-bugs] [Bug 30660] Add cancellation reason to holds delete endpoint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30660 Johanna Räisä changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 12:48:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 10:48:43 +0000 Subject: [Koha-bugs] [Bug 26692] Add barcode image generator service for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #34 from Kyle M Hall --- (In reply to David Cook from comment #33) > (In reply to Kyle M Hall from comment #0) > > Some libraries would like to add a scannable barcode to the patron self > > service area of the opac for patrons who do not have their library cards > > with them. > > While developing the plugin, I've realized that many libraries might be > using laser barcode scanners which are unlikely to work when scanning > barcodes on a mobile phone screen... Your screenshots look good! As long is the barcode is optional ( and if it's a plugin it definitely is ) I can't see a reason not to have this option for all the libraries using compatible scanners. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 13:46:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 11:46:33 +0000 Subject: [Koha-bugs] [Bug 9717] Local use recorded for holds/transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9717 Axelle Aix-Marseille Université changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |axelle.clarisse at univ-amu.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 13:57:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 11:57:59 +0000 Subject: [Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 13:59:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 11:59:31 +0000 Subject: [Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 --- Comment #29 from Marcel de Rooy --- (In reply to Paul Derscheid from comment #28) > Ha, meant to sign-off on all three but Kyle already did, so. > Just tested it out and I love this. Great work! An additional signoff line only provides more evidence of testing. So never hesitate to add one :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 14:02:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 12:02:50 +0000 Subject: [Koha-bugs] [Bug 30025] Split BiblioAddsAuthorities into 2 preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch splits the release notes| |system preference | |BiblioAddsAuthorities into | |two new system preferences | |that more clearly define | |what the settings do: | |1- | |RequireChoosingExistingAuth | |ority: this preference | |indicates whether a | |cataloger must choose from | |existing authorities, or if | |they can enter free text | |into controlled fields | |2- | |AutoLinkBiblios: this | |preference determines | |whether Koha will attempt | |to link a new record to | |existing authorities upon | |saving. In conjunction with | |the existing preference, | |AutoCreateAuthorities, | |unmatched headings will | |either be linked to a new | |authority, or remain | |uncontrolled Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 14:07:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 12:07:34 +0000 Subject: [Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 --- Comment #30 from Marcel de Rooy --- David, just glancing over but this code looks very good. Just thinking that Koha::Auth may be quite ambitiously named for now. How long will we have C4::Auth and Koha::Auth side by side? Do we actually need the 'staff' script or was it jusy easy while testing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 14:18:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 12:18:56 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139940|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy --- Created attachment 139942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139942&action=edit Bug 22678: Replace a few unneeded Koha::Logger calls We have Koha::Logger via the Mojo app now. Test plan: Run perl t/db_dependent/api/v1/unhandled_exceptions.t Your plack-api-error.log should contain something like: [2022/08/29 12:15:25] [ERROR] DELETE /api/v1/patrons/1052: unhandled exception (Koha::Exception)<> Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 14:27:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 12:27:33 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139942|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy --- Created attachment 139943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139943&action=edit Bug 22678: Replace a few unneeded Koha::Logger calls We have Koha::Logger via the Mojo app now. Test plan: Run perl t/db_dependent/api/v1/unhandled_exceptions.t Your plack-api-error.log should contain something like: [2022/08/29 12:15:25] [ERROR] DELETE /api/v1/patrons/1052: unhandled exception (Koha::Exception)<> Bonus: Add one line to Koha/REST/Plugin/PluginRoutes.pm: $app->log->error('PluginRoutes L49'); Before the line with if ( C4::Context->config("enable_plugins") ) Restart and hit the API once again. Your log should contain: [2022/08/29 12:21:55] [ERROR] PluginRoutes L49 This serves to demonstrate that the $api->log change in PluginRoutes works. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 14:29:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 12:29:26 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #17 from Marcel de Rooy --- Okay, David wrote the first patch. I added a follow-up and came up with a simnple test plan to verify those changes. Throwing a stone in the water now. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 14:29:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 12:29:33 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 14:30:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 12:30:07 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy at rijksmuseum.nl | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 14:36:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 12:36:50 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl --- Comment #18 from Tomás Cohen Arazi --- Please look at the return type for 'context': https://docs.mojolicious.org/Mojo/Log.txt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 14:46:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 12:46:08 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 --- Comment #19 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #18) > Please look at the return type for 'context': > > https://docs.mojolicious.org/Mojo/Log.txt Good catch. Although merely theoretical for now. We are not calling the log context of Mojo in Koha currently. We could however make sure that there is an (empty) arrayref inside? >From Mojo: sub context { my ($self, @context) = @_; return $self->new(parent => $self, context => \@context, level => $self->level); } sub _log { my ($self, $level) = (shift, pop); my @msgs = ref $_[0] eq 'CODE' ? $_[0]() : @_; unshift @msgs, @{$self->{context}} if $self->{context}; ($self->{parent} || $self)->emit('message', $level, @msgs); } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 14:52:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 12:52:04 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 --- Comment #20 from Marcel de Rooy --- Created attachment 139944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139944&action=edit Bug 22678: (follow-up) Array ref expected in context key -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 15:26:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 13:26:23 +0000 Subject: [Koha-bugs] [Bug 31482] New: Label creator does not call item_barcode_transform plugin hook Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482 Bug ID: 31482 Summary: Label creator does not call item_barcode_transform plugin hook Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The label creator can accept a list of either itemnumbers or item barcodes. In the case that the list of composed of barcodes, those barcodes should be passed though the item_barcode_transform plugin hook before the lookup is performed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 15:26:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 13:26:28 +0000 Subject: [Koha-bugs] [Bug 31482] Label creator does not call item_barcode_transform plugin hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 15:26:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 13:26:36 +0000 Subject: [Koha-bugs] [Bug 31482] Label creator does not call item_barcode_transform plugin hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 15:30:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 13:30:38 +0000 Subject: [Koha-bugs] [Bug 31482] Label creator does not call item_barcode_transform plugin hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 15:31:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 13:31:01 +0000 Subject: [Koha-bugs] [Bug 31482] Label creator does not call item_barcode_transform plugin hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482 --- Comment #1 from Kyle M Hall --- Created attachment 139945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139945&action=edit Bug 31482i: Label creator does not call item_barcode_transform plugin hook The label creator can accept a list of either itemnumbers or item barcodes. In the case that the list of composed of barcodes, those barcodes should be passed though the item_barcode_transform plugin hook before the lookup is performed. Test Plan: 1) Apply this patch 2) Download and install the Barcode Transformer plugin https://github.com/bywatersolutions/koha-plugin-barcode-transformer/releases/ 3) Go to the plugin configuration page, set the configuration to the example configuration from the same page 4) On the "New label batch" page of the Label creator,, type in some valid barcodes, but prefix them with X and postfix them with Y, e.g. X123456Y 5) Submit the form 6) Note the items are added to the label batch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 15:31:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 13:31:18 +0000 Subject: [Koha-bugs] [Bug 31482] Label creator does not call item_barcode_transform plugin hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26351 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 [Bug 26351] Add plugin hooks to transform item barcodes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 15:31:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 13:31:18 +0000 Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31482 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482 [Bug 31482] Label creator does not call item_barcode_transform plugin hook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 15:32:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 13:32:48 +0000 Subject: [Koha-bugs] [Bug 31482] Label creator does not call item_barcode_transform plugin hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139945|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 139946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139946&action=edit Bug 31482: Label creator does not call item_barcode_transform plugin hook The label creator can accept a list of either itemnumbers or item barcodes. In the case that the list of composed of barcodes, those barcodes should be passed though the item_barcode_transform plugin hook before the lookup is performed. Test Plan: 1) Apply this patch 2) Download and install the Barcode Transformer plugin https://github.com/bywatersolutions/koha-plugin-barcode-transformer/releases/ 3) Go to the plugin configuration page, set the configuration to the example configuration from the same page 4) On the "New label batch" page of the Label creator,, type in some valid barcodes, but prefix them with X and postfix them with Y, e.g. X123456Y 5) Submit the form 6) Note the items are added to the label batch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 15:38:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 13:38:04 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51832|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 15:38:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 13:38:52 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 --- Comment #42 from Marcel de Rooy --- Gonna remove the remainders of this bug report here now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 15:39:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 13:39:39 +0000 Subject: [Koha-bugs] [Bug 15545] Remove remainders of unfinished reqholdnotes functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Optionally make hold notes |Remove remainders of |required when placing a |unfinished reqholdnotes |hold |functionality -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 15:39:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 13:39:48 +0000 Subject: [Koha-bugs] [Bug 15545] Remove remainders of unfinished reqholdnotes functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Hold requests |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 15:44:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 13:44:17 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 --- Comment #61 from Andrew Fuerste-Henry --- Good catch on that missing space! And I agree about the use of quotes around pronouns in Contact Information -- it feels sort of off and non-standard. Using parentheses would make more sense to me. But I like it in the Contact Information section generally; that's where I'd expect to find information about how to address someone. (As an aside, I see we're similarly putting Other Name in parentheses some places and quotes others. I feel like for American English usage that should be quotes all over, but that at least another bug and probably a larger linguistic conversation.) I don't know the full extent of the change Katrin suggests to not include pronouns in koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc. I like the general idea, though, of only including pronouns in a few places in the patron record, not necessarily pushing them out to everywhere the patron name appears. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 15:48:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 13:48:51 +0000 Subject: [Koha-bugs] [Bug 15545] Remove remainders of unfinished reqholdnotes functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 15:48:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 13:48:57 +0000 Subject: [Koha-bugs] [Bug 15545] Remove remainders of unfinished reqholdnotes functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59252|0 |1 is obsolete| | Attachment #59253|0 |1 is obsolete| | --- Comment #43 from Marcel de Rooy --- Created attachment 139947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139947&action=edit Bug 15545: Remove reqholdnotes from opac-reserve This never really made it. So let's remove all traces. Test plan: Look at code changes and git grep reqholdnotes. Bonus: Place a hold with/without hold notes. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 15:49:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 13:49:38 +0000 Subject: [Koha-bugs] [Bug 15545] Remove remainders of unfinished reqholdnotes functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 --- Comment #44 from Marcel de Rooy --- Trivial: self SO. Just housekeeping. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 16:20:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 14:20:35 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 16:20:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 14:20:41 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138505|0 |1 is obsolete| | Attachment #138506|0 |1 is obsolete| | Attachment #138507|0 |1 is obsolete| | Attachment #138508|0 |1 is obsolete| | Attachment #138509|0 |1 is obsolete| | Attachment #138510|0 |1 is obsolete| | Attachment #138511|0 |1 is obsolete| | Attachment #138512|0 |1 is obsolete| | Attachment #138513|0 |1 is obsolete| | Attachment #138514|0 |1 is obsolete| | --- Comment #55 from Nick Clemens --- Created attachment 139948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139948&action=edit Bug 17170: DB Updates This patch adds the new table, permission, and a syspref to enable the feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 16:20:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 14:20:49 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #56 from Nick Clemens --- Created attachment 139949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139949&action=edit Bug 17170: DO NOT PUSH - Schema Updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 16:20:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 14:20:55 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #57 from Nick Clemens --- Created attachment 139950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139950&action=edit Bug 17170: Update schema for boolean -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 16:21:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 14:21:00 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #58 from Nick Clemens --- Created attachment 139951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139951&action=edit Bug 17170: Add API route for SearchFilters This adds the API routes and tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 16:21:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 14:21:07 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #59 from Nick Clemens --- Created attachment 139952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139952&action=edit Bug 17170: Add search filters to staff and opac interfaces This patch displays the filters on the results pages with the facets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 16:21:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 14:21:14 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #60 from Nick Clemens --- Created attachment 139953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139953&action=edit Bug 17170: Handle search filters in query builders This patch updates the query building code to expand filters when searching and pass them back as part of the cgi and descriptive search strings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 16:21:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 14:21:20 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #61 from Nick Clemens --- Created attachment 139954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139954&action=edit Bug 17170: Add admin page for filters and ability to edit/save existing filters This patchset adds a new ability to save searches on the staff client, and display them in the results page on staff or opac as a new filter. New filters can be added from the resuilts page after a search, and there is an admin page for updating deleting and renaming filters There is a new permission to control management of these filters New filters can be added that are not displayed along with facets, this allows for building custom links using these filters to keep URLs shorter Due to bug 30528 testing in ES is recommended To test: 1 - Apply patches and update database and restart all 2 - Enable new system preference 'SavedSearchFilters' 3 - As superlibrarian perform a search in staff client, something broad like 'a' 4 - Note new 'Save search as filter' link on results page 5 - Click it, save search as new filter, check 'Staff client' visibility 6 - Perform another search 7 - Note the filter now appears above facets 8 - Click to it filter results 9 - Note results are limited by the new filter, and it is checked in the facets 10 - Confirm click the [x] removes the filter 11 - Go to administration->search filters 12 - Confirm the filter appears 13 - Edit and mark as OPAC visible 14 - Test OPAC to ensure it shows and can be applied/removed 15 - Copy URL with filter applied 16 - In adminsitration mark filter as not visible on staff or opac 17 - Confirm link above still works 18 - Create a new staff with catalogue and search filters permission 19 - Ensure they can access/save filters 20 - Remove filter permission and ensure they cannot 21 - Disable system preference 22 - Confirm links to search filters page are removed from admin home and admin sidebar 23 - Confirm filters do not appear on results and cannot be created 24 - Enable pref 25 - Create a filter 26 - From search filters page, click 'Edit search' 27 - Confirm you are taken to advanced search page letting you know which filter you are editing 28 - Confirm you can change searhc options and save 29 - Confirm you can perform the search from this page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 16:21:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 14:21:28 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #62 from Nick Clemens --- Created attachment 139955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139955&action=edit Bug 17170: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 16:21:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 14:21:33 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #63 from Nick Clemens --- Created attachment 139956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139956&action=edit Bug 17170: (follow-up) Display search filters admin links when apprropriate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 16:21:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 14:21:39 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #64 from Nick Clemens --- Created attachment 139957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139957&action=edit Bug 17170: Add the ability to create 'saved searches' for use as filters when searching the catalog This patch alters the code in the ES QueryBuilder. Reflecting how things are handled in build_query_compat we clean the query, but not the limits. In Zebra we simply recursivly call buildQuery, but the ES query structure This patchset adds a new ability to save searches on the staff client, and display them in the results page on staff or opac as a new filter. New filters can be added from the results page after a search, and there is an admin page for updating deleting and renaming filters There is a new permission to control management of these filters New filters can be added that are not displayed along with facets, this allows for building custom links using these filters to keep URLs shorter Due to bug 30528 testing in ES is recommended To test: 1 - Apply patches and update database and restart all 2 - Enable new system preference 'SavedSearchFilters' 3 - As superlibrarian perform a search in staff client, something broad like 'a' 4 - Note new 'Save search as filter' link on results page 5 - Click it, save search as new filter, check 'Staff client' visibility 6 - Perform another search 7 - Note the filter now appears above facets 8 - Click to it filter results 9 - Note results are limited by the new filter, and it is checked in the facets 10 - Confirm click the [x] removes the filter 11 - Go to administration->search filters 12 - Confirm the filter appears 13 - Edit and mark as OPAC visible 14 - Test OPAC to ensure it shows and can be applied/removed 15 - Copy URL with filter applied 16 - In adminsitration mark filter as not visible on staff or opac 17 - Confirm link above still works 18 - Create a new staff with catalogue and search filters permission 19 - Ensure they can access/save filters 20 - Remove filter permission and ensure they cannot 21 - Disable system preference 22 - Confirm links to search filters page are removed from admin home and admin sidebar 23 - Confirm filters do not appear on results and cannot be created 24 - Enable pref 25 - Create a filter 26 - From search filters page, click 'Edit search' 27 - Confirm you are taken to advanced search page letting you know which filter you are editing 28 - Confirm you can change searhc options and save 29 - Confirm you can perform the search from this page Signed-off-by: Michal Urban -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 17:22:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 15:22:12 +0000 Subject: [Koha-bugs] [Bug 29777] Fields 580 are wrong displayed in summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29777 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128939|0 |1 is obsolete| | --- Comment #5 from Jérémy Breuillard --- Created attachment 139958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139958&action=edit Bug 29777: Fields 580 are wrong displayed in summary column The summary of Authority search results doesn't display informations about field $580. Those informations are separated by ; To test: 1) Make sure to have at least one authority with subfield 580$a 2) Home > Authorities > Results from authority search 3) Notice the series of semicolons in the summary " ; ; ; ; " - (screenshot 1) 4) Usually for earch subfield 580$a that you fill up when you modify/create an authority the summary should display 580$a (also $550, $560) followed by a semicolons "myEntryElementForSubfield580$a ; myOtherEntryElementForSubfield580$a ; " 5) Apply patch & refresh the browser 6) Notice the 580$a are now visible on summary and ends with a semicolon (screenshot 2) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 17:23:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 15:23:43 +0000 Subject: [Koha-bugs] [Bug 29777] Fields 580 are wrong displayed in summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29777 --- Comment #6 from Jérémy Breuillard --- Created attachment 139959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139959&action=edit screenshot 1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 17:25:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 15:25:42 +0000 Subject: [Koha-bugs] [Bug 29777] Fields 580 are wrong displayed in summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29777 --- Comment #7 from Jérémy Breuillard --- Created attachment 139960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139960&action=edit screenshot 2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 17:26:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 15:26:45 +0000 Subject: [Koha-bugs] [Bug 29777] Fields 580 are wrong displayed in summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29777 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 17:56:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 15:56:52 +0000 Subject: [Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138377|0 |1 is obsolete| | --- Comment #13 from Lucas Gass --- Created attachment 139961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139961&action=edit Bug 30624: Add select_loggedin_library permission To test: 1. Apply patch, updatedatabase, restart_all 2. Have a user with superlibrarian privileges ( User1 ) 3. Have a user who has staff access and circulate privileges but is not a super librarian. ( User2 ) Make note of this users home library 4. Turn on the system preference 'CircSidebar'. -MAIN log in ( auth.tt ) 5. As User1, go to the main login screen and try logging in. You should be able to log in AND you should be able to properly chnage your branch BEFORE logging in. 6. As User2, to to the main login screnn amd try logging in. You should be able to but if you try and switch your libraray to anything beside the user's home branch it will not work. You will be logged in at your home branch. 7. For User2, set the new permission 'select_loggedin_library' on. 8. Now you should be able to successfully switch libraries before log in. 9. Turn the 'select_loggedin_library' back off for User2. -AFTER log in- 10. With User1, click on your name/branch in the top right, you should see the the link 'Set library' at the top. If you turn on 'UseCirculationDesks' the link will be 'Set library and desk'. 11. With User2, click on your name/branch in the top right. If you have 'UseCirculationDesks' on, you should see 'Set desk', otherwise you should see nothing. 12. Repeat step 7. 13. NOw if you click on your name/branch in the top right, you should see the the link 'Set library' at the top. If you turn on 'UseCirculationDesks' the link will be 'Set library and desk'. 14. Repeat Step 9. -CircSideBar- 15. With 'CircSideBar' turned on, go to any ciculation page (Holds queue, Holds to pull, Holds awaiting pickup) with User1. You will see the 'Set library' link. If 'UseCirculationDesks' is on you will see a 'Set library and desk'. 16. Try with User2 and you will not see a 'Set library' link. If 'UseCirculationDesks' is on you will see a 'Set desk' link. 17. Repeat step 7. 18. For with User2 you go to any ciculation page (Holds queue, Holds to pull, Holds awaiting pickup). You will see the 'Set library' link. If 'UseCirculationDesks' is on you will see a 'Set library and desk'. 19. Repeat step 9. -Set library page- 20. Go to the set library page (http://localhost:8081/cgi-bin/koha/circ/set-library.pl) with User1. You will see a dropdown for 'Set library'. Make sure you can change your library successfully. 21. Go to the set library page (http://localhost:8081/cgi-bin/koha/circ/set-library.pl) with User2. You should NOT see see a dropdown for 'Set library'. 22. Repeat step 7. 23. Go to the set library page (http://localhost:8081/cgi-bin/koha/circ/set-library.pl) with User2. Now you should see a dropdown for 'Set library'. Signed-off-by: Andrew -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 17:56:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 15:56:56 +0000 Subject: [Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138378|0 |1 is obsolete| | --- Comment #14 from Lucas Gass --- Created attachment 139962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139962&action=edit Bug 30624: DB Update to add permission Signed-off-by: Andrew -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 17:57:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 15:57:24 +0000 Subject: [Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624 --- Comment #15 from Lucas Gass --- rebased for current master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 18:00:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 16:00:38 +0000 Subject: [Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624 --- Comment #16 from Lucas Gass --- (In reply to Fridolin Somers from comment #12) > I mean in authentication TT. > Actually there is only a UNLESS IndependentBranches : > > https://git.koha-community.org/Koha-community/Koha/src/commit/ > fc78953951837f6fe7a3e9d66ac497dcb5511f53/koha-tmpl/intranet-tmpl/prog/en/ > modules/auth.tt#L91 Ah, yes! Since that will be handled by a permission we no longer need this check, the dropdown should always show. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 18:02:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 16:02:35 +0000 Subject: [Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624 --- Comment #17 from Lucas Gass --- Created attachment 139963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139963&action=edit Bug 30624: (follow-up) Remove IndependentBraches check on auth.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 18:04:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 16:04:34 +0000 Subject: [Koha-bugs] [Bug 30209] Upgrade 'libdbd-sqlite2-perl' package to 'libdbd-sqlite3-perl' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30209 --- Comment #9 from Mason James --- (In reply to Mason James from comment #7) > (In reply to Mason James from comment #5) > > hi Frido > > can you apply this patch to pass the master tests on jenkins > > > > https://jenkins.koha-community.org/view/master/job/Koha_Master_D10/548/ > > lets not apply this to 21.11 and lower, for now hi tuxayo, any chance we can get this patch added to 21.05? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 18:05:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 16:05:28 +0000 Subject: [Koha-bugs] [Bug 4269] Module DBD::SQLite2 requirement will cause problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4269 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- CC| |victor at tuxayo.net Status|RESOLVED |REOPENED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 18:07:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 16:07:22 +0000 Subject: [Koha-bugs] [Bug 30209] Upgrade 'libdbd-sqlite2-perl' package to 'libdbd-sqlite3-perl' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30209 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- CC| |victor at tuxayo.net --- Comment #10 from Mason James --- (In reply to Mason James from comment #7) > (In reply to Mason James from comment #5) > > hi Frido > > can you apply this patch to pass the master tests on jenkins > > > > https://jenkins.koha-community.org/view/master/job/Koha_Master_D10/548/ > > lets not apply this to 21.11 and lower, for now hi tuxayo, any chance we can get this patch added to 21.05? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 18:07:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 16:07:45 +0000 Subject: [Koha-bugs] [Bug 4269] Module DBD::SQLite2 requirement will cause problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4269 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 18:19:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 16:19:40 +0000 Subject: [Koha-bugs] [Bug 31483] New: Minor UI problem in opac-reset-password.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Bug ID: 31483 Summary: Minor UI problem in opac-reset-password.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org When EnableExpiredPasswordReset is enabled, patrons can access a page to reset their password. In this page, the grey box that normally contains the breadcrumbs encompasses the whole form. To test: 1) Enable EnableExpiredPasswordReset 2) Find a patron and change their password so you know what it is supposed to be 3) In the database, expire the patron's password, e.g. UPDATE borrowers SET password_expiration_date = '2022-08-22' where borrowernumber = 21; 4) Go to the OPAC, try to log in with the patron's credentials 5) Click Reset your password => Note that the form is in the grey breadcrumbs box, you can compare with any other OPAC page, the grey box should only contain the breadcrumbs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 18:20:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 16:20:12 +0000 Subject: [Koha-bugs] [Bug 31483] Minor UI problem in opac-reset-password.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31382 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31382 [Bug 31382] Cannot reach password reset page when password expired -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 18:20:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 16:20:12 +0000 Subject: [Koha-bugs] [Bug 31382] Cannot reach password reset page when password expired In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31382 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31483 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 [Bug 31483] Minor UI problem in opac-reset-password.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 18:55:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 16:55:54 +0000 Subject: [Koha-bugs] [Bug 29198] Inconsistencies in opac results display vs staff results display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29198 --- Comment #3 from Lucas Gass --- This is still a bug although things have changed somewhat since I intially filed it. To recreate: 1. Create a NOT_LOAN value with a AV of 1. Give it both an description and OPAC desrciption. 2. Find something in the catalog with at least 2 items. 3. Mark at least 1 item with the new NOT_LOAN value. 4. Look at OPAC results vs staff results, the displays are not consistent. The OPAC says 1 available for reference. The staff client results says 1 unvailable. 5. Look at OPAC detail vs staff detail. OPAC says 'Available' while the staff client says "Not for loan (Staff description) Available" These displays should all be consistent. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 19:03:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 17:03:24 +0000 Subject: [Koha-bugs] [Bug 30648] Title is lost in Holds History when biblio is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 --- Comment #3 from Owen Leonard --- In the meantime I think we need an update to the holds history page in the OPAC to exclude deleted titles. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 19:04:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 17:04:22 +0000 Subject: [Koha-bugs] [Bug 31484] New: Renewals disabled message doesn't display all reasons why something cannot be renewed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31484 Bug ID: 31484 Summary: Renewals disabled message doesn't display all reasons why something cannot be renewed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com There are many reasons why the renewals-disabled button might display in the issues table but not all of them will display depending on the circumstance, this can hamper librarians ability to make correct choices. For example: 1. Have an item checkout out what can be renewed at least one time BUT make that item overdue. 2. In the renewal column you'll see "0 Not allowed: overdue". That is good. 3. Have 'AllowRenewalOnHoldOverride' set to 'Don't allow' 4. Place the same item from 1-2 on hold. Make it an item level hold on that specific item. 5. Look at the issues table again, it still says "0 Not allowed: overdue". 6. The message should include some language saying the item can't be renewed becuase it is on hold AND it is overdue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 19:13:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 17:13:20 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Carl changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ctodd at hcc.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 19:51:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 17:51:18 +0000 Subject: [Koha-bugs] [Bug 25426] Allow return policy to be selected via syspref and not just home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25426 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139802|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 139964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139964&action=edit Bug 25426: Allow return policy to be selected via syspref and not just home library 1) Apply this patch 2) Run updatedatabase.pl 3) Verify CircControlReturnsBranch is set to home library by default 4) Set a Return policy for Branch A to "Item returns home" ( homebranch ) 5) Set a Return polity for Branch B to "Item returns to issuing library" ( holdingbranch ) 6) Set a Return polity for Branch C to "Item floats" ( noreturn ) 7) Create an item with homebranch of Branch A, holding branch of branch B 8) Log in as Branch C 9) Set CircControlReturnsBranch to "the library the item is currently held by" 10) Check the item in, note it should be returned to the holding library 11) Set CircControlReturnsBranch to "the library the item is owned by" 12) Check the item in, note it should be returned to the home library 13) Set CircControlReturnsBranch to "the library you are logged in at" 14) Check the item in, note it should float Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 20:04:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 18:04:09 +0000 Subject: [Koha-bugs] [Bug 31458] Remove Koha::Patron::Debarment::AddDebarment and use $patron->add_restriction in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31458 --- Comment #4 from Kyle M Hall --- I believe we've discussed this elsewhere, but just to make sure it's public; The field borrowers.debarred was retained so that existing code utilizing the debarred field would continue to work. In practice, sometimes that field gets out of sync with the actual debarments. At this point in time, it makes a lot more sense to remove borrowers.debarred from the database. I think the same can be said for debarredcomment as well. (In reply to Martin Renvoize from comment #3) > Created attachment 139800 [details] [review] > Add _update_patron_restriction_fields > > This still needs some work.. picking which of the two constructs for > ordering works and removing new lines from the debarredcomment field. > > Do we even need the local debarredcomment field any more... and should > the debarred field just become a boolean.. or should we just drop the > fields from the borrowers table entirely and rely on relations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 20:15:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 18:15:23 +0000 Subject: [Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 --- Comment #11 from Kyle M Hall --- I have no idea what's going on, but in production this is breaking SIP! No errors in the logs. Is anyone else experiencing this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 20:40:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 18:40:15 +0000 Subject: [Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 --- Comment #12 from Kyle M Hall --- (In reply to Kyle M Hall from comment #11) > I have no idea what's going on, but in production this is breaking SIP! > No errors in the logs. > Is anyone else experiencing this? Ignore this^ I had set max lower than min. That was my bad. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 20:44:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 18:44:29 +0000 Subject: [Koha-bugs] [Bug 31485] New: Move ItemsDeniedRenewal checks from C4::Circulation to Koha::Item Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31485 Bug ID: 31485 Summary: Move ItemsDeniedRenewal checks from C4::Circulation to Koha::Item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: joonas.kylmala at iki.fi Reporter: joonas.kylmala at iki.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com C4/Circulation.pm contains currently a function called _item_denied_renewal which is clearly a method of Koha::Item, thus it should be moved there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 20:55:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 18:55:52 +0000 Subject: [Koha-bugs] [Bug 31485] Move ItemsDeniedRenewal checks from C4::Circulation to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31485 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 20:55:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 18:55:55 +0000 Subject: [Koha-bugs] [Bug 31485] Move ItemsDeniedRenewal checks from C4::Circulation to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31485 --- Comment #1 from Joonas Kylmälä --- Created attachment 139965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139965&action=edit Bug 31485: Move _item_denied_renewal to Koha::Item The question whether item is denied renewal doesn't depend on circulation rules or the patron, it is only a property of the item and only changes to the item's attributes can cause the return value of the check to change, thus we should move this to be a method of Koha::Item. To test: 1) Run unit tests $ prove t/db_dependent/Circulation.t $ prove t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 21:03:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 19:03:35 +0000 Subject: [Koha-bugs] [Bug 25753] Replace transferbook in circ/branchtransfers with Koha::Object method calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi --- Comment #1 from Joonas Kylmälä --- Martin, Any status update? I'm thinking whether to work on this, unless you have some plans already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 21:35:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 19:35:20 +0000 Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357 Jennifer Millikan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jmillikan at sja1840.org --- Comment #65 from Jennifer Millikan --- I am brand new to Koha, but I was told this bug is why I have to include apostrophes while searching. I tried searching for Don't Hate the Player title and came up with zero results. I did not use the apostrophe because I have never had to before in multiple catalog systems. I repeated the search with the apostrophe and found the title. I think the searching should work both ways with or without the apostrophe. Thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 21:35:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 19:35:52 +0000 Subject: [Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 Jennifer Millikan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jmillikan at sja1840.org --- Comment #12 from Jennifer Millikan --- I am brand new to Koha, but I was told this bug is why I have to include apostrophes while searching. I tried searching for Don't Hate the Player title and came up with zero results. I did not use the apostrophe because I have never had to before in multiple catalog systems. I repeated the search with the apostrophe and found the title. I agree with this and think the searching should work both ways with or without the apostrophe. Thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 21:55:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 19:55:23 +0000 Subject: [Koha-bugs] [Bug 15002] All system resources get used if user refreshes a web page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15002 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Joonas Kylmälä --- Unactionable as such, need to work on specific perf problems to mitigate the resource usage. Closing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 22:37:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 20:37:16 +0000 Subject: [Koha-bugs] [Bug 31486] New: Deleting a message from circulation.pl redirects to moremember.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486 Bug ID: 31486 Summary: Deleting a message from circulation.pl redirects to moremember.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If you are on the patron checkout page (circulation.pl) and you delete a message you will be redirected to the details page (moremember.pl) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 22:44:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 20:44:01 +0000 Subject: [Koha-bugs] [Bug 28167] A warning when setting which library to use in intranet and UseCashRegisters is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28167 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 22:44:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 20:44:05 +0000 Subject: [Koha-bugs] [Bug 28167] A warning when setting which library to use in intranet and UseCashRegisters is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28167 --- Comment #1 from Joonas Kylmälä --- Created attachment 139966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139966&action=edit Bug 28167: Remove uninitialized variable warnings from circ/set-library.pl With UseCashRegisters syspref disabled going to the page /cgi-bin/koha/circ/set-library.pl in staff interface and setting a library gives the following errors in plack-intranet-error.log: Use of uninitialized value $register_id in string ne at /kohadevbox/koha/circ/set-library.pl line 79. Use of uninitialized value $referer in pattern match (m//) at /kohadevbox/koha/circ/set-library.pl line 114. In the if clause $userenv_register_id appears to be typoed, it should have been $register_id as $userenv_register_id is always defined. As for the $referer variable, it is undef if there is no referer so let's just initialize it to an empty string for the regex so it doesn't give the warning. To test: 1) Go directly to /cgi-bin/koha/circ/set-library.pl by typing it in the URL bar and set a library 2) Make sure plack-intranet-error.log doesn't contain the above mentioned errors after applying this patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 23:08:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 21:08:55 +0000 Subject: [Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 --- Comment #3 from Victor Grousset/tuxayo --- Thanks a lot :D Backport needed down to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 23:30:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 21:30:11 +0000 Subject: [Koha-bugs] [Bug 30209] Upgrade 'libdbd-sqlite2-perl' package to 'libdbd-sqlite3-perl' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30209 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00, 21.05.19 released in| | --- Comment #11 from Victor Grousset/tuxayo --- Backported: Pushed to 21.05.x branch for 21.05.19 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 23:30:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 21:30:57 +0000 Subject: [Koha-bugs] [Bug 30209] Upgrade 'libdbd-sqlite2-perl' package to 'libdbd-sqlite3-perl' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30209 --- Comment #12 from Victor Grousset/tuxayo --- (In reply to Mason James from comment #10) > hi tuxayo, any chance we can get this patch added to 21.05? What about 21.11? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 23:51:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 21:51:35 +0000 Subject: [Koha-bugs] [Bug 31486] Deleting a message from circulation.pl redirects to moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 23:51:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 21:51:37 +0000 Subject: [Koha-bugs] [Bug 31486] Deleting a message from circulation.pl redirects to moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486 --- Comment #1 from Lucas Gass --- Created attachment 139967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139967&action=edit Bug 31486: Redirect to proper page after message deletion To test: 1. Go to a patron account and create some messages 2. Try deleting some from both the patron details page and the patron checkout page. 3. Notice that is you are on the patron checkout page and delete a message you are then redirected to the patron details page. 4. Apply patch 5. Try deleting messages from both pages and confirm you are redirected back to that same page and the message is properly deleted. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 29 23:53:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 21:53:01 +0000 Subject: [Koha-bugs] [Bug 31486] Deleting a message from circulation.pl redirects to moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Text to go in the| |This patch corrects a release notes| |problem where message | |deletion was improperly | |redirecting to the patron | |delete page when a message | |is deleted on the | |circulation page. Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 00:17:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 22:17:32 +0000 Subject: [Koha-bugs] [Bug 25090] Moderate OPAC self registrations before a patron account is created In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25090 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112497|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 00:17:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 22:17:43 +0000 Subject: [Koha-bugs] [Bug 25090] Moderate OPAC self registrations before a patron account is created In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25090 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112496|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 00:17:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 22:17:53 +0000 Subject: [Koha-bugs] [Bug 25090] Moderate OPAC self registrations before a patron account is created In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25090 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112495|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 00:18:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 22:18:03 +0000 Subject: [Koha-bugs] [Bug 25090] Moderate OPAC self registrations before a patron account is created In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25090 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112494|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 00:18:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 22:18:13 +0000 Subject: [Koha-bugs] [Bug 25090] Moderate OPAC self registrations before a patron account is created In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25090 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112493|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 00:26:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 22:26:23 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 00:26:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 22:26:27 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 --- Comment #62 from Lucas Gass --- Created attachment 139968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139968&action=edit Bug 10950: (follow-up) Change display of pronoun fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 00:30:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 22:30:13 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 --- Comment #63 from Lucas Gass --- Thanks for the feedback Cait and Andrew! I agree that adding the pronouns to the patron-title include makes things cumbersome. Since this is mostly informational for staff I think it is adequate to show it in the brief display and on the details page. The most sense to be would be underneath that patrons name, so that is where I added it in my follow-up. Also, happy to have other opinions therefore I am resetting this to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 00:34:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 22:34:59 +0000 Subject: [Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 --- Comment #13 from Nick Clemens --- Created attachment 139969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139969&action=edit Bug 27153: POC This is a small example to show that we can add an extra field to our default indexing that removes punctuation. If we then add that field to the fields we push, we can sarch both the regular and the punctuation stripped version To complete this we would need to add a 'search variations' field to the ES config page, for the user to decide which fields should be searched in all variations, and which shouldn't Or we could add this to all 'simple searches' from the search bar, and only search exact on advanced searches. I am happy to explore either option -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 00:39:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 22:39:17 +0000 Subject: [Koha-bugs] [Bug 31483] Minor UI problem in opac-reset-password.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 --- Comment #1 from Lucas Gass --- Created attachment 139970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139970&action=edit Bug 31483: Correct tiny HTML error on password reset page To test: 1) Enable EnableExpiredPasswordReset 2) Find a patron and change their password so you know what it is supposed to be 3) In the database, expire the patron's password, e.g. UPDATE borrowers SET password_expiration_date = '2022-08-22' where borrowernumber = 21; 4) Go to the OPAC, try to log in with the patron's credentials 5) Click Reset your password => Note that the form is in the grey breadcrumbs box, you can compare with any other OPAC page, the grey box should only contain the breadcrumbs 6) Apply patch 7) Try steps 4-5 again. The gray breadcrumbs box should be for breadcrumbs only! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 00:39:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 22:39:52 +0000 Subject: [Koha-bugs] [Bug 31483] Minor UI problem in opac-reset-password.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com Status|NEW |Needs Signoff Severity|enhancement |trivial CC| |lucas at bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 00:43:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 22:43:25 +0000 Subject: [Koha-bugs] [Bug 31475] Group system preferences for suggestions on OPAC tab under new heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31475 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 01:15:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 23:15:03 +0000 Subject: [Koha-bugs] [Bug 25812] Display overdue fines for the item on SIP checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 01:15:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 23:15:54 +0000 Subject: [Koha-bugs] [Bug 25816] Add OPAC messages in SIP display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25816 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 01:16:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 23:16:44 +0000 Subject: [Koha-bugs] [Bug 29409] Update for bug 25333 can fail due to bad data or constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29409 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 01:17:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 23:17:56 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 01:18:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Aug 2022 23:18:26 +0000 Subject: [Koha-bugs] [Bug 25426] Allow return policy to be selected via syspref and not just home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25426 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 02:14:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 00:14:08 +0000 Subject: [Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 --- Comment #14 from David Cook --- I had a librarian (from an English-only library) asking for this the other day, and I was wondering why we have apostrophes replaced with a space (both for CHR and ICU indexing with Zebra). But Frido's example makes a lot of sense: (In reply to Fridolin Somers from comment #6) > Elision removes the text : l'europe = europe > This apostrophe filter creates : l'europe = leurope > > Wrong in french but surely ranking will bet better for the exact match. And in English, we'd have "father's" become "fathers", which means "father" wouldn't match unless you're using right truncation (which Koha typically does out of the box I suppose). But then there's a Ukrainian word під'їзд which if you broke it into під їзд, you'd get hits for під which is a totally unrelated word. -- I know people have praised Google here, but it's not perfect either. Try searching "l'arbre під'їзд" and try searching "під'їзд l'arbre", and you'll get wildly different results. It seems that Google tries to determine the language of the search query (possibly based off the first word), and then analyze the search string based off that. For "l'arbre під'їзд", you get many results with "L'Arbre", "des arbres", "arbre", etc. Most results seem to include Russian rather than Ukrainian. But for "під'їзд l'arbre", you only get a few results that have the string "L'Arbre"and most of the results are Ukrainian. So Google is likely determining the language of the search string and then applying a language-specific analyzer. "My mom" in Chinese is 我的妈妈. 的 is the character that denotes possession of mom (妈妈) by me/I (我). You might think then you could replace 的 with a space to separate the 2 nouns... except 的 isn't always used that way. The word 目的 means "goal". Doing anything to 的 would compromise the word, unless you're able to understand the context that it's used in. If you google "我的妈妈", eventually it strips off "我的" and just searches for "妈妈" since that's the main noun in the phrase. Search is hard. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 02:24:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 00:24:20 +0000 Subject: [Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 --- Comment #15 from David Cook --- (In reply to Katrin Fischer from comment #7) > Could we treat it ' as a space and 'no space' at the same time maybe? Without language-specific analysis, this might be the best way to go... (In reply to Nick Clemens from comment #13) > Created attachment 139969 [details] [review] > Bug 27153: POC > > This is a small example to show that we can add an extra field to our > default indexing that > removes punctuation. > > If we then add that field to the fields we push, we can sarch both the > regular and the punctuation stripped version I'm not very familiar with the Elasticsearch integration, but that POC doesn't touch the indexing, does it? Isn't it just modifying the search? (I don't know that it's touching apostrophes either?) If you searched "carries war" but it had been indexed as "carrie s war", then you still wouldn't get a hit? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 06:18:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 04:18:21 +0000 Subject: [Koha-bugs] [Bug 31446] Optionally hide lightbox_descriptions from OPAC lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31446 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139738|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 06:18:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 04:18:32 +0000 Subject: [Koha-bugs] [Bug 31446] Optionally hide lightbox_descriptions from OPAC lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31446 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139739|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 06:22:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 04:22:42 +0000 Subject: [Koha-bugs] [Bug 31446] Make it easier for libraries to hide lightbox_descriptions from OPAC lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31446 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Optionally hide |Make it easier for |lightbox_descriptions from |libraries to hide |OPAC lightbox gallery |lightbox_descriptions from | |OPAC lightbox gallery -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 06:43:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 04:43:01 +0000 Subject: [Koha-bugs] [Bug 31446] Make it easier for libraries to hide lightbox_descriptions from OPAC lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31446 --- Comment #4 from Alex Buckley --- Created attachment 139971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139971&action=edit Bug 31446: Add IDs to parent elements of cover images Having ID attributes for all parent div tags of OPAC lightbox cover images would make it easier for libraries to hide the lightbox descriptions hint text displaying under cover images. Libraries could simply add some JavaScript (in a format like below) to their OpacUserJS system preference for each image content source they use: $("#coce-coverimg > .hint").hide(); Test plan: 1. Apply patch 2. Confirm all parent div elements of cover images now have an ID in opac-detail.tt Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 07:47:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 05:47:09 +0000 Subject: [Koha-bugs] [Bug 31446] Make it easier for libraries to hide lightbox_descriptions from OPAC lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31446 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139971|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 07:47:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 05:47:56 +0000 Subject: [Koha-bugs] [Bug 31446] Make it easier for libraries to hide lightbox_descriptions from OPAC lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31446 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #5 from Alex Buckley --- I am working on a compromise patch for this bug report - as per https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31456#c6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 07:52:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 05:52:24 +0000 Subject: [Koha-bugs] [Bug 31446] Make it easier for libraries to hide lightbox_descriptions from OPAC lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31446 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139739|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 07:52:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 05:52:45 +0000 Subject: [Koha-bugs] [Bug 31446] Make it easier for libraries to hide lightbox_descriptions from OPAC lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31446 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139738|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 08:19:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 06:19:18 +0000 Subject: [Koha-bugs] [Bug 30472] Field borrower_relationships.guarantor_id should be marked as NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30472 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 08:19:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 06:19:22 +0000 Subject: [Koha-bugs] [Bug 30472] Field borrower_relationships.guarantor_id should be marked as NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30472 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139711|0 |1 is obsolete| | --- Comment #4 from Fridolin Somers --- Created attachment 139972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139972&action=edit Bug 30472: Make borrower_relationships.guarantor_id not null In harmony with dbrev 19.06.00.022. Test plan: Run dbrev. Run t/db_dependent/Patron/Relationships.t Run t/db_dependent/Koha/Patrons.t Signed-off-by: Marcel de Rooy Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 08:20:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 06:20:13 +0000 Subject: [Koha-bugs] [Bug 30472] Field borrower_relationships.guarantor_id should be marked as NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30472 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Depends on| |14570 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 [Bug 14570] Make it possible to add multiple guarantors to a record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 08:20:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 06:20:13 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30472 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30472 [Bug 30472] Field borrower_relationships.guarantor_id should be marked as NOT NULL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 08:21:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 06:21:08 +0000 Subject: [Koha-bugs] [Bug 30472] Field borrower_relationships.guarantor_id should be marked as NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30472 --- Comment #5 from Fridolin Somers --- Makes perfect sens. Generated DBIx looks OK. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 08:36:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 06:36:40 +0000 Subject: [Koha-bugs] [Bug 30472] Field borrower_relationships.guarantor_id should be marked as NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30472 --- Comment #6 from Marcel de Rooy --- (In reply to Fridolin Somers from comment #4) > Signed-off-by: Fridolin Somers Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 09:01:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 07:01:19 +0000 Subject: [Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 --- Comment #31 from David Cook --- (In reply to Marcel de Rooy from comment #30) > David, just glancing over but this code looks very good. Thanks, Marcel :) > Just thinking that Koha::Auth may be quite ambitiously named for now. > How long will we have C4::Auth and Koha::Auth side by side? Probably for a while, but Koha::Auth can be a target for any new auth work or for refactoring work. In Bug 31389, I've created Koha::Auth::Permissions, which contains a function to be used in C4::Auth. I suppose we could always use Koha::Mojo::Auth or some other Koha::Auth::* module instead of Koha::Auth. > Do we actually need the 'staff' script or was it jusy easy while testing? The "staff" script is for non-Plack enabled Koha instances. "api/v1/app.pl" works similarly. Although, in plack.psgi, the API gets loaded by loading that file whereas I just load the Koha::Mojo::Staff module as I think that's cleaner. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 09:03:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 07:03:06 +0000 Subject: [Koha-bugs] [Bug 26692] Add barcode image generator service for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #35 from David Cook --- (In reply to Kyle M Hall from comment #34) > Your screenshots look good! As long is the barcode is optional ( and if it's > a plugin it definitely is ) I can't see a reason not to have this option for > all the libraries using compatible scanners. Yeah, the plugin just gives the API end point. Currently, you have to write your own OpacUserJS to get the image. I figured that would provide max flexibility for libraries. I may end up doing a configuration screen that includes some example JS. My library that was interested in this looks like they use an image scanner rather than a laser scanner so it might be all good. I'll post up my POC plugin here sometime in the next couple days! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 10:29:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 08:29:14 +0000 Subject: [Koha-bugs] [Bug 31487] New: Add emails to message queue by longoverdue script options Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31487 Bug ID: 31487 Summary: Add emails to message queue by longoverdue script options Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: thibaud.guillot at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Some customers request the possibility of sending an additional reminder when processing longoverdues. I think this may be useful for some and given that it remains an option, it does not handicap those who do not want to use it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:05:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:05:32 +0000 Subject: [Koha-bugs] [Bug 29333] Importing UNIMARC authorities in MARCXML UTF-8 breaks the encoding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29333 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 Status|Pushed to stable |Pushed to oldstable --- Comment #19 from Arthur Suzuki --- thx, pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:15:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:15:45 +0000 Subject: [Koha-bugs] [Bug 31039] Rebase issues lead to duplicate JS for cash summary modal printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 CC| |arthur.suzuki at biblibre.com Status|Pushed to stable |Pushed to oldstable --- Comment #21 from Arthur Suzuki --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:15:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:15:46 +0000 Subject: [Koha-bugs] [Bug 30661] Able to update more hold parameters via REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30661 Johanna Räisä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |johanna.raisa at koha-suomi.fi |ity.org | --- Comment #1 from Johanna Räisä --- Created attachment 139973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139973&action=edit Bug 30661: Allow to update more hold parameters via REST This patch adds hold_date and expiration_date to holds edit endpoint Test plan: 1) prove t/db_dependent/api/v1/holds.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:16:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:16:39 +0000 Subject: [Koha-bugs] [Bug 31054] Manual importing for EDIFACT invoices fails with a 500 error page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31054 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 Status|Pushed to stable |Pushed to oldstable CC| |arthur.suzuki at biblibre.com --- Comment #6 from Arthur Suzuki --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:16:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:16:52 +0000 Subject: [Koha-bugs] [Bug 30661] Able to update more hold parameters via REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30661 --- Comment #2 from Johanna Räisä --- Created attachment 139974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139974&action=edit Bug 30661: [FOLLOW-UP] add separate endpoints This patch adds separate endpoints for updating hold_date and expiration_date. Test plan: 1) prove t/db_dependent/api/v1/holds.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:17:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:17:04 +0000 Subject: [Koha-bugs] [Bug 30661] Able to update more hold parameters via REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30661 Johanna Räisä changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:17:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:17:11 +0000 Subject: [Koha-bugs] [Bug 31141] We can remove 'select_column' from waiting_holds.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31141 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Status|Pushed to stable |Pushed to oldstable Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 --- Comment #10 from Arthur Suzuki --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:18:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:18:00 +0000 Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.04, |22.11.00, 22.05.04, released in|21.05.18 |21.11.12, 21.05.18 --- Comment #56 from Arthur Suzuki --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:18:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:18:31 +0000 Subject: [Koha-bugs] [Bug 31145] Add some defaults for acquisitions in TestBuilder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 CC| |arthur.suzuki at biblibre.com Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Arthur Suzuki --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:18:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:18:57 +0000 Subject: [Koha-bugs] [Bug 31139] basic_workflow.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31139 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Arthur Suzuki --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:19:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:19:27 +0000 Subject: [Koha-bugs] [Bug 31129] Number of restrictions is always "0" on the "Check out" tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31129 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 CC| |arthur.suzuki at biblibre.com Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Arthur Suzuki --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:19:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:19:59 +0000 Subject: [Koha-bugs] [Bug 31137] Error editing label template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31137 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 CC| |arthur.suzuki at biblibre.com --- Comment #9 from Arthur Suzuki --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:20:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:20:26 +0000 Subject: [Koha-bugs] [Bug 31036] Cash management doesn't take SIP00 (Cash via SIP2) transactions into account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31036 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |arthur.suzuki at biblibre.com Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 --- Comment #14 from Arthur Suzuki --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:20:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:20:54 +0000 Subject: [Koha-bugs] [Bug 14680] When creating orders from a staged file discounts supplied in the form are added In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 CC| |arthur.suzuki at biblibre.com --- Comment #15 from Arthur Suzuki --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:21:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:21:21 +0000 Subject: [Koha-bugs] [Bug 30882] Add max_result_window to index config In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30882 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 CC| |arthur.suzuki at biblibre.com --- Comment #17 from Arthur Suzuki --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:21:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:21:48 +0000 Subject: [Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items responses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |arthur.suzuki at biblibre.com Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 --- Comment #20 from Arthur Suzuki --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:23:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:23:08 +0000 Subject: [Koha-bugs] [Bug 31144] When modifying an order we should not load the vendor default discount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31144 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 Status|Pushed to stable |Pushed to oldstable CC| |arthur.suzuki at biblibre.com --- Comment #7 from Arthur Suzuki --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:23:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:23:37 +0000 Subject: [Koha-bugs] [Bug 20439] SMS provider sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20439 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |arthur.suzuki at biblibre.com Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 --- Comment #13 from Arthur Suzuki --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:24:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:24:06 +0000 Subject: [Koha-bugs] [Bug 27667] Display the number of non-indexed records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27667 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 Status|Pushed to stable |Pushed to oldstable --- Comment #15 from Arthur Suzuki --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:24:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:24:34 +0000 Subject: [Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Status|Pushed to stable |Pushed to oldstable Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 --- Comment #29 from Arthur Suzuki --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:25:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:25:20 +0000 Subject: [Koha-bugs] [Bug 31163] Sort cashup history so that newest entries are first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31163 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |arthur.suzuki at biblibre.com Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 --- Comment #7 from Arthur Suzuki --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:25:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:25:50 +0000 Subject: [Koha-bugs] [Bug 29922] Group of libraries are now displayed in alphabetical order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 CC| |arthur.suzuki at biblibre.com Status|Pushed to stable |Pushed to oldstable --- Comment #26 from Arthur Suzuki --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:26:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:26:17 +0000 Subject: [Koha-bugs] [Bug 30447] pendingreserves.pl is checking too many transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30447 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 CC| |arthur.suzuki at biblibre.com Status|Pushed to stable |Pushed to oldstable --- Comment #19 from Arthur Suzuki --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:27:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:27:46 +0000 Subject: [Koha-bugs] [Bug 27683] Bind results of GetAnalyticsCount to the EasyAnalyticalRecords pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Status|Pushed to stable |Pushed to oldstable Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 --- Comment #18 from Arthur Suzuki --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:28:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:28:15 +0000 Subject: [Koha-bugs] [Bug 30935] Holds to pull shows wrong first patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30935 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 CC| |arthur.suzuki at biblibre.com Status|Pushed to stable |Pushed to oldstable --- Comment #11 from Arthur Suzuki --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:28:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:28:45 +0000 Subject: [Koha-bugs] [Bug 31020] PassItemMarcToXSLT only applies on results pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 CC| |arthur.suzuki at biblibre.com Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Arthur Suzuki --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:29:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:29:07 +0000 Subject: [Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set when creating a child patron from the adult In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 CC| |arthur.suzuki at biblibre.com --- Comment #19 from Arthur Suzuki --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:29:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:29:37 +0000 Subject: [Koha-bugs] [Bug 30268] When creating an order from a staged file, mandatory item subfields that are empty do not block form submission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30268 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |arthur.suzuki at biblibre.com Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 --- Comment #7 from Arthur Suzuki --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:30:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:30:20 +0000 Subject: [Koha-bugs] [Bug 27045] Exports using CSV profiles with tab as separator don't work correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 CC| |arthur.suzuki at biblibre.com Status|Pushed to stable |Pushed to oldstable --- Comment #24 from Arthur Suzuki --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:30:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:30:49 +0000 Subject: [Koha-bugs] [Bug 31186] Search result numbering in OPAC got suppressed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31186 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 Status|Pushed to stable |Pushed to oldstable CC| |arthur.suzuki at biblibre.com --- Comment #7 from Arthur Suzuki --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:31:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:31:33 +0000 Subject: [Koha-bugs] [Bug 30658] (Bug 29496 follow-up) CheckMandatorySubfields don't work properly with select field in serials-edit.tt for Supplemental issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30658 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 CC| |arthur.suzuki at biblibre.com Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Arthur Suzuki --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 11:59:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 09:59:45 +0000 Subject: [Koha-bugs] [Bug 31487] Add emails to message queue by longoverdue script options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31487 --- Comment #1 from Thibaud Guillot --- Created attachment 139975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139975&action=edit Bug 24857: No words Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 12:00:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 10:00:38 +0000 Subject: [Koha-bugs] [Bug 31487] Add emails to message queue by longoverdue script options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31487 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139975|0 |1 is obsolete| | Attachment #139975|1 |0 is patch| | --- Comment #2 from Thibaud Guillot --- Comment on attachment 139975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139975 Bug 24857: No words >From 31ab4940449cec56bdb164e34c140b2f80c4c36a Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi >Date: Tue, 9 Aug 2022 14:00:40 -0300 >Subject: [PATCH] Bug 24857: No words > >Signed-off-by: Tomas Cohen Arazi > >https://bugs.koha-community.org/show_bug.cgi?id=31487 >--- > api/v1/swagger/swagger.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/api/v1/swagger/swagger.yaml b/api/v1/swagger/swagger.yaml >index b152a6f7df..597af62166 100644 >--- a/api/v1/swagger/swagger.yaml >+++ b/api/v1/swagger/swagger.yaml >@@ -584,7 +584,7 @@ tags: > - description: "Manage import batches\n" > name: import_batches > x-display-name: Import batches >- - description: "Manate item groups\n" >+ - description: "Manage item groups\n" > name: item_groups > x-displayName: Item groups > - description: "Manage items\n" >-- >2.25.1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 12:01:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 10:01:53 +0000 Subject: [Koha-bugs] [Bug 31487] Add emails to message queue by longoverdue script options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31487 --- Comment #3 from Thibaud Guillot --- Created attachment 139976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139976&action=edit Bug 31487: Add an option to send by mail longoverdue items to borrowers Test plan: 1) You must have longoverdue items to one or many borrowers 2) You must create a notice template (Notices & slips section) 3) You can run the script misc/cronjobs/longoverdue.pl manually without --mail option first (see -h or --help for more info about the script) 4) You must see an output with some longoverdues (step 1 required) 5) Now you can run the script with --mail option but like its specify in "help" option you must add option --code="" (relative to your code template) and --branchcode="". 6) Normally you will see after the classic output a new block with emails added to the message queue and it will be sent on the next misc/cronjobs/process_message_queue.pl script iteration -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 12:09:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 10:09:00 +0000 Subject: [Koha-bugs] [Bug 31487] Add emails to message queue by longoverdue script options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31487 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139976|0 |1 is obsolete| | --- Comment #4 from Thibaud Guillot --- Created attachment 139977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139977&action=edit Bug 31487: Add an option to send by mail longoverdue items to borrowers Test plan: 1) You must have longoverdue items to one or many borrowers 2) You must create a notice template (Notices & slips section) 3) You can run the script misc/cronjobs/longoverdue.pl manually without --mail option first (see -h or --help for more info about the script) 4) You must see an output with some longoverdues (step 1 required) 5) Now you can run the script with --mail option but like its specify in "help" option you must add option --code="" (relative to your code template) and --branchcode="". 6) Normally you will see after the classic output a new block with emails added to the message queue and it will be sent on the next misc/cronjobs/process_message_queue.pl script iteration -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 12:11:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 10:11:23 +0000 Subject: [Koha-bugs] [Bug 31487] Add emails to message queue by longoverdue script options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31487 --- Comment #5 from Thibaud Guillot --- (In reply to Thibaud Guillot from comment #1) > Created attachment 139975 [details] > Bug 24857: No words > > Signed-off-by: Tomas Cohen Arazi Sorry for this mistake I missed my attachment -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 12:27:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 10:27:16 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 12:27:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 10:27:20 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136213|0 |1 is obsolete| | Attachment #136214|0 |1 is obsolete| | Attachment #136263|0 |1 is obsolete| | --- Comment #23 from Thibaud Guillot --- Created attachment 139978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139978&action=edit Bug 18064: (follow-up) Remove statement for summary & reorder sysprefs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 12:27:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 10:27:49 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130363|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 12:28:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 10:28:35 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130363|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 12:28:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 10:28:50 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135888|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 12:29:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 10:29:07 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136213|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 12:29:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 10:29:16 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136214|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 12:29:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 10:29:51 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135888|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 12:30:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 10:30:13 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136263|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 12:33:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 10:33:13 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 --- Comment #24 from Thibaud Guillot --- (In reply to Kyle M Hall from comment #21) > Comment on attachment 136213 [details] [review] > Bug 18064 : Add syspref to launch longOverdue script with calendar support > > Review of attachment 136213 [details] [review]: > ----------------------------------------------------------------- > > ::: misc/cronjobs/longoverdue.pl > @@ +492,4 @@ > > } > > } > > > > +if (!( C4::Context->preference( 'LongOverdueNoticeCalendar' ) )) { > > Why is this here? I don't understand the utility of suppressing the summary > if using the calendar. Yes you're right. I worked on this script again recently and realized that I had misunderstood this part. We need this output to get the summary, it's my mistake. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 12:35:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 10:35:21 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 --- Comment #25 from Thibaud Guillot --- If you are interested in this script, I have also opened a BZ (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31487) which can be useful if someone can give me their opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 12:58:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 10:58:50 +0000 Subject: [Koha-bugs] [Bug 31483] Minor UI problem in opac-reset-password.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 12:58:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 10:58:55 +0000 Subject: [Koha-bugs] [Bug 31483] Minor UI problem in opac-reset-password.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139970|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 139979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139979&action=edit Bug 31483: Correct tiny HTML error on password reset page To test: 1) Enable EnableExpiredPasswordReset 2) Find a patron and change their password so you know what it is supposed to be 3) In the database, expire the patron's password, e.g. UPDATE borrowers SET password_expiration_date = '2022-08-22' where borrowernumber = 21; 4) Go to the OPAC, try to log in with the patron's credentials 5) Click Reset your password => Note that the form is in the grey breadcrumbs box, you can compare with any other OPAC page, the grey box should only contain the breadcrumbs 6) Apply patch 7) Try steps 4-5 again. The gray breadcrumbs box should be for breadcrumbs only! Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 13:29:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 11:29:04 +0000 Subject: [Koha-bugs] [Bug 31488] New: "You have checked out too many items" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31488 Bug ID: 31488 Summary: "You have checked out too many items" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org This is a tiny, tiny thing, but still... koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt line 64 says: You have checked out too many items and can't check out any more. This makes it sound like the patron has done something wrong, and checked out *too many* items. But they probably just have the maximum number of items/loans, right? So we should not be accusing people of doing something wrong, when they are just being very active patrons. :-) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 13:29:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 11:29:44 +0000 Subject: [Koha-bugs] [Bug 31488] "You have checked out too many items" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31488 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 16:38:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 14:38:06 +0000 Subject: [Koha-bugs] [Bug 31478] Standardize upload/download icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31478 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 17:45:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 15:45:21 +0000 Subject: [Koha-bugs] [Bug 29926] Add ability for superlibrarians to edit password expiration dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29926 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/585 CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 17:48:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 15:48:59 +0000 Subject: [Koha-bugs] [Bug 31428] Shorten new button text "Configure this table" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31428 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 17:49:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 15:49:02 +0000 Subject: [Koha-bugs] [Bug 31428] Shorten new button text "Configure this table" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31428 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139569|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 139980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139980&action=edit Bug 31428: 'Configure this table' -> 'Configure' I agree, the shorter wording should be used. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 18:07:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 16:07:56 +0000 Subject: [Koha-bugs] [Bug 31489] New: Typo in EnableExpiredPasswordReset description Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31489 Bug ID: 31489 Summary: Typo in EnableExpiredPasswordReset description Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com This was noticed in Bug 29925 (comment 4 by Andrew) but it was pushed as is. The second sentence of the EnableExpiredPasswordReset system preference description is currently: If not enable patrons must either use the 'Forgot your password' feature or have staff reset their password. It should be: If not **enabled** patrons must either use the 'Forgot your password' feature or have staff reset their password. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 18:11:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 16:11:24 +0000 Subject: [Koha-bugs] [Bug 31489] Typo in EnableExpiredPasswordReset description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31489 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 18:11:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 16:11:29 +0000 Subject: [Koha-bugs] [Bug 31489] Typo in EnableExpiredPasswordReset description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31489 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 139981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139981&action=edit Bug 31489: Typo in EnableExpiredPasswordReset description This patch corrects a typo in the EnableExpiredPasswordReset system preference description. To test: 1) Apply patch 2) Go to Administration > Global system preferences 3) Search for EnableExpiredPasswordReset 4) Read the description and make sure there are no errors. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 18:11:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 16:11:52 +0000 Subject: [Koha-bugs] [Bug 31428] Shorten new button text "Configure this table" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31428 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 18:12:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 16:12:09 +0000 Subject: [Koha-bugs] [Bug 31489] Typo in EnableExpiredPasswordReset description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31489 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29925 Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29925 [Bug 29925] Add a 'set new password' page for patron's with expired passwords -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 18:12:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 16:12:09 +0000 Subject: [Koha-bugs] [Bug 29925] Add a 'set new password' page for patron's with expired passwords In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29925 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31489 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31489 [Bug 31489] Typo in EnableExpiredPasswordReset description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 18:33:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 16:33:02 +0000 Subject: [Koha-bugs] [Bug 31489] Typo in EnableExpiredPasswordReset description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31489 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 18:33:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 16:33:06 +0000 Subject: [Koha-bugs] [Bug 31489] Typo in EnableExpiredPasswordReset description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31489 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139981|0 |1 is obsolete| | --- Comment #2 from Joonas Kylmälä --- Created attachment 139982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139982&action=edit Bug 31489: Typo in EnableExpiredPasswordReset description This patch corrects a typo in the EnableExpiredPasswordReset system preference description. To test: 1) Apply patch 2) Go to Administration > Global system preferences 3) Search for EnableExpiredPasswordReset 4) Read the description and make sure there are no errors. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 18:33:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 16:33:35 +0000 Subject: [Koha-bugs] [Bug 31489] Typo in EnableExpiredPasswordReset description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31489 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi |y.org | Status|Signed Off |Passed QA --- Comment #3 from Joonas Kylmälä --- Trivial, straight to PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 18:38:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 16:38:25 +0000 Subject: [Koha-bugs] [Bug 31483] Minor UI problem in opac-reset-password.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |joonas.kylmala at iki.fi --- Comment #3 from Joonas Kylmälä --- Please close the ol tag explicitly with . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 18:47:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 16:47:15 +0000 Subject: [Koha-bugs] [Bug 25426] Allow return policy to be selected via syspref and not just home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25426 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi --- Comment #9 from Joonas Kylmälä --- Are all three options needed for the new syspref or just some of them? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 18:58:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 16:58:31 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Manual | CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #451 from Caroline Cyr La Rose --- I'm not comfortable enough with gitlab to change the merge request to a merge request to the community manual. Right now it is from David's own project to David's own project. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 18:59:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 16:59:15 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #452 from Caroline Cyr La Rose --- Ignore my comment! I saw that it was already merged sorry! I removed the Manual keyword. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 19:00:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 17:00:48 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139615|0 |1 is obsolete| | --- Comment #64 from ByWater Sandboxes --- Created attachment 139983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139983&action=edit Bug 10950: Database update Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 19:00:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 17:00:53 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139616|0 |1 is obsolete| | --- Comment #65 from ByWater Sandboxes --- Created attachment 139984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139984&action=edit Bug 10950: Schema update Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 19:00:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 17:00:57 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139617|0 |1 is obsolete| | --- Comment #66 from ByWater Sandboxes --- Created attachment 139985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139985&action=edit Bug 10950: Add intranet/OPAC form fields Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 19:01:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 17:01:01 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139618|0 |1 is obsolete| | --- Comment #67 from ByWater Sandboxes --- Created attachment 139986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139986&action=edit Bug 10950: Display pronouns field Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 19:01:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 17:01:06 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139619|0 |1 is obsolete| | --- Comment #68 from ByWater Sandboxes --- Created attachment 139987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139987&action=edit Bug 10950: API spec update Test plan: 1. Apply patch, restart_all, and updatedatabase 2. In the staff client go to a patron record or create a new patron. 3. Notice the pronouns field, make sure you add a value to it. 4. Now notice that the value should display in parentheses in places where the patron name is displayed. 5. Go to the details page and you should see the value display in quotes. ( next to othernames ) 6. Check to make sure you can hide the pronouns field via BorrowerUnwantedField. 7. Check to make sure you can make the field required with BorrowerMandatoryField 8. Go to the OPAC to self register. The pronouns field should appear in the form. 9. Make sure you can make it required ( PatronSelfRegistrationBorrowerMandatoryField ) and that you can hide it ( PatronSelfRegistrationBorrowerUnwantedField ). 10. Once registered check 'your personal details'. Check that the field can be required (PatronSelfModificationMandatoryField) or hidden ( PatronSelfModificationBorrowerUnwantedField ). 11. Try some notices like ISSUESLIP. You should be able to add either <> or [% borrower.pronoun %] to the notice and have it display when you generate the notice. Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 19:01:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 17:01:11 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139620|0 |1 is obsolete| | --- Comment #69 from ByWater Sandboxes --- Created attachment 139988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139988&action=edit Bug 10950: (follow-up) fix typo in kohastructure.sql Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 19:01:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 17:01:16 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139621|0 |1 is obsolete| | --- Comment #70 from ByWater Sandboxes --- Created attachment 139989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139989&action=edit Bug 10950: (QA follow-up) Exec Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 19:01:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 17:01:21 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139908|0 |1 is obsolete| | --- Comment #71 from ByWater Sandboxes --- Created attachment 139990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139990&action=edit Bug 10950: (QA follow-up) Fix typo in hidden check in OPAC patron form definded => defined Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 19:01:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 17:01:26 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139968|0 |1 is obsolete| | --- Comment #72 from ByWater Sandboxes --- Created attachment 139991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139991&action=edit Bug 10950: (follow-up) Change display of pronoun fields Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 19:01:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 17:01:51 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 19:25:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 17:25:14 +0000 Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Felicity Brown changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |felicity.brown at montgomeryco | |untymd.gov --- Comment #51 from Felicity Brown --- Does this apply to setting a status to "missing" as well as lost? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 19:32:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 17:32:58 +0000 Subject: [Koha-bugs] [Bug 30661] Able to update more hold parameters via REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30661 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi --- Comment #3 from Joonas Kylmälä --- Is it right to allow changing the reservedate after it has been set as you cannot do that now either through staff or opac as far as I know? Did you intend to use this to change the reservedate for a hold with reservedate in the future? Other than that I cannot think of any use case for this. We would have to probably add some checks to make sure the API user is only able to edit reservedate in the future, not one that has already passed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 20:17:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 18:17:32 +0000 Subject: [Koha-bugs] [Bug 31482] Label creator does not call item_barcode_transform plugin hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi --- Comment #3 from Joonas Kylmälä --- Shouldn't this actually be a call to C4::Circulation::barcodedecode ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 21:01:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 19:01:07 +0000 Subject: [Koha-bugs] [Bug 31490] New: Terminology: change "staff client" to "staff interface" in marc-overlay-rules Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31490 Bug ID: 31490 Summary: Terminology: change "staff client" to "staff interface" in marc-overlay-rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When setting overlay rules in administration, one source option is "staff client MARC editor". The terminology guide indicates we should use "staff interface" https://wiki.koha-community.org/wiki/Terminology#S To test: 1) Enable the MARCOverlayRules system preference 2) Go to Administration > Record overlay rules 3) Open the "Filter" drop-down menu => Note that the second option is "Staff client MARC editor" This should be changed to "Staff interface MARC editor" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 21:12:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 19:12:14 +0000 Subject: [Koha-bugs] [Bug 31490] Terminology: change "staff client" to "staff interface" in marc-overlay-rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31490 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 21:12:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 19:12:17 +0000 Subject: [Koha-bugs] [Bug 31490] Terminology: change "staff client" to "staff interface" in marc-overlay-rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31490 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 139992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139992&action=edit Bug 31490: Terminology: change 'staff client' to 'staff interface' in marc-overlay-rule This patch corrects the terminology for staff interface in the record overlay rules administration page. To test: 1) Apply patch 2) Enable the MARCOverlayRules system preference 3) Go to Administration > Record overlay rules 4) Open the 'Filter' drop-down menu => The second option should read 'Staff interface MARC editor' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 21:40:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 19:40:46 +0000 Subject: [Koha-bugs] [Bug 3935] Schedule tasks periodically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3935 Noémie Labine changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |noemie.labine at collecto.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 21:42:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 19:42:00 +0000 Subject: [Koha-bugs] [Bug 3935] Schedule tasks periodically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3935 Maude changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maude.boudreau at collecto.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 21:49:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 19:49:20 +0000 Subject: [Koha-bugs] [Bug 29777] Fields 580 are wrong displayed in summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29777 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi --- Comment #8 from Joonas Kylmälä --- The proposed change doesn't make sense for me, could you explain why it might fix this issue? I'm unable to reproduce on master, the bug report is for 20.11 though, do you have the issue with master as well? Also do you use Zebra or Elasticsearch? I used Zebra when trying to reproduce. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 23:30:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 21:30:33 +0000 Subject: [Koha-bugs] [Bug 31483] Minor UI problem in opac-reset-password.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 30 23:30:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 21:30:37 +0000 Subject: [Koha-bugs] [Bug 31483] Minor UI problem in opac-reset-password.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139979|0 |1 is obsolete| | --- Comment #4 from Lucas Gass --- Created attachment 139993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139993&action=edit Bug 31483: Fix breadcrumbs on password reset page To test: 1) Enable EnableExpiredPasswordReset 2) Find a patron and change their password so you know what it is supposed to be 3) In the database, expire the patron's password, e.g. UPDATE borrowers SET password_expiration_date = '2022-08-22' where borrowernumber = 21; 4) Go to the OPAC, try to log in with the patron's credentials 5) Click Reset your password => Note that the form is in the grey breadcrumbs box, you can compare with any other OPAC page, the grey box should only contain the breadcrumbs 6) Apply patch 7) Try steps 4-5 again. The gray breadcrumbs box should be for breadcrumbs only! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 00:33:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 22:33:19 +0000 Subject: [Koha-bugs] [Bug 30958] OPAC Overdrive search result page broken for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30958 --- Comment #14 from Alex Buckley --- (In reply to Victor Grousset/tuxayo from comment #13) > Backported: Pushed to 21.05.x branch for 21.05.18 Thanks Victor! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 00:42:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 22:42:48 +0000 Subject: [Koha-bugs] [Bug 31464] Coce images don't always load in Firefox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31464 --- Comment #3 from Alex Buckley --- Could bug 31034 be a possible duplicate of this bug report? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 00:43:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 22:43:18 +0000 Subject: [Koha-bugs] [Bug 31034] Cover images hidden in some browsers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31034 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31464 CC| |alexbuckley at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 00:43:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 22:43:18 +0000 Subject: [Koha-bugs] [Bug 31464] Coce images don't always load in Firefox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31464 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31034 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 01:19:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Aug 2022 23:19:14 +0000 Subject: [Koha-bugs] [Bug 31020] PassItemMarcToXSLT only applies on results pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 02:24:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 00:24:25 +0000 Subject: [Koha-bugs] [Bug 31491] New: C4::Service scripts should be replaced with REST API Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31491 Bug ID: 31491 Summary: C4::Service scripts should be replaced with REST API Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Here's a list of some users of C4::Service: members/default_messageprefs.pl opac/sco/sco-patron-image.pl opac/svc/checkout_notes svc/localization svc/problem_reports svc/cataloguing/control_num_sequences svc/cataloguing/framework svc/cataloguing/metasearch svc/config/systempreferences svc/letters/get svc/checkout_notes svc/authorised_values svc/creator_batches svc/split_callnumbers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 04:13:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 02:13:29 +0000 Subject: [Koha-bugs] [Bug 26692] Add barcode image generator service for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #36 from David Cook --- Created attachment 139994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139994&action=edit Koha plugin proof-of-concept This is still just a proof-of-concept but here is some sample code for OPACUserJS: $(document).ready(function(){ let opac_user_views = $("body#opac-user div#opac-user-views"); if (opac_user_views.length > 0 ){ let borrowernumber = window.borrowernumber; let url = `${location.origin}/api/v1/contrib/opac_account_barcode/public/patrons/${borrowernumber}/account_barcode/Code39`; $.ajax({ type: 'HEAD', url: url, success: function(data,status,xhr){ opac_user_views.append(`

    Your barcode

    `); } }); } }); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 04:19:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 02:19:10 +0000 Subject: [Koha-bugs] [Bug 26692] Add barcode image generator service for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #37 from David Cook --- Note that you can use any GD::Barcode supported barcode format by changing that last path parameter. And if you use something that doesn't exist like /api/v1/contrib/opac_account_barcode/public/patrons/57/account_barcode/foo, you'll get this error message: {"errors":[{"message":"Not in enum list: COOP2of5, Code39, EAN13, EAN8, IATA2of5, ITF, Industrial2of5, Matrix2of5, NW7, QRcode, UPCA, UPCE.","path":"\/barcode_type"}],"status":400} So that's cool. -- Other things to note... you can only get your own barcode. You must be authenticated and you are only authorised to query based on your own patron_id (which is available via Javascript in the OPAC). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 04:21:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 02:21:26 +0000 Subject: [Koha-bugs] [Bug 26692] Add barcode image generator service for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #38 from David Cook --- I have a library that is planning to replace physical borrower cards with this barcode that can be scanned from the user's phone, when they log into their Koha OPAC account on their phone. We haven't gone live yet, but I'm sure that experience will teach me more about anything missing here. If it goes well and no one disagrees, we could move the sample OPACUserJS code into the plugin itself (or add plugin hooks for displaying content in the OPAC account pages or whatever). -- Curious to hear what you think, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 04:36:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 02:36:19 +0000 Subject: [Koha-bugs] [Bug 26692] Add barcode image generator service for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #39 from David Cook --- It would be cool to do an Etag header using a MD5 hash of the image bytes, but the images are so small that it's probably not worth it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 05:33:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 03:33:33 +0000 Subject: [Koha-bugs] [Bug 31492] New: Patron image upload fails on first attempt with CSRF failure Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31492 Bug ID: 31492 Summary: Patron image upload fails on first attempt with CSRF failure Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: matthew.lindfield-seager at hope.edu.kh QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com After upgrading to 22.05.004 (and after manually installing `libmojolicious-plugin-openapi-perl` to get patron search to work - as per https://www.mail-archive.com/koha at lists.katipo.co.nz/msg28885.html) we are now seeing an issue uploading patron images. After logging in to Koha, the first attempt to upload an individual patron image (from the patron show screen) fails with a CSRF error: > The form submission failed (Wrong CSRF token). Try to come back, refresh the page, then try again. Second and subsequent attempts succeed up until we log out and log back in again. After that the first submission once again fails. I tailed the logs to see if I could see any errors using `tail -f /var/log/koha/library/*.log`. On one occasion I saw an error related to `picture_upload.pl` in `/var/log/koha/library/intranet-error.log` but I can't reproduce it. In case it's relevant the error I saw once was: > [Wed Aug 31 09:55:06.665314 2022] [cgi:error] [pid 288501] [client 136.228.129.94:64313] AH01215: Use of uninitialized value $cardnumber in concatenation (.) or string at /usr/share/koha/intranet/cgi-bin/tools/picture-upload.pl line 66.: /usr/share/koha/intranet/cgi-bin/tools/picture-upload.pl, referer: https:///cgi-bin/koha/circ/circulation.pl?borrowernumber=1790 The CSRF error in the client is reproducible in up-to-date versions of Chrome on Windows and Safari on macOS so it doesn't seem to be browser or OS specific. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 08:25:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 06:25:22 +0000 Subject: [Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 --- Comment #16 from Nick Clemens --- (In reply to David Cook from comment #15) > (In reply to Katrin Fischer from comment #7) > > Could we treat it ' as a space and 'no space' at the same time maybe? > Without language-specific analysis, this might be the best way to go... That's sort of what the POC does, but just for "as apostrophe" "as no space" - we could add a third field for converting apostrophes to spaces > > (In reply to Nick Clemens from comment #13) > > Created attachment 139969 [details] [review] [review] > > Bug 27153: POC > I'm not very familiar with the Elasticsearch integration, but that POC > doesn't touch the indexing, does it? It does, it adds an extra field, with a punctuation filter to the indexes for 'default' fields - that filter removes all ASCII punctuation characters > Isn't it just modifying the search? It then adds that field to the fields being searched in a 'keyword' search > If you searched "carries war" but it had been indexed as "carrie s war", > then you still wouldn't get a hit? Not with this one, but "carrie's war" or "carries war" would work The nice thing is, adding an extra index means we can generically search all versions of the field, but can also target specific ones: title.punc_removed: carries title.raw: carrie's So staff can be specific, while making standard search more friendly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 09:40:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 07:40:30 +0000 Subject: [Koha-bugs] [Bug 30209] Upgrade 'libdbd-sqlite2-perl' package to 'libdbd-sqlite3-perl' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30209 --- Comment #13 from Mason James --- (In reply to Victor Grousset/tuxayo from comment #12) > (In reply to Mason James from comment #10) > > hi tuxayo, any chance we can get this patch added to 21.05? > > What about 21.11? ok, lets do 21.11 too :0) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 09:41:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 07:41:27 +0000 Subject: [Koha-bugs] [Bug 30209] Upgrade 'libdbd-sqlite2-perl' package to 'libdbd-sqlite3-perl' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30209 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 09:54:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 07:54:17 +0000 Subject: [Koha-bugs] [Bug 29882] Remove unrequired package definitions in list-deps script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 --- Comment #5 from Mason James --- (In reply to David Cook from comment #4) > I take it that this is due to these deps being picked up out of the cpanfile? yes correct, both modules are referenced the cpanfile requires 'Mojolicious', '8.12'; requires 'Mojolicious::Plugin::OpenAPI', '2.16'; ps: swagger2 has been renamed to openapi :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 10:33:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 08:33:16 +0000 Subject: [Koha-bugs] [Bug 31493] New: Circulation.t fails if "RenewalPeriodBase" is set as "the current date" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31493 Bug ID: 31493 Summary: Circulation.t fails if "RenewalPeriodBase" is set as "the current date" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: emmi.takkinen at koha-suomi.fi QA Contact: testopia at bugs.koha-community.org Like in bug 26405 Circulation.t fails on the following error: t/db_dependent/Circulation.t .. 15/63 # Failed test 'AddRenewal left both fines' # at t/db_dependent/Circulation.t line 770. # got: '1' # expected: '2' # Looks like you planned 105 tests but ran 30. # Looks like you failed 1 test of 30 run. t/db_dependent/Circulation.t .. 17/63 # Failed test 'CanBookBeRenewed tests' # at t/db_dependent/Circulation.t line 1538. Can't call method "status" on an undefined value at t/db_dependent/Circulation.t line 772. Apparently this is happens when syspref "RenewalPeriodBase" is set as "the current date". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 11:05:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 09:05:25 +0000 Subject: [Koha-bugs] [Bug 31494] New: ILL breadcrumb improvement for ILL View action Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31494 Bug ID: 31494 Summary: ILL breadcrumb improvement for ILL View action Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com The breadcrumb when viewing an ILL request details stops at 'ILL Requests' and isn't linked. It should contain the 'ILL Requests' item linked and have a further item 'View request' or similar as the end point. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 11:05:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 09:05:31 +0000 Subject: [Koha-bugs] [Bug 31494] ILL breadcrumb improvement for ILL View action In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31494 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 11:17:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 09:17:59 +0000 Subject: [Koha-bugs] [Bug 31493] Circulation.t fails if "RenewalPeriodBase" is set as "the current date" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31493 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|chris at bigballofwax.co.nz |emmi.takkinen at koha-suomi.fi --- Comment #1 from Emmi Takkinen --- Created attachment 139995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139995&action=edit Bug 31493: Prevent Circulation.t failing on "AddRenewal left both fines" If one has syspref "RenewalPeriodBase" set as "the current date" Circulation.t tests fail on "AddRenewal left both fines". This causes one of the test fines to be dropped/charged. Mocking syspref "RenewalPeriodBase" as "the old due date of the checkout" solves the issue. To test: 1. Have syspref "RenewalPeriodBase" set as "the current date". 2. Run prove t/db_dependent/Circulation.t. => Tests fail. 3. Apply patch. 4. Run tests again. => Tests pass. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 11:22:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 09:22:07 +0000 Subject: [Koha-bugs] [Bug 31494] ILL breadcrumb improvement for ILL View action In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31494 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize at ptfs-europe |isobel.graham09 at gmail.com |.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 11:31:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 09:31:34 +0000 Subject: [Koha-bugs] [Bug 31463] (Bug 31313 follow-up) Show item order status on opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31463 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 11:31:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 09:31:38 +0000 Subject: [Koha-bugs] [Bug 31463] (Bug 31313 follow-up) Show item order status on opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31463 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139796|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 139996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139996&action=edit Bug 31463: Add order status to opac-detail.pl This adds a check for the preference OPACAcquisitionDetails and fetches the active orders for the item if necessary Additionally, we simply the check for biblio orders to use object methods and remove code that stored order information in the item_info To test: 1 - Enable preference: OPACAcquisitionDetails 2 - Create a basket with items created on order, add an order for a biblio, close the basket 3 - Create a second basket as above, add an order with multiple copies, leave basket open 4 - View biblio on opac 5 - You should see 1 item marked on order, and "1 items on order" below items table 6 - Close second basket 7 - Reload opac view, now 3 on order and in message 8 - Reopen first basket 9 - Reload opac view, now 2 on order and in message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 11:33:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 09:33:02 +0000 Subject: [Koha-bugs] [Bug 26692] Add barcode image generator service for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #40 from Kyle M Hall --- (In reply to David Cook from comment #38) > I have a library that is planning to replace physical borrower cards with > this barcode that can be scanned from the user's phone, when they log into > their Koha OPAC account on their phone. > > We haven't gone live yet, but I'm sure that experience will teach me more > about anything missing here. > > If it goes well and no one disagrees, we could move the sample OPACUserJS > code into the plugin itself (or add plugin hooks for displaying content in > the OPAC account pages or whatever). > > -- > > Curious to hear what you think, Kyle! Looks great! I can see pros and cons to to having the javascript in the opacjs method of the plugin. One one hand, it makes for a drop-in easy to use plugin for librarians. On the other hand, it does "limit" how it can be displayed if a library wants something different. I honestly think either choice is good. You can always put the javascript in the the documentation. Do you have this in a public repo yet? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 11:36:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 09:36:58 +0000 Subject: [Koha-bugs] [Bug 31482] Label creator does not call item_barcode_transform plugin hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482 --- Comment #4 from Kyle M Hall --- (In reply to Joonas Kylmälä from comment #3) > Shouldn't this actually be a call to C4::Circulation::barcodedecode ? Good thinking! I'll post an updated patch asap. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 11:39:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 09:39:13 +0000 Subject: [Koha-bugs] [Bug 31482] Label creator does not call item_barcode_transform plugin hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139946|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 139997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139997&action=edit Bug 31482: Label creator does not call item_barcode_transform plugin hook The label creator can accept a list of either itemnumbers or item barcodes. In the case that the list of composed of barcodes, those barcodes should be passed though the item_barcode_transform plugin hook before the lookup is performed. Test Plan: 1) Apply this patch 2) Download and install the Barcode Transformer plugin https://github.com/bywatersolutions/koha-plugin-barcode-transformer/releases/ 3) Go to the plugin configuration page, set the configuration to the example configuration from the same page 4) On the "New label batch" page of the Label creator,, type in some valid barcodes, but prefix them with X and postfix them with Y, e.g. X123456Y 5) Submit the form 6) Note the items are added to the label batch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 11:42:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 09:42:23 +0000 Subject: [Koha-bugs] [Bug 25426] Allow return policy to be selected via syspref and not just home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25426 --- Comment #10 from Kyle M Hall --- (In reply to Joonas Kylmälä from comment #9) > Are all three options needed for the new syspref or just some of them? I believe all three options are good and necessary for librarians to be able to set their circ returns rules as they would like them to behave. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 12:08:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 10:08:54 +0000 Subject: [Koha-bugs] [Bug 27136] Add languages and avoid displaying nothing in facet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 12:09:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 10:09:22 +0000 Subject: [Koha-bugs] [Bug 27136] Add languages and avoid displaying nothing in facet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 --- Comment #8 from Nick Clemens --- Created attachment 139998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139998&action=edit Bug 27136: Add additional languages for facet display This patch adds two missing languages, Cree & Afrikaans, as well as some necessary linguistic definitions for faceting: Multi language, undetermined, no linguistic content Signed-off-by: Alexis Ripetti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 12:09:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 10:09:43 +0000 Subject: [Koha-bugs] [Bug 27136] Add languages and avoid displaying nothing in facet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 --- Comment #9 from Nick Clemens --- Created attachment 139999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139999&action=edit Bug 27136: Avoid displaying nothing in facet This patch displays 'No information provided' if a facet value/description cannot be found, rather than displaying an empty/hidden facet Signed-off-by: Alexis Ripetti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 12:40:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 10:40:57 +0000 Subject: [Koha-bugs] [Bug 25267] OPAC browse shelf feature is not responsive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25267 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud at orex.es --- Comment #8 from Hugo Agud --- I have installed into sandbox and I get this error when I try to browse (itemcallnumber is filled with value 302) https://staff-orex25267.sandbox.bywatersolutions.com/ Can't call method "itemnumber" on unblessed reference at /kohadevbox/koha/opac/opac-detail.pl line 1099 in (eval) at /kohadevbox/koha/opac/opac-detail.pl line 1099 1096: ); 1097: 1098: # in which tab shelf browser should open ? 1099: if (grep { $starting_itemnumber == $_->itemnumber } @itemloop) { 1100: $template->param(shelfbrowser_tab => 'holdings'); 1101: } else { 1102: $template->param(shelfbrowser_tab => 'otherholdings'); in CGI::Compile::ROOT::kohadevbox_koha_opac_opac_2ddetail_2epl::__ANON__ at /kohadevbox/koha/opac/opac-detail.pl line 2 1: #!/usr/bin/perl 2: 3: # Copyright 2000-2002 Katipo Communications 4: # Copyright 2010 BibLibre 5: # Copyright 2011 KohaAloha, NZ Hide function arguments $_[0] 'CGI::Compile=HASH(0x55b3af97fd90)' $_[1] '' $_[2] '/kohadevbox/koha/opac/opac-detail.pl' $_[3] '/kohadevbox/koha/opac' $_[4] 'ARRAY(0x55b3b1e0fc88)' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 12:42:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 10:42:46 +0000 Subject: [Koha-bugs] [Bug 23439] Barcode number with serveral users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23439 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gveranis at dataly.gr --- Comment #2 from George Veranis --- Would be helpful if you have a notice message that also someone else also edit that item ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 13:18:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 11:18:54 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud at orex.es --- Comment #9 from Hugo Agud --- I have installed the patch in a sandbox, I have enabled syspref OpacTrustedCheckout I. have logged to the opac I am not able to see at opac-detail, opac-results or in my account the way to seld check out I have also checked that circ rules are configured I have also checked that the homebranch of books and users are the same -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 13:39:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 11:39:31 +0000 Subject: [Koha-bugs] [Bug 31023] Cannot create new GENRE/FORM authorities when QueryRegexEscapeOptions set to 'Unescape escaped' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31023 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |In Discussion --- Comment #8 from Tomás Cohen Arazi --- Hi, Nick. Do you think you could use Koha::SearchEngine::Zebra::QueryBuilder::clean_search_term on the authtypecode? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 13:45:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 11:45:35 +0000 Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses patron's home library not holds pick up library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |emmi.takkinen at koha-suomi.fi |ity.org | --- Comment #4 from Emmi Takkinen --- Created attachment 140000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140000&action=edit Bug 31447: Use holds pick up branch in "Please confirm checkout" message When one tries to check out item which has hold in it, "Please confirm checkout" message uses patrons home library instead of holds pick up library. It would be more logical to use latter here. To test: 1. Find record with holds. 2. For first priority hold, change it's pick up library to differ from patrons homebranch if needed. 3. Check out records item for a different patron. => Note that notice reads: "Item ... has been on hold for ... at [patrons homebranch] since ...". 4. Apply this patch. 5. Repeat steps 2 and 3. => Notice should now read: "Item ... has been on hold for ... at [holds pick up branch] since ...". Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 13:51:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 11:51:44 +0000 Subject: [Koha-bugs] [Bug 30016] Remove GetOpenIssue subroutine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30016 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 13:51:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 11:51:48 +0000 Subject: [Koha-bugs] [Bug 30016] Remove GetOpenIssue subroutine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30016 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 13:51:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 11:51:51 +0000 Subject: [Koha-bugs] [Bug 30262] opac/tracklinks.pl inconsistent with GetMarcUrls for whitespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30262 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 13:51:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 11:51:54 +0000 Subject: [Koha-bugs] [Bug 30262] opac/tracklinks.pl inconsistent with GetMarcUrls for whitespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30262 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 13:51:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 11:51:57 +0000 Subject: [Koha-bugs] [Bug 30335] Add ability to hide/disable manual invoices and manual credits in patron accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30335 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 13:52:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 11:52:00 +0000 Subject: [Koha-bugs] [Bug 30335] Add ability to hide/disable manual invoices and manual credits in patron accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30335 --- Comment #14 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 13:52:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 11:52:03 +0000 Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 13:52:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 11:52:06 +0000 Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #55 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 13:52:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 11:52:09 +0000 Subject: [Koha-bugs] [Bug 31315] Remove GetItemsInfo from moredetail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31315 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 13:52:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 11:52:12 +0000 Subject: [Koha-bugs] [Bug 31315] Remove GetItemsInfo from moredetail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31315 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 13:52:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 11:52:15 +0000 Subject: [Koha-bugs] [Bug 31489] Typo in EnableExpiredPasswordReset description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31489 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 13:52:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 11:52:18 +0000 Subject: [Koha-bugs] [Bug 31489] Typo in EnableExpiredPasswordReset description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31489 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 13:55:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 11:55:52 +0000 Subject: [Koha-bugs] [Bug 31495] New: Allow opac-page when enforcing GDPR policy Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31495 Bug ID: 31495 Summary: Allow opac-page when enforcing GDPR policy Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Very tiny adjustment in Auth module: When the user gave no consent yet, we could allow him to see opac-page.pl. These are actually CMS pages that could be viewed as standing next to the library catalogue. It also allows you to use opac-page for the privacy policy page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 14:00:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 12:00:39 +0000 Subject: [Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 --- Comment #43 from Frank Hansen --- (In reply to Katrin Fischer from comment #41) > Thx for the great work on the test plan and sample data, this makes it much > easier to test :) > > I am happy to add another sign-off, but for this to go through QA, we will > also need unit tests to cover the changes in the .pm files. Please let us > know if we can help with that! Yes, there are already existing tests in these files: t/db_dependent/Linker_Default.t t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t They need some minor changes so they will PASS tests. This test outputs warnings even if it says OK: t/db_dependent/Linker_FirstMatch.t Use of uninitialized value $thesaurus in concatenation (.) or string at /kohadevbox/koha/C4/Linker/Default.pm line 38. Use of uninitialized value $thesaurus in concatenation (.) or string at /kohadevbox/koha/C4/Linker/Default.pm line 79. Use of uninitialized value $thesaurus in concatenation (.) or string at /kohadevbox/koha/C4/Linker/Default.pm line 80. Use of uninitialized value $thesaurus in concatenation (.) or string at /kohadevbox/koha/C4/Linker/Default.pm line 81. Use of uninitialized value $thesaurus in concatenation (.) or string at /kohadevbox/koha/C4/Linker/Default.pm line 82. t/db_dependent/Linker_FirstMatch.t .. ok All tests successful. These warnings doesn't appear in t/db_dependent/Linker_Default.t I would like to add a few more test to t/db_dependent/Linker_Default.t to cover my changes in unit test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 14:04:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 12:04:18 +0000 Subject: [Koha-bugs] [Bug 31495] Allow opac-page when enforcing GDPR policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31495 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 14:04:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 12:04:22 +0000 Subject: [Koha-bugs] [Bug 31495] Allow opac-page when enforcing GDPR policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31495 --- Comment #1 from Marcel de Rooy --- Created attachment 140001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140001&action=edit Bug 31495: Allow opac-page when enforcing GDPR policy Test plan: Add some page under Additional contents. Enforce GDPR policy. Test with user that has no consent (yet or anymore). Check if you can reach additional contents with opac-page.pl. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 14:04:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 12:04:37 +0000 Subject: [Koha-bugs] [Bug 31495] Allow opac-page when enforcing GDPR policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31495 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 14:05:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 12:05:21 +0000 Subject: [Koha-bugs] [Bug 31496] New: Printslip.pl prints sco-using logged in patron's home branch to the slip instead of the staff member's which gives access to the sco. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31496 Bug ID: 31496 Summary: Printslip.pl prints sco-using logged in patron's home branch to the slip instead of the staff member's which gives access to the sco. Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: lmstrand at gmail.com QA Contact: testopia at bugs.koha-community.org When you print a receipt slip in SCO, the library/branch you are at in should be fetched from the logged in staff member's data (staff login done before entering SCO view) instead of the patron's own who has signed in to the SCO. Printing a slip shows patron's own home branch in the slip as the branch they're in. This causes confusion with patrons who want to print receipts/slips. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 14:05:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 12:05:25 +0000 Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31495 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31495 [Bug 31495] Allow opac-page when enforcing GDPR policy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 14:05:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 12:05:25 +0000 Subject: [Koha-bugs] [Bug 31495] Allow opac-page when enforcing GDPR policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31495 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18081 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 14:10:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 12:10:11 +0000 Subject: [Koha-bugs] [Bug 31496] Printslip.pl prints sco-using logged in patron's home branch to the slip instead of the staff member's which gives access to the sco. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31496 Lari Strand changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 14:10:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 12:10:27 +0000 Subject: [Koha-bugs] [Bug 30036] Add xslt for authority results normal view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130232|0 |1 is obsolete| | --- Comment #4 from Jérémy Breuillard --- Created attachment 140002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140002&action=edit Bug 30036: Add xslt for authority results normal view in OPAC This patch provides a xslt stylesheet on authority results normal view in OPAC. Have a look on opac-authorities-home.pl Test plan: 1)You need the file 'UNIMARCauthResults.xsl' -> get it in the patch from Bug 11083 2)For testing make sure to have at least one or more authorities defined 3)OPAC: Home > Authority search(Submit) > Authority search results 4)Notice the normal view of results 5)Apply patch 6)INTRA: Home > Administration > System preferences ->find "AuthorityXSLTOpacResultsDisplay" 7)Write the path where your file is, ex: '/home/koha/src/UNIMARCauthResults.xsl' 8)Save changes 9)Repeat 3) and 4) and notice the xslt view of results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 14:18:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 12:18:45 +0000 Subject: [Koha-bugs] [Bug 30042] Remove Date::Calc use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #5 from Tomás Cohen Arazi --- I still think this should be moved forward. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 14:51:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 12:51:11 +0000 Subject: [Koha-bugs] [Bug 31496] Printslip.pl prints sco-using logged in patron's home branch to the slip instead of the staff member's which gives access to the sco. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31496 --- Comment #1 from Lari Strand --- Created attachment 140003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140003&action=edit use staff id:s branch for sco printslip To test: Make sure the staff id's branch (used to login into SCO patron view) is not the same as the patron's who is logging into SCO. Print a slip in SCO and notice patron's own branch in the slip. Add patch. Print a slip and notice the branch is now the staff id:s branch used to sign in to SCO patron view. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 15:08:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 13:08:24 +0000 Subject: [Koha-bugs] [Bug 31497] New: When you forget to fill in a field of the patron quick_add_form during a 1st validation test, the field, even if completed, is no longer saved Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 Bug ID: 31497 Summary: When you forget to fill in a field of the patron quick_add_form during a 1st validation test, the field, even if completed, is no longer saved Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: koha at univ-lyon3.fr QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com After filling it in, the 2nd attempt is not blocked, the validation can be done, but it seems that the field is cleared just before submission. Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 15:08:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 13:08:59 +0000 Subject: [Koha-bugs] [Bug 31497] When you forget to fill in a field of the patron quick_add_form during a 1st validation test, the field, even if completed, is no longer saved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr Priority|P5 - low |P3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 15:11:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 13:11:31 +0000 Subject: [Koha-bugs] [Bug 31497] When you forget to fill in a mandatory field of the patron quick_add_form during a 1st validation test, the field, even if completed, is no longer saved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|When you forget to fill in |When you forget to fill in |a field of the patron |a mandatory field of the |quick_add_form during a 1st |patron quick_add_form |validation test, the field, |during a 1st validation |even if completed, is no |test, the field, even if |longer saved |completed, is no longer | |saved -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 15:16:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 13:16:02 +0000 Subject: [Koha-bugs] [Bug 30952] New interface for staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #154 from Paul Poulain --- Hello all, There are around 12 issues that have been risen on https://github.com/jajm/koha-staff-interface-redesign/issues Most are bugs, Julian will take care of them in the next 2 weeks. Regarding the search bar, I'm very reluctant to change things : - it has been discussed in web meetings before the development. Changing things now is a little bit unfair - maintaining the branch is a pain : every patch with something in a template requires a rebase. Thus, the earlier the whole thing is pushed, the better it is. It will also let us time to find any unseen bug. - we can always discuss & adjust the search bar after the main merge At the end, my proposal would be: - Julian Fixes bugs - we merge the patch as soon as possible, with the goal to have it for 22.11. - we open a separate bug for the search bar. Maybe comments from libraries using the proposed version will also help us find the best possible solution. I'm planning to continue BibLibre effort in order to modernize the staff interface. PS in case you missed the information: Solene is no more with us (back to school) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 15:45:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 13:45:33 +0000 Subject: [Koha-bugs] [Bug 31371] Value builder for UNIMARC field 283 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31371 Emmanuel Bétemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 15:45:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 13:45:48 +0000 Subject: [Koha-bugs] [Bug 31372] Value builder for UNIMARC field 325 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31372 Emmanuel Bétemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 15:46:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 13:46:30 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Emmanuel Bétemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 16:16:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 14:16:13 +0000 Subject: [Koha-bugs] [Bug 30952] New interface for staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #155 from Lucas Gass --- (In reply to Paul Poulain from comment #154) > Hello all, > There are around 12 issues that have been risen on > https://github.com/jajm/koha-staff-interface-redesign/issues > Most are bugs, Julian will take care of them in the next 2 weeks. > > Regarding the search bar, I'm very reluctant to change things : > - it has been discussed in web meetings before the development. Changing > things now is a little bit unfair > - maintaining the branch is a pain : every patch with something in a > template requires a rebase. Thus, the earlier the whole thing is pushed, the > better it is. It will also let us time to find any unseen bug. > - we can always discuss & adjust the search bar after the main merge > > At the end, my proposal would be: > - Julian Fixes bugs > - we merge the patch as soon as possible, with the goal to have it for 22.11. > - we open a separate bug for the search bar. Maybe comments from libraries > using the proposed version will also help us find the best possible > solution. I'm planning to continue BibLibre effort in order to modernize the > staff interface. > > PS in case you missed the information: Solene is no more with us (back to > school) It feels to me that it is getting too late in the 22.11 cycle to push this and still have time to work out any unseen bugs. Would it not be more prudent to have this ready for a very early push to 23.05? That way we would have ample time to work out those bugs? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 16:25:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 14:25:18 +0000 Subject: [Koha-bugs] [Bug 17485] Add Marc modification templates to z39.50 import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17485 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 16:29:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 14:29:02 +0000 Subject: [Koha-bugs] [Bug 30952] New interface for staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #156 from Benjamin Daeuber --- (In reply to Lucas Gass from comment #155) > Would it not be more > prudent to have this ready for a very early push to 23.05? That way we would > have ample time to work out those bugs? Agreed. Also, the search bar is arguably the single most important interface piece in all of Koha. It's interacted with hundreds of times a day here so getting it right is an absolute must, in my opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 16:33:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 14:33:12 +0000 Subject: [Koha-bugs] [Bug 20380] Email consent patron opt-in tracking for anti-spam legislation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20380 --- Comment #1 from Marcel de Rooy --- This is still interesting for us. We had a custom opt-in checkbox for library newsletters and service mails on the messaging tab of the opac account page. (And a timestamp for the consent saved in a separate table.) But the field should probably better be moved to Your consents on the account page (independent of enhanced messaging prefs). And could be extended with things described above? Bit more generic. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 16:41:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 14:41:33 +0000 Subject: [Koha-bugs] [Bug 30966] Record Overlay Rules - can't use Z39.50 filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 --- Comment #8 from ByWater Sandboxes --- Created attachment 140004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140004&action=edit Bug 30966: Record Overlay Rules - can't use Z39.50 filter This patch fixes overlay rules on z39.50 import Test plan: 1) Create protection overlay rule to some fields for z39.50. 2) Import a record via z39.50. 3) See that the protected fields are replaced on the editor. 4) Apply the patch. 5) Import a record again. 6) See that the protected fields are in place on the editor. Sponsored-by: Koha-Suomi Oy Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 16:42:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 14:42:35 +0000 Subject: [Koha-bugs] [Bug 30966] Record Overlay Rules - can't use Z39.50 filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 16:47:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 14:47:48 +0000 Subject: [Koha-bugs] [Bug 30952] New interface for staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #157 from Paul Poulain --- It will be the decision of the Release Manager. Maybe I'm optimistic, but I prefer to keep in mind the 22.11 goal, knowing it's optimistic, and not say "well, we've 6 more months", and let the topic fall in a pit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 16:53:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 14:53:00 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #86 from Marcel de Rooy --- Ping Martin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 16:53:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 14:53:14 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #105 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #104) > Marked as blocked by bug 24975 that offers a more elegant way to localize > our DB strings. Too bad that this one is Blocked and the other one is Does not apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 16:56:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 14:56:31 +0000 Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #134 from Tomás Cohen Arazi --- Comment on attachment 138804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138804 Bug 29697: WIP - fix t/db_dependent/Search.t Review of attachment 138804: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=29697&attachment=138804) ----------------------------------------------------------------- ::: t/db_dependent/Search.t @@ +472,5 @@ > + Koha::Database::flush_schema_cache(); > + fixtures_ok [ > + Item => [ > + [qw( itemnumber )], > + [ 1 ], Getting picky but... This is not entirely correct. When you look at data/marc21/zebraexport/large_biblio/exported_records.xml you see there are 4 items defined on that record. The itemnumbers for them are 123, 124, 125 and 126. Two of them are set to be not for loan (i.e. $7 1 in this case). That's why the test is expecting exactly 2 in the notforloancount return value for searchResults. This mock on the resultset 'fixes' the tests only because the ->count is returning 2, so unrelated to the actual itemnumbers. I think we should just do some simpler mocking. Will give it a try. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 17:15:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 15:15:03 +0000 Subject: [Koha-bugs] [Bug 31403] Activate circulation sidebar (CircSidebar system preference) on default in new installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31403 --- Comment #1 from Isobel Graham --- Created attachment 140005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140005&action=edit Bug 31403: Sync Circulation sidebar with Circulation home This patch syncs the content of the circulation sidebar navigation with the content of the circulation homepage Test plan 1. Enable the `CircSidebar` system preference 2. Compare the sidebar navigation on circulation pages with the content of the circulation homepage. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 17:16:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 15:16:23 +0000 Subject: [Koha-bugs] [Bug 31404] Update circulation sidebar to match circulation start page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31404 --- Comment #1 from Isobel Graham --- Created attachment 140006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140006&action=edit Bug 31404: Sync Circulation sidebar with Circulation home This patch syncs the content of the circulation sidebar navigation with the content of the circulation homepage Test plan 1. Enable the `CircSidebar` system preference 2. Compare the sidebar navigation on circulation pages with the content of the circulation homepage. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 17:17:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 15:17:05 +0000 Subject: [Koha-bugs] [Bug 31403] Activate circulation sidebar (CircSidebar system preference) on default in new installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31403 Isobel Graham changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140005|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 17:17:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 15:17:24 +0000 Subject: [Koha-bugs] [Bug 31404] Update circulation sidebar to match circulation start page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31404 Isobel Graham changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 17:35:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 15:35:38 +0000 Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #135 from Tomás Cohen Arazi --- Created attachment 140007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140007&action=edit Bug 29697: (QA follow-up) Make tests less fragile This patch makes the tests less fragile to existing data. It does so by making sure that when checking if the item would be hidden by OpacHiddenItems and lost status, the item is not skipped, and thus the notforloan value, as retrieved from the search engine is picked for the notforloan_count calculation. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 17:35:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 15:35:46 +0000 Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #136 from Tomás Cohen Arazi --- Created attachment 140008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140008&action=edit Bug 29697: (QA follow-up) Remove useless warning Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 17:36:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 15:36:22 +0000 Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138804|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 17:41:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 15:41:02 +0000 Subject: [Koha-bugs] [Bug 31495] Allow opac-page when enforcing GDPR policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31495 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 17:46:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 15:46:29 +0000 Subject: [Koha-bugs] [Bug 31483] Minor UI problem in opac-reset-password.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Joonas Kylmälä --- The patch was made on top of your own changes, thus doesn't apply. Can you resubmit the patch against master branch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 17:48:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 15:48:27 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 --- Comment #106 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #105) > (In reply to Jonathan Druart from comment #104) > > Marked as blocked by bug 24975 that offers a more elegant way to localize > > our DB strings. > > Too bad that this one is Blocked and the other one is Does not apply. Can you help please? Jonathan is absent for a couple months. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 17:53:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 15:53:24 +0000 Subject: [Koha-bugs] [Bug 31482] Label creator does not call item_barcode_transform plugin hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Joonas Kylmälä --- Need to move the barcodedecode call straight into Koha::Items->find(), it's not taking a reference but rather returning the decoded barcode. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 17:54:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 15:54:33 +0000 Subject: [Koha-bugs] [Bug 31482] Label creator does not call item_barcode_transform plugin hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482 --- Comment #7 from Joonas Kylmälä --- Please update the patch description too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 17:58:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 15:58:17 +0000 Subject: [Koha-bugs] [Bug 31498] New: Allow for custom primary contact method values Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31498 Bug ID: 31498 Summary: Allow for custom primary contact method values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The values in the primary_contact_method dropdown on patron creation/edit are hard coded. Some libraries would like to include custom options in that dropdown. Maybe via Authorized Values? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 18:19:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 16:19:18 +0000 Subject: [Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 --- Comment #17 from Jonathan Field --- I think the POC is a good compromise. Difficult are this but we need to do something to address it as it comes up constantly. We're happy to go with this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 18:42:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 16:42:33 +0000 Subject: [Koha-bugs] [Bug 31499] New: Add libhttp-tiny-perl 0.076 dependency for ES7 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31499 Bug ID: 31499 Summary: Add libhttp-tiny-perl 0.076 dependency for ES7 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org CC: mtj at kohaaloha.com this small patch allows ES7 to work on deb10 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 18:44:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 16:44:16 +0000 Subject: [Koha-bugs] [Bug 31499] Add libhttp-tiny-perl 0.076 dependency for ES7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31499 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 18:44:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 16:44:20 +0000 Subject: [Koha-bugs] [Bug 31499] Add libhttp-tiny-perl 0.076 dependency for ES7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31499 --- Comment #1 from Mason James --- Created attachment 140009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140009&action=edit Bug 31499: Add libhttp-tiny-perl 0.076 dependency for ES7 no testing info provided -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 18:44:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 16:44:29 +0000 Subject: [Koha-bugs] [Bug 31500] New: Add ability to specify MaxReservesPickupDelay at the patron category level Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31500 Bug ID: 31500 Summary: Add ability to specify MaxReservesPickupDelay at the patron category level Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Some libraries would like to be able to override MaxReservesPickupDelay on a per category basis. A good use case for this is that some libraries have a special patron category for patrons that are from "out of town" on vacation. In this case, the library may want to specify a shorter pickup period before the item expires than they would for a patron that lives in the area. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 18:47:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 16:47:04 +0000 Subject: [Koha-bugs] [Bug 31499] Add libhttp-tiny-perl 0.076 dependency for ES7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31499 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25439 CC| |tomascohen at gmail.com Assignee|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | Priority|P5 - low |P1 - high Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 18:47:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 16:47:04 +0000 Subject: [Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31499 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31499 [Bug 31499] Add libhttp-tiny-perl 0.076 dependency for ES7 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 18:50:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 16:50:52 +0000 Subject: [Koha-bugs] [Bug 31463] (Bug 31313 follow-up) Show item order status on opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31463 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 18:50:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 16:50:56 +0000 Subject: [Koha-bugs] [Bug 31463] (Bug 31313 follow-up) Show item order status on opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31463 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139996|0 |1 is obsolete| | --- Comment #4 from Joonas Kylmälä --- Created attachment 140010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140010&action=edit Bug 31463: Add order status to opac-detail.pl This adds a check for the preference OPACAcquisitionDetails and fetches the active orders for the item if necessary Additionally, we simply the check for biblio orders to use object methods and remove code that stored order information in the item_info To test: 1 - Enable preference: OPACAcquisitionDetails 2 - Create a basket with items created on order, add an order for a biblio, close the basket 3 - Create a second basket as above, add an order with multiple copies, leave basket open 4 - View biblio on opac 5 - You should see 1 item marked on order, and "1 items on order" below items table 6 - Close second basket 7 - Reload opac view, now 3 on order and in message 8 - Reopen first basket 9 - Reload opac view, now 2 on order and in message JK: Remove unused @itemnumbers_on_order variable Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 19:01:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 17:01:17 +0000 Subject: [Koha-bugs] [Bug 31499] Add libhttp-tiny-perl 0.076 dependency for ES7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31499 --- Comment #2 from Mason James --- this patch should fix the following build errors... https://jenkins.koha-community.org/view/master/job/Koha_Master_D10_ES6/101/ https://jenkins.koha-community.org/view/master/job/Koha_Master_D10_ES7/83/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 19:24:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 17:24:58 +0000 Subject: [Koha-bugs] [Bug 31501] New: After upgrading to 22.05, I am not able to search Patrons. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31501 Bug ID: 31501 Summary: After upgrading to 22.05, I am not able to search Patrons. Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: liny at cusat.ac.in QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 140011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140011&action=edit Patron are not displaying here After upgrading to 22.05, I am not able to search Patrons. It says Processing. But no results or errors are coming. Log file also has no information. if I give a cardnumber in search box its redirecting to that patrons page directly. But if there are more one result, it shows nothing in datatable. Please help -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 19:26:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 17:26:14 +0000 Subject: [Koha-bugs] [Bug 31499] Add libhttp-tiny-perl 0.076 dependency for ES7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31499 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 19:26:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 17:26:18 +0000 Subject: [Koha-bugs] [Bug 31499] Add libhttp-tiny-perl 0.076 dependency for ES7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31499 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140009|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi --- Created attachment 140012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140012&action=edit Bug 31499: Add libhttp-tiny-perl 0.076 dependency for ES7 no testing info provided Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 19:26:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 17:26:40 +0000 Subject: [Koha-bugs] [Bug 31499] Add libhttp-tiny-perl 0.076 dependency for ES7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31499 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 19:27:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 17:27:13 +0000 Subject: [Koha-bugs] [Bug 30042] Remove Date::Calc use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |joonas.kylmala at iki.fi --- Comment #6 from Joonas Kylmälä --- After the patch we add days instead of subtracting them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 19:27:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 17:27:15 +0000 Subject: [Koha-bugs] [Bug 31501] After upgrading to 22.05, I am not able to search Patrons. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31501 Liny Varghese changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liny at cusat.ac.in URL| |/cgi-bin/koha/members/membe | |rs-home.pl?firstletter=M Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 19:27:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 17:27:42 +0000 Subject: [Koha-bugs] [Bug 31499] Add libhttp-tiny-perl 0.076 dependency for ES7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31499 --- Comment #4 from Tomás Cohen Arazi --- Mason, please clarify if this depends on something else, to aid rmaints. Also, please use the rel_*_candidate to let rmaints know they need to backport this. And thanks, great job as usual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 19:37:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 17:37:09 +0000 Subject: [Koha-bugs] [Bug 30231] Don't display (rejected) forms of series entry in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30231 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 19:37:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 17:37:12 +0000 Subject: [Koha-bugs] [Bug 30231] Don't display (rejected) forms of series entry in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30231 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 19:37:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 17:37:15 +0000 Subject: [Koha-bugs] [Bug 31177] Misplaced import in C4::ILSDI::Services In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31177 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 19:37:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 17:37:17 +0000 Subject: [Koha-bugs] [Bug 31177] Misplaced import in C4::ILSDI::Services In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31177 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 19:37:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 17:37:20 +0000 Subject: [Koha-bugs] [Bug 31356] Itiva outbound script doesn't respect calendar when calculating expiration date for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31356 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 19:37:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 17:37:22 +0000 Subject: [Koha-bugs] [Bug 31356] Itiva outbound script doesn't respect calendar when calculating expiration date for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31356 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 19:37:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 17:37:25 +0000 Subject: [Koha-bugs] [Bug 31428] Shorten new button text "Configure this table" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31428 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 19:37:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 17:37:27 +0000 Subject: [Koha-bugs] [Bug 31428] Shorten new button text "Configure this table" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31428 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 19:37:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 17:37:30 +0000 Subject: [Koha-bugs] [Bug 31499] Add libhttp-tiny-perl 0.076 dependency for ES7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31499 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 19:37:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 17:37:32 +0000 Subject: [Koha-bugs] [Bug 31499] Add libhttp-tiny-perl 0.076 dependency for ES7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31499 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 19:41:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 17:41:40 +0000 Subject: [Koha-bugs] [Bug 31500] Add ability to specify MaxReservesPickupDelay at the patron category level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31500 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 19:41:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 17:41:43 +0000 Subject: [Koha-bugs] [Bug 31500] Add ability to specify MaxReservesPickupDelay at the patron category level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31500 --- Comment #1 from Kyle M Hall --- Created attachment 140013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140013&action=edit Bug 31500: Update Scheme file [DO NOT PUSH] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 19:41:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 17:41:53 +0000 Subject: [Koha-bugs] [Bug 31500] Add ability to specify MaxReservesPickupDelay at the patron category level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31500 --- Comment #2 from Kyle M Hall --- Created attachment 140014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140014&action=edit Bug 31500 - Add ability to specify MaxReservesPickupDelay at the patron category level Some libraries would like to be able to override MaxReservesPickupDelay on a per category basis. A good use case for this is that some libraries have a special patron category for patrons that are from "out of town" on vacation. In this case, the library may want to specify a shorter pickup period before the item expires than they would for a patron that lives in the area. Test Plan: 1) Apply this patch, restart all the things! 2) Set MaxReservesPickupDelay to 5 days 3) Choose a patron category, go to the categories editor, near the bottom of the form is the new "Max holds pickup delay" field. Set this field to 10 days 4) Place a hold for an item using a patron of that category 5) Trap the hold so it is waiting 6) Note the expiration date is 10 days from now 7) Repeat steps 4-6 for a patron of a different category 8) Note the expiration date is 5 days out -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 19:45:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 17:45:07 +0000 Subject: [Koha-bugs] [Bug 31500] Add ability to specify MaxReservesPickupDelay at the patron category level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31500 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 19:46:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 17:46:19 +0000 Subject: [Koha-bugs] [Bug 30042] Remove Date::Calc use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 19:46:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 17:46:23 +0000 Subject: [Koha-bugs] [Bug 30042] Remove Date::Calc use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130334|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi --- Created attachment 140015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140015&action=edit Bug 30042: Remove Date::Calc dependency in batch_anonymize.pl This patch makes the script use the Koha::DateUtils tools instead. To test: 1. Run: $ kshell k$ perl misc/cronjobs/batch_anonymise.pl --verbose --days 7 => SUCCESS: You see (the date may vary): Checkouts and holds before 2022-02-15 will be anonymised. 2. Apply this patch 3. Repeat 1 => SUCCESS: Same output 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 19:46:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 17:46:43 +0000 Subject: [Koha-bugs] [Bug 30042] Remove Date::Calc use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 --- Comment #8 from Tomás Cohen Arazi --- (In reply to Joonas Kylmälä from comment #6) > After the patch we add days instead of subtracting them. How did that happen LOL. Fixed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 19:57:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 17:57:57 +0000 Subject: [Koha-bugs] [Bug 30042] Remove Date::Calc use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 19:58:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 17:58:01 +0000 Subject: [Koha-bugs] [Bug 30042] Remove Date::Calc use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140015|0 |1 is obsolete| | --- Comment #9 from Joonas Kylmälä --- Created attachment 140016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140016&action=edit Bug 30042: Remove Date::Calc dependency in batch_anonymize.pl This patch makes the script use the Koha::DateUtils tools instead. To test: 1. Run: $ kshell k$ perl misc/cronjobs/batch_anonymise.pl --verbose --days 7 => SUCCESS: You see (the date may vary): Checkouts and holds before 2022-02-15 will be anonymised. 2. Apply this patch 3. Repeat 1 => SUCCESS: Same output 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 20:20:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 18:20:11 +0000 Subject: [Koha-bugs] [Bug 30359] GetBudgetHierarchy is slow on order receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30359 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi |y.org | CC| |joonas.kylmala at iki.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 20:25:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 18:25:27 +0000 Subject: [Koha-bugs] [Bug 30359] GetBudgetHierarchy is slow on order receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30359 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139765|0 |1 is obsolete| | Attachment #139766|0 |1 is obsolete| | --- Comment #6 from Joonas Kylmälä --- Created attachment 140017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140017&action=edit Bug 30359: GetBudgetHierarchy is slow on order receive page This patch adds skiptotals parameter to GetBudgetHierarchy so calculating totals can be skipped from some pages. Test plan: 1) Open browser's Inspect -> Network 2) Go to receive orders 3) Check the timings for page load 4) Apply the patch 5) Refresh the page 6) Check the timings again 7) prove t/db_dependent/Budgets.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Nick Clemens Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 20:25:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 18:25:31 +0000 Subject: [Koha-bugs] [Bug 30359] GetBudgetHierarchy is slow on order receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30359 --- Comment #7 from Joonas Kylmälä --- Created attachment 140018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140018&action=edit Bug 30359: Unit tests Signed-off-by: Nick Clemens Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 20:26:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 18:26:11 +0000 Subject: [Koha-bugs] [Bug 30359] GetBudgetHierarchy is slow on order receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30359 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 20:26:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 18:26:14 +0000 Subject: [Koha-bugs] [Bug 28290] Record matching rules with no subfields cause ISE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28290 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin Somers --- Still valid ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 20:48:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 18:48:45 +0000 Subject: [Koha-bugs] [Bug 31501] After upgrading to 22.05, I am not able to search Patrons. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31501 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi --- Comment #1 from Joonas Kylmälä --- Just a guess: could this be caused by non-latin characters. Does either the name or Notes field contain non-latin letters, apostrophes or similar? You can open the developer javascript console in the web browser to get more information usually, it might tell us the error that happens. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 21:12:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 19:12:22 +0000 Subject: [Koha-bugs] [Bug 31502] New: Add a customizable list of useful resources for cataloging to the left side of the cataloging module Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31502 Bug ID: 31502 Summary: Add a customizable list of useful resources for cataloging to the left side of the cataloging module Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: cpickford at sdlawlibrary.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl It would be helpful if there could be a customizable list of resources/links for cataloging. Examples would be links to OCLC's bibliographic formats, the Cataloging Calculator, MARC21 Bibliographic Data, etc. In appearance it would be similar to the "useful resources" links in the Create from SQL page in Reports. Ideally it could be carried over from the opening cataloging page to display next to the basic and advanced cataloging editors as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 22:21:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 20:21:43 +0000 Subject: [Koha-bugs] [Bug 31459] Order receive page is slow on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi --- Comment #2 from Joonas Kylmälä --- Need to investigate more tomorrow but it seems like if I select an inactive fund and save then on the invoice it shows the fund that was listed in the text "(Current: - Main fund)". Could be an indexing problem? My inactive fund was the first fund in the list, Main fund the second. Just a guess, will look into this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 23:00:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 21:00:22 +0000 Subject: [Koha-bugs] [Bug 31483] Minor UI problem in opac-reset-password.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 23:00:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 21:00:26 +0000 Subject: [Koha-bugs] [Bug 31483] Minor UI problem in opac-reset-password.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139993|0 |1 is obsolete| | --- Comment #6 from Lucas Gass --- Created attachment 140019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140019&action=edit Bug 31483: Close
      tag properly on password reset page To test: 1) Enable EnableExpiredPasswordReset 2) Find a patron and change their password so you know what it is supposed to be 3) In the database, expire the patron's password, e.g. UPDATE borrowers SET password_expiration_date = '2022-08-22' where borrowernumber = 21; 4) Go to the OPAC, try to log in with the patron's credentials 5) Click Reset your password => Note that the form is in the grey breadcrumbs box, you can compare with any other OPAC page, the grey box should only contain the breadcrumbs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 23:01:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 21:01:55 +0000 Subject: [Koha-bugs] [Bug 31483] Minor UI problem in opac-reset-password.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 --- Comment #7 from Lucas Gass --- Wow, you'd think I'd be able to properly close an HTML tag in less then 3 patches, alas. Thanks, Joonas. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 23:01:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 21:01:55 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 31 23:01:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 21:01:59 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #200 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.