[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #104 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Katrin Fischer from comment #102)
> I am sorry, but I get this error when trying to return an item with a hold
> on it:
> 
> Can't call method "id" on an undefined value at
> /kohadevbox/koha/circ/returns.pl line 351
> 
>   349:     # is there a waiting hold for the item, for which cancellation
>   350:     # has been requested?
>   351:     my $waiting_holds_to_be_cancelled =
>   352:       Koha::Holds->waiting->search( { itemnumber => $item->id } )
>   353:       ->filter_by_has_cancellation_requests;
>   354:     while ( my $hold = $waiting_holds_to_be_cancelled->next ) {

Sorry, I cannot reproduce. I tried with:

- 3 item-level holds, for different patrons, on same item
- 1 biblio-level hold
- Doing a check-in for a not having item-level hold item on the biblio

=> SUCCESS: biblio-level hold trapped, offered to confirm. tried both
confirming and discarding.

The fact it breaks on $item->id is pointing me to something else: it means the
item hasn't been found using the barcode. So... it must be something else on
your branch that wasn't correctly rebased after this one got pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.