[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Manual,
                   |                            |release-notes-needed
            Summary|Exclude itemtypes from      |Define itemtype specific
                   |UpdateNotForLoanStatusOnChe |rules in the
                   |ckin                        |UpdateNotForLoanStatusOnChe
                   |                            |ckin system preference
  Text to go in the|Add boolean flag            |The
      release notes|itemtypes.updatenotforloan, |UpdateNotForLoanStatusOnChe
                   |enabled by default. 
       |ckin system preference is
                   |
                           |now more flexible: you can
                   |When                        |define rules to be applied
                   |this item type flag is      |to specific item types upon
                   |disabled items of that type |check-in.
                   |will not be updated on      |
                   |check-in.                   |Adding the item
                   |                            |type code followed by a
                   |                            |colon, and then in separate
                   |                            |lines below each value pair
                   |                            |rules with leading spaces.
                   |                            |Example:
                   |                            |
                   |                            |BK
                   |                            | -1: 0
                   |                            |
                   |                            |If an
                   |                            |item type is not defined in
                   |                            |UpdateNotForLoanStatusOnChe
                   |                            |ckin then items of that
                   |                            |type will not have their
                   |                            |notforloan status change on
                   |                            |check-in, irrespective of
                   |                            |their current notforloan
                   |                            |value.

--- Comment #67 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
(In reply to Nick Clemens from comment #62)
> (In reply to Alex Buckley from comment #61)
> > Just to note I have a working patchset that can use YAML defined in the
> > UpdateNotForLoanStatusOnCheckin syspref like so:
> > 
> > BK:
> >  -1: 0
> > 
> > CR: 
> >  -2: 0
> > 
> > I am currently working on how to handle existing values in the syspref so
> > they still apply for all itemtypes for upgrading libraries.
> > Any suggestions would be much appreciated on this point.
> 
> Maybe add an _ALL_ option - and then existing rules can be placed under
> that? Similar to UpdateItemLocationOnCheckin - but probably not make _ALL_
> override the other rules as it does on that pref

Thanks for that Nick. Am certainly happy to make that change if you would like. 

You will see in the attached patchset I have just added, that I'm listing the
existing rules under each item type, like so:

BK:
 -1: 0

CR:
 -1: 0

etc.

The reason for this is I had a chat with Chris and we wondered whether having
an _ALL_ option could create user confusion in which rule is overridden in a
situation of conflicting rules, like:

_ALL_:
 -1: 0

BK:
 -1: 2

By explicitly defining every item type and all rules that could apply for it,
as I have in my attached patchset, it clarifies any potential confusion around
rules overriding. It does, however, mean librarians will need to write a rule
under every item type option for it to be applied to all items. 

I'm not sure if this should be 'Need signoff' so will leave it with the current
setting for now. 

Happy to hear your thoughts though? :)
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.