[Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck modules for Koha

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444

--- Comment #20 from David Cook <dcook at prosentient.com.au> ---
(In reply to Alex Buckley from comment #18)
> Ideally, they should be redirected back to the OPAC home page. I see on
> stock 22.05 that if you hit 'Finish' you're redirected to the form for
> entering cardnumber or username/password.

Yeah, out of the box, it redirects back to sco-main.pl, which makes sense for
physical self-checkout kiosks.

It could be interesting to have a "SelfCheckoutRedirect" system preference that
specifies where the user gets redirected to. 

Or even an additional parameter for sco-main.pl like "mode=online" which causes
"Finish" to return to opac-main.pl instead of sco-main.pl. 

> Checking a test site I have this patchset running on if I hit 'Finish' the
> self-checkout page re-loads and I am still logged in - see attached
> screenshot. 

That's what I was expecting as well. 

I suppose in your scenario you wouldn't want the user to be logged out from the
IdP, because they might still have other OPAC work that they want to do. 

> I had a discussion with Chris and we thought it would be a good idea if I
> move some of the patchset logic I have in C4/Auth->checkauth() and
> sco-main.pl into a new subroutine in  C4/Auth_with_shibboleth.pm. What are
> your thoughts on this?

I'd need to double-check C4/Auth->checkauth() and C4/Auth_with_shibboleth.pm,
but I agree about moving much of the code out of sco-main.pl and putting it
into C4/Auth_with_shibboleth.pm for sure. 

--

I'm waiting on some client requirements for SAML SSO in SCO, and when I get
those I should be able to provide more useful feedback/assistance as well.

-- 
You are receiving this mail because:
You are watching all bug changes.