[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Aug 4 04:05:57 CEST 2022


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #434 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Victor Grousset/tuxayo from comment #417)
> Hi :) I tried to rebase because why not, but hit a wall on the changes on
> ModReserveFill which was moved (and changed a lot) to Hold::fill(). I don't
> know where is a right place to put the new code:
> 
>     # if this hold was part of a group, cancel other holds in the group
>     my @holds = Koha::Holds->search({ hold_group_id => $hold->hold_group_id
> });
>     foreach my $h ( @holds ) {
>         $h->cancel unless $h->reserve_id == $hold->reserve_id;
>     }
> 
> 
> Also, maybe these lines are also needed in Hold::cancel()
> Not sure at all.
> 
> I would gladly give another try if someone know what to do about the two
> above points.

Have rebased the patches in case someone can come along and sign them off - but
will now work on putting this code in the right place and squashing some of
these patches. Welcome to test in the meantime.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list