[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #24 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Patch doesn't apply and doesn't even make conflicts, just fails. Why does
applying patches regularly does this?

Applying: Bug 30847: Don't get biblio/item info when placing holds
error: sha1 information is lacking or useless (opac/opac-reserve.pl).
error: could not build fake ancestor
Patch failed at 0001 Bug 30847: Don't get biblio/item info when placing holds

note: dependency bug 27272 is applied


patch -p1 <
/tmp/Bug-30847-Dont-get-biblioitem-info-when-placing-ho-giEvEm.patch 
patching file opac/opac-reserve.pl
Hunk #1 FAILED at 130.
1 out of 5 hunks FAILED -- saving rejects to file opac/opac-reserve.pl.rej

I never did this but it seems theoretically possible to manually apply(copy
paste lines!!!) the failed hunk but it would be quite tedious and unreliable.

Jonathan: if you don't have time to rebase I can do it, just push your local
version to a branch so I can use that and get conflict instead of this terrible
error.

-- 
You are receiving this mail because:
You are watching all bug changes.