[Koha-bugs] [Bug 31299] Duplicate output in search_for_data_inconsistencies.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31299

--- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 138713
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138713&action=edit
Bug 31299: Fix duplicate output in search_for_data_inconsistencies.pl

In search_for_data_inconsistencies.pl when there are several inconsistencies on
same framework, the second output of items contains the first one.

Looks like it is since Bug 21466

Test plan using koha-testing-docker :
1) Create 2 inconsistencies on the same item via SQL :
   update items set itemlost = 9 where itemnumber=900;
   update items set notforloan = 8 where itemnumber=900;
2) Without patch
3) Run ./misc/maintenance/search_for_data_inconsistencies.pl
=> You see duplicate output :
== Wrong values linked to authorised values ==
        * The Framework *BKS* is using the authorised value's category
*NOT_LOAN*, but the following items.notforloan do not have a value defined
({itemnumber => value }):
 {900 => 8}
        * The Framework *BKS* is using the authorised value's category *LOST*,
but the following items.itemlost do not have a value defined ({itemnumber =>
value }):
 {900 => 8} {900 => 9}

4) Apply patch
5) Run ./misc/maintenance/search_for_data_inconsistencies.pl
=> Fixed :D
== Wrong values linked to authorised values ==
        * The Framework *BKS* is using the authorised value's category *LOST*,
but the following items.itemlost do not have a value defined ({itemnumber =>
value }):
 {900 => 9}
        * The Framework *BKS* is using the authorised value's category
*NOT_LOAN*, but the following items.notforloan do not have a value defined
({itemnumber => value }):
 {900 => 8}

-- 
You are receiving this mail because:
You are watching all bug changes.