[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Aug 8 05:22:13 CEST 2022


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #445 from David Cook <dcook at prosentient.com.au> ---
My test plan:
0a) koha-upgrade-schema kohadev
0b) perl misc/devel/update_dbix_class_files.pl --koha-conf
/etc/koha/sites/kohadev/koha-conf.xml #NOTE: this step seemed unnecessary
0c) koha-plack --restart kohadev

__OPAC results__
1. Go to
http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1
2. Checkbox results 1 and 2
3. Click "Place hold" at the top of the search results
4. Checkbox "Treat as hold group (next available item fulfills all holds)"
5. Click "Confirm hold"
6. Go to http://localhost:8080/cgi-bin/koha/opac-user.pl
7. Click "Holds" 
8. Confirm the two holds appear with the text "part of a hold group",
and when you click on that text it shows you both hold group titles
9. Note the "Holds" tab shows 1 hold signifying the 2 holds in the hold group
count as 1 hold total

10. In the staff interface, check in "39999000001310"
11. Click "Confirm hold (Y)"
12. Go to
http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51
13. Note only 1 hold appears, and when you click on "part of a hold group" it
only shows 1 hold title

12. In the OPAC, go to http://localhost:8080/cgi-bin/koha/opac-user.pl
*13. Note the following error:
Template process failed: undef error - Can't call method "rule_value" on an
undefined value at /kohadevbox/koha/Koha/Hold.pm line 464.
 at /kohadevbox/koha/C4/Templates.pm line 127

14. Go to
http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51
15. Cancel the hold

__OPAC detail__
1. Go to http://localhost:8080/cgi-bin/koha/opac-reserve.pl?biblionumber=134
2. Checkbox "Treat as hold group (next available item fulfills all holds)" 
3. Click "Show more options"
4. Click "A specific item"
*5. Note that without
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 you can't
select multiple items,
so it doesn't make much sense to show "Treat as hold group" on this page... 

__Staff interface results__
1. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test
2. Checkbox results 1 and 2
3. Click "Place hold" at the top of the search results
4. Search for patron "koha"
5. Checkibox "Treat as hold group"
6. Choose "Centerville" as "Pickup at"
7. Click "Place holds"
8. Click on "part of a hold group" on the each hold and note the modal with
"Hold group" appears showing the 2 titles
9. Check in "39999000001310"
10. Click "Confirm hold (Y)"
11. Go to
http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51
12. Cancel the hold

__Staff interface detail__
1. Go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=134
2. Search for patron "koha"
3. Checkbox both items
4. Checkbox "Treat as hold group"
5. Click "Place hold"
*6. Note the following error: 
Alert box appears saying "- Please select an item to place a hold"
*7. In theory, one should be able to place holds on multiple items, but I think
in practice https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 is
needed
to make that happen, so it might not make sense to show "Treat as hold group"
on this page
at this time

--

On http://localhost:8080/cgi-bin/koha/opac-main.pl it will say "2 holds
pending", but when you click on that link it will show "Holds (1)" and then
"Holds (2 total)". I think that this is likely to confuse users... while I know
libraries want hold groups to count as 1 hold, I'm not sure that Koha can
really handle that in a coherent way...

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list