[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #188 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Nick Clemens from comment #140)
> patch needs minor rebase
> 
> opac-details:
> Template process failed: undef error - The method Koha::Item->transfertwhen
> is not covered by tests!
> --from item-status-schema-org

Fixed.

> Itemtype icons no longer displaying in staff interface

Fixed.

> That's all I can touch right now. If you do not object to this becoming an
> omnibus and breaking it apart I will work through it in sections. I am happy
> to create the new bugs to help.
> 
> This is fairly large in current state - I have some slight concerns about
> increased db fetches with this change and would like to be bale to focus on
> smaller bits

Which areas exactly? I am pretty sure we going globally to do better with this
move, the query run by GetItemsInfo is big and is certainly the cause of some
slowness.
We could split it up into several bugs, but my feeling is that it will add
extra work (new bug report, more people involved in SO+QA, more time to get it
in, can be released into 22.11 without all the work done, follow-ups can be
harder, same for revert if we need it) for not much benefit.

(In reply to Victor Grousset/tuxayo from comment #165)
> Issue found:
> 
> 1. Apply the patches (with or without bug 30847)
> 2. Go to the OPAC
> 3. Go to any record details page
> 4. it blows up
>    Template process failed: undef error - The method
> Koha::Item->transfertwhen is not covered by tests!

This is what Nick reported.

> Another issue found:
> 1. after from test plan: step 14 - Receive/find an issue with an item, view
> in opac
> 2. go to the staff detail page of the record
> 3. it blows up
>    Template process failed: undef error - The method
> Koha::Serial::Item->publisheddate is not covered by tests!

Fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.