[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

--- Comment #129 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
>From this change in C4::Search::searchResults

-           # OPAC hidden items
+            # OPAC hidden items
             if ($is_opac) {
-                # hidden because lost
-                if ($hidelostitems && $item->{itemlost}) {
+                # hidden based on OpacHiddenItems syspref or because lost
+                my $hi = Koha::Items->search( { itemnumber =>
$item->{itemnumber} } )
+                                    ->filter_by_visible_in_opac({ patron =>
$search_context->{patron} });
+                unless ( $hi->count ) {
                     push @hiddenitems, $item->{itemnumber};
                     $hideatopac_count++;
                     next;
                 }
-                # hidden based on OpacHiddenItems syspref
-                my @hi = C4::Items::GetHiddenItemnumbers({ items=> [ $item ],
borcat => $search_context->{category} });
-                if (scalar @hi) {
-                    push @hiddenitems, @hi;
-                    $hideatopac_count++;
-                    next;
-                }
             }

We are actually dealing with lost items HERE, when we were only dealing with
"OpacHiddenItems" only prior to this change, and lost items where handled
later.
Is that a problem? I don't think so. Should we expect side-effects?

The previous patch fixes the first error. The other one is still failing as we
are expecting notforloan_count to be set.

-- 
You are receiving this mail because:
You are watching all bug changes.