[Koha-bugs] [Bug 30484] Interlibrary loans should have the ability to send notices based on request supplier updates

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

--- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Andrew Isherwood from comment #8)
> Revised test plan:
> 
> This test plan tests the provided functionality by using a mocked update
> supplied by the FreeForm backend. The command line script is run which will
> look for requests that match the supplied criteria, obtain a mocked update
> from them, and process the update. The processor simply prints the message
> supplied in the update to the screen.
> 
> - Ensure you have Interlibrary Loans turned on and have the FreeForm backend
> installed. It is important you are using the "bug_30484_mock_request_update"
> branch of the FreeForm backend as this enables the backend to provide mock
> updates that this functionality uses.
> - Ensure that the patron that will be creating the request has the
> "Interlibrary loan updated" notice enabled for at least "Email"
> - Create a FreeForm ILL request
> - On the "Manage ILL request" page for the newly created request, click the
> "Confirm request" button, thereby setting the request status to "Requested"
> - Run the script, in the "misc" directory, run:
> 
>   perl process_ill_updates.pl --statuses REQ --backend FreeForm
> 
> - TEST: You should see the following:
>   - The message "This is a mock update from the FreeForm backend"
>   - The following run report:
> 
> Run details:
> Request ID: xxx
>   Processing by: FreeForm
>   Number of processors run: 1
>   Processor details:
>     Processor name: Print to STDERR
>     Success messages: PRINTED
>     Error messages:
> 
> - If the above messages were printed, the test plan can be considered
> successful.

1) Typo in updatedatabase: Kind Regards > Kind regards
I've added a follow-up patch fixing this globally.

2) +=head3 append_to_note.
I see it only appears in Illrequest.pm and has a test, but not sure how it
relates to the functionality of this patch set?

3) Worked through the test plan and it works as described. The changes for
messaging preferences appear to be complete, but we should start thinking about
a way to make the list of message options configurable as not all libraries
will offer all notices (totally a separate bug of course).

Now we need another QA for the dependent bug 28909 to unlock!

-- 
You are receiving this mail because:
You are watching all bug changes.