[Koha-bugs] [Bug 31330] Branchcode used for routing preview can be wrong

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31330

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---

> The change is about the library used to generate the hold, should it be the
> one from the holding library (if an item has been created with the serial
> item)? The one from the first published serial item?
> If no items have been created then the library from the subscription is used.

Hm, the hold feature has been broken for so long, that I have never seen it
working :(

Bug 2894 - Routing list holds are broken

So you are probably right about the code not being correct. 

I think it if there is no item, you can't place a hold and the hold should be
an item level hold (it needs to be as serial items represent a specific issue
and are not identical).

If you have created multiple items on receiving the issue (a recent feature
given the age of this code) we might need to pick one, which makes it more
complicate than it was in the past maybe.

I thought this was a display question for the routing slip until now... should
we move the hold stuff elsewhere or does it need to be solved?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.