[Koha-bugs] [Bug 31353] New: Improve display of lost items when placing holds in OPAC

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Aug 12 17:09:45 CEST 2022


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31353

            Bug ID: 31353
           Summary: Improve display of lost items when placing holds in
                    OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Bug 31314 revealed some oddness in our display of lost items. 

It changed from:
        # Management of lost or long overdue items
-        if ( $itemInfo->{itemlost} ) {
-
-            # FIXME localized strings should never be in Perl code
-            $itemLoopIter->{message} =
-                $itemInfo->{itemlost} == 1 ? "(lost)"
-              : $itemInfo->{itemlost} == 2 ? "(long overdue)"
-              : "";
-            $itemInfo->{backgroundcolor} = 'other';
-        }

To: 
+                                                                [% IF (
itemLoo.itemlost == 1 || itemLoo.itemlost == 2 ) %] [%# FIXME Why only for 1 or
2? Shouldn't we test for withdrawn as well? %]
                                                                     <span
class="lost">Unavailable (lost or missing)</span>
                                                                 [% END %]


Indeed we should display the description of the LOST authorised value here for
all authorised values that are > 0.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list