[Koha-bugs] [Bug 31333] Allow the ability to make purchase suggestions to be set by borrower type

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy,
                   |                            |release-notes-needed
             Status|ASSIGNED                    |Needs Signoff

--- Comment #9 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
I've attached a patchset that introduces a new syspref:
'suggestionPatronCategoryException'. 

This syspref, like the existing 'OPACHoldsIfAvailableAtPickupExceptions'
syspref, is a multi-choice dropdown of patron categories. Any categories
selected are not affected when the 'suggestion' syspref is enabled.

---
Note:

1. I deliberately chose to add a new syspref to 'exclude' categories, rather
than alter the existing 'suggestion' syspref to be the multi-choice dropdown of
'allowed' patron categories because I felt the latter could create confusion
for upgrading libraries. 

Specifically, every time they added new patron categories they may wonder why
those patrons could not submit suggestions if the library had not remembered to
manually allow that category to create suggestions.

2. Another conscious decision was to place the logic for checking if a patron
could create a suggestion in Koha/Patron/Category.pm. 

The point of this enhancement is to allow/disallow patrons from placing
suggestions based on their patron category. Therefore, it felt right to have
that logic in Koha/Patron/Category.pm, rather than Koha/Suggestion.pm

Ready for testing.

-- 
You are receiving this mail because:
You are watching all bug changes.