[Koha-bugs] [Bug 31333] Allow the ability to make purchase suggestions to be set by borrower type

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|Exclude some patron         |Exclude patron categories
        released in|categories from submitting  |from submitting OPAC
                   |OPAC purchase suggestions   |purchase suggestions by
                   |by selecting them in the    |selecting them in the new
                   |new                         |suggestionPatronCategoryExc
                   |suggestionPatronCategoryExc |eptions system preference.
                   |eptions system preference.  |

--- Comment #18 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
(In reply to Vinod from comment #17)
> What is relevance of old purchase suggestions, why it can't be replaced with
> new? Or current can be used in different way as discussed above?

Hi Vinod,

Are you referring to why did I add a new system preference
(suggestionPatronCategoryExceptions) rather than converting the existing
'suggestion' system preference to a dropdown of patron categories ALLOWED to
make suggestions?

If that is what you're referring to I did not go that route for 2 reasons:

Reason 1. It would have meant every time libraries added new patron categories
to Koha they would have had to remember to update the system preference
allowing those new patron categories to make suggestions, something easily
forgotten.

Whereas, adding a new system preference (suggestionPatronCategoryExceptions)
defining patron categories NOT allowed to make suggestions means as new patron
categories are added, by default, those patrons will be able to submit
suggestions.

i.e. From a library configuration perspective, I believe it is better for new
patron categories to be allowed to do something by default unless explicitly
denied. 

Reason 2: There are precedents for my approach already in Koha:
- The OPACHoldsIfAvailableAtPickup and OPACHoldsIfAvailableAtPickupExceptions
sysprefs.
- The OpacHiddenItems and OpacHiddenItemsExceptions sysprefs.

---

Also, I avoided adding a boolean flag to patron categories controlling whether
they could submit suggestions, to keep all suggestion configurations managed in
one place: system preferences.

Alex

-- 
You are receiving this mail because:
You are watching all bug changes.