[Koha-bugs] [Bug 30684] koha-* scripts --restart should start even when not running

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30684

--- Comment #25 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
(In reply to Jonathan Druart from comment #24)
> Ok go with your patch first then.
> 
> Two things however:
> 1. koha-sip (at least, but maybe others) is missing \n in the output for
> restart if stopped (see second patch from bug 24991)
> 
> $ koha-sip --verbose --stop kohadev
> Stopping SIP server for kohadev:.
> $ koha-sip --verbose --restart kohadev
> Warning: SIP server not running for kohadev.:Starting SIP server for
> kohadev:.
> 
> 2. in koha-zebra
>          if [ "$verbose" != "no" ]; then
> -            log_daemon_msg "Error: Zebra not running for ${name}"
> -            log_end_msg 1
> +            log_daemon_msg "Zebra not running for ${name}."
> +            start_zebra ${name}
>          else
> +            start_zebra ${name}
>              return 1
>          fi
> 
> returning 1 here is wrong.

Thanks, Jonathan. Working on fixing those two issues up!

-- 
You are receiving this mail because:
You are watching all bug changes.