[Koha-bugs] [Bug 31393] New: shibboleth broken since migration from XML::Simple

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31393

            Bug ID: 31393
           Summary: shibboleth  broken since migration from XML::Simple
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: didier.gautheron at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

Hi,

shibboleth can use content in its koha-conf.xml mapping but content key is
optimized out if it's the only key
before #28278 :

koha-conf
<branchcode content="foo"/>
perl:
'branchcode' => {
    'content' => 'foo'
},

Now 
<branchcode content="foo"/>
perl:
'branchcode' => 'foo',

It's faster but it breaks C4/Auth_with_shibboleth.pm

    while ( my ( $key, $entry ) = each %{$config->{'mapping'}} ) {
        if ( any { /(^psgi\.|^plack\.)/i } keys %ENV ) {
            $borrower{$key} = ( $entry->{'is'} && $ENV{"HTTP_" .
uc($entry->{'is'}) } ) || $entry->{'content'} || '';
        } else {
            $borrower{$key} = ( $entry->{'is'} && $ENV{ $entry->{'is'} } ) ||
$entry->{'content'} || '';
        }
    }

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.