[Koha-bugs] [Bug 31373] Notice template validation is missing INCLUDE_PATH

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Aug 18 16:04:28 CEST 2022


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31373

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #6)
> (In reply to Martin Renvoize from comment #4)
> > (In reply to Jonathan Druart from comment #3)
> > > Why do we process html_helpers?
> > 
> > Ha, this crept in from another bug I was working... I found that including
> > biblio-title.inc requires a pre-process of html_helpers and it felt like a
> > good one to add to the default process rather than requiring people to know
> > they need to have it processed at the top in the template itself.  It should
> > probably be in it's own bug.
> 
> Preferable to include it explicitly when you need it instead of adding black
> magic. And it won't help plugins to be compatible between different versions
> if sometimes it needs to be included, sometimes not.

Fair enough.. it should be very clearly documented somewhere which includes
require that helper then so notice authors aren't surprised by them not
working.

I'd also remove the KohaDates and Remove_MARC_punctuation additions too as they
suffer the same issues.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list