[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #187 from Nick Clemens <nick at bywatersolutions.com> ---
Hi Aleisha,

This looks great, but I found a few issues:

1 - Needs a minor rebase on top of article request rules
2 - The changes to iTiva outbound should be rebased on 31356 - essentially they
aren't needed as we should use the already calculated expiration date
3 - I think the atomic update can simply be dropped - if the rule is not
defined, it won't be used, no need to set it as blank
4 - When saving a more specific rule it is saved as blank, this still makes it
the effective rule
    i.e.
    - Set a default rule with "Holds pickup period" as 25
    - Set syspref  ReservesMaxPickUpDelay to 1
    - Set an branch specific all/all rule leaving "Holds pickup period" blank
    - Place two holds - one for pickup at branch with specific rule, one at
another
    - Sign in as the correct libraries and check in items and confirm holds
    - Branch with specific rule - hold gets 1 day delay
    - Other branch - hold gets 25 day delay

-- 
You are receiving this mail because:
You are watching all bug changes.