[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Sun Aug 21 21:39:19 CEST 2022
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295
Joonas Kylmälä <joonas.kylmala at iki.fi> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--- Comment #84 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Rebased the patches. In addition to the rebase I amended a couple minor fixes
(left a comment on those patches): I noticed you had added output_pref()
function call in some places but I didn't see it as needed as output_pref() is
already called on the Template side via the $KohaDates filter, in fact some of
the patches now were conflicting due to output_pref() calls being removed in
the scripts in origin/master. So I removed the output_pref calls. Then there
was a missing Koha::Items module import which I added.
Signing off.
Note to other testers: currently there is a regression in opac-detail.pl caused
by bug 31313, see comment 16 there. This makes it harder to test the code
change here as you would have to modify the item-status.inc code to fix the
regression in order to be able to see the transfer status this patch touches
on.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list